<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Also, JDK-8139189 fix was pushed after this issue is created.</p>
<p>So, is not a regression of JDK-8139189.</p>
--Semyon<br>
<br>
<div class="moz-cite-prefix">On 11/7/2016 3:17 PM, Semyon Sadetsky
wrote:<br>
</div>
<blockquote
cite="mid:2c157430-43e2-4e1d-269b-0e5ad23434b9@oracle.com"
type="cite">
<meta http-equiv="Context-Type" content="text/html; charset=utf-8">
<p>Hello Dmitry,</p>
<p>Did you run all cases of
java/awt/InputMethods/DiacriticsTest/DiacriticsTest.html after
the fix?</p>
<p>Could you add the current case to DiacriticsTest.html as well?<br>
</p>
<p>--Semyon<br>
</p>
<br>
<div class="moz-cite-prefix">On 11/7/2016 2:41 PM, dmitry markov
wrote:<br>
</div>
<blockquote cite="mid:58206862.1090508@oracle.com" type="cite">
Hello, <br>
<br>
Could you review a fix for jdk9, please? <br>
<br>
bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8158262">https://bugs.openjdk.java.net/browse/JDK-8158262</a><br>
webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edmarkov/8158262/webrev.00/">http://cr.openjdk.java.net/~dmarkov/8158262/webrev.00/</a><br>
<br>
Problem description: <br>
The new mechanism of dead keys detection and processing was
introduced by <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8139189"
title="VK_OEM_102 dead key detected as VK_UNDEFINED"
class="issue-link" data-issue-key="JDK-8139189"><strike>JDK-8139189</strike></a>.
It uses MapVirtualKey() function to detect dead key combination.
Also an output of MapVirtualKey() invocation is used as a value
which is send with Java's KEY_PRESSED/KEY_RELEASED events.
However if the mechanism, (i.e. WindowsKeyToJavaChar() function
inside awtComponent.cpp) is called from the Java layer via JNI
right after a keyboard layout has been changed, MapVirtualKey()
returns a character value related to the previous keyboard
layout. <br>
<br>
Fix: <br>
The function WindowsKeyToJavaChar() has to take into account the
current keyboard layout, (i.e. MapVirtualKey() should be
replaced with MapVirtualKeyEx()). <br>
<br>
Thanks, <br>
Dmitry </blockquote>
<br>
</blockquote>
<br>
</body>
</html>