<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thank you for the clarification. The code change looks good to me.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 10-Nov-2016, at 3:54 pm, Manajit Halder <<a href="mailto:manajit.halder@oracle.com" class="">manajit.halder@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=windows-1252" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Avik,<div class=""><br class=""></div><div class="">This change is done to avoid unnecessary charset lookup. No test cases fails. The fix is related to the issue <a href="https://bugs.openjdk.java.net/browse/JDK-8156099" class="">https://bugs.openjdk.java.net/browse/JDK-8156099</a>.</div><div class=""><div class=""><br class=""></div><div class="">Regards,</div><div class="">Manajit</div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On 10-Nov-2016, at 3:40 pm, Avik Niyogi <<a href="mailto:avik.niyogi@oracle.com" class="">avik.niyogi@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Code change looks good to me.<br class="">But just a query, any test cases that fail before the enhancement or this is purely cosmetic? Does charset lookup affect performance?<br class=""><br class="">With Regards,<br class="">Avik Niyogi<br class=""><blockquote type="cite" class="">On 07-Nov-2016, at 8:53 pm, Sergey Bylokhov <<a href="mailto:Sergey.Bylokhov@oracle.com" class="">Sergey.Bylokhov@oracle.com</a>> wrote:<br class=""><br class="">Looks fine.<br class=""><br class="">On 27.10.16 14:18, Manajit Halder wrote:<br class=""><blockquote type="cite" class="">Hi All,<br class=""><br class="">Kindly review the fix for JDK9.<br class=""><br class="">Bug:<br class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8165680" class="">https://bugs.openjdk.java.net/browse/JDK-8165680</a><br class=""><br class="">Webrev:<br class=""><a href="http://cr.openjdk.java.net/~mhalder/8165680/webrev.00/" class="">http://cr.openjdk.java.net/~mhalder/8165680/webrev.00/</a><br class=""><br class="">Issue:<br class="">[macosx] Enhance handling of UTF-8 characters in CDataTransfer.java<br class=""><br class="">Fix:<br class="">Improved handling of UTF_8 characters by avoiding unnecessary lookup.<br class=""><br class="">Regards,<br class="">Manajit<br class=""></blockquote><br class=""><br class="">-- <br class="">Best regards, Sergey.<br class=""></blockquote><br class=""></div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></div></body></html>