<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"Times New Roman \, serif";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Fix looks fine.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Regards,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Ajit<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span style='color:windowtext'> Prasanta Sadhukhan <br><b>Sent:</b> Friday, January 06, 2017 2:46 PM<br><b>To:</b> Prem Balakrishnan; awt-dev@openjdk.java.net<br><b>Subject:</b> Re: <AWT Dev> Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p>looks ok to me.<o:p></o:p></p><p class=MsoNormal>Regards<br>Prasanta<o:p></o:p></p><div><p class=MsoNormal>On 1/6/2017 2:11 PM, Prem Balakrishnan wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span style='color:windowtext'>Hi Prasanta,</span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><p class=MsoNormal style='text-autospace:none'><span style='color:windowtext'>On Ubuntu 16.04 test is taking 21350ms instead of 20000ms.</span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'>Removed manual timeout and made test rely on jtreg timeout.</span><o:p></o:p></p><p class=MsoNormal><span style='font-size:12.0pt'><a href="http://cr.openjdk.java.net/%7Epkbalakr/8172009/webrev.02/">http://cr.openjdk.java.net/~pkbalakr/8172009/webrev.02/</a></span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'>Regards,</span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'>Prem</span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'> Prasanta Sadhukhan <br><b>Sent:</b> Wednesday, January 04, 2017 4:36 PM<br><b>To:</b> Ajit Ghaisas; Prem Balakrishnan; <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br><b>Subject:</b> Re: Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java</span><o:p></o:p></p></div></div><p class=MsoNormal> <o:p></o:p></p><p>And also, I think this test has nothing to do with "print". It should be moved to java/awt/Paint folder, I guess.<o:p></o:p></p><p class=MsoNormal>Do you have an idea why it is taking more than 20 secs to complete, which api is taking so much time? Is it on all platform, or some specific?<br><br>Regards<br>Prasanta<o:p></o:p></p><div><p class=MsoNormal>On 1/4/2017 4:20 PM, Ajit Ghaisas wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span style='color:#1F497D'>Change looks fine.</span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'>Some correction can be done by replacing wildcard imports by specific imports.</span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'>Regards,</span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'>Ajit</span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span style='color:windowtext'> Prem Balakrishnan <br><b>Sent:</b> Wednesday, January 04, 2017 4:09 PM<br><b>To:</b> Ajit Ghaisas; Prasanta Sadhukhan; <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br><b>Subject:</b> Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java</span><o:p></o:p></p></div></div><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal><span style='font-size:12.0pt'>Hi<b>,</b></span><o:p></o:p></p><p class=MsoNormal><span style='font-size:12.0pt'>Please review fix for JDK 9,</span><o:p></o:p></p><p class=MsoNormal><span style='font-size:12.0pt'> </span><o:p></o:p></p><p class=MsoNormal><b><span style='font-size:12.0pt'>Bug:</span></b><span style='font-size:12.0pt'> <a href="https://bugs.openjdk.java.net/browse/JDK-8172009">https://bugs.openjdk.java.net/browse/JDK-8172009</a> </span><o:p></o:p></p><p class=MsoNormal><b><span style='font-size:12.0pt'>Webrev:</span></b><span style='font-size:12.0pt'> <a href="http://cr.openjdk.java.net/%7Epkbalakr/8172009/webrev.00/">http://cr.openjdk.java.net/~pkbalakr/8172009/webrev.00/</a> </span><o:p></o:p></p><p class=MsoNormal><span style='font-size:12.0pt'> </span><o:p></o:p></p><p class=MsoNormal><span style='font-size:12.0pt'>Test fails because it was taking more than 20 seconds to complete, updated timeout to 30 seconds.</span><o:p></o:p></p><p class=MsoNormal><span style='font-size:12.0pt'> </span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'>Regards,</span><o:p></o:p></p><p class=MsoNormal><span style='color:windowtext'>Prem</span><o:p></o:p></p></blockquote><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman , serif","serif"'> </span><o:p></o:p></p></blockquote><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman","serif"'><o:p> </o:p></span></p></div></body></html>