<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    The fix looks good to me.<br>
    <br>
    Thanks,<br>
    Alexandr.<br>
    <br>
    <div class="moz-cite-prefix">On 12/19/2016 10:29 PM, Sergey Bylokhov
      wrote:<br>
    </div>
    <blockquote
      cite="mid:0CC8F46C-C873-4617-B4E4-F2E9BA3F4360@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <br class="">
      <div>
        <blockquote type="cite" class="">
          <div class="">19 дек. 2016 г., в 22:28, Sergey Bylokhov <<a
              moz-do-not-send="true"
              href="mailto:Sergey.Bylokhov@oracle.com" class="">Sergey.Bylokhov@oracle.com</a>>
            написал(а):</div>
          <br class="Apple-interchange-newline">
          <div class="">
            <meta http-equiv="Content-Type" content="text/html;
              charset=utf-8" class="">
            <div style="word-wrap: break-word; -webkit-nbsp-mode: space;
              -webkit-line-break: after-white-space;" class="">
              <div class="">Hello.</div>
              <div class=""><font class="" face="Menlo"><span
                    style="font-size: 11px; background-color: rgb(255,
                    255, 255);" class="">
                    <div class="">Please review an updated version of
                      the fix.</div>
                    <div class=""> - The comments are updated.</div>
                    <div class="">Two additional public api are
                      deprecated:</div>
                    <div class=""> - KeyEvent.getKeyModifiersText()</div>
                    <div class=""> - AWTEvent(Event event)</div>
                    <div class=""><br class="">
                    </div>
                    <div class="">Note that I have to add
                      @SuppressWarnings("deprecation») in places where
                      the old API is used, because the option which
                      ignores this warning was removed from the
                      makefile. We will need to fix all of them one by
                      one in jdk10, I’ll file a CR for this.</div>
                  </span></font></div>
            </div>
          </div>
        </blockquote>
        <div><br class="">
        </div>
        <div>Ouch the link is:</div>
        <a moz-do-not-send="true"
          href="http://cr.openjdk.java.net/%7Eserb/8143077/webrev.04/"
          class="">http://cr.openjdk.java.net/~serb/8143077/webrev.04/</a></div>
      <div><br class="">
        <blockquote type="cite" class="">
          <div class="">
            <div style="word-wrap: break-word; -webkit-nbsp-mode: space;
              -webkit-line-break: after-white-space;" class="">
              <div class=""><font class="" face="Menlo"><span
                    style="font-size: 11px; background-color: rgb(255,
                    255, 255);" class="">
                    <div class=""><br class="">
                    </div>
                  </span></font>
                <div class="">
                  <div class="">
                    <blockquote type="cite" class="">
                      <div class=""><span style="font-family: Helvetica;
                          font-size: 12px; font-style: normal;
                          font-variant-caps: normal; font-weight:
                          normal; letter-spacing: normal; orphans: auto;
                          text-align: start; text-indent: 0px;
                          text-transform: none; white-space: normal;
                          widows: auto; word-spacing: 0px;
                          -webkit-text-stroke-width: 0px; float: none;
                          display: inline !important;" class="">On
                          10/26/2016 6:43 PM, Sergey Bylokhov wrote:</span><br
                          style="font-family: Helvetica; font-size:
                          12px; font-style: normal; font-variant-caps:
                          normal; font-weight: normal; letter-spacing:
                          normal; orphans: auto; text-align: start;
                          text-indent: 0px; text-transform: none;
                          white-space: normal; widows: auto;
                          word-spacing: 0px; -webkit-text-stroke-width:
                          0px;" class="">
                        <blockquote type="cite" style="font-family:
                          Helvetica; font-size: 12px; font-style:
                          normal; font-variant-caps: normal;
                          font-weight: normal; letter-spacing: normal;
                          orphans: auto; text-align: start; text-indent:
                          0px; text-transform: none; white-space:
                          normal; widows: auto; word-spacing: 0px;
                          -webkit-text-size-adjust: auto;
                          -webkit-text-stroke-width: 0px;" class="">On
                          25.10.16 18:46, Semyon Sadetsky wrote:<br
                            class="">
                          <blockquote type="cite" class="">
                            <blockquote type="cite" class="">I wonder
                              why he should decide that the old code can
                              be "simply<br class="">
                              replaced" by the new one? I suppose that
                              at least he should read the<br class="">
                              specification of the new extended API.
                              There is no notion that this<br class="">
                              api is replaced by the new one, there is a
                              recommendation that the new<br class="">
                              one should be used instead.<br class="">
                            </blockquote>
                            After reading such recommendation it's hard
                            to conclude that one "should<br class="">
                            read the specification of the new extended
                            API". Even "@see" tag<br class="">
                            pointing to the extended API is not provided
                            (I'm not even mentioning<br class="">
                            the warning that the extended API may be
                            nonequivalent replacement is<br class="">
                            absent). I read this recommendation as it
                            is: replace one constant with<br class="">
                            another, no side effects expected.<br
                              class="">
                          </blockquote>
                          <br class="">
                          Good to know that you don't read the
                          specification of the methods before using. So
                          what is your proposal? Should I add a notion
                          that these extendent constants contains
                          different int values, and if the user depends
                          from them in some way then he should not
                          replace the old one to the new one? Or what
                          @see reference should be added from some
                          fields to another?<br class="">
                        </blockquote>
                        <span style="font-family: Helvetica; font-size:
                          12px; font-style: normal; font-variant-caps:
                          normal; font-weight: normal; letter-spacing:
                          normal; orphans: auto; text-align: start;
                          text-indent: 0px; text-transform: none;
                          white-space: normal; widows: auto;
                          word-spacing: 0px; -webkit-text-stroke-width:
                          0px; float: none; display: inline !important;"
                          class="">The proposal is the same to notify
                          user that he/she should not only replace the
                          constant but start to use another API. It's up
                          to you how to formulate this. If I did this in
                          minimalistic way I would write:</span><br
                          style="font-family: Helvetica; font-size:
                          12px; font-style: normal; font-variant-caps:
                          normal; font-weight: normal; letter-spacing:
                          normal; orphans: auto; text-align: start;
                          text-indent: 0px; text-transform: none;
                          white-space: normal; widows: auto;
                          word-spacing: 0px; -webkit-text-stroke-width:
                          0px;" class="">
                        <br style="font-family: Helvetica; font-size:
                          12px; font-style: normal; font-variant-caps:
                          normal; font-weight: normal; letter-spacing:
                          normal; orphans: auto; text-align: start;
                          text-indent: 0px; text-transform: none;
                          white-space: normal; widows: auto;
                          word-spacing: 0px; -webkit-text-stroke-width:
                          0px;" class="">
                        <span style="font-family: Helvetica; font-size:
                          12px; font-style: normal; font-variant-caps:
                          normal; font-weight: normal; letter-spacing:
                          normal; orphans: auto; text-align: start;
                          text-indent: 0px; text-transform: none;
                          white-space: normal; widows: auto;
                          word-spacing: 0px; -webkit-text-stroke-width:
                          0px; float: none; display: inline !important;"
                          class="">@deprecated It is recommended that
                          SHIFT_DOWN_MASK and {@link getModifiersEx()}
                          be used instead.</span><br style="font-family:
                          Helvetica; font-size: 12px; font-style:
                          normal; font-variant-caps: normal;
                          font-weight: normal; letter-spacing: normal;
                          orphans: auto; text-align: start; text-indent:
                          0px; text-transform: none; white-space:
                          normal; widows: auto; word-spacing: 0px;
                          -webkit-text-stroke-width: 0px;" class="">
                        <blockquote type="cite" style="font-family:
                          Helvetica; font-size: 12px; font-style:
                          normal; font-variant-caps: normal;
                          font-weight: normal; letter-spacing: normal;
                          orphans: auto; text-align: start; text-indent:
                          0px; text-transform: none; white-space:
                          normal; widows: auto; word-spacing: 0px;
                          -webkit-text-size-adjust: auto;
                          -webkit-text-stroke-width: 0px;" class=""><br
                            class="">
                          <blockquote type="cite" class="">
                            <blockquote type="cite" class=""><br
                                class="">
                              <blockquote type="cite" class="">
                                <blockquote type="cite" class="">We
                                  already have a notions that these
                                  "extended modifier constant"<br
                                    class="">
                                  should be used in the constructor of
                                  InputEvent and moreover in spec<br
                                    class="">
                                  of getModifiersEx() we have an
                                  additional examples how to use this<br
                                    class="">
                                  constants. This is why we will have a
                                  reference from old constans to<br
                                    class="">
                                  the new, and from getModifiers() to
                                  the getModifiersEx();</blockquote>
                              </blockquote>
                            </blockquote>
                          </blockquote>
                        </blockquote>
                      </div>
                    </blockquote>
                  </div>
                  <br class="">
                </div>
              </div>
            </div>
          </div>
        </blockquote>
      </div>
      <br class="">
    </blockquote>
    <br>
  </body>
</html>