<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Alexander,</p>
<p>On the Windows platform you've only modified the dialog native
peer while on other platforms all window types are modified to use
FX window as a parent. Shouldn't the frame native peer be
modified too on the Windows platform?</p>
<p>--Semyon<br>
</p>
<br>
<div class="moz-cite-prefix">On 09/21/2017 10:56 PM, Alexander
Zvegintsev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:26bddfb0-3dfa-92ac-b476-abe5a6bda1e1@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<p>Hi Phil,</p>
<p>Please review the updated fix with reflection incorporated<br>
<a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eazvegint/jdk/10/8185634/01/"
moz-do-not-send="true">http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/</a><br>
<br>
New issue created <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8187803">JDK-8187803</a>
as JDK counterpart of this issue.<br>
</p>
<pre class="moz-signature" cols="72">Thanks,
Alexander.</pre>
<div class="moz-cite-prefix">On 21/09/2017 22:25, Phil Race wrote:<br>
</div>
<blockquote type="cite"
cite="mid:c10968d7-af0b-d599-6620-dd95e4d7af12@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
Some procedural comments :<br>
Since 90% of this is in AWT code, I'd have thought awt-dev
should be included here.<br>
I've added that list.<br>
<br>
And apart from needing separate bug ids, I don't see why the bug
below is confidential.<br>
<br>
<br>
I agree with what Kevin pointed out off-line that as in the
dialog case, the FX side<br>
of the code can use reflection and simply be a harmless
non-functional no-op<br>
if the SwingAccessor does not provide the new method.<br>
<br>
BTW <br>
<pre><span class="new"> 264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
</span></pre>
<span class="new">should be "dd" not "d".<br>
<br>
-phil.<br>
<br>
</span><span class="new"></span>
<div class="moz-cite-prefix">On 09/21/2017 03:38 AM, Alexander
Zvegintsev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:234563d7-7f68-296a-523c-c005cf4ca9a5@oracle.com">Hello,
<br>
<br>
please review the fix <br>
<br>
<a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eazvegint/jdk/10/8185634/00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/</a>
<br>
<br>
for the issue <br>
<br>
<a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8185634"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8185634</a>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>