<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Ok. I think I was reading things a bit backwards. Looks fine.<br>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 12/11/2017 07:55 AM, Shashidhara
Veerabhadraiah wrote:<br>
</div>
<blockquote type="cite"
cite="mid:5cc270e3-51d7-4b15-81f6-683684fba633@default">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
{font-family:Mangal;
panose-1:0 0 4 0 0 0 0 0 0 0;}
@font-face
{font-family:Tunga;
panose-1:0 0 4 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.removed
{mso-style-name:removed;}
span.new
{mso-style-name:new;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
Phil, Below are my replies below:<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">shashi<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"
moz-do-not-send="true"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Philip Race <br>
<b>Sent:</b> Saturday, December 9, 2017 11:30 PM<br>
<b>To:</b> Sergey Bylokhov
<a class="moz-txt-link-rfc2396E" href="mailto:sergey.bylokhov@oracle.com"><sergey.bylokhov@oracle.com></a><br>
<b>Cc:</b> Shashidhara Veerabhadraiah
<a class="moz-txt-link-rfc2396E" href="mailto:shashidhara.veerabhadraiah@oracle.com"><shashidhara.veerabhadraiah@oracle.com></a>;
<a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: <AWT Dev> [10] JDK-8190515:
java.awt.Desktop.moveToTrash(File) prompts on Windows 7
but not on Mac<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I expect I must be misunderstanding
something.<br>
The bug seems to be saying we should eliminate confirmation
dialogs but the fix reads<br>
like it does the opposite since it removes flag bits which
suppress the dialogs :<o:p></o:p></p>
<pre><span class="removed">- fop.fFlags = FOF_ALLOWUNDO;</span><o:p></o:p></pre>
<pre><span class="new">+ fop.fFlags = FOF_ALLOWUNDO | FOF_NOCONFIRMATION | FOF_NOERRORUI;<o:p></o:p></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">Does not "NOCONFIRMATION" mean "no confirmation dialog" ?<o:p></o:p></span></pre>
<pre><span class="new"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">[Shashi] FOF_NOCONFIRMATION means no confirmation dialog will be popped up.</span></i></b></span><span class="new"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">The bug says "does not happen on windows 10". Maybe there was a windows 7 bug ?<o:p></o:p></span></pre>
<pre><span class="new">So after this fix, what happens on windows 7 and 10 ? What versions was the fix tested on ?<o:p></o:p></span></pre>
<pre><span class="new"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">[Shashi] Before the fix, there is a pop up dialog on windows 7 and NO dialog pops up in the case of windows 10 for the same test.<o:p></o:p></span></i></b></span></pre>
<pre><span class="new"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">After this fix, windows 7 pop up dialog gets suppressed behaving same as windows 10 now. I think probable reason is that the implementation looks different between windows 7 and windows 10 for the file operations(SHFileOperation). With this change effective behavior is normalized across the different windows flavors.</span></i></b></span><span class="new"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></span></pre>
<pre><span class="new"><o:p> </o:p></span></pre>
<pre><span class="new">-phil.<o:p></o:p></span></pre>
<p class="MsoNormal"><br>
<br>
On 12/8/17, 5:40 PM, Sergey Bylokhov wrote: <o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Looks fine. <br>
<br>
On 05/12/2017 23:23, Shashidhara Veerabhadraiah wrote: <br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi All,
Please review a fix for the below bug. <br>
<br>
Bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8190515"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8190515</a>
<br>
<br>
Webrev: <a
href="http://cr.openjdk.java.net/%7Esveerabhadra/8190515/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~sveerabhadra/8190515/webrev.00/</a>
<br>
<br>
Summary: The file delete operation generates pop up dialog
in windows7 and not in other higher than windows 7
versions. To keep it consistent across the different
flavors, any dialog UI is being suppressed. <br>
<br>
Thanks and regards, <br>
<br>
Shashi <o:p></o:p></p>
</blockquote>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>