<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
webrev appears to be against the correct repo :<br>
sh://hg.openjdk.java.net/jdk/client
<br>
<br>
<br>
First can you point to what in the spec. or whatever points to<br>
the correct desired behaviour being what you describe :<br>
>If the frame is focusable then it is
resizable otherwise not.<br>
<br>
And regarding the fix, it isn't obvious how adding RESIZABLE changes
anything here<br>
for the unfocusable case which seems to be the situation that is
under discussion.<br>
<br>
Before: if its unfocusable, then setStyleBits will set the mask to 0
:<br>
<br>
// this is the counter-point to -[CWindow _nativeSetStyleBit:]<br>
private void setStyleBits(final int mask, final boolean value) {<br>
execute(ptr -> nativeSetNSWindowStyleBits(ptr, mask,
value ? mask : 0));<br>
}<br>
<br>
After: .. well exactly the same thing .. you just added a RESIZABLE
bit that will be ignored.<br>
<br>
It may make a difference in the isFocusable case .. but that does
not match what you<br>
say you are doing.<br>
<br>
-phil.<br>
<br>
<div class="moz-cite-prefix">On 02/16/2018 08:17 AM, Kevin Rushforth
wrote:<br>
</div>
<blockquote type="cite" cite="mid:5A870416.1030009@oracle.com">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
> Kindly review the fix for JDK10.<br>
<br>
You mean JDK 11, right?<br>
<br>
-- Kevin<br>
<br>
<br>
Manajit Halder wrote:
<blockquote
cite="mid:D9D0E2F1-34F0-4ACC-B2A4-A8C945D519A8@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div class="">
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">Hi All,</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69); min-height: 14px;"
class=""><br class="">
</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">Kindly
review the fix for JDK10.</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69); min-height: 14px;"
class=""><br class="">
</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">Bug: </div>
</div>
<div style="margin: 0px; line-height: normal;" class=""><font
class="" face="Helvetica Neue" color="#454545"><a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-7158623"
class="">https://bugs.openjdk.java.net/browse/JDK-7158623</a></font></div>
<div style="margin: 0px; line-height: normal;" class=""><font
class="" face="Helvetica Neue" color="#454545"><br class="">
</font></div>
<div class="">Webrev:</div>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Emhalder/7158623/webrev.00/"
class="">http://cr.openjdk.java.net/~mhalder/7158623/webrev.00/</a>
<div class=""><br class="">
</div>
<div class="">
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">Issue:</div>
</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">Unfocusable
frame was resizable.</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class=""><br
class="">
</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">Fix:</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">After the
fix resizability of the frame depends on
focusability of the frame. If the frame is focusable then it
is
resizable otherwise not.</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">The test
code was cleaned to remove old test machinery code.</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class=""><br
class="">
</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">Regards,</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class="">Manajit</div>
<div style="margin: 0px; line-height: normal; font-family:
'Helvetica Neue'; color: rgb(69, 69, 69);" class=""><br
class="">
</div>
</blockquote>
</blockquote>
<br>
</body>
</html>