<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
{font-family:Tunga;
panose-1:0 0 4 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>Thank you Denis and Sergey for the review.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>-Shashi<o:p></o:p></span></p><p class=MsoNormal><a name="_MailEndCompose"><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></a></p><p class=MsoNormal><b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'> Denis Fokin [mailto:denis.fokin@gmail.com] <br><b>Sent:</b> Friday, April 13, 2018 3:58 PM<br><b>To:</b> Shashidhara Veerabhadraiah <shashidhara.veerabhadraiah@oracle.com><br><b>Cc:</b> Sergey Bylokhov <sergey.bylokhov@oracle.com>; Hendrik Schreiber <hs@tagtraum.com>; awt-dev@openjdk.java.net<br><b>Subject:</b> Re: <AWT Dev> [11] JDK-8181910: [macos] Support dark title bars on macOS<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Hi <span style='color:#212121'>Shashi,</span><o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal><span style='color:#212121'>Thank you for the fix, it looks fine.</span><o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal><span style='color:#212121'>Thank you,</span><o:p></o:p></p></div><div><p class=MsoNormal><span style='color:#212121'> Denis.</span><o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><div><p class=MsoNormal>On Thu, Apr 12, 2018 at 7:30 AM Shashidhara Veerabhadraiah <<a href="mailto:shashidhara.veerabhadraiah@oracle.com">shashidhara.veerabhadraiah@oracle.com</a>> wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal>Thank you Sergey for the review.<br><br>Denis, Please let me know if you have any comments on the changes.<br><br>Thanks and regards,<br>Shashi<br><br>-----Original Message-----<br>From: Sergey Bylokhov <br>Sent: Thursday, April 12, 2018 3:36 AM<br>To: Denis Fokin <<a href="mailto:denis.fokin@gmail.com" target="_blank">denis.fokin@gmail.com</a>><br>Cc: Hendrik Schreiber <<a href="mailto:hs@tagtraum.com" target="_blank">hs@tagtraum.com</a>>; Shashidhara Veerabhadraiah <<a href="mailto:shashidhara.veerabhadraiah@oracle.com" target="_blank">shashidhara.veerabhadraiah@oracle.com</a>>; <a href="mailto:awt-dev@openjdk.java.net" target="_blank">awt-dev@openjdk.java.net</a><br>Subject: Re: <AWT Dev> [11] JDK-8181910: [macos] Support dark title bars on macOS<br><br>Thank you, the fix looks fine.<br><br>On 11/04/2018 07:44, Denis Fokin wrote:<br>> Hi Sergey,<br>> <br>> can I just approve any modifications and usage of the patch? I am <br>> absolutely ok with pushing or improving the fix by Shashidhara.<br>> <br>> __<br>> Thank you,<br>> Denis<br>> <br>> On Tue, Apr 3, 2018 at 10:50 PM Sergey Bylokhov <br>> <<a href="mailto:Sergey.Bylokhov@oracle.com" target="_blank">Sergey.Bylokhov@oracle.com</a> <mailto:<a href="mailto:Sergey.Bylokhov@oracle.com" target="_blank">Sergey.Bylokhov@oracle.com</a>>> wrote:<br>> <br>> Yes, this fix can be contributed by someone from the JB.<br>> <br>> On 03/04/2018 06:48, Hendrik Schreiber wrote:<br>> > Hey,<br>> ><br>> > I was wondering how this is going. Are you guys still stuck,<br>> waiting for Denis to help out?<br>> ><br>> > -hendrik<br>> ><br>> ><br>> >> On Mar 30, 2018, at 07:32, <a href="mailto:shashidhara.veerabhadraiah@oracle.com" target="_blank">shashidhara.veerabhadraiah@oracle.com</a><br>> <mailto:<a href="mailto:shashidhara.veerabhadraiah@oracle.com" target="_blank">shashidhara.veerabhadraiah@oracle.com</a>> wrote:<br>> >><br>> >> Sure. I did had a confusion to put for review though but did not<br>> know what to do and felt not to keep waiting. Thanks for the<br>> direction Sergey.<br>> >><br>> >> Thanks and regards,<br>> >> Shashi<br>> >><br>> >><br>> >> On 29/03/18 7:45 PM, Sergey Bylokhov wrote:<br>> >>> Unfortunately we cannot accept the patch which were suggested<br>> in the description of the bug. Initially it was implemented in<br>> JetBrains JRE. We can accept it if someone from the JetBrains will<br>> contribute it.<br>> >>><br>> >>> Maybe Denis who is author of the fix can help?<br>> >>><br>> >>> On 28/03/2018 02:29, Shashidhara Veerabhadraiah wrote:<br>> >>>> Hi All, Please review an enhancement for the below bug:<br>> >>>><br>> >>>> Enhancement: <a href="https://bugs.openjdk.java.net/browse/JDK-8181910" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8181910</a><br>> >>>><br>> >>>> Webrev:<br>> <a href="http://cr.openjdk.java.net/~sveerabhadra/8181910/webrev.00/" target="_blank">http://cr.openjdk.java.net/~sveerabhadra/8181910/webrev.00/</a><br>> >>>><br>> >>>> This utilizes the NSAppearance to set the appearance theme to<br>> dark or light.<br>> >>>><br>> >>>> Thanks and regards,<br>> >>>><br>> >>>> Shashi<br>> >>>><br>> >>><br>> >>><br>> >><br>> ><br>> <br>> <br>> --<br>> Best regards, Sergey.<br>> <br><br><br>--<br>Best regards, Sergey.<o:p></o:p></p></blockquote></div></div></body></html>