<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Segoe UI Emoji";
panose-1:2 11 5 2 4 2 4 2 2 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
span.removed
{mso-style-name:removed;}
span.new
{mso-style-name:new;}
span.EmailStyle25
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle26
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.plusline
{mso-style-name:plusline;}
span.EmailStyle28
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle29
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle30
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle31
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle32
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle33
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle34
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle35
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle36
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle37
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle38
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle39
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:594746852;
mso-list-type:hybrid;
mso-list-template-ids:-345466528 2119962456 67567619 67567621 67567617 67567619 67567621 67567617 67567619 67567621;}
@list l0:level1
{mso-level-start-at:4;
mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;
mso-fareast-font-family:Calibri;
mso-bidi-font-family:"Times New Roman";}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Symbol;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:"Courier New";}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;
font-family:Wingdings;}
@list l1
{mso-list-id:842429095;
mso-list-template-ids:-1484600036;}
@list l1:level1
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:36.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level2
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:72.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level3
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:108.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level4
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:144.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level5
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:180.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level6
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:216.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level7
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:252.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level8
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:288.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l1:level9
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:324.0pt;
mso-level-number-position:left;
text-indent:-18.0pt;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:windowtext">Thank‘s !<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Can I have a second review please ?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Best regards, Matthias<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE"> Phil Race <philip.race@oracle.com>
<br>
<b>Sent:</b> Freitag, 10. August 2018 20:12<br>
<b>To:</b> Baesken, Matthias <matthias.baesken@sap.com><br>
<b>Cc:</b> 'build-dev@openjdk.java.net' <build-dev@openjdk.java.net>; awt-dev@openjdk.java.net<br>
<b>Subject:</b> Re: [RFR]: 8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update - was : RE: RFR 8195615 : libsplashscreen linux ppc64le build error after libpng update<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">+1 from me.<br>
<br>
-phil.<span style="mso-fareast-language:DE"><o:p></o:p></span></p>
<div>
<p class="MsoNormal">On 08/10/2018 08:18 AM, Baesken, Matthias wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Hello , here is a new webrev :</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"><a href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8209115.1/">http://cr.openjdk.java.net/~mbaesken/webrevs/8209115.1/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">I set PNG_POWERPC_VSX_OPT now only on the linux ppc platforms .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Best regards, Matthias</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE"> Baesken, Matthias
<br>
<b>Sent:</b> Donnerstag, 9. August 2018 08:48<br>
<b>To:</b> 'Philip Race' <a href="mailto:philip.race@oracle.com"><philip.race@oracle.com></a><br>
<b>Cc:</b> '<a href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>'
<a href="mailto:build-dev@openjdk.java.net"><build-dev@openjdk.java.net></a>; <a href="mailto:awt-dev@openjdk.java.net">
awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> RE: [RFR]: 8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update - was : RE: RFR 8195615 : libsplashscreen linux ppc64le build error after libpng update</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<pre style="margin-left:36.0pt;text-indent:-18.0pt;mso-list:l0 level1 lfo2"><![if !supportLists]><span style="font-family:Wingdings"><span style="mso-list:Ignore">Ø<span style="font:7.0pt "Times New Roman""> </span></span></span><![endif]><span class="new"><span lang="EN-US">Seems like the ARM one has been harmless for an x64 build</span></span><o:p></o:p></pre>
<ul style="margin-top:0cm" type="disc">
<li class="MsoNormal" style="color:windowtext;mso-list:l0 level1 lfo2"><span class="new"><span lang="EN-US" style="color:black">so we could for now assume the PPC one is too</span></span><o:p></o:p></li></ul>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Hi Phil ,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> I will guard the define for the platform where we want to use it - I think this is better for the future than just setting it on all platforms .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">And btw. it has to be</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">PNG_POWERPC_VSX_OPT not PNG_POWERPC_VSX
</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="font-family:"Segoe UI Emoji",sans-serif">☹</span><span lang="EN-US" style="color:windowtext"> - my mistake .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">For some reason the current setting still builds on our ppc64 (le) test machine in the current codebase , strange !</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Best regards, Matthias</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE"> Philip Race <<a href="mailto:philip.race@oracle.com">philip.race@oracle.com</a>>
<br>
<b>Sent:</b> Donnerstag, 9. August 2018 04:09<br>
<b>To:</b> Baesken, Matthias <<a href="mailto:matthias.baesken@sap.com">matthias.baesken@sap.com</a>><br>
<b>Cc:</b> '<a href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>' <<a href="mailto:build-dev@openjdk.java.net">build-dev@openjdk.java.net</a>>;
<a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: [RFR]: 8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update - was : RE: RFR 8195615 : libsplashscreen linux ppc64le build error after libpng update</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><br>
The only comment I have is about this<o:p></o:p></p>
<pre><span class="removed">- LIBSPLASHSCREEN_CFLAGS += -DSPLASHSCREEN -DPNG_NO_MMX_CODE -DPNG_ARM_NEON_OPT=0</span><o:p></o:p></pre>
<pre><span class="new">+ LIBSPLASHSCREEN_CFLAGS += -DSPLASHSCREEN -DPNG_NO_MMX_CODE -DPNG_ARM_NEON_OPT=0 -DPNG_POWERPC_VSX=0</span><o:p></o:p></pre>
<pre><span class="new"> </span><o:p></o:p></pre>
<pre><span class="new">I suppose these platform defines are harmless and un-referenced unless building for</span><o:p></o:p></pre>
<pre><span class="new">the specified platform. Seems like the ARM one has been harmless for an x64 build</span><o:p></o:p></pre>
<pre><span class="new">so we could for now assume the PPC one is too.</span><o:p></o:p></pre>
<pre><span class="new">Or you could use jdk-submit to prove this :-)</span><o:p></o:p></pre>
<pre><span class="new"> </span><o:p></o:p></pre>
<pre><span class="new">-phil.</span><o:p></o:p></pre>
<p class="MsoNormal"><br>
On 8/8/18, 12:59 AM, Baesken, Matthias wrote: <o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Hello ,</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">please review this small adjustment for the build of libsplashscreen , especially the libpng parts .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Back then, we had to fix the build of the libpng parts in libsplashscreen on linux ppc64le with “8195615 : libsplashscreen linux ppc64le build error after libpng update” .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">However this introduced a small adjustment to pngpriv.h that needs to be kept every time libpng is updated (happened recently when Phil updated the lib).</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">So I better want to remove the adjustment to pngpriv from 8195615 , and instead change the build settings to fix the compilation on linuxppc64 le .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext">Webrev/bug :</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"><a href="http://cr.openjdk.java.net/%7Embaesken/webrevs/8209115.0/">http://cr.openjdk.java.net/~mbaesken/webrevs/8209115.0/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"><a href="https://bugs.openjdk.java.net/browse/JDK-8209115">https://bugs.openjdk.java.net/browse/JDK-8209115</a></span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext">Thanks , </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"> Matthias</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE"> Philip Race
<a href="mailto:philip.race@oracle.com"><philip.race@oracle.com></a> <br>
<b>Sent:</b> Dienstag, 7. August 2018 17:15<br>
<b>To:</b> Baesken, Matthias <a href="mailto:matthias.baesken@sap.com"><matthias.baesken@sap.com></a><br>
<b>Cc:</b> Doerr, Martin <a href="mailto:martin.doerr@sap.com"><martin.doerr@sap.com></a>;
<a href="mailto:2d-dev@openjdk.java.net">2d-dev@openjdk.java.net</a>; Simonis, Volker
<a href="mailto:volker.simonis@sap.com"><volker.simonis@sap.com></a>; Lindenmaier, Goetz
<a href="mailto:goetz.lindenmaier@sap.com"><goetz.lindenmaier@sap.com></a><br>
<b>Subject:</b> Re: libsplashscreen compilation on ppc64 ( le) - was : RE: RFR 8195615 : libsplashscreen linux ppc64le build error after libpng update</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Works for me. Include build-dev on the review.<br>
And splashscreen is considered an AWT feature so it should be awt-dev not 2d-dev<br>
although you may want to reference back to this earlier exchange.<br>
<br>
-phil.<br>
<br>
On 8/7/18, 8:04 AM, Baesken, Matthias wrote: <o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Hello, should I prepare a change setting the -DPNG_POWERPC_VSX=0 flag in the makefile (see below) ?</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Might make future libpng updates more simple .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Best regards, Matthias</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE">From:</span></b><span lang="EN-US" style="color:windowtext;mso-fareast-language:DE"> Baesken, Matthias
<br>
<b>Sent:</b> Donnerstag, 2. August 2018 17:28<br>
<b>To:</b> 'Phil Race' <a href="mailto:philip.race@oracle.com"><philip.race@oracle.com></a>; Doerr, Martin
<a href="mailto:martin.doerr@sap.com"><martin.doerr@sap.com></a><br>
<b>Cc:</b> Simonis, Volker <a href="mailto:volker.simonis@sap.com"><volker.simonis@sap.com></a>; Lindenmaier, Goetz
<a href="mailto:goetz.lindenmaier@sap.com"><goetz.lindenmaier@sap.com></a><br>
<b>Subject:</b> RE: RFR 8195615 : libsplashscreen linux ppc64le build error after libpng update - was : RE: jdk-hs ppc64le build error, probably related to libpng update</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Hi Phil, I added -DPNG_POWERPC_VSX=0 to Awt2dLibraries.gmk for the sphlashscreen library build, and removed (uncommented) the workaround in pngpriv.h .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Build on the head of jdk11 was fine on my linux ppc64le test machine .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Best regards, Matthias</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">Diff:</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">/open_jdk/jdk11> hg diff</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">diff -r 26cca23c165a make/lib/Awt2dLibraries.gmk</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">--- a/make/lib/Awt2dLibraries.gmk Thu Aug 02 09:49:04 2018 +0200</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">+++ b/make/lib/Awt2dLibraries.gmk Thu Aug 02 16:50:09 2018 +0200</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">@@ -794,7 +794,8 @@</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> LIBSPLASHSCREEN_EXCLUDE_SRC_PATTERNS := unix</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> endif</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">- LIBSPLASHSCREEN_CFLAGS += -DSPLASHSCREEN -DPNG_NO_MMX_CODE -DPNG_ARM_NEON_OPT=0</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">+ # disable ppc64 opts</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">+ LIBSPLASHSCREEN_CFLAGS += -DSPLASHSCREEN -DPNG_NO_MMX_CODE -DPNG_ARM_NEON_OPT=0 -DPNG_POWERPC_VSX=0</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> ifeq ($(OPENJDK_TARGET_OS), macosx)</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> LIBSPLASHSCREEN_CFLAGS += -DWITH_MACOSX</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">diff -r 26cca23c165a src/java.desktop/share/native/libsplashscreen/libpng/pngpriv.h</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">--- a/src/java.desktop/share/native/libsplashscreen/libpng/pngpriv.h Thu Aug 02 09:49:04 2018 +0200</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">+++ b/src/java.desktop/share/native/libsplashscreen/libpng/pngpriv.h Thu Aug 02 16:50:09 2018 +0200</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">@@ -290,12 +290,12 @@</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"># endif</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">#endif /* PNG_MIPS_MSA_OPT > 0 */</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">-#ifdef PNG_POWERPC_VSX_API_SUPPORTED</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">+/* #ifdef PNG_POWERPC_VSX_API_SUPPORTED */</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext">#if PNG_POWERPC_VSX_OPT > 0</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"># define PNG_FILTER_OPTIMIZATIONS png_init_filter_functions_vsx</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"># define PNG_POWERPC_VSX_IMPLEMENTATION 1</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext">#endif</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext">-#endif</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext">+/* #endif */</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="color:windowtext"> </span><o:p></o:p></p>
</div>
</blockquote>
</div>
</blockquote>
</div>
</div>
</blockquote>
<p class="MsoNormal"><span style="mso-fareast-language:DE"><o:p> </o:p></span></p>
</div>
</div>
</body>
</html>