<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:"Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"\@Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}
@font-face
{font-family:"Times New Roman \,serif";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:Consolas;
color:black;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Thanks for the comments. Here is the new webrev: </span><a href="http://cr.openjdk.java.net/~kaddepalli/8196681/webrev02/">http://cr.openjdk.java.net/~kaddepalli/8196681/webrev02/</a><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>--Krishna<o:p></o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span style='color:windowtext'> Prasanta Sadhukhan <br><b>Sent:</b> Friday, September 14, 2018 3:23 PM<br><b>To:</b> Krishna Addepalli <krishna.addepalli@oracle.com>; awt-dev@openjdk.java.net<br><b>Subject:</b> Re: <AWT Dev> RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p>ok. The formatting is screwed up, needs to be rectified. Also l194, there should be a space before {<span style='font-size:12.0pt'><o:p></o:p></span></p><p class=MsoNormal>Regards<br>Prasantaa<o:p></o:p></p><div><p class=MsoNormal>On 14-Sep-18 2:45 PM, Krishna Addepalli wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span style='color:#1F497D'>Thanks for the review Prasanta. Although there is not much difference between using fprintf and vfprintf, I have changed all the calls to vfprintf.</span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'>Here is the new webrev: </span><a href="http://cr.openjdk.java.net/%7Ekaddepalli/8196681/webrev01/">http://cr.openjdk.java.net/~kaddepalli/8196681/webrev01/</a><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'>Krishna</span><o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'> </span><o:p></o:p></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span style='color:windowtext'> Prasanta Sadhukhan <br><b>Sent:</b> Friday, September 14, 2018 11:38 AM<br><b>To:</b> Krishna Addepalli <a href="mailto:krishna.addepalli@oracle.com"><krishna.addepalli@oracle.com></a>; <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br><b>Subject:</b> Re: <AWT Dev> RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled</span><o:p></o:p></p></div></div><p class=MsoNormal> <o:p></o:p></p><p>One thing, since you are passing va_list as the last parameter, shouldn't all fprintf be actually vfprintf?<o:p></o:p></p><p class=MsoNormal>Regards<br>Prasanta<o:p></o:p></p><div><p class=MsoNormal>On 14-Sep-18 12:55 AM, Krishna Addepalli wrote:<o:p></o:p></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hi All, <o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Enhancement: <a href="https://bugs.openjdk.java.net/browse/JDK-8196681">https://bugs.openjdk.java.net/browse/JDK-8196681</a><o:p></o:p></p><p class=MsoNormal>Webrev: <a href="http://cr.openjdk.java.net/%7Ekaddepalli/8196681/webrev00/">http://cr.openjdk.java.net/~kaddepalli/8196681/webrev00/</a><o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Please review an enhancement for supporting the logging of Java Access Bridge, so that customers/users facing problems with Accessibility can turn on/off logging to debug problems with this feature.<o:p></o:p></p><p class=MsoNormal>The proposed solution is to have the user/developer define an environment variable “<b>JAVA_ACCESSBRIDGE_LOGFILE</b>” and filling with the path to the log file.<o:p></o:p></p><p class=MsoNormal>The JavaAccessBridge will read the variable, and write to the file in the path provided. <br>Note that the implementation is simplistic, and doesnot have any way to handle multiple applications, since it is a debug only feature.<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Thanks,<o:p></o:p></p><p class=MsoNormal>Krishna<o:p></o:p></p></blockquote><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman ,serif",serif'> </span><o:p></o:p></p></blockquote><p class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New Roman",serif'><o:p> </o:p></span></p></div></body></html>