<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Fix looks good to me.<br>
<br>
Regards,<br>
Manajit<br>
<br>
<div class="moz-cite-prefix">On 18/09/18 4:02 PM, Dmitry Markov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:597ED021-89D1-4DEB-9722-FA6B45B81B2D@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
That’s right. The changes look good to me.
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Dmitry<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 17 Sep 2018, at 17:01, Prasanta Sadhukhan
<<a href="mailto:prasanta.sadhukhan@oracle.com"
class="" moz-do-not-send="true">prasanta.sadhukhan@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8" class="">
<div text="#000000" bgcolor="#FFFFFF" class="">
<p class="">Hi Dmitry,<br class="">
</p>
I guess fullwidth currency symbols are <br class="">
<a
href="https://www.fileformat.info/info/unicode/char/ff04/index.htm"
class="" moz-do-not-send="true">U+FF04</a> FULLWIDTH
DOLLAR SIGN<br class="">
<a
href="https://www.fileformat.info/info/unicode/char/ffe1/index.htm"
class="" moz-do-not-send="true">U+FFE1</a> FULLWIDTH
POUND SIGN<br class="">
<a
href="https://www.fileformat.info/info/unicode/char/ffe5/index.htm"
class="" moz-do-not-send="true">U+FFE5</a> FULLWIDTH
YEN SIGN<br class="">
etc which are already part of this check <br class="">
<pre style="font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(238, 238, 238);" class="">(codePoint >= 0xFF00) && (codePoint <= 0xFFEF)
</pre>
<div class="moz-cite-prefix">right?<br class="">
<br class="">
Regards<br class="">
Prasanta<br class="">
On 17-Sep-18 9:22 PM, Dmitry Markov wrote:<br class="">
</div>
<blockquote type="cite"
cite="mid:19045414-FD4D-4E54-B68A-DB6428E9F435@oracle.com"
class="">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8" class="">
Hi Prasanta,
<div class=""><br class="">
</div>
<div class="">I think it would be wise to generate
InputMethodEvent for ‘Fullwidth currency symbols’,
as well.</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Dmitry <br class="">
<div class=""><br class="">
<blockquote type="cite" class="">
<div class="">On 17 Sep 2018, at 10:02, Prasanta
Sadhukhan <<a
href="mailto:prasanta.sadhukhan@oracle.com"
class="" moz-do-not-send="true">prasanta.sadhukhan@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="content-type"
content="text/html; charset=utf-8" class="">
<div text="#000000" bgcolor="#FFFFFF" class="">
<p class="">Hi All,</p>
Please review a fix for an issue where<br
class="">
when "yen" symbol is entered from a keyboard
using Romaji keyboard layout using
"backslash" character, it was showing a
"backslash" character <br class="">
rather than "yen" symbol.<br class="">
<br class="">
This is a regression of <a
class="issue-link"
data-issue-key="JDK-8068283"
href="https://bugs.openjdk.java.net/browse/JDK-8068283"
id="key-val" rel="4760961"
moz-do-not-send="true">JDK-8068283</a>
where the check to control JNI invocation of
"sun.lwawt.macosx.CInputMethod.insertText(String)" is changed from <br
class="">
"if ([self hasMarkedText] ||
!fProcessingKeystroke || (utf8Length >
1))<br class="">
to <br class="">
if ([self hasMarkedText] ||
!fProcessingKeystroke || (utf16Length >
2))<br class="">
<br class="">
Now, in this case for "yen" symbol, the
utf16Length is 2 so InputMethodEvent is not
generated, rather a KeyEvent is generated
for "\" character.<br class="">
This check was again modified for <a
class="issue-link"
data-issue-key="JDK-8132503"
href="https://bugs.openjdk.java.net/browse/JDK-8132503"
id="key-val" rel="4837840"
moz-do-not-send="true">JDK-8132503</a>
where the check for unichar belongs to
certain unicode block is introduced<br
class="">
<br class="">
<i class="">(utf8Length > 1) &&
[self
isCodePointInUnicodeBlockNeedingIMEvent:[useString
characterAtIndex:0]]</i><br class="">
<br class="">
Now, there although utf8Length is 2 the
check for codepoint is complex or not does
not take into account "unicode" currency
symbols. <br class="">
It only takes into account CJK symbols and
punctuations and "Halfwidth and Fullwidth
Forms' Unicode block.<br class="">
<br class="">
Proposed fix also add "currency" symbol
unicode [[<a class="moz-txt-link-freetext"
href="https://www.fileformat.info/info/unicode/category/Sc/list.htm"
moz-do-not-send="true">https://www.fileformat.info/info/unicode/category/Sc/list.htm</a>]<br
class="">
in the mix so that we can have
InputmethodEvent generated for currency
symbols.<br class="">
<br class="">
Bug: <a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8191178"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8191178</a><br
class="">
webrev: <a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8191178/webrev.0/"
moz-do-not-send="true">http://cr.openjdk.java.net/~psadhukhan/8191178/webrev.0/</a><br
class="">
<br class="">
Regards<br class="">
Prasanta<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br>
</body>
</html>