<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I suspect I understand this one now .. the array is stack allocated
so we don't want NULL<br>
but the compiler probably complained about possible uninitialised
use of the values ?<br>
<br>
-phil.<br>
<br>
On 10/1/18, 9:38 AM, Philip Race wrote:
<blockquote cite="mid:5BB24D6E.5020600@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
You really do need to explain *each* of the changes better.<br>
This one .. why not NULL ?<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html">http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html</a><br>
<br>
-phil<br>
<br>
On 10/1/18, 9:19 AM, Philip Race wrote:
<blockquote cite="mid:5BB2491B.7000501@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi,<br>
<br>
1) Has this been built on all platforms ?<br>
2) I can't find the list of warnings that you are seeing and
fixing and they are all over the place.<br>
So adding 2d-dev and build-dev.<br>
For each of these changes, please show what was the warning that
you received from the compiler<br>
This might sound like a lot of work, but it won't be
disproportionate and I've made the same<br>
request for similar reviews and without it, it is hard to review
the changes.<br>
<br>
For example (and I do mean just example) <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html">http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html</a><br>
<br>
why would that not be #ifdef instead ?<br>
<br>
3) Testing .. did you run at least all our jtreg tests to make
sure you didn't break<br>
some behaviour ..<br>
<br>
-phil.<br>
<br>
On 9/29/18, 8:18 PM, Krishna Addepalli wrote:
<blockquote
cite="mid:57768c04-a994-46f8-8322-fa89058d58c9@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:"Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@Yu Gothic";
panose-1:2 11 4 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi All, <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review a fix for JDK-8074824: <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8074824">https://bugs.openjdk.java.net/browse/JDK-8074824</a><o:p></o:p></p>
<p class="MsoNormal">Webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/">http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Most of the warnings have been fixed
for Linux, Mac and Windows.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Krishna<o:p></o:p></p>
</div>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>