<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Ok but you need to wait for the CSR to be approved before you can
    push.<br>
    <br>
    -phil.<br>
    <br>
    On 3/8/19, 11:41 AM, Shashidhara Veerabhadraiah wrote:
    <blockquote cite="mid:fcce40df-1b75-41ea-9381-f8fd5086d4ee@default"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <meta name="Generator" content="Microsoft Word 15 (filtered
        medium)">
      <style><!--
/* Font Definitions */
@font-face
        {font-family:PMingLiU;
        panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
        {font-family:Tunga;
        panose-1:0 0 4 0 0 0 0 0 0 0;}
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:Consolas;
        panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
        {font-family:"\@PMingLiU";}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0in;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Times New Roman",serif;
        color:black;}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:blue;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:purple;
        text-decoration:underline;}
pre
        {mso-style-priority:99;
        mso-style-link:"HTML Preformatted Char";
        margin:0in;
        margin-bottom:.0001pt;
        font-size:10.0pt;
        font-family:"Courier New";
        color:black;}
span.HTMLPreformattedChar
        {mso-style-name:"HTML Preformatted Char";
        mso-style-priority:99;
        mso-style-link:"HTML Preformatted";
        font-family:Consolas;
        color:black;}
span.changed
        {mso-style-name:changed;}
span.new
        {mso-style-name:new;}
span.EmailStyle21
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
span.EmailStyle22
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
span.EmailStyle23
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
span.EmailStyle24
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
span.EmailStyle25
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
span.EmailStyle26
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
span.EmailStyle27
        {mso-style-type:personal;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
span.EmailStyle28
        {mso-style-type:personal-reply;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-size:10.0pt;}
@page WordSection1
        {size:8.5in 11.0in;
        margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
        {page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
      <div class="WordSection1">
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
            Phil, As discussed here are the updates for the Webrev.
            Hopefully this is correct.<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><a
              moz-do-not-send="true"
              href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.09/">http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.09/</a><o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
            and regards,<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi<o:p></o:p></span></p>
        <p class="MsoNormal"><a moz-do-not-send="true"
            name="_MailEndCompose"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
        <div>
          <div style="border:none;border-top:solid #E1E1E1
            1.0pt;padding:3.0pt 0in 0in 0in">
            <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                Shashidhara Veerabhadraiah <br>
                <b>Sent:</b> Friday, March 8, 2019 10:33 AM<br>
                <b>To:</b> Philip Race <a class="moz-txt-link-rfc2396E" href="mailto:philip.race@oracle.com"><philip.race@oracle.com></a><br>
                <b>Cc:</b> <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; Joe Darcy
                <a class="moz-txt-link-rfc2396E" href="mailto:joe.darcy@oracle.com"><joe.darcy@oracle.com></a>; <a class="moz-txt-link-abbreviated" href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
                <b>Subject:</b> Re: <AWT Dev> <Swing Dev>
                [13] JDK-8216008:
                -Djavax.accessibility.assistive_technologies empty list
                leads to crash<o:p></o:p></span></p>
          </div>
        </div>
        <p class="MsoNormal"><o:p> </o:p></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thank
            you Phil for the review and here are the updates done:<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><a
              moz-do-not-send="true"
              href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.08/">http://cr.openjdk.java.net/~sveerabhadra/8216008//webrev.08/</a><o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
            and regards,<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi<o:p></o:p></span></p>
        <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
        <div>
          <div style="border:none;border-top:solid #E1E1E1
            1.0pt;padding:3.0pt 0in 0in 0in">
            <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                Philip Race <br>
                <b>Sent:</b> Wednesday, March 6, 2019 10:42 PM<br>
                <b>To:</b> Shashidhara Veerabhadraiah <<a
                  moz-do-not-send="true"
                  href="mailto:shashidhara.veerabhadraiah@oracle.com">shashidhara.veerabhadraiah@oracle.com</a>><br>
                <b>Cc:</b> <a moz-do-not-send="true"
                  href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>;
                <a moz-do-not-send="true"
                  href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a>;
                Joe Darcy <<a moz-do-not-send="true"
                  href="mailto:joe.darcy@oracle.com">joe.darcy@oracle.com</a>><br>
                <b>Subject:</b> Re: <AWT Dev> <Swing Dev>
                [13] JDK-8216008:
                -Djavax.accessibility.assistive_technologies empty list
                leads to crash<o:p></o:p></span></p>
          </div>
        </div>
        <p class="MsoNormal"><o:p> </o:p></p>
        <pre><span class="changed">the webrev needs a couple of minor tweaks :<o:p></o:p></span></pre>
        <pre><span class="changed"><o:p> </o:p></span></pre>
        <pre><span class="changed">contains empty string</span> -> is the empty string<o:p></o:p></pre>
        <pre><o:p> </o:p></pre>
        <pre>and<o:p></o:p></pre>
        <pre><o:p> </o:p></pre>
        <pre><span class="new">immeadiately -> immediately</span><o:p></o:p></pre>
        <p class="MsoNormal"><br>
          Go ahead and finalize the CSR which looks OK.<br>
          <br>
          -phil.<br>
          <br>
          On 3/6/19, 11:45 AM, Shashidhara Veerabhadraiah wrote: <o:p></o:p></p>
        <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
              Phil\Sergey, Please review the CSR along with the bug fix.</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Webrev:
            </span><a moz-do-not-send="true"
              href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.07/"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.07/</span></a><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">CSR:
            </span><a moz-do-not-send="true"
              href="https://bugs.openjdk.java.net/browse/JDK-8218737"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">https://bugs.openjdk.java.net/browse/JDK-8218737</span></a><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Bug:
            </span><a moz-do-not-send="true"
              href="https://bugs.openjdk.java.net/browse/JDK-8216008"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">https://bugs.openjdk.java.net/browse/JDK-8216008</span></a><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
              and regards,</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <div>
            <div style="border:none;border-top:solid #E1E1E1
              1.0pt;padding:3.0pt 0in 0in 0in">
              <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                  Shashidhara Veerabhadraiah <br>
                  <b>Sent:</b> Monday, March 4, 2019 3:36 PM<br>
                  <b>To:</b> Philip Race </span><a
                  moz-do-not-send="true"
                  href="mailto:philip.race@oracle.com"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif"><philip.race@oracle.com></span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">;
                  Joe Darcy </span><a moz-do-not-send="true"
                  href="mailto:joe.darcy@oracle.com"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif"><joe.darcy@oracle.com></span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><br>
                  <b>Cc:</b> </span><a moz-do-not-send="true"
                  href="mailto:awt-dev@openjdk.java.net"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">awt-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">;
                </span><a moz-do-not-send="true"
                  href="mailto:swing-dev@openjdk.java.net"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">swing-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><br>
                  <b>Subject:</b> Re: <AWT Dev> <Swing Dev>
                  [13] JDK-8216008:
                  -Djavax.accessibility.assistive_technologies empty
                  list leads to crash</span><o:p></o:p></p>
            </div>
          </div>
          <p class="MsoNormal"> <o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
              Joe, Please find the updated Webrev fixing the typo:</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><a moz-do-not-send="true"
              href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.07/"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.07/</span></a><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
              and regards,</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <div>
            <div style="border:none;border-top:solid #E1E1E1
              1.0pt;padding:3.0pt 0in 0in 0in">
              <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                  Shashidhara Veerabhadraiah <br>
                  <b>Sent:</b> Thursday, February 21, 2019 2:08 PM<br>
                  <b>To:</b> Philip Race <</span><a
                  moz-do-not-send="true"
                  href="mailto:philip.race@oracle.com"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">philip.race@oracle.com</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">>;
                  Joe Darcy <</span><a moz-do-not-send="true"
                  href="mailto:joe.darcy@oracle.com"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">joe.darcy@oracle.com</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">><br>
                  <b>Cc:</b> </span><a moz-do-not-send="true"
                  href="mailto:awt-dev@openjdk.java.net"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">awt-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">;
                </span><a moz-do-not-send="true"
                  href="mailto:swing-dev@openjdk.java.net"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">swing-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><br>
                  <b>Subject:</b> Re: <AWT Dev> <Swing Dev>
                  [13] JDK-8216008:
                  -Djavax.accessibility.assistive_technologies empty
                  list leads to crash</span><o:p></o:p></p>
            </div>
          </div>
          <p class="MsoNormal"> <o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
              Joe, Please find the new Webrev fixing the specification
              as asked in the CSR bug: </span><a moz-do-not-send="true"
              href="https://bugs.openjdk.java.net/browse/JDK-8218737"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">https://bugs.openjdk.java.net/browse/JDK-8218737</span></a><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Webrev:
            </span><a moz-do-not-send="true"
              href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.06/"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.06/</span></a><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
              and regards,</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <div>
            <div style="border:none;border-top:solid #E1E1E1
              1.0pt;padding:3.0pt 0in 0in 0in">
              <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                  Shashidhara Veerabhadraiah <br>
                  <b>Sent:</b> Monday, February 18, 2019 10:19 AM<br>
                  <b>To:</b> Philip Race <</span><a
                  moz-do-not-send="true"
                  href="mailto:philip.race@oracle.com"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">philip.race@oracle.com</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">><br>
                  <b>Cc:</b> </span><a moz-do-not-send="true"
                  href="mailto:awt-dev@openjdk.java.net"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">awt-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">;
                </span><a moz-do-not-send="true"
                  href="mailto:swing-dev@openjdk.java.net"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">swing-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><br>
                  <b>Subject:</b> Re: <AWT Dev> <Swing Dev>
                  [13] JDK-8216008:
                  -Djavax.accessibility.assistive_technologies empty
                  list leads to crash</span><o:p></o:p></p>
            </div>
          </div>
          <p class="MsoNormal"> <o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thank
              you Phil for that help on CSR.</span><o:p></o:p></p>
          <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
          <div>
            <div style="border:none;border-top:solid #E1E1E1
              1.0pt;padding:3.0pt 0in 0in 0in">
              <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                  Phil Race <br>
                  <b>Sent:</b> Friday, February 15, 2019 9:41 PM<br>
                  <b>To:</b> Shashidhara Veerabhadraiah <</span><a
                  moz-do-not-send="true"
                  href="mailto:shashidhara.veerabhadraiah@oracle.com"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">shashidhara.veerabhadraiah@oracle.com</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">><br>
                  <b>Cc:</b> Sergey Bylokhov <</span><a
                  moz-do-not-send="true"
                  href="mailto:sergey.bylokhov@oracle.com"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">sergey.bylokhov@oracle.com</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">>;
                </span><a moz-do-not-send="true"
                  href="mailto:awt-dev@openjdk.java.net"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">awt-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">;
                </span><a moz-do-not-send="true"
                  href="mailto:swing-dev@openjdk.java.net"><span
                    style="font-size:11.0pt;font-family:"Calibri",sans-serif">swing-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><br>
                  <b>Subject:</b> Re: <Swing Dev> [13]
                  JDK-8216008:
                  -Djavax.accessibility.assistive_technologies empty
                  list leads to crash</span><o:p></o:p></p>
            </div>
          </div>
          <p class="MsoNormal"> <o:p></o:p></p>
          <p class="MsoNormal" style="margin-bottom:12.0pt">That text
            may actually be worse.<br>
            Although I maybe didn't get your distinction of null vs the
            empty string here ?<br>
            <br>
            Oh, wait. Why is this doc clarification on the PRIVATE
            implementation method ?<br>
            It needs to go on the public getDefaultToolkit() method to
            have any point whatsoever<br>
            especially from a CSR perspective.<br>
            Try this :<br>
            -     * toolkit is created. All errors are handled via an
            AWTError exception.<br>
            +     * toolkit is created.<br>
            +     * If the list of assistive technology providers is the
            empty string, or<br>
            +     * contains only white space characters then the method
            returns immediately.<br>
            +     * All other errors are handled via an AWTError
            exception.<br>
            <br>
            <br>
            I think the CSR needs some work too. I've made some updates
            there.<br>
            <br>
            -phil.<o:p></o:p></p>
          <div>
            <p class="MsoNormal">On 2/15/19 2:10 AM, Shashidhara
              Veerabhadraiah wrote:<o:p></o:p></p>
          </div>
          <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
                Phil, I have updated the CSR and updated the information
                for the function and here is the new Webrev:</span><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
            <p class="MsoNormal"><a moz-do-not-send="true"
                href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.05/"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.05/</span></a><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
                and regards,</span><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi</span><o:p></o:p></p>
            <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
            <div>
              <div style="border:none;border-top:solid #E1E1E1
                1.0pt;padding:3.0pt 0in 0in 0in">
                <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                    Phil Race <br>
                    <b>Sent:</b> Friday, February 15, 2019 2:58 AM<br>
                    <b>To:</b> Shashidhara Veerabhadraiah </span><a
                    moz-do-not-send="true"
                    href="mailto:shashidhara.veerabhadraiah@oracle.com"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif"><shashidhara.veerabhadraiah@oracle.com></span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><br>
                    <b>Cc:</b> Sergey Bylokhov </span><a
                    moz-do-not-send="true"
                    href="mailto:sergey.bylokhov@oracle.com"><span
                      style="font-size:11.0pt;font-family:"Calibri",sans-serif"><sergey.bylokhov@oracle.com></span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">;
                  </span><a moz-do-not-send="true"
                    href="mailto:awt-dev@openjdk.java.net"><span
                      style="font-size:11.0pt;font-family:"Calibri",sans-serif">awt-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">;
                  </span><a moz-do-not-send="true"
                    href="mailto:swing-dev@openjdk.java.net"><span
                      style="font-size:11.0pt;font-family:"Calibri",sans-serif">swing-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><br>
                    <b>Subject:</b> Re: <Swing Dev> [13]
                    JDK-8216008:
                    -Djavax.accessibility.assistive_technologies empty
                    list leads to crash</span><o:p></o:p></p>
              </div>
            </div>
            <p class="MsoNormal"> <o:p></o:p></p>
            <pre><span class="new">+     * activate method.  If the list of assistive technology providers is empty string,</span><o:p></o:p></pre>
            <pre><span class="new"> </span><o:p></o:p></pre>
            <pre><span class="new">is "the" empty string.</span><o:p></o:p></pre>
            <pre><span class="new"> </span><o:p></o:p></pre>
            <pre><span class="new"> </span><o:p></o:p></pre>
            <pre><span class="new">The CSR needs to be updated to include this spec. </span><o:p></o:p></pre>
            <pre><span class="new">What is there now in the specification section needs to be fixed</span><o:p></o:p></pre>
            <pre><span class="new">It should not point to the webrev or review and right now</span><o:p></o:p></pre>
            <pre><span class="new">doesn't contain the change to the javadoc in the body of the CSR</span><o:p></o:p></pre>
            <pre><span class="new"> </span><o:p></o:p></pre>
            <pre><span class="new">I think I even have to question most of the rest of it.</span><o:p></o:p></pre>
            <pre><span class="new">Any one reading it would think that we always used to throw an exception in such</span><o:p></o:p></pre>
            <pre><span class="new">case and now want to stop doing so. Isn't the bug that we did NOT throw an exception</span><o:p></o:p></pre>
            <pre><span class="new">and now we do ? You only hint at that when you say at the end of "Solution", "as was the case earlier"</span><o:p></o:p></pre>
            <pre><span class="new"> </span><o:p></o:p></pre>
            <pre><span class="new">If I am right the only thing you need in the CSR is to say that you</span><o:p></o:p></pre>
            <pre><span class="new">are reverting the implementation to previous behaviour and updating the</span><o:p></o:p></pre>
            <pre><span class="new">specification to make it clear that this behaviour is allowed by the spec</span><o:p></o:p></pre>
            <pre><span class="new">since this case was unclear.</span><o:p></o:p></pre>
            <pre><span class="new"> </span><o:p></o:p></pre>
            <pre><span class="new">-phil.</span><o:p></o:p></pre>
            <p class="MsoNormal" style="margin-bottom:12.0pt"> <o:p></o:p></p>
            <div>
              <p class="MsoNormal">On 2/12/19 1:08 AM, Shashidhara
                Veerabhadraiah wrote:<o:p></o:p></p>
            </div>
            <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
              <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
                  Phil, Here is the new Webrev and CSR for the same:</span><o:p></o:p></p>
              <p class="MsoNormal"><a moz-do-not-send="true"
                  href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.04/"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.04/</span></a><o:p></o:p></p>
              <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
              <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">CSR:
                </span><a moz-do-not-send="true"
                  href="https://bugs.openjdk.java.net/browse/JDK-8218737"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">https://bugs.openjdk.java.net/browse/JDK-8218737</span></a><o:p></o:p></p>
              <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
              <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
                  and regards,</span><o:p></o:p></p>
              <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Shashi</span><o:p></o:p></p>
              <p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> </span><o:p></o:p></p>
              <div>
                <div style="border:none;border-top:solid #E1E1E1
                  1.0pt;padding:3.0pt 0in 0in 0in">
                  <p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
                      Philip Race <br>
                      <b>Sent:</b> Saturday, February 9, 2019 2:18 AM<br>
                      <b>To:</b> Shashidhara Veerabhadraiah </span><a
                      moz-do-not-send="true"
                      href="mailto:shashidhara.veerabhadraiah@oracle.com"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif"><shashidhara.veerabhadraiah@oracle.com></span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><br>
                      <b>Cc:</b> Sergey Bylokhov </span><a
                      moz-do-not-send="true"
                      href="mailto:sergey.bylokhov@oracle.com"><span
                        style="font-size:11.0pt;font-family:"Calibri",sans-serif"><sergey.bylokhov@oracle.com></span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">;
                    </span><a moz-do-not-send="true"
                      href="mailto:awt-dev@openjdk.java.net"><span
                        style="font-size:11.0pt;font-family:"Calibri",sans-serif">awt-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">;
                    </span><a moz-do-not-send="true"
                      href="mailto:swing-dev@openjdk.java.net"><span
                        style="font-size:11.0pt;font-family:"Calibri",sans-serif">swing-dev@openjdk.java.net</span></a><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"><br>
                      <b>Subject:</b> Re: <Swing Dev> [13]
                      JDK-8216008:
                      -Djavax.accessibility.assistive_technologies empty
                      list leads to crash</span><o:p></o:p></p>
                </div>
              </div>
              <p class="MsoNormal"> <o:p></o:p></p>
              <p class="MsoNormal">FWIW I think this could be closed out
                as "not a bug".<br>
                An empty value string is an error and the spec. says
                AWTError is<br>
                how errors are reported. In fact I'll argue that 8 was
                wrong not<br>
                to have thrown an exception in such a case.<br>
                It was an accident of the implementation that it did
                not.<br>
                But if we want to be behaviourally compatible then ... <br>
                Note that since you now document this you need an
                approved CSR BEFORE pushing it.<br>
                <br>
                And if you go the CSR route you may need to be more
                precise about what<br>
                you mean by "empty".<br>
                <br>
                I think it needs to say<br>
                <br>
                "If the list of assistive technology providers is null,
                or contains only white<br>
                space characters then the method returns immediately.<br>
                All other errors are handled by throwing {@code
                AWTError}"<br>
                <br>
                @throws AWTError if there is any error in parsing or
                loading the ATs.<br>
                <br>
                -phil.<br>
                <br>
                On 1/21/19, 9:12 AM, Shashidhara Veerabhadraiah wrote: <o:p></o:p></p>
              <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
                <pre>Hi Sergey, Here is the new Webrev for your comments:<o:p></o:p></pre>
                <pre> <o:p></o:p></pre>
                <pre><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.02/">http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.02/</a><o:p></o:p></pre>
                <pre> <o:p></o:p></pre>
                <pre>Thanks and regards,<o:p></o:p></pre>
                <pre>Shashi<o:p></o:p></pre>
                <pre> <o:p></o:p></pre>
                <pre>-----Original Message-----<o:p></o:p></pre>
                <pre>From: Sergey Bylokhov <o:p></o:p></pre>
                <pre>Sent: Saturday, January 19, 2019 3:47 AM<o:p></o:p></pre>
                <pre>To: Shashidhara Veerabhadraiah <a moz-do-not-send="true" href="mailto:shashidhara.veerabhadraiah@oracle.com"><shashidhara.veerabhadraiah@oracle.com></a>; <a moz-do-not-send="true" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; <a moz-do-not-send="true" href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><o:p></o:p></pre>
                <pre>Subject: Re: <Swing Dev> [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash<o:p></o:p></pre>
                <pre> <o:p></o:p></pre>
                <pre>On 16/01/2019 23:03, <a moz-do-not-send="true" href="mailto:shashidhara.veerabhadraiah@oracle.com">shashidhara.veerabhadraiah@oracle.com</a> wrote:<o:p></o:p></pre>
                <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
                  <pre>Another point is that the whitespace trimming should not trigger additional input processing  for the custom class that will be used for assistive technology. For eg., if custom class "FooProvider" is implemented and if we pass "  FooProvider  " by mistake, a bug may be created to trim the whitespace in this case as well!!<o:p></o:p></pre>
                </blockquote>
                <pre> <o:p></o:p></pre>
                <pre>Yes, my previous email suggested to always trim the content of the "input", it will cover all cases, the "atNames" is empty, the "atNames" contains only the whitespace, or the name of the class has some spaces at the start/end.<o:p></o:p></pre>
                <pre> <o:p></o:p></pre>
                <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
                  <pre> <o:p></o:p></pre>
                  <pre>Thanks and regards,<o:p></o:p></pre>
                  <pre> <o:p></o:p></pre>
                  <pre>Shashi<o:p></o:p></pre>
                  <pre> <o:p></o:p></pre>
                  <pre> <o:p></o:p></pre>
                  <pre>On 17/01/19 10:28 AM, Shashidhara Veerabhadraiah wrote:<o:p></o:p></pre>
                  <blockquote
                    style="margin-top:5.0pt;margin-bottom:5.0pt">
                    <pre>We need one way to tell the system not to load any assistive technologies and which is being provided.<o:p></o:p></pre>
                    <pre>If we add trailing white spaces removal then we may need to add another functionality to see if that class exists or not and based on that not to load anything(without throwing the error because we are parsing the input content). I think that would take a different direction. I feel it is fair enough to provide one way to tell not to load any assistive technologies and additional parsing would only lead to other ways/expectations.<o:p></o:p></pre>
                    <pre> <o:p></o:p></pre>
                    <pre>Thanks and regards,<o:p></o:p></pre>
                    <pre>Shashi<o:p></o:p></pre>
                    <pre> <o:p></o:p></pre>
                    <pre>-----Original Message-----<o:p></o:p></pre>
                    <pre>From: Sergey Bylokhov<o:p></o:p></pre>
                    <pre>Sent: Thursday, January 17, 2019 1:33 AM<o:p></o:p></pre>
                    <pre>To: Shashidhara Veerabhadraiah <a moz-do-not-send="true" href="mailto:shashidhara.veerabhadraiah@oracle.com"><shashidhara.veerabhadraiah@oracle.com></a>; <a moz-do-not-send="true" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; <a moz-do-not-send="true" href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><o:p></o:p></pre>
                    <pre>Subject: Re: <Swing Dev> [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash<o:p></o:p></pre>
                    <pre> <o:p></o:p></pre>
                    <pre>I guess you meant whitespaces, then it is unclear why we should not consider "empty" parameter as a "mistake"?<o:p></o:p></pre>
                    <pre> <o:p></o:p></pre>
                    <pre>On 15/01/2019 20:37, Shashidhara Veerabhadraiah wrote:<o:p></o:p></pre>
                    <blockquote
                      style="margin-top:5.0pt;margin-bottom:5.0pt">
                      <pre>Hi Sergey, I felt that a string with an empty space is intentional and should be considering it as a 'mistake' if done by the developers. Hence I feel it is not required(as there is a way to tell nothing to load). Please let me know if you think otherwise.<o:p></o:p></pre>
                    </blockquote>
                    <pre> <o:p></o:p></pre>
                    <pre> <o:p></o:p></pre>
                    <blockquote
                      style="margin-top:5.0pt;margin-bottom:5.0pt">
                      <pre>Thanks and regards,<o:p></o:p></pre>
                      <pre>Shashi<o:p></o:p></pre>
                      <pre> <o:p></o:p></pre>
                      <pre>-----Original Message-----<o:p></o:p></pre>
                      <pre>From: Sergey Bylokhov<o:p></o:p></pre>
                      <pre>Sent: Tuesday, January 15, 2019 7:32 AM<o:p></o:p></pre>
                      <pre>To: Shashidhara Veerabhadraiah <a moz-do-not-send="true" href="mailto:shashidhara.veerabhadraiah@oracle.com"><shashidhara.veerabhadraiah@oracle.com></a>; <a moz-do-not-send="true" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; <a moz-do-not-send="true" href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><o:p></o:p></pre>
                      <pre>Subject: Re: <Swing Dev> [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash<o:p></o:p></pre>
                      <pre> <o:p></o:p></pre>
                      <pre>Hi, Shashi.<o:p></o:p></pre>
                      <pre> <o:p></o:p></pre>
                      <pre>Should we trim all whitespaces from the "atNames"?<o:p></o:p></pre>
                      <pre>Otherwise the "atNames", which contains only one whitespace, will trigger the same error.<o:p></o:p></pre>
                      <pre> <o:p></o:p></pre>
                      <pre>On 09/01/2019 00:20, Shashidhara Veerabhadraiah wrote:<o:p></o:p></pre>
                      <blockquote
                        style="margin-top:5.0pt;margin-bottom:5.0pt">
                        <pre>Hi Sergey, Thanks for pointing that out. Here is the new Webrev:<o:p></o:p></pre>
                        <pre> <o:p></o:p></pre>
                        <pre><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.01/">http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.01/</a><o:p></o:p></pre>
                        <pre> <o:p></o:p></pre>
                        <pre>Thanks and regards,<o:p></o:p></pre>
                        <pre>Shashi<o:p></o:p></pre>
                        <pre> <o:p></o:p></pre>
                        <pre>-----Original Message-----<o:p></o:p></pre>
                        <pre>From: Sergey Bylokhov<o:p></o:p></pre>
                        <pre>Sent: Friday, January 4, 2019 3:48 AM<o:p></o:p></pre>
                        <pre>To: Shashidhara Veerabhadraiah <a moz-do-not-send="true" href="mailto:shashidhara.veerabhadraiah@oracle.com"><shashidhara.veerabhadraiah@oracle.com></a>; <a moz-do-not-send="true" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; <a moz-do-not-send="true" href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><o:p></o:p></pre>
                        <pre>Subject: Re: <Swing Dev> [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash<o:p></o:p></pre>
                        <pre> <o:p></o:p></pre>
                        <pre>Hi, Shashi.<o:p></o:p></pre>
                        <pre>I think you can update an existing test:<o:p></o:p></pre>
                        <pre>open/test/jdk/javax/accessibility/AccessibilityProvider/basic.sh<o:p></o:p></pre>
                        <pre> <o:p></o:p></pre>
                        <pre>On 03/01/2019 01:36, Shashidhara Veerabhadraiah wrote:<o:p></o:p></pre>
                        <blockquote
                          style="margin-top:5.0pt;margin-bottom:5.0pt">
                          <pre>Hi All, Please review a fix for the below bug.<o:p></o:p></pre>
                          <pre> <o:p></o:p></pre>
                          <pre>Bug: <a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8216008">https://bugs.openjdk.java.net/browse/JDK-8216008</a><o:p></o:p></pre>
                          <pre> <o:p></o:p></pre>
                          <pre>Webrev: <a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Esveerabhadra/8216008/webrev.00/">http://cr.openjdk.java.net/~sveerabhadra/8216008/webrev.00/</a><o:p></o:p></pre>
                          <pre> <o:p></o:p></pre>
                          <pre>Since the mentioned list of assistive technologies for the system property(javax.accessibility.assistive_technologies) is loaded by jvm am unable to write a test case for this bug. The test file attached with the bug can be used for testing this fix.<o:p></o:p></pre>
                          <pre> <o:p></o:p></pre>
                          <pre>This fix removes the error(class not found error) by passing an empty list to system variable javax.accessibility.assistive_technologies and does not load any assistive technologies(as the list is empty). Currently empty list produce a crash which is not required as there was no class name mentioned in the list. Please read the bug comments for more information.<o:p></o:p></pre>
                          <pre> <o:p></o:p></pre>
                          <pre>Thanks and regards,<o:p></o:p></pre>
                          <pre> <o:p></o:p></pre>
                          <pre>Shashi<o:p></o:p></pre>
                          <pre> <o:p></o:p></pre>
                        </blockquote>
                        <pre> <o:p></o:p></pre>
                      </blockquote>
                      <pre> <o:p></o:p></pre>
                    </blockquote>
                    <pre> <o:p></o:p></pre>
                  </blockquote>
                  <pre> <o:p></o:p></pre>
                </blockquote>
                <pre> <o:p></o:p></pre>
                <pre> <o:p></o:p></pre>
              </blockquote>
            </blockquote>
            <p class="MsoNormal"> <o:p></o:p></p>
          </blockquote>
          <p class="MsoNormal"> <o:p></o:p></p>
        </blockquote>
      </div>
    </blockquote>
  </body>
</html>