<div dir="ltr">Sorry, not awt/2d group, but to me it looks fine too. Only nit: the error printout at 495 I would put right after the associated dlsym at 456. You want to make sure dlerror() is not stale at the point where you call it, since it would return NULL.<div><br></div><div>Cheers, Thomas<br><div> </div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 18, 2019 at 3:17 PM Volker Simonis <<a href="mailto:volker.simonis@gmail.com">volker.simonis@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Ping...<br>
<br>
Can I please also get a review from the awt/2d group?<br>
<br>
Thanks,<br>
Volker<br>
<br>
On Wed, Mar 13, 2019 at 11:09 AM Volker Simonis<br>
<<a href="mailto:volker.simonis@gmail.com" target="_blank">volker.simonis@gmail.com</a>> wrote:<br>
><br>
> Hi,<br>
><br>
> can I please have a review for the following change which fixes<br>
> Xinerama and Xrender support on AIX:<br>
><br>
> <a href="http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528/</a><br>
> <a href="https://bugs.openjdk.java.net/browse/JDK-8220528" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8220528</a><br>
><br>
> The change basically fixes the way how the corresponding libraries<br>
> (libXext and libXrender) get loaded on AIX and does some cleanups with<br>
> regards to the various platform macros. I've also added some debug<br>
> tracing to the Xrender initialization code similar to the Xinerama<br>
> initialization.<br>
><br>
> Thank you and best regards,<br>
> Volker<br>
</blockquote></div>