<div><div><div dir="auto"><br></div></div><div><br><div class="gmail_quote"></div></div></div><div><div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon 25. Mar 2019 at 19:42, Volker Simonis <<a href="mailto:volker.simonis@gmail.com" target="_blank">volker.simonis@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Thomas, Christoph,<br>
<br>
thanks for looking into my fix. I hope I've addressed all your<br>
concerns with my new webrev:<br>
<br>
<a href="http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528.v4" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528.v4</a><br>
<br>
By the way, I've tested the new implementation by simulating a<br>
multi-screen environment on my Linux box with Xephyr:<br>
<br>
$ Xephyr +xinerama -screen 1024x768 -screen 1024x768+1024+0 -ac -listen tcp :1<br>
<br>
And started a Swing application from AIX where I've redirected the<br>
DISPLAY to myhost:1:<br>
<br>
$ DISPLAY=myhost:1 ./images/jdk/bin/java -showversion<br>
-Dsun.awt.nativedebug=true -Dawtdebug.trace=true -Dawtdebug.on=true<br>
-Dawtdebug.ctrace=true -cp ~/Java HelloSwing<br>
<br>
The various debug properties will lead to the following output:<br>
<br>
openjdk version "13-internal" 2019-09-17<br>
OpenJDK Runtime Environment (slowdebug build 13-internal+0-adhoc.xxx.jdk-jdk)<br>
OpenJDK 64-Bit Server VM (slowdebug build<br>
13-internal+0-adhoc.xxx.jdk-jdk, mixed mode)<br>
Xinerama extension is available<br>
calling XineramaQueryScreens func<br>
Enabling Xinerama support<br>
num screens = 2<br>
allocating 2 screens<br>
<br>
The Swing frame will appear on one of the Xinerama screens and can be<br>
move with the mouse between the two available screens.<br>
<br>
If I hear no further objections, I plan to push this by the end of the week.<br>
</blockquote><div dir="auto"><br></div></div></div></div><div><div class="gmail_quote"><div dir="auto">All good now. Thank you.</div><div dir="auto"><br></div><div dir="auto">Strange that this error was not detected before, what with the masses of people running swing apps on AIX.</div><div dir="auto"><br></div><div dir="auto">Cheers, thomas</div></div></div><div><div><div class="gmail_quote"><div dir="auto"><br></div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Thank you and best regards,<br>
Volker<br>
<br>
<br>
<br>
On Mon, Mar 18, 2019 at 8:59 PM Thomas Stüfe <<a href="mailto:thomas.stuefe@gmail.com" target="_blank">thomas.stuefe@gmail.com</a>> wrote:<br>
><br>
> Sorry, not awt/2d group, but to me it looks fine too. Only nit: the error printout at 495 I would put right after the associated dlsym at 456. You want to make sure dlerror() is not stale at the point where you call it, since it would return NULL.<br>
><br>
> Cheers, Thomas<br>
><br>
><br>
><br>
> On Mon, Mar 18, 2019 at 3:17 PM Volker Simonis <<a href="mailto:volker.simonis@gmail.com" target="_blank">volker.simonis@gmail.com</a>> wrote:<br>
>><br>
>> Ping...<br>
>><br>
>> Can I please also get a review from the awt/2d group?<br>
>><br>
>> Thanks,<br>
>> Volker<br>
>><br>
>> On Wed, Mar 13, 2019 at 11:09 AM Volker Simonis<br>
>> <<a href="mailto:volker.simonis@gmail.com" target="_blank">volker.simonis@gmail.com</a>> wrote:<br>
>> ><br>
>> > Hi,<br>
>> ><br>
>> > can I please have a review for the following change which fixes<br>
>> > Xinerama and Xrender support on AIX:<br>
>> ><br>
>> > <a href="http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528/</a><br>
>> > <a href="https://bugs.openjdk.java.net/browse/JDK-8220528" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8220528</a><br>
>> ><br>
>> > The change basically fixes the way how the corresponding libraries<br>
>> > (libXext and libXrender) get loaded on AIX and does some cleanups with<br>
>> > regards to the various platform macros. I've also added some debug<br>
>> > tracing to the Xrender initialization code similar to the Xinerama<br>
>> > initialization.<br>
>> ><br>
>> > Thank you and best regards,<br>
>> > Volker<br>
</blockquote></div></div>
</div>