<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">please help me reviewing the backport of “JDK-8211122: Reduce the number of internal classes made accessible to jdk.unsupported”. The main reason for backporting this item is that it’ll ease further backports which base
on that changeset. The patch is quite extensive and hence doesn’t fully apply. I had to resolve some rejects and also modify a few other places. Lots of the rejects were about copyright years (especially in the hotspot tests) which could be dropped. Find below
the link for a full webrev and an incremental one which only contains my manual changes. I’m currently running it through SAP’s test system to check for regressions.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Though this change is large and thorough review is tedious, I think the main issue is that we need 2 additional fixes to pull in before taking 8211122:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">JDK-8205537: Drop of sun.applet package<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">JDK-8211121: Remove sun.reflect.ReflectionFactory::newInstanceForSerialization<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">As the names already suggest, both changes remove methods/classes. I’m not 100% sure whether these removals should be done in a JDK11 update releases. I rather think they could because the one is about Java applets which
aren’t supported with (Open-)JDK 11 anyway and the other removed method claims to only have been added in 9.0.0.4 to be used by the meanwhile removed CORBA modules (removed with JDK11). But I’d really like to have some opinions about these.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Here are the links:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Original bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8211122">
https://bugs.openjdk.java.net/browse/JDK-8211122</a><span style="color:black"><o:p></o:p></span></span></p>
<p class="MsoNormal"><span lang="EN-US">Original review discussion: <a href="https://mail.openjdk.java.net/pipermail/core-libs-dev/2018-November/056397.html">
https://mail.openjdk.java.net/pipermail/core-libs-dev/2018-November/056397.html</a><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Original changeset: <a href="http://hg.openjdk.java.net/jdk/jdk/rev/3c6aa484536c">
http://hg.openjdk.java.net/jdk/jdk/rev/3c6aa484536c</a> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Full webrev: <a href="http://cr.openjdk.java.net/~clanger/webrevs/8211122.11u.full/">
http://cr.openjdk.java.net/~clanger/webrevs/8211122.11u.full/</a> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Incremental Webrev of manual changes: <a href="http://cr.openjdk.java.net/~clanger/webrevs/8211122.11u.manual/">
http://cr.openjdk.java.net/~clanger/webrevs/8211122.11u.manual/</a> <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Dependencies:<o:p></o:p></span></p>
<p class="MsoNormal">JDK-8205537 Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8205537">
https://bugs.openjdk.java.net/browse/JDK-8205537</a><o:p></o:p></p>
<p class="MsoNormal">JDK-8205537 Changeset: <a href="http://hg.openjdk.java.net/jdk/jdk/rev/26a17d160081">
http://hg.openjdk.java.net/jdk/jdk/rev/26a17d160081</a> <o:p></o:p></p>
<p class="MsoNormal">JDK-8211121 Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8211121">
https://bugs.openjdk.java.net/browse/JDK-8211121</a> <o:p></o:p></p>
<p class="MsoNormal">JDK-8211121 Changeset: <a href="http://hg.openjdk.java.net/jdk/jdk/rev/f6e15aa9c16e">
http://hg.openjdk.java.net/jdk/jdk/rev/f6e15aa9c16e</a> <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks<o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Christoph<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</body>
</html>