<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html;
      charset=windows-1252">
  </head>
  <body>
    <p>Thanks, that looks much better to me.</p>
    <p>/Erik<br>
    </p>
    <div class="moz-cite-prefix">On 2020-04-16 10:02, Igor Ignatyev
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:BEE466DA-9428-4FE5-9D5A-972E94ED6314@oracle.com">
      <meta http-equiv="Content-Type" content="text/html;
        charset=windows-1252">
      Hi Erik,
      <div class=""><br class="">
      </div>
      <div class="">sure, I've actually replaced one long statement w/
        multiple shorter ones, which made the comment section redundant
        -- <a
          href="http://cr.openjdk.java.net/~iignatyev//8240904/webrev.01"
          class="" moz-do-not-send="true">http://cr.openjdk.java.net/~iignatyev//8240904/webrev.01</a></div>
      <div class=""><br class="">
      </div>
      <div class="">Thanks,</div>
      <div class="">-- Igor</div>
      <div class="">
        <div><br class="">
          <blockquote type="cite" class="">
            <div class="">On Apr 16, 2020, at 6:17 AM, Erik Joelsson
              <<a href="mailto:erik.joelsson@oracle.com" class=""
                moz-do-not-send="true">erik.joelsson@oracle.com</a>>
              wrote:</div>
            <br class="Apple-interchange-newline">
            <div class="">
              <div class="">Looks ok to me. Would it be possible to
                break up the long lines a bit to improve readability?
                Backslash escape for newlines should work in properties
                files.<br class="">
                <br class="">
                /Erik<br class="">
                <br class="">
                On 2020-04-15 22:22, Igor Ignatyev wrote:<br class="">
                <blockquote type="cite" class=""><a
                    href="http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00"
                    class="" moz-do-not-send="true">http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00</a><br
                    class="">
                  <blockquote type="cite" class="">35 lines changed: 26
                    ins; 0 del; 10 mod<br class="">
                  </blockquote>
                  <br class="">
                  Hi all,<br class="">
                  <br class="">
                  8233827[1] which added screenshots to so-called
                  failure handler had an unexpected side-effect on
                  linux, where users might observer flashes each time a
                  screenshot is taken, which, to put it mildly, is
                  annoying. the patch replaces gnome-screenshot app w/
                  calling java.awt API to make a screenshot. the patch
                  also uses the same solution to make screenshots on
                  windows and solaris (which previously didn't save
                  screenshots on failures). we still use native app on
                  mac as using java.awt API requires accessibility
                  permissions, which might be as annoying as flashes on
                  linux.<br class="">
                  <br class="">
                  [1] <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8233827">https://bugs.openjdk.java.net/browse/JDK-8233827</a><br
                    class="">
                  <br class="">
                  JBS: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8240904">https://bugs.openjdk.java.net/browse/JDK-8240904</a><br
                    class="">
                  webrev:
                  <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00">http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00</a><br
                    class="">
                  testing: verified that screenshots are successfully
                  generated on headful systems, and headless systems
                  ignore errors ('java.awt.AWTException: headless
                  environment' from j.a.Robot::<init>).<br
                    class="">
                  <br class="">
                  Thanks,<br class="">
                  -- Igor<br class="">
                  <br class="">
                  <br class="">
                </blockquote>
              </div>
            </div>
          </blockquote>
        </div>
        <br class="">
      </div>
    </blockquote>
  </body>
</html>