From anton.litvinov at oracle.com  Wed May 21 15:29:24 2014
From: anton.litvinov at oracle.com (Anton Litvinov)
Date: Wed, 21 May 2014 19:29:24 +0400
Subject: <Beans Dev> [7u] Review request for 7172865: PropertyDescriptor
 fails to work with setter method name if setter is non-void
Message-ID: <537CC654.2010406@oracle.com>

Hello Sergey and Alexander,

Could you please review this backport of the fix, which you created and 
reviewed for JDK 8, from JDK 8 to JDK 7. The backport fix is identical 
to the original fix.

Bug: https://bugs.openjdk.java.net/browse/JDK-7172865
Webrev: http://cr.openjdk.java.net/~alitvinov/7172865/jdk7/webrev.00
JDK 8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2ad01ecbaf90

Thank you,
Anton

From sergey.malenkov at oracle.com  Thu May 22 10:13:10 2014
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Thu, 22 May 2014 14:13:10 +0400
Subject: <Beans Dev> Approved: [7u] Review request for 7172865:
 PropertyDescriptor fails to work with setter method name if setter is
 non-void
In-Reply-To: <537CC654.2010406@oracle.com>
References: <537CC654.2010406@oracle.com>
Message-ID: <537DCDB6.4070602@oracle.com>

Hi Anton,

The backport is similar to the original fix.
I approve.

Thanks,
SAM

On 21.05.2014 19:29, Anton Litvinov wrote:
> Hello Sergey and Alexander,
>
> Could you please review this backport of the fix, which you created 
> and reviewed for JDK 8, from JDK 8 to JDK 7. The backport fix is 
> identical to the original fix.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-7172865
> Webrev: http://cr.openjdk.java.net/~alitvinov/7172865/jdk7/webrev.00
> JDK 8 changeset: 
> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2ad01ecbaf90
>
> Thank you,
> Anton


From alexandr.scherbatiy at oracle.com  Thu May 22 10:23:21 2014
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Thu, 22 May 2014 14:23:21 +0400
Subject: <Beans Dev> [7u] Review request for 7172865: PropertyDescriptor
 fails to work with setter method name if setter is non-void
In-Reply-To: <537CC654.2010406@oracle.com>
References: <537CC654.2010406@oracle.com>
Message-ID: <537DD019.7070403@oracle.com>


   The backport looks good for me.

   Thanks,
   Alexandr.

On 5/21/2014 7:29 PM, Anton Litvinov wrote:
> Hello Sergey and Alexander,
>
> Could you please review this backport of the fix, which you created 
> and reviewed for JDK 8, from JDK 8 to JDK 7. The backport fix is 
> identical to the original fix.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-7172865
> Webrev: http://cr.openjdk.java.net/~alitvinov/7172865/jdk7/webrev.00
> JDK 8 changeset: 
> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2ad01ecbaf90
>
> Thank you,
> Anton


From joe.darcy at oracle.com  Fri May 30 03:12:57 2014
From: joe.darcy at oracle.com (Joe Darcy)
Date: Thu, 29 May 2014 20:12:57 -0700
Subject: <Beans Dev> JDK 9 RFR of JDK-8042860 : Fix raw and unchecked
	warnings in java.beans
Message-ID: <5387F739.2000802@oracle.com>

Hello,

Please review this draft fix for

     JDK-8042860 : Fix raw and unchecked warnings in java.beans
     http://cr.openjdk.java.net/~darcy/8042860.0/

Note that I did not try to generify the java.util.Collection methods in 
BeanContextSupport.

Thanks,

-Joe

From sergey.malenkov at oracle.com  Fri May 30 08:45:42 2014
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Fri, 30 May 2014 12:45:42 +0400
Subject: <Beans Dev> Approved: JDK 9 RFR of JDK-8042860 : Fix raw and
 unchecked warnings in java.beans
In-Reply-To: <5387F739.2000802@oracle.com>
References: <5387F739.2000802@oracle.com>
Message-ID: <53884536.6050000@oracle.com>

The fix is good to me.

SAM

On 30.05.2014 7:12, Joe Darcy wrote:
> Hello,
>
> Please review this draft fix for
>
>     JDK-8042860 : Fix raw and unchecked warnings in java.beans
>     http://cr.openjdk.java.net/~darcy/8042860.0/
>
> Note that I did not try to generify the java.util.Collection methods 
> in BeanContextSupport.
>
> Thanks,
>
> -Joe


From sergey.malenkov at oracle.com  Fri May 30 16:36:50 2014
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Fri, 30 May 2014 20:36:50 +0400
Subject: <Beans Dev> [9] RFR 7084904: Introspector returns isX() from base
 package-private class that throws exception
Message-ID: <5388B3A2.9080002@oracle.com>

Hello,

Could you please review the following fix:
http://cr.openjdk.java.net/~malenkov/7084904.9.0/
http://bugs.openjdk.java.net/browse/JDK-7084904
Add useful test.

Thanks,
SAM