<Beans Dev> [9] Review Request: 8077270 Missed test data in the test on java.beans.BeanProperty

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Aug 18 07:54:00 UTC 2015


   The fix looks good to me.

   Thanks,
   Alexandr.

On 8/17/2015 6:08 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for a typo in jdk9.
>
> Description:
> The test TestBeanProperty.java contains the check which never executed:
>
> if ((R.class == type) == !Boolean.TRUE.equals(pd.getValue("required"))) {
>        BeanUtils.reportPropertyDescriptor(pd);
>        throw new Error("required");
> }
>
> since R.class is missing in the Class<?>[] types. Instead, Class<?>[] 
> types contains D.class which is not used in the checks.
>
> In the fix R.class was added to the tested types and an additional 
> check was added to the D.class.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8077270
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8077270/webrev.00
>



More information about the beans-dev mailing list