From Sergey.Bylokhov at oracle.com  Tue Aug  9 14:30:26 2016
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 9 Aug 2016 17:30:26 +0300
Subject: <Beans Dev> [9] Review Request: 8159696 java.beans.MethodRef#get
 throws NullPointerException
Message-ID: <65614dfd-03b9-e846-ed62-12b0ee20dffc@oracle.com>

Hello.
Please review the fix for jdk9.

The NPE occurs in java.beans.MethodRef#get when we tries to check 
package access using null method. This happens when the class which we 
cached before was unloaded for some reason.

After the fix the get() method returns null in such situations.

Bug: https://bugs.openjdk.java.net/browse/JDK-8159696
Webrev can be found at: http://cr.openjdk.java.net/~serb/8159696/webrev.00

-- 
Best regards, Sergey.

From alexandr.scherbatiy at oracle.com  Wed Aug 10 15:25:56 2016
From: alexandr.scherbatiy at oracle.com (Alexandr Scherbatiy)
Date: Wed, 10 Aug 2016 18:25:56 +0300
Subject: <Beans Dev> [9] Review Request: 8159696
 java.beans.MethodRef#get throws NullPointerException
In-Reply-To: <65614dfd-03b9-e846-ed62-12b0ee20dffc@oracle.com>
References: <65614dfd-03b9-e846-ed62-12b0ee20dffc@oracle.com>
Message-ID: <f4775eaa-d220-9dd9-a0eb-5a7c27a4fe53@oracle.com>

The fix looks good to me.

Thanks,
Alexandr.

On 8/9/2016 5:30 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk9.
>
> The NPE occurs in java.beans.MethodRef#get when we tries to check 
> package access using null method. This happens when the class which we 
> cached before was unloaded for some reason.
>
> After the fix the get() method returns null in such situations.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8159696
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8159696/webrev.00
>


From Sergey.Bylokhov at oracle.com  Tue Aug 16 13:36:15 2016
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 16 Aug 2016 16:36:15 +0300
Subject: <Beans Dev> [9] Review Request: 8159898 Negative array size in
 java/beans/Introspector/Test8027905.java
Message-ID: <3d931888-8555-3316-7aa5-6420490bd2bd@oracle.com>

Hello.
Please review the fix for jdk9.

The javabeans test tries to allocate huge array and fail, because the 
calculated size became negative.(another test from the description of 
the bug was fixed already by JDK-8159899).

In the fix I added "-xm" option to minimize the available amount of memory.

Also I added this option to one of awt test, which works properly but 
this update will speedup it.

Bug: https://bugs.openjdk.java.net/browse/JDK-8159898
Webrev can be found at: http://cr.openjdk.java.net/~serb/8159898/webrev.00

-- 
Best regards, Sergey.

From yuri.nesterenko at oracle.com  Tue Aug 16 13:46:59 2016
From: yuri.nesterenko at oracle.com (Yuri Nesterenko)
Date: Tue, 16 Aug 2016 16:46:59 +0300
Subject: <Beans Dev> [9] Review Request: 8159898 Negative array size in
 java/beans/Introspector/Test8027905.java
In-Reply-To: <3d931888-8555-3316-7aa5-6420490bd2bd@oracle.com>
References: <3d931888-8555-3316-7aa5-6420490bd2bd@oracle.com>
Message-ID: <3498100f-59cb-279e-fb5d-0bbdbdf2a313@oracle.com>

+1

-yan

On 08/16/2016 04:36 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk9.
>
> The javabeans test tries to allocate huge array and fail, because the
> calculated size became negative.(another test from the description of
> the bug was fixed already by JDK-8159899).
>
> In the fix I added "-xm" option to minimize the available amount of memory.
>
> Also I added this option to one of awt test, which works properly but
> this update will speedup it.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8159898
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8159898/webrev.00
>


From alexandr.scherbatiy at oracle.com  Tue Aug 16 17:22:41 2016
From: alexandr.scherbatiy at oracle.com (Alexandr Scherbatiy)
Date: Tue, 16 Aug 2016 20:22:41 +0300
Subject: <Beans Dev> [9] Review Request: 8159898 Negative array size in
 java/beans/Introspector/Test8027905.java
In-Reply-To: <3498100f-59cb-279e-fb5d-0bbdbdf2a313@oracle.com>
References: <3d931888-8555-3316-7aa5-6420490bd2bd@oracle.com>
	<3498100f-59cb-279e-fb5d-0bbdbdf2a313@oracle.com>
Message-ID: <0dffeafd-8acc-cc98-9297-b2a05ba7048a@oracle.com>

The fix looks good to me.

Thanks,
Alexandr.

On 8/16/2016 4:46 PM, Yuri Nesterenko wrote:
> +1
>
> -yan
>
> On 08/16/2016 04:36 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk9.
>>
>> The javabeans test tries to allocate huge array and fail, because the
>> calculated size became negative.(another test from the description of
>> the bug was fixed already by JDK-8159899).
>>
>> In the fix I added "-xm" option to minimize the available amount of 
>> memory.
>>
>> Also I added this option to one of awt test, which works properly but
>> this update will speedup it.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8159898
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/8159898/webrev.00
>>
>