From sergey.bylokhov at oracle.com Thu Dec 8 21:55:54 2016 From: sergey.bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 8 Dec 2016 13:55:54 -0800 Subject: [9] Review Request: 8131347 new @BeanProperty annotation: inconsistent behavior for "enumerationValues" Message-ID: <5EBC41FC-4ABC-44EF-BF8C-B6C25D7EC765@oracle.com> Hello. Please review the fix for jdk9. The implementation was changed to report an empty array(instead of null) as a default value for @BeanProperty( ?enumerationValues?). Bug: https://bugs.openjdk.java.net/browse/JDK-8131347 Webrev can be found at: http://cr.openjdk.java.net/~serb/8131347/webrev.00 From alexander.v.stepanov at oracle.com Fri Dec 9 16:03:58 2016 From: alexander.v.stepanov at oracle.com (Alexander Stepanov) Date: Fri, 9 Dec 2016 19:03:58 +0300 Subject: [9] Review Request: 8131347 new @BeanProperty annotation: inconsistent behavior for "enumerationValues" In-Reply-To: <5EBC41FC-4ABC-44EF-BF8C-B6C25D7EC765@oracle.com> References: <5EBC41FC-4ABC-44EF-BF8C-B6C25D7EC765@oracle.com> Message-ID: Hello Sergey, the fix looks good for me (not a reviewer). Thanks, Alexander On 12/9/2016 12:55 AM, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk9. > > The implementation was changed to report an empty array(instead of null) as a default value for @BeanProperty( > ?enumerationValues?). > > Bug: https://bugs.openjdk.java.net/browse/JDK-8131347 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8131347/webrev.00 From philip.race at oracle.com Wed Dec 14 20:43:10 2016 From: philip.race at oracle.com (Phil Race) Date: Wed, 14 Dec 2016 12:43:10 -0800 Subject: [9] Review Request: 8169900 The code which use Applets should be deprecated In-Reply-To: References: Message-ID: <2529ee1d-c21a-b57c-a163-250377b10154@oracle.com> Looks OK except for a couple of typo nits below. You can fix those without a new review However you will need a CCC for deprecating the public API AppletInitializer and the Beans.instantiate method which references it 159 * @deprecated It s recommended to use "It is" ? -- 160 * {@link #instantiate(ClassLoader, String, BeanContext)}, because the 161 * Applet API is deprecated. See the Nit picky, but since you need to edit this anyway please break the above in the source as 160 * {@link #instantiate(ClassLoader, String, BeanContext)}, 161 * because the Applet API is deprecated. See the -phil. On 11/17/2016 09:31 AM, Sergey Bylokhov wrote: > Hello. > > Please review the fix for jdk9. > > Some time ago the Applets were deprecated,see JEP-289[1]. After that > the code which uses Applets were marked with > "@SuppressWarnings("deprecation")"[2]. > > This is a request to deprecate such API in JavaBeans and in Swing. > I also mark as deprecated the code which is related to AppletViewer(it > is also deprecated[3]) > > [1] http://openjdk.java.net/jeps/289 > [2] > http://mail.openjdk.java.net/pipermail/swing-dev/2016-October/006788.html > [3] https://bugs.openjdk.java.net/browse/JDK-8074165 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8169900 > Webrev can be found at: > http://cr.openjdk.java.net/~serb/8169900/webrev.00 > -------------- next part -------------- An HTML attachment was scrubbed... URL: