<Beans Dev> [9] Review Request: 8132973 @BeanProperty: what is the correct output in case of repeating annotations?

Alexandr Scherbatiy alexandr.scherbatiy at oracle.com
Mon May 23 18:01:26 UTC 2016

  Just two small comments.

"If the read method and the write method of the property annotated" - 
may be be it can be slightly rephrased like: "If both the read and the 
write methods of the property are annotated"

  There is the place where "update after 8132973 fix" code is 
uncommented. But the bug 8132973 is still open. Does it mean that the 
uncommented code does not relate to the issue 8132973?


On 5/23/2016 12:31 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk9.
> The bug describe the situation when for the same property both 
> read/write methods are annotated. Our code assumes that the annotation 
> exists only for one of these methods, and we produce the unspecified 
> mix of both annotations(some of the data from reader and other from 
> writer).
> As a fix I changed the order of initialization, first we will try the 
> reader and if necessary the writer (before it was expected that the 
> data from the read will overwrite the data from write, but it fails 
> because of optimization). The specification is clarified and ccc will 
> be filed after the technical review. The tests are updated also.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8132973
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8132973/webrev.00

More information about the beans-dev mailing list