<Beans Dev> [9] Review Request: 8132973 @BeanProperty: what is the correct output in case of repeating annotations?

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue May 24 12:35:02 UTC 2016

On 24/05/16 16:26, Sergey Bylokhov wrote:

> On 24.05.16 15:14, Alexander Scherbatiy wrote:
>>> This case related to JDK-8155013.
>>    It does not make something clearly because JDK-8155013 (and
>> JDK-8132973 comment from BeanPropertyTest) are still open.
> There are a testcases which fails before the fix, and uncomment after 
> the fix. Please clarify what comment did you mean?
   I see now. Thank you for details.

   The fix looks good to me.

>>>> On 5/23/2016 12:31 PM, Sergey Bylokhov wrote:
>>>>> Hello.
>>>>> Please review the fix for jdk9.
>>>>> The bug describe the situation when for the same property both
>>>>> read/write methods are annotated. Our code assumes that the 
>>>>> annotation
>>>>> exists only for one of these methods, and we produce the unspecified
>>>>> mix of both annotations(some of the data from reader and other from
>>>>> writer).
>>>>> As a fix I changed the order of initialization, first we will try the
>>>>> reader and if necessary the writer (before it was expected that the
>>>>> data from the read will overwrite the data from write, but it fails
>>>>> because of optimization). The specification is clarified and ccc will
>>>>> be filed after the technical review. The tests are updated also.
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8132973
>>>>> Webrev can be found at:
>>>>> http://cr.openjdk.java.net/~serb/8132973/webrev.00

More information about the beans-dev mailing list