From Sergey.Bylokhov at oracle.com  Mon Apr 22 07:15:43 2019
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 22 Apr 2019 00:15:43 -0700
Subject: <Beans Dev> [13] Review Request: 8222799 java.beans.Introspector
 uses an obsolete methods cache
Message-ID: <1b14d6ad-5c4e-2d6c-3756-810ebb76cda8@oracle.com>

Hello.
Please review the fix for JDK 13.

Bug: https://bugs.openjdk.java.net/browse/JDK-8222799
Fix: http://cr.openjdk.java.net/~serb/8222799/webrev.00

The "java.beans.Introspector" uses "declaredMethodCache" which was used before JDK-4058433:
http://hg.openjdk.java.net/jdk/jdk/rev/ba387c302edd#l9.367
Note that "declaredMethodCache.put()" was removed, and now we never populate this cache. It is used only as a synchronization monitor in some methods.

In the fix this cache was removed, and synchronization was moved to the ThreadGroupContext class.


-- 
Best regards, Sergey.

From philip.race at oracle.com  Mon Apr 22 16:17:11 2019
From: philip.race at oracle.com (Phil Race)
Date: Mon, 22 Apr 2019 09:17:11 -0700
Subject: <Beans Dev> [13] Review Request: 8222799
 java.beans.Introspector uses an obsolete methods cache
In-Reply-To: <1b14d6ad-5c4e-2d6c-3756-810ebb76cda8@oracle.com>
References: <1b14d6ad-5c4e-2d6c-3756-810ebb76cda8@oracle.com>
Message-ID: <95a3c01d-fb0a-6fb4-d9c0-bbdcbaf07ccb@oracle.com>

Looks fine.

-phil.

On 4/22/19 12:15 AM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for JDK 13.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222799
> Fix: http://cr.openjdk.java.net/~serb/8222799/webrev.00
>
> The "java.beans.Introspector" uses "declaredMethodCache" which was 
> used before JDK-4058433:
> http://hg.openjdk.java.net/jdk/jdk/rev/ba387c302edd#l9.367
> Note that "declaredMethodCache.put()" was removed, and now we never 
> populate this cache. It is used only as a synchronization monitor in 
> some methods.
>
> In the fix this cache was removed, and synchronization was moved to 
> the ThreadGroupContext class.
>
>