From github.com+741251+turbanoff at openjdk.java.net Fri Dec 11 08:09:03 2020 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Fri, 11 Dec 2020 08:09:03 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop Message-ID: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> 8258006: Replaces while cycles with iterator with enhanced for in java.desktop ------------- Commit messages: - [PATCH] Replaces while cycles with iterator with enhanced for in java.desktop Changes: https://git.openjdk.java.net/jdk/pull/1574/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1574&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258006 Stats: 167 lines in 25 files changed: 0 ins; 99 del; 68 mod Patch: https://git.openjdk.java.net/jdk/pull/1574.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1574/head:pull/1574 PR: https://git.openjdk.java.net/jdk/pull/1574 From serb at openjdk.java.net Fri Dec 11 08:09:03 2020 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Fri, 11 Dec 2020 08:09:03 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop In-Reply-To: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> Message-ID: On Wed, 2 Dec 2020 19:23:28 GMT, Andrey Turbanov wrote: > 8258006: Replaces while cycles with iterator with enhanced for in java.desktop The bug is filed: https://bugs.openjdk.java.net/browse/JDK-8258006 ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From prr at openjdk.java.net Sat Dec 12 23:07:56 2020 From: prr at openjdk.java.net (Phil Race) Date: Sat, 12 Dec 2020 23:07:56 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop In-Reply-To: References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> Message-ID: <0-jwcFGX120HimAS6zOwyWXaE2o21SGKRZuUbzFjYc4=.47a80aed-75e9-4788-a3a9-f32c989c206a@github.com> On Wed, 9 Dec 2020 23:50:23 GMT, Sergey Bylokhov wrote: >> 8258006: Replaces while cycles with iterator with enhanced for in java.desktop > > The bug is filed: > https://bugs.openjdk.java.net/browse/JDK-8258006 Whilst this looks "reasonable" I am not impressed by the complete lack of description of 1) why this is being proposed 2) what are the benefits 3) what testing has been done etc etc. The bug repoert is even more content free. It also deserves a meaningful description ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From github.com+741251+turbanoff at openjdk.java.net Mon Dec 14 19:50:55 2020 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Mon, 14 Dec 2020 19:50:55 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop In-Reply-To: <0-jwcFGX120HimAS6zOwyWXaE2o21SGKRZuUbzFjYc4=.47a80aed-75e9-4788-a3a9-f32c989c206a@github.com> References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> <0-jwcFGX120HimAS6zOwyWXaE2o21SGKRZuUbzFjYc4=.47a80aed-75e9-4788-a3a9-f32c989c206a@github.com> Message-ID: <6_qWqbMNRwSTEf_rllVnAH501WChHc1LWeR_6rvE8NU=.c28161e5-5428-4bda-96b9-bbb3e845ec21@github.com> On Sat, 12 Dec 2020 23:05:35 GMT, Phil Race wrote: >> The bug is filed: >> https://bugs.openjdk.java.net/browse/JDK-8258006 > > Whilst this looks "reasonable" I am not impressed by the complete lack of description of > 1) why this is being proposed > 2) what are the benefits > 3) what testing has been done > etc etc. > The bug repoert is even more content free. It also deserves a meaningful description I've added few words in description. About testing: as I can see testing is done via Github Actions. tier1 builds are ok. ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From prr at openjdk.java.net Mon Dec 14 20:06:55 2020 From: prr at openjdk.java.net (Phil Race) Date: Mon, 14 Dec 2020 20:06:55 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop In-Reply-To: <6_qWqbMNRwSTEf_rllVnAH501WChHc1LWeR_6rvE8NU=.c28161e5-5428-4bda-96b9-bbb3e845ec21@github.com> References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> <0-jwcFGX120HimAS6zOwyWXaE2o21SGKRZuUbzFjYc4=.47a80aed-75e9-4788-a3a9-f32c989c206a@github.com> <6_qWqbMNRwSTEf_rllVnAH501WChHc1LWeR_6rvE8NU=.c28161e5-5428-4bda-96b9-bbb3e845ec21@github.com> Message-ID: On Mon, 14 Dec 2020 19:48:36 GMT, Andrey Turbanov wrote: > I've added few words in description. > > About testing: as I can see testing is done via Github Actions. tier1 builds are ok. OK that's better But about testing. The github actions won't run a single test that touches any code with these changes All the client tests are in tier3-> tier5. ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From github.com+741251+turbanoff at openjdk.java.net Tue Dec 15 15:24:03 2020 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Tue, 15 Dec 2020 15:24:03 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2] In-Reply-To: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> Message-ID: > There are few places in code where manual `while` loop is used with `Iterator` to iterate over `Collection`. > Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle instead: it's less verbose, makes code easier to read and it's less error-prone. > It doesn't have any performance impact: java compiler generates similar code when compiling _enhanced-for_ cycle. > > See similar cleanup in C++ code - #1707 Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 8258006: Replace 'while' cycles with iterator with enhanced 'for' in java.desktop ------------- Changes: https://git.openjdk.java.net/jdk/pull/1574/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1574&range=01 Stats: 167 lines in 25 files changed: 0 ins; 99 del; 68 mod Patch: https://git.openjdk.java.net/jdk/pull/1574.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1574/head:pull/1574 PR: https://git.openjdk.java.net/jdk/pull/1574 From github.com+741251+turbanoff at openjdk.java.net Tue Dec 15 17:16:55 2020 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Tue, 15 Dec 2020 17:16:55 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop In-Reply-To: References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> <0-jwcFGX120HimAS6zOwyWXaE2o21SGKRZuUbzFjYc4=.47a80aed-75e9-4788-a3a9-f32c989c206a@github.com> <6_qWqbMNRwSTEf_rllVnAH501WChHc1LWeR_6rvE8NU=.c28161e5-5428-4bda-96b9-bbb3e845ec21@github.com> Message-ID: <3D-sUIk4a6Oqx9vB2QnpDPs_lVSMnLbcm9dSGC9T0EE=.7a72a072-7cd0-4427-aa25-034592a02dd9@github.com> On Mon, 14 Dec 2020 20:04:05 GMT, Phil Race wrote: >> I've added few words in description. >> >> About testing: as I can see testing is done via Github Actions. tier1 builds are ok. > >> I've added few words in description. >> >> About testing: as I can see testing is done via Github Actions. tier1 builds are ok. > > OK that's better But about testing. The github actions won't run a single test that touches any code with these changes > All the client tests are in tier3-> tier5. I've run `test-tier3`. 15 tests failed. Looks like they are not related to my changes: JT Harness : Tests that failed Tests are grouped by their final status message. Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: TestFailedException: TEST FAILED: Rmid process exited with status 1 after 100ms. java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java: synopsis: need to modify registered ActivationDesc and ActivationGroupDesc Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: TestFailedException: TEST FAILED: Test1 failed: a service would not restart java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java: synopsis: Activatable objects cannot be restarted. Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: java.rmi.activation.ActivateFailedException: activation failed; nested exception is: java.rmi.activation.ActivationException: timeout creating child process java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java: rmid should annotate child process output java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java: synopsis: rmid should not destroy group when it reports inactiveGroup Execution failed: `main' threw exception: java.lang.Error: text should be 1.1 java/beans/PropertyEditor/TestDoubleClassValue.java: Tests PropertyEditor for value of type Double java/beans/PropertyEditor/TestDoubleTypeValue.java: Tests PropertyEditor for value of type double Execution failed: `main' threw exception: java.lang.Error: values are not equal java/beans/PropertyEditor/TestDoubleClassJava.java: Tests PropertyEditor for value of type Double java/beans/PropertyEditor/TestDoubleTypeJava.java: Tests PropertyEditor for value of type double Execution failed: `main' threw exception: java.lang.Exception: failures: 1 sanity/client/SwingSet/src/ColorChooserDemoTest.java: Verifies SwingSet3 ColorChooserDemo by performing simple interaction with all the controls that are shown in the ColorChooserDialog. Execution failed: `main' threw exception: java.lang.StackOverflowError java/beans/XMLEncoder/Test6531597.java: Tests encoding of arrays of primitives java/beans/XMLEncoder/Test6989223.java: Tests Rectangle2D.Double encoding java/beans/XMLEncoder/java_awt_GridBagConstraints.java: Tests GridBagConstraints encoding java/beans/XMLEncoder/java_awt_LinearGradientPaint.java: Tests LinearGradientPaint encoding java/beans/XMLEncoder/java_awt_RadialGradientPaint.java: Tests RadialGradientPaint encoding java/beans/XMLEncoder/java_awt_geom_AffineTransform.java: Tests AffineTransform encoding ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From prr at openjdk.java.net Tue Dec 15 21:16:56 2020 From: prr at openjdk.java.net (Phil Race) Date: Tue, 15 Dec 2020 21:16:56 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop In-Reply-To: <3D-sUIk4a6Oqx9vB2QnpDPs_lVSMnLbcm9dSGC9T0EE=.7a72a072-7cd0-4427-aa25-034592a02dd9@github.com> References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> <0-jwcFGX120HimAS6zOwyWXaE2o21SGKRZuUbzFjYc4=.47a80aed-75e9-4788-a3a9-f32c989c206a@github.com> <6_qWqbMNRwSTEf_rllVnAH501WChHc1LWeR_6rvE8NU=.c28161e5-5428-4bda-96b9-bbb3e845ec21@github.com> <3D-sUIk4a6Oqx9vB2QnpDPs_lVSMnLbcm9dSGC9T0EE=.7a72a072-7cd0-4427-aa25-034592a02dd9@github.com> Message-ID: On Tue, 15 Dec 2020 17:14:11 GMT, Andrey Turbanov wrote: >>> I've added few words in description. >>> >>> About testing: as I can see testing is done via Github Actions. tier1 builds are ok. >> >> OK that's better But about testing. The github actions won't run a single test that touches any code with these changes >> All the client tests are in tier3-> tier5. > > I've run `test-tier3`. 15 tests failed. Looks like they are not related to my changes: > > JT Harness : Tests that failed > Tests are grouped by their final status message. > Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: TestFailedException: TEST FAILED: Rmid process exited with status 1 after 100ms. > > java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java: synopsis: need to modify registered ActivationDesc and ActivationGroupDesc > > Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: TestFailedException: TEST FAILED: Test1 failed: a service would not restart > > java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java: synopsis: Activatable objects cannot be restarted. > > Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: java.rmi.activation.ActivateFailedException: activation failed; nested exception is: java.rmi.activation.ActivationException: timeout creating child process > > java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java: rmid should annotate child process output > java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java: synopsis: rmid should not destroy group when it reports inactiveGroup > > Execution failed: `main' threw exception: java.lang.Error: text should be 1.1 > > java/beans/PropertyEditor/TestDoubleClassValue.java: Tests PropertyEditor for value of type Double > java/beans/PropertyEditor/TestDoubleTypeValue.java: Tests PropertyEditor for value of type double > > Execution failed: `main' threw exception: java.lang.Error: values are not equal > > java/beans/PropertyEditor/TestDoubleClassJava.java: Tests PropertyEditor for value of type Double > java/beans/PropertyEditor/TestDoubleTypeJava.java: Tests PropertyEditor for value of type double > > Execution failed: `main' threw exception: java.lang.Exception: failures: 1 > > sanity/client/SwingSet/src/ColorChooserDemoTest.java: Verifies SwingSet3 ColorChooserDemo by performing simple interaction with all the controls that are shown in the ColorChooserDialog. > > Execution failed: `main' threw exception: java.lang.StackOverflowError > > java/beans/XMLEncoder/Test6531597.java: Tests encoding of arrays of primitives > java/beans/XMLEncoder/Test6989223.java: Tests Rectangle2D.Double encoding > java/beans/XMLEncoder/java_awt_GridBagConstraints.java: Tests GridBagConstraints encoding > java/beans/XMLEncoder/java_awt_LinearGradientPaint.java: Tests LinearGradientPaint encoding > java/beans/XMLEncoder/java_awt_RadialGradientPaint.java: Tests RadialGradientPaint encoding > java/beans/XMLEncoder/java_awt_geom_AffineTransform.java: Tests AffineTransform encoding These tests more or less *never* fail so how are you sure it is not your changes ? And 8 beans tests failed and you made 3 changes in beans code so I'd like to see some evidence to show these failures are unrelated and an explanation as to why these stable tests now fail ? I don't think they are problem listed. ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From github.com+741251+turbanoff at openjdk.java.net Wed Dec 16 15:02:56 2020 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Wed, 16 Dec 2020 15:02:56 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop In-Reply-To: References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> <0-jwcFGX120HimAS6zOwyWXaE2o21SGKRZuUbzFjYc4=.47a80aed-75e9-4788-a3a9-f32c989c206a@github.com> <6_qWqbMNRwSTEf_rllVnAH501WChHc1LWeR_6rvE8NU=.c28161e5-5428-4bda-96b9-bbb3e845ec21@github.com> <3D-sUIk4a6Oqx9vB2QnpDPs_lVSMnLbcm9dSGC9T0EE=.7a72a072-7cd0-4427-aa25-034592a02dd9@github.com> Message-ID: On Tue, 15 Dec 2020 21:14:08 GMT, Phil Race wrote: >> I've run `test-tier3`. 15 tests failed. Looks like they are not related to my changes: >> >> JT Harness : Tests that failed >> Tests are grouped by their final status message. >> Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: TestFailedException: TEST FAILED: Rmid process exited with status 1 after 100ms. >> >> java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java: synopsis: need to modify registered ActivationDesc and ActivationGroupDesc >> >> Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: TestFailedException: TEST FAILED: Test1 failed: a service would not restart >> >> java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java: synopsis: Activatable objects cannot be restarted. >> >> Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: java.rmi.activation.ActivateFailedException: activation failed; nested exception is: java.rmi.activation.ActivationException: timeout creating child process >> >> java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java: rmid should annotate child process output >> java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java: synopsis: rmid should not destroy group when it reports inactiveGroup >> >> Execution failed: `main' threw exception: java.lang.Error: text should be 1.1 >> >> java/beans/PropertyEditor/TestDoubleClassValue.java: Tests PropertyEditor for value of type Double >> java/beans/PropertyEditor/TestDoubleTypeValue.java: Tests PropertyEditor for value of type double >> >> Execution failed: `main' threw exception: java.lang.Error: values are not equal >> >> java/beans/PropertyEditor/TestDoubleClassJava.java: Tests PropertyEditor for value of type Double >> java/beans/PropertyEditor/TestDoubleTypeJava.java: Tests PropertyEditor for value of type double >> >> Execution failed: `main' threw exception: java.lang.Exception: failures: 1 >> >> sanity/client/SwingSet/src/ColorChooserDemoTest.java: Verifies SwingSet3 ColorChooserDemo by performing simple interaction with all the controls that are shown in the ColorChooserDialog. >> >> Execution failed: `main' threw exception: java.lang.StackOverflowError >> >> java/beans/XMLEncoder/Test6531597.java: Tests encoding of arrays of primitives >> java/beans/XMLEncoder/Test6989223.java: Tests Rectangle2D.Double encoding >> java/beans/XMLEncoder/java_awt_GridBagConstraints.java: Tests GridBagConstraints encoding >> java/beans/XMLEncoder/java_awt_LinearGradientPaint.java: Tests LinearGradientPaint encoding >> java/beans/XMLEncoder/java_awt_RadialGradientPaint.java: Tests RadialGradientPaint encoding >> java/beans/XMLEncoder/java_awt_geom_AffineTransform.java: Tests AffineTransform encoding > > These tests more or less *never* fail so how are you sure it is not your changes ? > And 8 beans tests failed and you made 3 changes in beans code so I'd like to see some evidence > to show these failures are unrelated and an explanation as to why these stable tests now fail ? > I don't think they are problem listed. Oops. I also had changes from https://bugs.openjdk.java.net/browse/JDK-4511638 in my working tree. After I reverted them only 3 tests failed in `test-tier3`: JT Harness : Tests that failed Tests are grouped by their final status message. Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: java.rmi.activation.ActivateFailedException: activation failed; nested exception is: java.rmi.activation.ActivationException: timeout creating child process java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java: rmid does not handle group restart for latecomer objects Execution failed: `main' threw exception: java.lang.Exception: failures: 1 sanity/client/SwingSet/src/ColorChooserDemoTest.java: Verifies SwingSet3 ColorChooserDemo by performing simple interaction with all the controls that are shown in the ColorChooserDialog. sanity/client/SwingSet/src/SwingSet2DemoTest.java: Verifies check box menu item, radio button menu item, nested menus and themes using SwingSet2 main window. Report generated on Dec 16, 2020 5:54:22 PM Using JT Harness 6.0; built on November 30, 2020 at 12:00:00 AM MSK with java version "1.8.0_172" ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From github.com+741251+turbanoff at openjdk.java.net Wed Dec 16 15:17:55 2020 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Wed, 16 Dec 2020 15:17:55 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop In-Reply-To: References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> <0-jwcFGX120HimAS6zOwyWXaE2o21SGKRZuUbzFjYc4=.47a80aed-75e9-4788-a3a9-f32c989c206a@github.com> <6_qWqbMNRwSTEf_rllVnAH501WChHc1LWeR_6rvE8NU=.c28161e5-5428-4bda-96b9-bbb3e845ec21@github.com> <3D-sUIk4a6Oqx9vB2QnpDPs_lVSMnLbcm9dSGC9T0EE=.7a72a072-7cd0-4427-aa25-034592a02dd9@github.com> Message-ID: <95R1EkCgUgaaFlaDCTGOxGrJ2RFSlkBHD6iZZp6AbwQ=.30281786-4bef-43b6-8fdd-e89c40cfef28@github.com> On Wed, 16 Dec 2020 14:59:45 GMT, Andrey Turbanov wrote: >> These tests more or less *never* fail so how are you sure it is not your changes ? >> And 8 beans tests failed and you made 3 changes in beans code so I'd like to see some evidence >> to show these failures are unrelated and an explanation as to why these stable tests now fail ? >> I don't think they are problem listed. > > Oops. I also had changes from https://bugs.openjdk.java.net/browse/JDK-4511638 in my working tree. > After I reverted them only 3 tests failed in `test-tier3`: > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR >>> jtreg:test/jdk:tier3 1192 1189 3 0 << > jtreg:test/langtools:tier3 0 0 0 0 > jtreg:test/jaxp:tier3 0 0 0 0 > ============================== > TEST FAILURE > > JT Harness : Tests that failed > Tests are grouped by their final status message. > Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: java.rmi.activation.ActivateFailedException: activation failed; nested exception is: java.rmi.activation.ActivationException: timeout creating child process > > java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java: rmid does not handle group restart for latecomer objects > > Execution failed: `main' threw exception: java.lang.Exception: failures: 1 > > sanity/client/SwingSet/src/ColorChooserDemoTest.java: Verifies SwingSet3 ColorChooserDemo by performing simple interaction with all the controls that are shown in the ColorChooserDialog. > sanity/client/SwingSet/src/SwingSet2DemoTest.java: Verifies check box menu item, radio button menu item, nested menus and themes using SwingSet2 main window. > > Report generated on Dec 16, 2020 5:54:22 PM > Using JT Harness 6.0; built on November 30, 2020 at 12:00:00 AM MSK with java version "1.8.0_172" I tried to run this 3 tests separately - all passed. Looks like inference from other tests in test suite. user at WORK-PC /cygdrive/f/Projects/official_openjdk $ make test TEST="jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java" Building target 'test' in configuration 'windows-x86_64-server-release' Running tests using JTREG control variable 'VM_OPTIONS=-Duser.language=en -Duser.country=US' Test selection 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java', will run: * jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java Running test 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java' Passed: sanity/client/SwingSet/src/SwingSet2DemoTest.java Test results: passed: 1 Report written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java\html\report.html Results written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java Finished running test 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java' Test report is stored in build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java 1 1 0 0 ============================== TEST SUCCESS Finished building target 'test' in configuration 'windows-x86_64-server-release' user at WORK-PC /cygdrive/f/Projects/official_openjdk $ make test TEST="jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java" Building target 'test' in configuration 'windows-x86_64-server-release' Running tests using JTREG control variable 'VM_OPTIONS=-Duser.language=en -Duser.country=US' Test selection 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java', will run: * jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java Running test 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java' Passed: sanity/client/SwingSet/src/ColorChooserDemoTest.java Test results: passed: 1 Report written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java\html\report.html Results written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java Finished running test 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java' Test report is stored in build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java 1 1 0 0 ============================== TEST SUCCESS Finished building target 'test' in configuration 'windows-x86_64-server-release' user at WORK-PC /cygdrive/f/Projects/official_openjdk $ make test TEST="jtreg:test/jdk/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java" Building target 'test' in configuration 'windows-x86_64-server-release' Running tests using JTREG control variable 'VM_OPTIONS=-Duser.language=en -Duser.country=US' Test selection 'jtreg:test/jdk/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java', will run: * jtreg:test/jdk/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java Running test 'jtreg:test/jdk/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java' Passed: java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java Test results: passed: 1 Report written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_java_rmi_activation_Activatable_restartLatecomer_RestartLatecomer_java\html\report.html Results written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_java_rmi_activation_Activatable_restartLatecomer_RestartLatecomer_java Finished running test 'jtreg:test/jdk/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java' Test report is stored in build/windows-x86_64-server-release/test-results/jtreg_test_jdk_java_rmi_activation_Activatable_restartLatecomer_RestartLatecomer_java ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java 1 1 0 0 ============================== TEST SUCCESS Finished building target 'test' in configuration 'windows-x86_64-server-release' ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From prr at openjdk.java.net Wed Dec 16 17:15:00 2020 From: prr at openjdk.java.net (Phil Race) Date: Wed, 16 Dec 2020 17:15:00 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2] In-Reply-To: References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> Message-ID: <8x2aulxTMTvDITwrKYmoHwSmUfXi87jzQ2LziEe6cz4=.65b11f34-7fce-4836-aee2-7a43f2814384@github.com> On Tue, 15 Dec 2020 15:24:03 GMT, Andrey Turbanov wrote: >> There are few places in code where manual `while` loop is used with `Iterator` to iterate over `Collection`. >> Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle instead: it's less verbose, makes code easier to read and it's less error-prone. >> It doesn't have any performance impact: java compiler generates similar code when compiling _enhanced-for_ cycle. >> >> See similar cleanup in C++ code - #1707 > > Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8258006: Replace 'while' cycles with iterator with enhanced 'for' in java.desktop Ok. Approved. ------------- Marked as reviewed by prr (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1574 From serb at openjdk.java.net Fri Dec 18 00:10:57 2020 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Fri, 18 Dec 2020 00:10:57 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2] In-Reply-To: <8x2aulxTMTvDITwrKYmoHwSmUfXi87jzQ2LziEe6cz4=.65b11f34-7fce-4836-aee2-7a43f2814384@github.com> References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> <8x2aulxTMTvDITwrKYmoHwSmUfXi87jzQ2LziEe6cz4=.65b11f34-7fce-4836-aee2-7a43f2814384@github.com> Message-ID: On Wed, 16 Dec 2020 17:11:53 GMT, Phil Race wrote: >> Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> 8258006: Replace 'while' cycles with iterator with enhanced 'for' in java.desktop > > Ok. Approved. I'll run some other automated tests, in progress. ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From serb at openjdk.java.net Sat Dec 19 22:16:56 2020 From: serb at openjdk.java.net (Sergey Bylokhov) Date: Sat, 19 Dec 2020 22:16:56 GMT Subject: RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2] In-Reply-To: References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> Message-ID: On Tue, 15 Dec 2020 15:24:03 GMT, Andrey Turbanov wrote: >> There are few places in code where manual `while` loop is used with `Iterator` to iterate over `Collection`. >> Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle instead: it's less verbose, makes code easier to read and it's less error-prone. >> It doesn't have any performance impact: java compiler generates similar code when compiling _enhanced-for_ cycle. >> >> See similar cleanup in C++ code - #1707 > > Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 8258006: Replace 'while' cycles with iterator with enhanced 'for' in java.desktop Marked as reviewed by serb (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/1574 From github.com+741251+turbanoff at openjdk.java.net Sat Dec 19 22:22:56 2020 From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov) Date: Sat, 19 Dec 2020 22:22:56 GMT Subject: Integrated: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop In-Reply-To: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> References: <-qhgBaIcGzqUX1awyRI4iMC4ALv906xfvaSnVH7ObrU=.0369c185-5ddc-416d-ad56-301c3b692a23@github.com> Message-ID: On Wed, 2 Dec 2020 19:23:28 GMT, Andrey Turbanov wrote: > There are few places in code where manual `while` loop is used with `Iterator` to iterate over `Collection`. > Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle instead: it's less verbose, makes code easier to read and it's less error-prone. > It doesn't have any performance impact: java compiler generates similar code when compiling _enhanced-for_ cycle. > > See similar cleanup in C++ code - #1707 This pull request has now been integrated. Changeset: 580af490 Author: Andrey Turbanov Committer: Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/580af490 Stats: 167 lines in 25 files changed: 0 ins; 99 del; 68 mod 8258006: Replaces while cycles with iterator with enhanced for in java.desktop Reviewed-by: prr, serb ------------- PR: https://git.openjdk.java.net/jdk/pull/1574