<Beans Dev> RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2]

Phil Race prr at openjdk.java.net
Wed Dec 16 17:15:00 UTC 2020

On Tue, 15 Dec 2020 15:24:03 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

>> There are few places in code where manual `while` loop is used with `Iterator` to iterate over `Collection`.
>> Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle instead: it's less verbose, makes code easier to read and it's less error-prone.
>> It doesn't have any performance impact: java compiler generates similar code when compiling _enhanced-for_ cycle.
>> See similar cleanup in C++ code - #1707
> Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>   8258006: Replace 'while' cycles with iterator with enhanced 'for' in java.desktop

Ok. Approved.


Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1574

More information about the beans-dev mailing list