From prr at openjdk.java.net  Fri Oct  2 18:24:41 2020
From: prr at openjdk.java.net (Phil Race)
Date: Fri, 2 Oct 2020 18:24:41 GMT
Subject: <Beans Dev> RFR: 8251123: doclint warnings about missing
 javadoc tags and comments
In-Reply-To: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
Message-ID: <uVQfNzkXaMGLRflzd-LLsatQJyxFj5jtE57i-XPzzAU=.30e62e82-056d-4ad8-a2d5-c47e6c882f9d@github.com>

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
> 
> The fix:
>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>   - Adds comments to the "serializable" classes even if those classes are non-public
>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>   - Delete the java.awt.PeerFixer class.
> 
> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
> 
> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
> 
> The old review request:
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html

src/java.desktop/share/classes/javax/imageio/metadata/IIOMetadataNode.java line 44:

> 42: /**
> 43:  * A {@code IIODOMException} is thrown by the {@code IIOMetadataNode} in
> 44:  * "exceptional" circumstances.

"A" -> "An"

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From prr at openjdk.java.net  Fri Oct  2 18:38:39 2020
From: prr at openjdk.java.net (Phil Race)
Date: Fri, 2 Oct 2020 18:38:39 GMT
Subject: <Beans Dev> RFR: 8251123: doclint warnings about missing
 javadoc tags and comments
In-Reply-To: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
Message-ID: <_0gBfrD0z0Z7EFJ4SHXPR3namwcJkFJofC7GGwXOdq8=.901366c2-b6bc-4215-866d-f613def1006e@github.com>

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
> 
> The fix:
>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>   - Adds comments to the "serializable" classes even if those classes are non-public
>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>   - Delete the java.awt.PeerFixer class.
> 
> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
> 
> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
> 
> The old review request:
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html

I think the main thing here is I would separate out removing the duplicate PeerFixer into a new bug.

I also see that the CSR is still just a pure template.

src/java.desktop/share/classes/java/awt/ScrollPane.java line 815:

> 813:
> 814: /*
> 815:  * In JDK 1.1.1, the pkg private class java.awt.PeerFixer was moved to

As I mentioned in the OLD review thread for hg, this definitely needs a CSR
and it needs to be called out.
I think it should be separated out from this fix which is about fixing doclint warnings but here you are making an
incompatible change. Let's not mix the two.

src/java.desktop/share/classes/java/awt/CheckboxMenuItem.java line 434:

> 432:      * @serial
> 433:      */
> 434:     private int checkboxMenuItemSerializedDataVersion = 1;

OK. Good this was being discussed in the old review and it should stay.

src/java.desktop/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java line 75:

> 73:      * This constant is used when the backward focus traversal order is active.
> 74:      */
> 75:     private final int BACKWARD_TRAVERSAL = 1;

I see you also reverted the change of these two to static so that is also good.

-------------

Changes requested by prr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/369

From prr at openjdk.java.net  Fri Oct  2 19:48:40 2020
From: prr at openjdk.java.net (Phil Race)
Date: Fri, 2 Oct 2020 19:48:40 GMT
Subject: <Beans Dev> RFR: 8251123: doclint warnings about missing
 javadoc tags and comments
In-Reply-To: <_0gBfrD0z0Z7EFJ4SHXPR3namwcJkFJofC7GGwXOdq8=.901366c2-b6bc-4215-866d-f613def1006e@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
 <_0gBfrD0z0Z7EFJ4SHXPR3namwcJkFJofC7GGwXOdq8=.901366c2-b6bc-4215-866d-f613def1006e@github.com>
Message-ID: <a3IGk9CSgHYQtzvPRf6OKxOp0Y0TVtRdRKrTwSZzmjc=.ab15ee61-f58c-4300-b7b1-d56c4edfb0f5@github.com>

On Fri, 2 Oct 2020 18:35:25 GMT, Phil Race <prr at openjdk.org> wrote:

>> We have a number of missing javadoc tags and comments in the desktop module.
>> Most of the missing comments are related to the serialized form.
>> 
>> The fix:
>>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>>   - Adds comments to the "serializable" classes even if those classes are non-public
>>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>>   - Delete the java.awt.PeerFixer class.
>> 
>> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
>> 
>> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
>> 
>> The old review request:
>> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html
>
> I think the main thing here is I would separate out removing the duplicate PeerFixer into a new bug.
> 
> I also see that the CSR is still just a pure template.

> I need advice about what exact change should be reviewed in the CSR(except PeerFixer removal)

Probably almost all of it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From serb at openjdk.java.net  Sat Oct  3 00:31:48 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Sat, 3 Oct 2020 00:31:48 GMT
Subject: <Beans Dev> RFR: 8251123: doclint warnings about missing
 javadoc tags and comments [v2]
In-Reply-To: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
Message-ID: <6Ov7jdR5aBYuiqkmH1WnBXafvEMKjs0J56Qu5icFAzw=.eef7d4ff-1daf-44c7-8424-030a638c7c30@github.com>

> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
> 
> The fix:
>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>   - Adds comments to the "serializable" classes even if those classes are non-public
>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>   - Delete the java.awt.PeerFixer class.
> 
> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
> 
> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
> 
> The old review request:
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html

Sergey Bylokhov has updated the pull request incrementally with two additional commits since the last revision:

 - Update ScrollPane.java
 - Update based on the feedback

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/369/files
  - new: https://git.openjdk.java.net/jdk/pull/369/files/cfc1df5d..c1d83696

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=369&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=369&range=00-01

  Stats: 52 lines in 3 files changed: 49 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/369.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/369/head:pull/369

PR: https://git.openjdk.java.net/jdk/pull/369

From serb at openjdk.java.net  Sat Oct  3 03:59:39 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Sat, 3 Oct 2020 03:59:39 GMT
Subject: <Beans Dev> RFR: 8251123: doclint warnings about missing
 javadoc tags and comments [v2]
In-Reply-To: <a3IGk9CSgHYQtzvPRf6OKxOp0Y0TVtRdRKrTwSZzmjc=.ab15ee61-f58c-4300-b7b1-d56c4edfb0f5@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
 <_0gBfrD0z0Z7EFJ4SHXPR3namwcJkFJofC7GGwXOdq8=.901366c2-b6bc-4215-866d-f613def1006e@github.com>
 <a3IGk9CSgHYQtzvPRf6OKxOp0Y0TVtRdRKrTwSZzmjc=.ab15ee61-f58c-4300-b7b1-d56c4edfb0f5@github.com>
Message-ID: <UddqDTnOFHI-YSNdQZzuteuF_85KVQ0FK4deeIGu0y8=.5faf969a-fa30-4d0a-930a-3fc8dd33f407@github.com>

On Fri, 2 Oct 2020 19:46:10 GMT, Phil Race <prr at openjdk.org> wrote:

>> I think the main thing here is I would separate out removing the duplicate PeerFixer into a new bug.
>> 
>> I also see that the CSR is still just a pure template.
>
>> I need advice about what exact change should be reviewed in the CSR(except PeerFixer removal)
> 
> Probably almost all of it.

The PeerFixer is extracted to the separate CR:
https://bugs.openjdk.java.net/browse/JDK-8253965
https://github.com/openjdk/jdk/pull/493

Other review comments fixed as well, CSR is in progress.

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From serb at openjdk.java.net  Sat Oct  3 04:47:38 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Sat, 3 Oct 2020 04:47:38 GMT
Subject: <Beans Dev> RFR: 8251123: doclint warnings about missing
 javadoc tags and comments [v2]
In-Reply-To: <UddqDTnOFHI-YSNdQZzuteuF_85KVQ0FK4deeIGu0y8=.5faf969a-fa30-4d0a-930a-3fc8dd33f407@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
 <_0gBfrD0z0Z7EFJ4SHXPR3namwcJkFJofC7GGwXOdq8=.901366c2-b6bc-4215-866d-f613def1006e@github.com>
 <a3IGk9CSgHYQtzvPRf6OKxOp0Y0TVtRdRKrTwSZzmjc=.ab15ee61-f58c-4300-b7b1-d56c4edfb0f5@github.com>
 <UddqDTnOFHI-YSNdQZzuteuF_85KVQ0FK4deeIGu0y8=.5faf969a-fa30-4d0a-930a-3fc8dd33f407@github.com>
Message-ID: <D53f6P8Sy0JldulN2eLc5lvLf2vRqqWhdbDASunNYEA=.8411f644-ea3c-4567-9f6b-b2c16a9e8f0c@github.com>

On Sat, 3 Oct 2020 03:57:21 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>>> I need advice about what exact change should be reviewed in the CSR(except PeerFixer removal)
>> 
>> Probably almost all of it.
>
> The PeerFixer is extracted to the separate CR:
> https://bugs.openjdk.java.net/browse/JDK-8253965
> https://github.com/openjdk/jdk/pull/493
> 
> Other review comments fixed as well, CSR is in progress.

CSR is updated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From prr at openjdk.java.net  Sat Oct  3 19:36:38 2020
From: prr at openjdk.java.net (Phil Race)
Date: Sat, 3 Oct 2020 19:36:38 GMT
Subject: <Beans Dev> RFR: 8251123: doclint warnings about missing
 javadoc tags and comments [v2]
In-Reply-To: <6Ov7jdR5aBYuiqkmH1WnBXafvEMKjs0J56Qu5icFAzw=.eef7d4ff-1daf-44c7-8424-030a638c7c30@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
 <6Ov7jdR5aBYuiqkmH1WnBXafvEMKjs0J56Qu5icFAzw=.eef7d4ff-1daf-44c7-8424-030a638c7c30@github.com>
Message-ID: <afqcPoSnlob0W3uBFdJhPvJjQooTQtt0tKpVRF_CLn8=.c5c5d822-dd61-4009-958f-022abb53998f@github.com>

On Sat, 3 Oct 2020 00:31:48 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> We have a number of missing javadoc tags and comments in the desktop module.
>> Most of the missing comments are related to the serialized form.
>> 
>> The fix:
>>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>>   - Adds comments to the "serializable" classes even if those classes are non-public
>>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>>   - Delete the java.awt.PeerFixer class.
>> 
>> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
>> 
>> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
>> 
>> The old review request:
>> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html
>
> Sergey Bylokhov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update ScrollPane.java
>  - Update based on the feedback

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From serb at openjdk.java.net  Tue Oct  6 10:52:46 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Tue, 6 Oct 2020 10:52:46 GMT
Subject: <Beans Dev> Integrated: 8251123: doclint warnings about missing
 javadoc tags and comments
In-Reply-To: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
References: <dLKsXDutH87luyKefwe1x_JiZ2lE91G2kKdQ2b2pBBo=.a7a8b9c9-f008-4b0a-bbcc-72d23c7cdc2e@github.com>
Message-ID: <lmzyAsFG-4zRCB24dmBd8jYTT_pTVkVlXiqg6oocYkY=.3f9d9853-b02a-42d5-8cec-30ba575d3fed@github.com>

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
> 
> The fix:
>   - Adds missing comments to the non-static/non-transient fields(even private) of the "serializable" classes
>   - Adds comments to the "serializable" classes even if those classes are non-public
>   - Fixes references/adds missing tags to the special methods(like readObject/writeObject)
>   - Delete the java.awt.PeerFixer class.
> 
> I need advice about what exact change should be reviewed in  the CSR(except PeerFixer removal)
> 
> Note that in some cases I added the comments to the "implementation details", so I did not specify it fully.
> 
> The old review request:
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000423.html

This pull request has now been integrated.

Changeset: f397b60a
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/f397b60a
Stats:     1256 lines in 69 files changed: 809 ins; 165 del; 282 mod

8251123: doclint warnings about missing javadoc tags and comments

Reviewed-by: jdv, prr

-------------

PR: https://git.openjdk.java.net/jdk/pull/369

From serb at openjdk.java.net  Wed Oct 14 05:27:23 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Wed, 14 Oct 2020 05:27:23 GMT
Subject: <Beans Dev> RFR: 8231454: File lock in Windows on a loaded jar due
 to a leak in Introspector::getBeanInfo
Message-ID: <fZyUV7tor-0HcJaxCfQjj3nnU76X4jdfXSwtDGIo_qU=.64643678-b078-400b-998d-681ac2f357f5@github.com>

java.beans.Introspector is using a new cache mechanism since Java9 in com.sun.beans.introspect.ClassInfo::CACHE which
uses a SoftReference cache over the class, which makes the class "leak", unless clearing the cache manually or
collecting the SoftReference by the GC.

Note that this is not a pure "leak", because the SoftReference will be collected if there is no enough memory on the
system, but if the heap is big enough then all objects referenced from the cached class will be in the memory.

The class has a reference to the ClassLoader, and If the soft reference to the class is not collected by the GC, then
the ClassLoader cannot be unloaded and this block the jar file removing.

The solution is to update the implementation of Introspector.flushCaches()/flushFromCaches(Class) to clear the whole
cache or the cache for the specific class.

-------------

Commit messages:
 - Update FlushClassInfoCache.java
 - Initial fix

Changes: https://git.openjdk.java.net/jdk/pull/647/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=647&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8231454
  Stats: 113 lines in 3 files changed: 109 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/647.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/647/head:pull/647

PR: https://git.openjdk.java.net/jdk/pull/647

From serb at openjdk.java.net  Tue Oct 20 08:41:19 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Tue, 20 Oct 2020 08:41:19 GMT
Subject: <Beans Dev> RFR: 8255043: Incorrectly styled copyright text
Message-ID: <gmKuCsi5-p4TN8bZ4CswPyFBokCuuyLRwWNAGNktarI=.c88a1093-9525-40ca-9a37-0d780240b41a@github.com>

In some files, the copyright text is styled as a JavaDoc comment.
Most of the affected files are tests, only one product file is affected:
src/java.sql/share/classes/javax/sql/package-info.java

The chenge is trivial:
 - /**
 + /*
    * Copyright (c)

-------------

Commit messages:
 - Initial fix

Changes: https://git.openjdk.java.net/jdk/pull/759/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=759&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8255043
  Stats: 49 lines in 49 files changed: 0 ins; 0 del; 49 mod
  Patch: https://git.openjdk.java.net/jdk/pull/759.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/759/head:pull/759

PR: https://git.openjdk.java.net/jdk/pull/759

From dholmes at openjdk.java.net  Tue Oct 20 11:50:12 2020
From: dholmes at openjdk.java.net (David Holmes)
Date: Tue, 20 Oct 2020 11:50:12 GMT
Subject: <Beans Dev> RFR: 8255043: Incorrectly styled copyright text
In-Reply-To: <gmKuCsi5-p4TN8bZ4CswPyFBokCuuyLRwWNAGNktarI=.c88a1093-9525-40ca-9a37-0d780240b41a@github.com>
References: <gmKuCsi5-p4TN8bZ4CswPyFBokCuuyLRwWNAGNktarI=.c88a1093-9525-40ca-9a37-0d780240b41a@github.com>
Message-ID: <oAJyHuvaVS9H-Y8Z8vDnqML0RsSK5WmSrxKR9O2GYgw=.93275630-0b8e-4d4d-9f29-91e9d61ba7a0@github.com>

On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
> 
> The chenge is trivial:
>  - /**
>  + /*
>     * Copyright (c)

Seems trivially fine.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/759

From trebari at openjdk.java.net  Tue Oct 20 14:36:16 2020
From: trebari at openjdk.java.net (Tejpal Rebari)
Date: Tue, 20 Oct 2020 14:36:16 GMT
Subject: <Beans Dev> RFR: 8255043: Incorrectly styled copyright text
In-Reply-To: <gmKuCsi5-p4TN8bZ4CswPyFBokCuuyLRwWNAGNktarI=.c88a1093-9525-40ca-9a37-0d780240b41a@github.com>
References: <gmKuCsi5-p4TN8bZ4CswPyFBokCuuyLRwWNAGNktarI=.c88a1093-9525-40ca-9a37-0d780240b41a@github.com>
Message-ID: <CtA6WT7xZga1jTihp34QUNkSDWGbmKjloVbK2WKVeqc=.35ba1bd5-2a32-4f82-a361-fdb857d5b2ef@github.com>

On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
> 
> The chenge is trivial:
>  - /**
>  + /*
>     * Copyright (c)

Marked as reviewed by trebari (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/759

From jdv at openjdk.java.net  Tue Oct 20 15:43:14 2020
From: jdv at openjdk.java.net (Jayathirth D V)
Date: Tue, 20 Oct 2020 15:43:14 GMT
Subject: <Beans Dev> RFR: 8255043: Incorrectly styled copyright text
In-Reply-To: <gmKuCsi5-p4TN8bZ4CswPyFBokCuuyLRwWNAGNktarI=.c88a1093-9525-40ca-9a37-0d780240b41a@github.com>
References: <gmKuCsi5-p4TN8bZ4CswPyFBokCuuyLRwWNAGNktarI=.c88a1093-9525-40ca-9a37-0d780240b41a@github.com>
Message-ID: <3HXa_fWqHw4PKAfkD6oo5xKl8gR5ss7yhfl87HdSuGI=.fd3fa01c-a7a1-4e13-ab60-9852ff93162d@github.com>

On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
> 
> The chenge is trivial:
>  - /**
>  + /*
>     * Copyright (c)

Marked as reviewed by jdv (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/759

From kizune at openjdk.java.net  Tue Oct 20 21:47:13 2020
From: kizune at openjdk.java.net (Alexander Zuev)
Date: Tue, 20 Oct 2020 21:47:13 GMT
Subject: <Beans Dev> RFR: 8231454: File lock in Windows on a loaded jar
 due to a leak in Introspector::getBeanInfo
In-Reply-To: <fZyUV7tor-0HcJaxCfQjj3nnU76X4jdfXSwtDGIo_qU=.64643678-b078-400b-998d-681ac2f357f5@github.com>
References: <fZyUV7tor-0HcJaxCfQjj3nnU76X4jdfXSwtDGIo_qU=.64643678-b078-400b-998d-681ac2f357f5@github.com>
Message-ID: <CDPDacJWyLjqYaRNNhdlWKY20OYR8Ql6LejUmF4dVt0=.8087653e-1764-45d3-87c8-922ce52bcf0f@github.com>

On Wed, 14 Oct 2020 05:18:23 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> java.beans.Introspector is using a new cache mechanism since Java9 in com.sun.beans.introspect.ClassInfo::CACHE which
> uses a SoftReference cache over the class, which makes the class "leak", unless clearing the cache manually or
> collecting the SoftReference by the GC.  Note that this is not a pure "leak", because the SoftReference will be
> collected if there is no enough memory on the system, but if the heap is big enough then all objects referenced from
> the cached class will be in the memory.  The class has a reference to the ClassLoader, and If the soft reference to the
> class is not collected by the GC, then the ClassLoader cannot be unloaded and this block the jar file removing.
> The solution is to update the implementation of Introspector.flushCaches()/flushFromCaches(Class) to clear the whole
> cache or the cache for the specific class.

Looks good.

-------------

Marked as reviewed by kizune (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/647

From serb at openjdk.java.net  Wed Oct 21 02:08:16 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Wed, 21 Oct 2020 02:08:16 GMT
Subject: <Beans Dev> Integrated: 8231454: File lock in Windows on a loaded
 jar due to a leak in Introspector::getBeanInfo
In-Reply-To: <fZyUV7tor-0HcJaxCfQjj3nnU76X4jdfXSwtDGIo_qU=.64643678-b078-400b-998d-681ac2f357f5@github.com>
References: <fZyUV7tor-0HcJaxCfQjj3nnU76X4jdfXSwtDGIo_qU=.64643678-b078-400b-998d-681ac2f357f5@github.com>
Message-ID: <IyYo3fo6x8X8aKFwHmYFZRS3IMxdmo4pQmgiffvRaKw=.2c779d78-82b0-4d09-a74b-3e8d31f7d4ec@github.com>

On Wed, 14 Oct 2020 05:18:23 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> java.beans.Introspector is using a new cache mechanism since Java9 in com.sun.beans.introspect.ClassInfo::CACHE which
> uses a SoftReference cache over the class, which makes the class "leak", unless clearing the cache manually or
> collecting the SoftReference by the GC.  Note that this is not a pure "leak", because the SoftReference will be
> collected if there is no enough memory on the system, but if the heap is big enough then all objects referenced from
> the cached class will be in the memory.  The class has a reference to the ClassLoader, and If the soft reference to the
> class is not collected by the GC, then the ClassLoader cannot be unloaded and this block the jar file removing.
> The solution is to update the implementation of Introspector.flushCaches()/flushFromCaches(Class) to clear the whole
> cache or the cache for the specific class.

This pull request has now been integrated.

Changeset: 2ee2b4ae
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/2ee2b4ae
Stats:     113 lines in 3 files changed: 109 ins; 1 del; 3 mod

8231454: File lock in Windows on a loaded jar due to a leak in Introspector::getBeanInfo

Reviewed-by: kizune

-------------

PR: https://git.openjdk.java.net/jdk/pull/647

From serb at openjdk.java.net  Wed Oct 21 04:59:11 2020
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Wed, 21 Oct 2020 04:59:11 GMT
Subject: <Beans Dev> Integrated: 8255043: Incorrectly styled copyright text
In-Reply-To: <gmKuCsi5-p4TN8bZ4CswPyFBokCuuyLRwWNAGNktarI=.c88a1093-9525-40ca-9a37-0d780240b41a@github.com>
References: <gmKuCsi5-p4TN8bZ4CswPyFBokCuuyLRwWNAGNktarI=.c88a1093-9525-40ca-9a37-0d780240b41a@github.com>
Message-ID: <uY9_C2GsjjjeRUbkkGBGaLV1-0qpYTy51mavhxfKn-8=.83430cb4-fce3-4c17-83c8-e4f35c8f5af6@github.com>

On Tue, 20 Oct 2020 08:17:27 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> In some files, the copyright text is styled as a JavaDoc comment.
> Most of the affected files are tests, only one product file is affected:
> src/java.sql/share/classes/javax/sql/package-info.java
> 
> The chenge is trivial:
>  - /**
>  + /*
>     * Copyright (c)

This pull request has now been integrated.

Changeset: 2e510e04
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/2e510e04
Stats:     49 lines in 49 files changed: 0 ins; 0 del; 49 mod

8255043: Incorrectly styled copyright text

Reviewed-by: dholmes, trebari, jdv

-------------

PR: https://git.openjdk.java.net/jdk/pull/759