Invalid sanity check
Kelly O'Hair
kelly.ohair at oracle.com
Mon Oct 18 17:23:27 UTC 2010
On Oct 17, 2010, at 10:35 PM, David Holmes wrote:
> I happened to notice in jdk/make/common/shared/Sanity.gmk:
>
> sane-gcc-compiler:
> ifeq ($(PLATFORM), solaris)
> ifndef OPENJDK
> @if [ -r $(GCC_COMPILER_PATH) ]; then \
> ....
> fi
> endif
>
> ifeq ($(PLATFORM), linux)
>
>
> Looks to me like there's a misplaced endif there.
Not sure I see any misplaced endif. I looked at http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/0613978371d8/make/common/shared/Sanity.gmk
I do see a rather ugly improperly indented mix of shell if commands
and makefile if statements. :^(
Or maybe the bad indenting is the TAB character viewing problem. :^(
-kto
>
> David
More information about the build-dev
mailing list