From neil.richards at ngmr.net Wed Nov 2 17:37:08 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Wed, 02 Nov 2011 17:37:08 +0000 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> Message-ID: <1320255428.10693.16.camel@chalkhill> On Thu, 2011-10-20 at 09:21 -0700, Kelly O'Hair wrote: > Looks good. > > > -kto > Hi Zhengyu, Given Kelly's blessing, are you now happy to push this change to jdk8? (If you're otherwise tied up, I can drive the mechanics of the push if you provide me with a suitable java bug id to use.) Regards, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From zhengyu.gu at oracle.com Wed Nov 2 18:07:13 2011 From: zhengyu.gu at oracle.com (Zhengyu Gu) Date: Wed, 02 Nov 2011 14:07:13 -0400 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: <1320255428.10693.16.camel@chalkhill> References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> <1320255428.10693.16.camel@chalkhill> Message-ID: <4EB186D1.1080804@oracle.com> Hi Neil, My understanding is that you need to have at least two reviewers who have 'reviewer' privilege, (and I don't have 'reviewer' privilege). Yes, I am tied up, if you can handle the push, that will be great. What java bug id you need? can you use CR 6988099? BTW, here is the link to all the reviewers and committers: http://openjdk.java.net/census Thanks, -Zhengyu On 11/2/2011 1:37 PM, Neil Richards wrote: > On Thu, 2011-10-20 at 09:21 -0700, Kelly O'Hair wrote: >> Looks good. >> >> >> -kto >> > Hi Zhengyu, > Given Kelly's blessing, are you now happy to push this change to jdk8? > > (If you're otherwise tied up, I can drive the mechanics of the push if > you provide me with a suitable java bug id to use.) > > Regards, Neil > From neil.richards at ngmr.net Wed Nov 2 18:54:47 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Wed, 02 Nov 2011 18:54:47 +0000 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: <4EB186D1.1080804@oracle.com> References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> <1320255428.10693.16.camel@chalkhill> <4EB186D1.1080804@oracle.com> Message-ID: <1320260087.11068.37.camel@chalkhill> On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: > Hi Neil, > > My understanding is that you need to have at least two reviewers who > have 'reviewer' privilege, (and I don't have 'reviewer' privilege). > I had a quick leaf through the OpenJDK Bylaws. It looks like the number of necessary approvals from 'reviewers' vs 'committers' (vs anyone else) is project-specific, so it isn't directly defined there. Now you raise it, I wasn't able to track down where in the JDK 8 project documentation this is defined either. The log of (at least) the jdk repository suggests that this limit isn't universally applied (though in many cases, the submitter is of 'reviewer' status themselves - perhaps that counts towards the total ?). Kelly, can you give guidance / pointers here ? (So far, this change has found favor by one 'reviewer' - you - and two 'committers' - Zhengyu and myself). > Yes, I am tied up, if you can handle the push, that will be great. What > java bug id you need? can you use CR 6988099? > Doh! Of course I can. (I blame it all on coding-blindness - that's the same as snow-blindness, but in hex). Regards, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From kelly.ohair at oracle.com Wed Nov 2 19:29:35 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 2 Nov 2011 12:29:35 -0700 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: <1320260087.11068.37.camel@chalkhill> References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> <1320255428.10693.16.camel@chalkhill> <4EB186D1.1080804@oracle.com> <1320260087.11068.37.camel@chalkhill> Message-ID: This change is both a build change and a serviceability change, but I would argue that it is more of a build change since the functionality of the jvmti demos shouldn't have changed with this. Although I am listed as a member of the serviceability "group", I'm not exactly sure who leads that group now, Daniel D. Daugherty is listed in the census but I'm not sure if that is correct. Some groups have forests for integration changes into the primary releases, like jdk8 right now. I am the lead on the build "group" and I can speak to that. For jdk8 build changes, those being pushed into jdk8 (or the http://hg.openjdk.java.net/jdk8/build forest) only one reviewer is generally required, I have not heard anything about more than one, although more is always better, especially if there is any paranoia over the changes. In this case, and with most build changes, someone should verify that all platforms still build ok. It will be important that you create the changeset using the latest jdk8 build forest, e.g. using a clones from http://hg.openjdk.java.net/jdk8/build Once you are happy that the change is ok on your system, then bundle up the changeset with 'hg bundle' and I will run it through our internal JPRT build system to insure all build platforms are ok, then I can push it into the http://hg.openjdk.java.net/jdk8/build repos. -kto On Nov 2, 2011, at 11:54 AM, Neil Richards wrote: > On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: >> Hi Neil, >> >> My understanding is that you need to have at least two reviewers who >> have 'reviewer' privilege, (and I don't have 'reviewer' privilege). >> > > I had a quick leaf through the OpenJDK Bylaws. > It looks like the number of necessary approvals from 'reviewers' vs > 'committers' (vs anyone else) is project-specific, so it isn't directly > defined there. > > Now you raise it, I wasn't able to track down where in the JDK 8 project > documentation this is defined either. > > The log of (at least) the jdk repository suggests that this limit isn't > universally applied (though in many cases, the submitter is of > 'reviewer' status themselves - perhaps that counts towards the total ?). > > Kelly, can you give guidance / pointers here ? > (So far, this change has found favor by one 'reviewer' - you - and two > 'committers' - Zhengyu and myself). > >> Yes, I am tied up, if you can handle the push, that will be great. What >> java bug id you need? can you use CR 6988099? >> > > Doh! Of course I can. > (I blame it all on coding-blindness - that's the same as snow-blindness, > but in hex). > > Regards, Neil > > -- > Unless stated above: > IBM email: neil_richards at uk.ibm.com > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > From keith.mcguigan at oracle.com Wed Nov 2 19:30:23 2011 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Wed, 2 Nov 2011 15:30:23 -0400 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: <1320260087.11068.37.camel@chalkhill> References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> <1320255428.10693.16.camel@chalkhill> <4EB186D1.1080804@oracle.com> <1320260087.11068.37.camel@chalkhill> Message-ID: <28B63F29-A37E-4ABF-B1E9-2B830FF8888B@oracle.com> Didn't Dan Dougherty review this too? Is he a "reviewer" for this project? If it helps you can put me down as a reviewer (kamg). On Nov 2, 2011, at 2:54 PM, Neil Richards wrote: > On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: >> Hi Neil, >> >> My understanding is that you need to have at least two reviewers who >> have 'reviewer' privilege, (and I don't have 'reviewer' privilege). >> > > I had a quick leaf through the OpenJDK Bylaws. > It looks like the number of necessary approvals from 'reviewers' vs > 'committers' (vs anyone else) is project-specific, so it isn't > directly > defined there. > > Now you raise it, I wasn't able to track down where in the JDK 8 > project > documentation this is defined either. > > The log of (at least) the jdk repository suggests that this limit > isn't > universally applied (though in many cases, the submitter is of > 'reviewer' status themselves - perhaps that counts towards the > total ?). > > Kelly, can you give guidance / pointers here ? > (So far, this change has found favor by one 'reviewer' - you - and two > 'committers' - Zhengyu and myself). > >> Yes, I am tied up, if you can handle the push, that will be great. >> What >> java bug id you need? can you use CR 6988099? >> > > Doh! Of course I can. > (I blame it all on coding-blindness - that's the same as snow- > blindness, > but in hex). > > Regards, Neil > > -- > Unless stated above: > IBM email: neil_richards at uk.ibm.com > IBM United Kingdom Limited - Registered in England and Wales with > number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire > PO6 3AU > From david.katleman at sun.com Wed Nov 2 22:04:41 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 02 Nov 2011 22:04:41 +0000 Subject: hg: jdk8/build: Added tag jdk8-b11 for changeset 1defbc57940a Message-ID: <20111102220441.45B574720B@hg.openjdk.java.net> Changeset: 8e2104d565ba Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/8e2104d565ba Added tag jdk8-b11 for changeset 1defbc57940a ! .hgtags From david.katleman at sun.com Wed Nov 2 22:04:50 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 02 Nov 2011 22:04:50 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b11 for changeset 0199e4fef5cc Message-ID: <20111102220451.CB7124720C@hg.openjdk.java.net> Changeset: 31d70911b712 Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/31d70911b712 Added tag jdk8-b11 for changeset 0199e4fef5cc ! .hgtags From david.katleman at sun.com Wed Nov 2 22:21:58 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 02 Nov 2011 22:21:58 +0000 Subject: hg: jdk8/build/hotspot: 11 new changesets Message-ID: <20111102222223.43B024720D@hg.openjdk.java.net> Changeset: 02fe430d493e Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/02fe430d493e Added tag jdk8-b11 for changeset 4538caeef7b6 ! .hgtags Changeset: c9d25d93ddfe Author: jcoomes Date: 2011-10-21 16:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c9d25d93ddfe 7103619: Bump the hs23 build number to 04 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5e5d4821bf07 Author: brutisso Date: 2011-10-20 10:21 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5e5d4821bf07 7097516: G1: assert(0<= from_card && from_card Changeset: ca977d167697 Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/ca977d167697 Added tag jdk8-b11 for changeset d1b7a4f6dd20 ! .hgtags From david.katleman at sun.com Wed Nov 2 22:24:05 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 02 Nov 2011 22:24:05 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b11 for changeset a12ab897a249 Message-ID: <20111102222405.EDA3A4720F@hg.openjdk.java.net> Changeset: e6eed2ff5d5f Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/e6eed2ff5d5f Added tag jdk8-b11 for changeset a12ab897a249 ! .hgtags From david.katleman at sun.com Wed Nov 2 22:24:37 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 02 Nov 2011 22:24:37 +0000 Subject: hg: jdk8/build/jdk: 25 new changesets Message-ID: <20111102222847.7749A47210@hg.openjdk.java.net> Changeset: e1f4b4b4b96e Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e1f4b4b4b96e Added tag jdk8-b11 for changeset 7ab0d613cd1a ! .hgtags Changeset: 7746eb8c610b Author: bae Date: 2011-10-17 15:20 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7746eb8c610b 6997116: The case automatically failed due to java.lang.ClassCastException. Reviewed-by: jgodinez, prr ! src/windows/classes/sun/java2d/d3d/D3DSurfaceData.java + test/sun/java2d/DirectX/DrawBitmaskToSurfaceTest.java Changeset: a7a001378444 Author: jgodinez Date: 2011-10-24 09:58 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a7a001378444 6604109: javax.print.PrintServiceLookup.lookupPrintServices fails SOMETIMES for Cups Reviewed-by: bae, prr ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: 8f9b0629d088 Author: lana Date: 2011-10-25 21:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8f9b0629d088 Merge Changeset: 2b27e14a4c82 Author: vinnie Date: 2011-10-13 12:00 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2b27e14a4c82 7099228: Use a PKCS11 config attribute to control encoding of an EC point Reviewed-by: valeriep, mullan ! src/share/classes/sun/security/pkcs11/Config.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Key.java ! src/share/lib/security/sunpkcs11-solaris.cfg ! test/ProblemList.txt Changeset: 01615d3e74ed Author: mullan Date: 2011-10-13 13:50 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/01615d3e74ed 6953295: Move few sun.security.{util, x509, pkcs} classes used by keytool/jarsigner to another package Reviewed-by: mchung ! make/sun/security/other/Makefile - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java + src/share/classes/sun/security/pkcs10/PKCS10.java + src/share/classes/sun/security/pkcs10/PKCS10Attribute.java + src/share/classes/sun/security/pkcs10/PKCS10Attributes.java ! src/share/classes/sun/security/provider/certpath/CertStoreHelper.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/provider/certpath/ldap/LDAPCertStore.java ! src/share/classes/sun/security/provider/certpath/ldap/LDAPCertStoreHelper.java + src/share/classes/sun/security/provider/certpath/ssl/SSLServerCertStore.java + src/share/classes/sun/security/provider/certpath/ssl/SSLServerCertStoreHelper.java + src/share/classes/sun/security/tools/CertAndKeyGen.java ! src/share/classes/sun/security/tools/KeyTool.java + src/share/classes/sun/security/tools/PathList.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: 04ecbd2bcf5a Author: mullan Date: 2011-10-13 13:53 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/04ecbd2bcf5a Merge Changeset: 6cb07b35acf5 Author: weijun Date: 2011-10-17 17:11 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6cb07b35acf5 7099399: cannot deal with CRL file larger than 16MB Reviewed-by: xuelei, mullan ! src/share/classes/sun/security/provider/X509Factory.java + test/sun/security/provider/X509Factory/BigCRL.java Changeset: 9bf526cc4046 Author: mullan Date: 2011-10-18 10:12 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9bf526cc4046 7092897: sun.security.util.Cache should be generified Reviewed-by: xuelei ! src/share/classes/sun/security/pkcs11/KeyCache.java ! src/share/classes/sun/security/provider/X509Factory.java ! src/share/classes/sun/security/provider/certpath/CertStoreHelper.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/provider/certpath/X509CertificatePair.java ! src/share/classes/sun/security/provider/certpath/ldap/LDAPCertStore.java ! src/share/classes/sun/security/ssl/SSLSessionContextImpl.java ! src/share/classes/sun/security/util/Cache.java Changeset: f566cd364a90 Author: mullan Date: 2011-10-18 10:15 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f566cd364a90 Merge ! src/share/classes/sun/security/provider/X509Factory.java Changeset: 8640b7185be1 Author: wetmore Date: 2011-10-18 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8640b7185be1 7031830: bad_record_mac failure on TLSv1.2 enabled connection with SSLEngine Reviewed-by: xuelei, weijun, asaha ! src/share/classes/sun/security/ssl/CipherBox.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java Changeset: 57eb9136b73b Author: mullan Date: 2011-10-19 10:15 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/57eb9136b73b 7102686: Restructure timestamp code so that jars and modules can more easily share the same code Reviewed-by: mchung ! src/share/classes/sun/security/pkcs/PKCS7.java ! src/share/classes/sun/security/pkcs/SignerInfo.java ! src/share/classes/sun/security/timestamp/HttpTimestamper.java ! src/share/classes/sun/security/timestamp/TSRequest.java ! src/share/classes/sun/security/timestamp/TSResponse.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/TimestampedSigner.java ! src/share/classes/sun/security/util/Debug.java ! src/share/classes/sun/security/util/SignatureFileVerifier.java Changeset: 15078025eed9 Author: mullan Date: 2011-10-19 10:16 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/15078025eed9 Merge Changeset: c5c91589b126 Author: mduigou Date: 2011-10-19 14:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c5c91589b126 5029031: Add Collections.checkedQueue() Reviewed-by: mduigou Contributed-by: darryl.mocek at oracle.com ! src/share/classes/java/util/Collections.java + test/java/util/Collections/CheckedQueue.java Changeset: 634cd6f050ba Author: chegar Date: 2011-10-20 09:08 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/634cd6f050ba 7102704: test/java/net/DatagramSocket/ChangingAddress.java failing Reviewed-by: chegar Contributed-by: kurchi.subhra.hazra at oracle.com - test/java/net/DatagramSocket/ChangingAddress.java Changeset: 2d89c3f74aa5 Author: michaelm Date: 2011-10-20 09:21 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2d89c3f74aa5 7102665: Move tests to Problemlist Reviewed-by: chegar, alanb ! test/ProblemList.txt Changeset: 52c2dd336207 Author: michaelm Date: 2011-10-20 09:26 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/52c2dd336207 Merge - test/java/net/DatagramSocket/ChangingAddress.java Changeset: c3da0672a882 Author: ngmr Date: 2011-10-13 12:30 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c3da0672a882 7100054: (porting) Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Summary: Use POSIX defined includes for unistd.h and fcntl.h Reviewed-by: dholmes, alanb, chegar, ngmr Contributed-by: Charles Lee ! src/solaris/native/sun/nio/fs/genSolarisConstants.c ! src/solaris/native/sun/nio/fs/genUnixConstants.c Changeset: d979afceb792 Author: peytoia Date: 2011-10-21 15:56 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d979afceb792 7103108: (tz) Support tzdata2011l Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: db9e246c651e Author: peytoia Date: 2011-10-21 18:01 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/db9e246c651e 7103405: Correct display names for Pacific/Apia timezone Reviewed-by: okutsu ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: 3f391e649ccb Author: chegar Date: 2011-10-24 20:55 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3f391e649ccb 7104209: Cleanup and remove librmi (native library) Reviewed-by: mduigou, alanb ! make/java/java/mapfile-vers ! make/sun/rmi/rmi/Makefile - make/sun/rmi/rmi/mapfile-vers ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/sun/misc/VM.java ! src/share/classes/sun/rmi/server/MarshalInputStream.java ! src/share/native/java/io/ObjectInputStream.c ! src/share/native/sun/misc/VM.c - src/share/native/sun/rmi/server/MarshalInputStream.c Changeset: b375523d6037 Author: chegar Date: 2011-10-24 21:03 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b375523d6037 7103549: Remove dependencies on libjava and libjvm from security libraries Reviewed-by: vinnie, ohair, alanb, dholmes ! make/com/sun/security/auth/module/Makefile ! make/common/Defs.gmk ! make/common/Library.gmk ! make/sun/security/ec/Makefile ! make/sun/security/jgss/wrapper/Makefile ! make/sun/security/krb5/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! make/sun/security/smartcardio/Makefile ! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c ! src/share/native/sun/security/pkcs11/wrapper/p11_digest.c ! src/share/native/sun/security/pkcs11/wrapper/p11_dual.c ! src/share/native/sun/security/pkcs11/wrapper/p11_general.c ! src/share/native/sun/security/pkcs11/wrapper/p11_keymgmt.c ! src/share/native/sun/security/pkcs11/wrapper/p11_mutex.c ! src/share/native/sun/security/pkcs11/wrapper/p11_objmgmt.c ! src/share/native/sun/security/pkcs11/wrapper/p11_sessmgmt.c ! src/share/native/sun/security/pkcs11/wrapper/p11_sign.c ! src/share/native/sun/security/pkcs11/wrapper/p11_util.c ! src/share/native/sun/security/pkcs11/wrapper/pkcs11wrapper.h ! src/solaris/native/sun/security/pkcs11/j2secmod_md.c ! src/solaris/native/sun/security/smartcardio/pcsc_md.c ! src/windows/native/sun/security/pkcs11/j2secmod_md.c Changeset: 72666cd49ac3 Author: alanb Date: 2011-10-25 09:27 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/72666cd49ac3 7104577: Changes for 7104209 cause many RMI tests to fail Reviewed-by: chegar ! src/share/classes/sun/rmi/server/MarshalInputStream.java Changeset: 7814800c64bd Author: lana Date: 2011-10-25 21:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7814800c64bd Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: 09fd2067f715 Author: lana Date: 2011-10-28 17:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/09fd2067f715 Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java From david.katleman at sun.com Wed Nov 2 22:31:19 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 02 Nov 2011 22:31:19 +0000 Subject: hg: jdk8/build/langtools: 13 new changesets Message-ID: <20111102223146.CC92147211@hg.openjdk.java.net> Changeset: 8ff85191a7ac Author: katleman Date: 2011-10-27 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8ff85191a7ac Added tag jdk8-b11 for changeset 4bf01f1c4e34 ! .hgtags Changeset: b5d0b8effc85 Author: mcimadamore Date: 2011-10-17 12:54 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b5d0b8effc85 7097436: Project Coin: duplicate varargs warnings on method annotated with @SafeVarargs Summary: Duplicate aliasing check during subtyping leads to spurious varargs diagnostic Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/varargs/7097436/T7097436.java + test/tools/javac/varargs/7097436/T7097436.out ! test/tools/javac/varargs/warning/Warn5.java Changeset: 3cdfa97e1be9 Author: mcimadamore Date: 2011-10-17 12:57 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3cdfa97e1be9 7093325: Redundant entry in bytecode exception table Summary: Inlining of finalizers does not update gaps list accordingly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/T7093325.java Changeset: 366c233eb838 Author: mcimadamore Date: 2011-10-19 16:56 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/366c233eb838 7102515: javac running very very long and not returning Summary: Verbose resolution diagnostics slow down with operator resolution Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/7102515/T7102515.java + test/tools/javac/7102515/T7102515.out Changeset: d2cbb77469ed Author: jjg Date: 2011-10-19 15:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d2cbb77469ed 7101146: Paths should more directly managed by BaseFileManager Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java Changeset: b4021c520e40 Author: jjh Date: 2011-10-21 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b4021c520e40 7098530: tools/javac/javazip/Test.sh can fail on Windows Summary: Fix cygpath command to properly convert path Reviewed-by: jjg ! test/tools/javac/javazip/Test.sh Changeset: d346ab55031b Author: mcimadamore Date: 2011-10-24 13:00 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d346ab55031b 7096014: Javac tokens should retain state Summary: Refactor javac tokens from enum constants to stateful instances (to keep track of position, comments, etc.) Reviewed-by: jjg ! src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java - src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java ! src/share/classes/com/sun/tools/javac/parser/EndPosParser.java + src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java - src/share/classes/com/sun/tools/javac/parser/Keywords.java ! src/share/classes/com/sun/tools/javac/parser/Lexer.java ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/ScannerFactory.java - src/share/classes/com/sun/tools/javac/parser/Token.java + src/share/classes/com/sun/tools/javac/parser/Tokens.java + src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! test/tools/javac/api/TestJavacTaskScanner.java + test/tools/javac/depDocComment/DeprecatedDocComment3.java + test/tools/javac/tree/DocCommentToplevelTest.java Changeset: 05814303a056 Author: mcimadamore Date: 2011-10-24 13:00 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/05814303a056 7098660: Write better overload resolution/inference tests Summary: Add overload/inference debug diagnostics - added test harness using annotations to check outcome of overload resolution/inference Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/ApplicableMethodFound.java + test/tools/javac/diags/examples/ApplicableMethodFound1.java + test/tools/javac/diags/examples/DeferredMethodInst.java + test/tools/javac/diags/examples/FullInstSig.java + test/tools/javac/diags/examples/NotApplicableMethodFound.java + test/tools/javac/diags/examples/PartialInstSig.java + test/tools/javac/diags/examples/VerboseResolveMulti.java + test/tools/javac/diags/examples/VerboseResolveMulti1.java + test/tools/javac/resolve/Candidate.java + test/tools/javac/resolve/Pos.java + test/tools/javac/resolve/ResolveHarness.java + test/tools/javac/resolve/TraceResolve.java + test/tools/javac/resolve/tests/BoxedReturnTypeInference.java + test/tools/javac/resolve/tests/PrimitiveOverReferenceOverInferred.java + test/tools/javac/resolve/tests/PrimitiveOverReferenceOverVarargs.java + test/tools/javac/resolve/tests/PrimitiveOverReferenceVarargsAmbiguous.java + test/tools/javac/resolve/tests/PrimitiveOverload.java + test/tools/javac/resolve/tests/PrimitiveReturnTypeInference.java + test/tools/javac/resolve/tests/ReferenceOverInferred.java + test/tools/javac/resolve/tests/ReferenceOverVarargs.java + test/tools/javac/resolve/tests/ReferenceOverload.java Changeset: b73a9be0b993 Author: mcimadamore Date: 2011-10-25 15:40 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b73a9be0b993 7104618: MessageInfo.java is failing after lexer changes Summary: Two langtools regression tests cannot be built due to a bad import statement Reviewed-by: jjg ! test/tools/javac/diags/ArgTypeCompilerFactory.java Changeset: d830d28fc72e Author: jjg Date: 2011-10-25 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d830d28fc72e 7104039: refactor/cleanup javac Paths class Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java + src/share/classes/com/sun/tools/javac/file/Locations.java - src/share/classes/com/sun/tools/javac/file/Paths.java ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java Changeset: a1eaf78ababb Author: jjh Date: 2011-10-25 19:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a1eaf78ababb 7104905: Java SE build fails on call to CreateSymbols Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/Locations.java Changeset: 52df2131e294 Author: lana Date: 2011-10-25 21:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/52df2131e294 Merge - src/share/classes/com/sun/tools/javac/file/Paths.java - src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java - src/share/classes/com/sun/tools/javac/parser/Keywords.java - src/share/classes/com/sun/tools/javac/parser/Token.java Changeset: f2d6ed25857d Author: lana Date: 2011-10-28 17:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f2d6ed25857d Merge - src/share/classes/com/sun/tools/javac/file/Paths.java - src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java - src/share/classes/com/sun/tools/javac/parser/Keywords.java - src/share/classes/com/sun/tools/javac/parser/Token.java From david.holmes at oracle.com Thu Nov 3 00:50:55 2011 From: david.holmes at oracle.com (David Holmes) Date: Thu, 03 Nov 2011 10:50:55 +1000 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: <4EB1A4B9.3020905@oracle.com> References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> <1320255428.10693.16.camel@chalkhill> <4EB186D1.1080804@oracle.com> <1320260087.11068.37.camel@chalkhill> <4EB1A4B9.3020905@oracle.com> Message-ID: <4EB1E56F.8000404@oracle.com> On 3/11/2011 6:14 AM, Daniel D. Daugherty wrote: > On 11/2/11 1:29 PM, Kelly O'Hair wrote: >> This change is both a build change and a serviceability change, but I >> would argue that it is more >> of a build change since the functionality of the jvmti demos shouldn't >> have changed with this. >> >> Although I am listed as a member of the serviceability "group", I'm >> not exactly sure who leads that >> group now, Daniel D. Daugherty is listed in the census but I'm not >> sure if that is correct. > > It is not correct. I think the entire set of census entries for > Serviceability are now stale. They need to be updated with the > folks from the new Serviceability Team that Tuva Palm is building. This is getting somewhat off-topic with regard to pushing changesets, but there needs to be a formal voting process for adding/removing members of a group or appointing a new group lead. But do not confuse the OpenJDK Serviceability group with Oracle's internal "serviceability team" (as I will call them). These are not the same thing and team members need not be Serviceability Group members to work on changes in the serviceability area. The Serviceability group, as such, is not particularly relevant (no offence intended!). All that counts is Projects and their Authors, Committers and Reviewers. Regardless of whether this is a "build" change or a "serviceability" change, the repositories are in the jdk8 forest and so belong to the jdk8 project. Consequently it is the roles in that project which count. The JDK8 project page makes no mention of any Reviewer requirements, but the fact the Reviewers exist means that formal review is necessary. Arguably all discussion of changes intended for jdk8 should be held on the jdk8-dev mailing list. David > Dan > > > >> Some groups have forests for integration changes into the primary >> releases, like jdk8 right now. >> >> I am the lead on the build "group" and I can speak to that. >> >> For jdk8 build changes, those being pushed into jdk8 (or the >> http://hg.openjdk.java.net/jdk8/build forest) >> only one reviewer is generally required, I have not heard anything >> about more than one, although more >> is always better, especially if there is any paranoia over the changes. >> In this case, and with most build changes, someone should verify that >> all platforms still build ok. >> >> It will be important that you create the changeset using the latest >> jdk8 build >> forest, e.g. using a clones from http://hg.openjdk.java.net/jdk8/build >> Once you are happy that the change is ok on your system, then bundle >> up the changeset >> with 'hg bundle' and I will run it through our internal JPRT build >> system to insure all build >> platforms are ok, then I can push it into the >> http://hg.openjdk.java.net/jdk8/build repos. >> >> -kto >> >> On Nov 2, 2011, at 11:54 AM, Neil Richards wrote: >> >>> On Wed, 2011-11-02 at 14:07 -0400, Zhengyu Gu wrote: >>>> Hi Neil, >>>> >>>> My understanding is that you need to have at least two reviewers who >>>> have 'reviewer' privilege, (and I don't have 'reviewer' privilege). >>>> >>> I had a quick leaf through the OpenJDK Bylaws. >>> It looks like the number of necessary approvals from 'reviewers' vs >>> 'committers' (vs anyone else) is project-specific, so it isn't directly >>> defined there. >>> >>> Now you raise it, I wasn't able to track down where in the JDK 8 project >>> documentation this is defined either. >>> >>> The log of (at least) the jdk repository suggests that this limit isn't >>> universally applied (though in many cases, the submitter is of >>> 'reviewer' status themselves - perhaps that counts towards the total ?). >>> >>> Kelly, can you give guidance / pointers here ? >>> (So far, this change has found favor by one 'reviewer' - you - and two >>> 'committers' - Zhengyu and myself). >>> >>>> Yes, I am tied up, if you can handle the push, that will be great. What >>>> java bug id you need? can you use CR 6988099? >>>> >>> Doh! Of course I can. >>> (I blame it all on coding-blindness - that's the same as snow-blindness, >>> but in hex). >>> >>> Regards, Neil >>> >>> -- >>> Unless stated above: >>> IBM email: neil_richards at uk.ibm.com >>> IBM United Kingdom Limited - Registered in England and Wales with >>> number 741598. >>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire >>> PO6 3AU >>> >> From neil.richards at ngmr.net Thu Nov 3 17:02:04 2011 From: neil.richards at ngmr.net (Neil Richards) Date: Thu, 03 Nov 2011 17:02:04 +0000 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> <1320255428.10693.16.camel@chalkhill> <4EB186D1.1080804@oracle.com> <1320260087.11068.37.camel@chalkhill> Message-ID: <1320339724.11068.66.camel@chalkhill> On Wed, 2011-11-02 at 12:29 -0700, Kelly O'Hair wrote: > It will be important that you create the changeset using the latest jdk8 build > forest, e.g. using a clones from http://hg.openjdk.java.net/jdk8/build > Once you are happy that the change is ok on your system, then bundle up the changeset > with 'hg bundle' and I will run it through our internal JPRT build system to insure all build > platforms are ok, then I can push it into the http://hg.openjdk.java.net/jdk8/build repos. > > -kto Hi Kelly, Thank you for your kind offer. Please find attached the bundled form of the agreed fix (as made against http://hg.openjdk.java.net/jdk8/build/jdk ). (I've also included it below in plain hexdump form, from 'xxd -p', just in case the attachment gets mysteriously stripped.) Regards, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU 48473130425a683931415926535903cd019c00000a7ffffe705365ff6fff f77fbfdff5fffffffe3815850596806895c01942580e605cd340029cad05 b68c0d52626a69ea699064d068f51a03400d00c8d007a9a3d4000d00069a 3200f50d0d340d343353d3420d4298a794f227a9e93d23d11ea068000034 3406834034000340001a0000000002064c118020d3011a608d0313119301 184698984301321a310d189823098013000d100802126c4629934f50f44f 48686991a000d01a0d0304640034d3419308680034341bc7ae4efb97be61 16662f974f47b72b70a1c848291e3c8798f9b080271da032a6642fb54820 6a1e9469ba1dae1415d669b0e8048cd9a30d62e2ec4c23d2ba0337f75eab 40d086d6b7aa43300876c80eb40864e82a0f82de5ae3cc7faa83e72f0a28 e0d9a16f5718c5fc95854eac9ca9d7bf90d223b7b3b8eecade1e2c7e294b a605aa02a90c04d71ae40c202dc7d0048e5199106824a2d02ca631cc4664 41060f141f7312aedc03cc369b1cec8f8db9aa646e04991622e6aac5a8c5 c3db63554707275f8ce734d7e380dcf9a70c08b677519b679ce5c309e349 2be88a06381afaeb4b31d1fe79cd540e589b7124e5220b59cb8d0a7e4c12 4d2c733ae5ad8f280a39c07bef0baa5e0b924886e877c055e19c681b7655 d2dc94c70f090854583f801fbd12b7925939404b8007980b1258346217c2 50124a3be01fca9fcd24240f8d6cb29a28d126493418a455292a57ea00b3 6a0ab289f659b40509ca45981c268a3fa9fed01f9e4cf3db2215445102c4 3ee5f84970106a84722146e55d86a1caaa913d74136c45e0a01286d83d41 7e25c854d0a2d7011c07470696ee2036231b0c96e4b825b9b7c69594e553 b18a1caf31865845c10749974113808177e759e409e1084010584f3ea171 aed62853d1a932f48c45b264c0f5a037c511334cb928bd66d56747888483 0428e76894034b9df8dd157a1c045f9795d114671c89c0994db3c6539646 a551c4a1205ea6a2a867665b471c59052b8aa00c230a141aba8641cc0901 661e5202cdd6064a1580308256aeaa455b207620452994d63da0a8d4c098 9915a18926e5b6a0802102c9e98a0879a9742c892ca7d28684bbbef574ac 537223d2624ade20ac09bbb766306ab41924d85f1d104f810d28d2228112 d404d0f6021909cc4a5215a0f257157a4acf628c1dda12d2486c01193bc0 f54c05998058a6f00611f7fb940399ac93f9020cf8f1254a44089854bfe2 ee48a70a120079a03380 -------------- next part -------------- A non-text attachment was scrubbed... Name: j6988099.jdk.bundle Type: application/octet-stream Size: 910 bytes Desc: not available URL: From kelly.ohair at oracle.com Thu Nov 3 22:42:23 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 3 Nov 2011 15:42:23 -0700 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: <1320339724.11068.66.camel@chalkhill> References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> <1320255428.10693.16.camel@chalkhill> <4EB186D1.1080804@oracle.com> <1320260087.11068.37.camel@chalkhill> <1320339724.11068.66.camel@chalkhill> Message-ID: <0906BF08-9943-48F1-B690-1AA84B4162C4@oracle.com> Checking out the change now. -kto On Nov 3, 2011, at 10:02 AM, Neil Richards wrote: > On Wed, 2011-11-02 at 12:29 -0700, Kelly O'Hair wrote: >> It will be important that you create the changeset using the latest jdk8 build >> forest, e.g. using a clones from http://hg.openjdk.java.net/jdk8/build >> Once you are happy that the change is ok on your system, then bundle up the changeset >> with 'hg bundle' and I will run it through our internal JPRT build system to insure all build >> platforms are ok, then I can push it into the http://hg.openjdk.java.net/jdk8/build repos. >> >> -kto > > Hi Kelly, > Thank you for your kind offer. > Please find attached the bundled form of the agreed fix (as made against > http://hg.openjdk.java.net/jdk8/build/jdk ). > > (I've also included it below in plain hexdump form, from 'xxd -p', just > in case the attachment gets mysteriously stripped.) > > Regards, Neil > > -- > Unless stated above: > IBM email: neil_richards at uk.ibm.com > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > 48473130425a683931415926535903cd019c00000a7ffffe705365ff6fff > f77fbfdff5fffffffe3815850596806895c01942580e605cd340029cad05 > b68c0d52626a69ea699064d068f51a03400d00c8d007a9a3d4000d00069a > 3200f50d0d340d343353d3420d4298a794f227a9e93d23d11ea068000034 > 3406834034000340001a0000000002064c118020d3011a608d0313119301 > 184698984301321a310d189823098013000d100802126c4629934f50f44f > 48686991a000d01a0d0304640034d3419308680034341bc7ae4efb97be61 > 16662f974f47b72b70a1c848291e3c8798f9b080271da032a6642fb54820 > 6a1e9469ba1dae1415d669b0e8048cd9a30d62e2ec4c23d2ba0337f75eab > 40d086d6b7aa43300876c80eb40864e82a0f82de5ae3cc7faa83e72f0a28 > e0d9a16f5718c5fc95854eac9ca9d7bf90d223b7b3b8eecade1e2c7e294b > a605aa02a90c04d71ae40c202dc7d0048e5199106824a2d02ca631cc4664 > 41060f141f7312aedc03cc369b1cec8f8db9aa646e04991622e6aac5a8c5 > c3db63554707275f8ce734d7e380dcf9a70c08b677519b679ce5c309e349 > 2be88a06381afaeb4b31d1fe79cd540e589b7124e5220b59cb8d0a7e4c12 > 4d2c733ae5ad8f280a39c07bef0baa5e0b924886e877c055e19c681b7655 > d2dc94c70f090854583f801fbd12b7925939404b8007980b1258346217c2 > 50124a3be01fca9fcd24240f8d6cb29a28d126493418a455292a57ea00b3 > 6a0ab289f659b40509ca45981c268a3fa9fed01f9e4cf3db2215445102c4 > 3ee5f84970106a84722146e55d86a1caaa913d74136c45e0a01286d83d41 > 7e25c854d0a2d7011c07470696ee2036231b0c96e4b825b9b7c69594e553 > b18a1caf31865845c10749974113808177e759e409e1084010584f3ea171 > aed62853d1a932f48c45b264c0f5a037c511334cb928bd66d56747888483 > 0428e76894034b9df8dd157a1c045f9795d114671c89c0994db3c6539646 > a551c4a1205ea6a2a867665b471c59052b8aa00c230a141aba8641cc0901 > 661e5202cdd6064a1580308256aeaa455b207620452994d63da0a8d4c098 > 9915a18926e5b6a0802102c9e98a0879a9742c892ca7d28684bbbef574ac > 537223d2624ade20ac09bbb766306ab41924d85f1d104f810d28d2228112 > d404d0f6021909cc4a5215a0f257157a4acf628c1dda12d2486c01193bc0 > f54c05998058a6f00611f7fb940399ac93f9020cf8f1254a44089854bfe2 > ee48a70a120079a03380 > > From michael.fang at sun.com Fri Nov 4 00:41:08 2011 From: michael.fang at sun.com (michael.fang at sun.com) Date: Fri, 04 Nov 2011 00:41:08 +0000 Subject: hg: jdk8/build/jdk: 6 new changesets Message-ID: <20111104004206.B80724722F@hg.openjdk.java.net> Changeset: bfd720647db2 Author: yhuang Date: 2011-10-31 20:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bfd720647db2 7077119: remove past transition dates from CurrencyData.properties file Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! test/java/util/Currency/CurrencyTest.java ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Currency/tablea1.txt Changeset: cfc6fd491b97 Author: yhuang Date: 2011-10-31 21:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cfc6fd491b97 6755060: Collator.compare() does not compare correctly for the Thai locale Reviewed-by: naoto ! src/share/classes/sun/text/resources/CollationData_th.java + test/sun/text/resources/Collator/Bug6755060.java Changeset: 0549410acf26 Author: yhuang Date: 2011-10-31 21:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0549410acf26 Merge Changeset: f3227efde13d Author: yhuang Date: 2011-10-31 21:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f3227efde13d 7101495: In Latvia first day of week is Monday Reviewed-by: naoto, peytoia ! src/share/classes/sun/util/resources/CalendarData_lv.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: ab837acc60fb Author: yhuang Date: 2011-10-31 21:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ab837acc60fb Merge Changeset: 631ee738378a Author: mfang Date: 2011-11-03 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/631ee738378a Merge From kelly.ohair at oracle.com Fri Nov 4 16:21:07 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 4 Nov 2011 09:21:07 -0700 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: <1320339724.11068.66.camel@chalkhill> References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> <1320255428.10693.16.camel@chalkhill> <4EB186D1.1080804@oracle.com> <1320260087.11068.37.camel@chalkhill> <1320339724.11068.66.camel@chalkhill> Message-ID: <5B48D1C4-25C1-4199-A53F-627E149E982D@oracle.com> Builds on all platforms looked ok, it's in the pipeline, should be pushed into http://hg.openjdk.java.net/jdk8/build/jdk today, and then be integrated into the master jdk8 area in the next week. I'll be traveling next week so won;t be able to check on the integration until after that. Thanks for the contribution, hopefully as the bug tracking system become open and we can create a build&test system accessible to all openjdk contributors this will get easier for everyone. -kto On Nov 3, 2011, at 10:02 AM, Neil Richards wrote: > On Wed, 2011-11-02 at 12:29 -0700, Kelly O'Hair wrote: >> It will be important that you create the changeset using the latest jdk8 build >> forest, e.g. using a clones from http://hg.openjdk.java.net/jdk8/build >> Once you are happy that the change is ok on your system, then bundle up the changeset >> with 'hg bundle' and I will run it through our internal JPRT build system to insure all build >> platforms are ok, then I can push it into the http://hg.openjdk.java.net/jdk8/build repos. >> >> -kto > > Hi Kelly, > Thank you for your kind offer. > Please find attached the bundled form of the agreed fix (as made against > http://hg.openjdk.java.net/jdk8/build/jdk ). > > (I've also included it below in plain hexdump form, from 'xxd -p', just > in case the attachment gets mysteriously stripped.) > > Regards, Neil > > -- > Unless stated above: > IBM email: neil_richards at uk.ibm.com > IBM United Kingdom Limited - Registered in England and Wales with number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > > > 48473130425a683931415926535903cd019c00000a7ffffe705365ff6fff > f77fbfdff5fffffffe3815850596806895c01942580e605cd340029cad05 > b68c0d52626a69ea699064d068f51a03400d00c8d007a9a3d4000d00069a > 3200f50d0d340d343353d3420d4298a794f227a9e93d23d11ea068000034 > 3406834034000340001a0000000002064c118020d3011a608d0313119301 > 184698984301321a310d189823098013000d100802126c4629934f50f44f > 48686991a000d01a0d0304640034d3419308680034341bc7ae4efb97be61 > 16662f974f47b72b70a1c848291e3c8798f9b080271da032a6642fb54820 > 6a1e9469ba1dae1415d669b0e8048cd9a30d62e2ec4c23d2ba0337f75eab > 40d086d6b7aa43300876c80eb40864e82a0f82de5ae3cc7faa83e72f0a28 > e0d9a16f5718c5fc95854eac9ca9d7bf90d223b7b3b8eecade1e2c7e294b > a605aa02a90c04d71ae40c202dc7d0048e5199106824a2d02ca631cc4664 > 41060f141f7312aedc03cc369b1cec8f8db9aa646e04991622e6aac5a8c5 > c3db63554707275f8ce734d7e380dcf9a70c08b677519b679ce5c309e349 > 2be88a06381afaeb4b31d1fe79cd540e589b7124e5220b59cb8d0a7e4c12 > 4d2c733ae5ad8f280a39c07bef0baa5e0b924886e877c055e19c681b7655 > d2dc94c70f090854583f801fbd12b7925939404b8007980b1258346217c2 > 50124a3be01fca9fcd24240f8d6cb29a28d126493418a455292a57ea00b3 > 6a0ab289f659b40509ca45981c268a3fa9fed01f9e4cf3db2215445102c4 > 3ee5f84970106a84722146e55d86a1caaa913d74136c45e0a01286d83d41 > 7e25c854d0a2d7011c07470696ee2036231b0c96e4b825b9b7c69594e553 > b18a1caf31865845c10749974113808177e759e409e1084010584f3ea171 > aed62853d1a932f48c45b264c0f5a037c511334cb928bd66d56747888483 > 0428e76894034b9df8dd157a1c045f9795d114671c89c0994db3c6539646 > a551c4a1205ea6a2a867665b471c59052b8aa00c230a141aba8641cc0901 > 661e5202cdd6064a1580308256aeaa455b207620452994d63da0a8d4c098 > 9915a18926e5b6a0802102c9e98a0879a9742c892ca7d28684bbbef574ac > 537223d2624ade20ac09bbb766306ab41924d85f1d104f810d28d2228112 > d404d0f6021909cc4a5215a0f257157a4acf628c1dda12d2486c01193bc0 > f54c05998058a6f00611f7fb940399ac93f9020cf8f1254a44089854bfe2 > ee48a70a120079a03380 > > From kelly.ohair at oracle.com Fri Nov 4 17:34:32 2011 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 04 Nov 2011 17:34:32 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20111104173511.99CEE47243@hg.openjdk.java.net> Changeset: 94e5604022fa Author: ngmr Date: 2011-09-15 19:29 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/94e5604022fa 6988099: jvmti demos missing Publisher (COMPANY resource) in dlls/exes on windows Summary: Add creation/linking of resource data to link step for demos on Windows Reviewed-by: dcubed, zgu, ngmr, ohair Contributed-by: Sean Chou ! make/common/Demo.gmk Changeset: 5791714b9472 Author: ohair Date: 2011-11-04 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5791714b9472 Merge From zhouyx at linux.vnet.ibm.com Mon Nov 7 02:48:23 2011 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Mon, 7 Nov 2011 10:48:23 +0800 Subject: Code Review Request: CR 6988099 Add version information to jvmti demos. In-Reply-To: <5B48D1C4-25C1-4199-A53F-627E149E982D@oracle.com> References: <4DED9417.3000805@oracle.com> <4DEE4D61.3010507@oracle.com> <4DEF84AE.9050000@oracle.com> <4E722464.9020701@oracle.com> <1316112695.19296.14.camel@chalkhill> <4E7265DF.4090300@oracle.com> <4E85C3F6.3000602@oracle.com> <8947DC8D-531B-4AB8-B0B5-F99C0C105026@oracle.com> <1320255428.10693.16.camel@chalkhill> <4EB186D1.1080804@oracle.com> <1320260087.11068.37.camel@chalkhill> <1320339724.11068.66.camel@chalkhill> <5B48D1C4-25C1-4199-A53F-627E149E982D@oracle.com> Message-ID: Thanks for everyone bothered by the thread ! On Sat, Nov 5, 2011 at 12:21 AM, Kelly O'Hair wrote: > Builds on all platforms looked ok, it's in the pipeline, should be pushed > into > http://hg.openjdk.java.net/jdk8/build/jdk today, and then be integrated > into the master jdk8 area > in the next week. > > I'll be traveling next week so won;t be able to check on the integration > until after that. > > Thanks for the contribution, hopefully as the bug tracking system become > open and we can create a > build&test system accessible to all openjdk contributors this will get > easier for everyone. > > -kto > > On Nov 3, 2011, at 10:02 AM, Neil Richards wrote: > > > On Wed, 2011-11-02 at 12:29 -0700, Kelly O'Hair wrote: > >> It will be important that you create the changeset using the latest > jdk8 build > >> forest, e.g. using a clones from http://hg.openjdk.java.net/jdk8/build > >> Once you are happy that the change is ok on your system, then bundle up > the changeset > >> with 'hg bundle' and I will run it through our internal JPRT build > system to insure all build > >> platforms are ok, then I can push it into the > http://hg.openjdk.java.net/jdk8/build repos. > >> > >> -kto > > > > Hi Kelly, > > Thank you for your kind offer. > > Please find attached the bundled form of the agreed fix (as made against > > http://hg.openjdk.java.net/jdk8/build/jdk ). > > > > (I've also included it below in plain hexdump form, from 'xxd -p', just > > in case the attachment gets mysteriously stripped.) > > > > Regards, Neil > > > > -- > > Unless stated above: > > IBM email: neil_richards at uk.ibm.com > > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 > 3AU > > > > > > 48473130425a683931415926535903cd019c00000a7ffffe705365ff6fff > > f77fbfdff5fffffffe3815850596806895c01942580e605cd340029cad05 > > b68c0d52626a69ea699064d068f51a03400d00c8d007a9a3d4000d00069a > > 3200f50d0d340d343353d3420d4298a794f227a9e93d23d11ea068000034 > > 3406834034000340001a0000000002064c118020d3011a608d0313119301 > > 184698984301321a310d189823098013000d100802126c4629934f50f44f > > 48686991a000d01a0d0304640034d3419308680034341bc7ae4efb97be61 > > 16662f974f47b72b70a1c848291e3c8798f9b080271da032a6642fb54820 > > 6a1e9469ba1dae1415d669b0e8048cd9a30d62e2ec4c23d2ba0337f75eab > > 40d086d6b7aa43300876c80eb40864e82a0f82de5ae3cc7faa83e72f0a28 > > e0d9a16f5718c5fc95854eac9ca9d7bf90d223b7b3b8eecade1e2c7e294b > > a605aa02a90c04d71ae40c202dc7d0048e5199106824a2d02ca631cc4664 > > 41060f141f7312aedc03cc369b1cec8f8db9aa646e04991622e6aac5a8c5 > > c3db63554707275f8ce734d7e380dcf9a70c08b677519b679ce5c309e349 > > 2be88a06381afaeb4b31d1fe79cd540e589b7124e5220b59cb8d0a7e4c12 > > 4d2c733ae5ad8f280a39c07bef0baa5e0b924886e877c055e19c681b7655 > > d2dc94c70f090854583f801fbd12b7925939404b8007980b1258346217c2 > > 50124a3be01fca9fcd24240f8d6cb29a28d126493418a455292a57ea00b3 > > 6a0ab289f659b40509ca45981c268a3fa9fed01f9e4cf3db2215445102c4 > > 3ee5f84970106a84722146e55d86a1caaa913d74136c45e0a01286d83d41 > > 7e25c854d0a2d7011c07470696ee2036231b0c96e4b825b9b7c69594e553 > > b18a1caf31865845c10749974113808177e759e409e1084010584f3ea171 > > aed62853d1a932f48c45b264c0f5a037c511334cb928bd66d56747888483 > > 0428e76894034b9df8dd157a1c045f9795d114671c89c0994db3c6539646 > > a551c4a1205ea6a2a867665b471c59052b8aa00c230a141aba8641cc0901 > > 661e5202cdd6064a1580308256aeaa455b207620452994d63da0a8d4c098 > > 9915a18926e5b6a0802102c9e98a0879a9742c892ca7d28684bbbef574ac > > 537223d2624ade20ac09bbb766306ab41924d85f1d104f810d28d2228112 > > d404d0f6021909cc4a5215a0f257157a4acf628c1dda12d2486c01193bc0 > > f54c05998058a6f00611f7fb940399ac93f9020cf8f1254a44089854bfe2 > > ee48a70a120079a03380 > > > > > > -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: From zhouyx at linux.vnet.ibm.com Mon Nov 7 03:28:21 2011 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Mon, 7 Nov 2011 11:28:21 +0800 Subject: Successfully building 32- and 64-bit OpenJDK 8 on WinXP/64bit with free tools only In-Reply-To: References: Message-ID: Hi Volker, I would like to know have you tried to run gui application with the build on another windows machine which doesn't have freetype.dll installed ? I had built jdk on windows but found that it can run gui applications in the machine built it, but cann't run gui application in machines without freetype installed. On Sat, Oct 29, 2011 at 2:19 AM, Volker Simonis wrote: > Hi, > > I've put together a short description on how to build both, a 64- and > a 32-bit version of OpenJDK 8 on a plain, vanilla WindowsXP 64-bit > operating system using only free (as in free beer) tools: > > > http://weblogs.java.net/blog/simonis/archive/2011/10/28/yaojowbi-yet-another-openjdk-windows-build-instruction > > It seems as if it is not that hard anymore nowadays:) > > Regards, > Volker > -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: From volker.simonis at gmail.com Mon Nov 7 14:36:24 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 7 Nov 2011 15:36:24 +0100 Subject: Successfully building 32- and 64-bit OpenJDK 8 on WinXP/64bit with free tools only In-Reply-To: References: Message-ID: Hi Sean, for me it seems to work! I've just copied the created j2sdk-image directory to a Win2003 machine and run the demo\jfc\Font2DTest\Font2DTest.jar demo without any problems. As far as I can see, the "freetype.dll" is available within the JDK-image at j2sdk-image\jre\bin\freetype.dll. Had you build the images and copied these images to the new host when you run into the problems? Regards, Volker On Mon, Nov 7, 2011 at 4:28 AM, Sean Chou wrote: > Hi Volker, > ? ? I would like to know have you tried to run gui application with the > build on another > windows machine?which doesn't have freetype.dll installed ? ?I had built jdk > on > windows but found that it can?run gui applications in the machine built it, > but cann't > run gui application in machines?without freetype installed. > > On Sat, Oct 29, 2011 at 2:19 AM, Volker Simonis > wrote: >> >> Hi, >> >> I've put together a short description on how to build both, a 64- and >> a 32-bit version of OpenJDK 8 on a plain, vanilla WindowsXP 64-bit >> operating system using only free (as in free beer) tools: >> >> >> http://weblogs.java.net/blog/simonis/archive/2011/10/28/yaojowbi-yet-another-openjdk-windows-build-instruction >> >> It seems as if ?it is not that hard anymore nowadays:) >> >> Regards, >> Volker > > > > -- > Best Regards, > Sean Chou > > From philip.race at oracle.com Mon Nov 7 17:19:21 2011 From: philip.race at oracle.com (Phil Race) Date: Mon, 07 Nov 2011 09:19:21 -0800 Subject: Successfully building 32- and 64-bit OpenJDK 8 on WinXP/64bit with free tools only In-Reply-To: References: Message-ID: <4EB81319.4090809@oracle.com> Sean, I am not sure what you mean by "installed" - installed into \windows\system32 or installed in the JRE bin directory? But the latter is the only way its supposed to work, and the build should take the copy of freetype.dll you provide to it, and copy it to that location. At runtime, freetype is treated like any other JRE provided DLL, such as awt.dll, net.dll, etc. The difference is only at build time, since the openjdk sources don't contain the freetype sources. You need to build it separately. -phil. On 11/6/2011 7:28 PM, Sean Chou wrote: > Hi Volker, > > I would like to know have you tried to run gui application with > the build on another > windows machine which doesn't have freetype.dll installed ? I had > built jdk on > windows but found that it can run gui applications in the machine > built it, but cann't > run gui application in machines without freetype installed. > > > On Sat, Oct 29, 2011 at 2:19 AM, Volker Simonis > > wrote: > > Hi, > > I've put together a short description on how to build both, a 64- and > a 32-bit version of OpenJDK 8 on a plain, vanilla WindowsXP 64-bit > operating system using only free (as in free beer) tools: > > http://weblogs.java.net/blog/simonis/archive/2011/10/28/yaojowbi-yet-another-openjdk-windows-build-instruction > > It seems as if it is not that hard anymore nowadays:) > > Regards, > Volker > > > > > -- > Best Regards, > Sean Chou > From zhouyx at linux.vnet.ibm.com Tue Nov 8 06:38:07 2011 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Tue, 8 Nov 2011 14:38:07 +0800 Subject: Successfully building 32- and 64-bit OpenJDK 8 on WinXP/64bit with free tools only In-Reply-To: <4EB81319.4090809@oracle.com> References: <4EB81319.4090809@oracle.com> Message-ID: Hi Phil, The situation I found is strange: the JDK we build works well on windows which have the building environment. Eg. machine1 and machine2 both can build windows openjdk. If I copy a jdk built on machine1 to machine2, it works well. If machine3 doesn't have the build environment, it reports error about freetype.dll. I haven't investigate the problem, however the freetype.dll is there with awt.dll. So I guessed it was something related to freetype.dll installation. The attachment is the error information. On Tue, Nov 8, 2011 at 1:19 AM, Phil Race wrote: > Sean, > > I am not sure what you mean by "installed" - installed into > \windows\system32 > or installed in the JRE bin directory? But the latter is the only way its > supposed to > work, and the build should take the copy of freetype.dll you provide to > it, and > copy it to that location. At runtime, freetype is treated like any other > JRE provided > DLL, such as awt.dll, net.dll, etc. The difference is only at build time, > since the openjdk > sources don't contain the freetype sources. You need to build it > separately. > > -phil. > > > On 11/6/2011 7:28 PM, Sean Chou wrote: > >> Hi Volker, >> >> I would like to know have you tried to run gui application with the >> build on another >> windows machine which doesn't have freetype.dll installed ? I had built >> jdk on >> windows but found that it can run gui applications in the machine built >> it, but cann't >> run gui application in machines without freetype installed. >> >> >> On Sat, Oct 29, 2011 at 2:19 AM, Volker Simonis > volker.simonis at gmail.**com >> wrote: >> >> Hi, >> >> I've put together a short description on how to build both, a 64- and >> a 32-bit version of OpenJDK 8 on a plain, vanilla WindowsXP 64-bit >> operating system using only free (as in free beer) tools: >> >> http://weblogs.java.net/blog/**simonis/archive/2011/10/28/** >> yaojowbi-yet-another-openjdk-**windows-build-instruction >> >> It seems as if it is not that hard anymore nowadays:) >> >> Regards, >> Volker >> >> >> >> >> -- >> Best Regards, >> Sean Chou >> >> > -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: error.log Type: application/octet-stream Size: 3637 bytes Desc: not available URL: From zhouyx at linux.vnet.ibm.com Tue Nov 8 06:42:12 2011 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Tue, 8 Nov 2011 14:42:12 +0800 Subject: Successfully building 32- and 64-bit OpenJDK 8 on WinXP/64bit with free tools only In-Reply-To: References: Message-ID: That's great ! Yes. We went into the problem when copied the image to a windows without building environment. On Mon, Nov 7, 2011 at 10:36 PM, Volker Simonis wrote: > Hi Sean, > > for me it seems to work! > > I've just copied the created j2sdk-image directory to a Win2003 > machine and run the demo\jfc\Font2DTest\Font2DTest.jar demo without > any problems. As far as I can see, the "freetype.dll" is available > within the JDK-image at j2sdk-image\jre\bin\freetype.dll. > > Had you build the images and copied these images to the new host when > you run into the problems? > > Regards, > Volker > > On Mon, Nov 7, 2011 at 4:28 AM, Sean Chou > wrote: > > Hi Volker, > > I would like to know have you tried to run gui application with the > > build on another > > windows machine which doesn't have freetype.dll installed ? I had built > jdk > > on > > windows but found that it can run gui applications in the machine built > it, > > but cann't > > run gui application in machines without freetype installed. > > > > On Sat, Oct 29, 2011 at 2:19 AM, Volker Simonis < > volker.simonis at gmail.com> > > wrote: > >> > >> Hi, > >> > >> I've put together a short description on how to build both, a 64- and > >> a 32-bit version of OpenJDK 8 on a plain, vanilla WindowsXP 64-bit > >> operating system using only free (as in free beer) tools: > >> > >> > >> > http://weblogs.java.net/blog/simonis/archive/2011/10/28/yaojowbi-yet-another-openjdk-windows-build-instruction > >> > >> It seems as if it is not that hard anymore nowadays:) > >> > >> Regards, > >> Volker > > > > > > > > -- > > Best Regards, > > Sean Chou > > > > > -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: From volker.simonis at gmail.com Tue Nov 8 08:32:43 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 8 Nov 2011 09:32:43 +0100 Subject: Successfully building 32- and 64-bit OpenJDK 8 on WinXP/64bit with free tools only In-Reply-To: References: <4EB81319.4090809@oracle.com> Message-ID: Hi Sean, looking at your error.log I think you have a different problem: Caused by: java.lang.UnsatisfiedLinkError: C:\Users\zhouyx\Desktop\j2sdk-image\j re\bin\freetype.dll: Can't find dependent libraries This means that freetype.dll was found, but another library which freetype.dll is dependent on could not be located on the new system. You can check with a tool like for example "DependencyWalker" (http://www.dependencywalker.com/) on which other libraries freetype.dll is dependent on. As far as I can see on my system, the dependencies are not exceptional: t:\sapjvm_dev\d046063\j2sdk-image\jre\bin\FREETYPE.DLL |-->c:\windows\system32\KERNEL32.DLL |-->c:\windows\system32\NTDLL.DLL Hope this helps, Volker On Tue, Nov 8, 2011 at 7:38 AM, Sean Chou wrote: > ?Hi Phil, > ? ? The situation I found is strange: the JDK we build works well on windows > which > have the building environment. Eg. machine1 and machine2 both can build > windows > openjdk. If I copy a jdk built on machine1 to machine2, it works well. If > machine3 > doesn't have the build environment,?it reports error about freetype.dll. > ? ??I haven't investigate the problem,??however the freetype.dll?is there > with awt.dll. So I guessed it was something related?to freetype.dll > installation. > ? ? The attachment is the error information. > On Tue, Nov 8, 2011 at 1:19 AM, Phil Race wrote: >> >> Sean, >> >> I am not sure what you mean by "installed" - installed into >> \windows\system32 >> or installed in the JRE bin directory? ?But the latter is the only way its >> supposed to >> work, and the build should take the copy of freetype.dll you provide to >> it, and >> copy it to that location. At runtime, freetype is treated like any other >> JRE provided >> DLL, such as awt.dll, net.dll, etc. The difference is only at build time, >> since the openjdk >> sources don't contain the freetype sources. You need to build it >> separately. >> >> -phil. >> >> On 11/6/2011 7:28 PM, Sean Chou wrote: >>> >>> Hi Volker, >>> >>> ? ?I would like to know have you tried to run gui application with the >>> build on another >>> windows machine which doesn't have freetype.dll installed ? ?I had built >>> jdk on >>> windows but found that it can run gui applications in the machine built >>> it, but cann't >>> run gui application in machines without freetype installed. >>> >>> >>> On Sat, Oct 29, 2011 at 2:19 AM, Volker Simonis >> > wrote: >>> >>> ? ?Hi, >>> >>> ? ?I've put together a short description on how to build both, a 64- and >>> ? ?a 32-bit version of OpenJDK 8 on a plain, vanilla WindowsXP 64-bit >>> ? ?operating system using only free (as in free beer) tools: >>> >>> >>> ?http://weblogs.java.net/blog/simonis/archive/2011/10/28/yaojowbi-yet-another-openjdk-windows-build-instruction >>> >>> ? ?It seems as if ?it is not that hard anymore nowadays:) >>> >>> ? ?Regards, >>> ? ?Volker >>> >>> >>> >>> >>> -- >>> Best Regards, >>> Sean Chou >>> >> > > > > -- > Best Regards, > Sean Chou > > From volker.simonis at gmail.com Tue Nov 8 10:30:58 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 8 Nov 2011 11:30:58 +0100 Subject: Where have all the "fastdebug" builds gone? Message-ID: Hi, I could have sworn that http://jdk6.java.net/download.html and http://jdk7.java.net/download.html always contained product AND "fastdebug" builds, but as I just verified today there are no more "fastdebug" builds available neither for JDK6 nor for JDK7 and JDK8. Is this intentional? Is there any other source for debug builds of the original Oracle JDK? The debug builds have always been very useful to track down problems, especially because many of the diagnostic VM options are only available in debug builds. Regards, Volker From Ulf.Zibis at gmx.de Tue Nov 8 11:08:39 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 08 Nov 2011 12:08:39 +0100 Subject: Where have all the "fastdebug" builds gone? In-Reply-To: References: Message-ID: <4EB90DB7.6020006@gmx.de> Hi Volker, maybe you find some answers here: http://news.gmane.org/gmane.comp.java.openjdk.website/cutoff=297 http://markmail.org/search/?q=list%3Anet.java.openjdk#query:%20list%3Anet.java.openjdk.web-discuss+page:1+mid:hpggicgvoyuuezvi+state:results http://mail.openjdk.java.net/pipermail/web-discuss/2011-October/thread.html -Ulf Am 08.11.2011 11:30, schrieb Volker Simonis: > Hi, > > I could have sworn that > > http://jdk6.java.net/download.html and > http://jdk7.java.net/download.html > > always contained product AND "fastdebug" builds, but as I just > verified today there are no more "fastdebug" builds available neither > for JDK6 nor for JDK7 and JDK8. > > Is this intentional? > Is there any other source for debug builds of the original Oracle JDK? > > The debug builds have always been very useful to track down problems, > especially because many of the diagnostic VM options are only > available in debug builds. > > Regards, > Volker > From volker.simonis at gmail.com Tue Nov 8 11:46:36 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 8 Nov 2011 12:46:36 +0100 Subject: Where have all the "fastdebug" builds gone? In-Reply-To: <4EB90DB7.6020006@gmx.de> References: <4EB90DB7.6020006@gmx.de> Message-ID: Just to be clear: - I know that this an OpenJDK mailing list - I know that http://jdk[6,7,8].java.net/download.html contains Oracle JDK binaries - I know I can build OpenJDK fastdebug build myself (even on Windows:) But I just thought that some of the Oracle folks on this list may know why 6u25 is the only release for which the download page currently offers debug builds: http://download.java.net/jdk6/6u25/promoted/b03/index.html while this is not the case for any other release (nor before 6u25 and neither after 6u25) Thank you and best regards, Volker On Tue, Nov 8, 2011 at 12:08 PM, Ulf Zibis wrote: > Hi Volker, > > maybe you find some answers here: > http://news.gmane.org/gmane.comp.java.openjdk.website/cutoff=297 > http://markmail.org/search/?q=list%3Anet.java.openjdk#query:%20list%3Anet.java.openjdk.web-discuss+page:1+mid:hpggicgvoyuuezvi+state:results > http://mail.openjdk.java.net/pipermail/web-discuss/2011-October/thread.html > > -Ulf > > > > Am 08.11.2011 11:30, schrieb Volker Simonis: >> >> Hi, >> >> I could have sworn that >> >> http://jdk6.java.net/download.html and >> http://jdk7.java.net/download.html >> >> always contained product AND "fastdebug" builds, but as I just >> verified today there are no more "fastdebug" builds available neither >> for JDK6 nor for JDK7 and JDK8. >> >> Is this intentional? >> Is there any other source for debug builds of the original Oracle JDK? >> >> The debug builds have always been very useful to track down problems, >> especially because many of the diagnostic VM options are only >> available in debug builds. >> >> Regards, >> Volker >> > From Ulf.Zibis at gmx.de Tue Nov 8 12:38:25 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 08 Nov 2011 13:38:25 +0100 Subject: Where have all the "fastdebug" builds gone? In-Reply-To: References: <4EB90DB7.6020006@gmx.de> Message-ID: <4EB922C1.5070305@gmx.de> Hi Volker, thanks for your clarification in brief words. That's exactly what me irritates too. I would be so convenient, having some debug builds somewhere to download, ready for use. To be exact, the 6u25 fastdebug binary, you have mentioned, is not a release version, it's an EA version. -Ulf Am 08.11.2011 12:46, schrieb Volker Simonis: > Just to be clear: > - I know that this an OpenJDK mailing list > - I know that http://jdk[6,7,8].java.net/download.html contains Oracle > JDK binaries > - I know I can build OpenJDK fastdebug build myself (even on Windows:) > > But I just thought that some of the Oracle folks on this list may know > why 6u25 is the only release > for which the download page currently offers debug builds: > > http://download.java.net/jdk6/6u25/promoted/b03/index.html > > while this is not the case for any other release (nor before 6u25 and > neither after 6u25) > > Thank you and best regards, > Volker > > On Tue, Nov 8, 2011 at 12:08 PM, Ulf Zibis wrote: >> Hi Volker, >> >> maybe you find some answers here: >> http://news.gmane.org/gmane.comp.java.openjdk.website/cutoff=297 >> http://markmail.org/search/?q=list%3Anet.java.openjdk#query:%20list%3Anet.java.openjdk.web-discuss+page:1+mid:hpggicgvoyuuezvi+state:results >> http://mail.openjdk.java.net/pipermail/web-discuss/2011-October/thread.html >> >> -Ulf >> >> >> >> Am 08.11.2011 11:30, schrieb Volker Simonis: >>> Hi, >>> >>> I could have sworn that >>> >>> http://jdk6.java.net/download.html and >>> http://jdk7.java.net/download.html >>> >>> always contained product AND "fastdebug" builds, but as I just >>> verified today there are no more "fastdebug" builds available neither >>> for JDK6 nor for JDK7 and JDK8. >>> >>> Is this intentional? >>> Is there any other source for debug builds of the original Oracle JDK? >>> >>> The debug builds have always been very useful to track down problems, >>> especially because many of the diagnostic VM options are only >>> available in debug builds. >>> >>> Regards, >>> Volker >>> From Ulf.Zibis at gmx.de Tue Nov 8 13:12:43 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 08 Nov 2011 14:12:43 +0100 Subject: Where have all the "fastdebug" builds gone? In-Reply-To: References: <4EB90DB7.6020006@gmx.de> Message-ID: <4EB92ACB.9030703@gmx.de> Am 08.11.2011 12:46, schrieb Volker Simonis: > - I know I can build OpenJDK fastdebug build myself (even on Windows:) Do you have Visual Studio 2008 professional? Just to mention, that openJDK-6 doesn't build with free (of charge) compiler on Windows, as openJDK-7 does with Visual C Express. -Ulf From Ulf.Zibis at gmx.de Tue Nov 8 15:21:40 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 08 Nov 2011 16:21:40 +0100 Subject: Partly builds on Windows should not always need C compiler Message-ID: <4EB94904.2020507@gmx.de> Some times ago I tried to run the make for nio/charsets via CYGWIN. It turned out, that I was required to have Visual Studio installed, because $(BUILDDIR)/common/Defs.gmk always looks for the C compiler. Can this dependency interweaved in a different way, so building of JDK parts without C sources would be possible without a C compiler installed? -Ulf From david.holmes at oracle.com Wed Nov 9 03:22:09 2011 From: david.holmes at oracle.com (David Holmes) Date: Wed, 09 Nov 2011 13:22:09 +1000 Subject: Partly builds on Windows should not always need C compiler In-Reply-To: <4EB94904.2020507@gmx.de> References: <4EB94904.2020507@gmx.de> Message-ID: <4EB9F1E1.702@oracle.com> Ulf, On 9/11/2011 1:21 AM, Ulf Zibis wrote: > Some times ago I tried to run the make for nio/charsets via CYGWIN. > It turned out, that I was required to have Visual Studio installed, > because $(BUILDDIR)/common/Defs.gmk always looks for the C compiler. > Can this dependency interweaved in a different way, so building of JDK > parts without C sources would be possible without a C compiler installed? Generally all the tool checks etc are done upfront before it is known what needs to be actually built. But I think that if you build in INSANE mode then the checks will only be warnings not fatal errors. David From zhouyx at linux.vnet.ibm.com Wed Nov 9 05:42:56 2011 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Wed, 9 Nov 2011 13:42:56 +0800 Subject: Successfully building 32- and 64-bit OpenJDK 8 on WinXP/64bit with free tools only In-Reply-To: References: <4EB81319.4090809@oracle.com> Message-ID: That's useful information ! I find the problem, when building freetype.dll, the default setting is "Debug" instead of "Release", so it links MSVCR100D.dll which only exists if visualstudio is installed. On Tue, Nov 8, 2011 at 4:32 PM, Volker Simonis wrote: > Hi Sean, > > looking at your error.log I think you have a different problem: > > Caused by: java.lang.UnsatisfiedLinkError: > C:\Users\zhouyx\Desktop\j2sdk-image\j > > re\bin\freetype.dll: Can't find dependent libraries > > This means that freetype.dll was found, but another library which > freetype.dll is dependent on could not be located on the new system. > > You can check with a tool like for example "DependencyWalker" > (http://www.dependencywalker.com/) on which other libraries > freetype.dll is dependent on. As far as I can see on my system, the > dependencies are not exceptional: > > t:\sapjvm_dev\d046063\j2sdk-image\jre\bin\FREETYPE.DLL > |-->c:\windows\system32\KERNEL32.DLL > |-->c:\windows\system32\NTDLL.DLL > > Hope this helps, > Volker > > > On Tue, Nov 8, 2011 at 7:38 AM, Sean Chou > wrote: > > Hi Phil, > > The situation I found is strange: the JDK we build works well on > windows > > which > > have the building environment. Eg. machine1 and machine2 both can build > > windows > > openjdk. If I copy a jdk built on machine1 to machine2, it works well. If > > machine3 > > doesn't have the build environment, it reports error about freetype.dll. > > I haven't investigate the problem, however the freetype.dll is there > > with awt.dll. So I guessed it was something related to freetype.dll > > installation. > > The attachment is the error information. > > On Tue, Nov 8, 2011 at 1:19 AM, Phil Race > wrote: > >> > >> Sean, > >> > >> I am not sure what you mean by "installed" - installed into > >> \windows\system32 > >> or installed in the JRE bin directory? But the latter is the only way > its > >> supposed to > >> work, and the build should take the copy of freetype.dll you provide to > >> it, and > >> copy it to that location. At runtime, freetype is treated like any other > >> JRE provided > >> DLL, such as awt.dll, net.dll, etc. The difference is only at build > time, > >> since the openjdk > >> sources don't contain the freetype sources. You need to build it > >> separately. > >> > >> -phil. > >> > >> On 11/6/2011 7:28 PM, Sean Chou wrote: > >>> > >>> Hi Volker, > >>> > >>> I would like to know have you tried to run gui application with the > >>> build on another > >>> windows machine which doesn't have freetype.dll installed ? I had > built > >>> jdk on > >>> windows but found that it can run gui applications in the machine built > >>> it, but cann't > >>> run gui application in machines without freetype installed. > >>> > >>> > >>> On Sat, Oct 29, 2011 at 2:19 AM, Volker Simonis < > volker.simonis at gmail.com > >>> > wrote: > >>> > >>> Hi, > >>> > >>> I've put together a short description on how to build both, a 64- > and > >>> a 32-bit version of OpenJDK 8 on a plain, vanilla WindowsXP 64-bit > >>> operating system using only free (as in free beer) tools: > >>> > >>> > >>> > http://weblogs.java.net/blog/simonis/archive/2011/10/28/yaojowbi-yet-another-openjdk-windows-build-instruction > >>> > >>> It seems as if it is not that hard anymore nowadays:) > >>> > >>> Regards, > >>> Volker > >>> > >>> > >>> > >>> > >>> -- > >>> Best Regards, > >>> Sean Chou > >>> > >> > > > > > > > > -- > > Best Regards, > > Sean Chou > > > > > -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: From ysr1729 at gmail.com Wed Nov 9 08:45:50 2011 From: ysr1729 at gmail.com (Srinivas Ramakrishna) Date: Wed, 9 Nov 2011 00:45:50 -0800 Subject: Xm/Motif for OpenJDK build? Message-ID: Sorry for a rather naive question. I am building openjdk (6) from scratch for the first time and am running into an issue when building the AWT classes because of not finding the relevant Motif header files at the expected locations on my system (ubuntu/x64). Has anyone else encountered this issue and had to do a fresh install of motif library and headers? If so, would OpenMotif cut it? thanks for any tips. -- ramki -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.holmes at oracle.com Wed Nov 9 09:09:13 2011 From: david.holmes at oracle.com (David Holmes) Date: Wed, 09 Nov 2011 19:09:13 +1000 Subject: Xm/Motif for OpenJDK build? In-Reply-To: References: Message-ID: <4EBA4339.30207@oracle.com> Hi Ramki! On 9/11/2011 6:45 PM, Srinivas Ramakrishna wrote: > > Sorry for a rather naive question. I am building openjdk (6) from > scratch for the first > time and am running into an issue when building the AWT classes because > of not finding > the relevant Motif header files at the expected locations on my system > (ubuntu/x64). Is it just a case of the X11 headers being in a different location? Try setting ALT_OPENWIN_HOME to the top of the tree eg /usr/X11/ or /usr/X11R6/ or whatever it may be. David Has anyone > else encountered this issue and had to do a fresh install of motif > library and headers? > If so, would OpenMotif cut it? > > thanks for any tips. > -- ramki From fweimer at bfk.de Wed Nov 9 09:11:09 2011 From: fweimer at bfk.de (Florian Weimer) Date: Wed, 09 Nov 2011 09:11:09 +0000 Subject: Xm/Motif for OpenJDK build? In-Reply-To: (Srinivas Ramakrishna's message of "Wed, 9 Nov 2011 00:45:50 -0800") References: Message-ID: <8262ity82a.fsf@mid.bfk.de> * Srinivas Ramakrishna: > Sorry for a rather naive question. I am building openjdk (6) from > scratch for the first time and am running into an issue when building > the AWT classes because of not finding the relevant Motif header files > at the expected locations on my system (ubuntu/x64). I think these headers are plain Xt, not Motif. Here's the minimal list of build dependencies I ended up with: ant, ant-optional, cpio, file, gawk, libasound2-dev, libcups2-dev, libfreetype6-dev, libx11-dev, libxext-dev, libxi-dev, libxrender-dev, libxt-dev, libxtst-dev, m4, openjdk-6-jdk, openjdk-drops, procps, unzip, x11proto-input-dev, zip, This list is for building OpenJDK 7 on a derivative of Debian squeeze, but Ubuntu is probably similar. -- Florian Weimer BFK edv-consulting GmbH http://www.bfk.de/ Kriegsstra?e 100 tel: +49-721-96201-1 D-76133 Karlsruhe fax: +49-721-96201-99 From ahughes at redhat.com Wed Nov 9 14:39:45 2011 From: ahughes at redhat.com (Dr Andrew John Hughes) Date: Wed, 9 Nov 2011 14:39:45 +0000 Subject: Xm/Motif for OpenJDK build? In-Reply-To: <8262ity82a.fsf@mid.bfk.de> References: <8262ity82a.fsf@mid.bfk.de> Message-ID: <20111109143945.GI25917@rivendell.middle-earth.co.uk> On 09:11 Wed 09 Nov , Florian Weimer wrote: > * Srinivas Ramakrishna: > > > Sorry for a rather naive question. I am building openjdk (6) from > > scratch for the first time and am running into an issue when building > > the AWT classes because of not finding the relevant Motif header files > > at the expected locations on my system (ubuntu/x64). > > I think these headers are plain Xt, not Motif. Here's the minimal list > of build dependencies I ended up with: > > ant, > ant-optional, > cpio, > file, > gawk, > libasound2-dev, > libcups2-dev, > libfreetype6-dev, > libx11-dev, > libxext-dev, > libxi-dev, > libxrender-dev, > libxt-dev, > libxtst-dev, > m4, > openjdk-6-jdk, > openjdk-drops, > procps, > unzip, > x11proto-input-dev, > zip, > > This list is for building OpenJDK 7 on a derivative of Debian squeeze, > but Ubuntu is probably similar. > But he asked about 6, not 7. And 6 does require the Motif headers still. Works with OpenMotif. > -- > Florian Weimer > BFK edv-consulting GmbH http://www.bfk.de/ > Kriegsstra?e 100 tel: +49-721-96201-1 > D-76133 Karlsruhe fax: +49-721-96201-99 -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and IcedTea http://www.gnu.org/software/classpath http://icedtea.classpath.org PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: From ysr1729 at gmail.com Wed Nov 9 16:39:13 2011 From: ysr1729 at gmail.com (Srinivas Ramakrishna) Date: Wed, 9 Nov 2011 08:39:13 -0800 Subject: Xm/Motif for OpenJDK build? In-Reply-To: <20111109143945.GI25917@rivendell.middle-earth.co.uk> References: <8262ity82a.fsf@mid.bfk.de> <20111109143945.GI25917@rivendell.middle-earth.co.uk> Message-ID: Thanks everyone for your suggestions. Indeed I am building jdk6.. I'll try out David's and Andrew's suggestions and see. (David: the header files seem to be missing on my ubuntu box, at least i can't find them under /usr/X11 (which i do have)). -- ramki On Wed, Nov 9, 2011 at 6:39 AM, Dr Andrew John Hughes wrote: > On 09:11 Wed 09 Nov , Florian Weimer wrote: > > * Srinivas Ramakrishna: > > > > > Sorry for a rather naive question. I am building openjdk (6) from > > > scratch for the first time and am running into an issue when building > > > the AWT classes because of not finding the relevant Motif header files > > > at the expected locations on my system (ubuntu/x64). > > > > I think these headers are plain Xt, not Motif. Here's the minimal list > > of build dependencies I ended up with: > > > > ant, > > ant-optional, > > cpio, > > file, > > gawk, > > libasound2-dev, > > libcups2-dev, > > libfreetype6-dev, > > libx11-dev, > > libxext-dev, > > libxi-dev, > > libxrender-dev, > > libxt-dev, > > libxtst-dev, > > m4, > > openjdk-6-jdk, > > openjdk-drops, > > procps, > > unzip, > > x11proto-input-dev, > > zip, > > > > This list is for building OpenJDK 7 on a derivative of Debian squeeze, > > but Ubuntu is probably similar. > > > > But he asked about 6, not 7. And 6 does require the Motif headers still. > Works with OpenMotif. > > > -- > > Florian Weimer > > BFK edv-consulting GmbH http://www.bfk.de/ > > Kriegsstra?e 100 tel: +49-721-96201-1 > > D-76133 Karlsruhe fax: +49-721-96201-99 > > -- > Andrew :) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and IcedTea > http://www.gnu.org/software/classpath > http://icedtea.classpath.org > PGP Key: 248BDC07 (https://keys.indymedia.org/) > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From kelly.ohair at oracle.com Wed Nov 9 18:06:10 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 9 Nov 2011 13:06:10 -0500 Subject: Xm/Motif for OpenJDK build? In-Reply-To: References: <8262ity82a.fsf@mid.bfk.de> <20111109143945.GI25917@rivendell.middle-earth.co.uk> Message-ID: <7E723244-0CB2-46AD-93F0-D8A41853C944@oracle.com> I am using: aptitude update aptitude install mercurial aptitude install rpm ssh openjdk6-jdk expect tcsh csh ksh gawk g++ build-essential aptitude build-dep openjdk-6 if [ "`uname -m`" = "x86_64" ] ; then aptitude install ia32-libs fi aptitude install ntp -kto On Nov 9, 2011, at 11:39 AM, Srinivas Ramakrishna wrote: > Thanks everyone for your suggestions. Indeed I am building jdk6.. I'll try out David's and Andrew's > suggestions and see. (David: the header files seem to be missing on my ubuntu box, at least i > can't find them under /usr/X11 (which i do have)). > > -- ramki > > On Wed, Nov 9, 2011 at 6:39 AM, Dr Andrew John Hughes wrote: > On 09:11 Wed 09 Nov , Florian Weimer wrote: > > * Srinivas Ramakrishna: > > > > > Sorry for a rather naive question. I am building openjdk (6) from > > > scratch for the first time and am running into an issue when building > > > the AWT classes because of not finding the relevant Motif header files > > > at the expected locations on my system (ubuntu/x64). > > > > I think these headers are plain Xt, not Motif. Here's the minimal list > > of build dependencies I ended up with: > > > > ant, > > ant-optional, > > cpio, > > file, > > gawk, > > libasound2-dev, > > libcups2-dev, > > libfreetype6-dev, > > libx11-dev, > > libxext-dev, > > libxi-dev, > > libxrender-dev, > > libxt-dev, > > libxtst-dev, > > m4, > > openjdk-6-jdk, > > openjdk-drops, > > procps, > > unzip, > > x11proto-input-dev, > > zip, > > > > This list is for building OpenJDK 7 on a derivative of Debian squeeze, > > but Ubuntu is probably similar. > > > > But he asked about 6, not 7. And 6 does require the Motif headers still. > Works with OpenMotif. > > > -- > > Florian Weimer > > BFK edv-consulting GmbH http://www.bfk.de/ > > Kriegsstra?e 100 tel: +49-721-96201-1 > > D-76133 Karlsruhe fax: +49-721-96201-99 > > -- > Andrew :) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and IcedTea > http://www.gnu.org/software/classpath > http://icedtea.classpath.org > PGP Key: 248BDC07 (https://keys.indymedia.org/) > Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 > -------------- next part -------------- An HTML attachment was scrubbed... URL: From ysr1729 at gmail.com Wed Nov 9 19:58:51 2011 From: ysr1729 at gmail.com (Srinivas Ramakrishna) Date: Wed, 9 Nov 2011 11:58:51 -0800 Subject: Xm/Motif for OpenJDK build? In-Reply-To: <7E723244-0CB2-46AD-93F0-D8A41853C944@oracle.com> References: <8262ity82a.fsf@mid.bfk.de> <20111109143945.GI25917@rivendell.middle-earth.co.uk> <7E723244-0CB2-46AD-93F0-D8A41853C944@oracle.com> Message-ID: Thanks Kelly. This doesn't seem to pull in the motif dependencies. I need to manually apt-get libmotif (or more precisely lesstif2). The build seems to have gotten past that point once i grabbed it though. (although make sanity still complains about Motif being missing.) thanks for your help everyone!! -- ramki On Wed, Nov 9, 2011 at 10:06 AM, Kelly O'Hair wrote: > I am using: > > aptitude update > aptitude install mercurial > aptitude install rpm ssh openjdk6-jdk expect tcsh csh ksh gawk g++ > build-essential > aptitude build-dep openjdk-6 > if [ "`uname -m`" = "x86_64" ] ; then > aptitude install ia32-libs > fi > aptitude install ntp > > -kto > > On Nov 9, 2011, at 11:39 AM, Srinivas Ramakrishna wrote: > > Thanks everyone for your suggestions. Indeed I am building jdk6.. I'll try > out David's and Andrew's > suggestions and see. (David: the header files seem to be missing on my > ubuntu box, at least i > can't find them under /usr/X11 (which i do have)). > > -- ramki > > On Wed, Nov 9, 2011 at 6:39 AM, Dr Andrew John Hughes wrote: > >> On 09:11 Wed 09 Nov , Florian Weimer wrote: >> > * Srinivas Ramakrishna: >> > >> > > Sorry for a rather naive question. I am building openjdk (6) from >> > > scratch for the first time and am running into an issue when building >> > > the AWT classes because of not finding the relevant Motif header files >> > > at the expected locations on my system (ubuntu/x64). >> > >> > I think these headers are plain Xt, not Motif. Here's the minimal list >> > of build dependencies I ended up with: >> > >> > ant, >> > ant-optional, >> > cpio, >> > file, >> > gawk, >> > libasound2-dev, >> > libcups2-dev, >> > libfreetype6-dev, >> > libx11-dev, >> > libxext-dev, >> > libxi-dev, >> > libxrender-dev, >> > libxt-dev, >> > libxtst-dev, >> > m4, >> > openjdk-6-jdk, >> > openjdk-drops, >> > procps, >> > unzip, >> > x11proto-input-dev, >> > zip, >> > >> > This list is for building OpenJDK 7 on a derivative of Debian squeeze, >> > but Ubuntu is probably similar. >> > >> >> But he asked about 6, not 7. And 6 does require the Motif headers still. >> Works with OpenMotif. >> >> > -- >> > Florian Weimer >> > BFK edv-consulting GmbH http://www.bfk.de/ >> > Kriegsstra?e 100 tel: +49-721-96201-1 >> > D-76133 Karlsruhe fax: +49-721-96201-99 >> >> -- >> Andrew :) >> >> Free Java Software Engineer >> Red Hat, Inc. (http://www.redhat.com) >> >> Support Free Java! >> Contribute to GNU Classpath and IcedTea >> http://www.gnu.org/software/classpath >> http://icedtea.classpath.org >> PGP Key: 248BDC07 (https://keys.indymedia.org/) >> Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 >> > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.katleman at sun.com Wed Nov 9 22:25:07 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 09 Nov 2011 22:25:07 +0000 Subject: hg: jdk8/build: Added tag jdk8-b12 for changeset 8e2104d565ba Message-ID: <20111109222508.14362472B1@hg.openjdk.java.net> Changeset: 26fb81a1e9ce Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/26fb81a1e9ce Added tag jdk8-b12 for changeset 8e2104d565ba ! .hgtags From david.katleman at sun.com Wed Nov 9 22:25:17 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 09 Nov 2011 22:25:17 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b12 for changeset 31d70911b712 Message-ID: <20111109222518.5DA19472B2@hg.openjdk.java.net> Changeset: 5b9d9b839d3d Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/5b9d9b839d3d Added tag jdk8-b12 for changeset 31d70911b712 ! .hgtags From david.katleman at sun.com Wed Nov 9 22:26:28 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 09 Nov 2011 22:26:28 +0000 Subject: hg: jdk8/build/hotspot: 7 new changesets Message-ID: <20111109222643.E5414472B3@hg.openjdk.java.net> Changeset: ddb34559f9a7 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ddb34559f9a7 Added tag jdk8-b12 for changeset 1d3900713a67 ! .hgtags Changeset: 5c8c7bef6403 Author: jcoomes Date: 2011-10-28 18:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5c8c7bef6403 7106092: Bump the hs23 build number to 05 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: d5c4c73aa855 Author: dholmes Date: 2011-10-27 18:04 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d5c4c73aa855 7104173: sun/tools tests fail with debug build after 7012206 Summary: Disable PrintVMOptions in embedded debug builds so tests are unaffected by extra output Reviewed-by: twisti, coleenp, phh, fparain, dsamersoff ! src/share/vm/runtime/globals.hpp Changeset: 6da94c5a6746 Author: dholmes Date: 2011-10-30 18:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6da94c5a6746 Merge Changeset: 95009f678859 Author: brutisso Date: 2011-11-01 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/95009f678859 7106766: Move the precompiled header from the src/share/vm directory Summary: Moved precompiled.hpp to src/share/vm/precompiled Reviewed-by: coleenp, dholmes Contributed-by: rbackman ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/gcc.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/gcc.make ! make/windows/makefiles/vm.make - src/share/vm/precompiled.hpp + src/share/vm/precompiled/precompiled.hpp Changeset: 3e609627e780 Author: jcoomes Date: 2011-11-04 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3e609627e780 Merge - src/share/vm/precompiled.hpp Changeset: b92ca8e229d2 Author: jcoomes Date: 2011-11-04 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b92ca8e229d2 Added tag hs23-b05 for changeset 3e609627e780 ! .hgtags From david.katleman at sun.com Wed Nov 9 22:28:05 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 09 Nov 2011 22:28:05 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b12 for changeset ca977d167697 Message-ID: <20111109222806.0984D472B4@hg.openjdk.java.net> Changeset: bcc739229f63 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/bcc739229f63 Added tag jdk8-b12 for changeset ca977d167697 ! .hgtags From david.katleman at sun.com Wed Nov 9 22:28:18 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 09 Nov 2011 22:28:18 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b12 for changeset e6eed2ff5d5f Message-ID: <20111109222818.4CC03472B5@hg.openjdk.java.net> Changeset: adf2a6b5fde1 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/adf2a6b5fde1 Added tag jdk8-b12 for changeset e6eed2ff5d5f ! .hgtags From david.katleman at sun.com Wed Nov 9 22:28:33 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 09 Nov 2011 22:28:33 +0000 Subject: hg: jdk8/build/jdk: 2 new changesets Message-ID: <20111109222900.3C89C472B6@hg.openjdk.java.net> Changeset: d636e737c478 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d636e737c478 Added tag jdk8-b12 for changeset 09fd2067f715 ! .hgtags Changeset: 4cb2e8679b27 Author: katleman Date: 2011-11-09 13:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4cb2e8679b27 Merge From david.katleman at sun.com Wed Nov 9 22:30:35 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 09 Nov 2011 22:30:35 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b12 for changeset f2d6ed25857d Message-ID: <20111109223040.5EF9B472B7@hg.openjdk.java.net> Changeset: ae25163501bc Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ae25163501bc Added tag jdk8-b12 for changeset f2d6ed25857d ! .hgtags From mark.reinhold at oracle.com Thu Nov 10 05:24:56 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 09 Nov 2011 21:24:56 -0800 Subject: Review request (XS): 7110396: Sound code fails to build on multiarch Linux systems Message-ID: <20111110052456.AEC78111B@eggemoggin.niobe.net> Some Linux distros have started to adopt a "multiarch" filesystem layout for shared libraries in order to support the installation of packages for multiple hardware architectures on a single system. For more information see, e.g., http://wiki.debian.org/Multiarch. In Ubuntu 11.10 the ALSA shared library, libasound2, was converted to the multiarch format and so its files moved from their old location, /usr/lib, to /usr/lib/${ARCH_TRIPLET}. This caused the JDK build to fail when linking the Java sound library. The root cause appears to be that gcc only tries to resolve undefined symbols against a multiarch library if the library is named on the command line after the object files containing those symbols. The fix is simply to move -lasound to the end of the gcc invocation. I'll push this into JDK 8. It would trivially backport to 7. Patch: --- a/make/javax/sound/jsoundalsa/Makefile +++ b/make/javax/sound/jsoundalsa/Makefile @@ -65,7 +65,7 @@ $(MIDIFILES_export) \ $(PORTFILES_export) -LDFLAGS += -lasound +EXTRA_LIBS += -lasound CPPFLAGS += \ -DUSE_DAUDIO=TRUE \ Thanks, - Mark From robert.ottenhag at oracle.com Thu Nov 10 12:49:47 2011 From: robert.ottenhag at oracle.com (Robert Ottenhag) Date: Thu, 10 Nov 2011 13:49:47 +0100 Subject: Review request (XS): 7110396: Sound code fails to build on multiarch Linux systems In-Reply-To: <20111110052456.AEC78111B@eggemoggin.niobe.net> References: <20111110052456.AEC78111B@eggemoggin.niobe.net> Message-ID: <4EBBC86B.7040700@oracle.com> On 11/10/2011 06:24 AM, mark.reinhold at oracle.com wrote: > Some Linux distros have started to adopt a "multiarch" filesystem layout for > shared libraries in order to support the installation of packages for multiple > hardware architectures on a single system. For more information see, e.g., > http://wiki.debian.org/Multiarch. > > In Ubuntu 11.10 the ALSA shared library, libasound2, was converted to the > multiarch format and so its files moved from their old location, /usr/lib, > to /usr/lib/${ARCH_TRIPLET}. This caused the JDK build to fail when linking > the Java sound library. The root cause appears to be that gcc only tries to > resolve undefined symbols against a multiarch library if the library is named > on the command line after the object files containing those symbols. > > The fix is simply to move -lasound to the end of the gcc invocation. > > I'll push this into JDK 8. It would trivially backport to 7. > > Patch: > > --- a/make/javax/sound/jsoundalsa/Makefile > +++ b/make/javax/sound/jsoundalsa/Makefile > @@ -65,7 +65,7 @@ > $(MIDIFILES_export) \ > $(PORTFILES_export) > > -LDFLAGS += -lasound > +EXTRA_LIBS += -lasound > > CPPFLAGS += \ > -DUSE_DAUDIO=TRUE \ > > Thanks, > - Mark Mark, The patch is correct, but in order to follow the convention in most other makefiles, I advice to use OTHER_LDLIBS instead of EXTRA_LIBS. I have tested this patch locally on Ubuntu 11.10-x64 for most branches for OpenJDK 6, 7 and 8 and meant to commit it earlier but... please go ahead. Thank /Robert -- Oracle Robert Ottenhag | Senior Member of Technical Staff Phone: +46850630961 | Fax: +46850630911 | Mobile: +46707106161 Oracle Java HotSpot Virtual Machine ORACLE Sweden | Folkungagatan 122 | SE-116 30 Stockholm Oracle Svenska AB, Kronborgsgr?nd 17, S-164 28 KISTA, reg.no. 556254-6746 Green Oracle Oracle is committed to developing practices and products that help protect the environment -- From robert.ottenhag at oracle.com Thu Nov 10 13:16:20 2011 From: robert.ottenhag at oracle.com (Robert Ottenhag) Date: Thu, 10 Nov 2011 14:16:20 +0100 Subject: Review request (XS): 7110396: Sound code fails to build on multiarch Linux systems In-Reply-To: <4EBBC86B.7040700@oracle.com> References: <20111110052456.AEC78111B@eggemoggin.niobe.net> <4EBBC86B.7040700@oracle.com> Message-ID: <4EBBCEA4.6090907@oracle.com> On 11/10/2011 01:49 PM, Robert Ottenhag wrote: > On 11/10/2011 06:24 AM, mark.reinhold at oracle.com wrote: >> Some Linux distros have started to adopt a "multiarch" filesystem >> layout for >> shared libraries in order to support the installation of packages for >> multiple >> hardware architectures on a single system. For more information see, >> e.g., >> http://wiki.debian.org/Multiarch. >> >> In Ubuntu 11.10 the ALSA shared library, libasound2, was converted to >> the >> multiarch format and so its files moved from their old location, >> /usr/lib, >> to /usr/lib/${ARCH_TRIPLET}. This caused the JDK build to fail when >> linking >> the Java sound library. The root cause appears to be that gcc only >> tries to >> resolve undefined symbols against a multiarch library if the library >> is named >> on the command line after the object files containing those symbols. >> >> The fix is simply to move -lasound to the end of the gcc invocation. >> >> I'll push this into JDK 8. It would trivially backport to 7. >> >> Patch: >> >> --- a/make/javax/sound/jsoundalsa/Makefile >> +++ b/make/javax/sound/jsoundalsa/Makefile >> @@ -65,7 +65,7 @@ >> $(MIDIFILES_export) \ >> $(PORTFILES_export) >> >> -LDFLAGS += -lasound >> +EXTRA_LIBS += -lasound >> >> CPPFLAGS += \ >> -DUSE_DAUDIO=TRUE \ >> >> Thanks, >> - Mark > > Mark, > > The patch is correct, but in order to follow the convention in most > other makefiles, I advice to use OTHER_LDLIBS instead of EXTRA_LIBS. I > have tested this patch locally on Ubuntu 11.10-x64 for most branches > for OpenJDK 6, 7 and 8 and meant to commit it earlier but... please go > ahead. > > Thank > > /Robert > I am also not entirely convinced that the new multiarch support is the reason for these failures, although it may trigger it. The specification for GNU ld is that dependencies on the link line should always be written left to right, i.e. object files before library files. See also http://stackoverflow.com/questions/45135/linker-order-gcc/409402#409402. With that it mind, I would not be surprised if we get similar failures in the future and that is why I suggest that every linker line without circular dependencies should be ordered left to right. However, this will probably be satisfied in the near future as part of the new build-infra project that is converting each and every native library Makefile. /Robert -- Oracle Robert Ottenhag | Senior Member of Technical Staff Phone: +46850630961 | Fax: +46850630911 | Mobile: +46707106161 Oracle Java HotSpot Virtual Machine ORACLE Sweden | Folkungagatan 122 | SE-116 30 Stockholm Oracle Svenska AB, Kronborgsgr?nd 17, S-164 28 KISTA, reg.no. 556254-6746 Green Oracle Oracle is committed to developing practices and products that help protect the environment -- From Ulf.Zibis at gmx.de Thu Nov 10 13:25:58 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Thu, 10 Nov 2011 14:25:58 +0100 Subject: Request to mailing list discuss rejected regarding "Re: Where have all the "fastdebug" builds gone?" In-Reply-To: References: Message-ID: <4EBBD0E6.20101@gmx.de> Hi all, as discuss at openjdk.java.net was in the cc-list of those 3 posts, I just did "answer to all", as I thought my post would be interesting to all participants. I think, list moderators should accept such posts from un-subscribed senders, to avoid communication thread gaps. What is the right behaviour here from posters side? I do not want to overflow my mail account in subscribing to *all* openjdk lists. Your opinions are appreciated, -Ulf Am 09.11.2011 23:21, schrieb discuss-bounces at openjdk.java.net: > Your request to the discuss mailing list > > Posting of your message titled "Re: Where have all the "fastdebug" > builds gone?" > > has been rejected by the list moderator. The moderator gave the > following reason for rejecting your request: > > "No reason given" > > Any questions or comments should be directed to the list administrator > at: > > discuss-owner at openjdk.java.net > From kelly.ohair at ORACLE.COM Thu Nov 10 13:50:54 2011 From: kelly.ohair at ORACLE.COM (Kelly O'Hair) Date: Thu, 10 Nov 2011 08:50:54 -0500 Subject: Xm/Motif for OpenJDK build? In-Reply-To: References: <8262ity82a.fsf@mid.bfk.de> <20111109143945.GI25917@rivendell.middle-earth.co.uk> <7E723244-0CB2-46AD-93F0-D8A41853C944@oracle.com> Message-ID: Strange, I would have assumed that the aptitude build-dep openjdk-6 would have gotten this. Maybe Dalibor might know more on this aptitude build-dep openjdk-6. -kto On Nov 9, 2011, at 2:58 PM, Srinivas Ramakrishna wrote: > Thanks Kelly. This doesn't seem to pull in the motif dependencies. I need to manually > apt-get libmotif (or more precisely lesstif2). The build seems to have gotten past that point > once i grabbed it though. (although make sanity still complains about Motif being missing.) > > thanks for your help everyone!! > -- ramki > > On Wed, Nov 9, 2011 at 10:06 AM, Kelly O'Hair wrote: > I am using: > > aptitude update > aptitude install mercurial > aptitude install rpm ssh openjdk6-jdk expect tcsh csh ksh gawk g++ build-essential > aptitude build-dep openjdk-6 > if [ "`uname -m`" = "x86_64" ] ; then > aptitude install ia32-libs > fi > aptitude install ntp > > -kto > > On Nov 9, 2011, at 11:39 AM, Srinivas Ramakrishna wrote: > >> Thanks everyone for your suggestions. Indeed I am building jdk6.. I'll try out David's and Andrew's >> suggestions and see. (David: the header files seem to be missing on my ubuntu box, at least i >> can't find them under /usr/X11 (which i do have)). >> >> -- ramki >> >> On Wed, Nov 9, 2011 at 6:39 AM, Dr Andrew John Hughes wrote: >> On 09:11 Wed 09 Nov , Florian Weimer wrote: >> > * Srinivas Ramakrishna: >> > >> > > Sorry for a rather naive question. I am building openjdk (6) from >> > > scratch for the first time and am running into an issue when building >> > > the AWT classes because of not finding the relevant Motif header files >> > > at the expected locations on my system (ubuntu/x64). >> > >> > I think these headers are plain Xt, not Motif. Here's the minimal list >> > of build dependencies I ended up with: >> > >> > ant, >> > ant-optional, >> > cpio, >> > file, >> > gawk, >> > libasound2-dev, >> > libcups2-dev, >> > libfreetype6-dev, >> > libx11-dev, >> > libxext-dev, >> > libxi-dev, >> > libxrender-dev, >> > libxt-dev, >> > libxtst-dev, >> > m4, >> > openjdk-6-jdk, >> > openjdk-drops, >> > procps, >> > unzip, >> > x11proto-input-dev, >> > zip, >> > >> > This list is for building OpenJDK 7 on a derivative of Debian squeeze, >> > but Ubuntu is probably similar. >> > >> >> But he asked about 6, not 7. And 6 does require the Motif headers still. >> Works with OpenMotif. >> >> > -- >> > Florian Weimer >> > BFK edv-consulting GmbH http://www.bfk.de/ >> > Kriegsstra?e 100 tel: +49-721-96201-1 >> > D-76133 Karlsruhe fax: +49-721-96201-99 >> >> -- >> Andrew :) >> >> Free Java Software Engineer >> Red Hat, Inc. (http://www.redhat.com) >> >> Support Free Java! >> Contribute to GNU Classpath and IcedTea >> http://www.gnu.org/software/classpath >> http://icedtea.classpath.org >> PGP Key: 248BDC07 (https://keys.indymedia.org/) >> Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dalibor.topic at oracle.com Thu Nov 10 14:04:46 2011 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 10 Nov 2011 15:04:46 +0100 Subject: Request to mailing list discuss rejected regarding "Re: Where have all the "fastdebug" builds gone?" In-Reply-To: <4EBBD0E6.20101@gmx.de> References: <4EBBD0E6.20101@gmx.de> Message-ID: <4EBBD9FE.10509@oracle.com> On 11/10/11 2:25 PM, Ulf Zibis wrote: > Hi all, > > as discuss at openjdk.java.net was in the cc-list of those 3 posts, I just did "answer to all", as I thought my post would be interesting to all participants. While that is an understandable opinion on the side of any e-mail author, in practice it is very rare that any single e-mail message is interesting to all participants on any single mailing list, not to mention on multiple ones. See https://secure.wikimedia.org/wikipedia/en/wiki/Crossposting . > I think, list moderators should accept such posts from un-subscribed senders, to avoid communication thread gaps. No. As a list moderator for a couple of lists, I should point out that I almost never moderate any posts through, with the one exception being mercurial commit messages, since missing those confuses people about commits. > What is the right behaviour here from posters side? Subscribe to a list in order to post to it. cheers, dalibor topic -- Oracle Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 | Mobile: +491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: J?rgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle Oracle is committed to developing practices and products that help protect the environment From mark.reinhold at oracle.com Thu Nov 10 15:47:16 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 10 Nov 2011 07:47:16 -0800 Subject: Review request (XS): 7110396: Sound code fails to build on multiarch Linux systems In-Reply-To: robert.ottenhag@oracle.com; Thu, 10 Nov 2011 13:49:47 +0100; <4EBBC86B.7040700@oracle.com> Message-ID: <20111110154717.007BA2DE4@eggemoggin.niobe.net> 2011/11/10 4:49 -0800, robert.ottenhag at oracle.com: > The patch is correct, but in order to follow the convention in most other > makefiles, I advice to use OTHER_LDLIBS instead of EXTRA_LIBS. Ah, thanks. I missed that one when reading through the common makefiles. 2011/11/10 5:16 -0800, robert.ottenhag at oracle.com: > I am also not entirely convinced that the new multiarch support is the reason > for these failures, although it may trigger it. Right. It may be that newer versions of gcc would show this problem even on a non-multiarch system, but it's not really worth investigating any further. I'll clarify the description in the bug report. > The specification for GNU ld is > that dependencies on the link line should always be written left to right, > i.e. object files before library files. See also > http://stackoverflow.com/questions/45135/linker-order-gcc/409402#409402. With > that it mind, I would not be surprised if we get similar failures in the future > and that is why I suggest that every linker line without circular dependencies > should be ordered left to right. That's what I've always done too, but then I didn't write the makefile in question here. > However, this will probably be satisfied in > the near future as part of the new build-infra project that is converting each > and every native library Makefile. Looking forward to that ... - Mark From robert.ottenhag at oracle.com Thu Nov 10 16:39:10 2011 From: robert.ottenhag at oracle.com (Robert Ottenhag) Date: Thu, 10 Nov 2011 08:39:10 -0800 (PST) Subject: Review request (XS): 7110396: Sound code fails to build on multiarch Linux systems In-Reply-To: <20111110154717.007BA2DE4@eggemoggin.niobe.net> References: <10> <2011> <13:49:47> <+0100> <4EBBC86B.7040700@oracle.com 20111110154717.007BA2DE4@eggemoggin.niobe.net> Message-ID: <54cba21f-e095-4433-ad47-0358a7c2701c@default> > -----Original Message----- > From: Mark Reinhold > Sent: Thursday, November 10, 2011 4:47 PM > > 2011/11/10 5:16 -0800, robert.ottenhag at oracle.com: > > I am also not entirely convinced that the new multiarch > > support is the reason > > for these failures, although it may trigger it. > > Right. It may be that newer versions of gcc would show this > problem even > on a non-multiarch system, but it's not really worth investigating any > further. I'll clarify the description in the bug report. Looks good. Thanks /Robert From Ulf.Zibis at gmx.de Thu Nov 10 20:09:36 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Thu, 10 Nov 2011 21:09:36 +0100 Subject: Request to mailing list discuss rejected regarding "Re: Where have all the "fastdebug" builds gone?" In-Reply-To: <4EBBD9FE.10509@oracle.com> References: <4EBBD0E6.20101@gmx.de> <4EBBD9FE.10509@oracle.com> Message-ID: <4EBC2F80.3080706@gmx.de> Am 10.11.2011 15:04, schrieb Dalibor Topic: > On 11/10/11 2:25 PM, Ulf Zibis wrote: >> Hi all, >> >> as discuss at openjdk.java.net was in the cc-list of those 3 posts, I just did "answer to all", as I thought my post would be interesting to all participants. > While that is an understandable opinion on the side of any e-mail author, in practice it is very rare that any single > e-mail message is interesting to all participants on any single mailing list, not to mention on multiple ones. See > https://secure.wikimedia.org/wikipedia/en/wiki/Crossposting . > >> I think, list moderators should accept such posts from un-subscribed senders, to avoid communication thread gaps. > No. > > As a list moderator for a couple of lists, I should point out that I almost never moderate any posts through, with > the one exception being mercurial commit messages, since missing those confuses people about commits. > >> What is the right behaviour here from posters side? > Subscribe to a list in order to post to it. I recently found out, that I could disable email delivery to me. So now, subscribed to the list, I can CC to it without overflow in my email account. Thanks your your clarification Dalibor. -Ulf > > cheers, > dalibor topic From david.holmes at oracle.com Fri Nov 11 01:45:39 2011 From: david.holmes at oracle.com (David Holmes) Date: Fri, 11 Nov 2011 11:45:39 +1000 Subject: Review request (XS): 7110396: Sound code fails to build on multiarch Linux systems In-Reply-To: <20111110154717.007BA2DE4@eggemoggin.niobe.net> References: <20111110154717.007BA2DE4@eggemoggin.niobe.net> Message-ID: <4EBC7E43.5000805@oracle.com> On 11/11/2011 1:47 AM, mark.reinhold at oracle.com wrote: > 2011/11/10 4:49 -0800, robert.ottenhag at oracle.com: >> The patch is correct, but in order to follow the convention in most other >> makefiles, I advice to use OTHER_LDLIBS instead of EXTRA_LIBS. > > Ah, thanks. I missed that one when reading through the common makefiles. The common/Defs-*.gmk files say explicitly to use EXTRA_LIBS in place of LDLIBS or LDLIBS_COMMON (and seem ignorant of OTHER_LDLIBS). But if the intent was to ensure this link directive was at the end then I don't think OTHER_LDLIBS will work as it is the first set of entries in LDLIBS, while the last set is LDLIBS_COMMON to which EXTRA_LIBS is appended. David ----- > 2011/11/10 5:16 -0800, robert.ottenhag at oracle.com: >> I am also not entirely convinced that the new multiarch support is the reason >> for these failures, although it may trigger it. > > Right. It may be that newer versions of gcc would show this problem even > on a non-multiarch system, but it's not really worth investigating any > further. I'll clarify the description in the bug report. > >> The specification for GNU ld is >> that dependencies on the link line should always be written left to right, >> i.e. object files before library files. See also >> http://stackoverflow.com/questions/45135/linker-order-gcc/409402#409402. With >> that it mind, I would not be surprised if we get similar failures in the future >> and that is why I suggest that every linker line without circular dependencies >> should be ordered left to right. > > That's what I've always done too, but then I didn't write the makefile in > question here. > >> However, this will probably be satisfied in >> the near future as part of the new build-infra project that is converting each >> and every native library Makefile. > > Looking forward to that ... > > - Mark From mark.reinhold at oracle.com Fri Nov 11 05:27:27 2011 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Thu, 10 Nov 2011 21:27:27 -0800 Subject: Review request (XS): 7110396: Sound code fails to build on multiarch Linux systems In-Reply-To: david.holmes@oracle.com; Fri, 11 Nov 2011 11:45:39 +1000; <4EBC7E43.5000805@oracle.com> Message-ID: <20111111052728.045907E1@eggemoggin.niobe.net> 2011/11/10 17:45 -0800, david.holmes at oracle.com: > On 11/11/2011 1:47 AM, mark.reinhold at oracle.com wrote: >> 2011/11/10 4:49 -0800, robert.ottenhag at oracle.com: >>> The patch is correct, but in order to follow the convention in most other >>> makefiles, I advice to use OTHER_LDLIBS instead of EXTRA_LIBS. > > The common/Defs-*.gmk files say explicitly to use EXTRA_LIBS in place of LDLIBS > or LDLIBS_COMMON (and seem ignorant of OTHER_LDLIBS). > > But if the intent was to ensure this link directive was at the end then I don't > think OTHER_LDLIBS will work as it is the first set of entries in LDLIBS, while > the last set is LDLIBS_COMMON to which EXTRA_LIBS is appended. The intent is only to ensure that this link directive follows all object files; it's fine for it to precede the other libraries being linked. >From a build log, OTHER_LDLIBS is doing exactly what's needed: /usr/bin/gcc -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused \ -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN -DNDEBUG \ -DARCH='"i586"' -Di586 -DLINUX -DRELEASE='"1.8.0-mr_2011.11.10.1106"' \ -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -D_REENTRANT \ -I. -I/w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/CClassHeaders \ -I../../../../src/solaris/javavm/export \ -I../../../../src/share/javavm/export \ -I../../../../src/share/native/common \ -I../../../../src/solaris/native/common \ -I../../../../src/share/native/javax/sound \ -I../../../../src/solaris/native/javax/sound -DX_PLATFORM=X_LINUX \ -DX_ARCH=X_I586 -DUSE_DAUDIO=TRUE -DUSE_PORTS=TRUE \ -DUSE_PLATFORM_MIDI_OUT=TRUE -DUSE_PLATFORM_MIDI_IN=TRUE \ -I../../../../src/share/native/com/sun/media/sound -Xlinker -O1 -Xlinker \ -version-script=mapfile-vers -Wl,--hash-style=both -Xlinker -z -Xlinker \ origin -Xlinker -rpath -Xlinker \$ORIGIN -Xlinker -z -Xlinker defs \ -L/w/jdk8/build/lib/i386 -Wl,-soname=libjsoundalsa.so -shared \ -mimpure-text -o /w/jdk8/build/lib/i386/libjsoundalsa.so \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/Utilities.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/DirectAudioDeviceProvider.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/DirectAudioDevice.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/MidiInDevice.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/MidiInDeviceProvider.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/MidiOutDevice.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/MidiOutDeviceProvider.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PlatformMidi.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PortMixerProvider.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PortMixer.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PLATFORM_API_LinuxOS_ALSA_CommonUtils.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PLATFORM_API_LinuxOS_ALSA_PCM.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PLATFORM_API_LinuxOS_ALSA_PCMUtils.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PLATFORM_API_LinuxOS_ALSA_MidiIn.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PLATFORM_API_LinuxOS_ALSA_MidiOut.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PLATFORM_API_LinuxOS_ALSA_MidiUtils.o \ /w/jdk8/build/tmp/sun/javax.sound/jsoundalsa/obj/PLATFORM_API_LinuxOS_ALSA_Ports.o \ -lasound -ljava -L/w/jdk8/build/lib/i386/server -ljvm -lc ^^^^^^^^ (Without this fix, "-lasound" was appearing right before "-shared".) - Mark From andrea.weikert at printsoft.com Fri Nov 11 10:37:13 2011 From: andrea.weikert at printsoft.com (Andrea Weikert) Date: Fri, 11 Nov 2011 05:37:13 -0500 Subject: Checking build results Message-ID: <799E5EDBB4DDE949823BDAEA494449110DD9BC32B7@olexch1> Hi, have to admit that I'm quite new to the OpenJDK version 1.7.0-internal and trying to confirm that my build on Windows is fine. I have more or less successfully run the tests for hotspot and jdk so far and would like to compare the results to an official run of the tests. Running the build with cygwin on Windows XP I did have to make a few small adjustments to get them working but I still get a few test failures here and there. Is there a place where the official test results are published so I can compare? Specifically I'd like to know which tests are supposed to run, since I also get quite a few 'not run' tests. My second question is the langtools tests, I seem to run them successfully, but the summary.txt file isn't found. Any hint on that? (I have been running cygwin make 3.8.1 and read that probably a higher version is required - can anyone confirm before I rebuild the whole jdk?) Kind regards, Andrea PS: My command line for running the tests is from the main openjdk folder: Make test PRODUCT_HOME=build/windows-i586/j2sdk-image JPRT_JTREG_HOME= JPRT_JCK_HOME= From volker.simonis at gmail.com Fri Nov 11 13:37:48 2011 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 11 Nov 2011 14:37:48 +0100 Subject: Checking build results In-Reply-To: <799E5EDBB4DDE949823BDAEA494449110DD9BC32B7@olexch1> References: <799E5EDBB4DDE949823BDAEA494449110DD9BC32B7@olexch1> Message-ID: I think you really need a Gnumake higher than 3.81 and I honestly can not understand how you've managed to build the whole OpenJDK with the 3.81 version of make which comes with Cygwin (because it has serious problems with drive letters in Windows path names). I've recently wrote a blog how I've compiled OpenJDK on Windows (http://weblogs.java.net/blog/simonis/archive/2011/10/28/yaojowbi-yet-another-openjdk-windows-build-instruction) where I've also described how to build Gnumake 3.82 however I haven't run the tests until now. Best regards, Volker On Fri, Nov 11, 2011 at 11:37 AM, Andrea Weikert wrote: > Hi, > > > > have to admit that I?m quite new to the OpenJDK version 1.7.0-internal and > trying to confirm that my build on Windows is fine. > > I have more or less successfully run the tests for hotspot and jdk so far > and would like to compare the results to an official run of the tests. > > Running the build with cygwin on Windows XP I did have to make a few small > adjustments to get them working but I still get a few test failures here and > there. > > > > Is there a place where the official ?test results are published so I can > compare? Specifically I?d like to know which tests are supposed to run, > since I also get quite a few ?not run? tests. > > > > My second question is the langtools tests, I seem to run them successfully, > but the summary.txt file isn?t found. Any hint on that? > > (I have been running cygwin make 3.8.1 and read that probably a higher > version is required ? can anyone confirm before I rebuild the whole jdk?) > > > > Kind regards, > > Andrea > > > > > > PS: > > My command line for running the tests is from the main openjdk folder: > > > > Make test PRODUCT_HOME=build/windows-i586/j2sdk-image > JPRT_JTREG_HOME= JPRT_JCK_HOME= JPRT_JAVA_HOME= > From dalibor.topic at oracle.com Fri Nov 11 14:09:27 2011 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 11 Nov 2011 15:09:27 +0100 Subject: Checking build results In-Reply-To: <799E5EDBB4DDE949823BDAEA494449110DD9BC32B7@olexch1> References: <799E5EDBB4DDE949823BDAEA494449110DD9BC32B7@olexch1> Message-ID: <4EBD2C97.3090608@oracle.com> On 11/11/11 11:37 AM, Andrea Weikert wrote: > Is there a place where the official test results are published so I can compare? Not really. Some people publish their jtreg test results, for example for OpenJDK 6 releases, the Project Leads tend to publish their own jtreg run results, but I'm not aware of any central repository of such results. cheers, dalibor topic -- Oracle Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 | Mobile: +491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: J?rgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle Oracle is committed to developing practices and products that help protect the environment From jonathan.gibbons at oracle.com Fri Nov 11 14:52:25 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 11 Nov 2011 06:52:25 -0800 Subject: Checking build results In-Reply-To: <4EBD2C97.3090608@oracle.com> References: <799E5EDBB4DDE949823BDAEA494449110DD9BC32B7@olexch1> <4EBD2C97.3090608@oracle.com> Message-ID: <4EBD36A9.2000304@oracle.com> On 11/11/2011 06:09 AM, Dalibor Topic wrote: > On 11/11/11 11:37 AM, Andrea Weikert wrote: >> Is there a place where the official test results are published so I can compare? > Not really. Some people publish their jtreg test results, for example for OpenJDK 6 > releases, the Project Leads tend to publish their own jtreg run results, but I'm > not aware of any central repository of such results. > > cheers, > dalibor topic > All the langtools tests should always pass. -- Jon From nhann at chalmers.se Fri Nov 11 16:22:43 2011 From: nhann at chalmers.se (Dang Nhan Nguyen) Date: Fri, 11 Nov 2011 16:22:43 +0000 Subject: Profiling the hotspot, Message-ID: Hi, I need to measure some performance (mostly running time) of GC (CMS) while running on multi-core platform on Linux. I want to break down the cost of each phase in CMS and some related method. And I am thinking of performance profiling tool to do that. I have look at the build files and see that there used to be some "profiled" target for profiling hotspot. However, it was removed now (don't know why). Now, I am looking for a way to do the profiling. As my experience with profiling the hotspot on Windows (using Visual Studio), the generated of profiling data is huge (2-6GB) and in many cases, my computer could not handle the analysis of profiling data. In addition, hotspot's code and its build are quite complex, I want to consult some opinions first before actually do it. I am grateful if you can suggest a way to build the hotspot on Linux for profiling purpose. Thank you, Nhan Nguyen From david.holmes at oracle.com Sat Nov 12 03:23:56 2011 From: david.holmes at oracle.com (David Holmes) Date: Sat, 12 Nov 2011 13:23:56 +1000 Subject: Profiling the hotspot, In-Reply-To: References: Message-ID: <4EBDE6CC.2060105@oracle.com> As this mainly concerns GC profiling I've cc'ed the GC list. David On 12/11/2011 2:22 AM, Dang Nhan Nguyen wrote: > Hi, > > I need to measure some performance (mostly running time) of GC (CMS) while running on multi-core platform on Linux. I want to break down the cost of each phase in CMS and some related method. And I am thinking of performance profiling tool to do that. > > I have look at the build files and see that there used to be some "profiled" target for profiling hotspot. However, it was removed now (don't know why). > > Now, I am looking for a way to do the profiling. As my experience with profiling the hotspot on Windows (using Visual Studio), the generated of profiling data is huge (2-6GB) and in many cases, my computer could not handle the analysis of profiling data. In addition, hotspot's code and its build are quite complex, I want to consult some opinions first before actually do it. > > I am grateful if you can suggest a way to build the hotspot on Linux for profiling purpose. > > Thank you, > Nhan Nguyen > > From jon.masamitsu at oracle.com Sat Nov 12 07:44:00 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Fri, 11 Nov 2011 23:44:00 -0800 Subject: Profiling the hotspot, In-Reply-To: <4EBDE6CC.2060105@oracle.com> References: <4EBDE6CC.2060105@oracle.com> Message-ID: <4EBE23C0.1070607@oracle.com> Take a look at Charlie's blog about the collector analyzer tools http://blogs.oracle.com/charliebrown/entry/free_sun_studio_12_and And the quick start guide http://dsc.sun.com/solaris/articles/analyzer_qs.html The profiling build target in hotspot was deleted because they were not being used and I believe were not building correctly. On 11/11/2011 7:23 PM, David Holmes wrote: > As this mainly concerns GC profiling I've cc'ed the GC list. > > David > > On 12/11/2011 2:22 AM, Dang Nhan Nguyen wrote: >> Hi, >> >> I need to measure some performance (mostly running time) of GC (CMS) >> while running on multi-core platform on Linux. I want to break down >> the cost of each phase in CMS and some related method. And I am >> thinking of performance profiling tool to do that. >> >> I have look at the build files and see that there used to be some >> "profiled" target for profiling hotspot. However, it was removed now >> (don't know why). >> >> Now, I am looking for a way to do the profiling. As my experience >> with profiling the hotspot on Windows (using Visual Studio), the >> generated of profiling data is huge (2-6GB) and in many cases, my >> computer could not handle the analysis of profiling data. In >> addition, hotspot's code and its build are quite complex, I want to >> consult some opinions first before actually do it. >> >> I am grateful if you can suggest a way to build the hotspot on Linux >> for profiling purpose. >> >> Thank you, >> Nhan Nguyen >> >> From fancyerii at gmail.com Mon Nov 14 03:10:23 2011 From: fancyerii at gmail.com (Li Li) Date: Mon, 14 Nov 2011 11:10:23 +0800 Subject: problem when building openjdk6 Message-ID: hi all I tried to build a debug version of openjdk6. I follows these articles: http://weblogs.java.net/blog/simonis/archive/2008/01/hotspot_develop.html http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html I've got the latest codes and an error occured: 2045 /usr/bin/gcc -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -fno-omit-fra me-pointer -D_LITTLE_ENDIAN -DARCH='"i586"' -Di586 -DLINUX -DRELEASE='"1.6.0-internal"' -D_LARGEFI LE64_SOURCE -D_GNU_SOURCE -D_REENTRANT -I. -I/media/d/openjdk6/build/linux-i586/tmp/sun/sun.security .pkcs11/j2pkcs11/CClassHeaders -I../../../../src/solaris/javavm/export -I../../../../src/share/javav m/export -I../../../../src/share/javavm/include -I../../../../src/solaris/javavm/include -I../../../ ../src/share/native/sun/security/pkcs11/wrapper -I../../../../src/solaris/native/sun/security/pkcs11 /wrapper -I../../../../src/share/native/common -I../../../../src/solaris/native/common -I../../../.. /src/share/native/sun/security/pkcs11 -I../../../../src/solaris/native/sun/security/pkcs11 -c -o /media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/obj/p11_convert.o ../../../ ../src/share/native/sun/security/pkcs11/wrapper/p11_convert.c 2046 ../../../../src/share/native/sun/security/pkcs11/j2secmod.c:76:27: error: conflicting types for 'Jav a_sun_security_pkcs11_Secmod_nssGetModuleList' 2047 /media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/CClassHeaders/sun_security_p kcs11_Secmod.h:49:27: note: previous declaration of 'Java_sun_security_pkcs11_Secmod_nssGetModuleLis t' was here 2048 make[6]: *** [/media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/obj/j2secmod.o ] Error 1 I searched a bug in sun's bug database: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058133 in my make/sun/security/pkcs11/Makefile There is not any JAVAHFLAGS += -classpath $(CLASSDESTDIR) So I tried to add this line. But it still failed. The result of make sanity: make[1]: Entering directory `/media/d/openjdk6/jdk/make' make[2]: Entering directory `/media/d/openjdk6/jdk/make/tools/freetypecheck' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/media/d/openjdk6/jdk/make/tools/freetypecheck' make[1]: Leaving directory `/media/d/openjdk6/jdk/make' Build Machine Information: build machine = lili-desktop Build Directory Structure: CWD = /media/d/openjdk6 TOPDIR = . LANGTOOLS_TOPDIR = ./langtools JAXP_TOPDIR = ./jaxp JAXWS_TOPDIR = ./jaxws CORBA_TOPDIR = ./corba HOTSPOT_TOPDIR = ./hotspot JDK_TOPDIR = ./jdk Build Directives: BUILD_LANGTOOLS = true BUILD_JAXP = true BUILD_JAXWS = true BUILD_CORBA = true BUILD_HOTSPOT = true BUILD_JDK = true DEBUG_CLASSFILES = DEBUG_BINARIES = Hotspot Settings: HOTSPOT_BUILD_JOBS = HOTSPOT_OUTPUTDIR = /media/d/openjdk6/build/linux-i586/hotspot/outputdir HOTSPOT_EXPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import Bootstrap Settings: BOOTDIR = /home/lili/java/jdk1.6.0_26/ ALT_BOOTDIR = /home/lili/java/jdk1.6.0_26/ BOOT_VER = 1.6 [requires at least 1.6] OUTPUTDIR = /media/d/openjdk6/build/linux-i586 ALT_OUTPUTDIR = /media/d/openjdk6/build/linux-i586 ABS_OUTPUTDIR = /media/d/openjdk6/build/linux-i586 Build Tool Settings: SLASH_JAVA = /NOT-SET ALT_SLASH_JAVA = VARIANT = OPT JDK_DEVTOOLS_DIR = /NOT-SET/devtools ALT_JDK_DEVTOOLS_DIR = ANT_HOME = UNIXCOMMAND_PATH = /bin/ ALT_UNIXCOMMAND_PATH = COMPILER_PATH = /usr/bin/ ALT_COMPILER_PATH = DEVTOOLS_PATH = /usr/bin/ ALT_DEVTOOLS_PATH = UNIXCCS_PATH = /usr/ccs/bin/ ALT_UNIXCCS_PATH = USRBIN_PATH = /usr/bin/ ALT_USRBIN_PATH = MOTIF_DIR = /usr ALT_MOTIF_DIR = MOTIF_REQUIRED = false COMPILER_NAME = GCC COMPILER_VERSION = CC_VER = 4.5 [requires at least 3.2] ZIP_VER = 3.0 [requires at least 2.2] UNZIP_VER = 6.00 [requires at least 5.12] ANT_VER = 1.8 [requires at least 1.6.3] TEMPDIR = /media/d/openjdk6/build/linux-i586/tmp Build Directives: OPENJDK = true USE_HOTSPOT_INTERPRETER_MODE = PEDANTIC = DEV_ONLY = NO_DOCS = NO_IMAGES = TOOLS_ONLY = INSANE = COMPILE_APPROACH = parallel PARALLEL_COMPILE_JOBS = 2 ALT_PARALLEL_COMPILE_JOBS = FASTDEBUG = COMPILER_WARNINGS_FATAL = false COMPILER_WARNING_LEVEL = INCREMENTAL_BUILD = false CC_HIGHEST_OPT = -O3 CC_HIGHER_OPT = -O3 CC_LOWER_OPT = -O2 CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN BOOT_JAVA_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m BOOT_JAVAC_CMD = /home/lili/java/jdk1.6.0_26//bin/javac -J-XX:ThreadStackSize=768 -J-client -J-Xmx896m -J-Xms128m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -encoding ascii -source 5 -target 5 -XDignore.symbol.file=true BOOT_JAR_CMD = /home/lili/java/jdk1.6.0_26//bin/jar BOOT_JARSIGNER_CMD = /home/lili/java/jdk1.6.0_26//bin/jarsigner JAVAC_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -jar /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -source 1.5 -target 5 -encoding ascii -Xbootclasspath:/media/d/openjdk6/build/linux-i586/classes JAVAH_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javah.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -jar /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javah.jar -bootclasspath /media/d/openjdk6/build/linux-i586/classes JAVADOC_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/doclets.jar -jar /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar Build Platform Settings: USER = lili PLATFORM = linux ARCH = i586 LIBARCH = i386 ARCH_FAMILY = i586 ARCH_DATA_MODEL = 32 ARCHPROP = i386 LINUX_VERSION = Unknown linux ALSA_VERSION = 1.0.24.1 OS_VERSION = 2.6.38-12-generic [requires at least 2.4.9-e.3] OS_NAME = linux MB_OF_MEMORY = 3527 GNU Make Settings: MAKE = make MAKE_VER = 3.81 [requires at least 3.78] MAKECMDGOALS = sanity MAKEFLAGS = w SHELL = /bin/sh Target Build Versions: JDK_VERSION = 1.6.0 MILESTONE = internal RELEASE = 1.6.0-internal FULL_VERSION = 1.6.0-internal-lili_11_nov_2011_19_32-b00 BUILD_NUMBER = b00 External File/Binary Locations: USRJDKINSTANCES_PATH = /opt/java BUILD_JDK_IMPORT_PATH = /NOT-SET/re/openjdk/6/promoted/latest/binaries ALT_BUILD_JDK_IMPORT_PATH = JDK_IMPORT_PATH = /NOT-SET/re/openjdk/6/promoted/latest/binaries/linux-i586 ALT_JDK_IMPORT_PATH = LANGTOOLS_DIST = /media/d/openjdk6/build/linux-i586/langtools/dist ALT_LANGTOOLS_DIST = /media/d/openjdk6/build/linux-i586/langtools/dist CORBA_DIST = /media/d/openjdk6/build/linux-i586/corba/dist ALT_CORBA_DIST = /media/d/openjdk6/build/linux-i586/corba/dist JAXP_DIST = /media/d/openjdk6/build/linux-i586/jaxp/dist ALT_JAXP_DIST = /media/d/openjdk6/build/linux-i586/jaxp/dist JAXWS_DIST = /media/d/openjdk6/build/linux-i586/jaxws/dist ALT_JAXWS_DIST = /media/d/openjdk6/build/linux-i586/jaxws/dist HOTSPOT_DOCS_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import/docs ALT_HOTSPOT_DOCS_IMPORT_PATH = HOTSPOT_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import ALT_HOTSPOT_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import HOTSPOT_CLIENT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import/jre/lib/i386/client ALT_HOTSPOT_CLIENT_PATH = HOTSPOT_SERVER_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import/jre/lib/i386/server ALT_HOTSPOT_SERVER_PATH = CACERTS_FILE = ./../src/share/lib/security/cacerts ALT_CACERTS_FILE = CUPS_HEADERS_PATH = /usr/include ALT_CUPS_HEADERS_PATH = OpenJDK-specific settings: FREETYPE_HEADERS_PATH = /usr/include ALT_FREETYPE_HEADERS_PATH = FREETYPE_LIB_PATH = /usr/lib ALT_FREETYPE_LIB_PATH = PLUG_LIBRARY_NAMES = Previous JDK Settings: PREVIOUS_RELEASE_PATH = /NOT-SET/re/jdk/1.6.0/archive/fcs/bundles/linux-i586 ALT_PREVIOUS_RELEASE_PATH = PREVIOUS_JDK_VERSION = 1.6.0 ALT_PREVIOUS_JDK_VERSION = PREVIOUS_JDK_FILE = jdk-6-linux-i586.tar.gz ALT_PREVIOUS_JDK_FILE = PREVIOUS_JRE_FILE = jre-6-linux-i586.tar.gz ALT_PREVIOUS_JRE_FILE = PREVIOUS_RELEASE_IMAGE = ALT_PREVIOUS_RELEASE_IMAGE = Sanity check passed. -------------- next part -------------- An HTML attachment was scrubbed... URL: From kelly.ohair at oracle.com Mon Nov 14 16:34:51 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 14 Nov 2011 08:34:51 -0800 Subject: problem when building openjdk6 In-Reply-To: References: Message-ID: After you apply the fix, you need to start from scratch, delete the build/ directory and start again. -kto On Nov 13, 2011, at 7:10 PM, Li Li wrote: > hi all > I tried to build a debug version of openjdk6. I follows these articles: > http://weblogs.java.net/blog/simonis/archive/2008/01/hotspot_develop.html > http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html > I've got the latest codes and an error occured: > 2045 /usr/bin/gcc -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -fno-omit-fra me-pointer -D_LITTLE_ENDIAN -DARCH='"i586"' -Di586 -DLINUX -DRELEASE='"1.6.0-internal"' -D_LARGEFI LE64_SOURCE -D_GNU_SOURCE -D_REENTRANT -I. -I/media/d/openjdk6/build/linux-i586/tmp/sun/sun.security .pkcs11/j2pkcs11/CClassHeaders -I../../../../src/solaris/javavm/export -I../../../../src/share/javav m/export -I../../../../src/share/javavm/include -I../../../../src/solaris/javavm/include -I../../../ ../src/share/native/sun/security/pkcs11/wrapper -I../../../../src/solaris/native/sun/security/pkcs11 /wrapper -I../../../../src/share/native/common -I../../../../src/solaris/native/common -I../../../.. /src/share/native/sun/security/pkcs11 -I../../../../src/solaris/native/sun/security/pkcs11 -c -o /media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/obj/p11_convert.o ../../../ ../src/share/native/sun/security/pkcs11/wrapper/p11_convert.c > 2046 ../../../../src/share/native/sun/security/pkcs11/j2secmod.c:76:27: error: conflicting types for 'Jav a_sun_security_pkcs11_Secmod_nssGetModuleList' > 2047 /media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/CClassHeaders/sun_security_p kcs11_Secmod.h:49:27: note: previous declaration of 'Java_sun_security_pkcs11_Secmod_nssGetModuleLis t' was here > 2048 make[6]: *** [/media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/obj/j2secmod.o ] Error 1 > I searched a bug in sun's bug database: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058133 > in my make/sun/security/pkcs11/Makefile > There is not any JAVAHFLAGS += -classpath $(CLASSDESTDIR) > So I tried to add this line. But it still failed. > > > The result of make sanity: > make[1]: Entering directory `/media/d/openjdk6/jdk/make' > make[2]: Entering directory `/media/d/openjdk6/jdk/make/tools/freetypecheck' > make[2]: Nothing to be done for `all'. > make[2]: Leaving directory `/media/d/openjdk6/jdk/make/tools/freetypecheck' > make[1]: Leaving directory `/media/d/openjdk6/jdk/make' > > Build Machine Information: > build machine = lili-desktop > > Build Directory Structure: > CWD = /media/d/openjdk6 > TOPDIR = . > LANGTOOLS_TOPDIR = ./langtools > JAXP_TOPDIR = ./jaxp > JAXWS_TOPDIR = ./jaxws > CORBA_TOPDIR = ./corba > HOTSPOT_TOPDIR = ./hotspot > JDK_TOPDIR = ./jdk > > Build Directives: > BUILD_LANGTOOLS = true > BUILD_JAXP = true > BUILD_JAXWS = true > BUILD_CORBA = true > BUILD_HOTSPOT = true > BUILD_JDK = true > DEBUG_CLASSFILES = > DEBUG_BINARIES = > > Hotspot Settings: > HOTSPOT_BUILD_JOBS = > HOTSPOT_OUTPUTDIR = /media/d/openjdk6/build/linux-i586/hotspot/outputdir > HOTSPOT_EXPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import > > > > > Bootstrap Settings: > BOOTDIR = /home/lili/java/jdk1.6.0_26/ > ALT_BOOTDIR = /home/lili/java/jdk1.6.0_26/ > BOOT_VER = 1.6 [requires at least 1.6] > OUTPUTDIR = /media/d/openjdk6/build/linux-i586 > ALT_OUTPUTDIR = /media/d/openjdk6/build/linux-i586 > ABS_OUTPUTDIR = /media/d/openjdk6/build/linux-i586 > > Build Tool Settings: > SLASH_JAVA = /NOT-SET > ALT_SLASH_JAVA = > VARIANT = OPT > JDK_DEVTOOLS_DIR = /NOT-SET/devtools > ALT_JDK_DEVTOOLS_DIR = > ANT_HOME = > UNIXCOMMAND_PATH = /bin/ > ALT_UNIXCOMMAND_PATH = > COMPILER_PATH = /usr/bin/ > ALT_COMPILER_PATH = > DEVTOOLS_PATH = /usr/bin/ > ALT_DEVTOOLS_PATH = > UNIXCCS_PATH = /usr/ccs/bin/ > ALT_UNIXCCS_PATH = > USRBIN_PATH = /usr/bin/ > ALT_USRBIN_PATH = > MOTIF_DIR = /usr > ALT_MOTIF_DIR = > MOTIF_REQUIRED = false > COMPILER_NAME = GCC > COMPILER_VERSION = > CC_VER = 4.5 [requires at least 3.2] > ZIP_VER = 3.0 [requires at least 2.2] > UNZIP_VER = 6.00 [requires at least 5.12] > ANT_VER = 1.8 [requires at least 1.6.3] > TEMPDIR = /media/d/openjdk6/build/linux-i586/tmp > > Build Directives: > OPENJDK = true > USE_HOTSPOT_INTERPRETER_MODE = > PEDANTIC = > DEV_ONLY = > NO_DOCS = > NO_IMAGES = > TOOLS_ONLY = > INSANE = > COMPILE_APPROACH = parallel > PARALLEL_COMPILE_JOBS = 2 > ALT_PARALLEL_COMPILE_JOBS = > FASTDEBUG = > COMPILER_WARNINGS_FATAL = false > COMPILER_WARNING_LEVEL = > INCREMENTAL_BUILD = false > CC_HIGHEST_OPT = -O3 > CC_HIGHER_OPT = -O3 > CC_LOWER_OPT = -O2 > CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN > CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN > BOOT_JAVA_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m > BOOT_JAVAC_CMD = /home/lili/java/jdk1.6.0_26//bin/javac -J-XX:ThreadStackSize=768 -J-client -J-Xmx896m -J-Xms128m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -encoding ascii -source 5 -target 5 -XDignore.symbol.file=true > BOOT_JAR_CMD = /home/lili/java/jdk1.6.0_26//bin/jar > BOOT_JARSIGNER_CMD = /home/lili/java/jdk1.6.0_26//bin/jarsigner > JAVAC_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -jar /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -source 1.5 -target 5 -encoding ascii -Xbootclasspath:/media/d/openjdk6/build/linux-i586/classes > JAVAH_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javah.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -jar /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javah.jar -bootclasspath /media/d/openjdk6/build/linux-i586/classes > JAVADOC_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/doclets.jar -jar /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar > > Build Platform Settings: > USER = lili > PLATFORM = linux > ARCH = i586 > LIBARCH = i386 > ARCH_FAMILY = i586 > ARCH_DATA_MODEL = 32 > ARCHPROP = i386 > LINUX_VERSION = Unknown linux > ALSA_VERSION = 1.0.24.1 > OS_VERSION = 2.6.38-12-generic [requires at least 2.4.9-e.3] > OS_NAME = linux > MB_OF_MEMORY = 3527 > > GNU Make Settings: > MAKE = make > MAKE_VER = 3.81 [requires at least 3.78] > MAKECMDGOALS = sanity > MAKEFLAGS = w > SHELL = /bin/sh > > Target Build Versions: > JDK_VERSION = 1.6.0 > MILESTONE = internal > RELEASE = 1.6.0-internal > FULL_VERSION = 1.6.0-internal-lili_11_nov_2011_19_32-b00 > BUILD_NUMBER = b00 > > External File/Binary Locations: > USRJDKINSTANCES_PATH = /opt/java > BUILD_JDK_IMPORT_PATH = /NOT-SET/re/openjdk/6/promoted/latest/binaries > ALT_BUILD_JDK_IMPORT_PATH = > JDK_IMPORT_PATH = /NOT-SET/re/openjdk/6/promoted/latest/binaries/linux-i586 > ALT_JDK_IMPORT_PATH = > LANGTOOLS_DIST = /media/d/openjdk6/build/linux-i586/langtools/dist > ALT_LANGTOOLS_DIST = /media/d/openjdk6/build/linux-i586/langtools/dist > CORBA_DIST = /media/d/openjdk6/build/linux-i586/corba/dist > ALT_CORBA_DIST = /media/d/openjdk6/build/linux-i586/corba/dist > JAXP_DIST = /media/d/openjdk6/build/linux-i586/jaxp/dist > ALT_JAXP_DIST = /media/d/openjdk6/build/linux-i586/jaxp/dist > JAXWS_DIST = /media/d/openjdk6/build/linux-i586/jaxws/dist > ALT_JAXWS_DIST = /media/d/openjdk6/build/linux-i586/jaxws/dist > HOTSPOT_DOCS_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import/docs > ALT_HOTSPOT_DOCS_IMPORT_PATH = > HOTSPOT_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import > ALT_HOTSPOT_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import > HOTSPOT_CLIENT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import/jre/lib/i386/client > ALT_HOTSPOT_CLIENT_PATH = > HOTSPOT_SERVER_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import/jre/lib/i386/server > ALT_HOTSPOT_SERVER_PATH = > CACERTS_FILE = ./../src/share/lib/security/cacerts > ALT_CACERTS_FILE = > CUPS_HEADERS_PATH = /usr/include > ALT_CUPS_HEADERS_PATH = > > OpenJDK-specific settings: > FREETYPE_HEADERS_PATH = /usr/include > ALT_FREETYPE_HEADERS_PATH = > FREETYPE_LIB_PATH = /usr/lib > ALT_FREETYPE_LIB_PATH = > PLUG_LIBRARY_NAMES = > > Previous JDK Settings: > PREVIOUS_RELEASE_PATH = /NOT-SET/re/jdk/1.6.0/archive/fcs/bundles/linux-i586 > ALT_PREVIOUS_RELEASE_PATH = > PREVIOUS_JDK_VERSION = 1.6.0 > ALT_PREVIOUS_JDK_VERSION = > PREVIOUS_JDK_FILE = jdk-6-linux-i586.tar.gz > ALT_PREVIOUS_JDK_FILE = > PREVIOUS_JRE_FILE = jre-6-linux-i586.tar.gz > ALT_PREVIOUS_JRE_FILE = > PREVIOUS_RELEASE_IMAGE = > ALT_PREVIOUS_RELEASE_IMAGE = > > > Sanity check passed. -------------- next part -------------- An HTML attachment was scrubbed... URL: From sean.coffey at oracle.com Mon Nov 14 16:46:10 2011 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Mon, 14 Nov 2011 16:46:10 +0000 Subject: problem when building openjdk6 - CR 7058133 In-Reply-To: References: Message-ID: <4EC145D2.10901@oracle.com> I ran into the same issue last week. I'm hoping to push some RMI changes to 6-open shortly. Will push 7058133 in there also. regards, Sean. On 14/11/11 16:34, Kelly O'Hair wrote: > After you apply the fix, you need to start from scratch, delete the > build/ directory and start again. > > -kto > > On Nov 13, 2011, at 7:10 PM, Li Li wrote: > >> hi all >> I tried to build a debug version of openjdk6. I follows these >> articles: >> http://weblogs.java.net/blog/simonis/archive/2008/01/hotspot_develop.html >> http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html >> I've got the latest codes and an error occured: >> 2045 /usr/bin/gcc -O2 -fno-strict-aliasing -fPIC -W -Wall >> -Wno-unused -Wno-parentheses -fno-omit-fra me-pointer >> -D_LITTLE_ENDIAN -DARCH='"i586"' -Di586 -DLINUX >> -DRELEASE='"1.6.0-internal"' -D_LARGEFI LE64_SOURCE -D_GNU_SOURCE >> -D_REENTRANT -I. >> -I/media/d/openjdk6/build/linux-i586/tmp/sun/sun.security >> .pkcs11/j2pkcs11/CClassHeaders >> -I../../../../src/solaris/javavm/export -I../../../../src/share/javav >> m/export -I../../../../src/share/javavm/include >> -I../../../../src/solaris/javavm/include -I../../../ >> ../src/share/native/sun/security/pkcs11/wrapper >> -I../../../../src/solaris/native/sun/security/pkcs11 /wrapper >> -I../../../../src/share/native/common >> -I../../../../src/solaris/native/common -I../../../.. >> /src/share/native/sun/security/pkcs11 >> -I../../../../src/solaris/native/sun/security/pkcs11 -c -o >> /media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/obj/p11_convert.o >> ../../../ >> ../src/share/native/sun/security/pkcs11/wrapper/p11_convert.c >> 2046 >> ../../../../src/share/native/sun/security/pkcs11/j2secmod.c:76:27: >> error: conflicting types for 'Jav >> a_sun_security_pkcs11_Secmod_nssGetModuleList' >> 2047 >> /media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/CClassHeaders/sun_security_p >> kcs11_Secmod.h:49:27: note: previous declaration of >> 'Java_sun_security_pkcs11_Secmod_nssGetModuleLis t' was here >> 2048 make[6]: *** >> [/media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/obj/j2secmod.o >> ] Error 1 >> I searched a bug in sun's bug database: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058133 >> in my make/sun/security/pkcs11/Makefile >> There is not any JAVAHFLAGS += -classpath $(CLASSDESTDIR) >> So I tried to add this line. But it still failed. >> >> The result of make sanity: >> make[1]: Entering directory `/media/d/openjdk6/jdk/make' >> make[2]: Entering directory >> `/media/d/openjdk6/jdk/make/tools/freetypecheck' >> make[2]: Nothing to be done for `all'. >> make[2]: Leaving directory >> `/media/d/openjdk6/jdk/make/tools/freetypecheck' >> make[1]: Leaving directory `/media/d/openjdk6/jdk/make' >> >> Build Machine Information: >> build machine = lili-desktop >> >> Build Directory Structure: >> CWD = /media/d/openjdk6 >> TOPDIR = . >> LANGTOOLS_TOPDIR = ./langtools >> JAXP_TOPDIR = ./jaxp >> JAXWS_TOPDIR = ./jaxws >> CORBA_TOPDIR = ./corba >> HOTSPOT_TOPDIR = ./hotspot >> JDK_TOPDIR = ./jdk >> >> Build Directives: >> BUILD_LANGTOOLS = true >> BUILD_JAXP = true >> BUILD_JAXWS = true >> BUILD_CORBA = true >> BUILD_HOTSPOT = true >> BUILD_JDK = true >> DEBUG_CLASSFILES = >> DEBUG_BINARIES = >> >> Hotspot Settings: >> HOTSPOT_BUILD_JOBS = >> HOTSPOT_OUTPUTDIR = >> /media/d/openjdk6/build/linux-i586/hotspot/outputdir >> HOTSPOT_EXPORT_PATH = >> /media/d/openjdk6/build/linux-i586/hotspot/import >> >> >> >> Bootstrap Settings: >> BOOTDIR = /home/lili/java/jdk1.6.0_26/ >> ALT_BOOTDIR = /home/lili/java/jdk1.6.0_26/ >> BOOT_VER = 1.6 [requires at least 1.6] >> OUTPUTDIR = /media/d/openjdk6/build/linux-i586 >> ALT_OUTPUTDIR = /media/d/openjdk6/build/linux-i586 >> ABS_OUTPUTDIR = /media/d/openjdk6/build/linux-i586 >> Build Tool Settings: >> SLASH_JAVA = /NOT-SET >> ALT_SLASH_JAVA = >> VARIANT = OPT >> JDK_DEVTOOLS_DIR = /NOT-SET/devtools >> ALT_JDK_DEVTOOLS_DIR = >> ANT_HOME = >> UNIXCOMMAND_PATH = /bin/ >> ALT_UNIXCOMMAND_PATH = >> COMPILER_PATH = /usr/bin/ >> ALT_COMPILER_PATH = >> DEVTOOLS_PATH = /usr/bin/ >> ALT_DEVTOOLS_PATH = >> UNIXCCS_PATH = /usr/ccs/bin/ >> ALT_UNIXCCS_PATH = >> USRBIN_PATH = /usr/bin/ >> ALT_USRBIN_PATH = >> MOTIF_DIR = /usr >> ALT_MOTIF_DIR = >> MOTIF_REQUIRED = false >> COMPILER_NAME = GCC >> COMPILER_VERSION = >> CC_VER = 4.5 [requires at least 3.2] >> ZIP_VER = 3.0 [requires at least 2.2] >> UNZIP_VER = 6.00 [requires at least 5.12] >> ANT_VER = 1.8 [requires at least 1.6.3] >> TEMPDIR = /media/d/openjdk6/build/linux-i586/tmp >> Build Directives: >> OPENJDK = true >> USE_HOTSPOT_INTERPRETER_MODE = >> PEDANTIC = >> DEV_ONLY = >> NO_DOCS = >> NO_IMAGES = >> TOOLS_ONLY = >> INSANE = >> COMPILE_APPROACH = parallel >> PARALLEL_COMPILE_JOBS = 2 >> ALT_PARALLEL_COMPILE_JOBS = >> FASTDEBUG = >> COMPILER_WARNINGS_FATAL = false >> COMPILER_WARNING_LEVEL = >> INCREMENTAL_BUILD = false >> CC_HIGHEST_OPT = -O3 >> CC_HIGHER_OPT = -O3 >> CC_LOWER_OPT = -O2 >> CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused >> -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN >> CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused >> -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN >> BOOT_JAVA_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client >> -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m >> BOOT_JAVAC_CMD = /home/lili/java/jdk1.6.0_26//bin/javac >> -J-XX:ThreadStackSize=768 -J-client -J-Xmx896m -J-Xms128m >> -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -encoding ascii -source 5 >> -target 5 -XDignore.symbol.file=true >> BOOT_JAR_CMD = /home/lili/java/jdk1.6.0_26//bin/jar >> BOOT_JARSIGNER_CMD = /home/lili/java/jdk1.6.0_26//bin/jarsigner >> JAVAC_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m >> -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m >> -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar >> -jar >> /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar >> -source 1.5 -target 5 -encoding ascii >> -Xbootclasspath:/media/d/openjdk6/build/linux-i586/classes >> JAVAH_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m >> -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m >> -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javah.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar >> -jar >> /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javah.jar >> -bootclasspath /media/d/openjdk6/build/linux-i586/classes >> JAVADOC_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client >> -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m >> -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/doclets.jar >> -jar >> /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar >> Build Platform Settings: >> USER = lili >> PLATFORM = linux >> ARCH = i586 >> LIBARCH = i386 >> ARCH_FAMILY = i586 >> ARCH_DATA_MODEL = 32 >> ARCHPROP = i386 >> LINUX_VERSION = Unknown linux >> ALSA_VERSION = 1.0.24.1 >> OS_VERSION = 2.6.38-12-generic [requires at least 2.4.9-e.3] >> OS_NAME = linux >> MB_OF_MEMORY = 3527 >> GNU Make Settings: >> MAKE = make >> MAKE_VER = 3.81 [requires at least 3.78] >> MAKECMDGOALS = sanity >> MAKEFLAGS = w >> SHELL = /bin/sh >> Target Build Versions: >> JDK_VERSION = 1.6.0 >> MILESTONE = internal >> RELEASE = 1.6.0-internal >> FULL_VERSION = 1.6.0-internal-lili_11_nov_2011_19_32-b00 >> BUILD_NUMBER = b00 >> External File/Binary Locations: >> USRJDKINSTANCES_PATH = /opt/java >> BUILD_JDK_IMPORT_PATH = /NOT-SET/re/openjdk/6/promoted/latest/binaries >> ALT_BUILD_JDK_IMPORT_PATH = >> JDK_IMPORT_PATH = >> /NOT-SET/re/openjdk/6/promoted/latest/binaries/linux-i586 >> ALT_JDK_IMPORT_PATH = >> LANGTOOLS_DIST = /media/d/openjdk6/build/linux-i586/langtools/dist >> ALT_LANGTOOLS_DIST = >> /media/d/openjdk6/build/linux-i586/langtools/dist >> CORBA_DIST = /media/d/openjdk6/build/linux-i586/corba/dist >> ALT_CORBA_DIST = /media/d/openjdk6/build/linux-i586/corba/dist >> JAXP_DIST = /media/d/openjdk6/build/linux-i586/jaxp/dist >> ALT_JAXP_DIST = /media/d/openjdk6/build/linux-i586/jaxp/dist >> JAXWS_DIST = /media/d/openjdk6/build/linux-i586/jaxws/dist >> ALT_JAXWS_DIST = /media/d/openjdk6/build/linux-i586/jaxws/dist >> HOTSPOT_DOCS_IMPORT_PATH = >> /media/d/openjdk6/build/linux-i586/hotspot/import/docs >> ALT_HOTSPOT_DOCS_IMPORT_PATH = >> HOTSPOT_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import >> ALT_HOTSPOT_IMPORT_PATH = >> /media/d/openjdk6/build/linux-i586/hotspot/import >> HOTSPOT_CLIENT_PATH = >> /media/d/openjdk6/build/linux-i586/hotspot/import/jre/lib/i386/client >> ALT_HOTSPOT_CLIENT_PATH = >> HOTSPOT_SERVER_PATH = >> /media/d/openjdk6/build/linux-i586/hotspot/import/jre/lib/i386/server >> ALT_HOTSPOT_SERVER_PATH = >> CACERTS_FILE = ./../src/share/lib/security/cacerts >> ALT_CACERTS_FILE = >> CUPS_HEADERS_PATH = /usr/include >> ALT_CUPS_HEADERS_PATH = >> OpenJDK-specific settings: >> FREETYPE_HEADERS_PATH = /usr/include >> ALT_FREETYPE_HEADERS_PATH = >> FREETYPE_LIB_PATH = /usr/lib >> ALT_FREETYPE_LIB_PATH = >> PLUG_LIBRARY_NAMES = >> Previous JDK Settings: >> PREVIOUS_RELEASE_PATH = >> /NOT-SET/re/jdk/1.6.0/archive/fcs/bundles/linux-i586 >> ALT_PREVIOUS_RELEASE_PATH = >> PREVIOUS_JDK_VERSION = 1.6.0 >> ALT_PREVIOUS_JDK_VERSION = >> PREVIOUS_JDK_FILE = jdk-6-linux-i586.tar.gz >> ALT_PREVIOUS_JDK_FILE = >> PREVIOUS_JRE_FILE = jre-6-linux-i586.tar.gz >> ALT_PREVIOUS_JRE_FILE = >> PREVIOUS_RELEASE_IMAGE = >> ALT_PREVIOUS_RELEASE_IMAGE = >> >> >> Sanity check passed. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From nhann at chalmers.se Wed Nov 16 15:07:39 2011 From: nhann at chalmers.se (Dang Nhan Nguyen) Date: Wed, 16 Nov 2011 15:07:39 +0000 Subject: Profiling the hotspot (further questions), In-Reply-To: <4EBE9F84.9000607@oracle.com> References: <4EBDE6CC.2060105@oracle.com> <4EBE23C0.1070607@oracle.com> <4EBE9F84.9000607@oracle.com> Message-ID: Thanks Charlie and Jon, The guide did help me a lot, and I can do the profiling with Collector/Analyzer. As I was doing, I have a couple of questions which I described below. I used collector-analyzer in Solaris Studio Performance Analyzing to keep track of performance of CMS. The I used Analyser GUI interface to analyze the recording result. In the interface, I used tab Functions and filter out all the library except for pthread and jvm library. The I look at the execution time of different methods of classes that related to CMS (CMSCollector, CMSConcMarkingTask....) The result I got is ALMOST enough which showed me the time for phases in CMS collector, which were the concurrent marking phase (time that CMSConcMarkingTask.work() was executed), remark phase (CMSParRemarkTask.work() was executed) and sweep (CMSCollector.sweep()) But then I encounter a couple of issues: 1. The initial mark phase was not record. In all my measures, I found no record for CMSCollector::checkpointRootsInitialWork(), which is the method that performs initial marking phase. Why "collector" collect information of certain methods (e.g CMSCollector::collect_in_background(), sweep()...) but not the others? How can I force the collect (of collector/analyzer) to record this method? 2. As with concurrent marking phases, is the inclusive CPU time (in Performance Analyzer) to execute CMSConcMarkingTask.work() is sufficient for concurrent marking phase. The reason for this question is due to my observations (please correct me if I'm wrong): - concurrent marking will use GangWorker to perform the sub-tasks generated by CMSConcMarkingTask. - In turn, this Gangworker will call CMSConcMarkingTask.work(i) to perform the sub-tasks. - CMSConcMarkingTask.work(i) then calls CMSConcMarkingTask::do_scan_and_mark() in which a Par_MarkFromRootsClosure object is created and iterate over the MarkBitMap of CMS. My concern is that if I consider time to execute CMSConcMarkingTask.work() (the inclusive CPU time) is the time spending on CMS Concurrent marking phase, is it sufficient in the respect that it includes all the works in concurernt marking phases? Or should I include any other additional works done in this phase? If so, what are they? Cheers, --Nhan > -----Original Message----- > From: charlie hunt [mailto:charlie.hunt at oracle.com] > Sent: Saturday, November 12, 2011 5:32 PM > To: Dang Nhan Nguyen > Cc: Jon Masamitsu; build-dev at openjdk.java.net; hotspot-gc- > dev at openjdk.java.net > Subject: Re: Profiling the hotspot, > > Hi Nhan, > > This is a bit long winded ... hopefully you'll find it useful though. > > If you are wanting to only view HotSpot method names in the profile and > not also view HotSpot source code embedded in the profile and/or not > profile with hardware/CPU counters, then you do not need to build > anything special to see HotSpot method names with Oracle Solaris Studio > Performance Analyzer, (aka collector analyzer). > > Btw, don't let "Solaris" embedded in the product name deter you. > Although the official product name is "Oracle Solaris Studio", it is > also available on Linux. Because the product was originally built for > Solaris (both x86 and SPARC), its more mature on Solaris than Linux, > (the Linux port was done a couple years ago -- fwiw, I almost always > profile on Solaris since it is more mature and I can get hardware > counter info "out of the box"). The Linux version requires a (fairly) > recent kernel, i.e. Red Hat EL 5, SuSE ES 11 or Oracle Enterprise Linux > 5 or more recent versions. Other variants of Linux may work, i.e. > Ubuntu (I've run it on recent Ubuntu releases). > > If you want to see hardware/CPU counters info in the profile, then see > the section below "Hardware/CPU Counter Profiling" > > If you want to see HotSpot source code embedded in the profile, then > see > the section below "Embedded HotSpot Source Code". > > To limit the amount data collected in the profile, you can use > collect's > -y option to toggle on and toggle off profile gathering. > > To help find what you are looking for in tracing GC thread(s) activity, > once you look at the profile in Analyzer, I'd suggest to start by > looking at the Timeline tab where you see a row for every thread in the > JVM and Java application. Although each row doesn't list the thread > name, (an enhancement I've asked for), you can click in a given thread > row and look at the Call Stack panel to get a sense of which thread it > is. The Timeline will also show when the thread was busy. You could > use the Timeline and Call Stack panel to figure out what phase CMS is > in. From there you can filter the profile data based on the time line > info and for those CMS threads. That'll allow you to look specifically > at the CMS threads and when they are running. > > There's an intro to how to use Performance Analyzer in the Java > Performance book, but (unfortunately) it does not explicitly show your > use case. It does, however, offer an intro of the basic concepts. > There's also some really good documentation available at the Oracle > Solaris Studio product web site: > http://www.oracle.com/technetwork/server- > storage/solarisstudio/overview/index-jsp-138069.html > > There is also some tutorials in the product distribution that can help > get you familiar with the tool. > > Download page is: > http://www.oracle.com/technetwork/server- > storage/solarisstudio/downloads/index.html > > Hardware/CPU Counter Profiling > > If you want to see hardware/CPU counters info in the profile, then, on > Linux, you have to patch the kernel. Fwiw, patching the kernel is not > needed for Solaris (x86 or SPARC). If you want to see what hardware > counters are available, a simple 'collect' command with no args will > printout hardware counters that can be profiled. There's also a > section > in the Java Performance book that describes how to profile with > hardware/CPU counters. > > Embedded HotSpot Source Code > > If you want to see the HotSpot source code embedded in the profile, > then > you need to do a custom build of HotSpot. There's a couple ways you > can > accomplish what you need and what I list here is not necessary the best > way, or the only way. Hopefully the instructions below are not out of > date. These worked for me about 6 months ago. I'm sure there's others > who can offer an easier approach or offer corrections, (I'm not a > HotSpot build expert). > This is what I've done on Linux: > 1. After getting a copy of the HotSpot source code from the source code > repository > 2. Edit the /make/linux/makefiles/amd64.make file. > 3. Append -g0 to the line, OPT_CFLAGS/compactingPermGenGen.o = -O1 > i.e. OPT_CFLAGS/compactingPermGenGen.o = -O1 -g0 > 4. Edit the /make/linux/makefiles/gcc.make file. > 5. Append -g0 to the line, OPT_CFLAGS += -O3 i.e. OPT_CFLAGS += -O3 - > g0 > 6. Append -gdwarf-2 to the line, OPT_CFLAGS += -fno-strict-aliasing > i.e. OPT_CFLAGS += -fno-strict-aliasing -gdwarf-2 > 7. Append -g0 to the line, OPT_CFLAGS/NOOPT=-O0 i.e. > OPT_CFLAGS/NOOPT=-O0 -g0 > 8. Append -g0 to the line, OPT_CFLAGS/mulnode.o += -O0 i.e. > OPT_CFLAGS/mulnode.o += -O0 -g0 > 9. Change this line, DEBUG_CFLAGS += -gstabs, to DEBUG_CFLAGS += - > gdwarf-2 > 10. Edit the /make/linux/makefiles/product.make file. > 11. Comment out these two lines: > STRIP_LIBJVM = $(STRIP) -g $@ || exit 1; > STRIP_AOUT = $(STRIP) -x $@ || exit 1; > i.e. > #STRIP_LIBJVM = $(STRIP) -g $@ || exit 1; > #STRIP_AOUT = $(STRIP) -x $@ || exit 1; > 12. Now build HotSpot using the "product" target and build for either > 64-bit or 32-bit, i.e. to build 64-bit libjvm.so do, $ gmake LP64=1 > product > > hths, > > charlie ... > > On 11/12/11 01:44 AM, Jon Masamitsu wrote: > > Take a look at Charlie's blog about the collector analyzer tools > > > > http://blogs.oracle.com/charliebrown/entry/free_sun_studio_12_and > > > > And the quick start guide > > > > http://dsc.sun.com/solaris/articles/analyzer_qs.html > > > > The profiling build target in hotspot was deleted because they > > were not being used and I believe were not building correctly. > > > > > > On 11/11/2011 7:23 PM, David Holmes wrote: > >> As this mainly concerns GC profiling I've cc'ed the GC list. > >> > >> David > >> > >> On 12/11/2011 2:22 AM, Dang Nhan Nguyen wrote: > >>> Hi, > >>> > >>> I need to measure some performance (mostly running time) of GC > (CMS) > >>> while running on multi-core platform on Linux. I want to break down > >>> the cost of each phase in CMS and some related method. And I am > >>> thinking of performance profiling tool to do that. > >>> > >>> I have look at the build files and see that there used to be some > >>> "profiled" target for profiling hotspot. However, it was removed > now > >>> (don't know why). > >>> > >>> Now, I am looking for a way to do the profiling. As my experience > >>> with profiling the hotspot on Windows (using Visual Studio), the > >>> generated of profiling data is huge (2-6GB) and in many cases, my > >>> computer could not handle the analysis of profiling data. In > >>> addition, hotspot's code and its build are quite complex, I want to > >>> consult some opinions first before actually do it. > >>> > >>> I am grateful if you can suggest a way to build the hotspot on > Linux > >>> for profiling purpose. > >>> > >>> Thank you, > >>> Nhan Nguyen > >>> > >>> > From kumar.x.srinivasan at oracle.COM Wed Nov 16 19:47:15 2011 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Wed, 16 Nov 2011 11:47:15 -0800 Subject: Please review 7112160 Message-ID: <4EC41343.4000108@oracle.COM> Hi, Here is a tiny change to increase the heap space for javadoc, during the jdk build, this allows the build to complete and speeds up the build as well. fyi. The heap space was on the borderline of running out of heap and cause an OOM, some recent changes have increased the memory requirement, and tipped the scale over. http://cr.openjdk.java.net/~ksrini/7112160/ Thanks Kumar From kelly.ohair at oracle.com Wed Nov 16 20:15:37 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 16 Nov 2011 12:15:37 -0800 Subject: Please review 7112160 In-Reply-To: <4EC41343.4000108@oracle.COM> References: <4EC41343.4000108@oracle.COM> Message-ID: Looks fine. -kto On Nov 16, 2011, at 11:47 AM, Kumar Srinivasan wrote: > Hi, > > Here is a tiny change to increase the heap space for javadoc, during the > jdk build, this allows the build to complete and speeds up the build as well. > > fyi. The heap space was on the borderline of running out of heap and cause > an OOM, some recent changes have increased the memory requirement, > and tipped the scale over. > > http://cr.openjdk.java.net/~ksrini/7112160/ > > Thanks > Kumar > From david.katleman at oracle.com Wed Nov 16 20:21:15 2011 From: david.katleman at oracle.com (David Katleman) Date: Wed, 16 Nov 2011 12:21:15 -0800 Subject: Please review 7112160 In-Reply-To: <4EC41343.4000108@oracle.COM> References: <4EC41343.4000108@oracle.COM> Message-ID: <4EC41B3B.7020800@oracle.com> Hi Kumar, Looks fine, thanks! Dave On 11/16/2011 11:47 AM, Kumar Srinivasan wrote: > Hi, > > Here is a tiny change to increase the heap space for javadoc, during the > jdk build, this allows the build to complete and speeds up the build > as well. > > fyi. The heap space was on the borderline of running out of heap and > cause > an OOM, some recent changes have increased the memory requirement, > and tipped the scale over. > > http://cr.openjdk.java.net/~ksrini/7112160/ > > Thanks > Kumar > From mike.duigou at oracle.com Wed Nov 16 20:40:36 2011 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 16 Nov 2011 12:40:36 -0800 Subject: Please review 7112160 (Kumar Srinivasan) In-Reply-To: References: Message-ID: Since this is the maximum memory limit and not a specified allocation why not go right to 1GB? The netbeans launcher scripts also have some nice code which could determine an appropriate maximum for a given configuration. Mike On Nov 16 2011, at 12:00 , build-dev-request at openjdk.java.net wrote: > Hi, > > Here is a tiny change to increase the heap space for javadoc, during the > jdk build, this allows the build to complete and speeds up the build as > well. > > fyi. The heap space was on the borderline of running out of heap and cause > an OOM, some recent changes have increased the memory requirement, > and tipped the scale over. > > http://cr.openjdk.java.net/~ksrini/7112160/ > > Thanks > Kumar From kelly.ohair at oracle.com Wed Nov 16 20:55:03 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 16 Nov 2011 12:55:03 -0800 Subject: Please review 7112160 (Kumar Srinivasan) In-Reply-To: References: Message-ID: <38605121-08C9-4DD9-97B2-3E0B69934ADD@oracle.com> On windows, it's more of a "give me a block of memory this big", and sometimes even if the system has 4GB, it might not have a 1GB hole to give you. :^( So java just dies on startup. And if you make this number > RAM, the Linux/Solaris systems could very easily just page thrash. We could declare that 2GB RAM is the minimum now, on all systems, and do as you say, but there are people out there with less RAM, I think... not me... -kto On Nov 16, 2011, at 12:40 PM, Mike Duigou wrote: > Since this is the maximum memory limit and not a specified allocation why not go right to 1GB? > > The netbeans launcher scripts also have some nice code which could determine an appropriate maximum for a given configuration. > > Mike > > On Nov 16 2011, at 12:00 , build-dev-request at openjdk.java.net wrote: >> Hi, >> >> Here is a tiny change to increase the heap space for javadoc, during the >> jdk build, this allows the build to complete and speeds up the build as >> well. >> >> fyi. The heap space was on the borderline of running out of heap and cause >> an OOM, some recent changes have increased the memory requirement, >> and tipped the scale over. >> >> http://cr.openjdk.java.net/~ksrini/7112160/ >> >> Thanks >> Kumar From david.katleman at sun.com Wed Nov 16 23:23:24 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 16 Nov 2011 23:23:24 +0000 Subject: hg: jdk8/build: 6 new changesets Message-ID: <20111116232324.6DABC47394@hg.openjdk.java.net> Changeset: 8da26d5c32a7 Author: katleman Date: 2011-11-10 11:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/8da26d5c32a7 Added tag jdk8-b13 for changeset 26fb81a1e9ce ! .hgtags Changeset: a62a0f35eb9c Author: asaha Date: 2011-06-27 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/a62a0f35eb9c Merge Changeset: f9b3e6b2aa2c Author: asaha Date: 2011-06-28 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/f9b3e6b2aa2c Merge Changeset: ea2ab83ce564 Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/ea2ab83ce564 Merge Changeset: 8f525559ae73 Author: asaha Date: 2011-11-07 21:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/8f525559ae73 Merge Changeset: 23aa7f2c80a2 Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/23aa7f2c80a2 Merge From david.katleman at sun.com Wed Nov 16 23:23:34 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 16 Nov 2011 23:23:34 +0000 Subject: hg: jdk8/build/corba: 7 new changesets Message-ID: <20111116232339.4268647395@hg.openjdk.java.net> Changeset: 6f601a737e0f Author: katleman Date: 2011-11-10 11:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/6f601a737e0f Added tag jdk8-b13 for changeset 5b9d9b839d3d ! .hgtags Changeset: d84682019b5f Author: asaha Date: 2011-06-27 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/d84682019b5f Merge Changeset: 9c20c1e7cdd9 Author: asaha Date: 2011-06-28 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/9c20c1e7cdd9 Merge Changeset: cb5aec0570a5 Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/cb5aec0570a5 Merge Changeset: 21369018a679 Author: mbankal Date: 2011-08-09 05:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/21369018a679 7055902: Oracle Java IIOP Deserialization Type Confusion Remote Code Execution Vulnerability Reviewed-by: coffeys ! src/share/classes/com/sun/corba/se/impl/io/IIOPInputStream.java Changeset: 058c18d237a9 Author: asaha Date: 2011-11-07 21:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/058c18d237a9 Merge Changeset: e59c47de1ad8 Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/e59c47de1ad8 Merge From david.katleman at sun.com Wed Nov 16 23:24:49 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 16 Nov 2011 23:24:49 +0000 Subject: hg: jdk8/build/hotspot: Added tag jdk8-b13 for changeset b92ca8e229d2 Message-ID: <20111116232452.D711547396@hg.openjdk.java.net> Changeset: 088d09a130ff Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/088d09a130ff Added tag jdk8-b13 for changeset b92ca8e229d2 ! .hgtags From david.katleman at sun.com Wed Nov 16 23:26:29 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 16 Nov 2011 23:26:29 +0000 Subject: hg: jdk8/build/jaxp: 6 new changesets Message-ID: <20111116232629.645C547397@hg.openjdk.java.net> Changeset: e7172d80a8f4 Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/e7172d80a8f4 Added tag jdk8-b13 for changeset bcc739229f63 ! .hgtags Changeset: 7adf14d6060c Author: asaha Date: 2011-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/7adf14d6060c Merge Changeset: d239aa024b6e Author: asaha Date: 2011-06-28 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/d239aa024b6e Merge Changeset: eca33f89c823 Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/eca33f89c823 Merge Changeset: 0ed9ae36ee2a Author: asaha Date: 2011-11-07 21:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/0ed9ae36ee2a Merge Changeset: 9d0c9d638757 Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/9d0c9d638757 Merge From david.katleman at sun.com Wed Nov 16 23:26:39 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 16 Nov 2011 23:26:39 +0000 Subject: hg: jdk8/build/jaxws: 8 new changesets Message-ID: <20111116232639.54CD947398@hg.openjdk.java.net> Changeset: f502a343a92e Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/f502a343a92e Added tag jdk8-b13 for changeset adf2a6b5fde1 ! .hgtags Changeset: 75a652e72489 Author: asaha Date: 2011-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/75a652e72489 Merge Changeset: b058cae6fd3b Author: asaha Date: 2011-06-28 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b058cae6fd3b Merge Changeset: 61c046c6895a Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/61c046c6895a Merge Changeset: 9e82b46cd4fa Author: asaha Date: 2011-07-25 11:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/9e82b46cd4fa 7046794: Configurable behavior for server-side stacktraces Reviewed-by: ramap ! jaxws.properties Changeset: c78fccb01d4e Author: asaha Date: 2011-11-07 21:48 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/c78fccb01d4e Merge Changeset: cae6db74d6af Author: asaha Date: 2011-11-10 13:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/cae6db74d6af 7110676: Update jaf source download url for jaxws Reviewed-by: ramap ! jaxws.properties Changeset: 54c4bf4b83ec Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/54c4bf4b83ec Merge From david.katleman at sun.com Wed Nov 16 23:28:55 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 16 Nov 2011 23:28:55 +0000 Subject: hg: jdk8/build/jdk: 56 new changesets Message-ID: <20111116233842.DC4184739A@hg.openjdk.java.net> Changeset: 52bd7fc8fcb0 Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/52bd7fc8fcb0 Added tag jdk8-b13 for changeset 4cb2e8679b27 ! .hgtags Changeset: 9de1dbf8c9be Author: lana Date: 2011-10-26 17:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9de1dbf8c9be Merge - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/tools/jar/JarImageSource.java Changeset: 76defa20906a Author: ngmr Date: 2011-09-23 15:18 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/76defa20906a 7105640: Unix printing does not check the result of exec'd lpr/lp command Summary: Add checking, exception for spool process failure Reviewed-by: prr, jgodinez Contributed-by: Neil Richards ! src/share/classes/sun/print/PSPrinterJob.java ! src/solaris/classes/sun/print/UnixPrintJob.java Changeset: 4544585a3cea Author: lana Date: 2011-11-05 14:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4544585a3cea Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: aa3f5117c485 Author: rupashka Date: 2011-10-17 15:10 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/aa3f5117c485 7099251: javax.swing.text.html.HTMLDocument.insertAfterStart(null, something) throws NPE Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! src/share/classes/javax/swing/text/html/HTMLDocument.java Changeset: 4f74e3fdf86b Author: rupashka Date: 2011-10-17 16:40 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4f74e3fdf86b 7100004: javax.swing.JTable.setAutoCreateRowSorter(boolean autoCreateRowSorter) should mention default value Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! src/share/classes/javax/swing/JTable.java Changeset: f1dbc62c7c6d Author: rupashka Date: 2011-10-17 17:19 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f1dbc62c7c6d 7077293: javax/swing/JComponent/4337267/bug4337267.java failed on windows 2003 Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! src/share/classes/sun/swing/SwingUtilities2.java Changeset: a2f5d7049258 Author: dbuck Date: 2011-10-17 19:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a2f5d7049258 6887286: StackOverflowError at sun.awt.image.ImageWatched$WeakLink.isWatcher Summary: Fixed OffScreenImageSource to call imageComplete() with SINGLEFAMEDONE, not STATICIMAGEDONE. This fixed memory leak (that caused SOFE when we use recursion to iterate over linked list). Reviewed-by: bae ! src/share/classes/sun/awt/image/OffScreenImageSource.java Changeset: 7636a62aba7e Author: anthony Date: 2011-11-01 18:01 +0300 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7636a62aba7e 7104625: sun.awt.X11.XEvent is creating 600 MB of char[] for no good reason Summary: Wrap logging calls with if(){} statements Reviewed-by: anthony, son Contributed-by: Federico Tello Gentile ! src/solaris/classes/sun/awt/X11/XComponentPeer.java Changeset: ac55f169fadd Author: anthony Date: 2011-11-01 18:03 +0300 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ac55f169fadd 7105529: XAWT: Optimize getFieldsAsString() methods generated by WrapperGenerator Summary: Replace string concatenation with StringBuilder.append() Reviewed-by: anthony, son Contributed-by: Federico Tello Gentile ! src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java Changeset: 41610a897379 Author: rupashka Date: 2011-11-02 14:17 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/41610a897379 6624077: Regression test fails: closed/javax/swing/ToolTipManager/6256140/bug6256140.java Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/ToolTipManager/Test6256140.java Changeset: 8068f1584715 Author: mrkam Date: 2011-11-02 17:39 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8068f1584715 7074853: TransparentRuler demos Readme should mention the correct jar file name Reviewed-by: rupashka ! src/share/demo/jfc/TransparentRuler/README.txt Changeset: 323f6d046cc9 Author: rupashka Date: 2011-11-02 23:53 +0300 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/323f6d046cc9 7049024: DnD fails with JTextArea and JTextField Reviewed-by: rupashka Contributed-by: Sean Chou ! src/share/classes/javax/swing/text/DefaultCaret.java + test/javax/swing/JTextArea/7049024/bug7049024.java Changeset: 7c29751a9331 Author: rupashka Date: 2011-11-03 14:14 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7c29751a9331 6955919: Intermittent ClassCastException in bug4492274 test Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JEditorPane/4492274/bug4492274.java + test/javax/swing/JEditorPane/4492274/test.html Changeset: 1c0624d9a2b6 Author: ngmr Date: 2011-10-13 13:02 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1c0624d9a2b6 7107957: AWT: Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Summary: Use POSIX defined includes for unistd.h and fcntl.h Reviewed-by: anthony, ngmr Contributed-by: Charles Lee ! src/solaris/native/sun/awt/splashscreen/splashscreen_config.h Changeset: adb31ff942ef Author: rupashka Date: 2011-11-07 16:50 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/adb31ff942ef 7080203: JTree.getSelectionPaths() now returns empty array instead of null Reviewed-by: malenkov ! src/share/classes/javax/swing/JTree.java Changeset: d219e0b11327 Author: lana Date: 2011-11-07 10:26 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d219e0b11327 Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/classes/sun/tools/jar/JarImageSource.java - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c - src/share/native/sun/rmi/server/MarshalInputStream.c - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: f8a3dff76b48 Author: rupashka Date: 2011-11-08 14:36 +0300 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f8a3dff76b48 7107585: Test incorrect calculate position of object on frame Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JSlider/6348946/bug6348946.java Changeset: af4fb33fca29 Author: lana Date: 2011-11-08 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/af4fb33fca29 Merge Changeset: 88a260444e4d Author: chegar Date: 2011-10-26 13:58 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/88a260444e4d 7104650: rawtype warnings in several net, nio and security source files Summary: Also reviewed by Ulf.Zibis at gmx.de Reviewed-by: mcimadamore, alanb, dholmes ! make/sun/net/Makefile ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/security/Security.java ! src/share/classes/sun/nio/ch/Util.java Changeset: 0d371f2911a1 Author: peytoia Date: 2011-10-26 22:16 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0d371f2911a1 7090046: Lots of invalid link in java.text.BreakIterator comments Reviewed-by: okutsu ! src/share/classes/java/text/BreakIterator.java Changeset: 291b55aa9b1e Author: lana Date: 2011-10-25 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/291b55aa9b1e Merge - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c Changeset: 64faf533b99d Author: lana Date: 2011-10-26 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/64faf533b99d Merge Changeset: 449113aea001 Author: weijun Date: 2011-10-27 17:23 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/449113aea001 7104161: test/sun/tools/jinfo/Basic.sh fails on Ubuntu Reviewed-by: alanb ! test/sun/tools/jinfo/Basic.sh Changeset: 64ccf18bbad5 Author: coffeys Date: 2011-10-27 10:32 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/64ccf18bbad5 7099658: Properties.loadFromXML fails with ClassCastException Reviewed-by: alanb, mchung ! src/share/classes/sun/util/xml/XMLUtils.java Changeset: 56cc907fc8dc Author: mullan Date: 2011-10-27 10:57 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/56cc907fc8dc 7094155: JSR105 code throws javax.xml.crypto.URIReferenceException when running into Java 7 VM Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java ! test/javax/xml/crypto/dsig/GenerationTests.java Changeset: 8cd2e3b8127a Author: mullan Date: 2011-10-27 11:01 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8cd2e3b8127a Merge - make/sun/rmi/rmi/mapfile-vers - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c - src/share/native/sun/rmi/server/MarshalInputStream.c Changeset: 6e59c482e9b8 Author: xuelei Date: 2011-10-28 07:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6e59c482e9b8 7105940: Test regression: KeyStore must be from provider SunPKCS11-NSSKeyStore Reviewed-by: weijun ! test/sun/security/pkcs11/fips/CipherTest.java ! test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java Changeset: bb2b9a8b6e77 Author: alanb Date: 2011-10-30 14:53 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bb2b9a8b6e77 7103889: (fs) Reduce String concatenation when iterating over directory Reviewed-by: alanb Contributed-by: mike.skells at talk21.com ! src/share/classes/java/nio/file/Files.java ! src/windows/classes/sun/nio/fs/WindowsDirectoryStream.java ! src/windows/classes/sun/nio/fs/WindowsPathParser.java Changeset: 30900a1a9cfc Author: xuelei Date: 2011-10-30 20:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/30900a1a9cfc 7106277: Brokenness in the seqNumberOverflow of MAC Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/MAC.java Changeset: 8681362a2f04 Author: wetmore Date: 2011-10-31 11:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8681362a2f04 7105780: Add SSLSocket client/SSLEngine server to templates directory Reviewed-by: xuelei + test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java Changeset: b60e88ef5d8d Author: wetmore Date: 2011-10-31 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b60e88ef5d8d 7053252: New regression test does not compile on windows-amd64 Reviewed-by: valeriep ! test/ProblemList.txt ! test/sun/security/pkcs11/Provider/Absolute.java Changeset: 5f2838744544 Author: ysr Date: 2011-10-31 17:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5f2838744544 4243978: (ref) Race condition in Reference.enqueue() 4268317: (ref) Reference.isEnqueued() can return true when instance not enqueued Summary: The reference handler now declares, and assumes, that the discovered field, rather than the next field, is (to be) used to link the entries in the pending list, thus allowing a reference object to be safely enqueued even while it is in the pending state. Also added slightly modified regression tests from the two bug reports. Reviewed-by: mchung, alanb, jcoomes ! src/share/classes/java/lang/ref/Reference.java ! src/share/javavm/export/jvm.h ! src/share/native/common/jdk_util.c + test/java/lang/ref/ReferenceEnqueue.java + test/java/lang/ref/ReferenceEnqueuePending.java Changeset: 2f2f56ac8b82 Author: mduigou Date: 2011-11-03 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2f2f56ac8b82 4533691: Add Collections.emptySortedSet() Reviewed-by: mduigou, alanb, dholmes Contributed-by: darryl.mocek at oracle.com ! src/share/classes/java/util/Collections.java + test/java/util/Collections/EmptySortedSet.java Changeset: ead9dabe8c75 Author: lana Date: 2011-11-05 00:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ead9dabe8c75 Merge Changeset: 417d91754849 Author: sherman Date: 2011-11-07 13:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/417d91754849 7096080: UTF8 update and new CESU-8 charset 7082884: Incorrect UTF8 conversion for sequence ED 31 7082883: Incorrect UTF8 conversion for sequence fc 80 80 8f bf bf Summary: Updated UTF8 and added CESU-8 to following the latest Standard Reviewed-by: alanb ! make/java/nio/FILES_java.gmk + src/share/classes/sun/nio/cs/CESU_8.java ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/standard-charsets ! test/java/nio/charset/coders/Errors.java ! test/sun/nio/cs/TestStringCoding.java ! test/sun/nio/cs/TestStringCodingUTF8.java ! test/sun/nio/cs/TestUTF8.java Changeset: 0bb498332894 Author: lana Date: 2011-11-08 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0bb498332894 Merge Changeset: 51db54a3b953 Author: lana Date: 2011-11-14 18:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/51db54a3b953 Merge Changeset: 3b2128c89361 Author: alanb Date: 2011-06-15 14:49 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3b2128c89361 7000600: InputStream.skip() makes sensitive data accessible to malicious code Reviewed-by: hawtin, chegar ! src/share/classes/java/io/InputStream.java Changeset: 06e0d91548b3 Author: anthony Date: 2011-06-21 20:20 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/06e0d91548b3 7022113: Security icon can be moved behind the window using the com.sun.SecurityWarning.setPosition() method Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Window.cpp Changeset: d32b75c73389 Author: alanb Date: 2011-06-27 20:30 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d32b75c73389 7059259: (process) ProcessBuilder.start permission check should be improved when redirecting output to append Reviewed-by: hawtin ! src/windows/classes/java/lang/ProcessImpl.java Changeset: 446b13a08aca Author: asaha Date: 2011-06-27 12:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/446b13a08aca Merge Changeset: 4fdd1a44e846 Author: asaha Date: 2011-06-27 12:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4fdd1a44e846 Merge Changeset: 3e42f7893861 Author: asaha Date: 2011-06-28 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3e42f7893861 Merge Changeset: f578448792b9 Author: ksrini Date: 2011-07-15 13:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f578448792b9 7057857: SIGSEGV [libunpack.so] store_Utf8_char(signed char*, unsigned short) in java.util.jar.pack200 Reviewed-by: jrose, asaha, hawtin ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/com/sun/java/util/jar/pack/utils.cpp ! src/share/native/com/sun/java/util/jar/pack/utils.h Changeset: 4b20375fe623 Author: asaha Date: 2011-07-19 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4b20375fe623 Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: bc9c70e57f62 Author: asaha Date: 2011-07-20 09:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bc9c70e57f62 7032417: Fix for 6981922 does not address multiple VM case Reviewed-by: michaelm ! src/share/classes/sun/net/ResourceManager.java Changeset: a7177942302f Author: asaha Date: 2011-07-20 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a7177942302f 7023640: calculation for malloc size in TransformHelper.c could overflow an integer Reviewed-by: flar ! src/share/native/sun/java2d/loops/TransformHelper.c Changeset: 6c76f2a49061 Author: denis Date: 2011-07-22 21:14 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6c76f2a49061 7019773: AWTKeyStroke.ctor is a mutable static Reviewed-by: art ! src/share/classes/java/awt/AWTKeyStroke.java Changeset: b25558c39ffc Author: smarks Date: 2011-08-30 14:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b25558c39ffc 7077466: fix for RMI DGC Reviewed-by: valeriep ! src/share/classes/sun/rmi/server/UnicastServerRef.java Changeset: efd8035f3d14 Author: smarks Date: 2011-08-30 17:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/efd8035f3d14 7083012: fix for RMI Registry Reviewed-by: jdn, valeriep ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/server/LoaderHandler.java Changeset: 27bda11f1330 Author: smarks Date: 2011-09-21 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/27bda11f1330 7092186: adjust package access in rmiregistry Reviewed-by: asaha, coffeys ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! test/sun/tools/jstatd/jstatdExternalRegistry.sh Changeset: 42eb725f739c Author: xuelei Date: 2011-09-29 17:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/42eb725f739c 7064341: jsse/runtime security problem Reviewed-by: wetmore ! src/share/classes/javax/net/ssl/SSLEngine.java ! src/share/classes/sun/security/ssl/AppOutputStream.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/EngineOutputRecord.java ! src/share/classes/sun/security/ssl/Record.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/CheckStatus.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargeBufs.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargePacket.java Changeset: 53a16cf28db3 Author: xuelei Date: 2011-09-30 18:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/53a16cf28db3 7096936: issue in jsse/runtime 7096937: TEST: com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java need modification as a result of TLS fix Reviewed-by: wetmore, jdn, xuelei ! src/share/classes/com/sun/net/ssl/HttpsURLConnection.java ! src/share/classes/javax/net/ssl/HttpsURLConnection.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java Changeset: 27a8f4fc555a Author: asaha Date: 2011-11-14 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/27a8f4fc555a Merge ! src/share/classes/java/awt/AWTKeyStroke.java ! src/share/classes/javax/net/ssl/HttpsURLConnection.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargePacket.java ! test/sun/tools/jstatd/jstatdExternalRegistry.sh Changeset: 99632935785e Author: lana Date: 2011-11-14 18:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/99632935785e Merge From david.katleman at sun.com Wed Nov 16 23:43:58 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 16 Nov 2011 23:43:58 +0000 Subject: hg: jdk8/build/langtools: 13 new changesets Message-ID: <20111116234426.1131B4739B@hg.openjdk.java.net> Changeset: 65444e7998e3 Author: katleman Date: 2011-11-10 11:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/65444e7998e3 Added tag jdk8-b13 for changeset ae25163501bc ! .hgtags Changeset: e52159ff8d0c Author: lana Date: 2011-10-25 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e52159ff8d0c Merge Changeset: 897b72b2751b Author: lana Date: 2011-10-26 12:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/897b72b2751b Merge - src/share/classes/com/sun/tools/javac/file/Paths.java Changeset: 9e2eb4bc49eb Author: jjh Date: 2011-11-01 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/9e2eb4bc49eb 7101933: langtools jtreg tests do not work with jprt on windows Summary: Fixed langtools/test/Makefile to work on cygwin. Updated jtreg to 4.1 and JCK to JCK8. Reviewed-by: jjg, ohair ! test/Makefile Changeset: 56830d5cb5bb Author: mcimadamore Date: 2011-11-04 12:36 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/56830d5cb5bb 7104201: Refactor DocCommentScanner Summary: Add new Comment helper class to parse contents of comments in source code Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java + test/tools/javac/depDocComment/DeprecatedDocComment4.java + test/tools/javac/depDocComment/DeprecatedDocComment4.out Changeset: 11c184155128 Author: lana Date: 2011-11-05 00:02 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/11c184155128 Merge Changeset: ca49d50318dc Author: jjg Date: 2011-11-08 11:51 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ca49d50318dc 6921494: provide way to print javac tree tag values Reviewed-by: jjg, mcimadamore Contributed-by: vicenterz at yahoo.es ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/tree/AbstractTreeScannerTest.java ! test/tools/javac/tree/TreePosTest.java Changeset: b7003a6a530b Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b7003a6a530b Merge Changeset: 15ea1c763273 Author: asaha Date: 2011-06-27 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/15ea1c763273 Merge - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif Changeset: c79cf0f04be6 Author: asaha Date: 2011-06-28 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c79cf0f04be6 Merge Changeset: 34e175c1fabc Author: asaha Date: 2011-07-19 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/34e175c1fabc Merge Changeset: c4478931e22d Author: asaha Date: 2011-11-07 21:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c4478931e22d Merge Changeset: 58f1325d72b2 Author: lana Date: 2011-11-14 18:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/58f1325d72b2 Merge From david.holmes at oracle.com Thu Nov 17 05:24:51 2011 From: david.holmes at oracle.com (David Holmes) Date: Thu, 17 Nov 2011 15:24:51 +1000 Subject: Please review 7112160 (Kumar Srinivasan) In-Reply-To: <38605121-08C9-4DD9-97B2-3E0B69934ADD@oracle.com> References: <38605121-08C9-4DD9-97B2-3E0B69934ADD@oracle.com> Message-ID: <4EC49AA3.1000005@oracle.com> On 17/11/2011 6:55 AM, Kelly O'Hair wrote: > > On windows, it's more of a "give me a block of memory this big", and sometimes even if the > system has 4GB, it might not have a 1GB hole to give you. :^( So java just dies on startup. > > And if you make this number> RAM, the Linux/Solaris systems could very easily just page thrash. > > We could declare that 2GB RAM is the minimum now, on all systems, and do as you say, but > there are people out there with less RAM, I think... not me... Right - and while the build system already tries to account for such machines by lowering MIN/MAX_VM_MEMORY the settings in this makefile actually seem to override that and ignore it completely (which seems wrong to me). David ----- > -kto > > On Nov 16, 2011, at 12:40 PM, Mike Duigou wrote: > >> Since this is the maximum memory limit and not a specified allocation why not go right to 1GB? >> >> The netbeans launcher scripts also have some nice code which could determine an appropriate maximum for a given configuration. >> >> Mike >> >> On Nov 16 2011, at 12:00 , build-dev-request at openjdk.java.net wrote: >>> Hi, >>> >>> Here is a tiny change to increase the heap space for javadoc, during the >>> jdk build, this allows the build to complete and speeds up the build as >>> well. >>> >>> fyi. The heap space was on the borderline of running out of heap and cause >>> an OOM, some recent changes have increased the memory requirement, >>> and tipped the scale over. >>> >>> http://cr.openjdk.java.net/~ksrini/7112160/ >>> >>> Thanks >>> Kumar > From dalibor.topic at oracle.com Mon Nov 21 13:55:35 2011 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Mon, 21 Nov 2011 14:55:35 +0100 Subject: Please review 7112160 (Kumar Srinivasan) In-Reply-To: <38605121-08C9-4DD9-97B2-3E0B69934ADD@oracle.com> References: <38605121-08C9-4DD9-97B2-3E0B69934ADD@oracle.com> Message-ID: <4ECA5857.5080805@oracle.com> On 11/16/11 9:55 PM, Kelly O'Hair wrote: > > On windows, it's more of a "give me a block of memory this big", and sometimes even if the > system has 4GB, it might not have a 1GB hole to give you. :^( So java just dies on startup. > > And if you make this number > RAM, the Linux/Solaris systems could very easily just page thrash. > > We could declare that 2GB RAM is the minimum now, on all systems, and do as you say, but > there are people out there with less RAM, I think... not me... A 2G minimum sounds sensible to me. cheers, dalibor topic -- Oracle Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 | Mobile: +491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: J?rgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle Oracle is committed to developing practices and products that help protect the environment From david.holmes at oracle.com Wed Nov 23 06:55:07 2011 From: david.holmes at oracle.com (David Holmes) Date: Wed, 23 Nov 2011 16:55:07 +1000 Subject: (XS) Request for review: 7109092 - link changes for embedded builds Message-ID: <4ECC98CB.2040805@oracle.com> We need to make an adjustment to the link instructions used for libjava in embedded builds, as defined in Defs-embedded.gmk webrev: http://cr.openjdk.java.net/~dholmes/7109092/webrev/ Summary: system soft-float libraries need not have the level of accuracy required by Java floating-point semantics. On those platforms we have a custom soft-float library to provide the necessary accuracy. This change updated the linker instructions to use that library when linking libjava (really fdlibm is what needs it). The VM has been using a similar library for a while now. I currently have this as a child of jdk8/tl/jdk so would prefer to push there, but can switch to jdk8/build/jdk if the build-dev folks feel strongly about it. Thanks, David From Alan.Bateman at oracle.com Wed Nov 23 12:12:13 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 23 Nov 2011 12:12:13 +0000 Subject: jdk/src/solaris - time to re-visit it? Message-ID: <4ECCE31D.90007@oracle.com> In the jdk repository then src/solaris has all the Solaris and Linux code. Most of it is used for both platforms with a small number of files specific to one or the other. I'm sure this has come up before (probably many times) but I'd like to bring it up again. One of motives for bringing this up now is the Mac OS X port is coming. It adds/changes code in src/solaris and also adds a lot of code to a new tree src/macosx. Another motivation is patches from IBM folks which are really just changes to workaround the fact that we've got code for several platforms in the same directory. As I look through src/solaris now it is clear that we have taken several approaches to this. In some cases we've got Solaris* files, in other cases we rename files during the build. The purpose of this mail is just to probe and see if anyone has thought about this problem recently. I'm not suggesting anything specific except to see whether it's worth thinking about how we might change this in the future. I've no doubt that there isn't a perfect solution to this and clearly any changes will be disruptive (but there's no harm discussing possible options). -Alan. From fredrik.ohrstrom at oracle.com Wed Nov 23 13:33:27 2011 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Wed, 23 Nov 2011 14:33:27 +0100 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECCE31D.90007@oracle.com> References: <4ECCE31D.90007@oracle.com> Message-ID: <4ECCF627.1000507@oracle.com> 2011-11-23 13:12, Alan Bateman skrev: > In the jdk repository then src/solaris has all the Solaris and Linux > code. Most of it is used for both platforms with a small number of files > specific to one or the other. I'm sure this has come up before (probably > many times) but I'd like to bring it up again. > > One of motives for bringing this up now is the Mac OS X port is coming. > It adds/changes code in src/solaris and also adds a lot of code to a new > tree src/macosx. Another motivation is patches from IBM folks which are > really just changes to workaround the fact that we've got code for > several platforms in the same directory. As I look through src/solaris > now it is clear that we have taken several approaches to this. In some > cases we've got Solaris* files, in other cases we rename files during > the build. > > The purpose of this mail is just to probe and see if anyone has thought > about this problem recently. I'm not suggesting anything specific except > to see whether it's worth thinking about how we might change this in the > future. I've no doubt that there isn't a perfect solution to this and > clearly any changes will be disruptive (but there's no harm discussing > possible options). I have.... no suprise there I guess ;-). If you read CompileJavaClasses.gmk in build-infra/jdk7/jdk/make you can see the hoops we need to go through to filter out platform specific classes in share/classes and linux specific classes in solaris/classes etc etc. In build-infra we are using the variable: HOST_API that can be posix or winapi code common to linux,gnu,solaris,bsd,aix and macosx should be put into src/posix/classes. code belonging to windows is put inside src/winapi/classes. (winapi was earlier named win32 but the name was changed by Microsoft to winapi, since win32 actually supports 64 bits. Perhaps in the future there might be some windows_mobile platform that also uses code inside winapi.) HOST_OS (ie PLATFORM) is linux,bsd,gnu,solaris,macosx,aix etc thus platform specific code is in src/linux/classes src/solaris/classes src/bsd/classes Do we also need the variable HOST_OS_PEDIGREE that can be? gnu_pg (for code shared by linux,gnu etc) sysv_pg (for code shared by solaris,aix etc) bsd_pg (for code shared by macosx,bsd etc) if so, such code would be placed in src/sysv_pg/classes We are not really moving any source code around in build-infra. That has to wait until the big jigsaw change. But the variables are in place. //Fredrik From Dmitry.Samersoff at oracle.com Wed Nov 23 14:40:56 2011 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 23 Nov 2011 18:40:56 +0400 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECCE31D.90007@oracle.com> References: <4ECCE31D.90007@oracle.com> Message-ID: <4ECD05F8.80901@oracle.com> Alan, I'd thought about it couple of times (actually, every time i touched networking code) Unfortunately there is no simple solution because lots of code has huge common part and small platform specific function on top of it. Also with a course to expand platform coverage it's possible to end up with a chain {common posix code}, {common bsd part}, {mac os specific part} On my opinion more or less complete way is: 1. Create os/posix directory 2. Create set of subfolders as necessary os/posix/{solaris,linux,bsd ...}/{macos, openbsd, ... } 3. Change a build system to link all necessary files to build/src directory during ./configure step to simplify makefiles and avoid build time name clashes. 4. Revisit the code to get rid of #ifdef Platform -Dmitry On 2011-11-23 16:12, Alan Bateman wrote: > > In the jdk repository then src/solaris has all the Solaris and Linux > code. Most of it is used for both platforms with a small number of files > specific to one or the other. I'm sure this has come up before (probably > many times) but I'd like to bring it up again. > > One of motives for bringing this up now is the Mac OS X port is coming. > It adds/changes code in src/solaris and also adds a lot of code to a new > tree src/macosx. Another motivation is patches from IBM folks which are > really just changes to workaround the fact that we've got code for > several platforms in the same directory. As I look through src/solaris > now it is clear that we have taken several approaches to this. In some > cases we've got Solaris* files, in other cases we rename files during > the build. > > The purpose of this mail is just to probe and see if anyone has thought > about this problem recently. I'm not suggesting anything specific except > to see whether it's worth thinking about how we might change this in the > future. I've no doubt that there isn't a perfect solution to this and > clearly any changes will be disruptive (but there's no harm discussing > possible options). > > -Alan. > > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From jonathan.gibbons at oracle.com Wed Nov 23 15:14:12 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 23 Nov 2011 07:14:12 -0800 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECD05F8.80901@oracle.com> References: <4ECCE31D.90007@oracle.com> <4ECD05F8.80901@oracle.com> Message-ID: <4ECD0DC4.4090809@oracle.com> At the risk of including Yet Another alias, you should include build-infra-dev at openjdk.java.net, for the team working on the new build system. -- Jon On 11/23/2011 06:40 AM, Dmitry Samersoff wrote: > Alan, > > I'd thought about it couple of times (actually, every time i touched > networking code) > > Unfortunately there is no simple solution because lots of code has huge > common part and small platform specific function on top of it. > > Also with a course to expand platform coverage it's possible to end up > with a chain {common posix code}, {common bsd part}, {mac os specific part} > > On my opinion more or less complete way is: > > 1. Create os/posix directory > > 2. Create set of subfolders as necessary > os/posix/{solaris,linux,bsd ...}/{macos, openbsd, ... } > > 3. Change a build system to link all necessary files to > build/src directory during ./configure step to simplify > makefiles and avoid build time name clashes. > > 4. Revisit the code to get rid of #ifdef Platform > > -Dmitry > > > On 2011-11-23 16:12, Alan Bateman wrote: >> In the jdk repository then src/solaris has all the Solaris and Linux >> code. Most of it is used for both platforms with a small number of files >> specific to one or the other. I'm sure this has come up before (probably >> many times) but I'd like to bring it up again. >> >> One of motives for bringing this up now is the Mac OS X port is coming. >> It adds/changes code in src/solaris and also adds a lot of code to a new >> tree src/macosx. Another motivation is patches from IBM folks which are >> really just changes to workaround the fact that we've got code for >> several platforms in the same directory. As I look through src/solaris >> now it is clear that we have taken several approaches to this. In some >> cases we've got Solaris* files, in other cases we rename files during >> the build. >> >> The purpose of this mail is just to probe and see if anyone has thought >> about this problem recently. I'm not suggesting anything specific except >> to see whether it's worth thinking about how we might change this in the >> future. I've no doubt that there isn't a perfect solution to this and >> clearly any changes will be disruptive (but there's no harm discussing >> possible options). >> >> -Alan. >> >> > From Alan.Bateman at oracle.com Wed Nov 23 15:56:11 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 23 Nov 2011 15:56:11 +0000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECCF627.1000507@oracle.com> References: <4ECCE31D.90007@oracle.com> <4ECCF627.1000507@oracle.com> Message-ID: <4ECD179B.4020308@oracle.com> On 23/11/2011 13:33, Fredrik ?hrstr?m wrote: > : > I have.... no suprise there I guess ;-). If you read > CompileJavaClasses.gmk in build-infra/jdk7/jdk/make > you can see the hoops we need to go through to filter out platform > specific classes in share/classes > and linux specific classes in solaris/classes etc etc. Yes, I've looked at CompileJavaClasses.gmk where it is essentially has to filter the classes in src/solaris because there are classes for more than one platform. I just wonder whether it's time to re-visit that so that code for a specific platform is in its own src/ tree ( goes in there once the code is restructured on module lines). It fits with the new build infra in that the code in src/solaris should ultimately (may take a long time) be changed to be based on capabilities rather than ifdef . -Alan. From philip.race at oracle.com Wed Nov 23 18:07:56 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 23 Nov 2011 10:07:56 -0800 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECCF627.1000507@oracle.com> References: <4ECCE31D.90007@oracle.com> <4ECCF627.1000507@oracle.com> Message-ID: <4ECD367C.8060806@oracle.com> Its tricky. I would not gratuitously change any of the directory names, especially the win32 one. There'd have to be a compelling reason. The Linux and Solaris ports share X11 for their windowing system, but the OS X port doesn't. So some mac things would go in src/solaris, as they are shareable, [perhaps/often unixisms] to a very large degree but most of the new client code rightly belongs in a new macosx directory. So the name "posix" might seem the right one for "core" but as much of what is in src/solaris is X11 and other windowing system related and isn't defined by POSIX. And we can even use POSIX APis on windows .. I've always thought of src/solaris as "unix" or "unix+x11" specific directory". -phil On 11/23/2011 5:33 AM, Fredrik ?hrstr?m wrote: > 2011-11-23 13:12, Alan Bateman skrev: >> In the jdk repository then src/solaris has all the Solaris and Linux >> code. Most of it is used for both platforms with a small number of files >> specific to one or the other. I'm sure this has come up before (probably >> many times) but I'd like to bring it up again. >> >> One of motives for bringing this up now is the Mac OS X port is coming. >> It adds/changes code in src/solaris and also adds a lot of code to a new >> tree src/macosx. Another motivation is patches from IBM folks which are >> really just changes to workaround the fact that we've got code for >> several platforms in the same directory. As I look through src/solaris >> now it is clear that we have taken several approaches to this. In some >> cases we've got Solaris* files, in other cases we rename files during >> the build. >> >> The purpose of this mail is just to probe and see if anyone has thought >> about this problem recently. I'm not suggesting anything specific except >> to see whether it's worth thinking about how we might change this in the >> future. I've no doubt that there isn't a perfect solution to this and >> clearly any changes will be disruptive (but there's no harm discussing >> possible options). > I have.... no suprise there I guess ;-). If you read > CompileJavaClasses.gmk in build-infra/jdk7/jdk/make > you can see the hoops we need to go through to filter out platform > specific classes in share/classes > and linux specific classes in solaris/classes etc etc. > > In build-infra we are using the variable: > > HOST_API > that can be posix or winapi > > code common to linux,gnu,solaris,bsd,aix and macosx should be put into > src/posix/classes. > code belonging to windows is put inside src/winapi/classes. > > (winapi was earlier named win32 but the name was changed by Microsoft to > winapi, > since win32 actually supports 64 bits. Perhaps in the future there might > be some > windows_mobile platform that also uses code inside winapi.) > > HOST_OS (ie PLATFORM) > is linux,bsd,gnu,solaris,macosx,aix etc > thus platform specific code is in src/linux/classes > src/solaris/classes src/bsd/classes > > Do we also need the variable HOST_OS_PEDIGREE that can be? > gnu_pg (for code shared by linux,gnu etc) > sysv_pg (for code shared by solaris,aix etc) > bsd_pg (for code shared by macosx,bsd etc) > if so, such code would be placed in src/sysv_pg/classes > > We are not really moving any source code around in build-infra. That has > to wait until > the big jigsaw change. But the variables are in place. > > //Fredrik From david.holmes at oracle.com Wed Nov 23 20:48:38 2011 From: david.holmes at oracle.com (David Holmes) Date: Thu, 24 Nov 2011 06:48:38 +1000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECCE31D.90007@oracle.com> References: <4ECCE31D.90007@oracle.com> Message-ID: <4ECD5C26.1040303@oracle.com> Alan, It's definitely tricky (lots of refactoring needed) but it definitely needs to be done at some point - however I think we already missed the opportunity to do this before integrating the BSD and MacOSX code (same on the VM side) David On 23/11/2011 10:12 PM, Alan Bateman wrote: > > In the jdk repository then src/solaris has all the Solaris and Linux > code. Most of it is used for both platforms with a small number of files > specific to one or the other. I'm sure this has come up before (probably > many times) but I'd like to bring it up again. > > One of motives for bringing this up now is the Mac OS X port is coming. > It adds/changes code in src/solaris and also adds a lot of code to a new > tree src/macosx. Another motivation is patches from IBM folks which are > really just changes to workaround the fact that we've got code for > several platforms in the same directory. As I look through src/solaris > now it is clear that we have taken several approaches to this. In some > cases we've got Solaris* files, in other cases we rename files during > the build. > > The purpose of this mail is just to probe and see if anyone has thought > about this problem recently. I'm not suggesting anything specific except > to see whether it's worth thinking about how we might change this in the > future. I've no doubt that there isn't a perfect solution to this and > clearly any changes will be disruptive (but there's no harm discussing > possible options). > > -Alan. > > From Alan.Bateman at oracle.com Thu Nov 24 10:11:51 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 24 Nov 2011 10:11:51 +0000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECD5C26.1040303@oracle.com> References: <4ECCE31D.90007@oracle.com> <4ECD5C26.1040303@oracle.com> Message-ID: <4ECE1867.8020302@oracle.com> On 23/11/2011 20:48, David Holmes wrote: > Alan, > > It's definitely tricky (lots of refactoring needed) but it definitely > needs to be done at some point - however I think we already missed the > opportunity to do this before integrating the BSD and MacOSX code > (same on the VM side) I've often wondered how disruptive it would be if src/solaris were renamed to src/unix (like Phil, I view src/solaris tree as the unix tree). Clearly it would make it more awkward to move patches between jdk versions, and it would cause everyone with in-flight patches to re-base. If we did rename it then the ifdef code could stay. Over time (probably a long time) we could chip away at the refactoring. With the new build then the direction is to move to be based on capabilities so we're going to be re-visiting this code anyway. The immediate benefit of renaming is that it would allow us to move the Solaris and Linux specific source files out of the src/unix tree into src/ directories. That would eliminate the need for some of the filtering in the build and would also allow us sort out some name conflict issues that we have in several places (UNIXProcess.java. for example). -Alan. From Alan.Bateman at oracle.com Thu Nov 24 10:45:01 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 24 Nov 2011 10:45:01 +0000 Subject: (XS) Request for review: 7109092 - link changes for embedded builds In-Reply-To: <4ECC98CB.2040805@oracle.com> References: <4ECC98CB.2040805@oracle.com> Message-ID: <4ECE202D.4050700@oracle.com> On 23/11/2011 06:55, David Holmes wrote: > We need to make an adjustment to the link instructions used for > libjava in embedded builds, as defined in Defs-embedded.gmk > > webrev: http://cr.openjdk.java.net/~dholmes/7109092/webrev/ > > Summary: system soft-float libraries need not have the level of > accuracy required by Java floating-point semantics. On those platforms > we have a custom soft-float library to provide the necessary accuracy. > This change updated the linker instructions to use that library when > linking libjava (really fdlibm is what needs it). > > The VM has been using a similar library for a while now. > > I currently have this as a child of jdk8/tl/jdk so would prefer to > push there, but can switch to jdk8/build/jdk if the build-dev folks > feel strongly about it. Looks okay to me, as you say, libjvm.so is linked the same way. I don't think it matters which integration forest you use for this, jdk8/tl/jdk is fine. -Alan. From fredrik.ohrstrom at oracle.com Thu Nov 24 14:39:59 2011 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Thu, 24 Nov 2011 15:39:59 +0100 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECE1867.8020302@oracle.com> References: <4ECCE31D.90007@oracle.com> <4ECD5C26.1040303@oracle.com> <4ECE1867.8020302@oracle.com> Message-ID: <4ECE573F.1050702@oracle.com> 2011-11-24 11:11, Alan Bateman skrev: > The immediate benefit of renaming is that it would allow us to move the > Solaris and Linux specific source files out of the src/unix tree into > src/ directories. That would eliminate the need for some of > the filtering in the build and would also allow us sort out some name > conflict issues that we have in several places > (UNIXProcess.java. for example). It would be great to do the rename. However, we should not do that before the build-infra changes are in place. The peculiarities of the current build have already been worked around and the new makefiles are useful, since it is easy to see where the warts are. Thus when build-infra is done, we will have a neat list of all things that needs to be cleaned up by moving source code and platform specific code in src/share is just one of many problems. I was hoping that when we start incrementally moving towards jigsaw-like structuring of the source, we can fix this then? When we rename directories, we lose a lot of information in the source control system. Necessary yes, but at least we should try to do it just once. As for the naming: posix is the name of a standardized API to unix-like operating systems. winapi is the name of the defacto API to windows systems. Using two trademarks instead of the actual names of the APIs would be silly. And you can run posix software on Windows by installing cygwin et al, and you can run winapi software on Linux by installing wine. But this is not the point, the point is that the built jvm will run primarily using winapi, or primarily using posix. No-one answered my question if we need to track the posix pedigree? I.e. gnu, sysv and bsd? //Fredrik From david.holmes at oracle.com Thu Nov 24 21:07:57 2011 From: david.holmes at oracle.com (David Holmes) Date: Fri, 25 Nov 2011 07:07:57 +1000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECE573F.1050702@oracle.com> References: <4ECCE31D.90007@oracle.com> <4ECD5C26.1040303@oracle.com> <4ECE1867.8020302@oracle.com> <4ECE573F.1050702@oracle.com> Message-ID: <4ECEB22D.7040200@oracle.com> On 25/11/2011 12:39 AM, Fredrik ?hrstr?m wrote: > No-one answered my question if we need to track the posix pedigree? I.e. > gnu, sysv and bsd? I would hope this would not be necessary. There would have to be a "critical mass" of duplicated code (say between Solaris and BSD) to warrant a further refactor. Though maybe BSD and MacOSX are more tightly coupled. David From Alan.Bateman at oracle.com Fri Nov 25 10:59:01 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 25 Nov 2011 10:59:01 +0000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ECE573F.1050702@oracle.com> References: <4ECCE31D.90007@oracle.com> <4ECD5C26.1040303@oracle.com> <4ECE1867.8020302@oracle.com> <4ECE573F.1050702@oracle.com> Message-ID: <4ECF74F5.1050609@oracle.com> On 24/11/2011 14:39, Fredrik ?hrstr?m wrote: > : > It would be great to do the rename. However, we should not do that > before the build-infra changes > are in place. The peculiarities of the current build have already been > worked around and the new > makefiles are useful, since it is easy to see where the warts are. Thus > when build-infra is done, we will > have a neat list of all things that needs to be cleaned up by moving > source code and platform > specific code in src/share is just one of many problems. > > I was hoping that when we start incrementally moving towards jigsaw-like > structuring of the source, > we can fix this then? When we rename directories, we lose a lot of > information in the source control system. > Necessary yes, but at least we should try to do it just once. > > As for the naming: > posix is the name of a standardized API to unix-like operating systems. > winapi is the name of the defacto API to windows systems. > > Using two trademarks instead of the actual names of the APIs would be silly. > > And you can run posix software on Windows by installing cygwin et al, > and you > can run winapi software on Linux by installing wine. But this is not the > point, > the point is that the built jvm will run primarily using winapi, or > primarily > using posix. > > No-one answered my question if we need to track the posix pedigree? I.e. > gnu, sysv and bsd? > > //Fredrik I agree it's not a good time to do the renaming but I think it's good to discuss and think about the how we might organize the code in the future. I don't have strong opinions on the names but "posix" doesn't seem quite right just now as we have code in src/solaris/** that is making use of APIs that aren't part of POSIX (I think this was Phil's point too). On the pedigree then it might be better to cross that bridge when we come to it, meaning that we could only really make use of it in conjunction with refactoring work. You are right that the peculiarities have been worked around to date but more have been proposed [1]. Maybe it would be prudent to hold off on these changes until the new build is in place. -Alan. [1] http://mail.openjdk.java.net/pipermail/nio-dev/2011-November/001466.html From weijun.wang at oracle.com Fri Nov 25 11:16:23 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 25 Nov 2011 19:16:23 +0800 Subject: OT: jdk/build/solaris (was Re: jdk/src/solaris - time to re-visit it?) In-Reply-To: <4ECF74F5.1050609@oracle.com> References: <4ECCE31D.90007@oracle.com> <4ECD5C26.1040303@oracle.com> <4ECE1867.8020302@oracle.com> <4ECE573F.1050702@oracle.com> <4ECF74F5.1050609@oracle.com> Message-ID: <4ECF7907.4080907@oracle.com> Off topic. I don't have any suggestion on src and make at the moment but is it good to build platform-specific binaries into different directories and keep the common files at a single place? If so we can create a single merged image that is executable everywhere. -Max On 11/25/2011 06:59 PM, Alan Bateman wrote: > On 24/11/2011 14:39, Fredrik ?hrstr?m wrote: >> : >> It would be great to do the rename. However, we should not do that >> before the build-infra changes >> are in place. The peculiarities of the current build have already been >> worked around and the new >> makefiles are useful, since it is easy to see where the warts are. Thus >> when build-infra is done, we will >> have a neat list of all things that needs to be cleaned up by moving >> source code and platform >> specific code in src/share is just one of many problems. >> >> I was hoping that when we start incrementally moving towards jigsaw-like >> structuring of the source, >> we can fix this then? When we rename directories, we lose a lot of >> information in the source control system. >> Necessary yes, but at least we should try to do it just once. >> >> As for the naming: >> posix is the name of a standardized API to unix-like operating systems. >> winapi is the name of the defacto API to windows systems. >> >> Using two trademarks instead of the actual names of the APIs would be >> silly. >> >> And you can run posix software on Windows by installing cygwin et al, >> and you >> can run winapi software on Linux by installing wine. But this is not the >> point, >> the point is that the built jvm will run primarily using winapi, or >> primarily >> using posix. >> >> No-one answered my question if we need to track the posix pedigree? I.e. >> gnu, sysv and bsd? >> >> //Fredrik > I agree it's not a good time to do the renaming but I think it's good to > discuss and think about the how we might organize the code in the future. > > I don't have strong opinions on the names but "posix" doesn't seem quite > right just now as we have code in src/solaris/** that is making use of > APIs that aren't part of POSIX (I think this was Phil's point too). On > the pedigree then it might be better to cross that bridge when we come > to it, meaning that we could only really make use of it in conjunction > with refactoring work. > > You are right that the peculiarities have been worked around to date but > more have been proposed [1]. Maybe it would be prudent to hold off on > these changes until the new build is in place. > > -Alan. > > [1] > http://mail.openjdk.java.net/pipermail/nio-dev/2011-November/001466.html > From mike.duigou at oracle.com Sun Nov 27 21:29:28 2011 From: mike.duigou at oracle.com (Mike Duigou) Date: Sun, 27 Nov 2011 13:29:28 -0800 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: References: Message-ID: On Thu, 24 Nov 2011 15:39:59 +0100 Fredrik ?hrstr?m wrote : > > When we rename directories, we lose a lot of > information in the source control system. hg moves don't cause any of the history to be lost. Some tools (including NetBeans) follow the history through renames and copies without any special intervention needed by the user at all. I don't believe this should be an impediment. > Necessary yes, but at least we should try to do it just once. > > As for the naming: > posix is the name of a standardized API to unix-like operating systems. > winapi is the name of the defacto API to windows systems. > > No-one answered my question if we need to track the posix pedigree? I.e. > gnu, sysv and bsd? Only if necessary hopefully. As we have shared and platform code we might have shared |--posix | |--SYSV | | |--solaris | | |--aix | | | |--gnu | | |--linux | | | | |--BSD | |--darwin | |--freebsd | |--winapi |--win32 |--wince This is an imaginary sharing/specialization hierarchy, not the source hierarchy. Only the nodes that are actually required would need to exist--if there is no specialization needed between darwin and freebsd then neither node need exist. From david.holmes at oracle.com Sun Nov 27 22:45:20 2011 From: david.holmes at oracle.com (David Holmes) Date: Mon, 28 Nov 2011 08:45:20 +1000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: References: Message-ID: <4ED2BD80.5030102@oracle.com> On 28/11/2011 7:29 AM, Mike Duigou wrote: > On Thu, 24 Nov 2011 15:39:59 +0100 Fredrik ?hrstr?m wrote : >> >> When we rename directories, we lose a lot of >> information in the source control system. > > hg moves don't cause any of the history to be lost. Some tools (including NetBeans) follow the history through renames and copies without any special intervention needed by the user at all. I don't believe this should be an impediment. > >> Necessary yes, but at least we should try to do it just once. >> >> As for the naming: >> posix is the name of a standardized API to unix-like operating systems. >> winapi is the name of the defacto API to windows systems. >> >> No-one answered my question if we need to track the posix pedigree? I.e. >> gnu, sysv and bsd? > > Only if necessary hopefully. As we have shared and platform code we might have > > shared > |--posix > | |--SYSV > | | |--solaris > | | |--aix > | | > | |--gnu > | | |--linux > | | | > | |--BSD > | |--darwin > | |--freebsd > | > |--winapi > |--win32 > |--wince Maybe I'm miinterpreting what the above means, but the use of "posix" above would seem inappropriate. If you really mean the standard POSIX API's then the hierarchy would have POSIX as a sibling of BSD and SYSV - as they each define specific APIs that might be provided by an OS (eg Solaris) and used by the VM. If you mean "posix" to be "generic unix like OS" then the name should reflect that. I don't think we need to get to this degree of separation in one jump. First step would be to factor out the common POSIX API code and then pair that with OS-specific code. If there is still enough shared code between OS's that we can identify as BSD or SYSV or whatever, then we could further refactor. Though I'm unclear exactly how the refactoring would work at the file and class/function level. David > This is an imaginary sharing/specialization hierarchy, not the source hierarchy. Only the nodes that are actually required would need to exist--if there is no specialization needed between darwin and freebsd then neither node need exist. > From Ulf.Zibis at gmx.de Mon Nov 28 15:46:55 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Mon, 28 Nov 2011 16:46:55 +0100 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: References: Message-ID: <4ED3ACEF.4000403@gmx.de> Am 27.11.2011 22:29, schrieb Mike Duigou: > Only if necessary hopefully. As we have shared and platform code we might have > > shared > |--posix > | |--SYSV > | | |--solaris > | | |--aix > | | > | |--gnu > | | |--linux > | | | > | |--BSD > | |--darwin > | |--freebsd > | > |--winapi > |--win32 > |--wince I guess you meant: --shared --posix |--SYSV | |--solaris | |--aix | |--gnu | |--linux | | |--BSD |--darwin |--freebsd --winapi |--win32 |--wince against current ... --share --linux --solaris --windows -Ulf From fredrik.ohrstrom at oracle.com Mon Nov 28 16:20:34 2011 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Mon, 28 Nov 2011 17:20:34 +0100 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED3ACEF.4000403@gmx.de> References: <4ED3ACEF.4000403@gmx.de> Message-ID: <4ED3B4D2.2070403@oracle.com> 2011-11-28 16:46, Ulf Zibis skrev: > I guess you meant: > --shared > --posix > |--SYSV > | |--solaris > | |--aix > | > |--gnu > | |--linux > | | > |--BSD > |--darwin > |--freebsd > > --winapi > |--win32 > |--wince > > against current ... > --share > --linux > --solaris > --windows > The directory structure ought to be more flat than the possible combinations that form a product. For example if: HOST_API = posix winapi HOST_OS = solaris aix gnu linux darwin freebsd windows wince HOST_OS_PEDIGREE = SYSV GNU BSD then the directories are stored flat under src: --src |--share |--posix |--winapi |--SYSV |--GNU |--BSD |--solaris |--aix |--gnu |--linux |--darwin |--freebsd |--windows |--wince Then, when compiling, the union of the directories and files below the selected src subdirectories, form the source of the product. For example: share,posix,BSD,darwin share,posix,GNU,linux share,posix,GNU,gnu share,winapi,windows This gives less confusion about which subdirs to src/posix are configuration directories, and which are posix directories with code. //Fredrik From Ulf.Zibis at gmx.de Mon Nov 28 16:32:48 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Mon, 28 Nov 2011 17:32:48 +0100 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED3B4D2.2070403@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> Message-ID: <4ED3B7B0.6000004@gmx.de> Additionaly I think, 'share' should be replaced by 'common'. 'share', as a verb, seems ugly along 'posix', 'winapi' to me. -Ulf Am 28.11.2011 17:20, schrieb Fredrik ?hrstr?m: > 2011-11-28 16:46, Ulf Zibis skrev: >> I guess you meant: >> --shared >> --posix >> |--SYSV >> | |--solaris >> | |--aix >> | >> |--gnu >> | |--linux >> | | >> |--BSD >> |--darwin >> |--freebsd >> >> --winapi >> |--win32 >> |--wince >> >> against current ... >> --share >> --linux >> --solaris >> --windows >> > The directory structure ought to be more flat than > the possible combinations that form a product. > > For example if: > HOST_API = posix winapi > HOST_OS = solaris aix gnu linux darwin freebsd windows wince > HOST_OS_PEDIGREE = SYSV GNU BSD > > then the directories are stored flat under src: > > --src > |--share > |--posix > |--winapi > |--SYSV > |--GNU > |--BSD > |--solaris > |--aix > |--gnu > |--linux > |--darwin > |--freebsd > |--windows > |--wince > > Then, when compiling, the union of the directories and files below > the selected src subdirectories, form the source of the product. > For example: > share,posix,BSD,darwin > share,posix,GNU,linux > share,posix,GNU,gnu > share,winapi,windows > > This gives less confusion about which subdirs to src/posix > are configuration directories, and which are posix directories with code. > > //Fredrik > From kelly.ohair at oracle.com Mon Nov 28 18:12:27 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 28 Nov 2011 10:12:27 -0800 Subject: (XS) Request for review: 7109092 - link changes for embedded builds In-Reply-To: <4ECC98CB.2040805@oracle.com> References: <4ECC98CB.2040805@oracle.com> Message-ID: Looks ok to me. -kto On Nov 22, 2011, at 10:55 PM, David Holmes wrote: > We need to make an adjustment to the link instructions used for libjava in embedded builds, as defined in Defs-embedded.gmk > > webrev: http://cr.openjdk.java.net/~dholmes/7109092/webrev/ > > Summary: system soft-float libraries need not have the level of accuracy required by Java floating-point semantics. On those platforms we have a custom soft-float library to provide the necessary accuracy. This change updated the linker instructions to use that library when linking libjava (really fdlibm is what needs it). > > The VM has been using a similar library for a while now. > > I currently have this as a child of jdk8/tl/jdk so would prefer to push there, but can switch to jdk8/build/jdk if the build-dev folks feel strongly about it. > > Thanks, > David From stuart.marks at oracle.com Tue Nov 29 00:42:56 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Mon, 28 Nov 2011 16:42:56 -0800 Subject: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation Message-ID: <4ED42A90.4030003@oracle.com> Please review this change to add to the javac make rule some messages about the number of files being compiled, the current working directory, and a new message to demarcate the end of javac output. This will help capture and analyze javac output, in particular, warning messages. Thanks. s'marks diff -r 6fbd69f8e3ab make/common/Rules.gmk --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 +++ b/make/common/Rules.gmk Mon Nov 28 16:34:34 2011 -0800 @@ -236,9 +236,10 @@ @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ $(CAT) $<.filtered; \ - $(ECHO) "# Running javac:"; \ + $(ECHO) "# Running javac: `$(WC) -l < $<.filtered` files; in `pwd`"; \ $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ + $(ECHO) "# javac finished"; \ fi @$(java-vm-cleanup) From xiomara.jayasena at oracle.com Tue Nov 29 02:10:06 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Mon, 28 Nov 2011 18:10:06 -0800 (PST) Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 Message-ID: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. We would like to invite you to participate. To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. If you decide to participate then please reply to this e-mail with the area that you intend to work on. I will keep track of the areas so that there is no overlap of work. . A group of us working on this project will create bugs for the areas that developers sign up for. . The focus will be on java warnings, since these are less risky. . For this exercise please avoid making any API changes or any large scale refactorings. . Avoid @SuppressWarnings except where it is clearly necessary. . We would like to have the code changes completed by 5pm (PST) on Dec. 1st. . A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. The java files are in java.io, java.lang, java.util and a variety of related packages. Process to follow: 1. Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. 2. A bug ID will be generated for this. 3. Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk 4. Post your changes for review. If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. If the patch is too cumbersome to review, we can generate a webrev for you. 5. All of the changes must go through the usual build, test and review process before being pushed. If you are a JDK8 committer you may push after completing the usual process. If you aren't a committer we will help you review and test your changes. 6. In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! Lastly to get a build with warnings enable use the following flags: make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" Tip: Make sure to redirect output to a file. To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." -Xiomara -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.holmes at oracle.com Tue Nov 29 03:00:18 2011 From: david.holmes at oracle.com (David Holmes) Date: Tue, 29 Nov 2011 13:00:18 +1000 Subject: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation In-Reply-To: <4ED42A90.4030003@oracle.com> References: <4ED42A90.4030003@oracle.com> Message-ID: <4ED44AC2.9010700@oracle.com> Hi Stuart, On 29/11/2011 10:42 AM, Stuart Marks wrote: > Please review this change to add to the javac make rule some messages > about the number of files being compiled, the current working directory, > and a new message to demarcate the end of javac output. > > This will help capture and analyze javac output, in particular, warning > messages. > diff -r 6fbd69f8e3ab make/common/Rules.gmk > --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 > +++ b/make/common/Rules.gmk Mon Nov 28 16:34:34 2011 -0800 > @@ -236,9 +236,10 @@ > @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ > $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ > $(CAT) $<.filtered; \ > - $(ECHO) "# Running javac:"; \ > + $(ECHO) "# Running javac: `$(WC) -l < $<.filtered` files; in `pwd`"; \ Can we do this without running wc a second time? Also shouldn't the current working directory be known from when the current sub-dir is entered by make? David ----- > $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered; \ > $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ > + $(ECHO) "# javac finished"; \ > fi > @$(java-vm-cleanup) From stuart.marks at oracle.com Tue Nov 29 04:00:23 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Mon, 28 Nov 2011 20:00:23 -0800 Subject: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation In-Reply-To: <4ED44AC2.9010700@oracle.com> References: <4ED42A90.4030003@oracle.com> <4ED44AC2.9010700@oracle.com> Message-ID: <4ED458D7.3000308@oracle.com> On 11/28/11 7:00 PM, David Holmes wrote: > On 29/11/2011 10:42 AM, Stuart Marks wrote: >> Please review this change to add to the javac make rule some messages >> about the number of files being compiled, the current working directory, >> and a new message to demarcate the end of javac output. >> >> This will help capture and analyze javac output, in particular, warning >> messages. >> diff -r 6fbd69f8e3ab make/common/Rules.gmk >> --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 >> +++ b/make/common/Rules.gmk Mon Nov 28 16:34:34 2011 -0800 >> @@ -236,9 +236,10 @@ >> @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ >> $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ >> $(CAT) $<.filtered; \ >> - $(ECHO) "# Running javac:"; \ >> + $(ECHO) "# Running javac: `$(WC) -l < $<.filtered` files; in `pwd`"; \ > > Can we do this without running wc a second time? > > Also shouldn't the current working directory be known from when the current > sub-dir is entered by make? We can store the result of wc in a shell variable, but it has to be part of the same command as the if-statement that uses it, since successive lines of a make rule are executed by different shells. I've done this; see below. The current directory can probably be deduced, but it's not as simple as tracking the current subdirectory. Often the current directory is arrived at after having left a subdirectory. For example, this rule is invoked after this fragment of enter/leave messages from make have occurred: make[2]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/java' make[3]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/nio' make[3]: Leaving directory `/home/smarks/src/jdk8-jdk/make/java/nio' The current directory is now ..../make/java/java which isn't from the most recent "Entering" message, nor is it the parent of the most recent "Leaving" message. In this case make/java/java/Makefile calls a recursive make in ../nio! So, a script would have to track all the enter/leave messages and keep a stack of directories entered and left in order to determine the current one. I could enhance the parsing scripts to do this, but it seems complex and error-prone. If you're concerned about build performance, it *might* save a fork to replace a call to `pwd` with a make variable reference to $(CURDIR). The wc refactoring also saves a fork of the cat command. (Though I admit I don't know whether these actually speed things up or whether any change is measurable.) Revised diff below. Note that I've indented the entire if-statement as well as its contents, which is why so many more lines are changed. s'marks diff -r 6fbd69f8e3ab make/common/Rules.gmk --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 +++ b/make/common/Rules.gmk Mon Nov 28 19:40:34 2011 -0800 @@ -233,13 +233,15 @@ @$(MKDIR) -p $(CLASSDESTDIR) @$(RM) $<.filtered @$(CAT) $< | $(NAWK) 'length>0' | $(SORT) -u > $<.filtered - @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ - $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ - $(CAT) $<.filtered; \ - $(ECHO) "# Running javac:"; \ - $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ - fi + @numfiles=`$(WC) -l < $<.filtered` ; \ + if [ $$numfiles -ge 1 ] ; then \ + $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ + $(CAT) $<.filtered; \ + $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ + $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ + $(ECHO) "# javac finished"; \ + fi @$(java-vm-cleanup) clobber clean:: From david.holmes at oracle.com Tue Nov 29 04:16:20 2011 From: david.holmes at oracle.com (David Holmes) Date: Tue, 29 Nov 2011 14:16:20 +1000 Subject: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation In-Reply-To: <4ED458D7.3000308@oracle.com> References: <4ED42A90.4030003@oracle.com> <4ED44AC2.9010700@oracle.com> <4ED458D7.3000308@oracle.com> Message-ID: <4ED45C94.2000504@oracle.com> Thanks Stuart - looks okay to me. David On 29/11/2011 2:00 PM, Stuart Marks wrote: > > > On 11/28/11 7:00 PM, David Holmes wrote: >> On 29/11/2011 10:42 AM, Stuart Marks wrote: >>> Please review this change to add to the javac make rule some messages >>> about the number of files being compiled, the current working directory, >>> and a new message to demarcate the end of javac output. >>> >>> This will help capture and analyze javac output, in particular, warning >>> messages. >>> diff -r 6fbd69f8e3ab make/common/Rules.gmk >>> --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 >>> +++ b/make/common/Rules.gmk Mon Nov 28 16:34:34 2011 -0800 >>> @@ -236,9 +236,10 @@ >>> @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ >>> $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ >>> $(CAT) $<.filtered; \ >>> - $(ECHO) "# Running javac:"; \ >>> + $(ECHO) "# Running javac: `$(WC) -l < $<.filtered` files; in `pwd`"; \ >> >> Can we do this without running wc a second time? >> >> Also shouldn't the current working directory be known from when the >> current >> sub-dir is entered by make? > > We can store the result of wc in a shell variable, but it has to be part > of the same command as the if-statement that uses it, since successive > lines of a make rule are executed by different shells. I've done this; > see below. > > The current directory can probably be deduced, but it's not as simple as > tracking the current subdirectory. Often the current directory is > arrived at after having left a subdirectory. For example, this rule is > invoked after this fragment of enter/leave messages from make have > occurred: > > make[2]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/java' > make[3]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/nio' > make[3]: Leaving directory `/home/smarks/src/jdk8-jdk/make/java/nio' > > The current directory is now ..../make/java/java which isn't from the > most recent "Entering" message, nor is it the parent of the most recent > "Leaving" message. In this case make/java/java/Makefile calls a > recursive make in ../nio! So, a script would have to track all the > enter/leave messages and keep a stack of directories entered and left in > order to determine the current one. I could enhance the parsing scripts > to do this, but it seems complex and error-prone. > > If you're concerned about build performance, it *might* save a fork to > replace a call to `pwd` with a make variable reference to $(CURDIR). The > wc refactoring also saves a fork of the cat command. (Though I admit I > don't know whether these actually speed things up or whether any change > is measurable.) > > Revised diff below. Note that I've indented the entire if-statement as > well as its contents, which is why so many more lines are changed. > > s'marks > > > > diff -r 6fbd69f8e3ab make/common/Rules.gmk > --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 > +++ b/make/common/Rules.gmk Mon Nov 28 19:40:34 2011 -0800 > @@ -233,13 +233,15 @@ > @$(MKDIR) -p $(CLASSDESTDIR) > @$(RM) $<.filtered > @$(CAT) $< | $(NAWK) 'length>0' | $(SORT) -u > $<.filtered > - @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ > - $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ > - $(CAT) $<.filtered; \ > - $(ECHO) "# Running javac:"; \ > - $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered; \ > - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered; \ > - fi > + @numfiles=`$(WC) -l < $<.filtered` ; \ > + if [ $$numfiles -ge 1 ] ; then \ > + $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ > + $(CAT) $<.filtered; \ > + $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ > + $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered; \ > + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) > @$<.filtered; \ > + $(ECHO) "# javac finished"; \ > + fi > @$(java-vm-cleanup) > > clobber clean:: From benjamin.john.evans at gmail.com Tue Nov 29 11:47:04 2011 From: benjamin.john.evans at gmail.com (Ben Evans) Date: Tue, 29 Nov 2011 11:47:04 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: Hi Xiomara, This looks like a great project, and is definitely the sort of participation that the user group community can help with. However, we need more lead time to effectively participate. In our experience the best way for the community to help with something like this is to have a physical meet. That way the relatively small number of people in our communities who can build OpenJDK are able to help the others bootstrap ("teach them to fish"), and thereby increase overall participation. As this is an out-of-work activity for the vast majority of our members, we need time to plan and promote our events - especially if this is to be done as an after-work activity. We probably won't be able to manage to put an event together for this week - but on the assumption that there'll still be plenty of warnings to squish - can we plan for a later date when we can help? >From the community side, some of the right people to reach out to are myself and Martijn Verburg from LJC (London), and Bruno Souza and Yara Senger from SouJava (Brazil) - we can then ensure the message gets out to the rest of the global JUG community. Shame that it's probably too close for us to do much this time - but let us know how it goes, and we'd definitely love to do something if we had more notice. Thanks, Ben On Tue, Nov 29, 2011 at 2:10 AM, Xiomara Jayasena wrote: > A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. ?We would like to invite you to participate. > > > > To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. ?If you decide to participate then please reply to this e-mail with the area that you intend to work on. ?I will keep track of the areas so that there is no overlap of work. > > > > . ? ? ? ? A group of us working on this project will create bugs for the areas that developers sign up for. > > . ? ? ? ? The focus will be on java warnings, since these are less risky. > > . ? ? ? ? For this exercise please avoid making any API changes or any large scale refactorings. > > . ? ? ? ? Avoid @SuppressWarnings except where it is clearly necessary. > > . ? ? ? ? We would like to have the code changes completed by 5pm (PST) on Dec. 1st. > > . ? ? ? ? A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. ?The java files are in java.io, java.lang, java.util and a variety of related packages. > > > > Process to follow: > > > > 1. ? ? ? Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. > > 2. ? ? ? A bug ID will be generated for this. > > 3. ? ? ? Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk > > 4. ? ? ? Post your changes for review. ?If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. ?If the patch is too cumbersome to review, we can generate a webrev for you. > > 5. ? ? ? All of the changes must go through the usual build, test and review process before being pushed. ?If you are a JDK8 committer you may push after completing the usual process. ?If you aren't a committer we will help you review and test your changes. > > 6. ? ? ? In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! > > > > Lastly to get a build with warnings enable use the following flags: > > make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" > > > > Tip: Make sure to redirect output to a file. ?To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." > > > > -Xiomara > From spoole at linux.vnet.ibm.com Tue Nov 29 16:36:23 2011 From: spoole at linux.vnet.ibm.com (Steve Poole) Date: Tue, 29 Nov 2011 16:36:23 +0000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED3B4D2.2070403@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> Message-ID: <1322584583.12065.6.camel@jazzette> On Mon, 2011-11-28 at 17:20 +0100, Fredrik ?hrstr?m wrote: > 2011-11-28 16:46, Ulf Zibis skrev: > > I guess you meant: > > --shared > > --posix > > |--SYSV > > | |--solaris > > | |--aix > > | > > |--gnu > > | |--linux > > | | > > |--BSD > > |--darwin > > |--freebsd > > > > --winapi > > |--win32 > > |--wince > > > > against current ... > > --share > > --linux > > --solaris > > --windows > > > > The directory structure ought to be more flat than > the possible combinations that form a product. > > For example if: > HOST_API = posix winapi > HOST_OS = solaris aix gnu linux darwin freebsd windows wince > HOST_OS_PEDIGREE = SYSV GNU BSD > > then the directories are stored flat under src: > > --src > |--share > |--posix > |--winapi > |--SYSV > |--GNU > |--BSD > |--solaris > |--aix > |--gnu > |--linux > |--darwin > |--freebsd > |--windows > |--wince > I think that make sense. This is one of these discussions in which there is no simple answer. Trying to architect a directory structure to match all the possible combinations (now and for the future) is likely just to make things even more complicated. This approach is simple and makes it easy for new platforms to just drop in. > Then, when compiling, the union of the directories and files below > the selected src subdirectories, form the source of the product. > For example: > share,posix,BSD,darwin > share,posix,GNU,linux > share,posix,GNU,gnu > share,winapi,windows > > This gives less confusion about which subdirs to src/posix > are configuration directories, and which are posix directories with code. > I do like this approach -especially if the union of directories per platform is well documented and visible. That would really help understand the impact when someone has to change a file in one of these subdirectories. > //Fredrik > From kelly.ohair at oracle.com Tue Nov 29 19:13:36 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 29 Nov 2011 11:13:36 -0800 Subject: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation In-Reply-To: <4ED458D7.3000308@oracle.com> References: <4ED42A90.4030003@oracle.com> <4ED44AC2.9010700@oracle.com> <4ED458D7.3000308@oracle.com> Message-ID: Looks fine to me. -kto On Nov 28, 2011, at 8:00 PM, Stuart Marks wrote: > > > On 11/28/11 7:00 PM, David Holmes wrote: >> On 29/11/2011 10:42 AM, Stuart Marks wrote: >>> Please review this change to add to the javac make rule some messages >>> about the number of files being compiled, the current working directory, >>> and a new message to demarcate the end of javac output. >>> >>> This will help capture and analyze javac output, in particular, warning >>> messages. >>> diff -r 6fbd69f8e3ab make/common/Rules.gmk >>> --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 >>> +++ b/make/common/Rules.gmk Mon Nov 28 16:34:34 2011 -0800 >>> @@ -236,9 +236,10 @@ >>> @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ >>> $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ >>> $(CAT) $<.filtered; \ >>> - $(ECHO) "# Running javac:"; \ >>> + $(ECHO) "# Running javac: `$(WC) -l < $<.filtered` files; in `pwd`"; \ >> >> Can we do this without running wc a second time? >> >> Also shouldn't the current working directory be known from when the current >> sub-dir is entered by make? > > We can store the result of wc in a shell variable, but it has to be part of the same command as the if-statement that uses it, since successive lines of a make rule are executed by different shells. I've done this; see below. > > The current directory can probably be deduced, but it's not as simple as tracking the current subdirectory. Often the current directory is arrived at after having left a subdirectory. For example, this rule is invoked after this fragment of enter/leave messages from make have occurred: > > make[2]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/java' > make[3]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/nio' > make[3]: Leaving directory `/home/smarks/src/jdk8-jdk/make/java/nio' > > The current directory is now ..../make/java/java which isn't from the most recent "Entering" message, nor is it the parent of the most recent "Leaving" message. In this case make/java/java/Makefile calls a recursive make in ../nio! So, a script would have to track all the enter/leave messages and keep a stack of directories entered and left in order to determine the current one. I could enhance the parsing scripts to do this, but it seems complex and error-prone. > > If you're concerned about build performance, it *might* save a fork to replace a call to `pwd` with a make variable reference to $(CURDIR). The wc refactoring also saves a fork of the cat command. (Though I admit I don't know whether these actually speed things up or whether any change is measurable.) > > Revised diff below. Note that I've indented the entire if-statement as well as its contents, which is why so many more lines are changed. > > s'marks > > > > diff -r 6fbd69f8e3ab make/common/Rules.gmk > --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 > +++ b/make/common/Rules.gmk Mon Nov 28 19:40:34 2011 -0800 > @@ -233,13 +233,15 @@ > @$(MKDIR) -p $(CLASSDESTDIR) > @$(RM) $<.filtered > @$(CAT) $< | $(NAWK) 'length>0' | $(SORT) -u > $<.filtered > - @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ > - $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ > - $(CAT) $<.filtered; \ > - $(ECHO) "# Running javac:"; \ > - $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ > - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ > - fi > + @numfiles=`$(WC) -l < $<.filtered` ; \ > + if [ $$numfiles -ge 1 ] ; then \ > + $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ > + $(CAT) $<.filtered; \ > + $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ > + $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ > + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ > + $(ECHO) "# javac finished"; \ > + fi > @$(java-vm-cleanup) > > clobber clean:: From philip.race at oracle.com Tue Nov 29 19:34:06 2011 From: philip.race at oracle.com (Phil Race) Date: Tue, 29 Nov 2011 11:34:06 -0800 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <1322584583.12065.6.camel@jazzette> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> Message-ID: <4ED533AE.10609@oracle.com> > --src > |--share > |--posix > |--winapi > |--SYSV > |--GNU > |--BSD > |--solaris > |--aix > |--gnu > |--linux > |--darwin > |--freebsd > |--windows > |--wince * 95%+ of the code will be the same across solaris/linux/etc And remember this includes all the X11 code. * Of the remaining 5%, most of it is best dealt with via ifdef because its a few line delta in a large file. I'd guess 2% of the code might merit a separate source file. So whilst these may exist in ports that doesn't mean they should all exist in mainline. I suggest to keep src/solaris (for historical reasons) as meaing "src shared across the unix/X11 family" and others in mainline only for the core supported platforms, which will add macosx in JDK 8, largely because of client code differences Ports would add their own platform dir if they need to, or add ifdefs in src/solaris if that's easier. -phil. On 11/29/2011 8:36 AM, Steve Poole wrote: > On Mon, 2011-11-28 at 17:20 +0100, Fredrik ?hrstr?m wrote: >> 2011-11-28 16:46, Ulf Zibis skrev: >>> I guess you meant: >>> --shared >>> --posix >>> |--SYSV >>> | |--solaris >>> | |--aix >>> | >>> |--gnu >>> | |--linux >>> | | >>> |--BSD >>> |--darwin >>> |--freebsd >>> >>> --winapi >>> |--win32 >>> |--wince >>> >>> against current ... >>> --share >>> --linux >>> --solaris >>> --windows >>> >> The directory structure ought to be more flat than >> the possible combinations that form a product. >> >> For example if: >> HOST_API = posix winapi >> HOST_OS = solaris aix gnu linux darwin freebsd windows wince >> HOST_OS_PEDIGREE = SYSV GNU BSD >> >> then the directories are stored flat under src: >> >> --src >> |--share >> |--posix >> |--winapi >> |--SYSV >> |--GNU >> |--BSD >> |--solaris >> |--aix >> |--gnu >> |--linux >> |--darwin >> |--freebsd >> |--windows >> |--wince >> > I think that make sense. This is one of these discussions in which there > is no simple answer. Trying to architect a directory structure to match > all the possible combinations (now and for the future) is likely just to > make things even more complicated. > > This approach is simple and makes it easy for new platforms to just drop > in. > >> Then, when compiling, the union of the directories and files below >> the selected src subdirectories, form the source of the product. >> For example: >> share,posix,BSD,darwin >> share,posix,GNU,linux >> share,posix,GNU,gnu >> share,winapi,windows >> >> This gives less confusion about which subdirs to src/posix >> are configuration directories, and which are posix directories with code. >> > I do like this approach -especially if the union of directories per > platform is well documented and visible. That would really help > understand the impact when someone has to change a file in one of these > subdirectories. > >> //Fredrik >> > From Alan.Bateman at oracle.com Tue Nov 29 22:00:46 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 29 Nov 2011 22:00:46 +0000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED533AE.10609@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> Message-ID: <4ED5560E.6070004@oracle.com> On 29/11/2011 19:34, Phil Race wrote: > : > > * 95%+ of the code will be the same across solaris/linux/etc > And remember this includes all the X11 code. > * Of the remaining 5%, most of it is best dealt with via ifdef > because its a few line delta in a large file. > I'd guess 2% of the code might merit a separate source file. > > So whilst these may exist in ports that doesn't mean they should all > exist > in mainline. I suggest to keep src/solaris (for historical reasons) as > meaing "src shared across the unix/X11 family" and others in mainline > only for the core supported platforms, which will add macosx in JDK 8, > largely because of client code differences > > Ports would add their own platform dir if they need to, or add ifdefs > in src/solaris > if that's easier. I'm not so sure about keeping src/solaris as "src shared across the unix/X11 family", I'd prefer it be renamed to something that doesn't have "solaris" or "sunos" in the name. The reason is that keeping solaris in the name means there isn't an obvious location for Solaris specific files. If they stay in src/solaris then it means this tree requires pre-processing or filtering in the build. We do this today in several places with no consistency and it would be nice to get rid of this. In any case, keeping the directory structure flat as Fredrick suggested make sense to me. Whether we will actually or refactor to the point where we need sysv, gnu, etc. directories isn't clear to me. I think we would be doing well to replace most of the ifdef __solaris__ and ifdef __linux__ usages with ifdef . -Alan. From philip.race at oracle.com Tue Nov 29 23:08:58 2011 From: philip.race at oracle.com (Phil Race) Date: Tue, 29 Nov 2011 15:08:58 -0800 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED5560E.6070004@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> Message-ID: <4ED5660A.3010200@oracle.com> Flat vs Hierarchical is OK. its needless proliferation I was objecting to. If "ifdef capability" can be used I have no issues with that either. I suggested maintaining the name as src/solaris partly because I don't believe in churn and am not sure what would make a better name other than src/unix .. would that be OK ? You could create src/sunos for the really sunos parts .. Keeping the name the same also makes applying backport patches much easier. Well, that and of course my fingers know it very well. -phil. On 11/29/2011 2:00 PM, Alan Bateman wrote: > On 29/11/2011 19:34, Phil Race wrote: >> : >> >> * 95%+ of the code will be the same across solaris/linux/etc >> And remember this includes all the X11 code. >> * Of the remaining 5%, most of it is best dealt with via ifdef >> because its a few line delta in a large file. >> I'd guess 2% of the code might merit a separate source file. >> >> So whilst these may exist in ports that doesn't mean they should all >> exist >> in mainline. I suggest to keep src/solaris (for historical reasons) as >> meaing "src shared across the unix/X11 family" and others in mainline >> only for the core supported platforms, which will add macosx in JDK 8, >> largely because of client code differences >> >> Ports would add their own platform dir if they need to, or add ifdefs >> in src/solaris >> if that's easier. > I'm not so sure about keeping src/solaris as "src shared across the > unix/X11 family", I'd prefer it be renamed to something that doesn't > have "solaris" or "sunos" in the name. The reason is that keeping > solaris in the name means there isn't an obvious location for Solaris > specific files. If they stay in src/solaris then it means this tree > requires pre-processing or filtering in the build. We do this today in > several places with no consistency and it would be nice to get rid of > this. > > In any case, keeping the directory structure flat as Fredrick > suggested make sense to me. Whether we will actually or refactor to > the point where we need sysv, gnu, etc. directories isn't clear to me. > I think we would be doing well to replace most of the ifdef > __solaris__ and ifdef __linux__ usages with ifdef . > > -Alan. From stuart.marks at oracle.com Tue Nov 29 23:09:39 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 29 Nov 2011 15:09:39 -0800 Subject: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation In-Reply-To: References: <4ED42A90.4030003@oracle.com> <4ED44AC2.9010700@oracle.com> <4ED458D7.3000308@oracle.com> Message-ID: <4ED56633.4000003@oracle.com> Thanks Kelly (and David). Any objection if I were to push this into the TL forest? A test build on all the platforms (including Windows) was successful. s'marks On 11/29/11 11:13 AM, Kelly O'Hair wrote: > Looks fine to me. > > -kto > > On Nov 28, 2011, at 8:00 PM, Stuart Marks wrote: > >> >> >> On 11/28/11 7:00 PM, David Holmes wrote: >>> On 29/11/2011 10:42 AM, Stuart Marks wrote: >>>> Please review this change to add to the javac make rule some messages >>>> about the number of files being compiled, the current working directory, >>>> and a new message to demarcate the end of javac output. >>>> >>>> This will help capture and analyze javac output, in particular, warning >>>> messages. >>>> diff -r 6fbd69f8e3ab make/common/Rules.gmk >>>> --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 >>>> +++ b/make/common/Rules.gmk Mon Nov 28 16:34:34 2011 -0800 >>>> @@ -236,9 +236,10 @@ >>>> @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ >>>> $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ >>>> $(CAT) $<.filtered; \ >>>> - $(ECHO) "# Running javac:"; \ >>>> + $(ECHO) "# Running javac: `$(WC) -l< $<.filtered` files; in `pwd`"; \ >>> >>> Can we do this without running wc a second time? >>> >>> Also shouldn't the current working directory be known from when the current >>> sub-dir is entered by make? >> >> We can store the result of wc in a shell variable, but it has to be part of the same command as the if-statement that uses it, since successive lines of a make rule are executed by different shells. I've done this; see below. >> >> The current directory can probably be deduced, but it's not as simple as tracking the current subdirectory. Often the current directory is arrived at after having left a subdirectory. For example, this rule is invoked after this fragment of enter/leave messages from make have occurred: >> >> make[2]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/java' >> make[3]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/nio' >> make[3]: Leaving directory `/home/smarks/src/jdk8-jdk/make/java/nio' >> >> The current directory is now ..../make/java/java which isn't from the most recent "Entering" message, nor is it the parent of the most recent "Leaving" message. In this case make/java/java/Makefile calls a recursive make in ../nio! So, a script would have to track all the enter/leave messages and keep a stack of directories entered and left in order to determine the current one. I could enhance the parsing scripts to do this, but it seems complex and error-prone. >> >> If you're concerned about build performance, it *might* save a fork to replace a call to `pwd` with a make variable reference to $(CURDIR). The wc refactoring also saves a fork of the cat command. (Though I admit I don't know whether these actually speed things up or whether any change is measurable.) >> >> Revised diff below. Note that I've indented the entire if-statement as well as its contents, which is why so many more lines are changed. >> >> s'marks >> >> >> >> diff -r 6fbd69f8e3ab make/common/Rules.gmk >> --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 >> +++ b/make/common/Rules.gmk Mon Nov 28 19:40:34 2011 -0800 >> @@ -233,13 +233,15 @@ >> @$(MKDIR) -p $(CLASSDESTDIR) >> @$(RM) $<.filtered >> @$(CAT) $< | $(NAWK) 'length>0' | $(SORT) -u> $<.filtered >> - @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ >> - $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ >> - $(CAT) $<.filtered; \ >> - $(ECHO) "# Running javac:"; \ >> - $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >> - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >> - fi >> + @numfiles=`$(WC) -l< $<.filtered` ; \ >> + if [ $$numfiles -ge 1 ] ; then \ >> + $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ >> + $(CAT) $<.filtered; \ >> + $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ >> + $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >> + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >> + $(ECHO) "# javac finished"; \ >> + fi >> @$(java-vm-cleanup) >> >> clobber clean:: > From kelly.ohair at oracle.com Tue Nov 29 23:54:17 2011 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 29 Nov 2011 15:54:17 -0800 Subject: please review fix for 7116322, enhance javac make rule with a little bit of instrumentation In-Reply-To: <4ED56633.4000003@oracle.com> References: <4ED42A90.4030003@oracle.com> <4ED44AC2.9010700@oracle.com> <4ED458D7.3000308@oracle.com> <4ED56633.4000003@oracle.com> Message-ID: <3B24C240-B32F-4814-8815-64703DC16C40@oracle.com> No objection from me. -kto On Nov 29, 2011, at 3:09 PM, Stuart Marks wrote: > Thanks Kelly (and David). > > Any objection if I were to push this into the TL forest? A test build on all the platforms (including Windows) was successful. > > s'marks > > On 11/29/11 11:13 AM, Kelly O'Hair wrote: >> Looks fine to me. >> >> -kto >> >> On Nov 28, 2011, at 8:00 PM, Stuart Marks wrote: >> >>> >>> >>> On 11/28/11 7:00 PM, David Holmes wrote: >>>> On 29/11/2011 10:42 AM, Stuart Marks wrote: >>>>> Please review this change to add to the javac make rule some messages >>>>> about the number of files being compiled, the current working directory, >>>>> and a new message to demarcate the end of javac output. >>>>> >>>>> This will help capture and analyze javac output, in particular, warning >>>>> messages. >>>>> diff -r 6fbd69f8e3ab make/common/Rules.gmk >>>>> --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 >>>>> +++ b/make/common/Rules.gmk Mon Nov 28 16:34:34 2011 -0800 >>>>> @@ -236,9 +236,10 @@ >>>>> @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ >>>>> $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ >>>>> $(CAT) $<.filtered; \ >>>>> - $(ECHO) "# Running javac:"; \ >>>>> + $(ECHO) "# Running javac: `$(WC) -l< $<.filtered` files; in `pwd`"; \ >>>> >>>> Can we do this without running wc a second time? >>>> >>>> Also shouldn't the current working directory be known from when the current >>>> sub-dir is entered by make? >>> >>> We can store the result of wc in a shell variable, but it has to be part of the same command as the if-statement that uses it, since successive lines of a make rule are executed by different shells. I've done this; see below. >>> >>> The current directory can probably be deduced, but it's not as simple as tracking the current subdirectory. Often the current directory is arrived at after having left a subdirectory. For example, this rule is invoked after this fragment of enter/leave messages from make have occurred: >>> >>> make[2]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/java' >>> make[3]: Entering directory `/home/smarks/src/jdk8-jdk/make/java/nio' >>> make[3]: Leaving directory `/home/smarks/src/jdk8-jdk/make/java/nio' >>> >>> The current directory is now ..../make/java/java which isn't from the most recent "Entering" message, nor is it the parent of the most recent "Leaving" message. In this case make/java/java/Makefile calls a recursive make in ../nio! So, a script would have to track all the enter/leave messages and keep a stack of directories entered and left in order to determine the current one. I could enhance the parsing scripts to do this, but it seems complex and error-prone. >>> >>> If you're concerned about build performance, it *might* save a fork to replace a call to `pwd` with a make variable reference to $(CURDIR). The wc refactoring also saves a fork of the cat command. (Though I admit I don't know whether these actually speed things up or whether any change is measurable.) >>> >>> Revised diff below. Note that I've indented the entire if-statement as well as its contents, which is why so many more lines are changed. >>> >>> s'marks >>> >>> >>> >>> diff -r 6fbd69f8e3ab make/common/Rules.gmk >>> --- a/make/common/Rules.gmk Fri Nov 18 09:03:43 2011 +0000 >>> +++ b/make/common/Rules.gmk Mon Nov 28 19:40:34 2011 -0800 >>> @@ -233,13 +233,15 @@ >>> @$(MKDIR) -p $(CLASSDESTDIR) >>> @$(RM) $<.filtered >>> @$(CAT) $< | $(NAWK) 'length>0' | $(SORT) -u> $<.filtered >>> - @if [ `$(CAT) $<.filtered | $(WC) -l` -ge 1 ] ; then \ >>> - $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ >>> - $(CAT) $<.filtered; \ >>> - $(ECHO) "# Running javac:"; \ >>> - $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >>> - $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >>> - fi >>> + @numfiles=`$(WC) -l< $<.filtered` ; \ >>> + if [ $$numfiles -ge 1 ] ; then \ >>> + $(ECHO) "# Java sources to be compiled: (listed in file $<)"; \ >>> + $(CAT) $<.filtered; \ >>> + $(ECHO) "# Running javac: $$numfiles files; in $(CURDIR)"; \ >>> + $(ECHO) $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >>> + $(JAVAC_CMD) -sourcepath "$(SOURCEPATH)" -d $(CLASSDESTDIR) @$<.filtered; \ >>> + $(ECHO) "# javac finished"; \ >>> + fi >>> @$(java-vm-cleanup) >>> >>> clobber clean:: >> From sebastian.sickelmann at gmx.de Wed Nov 30 04:01:47 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Wed, 30 Nov 2011 05:01:47 +0100 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <4ED5AAAB.6070404@gmx.de> This is a great idea. Don't know how many time i can invest in the timeframe (till 02:00 am GMT+1) but i want to look at java.io -- Sebastian Am 29.11.2011 03:10, schrieb Xiomara Jayasena: > A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. We would like to invite you to participate. > > > > To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. If you decide to participate then please reply to this e-mail with the area that you intend to work on. I will keep track of the areas so that there is no overlap of work. > > > > . A group of us working on this project will create bugs for the areas that developers sign up for. > > . The focus will be on java warnings, since these are less risky. > > . For this exercise please avoid making any API changes or any large scale refactorings. > > . Avoid @SuppressWarnings except where it is clearly necessary. > > . We would like to have the code changes completed by 5pm (PST) on Dec. 1st. > > . A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. The java files are in java.io, java.lang, java.util and a variety of related packages. > > > > Process to follow: > > > > 1. Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. > > 2. A bug ID will be generated for this. > > 3. Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk > > 4. Post your changes for review. If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. If the patch is too cumbersome to review, we can generate a webrev for you. > > 5. All of the changes must go through the usual build, test and review process before being pushed. If you are a JDK8 committer you may push after completing the usual process. If you aren't a committer we will help you review and test your changes. > > 6. In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! > > > > Lastly to get a build with warnings enable use the following flags: > > make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" > > > > Tip: Make sure to redirect output to a file. To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." > > > > -Xiomara From spoole at linux.vnet.ibm.com Wed Nov 30 12:05:21 2011 From: spoole at linux.vnet.ibm.com (Steve Poole) Date: Wed, 30 Nov 2011 12:05:21 +0000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED5660A.3010200@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> Message-ID: <1322654721.26124.2.camel@jazzette> On Tue, 2011-11-29 at 15:08 -0800, Phil Race wrote: > Flat vs Hierarchical is OK. its needless proliferation I was objecting to. > > If "ifdef capability" can be used I have no issues with that either. > > I suggested maintaining the name as src/solaris partly because I don't > believe in churn > and am not sure what would make a better name other than src/unix .. > would that be OK ? +1 for src/unix > You could create src/sunos for the really sunos parts .. > Keeping the name the same also makes applying backport patches much easier. > Well, that and of course my fingers know it very well. > -phil. > > On 11/29/2011 2:00 PM, Alan Bateman wrote: > > On 29/11/2011 19:34, Phil Race wrote: > >> : > >> > >> * 95%+ of the code will be the same across solaris/linux/etc > >> And remember this includes all the X11 code. > >> * Of the remaining 5%, most of it is best dealt with via ifdef > >> because its a few line delta in a large file. > >> I'd guess 2% of the code might merit a separate source file. > >> > >> So whilst these may exist in ports that doesn't mean they should all > >> exist > >> in mainline. I suggest to keep src/solaris (for historical reasons) as > >> meaing "src shared across the unix/X11 family" and others in mainline > >> only for the core supported platforms, which will add macosx in JDK 8, > >> largely because of client code differences > >> > >> Ports would add their own platform dir if they need to, or add ifdefs > >> in src/solaris > >> if that's easier. > > I'm not so sure about keeping src/solaris as "src shared across the > > unix/X11 family", I'd prefer it be renamed to something that doesn't > > have "solaris" or "sunos" in the name. The reason is that keeping > > solaris in the name means there isn't an obvious location for Solaris > > specific files. If they stay in src/solaris then it means this tree > > requires pre-processing or filtering in the build. We do this today in > > several places with no consistency and it would be nice to get rid of > > this. > > > > In any case, keeping the directory structure flat as Fredrick > > suggested make sense to me. Whether we will actually or refactor to > > the point where we need sysv, gnu, etc. directories isn't clear to me. > > I think we would be doing well to replace most of the ifdef > > __solaris__ and ifdef __linux__ usages with ifdef . > > > > -Alan. > From Dmitry.Samersoff at oracle.com Wed Nov 30 12:10:36 2011 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 30 Nov 2011 16:10:36 +0400 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <1322654721.26124.2.camel@jazzette> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> <1322654721.26124.2.camel@jazzette> Message-ID: <4ED61D3C.1080501@oracle.com> On 2011-11-30 16:05, Steve Poole wrote: >> I suggested maintaining the name as src/solaris partly because I don't >> believe in churn >> and am not sure what would make a better name other than src/unix .. >> would that be OK ? > > +1 for src/unix count me too for src/unix +1 -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From stefan.karlsson at oracle.com Wed Nov 30 12:37:03 2011 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Wed, 30 Nov 2011 13:37:03 +0100 Subject: Review request (s): 7116081: USE_PRECOMPILED_HEADER=0 triggers a single threaded build of the JVM In-Reply-To: <4ED49C05.5090306@oracle.com> References: <4ED39BF0.7040802@oracle.com> <4ED41DEB.2000600@oracle.com> <4ED49C05.5090306@oracle.com> Message-ID: <4ED6236F.9060608@oracle.com> Looping in build-dev and build-infra-dev. StefanK On 11/29/2011 09:47 AM, Stefan Karlsson wrote: > David, > > Thanks for the review. > > All, > > Updated webrev: http://cr.openjdk.java.net/~stefank/7116081/webrev.2/ > > The rationale for this change is inlined: > > On 11/29/2011 12:48 AM, David Holmes wrote: >> Hi Stefan, >> >> On 29/11/2011 12:34 AM, Stefan Karlsson wrote: >>> http://cr.openjdk.java.net/~stefank/7116081/webrev/ >>> >>> Turning off the precompiled headers is somewhat broken. It triggers a >>> single threaded build even when HOTSPOT_BUILD_JOBS has been set. With >>> this fix the compile times went from around 14 minutes to 2.5 minutes, >>> on an 8 core machine. >> >> Took me a while to figure out why this was the case :) >> >>> This affects both Linux and BSD builds, but has only been tested on >>> Linux. It would be great if someone with access to a BSD machine could >>> verify this fix. >> >> The problem here was using >> >> ifdef USE_PRECOMPILED_HEADER >> >> when defining it to 0 is used to turn it off - so it seems to me the >> better fix here was to simply change to: >> >> ifeq ($(USE_PRECOMPILED_HEADER),1) > > I've changed the conditional to check USE_PRECOMPILED_HEADER instead. > > While doing that I found another issue. In gcc.make we try to redefine > USE_PRECOMPILED_HEADER: > > 88 ifneq ($(USE_PRECOMPILED_HEADER),0) > 89 USE_PRECOMPILED_HEADER=1 > > > That doesn't work, so setting USE_PRECOMPILED_HEADER= (not 0)> on the command line will leave the precompiled headers on, > but later logic: > > 219 ifneq ($(USE_PRECOMPILED_HEADER),1) > 220 CFLAGS += -DDONT_USE_PRECOMPILED_HEADER > > will empty the precompiled.hpp file. From precompiled.hpp: > > // Precompiled headers are turned off for Sun Studion, > // or if the user passes USE_PRECOMPILED_HEADER=0 to the makefiles. > #ifndef DONT_USE_PRECOMPILED_HEADER > > In the new webrev I've changed all places where we read > USE_PRECOMPILED_HEADER to always compare against 0. > > thanks, > StefanK > >> >> >> The removal of: >> >> PrecompiledOption = -DUSE_PRECOMPILED_HEADER >> >> seems okay. >> >> Cheers, >> David >> >> > From Ulf.Zibis at gmx.de Wed Nov 30 13:15:43 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 30 Nov 2011 14:15:43 +0100 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED61D3C.1080501@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> <1322654721.26124.2.camel@jazzette> <4ED61D3C.1080501@oracle.com> Message-ID: <4ED62C7F.4030005@gmx.de> Am 30.11.2011 13:10, schrieb Dmitry Samersoff: > On 2011-11-30 16:05, Steve Poole wrote: >>> I suggested maintaining the name as src/solaris partly because I don't >>> believe in churn >>> and am not sure what would make a better name other than src/unix .. >>> would that be OK ? >> +1 for src/unix > count me too for src/unix > +1 I more would like src/posix + src/winapi Combining Flat vs Hierarchical advantages: src/common or 'general' or 'independent' in homage to platform-independent src/posix src/posix.BSD src/posix.GNU src/posix.GNU.Linux src/posix.SYSV src/posix.SYSV.AIX src/posix.SYSV.Sun src/posix.X11 src/winapi src/winapi.32 src/winapi.CE Or "correctly": src/all src/all.posix src/all.posix.BSD src/all.posix.SYSV.Sun src/all.winapi Alternative: src/posix-GNU-Linux -Ulf From philip.race at oracle.com Wed Nov 30 17:16:48 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 30 Nov 2011 09:16:48 -0800 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED62C7F.4030005@gmx.de> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> <1322654721.26124.2.camel@jazzette> <4ED61D3C.1080501@oracle.com> <4ED62C7F.4030005@gmx.de> Message-ID: <4ED66500.4020808@oracle.com> On 11/30/2011 5:15 AM, Ulf Zibis wrote: > Am 30.11.2011 13:10, schrieb Dmitry Samersoff: >> On 2011-11-30 16:05, Steve Poole wrote: >>>> I suggested maintaining the name as src/solaris partly because I don't >>>> believe in churn >>>> and am not sure what would make a better name other than src/unix .. >>>> would that be OK ? >>> +1 for src/unix >> count me too for src/unix >> +1 > > I more would like src/posix + src/winapi Which would be wrong. Its not just posix. More of the code in src/solaris is related to UI stuff like GTK and core X11 APIs than anything else and none of it is defined by posix. Also there's printing etc .. If you are going that route you'd be better to call it src/x11 and have that imply posix .. rather than your misleading suggestion. "unix" has a better implication of more than just posix. src/solaris is 13.4Mb in size. A "du" check of the classes and native subdirs finds that at least 9.7Mb that is GUI related. 4.5Mb in classes and 5.2Mb in native. -phil. > > > Combining Flat vs Hierarchical advantages: > > src/common or 'general' or 'independent' in homage to > platform-independent > src/posix > src/posix.BSD > src/posix.GNU > src/posix.GNU.Linux > src/posix.SYSV > src/posix.SYSV.AIX > src/posix.SYSV.Sun > src/posix.X11 > src/winapi > src/winapi.32 > src/winapi.CE > > Or "correctly": > > src/all > src/all.posix > src/all.posix.BSD > src/all.posix.SYSV.Sun > src/all.winapi > > Alternative: > > src/posix-GNU-Linux > > -Ulf > From jonathan.gibbons at oracle.com Wed Nov 30 17:33:36 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 30 Nov 2011 09:33:36 -0800 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED66500.4020808@oracle.com> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> <1322654721.26124.2.camel@jazzette> <4ED61D3C.1080501@oracle.com> <4ED62C7F.4030005@gmx.de> <4ED66500.4020808@oracle.com> Message-ID: <4ED668F0.4010601@oracle.com> On 11/30/2011 09:16 AM, Phil Race wrote: > > "unix" has a better implication of more than just posix. From http://en.wikipedia.org/wiki/Unix-like The Open Group owns the UNIX trademark and administers the Single UNIX Specification, with the "UNIX" name being used as a certification mark. -- Jon From david.katleman at sun.com Wed Nov 30 22:15:15 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 30 Nov 2011 22:15:15 +0000 Subject: hg: jdk8/build: Added tag jdk8-b14 for changeset 23aa7f2c80a2 Message-ID: <20111130221515.CBD50474CC@hg.openjdk.java.net> Changeset: a4f28069d44a Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/a4f28069d44a Added tag jdk8-b14 for changeset 23aa7f2c80a2 ! .hgtags From david.katleman at sun.com Wed Nov 30 22:15:25 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 30 Nov 2011 22:15:25 +0000 Subject: hg: jdk8/build/corba: 3 new changesets Message-ID: <20111130221527.BD1B7474CD@hg.openjdk.java.net> Changeset: 99925e8d1b86 Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/99925e8d1b86 Added tag jdk8-b14 for changeset e59c47de1ad8 ! .hgtags Changeset: 44c269731425 Author: coffeys Date: 2011-11-11 10:16 +0000 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/44c269731425 7091388: Regular unexplained npe's from corba libs after system has been running for days Reviewed-by: alanb ! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream_1_0.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream_1_0.java Changeset: 7da69e7175a7 Author: lana Date: 2011-11-18 11:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/7da69e7175a7 Merge From david.katleman at sun.com Wed Nov 30 22:16:25 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 30 Nov 2011 22:16:25 +0000 Subject: hg: jdk8/build/hotspot: 43 new changesets Message-ID: <20111130221750.C29A6474CE@hg.openjdk.java.net> Changeset: 883328bfc472 Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/883328bfc472 Added tag jdk8-b14 for changeset 088d09a130ff ! .hgtags Changeset: 869804b759e7 Author: jcoomes Date: 2011-11-04 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/869804b759e7 7108553: Bump the hs23 build number to 06 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5bda8dae4e14 Author: never Date: 2011-10-23 20:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5bda8dae4e14 7103784: enable some flags by default Reviewed-by: kvn ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 754110e02bd5 Author: never Date: 2011-10-23 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/754110e02bd5 7103380: assertion failure with -XX:+PrintNativeNMethods Reviewed-by: kvn, iveresov ! src/share/vm/asm/codeBuffer.cpp Changeset: 42783d1414b2 Author: never Date: 2011-10-23 23:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/42783d1414b2 Merge - make/templates/bsd-header Changeset: b20d64f83668 Author: twisti Date: 2011-10-24 07:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b20d64f83668 7090904: JSR 292: JRuby junit test crashes in PSScavengeRootsClosure::do_oop Reviewed-by: kvn, never, jrose ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp Changeset: 12d38ffcba2a Author: twisti Date: 2011-10-25 00:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/12d38ffcba2a 7094138: JSR 292: JRuby junit test fails in CallSite.setTargetNormal: obj->is_oop() failed: sanity check Reviewed-by: iveresov, never ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/unsafe.cpp Changeset: 2ec638646e86 Author: twisti Date: 2011-10-25 04:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2ec638646e86 7101642: JSR 292: SIGSEGV in java.lang.invoke.MethodHandleImpl$FieldAccessor.getFieldI(Ljava/lang/Object;)I Reviewed-by: kvn, iveresov ! src/share/vm/runtime/sharedRuntime.cpp Changeset: a6eef545f1a2 Author: never Date: 2011-10-25 08:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a6eef545f1a2 7103224: collision between __LEAF define in interfaceSupport.hpp and /usr/include/sys/cdefs.h with gcc Reviewed-by: never Contributed-by: Omair Majid ! src/share/vm/opto/addnode.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/interfaceSupport.hpp Changeset: e69a66a1457b Author: kvn Date: 2011-10-25 12:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e69a66a1457b 7059039: EA: don't change non-escaping state of NULL pointer Summary: NULL pointers do not escape but escape state propagation may change it leading to worser results. Reviewed-by: never ! src/share/vm/opto/escape.cpp Changeset: d8cb48376797 Author: kvn Date: 2011-10-26 06:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d8cb48376797 7097546: Optimize use of CMOVE instructions Summary: Avoid CMove in a loop if possible. May generate CMove if it could be moved outside a loop. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/matcher.hpp Changeset: cec1757a0134 Author: twisti Date: 2011-10-27 04:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cec1757a0134 7102657: JSR 292: C1 deoptimizes unlinked invokedynamic call sites infinitely Reviewed-by: never, bdelsart ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/opto/runtime.cpp Changeset: e0658a9b3f87 Author: kvn Date: 2011-10-27 09:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e0658a9b3f87 7105364: JDK8 b10 hotspot: src/share/vm/ci/ciMethodHandle.cpp Error: Use "." or "->" Summary: Define ciMethodHandle::print_chain_impl() and ciMethodHandle::print_chain() bodies only in debug builds. Reviewed-by: never, twisti ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp Changeset: 34535d2cb362 Author: iveresov Date: 2011-10-27 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/34535d2cb362 7104177: Tiered: -XX:+PrintCanonicalization doesn't work with -XX:+TieredCompilation Summary: Initialize printable_bci of instruction when passed to Canonicalizer Reviewed-by: kvn, never ! src/share/vm/c1/c1_Canonicalizer.hpp Changeset: f350490a45fd Author: kvn Date: 2011-10-27 18:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f350490a45fd 7105611: Set::print() is broken Summary: Reimplemented class VSetI_ to restore Set::print(). Reviewed-by: never ! src/share/vm/libadt/vectset.cpp ! src/share/vm/libadt/vectset.hpp Changeset: eba044a722a4 Author: never Date: 2011-10-28 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/eba044a722a4 7103261: crash with jittester on sparc Reviewed-by: iveresov, kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp + test/compiler/7103261/Test7103261.java Changeset: e3b0dcc327b9 Author: twisti Date: 2011-10-31 03:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e3b0dcc327b9 7104561: UseRDPCForConstantTableBase doesn't work after shorten branches changes Reviewed-by: never, kvn ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/opto/machnode.cpp Changeset: 71699e9d8673 Author: kvn Date: 2011-10-31 15:52 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/71699e9d8673 7106907: 64 bit VM fails test compiler/6865265/StackOverflowBug.java Summary: Use -Xss224k instead of -Xss128k. Reviewed-by: never ! test/compiler/6865265/StackOverflowBug.java Changeset: e342a5110bed Author: twisti Date: 2011-11-03 01:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e342a5110bed 7106774: JSR 292: nightly test inlineMHTarget fails with wrong result Reviewed-by: kvn ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/runtime/deoptimization.cpp Changeset: 448691f285a5 Author: twisti Date: 2011-11-03 04:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/448691f285a5 7106944: assert(_pc == *pc_addr) failed may be too strong Reviewed-by: kvn, never ! src/cpu/x86/vm/frame_x86.cpp Changeset: 1feb272af3a7 Author: never Date: 2011-11-04 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1feb272af3a7 6636110: unaligned stackpointer leads to crash during deoptimization Reviewed-by: never, kvn Contributed-by: Andreas Schoesser ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp Changeset: 59e515ee9354 Author: kvn Date: 2011-11-07 14:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/59e515ee9354 7059047: EA: can't find initializing store with several CheckCastPP Summary: Split adjust_escape_state() method into two methods to find initializing stores. Reviewed-by: never ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 44ce519bc3d1 Author: never Date: 2011-11-08 10:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/44ce519bc3d1 7104960: JSR 292: +VerifyMethodHandles in product JVM can overflow buffer Reviewed-by: kvn, jrose, twisti ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp Changeset: c9a03402fe56 Author: never Date: 2011-11-08 17:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c9a03402fe56 7105305: assert check_method_context proper context Reviewed-by: jrose, kvn ! src/share/vm/code/dependencies.cpp ! src/share/vm/oops/constantPoolKlass.cpp Changeset: e3e363b2bf19 Author: never Date: 2011-11-08 20:42 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e3e363b2bf19 7108242: jinfo -permstat shouldn't report interned strings as part of perm Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java Changeset: 83d0b5cd1438 Author: twisti Date: 2011-11-09 00:42 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/83d0b5cd1438 7087727: JSR 292: C2 crash if ScavengeRootsInCode=2 when "static final" MethodHandle constants are in use Reviewed-by: jrose, kvn, never ! src/share/vm/opto/callGenerator.cpp Changeset: 7e0e43cf86d6 Author: kvn Date: 2011-11-09 06:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7e0e43cf86d6 7109887: java/util/Arrays/CopyMethods.java fails with -XX:+DeoptimizeALot Summary: zero array when compiled code is deoptimized. Reviewed-by: never, twisti ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp Changeset: 670a74b863fc Author: kvn Date: 2011-11-09 07:25 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected Summary: Use dead nodes elimination code in PhaseIdealLoop before executing EA. Reviewed-by: never, twisti ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/runtime/globals.hpp Changeset: 78bef05801ca Author: twisti Date: 2011-11-10 04:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/78bef05801ca Merge - src/share/vm/precompiled.hpp ! src/share/vm/runtime/globals.hpp Changeset: 3c7d67df8d07 Author: dholmes Date: 2011-11-10 06:23 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3c7d67df8d07 7108264: Fix for 7104173 is insufficient Summary: Disable PrintVMOptions by default for all builds Reviewed-by: dsamersoff, twisti ! src/share/vm/runtime/globals.hpp Changeset: f9a80a035a4a Author: coleenp Date: 2011-11-15 12:40 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f9a80a035a4a Merge ! src/share/vm/runtime/globals.hpp Changeset: 5a5ed80bea5b Author: ysr Date: 2011-10-26 21:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5a5ed80bea5b 7105163: CMS: some mentions of MinChunkSize should be IndexSetStart Summary: Fixed the instances that were missed in the changeset for 7099817. Reviewed-by: stefank ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp Changeset: 59519b7d7b9d Author: tonyp Date: 2011-10-28 13:04 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/59519b7d7b9d Merge Changeset: 6fd81579526f Author: brutisso Date: 2011-10-31 08:01 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6fd81579526f 7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise Summary: arrayOopDesc::max_array_length() should return a value that does not overflow a size_t if it is converted to bytes. Reviewed-by: kvn, dholmes ! make/jprt.properties ! src/share/vm/oops/arrayOop.cpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/quickSort.cpp ! test/Makefile Changeset: ed80554efa25 Author: brutisso Date: 2011-11-02 08:04 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ed80554efa25 7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV Summary: _cset_rs_update_cl[] was indexed with values beyond what it is set up to handle. Reviewed-by: ysr, jmasa, johnc ! src/share/vm/gc_implementation/g1/g1RemSet.cpp Changeset: 8aae2050e83e Author: tonyp Date: 2011-11-07 22:11 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8aae2050e83e 7092309: G1: introduce old region set Summary: Keep track of all the old regions in the heap with a heap region set. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.cpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp Changeset: 53074c2c4600 Author: tonyp Date: 2011-11-08 00:41 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/53074c2c4600 7099849: G1: include heap region information in hs_err files Reviewed-by: johnc, brutisso, poonam ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/utilities/vmError.cpp Changeset: ab5107bee78c Author: brutisso Date: 2011-11-09 23:21 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ab5107bee78c 7110190: GCCause::to_string missing case for _adaptive_size_policy Summary: Added case for _adaptive_size_policy Reviewed-by: johnc, ysr ! src/share/vm/gc_interface/gcCause.cpp Changeset: aa4c21b00f7f Author: brutisso Date: 2011-11-15 20:17 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/aa4c21b00f7f 7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow Summary: Reduce what arrayOopDesc::max_array_length() returns to avoid int overflow Reviewed-by: kvn, dholmes, tonyp ! src/share/vm/oops/arrayOop.hpp Changeset: 2ceafe3ceb65 Author: poonam Date: 2011-11-16 16:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2ceafe3ceb65 7110428: Crash during HeapDump operation Reviewed-by: ysr, dholmes ! src/share/vm/services/heapDumper.cpp Changeset: b1754f3fbbd8 Author: tonyp Date: 2011-11-17 13:14 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b1754f3fbbd8 Merge Changeset: 6c2a55d4902f Author: jcoomes Date: 2011-11-18 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6c2a55d4902f Merge Changeset: fde2a39ed7f3 Author: jcoomes Date: 2011-11-18 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fde2a39ed7f3 Added tag hs23-b06 for changeset 6c2a55d4902f ! .hgtags From david.katleman at sun.com Wed Nov 30 22:19:17 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 30 Nov 2011 22:19:17 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b14 for changeset 9d0c9d638757 Message-ID: <20111130221917.E4AC5474CF@hg.openjdk.java.net> Changeset: 804f666d6d44 Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/804f666d6d44 Added tag jdk8-b14 for changeset 9d0c9d638757 ! .hgtags From david.katleman at sun.com Wed Nov 30 22:19:27 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 30 Nov 2011 22:19:27 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b14 for changeset 54c4bf4b83ec Message-ID: <20111130221927.D707A474D0@hg.openjdk.java.net> Changeset: c9ab96ff23d5 Author: katleman Date: 2011-11-17 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/c9ab96ff23d5 Added tag jdk8-b14 for changeset 54c4bf4b83ec ! .hgtags From david.katleman at sun.com Wed Nov 30 22:20:21 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 30 Nov 2011 22:20:21 +0000 Subject: hg: jdk8/build/jdk: 37 new changesets Message-ID: <20111130222640.AE588474D1@hg.openjdk.java.net> Changeset: 00e2c88e2234 Author: katleman Date: 2011-11-17 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/00e2c88e2234 Added tag jdk8-b14 for changeset 99632935785e ! .hgtags Changeset: 2a147f854257 Author: twisti Date: 2011-11-02 02:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2a147f854257 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: jrose, never ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java + test/java/lang/invoke/CallSiteTest.java Changeset: 5c34ed65176e Author: twisti Date: 2011-11-09 00:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5c34ed65176e 7109063: JSR 292: fix for 7085860 is incomplete Reviewed-by: iveresov, alanb, jrose ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! test/ProblemList.txt ! test/java/lang/invoke/CallSiteTest.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java Changeset: bdb2d63c176c Author: jcoomes Date: 2011-11-18 16:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bdb2d63c176c Merge ! test/ProblemList.txt Changeset: 89952dc5be8e Author: prr Date: 2011-11-17 10:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/89952dc5be8e 7113017: Use POSIX compliant include file headers in sun/awt/medialib/mlib_types.h Reviewed-by: prr, bae Contributed-by: littlee at linux.vnet.ibm.com ! src/share/native/sun/awt/medialib/mlib_types.h Changeset: 60331bbcf4ad Author: lana Date: 2011-11-18 16:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/60331bbcf4ad Merge Changeset: f410b91caf45 Author: weijun Date: 2011-11-09 09:30 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f410b91caf45 7107019: sun.security.krb5.internal.ccache.CCacheInputStream.readCred does not use auth data Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ccache/CCacheInputStream.java ! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java Changeset: 52be75d060f9 Author: weijun Date: 2011-11-09 15:51 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/52be75d060f9 7109096: keytool -genkeypair needn't call -selfcert Reviewed-by: xuelei ! src/share/classes/sun/security/tools/CertAndKeyGen.java ! src/share/classes/sun/security/tools/KeyTool.java Changeset: d6a5da5f6ba0 Author: dl Date: 2011-11-10 12:21 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d6a5da5f6ba0 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative Reviewed-by: chegar, mduigou, dholmes ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java Changeset: 0ccfb35cce26 Author: michaelm Date: 2011-11-10 15:30 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0ccfb35cce26 7110484: HttpServer.stop() not closing selector Reviewed-by: chegar ! src/share/classes/sun/net/httpserver/ServerImpl.java Changeset: e5d65a583c15 Author: michaelm Date: 2011-11-10 15:41 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e5d65a583c15 Merge Changeset: 830d2e46023a Author: lancea Date: 2011-11-10 11:41 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/830d2e46023a 7110111: Minor Java SE javadoc & Constructor clean up Reviewed-by: alanb, darcy Contributed-by: Martin Desruisseaux ! src/share/classes/java/io/Writer.java ! src/share/classes/java/lang/AssertionError.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/util/jar/Attributes.java Changeset: 9dd994f319ee Author: coffeys Date: 2011-11-11 10:08 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9dd994f319ee 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile Reviewed-by: alanb ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java ! src/solaris/classes/java/io/FileDescriptor.java ! src/windows/classes/java/io/FileDescriptor.java - test/java/io/FileDescriptor/FileChannelFDTest.java + test/java/io/FileDescriptor/Sharing.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 5c7c83a6ee24 Author: xuelei Date: 2011-11-14 01:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5c7c83a6ee24 7111548: unexpected debug log message Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 68fc55d12ae6 Author: chegar Date: 2011-11-14 10:06 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/68fc55d12ae6 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/windows/classes/java/net/PlainSocketImpl.java Changeset: c740519fe83a Author: weijun Date: 2011-11-16 11:53 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c740519fe83a 7111579: klist starttime, renewtill, ticket etype Reviewed-by: mullan ! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java Changeset: cd6d236e863b Author: okutsu Date: 2011-11-16 12:57 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cd6d236e863b 7111903: (tz) Windows-only: tzmappings needs update for KB2570791 Reviewed-by: peytoia ! src/windows/lib/tzmappings Changeset: 1266e72f7896 Author: okutsu Date: 2011-11-16 13:17 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1266e72f7896 Merge Changeset: 398442b00b2b Author: ksrini Date: 2011-11-16 12:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/398442b00b2b 7112160: jdk8 javadoc failure in jdk/make/docs javadoc: error - java.lang.OutOfMemoryError Reviewed-by: ohair, katleman ! make/docs/Makefile Changeset: 3cd7dcf4a302 Author: mchung Date: 2011-11-17 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3cd7dcf4a302 7067691: java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently Reviewed-by: alanb, mchung Contributed-by: gary.adams at oracle.com ! test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java ! test/java/lang/management/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java Changeset: 5bfff9616b86 Author: weijun Date: 2011-11-18 16:13 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5bfff9616b86 7077172: KerberosTime does not take into account system clock adjustement Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/KerberosTime.java Changeset: cd37d8066437 Author: lana Date: 2011-11-18 11:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cd37d8066437 Merge ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: c98235762b30 Author: alanb Date: 2011-11-19 19:55 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c98235762b30 6818464: TEST_BUG: java/util/Timer/KillThread.java failing intermittently Reviewed-by: dholmes, alanb, forax Contributed-by: gary.adams at oracle.com ! test/java/util/Timer/KillThread.java Changeset: 8be37eae9598 Author: alanb Date: 2011-11-19 19:59 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8be37eae9598 6731620: TEST_BUG: java/util/Timer/Args.java is too optimistic about the execution time of System.out.printf Reviewed-by: dholmes, forax Contributed-by: gary.adams at oracle.com ! test/java/util/Timer/Args.java Changeset: 450c17e4808d Author: alanb Date: 2011-11-19 20:03 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/450c17e4808d 6860309: TEST_BUG: Insufficient sleep time in java/lang/Runtime/exec/StreamsSurviveDestroy.java Reviewed-by: alanb, dholmes, forax Contributed-by: gary.adams at oracle.com ! test/java/lang/Runtime/exec/StreamsSurviveDestroy.java Changeset: 184578f3e8b9 Author: alanb Date: 2011-11-21 12:51 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/184578f3e8b9 7084033: TEST_BUG: test/java/lang/ThreadGroup/Stop.java fails intermittently Reviewed-by: forax, chegar, dholmes Contributed-by: gary.adams at oracle.com ! test/java/lang/ThreadGroup/Stop.java Changeset: 2db942c7eb9c Author: alanb Date: 2011-11-21 12:57 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2db942c7eb9c 7114125: TEST_BUG: java/util/Timer/KillThread.java should use volatile cross thread variable declaration Reviewed-by: dholmes, alanb Contributed-by: gary.adams at oracle.com ! test/java/util/Timer/KillThread.java Changeset: 81987765cb81 Author: ngmr Date: 2011-11-11 14:40 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/81987765cb81 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo Reviewed-by: chegar, alanb, mduigou, ngmr Contributed-by: Charles Lee ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h Changeset: ee2fa62fb09f Author: ngmr Date: 2011-11-22 09:51 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ee2fa62fb09f 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN) Reviewed-by: chegar Contributed-by: Neil Richards ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: 1945abeb82a0 Author: mullan Date: 2011-11-22 08:58 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1945abeb82a0 7093090: Reduce synchronization in java.security.Policy.getPolicyNoCheck Reviewed-by: valeriep ! src/share/classes/java/security/Policy.java Changeset: bb8f19b80557 Author: mullan Date: 2011-11-22 09:00 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bb8f19b80557 Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: b4d7020c2a40 Author: mullan Date: 2011-11-22 09:17 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b4d7020c2a40 Merge Changeset: 82151e860a64 Author: xuelei Date: 2011-11-23 03:40 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/82151e860a64 7113275: compatibility issue with MD2 trust anchor and old X509TrustManager Summary: also reviewed by Dennis.Gu at oracle.com Reviewed-by: mullan ! src/share/classes/sun/security/ssl/SSLContextImpl.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/MD2InTrustAnchor.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/TrustTrustedCert.java Changeset: 7eb0debca9b3 Author: chegar Date: 2011-11-23 12:30 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7eb0debca9b3 6776144: java/lang/ThreadGroup/NullThreadName.java fails with Thread group is not destroyed ,fastdebug LINUX Reviewed-by: chegar, dholmes Contributed-by: gary.adams at oracle.com ! test/java/lang/ThreadGroup/NullThreadName.java Changeset: d27f0b2f1476 Author: coffeys Date: 2011-11-23 14:55 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d27f0b2f1476 7102369: remove java.rmi.server.codebase property parsing from registyimpl 7094468: rmiregistry clean up Reviewed-by: smarks ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/server/LoaderHandler.java + test/java/rmi/registry/readTest/readTest.java + test/java/rmi/registry/readTest/readTest.sh + test/java/rmi/registry/readTest/testPkg/Client.java + test/java/rmi/registry/readTest/testPkg/Hello.java + test/java/rmi/registry/readTest/testPkg/Server.java Changeset: 855675a4235b Author: lana Date: 2011-11-23 11:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/855675a4235b Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 3c248d0e2c48 Author: lana Date: 2011-11-28 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3c248d0e2c48 Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java From david.katleman at sun.com Wed Nov 30 22:28:35 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 30 Nov 2011 22:28:35 +0000 Subject: hg: jdk8/build/langtools: 7 new changesets Message-ID: <20111130222851.9D2DA474D2@hg.openjdk.java.net> Changeset: 16906df5bffc Author: katleman Date: 2011-11-17 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/16906df5bffc Added tag jdk8-b14 for changeset 58f1325d72b2 ! .hgtags Changeset: 36553cb94345 Author: jjg Date: 2011-11-08 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/36553cb94345 7108668: allow Log to be initialized and used earlier Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! src/share/classes/com/sun/tools/javadoc/Start.java Changeset: ae361e7f435a Author: jjg Date: 2011-11-08 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ae361e7f435a 7108669: cleanup Log methods for direct printing to streams Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/JavacOption.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/6410653/T6410653.java ! test/tools/javac/diags/ArgTypeCompilerFactory.java Changeset: c1238fcc9515 Author: ksrini Date: 2011-11-14 08:09 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/c1238fcc9515 7110974: (javac) add coding conventions and style checkers for langtools Reviewed-by: jjg ! make/build.properties ! make/build.xml + make/conf/checkstyle-emacs.xsl + make/conf/checkstyle-langtools.xml Changeset: 7375d4979bd3 Author: ksrini Date: 2011-11-14 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7375d4979bd3 7106166: (javac) re-factor EndPos parser Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java - src/share/classes/com/sun/tools/javac/parser/EndPosParser.java + src/share/classes/com/sun/tools/javac/parser/EndPosTable.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/6304921/TestLog.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/tree/TreePosTest.java Changeset: f07d6f55d39a Author: lana Date: 2011-11-18 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f07d6f55d39a Merge Changeset: 07599bd780ca Author: jjh Date: 2011-11-19 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/07599bd780ca 7110611: compiler message file broken for javac -fullversion Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/Main.java From david.holmes at oracle.com Wed Nov 30 22:32:31 2011 From: david.holmes at oracle.com (David Holmes) Date: Thu, 01 Dec 2011 08:32:31 +1000 Subject: jdk/src/solaris - time to re-visit it? In-Reply-To: <4ED62C7F.4030005@gmx.de> References: <4ED3ACEF.4000403@gmx.de> <4ED3B4D2.2070403@oracle.com> <1322584583.12065.6.camel@jazzette> <4ED533AE.10609@oracle.com> <4ED5560E.6070004@oracle.com> <4ED5660A.3010200@oracle.com> <1322654721.26124.2.camel@jazzette> <4ED61D3C.1080501@oracle.com> <4ED62C7F.4030005@gmx.de> Message-ID: <4ED6AEFF.6010003@oracle.com> On 30/11/2011 11:15 PM, Ulf Zibis wrote: > I more would like src/posix + src/winapi > > > Combining Flat vs Hierarchical advantages: > > src/common or 'general' or 'independent' in homage to platform-independent > src/posix > src/posix.BSD > src/posix.GNU > src/posix.GNU.Linux > src/posix.SYSV > src/posix.SYSV.AIX > src/posix.SYSV.Sun > src/posix.X11 > src/winapi > src/winapi.32 > src/winapi.CE But the BSD, GNU, SYSV api's are not POSIX - that's the whole point David ----- > Or "correctly": > > src/all > src/all.posix > src/all.posix.BSD > src/all.posix.SYSV.Sun > src/all.winapi > > Alternative: > > src/posix-GNU-Linux > > -Ulf > From alexey.menkov at oracle.com Thu Nov 10 10:25:49 2011 From: alexey.menkov at oracle.com (Alex Menkov) Date: Thu, 10 Nov 2011 10:25:49 -0000 Subject: Review request (XS): 7110396: Sound code fails to build on multiarch Linux systems In-Reply-To: <20111110052456.AEC78111B@eggemoggin.niobe.net> References: <20111110052456.AEC78111B@eggemoggin.niobe.net> Message-ID: <4EBBA69F.60003@oracle.com> Looks good regards Alex On 10.11.2011 09:24, mark.reinhold at oracle.com wrote: > Some Linux distros have started to adopt a "multiarch" filesystem layout for > shared libraries in order to support the installation of packages for multiple > hardware architectures on a single system. For more information see, e.g., > http://wiki.debian.org/Multiarch. > > In Ubuntu 11.10 the ALSA shared library, libasound2, was converted to the > multiarch format and so its files moved from their old location, /usr/lib, > to /usr/lib/${ARCH_TRIPLET}. This caused the JDK build to fail when linking > the Java sound library. The root cause appears to be that gcc only tries to > resolve undefined symbols against a multiarch library if the library is named > on the command line after the object files containing those symbols. > > The fix is simply to move -lasound to the end of the gcc invocation. > > I'll push this into JDK 8. It would trivially backport to 7. > > Patch: > > --- a/make/javax/sound/jsoundalsa/Makefile > +++ b/make/javax/sound/jsoundalsa/Makefile > @@ -65,7 +65,7 @@ > $(MIDIFILES_export) \ > $(PORTFILES_export) > > -LDFLAGS += -lasound > +EXTRA_LIBS += -lasound > > CPPFLAGS += \ > -DUSE_DAUDIO=TRUE \ > > Thanks, > - Mark From charlie.hunt at oracle.com Sat Nov 12 16:34:23 2011 From: charlie.hunt at oracle.com (charlie hunt) Date: Sat, 12 Nov 2011 16:34:23 -0000 Subject: Profiling the hotspot, In-Reply-To: <4EBE23C0.1070607@oracle.com> References: <4EBDE6CC.2060105@oracle.com> <4EBE23C0.1070607@oracle.com> Message-ID: <4EBE9F84.9000607@oracle.com> Hi Nhan, This is a bit long winded ... hopefully you'll find it useful though. If you are wanting to only view HotSpot method names in the profile and not also view HotSpot source code embedded in the profile and/or not profile with hardware/CPU counters, then you do not need to build anything special to see HotSpot method names with Oracle Solaris Studio Performance Analyzer, (aka collector analyzer). Btw, don't let "Solaris" embedded in the product name deter you. Although the official product name is "Oracle Solaris Studio", it is also available on Linux. Because the product was originally built for Solaris (both x86 and SPARC), its more mature on Solaris than Linux, (the Linux port was done a couple years ago -- fwiw, I almost always profile on Solaris since it is more mature and I can get hardware counter info "out of the box"). The Linux version requires a (fairly) recent kernel, i.e. Red Hat EL 5, SuSE ES 11 or Oracle Enterprise Linux 5 or more recent versions. Other variants of Linux may work, i.e. Ubuntu (I've run it on recent Ubuntu releases). If you want to see hardware/CPU counters info in the profile, then see the section below "Hardware/CPU Counter Profiling" If you want to see HotSpot source code embedded in the profile, then see the section below "Embedded HotSpot Source Code". To limit the amount data collected in the profile, you can use collect's -y option to toggle on and toggle off profile gathering. To help find what you are looking for in tracing GC thread(s) activity, once you look at the profile in Analyzer, I'd suggest to start by looking at the Timeline tab where you see a row for every thread in the JVM and Java application. Although each row doesn't list the thread name, (an enhancement I've asked for), you can click in a given thread row and look at the Call Stack panel to get a sense of which thread it is. The Timeline will also show when the thread was busy. You could use the Timeline and Call Stack panel to figure out what phase CMS is in. From there you can filter the profile data based on the time line info and for those CMS threads. That'll allow you to look specifically at the CMS threads and when they are running. There's an intro to how to use Performance Analyzer in the Java Performance book, but (unfortunately) it does not explicitly show your use case. It does, however, offer an intro of the basic concepts. There's also some really good documentation available at the Oracle Solaris Studio product web site: http://www.oracle.com/technetwork/server-storage/solarisstudio/overview/index-jsp-138069.html There is also some tutorials in the product distribution that can help get you familiar with the tool. Download page is: http://www.oracle.com/technetwork/server-storage/solarisstudio/downloads/index.html Hardware/CPU Counter Profiling If you want to see hardware/CPU counters info in the profile, then, on Linux, you have to patch the kernel. Fwiw, patching the kernel is not needed for Solaris (x86 or SPARC). If you want to see what hardware counters are available, a simple 'collect' command with no args will printout hardware counters that can be profiled. There's also a section in the Java Performance book that describes how to profile with hardware/CPU counters. Embedded HotSpot Source Code If you want to see the HotSpot source code embedded in the profile, then you need to do a custom build of HotSpot. There's a couple ways you can accomplish what you need and what I list here is not necessary the best way, or the only way. Hopefully the instructions below are not out of date. These worked for me about 6 months ago. I'm sure there's others who can offer an easier approach or offer corrections, (I'm not a HotSpot build expert). This is what I've done on Linux: 1. After getting a copy of the HotSpot source code from the source code repository 2. Edit the /make/linux/makefiles/amd64.make file. 3. Append -g0 to the line, OPT_CFLAGS/compactingPermGenGen.o = -O1 i.e. OPT_CFLAGS/compactingPermGenGen.o = -O1 -g0 4. Edit the /make/linux/makefiles/gcc.make file. 5. Append -g0 to the line, OPT_CFLAGS += -O3 i.e. OPT_CFLAGS += -O3 -g0 6. Append -gdwarf-2 to the line, OPT_CFLAGS += -fno-strict-aliasing i.e. OPT_CFLAGS += -fno-strict-aliasing -gdwarf-2 7. Append -g0 to the line, OPT_CFLAGS/NOOPT=-O0 i.e. OPT_CFLAGS/NOOPT=-O0 -g0 8. Append -g0 to the line, OPT_CFLAGS/mulnode.o += -O0 i.e. OPT_CFLAGS/mulnode.o += -O0 -g0 9. Change this line, DEBUG_CFLAGS += -gstabs, to DEBUG_CFLAGS += -gdwarf-2 10. Edit the /make/linux/makefiles/product.make file. 11. Comment out these two lines: STRIP_LIBJVM = $(STRIP) -g $@ || exit 1; STRIP_AOUT = $(STRIP) -x $@ || exit 1; i.e. #STRIP_LIBJVM = $(STRIP) -g $@ || exit 1; #STRIP_AOUT = $(STRIP) -x $@ || exit 1; 12. Now build HotSpot using the "product" target and build for either 64-bit or 32-bit, i.e. to build 64-bit libjvm.so do, $ gmake LP64=1 product hths, charlie ... On 11/12/11 01:44 AM, Jon Masamitsu wrote: > Take a look at Charlie's blog about the collector analyzer tools > > http://blogs.oracle.com/charliebrown/entry/free_sun_studio_12_and > > And the quick start guide > > http://dsc.sun.com/solaris/articles/analyzer_qs.html > > The profiling build target in hotspot was deleted because they > were not being used and I believe were not building correctly. > > > On 11/11/2011 7:23 PM, David Holmes wrote: >> As this mainly concerns GC profiling I've cc'ed the GC list. >> >> David >> >> On 12/11/2011 2:22 AM, Dang Nhan Nguyen wrote: >>> Hi, >>> >>> I need to measure some performance (mostly running time) of GC (CMS) >>> while running on multi-core platform on Linux. I want to break down >>> the cost of each phase in CMS and some related method. And I am >>> thinking of performance profiling tool to do that. >>> >>> I have look at the build files and see that there used to be some >>> "profiled" target for profiling hotspot. However, it was removed now >>> (don't know why). >>> >>> Now, I am looking for a way to do the profiling. As my experience >>> with profiling the hotspot on Windows (using Visual Studio), the >>> generated of profiling data is huge (2-6GB) and in many cases, my >>> computer could not handle the analysis of profiling data. In >>> addition, hotspot's code and its build are quite complex, I want to >>> consult some opinions first before actually do it. >>> >>> I am grateful if you can suggest a way to build the hotspot on Linux >>> for profiling purpose. >>> >>> Thank you, >>> Nhan Nguyen >>> >>> -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 5166 bytes Desc: S/MIME Cryptographic Signature URL: From bruno at javaman.com.br Tue Nov 29 15:50:58 2011 From: bruno at javaman.com.br (Bruno F. Souza) Date: Tue, 29 Nov 2011 13:50:58 -0200 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <7DFAAF38-9D38-4440-A4BF-1E1D1761BC13@javaman.com.br> Yes, I agree with Ben, it is just too short notice for us to do anything more then promote it. We will promote it anyway, no worries about it, but it would be nice to use this opportunity to help people get involved. We'll look forward for a next opportunity! Thanks! Bruno. On 29/11/2011, at 09:47, Ben Evans wrote: > Hi Xiomara, > > This looks like a great project, and is definitely the sort of > participation that the user group community can help with. > > However, we need more lead time to effectively participate. In our > experience the best way for the community to help with something like > this is to have a physical meet. That way the relatively small number > of people in our communities who can build OpenJDK are able to help > the others bootstrap ("teach them to fish"), and thereby increase > overall participation. > > As this is an out-of-work activity for the vast majority of our > members, we need time to plan and promote our events - especially if > this is to be done as an after-work activity. > > We probably won't be able to manage to put an event together for this > week - but on the assumption that there'll still be plenty of warnings > to squish - can we plan for a later date when we can help? > > From the community side, some of the right people to reach out to are > myself and Martijn Verburg from LJC (London), and Bruno Souza and Yara > Senger from SouJava (Brazil) - we can then ensure the message gets out > to the rest of the global JUG community. > > Shame that it's probably too close for us to do much this time - but > let us know how it goes, and we'd definitely love to do something if > we had more notice. > > Thanks, > > Ben > > On Tue, Nov 29, 2011 at 2:10 AM, Xiomara Jayasena > wrote: >> A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. We would like to invite you to participate. >> >> >> >> To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. If you decide to participate then please reply to this e-mail with the area that you intend to work on. I will keep track of the areas so that there is no overlap of work. >> >> >> >> . A group of us working on this project will create bugs for the areas that developers sign up for. >> >> . The focus will be on java warnings, since these are less risky. >> >> . For this exercise please avoid making any API changes or any large scale refactorings. >> >> . Avoid @SuppressWarnings except where it is clearly necessary. >> >> . We would like to have the code changes completed by 5pm (PST) on Dec. 1st. >> >> . A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. The java files are in java.io, java.lang, java.util and a variety of related packages. >> >> >> >> Process to follow: >> >> >> >> 1. Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. >> >> 2. A bug ID will be generated for this. >> >> 3. Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk >> >> 4. Post your changes for review. If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. If the patch is too cumbersome to review, we can generate a webrev for you. >> >> 5. All of the changes must go through the usual build, test and review process before being pushed. If you are a JDK8 committer you may push after completing the usual process. If you aren't a committer we will help you review and test your changes. >> >> 6. In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! >> >> >> >> Lastly to get a build with warnings enable use the following flags: >> >> make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" >> >> >> >> Tip: Make sure to redirect output to a file. To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." >> >> >> >> -Xiomara >> Bruno. ______________________________________________________________________ Bruno Peres Ferreira de Souza Brazil's JavaMan http://www.javaman.com.br bruno at javaman.com.br if I fail, if I succeed, at least I live as I believe From fancyerii at gmail.com Fri Nov 11 11:39:16 2011 From: fancyerii at gmail.com (Li Li) Date: Fri, 11 Nov 2011 11:39:16 -0000 Subject: build open jdk 6 error Message-ID: hi all I tried to build a debug version of openjdk6. I follows these articles: http://weblogs.java.net/blog/simonis/archive/2008/01/hotspot_develop.html http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html I've got the latest codes and an error occured: 2045 /usr/bin/gcc -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -fno-omit-fra me-pointer -D_LITTLE_ENDIAN -DARCH='"i586"' -Di586 -DLINUX -DRELEASE='"1.6.0-internal"' -D_LARGEFI LE64_SOURCE -D_GNU_SOURCE -D_REENTRANT -I. -I/media/d/openjdk6/build/linux-i586/tmp/sun/sun.security .pkcs11/j2pkcs11/CClassHeaders -I../../../../src/solaris/javavm/export -I../../../../src/share/javav m/export -I../../../../src/share/javavm/include -I../../../../src/solaris/javavm/include -I../../../ ../src/share/native/sun/security/pkcs11/wrapper -I../../../../src/solaris/native/sun/security/pkcs11 /wrapper -I../../../../src/share/native/common -I../../../../src/solaris/native/common -I../../../.. /src/share/native/sun/security/pkcs11 -I../../../../src/solaris/native/sun/security/pkcs11 -c -o /media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/obj/p11_convert.o ../../../ ../src/share/native/sun/security/pkcs11/wrapper/p11_convert.c 2046 ../../../../src/share/native/sun/security/pkcs11/j2secmod.c:76:27: error: conflicting types for 'Jav a_sun_security_pkcs11_Secmod_nssGetModuleList' 2047 /media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/CClassHeaders/sun_security_p kcs11_Secmod.h:49:27: note: previous declaration of 'Java_sun_security_pkcs11_Secmod_nssGetModuleLis t' was here 2048 make[6]: *** [/media/d/openjdk6/build/linux-i586/tmp/sun/sun.security.pkcs11/j2pkcs11/obj/j2secmod.o ] Error 1 I searched a bug in sun's bug database: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7058133 in my make/sun/security/pkcs11/Makefile There is not any JAVAHFLAGS += -classpath $(CLASSDESTDIR) So I tried to add this line. But it still failed. The result of make sanity: make[1]: Entering directory `/media/d/openjdk6/jdk/make' make[2]: Entering directory `/media/d/openjdk6/jdk/make/tools/freetypecheck' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/media/d/openjdk6/jdk/make/tools/freetypecheck' make[1]: Leaving directory `/media/d/openjdk6/jdk/make' Build Machine Information: build machine = lili-desktop Build Directory Structure: CWD = /media/d/openjdk6 TOPDIR = . LANGTOOLS_TOPDIR = ./langtools JAXP_TOPDIR = ./jaxp JAXWS_TOPDIR = ./jaxws CORBA_TOPDIR = ./corba HOTSPOT_TOPDIR = ./hotspot JDK_TOPDIR = ./jdk Build Directives: BUILD_LANGTOOLS = true BUILD_JAXP = true BUILD_JAXWS = true BUILD_CORBA = true BUILD_HOTSPOT = true BUILD_JDK = true DEBUG_CLASSFILES = DEBUG_BINARIES = Hotspot Settings: HOTSPOT_BUILD_JOBS = HOTSPOT_OUTPUTDIR = /media/d/openjdk6/build/linux-i586/hotspot/outputdir HOTSPOT_EXPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import Bootstrap Settings: BOOTDIR = /home/lili/java/jdk1.6.0_26/ ALT_BOOTDIR = /home/lili/java/jdk1.6.0_26/ BOOT_VER = 1.6 [requires at least 1.6] OUTPUTDIR = /media/d/openjdk6/build/linux-i586 ALT_OUTPUTDIR = /media/d/openjdk6/build/linux-i586 ABS_OUTPUTDIR = /media/d/openjdk6/build/linux-i586 Build Tool Settings: SLASH_JAVA = /NOT-SET ALT_SLASH_JAVA = VARIANT = OPT JDK_DEVTOOLS_DIR = /NOT-SET/devtools ALT_JDK_DEVTOOLS_DIR = ANT_HOME = UNIXCOMMAND_PATH = /bin/ ALT_UNIXCOMMAND_PATH = COMPILER_PATH = /usr/bin/ ALT_COMPILER_PATH = DEVTOOLS_PATH = /usr/bin/ ALT_DEVTOOLS_PATH = UNIXCCS_PATH = /usr/ccs/bin/ ALT_UNIXCCS_PATH = USRBIN_PATH = /usr/bin/ ALT_USRBIN_PATH = MOTIF_DIR = /usr ALT_MOTIF_DIR = MOTIF_REQUIRED = false COMPILER_NAME = GCC COMPILER_VERSION = CC_VER = 4.5 [requires at least 3.2] ZIP_VER = 3.0 [requires at least 2.2] UNZIP_VER = 6.00 [requires at least 5.12] ANT_VER = 1.8 [requires at least 1.6.3] TEMPDIR = /media/d/openjdk6/build/linux-i586/tmp Build Directives: OPENJDK = true USE_HOTSPOT_INTERPRETER_MODE = PEDANTIC = DEV_ONLY = NO_DOCS = NO_IMAGES = TOOLS_ONLY = INSANE = COMPILE_APPROACH = parallel PARALLEL_COMPILE_JOBS = 2 ALT_PARALLEL_COMPILE_JOBS = FASTDEBUG = COMPILER_WARNINGS_FATAL = false COMPILER_WARNING_LEVEL = INCREMENTAL_BUILD = false CC_HIGHEST_OPT = -O3 CC_HIGHER_OPT = -O3 CC_LOWER_OPT = -O2 CXXFLAGS = -O2 -fPIC -DCC_NOEX -W -Wall -Wno-unused -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN CFLAGS = -O2 -fno-strict-aliasing -fPIC -W -Wall -Wno-unused -Wno-parentheses -fno-omit-frame-pointer -D_LITTLE_ENDIAN BOOT_JAVA_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m BOOT_JAVAC_CMD = /home/lili/java/jdk1.6.0_26//bin/javac -J-XX:ThreadStackSize=768 -J-client -J-Xmx896m -J-Xms128m -J-XX:PermSize=32m -J-XX:MaxPermSize=160m -encoding ascii -source 5 -target 5 -XDignore.symbol.file=true BOOT_JAR_CMD = /home/lili/java/jdk1.6.0_26//bin/jar BOOT_JARSIGNER_CMD = /home/lili/java/jdk1.6.0_26//bin/jarsigner JAVAC_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -jar /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -source 1.5 -target 5 -encoding ascii -Xbootclasspath:/media/d/openjdk6/build/linux-i586/classes JAVAH_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javah.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar -jar /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javah.jar -bootclasspath /media/d/openjdk6/build/linux-i586/classes JAVADOC_CMD = /home/lili/java/jdk1.6.0_26//bin/java -client -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javac.jar:/media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/doclets.jar -jar /media/d/openjdk6/build/linux-i586/langtools/dist/bootstrap/lib/javadoc.jar Build Platform Settings: USER = lili PLATFORM = linux ARCH = i586 LIBARCH = i386 ARCH_FAMILY = i586 ARCH_DATA_MODEL = 32 ARCHPROP = i386 LINUX_VERSION = Unknown linux ALSA_VERSION = 1.0.24.1 OS_VERSION = 2.6.38-12-generic [requires at least 2.4.9-e.3] OS_NAME = linux MB_OF_MEMORY = 3527 GNU Make Settings: MAKE = make MAKE_VER = 3.81 [requires at least 3.78] MAKECMDGOALS = sanity MAKEFLAGS = w SHELL = /bin/sh Target Build Versions: JDK_VERSION = 1.6.0 MILESTONE = internal RELEASE = 1.6.0-internal FULL_VERSION = 1.6.0-internal-lili_11_nov_2011_19_32-b00 BUILD_NUMBER = b00 External File/Binary Locations: USRJDKINSTANCES_PATH = /opt/java BUILD_JDK_IMPORT_PATH = /NOT-SET/re/openjdk/6/promoted/latest/binaries ALT_BUILD_JDK_IMPORT_PATH = JDK_IMPORT_PATH = /NOT-SET/re/openjdk/6/promoted/latest/binaries/linux-i586 ALT_JDK_IMPORT_PATH = LANGTOOLS_DIST = /media/d/openjdk6/build/linux-i586/langtools/dist ALT_LANGTOOLS_DIST = /media/d/openjdk6/build/linux-i586/langtools/dist CORBA_DIST = /media/d/openjdk6/build/linux-i586/corba/dist ALT_CORBA_DIST = /media/d/openjdk6/build/linux-i586/corba/dist JAXP_DIST = /media/d/openjdk6/build/linux-i586/jaxp/dist ALT_JAXP_DIST = /media/d/openjdk6/build/linux-i586/jaxp/dist JAXWS_DIST = /media/d/openjdk6/build/linux-i586/jaxws/dist ALT_JAXWS_DIST = /media/d/openjdk6/build/linux-i586/jaxws/dist HOTSPOT_DOCS_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import/docs ALT_HOTSPOT_DOCS_IMPORT_PATH = HOTSPOT_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import ALT_HOTSPOT_IMPORT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import HOTSPOT_CLIENT_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import/jre/lib/i386/client ALT_HOTSPOT_CLIENT_PATH = HOTSPOT_SERVER_PATH = /media/d/openjdk6/build/linux-i586/hotspot/import/jre/lib/i386/server ALT_HOTSPOT_SERVER_PATH = CACERTS_FILE = ./../src/share/lib/security/cacerts ALT_CACERTS_FILE = CUPS_HEADERS_PATH = /usr/include ALT_CUPS_HEADERS_PATH = OpenJDK-specific settings: FREETYPE_HEADERS_PATH = /usr/include ALT_FREETYPE_HEADERS_PATH = FREETYPE_LIB_PATH = /usr/lib ALT_FREETYPE_LIB_PATH = PLUG_LIBRARY_NAMES = Previous JDK Settings: PREVIOUS_RELEASE_PATH = /NOT-SET/re/jdk/1.6.0/archive/fcs/bundles/linux-i586 ALT_PREVIOUS_RELEASE_PATH = PREVIOUS_JDK_VERSION = 1.6.0 ALT_PREVIOUS_JDK_VERSION = PREVIOUS_JDK_FILE = jdk-6-linux-i586.tar.gz ALT_PREVIOUS_JDK_FILE = PREVIOUS_JRE_FILE = jre-6-linux-i586.tar.gz ALT_PREVIOUS_JRE_FILE = PREVIOUS_RELEASE_IMAGE = ALT_PREVIOUS_RELEASE_IMAGE = Sanity check passed. -------------- next part -------------- An HTML attachment was scrubbed... URL: