From peter.brunet at oracle.com Wed Feb 1 05:08:36 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Tue, 31 Jan 2012 23:08:36 -0600 Subject: ...\jdk\make\docs\Makefile needs a fix Message-ID: <4F28C8D4.6040708@oracle.com> Back in November there was a change to ...\jdk\make\docs\Makefile to fix an out of memory problem by raising the memory size for a 32 bit build (line 74) from 512 to 612. That didn't work on my machine: 64 bit Windows 7 with 8 mb. I raised it up to 1024 to bypass the problem. I don't know if that's too much but it worked. Pete From erik.joelsson at oracle.com Wed Feb 1 09:13:30 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 01 Feb 2012 10:13:30 +0100 Subject: Review for 7141242: build-infra merge: Rename CPP->CXX and LINK->LD Message-ID: <4F29023A.9010905@oracle.com> http://cr.openjdk.java.net/~erikj/7141242/webrev.00/ 240 lines changed: 0 ins; 19 del; 221 mod; 6363 unchg 7141242: build-infra merge: Rename CPP->CXX and LINK->LD The build-infra project is starting to move into jdk8. For the hotspot build to stay compatible with the changes, the naming of standard make variables, like CC and LD need to be standardized across the build. Currently hotspot names the C++ compiler CPP, which is traditionally the name of the preprocessor. The windows nmake files name the linker LINK. We would like to rename the C++ compiler to CXX and have the linker named LD everywhere. Patch is tested with hsx/hotspot-rt. Testing with jdk7u is in progress. /Erik From paul.hohensee at oracle.com Wed Feb 1 12:12:40 2012 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Wed, 01 Feb 2012 07:12:40 -0500 Subject: Patch to fix build breakage with GCC 4.7 In-Reply-To: <20120131152335.GA7700@redhat.com> References: <20120130152052.GE3179@redhat.com> <4F273C6E.30801@oracle.com> <20120131023642.GO16474@redhat.com> <4F2756C9.4000304@oracle.com> <20120131152335.GA7700@redhat.com> Message-ID: <4F292C38.5010901@oracle.com> linux-sparc used to build and run fine (I did the port way back when), so it should be relatively easy to resurrect. The original port was on a T1. Paul On 1/31/12 10:23 AM, Deepak Bhole wrote: > * David Holmes [2012-01-30 21:50]: >> On 31/01/2012 12:36 PM, Deepak Bhole wrote: >>> * David Holmes [2012-01-30 19:57]: >>>> While gcc compilation on sparc is rare I'm not sure that simply >>>> deleting the sparc-only option unconditionally is the right thing to >>>> do. >>>> >>> I thought about that too. But I was unable to find info on OpenJDK + >>> SPARC + Linux. Is that combination even supported? The README doesn't >>> list it: >>> http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE >> Linux-sparc is not one of Oracle's supported OpenJDK platforms. >> However AFAIK there are people in the community building OpenJDK on >> Linux-sparc using the Zero interpreter. I don't know if this would >> affect them but it still seems to me that we should be careful not >> to break other people's builds. >> > Ah fair enough. If it is supported, the patch definitely needs to be > fixed. I will re-post. > > Thanks for taking a look! > > Deepak > >> David >> ----- >> >>> The option seemed more like a relic from Solaris + SPARC config rather >>> than a requirement for Linux + SPARC. >> >> >>> Cheers, >>> Deepak >>> >>>> David >>>> >>>> On 31/01/2012 1:20 AM, Deepak Bhole wrote: >>>>> Hi, >>>>> >>>>> JDK builds currently fail with GCC 4.7 due to its stricter option >>>>> checking. >>>>> >>>>> GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain >>>>> files in JDK supply the -mimpure-text option to GCC. This option is only >>>>> valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build >>>>> on Linux (I suppose . >>>>> >>>>> This patch removes the option: >>>>> http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 >>>>> >>>>> 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html >>>>> 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html >>>>> >>>>> If OK for push, please feel free to do so (I don't have commit access). >>>>> >>>>> Cheers, >>>>> Deepak From paul.hohensee at oracle.com Wed Feb 1 12:13:28 2012 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Wed, 01 Feb 2012 07:13:28 -0500 Subject: Patch to fix build breakage with GCC 4.7 In-Reply-To: <4F292C38.5010901@oracle.com> References: <20120130152052.GE3179@redhat.com> <4F273C6E.30801@oracle.com> <20120131023642.GO16474@redhat.com> <4F2756C9.4000304@oracle.com> <20120131152335.GA7700@redhat.com> <4F292C38.5010901@oracle.com> Message-ID: <4F292C68.60407@oracle.com> On, and it's not supported by Oracle, of course. One of the Linux distro companies might be interested though. On 2/1/12 7:12 AM, Paul Hohensee wrote: > linux-sparc used to build and run fine (I did the port way back when), > so it should be relatively easy to resurrect. The original port was on > a T1. > > Paul > > On 1/31/12 10:23 AM, Deepak Bhole wrote: >> * David Holmes [2012-01-30 21:50]: >>> On 31/01/2012 12:36 PM, Deepak Bhole wrote: >>>> * David Holmes [2012-01-30 19:57]: >>>>> While gcc compilation on sparc is rare I'm not sure that simply >>>>> deleting the sparc-only option unconditionally is the right thing to >>>>> do. >>>>> >>>> I thought about that too. But I was unable to find info on OpenJDK + >>>> SPARC + Linux. Is that combination even supported? The README doesn't >>>> list it: >>>> http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE >>>> >>> Linux-sparc is not one of Oracle's supported OpenJDK platforms. >>> However AFAIK there are people in the community building OpenJDK on >>> Linux-sparc using the Zero interpreter. I don't know if this would >>> affect them but it still seems to me that we should be careful not >>> to break other people's builds. >>> >> Ah fair enough. If it is supported, the patch definitely needs to be >> fixed. I will re-post. >> >> Thanks for taking a look! >> >> Deepak >> >>> David >>> ----- >>> >>>> The option seemed more like a relic from Solaris + SPARC config rather >>>> than a requirement for Linux + SPARC. >>> >>> >>>> Cheers, >>>> Deepak >>>> >>>>> David >>>>> >>>>> On 31/01/2012 1:20 AM, Deepak Bhole wrote: >>>>>> Hi, >>>>>> >>>>>> JDK builds currently fail with GCC 4.7 due to its stricter option >>>>>> checking. >>>>>> >>>>>> GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. >>>>>> Certain >>>>>> files in JDK supply the -mimpure-text option to GCC. This option >>>>>> is only >>>>>> valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during >>>>>> build >>>>>> on Linux (I suppose . >>>>>> >>>>>> This patch removes the option: >>>>>> http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 >>>>>> >>>>>> 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html >>>>>> 2: >>>>>> http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html >>>>>> >>>>>> If OK for push, please feel free to do so (I don't have commit >>>>>> access). >>>>>> >>>>>> Cheers, >>>>>> Deepak From fredrik.ohrstrom at oracle.com Wed Feb 1 12:38:59 2012 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Wed, 01 Feb 2012 13:38:59 +0100 Subject: Patch for: 7132779: build-infra merge: Enable ccache to work for most developer builds. In-Reply-To: <4F285F53.8070306@oracle.com> References: <4F27DF26.7060808@oracle.com> <4F285F53.8070306@oracle.com> Message-ID: <4F293263.6080101@oracle.com> 2012-01-31 22:38, David Holmes skrev: > I don't understand the comment on the new method though. Since jre_release_version() has a similar use case as vm_release(), ie it is called from crash handlers and error reporting handlers, I copied the comment for vm_release() to jre_release_version(). But perhaps it is a bit too much information since it is not that likely that the code will be refactored to have stringStreams instead of char *. > I'm assuming that the actual problem is the ccache compares the > defines used for a compilation and so if the version string contains a > timestamp and gets updated on each (incremental?) build then ccache > thinks it has to recompile. Yes, that is correct. As can be seen in most build server logs, the ccache is rarely used. It is only used when a build number is explicitly set, since the build number prevents a date and time to be inserted in the JRE_RELEASE_VERSION. //Fredrik From Alan.Bateman at oracle.com Wed Feb 1 15:18:51 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 01 Feb 2012 15:18:51 +0000 Subject: 7140918: Remove dependency on apt and com.sun.mirror API In-Reply-To: <4F2956A3.1030808@oracle.com> References: <4F26B283.8090103@oracle.com> <4F273AD3.5070207@oracle.com> <4F274012.7090904@oracle.com> <4F274146.9050103@oracle.com> <4F27A17A.1020809@oracle.com> <4F2956A3.1030808@oracle.com> Message-ID: <4F2957DB.4090401@oracle.com> On 01/02/2012 15:13, Miroslav Kos wrote: > Hi Alan, > do you have any update about approving the changeset? The jaxws bundle > is already in place, so there should be nothing blocking us from the > final step(?) I plan to push it later this week once I've verified the the downloads and done a few test builds with and without ALLOW_DOWNLOADS. -Alan. From peter.brunet at oracle.com Wed Feb 1 16:23:56 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Wed, 01 Feb 2012 10:23:56 -0600 Subject: fastdebug Message-ID: <4F29671C.8000509@oracle.com> What is the difference between using a target of fastdebug_build and no target but using the variable FASTDEBUG=true? From volker.simonis at gmail.com Wed Feb 1 17:43:55 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 1 Feb 2012 18:43:55 +0100 Subject: Is anyone able to build on Win 7 In-Reply-To: <4F20A816.4030108@oracle.com> References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> Message-ID: I went the other way round by trying the newest Cygwin snapshots (2012-01-23 and 2012-02-01) but unfortunately with absolutely no success! Quite contrary to Cygwin 1.7.9, the build reproducibly freezes after finishing jdk/make/java/jvm when entering jdk/make/java/redist and I hove no idea why. So the bad news is that the build problems on Windows7 will eventually get even worse with the next version of Cygwin. I've also tried with a Cygwin 1.7.9 and a slightly differently configured version of Gnumake 3.82 (I've set HAVE_CYGWIN_SHELL in config.h which was not the default). This looked promising in the beginning and I did several successful builds, however today the build crashed again with the well known "fork: Resource temporarily unavailable" error. So that was apparently not the solution. I really think we need support from a Cygwin/Gnumake expert here but I'm not sure how many people really qualify for this job:) By the way Peter, where did you get the old Cygwin version from? I couldn't find old versions on cygwin.com. And Peter, what kind of make are you using? Is it a Cygwin make (which version, compiled by you or original one from the distro) or is it a native Gnumake compiled with MinGW or even with VisualStudio? Thank you and best regards, Volker On Thu, Jan 26, 2012 at 2:10 AM, Pete Brunet wrote: > I just had success with the following changes: > - downgraded from cygwin 1.7.9 (with bash 4.1.10) to 1.7.0 (with bash > 3.2.49) > - changed ...\jdk\make\docs\Makefile line 74 > > ifeq ($(ARCH_DATA_MODEL),64) > ?MAX_VM_MEMORY = 1024 > else > ?MAX_VM_MEMORY = 1024 <--- This was 512 > endif > > I've only done one build and in prior builds had other issues besides > the memory problem, i.e. fork and error 126, but there's always hope. > > If others could report their W7 configurations and whether or not there > were problems, that would be helpful. > > Pete > > On 1/25/12 6:17 PM, Kelly O'Hair wrote: >> Sorry guys, I don't have the time or priority to track this down. >> Official builds are still happening on Windows XP and Windows 2003 X64 and these >> problems are not being seen on those systems.... yet... >> although we recently have been visited by the McAfee plague so maybe it's just a matter of time. ;^( >> >> Someone with some strong Windows experience needs to run this to ground. >> We do need this to work, eventually. >> >> -kto >> >> On Jan 25, 2012, at 9:09 AM, Pete Brunet wrote: >> >>> I started W7 in safe mode and the build failed with a fork failure. ?I >>> think that eliminates things in the BLODA list. ?If anyone out there is >>> building OK on W7 please send your configuration, e.g. as shown below. >>> Maybe that will suggest a different version of cygwin or bash. ?-Pete >>> >>> On 1/25/12 9:55 AM, Pete Brunet wrote: >>>> Thanks Volker, I was thinking I'm going to have to try using XP in a >>>> VM. ?My W7 config is very close to yours (make 3.81 instead of 3.82). >>>> >>>> W7 Pro, 64 bit, SP1 >>>> Intel Core 2 Duo, P8700, 2.53 GHz, 8 GB RAM >>>> CYGWIN_NT-6.1-WOW64 Bevo 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>> GNU bash, version 4.1.10(4)-release (i686-pc-cygwin) >>>> GNU Make 3.81 >>>> >>>> Pete >>>> >>>> On 1/25/12 9:06 AM, Volker Simonis wrote: >>>>> Hi Peter, >>>>> >>>>> glad to see that other have the same problems:) >>>>> >>>>> But seriously, on Windows 7 I'm currently experiencing the same >>>>> massive build problems and I'm not sure what the root cause of these >>>>> problems is. >>>>> >>>>> I found the following bug which exactly describes the problems I'm facing: >>>>> >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6903517 >>>>> >>>>> Among others, these are: >>>>> >>>>> - rm: cannot remove directory `META-INF': Directory not empty >>>>> - error: ?cannot create example2.html: Permission denied >>>>> - [javac] C:\Software\OpenJDK\jdk8\langtools\src\share\classes\com\sun\tools\javac\util\SharedNameTable.java:40: >>>>> error: error while writing SharedNameTable: >>>>> c:\Software\OpenJDK\output_amd64\langtools\build\bootstrap\classes\com\sun\tools\javac\util\SharedNameTable.class >>>>> (Access is denied) >>>>> >>>>> but I also saw the 'out of memory' and 'for' problems mentioned by you. >>>>> >>>>> The description of bug 6903517 references the "Big List of Dodgy Apps" >>>>> (http://cygwin.com/faq/faq.using.html#faq.using.bloda). This is a list >>>>> in the Cygwin FAQ which lists applications like Virus Scanners which >>>>> can interfere with Cygwin in an unpredictable way. An indeed the >>>>> Windows 7 box on which I observe the problems has some of them >>>>> installed (e.g. McAffe {Agent, GTI Proxy Agent, Intrusion Prevention, >>>>> VirusScan Enterprise, AntySpywaare Enterprise} to name just a few). >>>>> >>>>> On the other hand, on the same Windows 7 box I have a virtual machine >>>>> running inside VirtualBox ?with WindowsXP which has the same McAffe >>>>> software installed and it is running without any problems. The OpenJDK >>>>> build always succeeds in the virtual machine! >>>>> >>>>> So I'm not quite sure of this is: >>>>> - a problem of some additional software which is running on my Windows >>>>> 7 box and interferes with Cygwin >>>>> - a general Windows7 problem >>>>> - a problem of the specific Cygwin version I'm using >>>>> - a problem of Cygwin running on 64-bit Windows 7 >>>>> >>>>> I'll try to further narrow down the problem, but of course any hints >>>>> are highly welcome (unfortunately I can't easily get rid of the McAffe >>>>> stuff without losing my job, so please don't advise this:) >>>>> >>>>> Regards, >>>>> Volker >>>>> >>>>> PS: below you can find the exact versions of the software/hardware I'm using: >>>>> >>>>> 64-bit Windows 7, SP 1 >>>>> Dual Core Intel i7, 8GB RAM >>>>> >>>>> Cygwin (output of uname -a): >>>>> CYGWIN_NT-6.1-WOW64 WDFN00299915A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>> bash 4.1.10(4) ?// installed by Cygwin setup.exe >>>>> make 3.82 ?// compiled by myself >>>>> >>>>> In the Virtual box VM I have the following system: >>>>> >>>>> 64-bit Windows XP Professional Version 2003 SP 2 >>>>> >>>>> Cygwin (output of uname -a): >>>>> CYGWIN_NT-5.2-WOW64 WDFV00248216A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>> bash 4.1.10(4) ?// installed by Cygwin setup.exe >>>>> make 3.82 ?// compiled by myself >>>>> >>>>> >>>>> On Tue, Jan 24, 2012 at 5:52 PM, Pete Brunet wrote: >>>>>> Is anyone able to build on Win 7? ?I'm on my 8th build hoping to get to >>>>>> the end and have seen these errors: >>>>>> >>>>>> out of memory, 3 times - I have more than enough memory >>>>>> fork: Resource temporarily unavailable, 3 times >>>>>> error 126, once >>>>>> >>>>>> I have read http://cygwin.com/faq-nochunks.html#faq.using.bloda so >>>>>> apparently something on my system is causing a problem but I haven't >>>>>> been successful in finding it yet. ?I have my Norton 360 "Auto-Protect" >>>>>> turned off. ?It would be helpful to know if anyone has successfully >>>>>> built on Win 7 and also if anyone has ideas on what I might look for >>>>>> beyond what is listed in the cygwin FAQ. >>>>>> >>>>>> Thanks, Pete >>>>>> >>>>>> From philip.race at oracle.com Wed Feb 1 18:07:52 2012 From: philip.race at oracle.com (Phil Race) Date: Wed, 01 Feb 2012 10:07:52 -0800 Subject: Is anyone able to build on Win 7 In-Reply-To: References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> Message-ID: <4F297F78.6080306@oracle.com> Volker, Will you be able to debug this ? FWIW my cygwin is 1.7.8 and I use win7 x64, for JDK builds and have done so for about as long as its been available, and probably the main issue I've had is accidentally using the wrong version of gnu make, and I don't know offhand any more if the cygwin make is OK to use. At some point it was not. Kelly ? If there *is* a problem new with the latest cygwins it would be nice to track that down as we'd need to decide if we need to a) go back and fix all the 7 updates and the rest to work with the newer cygwins b) tell every one to archive last known good cygwin - I don't think we'd be able to host/redistribute it here. c) ask cygwin to correct the problem. That's all still speculative of course. -phil. On 2/1/2012 9:43 AM, Volker Simonis wrote: > I went the other way round by trying the newest Cygwin snapshots > (2012-01-23 and 2012-02-01) but unfortunately with absolutely no > success! > > Quite contrary to Cygwin 1.7.9, the build reproducibly freezes after > finishing jdk/make/java/jvm when entering jdk/make/java/redist and I > hove no idea why. So the bad news is that the build problems on > Windows7 will eventually get even worse with the next version of > Cygwin. > > I've also tried with a Cygwin 1.7.9 and a slightly differently > configured version of Gnumake 3.82 (I've set HAVE_CYGWIN_SHELL in > config.h which was not the default). This looked promising in the > beginning and I did several successful builds, however today the build > crashed again with the well known "fork: Resource temporarily > unavailable" error. So that was apparently not the solution. > > I really think we need support from a Cygwin/Gnumake expert here but > I'm not sure how many people really qualify for this job:) > > By the way Peter, where did you get the old Cygwin version from? I > couldn't find old versions on cygwin.com. > > And Peter, what kind of make are you using? Is it a Cygwin make (which > version, compiled by you or original one from the distro) or is it a > native Gnumake compiled with MinGW or even with VisualStudio? > > Thank you and best regards, > Volker > > On Thu, Jan 26, 2012 at 2:10 AM, Pete Brunet wrote: >> I just had success with the following changes: >> - downgraded from cygwin 1.7.9 (with bash 4.1.10) to 1.7.0 (with bash >> 3.2.49) >> - changed ...\jdk\make\docs\Makefile line 74 >> >> ifeq ($(ARCH_DATA_MODEL),64) >> MAX_VM_MEMORY = 1024 >> else >> MAX_VM_MEMORY = 1024<--- This was 512 >> endif >> >> I've only done one build and in prior builds had other issues besides >> the memory problem, i.e. fork and error 126, but there's always hope. >> >> If others could report their W7 configurations and whether or not there >> were problems, that would be helpful. >> >> Pete >> >> On 1/25/12 6:17 PM, Kelly O'Hair wrote: >>> Sorry guys, I don't have the time or priority to track this down. >>> Official builds are still happening on Windows XP and Windows 2003 X64 and these >>> problems are not being seen on those systems.... yet... >>> although we recently have been visited by the McAfee plague so maybe it's just a matter of time. ;^( >>> >>> Someone with some strong Windows experience needs to run this to ground. >>> We do need this to work, eventually. >>> >>> -kto >>> >>> On Jan 25, 2012, at 9:09 AM, Pete Brunet wrote: >>> >>>> I started W7 in safe mode and the build failed with a fork failure. I >>>> think that eliminates things in the BLODA list. If anyone out there is >>>> building OK on W7 please send your configuration, e.g. as shown below. >>>> Maybe that will suggest a different version of cygwin or bash. -Pete >>>> >>>> On 1/25/12 9:55 AM, Pete Brunet wrote: >>>>> Thanks Volker, I was thinking I'm going to have to try using XP in a >>>>> VM. My W7 config is very close to yours (make 3.81 instead of 3.82). >>>>> >>>>> W7 Pro, 64 bit, SP1 >>>>> Intel Core 2 Duo, P8700, 2.53 GHz, 8 GB RAM >>>>> CYGWIN_NT-6.1-WOW64 Bevo 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>> GNU bash, version 4.1.10(4)-release (i686-pc-cygwin) >>>>> GNU Make 3.81 >>>>> >>>>> Pete >>>>> >>>>> On 1/25/12 9:06 AM, Volker Simonis wrote: >>>>>> Hi Peter, >>>>>> >>>>>> glad to see that other have the same problems:) >>>>>> >>>>>> But seriously, on Windows 7 I'm currently experiencing the same >>>>>> massive build problems and I'm not sure what the root cause of these >>>>>> problems is. >>>>>> >>>>>> I found the following bug which exactly describes the problems I'm facing: >>>>>> >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6903517 >>>>>> >>>>>> Among others, these are: >>>>>> >>>>>> - rm: cannot remove directory `META-INF': Directory not empty >>>>>> - error: cannot create example2.html: Permission denied >>>>>> - [javac] C:\Software\OpenJDK\jdk8\langtools\src\share\classes\com\sun\tools\javac\util\SharedNameTable.java:40: >>>>>> error: error while writing SharedNameTable: >>>>>> c:\Software\OpenJDK\output_amd64\langtools\build\bootstrap\classes\com\sun\tools\javac\util\SharedNameTable.class >>>>>> (Access is denied) >>>>>> >>>>>> but I also saw the 'out of memory' and 'for' problems mentioned by you. >>>>>> >>>>>> The description of bug 6903517 references the "Big List of Dodgy Apps" >>>>>> (http://cygwin.com/faq/faq.using.html#faq.using.bloda). This is a list >>>>>> in the Cygwin FAQ which lists applications like Virus Scanners which >>>>>> can interfere with Cygwin in an unpredictable way. An indeed the >>>>>> Windows 7 box on which I observe the problems has some of them >>>>>> installed (e.g. McAffe {Agent, GTI Proxy Agent, Intrusion Prevention, >>>>>> VirusScan Enterprise, AntySpywaare Enterprise} to name just a few). >>>>>> >>>>>> On the other hand, on the same Windows 7 box I have a virtual machine >>>>>> running inside VirtualBox with WindowsXP which has the same McAffe >>>>>> software installed and it is running without any problems. The OpenJDK >>>>>> build always succeeds in the virtual machine! >>>>>> >>>>>> So I'm not quite sure of this is: >>>>>> - a problem of some additional software which is running on my Windows >>>>>> 7 box and interferes with Cygwin >>>>>> - a general Windows7 problem >>>>>> - a problem of the specific Cygwin version I'm using >>>>>> - a problem of Cygwin running on 64-bit Windows 7 >>>>>> >>>>>> I'll try to further narrow down the problem, but of course any hints >>>>>> are highly welcome (unfortunately I can't easily get rid of the McAffe >>>>>> stuff without losing my job, so please don't advise this:) >>>>>> >>>>>> Regards, >>>>>> Volker >>>>>> >>>>>> PS: below you can find the exact versions of the software/hardware I'm using: >>>>>> >>>>>> 64-bit Windows 7, SP 1 >>>>>> Dual Core Intel i7, 8GB RAM >>>>>> >>>>>> Cygwin (output of uname -a): >>>>>> CYGWIN_NT-6.1-WOW64 WDFN00299915A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>>> bash 4.1.10(4) // installed by Cygwin setup.exe >>>>>> make 3.82 // compiled by myself >>>>>> >>>>>> In the Virtual box VM I have the following system: >>>>>> >>>>>> 64-bit Windows XP Professional Version 2003 SP 2 >>>>>> >>>>>> Cygwin (output of uname -a): >>>>>> CYGWIN_NT-5.2-WOW64 WDFV00248216A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>>> bash 4.1.10(4) // installed by Cygwin setup.exe >>>>>> make 3.82 // compiled by myself >>>>>> >>>>>> >>>>>> On Tue, Jan 24, 2012 at 5:52 PM, Pete Brunet wrote: >>>>>>> Is anyone able to build on Win 7? I'm on my 8th build hoping to get to >>>>>>> the end and have seen these errors: >>>>>>> >>>>>>> out of memory, 3 times - I have more than enough memory >>>>>>> fork: Resource temporarily unavailable, 3 times >>>>>>> error 126, once >>>>>>> >>>>>>> I have read http://cygwin.com/faq-nochunks.html#faq.using.bloda so >>>>>>> apparently something on my system is causing a problem but I haven't >>>>>>> been successful in finding it yet. I have my Norton 360 "Auto-Protect" >>>>>>> turned off. It would be helpful to know if anyone has successfully >>>>>>> built on Win 7 and also if anyone has ideas on what I might look for >>>>>>> beyond what is listed in the cygwin FAQ. >>>>>>> >>>>>>> Thanks, Pete >>>>>>> >>>>>>> From peter.brunet at oracle.com Wed Feb 1 18:38:51 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Wed, 01 Feb 2012 12:38:51 -0600 Subject: Is anyone able to build on Win 7 In-Reply-To: References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> Message-ID: <4F2986BB.8040208@oracle.com> On 2/1/12 11:43 AM, Volker Simonis wrote: > I went the other way round by trying the newest Cygwin snapshots > (2012-01-23 and 2012-02-01) but unfortunately with absolutely no > success! > > Quite contrary to Cygwin 1.7.9, the build reproducibly freezes after > finishing jdk/make/java/jvm when entering jdk/make/java/redist and I > hove no idea why. So the bad news is that the build problems on > Windows7 will eventually get even worse with the next version of > Cygwin. > > I've also tried with a Cygwin 1.7.9 and a slightly differently > configured version of Gnumake 3.82 (I've set HAVE_CYGWIN_SHELL in > config.h which was not the default). This looked promising in the > beginning and I did several successful builds, however today the build > crashed again with the well known "fork: Resource temporarily > unavailable" error. So that was apparently not the solution. > > I really think we need support from a Cygwin/Gnumake expert here but > I'm not sure how many people really qualify for this job:) > > By the way Peter, where did you get the old Cygwin version from? I > couldn't find old versions on cygwin.com. I had it on another drive that I was using when I was running XP. This might help: http://www.fruitbat.org/Cygwin/index.html#cygwintimemachine or if that doesn't work out I could zip up 1.7.0 and put it on an ftp site for you. > > And Peter, what kind of make are you using? Is it a Cygwin make (which > version, compiled by you or original one from the distro) or is it a > native Gnumake compiled with MinGW or even with VisualStudio? I am using the make 3.8.1 from: http://www.cmake.org/files/cygwin/make.exe I notice that there is also: http://www.cmake.org/files/cygwin/make.exe-cygwin1.7 but I have not tried it. I just downloaded it and it's also version 3.8.1. It might be worth a try. > > Thank you and best regards, > Volker > > On Thu, Jan 26, 2012 at 2:10 AM, Pete Brunet wrote: >> I just had success with the following changes: >> - downgraded from cygwin 1.7.9 (with bash 4.1.10) to 1.7.0 (with bash >> 3.2.49) >> - changed ...\jdk\make\docs\Makefile line 74 >> >> ifeq ($(ARCH_DATA_MODEL),64) >> MAX_VM_MEMORY = 1024 >> else >> MAX_VM_MEMORY = 1024 <--- This was 512 >> endif >> >> I've only done one build and in prior builds had other issues besides >> the memory problem, i.e. fork and error 126, but there's always hope. >> >> If others could report their W7 configurations and whether or not there >> were problems, that would be helpful. >> >> Pete >> >> On 1/25/12 6:17 PM, Kelly O'Hair wrote: >>> Sorry guys, I don't have the time or priority to track this down. >>> Official builds are still happening on Windows XP and Windows 2003 X64 and these >>> problems are not being seen on those systems.... yet... >>> although we recently have been visited by the McAfee plague so maybe it's just a matter of time. ;^( >>> >>> Someone with some strong Windows experience needs to run this to ground. >>> We do need this to work, eventually. >>> >>> -kto >>> >>> On Jan 25, 2012, at 9:09 AM, Pete Brunet wrote: >>> >>>> I started W7 in safe mode and the build failed with a fork failure. I >>>> think that eliminates things in the BLODA list. If anyone out there is >>>> building OK on W7 please send your configuration, e.g. as shown below. >>>> Maybe that will suggest a different version of cygwin or bash. -Pete >>>> >>>> On 1/25/12 9:55 AM, Pete Brunet wrote: >>>>> Thanks Volker, I was thinking I'm going to have to try using XP in a >>>>> VM. My W7 config is very close to yours (make 3.81 instead of 3.82). >>>>> >>>>> W7 Pro, 64 bit, SP1 >>>>> Intel Core 2 Duo, P8700, 2.53 GHz, 8 GB RAM >>>>> CYGWIN_NT-6.1-WOW64 Bevo 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>> GNU bash, version 4.1.10(4)-release (i686-pc-cygwin) >>>>> GNU Make 3.81 >>>>> >>>>> Pete >>>>> >>>>> On 1/25/12 9:06 AM, Volker Simonis wrote: >>>>>> Hi Peter, >>>>>> >>>>>> glad to see that other have the same problems:) >>>>>> >>>>>> But seriously, on Windows 7 I'm currently experiencing the same >>>>>> massive build problems and I'm not sure what the root cause of these >>>>>> problems is. >>>>>> >>>>>> I found the following bug which exactly describes the problems I'm facing: >>>>>> >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6903517 >>>>>> >>>>>> Among others, these are: >>>>>> >>>>>> - rm: cannot remove directory `META-INF': Directory not empty >>>>>> - error: cannot create example2.html: Permission denied >>>>>> - [javac] C:\Software\OpenJDK\jdk8\langtools\src\share\classes\com\sun\tools\javac\util\SharedNameTable.java:40: >>>>>> error: error while writing SharedNameTable: >>>>>> c:\Software\OpenJDK\output_amd64\langtools\build\bootstrap\classes\com\sun\tools\javac\util\SharedNameTable.class >>>>>> (Access is denied) >>>>>> >>>>>> but I also saw the 'out of memory' and 'for' problems mentioned by you. >>>>>> >>>>>> The description of bug 6903517 references the "Big List of Dodgy Apps" >>>>>> (http://cygwin.com/faq/faq.using.html#faq.using.bloda). This is a list >>>>>> in the Cygwin FAQ which lists applications like Virus Scanners which >>>>>> can interfere with Cygwin in an unpredictable way. An indeed the >>>>>> Windows 7 box on which I observe the problems has some of them >>>>>> installed (e.g. McAffe {Agent, GTI Proxy Agent, Intrusion Prevention, >>>>>> VirusScan Enterprise, AntySpywaare Enterprise} to name just a few). >>>>>> >>>>>> On the other hand, on the same Windows 7 box I have a virtual machine >>>>>> running inside VirtualBox with WindowsXP which has the same McAffe >>>>>> software installed and it is running without any problems. The OpenJDK >>>>>> build always succeeds in the virtual machine! >>>>>> >>>>>> So I'm not quite sure of this is: >>>>>> - a problem of some additional software which is running on my Windows >>>>>> 7 box and interferes with Cygwin >>>>>> - a general Windows7 problem >>>>>> - a problem of the specific Cygwin version I'm using >>>>>> - a problem of Cygwin running on 64-bit Windows 7 >>>>>> >>>>>> I'll try to further narrow down the problem, but of course any hints >>>>>> are highly welcome (unfortunately I can't easily get rid of the McAffe >>>>>> stuff without losing my job, so please don't advise this:) >>>>>> >>>>>> Regards, >>>>>> Volker >>>>>> >>>>>> PS: below you can find the exact versions of the software/hardware I'm using: >>>>>> >>>>>> 64-bit Windows 7, SP 1 >>>>>> Dual Core Intel i7, 8GB RAM >>>>>> >>>>>> Cygwin (output of uname -a): >>>>>> CYGWIN_NT-6.1-WOW64 WDFN00299915A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>>> bash 4.1.10(4) // installed by Cygwin setup.exe >>>>>> make 3.82 // compiled by myself >>>>>> >>>>>> In the Virtual box VM I have the following system: >>>>>> >>>>>> 64-bit Windows XP Professional Version 2003 SP 2 >>>>>> >>>>>> Cygwin (output of uname -a): >>>>>> CYGWIN_NT-5.2-WOW64 WDFV00248216A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>>> bash 4.1.10(4) // installed by Cygwin setup.exe >>>>>> make 3.82 // compiled by myself >>>>>> >>>>>> >>>>>> On Tue, Jan 24, 2012 at 5:52 PM, Pete Brunet wrote: >>>>>>> Is anyone able to build on Win 7? I'm on my 8th build hoping to get to >>>>>>> the end and have seen these errors: >>>>>>> >>>>>>> out of memory, 3 times - I have more than enough memory >>>>>>> fork: Resource temporarily unavailable, 3 times >>>>>>> error 126, once >>>>>>> >>>>>>> I have read http://cygwin.com/faq-nochunks.html#faq.using.bloda so >>>>>>> apparently something on my system is causing a problem but I haven't >>>>>>> been successful in finding it yet. I have my Norton 360 "Auto-Protect" >>>>>>> turned off. It would be helpful to know if anyone has successfully >>>>>>> built on Win 7 and also if anyone has ideas on what I might look for >>>>>>> beyond what is listed in the cygwin FAQ. >>>>>>> >>>>>>> Thanks, Pete >>>>>>> >>>>>>> From michael.j.silverstri at gmail.com Wed Feb 1 20:57:06 2012 From: michael.j.silverstri at gmail.com (m silverstri) Date: Wed, 1 Feb 2012 12:57:06 -0800 Subject: How to build openjdk under mac osx Message-ID: Hi, I am trying to following the steps here to build openjdk 7 on Mac OS 10.6.8. https://wikis.oracle.com/display/OpenJDK/Darwin10Build But I am getting this error: rm -f bsd_x86_32.o /usr/bin/gcc -c -x assembler-with-cpp -m32 -march=i586 -mstackrealign -MMD -MP -MF ../generated/dependencies/bsd_x86_32.o.d -o bsd_x86_32.o /Users/michael/Src/openjdk/bsd-port/hotspot/src/os_cpu/bsd_x86/vm/bsd_x86_32.s /Users/michael/Src/openjdk/bsd-port/hotspot/src/os_cpu/bsd_x86/vm/bsd_x86_32.s:27:Unknown pseudo-op: .type /Users/michael/Src/openjdk/bsd-port/hotspot/src/os_cpu/bsd_x86/vm/bsd_x86_32.s:27:Rest of line ignored. 1st junk character valued 95 (_). make[6]: *** [bsd_x86_32.o] Error 1 make[5]: *** [the_vm] Error 2 make[4]: *** [product] Error 2 make[3]: *** [generic_build2] Error 2 make[2]: *** [product] Error 2 make[1]: *** [hotspot-build] Error 2 make: *** [build_product_image] Error 2 Does anyone know how to fix it? Thank you. From kelly.ohair at oracle.com Wed Feb 1 22:36:38 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 1 Feb 2012 14:36:38 -0800 Subject: ...\jdk\make\docs\Makefile needs a fix In-Reply-To: <4F28C8D4.6040708@oracle.com> References: <4F28C8D4.6040708@oracle.com> Message-ID: Probably should be 1024 now for everybody, but as I recall, that could create problems for some windows machines that might not have that big a hole available in the virtual memory. export NO_DOCS=true should skip most javadoc runs. Not sure many developers really need to constantly run javadoc, not the speediest animal on the planet. :^( -kto On Jan 31, 2012, at 9:08 PM, Pete Brunet wrote: > Back in November there was a change to ...\jdk\make\docs\Makefile to fix > an out of memory problem by raising the memory size for a 32 bit build > (line 74) from 512 to 612. That didn't work on my machine: 64 bit > Windows 7 with 8 mb. I raised it up to 1024 to bypass the problem. I > don't know if that's too much but it worked. > > Pete From kelly.ohair at oracle.com Wed Feb 1 23:10:50 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 1 Feb 2012 15:10:50 -0800 Subject: Is anyone able to build on Win 7 In-Reply-To: <4F297F78.6080306@oracle.com> References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> <4F297F78.6080306@oracle.com> Message-ID: <066F07A9-2F32-4435-812D-7E40E38D792F@oracle.com> On Feb 1, 2012, at 10:07 AM, Phil Race wrote: > Volker, > > Will you be able to debug this ? > > FWIW my cygwin is 1.7.8 and I use win7 x64, for JDK builds and have done so for about as > long as its been available, and probably the main issue I've had is accidentally using the > wrong version of gnu make, and I don't know offhand any more if the cygwin make is OK to use. If it is the wrong make.exe (the one that does not support C:/ style pathnames) then you will find out very quickly, it just does not get very far. It thinks the : character is a target:dependencies separator. > At some point it was not. Kelly ? I don't know what the current state is. The CYGWIN community seemed pretty adamant that they wanted to stamp out all drive letter pathnames. As I understood it, it's not so much the version of make.exe, but how the make.exe was built. Some kind of 'allow drive letter paths' option needs to be turned on when building. I've been trapped in a hidey-hole for some time now managing physical and virtual machines that seem to dance around me like pink elephants from the Dumbo movie. :^( So I'm a bit disconnected right now. I have automated the copy of an make.exe that works onto the build machines, so I use the same exact make.exe on all Windows systems and all CYGWIN versions. Hasn't been an issue. I know that make 3.82 had some kind of problem, not sure it was windows related though. > > If there *is* a problem new with the latest cygwins it would be nice to track that down > as we'd need to decide if we need to > a) go back and fix all the 7 updates and the rest to work with the newer cygwins > b) tell every one to archive last known good cygwin - I don't think we'd be > able to host/redistribute it here. > c) ask cygwin to correct the problem. Agreed. > > That's all still speculative of course. With Windows it's always speculative. -kto > > -phil. > > > On 2/1/2012 9:43 AM, Volker Simonis wrote: >> I went the other way round by trying the newest Cygwin snapshots >> (2012-01-23 and 2012-02-01) but unfortunately with absolutely no >> success! >> >> Quite contrary to Cygwin 1.7.9, the build reproducibly freezes after >> finishing jdk/make/java/jvm when entering jdk/make/java/redist and I >> hove no idea why. So the bad news is that the build problems on >> Windows7 will eventually get even worse with the next version of >> Cygwin. >> >> I've also tried with a Cygwin 1.7.9 and a slightly differently >> configured version of Gnumake 3.82 (I've set HAVE_CYGWIN_SHELL in >> config.h which was not the default). This looked promising in the >> beginning and I did several successful builds, however today the build >> crashed again with the well known "fork: Resource temporarily >> unavailable" error. So that was apparently not the solution. >> >> I really think we need support from a Cygwin/Gnumake expert here but >> I'm not sure how many people really qualify for this job:) >> >> By the way Peter, where did you get the old Cygwin version from? I >> couldn't find old versions on cygwin.com. >> >> And Peter, what kind of make are you using? Is it a Cygwin make (which >> version, compiled by you or original one from the distro) or is it a >> native Gnumake compiled with MinGW or even with VisualStudio? >> >> Thank you and best regards, >> Volker >> >> On Thu, Jan 26, 2012 at 2:10 AM, Pete Brunet wrote: >>> I just had success with the following changes: >>> - downgraded from cygwin 1.7.9 (with bash 4.1.10) to 1.7.0 (with bash >>> 3.2.49) >>> - changed ...\jdk\make\docs\Makefile line 74 >>> >>> ifeq ($(ARCH_DATA_MODEL),64) >>> MAX_VM_MEMORY = 1024 >>> else >>> MAX_VM_MEMORY = 1024<--- This was 512 >>> endif >>> >>> I've only done one build and in prior builds had other issues besides >>> the memory problem, i.e. fork and error 126, but there's always hope. >>> >>> If others could report their W7 configurations and whether or not there >>> were problems, that would be helpful. >>> >>> Pete >>> >>> On 1/25/12 6:17 PM, Kelly O'Hair wrote: >>>> Sorry guys, I don't have the time or priority to track this down. >>>> Official builds are still happening on Windows XP and Windows 2003 X64 and these >>>> problems are not being seen on those systems.... yet... >>>> although we recently have been visited by the McAfee plague so maybe it's just a matter of time. ;^( >>>> >>>> Someone with some strong Windows experience needs to run this to ground. >>>> We do need this to work, eventually. >>>> >>>> -kto >>>> >>>> On Jan 25, 2012, at 9:09 AM, Pete Brunet wrote: >>>> >>>>> I started W7 in safe mode and the build failed with a fork failure. I >>>>> think that eliminates things in the BLODA list. If anyone out there is >>>>> building OK on W7 please send your configuration, e.g. as shown below. >>>>> Maybe that will suggest a different version of cygwin or bash. -Pete >>>>> >>>>> On 1/25/12 9:55 AM, Pete Brunet wrote: >>>>>> Thanks Volker, I was thinking I'm going to have to try using XP in a >>>>>> VM. My W7 config is very close to yours (make 3.81 instead of 3.82). >>>>>> >>>>>> W7 Pro, 64 bit, SP1 >>>>>> Intel Core 2 Duo, P8700, 2.53 GHz, 8 GB RAM >>>>>> CYGWIN_NT-6.1-WOW64 Bevo 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>>> GNU bash, version 4.1.10(4)-release (i686-pc-cygwin) >>>>>> GNU Make 3.81 >>>>>> >>>>>> Pete >>>>>> >>>>>> On 1/25/12 9:06 AM, Volker Simonis wrote: >>>>>>> Hi Peter, >>>>>>> >>>>>>> glad to see that other have the same problems:) >>>>>>> >>>>>>> But seriously, on Windows 7 I'm currently experiencing the same >>>>>>> massive build problems and I'm not sure what the root cause of these >>>>>>> problems is. >>>>>>> >>>>>>> I found the following bug which exactly describes the problems I'm facing: >>>>>>> >>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6903517 >>>>>>> >>>>>>> Among others, these are: >>>>>>> >>>>>>> - rm: cannot remove directory `META-INF': Directory not empty >>>>>>> - error: cannot create example2.html: Permission denied >>>>>>> - [javac] C:\Software\OpenJDK\jdk8\langtools\src\share\classes\com\sun\tools\javac\util\SharedNameTable.java:40: >>>>>>> error: error while writing SharedNameTable: >>>>>>> c:\Software\OpenJDK\output_amd64\langtools\build\bootstrap\classes\com\sun\tools\javac\util\SharedNameTable.class >>>>>>> (Access is denied) >>>>>>> >>>>>>> but I also saw the 'out of memory' and 'for' problems mentioned by you. >>>>>>> >>>>>>> The description of bug 6903517 references the "Big List of Dodgy Apps" >>>>>>> (http://cygwin.com/faq/faq.using.html#faq.using.bloda). This is a list >>>>>>> in the Cygwin FAQ which lists applications like Virus Scanners which >>>>>>> can interfere with Cygwin in an unpredictable way. An indeed the >>>>>>> Windows 7 box on which I observe the problems has some of them >>>>>>> installed (e.g. McAffe {Agent, GTI Proxy Agent, Intrusion Prevention, >>>>>>> VirusScan Enterprise, AntySpywaare Enterprise} to name just a few). >>>>>>> >>>>>>> On the other hand, on the same Windows 7 box I have a virtual machine >>>>>>> running inside VirtualBox with WindowsXP which has the same McAffe >>>>>>> software installed and it is running without any problems. The OpenJDK >>>>>>> build always succeeds in the virtual machine! >>>>>>> >>>>>>> So I'm not quite sure of this is: >>>>>>> - a problem of some additional software which is running on my Windows >>>>>>> 7 box and interferes with Cygwin >>>>>>> - a general Windows7 problem >>>>>>> - a problem of the specific Cygwin version I'm using >>>>>>> - a problem of Cygwin running on 64-bit Windows 7 >>>>>>> >>>>>>> I'll try to further narrow down the problem, but of course any hints >>>>>>> are highly welcome (unfortunately I can't easily get rid of the McAffe >>>>>>> stuff without losing my job, so please don't advise this:) >>>>>>> >>>>>>> Regards, >>>>>>> Volker >>>>>>> >>>>>>> PS: below you can find the exact versions of the software/hardware I'm using: >>>>>>> >>>>>>> 64-bit Windows 7, SP 1 >>>>>>> Dual Core Intel i7, 8GB RAM >>>>>>> >>>>>>> Cygwin (output of uname -a): >>>>>>> CYGWIN_NT-6.1-WOW64 WDFN00299915A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>>>> bash 4.1.10(4) // installed by Cygwin setup.exe >>>>>>> make 3.82 // compiled by myself >>>>>>> >>>>>>> In the Virtual box VM I have the following system: >>>>>>> >>>>>>> 64-bit Windows XP Professional Version 2003 SP 2 >>>>>>> >>>>>>> Cygwin (output of uname -a): >>>>>>> CYGWIN_NT-5.2-WOW64 WDFV00248216A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>>>> bash 4.1.10(4) // installed by Cygwin setup.exe >>>>>>> make 3.82 // compiled by myself >>>>>>> >>>>>>> >>>>>>> On Tue, Jan 24, 2012 at 5:52 PM, Pete Brunet wrote: >>>>>>>> Is anyone able to build on Win 7? I'm on my 8th build hoping to get to >>>>>>>> the end and have seen these errors: >>>>>>>> >>>>>>>> out of memory, 3 times - I have more than enough memory >>>>>>>> fork: Resource temporarily unavailable, 3 times >>>>>>>> error 126, once >>>>>>>> >>>>>>>> I have read http://cygwin.com/faq-nochunks.html#faq.using.bloda so >>>>>>>> apparently something on my system is causing a problem but I haven't >>>>>>>> been successful in finding it yet. I have my Norton 360 "Auto-Protect" >>>>>>>> turned off. It would be helpful to know if anyone has successfully >>>>>>>> built on Win 7 and also if anyone has ideas on what I might look for >>>>>>>> beyond what is listed in the cygwin FAQ. >>>>>>>> >>>>>>>> Thanks, Pete >>>>>>>> >>>>>>>> > From kelly.ohair at oracle.com Wed Feb 1 23:15:49 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 1 Feb 2012 15:15:49 -0800 Subject: Is anyone able to build on Win 7 In-Reply-To: References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> Message-ID: <7B120C68-6BE7-4ACF-9E3F-45CCD588CB44@oracle.com> On Feb 1, 2012, at 9:43 AM, Volker Simonis wrote: > Quite contrary to Cygwin 1.7.9, the build reproducibly freezes after > finishing jdk/make/java/jvm when entering jdk/make/java/redist and I > hove no idea why. So the bad news is that the build problems on > Windows7 will eventually get even worse with the next version of > Cygwin. for the most part jdk/make/java/redist is copying files. That smells like an anti-virus on-access scanning issue. You might try turning off AV on-access scanning temporarily and see if that changes things. Or add your source tree and build result area to the AV directory exclude list temporarily. Of course, changing AV settings is a dangerous notice I said 'temporarily'. Ultimate AV solution is Linux or Solaris of course. ;^) Has anyone invented a Windows application build system that runs on Linux? ;^) -kto -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.katleman at sun.com Thu Feb 2 01:02:45 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 02 Feb 2012 01:02:45 +0000 Subject: hg: jdk8/build: Added tag jdk8-b23 for changeset 60d6f64a86b1 Message-ID: <20120202010245.7C006472EF@hg.openjdk.java.net> Changeset: 1a5f1d6b98d6 Author: katleman Date: 2012-01-26 18:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/1a5f1d6b98d6 Added tag jdk8-b23 for changeset 60d6f64a86b1 ! .hgtags From david.katleman at sun.com Thu Feb 2 01:02:52 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 02 Feb 2012 01:02:52 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b23 for changeset 5218eb256658 Message-ID: <20120202010253.14955472F0@hg.openjdk.java.net> Changeset: b98f0e6dddf9 Author: katleman Date: 2012-01-26 18:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/b98f0e6dddf9 Added tag jdk8-b23 for changeset 5218eb256658 ! .hgtags From david.katleman at sun.com Thu Feb 2 01:04:40 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 02 Feb 2012 01:04:40 +0000 Subject: hg: jdk8/build/hotspot: 45 new changesets Message-ID: <20120202010612.820E9472F2@hg.openjdk.java.net> Changeset: 6edfe6e42a68 Author: katleman Date: 2012-01-26 18:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6edfe6e42a68 Added tag jdk8-b23 for changeset e850d8e7ea54 ! .hgtags Changeset: 5f3fcd591768 Author: amurillo Date: 2012-01-20 17:07 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5f3fcd591768 7131979: new hotspot build - hs23-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 53a127075045 Author: kvn Date: 2012-01-20 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/53a127075045 7131302: connode.cpp:205 Error: ShouldNotReachHere() Summary: Add Value() methods to short and byte Load nodes to truncate constants which does not fit. Reviewed-by: jrose ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp Changeset: 9164b8236699 Author: iveresov Date: 2012-01-20 15:02 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9164b8236699 7131028: Switch statement takes wrong path Summary: Pass correct type to branch in LIRGenerator::do_SwitchRanges() Reviewed-by: kvn, never ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: a81f60ddab06 Author: never Date: 2012-01-22 14:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a81f60ddab06 7130676: Tiered: assert(bci == 0 || 0<= bci && bciis_loaded() Summary: handle not loaded array klass in Parse::do_checkcast(). Reviewed-by: kvn, never ! src/share/vm/opto/parseHelper.cpp Changeset: 5dbed2f542ff Author: bdelsart Date: 2012-01-26 16:49 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5dbed2f542ff 7120468: SPARC/x86: use frame::describe to enhance trace_method_handle Summary: improvements of TraceMethodHandles for JSR292 Reviewed-by: never, twisti ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/zero/vm/frame_zero.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp Changeset: 20334ed5ed3c Author: iveresov Date: 2012-01-26 12:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/20334ed5ed3c 7131259: compile_method and CompilationPolicy::event shouldn't be declared TRAPS Summary: Make sure that CompilationPolicy::event() doesn't throw exceptions Reviewed-by: kvn, never ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/compilationPolicy.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp ! src/share/vm/utilities/exceptions.hpp Changeset: 072384a61312 Author: jrose Date: 2012-01-26 19:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/072384a61312 Merge Changeset: 2e966d967c5c Author: johnc Date: 2012-01-13 13:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2e966d967c5c 7121547: G1: High number mispredicted branches while iterating over the marking bitmap Summary: There is a high number of mispredicted branches associated with calling BitMap::iteratate() from within CMBitMapRO::iterate(). Implement a version of CMBitMapRO::iterate() directly using inline-able routines. Reviewed-by: tonyp, iveresov ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/utilities/bitMap.inline.hpp Changeset: 851b58c26def Author: brutisso Date: 2012-01-16 11:21 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/851b58c26def 7130334: G1: Change comments and error messages that refer to CMS in g1/concurrentMark.cpp/hpp Summary: Removed references to CMS in the concurrentMark.cpp/hpp files. Reviewed-by: tonyp, jmasa, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp Changeset: 9509c20bba28 Author: brutisso Date: 2012-01-16 22:10 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9509c20bba28 6976060: G1: humongous object allocations should initiate marking cycles when necessary Reviewed-by: tonyp, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/gc_interface/gcCause.hpp Changeset: 0b3d1ec6eaee Author: tonyp Date: 2012-01-18 10:30 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0b3d1ec6eaee 7097586: G1: improve the per-space output when using jmap -heap Summary: Extend the jmap -heap output for G1 to include some more G1-specific information. Reviewed-by: brutisso, johnc, poonam ! agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1CollectedHeap.java ! agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/G1MonitoringSupport.java + agent/src/share/classes/sun/jvm/hotspot/gc_implementation/g1/HeapRegionSetBase.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/vmStructs_g1.hpp Changeset: 7ca7be5a6a0b Author: johnc Date: 2012-01-17 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7ca7be5a6a0b 7129271: G1: Interference from multiple threads in PrintGC/PrintGCDetails output Summary: During an initial mark pause, signal the Concurrent Mark thread after the pause output from PrintGC/PrintGCDetails is complete. Reviewed-by: tonyp, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: a8a126788ea0 Author: tonyp Date: 2012-01-19 09:13 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a8a126788ea0 7078465: G1: Don't use the undefined value (-1) for the G1 old memory pool max size Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp ! src/share/vm/services/g1MemoryPool.hpp Changeset: 57025542827f Author: brutisso Date: 2012-01-20 18:01 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/57025542827f 7131791: G1: Asserts in nightly testing due to 6976060 Summary: Create a handle and fake an object to make sure that we don't loose the memory we just allocated Reviewed-by: tonyp, stefank ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 6a78aa6ac1ff Author: brutisso Date: 2012-01-23 20:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6a78aa6ac1ff 7132311: G1: assert((s == klass->oop_size(this)) || (Universe::heap()->is_gc_active() && ((is_typeArray()... Summary: Move the check for when to call collect() to before we do a humongous object allocation Reviewed-by: stefank, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: 877914d90c57 Author: tonyp Date: 2012-01-24 17:08 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/877914d90c57 7132398: G1: java.lang.IllegalArgumentException: Invalid threshold: 9223372036854775807 > max (1073741824) Summary: Was not passing the right old pool max to the memory pool constructor in the fix for 7078465. Reviewed-by: brutisso, johnc ! src/share/vm/services/g1MemoryPool.cpp Changeset: d30fa85f9994 Author: johnc Date: 2012-01-12 00:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d30fa85f9994 6484965: G1: piggy-back liveness accounting phase on marking Summary: Remove the separate counting phase of concurrent marking by tracking the amount of marked bytes and the cards spanned by marked objects in marking task/worker thread local data structures, which are updated as individual objects are marked. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1EvacFailure.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: eff609af17d7 Author: tonyp Date: 2012-01-25 12:58 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/eff609af17d7 7127706: G1: re-enable survivors during the initial-mark pause Summary: Re-enable survivors during the initial-mark pause. Afterwards, the concurrent marking threads have to scan them and mark everything reachable from them. The next GC will have to wait for the survivors to be scanned. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1EvacFailure.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegion.inline.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp Changeset: a5244e07b761 Author: jcoomes Date: 2012-01-25 21:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a5244e07b761 7112413: JVM Crash, possibly GC-related Summary: disable UseAdaptiveSizePolicy with the CMS and ParNew Reviewed-by: johnc, brutisso ! src/share/vm/runtime/arguments.cpp Changeset: b4ebad3520bb Author: johnc Date: 2012-01-26 14:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b4ebad3520bb 7133038: G1: Some small profile based optimizations Summary: Some minor profile based optimizations. Reduce the number of branches and branch mispredicts by removing some virtual calls, through closure specalization, and refactoring some conditional statements. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp Changeset: 0a10d80352d5 Author: brutisso Date: 2012-01-27 09:04 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0a10d80352d5 Merge - src/os/bsd/vm/decoder_bsd.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp Changeset: af739d5ab23c Author: bpittore Date: 2012-01-21 23:02 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/af739d5ab23c 6972759: Step over not working after thrown exception and Pop Summary: reset jvmtithreadstate exception state after frame pop and forceearlyreturn processed Reviewed-by: minqi, dholmes, dlong Contributed-by: bill.pittore at oracle.com ! src/share/vm/prims/jvmtiThreadState.cpp ! src/share/vm/prims/jvmtiThreadState.hpp Changeset: 583b428aa858 Author: coleenp Date: 2012-01-23 17:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/583b428aa858 Merge - src/os/bsd/vm/decoder_bsd.cpp Changeset: d6660fedbab5 Author: phh Date: 2012-01-24 14:07 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d6660fedbab5 7126732: MAC: Require Mac OS X builds/tests for JPRT integrate jobs for HotSpot Summary: Modify jprt.properties to run OSX builds and tests. Reviewed-by: dcubed, kamg, ohair, dholmes Contributed-by: james.melvin at oracle.com ! make/jprt.properties Changeset: bf864f701a4a Author: dsamersoff Date: 2012-01-25 02:29 +0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bf864f701a4a 7066129: GarbageCollectorMXBean#getLastGcInfo leaks native memory Summary: Make GCStatInfo a resource object Reviewed-by: phh, coleenp ! src/share/vm/services/gcNotifier.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memoryManager.cpp ! src/share/vm/services/memoryManager.hpp Changeset: df88f58f3b61 Author: dsamersoff Date: 2012-01-24 20:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/df88f58f3b61 Merge Changeset: e8a4934564b2 Author: phh Date: 2012-01-24 19:33 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e8a4934564b2 7125793: MAC: test_gamma should always work Summary: Fix gamma launcher on Mac OS X and reconcile test_gamma script on Unix platforms Reviewed-by: dcubed, ohair, jcoomes, dholmes, ksrini Contributed-by: james.melvin at oracle.com ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/buildtree.make ! make/solaris/makefiles/buildtree.make ! src/os/bsd/vm/os_bsd.cpp ! src/os/posix/launcher/java_md.c Changeset: 78dadb7b16ab Author: phh Date: 2012-01-25 01:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/78dadb7b16ab Merge Changeset: d708a8cdd022 Author: kamg Date: 2012-01-25 10:08 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d708a8cdd022 Merge Changeset: 520830f632e7 Author: fparain Date: 2012-01-25 10:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/520830f632e7 7131346: Parsing of boolean arguments to diagnostic commands is broken Reviewed-by: dholmes, dcubed ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp Changeset: 24ec1a6d6ef3 Author: fparain Date: 2012-01-25 16:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/24ec1a6d6ef3 Merge Changeset: a42c07c38c47 Author: dsamersoff Date: 2012-01-25 21:10 +0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a42c07c38c47 7132515: Add dcmd to manage UnlockingCommercialFeature flag Summary: Added dcmd to unlock or check status of UnlockingCommercialFeature flag Reviewed-by: fparain, rottenha ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp + src/share/vm/services/diagnosticCommand_ext.hpp ! src/share/vm/services/diagnosticFramework.hpp ! src/share/vm/services/management.cpp Changeset: 6d00795f99a1 Author: dsamersoff Date: 2012-01-25 15:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6d00795f99a1 Merge Changeset: 6db63e782d3d Author: dsamersoff Date: 2012-01-25 18:58 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6db63e782d3d Merge Changeset: de268c8a8075 Author: phh Date: 2012-01-26 20:06 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/de268c8a8075 7082553: Interpret Thread.setPriority(Thread.MAX_PRIORITY) to mean FX60 on Solaris 10 and 11 Summary: Add CriticalPriority == MaxPriority+1 and enable scheduling class as well as thread priority to change on Solaris. Reviewed-by: dholmes, dcubed ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/osThread_solaris.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp Changeset: bf5da1648543 Author: kamg Date: 2012-01-27 10:42 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bf5da1648543 Merge ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/globals.hpp Changeset: 9e177d44b10f Author: amurillo Date: 2012-01-27 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9e177d44b10f Merge Changeset: a80fd4f45d7a Author: amurillo Date: 2012-01-27 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a80fd4f45d7a Added tag hs23-b12 for changeset 9e177d44b10f ! .hgtags From david.katleman at sun.com Thu Feb 2 01:07:20 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 02 Feb 2012 01:07:20 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b23 for changeset 95102fd33418 Message-ID: <20120202010720.17EC8472F3@hg.openjdk.java.net> Changeset: 7836655e2495 Author: katleman Date: 2012-01-26 18:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/7836655e2495 Added tag jdk8-b23 for changeset 95102fd33418 ! .hgtags From david.katleman at sun.com Thu Feb 2 01:07:27 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 02 Feb 2012 01:07:27 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b23 for changeset 25ce7a000487 Message-ID: <20120202010727.A8019472F4@hg.openjdk.java.net> Changeset: e0d90803439b Author: katleman Date: 2012-01-26 18:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/e0d90803439b Added tag jdk8-b23 for changeset 25ce7a000487 ! .hgtags From david.katleman at sun.com Thu Feb 2 01:07:38 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 02 Feb 2012 01:07:38 +0000 Subject: hg: jdk8/build/jdk: Added tag jdk8-b23 for changeset 54202e0148ec Message-ID: <20120202010749.06B18472F5@hg.openjdk.java.net> Changeset: 34029a0c69bb Author: katleman Date: 2012-01-26 18:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/34029a0c69bb Added tag jdk8-b23 for changeset 54202e0148ec ! .hgtags From david.katleman at sun.com Thu Feb 2 01:09:36 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 02 Feb 2012 01:09:36 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b23 for changeset 601ffcc6551d Message-ID: <20120202010939.13871472F6@hg.openjdk.java.net> Changeset: 6c9d21ca92c4 Author: katleman Date: 2012-01-26 18:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/6c9d21ca92c4 Added tag jdk8-b23 for changeset 601ffcc6551d ! .hgtags From david.holmes at oracle.com Thu Feb 2 02:33:08 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 02 Feb 2012 12:33:08 +1000 Subject: Review for 7141242: build-infra merge: Rename CPP->CXX and LINK->LD In-Reply-To: <4F29023A.9010905@oracle.com> References: <4F29023A.9010905@oracle.com> Message-ID: <4F29F5E4.4010309@oracle.com> Hi Erik, On 1/02/2012 7:13 PM, Erik Joelsson wrote: > http://cr.openjdk.java.net/~erikj/7141242/webrev.00/ > 240 lines changed: 0 ins; 19 del; 221 mod; 6363 unchg > > 7141242: build-infra merge: Rename CPP->CXX and LINK->LD Lots of CCC to CXX too :) One compatibility concern: anyone currently setting CPP_FLAGS or LINK_FLAGS etc, externally, will need to change to the new names. Probably worth sending a wider email (jdk8-dev?) when this gets pushed. --- make/bsd/makefiles/gcc.make - CPP = $(CXX) + CXX = $(CXX) infinite recursion or a tautology? :) --- make/*/makefiles/launcher.make Not your doing but this has highlighted some strange rules eg: + $(QUIETLY) $(CC) -g -o $@ -c $< -MMD $(LAUNCHERFLAGS) $(CXXFLAGS) C++ flags passed to C compiler? --- make/*/makefiles/rules.make -# $(CC) is the c compiler (cc/gcc), $(CCC) is the c++ compiler (CC/g++). -C_COMPILE = $(CC) $(CPPFLAGS) $(CFLAGS) -CC_COMPILE = $(CCC) $(CPPFLAGS) $(CFLAGS) +# $(CC) is the c compiler (cc/gcc), $(CXX) is the c++ compiler (CC/g++). +C_COMPILE = $(CC) $(CXXFLAGS) $(CFLAGS) +CC_COMPILE = $(CXX) $(CXXFLAGS) $(CFLAGS) The original code is confusing, given that CC is the C compiler it makes no sense that a C++ compile be called CC_COMPILE. Is it worth changing these to CC_COMPILE and CXX_COMPILE? Maybe a secondary cleanup? And again C++ flags passed to C compiler :( --- You missed a couple of scripts on Windows that use LINK_VER: windows/get_msc_ver.sh windows/build_vm_def.sh Cheers, David ----- > The build-infra project is starting to move into jdk8. For the hotspot > build to stay compatible with the changes, the naming of standard make > variables, like CC and LD need to be standardized across the build. > Currently hotspot names the C++ compiler CPP, which is traditionally the > name of the preprocessor. The windows nmake files name the linker LINK. > We would like to rename the C++ compiler to CXX and have the linker > named LD everywhere. > > Patch is tested with hsx/hotspot-rt. Testing with jdk7u is in progress. > > /Erik > > From peter.brunet at oracle.com Thu Feb 2 04:54:37 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Wed, 01 Feb 2012 22:54:37 -0600 Subject: building part of jdk 8 In-Reply-To: <4F1D7F39.8010502@oracle.com> References: <4F1D7F39.8010502@oracle.com> Message-ID: <4F2A170D.5020701@oracle.com> On 1/23/12 9:39 AM, Pete Brunet wrote: > In the past I was able to build part of jdk 8 but that is not currently > working although I am able to do a full 32 bit build. I've recently > moved from XP to W7 so my environment might not be set up quite right > yet. Here's what I do... > > // These are done in a bat file before I do any makes > set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 > set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include > set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 > set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 > set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin > set CLASSPATH= > set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; > set CYGWIN=nodosfilewarning > cd c:\Users\Pete\cygwin\bin > bash --login -i > > // These are done at the command line > eval `bin/vsvars.sh -v10 -32` > cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ > make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log > > The error I am getting is > > make: *** No rule to make target > `../../../build/windows-i586/btjars/compileproperties.jar', needed by > `compile_all_props'. Stop. When building below the top level, for some reason a partial build directory is being created in jdk8/jdk. When doing a full build from the top level the only build directory I see is the one in jdk8. It appears that ../../../build/... is using the build under jdk rather than the build under the top level. Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' make[2]: *** No rule to make target `javax/swing/JLabel', needed by `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. and when trying to build directly at .../jdk/make/javax/swing, i.e. make: *** No rule to make target `javax/swing/JLabel', needed by `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. In case it's helpful jdk/build contains these directories: bin btbins btclasses btjars classes gensrc include lib > > Since the above has windows-i586 instead of windows-i586-debug it looks > like I need to add another variable when invoking make. > > Pete From erik.joelsson at oracle.com Thu Feb 2 08:58:05 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 02 Feb 2012 09:58:05 +0100 Subject: Review for 7141242: build-infra merge: Rename CPP->CXX and LINK->LD In-Reply-To: <08B80E0F-2DB6-4180-85DA-F8101041A022@oracle.com> References: <4F29023A.9010905@oracle.com> <4F29F5E4.4010309@oracle.com> <4F2A408F.4060208@oracle.com> <08B80E0F-2DB6-4180-85DA-F8101041A022@oracle.com> Message-ID: <4F2A501D.3040304@oracle.com> Hello, I've intentionally left out all VS project files. I'm not sure but I suspect that CPP is some kind of standard name for the compiler in that context. I'm happy to hear I didn't mess up the project creation! /Erik On 2012-02-02 09:01, Staffan Larsen wrote: > Those generated files are Visual Studio projects for VS version 6 (I think). Really old stuff. I don't think these are used (nor is VS 6 supported), so we should eventually clean out that code. I wouldn't bother fixing it. > > /Staffan > > > On 2 feb 2012, at 08:51, Bengt Rutisson wrote: > >> Hi Erik, >> >> I have not looked closely at your changes, so don't consider this a review. What I did do was apply your patch and try to create a Visual Studio project with the create.bat script. That still works. Nice! >> >> One thing I noticed is that the ProjectCreator tool generates some files for the ADLC builds. These files still use the CPP name. Since it still works to create a project I don't know if this needs to be changed. But maybe it is good to be consistent. >> >> Here's where we use the CPP name: >> >> src\share\tools\ProjectCreator/WinGammaPlatformVC6.java: >> >> 68: printWriter.println("CPP=cl.exe"); >> 145: printWriter.println("# SUBTRACT CPP /YX /Yc /Yu"); >> 149: printWriter.println("# ADD CPP /Yc\"incls/_precompiled.incl\""); >> 210: rv.add("ADD CPP /nologo /MT /W3 /WX /GX /YX /Fr /FD /c"); >> 217: rv.add("ADD BASE CPP "+Util.prefixed_join(" /I ", includes, true)); >> 218: rv.add("ADD CPP "+Util.prefixed_join(" /I ", includes, true)); >> 219: rv.add("ADD BASE CPP "+Util.prefixed_join(" /D ", defines, true)); >> 220: rv.add("ADD CPP "+Util.prefixed_join(" /D ", defines, true)); >> 221: rv.add("ADD CPP /Yu\"incls/_precompiled.incl\""); >> 230: rv.add("ADD BASE CPP /MD"); >> 231: rv.add("ADD CPP /MD"); >> 252: rv.add("ADD BASE CPP /Gm /Zi /O"+opt); >> 272: rv.add("ADD CPP /O"+getOptFlag()); >> >> And these are the generated files: >> >> build\vs-amd64/compiler2/generated/ADLCompiler.dsp >> build\vs-amd64/tiered/generated/ADLCompiler.dsp >> >> >> Bengt >> >> On 2012-02-02 03:33, David Holmes wrote: >>> Hi Erik, >>> >>> On 1/02/2012 7:13 PM, Erik Joelsson wrote: >>>> http://cr.openjdk.java.net/~erikj/7141242/webrev.00/ >>>> 240 lines changed: 0 ins; 19 del; 221 mod; 6363 unchg >>>> >>>> 7141242: build-infra merge: Rename CPP->CXX and LINK->LD >>> Lots of CCC to CXX too :) >>> >>> One compatibility concern: anyone currently setting CPP_FLAGS or LINK_FLAGS etc, externally, will need to change to the new names. Probably worth sending a wider email (jdk8-dev?) when this gets pushed. >>> >>> --- >>> >>> make/bsd/makefiles/gcc.make >>> >>> - CPP = $(CXX) >>> + CXX = $(CXX) >>> >>> infinite recursion or a tautology? :) >>> >>> --- >>> >>> make/*/makefiles/launcher.make >>> >>> Not your doing but this has highlighted some strange rules eg: >>> >>> + $(QUIETLY) $(CC) -g -o $@ -c $< -MMD $(LAUNCHERFLAGS) $(CXXFLAGS) >>> >>> C++ flags passed to C compiler? >>> >>> --- >>> >>> make/*/makefiles/rules.make >>> >>> -# $(CC) is the c compiler (cc/gcc), $(CCC) is the c++ compiler (CC/g++). >>> -C_COMPILE = $(CC) $(CPPFLAGS) $(CFLAGS) >>> -CC_COMPILE = $(CCC) $(CPPFLAGS) $(CFLAGS) >>> +# $(CC) is the c compiler (cc/gcc), $(CXX) is the c++ compiler (CC/g++). >>> +C_COMPILE = $(CC) $(CXXFLAGS) $(CFLAGS) >>> +CC_COMPILE = $(CXX) $(CXXFLAGS) $(CFLAGS) >>> >>> The original code is confusing, given that CC is the C compiler it makes no sense that a C++ compile be called CC_COMPILE. Is it worth changing these to CC_COMPILE and CXX_COMPILE? Maybe a secondary cleanup? >>> >>> And again C++ flags passed to C compiler :( >>> >>> --- >>> >>> You missed a couple of scripts on Windows that use LINK_VER: >>> >>> windows/get_msc_ver.sh >>> windows/build_vm_def.sh >>> >>> Cheers, >>> David >>> ----- >>> >>> >>>> The build-infra project is starting to move into jdk8. For the hotspot >>>> build to stay compatible with the changes, the naming of standard make >>>> variables, like CC and LD need to be standardized across the build. >>>> Currently hotspot names the C++ compiler CPP, which is traditionally the >>>> name of the preprocessor. The windows nmake files name the linker LINK. >>>> We would like to rename the C++ compiler to CXX and have the linker >>>> named LD everywhere. >>>> >>>> Patch is tested with hsx/hotspot-rt. Testing with jdk7u is in progress. >>>> >>>> /Erik >>>> >>>> From erik.joelsson at oracle.com Thu Feb 2 09:59:17 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 02 Feb 2012 10:59:17 +0100 Subject: Review for 7141242: build-infra merge: Rename CPP->CXX and LINK->LD In-Reply-To: <4F29F5E4.4010309@oracle.com> References: <4F29023A.9010905@oracle.com> <4F29F5E4.4010309@oracle.com> Message-ID: <4F2A5E75.3010803@oracle.com> Hello David, Thanks for taking a look! New webrev here: http://cr.openjdk.java.net/~erikj/7141242/webrev.01/ JPRT job running. In this version a lot more has changes, see comments inline. On 2012-02-02 03:33, David Holmes wrote: > Hi Erik, > > Lots of CCC to CXX too :) > Right, it looked to me like CCC was used in rules.make by someone who didn't like using CPP for the C++ compiler. I couldn't see any need for an intermediate variable there, just extra confusion. > One compatibility concern: anyone currently setting CPP_FLAGS or > LINK_FLAGS etc, externally, will need to change to the new names. > Probably worth sending a wider email (jdk8-dev?) when this gets pushed. > Good point. We will need to send it out both to jdk8 and jdk7 consumers as this will (unfortunately) also hit 7u4. > make/bsd/makefiles/gcc.make > > - CPP = $(CXX) > + CXX = $(CXX) Thanks for spotting that. Fixed in new webrev. I think I've created variations on this patch too many times now. > > C++ flags passed to C compiler? > That looks weird yes. I don't dare changing it in the scope of this work though. > make/*/makefiles/rules.make > > -# $(CC) is the c compiler (cc/gcc), $(CCC) is the c++ compiler (CC/g++). > -C_COMPILE = $(CC) $(CPPFLAGS) $(CFLAGS) > -CC_COMPILE = $(CCC) $(CPPFLAGS) $(CFLAGS) > +# $(CC) is the c compiler (cc/gcc), $(CXX) is the c++ compiler (CC/g++). > +C_COMPILE = $(CC) $(CXXFLAGS) $(CFLAGS) > +CC_COMPILE = $(CXX) $(CXXFLAGS) $(CFLAGS) > > The original code is confusing, given that CC is the C compiler it > makes no sense that a C++ compile be called CC_COMPILE. Is it worth > changing these to CC_COMPILE and CXX_COMPILE? Maybe a secondary cleanup? > Either a secondary cleanup or all at once. The new webrev deals with these and the related COMPILE.CC. These changes aren't needed for build-infra but they sure make the code clearer. Basically: CC_COMPILE -> CXX_COMPILE C_COMPILE -> CC_COMPILE *.CC -> *.CXX *.c -> *.CC Removed *.cpp as they weren't used (* is COMPILE, GENASM, LINK, LINK_LIB and PREPROCESS) Question is, how far do we want to go? With these changes, we have consistent naming of CC and CXX in all cases that I have found. > You missed a couple of scripts on Windows that use LINK_VER: > > windows/get_msc_ver.sh > windows/build_vm_def.sh I skipped the scripts as it didn't seem needed for my purposes, but included them in the new webrev. /Erik From aph at redhat.com Thu Feb 2 12:46:48 2012 From: aph at redhat.com (Andrew Haley) Date: Thu, 02 Feb 2012 12:46:48 +0000 Subject: jsr instructions in OpenJDK 6 classes Message-ID: <4F2A85B8.5060109@redhat.com> I'm sorry for the cross-post, but I don't know exactly who to address this to. Just to save you time reading all this: the javac in OpenJDK 6 generates jsr instructions, but only if you compile a great many source files in one go. This affects rt.jar. I'm trying to find out why. If you build OpenJDK6 and do this: happy:jdk6 $ javap -c -bootclasspath build/linux-amd64/classes/ -classpath build/linux-amd64/classes/ java.util.concurrent/PriorityBlockingQueue | grep jsr 48: jsr 62 56: jsr 62 17: jsr 28 23: jsr 28 74: jsr 87 ... you'll see lots of jsr instructions. Why is this? It seems that if you compile the .java file this doesn't happen: happy:jdk6 $ ./build/linux-amd64/j2sdk-image/jre/bin/java -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:./build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -jar ./build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -g -source 1.5 -target 5 -encoding ascii -Xbootclasspath:/local/openjdk/jdk6/build/linux-amd64/classes -sourcepath /local/openjdk/jdk6/build/linux-amd64/gensrc:/local/openjdk/jdk6/jdk/src/solaris/classes:/local/openjdk/jdk6/jdk/src/share/classes -d /tmp /local/openjdk/jdk6/jdk/src/share/classes/java/util/concurrent/PriorityBlockingQueue.java happy:jdk6 $ javap -c -bootclasspath /tmp -classpath /tmp java.util.concurrent/PriorityBlockingQueue | grep jsr No jsr instructions this time. So, I try the compile again, but with the full list of classes in .classes.list: $ $ /local/openjdk/jdk6/build/linux-amd64/j2sdk-image/jre/bin/java -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -jar /local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -g -source 1.5 -target 5 -encoding ascii -Xbootclasspath:/local/openjdk/jdk6/build/linux-amd64/classes -sourcepath /local/openjdk/jdk6/build/linux-amd64/gensrc:/local/openjdk/jdk6/jdk/src/solaris/classes:/local/openjdk/jdk6/jdk/src/share/classes -d /tmp @/local/openjdk/jdk6/build/linux-amd64/tmp/java/java.lang/java/.classes.list $ javap -c -bootclasspath /tmp -classpath /tmp java.util.concurrent/PriorityBlockingQueue | grep jsr | head -5 48: jsr 62 56: jsr 62 17: jsr 28 23: jsr 28 74: jsr 87 Lots of jsrs. Now the really weird bit: if I edit classes.list to contain only a small subset of the files and run the command again, $ grep java.util.concurrent /local/openjdk/jdk6/build/linux-amd64/tmp/java/java.lang/java/.classes.list > classes.concurrent $ /local/openjdk/jdk6/build/linux-amd64/j2sdk-image/jre/bin/java -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -jar /local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -g -source 1.5 -target 5 -encoding ascii -Xbootclasspath:/local/openjdk/jdk6/build/linux-amd64/classes -sourcepath /local/openjdk/jdk6/build/linux-amd64/gensrc:/local/openjdk/jdk6/jdk/src/solaris/classes:/local/openjdk/jdk6/jdk/src/share/classes -d /tmp @classes.concurrent $ javap -c -bootclasspath /tmp -classpath /tmp java.util.concurrent/PriorityBlockingQueue | grep jsr | head -5 ... no jsr instructions. I realize that OpenJDK 6 is nearing EOL, but this behaviour is so bizarre that I'd appreciate some input! Thanks, Andrew. From fredrik.ohrstrom at oracle.com Thu Feb 2 13:22:31 2012 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Thu, 02 Feb 2012 14:22:31 +0100 Subject: Is anyone able to build on Win 7 In-Reply-To: <066F07A9-2F32-4435-812D-7E40E38D792F@oracle.com> References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> <4F297F78.6080306@oracle.com> <066F07A9-2F32-4435-812D-7E40E38D792F@oracle.com> Message-ID: <4F2A8E17.4050904@oracle.com> 2012-02-02 00:10, Kelly O'Hair skrev: > I don't know what the current state is. The CYGWIN community seemed pretty adamant that they wanted > to stamp out all drive letter pathnames. As I understood it, it's not so much the version of make.exe, but how > the make.exe was built. Some kind of 'allow drive letter paths' option needs to be turned on when building. > I created a neat solution to get around this drive letter problem in the new build-infra/jdk8 (jdk7) forest. The configure script compiles an executable called uncygdrive.exe The make variables that point to tools that do not understand /cygdrive paths, like CC:=cl.exe and JAVA:=java.exe are rewritten to: CC:=uncygdrive.exe cl.exe JAVA:=uncygdrive.exe java.exe As you can guess, the uncygdrive command parses the command line and rewrites any /cygdrive/c/ into just c:/ (likewise for any other drive letter). It even enters into @files and creates a temporary file with adjusted content. Then it execs the new adjusted command line. Works great and the Makefiles become much simpler since you can just use /cygdrive everywhere! A more important problem is the dreaded slowdown of cygwin on 64 bit windows. It is believed to be the fork simulation gone haywaire when dealing with 64 bit address space, but what do I know..... //Fredrik From peter.brunet at oracle.com Thu Feb 2 16:27:58 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Thu, 02 Feb 2012 10:27:58 -0600 Subject: unable to build JLabel Message-ID: <4F2AB98E.1000205@oracle.com> After editing JLabel.java, deleting my build directory, and starting a full build I am getting make[5]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' make[5]: *** No rule to make target `javax/swing/JLabel', needed by `C:/OpenJDK/jdk8/build/windows-i586/../windows-i586-fastdebug/tmp/com/javax.swing/.classes.list'. Stop. My build process was: // These are done in a bat file before I do any makes set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin set CLASSPATH= set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; set CYGWIN=nodosfilewarning cd c:\Users\Pete\cygwin\bin bash --login -i // These are done at the cygwin command line eval `bin/vsvars.sh -v10 -32` cd /cygdrive/c/OpenJDK/jdk8 make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true NO_DOCS=true fastdebug_build 2>&1 | tee build.log From joe.darcy at oracle.com Thu Feb 2 16:52:12 2012 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 02 Feb 2012 08:52:12 -0800 Subject: jsr instructions in OpenJDK 6 classes In-Reply-To: <4F2A85B8.5060109@redhat.com> References: <4F2A85B8.5060109@redhat.com> Message-ID: <4F2ABF3C.5080400@oracle.com> Hi Andrew, Whether or not the jsr instruction is used is -target specific; version 50.0 class files from -target 6 and later do not support jsr/ret since stackmaps are used. I haven't delved into the OpenJDK 6 build before writing this email, but I suspect some of the classes in rt.jar are compiled with -target 5, but javac in OpenJDK 6 defaults to -target 6 so you wouldn't see jsr instructions from a stock compile. Sufficiently recent versions of javap will emit the classfile version under the -verbose flag. HTH, -Joe [1] "Source, target, class file version decoder ring," http://blogs.oracle.com/darcy/entry/source_target_class_file_version On 02/02/2012 04:46 AM, Andrew Haley wrote: > I'm sorry for the cross-post, but I don't know exactly who to > address this to. > > Just to save you time reading all this: the javac in OpenJDK 6 > generates jsr instructions, but only if you compile a great many > source files in one go. This affects rt.jar. I'm trying to find > out why. > > If you build OpenJDK6 and do this: > > happy:jdk6 $ javap -c -bootclasspath build/linux-amd64/classes/ -classpath build/linux-amd64/classes/ java.util.concurrent/PriorityBlockingQueue | grep jsr > 48: jsr 62 > 56: jsr 62 > 17: jsr 28 > 23: jsr 28 > 74: jsr 87 > ... > > you'll see lots of jsr instructions. Why is this? It seems that if > you compile the .java file this doesn't happen: > > happy:jdk6 $ ./build/linux-amd64/j2sdk-image/jre/bin/java -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:./build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -jar ./build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -g -source 1.5 -target 5 -encoding ascii -Xbootclasspath:/local/openjdk/jdk6/build/linux-amd64/classes -sourcepath /local/openjdk/jdk6/build/linux-amd64/gensrc:/local/openjdk/jdk6/jdk/src/solaris/classes:/local/openjdk/jdk6/jdk/src/share/classes -d /tmp > /local/openjdk/jdk6/jdk/src/share/classes/java/util/concurrent/PriorityBlockingQueue.java > > happy:jdk6 $ javap -c -bootclasspath /tmp -classpath /tmp java.util.concurrent/PriorityBlockingQueue | grep jsr > > No jsr instructions this time. > > So, I try the compile again, but with the full list of classes in .classes.list: > > $ $ /local/openjdk/jdk6/build/linux-amd64/j2sdk-image/jre/bin/java -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -jar /local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -g -source 1.5 -target 5 -encoding ascii -Xbootclasspath:/local/openjdk/jdk6/build/linux-amd64/classes -sourcepath > /local/openjdk/jdk6/build/linux-amd64/gensrc:/local/openjdk/jdk6/jdk/src/solaris/classes:/local/openjdk/jdk6/jdk/src/share/classes -d /tmp @/local/openjdk/jdk6/build/linux-amd64/tmp/java/java.lang/java/.classes.list > > $ javap -c -bootclasspath /tmp -classpath /tmp java.util.concurrent/PriorityBlockingQueue | grep jsr | head -5 > 48: jsr 62 > 56: jsr 62 > 17: jsr 28 > 23: jsr 28 > 74: jsr 87 > > Lots of jsrs. > > Now the really weird bit: if I edit classes.list to contain only a > small subset of the files and run the command again, > > $ grep java.util.concurrent /local/openjdk/jdk6/build/linux-amd64/tmp/java/java.lang/java/.classes.list> classes.concurrent > > $ /local/openjdk/jdk6/build/linux-amd64/j2sdk-image/jre/bin/java -Xmx896m -Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m -Xbootclasspath/p:/local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -jar /local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -g -source 1.5 -target 5 -encoding ascii -Xbootclasspath:/local/openjdk/jdk6/build/linux-amd64/classes -sourcepath > /local/openjdk/jdk6/build/linux-amd64/gensrc:/local/openjdk/jdk6/jdk/src/solaris/classes:/local/openjdk/jdk6/jdk/src/share/classes -d /tmp @classes.concurrent > > $ javap -c -bootclasspath /tmp -classpath /tmp java.util.concurrent/PriorityBlockingQueue | grep jsr | head -5 > > ... no jsr instructions. > > I realize that OpenJDK 6 is nearing EOL, but this behaviour is so bizarre > that I'd appreciate some input! > > Thanks, > Andrew. From aph at redhat.com Thu Feb 2 16:59:24 2012 From: aph at redhat.com (Andrew Haley) Date: Thu, 02 Feb 2012 16:59:24 +0000 Subject: jsr instructions in OpenJDK 6 classes In-Reply-To: <4F2ABF3C.5080400@oracle.com> References: <4F2A85B8.5060109@redhat.com> <4F2ABF3C.5080400@oracle.com> Message-ID: <4F2AC0EC.3000801@redhat.com> On 02/02/2012 04:52 PM, Joe Darcy wrote: > stackmaps are used. > > I haven't delved into the OpenJDK 6 build before writing this email, but > I suspect some of the classes in rt.jar are compiled with -target 5, but > javac in OpenJDK 6 defaults to -target 6 so you wouldn't see jsr > instructions from a stock compile. Well, I'm using the same compile command so that doesn't quite explain it, but never mind. Why are some of the classes in rt.jar are compiled with -target 5 ? Would it hurt simply to remove that? Andrew. From joe.darcy at oracle.com Thu Feb 2 17:08:10 2012 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 02 Feb 2012 09:08:10 -0800 Subject: jsr instructions in OpenJDK 6 classes In-Reply-To: <4F2AC0EC.3000801@redhat.com> References: <4F2A85B8.5060109@redhat.com> <4F2ABF3C.5080400@oracle.com> <4F2AC0EC.3000801@redhat.com> Message-ID: <4F2AC2FA.60309@oracle.com> On 02/02/2012 08:59 AM, Andrew Haley wrote: > On 02/02/2012 04:52 PM, Joe Darcy wrote: >> stackmaps are used. >> >> I haven't delved into the OpenJDK 6 build before writing this email, but >> I suspect some of the classes in rt.jar are compiled with -target 5, but >> javac in OpenJDK 6 defaults to -target 6 so you wouldn't see jsr >> instructions from a stock compile. > Well, I'm using the same compile command so that doesn't quite explain it, > but never mind. > > Why are some of the classes in rt.jar are compiled with -target 5 ? > Would it hurt simply to remove that? > > Andrew. I haven't had to poke around this part of the system for a while, but some classes were compiled as part of bootstrapping under the previous platform version language level. I don't recall offhand the earliest system OpenJDK 6 supports using as a bootstrap. I don't think compiling the classes in rt.jar with -target 5 or -target 6 should make much difference, but probably wouldn't offer much benefit either. (The classes in rt.jar aren't verified anyway so the faster verifier doesn't help.) -Joe From peter.brunet at oracle.com Thu Feb 2 20:17:09 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Thu, 02 Feb 2012 14:17:09 -0600 Subject: Fwd: unable to build JLabel In-Reply-To: <4F2AB98E.1000205@oracle.com> References: <4F2AB98E.1000205@oracle.com> Message-ID: <4F2AEF45.3030000@oracle.com> The problem was caused by the existence of ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is Windows' scheme for copies.) -------- Original Message -------- Subject: unable to build JLabel Date: Thu, 02 Feb 2012 10:27:58 -0600 From: Pete Brunet Reply-To: peter.brunet at oracle.com To: build-dev After editing JLabel.java, deleting my build directory, and starting a full build I am getting make[5]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' make[5]: *** No rule to make target `javax/swing/JLabel', needed by `C:/OpenJDK/jdk8/build/windows-i586/../windows-i586-fastdebug/tmp/com/javax.swing/.classes.list'. Stop. My build process was: // These are done in a bat file before I do any makes set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin set CLASSPATH= set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; set CYGWIN=nodosfilewarning cd c:\Users\Pete\cygwin\bin bash --login -i // These are done at the cygwin command line eval `bin/vsvars.sh -v10 -32` cd /cygdrive/c/OpenJDK/jdk8 make ARCH_DATA_MODEL=32 ALLOW_DOWNLOADS=true NO_DOCS=true fastdebug_build 2>&1 | tee build.log -------------- next part -------------- An HTML attachment was scrubbed... URL: From peter.brunet at oracle.com Thu Feb 2 20:19:16 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Thu, 02 Feb 2012 14:19:16 -0600 Subject: building part of jdk 8 In-Reply-To: <4F2A170D.5020701@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> Message-ID: <4F2AEFC4.5010907@oracle.com> On 2/1/12 10:54 PM, Pete Brunet wrote: > On 1/23/12 9:39 AM, Pete Brunet wrote: >> In the past I was able to build part of jdk 8 but that is not currently >> working although I am able to do a full 32 bit build. I've recently >> moved from XP to W7 so my environment might not be set up quite right >> yet. Here's what I do... >> >> // These are done in a bat file before I do any makes >> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >> set CLASSPATH= >> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >> set CYGWIN=nodosfilewarning >> cd c:\Users\Pete\cygwin\bin >> bash --login -i >> >> // These are done at the command line >> eval `bin/vsvars.sh -v10 -32` >> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >> >> The error I am getting is >> >> make: *** No rule to make target >> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >> `compile_all_props'. Stop. > When building below the top level, for some reason a partial build > directory is being created in jdk8/jdk. When doing a full build from > the top level the only build directory I see is the one in jdk8. It > appears that ../../../build/... is using the build under jdk rather than > the build under the top level. > > Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: > > make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' > make[2]: *** No rule to make target `javax/swing/JLabel', needed by > `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. > > and when trying to build directly at .../jdk/make/javax/swing, i.e. > > make: *** No rule to make target `javax/swing/JLabel', needed by > `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. The JLabel issue was caused by the existence of ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is Windows' scheme for copies.). However, that wouldn't explain the use of a build directory under jdk (instead of under the top level), i.e. my original problem might have been caused by using the wrong build dir: make: *** No rule to make target `../../../build/windows-i586/btjars/compileproperties.jar', needed by `compile_all_props'. Stop. > > In case it's helpful jdk/build contains these directories: > bin > btbins > btclasses > btjars > classes > gensrc > include > lib >> Since the above has windows-i586 instead of windows-i586-debug it looks >> like I need to add another variable when invoking make. >> >> Pete From kelly.ohair at oracle.com Thu Feb 2 21:22:59 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 2 Feb 2012 13:22:59 -0800 Subject: Is anyone able to build on Win 7 In-Reply-To: <4F2A8E17.4050904@oracle.com> References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> <4F297F78.6080306@oracle.com> <066F07A9-2F32-4435-812D-7E40E38D792F@oracle.com> <4F2A8E17.4050904@oracle.com> Message-ID: On Feb 2, 2012, at 5:22 AM, Fredrik ?hrstr?m wrote: > 2012-02-02 00:10, Kelly O'Hair skrev: >> I don't know what the current state is. The CYGWIN community seemed pretty adamant that they wanted >> to stamp out all drive letter pathnames. As I understood it, it's not so much the version of make.exe, but how >> the make.exe was built. Some kind of 'allow drive letter paths' option needs to be turned on when building. >> > > I created a neat solution to get around this drive letter problem in the > new build-infra/jdk8 (jdk7) forest. > > The configure script compiles an executable called uncygdrive.exe > > The make variables that point to tools that do not understand /cygdrive > paths, like CC:=cl.exe and JAVA:=java.exe are rewritten to: > > CC:=uncygdrive.exe cl.exe > JAVA:=uncygdrive.exe java.exe > > As you can guess, the uncygdrive command parses the command line and > rewrites any /cygdrive/c/ into just c:/ (likewise for any other drive > letter). It even enters into @files and creates a temporary file with > adjusted content. Then it execs the new adjusted command line. > > Works great and the Makefiles become much simpler since you can just use > /cygdrive everywhere! Excellent. This assumes that the CYGWIN user has not used mount points, e.g. mount C:/foobar to /foobar but we can deal with that when the time comes. I like your solution. > > A more important problem is the dreaded slowdown of cygwin on 64 bit > windows. It is believed to be the fork simulation gone haywaire when > dealing with 64 bit address space, but what do I know..... Yeah. It's bad enough that it could be slower because it is a VM, could be slowed down by AV On-Access scanning, or is just a slow Windows file system. So many things can slow a Windows system down. :^( And my long term plan was to do both 32bit and 64bit builds on Windows 64bit so we need fewer systems, and we use 64bit OS's that can have more CPU and RAM for scaling up the build. :^( If we had a really good Windows System Performance expert somewhere out there, I bet he/she could find some ways for us to make this Windows X64 CYGWIN situation faster. I'm not that person, and I've run out of ideas. :^( In the meantime I'm still using MKS. :^( -kto > > //Fredrik > From kelly.ohair at oracle.com Thu Feb 2 21:29:11 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 2 Feb 2012 13:29:11 -0800 Subject: jsr instructions in OpenJDK 6 classes In-Reply-To: <4F2AC0EC.3000801@redhat.com> References: <4F2A85B8.5060109@redhat.com> <4F2ABF3C.5080400@oracle.com> <4F2AC0EC.3000801@redhat.com> Message-ID: <8B38E6F7-C058-46E1-82DC-D28F43B66540@oracle.com> On Feb 2, 2012, at 8:59 AM, Andrew Haley wrote: > On 02/02/2012 04:52 PM, Joe Darcy wrote: >> stackmaps are used. >> >> I haven't delved into the OpenJDK 6 build before writing this email, but >> I suspect some of the classes in rt.jar are compiled with -target 5, but >> javac in OpenJDK 6 defaults to -target 6 so you wouldn't see jsr >> instructions from a stock compile. > > Well, I'm using the same compile command so that doesn't quite explain it, > but never mind. > > Why are some of the classes in rt.jar are compiled with -target 5 ? > Would it hurt simply to remove that? > > Andrew. Not sure about OpenJDK6. But I thought ALL the classes in JDK6 were compiled with -target 5. As I recall the big issue was the StackMapTable attributes in -target 6 classes. Many of the classfile reader/writers had issues having to re-create the StackMaptable attribute and I vaguely recall some performance issues, and maybe some rt.jar size issues, and maybe some pack200 issues, etc. etc. It was, how do you say it..... a 'can o worms' ???:^( -kto From keith.mcguigan at oracle.com Thu Feb 2 23:56:27 2012 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Thu, 02 Feb 2012 18:56:27 -0500 Subject: Request for review: hotspot/jprt.properties [S] Message-ID: <4F2B22AB.2090807@oracle.com> Hello, Here's a webrev for changing the default JPRT release value for hotspot to jdk8. It can still be overridden by the -release jdk7 during JPRT submission. I also removed references to pre-7 releases and other unused value (jdk7b107, jdk7temp). The targets and parameters for jdk7 & jdk8 are identical for now, but it's probably good to keep the distinction in the file so we can update jdk8 targets independently as development continues. http://cr.openjdk.java.net/~kamg/7069991/webrev.00/ Thanks for any reviews. -- - Keith From paul.hohensee at oracle.com Fri Feb 3 00:42:41 2012 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Thu, 02 Feb 2012 19:42:41 -0500 Subject: Request for review: hotspot/jprt.properties [S] In-Reply-To: <4F2B22AB.2090807@oracle.com> References: <4F2B22AB.2090807@oracle.com> Message-ID: <4F2B2D81.1020406@oracle.com> Looks good. Paul On 2/2/12 6:56 PM, Keith McGuigan wrote: > Hello, > > Here's a webrev for changing the default JPRT release value for > hotspot to jdk8. It can still be overridden by the -release jdk7 > during JPRT submission. I also removed references to pre-7 releases > and other unused value (jdk7b107, jdk7temp). > > The targets and parameters for jdk7 & jdk8 are identical for now, but > it's probably good to keep the distinction in the file so we can > update jdk8 targets independently as development continues. > > http://cr.openjdk.java.net/~kamg/7069991/webrev.00/ > > Thanks for any reviews. > > -- > - Keith From david.holmes at oracle.com Fri Feb 3 01:43:15 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 03 Feb 2012 11:43:15 +1000 Subject: Review for 7141242: build-infra merge: Rename CPP->CXX and LINK->LD In-Reply-To: <4F2A5E75.3010803@oracle.com> References: <4F29023A.9010905@oracle.com> <4F29F5E4.4010309@oracle.com> <4F2A5E75.3010803@oracle.com> Message-ID: <4F2B3BB3.60503@oracle.com> Hi Erik, I think this has gone as far as it needs for now. My visual inspection of these changes looks okay. My lingering concern is the impact on external scripts etc that may set some of the renamed flags. Even I have a build script that sets things so that I don't get complaints about using the wrong compiler version on Solaris. David On 2/02/2012 7:59 PM, Erik Joelsson wrote: > Hello David, > > Thanks for taking a look! > > New webrev here: http://cr.openjdk.java.net/~erikj/7141242/webrev.01/ > JPRT job running. > > In this version a lot more has changes, see comments inline. > > On 2012-02-02 03:33, David Holmes wrote: >> Hi Erik, >> >> Lots of CCC to CXX too :) >> > Right, it looked to me like CCC was used in rules.make by someone who > didn't like using CPP for the C++ compiler. I couldn't see any need for > an intermediate variable there, just extra confusion. > >> One compatibility concern: anyone currently setting CPP_FLAGS or >> LINK_FLAGS etc, externally, will need to change to the new names. >> Probably worth sending a wider email (jdk8-dev?) when this gets pushed. >> > Good point. We will need to send it out both to jdk8 and jdk7 consumers > as this will (unfortunately) also hit 7u4. >> make/bsd/makefiles/gcc.make >> >> - CPP = $(CXX) >> + CXX = $(CXX) > Thanks for spotting that. Fixed in new webrev. I think I've created > variations on this patch too many times now. >> >> C++ flags passed to C compiler? >> > That looks weird yes. I don't dare changing it in the scope of this work > though. >> make/*/makefiles/rules.make >> >> -# $(CC) is the c compiler (cc/gcc), $(CCC) is the c++ compiler (CC/g++). >> -C_COMPILE = $(CC) $(CPPFLAGS) $(CFLAGS) >> -CC_COMPILE = $(CCC) $(CPPFLAGS) $(CFLAGS) >> +# $(CC) is the c compiler (cc/gcc), $(CXX) is the c++ compiler (CC/g++). >> +C_COMPILE = $(CC) $(CXXFLAGS) $(CFLAGS) >> +CC_COMPILE = $(CXX) $(CXXFLAGS) $(CFLAGS) >> >> The original code is confusing, given that CC is the C compiler it >> makes no sense that a C++ compile be called CC_COMPILE. Is it worth >> changing these to CC_COMPILE and CXX_COMPILE? Maybe a secondary cleanup? >> > Either a secondary cleanup or all at once. The new webrev deals with > these and the related COMPILE.CC. These changes aren't needed for > build-infra but they sure make the code clearer. Basically: > > CC_COMPILE -> CXX_COMPILE > C_COMPILE -> CC_COMPILE > *.CC -> *.CXX > *.c -> *.CC > Removed *.cpp as they weren't used > (* is COMPILE, GENASM, LINK, LINK_LIB and PREPROCESS) > > Question is, how far do we want to go? With these changes, we have > consistent naming of CC and CXX in all cases that I have found. > >> You missed a couple of scripts on Windows that use LINK_VER: >> >> windows/get_msc_ver.sh >> windows/build_vm_def.sh > I skipped the scripts as it didn't seem needed for my purposes, but > included them in the new webrev. > > /Erik From david.holmes at oracle.com Fri Feb 3 02:01:01 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 03 Feb 2012 12:01:01 +1000 Subject: Request for review: hotspot/jprt.properties [S] In-Reply-To: <4F2B22AB.2090807@oracle.com> References: <4F2B22AB.2090807@oracle.com> Message-ID: <4F2B3FDD.50104@oracle.com> Hi Keith, On 3/02/2012 9:56 AM, Keith McGuigan wrote: > Here's a webrev for changing the default JPRT release value for hotspot > to jdk8. It can still be overridden by the -release jdk7 during JPRT > submission. I also removed references to pre-7 releases and other unused > value (jdk7b107, jdk7temp). Are we sure there is no reason to leave any pre-7 release info here? Otherwise changes seem okay. David > The targets and parameters for jdk7 & jdk8 are identical for now, but > it's probably good to keep the distinction in the file so we can update > jdk8 targets independently as development continues. > > http://cr.openjdk.java.net/~kamg/7069991/webrev.00/ > > Thanks for any reviews. > > -- > - Keith From david.holmes at oracle.com Fri Feb 3 03:13:28 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 03 Feb 2012 13:13:28 +1000 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B1C6C.4020208@oracle.com> References: <4F2B1C6C.4020208@oracle.com> Message-ID: <4F2B50D8.6010701@oracle.com> Hi Jim, I added build-dev to the cc as this is of general interest. Actually before doing this a heads-up should go out to all jdk8-dev I think. One question: are there any cross-compilation issues with building this? I'm assuming not but want to check. Okay two questions :) : do you know when this will get modularized and show up in the jigsaw repositories? Thanks, David On 3/02/2012 9:29 AM, Jim Holmlund wrote: > This is just a heads up that we are in the process of adding > http://asm.ow2.org/ > > to jdk 8 as a new top level repo. This new repo contains the asm source > code, with a few mods that are needed to build/run it in our > environment. The new repo also contains the build files needed to > participate in our forest builds. The main building is done by the asm > build.xml, with a Makefile wrapper around that in order to participate > in the forest build. This Makefile dynamically renames the asm packages > by prepending 'org.openjdk'. > > The forest build handles the asm repo in the same was as the other > repos, eg, corba. The asm repo is built just after langtools, and then > the resulting .class files are known in the jdk build and are put into > rt.jar. > > The changes for this are: > - These files are modified/added: > M Makefile > M make/Defs-internal.gmk > M make/README.pre-components > A make/asm-rules.gmk > M make/jdk-rules.gmk > M make/sanity-rules.gmk > M make/scripts/hgforest.sh > > - the new asm repo is built just after langtools > > - these files in the jdk repo are modified/added: > M THIRD_PARTY_README > M make/Makefile > M make/common/Release.gmk > M make/common/internal/ImportComponents.gmk > M make/common/shared/Defs-control.gmk > M make/common/shared/Defs.gmk > M make/common/shared/Sanity-Settings.gmk > A make/common/internal/Defs-asm.gmk > A test/org/openjdk/org/objectweb/asm/OmitCommons.java > A test/org/openjdk/org/objectweb/asm/OmitOptimizer.java > A test/org/openjdk/org/objectweb/asm/OmitTreeAnalysis.java > A test/org/openjdk/org/objectweb/asm/OmitUtil.java > A test/org/openjdk/org/objectweb/asm/OmitXml.java > A test/org/openjdk/org/objectweb/asm/RequiredAsmClasses.java > > These changes have not been reviewed and thus are subject to change. > Hopefully, this work can be finished in the next couple weeks. But where > have we heard that before. > > Please let me know if you have any questions or need more info. > > - jjh > > > From mandy.chung at oracle.com Fri Feb 3 03:33:12 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 02 Feb 2012 19:33:12 -0800 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B50D8.6010701@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> Message-ID: <4F2B5578.2080005@oracle.com> On 2/2/2012 7:13 PM, David Holmes wrote: > Okay two questions :) : do you know when this will get modularized and > show up in the jigsaw repositories? FWIW. We have been sync'ing up jigsaw forest with jdk8 periodically and hope to do it in a regular basis. It's currently sync'ed with jdk8-b23. When asm shows up in jdk8 promoted build, I hope to pull it down and do the merge in the following week or two depending on how it'll be modularized and their dependencies. Mandy From mandy.chung at oracle.com Fri Feb 3 04:04:56 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 02 Feb 2012 20:04:56 -0800 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B55BA.7010500@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> Message-ID: <4F2B5CE8.6050808@oracle.com> Great. That would give a good starting point. Mandy On 2/2/2012 7:34 PM, Brian Goetz wrote: > The main ASM distribution is broken into 5 jars, based on how people > tend to use it; this is probably a good starting candidate for module > boundaries. > > On 2/2/2012 10:33 PM, Mandy Chung wrote: >> On 2/2/2012 7:13 PM, David Holmes wrote: >>> Okay two questions :) : do you know when this will get modularized and >>> show up in the jigsaw repositories? >> >> FWIW. We have been sync'ing up jigsaw forest with jdk8 periodically and >> hope to do it in a regular basis. It's currently sync'ed with jdk8-b23. >> When asm shows up in jdk8 promoted build, I hope to pull it down and do >> the merge in the following week or two depending on how it'll be >> modularized and their dependencies. >> >> Mandy From david.holmes at oracle.com Fri Feb 3 04:29:45 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 03 Feb 2012 14:29:45 +1000 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B55BA.7010500@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> Message-ID: <4F2B62B9.7040903@oracle.com> On 3/02/2012 1:34 PM, Brian Goetz wrote: > The main ASM distribution is broken into 5 jars, based on how people > tend to use it; this is probably a good starting candidate for module > boundaries. That will be an interesting testcase for jigsaw as well I think. David > On 2/2/2012 10:33 PM, Mandy Chung wrote: >> On 2/2/2012 7:13 PM, David Holmes wrote: >>> Okay two questions :) : do you know when this will get modularized and >>> show up in the jigsaw repositories? >> >> FWIW. We have been sync'ing up jigsaw forest with jdk8 periodically and >> hope to do it in a regular basis. It's currently sync'ed with jdk8-b23. >> When asm shows up in jdk8 promoted build, I hope to pull it down and do >> the merge in the following week or two depending on how it'll be >> modularized and their dependencies. >> >> Mandy From Dmitry.Samersoff at oracle.com Fri Feb 3 05:08:53 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Fri, 03 Feb 2012 09:08:53 +0400 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B50D8.6010701@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> Message-ID: <4F2B6BE5.5080802@oracle.com> Jim, Do you plan to remove one already existing in the rt.jar (it comes from jax-ws)? com.sun.xml.internal.ws.org.objectweb.asm Do you have permission to include one particular version or plan to sync it regularly? -Dmitry On 2012-02-03 07:13, David Holmes wrote: > Hi Jim, > > I added build-dev to the cc as this is of general interest. Actually > before doing this a heads-up should go out to all jdk8-dev I think. > > One question: are there any cross-compilation issues with building this? > I'm assuming not but want to check. > > Okay two questions :) : do you know when this will get modularized and > show up in the jigsaw repositories? > > Thanks, > David > > On 3/02/2012 9:29 AM, Jim Holmlund wrote: >> This is just a heads up that we are in the process of adding >> http://asm.ow2.org/ >> >> to jdk 8 as a new top level repo. This new repo contains the asm source >> code, with a few mods that are needed to build/run it in our >> environment. The new repo also contains the build files needed to >> participate in our forest builds. The main building is done by the asm >> build.xml, with a Makefile wrapper around that in order to participate >> in the forest build. This Makefile dynamically renames the asm packages >> by prepending 'org.openjdk'. >> >> The forest build handles the asm repo in the same was as the other >> repos, eg, corba. The asm repo is built just after langtools, and then >> the resulting .class files are known in the jdk build and are put into >> rt.jar. >> >> The changes for this are: >> - These files are modified/added: >> M Makefile >> M make/Defs-internal.gmk >> M make/README.pre-components >> A make/asm-rules.gmk >> M make/jdk-rules.gmk >> M make/sanity-rules.gmk >> M make/scripts/hgforest.sh >> >> - the new asm repo is built just after langtools >> >> - these files in the jdk repo are modified/added: >> M THIRD_PARTY_README >> M make/Makefile >> M make/common/Release.gmk >> M make/common/internal/ImportComponents.gmk >> M make/common/shared/Defs-control.gmk >> M make/common/shared/Defs.gmk >> M make/common/shared/Sanity-Settings.gmk >> A make/common/internal/Defs-asm.gmk >> A test/org/openjdk/org/objectweb/asm/OmitCommons.java >> A test/org/openjdk/org/objectweb/asm/OmitOptimizer.java >> A test/org/openjdk/org/objectweb/asm/OmitTreeAnalysis.java >> A test/org/openjdk/org/objectweb/asm/OmitUtil.java >> A test/org/openjdk/org/objectweb/asm/OmitXml.java >> A test/org/openjdk/org/objectweb/asm/RequiredAsmClasses.java >> >> These changes have not been reviewed and thus are subject to change. >> Hopefully, this work can be finished in the next couple weeks. But where >> have we heard that before. >> >> Please let me know if you have any questions or need more info. >> >> - jjh >> >> >> -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From Alan.Bateman at oracle.com Fri Feb 3 11:46:59 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 03 Feb 2012 11:46:59 +0000 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B5CE8.6050808@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> <4F2B5CE8.6050808@oracle.com> Message-ID: <4F2BC933.3010705@oracle.com> On 03/02/2012 04:04, Mandy Chung wrote: > Great. That would give a good starting point. > > Mandy > > On 2/2/2012 7:34 PM, Brian Goetz wrote: >> The main ASM distribution is broken into 5 jars, based on how people >> tend to use it; this is probably a good starting candidate for module >> boundaries. Brian - I also think we'll need a brief overview on usage too. In particular, is the plan to run ASM at runtime and is this the plan for the long term too or will it be replaced by something in the core to generate the classes as runtime? (I'm been too busy to track many of the details of lambda). -Alan From Alan.Bateman at oracle.com Fri Feb 3 11:48:26 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 03 Feb 2012 11:48:26 +0000 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B6BE5.5080802@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B6BE5.5080802@oracle.com> Message-ID: <4F2BC98A.1090106@oracle.com> On 03/02/2012 05:08, Dmitry Samersoff wrote: > Jim, > > Do you plan to remove one already existing in the > rt.jar (it comes from jax-ws)? > > com.sun.xml.internal.ws.org.objectweb.asm > > Do you have permission to include one particular version or > plan to sync it regularly? > > -Dmitry > This is a good point. Once ASM is bedded down then it doesn't make any sense to continue to include the ASM subset in the JAX-WS bundle. -Alan. From keith.mcguigan at oracle.com Fri Feb 3 11:55:37 2012 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Fri, 03 Feb 2012 06:55:37 -0500 Subject: Request for review: hotspot/jprt.properties [S] In-Reply-To: <4F2B3FDD.50104@oracle.com> References: <4F2B22AB.2090807@oracle.com> <4F2B3FDD.50104@oracle.com> Message-ID: <4F2BCB39.60806@oracle.com> On 2/2/2012 9:01 PM, David Holmes wrote: > On 3/02/2012 9:56 AM, Keith McGuigan wrote: >> Here's a webrev for changing the default JPRT release value for hotspot >> to jdk8. It can still be overridden by the -release jdk7 during JPRT >> submission. I also removed references to pre-7 releases and other unused >> value (jdk7b107, jdk7temp). > > Are we sure there is no reason to leave any pre-7 release info here? As far as I know, hsx will be used only for jdk7 & jdk8 releases, anything pre-7 has it's own separate hotspot repository (or it will, if needed). -- - Keith From fredrik.ohrstrom at oracle.com Fri Feb 3 13:45:45 2012 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Fri, 03 Feb 2012 14:45:45 +0100 Subject: Review for 7141242: build-infra merge: Rename CPP->CXX and LINK->LD In-Reply-To: <4F2B3BB3.60503@oracle.com> References: <4F29023A.9010905@oracle.com> <4F29F5E4.4010309@oracle.com> <4F2A5E75.3010803@oracle.com> <4F2B3BB3.60503@oracle.com> Message-ID: <4F2BE509.3030006@oracle.com> 2012-02-03 02:43, David Holmes skrev: > Hi Erik, > > I think this has gone as far as it needs for now. My visual inspection > of these changes looks okay. > > My lingering concern is the impact on external scripts etc that may set > some of the renamed flags. Even I have a build script that sets things > so that I don't get complaints about using the wrong compiler version on > Solaris. > > David The changes looks good. Erik, can you create a "hg export" patch and put with the webrev so that David can commit for us as quickly as possible? Thanks! //Fredrik From Alan.Bateman at oracle.com Fri Feb 3 15:47:54 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 03 Feb 2012 15:47:54 +0000 Subject: Adding asm to JDK 8 In-Reply-To: <4F2BF826.9080100@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> <4F2B5CE8.6050808@oracle.com> <4F2BC933.3010705@oracle.com> <4F2BF826.9080100@oracle.com> Message-ID: <4F2C01AA.8010006@oracle.com> On 03/02/2012 15:07, Brian Goetz wrote: > The current plan is to use ASM long-term to generate classes at > runtime. Now, it is possible that "something better will come along" > (perhaps needed functionality will be provided by JSR-292 in the > future) but we're not banking on this. > > The EE team has also asked that we officially include ASM in the base > distribution, so they can get rid of the seven copies of ASM that are > floating around in Glassfish. > > My thinking was that the base module would have a private > (non-exporting) dependency on ASM, so that even though the language > runtime uses ASM, users only get it when they ask for it. While Jigsaw can handle circular dependencies it might be a bit odd for the base module to have a non-optional dependency on another module. Having asm potentially loaded by a different module class loader may also require consideration. -Alan. From miroslav.kos at oracle.com Wed Feb 1 15:13:39 2012 From: miroslav.kos at oracle.com (Miroslav Kos) Date: Wed, 01 Feb 2012 16:13:39 +0100 Subject: 7140918: Remove dependency on apt and com.sun.mirror API In-Reply-To: <4F27A17A.1020809@oracle.com> References: <4F26B283.8090103@oracle.com> <4F273AD3.5070207@oracle.com> <4F274012.7090904@oracle.com> <4F274146.9050103@oracle.com> <4F27A17A.1020809@oracle.com> Message-ID: <4F2956A3.1030808@oracle.com> Hi Alan, do you have any update about approving the changeset? The jaxws bundle is already in place, so there should be nothing blocking us from the final step(?) We already have PIT Certificate from QA: https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=13491649 Regards Miran On 31.1.2012 9:08, Alan Bateman wrote: > On 31/01/2012 01:17, David Holmes wrote: >> : >> Okay. So as part of this will the new zip file be installed before >> the change gets pushed? > Yes, that's right. > > -Alan From brian.goetz at oracle.com Fri Feb 3 03:34:18 2012 From: brian.goetz at oracle.com (Brian Goetz) Date: Thu, 02 Feb 2012 22:34:18 -0500 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B5578.2080005@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> Message-ID: <4F2B55BA.7010500@oracle.com> The main ASM distribution is broken into 5 jars, based on how people tend to use it; this is probably a good starting candidate for module boundaries. On 2/2/2012 10:33 PM, Mandy Chung wrote: > On 2/2/2012 7:13 PM, David Holmes wrote: >> Okay two questions :) : do you know when this will get modularized and >> show up in the jigsaw repositories? > > FWIW. We have been sync'ing up jigsaw forest with jdk8 periodically and > hope to do it in a regular basis. It's currently sync'ed with jdk8-b23. > When asm shows up in jdk8 promoted build, I hope to pull it down and do > the merge in the following week or two depending on how it'll be > modularized and their dependencies. > > Mandy From brian.goetz at oracle.com Fri Feb 3 15:07:18 2012 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 03 Feb 2012 10:07:18 -0500 Subject: Adding asm to JDK 8 In-Reply-To: <4F2BC933.3010705@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> <4F2B5CE8.6050808@oracle.com> <4F2BC933.3010705@oracle.com> Message-ID: <4F2BF826.9080100@oracle.com> The current plan is to use ASM long-term to generate classes at runtime. Now, it is possible that "something better will come along" (perhaps needed functionality will be provided by JSR-292 in the future) but we're not banking on this. The EE team has also asked that we officially include ASM in the base distribution, so they can get rid of the seven copies of ASM that are floating around in Glassfish. My thinking was that the base module would have a private (non-exporting) dependency on ASM, so that even though the language runtime uses ASM, users only get it when they ask for it. For now the packages have been renamed but once we modularize ASM we may not need to do that any more. On 2/3/2012 6:46 AM, Alan Bateman wrote: > On 03/02/2012 04:04, Mandy Chung wrote: >> Great. That would give a good starting point. >> >> Mandy >> >> On 2/2/2012 7:34 PM, Brian Goetz wrote: >>> The main ASM distribution is broken into 5 jars, based on how people >>> tend to use it; this is probably a good starting candidate for module >>> boundaries. > Brian - I also think we'll need a brief overview on usage too. In > particular, is the plan to run ASM at runtime and is this the plan for > the long term too or will it be replaced by something in the core to > generate the classes as runtime? (I'm been too busy to track many of the > details of lambda). > > -Alan From brian.goetz at oracle.com Fri Feb 3 15:08:07 2012 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 03 Feb 2012 10:08:07 -0500 Subject: Adding asm to JDK 8 In-Reply-To: <4F2BC98A.1090106@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B6BE5.5080802@oracle.com> <4F2BC98A.1090106@oracle.com> Message-ID: <4F2BF857.7050600@oracle.com> The hope there is that JAX-WS can convert over to / certify on the bundled ASM, and then we can get rid of their old copy. Same process as removing APT; they have to do some work first. On 2/3/2012 6:48 AM, Alan Bateman wrote: > On 03/02/2012 05:08, Dmitry Samersoff wrote: >> Jim, >> >> Do you plan to remove one already existing in the >> rt.jar (it comes from jax-ws)? >> >> com.sun.xml.internal.ws.org.objectweb.asm >> >> Do you have permission to include one particular version or >> plan to sync it regularly? >> >> -Dmitry >> > This is a good point. Once ASM is bedded down then it doesn't make any > sense to continue to include the ASM subset in the JAX-WS bundle. > > -Alan. > From paul.hohensee at oracle.com Fri Feb 3 15:58:47 2012 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Fri, 03 Feb 2012 10:58:47 -0500 Subject: Request for review: hotspot/jprt.properties [S] In-Reply-To: <4F2BCB39.60806@oracle.com> References: <4F2B22AB.2090807@oracle.com> <4F2B3FDD.50104@oracle.com> <4F2BCB39.60806@oracle.com> Message-ID: <4F2C0437.90104@oracle.com> Correct. Sustaining owns the pre-7 releases. Paul On 2/3/12 6:55 AM, Keith McGuigan wrote: > > > On 2/2/2012 9:01 PM, David Holmes wrote: >> On 3/02/2012 9:56 AM, Keith McGuigan wrote: >>> Here's a webrev for changing the default JPRT release value for hotspot >>> to jdk8. It can still be overridden by the -release jdk7 during JPRT >>> submission. I also removed references to pre-7 releases and other >>> unused >>> value (jdk7b107, jdk7temp). >> >> Are we sure there is no reason to leave any pre-7 release info here? > > As far as I know, hsx will be used only for jdk7 & jdk8 releases, > anything pre-7 has it's own separate hotspot repository (or it will, > if needed). > > -- > - Keith > From philip.race at oracle.com Fri Feb 3 17:11:21 2012 From: philip.race at oracle.com (Phil Race) Date: Fri, 03 Feb 2012 09:11:21 -0800 Subject: Adding asm to JDK 8 In-Reply-To: <4F2BC933.3010705@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> <4F2B5CE8.6050808@oracle.com> <4F2BC933.3010705@oracle.com> Message-ID: <4F2C1539.70502@oracle.com> Oh, its for lambda! Thank you for mentioning that. I had no clue what we needed this thing for :-), may be it was obvious to the rest of the world but not to me and I was surprised it wasn't mentioned in Jim's email. But does it really need its own new repo ? I think there needs to be a discussion on this as I'd like to see *fewer* of them. How enormous is this thing ? Can't be that big if there's a copy buried in jax-ws -phil. On 2/3/2012 3:46 AM, Alan Bateman wrote: > On 03/02/2012 04:04, Mandy Chung wrote: >> Great. That would give a good starting point. >> >> Mandy >> >> On 2/2/2012 7:34 PM, Brian Goetz wrote: >>> The main ASM distribution is broken into 5 jars, based on how people >>> tend to use it; this is probably a good starting candidate for >>> module boundaries. > Brian - I also think we'll need a brief overview on usage too. In > particular, is the plan to run ASM at runtime and is this the plan for > the long term too or will it be replaced by something in the core to > generate the classes as runtime? (I'm been too busy to track many of > the details of lambda). > > -Alan From Dmitry.Samersoff at oracle.com Fri Feb 3 17:34:20 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Fri, 03 Feb 2012 21:34:20 +0400 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B55BA.7010500@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> Message-ID: <4F2C1A9C.7080304@oracle.com> Brian, Does any body has a justification to include all of them. ASM has core and couple of interfaces around it. Subset included now to jaxp workspace is enough to do all necessary things. -Dmitry On 2012-02-03 07:34, Brian Goetz wrote: > The main ASM distribution is broken into 5 jars, based on how people > tend to use it; this is probably a good starting candidate for module > boundaries. > > On 2/2/2012 10:33 PM, Mandy Chung wrote: >> On 2/2/2012 7:13 PM, David Holmes wrote: >>> Okay two questions :) : do you know when this will get modularized and >>> show up in the jigsaw repositories? >> >> FWIW. We have been sync'ing up jigsaw forest with jdk8 periodically and >> hope to do it in a regular basis. It's currently sync'ed with jdk8-b23. >> When asm shows up in jdk8 promoted build, I hope to pull it down and do >> the merge in the following week or two depending on how it'll be >> modularized and their dependencies. >> >> Mandy -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From brian.goetz at oracle.com Fri Feb 3 17:38:24 2012 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 03 Feb 2012 12:38:24 -0500 Subject: Adding asm to JDK 8 In-Reply-To: <4F2C1539.70502@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> <4F2B5CE8.6050808@oracle.com> <4F2BC933.3010705@oracle.com> <4F2C1539.70502@oracle.com> Message-ID: <4F2C1B90.5090801@oracle.com> Lambda was the proximate driving force. EE was also a contributor; as I mentioned earlier, Glassfish includes half a dozen versions of ASM, some of different vintages, because of how it is componentized. We can probably get rid of the extra repo once we can make it into a module. On 2/3/2012 12:11 PM, Phil Race wrote: > Oh, its for lambda! Thank you for mentioning that. I had no clue what we > needed this thing for :-), may be it was obvious to the rest of the world > but not to me and I was surprised it wasn't mentioned in Jim's email. > > But does it really need its own new repo ? I think there needs to be a > discussion on this > as I'd like to see *fewer* of them. How enormous is this thing ? > > Can't be that big if there's a copy buried in jax-ws > > -phil. > > On 2/3/2012 3:46 AM, Alan Bateman wrote: >> On 03/02/2012 04:04, Mandy Chung wrote: >>> Great. That would give a good starting point. >>> >>> Mandy >>> >>> On 2/2/2012 7:34 PM, Brian Goetz wrote: >>>> The main ASM distribution is broken into 5 jars, based on how people >>>> tend to use it; this is probably a good starting candidate for >>>> module boundaries. >> Brian - I also think we'll need a brief overview on usage too. In >> particular, is the plan to run ASM at runtime and is this the plan for >> the long term too or will it be replaced by something in the core to >> generate the classes as runtime? (I'm been too busy to track many of >> the details of lambda). >> >> -Alan > From philip.race at oracle.com Fri Feb 3 17:43:37 2012 From: philip.race at oracle.com (Phil Race) Date: Fri, 03 Feb 2012 09:43:37 -0800 Subject: Adding asm to JDK 8 In-Reply-To: <4F2C1B90.5090801@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> <4F2B5CE8.6050808@oracle.com> <4F2BC933.3010705@oracle.com> <4F2C1539.70502@oracle.com> <4F2C1B90.5090801@oracle.com> Message-ID: <4F2C1CC9.90804@oracle.com> On 2/3/2012 9:38 AM, Brian Goetz wrote: > Lambda was the proximate driving force. EE was also a contributor; as > I mentioned earlier, Glassfish includes half a dozen versions of ASM, > some of different vintages, because of how it is componentized. > > We can probably get rid of the extra repo once we can make it into a > module. Why does it need to be a module before that can happen ? So far as I can tell initially binary goes into rt.jar either way (source in shared or separate repo). -phil. > > On 2/3/2012 12:11 PM, Phil Race wrote: >> Oh, its for lambda! Thank you for mentioning that. I had no clue what we >> needed this thing for :-), may be it was obvious to the rest of the >> world >> but not to me and I was surprised it wasn't mentioned in Jim's email. >> >> But does it really need its own new repo ? I think there needs to be a >> discussion on this >> as I'd like to see *fewer* of them. How enormous is this thing ? >> >> Can't be that big if there's a copy buried in jax-ws >> >> -phil. >> >> On 2/3/2012 3:46 AM, Alan Bateman wrote: >>> On 03/02/2012 04:04, Mandy Chung wrote: >>>> Great. That would give a good starting point. >>>> >>>> Mandy >>>> >>>> On 2/2/2012 7:34 PM, Brian Goetz wrote: >>>>> The main ASM distribution is broken into 5 jars, based on how people >>>>> tend to use it; this is probably a good starting candidate for >>>>> module boundaries. >>> Brian - I also think we'll need a brief overview on usage too. In >>> particular, is the plan to run ASM at runtime and is this the plan for >>> the long term too or will it be replaced by something in the core to >>> generate the classes as runtime? (I'm been too busy to track many of >>> the details of lambda). >>> >>> -Alan >> From brian.goetz at oracle.com Fri Feb 3 17:45:24 2012 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 03 Feb 2012 12:45:24 -0500 Subject: Adding asm to JDK 8 In-Reply-To: <4F2C1A9C.7080304@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> <4F2C1A9C.7080304@oracle.com> Message-ID: <4F2C1D34.3040900@oracle.com> The official ASM distro has six JARs: core: processing classes based on Class{Reader,Writer} visitors tree: alternate API for processing classes; used in more advanced applications util: debugging utilities, such as the checking and tracing visitors commons: random contributions, some of which are pretty useful (e.g., InstructionAdapter, SimpleRemapper) xml: not even sure analysis: a bytecode interpreter toolkit Obviously people use core all the time. Everyone uses util and common pieces sometimes; the util pieces are more commonly used at development rather than runtime. I use the tree stuff not for code generation in lambda, but I do use it in the 'indify' tool, for example. I've not found any use for the analysis package yet. Overall I think these boundaries are pretty reasonable ones. On 2/3/2012 12:34 PM, Dmitry Samersoff wrote: > Brian, > > Does any body has a justification to include all of them. > > ASM has core and couple of interfaces around it. Subset included now to > jaxp workspace is enough to do all necessary things. > > -Dmitry > > > On 2012-02-03 07:34, Brian Goetz wrote: >> The main ASM distribution is broken into 5 jars, based on how people >> tend to use it; this is probably a good starting candidate for module >> boundaries. >> >> On 2/2/2012 10:33 PM, Mandy Chung wrote: >>> On 2/2/2012 7:13 PM, David Holmes wrote: >>>> Okay two questions :) : do you know when this will get modularized and >>>> show up in the jigsaw repositories? >>> >>> FWIW. We have been sync'ing up jigsaw forest with jdk8 periodically and >>> hope to do it in a regular basis. It's currently sync'ed with jdk8-b23. >>> When asm shows up in jdk8 promoted build, I hope to pull it down and do >>> the merge in the following week or two depending on how it'll be >>> modularized and their dependencies. >>> >>> Mandy > > From james.holmlund at oracle.com Fri Feb 3 19:03:23 2012 From: james.holmlund at oracle.com (Jim Holmlund) Date: Fri, 03 Feb 2012 11:03:23 -0800 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B50D8.6010701@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> Message-ID: <4F2C2F7B.1060100@oracle.com> On 2/2/2012 7:13 PM, David Holmes wrote: > Hi Jim, > > I added build-dev to the cc as this is of general interest. Actually before doing this a heads-up > should go out to all jdk8-dev I think. > > One question: are there any cross-compilation issues with building this? I'm assuming not but want > to check. I don't know of any such issues. What sort of build scenario are you thinking of? - jjh > > Okay two questions :) : do you know when this will get modularized and show up in the jigsaw > repositories? > > Thanks, > David > > On 3/02/2012 9:29 AM, Jim Holmlund wrote: >> This is just a heads up that we are in the process of adding >> http://asm.ow2.org/ >> >> to jdk 8 as a new top level repo. This new repo contains the asm source >> code, with a few mods that are needed to build/run it in our >> environment. The new repo also contains the build files needed to >> participate in our forest builds. The main building is done by the asm >> build.xml, with a Makefile wrapper around that in order to participate >> in the forest build. This Makefile dynamically renames the asm packages >> by prepending 'org.openjdk'. >> >> The forest build handles the asm repo in the same was as the other >> repos, eg, corba. The asm repo is built just after langtools, and then >> the resulting .class files are known in the jdk build and are put into >> rt.jar. >> >> The changes for this are: >> - These files are modified/added: >> M Makefile >> M make/Defs-internal.gmk >> M make/README.pre-components >> A make/asm-rules.gmk >> M make/jdk-rules.gmk >> M make/sanity-rules.gmk >> M make/scripts/hgforest.sh >> >> - the new asm repo is built just after langtools >> >> - these files in the jdk repo are modified/added: >> M THIRD_PARTY_README >> M make/Makefile >> M make/common/Release.gmk >> M make/common/internal/ImportComponents.gmk >> M make/common/shared/Defs-control.gmk >> M make/common/shared/Defs.gmk >> M make/common/shared/Sanity-Settings.gmk >> A make/common/internal/Defs-asm.gmk >> A test/org/openjdk/org/objectweb/asm/OmitCommons.java >> A test/org/openjdk/org/objectweb/asm/OmitOptimizer.java >> A test/org/openjdk/org/objectweb/asm/OmitTreeAnalysis.java >> A test/org/openjdk/org/objectweb/asm/OmitUtil.java >> A test/org/openjdk/org/objectweb/asm/OmitXml.java >> A test/org/openjdk/org/objectweb/asm/RequiredAsmClasses.java >> >> These changes have not been reviewed and thus are subject to change. >> Hopefully, this work can be finished in the next couple weeks. But where >> have we heard that before. >> >> Please let me know if you have any questions or need more info. >> >> - jjh >> >> >> From james.holmlund at oracle.com Fri Feb 3 19:07:21 2012 From: james.holmlund at oracle.com (Jim Holmlund) Date: Fri, 03 Feb 2012 11:07:21 -0800 Subject: Adding asm to JDK 8 In-Reply-To: <4F2B6BE5.5080802@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B6BE5.5080802@oracle.com> Message-ID: <4F2C3069.9090008@oracle.com> On 2/2/2012 9:08 PM, Dmitry Samersoff wrote: > Jim, > > Do you plan to remove one already existing in the > rt.jar (it comes from jax-ws)? > > com.sun.xml.internal.ws.org.objectweb.asm > I don't plan to remove that myself, but jaxws will be notified and urged to remove their version. > Do you have permission to include one particular version or > plan to sync it regularly? I plan to sync it from time to time. - jjh > > -Dmitry > > On 2012-02-03 07:13, David Holmes wrote: >> Hi Jim, >> >> I added build-dev to the cc as this is of general interest. Actually >> before doing this a heads-up should go out to all jdk8-dev I think. >> >> One question: are there any cross-compilation issues with building this? >> I'm assuming not but want to check. >> >> Okay two questions :) : do you know when this will get modularized and >> show up in the jigsaw repositories? >> >> Thanks, >> David >> >> On 3/02/2012 9:29 AM, Jim Holmlund wrote: >>> This is just a heads up that we are in the process of adding >>> http://asm.ow2.org/ >>> >>> to jdk 8 as a new top level repo. This new repo contains the asm source >>> code, with a few mods that are needed to build/run it in our >>> environment. The new repo also contains the build files needed to >>> participate in our forest builds. The main building is done by the asm >>> build.xml, with a Makefile wrapper around that in order to participate >>> in the forest build. This Makefile dynamically renames the asm packages >>> by prepending 'org.openjdk'. >>> >>> The forest build handles the asm repo in the same was as the other >>> repos, eg, corba. The asm repo is built just after langtools, and then >>> the resulting .class files are known in the jdk build and are put into >>> rt.jar. >>> >>> The changes for this are: >>> - These files are modified/added: >>> M Makefile >>> M make/Defs-internal.gmk >>> M make/README.pre-components >>> A make/asm-rules.gmk >>> M make/jdk-rules.gmk >>> M make/sanity-rules.gmk >>> M make/scripts/hgforest.sh >>> >>> - the new asm repo is built just after langtools >>> >>> - these files in the jdk repo are modified/added: >>> M THIRD_PARTY_README >>> M make/Makefile >>> M make/common/Release.gmk >>> M make/common/internal/ImportComponents.gmk >>> M make/common/shared/Defs-control.gmk >>> M make/common/shared/Defs.gmk >>> M make/common/shared/Sanity-Settings.gmk >>> A make/common/internal/Defs-asm.gmk >>> A test/org/openjdk/org/objectweb/asm/OmitCommons.java >>> A test/org/openjdk/org/objectweb/asm/OmitOptimizer.java >>> A test/org/openjdk/org/objectweb/asm/OmitTreeAnalysis.java >>> A test/org/openjdk/org/objectweb/asm/OmitUtil.java >>> A test/org/openjdk/org/objectweb/asm/OmitXml.java >>> A test/org/openjdk/org/objectweb/asm/RequiredAsmClasses.java >>> >>> These changes have not been reviewed and thus are subject to change. >>> Hopefully, this work can be finished in the next couple weeks. But where >>> have we heard that before. >>> >>> Please let me know if you have any questions or need more info. >>> >>> - jjh >>> >>> >>> > > From james.holmlund at oracle.com Sat Feb 4 00:58:11 2012 From: james.holmlund at oracle.com (Jim Holmlund) Date: Fri, 03 Feb 2012 16:58:11 -0800 Subject: Adding asm to JDK 8 In-Reply-To: <4F2C1539.70502@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2B5578.2080005@oracle.com> <4F2B55BA.7010500@oracle.com> <4F2B5CE8.6050808@oracle.com> <4F2BC933.3010705@oracle.com> <4F2C1539.70502@oracle.com> Message-ID: <4F2C82A3.8080908@oracle.com> On 2/3/2012 9:11 AM, Phil Race wrote: > Oh, its for lambda! Thank you for mentioning that. I had no clue what we > needed this thing for :-), may be it was obvious to the rest of the world > but not to me and I was surprised it wasn't mentioned in Jim's email. > Sorry about that. I thought I was jut giving a heads up to the infrastructure group. I planned on sending out more info to a wider group later. > But does it really need its own new repo ? I think there needs to be a discussion on this > as I'd like to see *fewer* of them. How enormous is this thing ? > Sure we can discuss it. What are is the process for such a discussion - eg, who gets to make the final decision? At the moment, I am busy with a bug but I'll get back to you... > Can't be that big if there's a copy buried in jax-ws The current size of the repo is about 18MB (includes .hg/ and the working files, including doc, eclipse stuff, web stuff, tests, ...). I don't know if we need the extraneous stuff or not. The classes.jar that gets built from the asm repo and imported into rt.jar is about 270KB. But this doesn't include all the items Brian mentioned (eg, it doesn't include the util and common pkgs that Brian mentioned), so changes might occur here. - jjh > > -phil. > > On 2/3/2012 3:46 AM, Alan Bateman wrote: >> On 03/02/2012 04:04, Mandy Chung wrote: >>> Great. That would give a good starting point. >>> >>> Mandy >>> >>> On 2/2/2012 7:34 PM, Brian Goetz wrote: >>>> The main ASM distribution is broken into 5 jars, based on how people tend to use it; this is >>>> probably a good starting candidate for module boundaries. >> Brian - I also think we'll need a brief overview on usage too. In particular, is the plan to run >> ASM at runtime and is this the plan for the long term too or will it be replaced by something in >> the core to generate the classes as runtime? (I'm been too busy to track many of the details of >> lambda). >> >> -Alan > From david.holmes at oracle.com Mon Feb 6 08:04:23 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 06 Feb 2012 18:04:23 +1000 Subject: Adding asm to JDK 8 In-Reply-To: <4F2C2F7B.1060100@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2C2F7B.1060100@oracle.com> Message-ID: <4F2F8987.40806@oracle.com> On 4/02/2012 5:03 AM, Jim Holmlund wrote: > On 2/2/2012 7:13 PM, David Holmes wrote: >> I added build-dev to the cc as this is of general interest. Actually >> before doing this a heads-up should go out to all jdk8-dev I think. >> >> One question: are there any cross-compilation issues with building >> this? I'm assuming not but want to check. > I don't know of any such issues. What sort of build scenario are you > thinking of? When we cross-compile we have to distinguish between tools executed on the build host and those built for the target host. If ASM is pure Java (is it?) then there should not be any such concerns - as long as it doesn't build something in phase N that it has to execute in phase M>N. David ----- > - jjh >> >> Okay two questions :) : do you know when this will get modularized and >> show up in the jigsaw repositories? >> >> Thanks, >> David >> >> On 3/02/2012 9:29 AM, Jim Holmlund wrote: >>> This is just a heads up that we are in the process of adding >>> http://asm.ow2.org/ >>> >>> to jdk 8 as a new top level repo. This new repo contains the asm source >>> code, with a few mods that are needed to build/run it in our >>> environment. The new repo also contains the build files needed to >>> participate in our forest builds. The main building is done by the asm >>> build.xml, with a Makefile wrapper around that in order to participate >>> in the forest build. This Makefile dynamically renames the asm packages >>> by prepending 'org.openjdk'. >>> >>> The forest build handles the asm repo in the same was as the other >>> repos, eg, corba. The asm repo is built just after langtools, and then >>> the resulting .class files are known in the jdk build and are put into >>> rt.jar. >>> >>> The changes for this are: >>> - These files are modified/added: >>> M Makefile >>> M make/Defs-internal.gmk >>> M make/README.pre-components >>> A make/asm-rules.gmk >>> M make/jdk-rules.gmk >>> M make/sanity-rules.gmk >>> M make/scripts/hgforest.sh >>> >>> - the new asm repo is built just after langtools >>> >>> - these files in the jdk repo are modified/added: >>> M THIRD_PARTY_README >>> M make/Makefile >>> M make/common/Release.gmk >>> M make/common/internal/ImportComponents.gmk >>> M make/common/shared/Defs-control.gmk >>> M make/common/shared/Defs.gmk >>> M make/common/shared/Sanity-Settings.gmk >>> A make/common/internal/Defs-asm.gmk >>> A test/org/openjdk/org/objectweb/asm/OmitCommons.java >>> A test/org/openjdk/org/objectweb/asm/OmitOptimizer.java >>> A test/org/openjdk/org/objectweb/asm/OmitTreeAnalysis.java >>> A test/org/openjdk/org/objectweb/asm/OmitUtil.java >>> A test/org/openjdk/org/objectweb/asm/OmitXml.java >>> A test/org/openjdk/org/objectweb/asm/RequiredAsmClasses.java >>> >>> These changes have not been reviewed and thus are subject to change. >>> Hopefully, this work can be finished in the next couple weeks. But where >>> have we heard that before. >>> >>> Please let me know if you have any questions or need more info. >>> >>> - jjh >>> >>> >>> From erik.joelsson at oracle.com Mon Feb 6 12:45:42 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 06 Feb 2012 13:45:42 +0100 Subject: Review for 7141242: build-infra merge: Rename CPP->CXX and LINK->LD In-Reply-To: <4F2B3BB3.60503@oracle.com> References: <4F29023A.9010905@oracle.com> <4F29F5E4.4010309@oracle.com> <4F2A5E75.3010803@oracle.com> <4F2B3BB3.60503@oracle.com> Message-ID: <4F2FCB76.4080203@oracle.com> New webrev posted: http://cr.openjdk.java.net/~erikj/7141242/webrev.02/ Fredriks change for ccache added this line to all vm.make files: vm_version.o: CPPFLAGS += ${JRE_VERSION} which had to be replaced by vm_version.o: CXXFLAGS += ${JRE_VERSION} /Erik On 2012-02-03 02:43, David Holmes wrote: > Hi Erik, > > I think this has gone as far as it needs for now. My visual inspection > of these changes looks okay. > > My lingering concern is the impact on external scripts etc that may > set some of the renamed flags. Even I have a build script that sets > things so that I don't get complaints about using the wrong compiler > version on Solaris. > > David > > On 2/02/2012 7:59 PM, Erik Joelsson wrote: >> Hello David, >> >> Thanks for taking a look! >> >> New webrev here: http://cr.openjdk.java.net/~erikj/7141242/webrev.01/ >> JPRT job running. >> >> In this version a lot more has changes, see comments inline. >> >> On 2012-02-02 03:33, David Holmes wrote: >>> Hi Erik, >>> >>> Lots of CCC to CXX too :) >>> >> Right, it looked to me like CCC was used in rules.make by someone who >> didn't like using CPP for the C++ compiler. I couldn't see any need for >> an intermediate variable there, just extra confusion. >> >>> One compatibility concern: anyone currently setting CPP_FLAGS or >>> LINK_FLAGS etc, externally, will need to change to the new names. >>> Probably worth sending a wider email (jdk8-dev?) when this gets pushed. >>> >> Good point. We will need to send it out both to jdk8 and jdk7 consumers >> as this will (unfortunately) also hit 7u4. >>> make/bsd/makefiles/gcc.make >>> >>> - CPP = $(CXX) >>> + CXX = $(CXX) >> Thanks for spotting that. Fixed in new webrev. I think I've created >> variations on this patch too many times now. >>> >>> C++ flags passed to C compiler? >>> >> That looks weird yes. I don't dare changing it in the scope of this work >> though. >>> make/*/makefiles/rules.make >>> >>> -# $(CC) is the c compiler (cc/gcc), $(CCC) is the c++ compiler >>> (CC/g++). >>> -C_COMPILE = $(CC) $(CPPFLAGS) $(CFLAGS) >>> -CC_COMPILE = $(CCC) $(CPPFLAGS) $(CFLAGS) >>> +# $(CC) is the c compiler (cc/gcc), $(CXX) is the c++ compiler >>> (CC/g++). >>> +C_COMPILE = $(CC) $(CXXFLAGS) $(CFLAGS) >>> +CC_COMPILE = $(CXX) $(CXXFLAGS) $(CFLAGS) >>> >>> The original code is confusing, given that CC is the C compiler it >>> makes no sense that a C++ compile be called CC_COMPILE. Is it worth >>> changing these to CC_COMPILE and CXX_COMPILE? Maybe a secondary >>> cleanup? >>> >> Either a secondary cleanup or all at once. The new webrev deals with >> these and the related COMPILE.CC. These changes aren't needed for >> build-infra but they sure make the code clearer. Basically: >> >> CC_COMPILE -> CXX_COMPILE >> C_COMPILE -> CC_COMPILE >> *.CC -> *.CXX >> *.c -> *.CC >> Removed *.cpp as they weren't used >> (* is COMPILE, GENASM, LINK, LINK_LIB and PREPROCESS) >> >> Question is, how far do we want to go? With these changes, we have >> consistent naming of CC and CXX in all cases that I have found. >> >>> You missed a couple of scripts on Windows that use LINK_VER: >>> >>> windows/get_msc_ver.sh >>> windows/build_vm_def.sh >> I skipped the scripts as it didn't seem needed for my purposes, but >> included them in the new webrev. >> >> /Erik From james.holmlund at oracle.com Mon Feb 6 16:46:35 2012 From: james.holmlund at oracle.com (Jim Holmlund) Date: Mon, 06 Feb 2012 08:46:35 -0800 Subject: Adding asm to JDK 8 In-Reply-To: <4F2F8987.40806@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2C2F7B.1060100@oracle.com> <4F2F8987.40806@oracle.com> Message-ID: <4F3003EB.6030105@oracle.com> On 2/6/2012 12:04 AM, David Holmes wrote: > On 4/02/2012 5:03 AM, Jim Holmlund wrote: >> On 2/2/2012 7:13 PM, David Holmes wrote: >>> I added build-dev to the cc as this is of general interest. Actually >>> before doing this a heads-up should go out to all jdk8-dev I think. >>> >>> One question: are there any cross-compilation issues with building >>> this? I'm assuming not but want to check. >> I don't know of any such issues. What sort of build scenario are you >> thinking of? > > When we cross-compile we have to distinguish between tools executed on the build host and those > built for the target host. If ASM is pure Java (is it?) then there should not be any such concerns > - as long as it doesn't build something in phase N that it has to execute in phase M>N. > Ok, thanks for the info. asm is pure java and has no issues in this area. - jjh > David > ----- > >> - jjh >>> >>> Okay two questions :) : do you know when this will get modularized and >>> show up in the jigsaw repositories? >>> >>> Thanks, >>> David >>> >>> On 3/02/2012 9:29 AM, Jim Holmlund wrote: >>>> This is just a heads up that we are in the process of adding >>>> http://asm.ow2.org/ >>>> >>>> to jdk 8 as a new top level repo. This new repo contains the asm source >>>> code, with a few mods that are needed to build/run it in our >>>> environment. The new repo also contains the build files needed to >>>> participate in our forest builds. The main building is done by the asm >>>> build.xml, with a Makefile wrapper around that in order to participate >>>> in the forest build. This Makefile dynamically renames the asm packages >>>> by prepending 'org.openjdk'. >>>> >>>> The forest build handles the asm repo in the same was as the other >>>> repos, eg, corba. The asm repo is built just after langtools, and then >>>> the resulting .class files are known in the jdk build and are put into >>>> rt.jar. >>>> >>>> The changes for this are: >>>> - These files are modified/added: >>>> M Makefile >>>> M make/Defs-internal.gmk >>>> M make/README.pre-components >>>> A make/asm-rules.gmk >>>> M make/jdk-rules.gmk >>>> M make/sanity-rules.gmk >>>> M make/scripts/hgforest.sh >>>> >>>> - the new asm repo is built just after langtools >>>> >>>> - these files in the jdk repo are modified/added: >>>> M THIRD_PARTY_README >>>> M make/Makefile >>>> M make/common/Release.gmk >>>> M make/common/internal/ImportComponents.gmk >>>> M make/common/shared/Defs-control.gmk >>>> M make/common/shared/Defs.gmk >>>> M make/common/shared/Sanity-Settings.gmk >>>> A make/common/internal/Defs-asm.gmk >>>> A test/org/openjdk/org/objectweb/asm/OmitCommons.java >>>> A test/org/openjdk/org/objectweb/asm/OmitOptimizer.java >>>> A test/org/openjdk/org/objectweb/asm/OmitTreeAnalysis.java >>>> A test/org/openjdk/org/objectweb/asm/OmitUtil.java >>>> A test/org/openjdk/org/objectweb/asm/OmitXml.java >>>> A test/org/openjdk/org/objectweb/asm/RequiredAsmClasses.java >>>> >>>> These changes have not been reviewed and thus are subject to change. >>>> Hopefully, this work can be finished in the next couple weeks. But where >>>> have we heard that before. >>>> >>>> Please let me know if you have any questions or need more info. >>>> >>>> - jjh >>>> >>>> >>>> From kelly.ohair at oracle.com Mon Feb 6 21:35:50 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 6 Feb 2012 13:35:50 -0800 Subject: Adding asm to JDK 8 In-Reply-To: <4F3003EB.6030105@oracle.com> References: <4F2B1C6C.4020208@oracle.com> <4F2B50D8.6010701@oracle.com> <4F2C2F7B.1060100@oracle.com> <4F2F8987.40806@oracle.com> <4F3003EB.6030105@oracle.com> Message-ID: <4936596B-47E3-4523-A505-07A0A49441E2@oracle.com> On Feb 6, 2012, at 8:46 AM, Jim Holmlund wrote: > > > On 2/6/2012 12:04 AM, David Holmes wrote: >> On 4/02/2012 5:03 AM, Jim Holmlund wrote: >>> On 2/2/2012 7:13 PM, David Holmes wrote: >>>> I added build-dev to the cc as this is of general interest. Actually >>>> before doing this a heads-up should go out to all jdk8-dev I think. >>>> >>>> One question: are there any cross-compilation issues with building >>>> this? I'm assuming not but want to check. >>> I don't know of any such issues. What sort of build scenario are you >>> thinking of? >> >> When we cross-compile we have to distinguish between tools executed on the build host and those built for the target host. If ASM is pure Java (is it?) then there should not be any such concerns - as long as it doesn't build something in phase N that it has to execute in phase M>N. >> > Ok, thanks for the info. asm is pure java and has no issues in this area. Ah... but even if it is pure Java, if it needs to be run in Phase 1 with the BOOT JDK, then it needs to be built with -target 7. But if it gets delivered into jdk8 somehow, then it needs to be built with -target 8. Not a huge deal, just something to keep in mind. langtools builds a bootstrap javac (-target 6) and one for delivery into the jdk8 image (-target 8). But jaxp and jaxws, are just built once with -target 8, because it is not run by the BOOT JDK, or isn't yet. Again, jigsaw may change things. -kto > - jjh > >> David >> ----- >> >>> - jjh >>>> >>>> Okay two questions :) : do you know when this will get modularized and >>>> show up in the jigsaw repositories? >>>> >>>> Thanks, >>>> David >>>> >>>> On 3/02/2012 9:29 AM, Jim Holmlund wrote: >>>>> This is just a heads up that we are in the process of adding >>>>> http://asm.ow2.org/ >>>>> >>>>> to jdk 8 as a new top level repo. This new repo contains the asm source >>>>> code, with a few mods that are needed to build/run it in our >>>>> environment. The new repo also contains the build files needed to >>>>> participate in our forest builds. The main building is done by the asm >>>>> build.xml, with a Makefile wrapper around that in order to participate >>>>> in the forest build. This Makefile dynamically renames the asm packages >>>>> by prepending 'org.openjdk'. >>>>> >>>>> The forest build handles the asm repo in the same was as the other >>>>> repos, eg, corba. The asm repo is built just after langtools, and then >>>>> the resulting .class files are known in the jdk build and are put into >>>>> rt.jar. >>>>> >>>>> The changes for this are: >>>>> - These files are modified/added: >>>>> M Makefile >>>>> M make/Defs-internal.gmk >>>>> M make/README.pre-components >>>>> A make/asm-rules.gmk >>>>> M make/jdk-rules.gmk >>>>> M make/sanity-rules.gmk >>>>> M make/scripts/hgforest.sh >>>>> >>>>> - the new asm repo is built just after langtools >>>>> >>>>> - these files in the jdk repo are modified/added: >>>>> M THIRD_PARTY_README >>>>> M make/Makefile >>>>> M make/common/Release.gmk >>>>> M make/common/internal/ImportComponents.gmk >>>>> M make/common/shared/Defs-control.gmk >>>>> M make/common/shared/Defs.gmk >>>>> M make/common/shared/Sanity-Settings.gmk >>>>> A make/common/internal/Defs-asm.gmk >>>>> A test/org/openjdk/org/objectweb/asm/OmitCommons.java >>>>> A test/org/openjdk/org/objectweb/asm/OmitOptimizer.java >>>>> A test/org/openjdk/org/objectweb/asm/OmitTreeAnalysis.java >>>>> A test/org/openjdk/org/objectweb/asm/OmitUtil.java >>>>> A test/org/openjdk/org/objectweb/asm/OmitXml.java >>>>> A test/org/openjdk/org/objectweb/asm/RequiredAsmClasses.java >>>>> >>>>> These changes have not been reviewed and thus are subject to change. >>>>> Hopefully, this work can be finished in the next couple weeks. But where >>>>> have we heard that before. >>>>> >>>>> Please let me know if you have any questions or need more info. >>>>> >>>>> - jjh >>>>> >>>>> >>>>> From mike.duigou at oracle.com Mon Feb 6 22:55:59 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Mon, 6 Feb 2012 14:55:59 -0800 Subject: Review Request : 7143162 : Allow disable building of jdk demos and samples Message-ID: Hello all; WEBREV @ http://cr.openjdk.java.net/~mduigou/7143162/0/webrev/ A fairly simple patch for review. It allows developers to shut off building of the jdk demos and samples. Disabling these builds has a very positive impact upon build turnaround for incremental builds. Export NO_DEMOS and/or NO_SAMPLES in your shell before running make and demos and/or samples will be skipped. The default behaviour remains unchanged. I know that the new build infrastructure is coming soon and it will render this patch irrelevant. :-) I was asked again today for a copy of this patch so thought others may still benefit. Thanks, Mike From kelly.ohair at oracle.com Tue Feb 7 00:30:31 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 6 Feb 2012 16:30:31 -0800 Subject: Review Request : 7143162 : Allow disable building of jdk demos and samples In-Reply-To: References: Message-ID: Looks ok to me. -kto On Feb 6, 2012, at 2:55 PM, Mike Duigou wrote: > Hello all; > > WEBREV @ http://cr.openjdk.java.net/~mduigou/7143162/0/webrev/ > > A fairly simple patch for review. It allows developers to shut off building of the jdk demos and samples. Disabling these builds has a very positive impact upon build turnaround for incremental builds. Export NO_DEMOS and/or NO_SAMPLES in your shell before running make and demos and/or samples will be skipped. > > The default behaviour remains unchanged. > > I know that the new build infrastructure is coming soon and it will render this patch irrelevant. :-) I was asked again today for a copy of this patch so thought others may still benefit. > > Thanks, > > Mike From david.holmes at oracle.com Tue Feb 7 02:52:20 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 07 Feb 2012 12:52:20 +1000 Subject: Request for review: hotspot/jprt.properties [S] In-Reply-To: <4F2BCB39.60806@oracle.com> References: <4F2B22AB.2090807@oracle.com> <4F2B3FDD.50104@oracle.com> <4F2BCB39.60806@oracle.com> Message-ID: <4F3091E4.3040002@oracle.com> On 3/02/2012 9:55 PM, Keith McGuigan wrote: > On 2/2/2012 9:01 PM, David Holmes wrote: >> On 3/02/2012 9:56 AM, Keith McGuigan wrote: >>> Here's a webrev for changing the default JPRT release value for hotspot >>> to jdk8. It can still be overridden by the -release jdk7 during JPRT >>> submission. I also removed references to pre-7 releases and other unused >>> value (jdk7b107, jdk7temp). >> >> Are we sure there is no reason to leave any pre-7 release info here? > > As far as I know, hsx will be used only for jdk7 & jdk8 releases, > anything pre-7 has it's own separate hotspot repository (or it will, if > needed). Ok. Good to go. David From david.holmes at oracle.com Tue Feb 7 03:08:41 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 07 Feb 2012 13:08:41 +1000 Subject: Fwd: hg: hsx/hotspot-rt/hotspot: 7141242: build-infra merge: Rename CPP->CXX and LINK->LD In-Reply-To: <20120207025517.43DA9473B1@hg.openjdk.java.net> References: <20120207025517.43DA9473B1@hg.openjdk.java.net> Message-ID: <4F3095B9.50506@oracle.com> Sorry for the wide distribution but the handful of people that may be affected by this could be spread across various groups. The patch below changes the names of the some of make variables used when building hotspot. Eg CPPFLAGS becomes CXXFLAGS, LINKXXX becomes LDXXX etc. It is possible that people occasionally pre-set these variables in their environment to override the default settings in the build system, or to add to them. If you do that then you will need to update your build environment to use the new names. Cheers, David Holmes (Don't shoot me, I'm just the messenger ;-) ) -------- Original Message -------- Subject: hg: hsx/hotspot-rt/hotspot: 7141242: build-infra merge: Rename CPP->CXX and LINK->LD Date: Tue, 07 Feb 2012 02:55:13 +0000 From: david.holmes at oracle.com To: hotspot-runtime-dev at openjdk.java.net, serviceability-dev at openjdk.java.net Changeset: 719f7007c8e8 Author: erikj Date: 2012-02-06 09:14 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/719f7007c8e8 7141242: build-infra merge: Rename CPP->CXX and LINK->LD Summary: Cleaned up make variables for compilers and linker to consistently use CXX for C++ compiler, CC for C compiler and LD for linker. Reviewed-by: dholmes, ohrstrom ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/rules.make ! make/bsd/makefiles/sparcWorks.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/adlc.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/product.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sparcWorks.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/launcher.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build_vm_def.sh ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/launcher.make ! make/windows/makefiles/product.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/sa.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/shared.make ! make/windows/makefiles/vm.make From erik.joelsson at oracle.com Tue Feb 7 08:07:40 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 07 Feb 2012 09:07:40 +0100 Subject: Review Request : 7143162 : Allow disable building of jdk demos and samples In-Reply-To: References: Message-ID: <4F30DBCC.1050609@oracle.com> Hello, Looks ok to me too. /Erik On 2012-02-06 23:55, Mike Duigou wrote: > Hello all; > > WEBREV @ http://cr.openjdk.java.net/~mduigou/7143162/0/webrev/ > > A fairly simple patch for review. It allows developers to shut off building of the jdk demos and samples. Disabling these builds has a very positive impact upon build turnaround for incremental builds. Export NO_DEMOS and/or NO_SAMPLES in your shell before running make and demos and/or samples will be skipped. > > The default behaviour remains unchanged. > > I know that the new build infrastructure is coming soon and it will render this patch irrelevant. :-) I was asked again today for a copy of this patch so thought others may still benefit. > > Thanks, > > Mike From erik.joelsson at oracle.com Tue Feb 7 16:30:47 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 07 Feb 2012 17:30:47 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable Message-ID: <4F3151B7.7000806@oracle.com> http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable The build-infra project is starting to move into jdk8. For the hotspot build to stay compatible with the changes, key hotspot makefiles need to add an optional include statement: -include $(SPEC) In the new build system, the spec file is generated by configure and contains the configuration for the build. Only a handfull of files need to add this line. In addition to including the spec file, some variables need to be changed to only be set conditionally so that a value from the spec file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, NAWK (and for windows RC and MT). The hotspot makefiles should check each variable if it's already set or if it has a gnumake default value. These changes have been verified to work for hotspot-rt. Jdk7u will be verified as well before pushing. /Erik From paul.hohensee at oracle.com Tue Feb 7 16:55:56 2012 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Tue, 07 Feb 2012 11:55:56 -0500 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F3151B7.7000806@oracle.com> References: <4F3151B7.7000806@oracle.com> Message-ID: <4F31579C.8000403@oracle.com> Can you make this work when building from the make/ directories? E.g., you could add the $(SPEC) include to make/solaris/Makefile, etc. Thanks, Paul On 2/7/12 11:30 AM, Erik Joelsson wrote: > http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ > > 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg > > 7141244: build-infra merge: Include $(SPEC) in makefiles and make > variables overridable > > The build-infra project is starting to move into jdk8. For the hotspot > build to stay compatible with the changes, key hotspot makefiles need > to add an optional include statement: > > > -include $(SPEC) > > In the new build system, the spec file is generated by configure and > contains the configuration for the build. Only a handfull of files > need to add this line. > > In addition to including the spec file, some variables need to be > changed to only be set conditionally so that a value from the spec > file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, > NAWK (and for windows RC and MT). The hotspot makefiles should check > each variable if it's already set or if it has a gnumake default value. > > These changes have been verified to work for hotspot-rt. Jdk7u will be > verified as well before pushing. > > /Erik > From david.holmes at oracle.com Wed Feb 8 00:42:47 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 08 Feb 2012 10:42:47 +1000 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F31579C.8000403@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31579C.8000403@oracle.com> Message-ID: <4F31C507.6040609@oracle.com> On 8/02/2012 2:55 AM, Paul Hohensee wrote: > Can you make this work when building from the make/ directories? > E.g., you could add the $(SPEC) include to make/solaris/Makefile, etc. I'm not sure that makes sense. The SPEC file only exists for the new build and in the new build you run configure for each platform, so if you configured for solaris then that is the only build you can do there. You can't decide to do a linux build instead - you need to re-run configure. I'll take a look at this ASAP but am somewhat swamped right now. David > Thanks, > > Paul > > On 2/7/12 11:30 AM, Erik Joelsson wrote: >> http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ >> >> 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg >> >> 7141244: build-infra merge: Include $(SPEC) in makefiles and make >> variables overridable >> >> The build-infra project is starting to move into jdk8. For the hotspot >> build to stay compatible with the changes, key hotspot makefiles need >> to add an optional include statement: >> >> >> -include $(SPEC) >> >> In the new build system, the spec file is generated by configure and >> contains the configuration for the build. Only a handfull of files >> need to add this line. >> >> In addition to including the spec file, some variables need to be >> changed to only be set conditionally so that a value from the spec >> file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, >> NAWK (and for windows RC and MT). The hotspot makefiles should check >> each variable if it's already set or if it has a gnumake default value. >> >> These changes have been verified to work for hotspot-rt. Jdk7u will be >> verified as well before pushing. >> >> /Erik >> From david.holmes at oracle.com Wed Feb 8 01:47:19 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 08 Feb 2012 11:47:19 +1000 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F3151B7.7000806@oracle.com> References: <4F3151B7.7000806@oracle.com> Message-ID: <4F31D427.4020103@oracle.com> Hi Erik, On 8/02/2012 2:30 AM, Erik Joelsson wrote: > http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ > > 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg > > 7141244: build-infra merge: Include $(SPEC) in makefiles and make > variables overridable > > The build-infra project is starting to move into jdk8. For the hotspot > build to stay compatible with the changes, key hotspot makefiles need to > add an optional include statement: > > > -include $(SPEC) It doesn't make sense to me to include SPEC in make/Makefile and make/Defs.make because Makefile includes Defs.make. You only need the -include in Defs.make (unless SPEC is going to define GAMMADIR or ALT_OUTPUTDIR - in which case include it in the Makefile not Defs.make) > In the new build system, the spec file is generated by configure and > contains the configuration for the build. Only a handfull of files need > to add this line. > > In addition to including the spec file, some variables need to be > changed to only be set conditionally so that a value from the spec file > takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, NAWK (and > for windows RC and MT). The hotspot makefiles should check each variable > if it's already set or if it has a gnumake default value. So this seems really ugly to me. If these were all set as Make variables on a top-level make invocation then you wouldn't need to do any of these tests. If the SPEC file is always going to set these variables then why not either include SPEC or else do these definitions eg: ifeq ($(SPEC),) CC = ... CXX = .. ... endif # else SPEC already defined these this might need some refactoring to group the necessary settings together. David ----- > These changes have been verified to work for hotspot-rt. Jdk7u will be > verified as well before pushing. > > /Erik > From paul.hohensee at oracle.com Wed Feb 8 01:54:03 2012 From: paul.hohensee at oracle.com (Paul Hohensee) Date: Tue, 07 Feb 2012 20:54:03 -0500 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F31C507.6040609@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31579C.8000403@oracle.com> <4F31C507.6040609@oracle.com> Message-ID: <4F31D5BB.4050700@oracle.com> Thanks for the explanation. As long as I can still do builds from make/, I'm happy. Paul On 2/7/12 7:42 PM, David Holmes wrote: > On 8/02/2012 2:55 AM, Paul Hohensee wrote: >> Can you make this work when building from the make/ >> directories? >> E.g., you could add the $(SPEC) include to make/solaris/Makefile, etc. > > I'm not sure that makes sense. The SPEC file only exists for the new > build and in the new build you run configure for each platform, so if > you configured for solaris then that is the only build you can do > there. You can't decide to do a linux build instead - you need to > re-run configure. > > I'll take a look at this ASAP but am somewhat swamped right now. > > David > >> Thanks, >> >> Paul >> >> On 2/7/12 11:30 AM, Erik Joelsson wrote: >>> http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ >>> >>> 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg >>> >>> 7141244: build-infra merge: Include $(SPEC) in makefiles and make >>> variables overridable >>> >>> The build-infra project is starting to move into jdk8. For the hotspot >>> build to stay compatible with the changes, key hotspot makefiles need >>> to add an optional include statement: >>> >>> >>> -include $(SPEC) >>> >>> In the new build system, the spec file is generated by configure and >>> contains the configuration for the build. Only a handfull of files >>> need to add this line. >>> >>> In addition to including the spec file, some variables need to be >>> changed to only be set conditionally so that a value from the spec >>> file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, >>> NAWK (and for windows RC and MT). The hotspot makefiles should check >>> each variable if it's already set or if it has a gnumake default value. >>> >>> These changes have been verified to work for hotspot-rt. Jdk7u will be >>> verified as well before pushing. >>> >>> /Erik >>> From erik.joelsson at oracle.com Wed Feb 8 08:14:53 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 08 Feb 2012 09:14:53 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F31D427.4020103@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> Message-ID: <4F322EFD.6050900@oracle.com> Thanks for looking at this! On 2012-02-08 02:47, David Holmes wrote: > It doesn't make sense to me to include SPEC in make/Makefile and > make/Defs.make because Makefile includes Defs.make. You only need the > -include in Defs.make (unless SPEC is going to define GAMMADIR or > ALT_OUTPUTDIR - in which case include it in the Makefile not Defs.make) > I checked this again and you are right, we don't set anything that warrants including SPEC in make/Makefile. I will move it to defs only. > So this seems really ugly to me. If these were all set as Make > variables on a top-level make invocation then you wouldn't need to do > any of these tests. If the SPEC file is always going to set these > variables then why not either include SPEC or else do these > definitions eg: > > ifeq ($(SPEC),) > CC = ... > CXX = .. > ... > endif > # else SPEC already defined these > > this might need some refactoring to group the necessary settings > together. > This was how I initially did it, but I wasn't sure on the best solution. I also forgot about command line overriding normal assignments. With an explicit check for SPEC it's very obvious what we are trying to achieve. I will look into this and try to group things more neatly together for it. Hope to publish a new webrev later today. /Erik From erik.joelsson at oracle.com Wed Feb 8 08:18:11 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 08 Feb 2012 09:18:11 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F31D5BB.4050700@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31579C.8000403@oracle.com> <4F31C507.6040609@oracle.com> <4F31D5BB.4050700@oracle.com> Message-ID: <4F322FC3.6040602@oracle.com> Thanks for taking a look. While I haven't tried building in the way describe (yet), these changes shouldn't affect it. The idea is to leave everything in the hotspot build just like it is now, but let configure override things when configure is used, which is only when building the full forest. /Erik On 2012-02-08 02:54, Paul Hohensee wrote: > Thanks for the explanation. As long as I can still do builds from > make/, I'm happy. > > Paul > > On 2/7/12 7:42 PM, David Holmes wrote: >> On 8/02/2012 2:55 AM, Paul Hohensee wrote: >>> Can you make this work when building from the make/ >>> directories? >>> E.g., you could add the $(SPEC) include to make/solaris/Makefile, etc. >> >> I'm not sure that makes sense. The SPEC file only exists for the new >> build and in the new build you run configure for each platform, so if >> you configured for solaris then that is the only build you can do >> there. You can't decide to do a linux build instead - you need to >> re-run configure. >> >> I'll take a look at this ASAP but am somewhat swamped right now. >> >> David >> >>> Thanks, >>> >>> Paul >>> >>> On 2/7/12 11:30 AM, Erik Joelsson wrote: >>>> http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ >>>> >>>> 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg >>>> >>>> 7141244: build-infra merge: Include $(SPEC) in makefiles and make >>>> variables overridable >>>> >>>> The build-infra project is starting to move into jdk8. For the hotspot >>>> build to stay compatible with the changes, key hotspot makefiles need >>>> to add an optional include statement: >>>> >>>> >>>> -include $(SPEC) >>>> >>>> In the new build system, the spec file is generated by configure and >>>> contains the configuration for the build. Only a handfull of files >>>> need to add this line. >>>> >>>> In addition to including the spec file, some variables need to be >>>> changed to only be set conditionally so that a value from the spec >>>> file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, >>>> NAWK (and for windows RC and MT). The hotspot makefiles should check >>>> each variable if it's already set or if it has a gnumake default >>>> value. >>>> >>>> These changes have been verified to work for hotspot-rt. Jdk7u will be >>>> verified as well before pushing. >>>> >>>> /Erik >>>> From david.holmes at oracle.com Wed Feb 8 08:33:16 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 08 Feb 2012 18:33:16 +1000 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F322EFD.6050900@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> Message-ID: <4F32334C.1090101@oracle.com> Hi Erik, On 8/02/2012 6:14 PM, Erik Joelsson wrote: > Thanks for looking at this! > > On 2012-02-08 02:47, David Holmes wrote: >> It doesn't make sense to me to include SPEC in make/Makefile and >> make/Defs.make because Makefile includes Defs.make. You only need the >> -include in Defs.make (unless SPEC is going to define GAMMADIR or >> ALT_OUTPUTDIR - in which case include it in the Makefile not Defs.make) >> > I checked this again and you are right, we don't set anything that > warrants including SPEC in make/Makefile. I will move it to defs only. >> So this seems really ugly to me. If these were all set as Make >> variables on a top-level make invocation then you wouldn't need to do >> any of these tests. If the SPEC file is always going to set these >> variables then why not either include SPEC or else do these >> definitions eg: >> >> ifeq ($(SPEC),) >> CC = ... >> CXX = .. >> ... >> endif >> # else SPEC already defined these >> >> this might need some refactoring to group the necessary settings >> together. >> > This was how I initially did it, but I wasn't sure on the best solution. > I also forgot about command line overriding normal assignments. With an > explicit check for SPEC it's very obvious what we are trying to achieve. > I will look into this and try to group things more neatly together for > it. Hope to publish a new webrev later today. This reminded me that one of the things on my wishlist for the new build was that I can still override something in SPEC by setting it on the command-line invocation of make. Cheers, David > /Erik From fredrik.ohrstrom at oracle.com Wed Feb 8 13:14:14 2012 From: fredrik.ohrstrom at oracle.com (=?UTF-8?B?RnJlZHJpayDDlmhyc3Ryw7Zt?=) Date: Wed, 8 Feb 2012 05:14:14 -0800 (PST) Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable Message-ID: <5c2dfd6a-7b95-4520-b711-c34e16be01eb@default> ----- david.holmes at oracle.com skrev: > This reminded me that one of the things on my wishlist for the new > build > was that I can still override something in SPEC by setting it on the > command-line invocation of make. That should work, since a variable specified on the make command line, forcibly overrides any attempt to set it inside the makefiles. (Well, you can forcibly-forcibly override it again in the makefile, but we have no intention to do that.) We only need to make sure that the variables specified to the root makefile gets propagated to the sub-make command lines. Should be easy to fix. But it will not be part of this webrev. //Fredrik From erik.joelsson at oracle.com Wed Feb 8 15:36:02 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 08 Feb 2012 16:36:02 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F322EFD.6050900@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> Message-ID: <4F329662.7030200@oracle.com> New webrev up with the changes I detailed below: http://cr.openjdk.java.net/~erikj/7141244/webrev.01/ 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg /Erik On 2012-02-08 09:14, Erik Joelsson wrote: > Thanks for looking at this! > > On 2012-02-08 02:47, David Holmes wrote: >> It doesn't make sense to me to include SPEC in make/Makefile and >> make/Defs.make because Makefile includes Defs.make. You only need the >> -include in Defs.make (unless SPEC is going to define GAMMADIR or >> ALT_OUTPUTDIR - in which case include it in the Makefile not Defs.make) >> > I checked this again and you are right, we don't set anything that > warrants including SPEC in make/Makefile. I will move it to defs only. >> So this seems really ugly to me. If these were all set as Make >> variables on a top-level make invocation then you wouldn't need to do >> any of these tests. If the SPEC file is always going to set these >> variables then why not either include SPEC or else do these >> definitions eg: >> >> ifeq ($(SPEC),) >> CC = ... >> CXX = .. >> ... >> endif >> # else SPEC already defined these >> >> this might need some refactoring to group the necessary settings >> together. >> > This was how I initially did it, but I wasn't sure on the best > solution. I also forgot about command line overriding normal > assignments. With an explicit check for SPEC it's very obvious what we > are trying to achieve. I will look into this and try to group things > more neatly together for it. Hope to publish a new webrev later today. > > /Erik From michael.fang at sun.com Wed Feb 8 18:24:57 2012 From: michael.fang at sun.com (michael.fang at sun.com) Date: Wed, 08 Feb 2012 18:24:57 +0000 Subject: hg: jdk8/build/jdk: 3 new changesets Message-ID: <20120208182547.0152E473EF@hg.openjdk.java.net> Changeset: 8da468cf037b Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8da468cf037b Added tag jdk8-b24 for changeset 34029a0c69bb ! .hgtags Changeset: 1a99dad28223 Author: yhuang Date: 2012-02-06 18:56 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1a99dad28223 7129382: change minor unit of VND to 0 Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! test/java/util/Currency/tablea1.txt Changeset: 930756e55285 Author: yhuang Date: 2012-02-06 18:58 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/930756e55285 Merge From michael.x.mcmahon at oracle.com Mon Feb 6 22:31:21 2012 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Mon, 06 Feb 2012 22:31:21 +0000 Subject: RFR 7142950: jdk7u cannot bootstrap Mac OS build [macosx] Message-ID: <4F3054B9.5070009@oracle.com> There are a few problems with the Mac build at the moment. 1. If SKIP_BOOT_CYCLE=false then the build fails, due to two problems:- 1) top level Makefile doesn't know about Mac OS image directory structure 2) it also fails due to problem 2. below 2. General bootstrapping problem. The build currently cannot use itself as the bootstrap JDK due to an assumption in the framework classes that "os.arch" is x86_64, whereas we currently set it to amd64. The change is to fix that code to expect amd64. There is a related question then about what the correct value for os.arch should be. I'd like to raise this in a separate discussion and hopefully fix these build problems independently of that. 3. jvm.cfg is currently being taken from the solaris src tree even though a macos version of the file is there. Fix that problem too. The macos source jvm.cfg is changed to be the same as the solaris/amd64 version (ie. the one that was being used, and which makes -client UNKNOWN) The following webrevs address these issues. Top level repo ------------------ http://cr.openjdk.java.net/~michaelm/7142950/top/webrev.1/ JDK repo ------------ http://cr.openjdk.java.net/~michaelm/7142950/jdk/webrev.1/ From scott.kovatch at oracle.com Mon Feb 6 23:21:00 2012 From: scott.kovatch at oracle.com (Scott Kovatch) Date: Mon, 6 Feb 2012 15:21:00 -0800 Subject: RFR 7142950: jdk7u cannot bootstrap Mac OS build [macosx] In-Reply-To: <4F3054B9.5070009@oracle.com> References: <4F3054B9.5070009@oracle.com> Message-ID: <32131CAD-A904-4DA1-8E8D-ADBDD73A6279@oracle.com> On Feb 6, 2012, at 2:31 PM, Michael McMahon wrote: > There are a few problems with the Mac build at the moment. > > 1. If SKIP_BOOT_CYCLE=false then the build fails, due to two problems:- > 1) top level Makefile doesn't know about Mac OS image directory structure > 2) it also fails due to problem 2. below > 2. General bootstrapping problem. The build currently cannot use itself as > the bootstrap JDK due to an assumption in the framework classes that > "os.arch" is x86_64, whereas we currently set it to amd64. The change is to > fix that code to expect amd64. There is a related question then about what the > correct value for os.arch should be. I'd like to raise this in a separate discussion > and hopefully fix these build problems independently of that. I was going to propose that we fix the image directory issues by building into the image directories the same way on all platforms and have the mac build copy the image directories into j2sdk-bundle. (7133768) I'm pretty sure that even with this change you can't build rt.jar because the jar tool gets moved out from underneath the running build when the bundle is constructed. I don't think your changes would interfere with my proposed fix for 7133768, though. And, the other changes for generating the folder name dynamically are very much welcome. -- Scott K. ---------------------------------------- Scott Kovatch scott.kovatch at oracle.com Santa Clara/Pleasanton, CA From david.holmes at oracle.com Thu Feb 9 02:51:18 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 09 Feb 2012 12:51:18 +1000 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F329662.7030200@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> <4F329662.7030200@oracle.com> Message-ID: <4F3334A6.3020700@oracle.com> On 9/02/2012 1:36 AM, Erik Joelsson wrote: > New webrev up with the changes I detailed below: > > http://cr.openjdk.java.net/~erikj/7141244/webrev.01/ > 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg make/defs.make: + ifneq (,$(SPEC)) + include $(SPEC) + endif Having the blank first looks odd. I assume you aren't using -inlcude because you want to see errors if SPEC is set but not found. make/windows/makefiles/compile.make: The definitions of MT=mt.exe in each block for the different VS versions seems redundant. If we factor this out is there any reason not to group: CXX=cl.exe MT=mt.exe RC=rc.exe LD=link.exe together and use the same "if (,$(SPEC))" approach? David ----- > /Erik > > On 2012-02-08 09:14, Erik Joelsson wrote: >> Thanks for looking at this! >> >> On 2012-02-08 02:47, David Holmes wrote: >>> It doesn't make sense to me to include SPEC in make/Makefile and >>> make/Defs.make because Makefile includes Defs.make. You only need the >>> -include in Defs.make (unless SPEC is going to define GAMMADIR or >>> ALT_OUTPUTDIR - in which case include it in the Makefile not Defs.make) >>> >> I checked this again and you are right, we don't set anything that >> warrants including SPEC in make/Makefile. I will move it to defs only. >>> So this seems really ugly to me. If these were all set as Make >>> variables on a top-level make invocation then you wouldn't need to do >>> any of these tests. If the SPEC file is always going to set these >>> variables then why not either include SPEC or else do these >>> definitions eg: >>> >>> ifeq ($(SPEC),) >>> CC = ... >>> CXX = .. >>> ... >>> endif >>> # else SPEC already defined these >>> >>> this might need some refactoring to group the necessary settings >>> together. >>> >> This was how I initially did it, but I wasn't sure on the best >> solution. I also forgot about command line overriding normal >> assignments. With an explicit check for SPEC it's very obvious what we >> are trying to achieve. I will look into this and try to group things >> more neatly together for it. Hope to publish a new webrev later today. >> >> /Erik From david.katleman at sun.com Thu Feb 9 04:28:21 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 09 Feb 2012 04:28:21 +0000 Subject: hg: jdk8/build: 4 new changesets Message-ID: <20120209042821.6BF55473FC@hg.openjdk.java.net> Changeset: 5350cd6e0cc0 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/5350cd6e0cc0 Added tag jdk8-b24 for changeset 1a5f1d6b98d6 ! .hgtags Changeset: 0f653ee93477 Author: alanb Date: 2012-01-24 09:08 +0000 URL: http://hg.openjdk.java.net/jdk8/build/rev/0f653ee93477 7132204: Default testset in JPRT should not run all tests Reviewed-by: ohair ! make/jprt.properties Changeset: bd3fcc98c5d2 Author: lana Date: 2012-01-28 20:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/bd3fcc98c5d2 Merge Changeset: 221a378e06a3 Author: lana Date: 2012-02-07 10:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/221a378e06a3 Merge From david.katleman at sun.com Thu Feb 9 04:28:28 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 09 Feb 2012 04:28:28 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b24 for changeset b98f0e6dddf9 Message-ID: <20120209042830.2DC54473FE@hg.openjdk.java.net> Changeset: e45d6b406d5f Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/e45d6b406d5f Added tag jdk8-b24 for changeset b98f0e6dddf9 ! .hgtags From david.katleman at sun.com Thu Feb 9 04:30:24 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 09 Feb 2012 04:30:24 +0000 Subject: hg: jdk8/build/hotspot: 29 new changesets Message-ID: <20120209043229.20674473FF@hg.openjdk.java.net> Changeset: 905945c5913e Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/905945c5913e Added tag jdk8-b24 for changeset a80fd4f45d7a ! .hgtags Changeset: 9f1c2b7cdfb6 Author: amurillo Date: 2012-01-27 14:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9f1c2b7cdfb6 7135385: new hotspot build - hs23-b13 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 34e2e90e7182 Author: rbackman Date: 2012-01-24 14:48 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/34e2e90e7182 7130476: Remove use of #ifdef TRACE_DEFINE_KLASS_TRACE_ID from klass.hpp Reviewed-by: kamg, phh, dsamersoff Contributed-by: Rickard Backman ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/trace/traceMacros.hpp Changeset: 26a08cbbf042 Author: stefank Date: 2012-01-27 13:46 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/26a08cbbf042 7022100: Method annotations are incorrectly set when redefining classes Summary: Changed to the correct annotation arrays Reviewed-by: kamg, dholmes, sla ! src/share/vm/oops/instanceKlass.hpp Changeset: f457154eee8b Author: brutisso Date: 2012-01-30 12:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f457154eee8b 7140882: Don't return booleans from methods returning pointers Summary: Changed "return false" to "return NULL" Reviewed-by: dholmes, rottenha Contributed-by: dbhole at redhat.com ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/opto/loopnode.cpp Changeset: d96c130c9399 Author: brutisso Date: 2012-01-30 05:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d96c130c9399 Merge Changeset: b2cd0ee8f778 Author: acorn Date: 2012-01-30 23:27 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b2cd0ee8f778 7114376: Make system dictionary hashtable bucket array size configurable Summary: 7u4 new experimental flag -XX:PredictedClassLoadedCount=# Reviewed-by: dholmes, phh, dcubed ! agent/src/share/classes/sun/jvm/hotspot/memory/LoaderConstraintTable.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/hashtable.hpp Changeset: 481a9443f721 Author: phh Date: 2012-02-01 15:01 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/481a9443f721 7123386: RFE: Preserve universal builds of HotSpot on Mac OS X Summary: Add support for packaging HotSpot JVM builds in universal binaries Reviewed-by: dholmes, kamg, dcubed, phh Contributed-by: james.melvin at oracle.com ! make/Makefile ! make/bsd/makefiles/defs.make + make/bsd/makefiles/universal.gmk ! make/defs.make Changeset: 527cf36f4a20 Author: fparain Date: 2012-02-03 14:04 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/527cf36f4a20 Merge ! src/share/vm/runtime/globals.hpp Changeset: 1a2723f7ad8e Author: never Date: 2012-01-29 16:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1a2723f7ad8e 7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale Reviewed-by: kvn, iveresov, dholmes ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/gcLocker.inline.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/safepoint.hpp ! src/share/vm/runtime/thread.hpp Changeset: 5f17b16b3219 Author: iveresov Date: 2012-01-30 19:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5f17b16b3219 7141059: 7116795 broke pure c2 builds Summary: Fix pure c2 builds Reviewed-by: kvn, brutisso, never ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 5ed8f599a788 Author: kvn Date: 2012-01-31 07:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5ed8f599a788 7140924: SIGSEGV in compiled code for sun.awt.X11.XDecoratedPeer.updateMinSizeHints Summary: Use unknown_obj instead of empty_map for NULL or Constant Pool object constants in bytecode Escape Analyzer. Reviewed-by: iveresov, never ! src/share/vm/ci/bcEscapeAnalyzer.cpp Changeset: 2f5980b127e3 Author: twisti Date: 2012-01-31 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2f5980b127e3 7132180: JSR 292: C1 JVM crash with ClassValue/MethodHandle Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f067b4e0e04b Author: roland Date: 2012-02-01 10:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f067b4e0e04b 7090976: Eclipse/CDT causes a JVM crash while indexing C++ code Summary: too optimistic inlining decision confuses local value numbering. Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_ValueMap.cpp + test/compiler/7090976/Test7090976.java Changeset: aa3d708d67c4 Author: never Date: 2012-02-01 07:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/aa3d708d67c4 7141200: log some interesting information in ring buffers for crashes Reviewed-by: kvn, jrose, kevinw, brutisso, twisti, jmasa ! src/os/windows/vm/os_windows.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/vmError.cpp Changeset: 0382d2b469b2 Author: never Date: 2012-02-01 16:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0382d2b469b2 7013347: allow crypto functions to be called inline to enhance performance Reviewed-by: kvn ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/oops/arrayOop.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/prims/nativeLookup.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/safepoint.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 392a3f07d567 Author: twisti Date: 2012-02-02 09:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/392a3f07d567 7141637: JSR 292: MH spread invoker crashes with NULL argument on x86_32 Reviewed-by: twisti Contributed-by: Volker Simonis ! src/cpu/x86/vm/methodHandles_x86.cpp + test/compiler/7141637/SpreadNullArg.java Changeset: 379b22e03c32 Author: jcoomes Date: 2012-02-03 12:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/379b22e03c32 Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/globals.hpp Changeset: be649fefcdc2 Author: stefank Date: 2012-01-27 14:14 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/be649fefcdc2 7134655: Crash in reference processing when doing single-threaded remarking Summary: Temporarily disabled multi-threaded reference discovery when entering a single-threaded remark phase. Reviewed-by: brutisso, tonyp, jmasa, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: c03e06373b47 Author: stefank Date: 2012-01-28 01:15 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c03e06373b47 Merge - src/os/bsd/vm/decoder_bsd.cpp Changeset: 2eeebe4b4213 Author: brutisso Date: 2012-01-30 15:21 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2eeebe4b4213 7140909: Visual Studio project builds broken: need to define INCLUDE_TRACE Summary: Add define of INCLUDE_TRACE Reviewed-by: sla, kamg ! src/share/tools/ProjectCreator/BuildConfig.java Changeset: 24cae3e4cbaa Author: jcoomes Date: 2012-02-02 16:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/24cae3e4cbaa 6679764: enable parallel compaction by default Reviewed-by: phh, jmasa ! src/share/vm/runtime/arguments.cpp Changeset: 5ab44ceb4d57 Author: jcoomes Date: 2012-02-03 12:20 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5ab44ceb4d57 Merge Changeset: b22de8247499 Author: amurillo Date: 2012-02-03 18:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b22de8247499 Merge Changeset: 4e9b30938cbf Author: amurillo Date: 2012-02-03 18:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4e9b30938cbf Added tag hs23-b13 for changeset b22de8247499 ! .hgtags Changeset: 1f22b536808b Author: amurillo Date: 2012-02-03 18:09 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1f22b536808b 7142393: new hotspot build - hs23-b14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 585feefad374 Author: phh Date: 2012-02-06 14:01 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/585feefad374 7142852: MAC: Comment out JPRT jbb tests on Mac OS X until 7142850 is resolved Summary: Comment out JPRT jbb tests on Mac OS X until GUI hang can be fixed Reviewed-by: dholmes, brutisso, phh Contributed-by: james.melvin at oracle.com ! make/jprt.properties Changeset: 64b46f975ab8 Author: phh Date: 2012-02-06 14:02 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/64b46f975ab8 7142616: MAC: Honor ALT_EXPORT_PATH overrides from JDK control builds Summary: Fix EXPORT_PATH overrides on Mac OS X and only change default. Reviewed-by: phh, dcubed Contributed-by: james.melvin at oracle.com ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/universal.gmk Changeset: 9ad8feb5afbd Author: amurillo Date: 2012-02-06 12:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9ad8feb5afbd Added tag hs23-b14 for changeset 64b46f975ab8 ! .hgtags From david.katleman at sun.com Thu Feb 9 04:33:43 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 09 Feb 2012 04:33:43 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b24 for changeset 7836655e2495 Message-ID: <20120209043343.3B4A547400@hg.openjdk.java.net> Changeset: bb694c151fc7 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/bb694c151fc7 Added tag jdk8-b24 for changeset 7836655e2495 ! .hgtags From david.katleman at sun.com Thu Feb 9 04:33:50 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 09 Feb 2012 04:33:50 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b24 for changeset e0d90803439b Message-ID: <20120209043350.734BF47401@hg.openjdk.java.net> Changeset: b376d901e006 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b376d901e006 Added tag jdk8-b24 for changeset e0d90803439b ! .hgtags From david.katleman at sun.com Thu Feb 9 04:35:01 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 09 Feb 2012 04:35:01 +0000 Subject: hg: jdk8/build/jdk: 44 new changesets Message-ID: <20120209044829.77D5747404@hg.openjdk.java.net> Changeset: ad9f1c8970da Author: prr Date: 2012-01-19 12:41 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ad9f1c8970da 7131153: GetDC called way too many times - causes bad performance. Reviewed-by: igor, jgodinez ! src/windows/native/sun/font/fontpath.c Changeset: f7dda4bbf1f9 Author: lana Date: 2012-01-28 22:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f7dda4bbf1f9 Merge - test/java/io/File/BlockIsDirectory.java Changeset: 84b153cd9bd4 Author: denis Date: 2012-01-19 14:59 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/84b153cd9bd4 7121761: creation of java.awt.DataFlavour fails for turkish locale Reviewed-by: anthony ! src/share/classes/java/awt/datatransfer/MimeType.java Changeset: e32db6535c05 Author: alexsch Date: 2012-01-23 13:05 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e32db6535c05 7112854: [macosx] closed/javax/swing/JPopupMenu/Test6827786.java unstable on MacOS Reviewed-by: rupashka + test/javax/swing/JPopupMenu/6827786/bug6827786.java Changeset: cc88a9c0474f Author: alexsch Date: 2012-01-23 13:53 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cc88a9c0474f 7116634: [macosx] closed/javax/swing/JTree/6263446/bug6263446Tree.java fails on MacOS Reviewed-by: rupashka + test/javax/swing/JTree/6263446/bug6263446.java Changeset: 19431d07bc19 Author: denis Date: 2012-01-23 17:26 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/19431d07bc19 7130140: using horizontal scroll button on mouse causes a message to be printed on stdout Reviewed-by: art ! src/share/classes/java/awt/event/MouseEvent.java Changeset: 5255fd5b0418 Author: denis Date: 2012-01-24 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5255fd5b0418 7078460: JDialog is shown as separate icon on the taskbar Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: b4589ff4457c Author: malenkov Date: 2012-01-24 19:40 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b4589ff4457c 7121905: grammatically incorrect apostrophe in BeanInfo javadoc Reviewed-by: rupashka ! src/share/classes/java/beans/BeanInfo.java Changeset: 4f2a2bf0ce84 Author: rupashka Date: 2012-01-26 17:38 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4f2a2bf0ce84 7010561: Tab text position with Synth based LaF is different to Java 5/6 Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/javax/swing/JTabbedPane/7010561/bug7010561.java Changeset: cc9ff174a1c3 Author: alexsch Date: 2012-01-27 16:32 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cc9ff174a1c3 7122173: [macosx] Several Regression tests fail on MacOS Reviewed-by: rupashka + test/javax/swing/SwingUtilities/4917669/bug4917669.java + test/javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java + test/javax/swing/text/html/CSS/4530474/bug4530474.java + test/javax/swing/text/html/CSS/4530474/test.css + test/javax/swing/text/html/CSS/4530474/test.html Changeset: 96b5999af66b Author: alexsch Date: 2012-01-27 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/96b5999af66b 7109962: [macosx] closed/javax/swing/JList/6462008/bug6462008.java fails on MacOS Reviewed-by: rupashka + test/javax/swing/JList/6462008/bug6462008.java Changeset: 6a7109f52966 Author: alexsch Date: 2012-01-27 17:36 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6a7109f52966 7105040: [macosx] closed/javax/swing/JPopupMenu/4966112/bug4966112.java deadlocks on MacOS Reviewed-by: rupashka + test/javax/swing/JPopupMenu/4966112/bug4966112.java Changeset: bc1c20ac8676 Author: chegar Date: 2012-01-27 13:48 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bc1c20ac8676 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt Reviewed-by: art, prr, dholmes, alanb ! make/common/Release-embedded.gmk ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/headless/Makefile ! make/sun/jawt/Makefile ! make/sun/xawt/Makefile ! src/solaris/native/java/lang/java_props_md.c ! src/solaris/native/sun/awt/awt_LoadLibrary.c Changeset: 5dab2d55bc5b Author: lana Date: 2012-01-28 22:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5dab2d55bc5b Merge - test/java/io/File/BlockIsDirectory.java Changeset: 39b661c5867a Author: alexsch Date: 2012-01-30 12:52 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/39b661c5867a 7122149: [macosx] closed/javax/swing/UITest/UITest.java fails on MacOS Reviewed-by: rupashka ! src/share/classes/sun/awt/OSInfo.java + test/javax/swing/UITest/UITest.java Changeset: 7d6c7dd72e25 Author: malenkov Date: 2012-01-31 14:20 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7d6c7dd72e25 7122138: IAE thrown because Introspector ignores synthetic methods Reviewed-by: rupashka ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/7122138/Test7122138.java + test/java/beans/Introspector/7122138/pack/Sub.java + test/java/beans/Introspector/7122138/pack/Super.java Changeset: c5c78f293ff8 Author: rupashka Date: 2012-01-31 17:30 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c5c78f293ff8 7082443: JComboBox not backward compatible (with Java 6) Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java + test/javax/swing/JComboBox/7082443/bug7082443.java Changeset: 363086137375 Author: lana Date: 2012-01-31 19:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/363086137375 Merge Changeset: 313da5d059bf Author: valeriep Date: 2012-01-19 12:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/313da5d059bf 7092825: javax.crypto.Cipher.Transform.patternCache is synchronizedMap and became scalability bottleneck. Summary: Changed patternCache from synchronizedMap to ConcurrentHashMap. Reviewed-by: mullan ! src/share/classes/javax/crypto/Cipher.java Changeset: 71200c517524 Author: darcy Date: 2012-01-20 17:56 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/71200c517524 4504839: Java libraries should provide support for unsigned integer arithmetic 4215269: Some Integer.toHexString(int) results cannot be decoded back to an int 6322074: Converting integers to string as if unsigned Reviewed-by: mduigou, emcmanus, flar ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java + test/java/lang/Integer/Unsigned.java + test/java/lang/Long/Unsigned.java Changeset: d383b5d128e3 Author: xuelei Date: 2012-01-23 04:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d383b5d128e3 7132248: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java failing Reviewed-by: alanb ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHttpsClientTest.java Changeset: 3df0bd3ed880 Author: mullan Date: 2012-01-23 12:17 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3df0bd3ed880 7131084: XMLDSig XPathFilter2Transform regression involving intersect filter Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXPath2Filter.java ! test/javax/xml/crypto/dsig/KeySelectors.java ! test/javax/xml/crypto/dsig/ValidationTests.java ! test/javax/xml/crypto/dsig/X509KeySelector.java + test/javax/xml/crypto/dsig/data/xmldsig-xfilter2.xml Changeset: 5e1ad6ad41b7 Author: mullan Date: 2012-01-23 13:23 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5e1ad6ad41b7 Merge Changeset: 914711cccc60 Author: darcy Date: 2012-01-23 12:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/914711cccc60 7132338: Use @code friendly idiom for '\' in javadoc Reviewed-by: alanb ! src/share/classes/java/io/DataInput.java ! src/share/classes/java/io/LineNumberInputStream.java ! src/share/classes/java/io/RandomAccessFile.java ! src/share/classes/java/io/StreamTokenizer.java ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/Properties.java Changeset: 237319a01a9a Author: alanb Date: 2012-01-24 09:09 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/237319a01a9a 7132204: Default testset in JPRT should not run all tests Reviewed-by: ohair ! make/jprt.properties ! test/ProblemList.txt Changeset: 718bca4e685f Author: rbackman Date: 2012-01-17 16:20 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/718bca4e685f 7132386: makefile support for tracing/Java Flight Recorder framework phase I Reviewed-by: ohair, dholmes, rottenha Contributed-by: Markus Gronlund , Erik Gahlin , Nils Loodin , Rickard Backman , Staffan Larsen ! make/com/oracle/Makefile + make/com/oracle/jfr/Makefile ! make/common/Defs.gmk ! make/common/Release.gmk Changeset: f64ea40293db Author: ksrini Date: 2012-01-24 09:58 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f64ea40293db 7132270: tools/launcher/DefaultLocaleTestRun.java failing (win) Reviewed-by: alanb, chegar ! test/tools/launcher/DefaultLocaleTestRun.java ! test/tools/launcher/TestHelper.java Changeset: 303b67074666 Author: lancea Date: 2012-01-24 15:13 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/303b67074666 7132879: address Findbugs issue in WebRowSetXmlWriter Reviewed-by: forax ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java Changeset: ceab7e149581 Author: peytoia Date: 2012-01-26 17:06 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ceab7e149581 7017458: (cal) Multithreaded deserialization of Calendar leads to ClassCastException Reviewed-by: okutsu ! src/share/classes/java/util/Calendar.java + test/java/util/Calendar/Bug7017458.java Changeset: 350971f50949 Author: rbackman Date: 2012-01-26 09:51 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/350971f50949 7133124: Remove redundant packages from JAR command line Reviewed-by: acorn, alanb, dholmes, rottenha ! make/common/Release.gmk Changeset: b518b160607f Author: lancea Date: 2012-01-26 19:41 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b518b160607f 7133815: address the findbug errors in CachedRowSetImpl, SerialStruct, BaseRow, SerialInputImpl, SerialOutputImpl Reviewed-by: forax ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/BaseRow.java ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java Changeset: 5ee30ab905db Author: wetmore Date: 2012-01-26 17:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5ee30ab905db 7126889: Incorrect SSLEngine debug output Reviewed-by: xuelei ! src/share/classes/sun/security/ssl/EngineArgs.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh Changeset: 7aa5ddfa3c9d Author: okutsu Date: 2012-01-27 14:58 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7aa5ddfa3c9d 7130335: Problem with timezone in a SimpleDateFormat Reviewed-by: peytoia ! src/share/classes/java/text/SimpleDateFormat.java + test/java/text/Format/DateFormat/Bug7130335.java Changeset: ff24779c147f Author: valeriep Date: 2012-01-27 15:25 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ff24779c147f 7136538: typo in test/Makefile under the jdk_security3 target Summary: Fixed the typo of "secrity". Reviewed-by: wetmore ! test/Makefile Changeset: 7dbc129d8e5c Author: ksrini Date: 2012-01-28 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7dbc129d8e5c 7127906: (launcher) convert the launcher regression tests to java Reviewed-by: darcy, naoto ! test/tools/launcher/Arrrghs.java + test/tools/launcher/ChangeDataModel.java - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java ! test/tools/launcher/DefaultLocaleTestRun.java ! test/tools/launcher/ExecutionEnvironment.java ! test/tools/launcher/I18NJarTest.java + test/tools/launcher/I18NTest.java ! test/tools/launcher/MiscTests.java ! test/tools/launcher/Settings.java - test/tools/launcher/SomeException.java ! test/tools/launcher/Test7029048.java ! test/tools/launcher/TestHelper.java - test/tools/launcher/UnicodeCleanup.java ! test/tools/launcher/UnicodeTest.java - test/tools/launcher/UnicodeTest.sh ! test/tools/launcher/UnresolvedExceptions.java - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: 7a25b72b3644 Author: lana Date: 2012-01-28 20:41 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7a25b72b3644 Merge Changeset: f9fb8c4b4550 Author: dl Date: 2012-01-30 11:44 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f9fb8c4b4550 7132378: Race in FutureTask if used with explicit set ( not Runnable ) Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/FutureTask.java + test/java/util/concurrent/FutureTask/DoneTimedGetLoops.java + test/java/util/concurrent/FutureTask/ExplicitSet.java Changeset: 863a20b0bf08 Author: ngmr Date: 2012-01-10 00:07 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/863a20b0bf08 7123229: (coll) EnumMap.containsValue(null) returns true Summary: java.util.EnumMap.NULL equals() must only be true for itself Reviewed-by: alanb, mduigou Contributed-by: Neil Richards ! src/share/classes/java/util/EnumMap.java + test/java/util/EnumMap/UniqueNullValue.java Changeset: 13978750cb87 Author: ngmr Date: 2012-01-31 10:31 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/13978750cb87 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solaris/native/java/lang/UNIXProcess_md.c Changeset: 431bc327f34a Author: sla Date: 2012-01-31 10:46 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/431bc327f34a 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms Summary: Make sure HotSpot and JDK looks for well-known files in the same location Reviewed-by: dholmes, dsamersoff ! src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java ! src/solaris/classes/sun/tools/attach/SolarisVirtualMachine.java ! test/ProblemList.txt Changeset: 663a6333105d Author: sla Date: 2012-01-31 04:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/663a6333105d Merge Changeset: 533bc0a10233 Author: lana Date: 2012-01-31 19:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/533bc0a10233 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: ce62fb7aa1b8 Author: lana Date: 2012-02-07 10:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ce62fb7aa1b8 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: ec17fbe5b8fb Author: katleman Date: 2012-02-08 19:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ec17fbe5b8fb Merge From david.katleman at sun.com Thu Feb 9 04:51:01 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 09 Feb 2012 04:51:01 +0000 Subject: hg: jdk8/build/langtools: 7 new changesets Message-ID: <20120209045119.04E1947405@hg.openjdk.java.net> Changeset: 5a784dab75f1 Author: katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/5a784dab75f1 Added tag jdk8-b24 for changeset 6c9d21ca92c4 ! .hgtags Changeset: 51fb17abfc32 Author: mcimadamore Date: 2012-01-24 17:52 +0000 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/51fb17abfc32 7129801: Merge the two method applicability routines Summary: Resolve.java and Infer.java should reuse the same method applicability check routine Reviewed-by: dlsmith, jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/InferVarargsArgumentMismatch.java Changeset: ac36176b7de0 Author: jjh Date: 2012-01-24 15:51 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ac36176b7de0 7126832: com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/main/Main.java + test/tools/javah/T7126832/T7126832.java + test/tools/javah/T7126832/java.java Changeset: d16b464e742c Author: jjh Date: 2012-01-24 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d16b464e742c 7129225: javac fails to run annotation processors when star import of package of gensrc Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/7129225/Anno.java + test/tools/javac/7129225/AnnoProcessor.java + test/tools/javac/7129225/NegTest.ref + test/tools/javac/7129225/TestImportStar.java + test/tools/javac/7129225/TestImportStar.ref Changeset: 332dfa0f91df Author: jjh Date: 2012-01-25 12:20 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/332dfa0f91df 7133314: The regression test for 7129225 fails when run with jtreg -samevm or jtreg -agentvm Reviewed-by: jjg ! test/tools/javac/7129225/AnnoProcessor.java ! test/tools/javac/7129225/NegTest.ref ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/7129225/TestImportStar.ref Changeset: 7d412606d641 Author: lana Date: 2012-01-28 20:42 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7d412606d641 Merge Changeset: 520c30f85bb5 Author: lana Date: 2012-02-07 10:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/520c30f85bb5 Merge From erik.joelsson at oracle.com Thu Feb 9 09:09:32 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 09 Feb 2012 10:09:32 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F3334A6.3020700@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> <4F329662.7030200@oracle.com> <4F3334A6.3020700@oracle.com> Message-ID: <4F338D4C.3020505@oracle.com> On 2012-02-09 03:51, David Holmes wrote: > make/defs.make: > > + ifneq (,$(SPEC)) > + include $(SPEC) > + endif > > Having the blank first looks odd. I assume you aren't using -inlcude > because you want to see errors if SPEC is set but not found. > I guess it's an unconscious habit from java where you rather do "".equals(something) to avoid NPE. I will switch it around. And the assumption is correct. We used -include at first, but I figured that we wanted to know if the include failed at least on the root level Makefile. > make/windows/makefiles/compile.make: > > The definitions of MT=mt.exe in each block for the different VS > versions seems redundant. If we factor this out is there any reason > not to group: > > CXX=cl.exe > MT=mt.exe > RC=rc.exe > LD=link.exe > > together and use the same "if (,$(SPEC))" approach? > Grouping them together would certainly look nicer, but MT isn't set for every possible compiler version. Not sure if that matters since we don't support older versions anyway, right? As for testing for SPEC, this is nmake and the SPEC file is only gnumake compatible. CXX, MT, RC and LD are sent in to nmake on the command line from gnumake. They are then generated into local.make which is in turn included by sub invocations of nmake. Sending in SPEC as well seemed redundant to me, but we could send it in as a flag signaling that configure should be in control. Wouldn't look obviously better to me though. I'm open for suggestions. /Erik From erik.joelsson at oracle.com Thu Feb 9 09:33:48 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 09 Feb 2012 10:33:48 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F338D4C.3020505@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> <4F329662.7030200@oracle.com> <4F3334A6.3020700@oracle.com> <4F338D4C.3020505@oracle.com> Message-ID: <4F3392FC.4060903@oracle.com> New webrev: http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg Changes since last time: * Moved the , to after $(SPEC) * Changed comment in gcc/sparcWorks.make according to suggestion from Fredrik. Haven't changed anything regarding the nmake files. /Erik On 2012-02-09 10:09, Erik Joelsson wrote: > > On 2012-02-09 03:51, David Holmes wrote: >> make/defs.make: >> >> + ifneq (,$(SPEC)) >> + include $(SPEC) >> + endif >> >> Having the blank first looks odd. I assume you aren't using -inlcude >> because you want to see errors if SPEC is set but not found. >> > I guess it's an unconscious habit from java where you rather do > "".equals(something) to avoid NPE. I will switch it around. And the > assumption is correct. We used -include at first, but I figured that > we wanted to know if the include failed at least on the root level > Makefile. >> make/windows/makefiles/compile.make: >> >> The definitions of MT=mt.exe in each block for the different VS >> versions seems redundant. If we factor this out is there any reason >> not to group: >> >> CXX=cl.exe >> MT=mt.exe >> RC=rc.exe >> LD=link.exe >> >> together and use the same "if (,$(SPEC))" approach? >> > Grouping them together would certainly look nicer, but MT isn't set > for every possible compiler version. Not sure if that matters since we > don't support older versions anyway, right? > > As for testing for SPEC, this is nmake and the SPEC file is only > gnumake compatible. CXX, MT, RC and LD are sent in to nmake on the > command line from gnumake. They are then generated into local.make > which is in turn included by sub invocations of nmake. Sending in SPEC > as well seemed redundant to me, but we could send it in as a flag > signaling that configure should be in control. Wouldn't look obviously > better to me though. I'm open for suggestions. > > /Erik From fredrik.ohrstrom at oracle.com Thu Feb 9 09:50:27 2012 From: fredrik.ohrstrom at oracle.com (=?UTF-8?B?RnJlZHJpayDDlmhyc3Ryw7Zt?=) Date: Thu, 9 Feb 2012 01:50:27 -0800 (PST) Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable Message-ID: <1f35f096-81d8-49b7-b9a9-4c73584b1ea9@default> Looks good! //Fredrik ----- erik.joelsson at oracle.com skrev: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ > > 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg > > Changes since last time: > > * Moved the , to after $(SPEC) > * Changed comment in gcc/sparcWorks.make according to suggestion from > > Fredrik. > > Haven't changed anything regarding the nmake files. > > /Erik > > On 2012-02-09 10:09, Erik Joelsson wrote: > > > > On 2012-02-09 03:51, David Holmes wrote: > >> make/defs.make: > >> > >> + ifneq (,$(SPEC)) > >> + include $(SPEC) > >> + endif > >> > >> Having the blank first looks odd. I assume you aren't using > -inlcude > >> because you want to see errors if SPEC is set but not found. > >> > > I guess it's an unconscious habit from java where you rather do > > "".equals(something) to avoid NPE. I will switch it around. And the > > > assumption is correct. We used -include at first, but I figured that > > > we wanted to know if the include failed at least on the root level > > Makefile. > >> make/windows/makefiles/compile.make: > >> > >> The definitions of MT=mt.exe in each block for the different VS > >> versions seems redundant. If we factor this out is there any reason > > >> not to group: > >> > >> CXX=cl.exe > >> MT=mt.exe > >> RC=rc.exe > >> LD=link.exe > >> > >> together and use the same "if (,$(SPEC))" approach? > >> > > Grouping them together would certainly look nicer, but MT isn't set > > > for every possible compiler version. Not sure if that matters since > we > > don't support older versions anyway, right? > > > > As for testing for SPEC, this is nmake and the SPEC file is only > > gnumake compatible. CXX, MT, RC and LD are sent in to nmake on the > > command line from gnumake. They are then generated into local.make > > which is in turn included by sub invocations of nmake. Sending in > SPEC > > as well seemed redundant to me, but we could send it in as a flag > > signaling that configure should be in control. Wouldn't look > obviously > > better to me though. I'm open for suggestions. > > > > /Erik From david.holmes at oracle.com Thu Feb 9 10:39:32 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 09 Feb 2012 20:39:32 +1000 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F3392FC.4060903@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> <4F329662.7030200@oracle.com> <4F3334A6.3020700@oracle.com> <4F338D4C.3020505@oracle.com> <4F3392FC.4060903@oracle.com> Message-ID: <4F33A264.1010707@oracle.com> Added back runtime to the cc list On 9/02/2012 7:33 PM, Erik Joelsson wrote: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ > > 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg > > Changes since last time: > > * Moved the , to after $(SPEC) > * Changed comment in gcc/sparcWorks.make according to suggestion from > Fredrik. > > Haven't changed anything regarding the nmake files. That's okay - it was just an observation. Seems okay to me. Let's see if we can get Kelly or someone else from HS to comment. David ----- > /Erik > > On 2012-02-09 10:09, Erik Joelsson wrote: >> >> On 2012-02-09 03:51, David Holmes wrote: >>> make/defs.make: >>> >>> + ifneq (,$(SPEC)) >>> + include $(SPEC) >>> + endif >>> >>> Having the blank first looks odd. I assume you aren't using -inlcude >>> because you want to see errors if SPEC is set but not found. >>> >> I guess it's an unconscious habit from java where you rather do >> "".equals(something) to avoid NPE. I will switch it around. And the >> assumption is correct. We used -include at first, but I figured that >> we wanted to know if the include failed at least on the root level >> Makefile. >>> make/windows/makefiles/compile.make: >>> >>> The definitions of MT=mt.exe in each block for the different VS >>> versions seems redundant. If we factor this out is there any reason >>> not to group: >>> >>> CXX=cl.exe >>> MT=mt.exe >>> RC=rc.exe >>> LD=link.exe >>> >>> together and use the same "if (,$(SPEC))" approach? >>> >> Grouping them together would certainly look nicer, but MT isn't set >> for every possible compiler version. Not sure if that matters since we >> don't support older versions anyway, right? >> >> As for testing for SPEC, this is nmake and the SPEC file is only >> gnumake compatible. CXX, MT, RC and LD are sent in to nmake on the >> command line from gnumake. They are then generated into local.make >> which is in turn included by sub invocations of nmake. Sending in SPEC >> as well seemed redundant to me, but we could send it in as a flag >> signaling that configure should be in control. Wouldn't look obviously >> better to me though. I'm open for suggestions. >> >> /Erik From kelly.ohair at oracle.com Thu Feb 9 18:23:38 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 9 Feb 2012 10:23:38 -0800 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F3392FC.4060903@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> <4F329662.7030200@oracle.com> <4F3334A6.3020700@oracle.com> <4F338D4C.3020505@oracle.com> <4F3392FC.4060903@oracle.com> Message-ID: <659FB8A7-91E2-47A4-A863-7D25E5D1CFB6@oracle.com> The only issue I see is that it's using cygpath -m -a and not cygpath -s -m -a which I think means that the path could have spaces in it. Otherwise, looks fine. -kto On Feb 9, 2012, at 1:33 AM, Erik Joelsson wrote: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ > 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg > > Changes since last time: > > * Moved the , to after $(SPEC) > * Changed comment in gcc/sparcWorks.make according to suggestion from Fredrik. > > Haven't changed anything regarding the nmake files. > > /Erik > > On 2012-02-09 10:09, Erik Joelsson wrote: >> >> On 2012-02-09 03:51, David Holmes wrote: >>> make/defs.make: >>> >>> + ifneq (,$(SPEC)) >>> + include $(SPEC) >>> + endif >>> >>> Having the blank first looks odd. I assume you aren't using -inlcude because you want to see errors if SPEC is set but not found. >>> >> I guess it's an unconscious habit from java where you rather do "".equals(something) to avoid NPE. I will switch it around. And the assumption is correct. We used -include at first, but I figured that we wanted to know if the include failed at least on the root level Makefile. >>> make/windows/makefiles/compile.make: >>> >>> The definitions of MT=mt.exe in each block for the different VS versions seems redundant. If we factor this out is there any reason not to group: >>> >>> CXX=cl.exe >>> MT=mt.exe >>> RC=rc.exe >>> LD=link.exe >>> >>> together and use the same "if (,$(SPEC))" approach? >>> >> Grouping them together would certainly look nicer, but MT isn't set for every possible compiler version. Not sure if that matters since we don't support older versions anyway, right? >> >> As for testing for SPEC, this is nmake and the SPEC file is only gnumake compatible. CXX, MT, RC and LD are sent in to nmake on the command line from gnumake. They are then generated into local.make which is in turn included by sub invocations of nmake. Sending in SPEC as well seemed redundant to me, but we could send it in as a flag signaling that configure should be in control. Wouldn't look obviously better to me though. I'm open for suggestions. >> >> /Erik From kelly.ohair at oracle.com Thu Feb 9 20:42:28 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 9 Feb 2012 12:42:28 -0800 Subject: Is anyone able to build on Win 7 In-Reply-To: <4F20A816.4030108@oracle.com> References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> Message-ID: Does this article provide any help: https://kc.mcafee.com/corporate/index?page=content&id=KB55075&actp=search&viewlocale=en_US&searchid=1328818133782 It suggests that rebase'ing the CYGWIN DLL's will help. Seems a bit strange to me, just passing it on. -kto On Jan 25, 2012, at 5:10 PM, Pete Brunet wrote: > I just had success with the following changes: > - downgraded from cygwin 1.7.9 (with bash 4.1.10) to 1.7.0 (with bash > 3.2.49) > - changed ...\jdk\make\docs\Makefile line 74 > > ifeq ($(ARCH_DATA_MODEL),64) > MAX_VM_MEMORY = 1024 > else > MAX_VM_MEMORY = 1024 <--- This was 512 > endif > > I've only done one build and in prior builds had other issues besides > the memory problem, i.e. fork and error 126, but there's always hope. > > If others could report their W7 configurations and whether or not there > were problems, that would be helpful. > > Pete > > On 1/25/12 6:17 PM, Kelly O'Hair wrote: >> Sorry guys, I don't have the time or priority to track this down. >> Official builds are still happening on Windows XP and Windows 2003 X64 and these >> problems are not being seen on those systems.... yet... >> although we recently have been visited by the McAfee plague so maybe it's just a matter of time. ;^( >> >> Someone with some strong Windows experience needs to run this to ground. >> We do need this to work, eventually. >> >> -kto >> >> On Jan 25, 2012, at 9:09 AM, Pete Brunet wrote: >> >>> I started W7 in safe mode and the build failed with a fork failure. I >>> think that eliminates things in the BLODA list. If anyone out there is >>> building OK on W7 please send your configuration, e.g. as shown below. >>> Maybe that will suggest a different version of cygwin or bash. -Pete >>> >>> On 1/25/12 9:55 AM, Pete Brunet wrote: >>>> Thanks Volker, I was thinking I'm going to have to try using XP in a >>>> VM. My W7 config is very close to yours (make 3.81 instead of 3.82). >>>> >>>> W7 Pro, 64 bit, SP1 >>>> Intel Core 2 Duo, P8700, 2.53 GHz, 8 GB RAM >>>> CYGWIN_NT-6.1-WOW64 Bevo 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>> GNU bash, version 4.1.10(4)-release (i686-pc-cygwin) >>>> GNU Make 3.81 >>>> >>>> Pete >>>> >>>> On 1/25/12 9:06 AM, Volker Simonis wrote: >>>>> Hi Peter, >>>>> >>>>> glad to see that other have the same problems:) >>>>> >>>>> But seriously, on Windows 7 I'm currently experiencing the same >>>>> massive build problems and I'm not sure what the root cause of these >>>>> problems is. >>>>> >>>>> I found the following bug which exactly describes the problems I'm facing: >>>>> >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6903517 >>>>> >>>>> Among others, these are: >>>>> >>>>> - rm: cannot remove directory `META-INF': Directory not empty >>>>> - error: cannot create example2.html: Permission denied >>>>> - [javac] C:\Software\OpenJDK\jdk8\langtools\src\share\classes\com\sun\tools\javac\util\SharedNameTable.java:40: >>>>> error: error while writing SharedNameTable: >>>>> c:\Software\OpenJDK\output_amd64\langtools\build\bootstrap\classes\com\sun\tools\javac\util\SharedNameTable.class >>>>> (Access is denied) >>>>> >>>>> but I also saw the 'out of memory' and 'for' problems mentioned by you. >>>>> >>>>> The description of bug 6903517 references the "Big List of Dodgy Apps" >>>>> (http://cygwin.com/faq/faq.using.html#faq.using.bloda). This is a list >>>>> in the Cygwin FAQ which lists applications like Virus Scanners which >>>>> can interfere with Cygwin in an unpredictable way. An indeed the >>>>> Windows 7 box on which I observe the problems has some of them >>>>> installed (e.g. McAffe {Agent, GTI Proxy Agent, Intrusion Prevention, >>>>> VirusScan Enterprise, AntySpywaare Enterprise} to name just a few). >>>>> >>>>> On the other hand, on the same Windows 7 box I have a virtual machine >>>>> running inside VirtualBox with WindowsXP which has the same McAffe >>>>> software installed and it is running without any problems. The OpenJDK >>>>> build always succeeds in the virtual machine! >>>>> >>>>> So I'm not quite sure of this is: >>>>> - a problem of some additional software which is running on my Windows >>>>> 7 box and interferes with Cygwin >>>>> - a general Windows7 problem >>>>> - a problem of the specific Cygwin version I'm using >>>>> - a problem of Cygwin running on 64-bit Windows 7 >>>>> >>>>> I'll try to further narrow down the problem, but of course any hints >>>>> are highly welcome (unfortunately I can't easily get rid of the McAffe >>>>> stuff without losing my job, so please don't advise this:) >>>>> >>>>> Regards, >>>>> Volker >>>>> >>>>> PS: below you can find the exact versions of the software/hardware I'm using: >>>>> >>>>> 64-bit Windows 7, SP 1 >>>>> Dual Core Intel i7, 8GB RAM >>>>> >>>>> Cygwin (output of uname -a): >>>>> CYGWIN_NT-6.1-WOW64 WDFN00299915A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>> bash 4.1.10(4) // installed by Cygwin setup.exe >>>>> make 3.82 // compiled by myself >>>>> >>>>> In the Virtual box VM I have the following system: >>>>> >>>>> 64-bit Windows XP Professional Version 2003 SP 2 >>>>> >>>>> Cygwin (output of uname -a): >>>>> CYGWIN_NT-5.2-WOW64 WDFV00248216A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>> bash 4.1.10(4) // installed by Cygwin setup.exe >>>>> make 3.82 // compiled by myself >>>>> >>>>> >>>>> On Tue, Jan 24, 2012 at 5:52 PM, Pete Brunet wrote: >>>>>> Is anyone able to build on Win 7? I'm on my 8th build hoping to get to >>>>>> the end and have seen these errors: >>>>>> >>>>>> out of memory, 3 times - I have more than enough memory >>>>>> fork: Resource temporarily unavailable, 3 times >>>>>> error 126, once >>>>>> >>>>>> I have read http://cygwin.com/faq-nochunks.html#faq.using.bloda so >>>>>> apparently something on my system is causing a problem but I haven't >>>>>> been successful in finding it yet. I have my Norton 360 "Auto-Protect" >>>>>> turned off. It would be helpful to know if anyone has successfully >>>>>> built on Win 7 and also if anyone has ideas on what I might look for >>>>>> beyond what is listed in the cygwin FAQ. >>>>>> >>>>>> Thanks, Pete >>>>>> >>>>>> From michael.x.mcmahon at oracle.com Thu Feb 9 21:59:47 2012 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Thu, 09 Feb 2012 21:59:47 +0000 Subject: RFR 7142950: jdk7u cannot bootstrap Mac OS build [macosx] In-Reply-To: <32131CAD-A904-4DA1-8E8D-ADBDD73A6279@oracle.com> References: <4F3054B9.5070009@oracle.com> <32131CAD-A904-4DA1-8E8D-ADBDD73A6279@oracle.com> Message-ID: <4F3441D3.1010508@oracle.com> Hi, http://cr.openjdk.java.net/~michaelm/7142950/jdk/webrev.2/ This is an updated webrev based on the contribution/suggestion from Scott Kovatch. It changes the build image directories on Mac, to have the same format/directory structure as the other platforms (ie. it removes the Contents/Home stuff). That directory structure required by Mac bundles is now generated in specific bundle directories and these are used by the install. A consequence of this change is that anyone who has adjusted scripts that used the built j2sdk-image, or j2re-image to know about the mac specific paths will have to change that back again. This version of the change is almost agnostic on the "os.arch" setting. The only dependency is on 'src/macosx/bin/amd64/jvm.cfg'. That will have to be renamed to x86_64/jvm.cfg when 'os.arch' is changed. No other change is required. With this change, jdk only, and incremental builds should work again. If you are using the previous output from a control build as bootstrap or import jdk for a subsequent jdk only build, then it is possible you could run into the build problem described in 6967648. The workaround is to rename the top-level build directory to some other name before doing the jdk build. Thanks, Michael On 06/02/12 23:21, Scott Kovatch wrote: > On Feb 6, 2012, at 2:31 PM, Michael McMahon wrote: > >> There are a few problems with the Mac build at the moment. >> >> 1. If SKIP_BOOT_CYCLE=false then the build fails, due to two problems:- >> 1) top level Makefile doesn't know about Mac OS image directory >> structure >> 2) it also fails due to problem 2. below >> 2. General bootstrapping problem. The build currently cannot use >> itself as >> the bootstrap JDK due to an assumption in the framework classes that >> "os.arch" is x86_64, whereas we currently set it to amd64. The >> change is to >> fix that code to expect amd64. There is a related question then >> about what the >> correct value for os.arch should be. I'd like to raise this in a >> separate discussion >> and hopefully fix these build problems independently of that. > I was going to propose that we fix the image directory issues by > building into the image directories the same way on all platforms and > have the mac build copy the image directories into j2sdk-bundle. > (7133768) I'm pretty sure that even with this change you can't build > rt.jar because the jar tool gets moved out from underneath the running > build when the bundle is constructed. > > I don't think your changes would interfere with my proposed fix for > 7133768, though. And, the other changes for generating the folder name > dynamically are very much welcome. > > -- Scott K. > > ---------------------------------------- > Scott Kovatch > scott.kovatch at oracle.com > Santa Clara/Pleasanton, CA > -------------- next part -------------- An HTML attachment was scrubbed... URL: From John.Coomes at oracle.com Thu Feb 9 22:43:03 2012 From: John.Coomes at oracle.com (John Coomes) Date: Thu, 9 Feb 2012 14:43:03 -0800 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F3392FC.4060903@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> <4F329662.7030200@oracle.com> <4F3334A6.3020700@oracle.com> <4F338D4C.3020505@oracle.com> <4F3392FC.4060903@oracle.com> Message-ID: <20276.19447.205281.741058@oracle.com> Erik Joelsson (erik.joelsson at oracle.com) wrote: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.02/ > > 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg > > Changes since last time: > > * Moved the , to after $(SPEC) > * Changed comment in gcc/sparcWorks.make according to suggestion from > Fredrik. Looks good. One minor request: in linux/makefiles/gcc.make, you moved the setting of STRIP under the SPEC conditional. Might as well fold it into the CROSS_COMPILE_ARCH conditional that's already there. -John > On 2012-02-09 10:09, Erik Joelsson wrote: > > > > On 2012-02-09 03:51, David Holmes wrote: > >> make/defs.make: > >> > >> + ifneq (,$(SPEC)) > >> + include $(SPEC) > >> + endif > >> > >> Having the blank first looks odd. I assume you aren't using -inlcude > >> because you want to see errors if SPEC is set but not found. > >> > > I guess it's an unconscious habit from java where you rather do > > "".equals(something) to avoid NPE. I will switch it around. And the > > assumption is correct. We used -include at first, but I figured that > > we wanted to know if the include failed at least on the root level > > Makefile. > >> make/windows/makefiles/compile.make: > >> > >> The definitions of MT=mt.exe in each block for the different VS > >> versions seems redundant. If we factor this out is there any reason > >> not to group: > >> > >> CXX=cl.exe > >> MT=mt.exe > >> RC=rc.exe > >> LD=link.exe > >> > >> together and use the same "if (,$(SPEC))" approach? > >> > > Grouping them together would certainly look nicer, but MT isn't set > > for every possible compiler version. Not sure if that matters since we > > don't support older versions anyway, right? > > > > As for testing for SPEC, this is nmake and the SPEC file is only > > gnumake compatible. CXX, MT, RC and LD are sent in to nmake on the > > command line from gnumake. They are then generated into local.make > > which is in turn included by sub invocations of nmake. Sending in SPEC > > as well seemed redundant to me, but we could send it in as a flag > > signaling that configure should be in control. Wouldn't look obviously > > better to me though. I'm open for suggestions. > > > > /Erik From erik.joelsson at oracle.com Fri Feb 10 09:25:50 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 10 Feb 2012 10:25:50 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <20276.19447.205281.741058@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> <4F329662.7030200@oracle.com> <4F3334A6.3020700@oracle.com> <4F338D4C.3020505@oracle.com> <4F3392FC.4060903@oracle.com> <20276.19447.205281.741058@oracle.com> Message-ID: <4F34E29E.6060603@oracle.com> Posted new webrev: http://cr.openjdk.java.net/~erikj/7141244/webrev.03/ 172 lines changed: 84 ins; 29 del; 59 mod; 3970 unchg See comments inline. On 2012-02-09 19:23, Kelly O'Hair wrote: > The only issue I see is that it's using cygpath -m -a and not cygpath -s -m -a > which I think means that the path could have spaces in it. > Thanks for the review! There were indeed spaces in my own setup, but the quotes handled it. Getting rid of spaces is a good thing though so I added -s and it still works on my windows machine. On 2012-02-09 23:43, John Coomes wrote: > Looks good. One minor request: in linux/makefiles/gcc.make, you > moved the setting of STRIP under the SPEC conditional. Might as well > fold it into the CROSS_COMPILE_ARCH conditional that's already there. > Thanks for the review! That did look rather weird, I agree. Fixed it. /Erik From Kelly.Ohair at oracle.com Fri Feb 10 17:18:37 2012 From: Kelly.Ohair at oracle.com (Kelly O'Hair) Date: Fri, 10 Feb 2012 09:18:37 -0800 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F34E29E.6060603@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> <4F329662.7030200@oracle.com> <4F3334A6.3020700@oracle.com> <4F338D4C.3020505@oracle.com> <4F3392FC.4060903@oracle.com> <20276.19447.205281.741058@oracle.com> <4F34E29E.6060603@oracle.com> Message-ID: <5C17C081-2586-4E2A-9058-900106D30961@oracle.com> Looks good to me. I assume you will work with John or someone in the hotspot team to get this integrated into one of the hotspot integration areas? -kto On Feb 10, 2012, at 1:25 AM, Erik Joelsson wrote: > Posted new webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.03/ > 172 lines changed: 84 ins; 29 del; 59 mod; 3970 unchg > > See comments inline. > > On 2012-02-09 19:23, Kelly O'Hair wrote: >> The only issue I see is that it's using cygpath -m -a and not cygpath -s -m -a >> which I think means that the path could have spaces in it. >> > Thanks for the review! There were indeed spaces in my own setup, but the quotes handled it. Getting rid of spaces is a good thing though so I added -s and it still works on my windows machine. > > On 2012-02-09 23:43, John Coomes wrote: >> Looks good. One minor request: in linux/makefiles/gcc.make, you >> moved the setting of STRIP under the SPEC conditional. Might as well >> fold it into the CROSS_COMPILE_ARCH conditional that's already there. >> > Thanks for the review! That did look rather weird, I agree. Fixed it. > > /Erik From oehrstroem at gmail.com Sat Feb 11 09:17:22 2012 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Sat, 11 Feb 2012 10:17:22 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <5C17C081-2586-4E2A-9058-900106D30961@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F31D427.4020103@oracle.com> <4F322EFD.6050900@oracle.com> <4F329662.7030200@oracle.com> <4F3334A6.3020700@oracle.com> <4F338D4C.3020505@oracle.com> <4F3392FC.4060903@oracle.com> <20276.19447.205281.741058@oracle.com> <4F34E29E.6060603@oracle.com> <5C17C081-2586-4E2A-9058-900106D30961@oracle.com> Message-ID: 2012/2/10 Kelly O'Hair : > Looks good to me. > > I assume you will work with John or someone in the hotspot team to get this integrated into > one of the hotspot integration areas? Yes, we are already working with David Holmes to get these patches committed into hotspot. //Fredrik From peter.brunet at oracle.com Mon Feb 13 17:08:39 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 13 Feb 2012 11:08:39 -0600 Subject: building part of jdk 8 In-Reply-To: <4F2AEFC4.5010907@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> Message-ID: <4F394397.5050401@oracle.com> This worked for me today for building just awt: This is in my bat file. The first two sets are what resolved my issue. set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug set ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/windows-i586-fastdebug/j2sdk-image set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin set CLASSPATH= set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; set CYGWIN=nodosfilewarning cd c:\Users\Pete\cygwin\bin bash --login -i Then at the cygwin command line: eval `bin/vsvars.sh -v10 -32` cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ make ARCH_DATA_MODEL=32 2>&1 | tee build.log Note: I suspect I don't need wbem in my path; I'll remove it the next time I do a build. Pete On 2/2/12 2:19 PM, Pete Brunet wrote: > On 2/1/12 10:54 PM, Pete Brunet wrote: >> On 1/23/12 9:39 AM, Pete Brunet wrote: >>> In the past I was able to build part of jdk 8 but that is not currently >>> working although I am able to do a full 32 bit build. I've recently >>> moved from XP to W7 so my environment might not be set up quite right >>> yet. Here's what I do... >>> >>> // These are done in a bat file before I do any makes >>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>> set CLASSPATH= >>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>> set CYGWIN=nodosfilewarning >>> cd c:\Users\Pete\cygwin\bin >>> bash --login -i >>> >>> // These are done at the command line >>> eval `bin/vsvars.sh -v10 -32` >>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >>> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >>> >>> The error I am getting is >>> >>> make: *** No rule to make target >>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>> `compile_all_props'. Stop. >> When building below the top level, for some reason a partial build >> directory is being created in jdk8/jdk. When doing a full build from >> the top level the only build directory I see is the one in jdk8. It >> appears that ../../../build/... is using the build under jdk rather than >> the build under the top level. >> >> Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: >> >> make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' >> make[2]: *** No rule to make target `javax/swing/JLabel', needed by >> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >> >> and when trying to build directly at .../jdk/make/javax/swing, i.e. >> >> make: *** No rule to make target `javax/swing/JLabel', needed by >> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. > The JLabel issue was caused by the existence of > ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is > Windows' scheme for copies.). However, that wouldn't explain the use of > a build directory under jdk (instead of under the top level), i.e. my > original problem might have been caused by using the wrong build dir: > > make: *** No rule to make target > `../../../build/windows-i586/btjars/compileproperties.jar', needed by > `compile_all_props'. Stop. > >> In case it's helpful jdk/build contains these directories: >> bin >> btbins >> btclasses >> btjars >> classes >> gensrc >> include >> lib >>> Since the above has windows-i586 instead of windows-i586-debug it looks >>> like I need to add another variable when invoking make. >>> >>> Pete From kelly.ohair at oracle.com Mon Feb 13 19:35:07 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 13 Feb 2012 11:35:07 -0800 Subject: building part of jdk 8 In-Reply-To: <4F394397.5050401@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> Message-ID: <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> Just a few comments below... On Feb 13, 2012, at 9:08 AM, Pete Brunet wrote: > This worked for me today for building just awt: > > This is in my bat file. The first two sets are what resolved my issue. > set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug > set > ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/windows-i586-fastdebug/j2sdk-image The above two settings make no sense to me. ALT_OUTPUTDIR is supposed to point at the directory where you want the build results to go. One of the directories created is the j2sdk-image. This is a huge disk write area. ALT_JDK_IMPORT_PATH is something you set when you are doing partial builds, e.g. not building hotspot. It needs to point at some place that is pretty golden and steady, for a place to get parts of the jdk image that you are not building. You have it set to the same place you are building. :^( That seems fishy to me. I would have done a full build, moved or copied j2sdk-image to some place safe, and had ALT_JDK_IMPORT_PATH refer to that copy, where it would be safe from destruction during the build. > set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 The official boot jdk for jdk8 is actually the first shipping jdk7, although 7u2 should work, our release engineering and automated build systems use jdk7 fcs. > set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include > set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 > set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 > set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin Not sure why ALT_MSDEVTOOLS_PATH is needed. Did you find this necessary for some reason? > set CLASSPATH= > set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; > set CYGWIN=nodosfilewarning > cd c:\Users\Pete\cygwin\bin > bash --login -i This bash command will add /usr/bin to the PATH, and convert PATH to the CYGWIN world. > > Then at the cygwin command line: > eval `bin/vsvars.sh -v10 -32` Perfect. That adjusts PATH, LIB, INCLUDE, etc, all for the Visual Studio compiler. > cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ > make ARCH_DATA_MODEL=32 2>&1 | tee build.log Yup. > > Note: I suspect I don't need wbem in my path; I'll remove it the next > time I do a build. I've never been sure about Wbem needing to be in the system path. Let me know what you find out. ---- So this is Windows 7 right? Is it Windows 7 X64 or X86? (32 or 64 bit OS) Do you have any anti-virus software installed, and any special settings? Is this the latest CYGWIN? (what does uname -a say?) There have been reports of problems with Windows 7 building, possibly involving CYGWIN and McAfee colliding somehow. Just curious. -kto > > Pete > > On 2/2/12 2:19 PM, Pete Brunet wrote: >> On 2/1/12 10:54 PM, Pete Brunet wrote: >>> On 1/23/12 9:39 AM, Pete Brunet wrote: >>>> In the past I was able to build part of jdk 8 but that is not currently >>>> working although I am able to do a full 32 bit build. I've recently >>>> moved from XP to W7 so my environment might not be set up quite right >>>> yet. Here's what I do... >>>> >>>> // These are done in a bat file before I do any makes >>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>> set CLASSPATH= >>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>> set CYGWIN=nodosfilewarning >>>> cd c:\Users\Pete\cygwin\bin >>>> bash --login -i >>>> >>>> // These are done at the command line >>>> eval `bin/vsvars.sh -v10 -32` >>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >>>> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >>>> >>>> The error I am getting is >>>> >>>> make: *** No rule to make target >>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>> `compile_all_props'. Stop. >>> When building below the top level, for some reason a partial build >>> directory is being created in jdk8/jdk. When doing a full build from >>> the top level the only build directory I see is the one in jdk8. It >>> appears that ../../../build/... is using the build under jdk rather than >>> the build under the top level. >>> >>> Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: >>> >>> make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' >>> make[2]: *** No rule to make target `javax/swing/JLabel', needed by >>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>> >>> and when trying to build directly at .../jdk/make/javax/swing, i.e. >>> >>> make: *** No rule to make target `javax/swing/JLabel', needed by >>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >> The JLabel issue was caused by the existence of >> ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is >> Windows' scheme for copies.). However, that wouldn't explain the use of >> a build directory under jdk (instead of under the top level), i.e. my >> original problem might have been caused by using the wrong build dir: >> >> make: *** No rule to make target >> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >> `compile_all_props'. Stop. >> >>> In case it's helpful jdk/build contains these directories: >>> bin >>> btbins >>> btclasses >>> btjars >>> classes >>> gensrc >>> include >>> lib >>>> Since the above has windows-i586 instead of windows-i586-debug it looks >>>> like I need to add another variable when invoking make. >>>> >>>> Pete From peter.brunet at oracle.com Mon Feb 13 20:12:48 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 13 Feb 2012 14:12:48 -0600 Subject: building part of jdk 8 In-Reply-To: <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> Message-ID: <4F396EC0.2010004@oracle.com> On 2/13/12 1:35 PM, Kelly O'Hair wrote: > Just a few comments below... > > On Feb 13, 2012, at 9:08 AM, Pete Brunet wrote: > >> This worked for me today for building just awt: >> >> This is in my bat file. The first two sets are what resolved my issue. >> set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug >> set >> ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/windows-i586-fastdebug/j2sdk-image > The above two settings make no sense to me. > > ALT_OUTPUTDIR is supposed to point at the directory where you want the build results to go. > One of the directories created is the j2sdk-image. This is a huge disk write area. I think I needed this to make my partial build use the same directory as my fastdebug_build full build. > > ALT_JDK_IMPORT_PATH is something you set when you are doing partial builds, e.g. > not building hotspot. It needs to point at some place that is pretty golden and steady, for > a place to get parts of the jdk image that you are not building. > You have it set to the same place you are building. :^( That seems fishy to me. > I would have done a full build, moved or copied j2sdk-image to some place safe, and > had ALT_JDK_IMPORT_PATH refer to that copy, where it would be safe from destruction > during the build. I only build parts of awt and swing so maybe I've been lucky. In any event I made that change. > >> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 > The official boot jdk for jdk8 is actually the first shipping jdk7, although 7u2 should work, > our release engineering and automated build systems use jdk7 fcs. > >> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin > Not sure why ALT_MSDEVTOOLS_PATH is needed. Did you find this necessary for some reason? > >> set CLASSPATH= >> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >> set CYGWIN=nodosfilewarning >> cd c:\Users\Pete\cygwin\bin >> bash --login -i > This bash command will add /usr/bin to the PATH, and convert PATH to the CYGWIN world. Do I need to change something? > >> Then at the cygwin command line: >> eval `bin/vsvars.sh -v10 -32` > Perfect. That adjusts PATH, LIB, INCLUDE, etc, all for the Visual Studio compiler. > >> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ >> make ARCH_DATA_MODEL=32 2>&1 | tee build.log > Yup. > >> Note: I suspect I don't need wbem in my path; I'll remove it the next >> time I do a build. > I've never been sure about Wbem needing to be in the system path. Let me know what you find out. Rebuilding after tweaking awt_Component.cpp worked fine without this. I'll report back at some other time after doing a full rebuild. > > ---- > So this is Windows 7 right? > Is it Windows 7 X64 or X86? (32 or 64 bit OS) 64 bit Windows 7 > Do you have any anti-virus software installed, and any special settings? I have Norton 360 and for a full build I disable auto-protect. I don't bother disabling that for a partial build. > Is this the latest CYGWIN? (what does uname -a say?) 1.7.0 (I dropped back from using 1.7.9 and so far this has been working, but I haven't done enough full builds yet to be sure.) Pete > > There have been reports of problems with Windows 7 building, possibly involving CYGWIN and McAfee > colliding somehow. Just curious. > > -kto > >> Pete >> >> On 2/2/12 2:19 PM, Pete Brunet wrote: >>> On 2/1/12 10:54 PM, Pete Brunet wrote: >>>> On 1/23/12 9:39 AM, Pete Brunet wrote: >>>>> In the past I was able to build part of jdk 8 but that is not currently >>>>> working although I am able to do a full 32 bit build. I've recently >>>>> moved from XP to W7 so my environment might not be set up quite right >>>>> yet. Here's what I do... >>>>> >>>>> // These are done in a bat file before I do any makes >>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>> set CLASSPATH= >>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>> set CYGWIN=nodosfilewarning >>>>> cd c:\Users\Pete\cygwin\bin >>>>> bash --login -i >>>>> >>>>> // These are done at the command line >>>>> eval `bin/vsvars.sh -v10 -32` >>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >>>>> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >>>>> >>>>> The error I am getting is >>>>> >>>>> make: *** No rule to make target >>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>> `compile_all_props'. Stop. >>>> When building below the top level, for some reason a partial build >>>> directory is being created in jdk8/jdk. When doing a full build from >>>> the top level the only build directory I see is the one in jdk8. It >>>> appears that ../../../build/... is using the build under jdk rather than >>>> the build under the top level. >>>> >>>> Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: >>>> >>>> make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' >>>> make[2]: *** No rule to make target `javax/swing/JLabel', needed by >>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>> >>>> and when trying to build directly at .../jdk/make/javax/swing, i.e. >>>> >>>> make: *** No rule to make target `javax/swing/JLabel', needed by >>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>> The JLabel issue was caused by the existence of >>> ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is >>> Windows' scheme for copies.). However, that wouldn't explain the use of >>> a build directory under jdk (instead of under the top level), i.e. my >>> original problem might have been caused by using the wrong build dir: >>> >>> make: *** No rule to make target >>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>> `compile_all_props'. Stop. >>> >>>> In case it's helpful jdk/build contains these directories: >>>> bin >>>> btbins >>>> btclasses >>>> btjars >>>> classes >>>> gensrc >>>> include >>>> lib >>>>> Since the above has windows-i586 instead of windows-i586-debug it looks >>>>> like I need to add another variable when invoking make. >>>>> >>>>> Pete From kelly.ohair at oracle.com Mon Feb 13 21:13:46 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 13 Feb 2012 13:13:46 -0800 Subject: building part of jdk 8 In-Reply-To: <4F396EC0.2010004@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> <4F396EC0.2010004@oracle.com> Message-ID: <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> On Feb 13, 2012, at 12:12 PM, Pete Brunet wrote: > On 2/13/12 1:35 PM, Kelly O'Hair wrote: >> Just a few comments below... >> >> On Feb 13, 2012, at 9:08 AM, Pete Brunet wrote: >> >>> This worked for me today for building just awt: >>> >>> This is in my bat file. The first two sets are what resolved my issue. >>> set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug >>> set >>> ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/windows-i586-fastdebug/j2sdk-image >> The above two settings make no sense to me. >> >> ALT_OUTPUTDIR is supposed to point at the directory where you want the build results to go. >> One of the directories created is the j2sdk-image. This is a huge disk write area. > I think I needed this to make my partial build use the same directory as > my fastdebug_build full build. Understood. That's a perfectly valid reason. >> >> ALT_JDK_IMPORT_PATH is something you set when you are doing partial builds, e.g. >> not building hotspot. It needs to point at some place that is pretty golden and steady, for >> a place to get parts of the jdk image that you are not building. >> You have it set to the same place you are building. :^( That seems fishy to me. >> I would have done a full build, moved or copied j2sdk-image to some place safe, and >> had ALT_JDK_IMPORT_PATH refer to that copy, where it would be safe from destruction >> during the build. > I only build parts of awt and swing so maybe I've been lucky. In any > event I made that change. >> >>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >> The official boot jdk for jdk8 is actually the first shipping jdk7, although 7u2 should work, >> our release engineering and automated build systems use jdk7 fcs. >> >>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >> Not sure why ALT_MSDEVTOOLS_PATH is needed. Did you find this necessary for some reason? >> >>> set CLASSPATH= >>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>> set CYGWIN=nodosfilewarning >>> cd c:\Users\Pete\cygwin\bin >>> bash --login -i >> This bash command will add /usr/bin to the PATH, and convert PATH to the CYGWIN world. > Do I need to change something? No you are perfectly fine. I was just commenting that the PATH setting has changed. I always keep track of when PATH changes. >> >>> Then at the cygwin command line: >>> eval `bin/vsvars.sh -v10 -32` >> Perfect. That adjusts PATH, LIB, INCLUDE, etc, all for the Visual Studio compiler. >> >>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ >>> make ARCH_DATA_MODEL=32 2>&1 | tee build.log >> Yup. >> >>> Note: I suspect I don't need wbem in my path; I'll remove it the next >>> time I do a build. >> I've never been sure about Wbem needing to be in the system path. Let me know what you find out. > Rebuilding after tweaking awt_Component.cpp worked fine without this. > I'll report back at some other time after doing a full rebuild. http://www.pcreview.co.uk/forums/do-need-wbem-path-statement-t2330116.html My tendency is to leave Wbem in PATH. Not sure we need it, but why vary the standard Windows PATH and ask for trouble? ;^) -kto >> >> ---- >> So this is Windows 7 right? >> Is it Windows 7 X64 or X86? (32 or 64 bit OS) > 64 bit Windows 7 >> Do you have any anti-virus software installed, and any special settings? > I have Norton 360 and for a full build I disable auto-protect. I don't > bother disabling that for a partial build. >> Is this the latest CYGWIN? (what does uname -a say?) > 1.7.0 (I dropped back from using 1.7.9 and so far this has been working, > but I haven't done enough full builds yet to be sure.) > > Pete >> >> There have been reports of problems with Windows 7 building, possibly involving CYGWIN and McAfee >> colliding somehow. Just curious. >> >> -kto >> >>> Pete >>> >>> On 2/2/12 2:19 PM, Pete Brunet wrote: >>>> On 2/1/12 10:54 PM, Pete Brunet wrote: >>>>> On 1/23/12 9:39 AM, Pete Brunet wrote: >>>>>> In the past I was able to build part of jdk 8 but that is not currently >>>>>> working although I am able to do a full 32 bit build. I've recently >>>>>> moved from XP to W7 so my environment might not be set up quite right >>>>>> yet. Here's what I do... >>>>>> >>>>>> // These are done in a bat file before I do any makes >>>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>>> set CLASSPATH= >>>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>>> set CYGWIN=nodosfilewarning >>>>>> cd c:\Users\Pete\cygwin\bin >>>>>> bash --login -i >>>>>> >>>>>> // These are done at the command line >>>>>> eval `bin/vsvars.sh -v10 -32` >>>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >>>>>> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >>>>>> >>>>>> The error I am getting is >>>>>> >>>>>> make: *** No rule to make target >>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>> `compile_all_props'. Stop. >>>>> When building below the top level, for some reason a partial build >>>>> directory is being created in jdk8/jdk. When doing a full build from >>>>> the top level the only build directory I see is the one in jdk8. It >>>>> appears that ../../../build/... is using the build under jdk rather than >>>>> the build under the top level. >>>>> >>>>> Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: >>>>> >>>>> make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' >>>>> make[2]: *** No rule to make target `javax/swing/JLabel', needed by >>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>> >>>>> and when trying to build directly at .../jdk/make/javax/swing, i.e. >>>>> >>>>> make: *** No rule to make target `javax/swing/JLabel', needed by >>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>> The JLabel issue was caused by the existence of >>>> ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is >>>> Windows' scheme for copies.). However, that wouldn't explain the use of >>>> a build directory under jdk (instead of under the top level), i.e. my >>>> original problem might have been caused by using the wrong build dir: >>>> >>>> make: *** No rule to make target >>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>> `compile_all_props'. Stop. >>>> >>>>> In case it's helpful jdk/build contains these directories: >>>>> bin >>>>> btbins >>>>> btclasses >>>>> btjars >>>>> classes >>>>> gensrc >>>>> include >>>>> lib >>>>>> Since the above has windows-i586 instead of windows-i586-debug it looks >>>>>> like I need to add another variable when invoking make. >>>>>> >>>>>> Pete From volker.simonis at gmail.com Tue Feb 14 11:29:52 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 14 Feb 2012 12:29:52 +0100 Subject: Is anyone able to build on Win 7 In-Reply-To: References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> Message-ID: Hi Kelly, that's an interesting hint. I looked at it and tried to understand what's behind it. Here's what I found out - if I'm wrong or if somebody has additional information I would appreciate any correction! 1. Windows DLLs have a base address which indicates the virtual base address where they would like to get loaded to. 2. If this address is already in use, the operating system chooses another base address and the DLL is relocated to that new base address. Relocation should be no problem for a DLL, but apparently the implementation of "fork()" in Cygwin is very picky about these base addresses and "..needs to have a very special memory layout to implement the fork semantics in Win32. If this memory layout is disrupted, fork breaks.." (from http://www.cygwin.com/ml/cygwin/2009-05/msg00413.html). 3. The McAffe knowledge base entry cited by Kelly states: "..When a Cygwin DLL fails to load to the default address, Windows arbitrarily chooses an available address and loads it there. That works only as long as Windows chooses the same address every time, but there are a lot of conditions during startup that may affect the outcome." 4. Cygwin comes with its own rebase tool (/bin/rebaseall) which "..does its best to locate all Cygwin DLLs that it knows of into a layout that avoids collisions.." "rebaseall" is usually called by setup.exe so if you do not manually install any DLLs, this shouldn't be a problem. I indeed ran 'rebaseall' (call 'rebaseall --help' for an instruction how to use it) without any positive effect and I assume this is because all the DLLs already had non-overlapping base addresses. There's one thing to keep in mind however: Cygwins 'rebaseall' can not rebase 'cygwin1.dll' because it is linked against it. To rebase 'cygwin1.dll' one has to use another rebase tool (e.g. "C:\Program Files\Microsoft SDKs\Windows\v7.1\Bin\ReBase.Exe" from the MS SDK). I've done that but that even worsened things (probably because it is not so easy to rebase cygwin1.dll to a meaningful new base address without knowing the memory layout of 32-bit Windows processes:). 5. During all these experiments I ran across another new Windows7 feature called ASLR (Address Space Layout Randomization, see http://en.wikipedia.org/wiki/Address_space_layout_randomization). Actually it is not really new in Windows 7 but from what I've read it is implemented much more aggressively in Windows 7. On Windows 7, ASLR can only be disabled by using the Enhanced Mitigation Experience Toolkit provided by Microsoft (http://support.microsoft.com/kb/2458544), (the HKLM\SYSTEM\CurrentControlSet\Control\Session Manager\Memory Management\MoveImages registry setting has no effect in Windows 7) 6. The default setting for ASLR is still "application opt in" which means that only applications which want will be randomized. You can check this for example with the Cygwins /usr/bin/peflags tool. It will display something like "[-dynamicbase]" for applications which don't want to be randomized. Now all Cygwin DLL's have "-dynamicbase", so why should this be a problem? My naive explanation is that the Cygwin DLLs still depend an native Windows runtime DLLs and they all will be randomized by default. If now one of these Windows sysytem DLLs will be placed at the default base address of a Cygwin DLL, the Cygwin DLL will have to be relocated with the outcome described in 2. 7. I switched ASLR off (you need to reboot afterwards) and was able to do 4 consecutive, full builds without any error. After that I switched ASLR on again, rebooted and the second build failed with the well known "fork" problem. To cut a long story short: - disabling "on access" scanning of *.{java,c,cpp,h,hpp} seems to resolve the file io problems (permission denied, access denied) - disabling ASLR seems to resolve the "fork" problems I would be graceful if anybody could confirm these findings or can come up with another, better solution/explanation. Regards, Volker On Thu, Feb 9, 2012 at 9:42 PM, Kelly O'Hair wrote: > > Does this article provide any help: > > https://kc.mcafee.com/corporate/index?page=content&id=KB55075&actp=search&viewlocale=en_US&searchid=1328818133782 > > It suggests that rebase'ing the CYGWIN DLL's will help. Seems a bit strange to me, just passing it on. > > -kto > > On Jan 25, 2012, at 5:10 PM, Pete Brunet wrote: > >> I just had success with the following changes: >> - downgraded from cygwin 1.7.9 (with bash 4.1.10) to 1.7.0 (with bash >> 3.2.49) >> - changed ...\jdk\make\docs\Makefile line 74 >> >> ifeq ($(ARCH_DATA_MODEL),64) >> ?MAX_VM_MEMORY = 1024 >> else >> ?MAX_VM_MEMORY = 1024 <--- This was 512 >> endif >> >> I've only done one build and in prior builds had other issues besides >> the memory problem, i.e. fork and error 126, but there's always hope. >> >> If others could report their W7 configurations and whether or not there >> were problems, that would be helpful. >> >> Pete >> >> On 1/25/12 6:17 PM, Kelly O'Hair wrote: >>> Sorry guys, I don't have the time or priority to track this down. >>> Official builds are still happening on Windows XP and Windows 2003 X64 and these >>> problems are not being seen on those systems.... yet... >>> although we recently have been visited by the McAfee plague so maybe it's just a matter of time. ;^( >>> >>> Someone with some strong Windows experience needs to run this to ground. >>> We do need this to work, eventually. >>> >>> -kto >>> >>> On Jan 25, 2012, at 9:09 AM, Pete Brunet wrote: >>> >>>> I started W7 in safe mode and the build failed with a fork failure. ?I >>>> think that eliminates things in the BLODA list. ?If anyone out there is >>>> building OK on W7 please send your configuration, e.g. as shown below. >>>> Maybe that will suggest a different version of cygwin or bash. ?-Pete >>>> >>>> On 1/25/12 9:55 AM, Pete Brunet wrote: >>>>> Thanks Volker, I was thinking I'm going to have to try using XP in a >>>>> VM. ?My W7 config is very close to yours (make 3.81 instead of 3.82). >>>>> >>>>> W7 Pro, 64 bit, SP1 >>>>> Intel Core 2 Duo, P8700, 2.53 GHz, 8 GB RAM >>>>> CYGWIN_NT-6.1-WOW64 Bevo 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>> GNU bash, version 4.1.10(4)-release (i686-pc-cygwin) >>>>> GNU Make 3.81 >>>>> >>>>> Pete >>>>> >>>>> On 1/25/12 9:06 AM, Volker Simonis wrote: >>>>>> Hi Peter, >>>>>> >>>>>> glad to see that other have the same problems:) >>>>>> >>>>>> But seriously, on Windows 7 I'm currently experiencing the same >>>>>> massive build problems and I'm not sure what the root cause of these >>>>>> problems is. >>>>>> >>>>>> I found the following bug which exactly describes the problems I'm facing: >>>>>> >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6903517 >>>>>> >>>>>> Among others, these are: >>>>>> >>>>>> - rm: cannot remove directory `META-INF': Directory not empty >>>>>> - error: ?cannot create example2.html: Permission denied >>>>>> - [javac] C:\Software\OpenJDK\jdk8\langtools\src\share\classes\com\sun\tools\javac\util\SharedNameTable.java:40: >>>>>> error: error while writing SharedNameTable: >>>>>> c:\Software\OpenJDK\output_amd64\langtools\build\bootstrap\classes\com\sun\tools\javac\util\SharedNameTable.class >>>>>> (Access is denied) >>>>>> >>>>>> but I also saw the 'out of memory' and 'for' problems mentioned by you. >>>>>> >>>>>> The description of bug 6903517 references the "Big List of Dodgy Apps" >>>>>> (http://cygwin.com/faq/faq.using.html#faq.using.bloda). This is a list >>>>>> in the Cygwin FAQ which lists applications like Virus Scanners which >>>>>> can interfere with Cygwin in an unpredictable way. An indeed the >>>>>> Windows 7 box on which I observe the problems has some of them >>>>>> installed (e.g. McAffe {Agent, GTI Proxy Agent, Intrusion Prevention, >>>>>> VirusScan Enterprise, AntySpywaare Enterprise} to name just a few). >>>>>> >>>>>> On the other hand, on the same Windows 7 box I have a virtual machine >>>>>> running inside VirtualBox ?with WindowsXP which has the same McAffe >>>>>> software installed and it is running without any problems. The OpenJDK >>>>>> build always succeeds in the virtual machine! >>>>>> >>>>>> So I'm not quite sure of this is: >>>>>> - a problem of some additional software which is running on my Windows >>>>>> 7 box and interferes with Cygwin >>>>>> - a general Windows7 problem >>>>>> - a problem of the specific Cygwin version I'm using >>>>>> - a problem of Cygwin running on 64-bit Windows 7 >>>>>> >>>>>> I'll try to further narrow down the problem, but of course any hints >>>>>> are highly welcome (unfortunately I can't easily get rid of the McAffe >>>>>> stuff without losing my job, so please don't advise this:) >>>>>> >>>>>> Regards, >>>>>> Volker >>>>>> >>>>>> PS: below you can find the exact versions of the software/hardware I'm using: >>>>>> >>>>>> 64-bit Windows 7, SP 1 >>>>>> Dual Core Intel i7, 8GB RAM >>>>>> >>>>>> Cygwin (output of uname -a): >>>>>> CYGWIN_NT-6.1-WOW64 WDFN00299915A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>>> bash 4.1.10(4) ?// installed by Cygwin setup.exe >>>>>> make 3.82 ?// compiled by myself >>>>>> >>>>>> In the Virtual box VM I have the following system: >>>>>> >>>>>> 64-bit Windows XP Professional Version 2003 SP 2 >>>>>> >>>>>> Cygwin (output of uname -a): >>>>>> CYGWIN_NT-5.2-WOW64 WDFV00248216A 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin >>>>>> bash 4.1.10(4) ?// installed by Cygwin setup.exe >>>>>> make 3.82 ?// compiled by myself >>>>>> >>>>>> >>>>>> On Tue, Jan 24, 2012 at 5:52 PM, Pete Brunet wrote: >>>>>>> Is anyone able to build on Win 7? ?I'm on my 8th build hoping to get to >>>>>>> the end and have seen these errors: >>>>>>> >>>>>>> out of memory, 3 times - I have more than enough memory >>>>>>> fork: Resource temporarily unavailable, 3 times >>>>>>> error 126, once >>>>>>> >>>>>>> I have read http://cygwin.com/faq-nochunks.html#faq.using.bloda so >>>>>>> apparently something on my system is causing a problem but I haven't >>>>>>> been successful in finding it yet. ?I have my Norton 360 "Auto-Protect" >>>>>>> turned off. ?It would be helpful to know if anyone has successfully >>>>>>> built on Win 7 and also if anyone has ideas on what I might look for >>>>>>> beyond what is listed in the cygwin FAQ. >>>>>>> >>>>>>> Thanks, Pete >>>>>>> >>>>>>> > From fredrik.ohrstrom at oracle.com Tue Feb 14 11:43:49 2012 From: fredrik.ohrstrom at oracle.com (=?UTF-8?B?RnJlZHJpayDDlmhyc3Ryw7Zt?=) Date: Tue, 14 Feb 2012 12:43:49 +0100 Subject: Is anyone able to build on Win 7 In-Reply-To: References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> Message-ID: <4F3A48F5.60705@oracle.com> 2012-02-14 12:29, Volker Simonis skrev: > To cut a long story short: > - disabling "on access" scanning of *.{java,c,cpp,h,hpp} seems to > resolve the file io problems (permission denied, access denied) > - disabling ASLR seems to resolve the "fork" problems Great work! Do you know if disabling ASLR affects the fork performance on 64 bit windows? //Fredrik From fredrik.ohrstrom at oracle.com Tue Feb 14 13:47:07 2012 From: fredrik.ohrstrom at oracle.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Tue, 14 Feb 2012 14:47:07 +0100 Subject: Question about BUILD_HEADLESS and HEADLESS Message-ID: <4F3A65DB.6030307@oracle.com> Is the use of HEADLESS in gcc.make (linux and bsd) an archaeological remnant and should be removed? (No source in the hotspot repo looks a the HEADLESS define.) Is there any reason to not build a headless version of awt? (ie modify BUILD_HEADLESS to not be defined.) It seeems like headless is not currently built on bsd/macosx/windows, but it is built on solaris and linux? //Fredrik From michael.x.mcmahon at oracle.com Tue Feb 14 14:49:42 2012 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Tue, 14 Feb 2012 14:49:42 +0000 Subject: Question about BUILD_HEADLESS and HEADLESS In-Reply-To: <4F3A65DB.6030307@oracle.com> References: <4F3A65DB.6030307@oracle.com> Message-ID: <4F3A7486.5010107@oracle.com> On 14/02/12 13:47, Fredrik ?hrstr?m wrote: > Is the use of HEADLESS in gcc.make (linux and bsd) an archaeological > remnant and should be removed? (No source in the hotspot repo looks a > the HEADLESS define.) > > Is there any reason to not build a headless version of awt? (ie modify > BUILD_HEADLESS to not be defined.) > It seeems like headless is not currently built on bsd/macosx/windows, > but it is built on solaris and linux? > > //Fredrik Fredrik, It's being built on macosx as well. - Michael. From volker.simonis at gmail.com Tue Feb 14 14:59:11 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 14 Feb 2012 15:59:11 +0100 Subject: Is anyone able to build on Win 7 In-Reply-To: <4F3A48F5.60705@oracle.com> References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> <4F3A48F5.60705@oracle.com> Message-ID: On Tue, Feb 14, 2012 at 12:43 PM, Fredrik ?hrstr?m wrote: > 2012-02-14 12:29, Volker Simonis skrev: >> To cut a long story short: >> - disabling "on access" scanning of *.{java,c,cpp,h,hpp} seems to >> resolve the file io problems (permission denied, access denied) >> - disabling ASLR seems to resolve the "fork" problems > > Great work! Do you know if disabling ASLR affects the fork performance > on 64 bit windows? > No, definitely not. The build time on my DualCore i7 @ 2.7 GHz notebook with 8GB Ram is constantly 1h43min for a full JDK8 opt build. Now that that the build seems stable I want to compare it with a Linux build in a VirtualBox VM on the same host. I'll let you know the results once I'm done, but I don't think that "fork" is the big problem - at least not the only one. But once you asked here's my main suspect since long time (you asked so you have to read the conspiracy:) stat (or lstat/fstat/stat64 ...) --------------------------------- I'm quite sure that the poor implementation of stat in Cygwin and its usage in make is one of the main reasons why the build Windows build is so terrible slow in Windows compared to Linux. I first realized this years ago when I was first building Windows inside a VMWare image with the sources on network shares. The build times were excessively long and it was not the compile times because SMB shares do a quite efficient caching - it was the times which make needed in order to check the build dependencies. The build times could be improved by factors if the sources were moved to a local disc. But even locallly, I think that the stat calls for large dependency lists as we have them in the OpenJDK build may still be one of the causes for the slow build. Running make inside strace will reveal the shear number of these calls and there is evidence that the stat performance is really poor in Cygwin. I'll attach some unsorted links to some of the resources which discuss this issue just in case somebody wants to deep dive into this topic. I'm definitely not a Windows/Cygwin expert and I can't promise I'll have the time to solve it 'real soon' but I'll definitely stick to this topic because it is a real PITA (especially if you want to change your build from MKS to Cygwin the developers who will first love you because freed them from of the MKS licensing night mare will very soon kill you because of the build times:) "performance issue with cgywin make" http://www.mail-archive.com/make-w32 at gnu.org/msg01353.html - mailing list thread which compares the bad performance of Cygwin make with MS nmake and discusses how some of the problems have been solved in CMake by using direct windows sys-calls instead of stat. "make 3.82 performing more stat() calls than 3.81" http://lists.gnu.org/archive/html/bug-make/2011-09/msg00025.html - mailing list thread discussing a bug in make 3.82 which leads to even more calls to stat (and has been fixed already in the head revision of make) "Cygwin Performance and stat()" http://omgili.com/mailinglist/cygwin/cygwin/com/efe8a37b2e4466daa7b6eb1aa610c3d7squirrelwwwwebmailwingertorg.html - very long thrad, very ?flamy?, no outcome, some interesting infos nevertheless "cygwin: Use native Win32 API for stat" http://marc.info/?l=git&m=122278284210941 - partial patch for the problem by implementing a stripped down version of stat which does just enough... "_NutFastStat(), _NutFastStat64()" http://www.mkssoftware.com/docs/man3/_NutFastStat.3.asp - MKSs limited but faster version of stat (not sure if MKS make uses this, but that may be an explanation why builds under MKS are reported to be considerably faster compared to Cygwin builds "Managing Projects with GNU Make, 3rd Edition, The Power of GNU make for Building Anything, By Robert Mecklenburg" http://shop.oreilly.com/product/9780596006105.do - Chapter 10: "Improving the Performance of make" freely available as PDF download: http://reilly.com/catalog/make3/book/ch10.pdf "Compile time Local Cygwin vs. VMware session on same system" http://cygwin.com/ml/cygwin/2008-10/threads.html#00415 - mail thread suggesting the usage of ?dash? instead of ?bash? for a >10% performance improvement > //Fredrik > From philip.race at oracle.com Tue Feb 14 17:27:49 2012 From: philip.race at oracle.com (Phil Race) Date: Tue, 14 Feb 2012 09:27:49 -0800 Subject: Question about BUILD_HEADLESS and HEADLESS In-Reply-To: <4F3A7486.5010107@oracle.com> References: <4F3A65DB.6030307@oracle.com> <4F3A7486.5010107@oracle.com> Message-ID: <4F3A9995.8010009@oracle.com> On windows headless is simply a state. But Solaris/Linux have "true" headless builds where there are headless (stub) versions of UI libraries. And I think that headless is a valid JCK mode .. you can pass JCK in headless on platforms that don't support UI. But I'd check the JCK guys on that one, don't take my word for it. -phk. On 2/14/2012 6:49 AM, Michael McMahon wrote: > On 14/02/12 13:47, Fredrik ?hrstr?m wrote: >> Is the use of HEADLESS in gcc.make (linux and bsd) an archaeological >> remnant and should be removed? (No source in the hotspot repo looks a >> the HEADLESS define.) >> >> Is there any reason to not build a headless version of awt? (ie modify >> BUILD_HEADLESS to not be defined.) >> It seeems like headless is not currently built on bsd/macosx/windows, >> but it is built on solaris and linux? >> >> //Fredrik > Fredrik, > > It's being built on macosx as well. > > - Michael. From kelly.ohair at oracle.com Tue Feb 14 19:07:01 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 14 Feb 2012 11:07:01 -0800 Subject: Is anyone able to build on Win 7 In-Reply-To: References: <4F1EE1BA.7010805@oracle.com> <4F2025FA.2050609@oracle.com> <4F203763.8050807@oracle.com> <7012C95D-45EC-4D1D-BFF1-0AF05CE46232@oracle.com> <4F20A816.4030108@oracle.com> <4F3A48F5.60705@oracle.com> Message-ID: <3B025719-3F92-4C8A-9057-2F4B8AF73644@oracle.com> Fantastic information set. Many thanks for all this digging. I suspect, that our build infrastructure work may help, in that if we get rid of the nested makes, then I can only assume we will be doing fewer stat() calls, but I think we still have a problem. A year or so ago, I managed to reduce the fork/exec count by 50% thinking it would improve windows build times, it did very little, I was disappointed, and assumed the bigger spike had to be related to I/O. So I tried a fast SSD on a Windows machine, which sure made it quiet, but also didn't help much. So I'm with you on the stat() theory, makes a great deal of sense. -kto On Feb 14, 2012, at 6:59 AM, Volker Simonis wrote: > On Tue, Feb 14, 2012 at 12:43 PM, Fredrik ?hrstr?m > wrote: >> 2012-02-14 12:29, Volker Simonis skrev: >>> To cut a long story short: >>> - disabling "on access" scanning of *.{java,c,cpp,h,hpp} seems to >>> resolve the file io problems (permission denied, access denied) >>> - disabling ASLR seems to resolve the "fork" problems >> >> Great work! Do you know if disabling ASLR affects the fork performance >> on 64 bit windows? >> > > No, definitely not. > The build time on my DualCore i7 @ 2.7 GHz notebook with 8GB Ram is > constantly 1h43min for a full JDK8 opt build. > > Now that that the build seems stable I want to compare it with a Linux > build in a VirtualBox VM on the same host. > I'll let you know the results once I'm done, but I don't think that > "fork" is the big problem - at least not the only one. > > But once you asked here's my main suspect since long time (you asked > so you have to read the conspiracy:) > > stat (or lstat/fstat/stat64 ...) > --------------------------------- > > I'm quite sure that the poor implementation of stat in Cygwin and its > usage in make is one of the main reasons > why the build Windows build is so terrible slow in Windows compared to Linux. > > I first realized this years ago when I was first building Windows > inside a VMWare image with the sources on > network shares. The build times were excessively long and it was not > the compile times because SMB shares > do a quite efficient caching - it was the times which make needed in > order to check the build dependencies. > The build times could be improved by factors if the sources were moved > to a local disc. > > But even locallly, I think that the stat calls for large dependency > lists as we have them in the OpenJDK build > may still be one of the causes for the slow build. Running make inside > strace will reveal the shear number > of these calls and there is evidence that the stat performance is > really poor in Cygwin. > > I'll attach some unsorted links to some of the resources which discuss > this issue just in case somebody wants to > deep dive into this topic. I'm definitely not a Windows/Cygwin expert > and I can't promise I'll have the time > to solve it 'real soon' but I'll definitely stick to this topic > because it is a real PITA (especially if you want to > change your build from MKS to Cygwin the developers who will first > love you because freed them from of > the MKS licensing night mare will very soon kill you because of the > build times:) > > "performance issue with cgywin make" > http://www.mail-archive.com/make-w32 at gnu.org/msg01353.html > > - mailing list thread which compares the bad performance of Cygwin > make with MS nmake and discusses > how some of the problems have been solved in CMake by using direct > windows sys-calls instead of stat. > > "make 3.82 performing more stat() calls than 3.81" > http://lists.gnu.org/archive/html/bug-make/2011-09/msg00025.html > > - mailing list thread discussing a bug in make 3.82 which leads to > even more calls to stat > (and has been fixed already in the head revision of make) > > > "Cygwin Performance and stat()" > http://omgili.com/mailinglist/cygwin/cygwin/com/efe8a37b2e4466daa7b6eb1aa610c3d7squirrelwwwwebmailwingertorg.html > > - very long thrad, very ?flamy?, no outcome, some interesting infos nevertheless > > "cygwin: Use native Win32 API for stat" > http://marc.info/?l=git&m=122278284210941 > > - partial patch for the problem by implementing a stripped down > version of stat which does just enough... > > "_NutFastStat(), _NutFastStat64()" > http://www.mkssoftware.com/docs/man3/_NutFastStat.3.asp > > - MKSs limited but faster version of stat (not sure if MKS make uses > this, but that may be an > explanation why builds under MKS are reported to be considerably > faster compared to Cygwin builds > > "Managing Projects with GNU Make, 3rd Edition, The Power of GNU make > for Building Anything, By Robert Mecklenburg" > http://shop.oreilly.com/product/9780596006105.do > > - Chapter 10: "Improving the Performance of make" freely available as > PDF download: > http://reilly.com/catalog/make3/book/ch10.pdf > > > "Compile time Local Cygwin vs. VMware session on same system" > http://cygwin.com/ml/cygwin/2008-10/threads.html#00415 > > - mail thread suggesting the usage of ?dash? instead of ?bash? for a >> 10% performance improvement > >> //Fredrik >> From peter.brunet at oracle.com Wed Feb 15 03:35:04 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Tue, 14 Feb 2012 21:35:04 -0600 Subject: building part of jdk 8 In-Reply-To: <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> <4F396EC0.2010004@oracle.com> <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> Message-ID: <4F3B27E8.8040309@oracle.com> I don't know if this is a problem but it's something I noticed. When I do the full fastdebug_build build there are two directories under C:\OpenJDK\jdk8\build\windows-i586-fastdebug\tmp\sun\sun.awt\awt, i.e. CClassHeaders and Obj_gO. When I then do the partial build of awt (described in the history below) a new directory, obj, is added and populated. On 2/13/12 3:13 PM, Kelly O'Hair wrote: > On Feb 13, 2012, at 12:12 PM, Pete Brunet wrote: > >> On 2/13/12 1:35 PM, Kelly O'Hair wrote: >>> Just a few comments below... >>> >>> On Feb 13, 2012, at 9:08 AM, Pete Brunet wrote: >>> >>>> This worked for me today for building just awt: >>>> >>>> This is in my bat file. The first two sets are what resolved my issue. >>>> set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug >>>> set >>>> ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/windows-i586-fastdebug/j2sdk-image >>> The above two settings make no sense to me. >>> >>> ALT_OUTPUTDIR is supposed to point at the directory where you want the build results to go. >>> One of the directories created is the j2sdk-image. This is a huge disk write area. >> I think I needed this to make my partial build use the same directory as >> my fastdebug_build full build. > Understood. That's a perfectly valid reason. > >>> ALT_JDK_IMPORT_PATH is something you set when you are doing partial builds, e.g. >>> not building hotspot. It needs to point at some place that is pretty golden and steady, for >>> a place to get parts of the jdk image that you are not building. >>> You have it set to the same place you are building. :^( That seems fishy to me. >>> I would have done a full build, moved or copied j2sdk-image to some place safe, and >>> had ALT_JDK_IMPORT_PATH refer to that copy, where it would be safe from destruction >>> during the build. >> I only build parts of awt and swing so maybe I've been lucky. In any >> event I made that change. >>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>> The official boot jdk for jdk8 is actually the first shipping jdk7, although 7u2 should work, >>> our release engineering and automated build systems use jdk7 fcs. >>> >>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>> Not sure why ALT_MSDEVTOOLS_PATH is needed. Did you find this necessary for some reason? >>> >>>> set CLASSPATH= >>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>> set CYGWIN=nodosfilewarning >>>> cd c:\Users\Pete\cygwin\bin >>>> bash --login -i >>> This bash command will add /usr/bin to the PATH, and convert PATH to the CYGWIN world. >> Do I need to change something? > No you are perfectly fine. I was just commenting that the PATH setting has changed. > I always keep track of when PATH changes. > >>>> Then at the cygwin command line: >>>> eval `bin/vsvars.sh -v10 -32` >>> Perfect. That adjusts PATH, LIB, INCLUDE, etc, all for the Visual Studio compiler. >>> >>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ >>>> make ARCH_DATA_MODEL=32 2>&1 | tee build.log >>> Yup. >>> >>>> Note: I suspect I don't need wbem in my path; I'll remove it the next >>>> time I do a build. >>> I've never been sure about Wbem needing to be in the system path. Let me know what you find out. >> Rebuilding after tweaking awt_Component.cpp worked fine without this. >> I'll report back at some other time after doing a full rebuild. > http://www.pcreview.co.uk/forums/do-need-wbem-path-statement-t2330116.html > > My tendency is to leave Wbem in PATH. Not sure we need it, but why vary the standard Windows > PATH and ask for trouble? ;^) > > -kto > >>> ---- >>> So this is Windows 7 right? >>> Is it Windows 7 X64 or X86? (32 or 64 bit OS) >> 64 bit Windows 7 >>> Do you have any anti-virus software installed, and any special settings? >> I have Norton 360 and for a full build I disable auto-protect. I don't >> bother disabling that for a partial build. >>> Is this the latest CYGWIN? (what does uname -a say?) >> 1.7.0 (I dropped back from using 1.7.9 and so far this has been working, >> but I haven't done enough full builds yet to be sure.) >> >> Pete >>> There have been reports of problems with Windows 7 building, possibly involving CYGWIN and McAfee >>> colliding somehow. Just curious. >>> >>> -kto >>> >>>> Pete >>>> >>>> On 2/2/12 2:19 PM, Pete Brunet wrote: >>>>> On 2/1/12 10:54 PM, Pete Brunet wrote: >>>>>> On 1/23/12 9:39 AM, Pete Brunet wrote: >>>>>>> In the past I was able to build part of jdk 8 but that is not currently >>>>>>> working although I am able to do a full 32 bit build. I've recently >>>>>>> moved from XP to W7 so my environment might not be set up quite right >>>>>>> yet. Here's what I do... >>>>>>> >>>>>>> // These are done in a bat file before I do any makes >>>>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>>>> set CLASSPATH= >>>>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>>>> set CYGWIN=nodosfilewarning >>>>>>> cd c:\Users\Pete\cygwin\bin >>>>>>> bash --login -i >>>>>>> >>>>>>> // These are done at the command line >>>>>>> eval `bin/vsvars.sh -v10 -32` >>>>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >>>>>>> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >>>>>>> >>>>>>> The error I am getting is >>>>>>> >>>>>>> make: *** No rule to make target >>>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>>> `compile_all_props'. Stop. >>>>>> When building below the top level, for some reason a partial build >>>>>> directory is being created in jdk8/jdk. When doing a full build from >>>>>> the top level the only build directory I see is the one in jdk8. It >>>>>> appears that ../../../build/... is using the build under jdk rather than >>>>>> the build under the top level. >>>>>> >>>>>> Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: >>>>>> >>>>>> make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' >>>>>> make[2]: *** No rule to make target `javax/swing/JLabel', needed by >>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>>> >>>>>> and when trying to build directly at .../jdk/make/javax/swing, i.e. >>>>>> >>>>>> make: *** No rule to make target `javax/swing/JLabel', needed by >>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>> The JLabel issue was caused by the existence of >>>>> ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is >>>>> Windows' scheme for copies.). However, that wouldn't explain the use of >>>>> a build directory under jdk (instead of under the top level), i.e. my >>>>> original problem might have been caused by using the wrong build dir: >>>>> >>>>> make: *** No rule to make target >>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>> `compile_all_props'. Stop. >>>>> >>>>>> In case it's helpful jdk/build contains these directories: >>>>>> bin >>>>>> btbins >>>>>> btclasses >>>>>> btjars >>>>>> classes >>>>>> gensrc >>>>>> include >>>>>> lib >>>>>>> Since the above has windows-i586 instead of windows-i586-debug it looks >>>>>>> like I need to add another variable when invoking make. >>>>>>> >>>>>>> Pete From david.holmes at oracle.com Wed Feb 15 04:44:24 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 15 Feb 2012 14:44:24 +1000 Subject: Question about BUILD_HEADLESS and HEADLESS In-Reply-To: <4F3A65DB.6030307@oracle.com> References: <4F3A65DB.6030307@oracle.com> Message-ID: <4F3B3828.80703@oracle.com> On 14/02/2012 11:47 PM, Fredrik ?hrstr?m wrote: > Is the use of HEADLESS in gcc.make (linux and bsd) an archaeological > remnant and should be removed? (No source in the hotspot repo looks a > the HEADLESS define.) I agree this seems superfluous. There's no use of the HEADLESS define in the Hotspot sources. > Is there any reason to not build a headless version of awt? (ie modify > BUILD_HEADLESS to not be defined.) > It seeems like headless is not currently built on bsd/macosx/windows, > but it is built on solaris and linux? I'm not sure what you are asking. BUILD_HEADLESS is a JDK build flag. As you say it is set true in the linux and solaris Def-.gmk files, and AFAICS it is only used in one place in make/sun/headless/Makefile Note: BUILD_HEADLESS_ONLY is an unrelated option that was added to support special SE Embedded builds on platforms with no X11 includes or libraries available at all. David ----- > > //Fredrik From michael.x.mcmahon at oracle.com Wed Feb 15 09:42:37 2012 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Wed, 15 Feb 2012 09:42:37 +0000 Subject: Question about BUILD_HEADLESS and HEADLESS In-Reply-To: <4F3A9995.8010009@oracle.com> References: <4F3A65DB.6030307@oracle.com> <4F3A7486.5010107@oracle.com> <4F3A9995.8010009@oracle.com> Message-ID: <4F3B7E0D.4070708@oracle.com> The stub library is headless/libmawt.so*. Right? It's being built on Mac OS as well, but currently being put in a different location to the normal one. It also seems like it is not being used because if you rename or delete it, there isn't any change in behavior, which sounds like a bug. So, what exactly is the function of the stub library? Is it to allow some functions of awt to work that don't require a real display? In any case, I don't see why Mac should be different from Solaris or Linux in this respect. - Michael. * In 8 it has a different name, but it'll be built on Mac as well in 8. On 14/02/12 17:27, Phil Race wrote: > On windows headless is simply a state. > But Solaris/Linux have "true" headless builds where there are headless > (stub) versions of UI libraries. > And I think that headless is a valid JCK mode .. you can pass JCK in > headless > on platforms that don't support UI. But I'd check the JCK guys on that > one, > don't take my word for it. > > -phk. > > On 2/14/2012 6:49 AM, Michael McMahon wrote: >> On 14/02/12 13:47, Fredrik ?hrstr?m wrote: >>> Is the use of HEADLESS in gcc.make (linux and bsd) an archaeological >>> remnant and should be removed? (No source in the hotspot repo looks a >>> the HEADLESS define.) >>> >>> Is there any reason to not build a headless version of awt? (ie modify >>> BUILD_HEADLESS to not be defined.) >>> It seeems like headless is not currently built on bsd/macosx/windows, >>> but it is built on solaris and linux? >>> >>> //Fredrik >> Fredrik, >> >> It's being built on macosx as well. >> >> - Michael. > From fredrik.ohrstrom at oracle.com Wed Feb 15 11:48:01 2012 From: fredrik.ohrstrom at oracle.com (=?UTF-8?B?RnJlZHJpayDDlmhyc3Ryw7Zt?=) Date: Wed, 15 Feb 2012 03:48:01 -0800 (PST) Subject: Question about BUILD_HEADLESS and HEADLESS Message-ID: <58fa3921-bddd-4b7f-9f2f-7ff165e47624@default> ----- david.holmes at oracle.com skrev: > I'm not sure what you are asking. BUILD_HEADLESS is a JDK build flag. > As you say it is set true in the linux and solaris Def-.gmk files, > and AFAICS it is only used in one place in make/sun/headless/Makefile > > Note: BUILD_HEADLESS_ONLY is an unrelated option that was added to > support special SE Embedded builds on platforms with no X11 includes > or libraries available at all. Ok, the question concerns the api for configuring the build. My personal opinion now, is that the build should always compile support for headless execution of the jdk. But you can disable the compilation of head support with ./configure --disable-head This seems to be consistent with the actual usage of the old makefile variables according to the answers I got to this question. //Fredrik From fredrik.ohrstrom at oracle.com Wed Feb 15 12:10:00 2012 From: fredrik.ohrstrom at oracle.com (=?UTF-8?B?RnJlZHJpayDDlmhyc3Ryw7Zt?=) Date: Wed, 15 Feb 2012 04:10:00 -0800 (PST) Subject: Is anyone able to build on Win 7 Message-ID: ----- kelly.ohair at oracle.com skrev: > So I'm with you on the stat() theory, makes a great deal of sense. The stat theory is very interesting, but it is unclear to me if it explains all of the problem. I setup a quadruple boot x86_64 machine with 4GB of ram and 4 cores: Winxp 32bit Win7 64bit Solaris 64bit Ubuntu 64bit And tested the build times on the different OS:es. Ubuntu Fastest by far. Solaris, slower, but this is only because of bad CC performance. Winxp, even slower but still ok. Win7, ridiculously slow. The configure script prints one line per second! Clearly, just running a bash script in cygwin/win7/64bit is problematic. If we get 10% speedup from dash, then that is not going to help because the slowdown is a factor 10. Could someone try out the difference between a 32bit win7 clean install and a 64 bit win7 clean install when running the latest cygwin and just the build-infra/jdk8/common/autoconf/configure script? (My patience for installing many OSes into the same box, just ran out. And virtualization testing can give a hint, but cannot be entirely trusted.) //Fredrik From erik.joelsson at oracle.com Wed Feb 15 15:06:43 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 15 Feb 2012 16:06:43 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F3151B7.7000806@oracle.com> References: <4F3151B7.7000806@oracle.com> Message-ID: <4F3BCA03.9050707@oracle.com> New webrev: http://cr.openjdk.java.net/~erikj/7141244/webrev.04/ 175 lines changed: 87 ins; 29 del; 59 mod; 3970 unchg I discovered that the -include $(SPEC) line needed to be added to the make/{bsd,solaris,linux}/makefiles/buildtree.make files. Otherwise the hotspot build won't respect setting OPENJDK=true in the spec. It seems the windows build isn't respecting the OPENJDK variable today so I won't bother fixing that. /Erik On 2012-02-07 17:30, Erik Joelsson wrote: > http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ > > 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg > > 7141244: build-infra merge: Include $(SPEC) in makefiles and make > variables overridable > > The build-infra project is starting to move into jdk8. For the hotspot > build to stay compatible with the changes, key hotspot makefiles need > to add an optional include statement: > > > -include $(SPEC) > > In the new build system, the spec file is generated by configure and > contains the configuration for the build. Only a handfull of files > need to add this line. > > In addition to including the spec file, some variables need to be > changed to only be set conditionally so that a value from the spec > file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, > NAWK (and for windows RC and MT). The hotspot makefiles should check > each variable if it's already set or if it has a gnumake default value. > > These changes have been verified to work for hotspot-rt. Jdk7u will be > verified as well before pushing. > > /Erik > From kelly.ohair at oracle.com Wed Feb 15 16:37:51 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 15 Feb 2012 08:37:51 -0800 Subject: building part of jdk 8 In-Reply-To: <4F3B27E8.8040309@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> <4F396EC0.2010004@oracle.com> <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> <4F3B27E8.8040309@oracle.com> Message-ID: The debug (obj_g/), fastdebug (obj_gO/), and product (obj/) directories keep the different .o or .obj files separate, since there is no guarantee that these can be mixed together and work. All compilations for a library need to be the same kind of compilation. -kto On Feb 14, 2012, at 7:35 PM, Pete Brunet wrote: > I don't know if this is a problem but it's something I noticed. When I > do the full fastdebug_build build there are two directories under > C:\OpenJDK\jdk8\build\windows-i586-fastdebug\tmp\sun\sun.awt\awt, i.e. > CClassHeaders and Obj_gO. When I then do the partial build of awt > (described in the history below) a new directory, obj, is added and > populated. > > On 2/13/12 3:13 PM, Kelly O'Hair wrote: >> On Feb 13, 2012, at 12:12 PM, Pete Brunet wrote: >> >>> On 2/13/12 1:35 PM, Kelly O'Hair wrote: >>>> Just a few comments below... >>>> >>>> On Feb 13, 2012, at 9:08 AM, Pete Brunet wrote: >>>> >>>>> This worked for me today for building just awt: >>>>> >>>>> This is in my bat file. The first two sets are what resolved my issue. >>>>> set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug >>>>> set >>>>> ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/windows-i586-fastdebug/j2sdk-image >>>> The above two settings make no sense to me. >>>> >>>> ALT_OUTPUTDIR is supposed to point at the directory where you want the build results to go. >>>> One of the directories created is the j2sdk-image. This is a huge disk write area. >>> I think I needed this to make my partial build use the same directory as >>> my fastdebug_build full build. >> Understood. That's a perfectly valid reason. >> >>>> ALT_JDK_IMPORT_PATH is something you set when you are doing partial builds, e.g. >>>> not building hotspot. It needs to point at some place that is pretty golden and steady, for >>>> a place to get parts of the jdk image that you are not building. >>>> You have it set to the same place you are building. :^( That seems fishy to me. >>>> I would have done a full build, moved or copied j2sdk-image to some place safe, and >>>> had ALT_JDK_IMPORT_PATH refer to that copy, where it would be safe from destruction >>>> during the build. >>> I only build parts of awt and swing so maybe I've been lucky. In any >>> event I made that change. >>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>> The official boot jdk for jdk8 is actually the first shipping jdk7, although 7u2 should work, >>>> our release engineering and automated build systems use jdk7 fcs. >>>> >>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>> Not sure why ALT_MSDEVTOOLS_PATH is needed. Did you find this necessary for some reason? >>>> >>>>> set CLASSPATH= >>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>> set CYGWIN=nodosfilewarning >>>>> cd c:\Users\Pete\cygwin\bin >>>>> bash --login -i >>>> This bash command will add /usr/bin to the PATH, and convert PATH to the CYGWIN world. >>> Do I need to change something? >> No you are perfectly fine. I was just commenting that the PATH setting has changed. >> I always keep track of when PATH changes. >> >>>>> Then at the cygwin command line: >>>>> eval `bin/vsvars.sh -v10 -32` >>>> Perfect. That adjusts PATH, LIB, INCLUDE, etc, all for the Visual Studio compiler. >>>> >>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ >>>>> make ARCH_DATA_MODEL=32 2>&1 | tee build.log >>>> Yup. >>>> >>>>> Note: I suspect I don't need wbem in my path; I'll remove it the next >>>>> time I do a build. >>>> I've never been sure about Wbem needing to be in the system path. Let me know what you find out. >>> Rebuilding after tweaking awt_Component.cpp worked fine without this. >>> I'll report back at some other time after doing a full rebuild. >> http://www.pcreview.co.uk/forums/do-need-wbem-path-statement-t2330116.html >> >> My tendency is to leave Wbem in PATH. Not sure we need it, but why vary the standard Windows >> PATH and ask for trouble? ;^) >> >> -kto >> >>>> ---- >>>> So this is Windows 7 right? >>>> Is it Windows 7 X64 or X86? (32 or 64 bit OS) >>> 64 bit Windows 7 >>>> Do you have any anti-virus software installed, and any special settings? >>> I have Norton 360 and for a full build I disable auto-protect. I don't >>> bother disabling that for a partial build. >>>> Is this the latest CYGWIN? (what does uname -a say?) >>> 1.7.0 (I dropped back from using 1.7.9 and so far this has been working, >>> but I haven't done enough full builds yet to be sure.) >>> >>> Pete >>>> There have been reports of problems with Windows 7 building, possibly involving CYGWIN and McAfee >>>> colliding somehow. Just curious. >>>> >>>> -kto >>>> >>>>> Pete >>>>> >>>>> On 2/2/12 2:19 PM, Pete Brunet wrote: >>>>>> On 2/1/12 10:54 PM, Pete Brunet wrote: >>>>>>> On 1/23/12 9:39 AM, Pete Brunet wrote: >>>>>>>> In the past I was able to build part of jdk 8 but that is not currently >>>>>>>> working although I am able to do a full 32 bit build. I've recently >>>>>>>> moved from XP to W7 so my environment might not be set up quite right >>>>>>>> yet. Here's what I do... >>>>>>>> >>>>>>>> // These are done in a bat file before I do any makes >>>>>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>>>>> set CLASSPATH= >>>>>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>>>>> set CYGWIN=nodosfilewarning >>>>>>>> cd c:\Users\Pete\cygwin\bin >>>>>>>> bash --login -i >>>>>>>> >>>>>>>> // These are done at the command line >>>>>>>> eval `bin/vsvars.sh -v10 -32` >>>>>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >>>>>>>> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >>>>>>>> >>>>>>>> The error I am getting is >>>>>>>> >>>>>>>> make: *** No rule to make target >>>>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>>>> `compile_all_props'. Stop. >>>>>>> When building below the top level, for some reason a partial build >>>>>>> directory is being created in jdk8/jdk. When doing a full build from >>>>>>> the top level the only build directory I see is the one in jdk8. It >>>>>>> appears that ../../../build/... is using the build under jdk rather than >>>>>>> the build under the top level. >>>>>>> >>>>>>> Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: >>>>>>> >>>>>>> make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' >>>>>>> make[2]: *** No rule to make target `javax/swing/JLabel', needed by >>>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>>>> >>>>>>> and when trying to build directly at .../jdk/make/javax/swing, i.e. >>>>>>> >>>>>>> make: *** No rule to make target `javax/swing/JLabel', needed by >>>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>>> The JLabel issue was caused by the existence of >>>>>> ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is >>>>>> Windows' scheme for copies.). However, that wouldn't explain the use of >>>>>> a build directory under jdk (instead of under the top level), i.e. my >>>>>> original problem might have been caused by using the wrong build dir: >>>>>> >>>>>> make: *** No rule to make target >>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>> `compile_all_props'. Stop. >>>>>> >>>>>>> In case it's helpful jdk/build contains these directories: >>>>>>> bin >>>>>>> btbins >>>>>>> btclasses >>>>>>> btjars >>>>>>> classes >>>>>>> gensrc >>>>>>> include >>>>>>> lib >>>>>>>> Since the above has windows-i586 instead of windows-i586-debug it looks >>>>>>>> like I need to add another variable when invoking make. >>>>>>>> >>>>>>>> Pete From peter.brunet at oracle.com Wed Feb 15 17:01:52 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Wed, 15 Feb 2012 11:01:52 -0600 Subject: building part of jdk 8 In-Reply-To: References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> <4F396EC0.2010004@oracle.com> <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> <4F3B27E8.8040309@oracle.com> Message-ID: <4F3BE500.4010001@oracle.com> Thanks Kelly, That's interesting. That might provide a hint regarding a problem I am working on. When I do a full fastdebug_build build with my patch applied I get a hang when exiting the app, but when I do a subsequent partial build (with the side effect of using obj instead of obj_gO) there is no problem. What do I have to change in the following partial build invocation to compile with fastdebug (and use the fastdebug obj_gO directory) or to compile with debug (and use the debug obj_g directory)? eval `bin/vsvars.sh -v10 -32` cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ make ARCH_DATA_MODEL=32 2>&1 | tee build.log As a reminder, this is what I do before invoking cywin: set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug set ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/j2sdk-image set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 set CLASSPATH= set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; set CYGWIN=nodosfilewarning And if anyone has an idea why using obj_gO results in a hang on exit but using obj doesn't that would be helpful. Maybe when building just awt there is a mismatch between the awt obj files and the rest of the obj files that make up awt.dll. Or maybe my full build needs to be a product build rather than a fastdebug_build build (to ensure a match between my full and partial builds). Is that done by removing fastdebug_build when running make at the top level? Pete On 2/15/12 10:37 AM, Kelly O'Hair wrote: > The debug (obj_g/), fastdebug (obj_gO/), and product (obj/) directories keep the different .o or .obj files > separate, since there is no guarantee that these can be mixed together and work. > All compilations for a library need to be the same kind of compilation. > > -kto > > On Feb 14, 2012, at 7:35 PM, Pete Brunet wrote: > >> I don't know if this is a problem but it's something I noticed. When I >> do the full fastdebug_build build there are two directories under >> C:\OpenJDK\jdk8\build\windows-i586-fastdebug\tmp\sun\sun.awt\awt, i.e. >> CClassHeaders and Obj_gO. When I then do the partial build of awt >> (described in the history below) a new directory, obj, is added and >> populated. >> >> On 2/13/12 3:13 PM, Kelly O'Hair wrote: >>> On Feb 13, 2012, at 12:12 PM, Pete Brunet wrote: >>> >>>> On 2/13/12 1:35 PM, Kelly O'Hair wrote: >>>>> Just a few comments below... >>>>> >>>>> On Feb 13, 2012, at 9:08 AM, Pete Brunet wrote: >>>>> >>>>>> This worked for me today for building just awt: >>>>>> >>>>>> This is in my bat file. The first two sets are what resolved my issue. >>>>>> set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug >>>>>> set >>>>>> ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/windows-i586-fastdebug/j2sdk-image >>>>> The above two settings make no sense to me. >>>>> >>>>> ALT_OUTPUTDIR is supposed to point at the directory where you want the build results to go. >>>>> One of the directories created is the j2sdk-image. This is a huge disk write area. >>>> I think I needed this to make my partial build use the same directory as >>>> my fastdebug_build full build. >>> Understood. That's a perfectly valid reason. >>> >>>>> ALT_JDK_IMPORT_PATH is something you set when you are doing partial builds, e.g. >>>>> not building hotspot. It needs to point at some place that is pretty golden and steady, for >>>>> a place to get parts of the jdk image that you are not building. >>>>> You have it set to the same place you are building. :^( That seems fishy to me. >>>>> I would have done a full build, moved or copied j2sdk-image to some place safe, and >>>>> had ALT_JDK_IMPORT_PATH refer to that copy, where it would be safe from destruction >>>>> during the build. >>>> I only build parts of awt and swing so maybe I've been lucky. In any >>>> event I made that change. >>>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>> The official boot jdk for jdk8 is actually the first shipping jdk7, although 7u2 should work, >>>>> our release engineering and automated build systems use jdk7 fcs. >>>>> >>>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>> Not sure why ALT_MSDEVTOOLS_PATH is needed. Did you find this necessary for some reason? >>>>> >>>>>> set CLASSPATH= >>>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>>> set CYGWIN=nodosfilewarning >>>>>> cd c:\Users\Pete\cygwin\bin >>>>>> bash --login -i >>>>> This bash command will add /usr/bin to the PATH, and convert PATH to the CYGWIN world. >>>> Do I need to change something? >>> No you are perfectly fine. I was just commenting that the PATH setting has changed. >>> I always keep track of when PATH changes. >>> >>>>>> Then at the cygwin command line: >>>>>> eval `bin/vsvars.sh -v10 -32` >>>>> Perfect. That adjusts PATH, LIB, INCLUDE, etc, all for the Visual Studio compiler. >>>>> >>>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ >>>>>> make ARCH_DATA_MODEL=32 2>&1 | tee build.log >>>>> Yup. >>>>> >>>>>> Note: I suspect I don't need wbem in my path; I'll remove it the next >>>>>> time I do a build. >>>>> I've never been sure about Wbem needing to be in the system path. Let me know what you find out. >>>> Rebuilding after tweaking awt_Component.cpp worked fine without this. >>>> I'll report back at some other time after doing a full rebuild. >>> http://www.pcreview.co.uk/forums/do-need-wbem-path-statement-t2330116.html >>> >>> My tendency is to leave Wbem in PATH. Not sure we need it, but why vary the standard Windows >>> PATH and ask for trouble? ;^) >>> >>> -kto >>> >>>>> ---- >>>>> So this is Windows 7 right? >>>>> Is it Windows 7 X64 or X86? (32 or 64 bit OS) >>>> 64 bit Windows 7 >>>>> Do you have any anti-virus software installed, and any special settings? >>>> I have Norton 360 and for a full build I disable auto-protect. I don't >>>> bother disabling that for a partial build. >>>>> Is this the latest CYGWIN? (what does uname -a say?) >>>> 1.7.0 (I dropped back from using 1.7.9 and so far this has been working, >>>> but I haven't done enough full builds yet to be sure.) >>>> >>>> Pete >>>>> There have been reports of problems with Windows 7 building, possibly involving CYGWIN and McAfee >>>>> colliding somehow. Just curious. >>>>> >>>>> -kto >>>>> >>>>>> Pete >>>>>> >>>>>> On 2/2/12 2:19 PM, Pete Brunet wrote: >>>>>>> On 2/1/12 10:54 PM, Pete Brunet wrote: >>>>>>>> On 1/23/12 9:39 AM, Pete Brunet wrote: >>>>>>>>> In the past I was able to build part of jdk 8 but that is not currently >>>>>>>>> working although I am able to do a full 32 bit build. I've recently >>>>>>>>> moved from XP to W7 so my environment might not be set up quite right >>>>>>>>> yet. Here's what I do... >>>>>>>>> >>>>>>>>> // These are done in a bat file before I do any makes >>>>>>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>>>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>>>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>>>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>>>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>>>>>> set CLASSPATH= >>>>>>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>>>>>> set CYGWIN=nodosfilewarning >>>>>>>>> cd c:\Users\Pete\cygwin\bin >>>>>>>>> bash --login -i >>>>>>>>> >>>>>>>>> // These are done at the command line >>>>>>>>> eval `bin/vsvars.sh -v10 -32` >>>>>>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >>>>>>>>> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >>>>>>>>> >>>>>>>>> The error I am getting is >>>>>>>>> >>>>>>>>> make: *** No rule to make target >>>>>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>>>>> `compile_all_props'. Stop. >>>>>>>> When building below the top level, for some reason a partial build >>>>>>>> directory is being created in jdk8/jdk. When doing a full build from >>>>>>>> the top level the only build directory I see is the one in jdk8. It >>>>>>>> appears that ../../../build/... is using the build under jdk rather than >>>>>>>> the build under the top level. >>>>>>>> >>>>>>>> Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: >>>>>>>> >>>>>>>> make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' >>>>>>>> make[2]: *** No rule to make target `javax/swing/JLabel', needed by >>>>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>>>>> >>>>>>>> and when trying to build directly at .../jdk/make/javax/swing, i.e. >>>>>>>> >>>>>>>> make: *** No rule to make target `javax/swing/JLabel', needed by >>>>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>>>> The JLabel issue was caused by the existence of >>>>>>> ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is >>>>>>> Windows' scheme for copies.). However, that wouldn't explain the use of >>>>>>> a build directory under jdk (instead of under the top level), i.e. my >>>>>>> original problem might have been caused by using the wrong build dir: >>>>>>> >>>>>>> make: *** No rule to make target >>>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>>> `compile_all_props'. Stop. >>>>>>> >>>>>>>> In case it's helpful jdk/build contains these directories: >>>>>>>> bin >>>>>>>> btbins >>>>>>>> btclasses >>>>>>>> btjars >>>>>>>> classes >>>>>>>> gensrc >>>>>>>> include >>>>>>>> lib >>>>>>>>> Since the above has windows-i586 instead of windows-i586-debug it looks >>>>>>>>> like I need to add another variable when invoking make. >>>>>>>>> >>>>>>>>> Pete From kelly.ohair at oracle.com Wed Feb 15 17:33:19 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 15 Feb 2012 09:33:19 -0800 Subject: building part of jdk 8 In-Reply-To: <4F3BE500.4010001@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> <4F396EC0.2010004@oracle.com> <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> <4F3B27E8.8040309@oracle.com> <4F3BE500.4010001@oracle.com> Message-ID: <6D2D623A-368F-4601-8A9A-41540C2433A8@oracle.com> On Feb 15, 2012, at 9:01 AM, Pete Brunet wrote: > Thanks Kelly, That's interesting. That might provide a hint regarding a > problem I am working on. When I do a full fastdebug_build build with my > patch applied I get a hang when exiting the app, but when I do a > subsequent partial build (with the side effect of using obj instead of > obj_gO) there is no problem. > > What do I have to change in the following partial build invocation to > compile with fastdebug (and use the fastdebug obj_gO directory) or to > compile with debug (and use the debug obj_g directory)? > > eval `bin/vsvars.sh -v10 -32` > cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ > make ARCH_DATA_MODEL=32 2>&1 | tee build.log ^ maybe use target fastdebug? I think every Makefile that uses Library.gmk should have a fastdebug build target. A fastdebug build is a combination of the variables VARIANT=DBG and FASTDEBUG=true but it's been a long time since I looked at that. Proof is in the pudding. Good Luck. -kto > > As a reminder, this is what I do before invoking cywin: > > set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug > set ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/j2sdk-image > set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 > set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include > set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 > set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 > set CLASSPATH= > set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; > set CYGWIN=nodosfilewarning > > And if anyone has an idea why using obj_gO results in a hang on exit but > using obj doesn't that would be helpful. Maybe when building just awt > there is a mismatch between the awt obj files and the rest of the obj > files that make up awt.dll. > > Or maybe my full build needs to be a product build rather than a > fastdebug_build build (to ensure a match between my full and partial > builds). Is that done by removing fastdebug_build when running make at > the top level? > > Pete > > On 2/15/12 10:37 AM, Kelly O'Hair wrote: >> The debug (obj_g/), fastdebug (obj_gO/), and product (obj/) directories keep the different .o or .obj files >> separate, since there is no guarantee that these can be mixed together and work. >> All compilations for a library need to be the same kind of compilation. >> >> -kto >> >> On Feb 14, 2012, at 7:35 PM, Pete Brunet wrote: >> >>> I don't know if this is a problem but it's something I noticed. When I >>> do the full fastdebug_build build there are two directories under >>> C:\OpenJDK\jdk8\build\windows-i586-fastdebug\tmp\sun\sun.awt\awt, i.e. >>> CClassHeaders and Obj_gO. When I then do the partial build of awt >>> (described in the history below) a new directory, obj, is added and >>> populated. >>> >>> On 2/13/12 3:13 PM, Kelly O'Hair wrote: >>>> On Feb 13, 2012, at 12:12 PM, Pete Brunet wrote: >>>> >>>>> On 2/13/12 1:35 PM, Kelly O'Hair wrote: >>>>>> Just a few comments below... >>>>>> >>>>>> On Feb 13, 2012, at 9:08 AM, Pete Brunet wrote: >>>>>> >>>>>>> This worked for me today for building just awt: >>>>>>> >>>>>>> This is in my bat file. The first two sets are what resolved my issue. >>>>>>> set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug >>>>>>> set >>>>>>> ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/windows-i586-fastdebug/j2sdk-image >>>>>> The above two settings make no sense to me. >>>>>> >>>>>> ALT_OUTPUTDIR is supposed to point at the directory where you want the build results to go. >>>>>> One of the directories created is the j2sdk-image. This is a huge disk write area. >>>>> I think I needed this to make my partial build use the same directory as >>>>> my fastdebug_build full build. >>>> Understood. That's a perfectly valid reason. >>>> >>>>>> ALT_JDK_IMPORT_PATH is something you set when you are doing partial builds, e.g. >>>>>> not building hotspot. It needs to point at some place that is pretty golden and steady, for >>>>>> a place to get parts of the jdk image that you are not building. >>>>>> You have it set to the same place you are building. :^( That seems fishy to me. >>>>>> I would have done a full build, moved or copied j2sdk-image to some place safe, and >>>>>> had ALT_JDK_IMPORT_PATH refer to that copy, where it would be safe from destruction >>>>>> during the build. >>>>> I only build parts of awt and swing so maybe I've been lucky. In any >>>>> event I made that change. >>>>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>>> The official boot jdk for jdk8 is actually the first shipping jdk7, although 7u2 should work, >>>>>> our release engineering and automated build systems use jdk7 fcs. >>>>>> >>>>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>>> Not sure why ALT_MSDEVTOOLS_PATH is needed. Did you find this necessary for some reason? >>>>>> >>>>>>> set CLASSPATH= >>>>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>>>> set CYGWIN=nodosfilewarning >>>>>>> cd c:\Users\Pete\cygwin\bin >>>>>>> bash --login -i >>>>>> This bash command will add /usr/bin to the PATH, and convert PATH to the CYGWIN world. >>>>> Do I need to change something? >>>> No you are perfectly fine. I was just commenting that the PATH setting has changed. >>>> I always keep track of when PATH changes. >>>> >>>>>>> Then at the cygwin command line: >>>>>>> eval `bin/vsvars.sh -v10 -32` >>>>>> Perfect. That adjusts PATH, LIB, INCLUDE, etc, all for the Visual Studio compiler. >>>>>> >>>>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ >>>>>>> make ARCH_DATA_MODEL=32 2>&1 | tee build.log >>>>>> Yup. >>>>>> >>>>>>> Note: I suspect I don't need wbem in my path; I'll remove it the next >>>>>>> time I do a build. >>>>>> I've never been sure about Wbem needing to be in the system path. Let me know what you find out. >>>>> Rebuilding after tweaking awt_Component.cpp worked fine without this. >>>>> I'll report back at some other time after doing a full rebuild. >>>> http://www.pcreview.co.uk/forums/do-need-wbem-path-statement-t2330116.html >>>> >>>> My tendency is to leave Wbem in PATH. Not sure we need it, but why vary the standard Windows >>>> PATH and ask for trouble? ;^) >>>> >>>> -kto >>>> >>>>>> ---- >>>>>> So this is Windows 7 right? >>>>>> Is it Windows 7 X64 or X86? (32 or 64 bit OS) >>>>> 64 bit Windows 7 >>>>>> Do you have any anti-virus software installed, and any special settings? >>>>> I have Norton 360 and for a full build I disable auto-protect. I don't >>>>> bother disabling that for a partial build. >>>>>> Is this the latest CYGWIN? (what does uname -a say?) >>>>> 1.7.0 (I dropped back from using 1.7.9 and so far this has been working, >>>>> but I haven't done enough full builds yet to be sure.) >>>>> >>>>> Pete >>>>>> There have been reports of problems with Windows 7 building, possibly involving CYGWIN and McAfee >>>>>> colliding somehow. Just curious. >>>>>> >>>>>> -kto >>>>>> >>>>>>> Pete >>>>>>> >>>>>>> On 2/2/12 2:19 PM, Pete Brunet wrote: >>>>>>>> On 2/1/12 10:54 PM, Pete Brunet wrote: >>>>>>>>> On 1/23/12 9:39 AM, Pete Brunet wrote: >>>>>>>>>> In the past I was able to build part of jdk 8 but that is not currently >>>>>>>>>> working although I am able to do a full 32 bit build. I've recently >>>>>>>>>> moved from XP to W7 so my environment might not be set up quite right >>>>>>>>>> yet. Here's what I do... >>>>>>>>>> >>>>>>>>>> // These are done in a bat file before I do any makes >>>>>>>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>>>>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>>>>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>>>>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>>>>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>>>>>>> set CLASSPATH= >>>>>>>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>>>>>>> set CYGWIN=nodosfilewarning >>>>>>>>>> cd c:\Users\Pete\cygwin\bin >>>>>>>>>> bash --login -i >>>>>>>>>> >>>>>>>>>> // These are done at the command line >>>>>>>>>> eval `bin/vsvars.sh -v10 -32` >>>>>>>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >>>>>>>>>> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >>>>>>>>>> >>>>>>>>>> The error I am getting is >>>>>>>>>> >>>>>>>>>> make: *** No rule to make target >>>>>>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>>>>>> `compile_all_props'. Stop. >>>>>>>>> When building below the top level, for some reason a partial build >>>>>>>>> directory is being created in jdk8/jdk. When doing a full build from >>>>>>>>> the top level the only build directory I see is the one in jdk8. It >>>>>>>>> appears that ../../../build/... is using the build under jdk rather than >>>>>>>>> the build under the top level. >>>>>>>>> >>>>>>>>> Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: >>>>>>>>> >>>>>>>>> make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' >>>>>>>>> make[2]: *** No rule to make target `javax/swing/JLabel', needed by >>>>>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>>>>>> >>>>>>>>> and when trying to build directly at .../jdk/make/javax/swing, i.e. >>>>>>>>> >>>>>>>>> make: *** No rule to make target `javax/swing/JLabel', needed by >>>>>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>>>>> The JLabel issue was caused by the existence of >>>>>>>> ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is >>>>>>>> Windows' scheme for copies.). However, that wouldn't explain the use of >>>>>>>> a build directory under jdk (instead of under the top level), i.e. my >>>>>>>> original problem might have been caused by using the wrong build dir: >>>>>>>> >>>>>>>> make: *** No rule to make target >>>>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>>>> `compile_all_props'. Stop. >>>>>>>> >>>>>>>>> In case it's helpful jdk/build contains these directories: >>>>>>>>> bin >>>>>>>>> btbins >>>>>>>>> btclasses >>>>>>>>> btjars >>>>>>>>> classes >>>>>>>>> gensrc >>>>>>>>> include >>>>>>>>> lib >>>>>>>>>> Since the above has windows-i586 instead of windows-i586-debug it looks >>>>>>>>>> like I need to add another variable when invoking make. >>>>>>>>>> >>>>>>>>>> Pete From david.katleman at sun.com Wed Feb 15 23:31:56 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 15 Feb 2012 23:31:56 +0000 Subject: hg: jdk8/build: Added tag jdk8-b25 for changeset 221a378e06a3 Message-ID: <20120215233156.8DD8647505@hg.openjdk.java.net> Changeset: 2accafff224a Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/2accafff224a Added tag jdk8-b25 for changeset 221a378e06a3 ! .hgtags From david.katleman at sun.com Wed Feb 15 23:32:03 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 15 Feb 2012 23:32:03 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b25 for changeset e45d6b406d5f Message-ID: <20120215233204.9B8A947506@hg.openjdk.java.net> Changeset: 79f709a099f4 Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/79f709a099f4 Added tag jdk8-b25 for changeset e45d6b406d5f ! .hgtags From david.katleman at sun.com Wed Feb 15 23:35:30 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 15 Feb 2012 23:35:30 +0000 Subject: hg: jdk8/build/hotspot: 18 new changesets Message-ID: <20120215233607.5B69C47507@hg.openjdk.java.net> Changeset: aaceb8ddf2e2 Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/aaceb8ddf2e2 Added tag jdk8-b25 for changeset 9ad8feb5afbd ! .hgtags Changeset: 3c4621be5149 Author: amurillo Date: 2012-02-06 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3c4621be5149 7143122: new hotspot build - hs23-b15 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 869be5c8882e Author: phh Date: 2012-02-03 17:21 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/869be5c8882e 7142586: Cannot build on Solaris 11 due to use of ia_nice Summary: Delete the single use of ia_nice in os_solaris.cpp Reviewed-by: kamg, kvn ! src/os/solaris/vm/os_solaris.cpp Changeset: c77d473e71f7 Author: ohrstrom Date: 2012-01-31 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c77d473e71f7 7132779: build-infra merge: Enable ccache to work for most developer builds. Summary: When a build number is not specified, the JRE_RELEASE_VERSION define contains a date and timestamp. Thus ccache cannot cache the object files for longer than a minute since the define is passed to the compilation of all source files. This change passes JRE_RELEASE_VERSION only to vm_version.cpp and adds a function jre_release_version() to Abstract_VM_Version. This allows all other source files to be ccached. Reviewed-by: ohair, rottenha Contributed-by: fredrik.ohrstrom at oracle.com ! make/bsd/makefiles/vm.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/vm.make ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp Changeset: 719f7007c8e8 Author: erikj Date: 2012-02-06 09:14 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/719f7007c8e8 7141242: build-infra merge: Rename CPP->CXX and LINK->LD Summary: Cleaned up make variables for compilers and linker to consistently use CXX for C++ compiler, CC for C compiler and LD for linker. Reviewed-by: dholmes, ohrstrom ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/rules.make ! make/bsd/makefiles/sparcWorks.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/adlc.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/product.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sparcWorks.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/launcher.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build_vm_def.sh ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/launcher.make ! make/windows/makefiles/product.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/sa.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/shared.make ! make/windows/makefiles/vm.make Changeset: ea677dbdd883 Author: fparain Date: 2012-02-07 12:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ea677dbdd883 Merge Changeset: 5e9fba4e8718 Author: kvn Date: 2012-02-07 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5e9fba4e8718 7142167: MAC: _get_previous_fp broken on bsd with llvm-gcc Summary: LLVM-GCC (__llvm__) should use the same _get_previous_fp implementation as __clang__ (as is the case for os::current_stack_pointer). Reviewed-by: twisti, never, dcubed ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: b9bc6cae88f2 Author: kvn Date: 2012-02-07 16:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b9bc6cae88f2 7143491: G1 C2 CTW: assert(p2x->outcnt() == 2) failed: expects 2 users: Xor and URShift nodes Summary: Adjust the assert and code in eliminate_card_mark() method for case when stored value is NULL. Reviewed-by: iveresov, never ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/macro.cpp Changeset: c742b0b47fe5 Author: roland Date: 2012-02-08 09:52 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c742b0b47fe5 7119286: JSR292: SIGSEGV in JNIHandleBlock::release_block(JNIHandleBlock*, Thread*)+0x3c Summary: unaligned stack in throw_NullPointerException_at_call_entry(). Reviewed-by: twisti, never, kvn ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 2f985b6ce7ff Author: jrose Date: 2012-02-09 18:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2f985b6ce7ff Merge Changeset: 1ac084126285 Author: dlong Date: 2012-01-24 18:00 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1ac084126285 7130319: C2: running with -XX:+PrintOptoAssembly crashes the VM with assert(false) failed: bad tag in log Summary: Relax assert to allow the VMThread to close the log while the compiler thread is still writing to it. Reviewed-by: dholmes, never Contributed-by: dean.long at oracle.com ! src/share/vm/utilities/xmlstream.cpp Changeset: d851f3714641 Author: dholmes Date: 2012-01-25 19:26 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d851f3714641 Merge - src/os/bsd/vm/decoder_bsd.cpp Changeset: a79cb7c55012 Author: jiangli Date: 2012-01-25 17:40 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a79cb7c55012 7132690: InstanceKlass:_reference_type should be u1 type Summary: Change InstanceKlass::_reference_type to u1 type. Reviewed-by: dholmes, coleenp, acorn Contributed-by: Jiangli Zhou ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f3fa16bd7159 Author: bobv Date: 2012-01-25 21:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f3fa16bd7159 Merge Changeset: b7b8b6d2f97d Author: bpittore Date: 2012-02-06 10:57 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b7b8b6d2f97d Merge ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f174909614bd Author: bpittore Date: 2012-02-10 10:55 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f174909614bd Merge ! src/share/vm/opto/library_call.cpp Changeset: d71e662fe037 Author: amurillo Date: 2012-02-10 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d71e662fe037 Merge Changeset: fd3060701216 Author: amurillo Date: 2012-02-10 11:41 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fd3060701216 Added tag hs23-b15 for changeset d71e662fe037 ! .hgtags From david.katleman at sun.com Wed Feb 15 23:37:15 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 15 Feb 2012 23:37:15 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b25 for changeset bb694c151fc7 Message-ID: <20120215233715.1030947508@hg.openjdk.java.net> Changeset: dbb7283c197b Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/dbb7283c197b Added tag jdk8-b25 for changeset bb694c151fc7 ! .hgtags From david.katleman at sun.com Wed Feb 15 23:37:21 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 15 Feb 2012 23:37:21 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b25 for changeset b376d901e006 Message-ID: <20120215233721.D1B7747509@hg.openjdk.java.net> Changeset: 3518639eab6c Author: katleman Date: 2012-02-09 12:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/3518639eab6c Added tag jdk8-b25 for changeset b376d901e006 ! .hgtags From david.katleman at sun.com Wed Feb 15 23:37:31 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 15 Feb 2012 23:37:31 +0000 Subject: hg: jdk8/build/jdk: Added tag jdk8-b25 for changeset ec17fbe5b8fb Message-ID: <20120215233751.F29A84750A@hg.openjdk.java.net> Changeset: 5aca406e87cb Author: katleman Date: 2012-02-09 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5aca406e87cb Added tag jdk8-b25 for changeset ec17fbe5b8fb ! .hgtags From david.katleman at sun.com Wed Feb 15 23:39:04 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 15 Feb 2012 23:39:04 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b25 for changeset 520c30f85bb5 Message-ID: <20120215233909.5B1394750B@hg.openjdk.java.net> Changeset: b556aa8a99c3 Author: katleman Date: 2012-02-09 12:56 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b556aa8a99c3 Added tag jdk8-b25 for changeset 520c30f85bb5 ! .hgtags From david.holmes at oracle.com Thu Feb 16 06:21:55 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 16 Feb 2012 16:21:55 +1000 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F3BCA03.9050707@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F3BCA03.9050707@oracle.com> Message-ID: <4F3CA083.9060408@oracle.com> On 16/02/2012 1:06 AM, Erik Joelsson wrote: > New webrev: > http://cr.openjdk.java.net/~erikj/7141244/webrev.04/ > 175 lines changed: 87 ins; 29 del; 59 mod; 3970 unchg > > I discovered that the -include $(SPEC) line needed to be added to the > make/{bsd,solaris,linux}/makefiles/buildtree.make files. Otherwise the > hotspot build won't respect setting OPENJDK=true in the spec. Is that the only change from version 3? Have you verified you can do all three variants: openjdk, jdk, embedded jdk? > It seems the windows build isn't respecting the OPENJDK variable today > so I won't bother fixing that. Can't comment on that. David > > /Erik > > On 2012-02-07 17:30, Erik Joelsson wrote: >> http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ >> >> 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg >> >> 7141244: build-infra merge: Include $(SPEC) in makefiles and make >> variables overridable >> >> The build-infra project is starting to move into jdk8. For the hotspot >> build to stay compatible with the changes, key hotspot makefiles need >> to add an optional include statement: >> >> >> -include $(SPEC) >> >> In the new build system, the spec file is generated by configure and >> contains the configuration for the build. Only a handfull of files >> need to add this line. >> >> In addition to including the spec file, some variables need to be >> changed to only be set conditionally so that a value from the spec >> file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, >> NAWK (and for windows RC and MT). The hotspot makefiles should check >> each variable if it's already set or if it has a gnumake default value. >> >> These changes have been verified to work for hotspot-rt. Jdk7u will be >> verified as well before pushing. >> >> /Erik >> From erik.joelsson at oracle.com Thu Feb 16 08:20:48 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 16 Feb 2012 09:20:48 +0100 Subject: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable In-Reply-To: <4F3CA083.9060408@oracle.com> References: <4F3151B7.7000806@oracle.com> <4F3BCA03.9050707@oracle.com> <4F3CA083.9060408@oracle.com> Message-ID: <4F3CBC60.5000707@oracle.com> On 2012-02-16 07:21, David Holmes wrote: > On 16/02/2012 1:06 AM, Erik Joelsson wrote: >> New webrev: >> http://cr.openjdk.java.net/~erikj/7141244/webrev.04/ >> 175 lines changed: 87 ins; 29 del; 59 mod; 3970 unchg >> >> I discovered that the -include $(SPEC) line needed to be added to the >> make/{bsd,solaris,linux}/makefiles/buildtree.make files. Otherwise the >> hotspot build won't respect setting OPENJDK=true in the spec. > > Is that the only change from version 3? > That is the only change yes. > Have you verified you can do all three variants: openjdk, jdk, > embedded jdk? > Not sure how you mean. The problem I corrected was discovered during development in the build-infra repo, where I'm currently working on the open vs non open scenarios. We haven't started looking at embedded much yet (build-infra isn't currently building on anything but linux atm). This issue, and the change, has no impact on the old build system, either building just hotspot or from the root repo. I'm running my hotspot-rt through jprt now anyway to be sure. /Erik From artem.ananiev at oracle.com Fri Feb 17 09:56:30 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Fri, 17 Feb 2012 13:56:30 +0400 Subject: Question about BUILD_HEADLESS and HEADLESS In-Reply-To: <4F3B7E0D.4070708@oracle.com> References: <4F3A65DB.6030307@oracle.com> <4F3A7486.5010107@oracle.com> <4F3A9995.8010009@oracle.com> <4F3B7E0D.4070708@oracle.com> Message-ID: <4F3E244E.4010606@oracle.com> On 2/15/2012 1:42 PM, Michael McMahon wrote: > The stub library is headless/libmawt.so*. Right? It's being built on Mac > OS as well, but currently being > put in a different location to the normal one. It also seems like it is > not being used > because if you rename or delete it, there isn't any change in behavior, > which sounds like a bug. headless/libmawt.so is not used when running in headless mode with CToolkit. Have you tried forcing XToolkit? That is AWT_TOOLKIT=XToolkit java -Djava.awt.headless=true AppName ? > So, what exactly is the function of the stub library? Is it to allow > some functions of awt to work that don't require a real display? headless/libmawt.so contains all the native code that is expected to work in headless mode, e.g. printing or image manipulation. > In any case, I don't see why Mac should be different from Solaris or > Linux in this respect. Thanks, Artem > - Michael. > > * In 8 it has a different name, but it'll be built on Mac as well in 8. > > On 14/02/12 17:27, Phil Race wrote: >> On windows headless is simply a state. >> But Solaris/Linux have "true" headless builds where there are headless >> (stub) versions of UI libraries. >> And I think that headless is a valid JCK mode .. you can pass JCK in >> headless >> on platforms that don't support UI. But I'd check the JCK guys on that >> one, >> don't take my word for it. >> >> -phk. >> >> On 2/14/2012 6:49 AM, Michael McMahon wrote: >>> On 14/02/12 13:47, Fredrik ?hrstr?m wrote: >>>> Is the use of HEADLESS in gcc.make (linux and bsd) an archaeological >>>> remnant and should be removed? (No source in the hotspot repo looks a >>>> the HEADLESS define.) >>>> >>>> Is there any reason to not build a headless version of awt? (ie modify >>>> BUILD_HEADLESS to not be defined.) >>>> It seeems like headless is not currently built on bsd/macosx/windows, >>>> but it is built on solaris and linux? >>>> >>>> //Fredrik >>> Fredrik, >>> >>> It's being built on macosx as well. >>> >>> - Michael. >> > From peter.brunet at oracle.com Mon Feb 20 18:02:42 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 20 Feb 2012 12:02:42 -0600 Subject: building part of jdk 8 In-Reply-To: <6D2D623A-368F-4601-8A9A-41540C2433A8@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> <4F396EC0.2010004@oracle.com> <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> <4F3B27E8.8040309@oracle.com> <4F3BE500.4010001@oracle.com> <6D2D623A-368F-4601-8A9A-41540C2433A8@oracle.com> Message-ID: <4F428AC2.4030205@oracle.com> On 2/15/12 11:33 AM, Kelly O'Hair wrote: > On Feb 15, 2012, at 9:01 AM, Pete Brunet wrote: > >> Thanks Kelly, That's interesting. That might provide a hint regarding a >> problem I am working on. When I do a full fastdebug_build build with my >> patch applied I get a hang when exiting the app, but when I do a >> subsequent partial build (with the side effect of using obj instead of >> obj_gO) there is no problem. >> >> What do I have to change in the following partial build invocation to >> compile with fastdebug (and use the fastdebug obj_gO directory) or to >> compile with debug (and use the debug obj_g directory)? >> >> eval `bin/vsvars.sh -v10 -32` >> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ >> make ARCH_DATA_MODEL=32 2>&1 | tee build.log > ^ maybe use target fastdebug? > > I think every Makefile that uses Library.gmk should have a fastdebug build target. > > A fastdebug build is a combination of the variables VARIANT=DBG and FASTDEBUG=true > but it's been a long time since I looked at that. Proof is in the pudding. Good Luck. Thanks Kelly, That's true. Also, I hadn't realized that I need to use target fastdebug_build at the top level and fastdebug at the lower levels. > > -kto > >> As a reminder, this is what I do before invoking cywin: >> >> set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug >> set ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/j2sdk-image >> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >> set CLASSPATH= >> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >> set CYGWIN=nodosfilewarning >> >> And if anyone has an idea why using obj_gO results in a hang on exit but >> using obj doesn't that would be helpful. Maybe when building just awt >> there is a mismatch between the awt obj files and the rest of the obj >> files that make up awt.dll. >> >> Or maybe my full build needs to be a product build rather than a >> fastdebug_build build (to ensure a match between my full and partial >> builds). Is that done by removing fastdebug_build when running make at >> the top level? >> >> Pete >> >> On 2/15/12 10:37 AM, Kelly O'Hair wrote: >>> The debug (obj_g/), fastdebug (obj_gO/), and product (obj/) directories keep the different .o or .obj files >>> separate, since there is no guarantee that these can be mixed together and work. >>> All compilations for a library need to be the same kind of compilation. >>> >>> -kto >>> >>> On Feb 14, 2012, at 7:35 PM, Pete Brunet wrote: >>> >>>> I don't know if this is a problem but it's something I noticed. When I >>>> do the full fastdebug_build build there are two directories under >>>> C:\OpenJDK\jdk8\build\windows-i586-fastdebug\tmp\sun\sun.awt\awt, i.e. >>>> CClassHeaders and Obj_gO. When I then do the partial build of awt >>>> (described in the history below) a new directory, obj, is added and >>>> populated. >>>> >>>> On 2/13/12 3:13 PM, Kelly O'Hair wrote: >>>>> On Feb 13, 2012, at 12:12 PM, Pete Brunet wrote: >>>>> >>>>>> On 2/13/12 1:35 PM, Kelly O'Hair wrote: >>>>>>> Just a few comments below... >>>>>>> >>>>>>> On Feb 13, 2012, at 9:08 AM, Pete Brunet wrote: >>>>>>> >>>>>>>> This worked for me today for building just awt: >>>>>>>> >>>>>>>> This is in my bat file. The first two sets are what resolved my issue. >>>>>>>> set ALT_OUTPUTDIR=c:/OpenJDK/jdk8/build/windows-i586-fastdebug >>>>>>>> set >>>>>>>> ALT_JDK_IMPORT_PATH=c:/OpenJDK/jdk8/build/windows-i586-fastdebug/j2sdk-image >>>>>>> The above two settings make no sense to me. >>>>>>> >>>>>>> ALT_OUTPUTDIR is supposed to point at the directory where you want the build results to go. >>>>>>> One of the directories created is the j2sdk-image. This is a huge disk write area. >>>>>> I think I needed this to make my partial build use the same directory as >>>>>> my fastdebug_build full build. >>>>> Understood. That's a perfectly valid reason. >>>>> >>>>>>> ALT_JDK_IMPORT_PATH is something you set when you are doing partial builds, e.g. >>>>>>> not building hotspot. It needs to point at some place that is pretty golden and steady, for >>>>>>> a place to get parts of the jdk image that you are not building. >>>>>>> You have it set to the same place you are building. :^( That seems fishy to me. >>>>>>> I would have done a full build, moved or copied j2sdk-image to some place safe, and >>>>>>> had ALT_JDK_IMPORT_PATH refer to that copy, where it would be safe from destruction >>>>>>> during the build. >>>>>> I only build parts of awt and swing so maybe I've been lucky. In any >>>>>> event I made that change. >>>>>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>>>> The official boot jdk for jdk8 is actually the first shipping jdk7, although 7u2 should work, >>>>>>> our release engineering and automated build systems use jdk7 fcs. >>>>>>> >>>>>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>>>> Not sure why ALT_MSDEVTOOLS_PATH is needed. Did you find this necessary for some reason? >>>>>>> >>>>>>>> set CLASSPATH= >>>>>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>>>>> set CYGWIN=nodosfilewarning >>>>>>>> cd c:\Users\Pete\cygwin\bin >>>>>>>> bash --login -i >>>>>>> This bash command will add /usr/bin to the PATH, and convert PATH to the CYGWIN world. >>>>>> Do I need to change something? >>>>> No you are perfectly fine. I was just commenting that the PATH setting has changed. >>>>> I always keep track of when PATH changes. >>>>> >>>>>>>> Then at the cygwin command line: >>>>>>>> eval `bin/vsvars.sh -v10 -32` >>>>>>> Perfect. That adjusts PATH, LIB, INCLUDE, etc, all for the Visual Studio compiler. >>>>>>> >>>>>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/sun/awt/ >>>>>>>> make ARCH_DATA_MODEL=32 2>&1 | tee build.log >>>>>>> Yup. >>>>>>> >>>>>>>> Note: I suspect I don't need wbem in my path; I'll remove it the next >>>>>>>> time I do a build. >>>>>>> I've never been sure about Wbem needing to be in the system path. Let me know what you find out. >>>>>> Rebuilding after tweaking awt_Component.cpp worked fine without this. >>>>>> I'll report back at some other time after doing a full rebuild. >>>>> http://www.pcreview.co.uk/forums/do-need-wbem-path-statement-t2330116.html >>>>> >>>>> My tendency is to leave Wbem in PATH. Not sure we need it, but why vary the standard Windows >>>>> PATH and ask for trouble? ;^) >>>>> >>>>> -kto >>>>> >>>>>>> ---- >>>>>>> So this is Windows 7 right? >>>>>>> Is it Windows 7 X64 or X86? (32 or 64 bit OS) >>>>>> 64 bit Windows 7 >>>>>>> Do you have any anti-virus software installed, and any special settings? >>>>>> I have Norton 360 and for a full build I disable auto-protect. I don't >>>>>> bother disabling that for a partial build. >>>>>>> Is this the latest CYGWIN? (what does uname -a say?) >>>>>> 1.7.0 (I dropped back from using 1.7.9 and so far this has been working, >>>>>> but I haven't done enough full builds yet to be sure.) >>>>>> >>>>>> Pete >>>>>>> There have been reports of problems with Windows 7 building, possibly involving CYGWIN and McAfee >>>>>>> colliding somehow. Just curious. >>>>>>> >>>>>>> -kto >>>>>>> >>>>>>>> Pete >>>>>>>> >>>>>>>> On 2/2/12 2:19 PM, Pete Brunet wrote: >>>>>>>>> On 2/1/12 10:54 PM, Pete Brunet wrote: >>>>>>>>>> On 1/23/12 9:39 AM, Pete Brunet wrote: >>>>>>>>>>> In the past I was able to build part of jdk 8 but that is not currently >>>>>>>>>>> working although I am able to do a full 32 bit build. I've recently >>>>>>>>>>> moved from XP to W7 so my environment might not be set up quite right >>>>>>>>>>> yet. Here's what I do... >>>>>>>>>>> >>>>>>>>>>> // These are done in a bat file before I do any makes >>>>>>>>>>> set ALT_BOOTDIR=C:/Progra~1/Java/jdk1.7.0_02 >>>>>>>>>>> set ALT_FREETYPE_HEADERS_PATH=C:/Users/Pete/freetype-2.4.8/include >>>>>>>>>>> set ALT_FREETYPE_LIB_PATH=C:/Users/Pete/freetype-2.4.8/objs/win32/vc2010 >>>>>>>>>>> set ANT_HOME=C:/Progra~2/apache-ant-1.7.1 >>>>>>>>>>> set ALT_MSDEVTOOLS_PATH=C:/Progra~2/MICROS~1/Windows/v7.0A/bin >>>>>>>>>>> set CLASSPATH= >>>>>>>>>>> set PATH=C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem; >>>>>>>>>>> set CYGWIN=nodosfilewarning >>>>>>>>>>> cd c:\Users\Pete\cygwin\bin >>>>>>>>>>> bash --login -i >>>>>>>>>>> >>>>>>>>>>> // These are done at the command line >>>>>>>>>>> eval `bin/vsvars.sh -v10 -32` >>>>>>>>>>> cd /cygdrive/c/OpenJDK/jdk8/jdk/make/java/awt/ >>>>>>>>>>> make ARCH_DATA_MODEL=32 FASTDEBUG=true 2>&1 | tee build.log >>>>>>>>>>> >>>>>>>>>>> The error I am getting is >>>>>>>>>>> >>>>>>>>>>> make: *** No rule to make target >>>>>>>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>>>>>>> `compile_all_props'. Stop. >>>>>>>>>> When building below the top level, for some reason a partial build >>>>>>>>>> directory is being created in jdk8/jdk. When doing a full build from >>>>>>>>>> the top level the only build directory I see is the one in jdk8. It >>>>>>>>>> appears that ../../../build/... is using the build under jdk rather than >>>>>>>>>> the build under the top level. >>>>>>>>>> >>>>>>>>>> Tonight I saw a similar failure when trying to rebuild JLabel.java from jdk: >>>>>>>>>> >>>>>>>>>> make[2]: Entering directory `/cygdrive/c/OpenJDK/jdk8/jdk/make/javax/swing' >>>>>>>>>> make[2]: *** No rule to make target `javax/swing/JLabel', needed by >>>>>>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>>>>>>> >>>>>>>>>> and when trying to build directly at .../jdk/make/javax/swing, i.e. >>>>>>>>>> >>>>>>>>>> make: *** No rule to make target `javax/swing/JLabel', needed by >>>>>>>>>> `../../../build/windows-i586/tmp/com/javax.swing/.classes.list'. Stop. >>>>>>>>> The JLabel issue was caused by the existence of >>>>>>>>> ...\jdk\src\share\classes\javax\swing\JLabel - Copy.java. (This is >>>>>>>>> Windows' scheme for copies.). However, that wouldn't explain the use of >>>>>>>>> a build directory under jdk (instead of under the top level), i.e. my >>>>>>>>> original problem might have been caused by using the wrong build dir: >>>>>>>>> >>>>>>>>> make: *** No rule to make target >>>>>>>>> `../../../build/windows-i586/btjars/compileproperties.jar', needed by >>>>>>>>> `compile_all_props'. Stop. >>>>>>>>> >>>>>>>>>> In case it's helpful jdk/build contains these directories: >>>>>>>>>> bin >>>>>>>>>> btbins >>>>>>>>>> btclasses >>>>>>>>>> btjars >>>>>>>>>> classes >>>>>>>>>> gensrc >>>>>>>>>> include >>>>>>>>>> lib >>>>>>>>>>> Since the above has windows-i586 instead of windows-i586-debug it looks >>>>>>>>>>> like I need to add another variable when invoking make. >>>>>>>>>>> >>>>>>>>>>> Pete From oehrstroem at gmail.com Mon Feb 20 19:25:42 2012 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Mon, 20 Feb 2012 20:25:42 +0100 Subject: building part of jdk 8 In-Reply-To: <4F428AC2.4030205@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> <4F396EC0.2010004@oracle.com> <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> <4F3B27E8.8040309@oracle.com> <4F3BE500.4010001@oracle.com> <6D2D623A-368F-4601-8A9A-41540C2433A8@oracle.com> <4F428AC2.4030205@oracle.com> Message-ID: Den m?ndagen den 20:e februari 2012 skrev Pete > > > > > A fastdebug build is a combination of the variables VARIANT=DBG and > FASTDEBUG=true > > but it's been a long time since I looked at that. Proof is in the > pudding. Good Luck. > Thanks Kelly, That's true. Also, I hadn't realized that I need to use > target fastdebug_build at the top level and fastdebug at the lower levels. The new build system tries to avoid this confusion by simplifying the setup. ./configure --with-debug-level=slowdebug where debug level is release,fastdebug,slowdebug. This setting affects all repos, both hotspot and the jdk. Previously the jdk build took so long time that it made sense to squeeze every version of hotspot binaries into the same hotspot build directory. (several different debug versions, even 32 and 64 bit on sparc platforms?) Since whatever you did, it was vital that you did not have to recompile the jdk. The result was the confusing pudding of files in the build directory. With the new build system, rebuilding the jdk is faster than rebuilding hotspot. You can therefore afford to create many many different configurations and build them all from the same source. This is why the configuration warns when you build more than one jvm. Typically on 32 bit platforms you want to supply --with-jvm-variants=server to only build the best jvm. By default, mimicing the old makefiles, the default on 32 bit is --with-jvm-variants=client,server,minimal resulting in a build that spends 75% of the build time building jvm variants..... //Fredrik -------------- next part -------------- An HTML attachment was scrubbed... URL: From peter.brunet at oracle.com Mon Feb 20 20:01:47 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Mon, 20 Feb 2012 14:01:47 -0600 Subject: building part of jdk 8 In-Reply-To: References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> <4F396EC0.2010004@oracle.com> <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> <4F3B27E8.8040309@oracle.com> <4F3BE500.4010001@oracle.com> <6D2D623A-368F-4601-8A9A-41540C2433A8@oracle.com> <4F428AC2.4030205@oracle.com> Message-ID: <4F42A6AB.1090204@oracle.com> On 2/20/12 1:25 PM, Fredrik ?hrstr?m wrote: > Den m?ndagen den 20:e februari 2012 skrev Pete > > > > > A fastdebug build is a combination of the variables VARIANT=DBG > and FASTDEBUG=true > > but it's been a long time since I looked at that. Proof is in > the pudding. Good Luck. > > > > Thanks Kelly, That's true. Also, I hadn't realized that I need to use > target fastdebug_build at the top level and fastdebug at the lower > levels. > > > The new build system tries to avoid this confusion by simplifying the > setup. > ./configure --with-debug-level=slowdebug > where debug level is release,fastdebug,slowdebug. This setting affects > all repos, both hotspot and the jdk. Hi Fredrik, I can't find any files named configure. Is there further documentation? -Pete > > Previously the jdk build took so long time that it made sense to > squeeze every version > of hotspot binaries into the same hotspot build directory. (several > different debug versions, even 32 and 64 bit on sparc platforms?) > Since whatever you did, it was vital that you did not have to > recompile the jdk. The result was the confusing pudding of files in > the build directory. > > With the new build system, rebuilding the jdk is faster than > rebuilding hotspot. You can therefore afford to create many many > different configurations and build them all from the same source. > > This is why the configuration warns when you build more than one jvm. > Typically on 32 bit platforms you want to supply > --with-jvm-variants=server to only build the best jvm. By default, > mimicing the old makefiles, the default on 32 bit is > --with-jvm-variants=client,server,minimal resulting in a build that > spends 75% of the build time building jvm variants..... > > //Fredrik -------------- next part -------------- An HTML attachment was scrubbed... URL: From oehrstroem at gmail.com Mon Feb 20 21:01:33 2012 From: oehrstroem at gmail.com (=?ISO-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Mon, 20 Feb 2012 22:01:33 +0100 Subject: building part of jdk 8 In-Reply-To: <4F42A6AB.1090204@oracle.com> References: <4F1D7F39.8010502@oracle.com> <4F2A170D.5020701@oracle.com> <4F2AEFC4.5010907@oracle.com> <4F394397.5050401@oracle.com> <5EE746DD-5CE8-4481-A449-C81C342B0262@oracle.com> <4F396EC0.2010004@oracle.com> <42C4D223-DCE8-4651-A59E-B50D12D8E464@oracle.com> <4F3B27E8.8040309@oracle.com> <4F3BE500.4010001@oracle.com> <6D2D623A-368F-4601-8A9A-41540C2433A8@oracle.com> <4F428AC2.4030205@oracle.com> <4F42A6AB.1090204@oracle.com> Message-ID: Den m?ndagen den 20:e februari 2012 skrev Pete Brunet: > > Hi Fredrik, I can't find any files named configure. Is there further > documentation? -Pete > Ah, this is the work in progress, the build-infra project. Discussed a bit here and on build-infra-dev. hg clone http://hg.openjdk.java.net/build-infra/jdk8 cd jdk8 sh get_source.sh cd common/makefiles ../autoconf/configure make ../../build/....../jdk/bin/java -version the old makefiles and the new live concurrently for some time. Eventually, the configure will be in the root directory. //Fredrik -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.katleman at sun.com Wed Feb 22 23:21:14 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 22 Feb 2012 23:21:14 +0000 Subject: hg: jdk8/build: Added tag jdk8-b26 for changeset 2accafff224a Message-ID: <20120222232114.D627F47635@hg.openjdk.java.net> Changeset: 1533dfab9903 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/1533dfab9903 Added tag jdk8-b26 for changeset 2accafff224a ! .hgtags From david.katleman at sun.com Wed Feb 22 23:21:21 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 22 Feb 2012 23:21:21 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b26 for changeset 79f709a099f4 Message-ID: <20120222232123.2535B47636@hg.openjdk.java.net> Changeset: 4fffe75e4edd Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/4fffe75e4edd Added tag jdk8-b26 for changeset 79f709a099f4 ! .hgtags From david.katleman at sun.com Wed Feb 22 23:23:20 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 22 Feb 2012 23:23:20 +0000 Subject: hg: jdk8/build/hotspot: 52 new changesets Message-ID: <20120222232503.5F6E747637@hg.openjdk.java.net> Changeset: 087daaec688d Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/087daaec688d Added tag jdk8-b26 for changeset fd3060701216 ! .hgtags Changeset: 094138495da4 Author: amurillo Date: 2012-02-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/094138495da4 7144322: new hotspot build - hs23-b16 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 77a488cd4af2 Author: dlong Date: 2012-02-15 00:51 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/77a488cd4af2 7140866: assert(covered) failed: Card for end of new region not committed Summary: resize covered region only after successfully mapping shared archive Reviewed-by: brutisso, ysr Contributed-by: dean.long at oracle.com ! src/share/vm/memory/compactingPermGenGen.cpp Changeset: f9961b6498f9 Author: bpittore Date: 2012-02-15 16:09 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f9961b6498f9 Merge Changeset: 95f6641e38e0 Author: iveresov Date: 2012-02-10 17:40 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/95f6641e38e0 7144296: PS: Optimize nmethods processing Summary: Prunes scavenge roots in code list every young GC, promote objects directly pointed by the code immediately Reviewed-by: johnc, jcoomes ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp Changeset: caa4652b4414 Author: tonyp Date: 2012-02-14 08:21 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/caa4652b4414 7129892: G1: explicit marking cycle initiation might fail to initiate a marking cycle Summary: If we try to schedule an initial-mark GC in order to explicit start a conc mark cycle and it gets pre-empted by antoher GC, we should retry the attempt as long as it's appropriate for the GC cause. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Changeset: d903bf750e9f Author: johnc Date: 2012-01-18 09:50 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d903bf750e9f 7129514: time warp warnings after 7117303 Summary: Replace calls to os::javaTimeMillis() that are used to update the milliseconds since the last GC to an equivalent that uses a monotonically non-decreasing time source. Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: a9647476d1a4 Author: tonyp Date: 2012-02-15 13:06 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a9647476d1a4 7132029: G1: mixed GC phase lasts for longer than it should Summary: Revamp of the mechanism that chooses old regions for inclusion in the CSet. It simplifies the code and introduces min and max bounds on the number of old regions added to the CSet at each mixed GC to avoid pathological cases. It also ensures that when we do a mixed GC we'll always find old regions to add to the CSet (i.e., it eliminates the case where a mixed GC will collect no old regions which can happen today). Reviewed-by: johnc, brutisso ! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp ! src/share/vm/gc_implementation/g1/collectionSetChooser.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: ab4422d0ed59 Author: jcoomes Date: 2012-02-16 13:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ab4422d0ed59 7146343: PS invoke methods should indicate the type of gc done Reviewed-by: stefank, jmasa ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp Changeset: 23c0eb012d6f Author: jcoomes Date: 2012-02-16 13:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/23c0eb012d6f 6330863: vm/gc/InfiniteList.java fails intermittently due to timeout Summary: in some cases, allocate from the old gen before doing a full gc Reviewed-by: stefank, jmasa ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.inline.hpp Changeset: be398bba40e9 Author: stefank Date: 2012-02-17 13:23 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/be398bba40e9 Merge Changeset: 1b0e0f8be510 Author: minqi Date: 2012-02-09 00:51 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1b0e0f8be510 7131006: java/lang/management/ThreadMXBean/ThreadLists.java Reviewed-by: dholmes, acorn ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/utilities/preserveException.cpp Changeset: db006a85bf91 Author: zgu Date: 2012-02-09 10:16 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/db006a85bf91 7141259: Native stack is missing in hs_err Summary: Code cleanup and creating a private decoder for error handler, since it can be triggered from in signal handler, where no lock can be taken Reviewed-by: dholmes, kamg, acorn, coleenp ! src/os/bsd/vm/decoder_machO.hpp ! src/os/windows/vm/decoder_windows.hpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder.hpp ! src/share/vm/utilities/decoder_elf.hpp ! src/share/vm/utilities/vmError.hpp Changeset: ea527c5cde03 Author: zgu Date: 2012-02-09 07:35 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ea527c5cde03 Merge Changeset: 54d3535a6dd3 Author: poonam Date: 2012-02-12 19:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/54d3535a6dd3 7009098: SA cannot open core files larger than 2GB on Linux 32-bit Summary: Added Large File Support by compiling libsaproc.so with -D_FILE_OFFSET_BITS=64, and a small change with which SA should first load libraries from the path specified with SA_ALTROOT. Reviewed-by: dholmes, kevinw, dcubed, minqi ! agent/src/os/linux/Makefile ! agent/src/os/linux/libproc_impl.c ! make/linux/makefiles/saproc.make Changeset: 1bb2838e2fc1 Author: fparain Date: 2012-02-13 06:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1bb2838e2fc1 Merge Changeset: 849412a95e45 Author: coleenp Date: 2012-02-13 12:30 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/849412a95e45 7059899: Stack overflows in Java code cause 64-bit JVMs to exit due to SIGSEGV Summary: Increase StackShadowPages to accomodate the JDK changes to increase buffer size in socketWrite Reviewed-by: acorn, phh ! src/cpu/x86/vm/globals_x86.hpp Changeset: 1891640ca63f Author: fparain Date: 2012-02-14 06:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1891640ca63f 7143760: Memory leak in GarbageCollectionNotifications Reviewed-by: dholmes, dcubed, kamg ! src/share/vm/services/gcNotifier.cpp ! src/share/vm/services/gcNotifier.hpp Changeset: a9831b955a0a Author: kamg Date: 2012-02-13 14:03 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a9831b955a0a 7069991: Setup make/jprt.properties files for jdk8 Summary: Change default release value to jdk8 (but overrideable) Reviewed-by: phh, jcoomes, dholmes, ohair ! make/jprt.properties Changeset: a9ac4910e7f2 Author: kamg Date: 2012-02-14 15:52 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a9ac4910e7f2 Merge Changeset: 28d91e43ab6d Author: coleenp Date: 2012-02-14 16:50 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/28d91e43ab6d 7145587: Stack overflows in Java code cause 64-bit JVMs to exit due to SIGSEGV (sparc version) Summary: Increase StackShadowPages to accomodate the JDK changes to increase buffer size in socketWrite Reviewed-by: acorn, phh, dcubed, kamg, dsamersoff ! src/cpu/sparc/vm/globals_sparc.hpp Changeset: cf772dff4bfd Author: coleenp Date: 2012-02-14 18:35 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cf772dff4bfd Merge Changeset: b8a4e1d372a0 Author: kamg Date: 2012-02-14 20:02 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b8a4e1d372a0 7145589: First JSDT provider creation fails Summary: 0 is a successful return from an ioctl() call Reviewed-by: dcubed, phh, dsamersoff ! src/share/vm/runtime/dtraceJSDT.cpp Changeset: 91a81502a27d Author: kamg Date: 2012-02-15 00:09 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/91a81502a27d Merge Changeset: 2b150750d53d Author: sspitsyn Date: 2012-02-14 17:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2b150750d53d 7130993: nsk/jdi/ReferenceType/instances/instances004 fails with JFR: assert(ServiceUtil::visible_oop(obj)) Summary: Skip reporting invisible refs in iterate_over_object to avoid assert(ServiceUtil::visible_oop(obj)) Reviewed-by: dcubed, mgronlun, rbackman Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: cd239a88b90c Author: minqi Date: 2012-02-14 20:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cd239a88b90c Merge Changeset: 64fc5ac1b770 Author: minqi Date: 2012-02-14 23:50 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/64fc5ac1b770 Merge Changeset: f1cb6f9cfe21 Author: fparain Date: 2012-02-15 12:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f1cb6f9cfe21 7145243: Need additional specializations for argument parsing framework Reviewed-by: acorn, fparain Contributed-by: nils.loodin at oracle.com ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/diagnosticArgument.hpp ! src/share/vm/services/diagnosticFramework.cpp ! src/share/vm/services/diagnosticFramework.hpp Changeset: 4a24c4f648bd Author: phh Date: 2012-02-16 13:50 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4a24c4f648bd 7142113: Add Ivy Bridge to the known Intel x86 cpu families Summary: In vm_version_x86.hpp, add and use CPU_MODEL_IVYBRIDGE_EP, and restrict is_intel_tsc_synced_at_init() to EP models. Reviewed-by: kvn, acorn ! src/cpu/x86/vm/vm_version_x86.hpp Changeset: 7df3125953cb Author: coleenp Date: 2012-02-16 15:52 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7df3125953cb 7146354: Re-enable Compressed OOPs after 7118647 is resolved Summary: Relax the assertion to simply check for COOP mode rather than an exact address. Reviewed-by: coleenp, kvn, phh, dcubed Contributed-by: james.melvin at oracle.com ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/virtualspace.cpp Changeset: df4927a3b82e Author: coleenp Date: 2012-02-16 17:19 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/df4927a3b82e Merge Changeset: d3384450b649 Author: fparain Date: 2012-02-17 06:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d3384450b649 Merge Changeset: 73df3733f2eb Author: kvn Date: 2012-02-10 12:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/73df3733f2eb 7129284: +DoEscapeAnalysis regression w/ early build of 7u4 (HotSpot 23) on Linux Summary: Removed code which tried to create edges from fields of destination objects of arraycopy to fields of source objects. Added 30 sec time limit for EA graph construction. Reviewed-by: never ! src/share/vm/opto/escape.cpp Changeset: de34c646c3f7 Author: kvn Date: 2012-02-10 17:20 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/de34c646c3f7 7140985: HSDIS does not handle caller options correctly Summary: Fix typo. Reviewed-by: jrose, kvn Contributed-by: Andrew Haley ! src/share/tools/hsdis/hsdis.c Changeset: 45a1bf98f1bb Author: twisti Date: 2012-02-13 02:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/45a1bf98f1bb 7141329: Strange values of stack_size in -XX:+TraceMethodHandles output Reviewed-by: kvn, never ! src/cpu/x86/vm/methodHandles_x86.cpp Changeset: f09ae3853e3b Author: twisti Date: 2012-02-13 04:30 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f09ae3853e3b 7143766: add ALT_JDK_IMAGE_DIR and improve test_jdk Reviewed-by: rbackman, jrose, dholmes ! make/Makefile ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/top.make ! make/defs.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/top.make Changeset: b522995d91f0 Author: roland Date: 2012-02-14 09:43 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b522995d91f0 7144405: JumbleGC002 assert(m->offset() == pc_offset) failed: oopmap not found Summary: oop map needs pc stored in frame anchor in StubGenerator::generate_throw_exception() Reviewed-by: twisti, never, kvn ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: 8f4eb44b3b76 Author: never Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8f4eb44b3b76 7143061: nsk/stress/stack/b4525850 crash VM Reviewed-by: kvn, twisti ! src/cpu/x86/vm/globals_x86.hpp Changeset: 80107dc493db Author: roland Date: 2012-02-15 09:43 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/80107dc493db 7126041: jdk7u4 b05 and b06 crash with RubyMine 3.2.4, works well with b04 Summary: Goto that replaces a If mistaken to be a back branch and triggers erroneous OSR compilation. Reviewed-by: never, iveresov ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: 09d00c18e323 Author: never Date: 2012-02-15 10:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/09d00c18e323 7145537: minor tweaks to LogEvents Reviewed-by: kvn, twisti ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/events.hpp Changeset: cfdfbeac0a5b Author: iveresov Date: 2012-02-15 12:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cfdfbeac0a5b 7145345: Code cache sweeper must cooperate with safepoints Summary: Safepoint in the sweeper loop in necessary Reviewed-by: kvn, never ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp Changeset: 69333a2fbae2 Author: iveresov Date: 2012-02-15 16:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/69333a2fbae2 7142680: default GC affected by jvm path Summary: Removed old tiered code Reviewed-by: never, kvn ! src/share/vm/runtime/arguments.cpp Changeset: fd8114661503 Author: kvn Date: 2012-02-15 21:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fd8114661503 7125136: SIGILL on linux amd64 in gc/ArrayJuggle/Juggle29 Summary: For C2 moved saving EBP after ESP adjustment. For C1 generated 5 byte nop instruction first if needed. Reviewed-by: never, twisti, azeemj ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/output.cpp Changeset: c7401dcad8bf Author: roland Date: 2012-02-16 09:20 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c7401dcad8bf 7143038: SIGSEGV in assert_equal / LinearScan::assign_reg_num Summary: forced exit may destory global objects that are still in use. Reviewed-by: twisti, never, kvn ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp Changeset: ad3b47344802 Author: never Date: 2012-02-16 11:33 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ad3b47344802 7144318: GCLocker assert failure: assert(_needs_gc || SafepointSynchronize::is_at_safepoint( Reviewed-by: kvn, twisti ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/gcLocker.inline.hpp Changeset: 9b8ce46870df Author: kvn Date: 2012-02-16 17:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9b8ce46870df 7145346: VerifyStackAtCalls is broken Summary: Replace call_epilog() encoding with macroassembler use. Moved duplicated code to x86.ad. Fixed return_addr() definition. Reviewed-by: never ! src/cpu/x86/vm/x86.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/bsd_x86/vm/bsd_x86_32.ad ! src/os_cpu/bsd_x86/vm/bsd_x86_64.ad ! src/os_cpu/linux_x86/vm/linux_x86_32.ad ! src/os_cpu/linux_x86/vm/linux_x86_64.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_32.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_64.ad ! src/os_cpu/windows_x86/vm/windows_x86_32.ad ! src/os_cpu/windows_x86/vm/windows_x86_64.ad ! src/share/vm/opto/chaitin.cpp Changeset: 72c425c46102 Author: never Date: 2012-02-17 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/72c425c46102 7146729: nightly failure after 7141200: tty is sometimes null during shutdown of main thread Reviewed-by: kvn ! src/share/vm/utilities/events.hpp Changeset: 15085a6eb50c Author: never Date: 2012-02-17 12:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/15085a6eb50c Merge ! src/cpu/x86/vm/globals_x86.hpp ! src/share/vm/runtime/arguments.cpp Changeset: f92a171cf007 Author: amurillo Date: 2012-02-17 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f92a171cf007 Merge Changeset: 98cd09d11a21 Author: amurillo Date: 2012-02-17 15:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/98cd09d11a21 Added tag hs23-b16 for changeset f92a171cf007 ! .hgtags Changeset: 931e5f39e365 Author: kvn Date: 2012-02-20 13:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/931e5f39e365 7147064: assert(allocates2(pc)) failed: not in CodeBuffer memory: 0xffffffff778d9d60 <= 0xffffffff778da69c Summary: Increase size of deopt_blob and uncommon_trap_blob by size of stack bang code (SPARC). Reviewed-by: azeemj, iveresov, never, phh ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp Changeset: 3b24e7e01d20 Author: jcoomes Date: 2012-02-20 22:32 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3b24e7e01d20 Added tag hs23-b16 for changeset 931e5f39e365 ! .hgtags From david.katleman at sun.com Wed Feb 22 23:26:15 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 22 Feb 2012 23:26:15 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b26 for changeset dbb7283c197b Message-ID: <20120222232615.2A32D47638@hg.openjdk.java.net> Changeset: 80c47eb83d24 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/80c47eb83d24 Added tag jdk8-b26 for changeset dbb7283c197b ! .hgtags From david.katleman at sun.com Wed Feb 22 23:26:22 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 22 Feb 2012 23:26:22 +0000 Subject: hg: jdk8/build/jaxws: 5 new changesets Message-ID: <20120222232622.D2FF947639@hg.openjdk.java.net> Changeset: 329ace7198ac Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/329ace7198ac Added tag jdk8-b26 for changeset 3518639eab6c ! .hgtags Changeset: 6a8f54fb5f15 Author: alanb Date: 2012-02-05 12:07 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/6a8f54fb5f15 7140918: Remove dependency on apt and com.sun.mirror API Reviewed-by: darcy Contributed-by: miroslav.kos at oracle.com, martin.grebac at oracle.com ! build-defs.xml ! jaxws.properties Changeset: 65977d8d348e Author: lana Date: 2012-02-09 22:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/65977d8d348e Merge Changeset: b962e9c3eba2 Author: alanb Date: 2012-02-15 17:32 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b962e9c3eba2 7145910: Remove dependency on apt and com.sun.mirror API (breaks boot cycle builds) Reviewed-by: ohair ! jaxws.properties Changeset: 38c037af4127 Author: lana Date: 2012-02-18 16:09 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/38c037af4127 Merge From david.katleman at sun.com Wed Feb 22 23:27:30 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 22 Feb 2012 23:27:30 +0000 Subject: hg: jdk8/build/jdk: 50 new changesets Message-ID: <20120222233542.F1B2F4763A@hg.openjdk.java.net> Changeset: 4196fc971f65 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4196fc971f65 Added tag jdk8-b26 for changeset 5aca406e87cb ! .hgtags Changeset: 7a5c8c6f1c6b Author: prr Date: 2012-02-03 09:57 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7a5c8c6f1c6b 7141914: Draw glyph cause JVM crash Reviewed-by: bae, igor ! src/share/classes/sun/font/FileFont.java ! src/share/classes/sun/font/StandardGlyphVector.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/font/TrueTypeFont.java Changeset: 996cd6e8d00e Author: lana Date: 2012-02-09 19:42 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/996cd6e8d00e Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: a06fd6ada85c Author: prr Date: 2012-02-14 14:16 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a06fd6ada85c 7143612: improve backwards compatibility of OSIS post-CR6887286 Reviewed-by: flar, prr Contributed-by: david.buck at oracle.com ! src/share/classes/sun/awt/image/OffScreenImageSource.java Changeset: 45ce82d366ec Author: anthony Date: 2012-02-02 17:49 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/45ce82d366ec 7132194: GtkFileDialog does not point to the correct file(s) is Recent Files are used. Summary: Handle the file list differently if gtk_file_chooser_get_current_folder() returns NULL Reviewed-by: anthony Contributed-by: Matthew Smith ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: 10fa63972ad5 Author: rupashka Date: 2012-02-03 17:57 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/10fa63972ad5 7141573: JProgressBar resize exception, if setStringPainted in Windows LAF Reviewed-by: malenkov ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsProgressBarUI.java + test/javax/swing/JProgressBar/7141573/bug7141573.java Changeset: 34571be262e9 Author: rupashka Date: 2012-02-03 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/34571be262e9 7071775: javax/swing/JFileChooser/6396844/TwentyThousandTest.java failed on winxp Reviewed-by: alexp ! test/javax/swing/JFileChooser/6396844/TwentyThousandTest.java Changeset: 1880e8cc89b8 Author: rupashka Date: 2012-02-08 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1880e8cc89b8 7138665: JOptionPane.getValue() unexpected change between JRE 1.6 and JRE 1.7 Reviewed-by: alexp ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java + test/javax/swing/JOptionPane/7138665/bug7138665.java Changeset: d2e067142112 Author: bagiras Date: 2012-02-08 18:28 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d2e067142112 7132367: [macosx] ChoiceMouseWheelTest should be adapted for mac toolkit Reviewed-by: art ! test/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java Changeset: d43447758eba Author: rupashka Date: 2012-02-09 14:21 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d43447758eba 7143857: Memory leak in javax.swing.plaf.synth.SynthTreeUI Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java Changeset: 403e3bb8a162 Author: rupashka Date: 2012-02-09 18:26 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/403e3bb8a162 7142955: DefaultTreeCellRenderer doesn't honor 'Tree.rendererFillBackground' LAF property Reviewed-by: malenkov ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java + test/javax/swing/tree/DefaultTreeCellRenderer/7142955/bug7142955.java Changeset: a3b50244bd10 Author: chegar Date: 2012-02-10 11:03 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a3b50244bd10 7144475: fix some warnings in java.awt, javax.print.attribute.standard, and sun.beans.infos Reviewed-by: chegar, prr, alanb, anthony Contributed-by: Prasannaa , Martijn Verburg , Goerge Albrecht , Graham Allan , Iordanis Giannakakis , Jose Llarena , Abrahamn Marin Perez ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/javax/print/attribute/standard/PrinterStateReasons.java ! src/share/classes/javax/print/attribute/standard/ReferenceUriSchemesSupported.java ! src/share/classes/sun/beans/infos/ComponentBeanInfo.java Changeset: 55adee49df8e Author: alexsch Date: 2012-02-10 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/55adee49df8e 7109991: SwingUtilities.isXMouseButton behaves unexpectedly starting from JDK8 b08 Reviewed-by: rupashka ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/awt/event/MouseEvent.java Changeset: de74d3310e96 Author: lana Date: 2012-02-09 23:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/de74d3310e96 Merge - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: 081a44952699 Author: lana Date: 2012-02-10 10:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/081a44952699 Merge Changeset: 3f4701d08418 Author: bagiras Date: 2012-02-13 17:49 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3f4701d08418 7143070: test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit Reviewed-by: anthony ! test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java Changeset: a1dc74291966 Author: alexsch Date: 2012-02-14 18:44 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a1dc74291966 7133577: [macosx] closed/javax/swing/JTree/4314199/bug4314199.java fails on MacOS Reviewed-by: rupashka + test/javax/swing/JTree/4314199/bug4314199.html + test/javax/swing/JTree/4314199/bug4314199.java Changeset: 24e30ae2a192 Author: lana Date: 2012-02-15 15:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/24e30ae2a192 Merge Changeset: ac26d04e76c3 Author: fparain Date: 2012-02-01 03:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ac26d04e76c3 7120974: ManagementPermission "control" needs clarification Reviewed-by: mchung, dholmes ! src/share/classes/java/lang/management/ManagementPermission.java Changeset: 55a82eba1986 Author: wetmore Date: 2012-02-01 16:00 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/55a82eba1986 7141910: Incorrect copyright dates on new test cases. Reviewed-by: mullan ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOneExtraByte.sh Changeset: 24478d62d068 Author: ksrini Date: 2012-02-02 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/24478d62d068 7141141: Add 3 new test scenarios for testing Main-Class attribute in jar manifest file Reviewed-by: ksrini, darcy Contributed-by: sonali.goel at oracle.com ! test/tools/launcher/Arrrghs.java + test/tools/launcher/MainClassAttributeTest.java Changeset: bbadb6605a1c Author: chegar Date: 2012-02-04 07:29 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bbadb6605a1c 7041778: Move SCTP implementation out of sun.nio.ch and into its own package Reviewed-by: alanb ! make/com/sun/nio/sctp/Exportedfiles.gmk ! make/com/sun/nio/sctp/FILES_java.gmk ! make/com/sun/nio/sctp/Makefile ! make/com/sun/nio/sctp/mapfile-vers ! src/share/classes/com/sun/nio/sctp/MessageInfo.java ! src/share/classes/com/sun/nio/sctp/SctpChannel.java ! src/share/classes/com/sun/nio/sctp/SctpMultiChannel.java ! src/share/classes/com/sun/nio/sctp/SctpServerChannel.java ! src/share/classes/com/sun/nio/sctp/SctpStandardSocketOptions.java ! src/share/classes/sun/nio/ch/AbstractPollArrayWrapper.java ! src/share/classes/sun/nio/ch/AbstractPollSelectorImpl.java ! src/share/classes/sun/nio/ch/IOStatus.java ! src/share/classes/sun/nio/ch/IOUtil.java ! src/share/classes/sun/nio/ch/Net.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java ! src/share/classes/sun/nio/ch/SelChImpl.java ! src/share/classes/sun/nio/ch/SelectionKeyImpl.java ! src/share/classes/sun/nio/ch/SelectorImpl.java ! src/share/classes/sun/nio/ch/Util.java + src/share/classes/sun/nio/ch/sctp/MessageInfoImpl.java + src/share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java ! src/solaris/classes/sun/nio/ch/DevPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/NativeThread.java ! src/solaris/classes/sun/nio/ch/PollArrayWrapper.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java + src/solaris/classes/sun/nio/ch/sctp/AssociationChange.java + src/solaris/classes/sun/nio/ch/sctp/AssociationImpl.java + src/solaris/classes/sun/nio/ch/sctp/PeerAddrChange.java + src/solaris/classes/sun/nio/ch/sctp/ResultContainer.java + src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java + src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java + src/solaris/classes/sun/nio/ch/sctp/SctpNet.java + src/solaris/classes/sun/nio/ch/sctp/SctpNotification.java + src/solaris/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java + src/solaris/classes/sun/nio/ch/sctp/SendFailed.java + src/solaris/classes/sun/nio/ch/sctp/Shutdown.java - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c + src/solaris/native/sun/nio/ch/sctp/Sctp.h + src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c + src/solaris/native/sun/nio/ch/sctp/SctpNet.c + src/solaris/native/sun/nio/ch/sctp/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java + src/windows/classes/sun/nio/ch/sctp/SctpChannelImpl.java + src/windows/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java + src/windows/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java Changeset: e528a64dd21b Author: chegar Date: 2012-02-04 07:36 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e528a64dd21b Merge Changeset: ce5ffdb2be25 Author: alanb Date: 2012-02-05 12:29 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ce5ffdb2be25 7140918: Remove dependency on apt and com.sun.mirror API Reviewed-by: darcy Contributed-by: miroslav.kos at oracle.com, martin.grebac at oracle.com ! make/common/Release.gmk ! make/common/internal/Defs-jaxws.gmk Changeset: e55522710586 Author: darcy Date: 2012-02-05 21:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e55522710586 7041249: Remove apt tool and API from the JDK Reviewed-by: jjg, ohair ! make/com/sun/Makefile ! make/common/Release.gmk ! make/common/internal/Defs-langtools.gmk ! make/docs/Makefile ! make/docs/NON_CORE_PKGS.gmk ! make/launchers/Makefile ! make/launchers/Makefile.launcher - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 Changeset: c6d6ef8ec2bf Author: alanb Date: 2012-02-07 13:28 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c6d6ef8ec2bf 7142847: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java has incorrect @run tag, runs Basic Reviewed-by: chegar ! test/java/nio/file/WatchService/Basic.java ! test/java/nio/file/WatchService/SensitivityModifier.java Changeset: 946056e6116e Author: darcy Date: 2012-02-07 17:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/946056e6116e 7143629: JDK jar/zip code should use unsigned library support Reviewed-by: sherman ! src/share/classes/java/util/jar/JarOutputStream.java ! src/share/classes/java/util/jar/Manifest.java ! src/share/classes/java/util/zip/InflaterInputStream.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipConstants.java Changeset: 085c4f780d4e Author: weijun Date: 2012-02-08 11:44 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/085c4f780d4e 6880619: reg tests for 6879540 Reviewed-by: valeriep + test/sun/security/krb5/auto/EmptyPassword.java Changeset: c64c815974ff Author: chegar Date: 2012-02-08 11:16 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c64c815974ff 7105929: java/util/concurrent/FutureTask/BlockingTaskExecutor.java fails on solaris sparc Reviewed-by: dholmes ! test/java/util/concurrent/FutureTask/BlockingTaskExecutor.java Changeset: 7289599216fe Author: gadams Date: 2012-02-08 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7289599216fe 6736316: Timeout value in java/util/concurrent/locks/Lock/FlakyMutex.java is insufficient Reviewed-by: chegar, dholmes, alanb ! test/java/util/concurrent/locks/Lock/FlakyMutex.java Changeset: 72d8f91514d1 Author: gadams Date: 2012-02-08 11:19 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/72d8f91514d1 6957683: test/java/util/concurrent/ThreadPoolExecutor/Custom.java failing Reviewed-by: chegar, dholmes, alanb ! test/java/util/concurrent/ThreadPoolExecutor/Custom.java Changeset: 184b9cb4f13a Author: alanb Date: 2012-02-09 13:43 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/184b9cb4f13a 7114611: (fs) DirectoryStream fails with SIGBUS on some embedded platforms, dirent alignment Reviewed-by: dholmes, alanb Contributed-by: carlos.lucasius at oracle.com ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c Changeset: 8326d434681d Author: alanb Date: 2012-02-09 16:38 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8326d434681d 7144086: TEST_BUG: java/nio/file/WatchService/SensitivityModifier.java failing intermittently Reviewed-by: chegar ! test/java/nio/file/WatchService/SensitivityModifier.java Changeset: bdd1dd1e1462 Author: weijun Date: 2012-02-10 11:41 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bdd1dd1e1462 6879539: enable empty password support for pkcs12 keystore Reviewed-by: vinnie, weijun Contributed-by: Florian Weimer ! src/share/classes/com/sun/crypto/provider/PBEKey.java ! src/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java + test/sun/security/pkcs12/Bug6415637.java Changeset: 7fc2797cbb4c Author: lana Date: 2012-02-09 22:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7fc2797cbb4c Merge Changeset: b16cbeb0d213 Author: wetmore Date: 2012-02-10 19:07 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b16cbeb0d213 7142509: Cipher.doFinal(ByteBuffer,ByteBuffer) fails to process when in.remaining() == 0 Reviewed-by: valeriep ! src/share/classes/javax/crypto/CipherSpi.java + test/javax/crypto/CipherSpi/DirectBBRemaining.java Changeset: da8b8ee281f9 Author: xuelei Date: 2012-02-10 22:17 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/da8b8ee281f9 7144781: incorrect URLs in JSSE java doc Reviewed-by: wetmore, skannan ! src/share/classes/javax/net/ssl/ExtendedSSLSession.java ! src/share/classes/javax/net/ssl/SSLParameters.java Changeset: 27a6b299ed6a Author: chegar Date: 2012-02-12 08:47 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/27a6b299ed6a 7133367: ResponseCache.put should not be called when setUseCaches(false) Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/NoCache.java Changeset: 27e746e6f3fe Author: alanb Date: 2012-02-12 21:09 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/27e746e6f3fe 7144895: ProblemList.txt updates (2/2012) Reviewed-by: darcy, ohair ! test/Makefile ! test/ProblemList.txt ! test/TEST.ROOT Changeset: 445ada5e6b4a Author: smarks Date: 2012-02-12 21:56 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/445ada5e6b4a 7143230: fix warnings in java.util.jar, sun.tools.jar, zipfs demo, etc. Reviewed-by: alanb, chegar, lancea, smarks Contributed-by: Mani Sarkar , Michael Barker , Carl Jokl , Dinuk Weerasinghe , Markus Stoy , Tom Anderson ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/sun/tools/jar/CommandLine.java ! src/share/classes/sun/tools/jar/Manifest.java ! src/share/classes/sun/tools/jar/SignatureFile.java ! src/share/demo/management/MemoryMonitor/MemoryMonitor.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileStore.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipInfo.java Changeset: 3554f175341a Author: vinnie Date: 2012-02-13 14:26 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3554f175341a 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done Reviewed-by: xuelei, wetmore ! src/share/classes/sun/security/pkcs/PKCS7.java Changeset: 59bd472746d6 Author: vinnie Date: 2012-02-13 14:31 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/59bd472746d6 Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java Changeset: f62077973f9b Author: vinnie Date: 2012-02-14 11:47 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f62077973f9b 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc Reviewed-by: xuelei ! test/sun/security/tools/jarsigner/ec.sh Changeset: 13aef38438d8 Author: fparain Date: 2012-02-14 07:28 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/13aef38438d8 7140868: TEST_BUG: jcmd tests need to use -XX:+UsePerfData Reviewed-by: fparain, dholmes ! test/sun/tools/jcmd/jcmd-Defaults.sh ! test/sun/tools/jcmd/jcmd-f.sh ! test/sun/tools/jcmd/jcmd-help-help.sh ! test/sun/tools/jcmd/jcmd-help.sh ! test/sun/tools/jcmd/jcmd-pid.sh Changeset: 0720542d6c1e Author: mullan Date: 2012-02-15 07:45 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0720542d6c1e 7024604: OID.1 causes IAE in X500Principal constructor Reviewed-by: vinnie ! src/share/classes/javax/security/auth/x500/X500Principal.java ! src/share/classes/javax/security/auth/x500/package.html ! test/javax/security/auth/x500/X500Principal/Parse.java Changeset: 3207b3e271f2 Author: mullan Date: 2012-02-15 07:52 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3207b3e271f2 Merge Changeset: 59884f656b7d Author: fparain Date: 2012-02-15 09:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/59884f656b7d 7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently Reviewed-by: alanb ! test/ProblemList.txt ! test/sun/tools/jcmd/jcmd_Output1.awk Changeset: 20d39a0e6fdc Author: fparain Date: 2012-02-15 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/20d39a0e6fdc 7145925: Removing remote access to diagnostic commands in the HotSpotDiagnosticMBean Reviewed-by: acorn, mchung, phh ! make/java/management/mapfile-vers - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/native/sun/management/HotSpotDiagnostic.c - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java Changeset: 2a3f026b3a29 Author: lana Date: 2012-02-15 15:28 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2a3f026b3a29 Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java Changeset: c68342532e2e Author: lana Date: 2012-02-18 16:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c68342532e2e Merge - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/com/sun/management/DiagnosticCommandArgumentInfo.java - src/share/classes/com/sun/management/DiagnosticCommandInfo.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java - test/com/sun/management/HotSpotDiagnosticMXBean/ExecuteDiagnosticCommand.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommandInfo.java - test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticCommands.java From david.katleman at sun.com Wed Feb 22 23:38:03 2012 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 22 Feb 2012 23:38:03 +0000 Subject: hg: jdk8/build/langtools: 8 new changesets Message-ID: <20120222233820.DF2DA4763B@hg.openjdk.java.net> Changeset: fba3cbee0fa3 Author: katleman Date: 2012-02-16 13:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/fba3cbee0fa3 Added tag jdk8-b26 for changeset b556aa8a99c3 ! .hgtags Changeset: 2360c8213989 Author: darcy Date: 2012-02-05 21:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/2360c8213989 7041249: Remove apt tool and API from the JDK Reviewed-by: jjg, ohair ! make/Makefile-classic ! make/build.properties ! make/build.xml ! make/netbeans/README - make/test/lib/apt.sh ! make/test/lib/src.gold.txt - src/share/classes/com/sun/mirror/apt/AnnotationProcessor.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorEnvironment.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorFactory.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorListener.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessors.java - src/share/classes/com/sun/mirror/apt/Filer.java - src/share/classes/com/sun/mirror/apt/Messager.java - src/share/classes/com/sun/mirror/apt/RoundCompleteEvent.java - src/share/classes/com/sun/mirror/apt/RoundCompleteListener.java - src/share/classes/com/sun/mirror/apt/RoundState.java - src/share/classes/com/sun/mirror/apt/package-info.java - src/share/classes/com/sun/mirror/declaration/AnnotationMirror.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeElementDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationValue.java - src/share/classes/com/sun/mirror/declaration/ClassDeclaration.java - src/share/classes/com/sun/mirror/declaration/ConstructorDeclaration.java - src/share/classes/com/sun/mirror/declaration/Declaration.java - src/share/classes/com/sun/mirror/declaration/EnumConstantDeclaration.java - src/share/classes/com/sun/mirror/declaration/EnumDeclaration.java - src/share/classes/com/sun/mirror/declaration/ExecutableDeclaration.java - src/share/classes/com/sun/mirror/declaration/FieldDeclaration.java - src/share/classes/com/sun/mirror/declaration/InterfaceDeclaration.java - src/share/classes/com/sun/mirror/declaration/MemberDeclaration.java - src/share/classes/com/sun/mirror/declaration/MethodDeclaration.java - src/share/classes/com/sun/mirror/declaration/Modifier.java - src/share/classes/com/sun/mirror/declaration/PackageDeclaration.java - src/share/classes/com/sun/mirror/declaration/ParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/package-info.java - src/share/classes/com/sun/mirror/overview.html - src/share/classes/com/sun/mirror/type/AnnotationType.java - src/share/classes/com/sun/mirror/type/ArrayType.java - src/share/classes/com/sun/mirror/type/ClassType.java - src/share/classes/com/sun/mirror/type/DeclaredType.java - src/share/classes/com/sun/mirror/type/EnumType.java - src/share/classes/com/sun/mirror/type/InterfaceType.java - src/share/classes/com/sun/mirror/type/MirroredTypeException.java - src/share/classes/com/sun/mirror/type/MirroredTypesException.java - src/share/classes/com/sun/mirror/type/PrimitiveType.java - src/share/classes/com/sun/mirror/type/ReferenceType.java - src/share/classes/com/sun/mirror/type/TypeMirror.java - src/share/classes/com/sun/mirror/type/TypeVariable.java - src/share/classes/com/sun/mirror/type/VoidType.java - src/share/classes/com/sun/mirror/type/WildcardType.java - src/share/classes/com/sun/mirror/type/package-info.java - src/share/classes/com/sun/mirror/util/DeclarationFilter.java - src/share/classes/com/sun/mirror/util/DeclarationScanner.java - src/share/classes/com/sun/mirror/util/DeclarationVisitor.java - src/share/classes/com/sun/mirror/util/DeclarationVisitors.java - src/share/classes/com/sun/mirror/util/Declarations.java - src/share/classes/com/sun/mirror/util/SimpleDeclarationVisitor.java - src/share/classes/com/sun/mirror/util/SimpleTypeVisitor.java - src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java - src/share/classes/com/sun/mirror/util/SourcePosition.java - src/share/classes/com/sun/mirror/util/TypeVisitor.java - src/share/classes/com/sun/mirror/util/Types.java - src/share/classes/com/sun/mirror/util/package-info.java - src/share/classes/com/sun/tools/apt/Main.java - src/share/classes/com/sun/tools/apt/comp/AnnotationProcessingError.java - src/share/classes/com/sun/tools/apt/comp/Apt.java - src/share/classes/com/sun/tools/apt/comp/BootstrapAPF.java - src/share/classes/com/sun/tools/apt/comp/PrintAP.java - src/share/classes/com/sun/tools/apt/comp/UsageMessageNeededException.java - src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java - src/share/classes/com/sun/tools/apt/main/CommandLine.java - src/share/classes/com/sun/tools/apt/main/Main.java - src/share/classes/com/sun/tools/apt/mirror/AptEnv.java - src/share/classes/com/sun/tools/apt/mirror/apt/AnnotationProcessorEnvironmentImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/MessagerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundCompleteEventImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundStateImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeElementDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationValueImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ClassDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/Constants.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ConstructorDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumConstantDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ExecutableDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/FieldDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/InterfaceDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MemberDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MethodDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/PackageDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/AnnotationTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ArrayTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ClassTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/DeclaredTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/EnumTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/InterfaceTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/PrimitiveTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMaker.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeVariableImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/VoidTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/WildcardTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/DeclarationsImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/SourcePositionImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/TypesImpl.java - src/share/classes/com/sun/tools/apt/resources/apt.properties - src/share/classes/com/sun/tools/apt/resources/apt_ja.properties - src/share/classes/com/sun/tools/apt/resources/apt_zh_CN.properties - src/share/classes/com/sun/tools/apt/util/Bark.java - test/tools/apt/Basics/Aggregate.java - test/tools/apt/Basics/ClassAnnotations.java - test/tools/apt/Basics/FreshnessApf.java - test/tools/apt/Basics/GenClass.java - test/tools/apt/Basics/Indirect.java - test/tools/apt/Basics/Lacuna.java - test/tools/apt/Basics/MethodAnnotations.java - test/tools/apt/Basics/Milk.java - test/tools/apt/Basics/MisMatch.java - test/tools/apt/Basics/Misc.java - test/tools/apt/Basics/MyMarker.java - test/tools/apt/Basics/MySimple.java - test/tools/apt/Basics/NestedClassAnnotations.java - test/tools/apt/Basics/ParameterAnnotations.java - test/tools/apt/Basics/StaticFieldAnnotations.java - test/tools/apt/Basics/StaticMethodAnnotations.java - test/tools/apt/Basics/TestGetPackageApf.java - test/tools/apt/Basics/TestGetTypeDeclarationApf.java - test/tools/apt/Basics/annot/AnnotMarker.java - test/tools/apt/Basics/annot/AnnotShangri_la.java - test/tools/apt/Basics/annot/AnnotSimple.java - test/tools/apt/Basics/annot/annot2/AnnotMarker2.java - test/tools/apt/Basics/annot/annot2/AnnotSimple2.java ! test/tools/apt/Basics/apt.sh - test/tools/apt/Basics/com.sun.mirror.apt.AnnotationProcessorFactory - test/tools/apt/Basics/foo/bar/Baz.java - test/tools/apt/Basics/foo/bar/Quux.java - test/tools/apt/Basics/golden.txt - test/tools/apt/Basics/goldenAggregate.txt - test/tools/apt/Basics/p1/p2.java - test/tools/apt/Basics/p1/p2/C1.java - test/tools/apt/Basics/print.sh - test/tools/apt/Compile/ClassDeclApf.java - test/tools/apt/Compile/ClassDeclApf2.java - test/tools/apt/Compile/Dummy1.java - test/tools/apt/Compile/ErrorAPF.java - test/tools/apt/Compile/HelloAnnotation.java - test/tools/apt/Compile/HelloWorld.java - test/tools/apt/Compile/Round1Apf.java - test/tools/apt/Compile/Round2Apf.java - test/tools/apt/Compile/Round3Apf.java - test/tools/apt/Compile/Round4Apf.java - test/tools/apt/Compile/Rounds.java - test/tools/apt/Compile/StaticApf.java - test/tools/apt/Compile/WarnAPF.java - test/tools/apt/Compile/WrappedStaticApf.java - test/tools/apt/Compile/compile.sh - test/tools/apt/Compile/golden.txt - test/tools/apt/Compile/goldenFactory.txt - test/tools/apt/Compile/goldenWarn.txt - test/tools/apt/Compile/servicesRound1 - test/tools/apt/Compile/servicesRound2 - test/tools/apt/Compile/servicesRound3 - test/tools/apt/Compile/servicesRound4 - test/tools/apt/Compile/servicesStaticApf - test/tools/apt/Compile/src/AhOneClass.java - test/tools/apt/Compile/src/AndAhTwoClass.java - test/tools/apt/Compile/src/Round1Class.java - test/tools/apt/Discovery/Dee.java - test/tools/apt/Discovery/Dum.java - test/tools/apt/Discovery/Empty.java - test/tools/apt/Discovery/PhantomTouch.java - test/tools/apt/Discovery/PhantomUpdate.java - test/tools/apt/Discovery/Touch.java - test/tools/apt/Discovery/discovery.sh - test/tools/apt/Discovery/servicesBadTouch - test/tools/apt/Discovery/servicesPhantomTouch - test/tools/apt/Discovery/servicesTouch - test/tools/apt/Discovery/servicesTweedle - test/tools/apt/Misc/Marked.java - test/tools/apt/Misc/Marker.java - test/tools/apt/Misc/Misc.java - test/tools/apt/Misc/misc.sh - test/tools/apt/Misc/servicesMisc - test/tools/apt/Options/Marked.java - test/tools/apt/Options/Marker.java - test/tools/apt/Options/OptionChecker.java - test/tools/apt/Options/options.sh - test/tools/apt/Options/servicesOptions - test/tools/apt/Scanners/Counter.java - test/tools/apt/Scanners/MemberOrderApf.java - test/tools/apt/Scanners/Order.java - test/tools/apt/Scanners/Scanner.java - test/tools/apt/Scanners/TestEnum.java - test/tools/apt/Scanners/VisitOrder.java - test/tools/apt/Scanners/scanner.sh - test/tools/apt/Scanners/servicesScanner - test/tools/apt/lib/Ignore.java - test/tools/apt/lib/Test.java - test/tools/apt/lib/TestProcessor.java - test/tools/apt/lib/TestProcessorFactory.java - test/tools/apt/lib/Tester.java - test/tools/apt/mirror/declaration/AnnoMirror.java - test/tools/apt/mirror/declaration/AnnoTypeDecl.java - test/tools/apt/mirror/declaration/AnnoTypeElemDecl.java - test/tools/apt/mirror/declaration/AnnoVal.java - test/tools/apt/mirror/declaration/ClassDecl.java - test/tools/apt/mirror/declaration/ConstExpr.java - test/tools/apt/mirror/declaration/ConstructorDecl.java - test/tools/apt/mirror/declaration/EnumDecl.java - test/tools/apt/mirror/declaration/FieldDecl.java - test/tools/apt/mirror/declaration/GetAnno.java - test/tools/apt/mirror/declaration/InterfaceDecl.java - test/tools/apt/mirror/declaration/MethodDecl.java - test/tools/apt/mirror/declaration/PackageDecl.java - test/tools/apt/mirror/declaration/ParameterDecl.java - test/tools/apt/mirror/declaration/pkg1/AClass.java - test/tools/apt/mirror/declaration/pkg1/AnAnnoType.java - test/tools/apt/mirror/declaration/pkg1/AnEnum.java - test/tools/apt/mirror/declaration/pkg1/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/package-info.java - test/tools/apt/mirror/declaration/pkg1/pkg2/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/pkg2/package.html - test/tools/apt/mirror/type/AnnoTyp.java - test/tools/apt/mirror/type/ArrayTyp.java - test/tools/apt/mirror/type/ClassTyp.java - test/tools/apt/mirror/type/EnumTyp.java - test/tools/apt/mirror/type/InterfaceTyp.java - test/tools/apt/mirror/type/PrimitiveTyp.java - test/tools/apt/mirror/type/TypeVar.java - test/tools/apt/mirror/type/WildcardTyp.java - test/tools/apt/mirror/util/Overrides.java - test/tools/apt/mirror/util/TypeCreation.java Changeset: 2ac31f40741d Author: lana Date: 2012-02-09 22:56 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/2ac31f40741d Merge Changeset: cd5ca700da4c Author: jjg Date: 2012-02-12 16:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/cd5ca700da4c 7144979: incorrect path separator in make/build.xml for Windows when running jtreg tests Reviewed-by: jjg Contributed-by: jan.valenta at oracle.com ! make/build.xml Changeset: 237198ef45f5 Author: jjh Date: 2012-02-13 16:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/237198ef45f5 7142672: Problems with the value passed to the 'classes' param of JavaCompiler.CompilationTask.getTask(...) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/T7142672/AnnoProcessor.java + test/tools/javac/T7142672/Bug.java + test/tools/javac/T7142672/Test2.java + test/tools/javac/T7142672/Test3.java Changeset: 84b61130cbed Author: mcimadamore Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/84b61130cbed 7142086: performance problem in Check.checkOverrideClashes(...) Summary: Code in Check.checkOverrideClashes() causes too many calls to MethodSymbol.overrides Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/7142086/T7142086.java Changeset: e127334a64fe Author: darcy Date: 2012-02-17 15:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e127334a64fe 7143910: test/tools/apt/Basics/apt.sh fails with 'real' sh Reviewed-by: darcy Contributed-by: sonali.goel at oracle.com ! test/tools/apt/Basics/apt.sh Changeset: be456f9c64e8 Author: lana Date: 2012-02-18 16:12 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/be456f9c64e8 Merge - make/test/lib/apt.sh - src/share/classes/com/sun/mirror/apt/AnnotationProcessor.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorEnvironment.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorFactory.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessorListener.java - src/share/classes/com/sun/mirror/apt/AnnotationProcessors.java - src/share/classes/com/sun/mirror/apt/Filer.java - src/share/classes/com/sun/mirror/apt/Messager.java - src/share/classes/com/sun/mirror/apt/RoundCompleteEvent.java - src/share/classes/com/sun/mirror/apt/RoundCompleteListener.java - src/share/classes/com/sun/mirror/apt/RoundState.java - src/share/classes/com/sun/mirror/apt/package-info.java - src/share/classes/com/sun/mirror/declaration/AnnotationMirror.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationTypeElementDeclaration.java - src/share/classes/com/sun/mirror/declaration/AnnotationValue.java - src/share/classes/com/sun/mirror/declaration/ClassDeclaration.java - src/share/classes/com/sun/mirror/declaration/ConstructorDeclaration.java - src/share/classes/com/sun/mirror/declaration/Declaration.java - src/share/classes/com/sun/mirror/declaration/EnumConstantDeclaration.java - src/share/classes/com/sun/mirror/declaration/EnumDeclaration.java - src/share/classes/com/sun/mirror/declaration/ExecutableDeclaration.java - src/share/classes/com/sun/mirror/declaration/FieldDeclaration.java - src/share/classes/com/sun/mirror/declaration/InterfaceDeclaration.java - src/share/classes/com/sun/mirror/declaration/MemberDeclaration.java - src/share/classes/com/sun/mirror/declaration/MethodDeclaration.java - src/share/classes/com/sun/mirror/declaration/Modifier.java - src/share/classes/com/sun/mirror/declaration/PackageDeclaration.java - src/share/classes/com/sun/mirror/declaration/ParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeDeclaration.java - src/share/classes/com/sun/mirror/declaration/TypeParameterDeclaration.java - src/share/classes/com/sun/mirror/declaration/package-info.java - src/share/classes/com/sun/mirror/overview.html - src/share/classes/com/sun/mirror/type/AnnotationType.java - src/share/classes/com/sun/mirror/type/ArrayType.java - src/share/classes/com/sun/mirror/type/ClassType.java - src/share/classes/com/sun/mirror/type/DeclaredType.java - src/share/classes/com/sun/mirror/type/EnumType.java - src/share/classes/com/sun/mirror/type/InterfaceType.java - src/share/classes/com/sun/mirror/type/MirroredTypeException.java - src/share/classes/com/sun/mirror/type/MirroredTypesException.java - src/share/classes/com/sun/mirror/type/PrimitiveType.java - src/share/classes/com/sun/mirror/type/ReferenceType.java - src/share/classes/com/sun/mirror/type/TypeMirror.java - src/share/classes/com/sun/mirror/type/TypeVariable.java - src/share/classes/com/sun/mirror/type/VoidType.java - src/share/classes/com/sun/mirror/type/WildcardType.java - src/share/classes/com/sun/mirror/type/package-info.java - src/share/classes/com/sun/mirror/util/DeclarationFilter.java - src/share/classes/com/sun/mirror/util/DeclarationScanner.java - src/share/classes/com/sun/mirror/util/DeclarationVisitor.java - src/share/classes/com/sun/mirror/util/DeclarationVisitors.java - src/share/classes/com/sun/mirror/util/Declarations.java - src/share/classes/com/sun/mirror/util/SimpleDeclarationVisitor.java - src/share/classes/com/sun/mirror/util/SimpleTypeVisitor.java - src/share/classes/com/sun/mirror/util/SourceOrderDeclScanner.java - src/share/classes/com/sun/mirror/util/SourcePosition.java - src/share/classes/com/sun/mirror/util/TypeVisitor.java - src/share/classes/com/sun/mirror/util/Types.java - src/share/classes/com/sun/mirror/util/package-info.java - src/share/classes/com/sun/tools/apt/Main.java - src/share/classes/com/sun/tools/apt/comp/AnnotationProcessingError.java - src/share/classes/com/sun/tools/apt/comp/Apt.java - src/share/classes/com/sun/tools/apt/comp/BootstrapAPF.java - src/share/classes/com/sun/tools/apt/comp/PrintAP.java - src/share/classes/com/sun/tools/apt/comp/UsageMessageNeededException.java - src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java - src/share/classes/com/sun/tools/apt/main/CommandLine.java - src/share/classes/com/sun/tools/apt/main/Main.java - src/share/classes/com/sun/tools/apt/mirror/AptEnv.java - src/share/classes/com/sun/tools/apt/mirror/apt/AnnotationProcessorEnvironmentImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/FilerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/MessagerImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundCompleteEventImpl.java - src/share/classes/com/sun/tools/apt/mirror/apt/RoundStateImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationTypeElementDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationValueImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ClassDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/Constants.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ConstructorDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/DeclarationMaker.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumConstantDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/EnumDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ExecutableDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/FieldDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/InterfaceDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MemberDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/MethodDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/PackageDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/ParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/declaration/TypeParameterDeclarationImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/AnnotationTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ArrayTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/ClassTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/DeclaredTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/EnumTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/InterfaceTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/PrimitiveTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMaker.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeMirrorImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/TypeVariableImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/VoidTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/type/WildcardTypeImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/DeclarationsImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/SourcePositionImpl.java - src/share/classes/com/sun/tools/apt/mirror/util/TypesImpl.java - src/share/classes/com/sun/tools/apt/resources/apt.properties - src/share/classes/com/sun/tools/apt/resources/apt_ja.properties - src/share/classes/com/sun/tools/apt/resources/apt_zh_CN.properties - src/share/classes/com/sun/tools/apt/util/Bark.java - test/tools/apt/Basics/Aggregate.java - test/tools/apt/Basics/ClassAnnotations.java - test/tools/apt/Basics/FreshnessApf.java - test/tools/apt/Basics/GenClass.java - test/tools/apt/Basics/Indirect.java - test/tools/apt/Basics/Lacuna.java - test/tools/apt/Basics/MethodAnnotations.java - test/tools/apt/Basics/Milk.java - test/tools/apt/Basics/MisMatch.java - test/tools/apt/Basics/Misc.java - test/tools/apt/Basics/MyMarker.java - test/tools/apt/Basics/MySimple.java - test/tools/apt/Basics/NestedClassAnnotations.java - test/tools/apt/Basics/ParameterAnnotations.java - test/tools/apt/Basics/StaticFieldAnnotations.java - test/tools/apt/Basics/StaticMethodAnnotations.java - test/tools/apt/Basics/TestGetPackageApf.java - test/tools/apt/Basics/TestGetTypeDeclarationApf.java - test/tools/apt/Basics/annot/AnnotMarker.java - test/tools/apt/Basics/annot/AnnotShangri_la.java - test/tools/apt/Basics/annot/AnnotSimple.java - test/tools/apt/Basics/annot/annot2/AnnotMarker2.java - test/tools/apt/Basics/annot/annot2/AnnotSimple2.java - test/tools/apt/Basics/com.sun.mirror.apt.AnnotationProcessorFactory - test/tools/apt/Basics/foo/bar/Baz.java - test/tools/apt/Basics/foo/bar/Quux.java - test/tools/apt/Basics/golden.txt - test/tools/apt/Basics/goldenAggregate.txt - test/tools/apt/Basics/p1/p2.java - test/tools/apt/Basics/p1/p2/C1.java - test/tools/apt/Basics/print.sh - test/tools/apt/Compile/ClassDeclApf.java - test/tools/apt/Compile/ClassDeclApf2.java - test/tools/apt/Compile/Dummy1.java - test/tools/apt/Compile/ErrorAPF.java - test/tools/apt/Compile/HelloAnnotation.java - test/tools/apt/Compile/HelloWorld.java - test/tools/apt/Compile/Round1Apf.java - test/tools/apt/Compile/Round2Apf.java - test/tools/apt/Compile/Round3Apf.java - test/tools/apt/Compile/Round4Apf.java - test/tools/apt/Compile/Rounds.java - test/tools/apt/Compile/StaticApf.java - test/tools/apt/Compile/WarnAPF.java - test/tools/apt/Compile/WrappedStaticApf.java - test/tools/apt/Compile/compile.sh - test/tools/apt/Compile/golden.txt - test/tools/apt/Compile/goldenFactory.txt - test/tools/apt/Compile/goldenWarn.txt - test/tools/apt/Compile/servicesRound1 - test/tools/apt/Compile/servicesRound2 - test/tools/apt/Compile/servicesRound3 - test/tools/apt/Compile/servicesRound4 - test/tools/apt/Compile/servicesStaticApf - test/tools/apt/Compile/src/AhOneClass.java - test/tools/apt/Compile/src/AndAhTwoClass.java - test/tools/apt/Compile/src/Round1Class.java - test/tools/apt/Discovery/Dee.java - test/tools/apt/Discovery/Dum.java - test/tools/apt/Discovery/Empty.java - test/tools/apt/Discovery/PhantomTouch.java - test/tools/apt/Discovery/PhantomUpdate.java - test/tools/apt/Discovery/Touch.java - test/tools/apt/Discovery/discovery.sh - test/tools/apt/Discovery/servicesBadTouch - test/tools/apt/Discovery/servicesPhantomTouch - test/tools/apt/Discovery/servicesTouch - test/tools/apt/Discovery/servicesTweedle - test/tools/apt/Misc/Marked.java - test/tools/apt/Misc/Marker.java - test/tools/apt/Misc/Misc.java - test/tools/apt/Misc/misc.sh - test/tools/apt/Misc/servicesMisc - test/tools/apt/Options/Marked.java - test/tools/apt/Options/Marker.java - test/tools/apt/Options/OptionChecker.java - test/tools/apt/Options/options.sh - test/tools/apt/Options/servicesOptions - test/tools/apt/Scanners/Counter.java - test/tools/apt/Scanners/MemberOrderApf.java - test/tools/apt/Scanners/Order.java - test/tools/apt/Scanners/Scanner.java - test/tools/apt/Scanners/TestEnum.java - test/tools/apt/Scanners/VisitOrder.java - test/tools/apt/Scanners/scanner.sh - test/tools/apt/Scanners/servicesScanner - test/tools/apt/lib/Ignore.java - test/tools/apt/lib/Test.java - test/tools/apt/lib/TestProcessor.java - test/tools/apt/lib/TestProcessorFactory.java - test/tools/apt/lib/Tester.java - test/tools/apt/mirror/declaration/AnnoMirror.java - test/tools/apt/mirror/declaration/AnnoTypeDecl.java - test/tools/apt/mirror/declaration/AnnoTypeElemDecl.java - test/tools/apt/mirror/declaration/AnnoVal.java - test/tools/apt/mirror/declaration/ClassDecl.java - test/tools/apt/mirror/declaration/ConstExpr.java - test/tools/apt/mirror/declaration/ConstructorDecl.java - test/tools/apt/mirror/declaration/EnumDecl.java - test/tools/apt/mirror/declaration/FieldDecl.java - test/tools/apt/mirror/declaration/GetAnno.java - test/tools/apt/mirror/declaration/InterfaceDecl.java - test/tools/apt/mirror/declaration/MethodDecl.java - test/tools/apt/mirror/declaration/PackageDecl.java - test/tools/apt/mirror/declaration/ParameterDecl.java - test/tools/apt/mirror/declaration/pkg1/AClass.java - test/tools/apt/mirror/declaration/pkg1/AnAnnoType.java - test/tools/apt/mirror/declaration/pkg1/AnEnum.java - test/tools/apt/mirror/declaration/pkg1/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/package-info.java - test/tools/apt/mirror/declaration/pkg1/pkg2/AnInterface.java - test/tools/apt/mirror/declaration/pkg1/pkg2/package.html - test/tools/apt/mirror/type/AnnoTyp.java - test/tools/apt/mirror/type/ArrayTyp.java - test/tools/apt/mirror/type/ClassTyp.java - test/tools/apt/mirror/type/EnumTyp.java - test/tools/apt/mirror/type/InterfaceTyp.java - test/tools/apt/mirror/type/PrimitiveTyp.java - test/tools/apt/mirror/type/TypeVar.java - test/tools/apt/mirror/type/WildcardTyp.java - test/tools/apt/mirror/util/Overrides.java - test/tools/apt/mirror/util/TypeCreation.java From david.bosschaert at gmail.com Thu Feb 23 14:55:16 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Thu, 23 Feb 2012 14:55:16 +0000 Subject: JDK 8 Linking error on Fedora 16 Message-ID: Hi all, This is probably a bit of a n00b question. However someone here might know the answer to this. When I try to build JDK 8 on Fedora 16 I'm getting the link error below. The environment variables I have set are: ALLOW_DOWNLOADS=true ALT_BOOTDIR=/usr/lib/jvm/java-1.7.0-openjdk LANG=C BTW I do have the latest libstdc++ installed: $ sudo yum install libstdc++ Loaded plugins: langpacks, presto, refresh-packagekit Setting up Install Process Package libstdc++-4.6.2-1.fc16.i686 already installed and latest version Nothing to do Anyone know how to fix this? Thanks, David Linking vm... /usr/bin/ld: cannot find -lstdc++ collect2: ld returned 1 exit status ln: accessing `libjvm.so.1': Too many levels of symbolic links /usr/bin/chcon: failed to get security context of `libjvm.so': Too many levels of symbolic links ERROR: Cannot chcon libjvm.so /usr/bin/objcopy --only-keep-debug libjvm.so libjvm.debuginfo /usr/bin/objcopy: Warning: could not locate 'libjvm.so'. reason: Too many levels of symbolic links make[6]: *** [libjvm.so] Error 1 From aph at redhat.com Thu Feb 23 15:59:28 2012 From: aph at redhat.com (Andrew Haley) Date: Thu, 23 Feb 2012 15:59:28 +0000 Subject: JDK 8 Linking error on Fedora 16 In-Reply-To: References: Message-ID: <4F466260.3020509@redhat.com> On 02/23/2012 02:55 PM, David Bosschaert wrote: > Hi all, > > This is probably a bit of a n00b question. However someone here might > know the answer to this. > When I try to build JDK 8 on Fedora 16 I'm getting the link error below. > The environment variables I have set are: > ALLOW_DOWNLOADS=true > ALT_BOOTDIR=/usr/lib/jvm/java-1.7.0-openjdk > LANG=C > > BTW I do have the latest libstdc++ installed: > $ sudo yum install libstdc++ > Loaded plugins: langpacks, presto, refresh-packagekit > Setting up Install Process > Package libstdc++-4.6.2-1.fc16.i686 already installed and latest version > Nothing to do > > Anyone know how to fix this? > > Thanks, > > David This happens when the build has failed for some other reason. Go into the product directory and delete the libjvm.so symlink and try "make hotspot" again. Andrew. From david.bosschaert at gmail.com Thu Feb 23 16:23:21 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Thu, 23 Feb 2012 16:23:21 +0000 Subject: JDK 8 Linking error on Fedora 16 In-Reply-To: <4F466260.3020509@redhat.com> References: <4F466260.3020509@redhat.com> Message-ID: On 23 February 2012 15:59, Andrew Haley wrote: > On 02/23/2012 02:55 PM, David Bosschaert wrote: >> Hi all, >> >> This is probably a bit of a n00b question. However someone here might >> know the answer to this. >> When I try to build JDK 8 on Fedora 16 I'm getting the link error below. >> The environment variables I have set are: >> ? ALLOW_DOWNLOADS=true >> ? ALT_BOOTDIR=/usr/lib/jvm/java-1.7.0-openjdk >> ? LANG=C >> >> BTW I do have the latest libstdc++ installed: >> ? $ sudo yum install libstdc++ >> ? Loaded plugins: langpacks, presto, refresh-packagekit >> ? Setting up Install Process >> ? Package libstdc++-4.6.2-1.fc16.i686 already installed and latest version >> ? Nothing to do >> >> Anyone know how to fix this? >> >> Thanks, >> >> David > > This happens when the build has failed for some other reason. ?Go into > the product directory and delete the libjvm.so symlink and try "make > hotspot" again. > > Andrew. It keeps failing. What how can I find out what the other reason for failing is? Could it be related to this message? Linking vm... /usr/bin/ld: cannot find -lstdc++ collect2: ld returned 1 exit status which is a bit odd given that I have the latest libstdc++ installed... Cheers, David From aph at redhat.com Thu Feb 23 16:26:04 2012 From: aph at redhat.com (Andrew Haley) Date: Thu, 23 Feb 2012 16:26:04 +0000 Subject: JDK 8 Linking error on Fedora 16 In-Reply-To: References: <4F466260.3020509@redhat.com> Message-ID: <4F46689C.1020701@redhat.com> On 02/23/2012 04:23 PM, David Bosschaert wrote: > Could it be related to this message? > Linking vm... > /usr/bin/ld: cannot find -lstdc++ > collect2: ld returned 1 exit status > which is a bit odd given that I have the latest libstdc++ installed... Yes, that's it. The problem is probably that it's trying to link statically with libstdc++ and you have no static version of that library. Andrew. From david.bosschaert at gmail.com Thu Feb 23 19:31:56 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Thu, 23 Feb 2012 19:31:56 +0000 Subject: JDK 8 Linking error on Fedora 16 In-Reply-To: <4F46689C.1020701@redhat.com> References: <4F466260.3020509@redhat.com> <4F46689C.1020701@redhat.com> Message-ID: On 23 February 2012 16:26, Andrew Haley wrote: > On 02/23/2012 04:23 PM, David Bosschaert wrote: >> Could it be related to this message? >> ? Linking vm... >> ? /usr/bin/ld: cannot find -lstdc++ >> ? collect2: ld returned 1 exit status >> which is a bit odd given that I have the latest libstdc++ installed... > > Yes, that's it. ?The problem is probably that it's trying to link > statically with libstdc++ and you have no static version of that > library. > > Andrew. > Turns out that I had to install the static version separately, the following did the trick: yum install libstdc++-static Thanks Andrew for this! David From david.bosschaert at gmail.com Fri Feb 24 13:12:12 2012 From: david.bosschaert at gmail.com (David Bosschaert) Date: Fri, 24 Feb 2012 13:12:12 +0000 Subject: JDK 8 Linking error on Fedora 16 In-Reply-To: References: <4F466260.3020509@redhat.com> <4F46689C.1020701@redhat.com> Message-ID: On 23 February 2012 19:31, David Bosschaert wrote: > On 23 February 2012 16:26, Andrew Haley wrote: >> On 02/23/2012 04:23 PM, David Bosschaert wrote: >>> Could it be related to this message? >>> ? Linking vm... >>> ? /usr/bin/ld: cannot find -lstdc++ >>> ? collect2: ld returned 1 exit status >>> which is a bit odd given that I have the latest libstdc++ installed... >> >> Yes, that's it. ?The problem is probably that it's trying to link >> statically with libstdc++ and you have no static version of that >> library. >> >> Andrew. >> > > Turns out that I had to install the static version separately, the > following did the trick: > ?yum install libstdc++-static > > Thanks Andrew for this! > > David I've documented all the steps to build OpenJDK 8 on Fedora 16 here: http://coderthoughts.blogspot.com/2012/02/building-project-penrose-or-openjdk-8.html Feel free to include this in the build page http://hg.openjdk.java.net/jdk8/build/raw-file/tip/README-builds.html whenever that gets brought to life. Cheers, David From ahughes at redhat.com Mon Feb 27 19:04:52 2012 From: ahughes at redhat.com (Andrew Hughes) Date: Mon, 27 Feb 2012 14:04:52 -0500 (EST) Subject: JDK 8 Linking error on Fedora 16 In-Reply-To: Message-ID: <52c21e44-4adc-42b2-bb15-112166186b8e@zmail17.collab.prod.int.phx2.redhat.com> ----- Original Message ----- > On 23 February 2012 19:31, David Bosschaert > wrote: > > On 23 February 2012 16:26, Andrew Haley wrote: > >> On 02/23/2012 04:23 PM, David Bosschaert wrote: > >>> Could it be related to this message? > >>> ? Linking vm... > >>> ? /usr/bin/ld: cannot find -lstdc++ > >>> ? collect2: ld returned 1 exit status > >>> which is a bit odd given that I have the latest libstdc++ > >>> installed... > >> > >> Yes, that's it. ?The problem is probably that it's trying to link > >> statically with libstdc++ and you have no static version of that > >> library. > >> > >> Andrew. > >> > > > > Turns out that I had to install the static version separately, the > > following did the trick: > > ?yum install libstdc++-static > > > > Thanks Andrew for this! > > > > David > > I've documented all the steps to build OpenJDK 8 on Fedora 16 here: > http://coderthoughts.blogspot.com/2012/02/building-project-penrose-or-openjdk-8.html > > Feel free to include this in the build page > http://hg.openjdk.java.net/jdk8/build/raw-file/tip/README-builds.html > whenever that gets brought to life. > Passing STATIC_CXX="false" will also work and is preferable. This is what we do in IcedTea. > Cheers, > > David > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From mike.duigou at oracle.com Tue Feb 28 00:14:29 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Mon, 27 Feb 2012 16:14:29 -0800 Subject: Review Request : 7143162 : Allow disable building of jdk demos and samples Message-ID: Hello all; WEBREV @ http://cr.openjdk.java.net/~mduigou/7143162/1/webrev/ An updated version of my previous webrev. I'm reposting it because this version includes a previously missing bit from the top level sanity makefile that produce warning notices when demos and samples are turned off similar to the NO_DOCS javadoc warning. Also includes a correction in Release.gmk. Overall this is fairly simple patch for review. It allows developers to shut off building of the jdk demos and samples. Disabling these builds has a very positive impact upon build turnaround for incremental builds. Export NO_DEMOS and/or NO_SAMPLES in your shell before running make and demos and/or samples will be skipped. The default behaviour remains unchanged. Thanks, Mike From kelly.ohair at oracle.com Tue Feb 28 01:53:57 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 27 Feb 2012 17:53:57 -0800 Subject: Review Request : 7143162 : Allow disable building of jdk demos and samples In-Reply-To: References: Message-ID: Looks fine to me. -kto On Feb 27, 2012, at 4:14 PM, Mike Duigou wrote: > Hello all; > > WEBREV @ http://cr.openjdk.java.net/~mduigou/7143162/1/webrev/ > > An updated version of my previous webrev. I'm reposting it because this version includes a previously missing bit from the top level sanity makefile that produce warning notices when demos and samples are turned off similar to the NO_DOCS javadoc warning. Also includes a correction in Release.gmk. > > Overall this is fairly simple patch for review. It allows developers to shut off building of the jdk demos and samples. Disabling these builds has a very positive impact upon build turnaround for incremental builds. Export NO_DEMOS and/or NO_SAMPLES in your shell before running make and demos and/or samples will be skipped. > > The default behaviour remains unchanged. > > Thanks, > > Mike From kelly.ohair at oracle.com Wed Feb 29 18:46:20 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 29 Feb 2012 18:46:20 +0000 Subject: hg: jdk8/build: 4 new changesets Message-ID: <20120229184620.DD2B647727@hg.openjdk.java.net> Changeset: 97bb465be99d Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/97bb465be99d Added tag jdk8-b27 for changeset 1533dfab9903 ! .hgtags Changeset: 9760a2114f51 Author: asaha Date: 2012-02-14 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/9760a2114f51 Merge Changeset: d47bf204f34d Author: asaha Date: 2012-02-17 14:58 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/d47bf204f34d Merge Changeset: 6e2541d60f4e Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/6e2541d60f4e Merge From kelly.ohair at oracle.com Wed Feb 29 18:46:29 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 29 Feb 2012 18:46:29 +0000 Subject: hg: jdk8/build/corba: 5 new changesets Message-ID: <20120229184633.911F147728@hg.openjdk.java.net> Changeset: 7bf4278af030 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/7bf4278af030 Added tag jdk8-b27 for changeset 4fffe75e4edd ! .hgtags Changeset: 66c7161ee588 Author: coffeys Date: 2011-11-17 10:51 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/66c7161ee588 7110704: Issues with some method in corba Reviewed-by: mbankal ! src/share/classes/com/sun/corba/se/impl/dynamicany/DynAnyFactoryImpl.java ! src/share/classes/com/sun/corba/se/impl/dynamicany/DynAnyImpl.java ! src/share/classes/com/sun/org/omg/SendingContext/_CodeBaseImplBase.java Changeset: c4afff3939d8 Author: asaha Date: 2012-02-14 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/c4afff3939d8 Merge Changeset: 695408e22b29 Author: asaha Date: 2012-02-17 14:58 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/695408e22b29 Merge Changeset: 2082eb35d49a Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/2082eb35d49a Merge From kelly.ohair at oracle.com Wed Feb 29 18:48:47 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 29 Feb 2012 18:48:47 +0000 Subject: hg: jdk8/build/hotspot: 12 new changesets Message-ID: <20120229184914.246CD4772A@hg.openjdk.java.net> Changeset: 0ed0960af27d Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0ed0960af27d Added tag jdk8-b27 for changeset 3b24e7e01d20 ! .hgtags Changeset: 4ab89de75552 Author: amurillo Date: 2012-02-17 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4ab89de75552 7146700: new hotspot build - hs24-b01 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 86ce3208eb18 Author: dcubed Date: 2012-02-17 15:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/86ce3208eb18 7145798: System.loadLibrary does not search current working directory Summary: Append "." to java.library.path on MacOS X to ease migration from Apple's Java6 to OpenJDK7. Reviewed-by: phh, jmelvin, coleenp ! src/os/bsd/vm/os_bsd.cpp Changeset: 0368109684cb Author: sla Date: 2012-02-19 13:11 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0368109684cb 7132070: Use a mach_port_t as the OSThread thread_id rather than pthread_t on BSD/OSX Summary: Change OSThread to use mach thread_t Reviewed-by: phh, dcubed ! src/cpu/x86/vm/vm_version_x86.cpp ! src/os/bsd/vm/osThread_bsd.cpp ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp Changeset: 38fd165da001 Author: poonam Date: 2012-02-20 21:27 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/38fd165da001 7145358: SA throws ClassCastException for partially loaded ConstantPool Summary: In printValueOn() in ConstantPool.java check if the poolHolder is a valid Klass and only then print it. Reviewed-by: sla, sspitsyn Contributed-by: Krystal Mok ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java Changeset: 1a4e5feb63c4 Author: fparain Date: 2012-02-22 08:19 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1a4e5feb63c4 Merge Changeset: d9b93445a67c Author: vladidan Date: 2012-02-15 20:26 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d9b93445a67c 7129401: PPC: runtime/7100935/TestShortArraycopy.java fails Summary: pass assembler switches for PPC Reviewed-by: dholmes ! make/linux/makefiles/ppc.make Changeset: d79f8393df2b Author: bpittore Date: 2012-02-22 14:00 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d79f8393df2b Merge Changeset: 701a83c86f28 Author: jiangli Date: 2012-02-21 13:14 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/701a83c86f28 7120481: storeStore barrier in constructor with final field Summary: Issue storestore barrier before constructor return if the constructor write final field. Reviewed-by: dholmes, jrose, roland, coleenp Contributed-by: Jiangli Zhou ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_ValueMap.hpp Changeset: 398c5d0fb0ae Author: bpittore Date: 2012-02-23 21:10 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/398c5d0fb0ae Merge Changeset: 975c4105f1e2 Author: amurillo Date: 2012-02-24 18:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/975c4105f1e2 Merge Changeset: b183b0863611 Author: amurillo Date: 2012-02-24 18:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b183b0863611 Added tag hs24-b01 for changeset 975c4105f1e2 ! .hgtags From kelly.ohair at oracle.com Wed Feb 29 18:50:33 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 29 Feb 2012 18:50:33 +0000 Subject: hg: jdk8/build/jaxp: 4 new changesets Message-ID: <20120229185033.F060C4772B@hg.openjdk.java.net> Changeset: 38cc4c09b847 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/38cc4c09b847 Added tag jdk8-b27 for changeset 80c47eb83d24 ! .hgtags Changeset: 6fc515ab48c3 Author: asaha Date: 2012-02-14 10:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/6fc515ab48c3 Merge Changeset: a8e76ac83b62 Author: asaha Date: 2012-02-17 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/a8e76ac83b62 Merge Changeset: f3244c1f0486 Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/f3244c1f0486 Merge From kelly.ohair at oracle.com Wed Feb 29 18:50:41 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 29 Feb 2012 18:50:41 +0000 Subject: hg: jdk8/build/jaxws: 5 new changesets Message-ID: <20120229185041.31D144772C@hg.openjdk.java.net> Changeset: 6a2e8a833460 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/6a2e8a833460 Added tag jdk8-b27 for changeset 38c037af4127 ! .hgtags Changeset: 4289a81ba085 Author: asaha Date: 2012-02-14 10:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/4289a81ba085 Merge Changeset: 456621c5d797 Author: asaha Date: 2012-02-17 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/456621c5d797 Merge Changeset: c88e83be4b1a Author: lana Date: 2012-02-23 00:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/c88e83be4b1a Merge Changeset: 88b85470e72c Author: lana Date: 2012-02-24 18:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/88b85470e72c Merge From kelly.ohair at oracle.com Wed Feb 29 18:51:15 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 29 Feb 2012 18:51:15 +0000 Subject: hg: jdk8/build/jdk: 28 new changesets Message-ID: <20120229185601.758174772D@hg.openjdk.java.net> Changeset: 7d683ab46571 Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7d683ab46571 Added tag jdk8-b27 for changeset c68342532e2e ! .hgtags Changeset: 2152ac3e4575 Author: dl Date: 2011-10-12 16:33 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2152ac3e4575 7082299: AtomicReferenceArray should ensure that array is Object[] Reviewed-by: chegar, dholmes, alanb ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java Changeset: 23c3d1a0e150 Author: amenkov Date: 2011-10-26 14:00 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/23c3d1a0e150 7088367: JavaSound security issue (12865443) Reviewed-by: denis ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/share/classes/com/sun/media/sound/SoftMixingSourceDataLine.java + test/javax/sound/sampled/DataLine/DataLine_ArrayIndexOutOfBounds.java Changeset: 3ee041967af6 Author: smarks Date: 2011-11-11 15:22 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3ee041967af6 7110700: Enhance exception throwing mechanism in ObjectStreamClass Reviewed-by: dmeetry, hawtin ! src/share/classes/java/io/ObjectStreamClass.java ! test/java/io/Serializable/expectedStackTrace/ExpectedStackTrace.java Changeset: 18335c98ab8b Author: smarks Date: 2011-11-17 15:04 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/18335c98ab8b 7112267: clean up fix for 7110700 Reviewed-by: dmeetry ! test/java/io/Serializable/expectedStackTrace/ExpectedStackTrace.java Changeset: 4b98d2682c31 Author: okutsu Date: 2011-12-14 11:23 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4b98d2682c31 6351654: Problem with java/classes_util_i18n Reviewed-by: hawtin, coffeys ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/TimeZone.java ! src/share/classes/sun/awt/AppContext.java + src/share/classes/sun/misc/JavaAWTAccess.java ! src/share/classes/sun/misc/SharedSecrets.java Changeset: 5d7e49a3a2f9 Author: bagiras Date: 2011-12-14 14:43 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5d7e49a3a2f9 7112642: Incorrect checking for graphics rendering object Reviewed-by: art, bae ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/opengl/OGLRenderer.java ! src/share/classes/sun/java2d/pipe/BufferedContext.java ! src/windows/classes/sun/java2d/d3d/D3DRenderer.java ! src/windows/classes/sun/java2d/windows/GDIRenderer.java ! src/windows/native/sun/java2d/windows/GDIRenderer.cpp Changeset: a7cb0afadbee Author: sherman Date: 2011-12-15 14:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a7cb0afadbee 7118283: Better input parameter checking in zip file processing Summary: Fixed off-by-one bug in zip_util.c Reviewed-by: alanb ! src/share/native/java/util/zip/zip_util.c Changeset: d544965b59fe Author: bagiras Date: 2011-12-28 14:26 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d544965b59fe 7121482: some sun/java2d and sun/awt tests failed with InvalidPipeException since 1.7.0_03b02, 6u31b02 Reviewed-by: art, bae ! src/share/classes/sun/java2d/SunGraphics2D.java Changeset: 5e6f3c8646cf Author: xuelei Date: 2012-01-09 20:55 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5e6f3c8646cf 7123519: problems with certification path Summary: Also including the contribution from Dennis Gu Reviewed-by: mullan, weijun ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java + src/share/classes/sun/security/provider/certpath/UntrustedChecker.java + src/share/classes/sun/security/util/UntrustedCertificates.java ! src/share/classes/sun/security/validator/SimpleValidator.java ! src/share/classes/sun/security/validator/ValidatorException.java + test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java + test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java + test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/ComodoHacker.java Changeset: d9897e95323c Author: chegar Date: 2012-01-18 15:35 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d9897e95323c 7126960: Add property to limit number of request headers to the HTTP Server Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/ServerConfig.java Changeset: 7699f0a9c6d7 Author: asaha Date: 2012-02-20 11:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7699f0a9c6d7 Merge ! make/java/java/FILES_java.gmk ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/ServerConfig.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/validator/SimpleValidator.java Changeset: f525c1e9e12c Author: lana Date: 2012-02-23 00:14 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f525c1e9e12c Merge Changeset: 45804d661008 Author: xuelei Date: 2012-02-15 23:45 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/45804d661008 7145837: a little performance improvement on the usage of SecureRandom Reviewed-by: chegar, wetmore ! src/share/classes/sun/security/ssl/CipherSuite.java Changeset: b971b51bec01 Author: sherman Date: 2012-02-16 11:43 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b971b51bec01 6708398: Support integer overflow Summary: Added add/sub/multiply/toIntExact methods to j.l.Math and StrictMath classes Reviewed-by: emcmanus Contributed-by: roger.riggs at oracle.com ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java + test/java/lang/Math/ExactArithTests.java + test/java/lang/StrictMath/ExactArithTests.java Changeset: d38fed7d2ea7 Author: sherman Date: 2012-02-16 22:13 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d38fed7d2ea7 4153167: separate between ANSI and OEM code pages on Windows Summary: To use OEM code page for System.out&err when not redirected Reviewed-by: alanb ! src/share/classes/java/lang/System.java ! src/share/native/java/lang/System.c ! src/share/native/java/lang/java_props.h ! src/windows/native/java/lang/java_props_md.c Changeset: 24c298ef20a8 Author: forax Date: 2012-02-19 16:51 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/24c298ef20a8 7146152: File.path should be final Reviewed-by: alanb, dholmes, mduigou ! src/share/classes/java/io/File.java Changeset: de7f6d5841b6 Author: littlee Date: 2012-02-20 11:24 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/de7f6d5841b6 7146506: (fc) Add EACCES check to the return of fcntl native method Summary: Add EACCES check according to the spec of fcntl Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/FileDispatcherImpl.c Changeset: 7326971f09af Author: alanb Date: 2012-02-20 18:55 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7326971f09af 6346658: (se) Selector briefly spins when asynchronously closing a registered channel [win] Reviewed-by: chegar, coffeys ! src/share/classes/sun/nio/ch/NativeThreadSet.java ! src/windows/classes/sun/nio/ch/NativeThread.java ! src/windows/classes/sun/nio/ch/SocketDispatcher.java ! src/windows/native/sun/nio/ch/SocketDispatcher.c Changeset: 5e56d498e913 Author: alanb Date: 2012-02-20 19:33 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5e56d498e913 7147087: Remove AWT/Swing/client tests from ProblemList Reviewed-by: ohair ! test/Makefile ! test/ProblemList.txt Changeset: 0243e7c0b0fb Author: weijun Date: 2012-02-21 08:51 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0243e7c0b0fb 7144530: KeyTab.getInstance(String) no longer handles keyTabNames with "file:" prefix Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java + test/sun/security/krb5/ktab/FileKeyTab.java Changeset: b739dd7ce59c Author: weijun Date: 2012-02-21 15:11 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b739dd7ce59c 7147336: clarification on warning of keytool -printcrl Reviewed-by: xuelei ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/util/Resources.java Changeset: a4e3dde9a8a7 Author: xuelei Date: 2012-02-21 05:44 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a4e3dde9a8a7 7147407: remove never used debug code in DnsClient.java Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/dns/DnsClient.java Changeset: 6a5d6b2800f6 Author: lana Date: 2012-02-22 16:52 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6a5d6b2800f6 Merge Changeset: fcdd5a4bae0e Author: lana Date: 2012-02-23 07:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fcdd5a4bae0e Merge Changeset: ca2218135bac Author: asaha Date: 2012-02-24 17:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ca2218135bac 7148758: Resolve merge issue which caused testcase failure Reviewed-by: alanb, chegar ! src/share/classes/sun/net/httpserver/ServerConfig.java Changeset: 39dcb3264fb3 Author: lana Date: 2012-02-24 17:38 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/39dcb3264fb3 Merge Changeset: 1e1d41daaded Author: lana Date: 2012-02-24 18:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1e1d41daaded Merge From kelly.ohair at oracle.com Wed Feb 29 18:59:07 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 29 Feb 2012 18:59:07 +0000 Subject: hg: jdk8/build/langtools: 5 new changesets Message-ID: <20120229185920.5F7224772E@hg.openjdk.java.net> Changeset: 8503479162bd Author: katleman Date: 2012-02-23 12:03 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8503479162bd Added tag jdk8-b27 for changeset be456f9c64e8 ! .hgtags Changeset: 3b168225dfc0 Author: asaha Date: 2012-02-14 10:29 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3b168225dfc0 Merge - src/share/classes/com/sun/tools/javac/Launcher.java Changeset: d903497bf389 Author: asaha Date: 2012-02-17 14:59 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d903497bf389 Merge Changeset: a696a8610b2a Author: lana Date: 2012-02-23 07:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a696a8610b2a Merge Changeset: 5bed623b0c77 Author: lana Date: 2012-02-24 18:24 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/5bed623b0c77 Merge From dbhole at redhat.com Wed Feb 29 20:30:06 2012 From: dbhole at redhat.com (Deepak Bhole) Date: Wed, 29 Feb 2012 15:30:06 -0500 Subject: Patch to fix build breakage with GCC 4.7 In-Reply-To: <4F2756C9.4000304@oracle.com> References: <20120130152052.GE3179@redhat.com> <4F273C6E.30801@oracle.com> <20120131023642.GO16474@redhat.com> <4F2756C9.4000304@oracle.com> Message-ID: <20120229203004.GA32730@redhat.com> * David Holmes [2012-01-30 21:50]: > On 31/01/2012 12:36 PM, Deepak Bhole wrote: > >* David Holmes [2012-01-30 19:57]: > >>While gcc compilation on sparc is rare I'm not sure that simply > >>deleting the sparc-only option unconditionally is the right thing to > >>do. > >> > > > >I thought about that too. But I was unable to find info on OpenJDK + > >SPARC + Linux. Is that combination even supported? The README doesn't > >list it: > >http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE > > Linux-sparc is not one of Oracle's supported OpenJDK platforms. > However AFAIK there are people in the community building OpenJDK on > Linux-sparc using the Zero interpreter. I don't know if this would > affect them but it still seems to me that we should be careful not > to break other people's builds. > With FOSDEM and subsequent security errata, this got pushed to side. Sorry for the delay. I've created a new webrev which contains a special case for the Sparc family (on Linux): http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ If it is okay for push, please go ahead and push it (I don't have commit access). I will then propose it for 7u. Thanks, Deepak > David > ----- > > >The option seemed more like a relic from Solaris + SPARC config rather > >than a requirement for Linux + SPARC. > > > > >Cheers, > >Deepak > > > >>David > >> > >>On 31/01/2012 1:20 AM, Deepak Bhole wrote: > >>>Hi, > >>> > >>>JDK builds currently fail with GCC 4.7 due to its stricter option > >>>checking. > >>> > >>>GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain > >>>files in JDK supply the -mimpure-text option to GCC. This option is only > >>>valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build > >>>on Linux (I suppose . > >>> > >>>This patch removes the option: > >>>http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 > >>> > >>>1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html > >>>2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html > >>> > >>>If OK for push, please feel free to do so (I don't have commit access). > >>> > >>>Cheers, > >>>Deepak From david.holmes at oracle.com Wed Feb 29 23:28:26 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 01 Mar 2012 09:28:26 +1000 Subject: Patch to fix build breakage with GCC 4.7 In-Reply-To: <20120229203004.GA32730@redhat.com> References: <20120130152052.GE3179@redhat.com> <4F273C6E.30801@oracle.com> <20120131023642.GO16474@redhat.com> <4F2756C9.4000304@oracle.com> <20120229203004.GA32730@redhat.com> Message-ID: <4F4EB49A.8060909@oracle.com> Hi Deepak, On 1/03/2012 6:30 AM, Deepak Bhole wrote: > * David Holmes [2012-01-30 21:50]: >> On 31/01/2012 12:36 PM, Deepak Bhole wrote: >>> * David Holmes [2012-01-30 19:57]: >>>> While gcc compilation on sparc is rare I'm not sure that simply >>>> deleting the sparc-only option unconditionally is the right thing to >>>> do. >>>> >>> >>> I thought about that too. But I was unable to find info on OpenJDK + >>> SPARC + Linux. Is that combination even supported? The README doesn't >>> list it: >>> http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE >> >> Linux-sparc is not one of Oracle's supported OpenJDK platforms. >> However AFAIK there are people in the community building OpenJDK on >> Linux-sparc using the Zero interpreter. I don't know if this would >> affect them but it still seems to me that we should be careful not >> to break other people's builds. >> > > With FOSDEM and subsequent security errata, this got pushed to side. > > Sorry for the delay. I've created a new webrev which contains a special > case for the Sparc family (on Linux): > > http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ Where is ARCH_FAMILY being set? David > If it is okay for push, please go ahead and push it (I don't have commit > access). I will then propose it for 7u. > > Thanks, > Deepak > >> David >> ----- >> >>> The option seemed more like a relic from Solaris + SPARC config rather >>> than a requirement for Linux + SPARC. >> >> >> >>> Cheers, >>> Deepak >>> >>>> David >>>> >>>> On 31/01/2012 1:20 AM, Deepak Bhole wrote: >>>>> Hi, >>>>> >>>>> JDK builds currently fail with GCC 4.7 due to its stricter option >>>>> checking. >>>>> >>>>> GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain >>>>> files in JDK supply the -mimpure-text option to GCC. This option is only >>>>> valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build >>>>> on Linux (I suppose . >>>>> >>>>> This patch removes the option: >>>>> http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 >>>>> >>>>> 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html >>>>> 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html >>>>> >>>>> If OK for push, please feel free to do so (I don't have commit access). >>>>> >>>>> Cheers, >>>>> Deepak From dbhole at redhat.com Wed Feb 29 23:43:18 2012 From: dbhole at redhat.com (Deepak Bhole) Date: Wed, 29 Feb 2012 18:43:18 -0500 Subject: Patch to fix build breakage with GCC 4.7 In-Reply-To: <4F4EB49A.8060909@oracle.com> References: <20120130152052.GE3179@redhat.com> <4F273C6E.30801@oracle.com> <20120131023642.GO16474@redhat.com> <4F2756C9.4000304@oracle.com> <20120229203004.GA32730@redhat.com> <4F4EB49A.8060909@oracle.com> Message-ID: <20120229234318.GB32730@redhat.com> * David Holmes [2012-02-29 18:29]: > Hi Deepak, > > On 1/03/2012 6:30 AM, Deepak Bhole wrote: > >* David Holmes [2012-01-30 21:50]: > >>On 31/01/2012 12:36 PM, Deepak Bhole wrote: > >>>* David Holmes [2012-01-30 19:57]: > >>>>While gcc compilation on sparc is rare I'm not sure that simply > >>>>deleting the sparc-only option unconditionally is the right thing to > >>>>do. > >>>> > >>> > >>>I thought about that too. But I was unable to find info on OpenJDK + > >>>SPARC + Linux. Is that combination even supported? The README doesn't > >>>list it: > >>>http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE > >> > >>Linux-sparc is not one of Oracle's supported OpenJDK platforms. > >>However AFAIK there are people in the community building OpenJDK on > >>Linux-sparc using the Zero interpreter. I don't know if this would > >>affect them but it still seems to me that we should be careful not > >>to break other people's builds. > >> > > > >With FOSDEM and subsequent security errata, this got pushed to side. > > > >Sorry for the delay. I've created a new webrev which contains a special > >case for the Sparc family (on Linux): > > > >http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ > > Where is ARCH_FAMILY being set? > It is set in make/common/shared/Platform.gmk Deepak > David > > > >If it is okay for push, please go ahead and push it (I don't have commit > >access). I will then propose it for 7u. > > > >Thanks, > >Deepak > > > >>David > >>----- > >> > >>>The option seemed more like a relic from Solaris + SPARC config rather > >>>than a requirement for Linux + SPARC. > >> > >> > >> > >>>Cheers, > >>>Deepak > >>> > >>>>David > >>>> > >>>>On 31/01/2012 1:20 AM, Deepak Bhole wrote: > >>>>>Hi, > >>>>> > >>>>>JDK builds currently fail with GCC 4.7 due to its stricter option > >>>>>checking. > >>>>> > >>>>>GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain > >>>>>files in JDK supply the -mimpure-text option to GCC. This option is only > >>>>>valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build > >>>>>on Linux (I suppose . > >>>>> > >>>>>This patch removes the option: > >>>>>http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 > >>>>> > >>>>>1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html > >>>>>2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html > >>>>> > >>>>>If OK for push, please feel free to do so (I don't have commit access). > >>>>> > >>>>>Cheers, > >>>>>Deepak From david.holmes at oracle.com Wed Feb 29 23:47:30 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 01 Mar 2012 09:47:30 +1000 Subject: Patch to fix build breakage with GCC 4.7 In-Reply-To: <4F4EB49A.8060909@oracle.com> References: <20120130152052.GE3179@redhat.com> <4F273C6E.30801@oracle.com> <20120131023642.GO16474@redhat.com> <4F2756C9.4000304@oracle.com> <20120229203004.GA32730@redhat.com> <4F4EB49A.8060909@oracle.com> Message-ID: <4F4EB912.2070708@oracle.com> Sorry let me back up a step here. The issue with linux-sparc involved the actual build instructions in Compiler-gcc.gmk, not so much the sample makefiles for the various JVMTI demos - at least in my response. Unless someone from serviceability indicates otherwise I'd suggest just deleting -mimpure-text from those samples. Just to confuse things further, the gcc manual now lists this as a Solaris 2 option _not_ a sparc option: http://gcc.gnu.org/onlinedocs/gcc/Solaris-2-Options.html#index-mimpure_002dtext-2103 http://old.nabble.com/Correctly-document-Solaris-2-options-td29851048.html This seems to indicate the gcc folk are ignorant of linux-sparc! As we only used this option for linux builds and not Solaris builds I find this even more confusing. So at this point I will step back and let the build folk figure it out. David ----- On 1/03/2012 9:28 AM, David Holmes wrote: > Hi Deepak, > > On 1/03/2012 6:30 AM, Deepak Bhole wrote: >> * David Holmes [2012-01-30 21:50]: >>> On 31/01/2012 12:36 PM, Deepak Bhole wrote: >>>> * David Holmes [2012-01-30 19:57]: >>>>> While gcc compilation on sparc is rare I'm not sure that simply >>>>> deleting the sparc-only option unconditionally is the right thing to >>>>> do. >>>>> >>>> >>>> I thought about that too. But I was unable to find info on OpenJDK + >>>> SPARC + Linux. Is that combination even supported? The README doesn't >>>> list it: >>>> http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE >>>> >>> >>> Linux-sparc is not one of Oracle's supported OpenJDK platforms. >>> However AFAIK there are people in the community building OpenJDK on >>> Linux-sparc using the Zero interpreter. I don't know if this would >>> affect them but it still seems to me that we should be careful not >>> to break other people's builds. >>> >> >> With FOSDEM and subsequent security errata, this got pushed to side. >> >> Sorry for the delay. I've created a new webrev which contains a special >> case for the Sparc family (on Linux): >> >> http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ > > Where is ARCH_FAMILY being set? > > David > > >> If it is okay for push, please go ahead and push it (I don't have commit >> access). I will then propose it for 7u. >> >> Thanks, >> Deepak >> >>> David >>> ----- >>> >>>> The option seemed more like a relic from Solaris + SPARC config rather >>>> than a requirement for Linux + SPARC. >>> >>> >>> >>>> Cheers, >>>> Deepak >>>> >>>>> David >>>>> >>>>> On 31/01/2012 1:20 AM, Deepak Bhole wrote: >>>>>> Hi, >>>>>> >>>>>> JDK builds currently fail with GCC 4.7 due to its stricter option >>>>>> checking. >>>>>> >>>>>> GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. >>>>>> Certain >>>>>> files in JDK supply the -mimpure-text option to GCC. This option >>>>>> is only >>>>>> valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during >>>>>> build >>>>>> on Linux (I suppose . >>>>>> >>>>>> This patch removes the option: >>>>>> http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 >>>>>> >>>>>> 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html >>>>>> 2: >>>>>> http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html >>>>>> >>>>>> >>>>>> If OK for push, please feel free to do so (I don't have commit >>>>>> access). >>>>>> >>>>>> Cheers, >>>>>> Deepak From david.holmes at oracle.com Wed Feb 29 23:48:25 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 01 Mar 2012 09:48:25 +1000 Subject: Patch to fix build breakage with GCC 4.7 In-Reply-To: <20120229234318.GB32730@redhat.com> References: <20120130152052.GE3179@redhat.com> <4F273C6E.30801@oracle.com> <20120131023642.GO16474@redhat.com> <4F2756C9.4000304@oracle.com> <20120229203004.GA32730@redhat.com> <4F4EB49A.8060909@oracle.com> <20120229234318.GB32730@redhat.com> Message-ID: <4F4EB949.70303@oracle.com> On 1/03/2012 9:43 AM, Deepak Bhole wrote: > * David Holmes [2012-02-29 18:29]: >>> http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ >> >> Where is ARCH_FAMILY being set? >> > > It is set in make/common/shared/Platform.gmk But that has no connection to the sample Makefiles. David > Deepak > >> David >> >> >>> If it is okay for push, please go ahead and push it (I don't have commit >>> access). I will then propose it for 7u. >>> >>> Thanks, >>> Deepak >>> >>>> David >>>> ----- >>>> >>>>> The option seemed more like a relic from Solaris + SPARC config rather >>>>> than a requirement for Linux + SPARC. >>>> >>>> >>>> >>>>> Cheers, >>>>> Deepak >>>>> >>>>>> David >>>>>> >>>>>> On 31/01/2012 1:20 AM, Deepak Bhole wrote: >>>>>>> Hi, >>>>>>> >>>>>>> JDK builds currently fail with GCC 4.7 due to its stricter option >>>>>>> checking. >>>>>>> >>>>>>> GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain >>>>>>> files in JDK supply the -mimpure-text option to GCC. This option is only >>>>>>> valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build >>>>>>> on Linux (I suppose . >>>>>>> >>>>>>> This patch removes the option: >>>>>>> http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 >>>>>>> >>>>>>> 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html >>>>>>> 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html >>>>>>> >>>>>>> If OK for push, please feel free to do so (I don't have commit access). >>>>>>> >>>>>>> Cheers, >>>>>>> Deepak