From nils.loodin at oracle.com Mon Jun 4 09:10:02 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 4 Jun 2012 11:10:02 +0200 Subject: RFR - 7163471: Licensee source bundle failed around 7u4 Message-ID: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> http://cr.openjdk.java.net/~nloodin/71663471/webrev.00/ Simple fix, check if the directory exist or not, and if not don't build that subdirectory. Modelled the mechanic after another makefile in the jdk. -------------- next part -------------- An HTML attachment was scrubbed... URL: From erik.joelsson at oracle.com Mon Jun 4 10:01:17 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 04 Jun 2012 12:01:17 +0200 Subject: RFR - 7163471: Licensee source bundle failed around 7u4 In-Reply-To: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> References: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> Message-ID: <4FCC876D.9010605@oracle.com> In what scenario would the directory not exist when OPENJDK is not defined? /Erik On 2012-06-04 11:10, Nils Loodin wrote: > http://cr.openjdk.java.net/~nloodin/71663471/webrev.00/ > > > Simple fix, check if the directory exist or not, and if not don't > build that subdirectory. > > Modelled the mechanic after another makefile in the jdk. > > From nils.loodin at oracle.com Mon Jun 4 11:11:46 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 4 Jun 2012 13:11:46 +0200 Subject: RFR - 7163471: Licensee source bundle failed around 7u4 In-Reply-To: <4FCC876D.9010605@oracle.com> References: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> <4FCC876D.9010605@oracle.com> Message-ID: In the scenario which the bugs talk about, i.e. licensee builds. They don?t have, and don't want, a define in the makefiles. Their only mechanism is to remove certain files based on a blacklist. This is currently causing a build failure from the licensee sources. /Nisse On Jun 4, 2012, at 12:01 , Erik Joelsson wrote: > In what scenario would the directory not exist when OPENJDK is not defined? > > /Erik > > On 2012-06-04 11:10, Nils Loodin wrote: >> http://cr.openjdk.java.net/~nloodin/71663471/webrev.00/ >> >> Simple fix, check if the directory exist or not, and if not don't build that subdirectory. >> >> Modelled the mechanic after another makefile in the jdk. >> >> From erik.joelsson at oracle.com Mon Jun 4 12:07:27 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 04 Jun 2012 14:07:27 +0200 Subject: RFR - 7163471: Licensee source bundle failed around 7u4 In-Reply-To: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> References: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> Message-ID: <4FCCA4FF.7020809@oracle.com> Looks good to me. /Erik On 2012-06-04 11:10, Nils Loodin wrote: > http://cr.openjdk.java.net/~nloodin/71663471/webrev.00/ > > > Simple fix, check if the directory exist or not, and if not don't > build that subdirectory. > > Modelled the mechanic after another makefile in the jdk. > > From staffan.larsen at oracle.com Mon Jun 4 13:03:39 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 4 Jun 2012 15:03:39 +0200 Subject: RFR (S): 7165257: Adding JFR test targets In-Reply-To: References: Message-ID: <4AE10FCE-86BF-4B4A-AB82-3C600ADD9A22@oracle.com> Can someone please review this change? Thanks, /Staffan On 25 maj 2012, at 15:41, Staffan Larsen wrote: > Please review the following change to makefiles to add a target for the JFR tests. > > Webrev: http://cr.openjdk.java.net/~sla/7165257/webrev.01/ > > Thanks, > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: From erik.joelsson at oracle.com Mon Jun 4 14:15:10 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 04 Jun 2012 16:15:10 +0200 Subject: Review Request: Build-infra update In-Reply-To: <4FBD18D9.1080401@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> Message-ID: <4FCCC2EE.1050302@oracle.com> I have created a (hopefully temporary) hack to run javah manually for these 5 classes. This webrev is just against the build-infra repo. Unless anybody objects to this temporary solution, I will publish a new full webrev against the jdk8/build forest tomorrow. http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/ /Erik On 2012-05-23 19:05, Alan Bateman wrote: > On 23/05/2012 17:50, Kelly O'Hair wrote: >> Has anyone tried creating an unused native method declaration in the >> class to trigger the native header >> generation? public native void GenerateNativeHeader(); ??? Is >> that too ugly? >> >> -kto > As Jon put it, for the classes in the base module, "we are delicate > bootstrapping ground" so if you add something like "private static > native void dummy()" rather than the annotation to the classes in the > base module then it could be a solution for the short term. This means > the following sources in the webrev: > > src/share/classes/java/lang/Integer.java > src/share/classes/java/lang/Long.java > src/share/classes/java/net/SocketOptions.java > src/windows/classes/sun/nio/ch/PollArrayWrapper.java > > Also it would be good to remove it from > src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation > in the first round). > > -Alan. > From staffan.larsen at oracle.com Mon Jun 4 14:40:55 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 4 Jun 2012 16:40:55 +0200 Subject: RFR - 7163471: Licensee source bundle failed around 7u4 In-Reply-To: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> References: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> Message-ID: <61907CFB-AA56-43D7-9D76-ECEDFE510A12@oracle.com> Looks good. /Staffan On 4 jun 2012, at 11:10, Nils Loodin wrote: > http://cr.openjdk.java.net/~nloodin/71663471/webrev.00/ > > Simple fix, check if the directory exist or not, and if not don't build that subdirectory. > > Modelled the mechanic after another makefile in the jdk. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From magnus.ihse.bursie at oracle.com Mon Jun 4 15:00:13 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 04 Jun 2012 17:00:13 +0200 Subject: Bug in FDS for Solaris? In-Reply-To: <4FC506BD.9060507@oracle.com> References: <4FC48DC5.6030507@oracle.com> <4FC506BD.9060507@oracle.com> Message-ID: <4FCCCD7D.2060106@oracle.com> On 2012-05-29 19:26, Daniel D. Daugherty wrote: > Thanks for spotting this... Do you happen to already have a suggested > fix for this? We didn't have a fix (after all, we're not working with the old build system) but Jonas created one now. I'll patch a webrev shortly. /Magnus From magnus.ihse.bursie at oracle.com Mon Jun 4 15:00:27 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 04 Jun 2012 17:00:27 +0200 Subject: Reqest for Review: Fix bug in FDS on Solaris Message-ID: <4FCCCD8B.2010300@oracle.com> As previously discussed here, there is a bug basically disabling FDS on Solaris. Here is a webrev for a patch from Jonas Oreland (jonas.oreland at oracle.com; he's not on this list though). http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/ Jonas has done some reasonable amount of testing, looking at command lines and making sure they seem alright, and checking that debug information is added to output. I have reviewed it myself and find it OK. Kelly: if this get's OK in the reviews (for my part I'm satisfied if Daniel says OK), can you push it into the build forest? /Magnus From kelly.ohair at oracle.com Mon Jun 4 16:52:30 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 4 Jun 2012 09:52:30 -0700 Subject: Review Request: Build-infra update In-Reply-To: <4FCCC2EE.1050302@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FCCC2EE.1050302@oracle.com> Message-ID: <781FCCF0-55D1-4982-8AAA-77F23ED84B84@oracle.com> Are these ok? ./share/classes/sun/nio/ch/DatagramChannelImpl.java:@GenerateNativeHeader ./share/classes/sun/nio/ch/IOStatus.java:@GenerateNativeHeader ./share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java:@GenerateNativeHeader ./solaris/classes/sun/nio/ch/sctp/AssociationChange.java:@GenerateNativeHeader ./solaris/classes/sun/nio/ch/sctp/PeerAddrChange.java:@GenerateNativeHeader ./solaris/classes/sun/nio/ch/sctp/ResultContainer.java:@GenerateNativeHeader ./windows/classes/sun/nio/ch/PollArrayWrapper.java:@GenerateNativeHeader Otherwise, the change looks ok to me, although I was puzzled by the "| $(BUILD_JDK)" in 314 $(JDK_OUTPUTDIR)/classes/_the.jdk.base.headers: $(JDK_BASE_HEADER_JAVA_FILES) | $(BUILD_JDK) Never seen a | character in the dependencies before, is that a valid syntax? -kto On Jun 4, 2012, at 7:15 AM, Erik Joelsson wrote: > I have created a (hopefully temporary) hack to run javah manually for these 5 classes. This webrev is just against the build-infra repo. Unless anybody objects to this temporary solution, I will publish a new full webrev against the jdk8/build forest tomorrow. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/ > > /Erik > > On 2012-05-23 19:05, Alan Bateman wrote: >> On 23/05/2012 17:50, Kelly O'Hair wrote: >>> Has anyone tried creating an unused native method declaration in the class to trigger the native header >>> generation? public native void GenerateNativeHeader(); ??? Is that too ugly? >>> >>> -kto >> As Jon put it, for the classes in the base module, "we are delicate bootstrapping ground" so if you add something like "private static native void dummy()" rather than the annotation to the classes in the base module then it could be a solution for the short term. This means the following sources in the webrev: >> >> src/share/classes/java/lang/Integer.java >> src/share/classes/java/lang/Long.java >> src/share/classes/java/net/SocketOptions.java >> src/windows/classes/sun/nio/ch/PollArrayWrapper.java >> >> Also it would be good to remove it from src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in the first round). >> >> -Alan. >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From kelly.ohair at oracle.com Mon Jun 4 18:55:56 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 4 Jun 2012 11:55:56 -0700 Subject: Review Request: Build-infra update In-Reply-To: <781FCCF0-55D1-4982-8AAA-77F23ED84B84@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FCCC2EE.1050302@oracle.com> <781FCCF0-55D1-4982-8AAA-77F23ED84B84@oracle.com> Message-ID: On Jun 4, 2012, at 9:52 AM, Kelly O'Hair wrote: > although I was puzzled by the "| $(BUILD_JDK)" in > 314 $(JDK_OUTPUTDIR)/classes/_the.jdk.base.headers: $(JDK_BASE_HEADER_JAVA_FILES) | $(BUILD_JDK) > Never seen a | character in the dependencies before, is that a valid syntax? > > -kto Never mind about the |, learn something new everyday. This was new to GNU make 3.80, and I wasn't aware of it until now. http://www.gnu.org/software/make/manual/make.html#Prerequisite-Types -kto -------------- next part -------------- An HTML attachment was scrubbed... URL: From fredrik.ohrstrom at oracle.com Mon Jun 4 19:11:40 2012 From: fredrik.ohrstrom at oracle.com (=?iso-8859-1?Q?Fredrik_=D6hrstr=F6m?=) Date: Mon, 4 Jun 2012 21:11:40 +0200 Subject: Review Request: Build-infra update In-Reply-To: <4FCCC2EE.1050302@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FCCC2EE.1050302@oracle.com> Message-ID: Nice! Just fix the spelling of "annotaion". //Fredrik 4 jun 2012 kl. 16:15 skrev Erik Joelsson: > I have created a (hopefully temporary) hack to run javah manually for these 5 classes. This webrev is just against the build-infra repo. Unless anybody objects to this temporary solution, I will publish a new full webrev against the jdk8/build forest tomorrow. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/ > > /Erik > > On 2012-05-23 19:05, Alan Bateman wrote: >> On 23/05/2012 17:50, Kelly O'Hair wrote: >>> Has anyone tried creating an unused native method declaration in the class to trigger the native header >>> generation? public native void GenerateNativeHeader(); ??? Is that too ugly? >>> >>> -kto >> As Jon put it, for the classes in the base module, "we are delicate bootstrapping ground" so if you add something like "private static native void dummy()" rather than the annotation to the classes in the base module then it could be a solution for the short term. This means the following sources in the webrev: >> >> src/share/classes/java/lang/Integer.java >> src/share/classes/java/lang/Long.java >> src/share/classes/java/net/SocketOptions.java >> src/windows/classes/sun/nio/ch/PollArrayWrapper.java >> >> Also it would be good to remove it from src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in the first round). >> >> -Alan. >> From tim.bell at oracle.com Mon Jun 4 20:22:22 2012 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 04 Jun 2012 13:22:22 -0700 Subject: Review Request: Build-infra update In-Reply-To: <4FCCC2EE.1050302@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FCCC2EE.1050302@oracle.com> Message-ID: <4FCD18FE.1080502@oracle.com> Looks good to me. Line 314 of CompileJavaClasses.gmk is an 'order-only' prerequisite - I had to look it up as I have only seen it used one other time. http://www.gnu.org/software/make/manual/make.html#Prerequisite-Types Tim On 06/04/12 07:15, Erik Joelsson wrote: > I have created a (hopefully temporary) hack to run javah manually for > these 5 classes. This webrev is just against the build-infra repo. > Unless anybody objects to this temporary solution, I will publish a > new full webrev against the jdk8/build forest tomorrow. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/ > > > /Erik > > On 2012-05-23 19:05, Alan Bateman wrote: >> On 23/05/2012 17:50, Kelly O'Hair wrote: >>> Has anyone tried creating an unused native method declaration in the >>> class to trigger the native header >>> generation? public native void GenerateNativeHeader(); ??? Is >>> that too ugly? >>> >>> -kto >> As Jon put it, for the classes in the base module, "we are delicate >> bootstrapping ground" so if you add something like "private static >> native void dummy()" rather than the annotation to the classes in the >> base module then it could be a solution for the short term. This >> means the following sources in the webrev: >> >> src/share/classes/java/lang/Integer.java >> src/share/classes/java/lang/Long.java >> src/share/classes/java/net/SocketOptions.java >> src/windows/classes/sun/nio/ch/PollArrayWrapper.java >> >> Also it would be good to remove it from >> src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation >> in the first round). >> >> -Alan. >> From kelly.ohair at oracle.com Mon Jun 4 20:36:12 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 4 Jun 2012 13:36:12 -0700 Subject: RFR (S): 7165257: Adding JFR test targets In-Reply-To: <4AE10FCE-86BF-4B4A-AB82-3C600ADD9A22@oracle.com> References: <4AE10FCE-86BF-4B4A-AB82-3C600ADD9A22@oracle.com> Message-ID: <520FC58C-4156-430F-BA7E-9D8BE8AB80D0@oracle.com> You can add me as the reviewer. But I think you need to send an email out to core-libs-dev at openjdk.java.net warning them that you have added the jfr tests to testset=core. So that if they run into jfr failures, they know who to contact. -kto On Jun 4, 2012, at 6:03 AM, Staffan Larsen wrote: > Can someone please review this change? > > Thanks, > /Staffan > > On 25 maj 2012, at 15:41, Staffan Larsen wrote: > >> Please review the following change to makefiles to add a target for the JFR tests. >> >> Webrev: http://cr.openjdk.java.net/~sla/7165257/webrev.01/ >> >> Thanks, >> /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: From magnus.ihse.bursie at oracle.com Mon Jun 4 23:27:10 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 5 Jun 2012 01:27:10 +0200 Subject: Review Request: Build-infra update In-Reply-To: <4FCD18FE.1080502@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FCCC2EE.1050302@oracle.com> <4FCD18FE.1080502@oracle.com> Message-ID: <13486963-9330-4DD1-ABBF-18332CDA2063@oracle.com> I had to ask Erik about it, too. :-) Since we are now a small crowd not knowing about it, I think that warrants a comment describing the purpose. Erik, can you fix that? /Magnus 4 jun 2012 kl. 22:22 skrev Tim Bell : > Looks good to me. Line 314 of CompileJavaClasses.gmk is an 'order-only' prerequisite - I had to look it up as I have only seen it used one other time. > > http://www.gnu.org/software/make/manual/make.html#Prerequisite-Types > > Tim > > > > > On 06/04/12 07:15, Erik Joelsson wrote: >> I have created a (hopefully temporary) hack to run javah manually for these 5 classes. This webrev is just against the build-infra repo. Unless anybody objects to this temporary solution, I will publish a new full webrev against the jdk8/build forest tomorrow. >> >> http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/ >> >> /Erik >> >> On 2012-05-23 19:05, Alan Bateman wrote: >>> On 23/05/2012 17:50, Kelly O'Hair wrote: >>>> Has anyone tried creating an unused native method declaration in the class to trigger the native header >>>> generation? public native void GenerateNativeHeader(); ??? Is that too ugly? >>>> >>>> -kto >>> As Jon put it, for the classes in the base module, "we are delicate bootstrapping ground" so if you add something like "private static native void dummy()" rather than the annotation to the classes in the base module then it could be a solution for the short term. This means the following sources in the webrev: >>> >>> src/share/classes/java/lang/Integer.java >>> src/share/classes/java/lang/Long.java >>> src/share/classes/java/net/SocketOptions.java >>> src/windows/classes/sun/nio/ch/PollArrayWrapper.java >>> >>> Also it would be good to remove it from src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in the first round). >>> >>> -Alan. >>> > From misha.bykov at oracle.com Mon Jun 4 23:53:58 2012 From: misha.bykov at oracle.com (Misha Bykov) Date: Mon, 04 Jun 2012 16:53:58 -0700 Subject: 2nd try: please, review the script for JDK license headers verification Message-ID: <4FCD4A96.1050903@oracle.com> Please, review the webrev is located at: http://cr.openjdk.java.net/~mbykov/lic_check/webrev.00/ INTRO It's recommended for a developer, when he introduced or modified source code files, to check whether a license header is precisely correct for every modified file. The new script allows a JDK developer to check if the specified license header for a given file (or a set of files) matches the right header template. NAME lic_check.sh - JDK source code legal headers conformance verification SYNOPSIS lic_check.sh [-gpl] or [-gplcp] or [-bsd] file(s) DESCRIPTION The script for OpenJDK distribution to verify legal notices in a particular source file or a set of files. The script must be located in the directory: $ROOT/make/scripts It uses templates from: $ROOT/make/templates The successful output example: ### ### Checking copyright notice in the file: filename.java ### No differences encountered SUCCESS: The license header for filename.java has been verified. The unsuccessful output example if Oracle copyright string is missing or copyright years are not correct : ### ### Checking copyright notice in the file: filename.java ### ERROR: Copyright string is not correct or missing in filename.java. If the copyright string is correct, but the license header is not correct, the script should produce the "diff" output between a template in $ROOT/make/templates and the license header from the given file. HOW TO TEST 1. Place the script into $ROOT/make/scripts in JDK8 source repository (otherwise it will not find $ROOT/make/templates and produce an error). 2. cd to the directory with the files to check license headers 3. $ROOT/make/scripts/lic_check.sh [-gpl] or [-gplcp] or [-bsd] filename(s) SUCCESS EXAMPLE % ./lic_check.sh -gpl update_copyright_year.sh ### Checking copyright notice in the file: update_copyright_year.sh ### No differences encountered SUCCESS: The license header for jdk8/make/scripts/update_copyright_year.sh has been verified. ### FAILURE EXAMPLE % ./lic_check.sh -gpl hgforest.sh ### Checking copyright notice in the file: hgforest.sh ### *** /tmp/source_file.9122 Mon Jun 4 17:44:11 2012 --- jdk8/make/scripts/./../templates/gpl-header Wed Apr 11 08:53:09 2012 *************** *** 1,7 **** Copyright (c) %YEARS% Oracle and/or its affiliates. All rights reserved. DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. ! This code is free software; you can redistribute it and/or modify itX under the terms of the GNU General Public License version 2 only, as published by the Free Software Foundation. --- 1,7 ---- Copyright (c) %YEARS% Oracle and/or its affiliates. All rights reserved. DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. ! This code is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License version 2 only, as published by the Free Software Foundation. ERROR: License header is not correct in /java/jle_build/headers/jdk8/make/scripts/hgforest.sh See diffs above. ### NEXT STEPS In the future, this script will be used by special scripts to allow headers verification in the whole OpenJDK source code base. From david.holmes at oracle.com Tue Jun 5 00:44:56 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 05 Jun 2012 10:44:56 +1000 Subject: Reqest for Review: Fix bug in FDS on Solaris In-Reply-To: <4FCCCD8B.2010300@oracle.com> References: <4FCCCD8B.2010300@oracle.com> Message-ID: <4FCD5688.7000205@oracle.com> Hi Magnus, On 5/06/2012 1:00 AM, Magnus Ihse Bursie wrote: > As previously discussed here, there is a bug basically disabling FDS on > Solaris. > > Here is a webrev for a patch from Jonas Oreland > (jonas.oreland at oracle.com; he's not on this list though). > > http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/ > > Jonas has done some reasonable amount of testing, looking at command > lines and making sure they seem alright, and checking that debug > information is added to output. This stuff gives me a headache. The changes themselves seem to be okay. Though in working through this I am left perplexed as, as far as I can see, the variables CFLAGS_DBG and CXXFLAGS_DBG never end up getting used anywhere ??? I also can't convince myself if things are correct if TCOV_BUILD is defined (whatever that is!) because it disable -g but then FDS will set -xs. That said maybe those debug flags never get used anyway. David ----- > I have reviewed it myself and find it OK. > > Kelly: if this get's OK in the reviews (for my part I'm satisfied if > Daniel says OK), can you push it into the build forest? > > /Magnus From jonathan.gibbons at oracle.com Tue Jun 5 00:48:34 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 04 Jun 2012 17:48:34 -0700 Subject: 2nd try: please, review the script for JDK license headers verification In-Reply-To: <4FCD4A96.1050903@oracle.com> References: <4FCD4A96.1050903@oracle.com> Message-ID: <4FCD5762.9050609@oracle.com> Misha, "It would be nice" if you could infer the default license type from the type and/or location of file. "It would be nice" if it could default the set of files to the set of recently modified files, such as determined by "hg status". -- Jon On 06/04/2012 04:53 PM, Misha Bykov wrote: > > Please, review the webrev is located at: > > http://cr.openjdk.java.net/~mbykov/lic_check/webrev.00/ > > INTRO > > It's recommended for a developer, when he introduced or modified > source code files, to check whether a license header is precisely > correct for every modified file. > > The new script allows a JDK developer to check if the specified > license header for a given file (or a set of files) matches the right > header template. > > NAME > > lic_check.sh - JDK source code legal headers conformance verification > > SYNOPSIS > > lic_check.sh [-gpl] or [-gplcp] or [-bsd] file(s) > > DESCRIPTION > > The script for OpenJDK distribution to verify legal notices in a > particular source file or a set of files. > > The script must be located in the directory: > > $ROOT/make/scripts > > It uses templates from: > > $ROOT/make/templates > > The successful output example: > > ### > ### Checking copyright notice in the file: filename.java > ### > No differences encountered > SUCCESS: The license header for filename.java has been verified. > > The unsuccessful output example if Oracle copyright string is missing > or copyright years are not correct : > > ### > ### Checking copyright notice in the file: filename.java > ### > ERROR: Copyright string is not correct or missing in filename.java. > > If the copyright string is correct, but the license header is not > correct, the script should produce the > "diff" output between a template in $ROOT/make/templates and the > license header from the given file. > > HOW TO TEST > > 1. Place the script into $ROOT/make/scripts in JDK8 source repository > (otherwise it will not find $ROOT/make/templates and produce an error). > 2. cd to the directory with the files to check license headers > 3. $ROOT/make/scripts/lic_check.sh [-gpl] or [-gplcp] or [-bsd] > filename(s) > > SUCCESS EXAMPLE > > % ./lic_check.sh -gpl update_copyright_year.sh > ### Checking copyright notice in the file: update_copyright_year.sh > ### > No differences encountered > SUCCESS: The license header for > jdk8/make/scripts/update_copyright_year.sh has been verified. > ### > > FAILURE EXAMPLE > > % ./lic_check.sh -gpl hgforest.sh > ### Checking copyright notice in the file: hgforest.sh > ### > *** /tmp/source_file.9122 Mon Jun 4 17:44:11 2012 > --- jdk8/make/scripts/./../templates/gpl-header Wed Apr 11 08:53:09 2012 > *************** > *** 1,7 **** > Copyright (c) %YEARS% Oracle and/or its affiliates. All rights reserved. > DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > > ! This code is free software; you can redistribute it and/or modify itX > under the terms of the GNU General Public License version 2 only, as > published by the Free Software Foundation. > > --- 1,7 ---- > Copyright (c) %YEARS% Oracle and/or its affiliates. All rights reserved. > DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > > ! This code is free software; you can redistribute it and/or modify it > under the terms of the GNU General Public License version 2 only, as > published by the Free Software Foundation. > > ERROR: License header is not correct in > /java/jle_build/headers/jdk8/make/scripts/hgforest.sh > See diffs above. > ### > > > NEXT STEPS > > In the future, this script will be used by special scripts to allow > headers verification in the whole OpenJDK source code base. > From kelly.ohair at oracle.com Tue Jun 5 01:19:25 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 4 Jun 2012 18:19:25 -0700 Subject: Reqest for Review: Fix bug in FDS on Solaris In-Reply-To: <4FCD5688.7000205@oracle.com> References: <4FCCCD8B.2010300@oracle.com> <4FCD5688.7000205@oracle.com> Message-ID: On Jun 4, 2012, at 5:44 PM, David Holmes wrote: > Hi Magnus, > > On 5/06/2012 1:00 AM, Magnus Ihse Bursie wrote: >> As previously discussed here, there is a bug basically disabling FDS on >> Solaris. >> >> Here is a webrev for a patch from Jonas Oreland >> (jonas.oreland at oracle.com; he's not on this list though). >> >> http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/ >> >> Jonas has done some reasonable amount of testing, looking at command >> lines and making sure they seem alright, and checking that debug >> information is added to output. > > This stuff gives me a headache. The changes themselves seem to be okay. Though in working through this I am left perplexed as, as far as I can see, the variables CFLAGS_DBG and CXXFLAGS_DBG never end up getting used anywhere ??? They are, somehow via a $(CFLAGS_$(VARIANT))/BYFILE it's complicated, overly complicated. :^( > > I also can't convince myself if things are correct if TCOV_BUILD is defined (whatever that is!) because it disable -g but then FDS will set -xs. That said maybe those debug flags never get used anyway. TCOV_BUILD only applied to debug builds as I recall. It was like a debug build (no opt) but with no debug symbols either. -kto > > David > ----- > >> I have reviewed it myself and find it OK. >> >> Kelly: if this get's OK in the reviews (for my part I'm satisfied if >> Daniel says OK), can you push it into the build forest? >> >> /Magnus From kelly.ohair at oracle.com Tue Jun 5 01:32:57 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 4 Jun 2012 18:32:57 -0700 Subject: Reqest for Review: Fix bug in FDS on Solaris In-Reply-To: <4FCCCD8B.2010300@oracle.com> References: <4FCCCD8B.2010300@oracle.com> Message-ID: I'm waiting on Dan, and I'm doing a dryrun through JPRT. Was there a CR on this? And should I really be integrating this FDS change, or should Dan? -kto On Jun 4, 2012, at 8:00 AM, Magnus Ihse Bursie wrote: > As previously discussed here, there is a bug basically disabling FDS on Solaris. > > Here is a webrev for a patch from Jonas Oreland (jonas.oreland at oracle.com; he's not on this list though). > > http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/ > > Jonas has done some reasonable amount of testing, looking at command lines and making sure they seem alright, and checking that debug information is added to output. > > I have reviewed it myself and find it OK. > > Kelly: if this get's OK in the reviews (for my part I'm satisfied if Daniel says OK), can you push it into the build forest? > > /Magnus From joe.darcy at oracle.com Tue Jun 5 02:53:28 2012 From: joe.darcy at oracle.com (Joe Darcy) Date: Mon, 04 Jun 2012 19:53:28 -0700 Subject: 2nd try: please, review the script for JDK license headers verification In-Reply-To: <4FCD5762.9050609@oracle.com> References: <4FCD4A96.1050903@oracle.com> <4FCD5762.9050609@oracle.com> Message-ID: <4FCD74A8.3070301@oracle.com> Hello, I've suggested to Misha in the past a design where a basic and simple lic_check.sh script would live in the root repository and then each child repo (jdk, langtools, hotspot, etc.) would have a repo-specific license checking script that would encode all the expected values and per-repo rules. As a simple example, for langtools a first approximation of the expected license rules would be # GPL with ClassPath exception expected on normal sources... ../make/scripts/lic_check.sh -gplcp `find src "*.java"` # but GPL without ClassPath expected expected on tests ../make/scripts/lic_check.sh -gpl `find tests "*.java" (The full check of langtools would have to account for various exceptions, such as the tests that need to have /nodynamiccopyright/, etc.) -Joe On 6/4/2012 5:48 PM, Jonathan Gibbons wrote: > Misha, > > "It would be nice" if you could infer the default license type from > the type and/or location of file. > > "It would be nice" if it could default the set of files to the set of > recently modified files, such as determined by "hg status". > > -- Jon > > On 06/04/2012 04:53 PM, Misha Bykov wrote: >> >> Please, review the webrev is located at: >> >> http://cr.openjdk.java.net/~mbykov/lic_check/webrev.00/ >> >> INTRO >> >> It's recommended for a developer, when he introduced or modified >> source code files, to check whether a license header is precisely >> correct for every modified file. >> >> The new script allows a JDK developer to check if the specified >> license header for a given file (or a set of files) matches the right >> header template. >> >> NAME >> >> lic_check.sh - JDK source code legal headers conformance verification >> >> SYNOPSIS >> >> lic_check.sh [-gpl] or [-gplcp] or [-bsd] file(s) >> >> DESCRIPTION >> >> The script for OpenJDK distribution to verify legal notices in a >> particular source file or a set of files. >> >> The script must be located in the directory: >> >> $ROOT/make/scripts >> >> It uses templates from: >> >> $ROOT/make/templates >> >> The successful output example: >> >> ### >> ### Checking copyright notice in the file: filename.java >> ### >> No differences encountered >> SUCCESS: The license header for filename.java has been verified. >> >> The unsuccessful output example if Oracle copyright string is missing >> or copyright years are not correct : >> >> ### >> ### Checking copyright notice in the file: filename.java >> ### >> ERROR: Copyright string is not correct or missing in filename.java. >> >> If the copyright string is correct, but the license header is not >> correct, the script should produce the >> "diff" output between a template in $ROOT/make/templates and the >> license header from the given file. >> >> HOW TO TEST >> >> 1. Place the script into $ROOT/make/scripts in JDK8 source repository >> (otherwise it will not find $ROOT/make/templates and produce an error). >> 2. cd to the directory with the files to check license headers >> 3. $ROOT/make/scripts/lic_check.sh [-gpl] or [-gplcp] or [-bsd] >> filename(s) >> >> SUCCESS EXAMPLE >> >> % ./lic_check.sh -gpl update_copyright_year.sh >> ### Checking copyright notice in the file: update_copyright_year.sh >> ### >> No differences encountered >> SUCCESS: The license header for >> jdk8/make/scripts/update_copyright_year.sh has been verified. >> ### >> >> FAILURE EXAMPLE >> >> % ./lic_check.sh -gpl hgforest.sh >> ### Checking copyright notice in the file: hgforest.sh >> ### >> *** /tmp/source_file.9122 Mon Jun 4 17:44:11 2012 >> --- jdk8/make/scripts/./../templates/gpl-header Wed Apr 11 08:53:09 2012 >> *************** >> *** 1,7 **** >> Copyright (c) %YEARS% Oracle and/or its affiliates. All rights >> reserved. >> DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> >> ! This code is free software; you can redistribute it and/or modify itX >> under the terms of the GNU General Public License version 2 only, as >> published by the Free Software Foundation. >> >> --- 1,7 ---- >> Copyright (c) %YEARS% Oracle and/or its affiliates. All rights >> reserved. >> DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> >> ! This code is free software; you can redistribute it and/or modify it >> under the terms of the GNU General Public License version 2 only, as >> published by the Free Software Foundation. >> >> ERROR: License header is not correct in >> /java/jle_build/headers/jdk8/make/scripts/hgforest.sh >> See diffs above. >> ### >> >> >> NEXT STEPS >> >> In the future, this script will be used by special scripts to allow >> headers verification in the whole OpenJDK source code base. >> > From magnus.ihse.bursie at oracle.com Tue Jun 5 08:10:16 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 05 Jun 2012 10:10:16 +0200 Subject: Reqest for Review: Fix bug in FDS on Solaris In-Reply-To: References: <4FCCCD8B.2010300@oracle.com> Message-ID: <4FCDBEE8.1030107@oracle.com> On 2012-06-05 03:32, Kelly O'Hair wrote: > I'm waiting on Dan, and I'm doing a dryrun through JPRT. > > Was there a CR on this? No, sorry. > And should I really be integrating this FDS change, or should Dan? I don't know. I don't have any opinion on that. If it comes into the build forest directly we'll get it a bit faster, but I'm not sure it matters. /Magnus From Alan.Bateman at oracle.com Tue Jun 5 10:44:47 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 05 Jun 2012 11:44:47 +0100 Subject: Review Request: Build-infra update In-Reply-To: <4FCCC2EE.1050302@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FCCC2EE.1050302@oracle.com> Message-ID: <4FCDE31F.9070209@oracle.com> On 04/06/2012 15:15, Erik Joelsson wrote: > I have created a (hopefully temporary) hack to run javah manually for > these 5 classes. This webrev is just against the build-infra repo. > Unless anybody objects to this temporary solution, I will publish a > new full webrev against the jdk8/build forest tomorrow. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/ > > > /Erik Thanks, I'm okay with this. -Alan From Alan.Bateman at oracle.com Tue Jun 5 10:47:19 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 05 Jun 2012 11:47:19 +0100 Subject: Review Request: Build-infra update In-Reply-To: <781FCCF0-55D1-4982-8AAA-77F23ED84B84@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FCCC2EE.1050302@oracle.com> <781FCCF0-55D1-4982-8AAA-77F23ED84B84@oracle.com> Message-ID: <4FCDE3B7.3050508@oracle.com> On 04/06/2012 17:52, Kelly O'Hair wrote: > > ./share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java:@GenerateNativeHeader > ./solaris/classes/sun/nio/ch/sctp/AssociationChange.java:@GenerateNativeHeader > ./solaris/classes/sun/nio/ch/sctp/PeerAddrChange.java:@GenerateNativeHeader > ./solaris/classes/sun/nio/ch/sctp/ResultContainer.java:@GenerateNativeHeader > These four are SCTP (likely to be a separate module) so they aren't really a concern at the moment. -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.holmes at oracle.com Tue Jun 5 10:52:44 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 05 Jun 2012 20:52:44 +1000 Subject: RFR - 7163471: Licensee source bundle failed around 7u4 In-Reply-To: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> References: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> Message-ID: <4FCDE4FC.3020702@oracle.com> Hi Nils, On 4/06/2012 7:10 PM, Nils Loodin wrote: > http://cr.openjdk.java.net/~nloodin/71663471/webrev.00/ > > Simple fix, check if the directory exist or not, and if not don't build > that subdirectory. > > Modelled the mechanic after another makefile in the jdk. Seems okay. One minor nit: JFR_SRCDIRS_EXIST = $(shell \ should be JFR_SRCDIRS_EXIST := $(shell \ so it is only evaluated once (which it would be in this case anyway, but as a general rule ...) David From nils.loodin at oracle.com Tue Jun 5 11:42:07 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Tue, 5 Jun 2012 13:42:07 +0200 Subject: RFR - 7163471: Licensee source bundle failed around 7u4 In-Reply-To: <4FCDE4FC.3020702@oracle.com> References: <34D319B2-52E9-4EB8-8858-96BA858F4979@oracle.com> <4FCDE4FC.3020702@oracle.com> Message-ID: <94FB7873-7EC6-45A8-BCDD-8613531C0DAD@oracle.com> You're right. I'll fix and then push. Thanks a lot David! Regards, Nils Loodin On Jun 5, 2012, at 12:52 , David Holmes wrote: > Hi Nils, > > On 4/06/2012 7:10 PM, Nils Loodin wrote: >> http://cr.openjdk.java.net/~nloodin/71663471/webrev.00/ >> >> Simple fix, check if the directory exist or not, and if not don't build >> that subdirectory. >> >> Modelled the mechanic after another makefile in the jdk. > > Seems okay. One minor nit: > > JFR_SRCDIRS_EXIST = $(shell \ > > should be > > JFR_SRCDIRS_EXIST := $(shell \ > > so it is only evaluated once (which it would be in this case anyway, but as a general rule ...) > > David From erik.joelsson at oracle.com Tue Jun 5 12:06:16 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 05 Jun 2012 14:06:16 +0200 Subject: Review Request: Build-infra update In-Reply-To: <4FCCC2EE.1050302@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FCCC2EE.1050302@oracle.com> Message-ID: <4FCDF638.8060908@oracle.com> Here is the new webrev, against latest jdk8/build. Only the jdk repo needed to be redone: http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk.2/ I added a comment explaining the usage of |. /Erik On 2012-06-04 16:15, Erik Joelsson wrote: > I have created a (hopefully temporary) hack to run javah manually for > these 5 classes. This webrev is just against the build-infra repo. > Unless anybody objects to this temporary solution, I will publish a > new full webrev against the jdk8/build forest tomorrow. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/ > > > /Erik > > On 2012-05-23 19:05, Alan Bateman wrote: >> On 23/05/2012 17:50, Kelly O'Hair wrote: >>> Has anyone tried creating an unused native method declaration in the >>> class to trigger the native header >>> generation? public native void GenerateNativeHeader(); ??? Is >>> that too ugly? >>> >>> -kto >> As Jon put it, for the classes in the base module, "we are delicate >> bootstrapping ground" so if you add something like "private static >> native void dummy()" rather than the annotation to the classes in the >> base module then it could be a solution for the short term. This >> means the following sources in the webrev: >> >> src/share/classes/java/lang/Integer.java >> src/share/classes/java/lang/Long.java >> src/share/classes/java/net/SocketOptions.java >> src/windows/classes/sun/nio/ch/PollArrayWrapper.java >> >> Also it would be good to remove it from >> src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation >> in the first round). >> >> -Alan. >> From daniel.daugherty at oracle.com Tue Jun 5 14:41:43 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 05 Jun 2012 08:41:43 -0600 Subject: Reqest for Review: Fix bug in FDS on Solaris In-Reply-To: <4FCCCD8B.2010300@oracle.com> References: <4FCCCD8B.2010300@oracle.com> Message-ID: <4FCE1AA7.5020102@oracle.com> On 6/4/12 9:00 AM, Magnus Ihse Bursie wrote: > As previously discussed here, there is a bug basically disabling FDS > on Solaris. > > Here is a webrev for a patch from Jonas Oreland > (jonas.oreland at oracle.com; he's not on this list though). > > http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/ > > Jonas has done some reasonable amount of testing, looking at command > lines and making sure they seem alright, and checking that debug > information is added to output. > > I have reviewed it myself and find it OK. > > Kelly: if this get's OK in the reviews (for my part I'm satisfied if > Daniel says OK), can you push it into the build forest? Sorry for the delay. Yesterday was my b-day so I took the day off to celebrate with my family. Change looks fine to me. Magnus, thanks for finding this issue. Jonas, thanks for providing a fix. Magnus/Kelly, this fix can either come in thru the build repo or I can push it via T&L. It will take longer to become available via T&L... Please let me know how you guys would prefer this be handled. Dan From daniel.daugherty at oracle.com Wed Jun 6 19:45:45 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 06 Jun 2012 13:45:45 -0600 Subject: Reqest for Review: Fix bug in FDS on Solaris In-Reply-To: <4FCE1AA7.5020102@oracle.com> References: <4FCCCD8B.2010300@oracle.com> <4FCE1AA7.5020102@oracle.com> Message-ID: <4FCFB369.2030300@oracle.com> On 6/5/12 8:41 AM, Daniel D. Daugherty wrote: > On 6/4/12 9:00 AM, Magnus Ihse Bursie wrote: >> As previously discussed here, there is a bug basically disabling FDS >> on Solaris. >> >> Here is a webrev for a patch from Jonas Oreland >> (jonas.oreland at oracle.com; he's not on this list though). >> >> http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/ >> >> Jonas has done some reasonable amount of testing, looking at command >> lines and making sure they seem alright, and checking that debug >> information is added to output. >> >> I have reviewed it myself and find it OK. >> >> Kelly: if this get's OK in the reviews (for my part I'm satisfied if >> Daniel says OK), can you push it into the build forest? > > Sorry for the delay. Yesterday was my b-day so I took the day off > to celebrate with my family. > > Change looks fine to me. > > Magnus, thanks for finding this issue. > > Jonas, thanks for providing a fix. > > Magnus/Kelly, this fix can either come in thru the build repo or > I can push it via T&L. It will take longer to become available > via T&L... > > Please let me know how you guys would prefer this be handled. I've imported Jonas' patch into my local T&L clone, built the bits on Solaris X86, compared the build logs for "all", "debug" and "fastdebug", and compared the sizes of the "all" .diz files with the previous build: - the '-g' and '-xs' options are showing up where expected - '-xO4' is changed to '-xO2' where expected - the .diz files are now bigger since they have more debug info in them; a combination of effects from '-g' and '-xs' I'm not on the build-dev alias, but I checked pipermail and I don't see any new posts after my last one. I also checked: http://hg.openjdk.java.net/jdk8/build/jdk and I don't see any sign of this fix already being pushed. I did a search for bugs mentioning FDS and I don't see a new one covering this issue. I'll file a new bug for the issue shortly. I see that Jonas has an OpenJDK user name so I'll list him as the author; I'll list Magnus, David H., Kelly and myself as reviewers. Have I missed anything? Dan From david.katleman at oracle.com Wed Jun 6 22:21:47 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 06 Jun 2012 22:21:47 +0000 Subject: hg: jdk8/build: Added tag jdk8-b41 for changeset 1a8c7c530f8a Message-ID: <20120606222147.9DD4D4775E@hg.openjdk.java.net> Changeset: 1ce5dc164166 Author: cl Date: 2012-06-01 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/1ce5dc164166 Added tag jdk8-b41 for changeset 1a8c7c530f8a ! .hgtags From david.katleman at oracle.com Wed Jun 6 22:21:52 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 06 Jun 2012 22:21:52 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b41 for changeset 113f0d5f0a08 Message-ID: <20120606222153.D7DC24775F@hg.openjdk.java.net> Changeset: 79cc42c9c71b Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/79cc42c9c71b Added tag jdk8-b41 for changeset 113f0d5f0a08 ! .hgtags From david.katleman at oracle.com Wed Jun 6 22:24:05 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 06 Jun 2012 22:24:05 +0000 Subject: hg: jdk8/build/hotspot: 22 new changesets Message-ID: <20120606222451.3A8D047760@hg.openjdk.java.net> Changeset: 2040997cba56 Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2040997cba56 Added tag jdk8-b41 for changeset 37add4fa0296 ! .hgtags Changeset: c80d42d78a01 Author: amurillo Date: 2012-05-25 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c80d42d78a01 7171853: new hotspot build - hs24-b13 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 960a442eae91 Author: rbackman Date: 2012-05-22 10:11 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/960a442eae91 7161732: Improve handling of thread_id in OSThread Reviewed-by: dholmes, kamg ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/linux/vm/osThread_linux.hpp ! src/os/solaris/vm/osThread_solaris.hpp ! src/os/windows/vm/osThread_windows.hpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/os_cpu/linux_sparc/vm/vmStructs_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/vmStructs_linux_x86.hpp ! src/os_cpu/solaris_sparc/vm/vmStructs_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/vmStructs_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp ! src/share/vm/runtime/osThread.hpp Changeset: df84b4a3ebcb Author: rbackman Date: 2012-05-24 13:37 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/df84b4a3ebcb 7171422: Change 7161732 breaks SA on Windows Reviewed-by: dholmes, sla ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp Changeset: 9c1709c4c80c Author: dcubed Date: 2012-05-24 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9c1709c4c80c 7165598: enable FDS on Solaris X64 when 7165593 is fixed Summary: Work around 'gobjcopy' failure on Solaris X64 by adding a temporary tool that removes the SHF_ALLOC flag from "empty" section headers. Reviewed-by: sspitsyn, acorn ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make + make/solaris/makefiles/fix_empty_sec_hdr_flags.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/vm.make + src/os/solaris/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c Changeset: fb8f9ab27c14 Author: dcubed Date: 2012-05-24 12:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fb8f9ab27c14 Merge ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/vm.make ! make/windows/makefiles/defs.make Changeset: cd3a8ab0352b Author: zgu Date: 2012-05-24 20:04 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/cd3a8ab0352b Merge Changeset: 17be2328b50b Author: zgu Date: 2012-05-26 06:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/17be2328b50b Merge Changeset: 5be76dc5304d Author: zgu Date: 2012-05-29 20:06 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5be76dc5304d Merge Changeset: 71afdabfd05b Author: jiangli Date: 2012-05-21 14:10 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/71afdabfd05b 7168280: Eliminate the generic signature index slot from field array for field without generic signature. Summary: Only allocate the generic signature index slot in the field array for field with generic signature attribute. Reviewed-by: coleenp, dlong ! agent/src/share/classes/sun/jvm/hotspot/oops/AccessFlags.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/oops/fieldInfo.hpp ! src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: 48df98e03639 Author: dholmes Date: 2012-05-23 20:09 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/48df98e03639 7170197: Update JPRT default build targets to support embedded builds Reviewed-by: jcoomes, kvn ! make/jprt.properties Changeset: 4e64a590066e Author: jprovino Date: 2012-05-26 08:49 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4e64a590066e Merge Changeset: dd45f26b4282 Author: dholmes Date: 2012-05-30 17:45 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dd45f26b4282 Merge Changeset: c92a79900986 Author: brutisso Date: 2012-05-17 21:53 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c92a79900986 7169062: CMS: Assertion failed with -XX:+ObjectAlignmentInBytes=64 Summary: Removed the assert in CompactibleFreeListSpace::check_free_list_consistency() since it was too strict. Simplified CompactibleFreeListSpace::set_cms_values() to reducde the need for asserts. Reviewed-by: jcoomes, stefank ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp Changeset: 9a344d88dc22 Author: mnunez Date: 2012-05-21 14:59 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9a344d88dc22 7168848: Add test to check that humongous object allocation path also checks the heap occupancy. Summary: Added test that checks humongous object allocation path also check the heap occupancy and initiate a marking cycle when / if needed. Reviewed-by: brutisso, jwilhelm + test/gc/7168848/HumongousAlloc.java Changeset: 1d478c993020 Author: johnc Date: 2012-05-29 10:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1d478c993020 7143858: G1: Back to back young GCs with the second GC having a minimally sized eden Summary: Before the last thread to leave a JNI critical region was able to schedule a GCLocker Initiated GC, another thread was attempting an allocation and saw that the GCLocker region was no longer active and successfully scheduled a GC. Stall allocating threads until the GCLocker Initiated GC is performed and then retry the allocation. Reviewed-by: brutisso, huntch ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 5c8bd7c16119 Author: brutisso Date: 2012-05-25 22:35 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5c8bd7c16119 7171936: LOG_G incorrectly defined in globalDefinitions.hpp Summary: Removed LOG_G and LOG_K. Moved LOG_M to where it is being used. Reviewed-by: twisti, johnc ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: c52a6a39546c Author: johnc Date: 2012-05-30 10:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c52a6a39546c 7158682: G1: Handle leak when running nsk.sysdict tests Summary: Place HandleMarks in the code that allocates handles for the pending list lock so that the handles are freed and multiple, unsuccessful, attempts to schedule a GC do not cause an OOM. Reviewed-by: brutisso ! src/share/vm/oops/instanceRefKlass.cpp Changeset: bbc900c2482a Author: brutisso Date: 2012-05-31 21:10 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bbc900c2482a 7172279: G1: Clean up TraceGen0Time and TraceGen1Time data gathering Summary: Simplify code, remove unused code, remove ExitAfterGCNum Reviewed-by: huntch, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/numberSeq.cpp ! src/share/vm/utilities/numberSeq.hpp Changeset: 7121cd2c58b5 Author: jcoomes Date: 2012-06-01 10:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7121cd2c58b5 Merge Changeset: bd568544be7f Author: amurillo Date: 2012-06-01 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bd568544be7f Merge Changeset: 55954061c6e8 Author: amurillo Date: 2012-06-01 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/55954061c6e8 Added tag hs24-b13 for changeset bd568544be7f ! .hgtags From david.katleman at oracle.com Wed Jun 6 22:26:10 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 06 Jun 2012 22:26:10 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b41 for changeset 6f5c0e17415d Message-ID: <20120606222614.A62B747761@hg.openjdk.java.net> Changeset: 39ee03c16021 Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/39ee03c16021 Added tag jdk8-b41 for changeset 6f5c0e17415d ! .hgtags From david.katleman at oracle.com Wed Jun 6 22:26:19 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 06 Jun 2012 22:26:19 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b41 for changeset f2072b164b05 Message-ID: <20120606222623.0EA5947762@hg.openjdk.java.net> Changeset: 1f20f37818a9 Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/1f20f37818a9 Added tag jdk8-b41 for changeset f2072b164b05 ! .hgtags From david.katleman at oracle.com Wed Jun 6 22:26:30 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 06 Jun 2012 22:26:30 +0000 Subject: hg: jdk8/build/jdk: Added tag jdk8-b41 for changeset 4eac56f073ea Message-ID: <20120606222654.83B3547763@hg.openjdk.java.net> Changeset: cf5c1f6fbc5b Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cf5c1f6fbc5b Added tag jdk8-b41 for changeset 4eac56f073ea ! .hgtags From david.katleman at oracle.com Wed Jun 6 22:28:18 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 06 Jun 2012 22:28:18 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b41 for changeset 179fa85aeefa Message-ID: <20120606222823.26F5747764@hg.openjdk.java.net> Changeset: 02c5a3575539 Author: cl Date: 2012-06-01 14:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/02c5a3575539 Added tag jdk8-b41 for changeset 179fa85aeefa ! .hgtags From Kelly.Ohair at oracle.com Fri Jun 8 00:47:17 2012 From: Kelly.Ohair at oracle.com (Kelly O'Hair) Date: Thu, 7 Jun 2012 17:47:17 -0700 Subject: Reqest for Review: Fix bug in FDS on Solaris In-Reply-To: <4FCFB369.2030300@oracle.com> References: <4FCCCD8B.2010300@oracle.com> <4FCE1AA7.5020102@oracle.com> <4FCFB369.2030300@oracle.com> Message-ID: On Jun 6, 2012, at 12:45 PM, Daniel D. Daugherty wrote: > On 6/5/12 8:41 AM, Daniel D. Daugherty wrote: >> On 6/4/12 9:00 AM, Magnus Ihse Bursie wrote: >>> As previously discussed here, there is a bug basically disabling FDS on Solaris. >>> >>> Here is a webrev for a patch from Jonas Oreland (jonas.oreland at oracle.com; he's not on this list though). >>> >>> http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/ >>> >>> Jonas has done some reasonable amount of testing, looking at command lines and making sure they seem alright, and checking that debug information is added to output. >>> >>> I have reviewed it myself and find it OK. >>> >>> Kelly: if this get's OK in the reviews (for my part I'm satisfied if Daniel says OK), can you push it into the build forest? >> >> Sorry for the delay. Yesterday was my b-day so I took the day off >> to celebrate with my family. >> >> Change looks fine to me. >> >> Magnus, thanks for finding this issue. >> >> Jonas, thanks for providing a fix. >> >> Magnus/Kelly, this fix can either come in thru the build repo or >> I can push it via T&L. It will take longer to become available >> via T&L... >> >> Please let me know how you guys would prefer this be handled. > > I've imported Jonas' patch into my local T&L clone, built the bits on > Solaris X86, compared the build logs for "all", "debug" and "fastdebug", > and compared the sizes of the "all" .diz files with the previous build: > > - the '-g' and '-xs' options are showing up where expected > - '-xO4' is changed to '-xO2' where expected > - the .diz files are now bigger since they have more debug info in them; > a combination of effects from '-g' and '-xs' > > I'm not on the build-dev alias, but I checked pipermail and I don't see > any new posts after my last one. I also checked: > > http://hg.openjdk.java.net/jdk8/build/jdk > > and I don't see any sign of this fix already being pushed. I did a search > for bugs mentioning FDS and I don't see a new one covering this issue. > I'll file a new bug for the issue shortly. > > I see that Jonas has an OpenJDK user name so I'll list him as the author; > I'll list Magnus, David H., Kelly and myself as reviewers. > > Have I missed anything? Nope. I'm going to let you take this on. I have some other alligators to kill right now. -kto > > Dan > From daniel.daugherty at oracle.com Fri Jun 8 00:48:35 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 07 Jun 2012 18:48:35 -0600 Subject: Reqest for Review: Fix bug in FDS on Solaris In-Reply-To: References: <4FCCCD8B.2010300@oracle.com> <4FCE1AA7.5020102@oracle.com> <4FCFB369.2030300@oracle.com> Message-ID: <4FD14BE3.7020104@oracle.com> On 6/7/12 6:47 PM, Kelly O'Hair wrote: > On Jun 6, 2012, at 12:45 PM, Daniel D. Daugherty wrote: > >> On 6/5/12 8:41 AM, Daniel D. Daugherty wrote: >>> On 6/4/12 9:00 AM, Magnus Ihse Bursie wrote: >>>> As previously discussed here, there is a bug basically disabling FDS on Solaris. >>>> >>>> Here is a webrev for a patch from Jonas Oreland (jonas.oreland at oracle.com; he's not on this list though). >>>> >>>> http://cr.openjdk.java.net/~ihse/fds-solaris-bugfix/webrev.00/ >>>> >>>> Jonas has done some reasonable amount of testing, looking at command lines and making sure they seem alright, and checking that debug information is added to output. >>>> >>>> I have reviewed it myself and find it OK. >>>> >>>> Kelly: if this get's OK in the reviews (for my part I'm satisfied if Daniel says OK), can you push it into the build forest? >>> Sorry for the delay. Yesterday was my b-day so I took the day off >>> to celebrate with my family. >>> >>> Change looks fine to me. >>> >>> Magnus, thanks for finding this issue. >>> >>> Jonas, thanks for providing a fix. >>> >>> Magnus/Kelly, this fix can either come in thru the build repo or >>> I can push it via T&L. It will take longer to become available >>> via T&L... >>> >>> Please let me know how you guys would prefer this be handled. >> I've imported Jonas' patch into my local T&L clone, built the bits on >> Solaris X86, compared the build logs for "all", "debug" and "fastdebug", >> and compared the sizes of the "all" .diz files with the previous build: >> >> - the '-g' and '-xs' options are showing up where expected >> - '-xO4' is changed to '-xO2' where expected >> - the .diz files are now bigger since they have more debug info in them; >> a combination of effects from '-g' and '-xs' >> >> I'm not on the build-dev alias, but I checked pipermail and I don't see >> any new posts after my last one. I also checked: >> >> http://hg.openjdk.java.net/jdk8/build/jdk >> >> and I don't see any sign of this fix already being pushed. I did a search >> for bugs mentioning FDS and I don't see a new one covering this issue. >> I'll file a new bug for the issue shortly. >> >> I see that Jonas has an OpenJDK user name so I'll list him as the author; >> I'll list Magnus, David H., Kelly and myself as reviewers. >> >> Have I missed anything? > Nope. > > I'm going to let you take this on. I have some other alligators to kill right now. The fix is already in JDK8 T&L and 7u6... Dan From kelly.ohair at oracle.com Fri Jun 8 01:03:50 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 7 Jun 2012 18:03:50 -0700 Subject: Review Request: Build-infra update In-Reply-To: <4FCDF638.8060908@oracle.com> References: <4FB39E43.6080909@oracle.com> <4FBBAE1F.3060906@oracle.com> <0272F5AB-B21F-466D-9820-86125E75065D@oracle.com> <4FBC9233.9000306@oracle.com> <4FBC9920.1010806@oracle.com> <4FBCFBC0.9070301@oracle.com> <5786AA72-2B06-4EB3-BE0A-1B413D0856F9@oracle.com> <4FBD18D9.1080401@oracle.com> <4FCCC2EE.1050302@oracle.com> <4FCDF638.8060908@oracle.com> Message-ID: <7F3D3860-6260-4EEE-942E-F2F242BD0599@oracle.com> Looks good. I'm doing a separate changeset for the src changes. -kto On Jun 5, 2012, at 5:06 AM, Erik Joelsson wrote: > Here is the new webrev, against latest jdk8/build. Only the jdk repo needed to be redone: > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk.2/ > > I added a comment explaining the usage of |. > > /Erik > > On 2012-06-04 16:15, Erik Joelsson wrote: >> I have created a (hopefully temporary) hack to run javah manually for these 5 classes. This webrev is just against the build-infra repo. Unless anybody objects to this temporary solution, I will publish a new full webrev against the jdk8/build forest tomorrow. >> >> http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/ >> >> /Erik >> >> On 2012-05-23 19:05, Alan Bateman wrote: >>> On 23/05/2012 17:50, Kelly O'Hair wrote: >>>> Has anyone tried creating an unused native method declaration in the class to trigger the native header >>>> generation? public native void GenerateNativeHeader(); ??? Is that too ugly? >>>> >>>> -kto >>> As Jon put it, for the classes in the base module, "we are delicate bootstrapping ground" so if you add something like "private static native void dummy()" rather than the annotation to the classes in the base module then it could be a solution for the short term. This means the following sources in the webrev: >>> >>> src/share/classes/java/lang/Integer.java >>> src/share/classes/java/lang/Long.java >>> src/share/classes/java/net/SocketOptions.java >>> src/windows/classes/sun/nio/ch/PollArrayWrapper.java >>> >>> Also it would be good to remove it from src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in the first round). >>> >>> -Alan. >>> From Kelly.Ohair at Oracle.Com Fri Jun 8 03:10:07 2012 From: Kelly.Ohair at Oracle.Com (Kelly O'Hair) Date: Thu, 7 Jun 2012 20:10:07 -0700 Subject: Need reviewer: build-infra makefile changes Message-ID: <46B56D0A-4D5C-494B-8F01-A4D3583499D8@Oracle.Com> No impact to the current makefiles. This is changes for the new build-infra makefiles. I'm sure there is more to come. Thanks to Erik, Magnus, Fredrik, and Jonas. If I missed anyone else that has contributed on this, my apologies. 7170079: Adjustments to build-infra makefiles http://cr.openjdk.java.net/~ohair/openjdk8/build-infra2/webrev/ -kto From volker.simonis at gmail.com Fri Jun 8 15:58:51 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 8 Jun 2012 17:58:51 +0200 Subject: Missing/wrong build dependencies for inline functions in HotSpot Message-ID: Hi, I've just stumbled across the problem that changing the implementation of an inline function in HotSpot does not necessarily rebuild all the call sites of that function. This is because because of the way how the build dependencies are handled within the HotSpot. As an example you may have a look at frame.cpp: frame.cpp includes frame.inline.hpp frame.inline.hpp includes frame_x86.inline.hpp However frame.cpp only depends on frame.inline.hpp directly (i.e. frame.cpp only includes frame.inline.hpp directly and this is where the dependencies generated by gcc with '-MMD' are computed from). So if an inline function in frame_x86.inline.hpp will be changed (e.g. the constructor frame::frame()), frame.cpp will not be recompiled in an incremental build, although it uses the constructor frame::frame(). This makes incremental builds useless (or dangerous, depending on the view point) when inline functions are changed. I think this is a non-trivial problem which is deeply rooted in the way how C++ implements inlining and the way how inline functions are defined in HotSpot (i.e. .hpp, .inline.hpp, _.hpp and _.inline.hpp files). I don't have a solution for it but just wanted to ask if somebody else already stumbled upon this problem and/or has solution for it? Regards, Volker From keith.mcguigan at oracle.com Fri Jun 8 16:25:59 2012 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Fri, 08 Jun 2012 12:25:59 -0400 Subject: Missing/wrong build dependencies for inline functions in HotSpot In-Reply-To: References: Message-ID: <4FD22797.4090904@oracle.com> I don't understand why gcc doesn't put frame_x86.inline.hpp into the generated/dependencies/frame.o.d file. Isn't the point of -MMD to calculate the full closer of header files used for listing as a dependency? Is this a bug in gcc or are we using it wrong? I notice that Sun Studio compiler does put the arch-specific header file in the generated dependency file. Weird. -- - Keith On 6/8/2012 11:58 AM, Volker Simonis wrote: > Hi, > > I've just stumbled across the problem that changing the implementation > of an inline function in HotSpot does not necessarily rebuild all the > call sites of that function. This is because because of the way how > the build dependencies are handled within the HotSpot. As an example > you may have a look at frame.cpp: > > frame.cpp includes frame.inline.hpp > frame.inline.hpp includes frame_x86.inline.hpp > > However frame.cpp only depends on frame.inline.hpp directly (i.e. > frame.cpp only includes frame.inline.hpp directly and this is where > the dependencies generated by gcc with '-MMD' are computed from). > So if an inline function in frame_x86.inline.hpp will be changed (e.g. > the constructor frame::frame()), frame.cpp will not be recompiled in > an incremental build, although it uses the constructor frame::frame(). > This makes incremental builds useless (or dangerous, depending on the > view point) when inline functions are changed. > > I think this is a non-trivial problem which is deeply rooted in the > way how C++ implements inlining and the way how inline functions are > defined in HotSpot (i.e. .hpp, .inline.hpp, _.hpp and > _.inline.hpp files). I don't have a solution for it but just > wanted to ask if somebody else already stumbled upon this problem > and/or has solution for it? > > Regards, > Volker From kelly.ohair at oracle.com Fri Jun 8 17:10:13 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 08 Jun 2012 17:10:13 +0000 Subject: hg: jdk8/build: 7170079: Adjustments to build-infra makefiles Message-ID: <20120608171013.C719B47800@hg.openjdk.java.net> Changeset: efd26e051e50 Author: erikj Date: 2012-06-07 20:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/efd26e051e50 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! README-builds.html ! common/autoconf/autogen.sh ! common/autoconf/builddeps.m4 ! common/autoconf/configure ! common/autoconf/configure.ac ! common/autoconf/help.m4 ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in ! common/bin/compareimage.sh ! common/bin/diffexec.sh ! common/bin/diffjarzip.sh ! common/bin/difflib.sh ! common/bin/logger.sh ! common/makefiles/JavaCompilation.gmk ! common/makefiles/MakeBase.gmk ! common/makefiles/Makefile ! common/makefiles/NativeCompilation.gmk From kelly.ohair at oracle.com Fri Jun 8 17:10:28 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 08 Jun 2012 17:10:28 +0000 Subject: hg: jdk8/build/jdk: 3 new changesets Message-ID: <20120608171111.719DA47801@hg.openjdk.java.net> Changeset: c499fd3f1695 Author: erikj Date: 2012-06-07 18:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c499fd3f1695 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI Reviewed-by: ohair, ohrstrom, ihse ! make/sun/awt/make.depend ! src/macosx/classes/apple/laf/JRSUIConstants.java ! src/macosx/classes/com/apple/eawt/FullScreenHandler.java ! src/macosx/classes/com/apple/eawt/event/GestureHandler.java ! src/macosx/classes/sun/java2d/OSXSurfaceData.java ! src/macosx/classes/sun/lwawt/LWLabelPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/macosx/classes/sun/lwawt/macosx/CocoaConstants.java ! src/share/classes/java/awt/Adjustable.java ! src/share/classes/java/awt/BasicStroke.java ! src/share/classes/java/awt/Choice.java ! src/share/classes/java/awt/DisplayMode.java ! src/share/classes/java/awt/Image.java ! src/share/classes/java/awt/List.java ! src/share/classes/java/awt/PopupMenu.java ! src/share/classes/java/awt/SystemColor.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/Transparency.java ! src/share/classes/java/awt/color/ColorSpace.java ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/awt/datatransfer/Clipboard.java ! src/share/classes/java/awt/datatransfer/StringSelection.java ! src/share/classes/java/awt/dnd/DnDConstants.java ! src/share/classes/java/awt/event/ActionEvent.java ! src/share/classes/java/awt/event/AdjustmentEvent.java ! src/share/classes/java/awt/event/ComponentEvent.java ! src/share/classes/java/awt/event/InputMethodEvent.java ! src/share/classes/java/awt/event/MouseWheelEvent.java ! src/share/classes/java/awt/geom/PathIterator.java ! src/share/classes/java/awt/image/AffineTransformOp.java ! src/share/classes/java/awt/image/ConvolveOp.java ! src/share/classes/java/awt/image/DataBuffer.java ! src/share/classes/java/awt/image/DirectColorModel.java ! src/share/classes/java/awt/image/ImageConsumer.java ! src/share/classes/java/awt/image/ImageObserver.java ! src/share/classes/java/awt/peer/ComponentPeer.java ! src/share/classes/java/awt/print/PageFormat.java ! src/share/classes/java/awt/print/Pageable.java ! src/share/classes/java/awt/print/Printable.java ! src/share/classes/sun/awt/CharsetString.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/share/classes/sun/awt/SunHints.java ! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/share/classes/sun/awt/image/BufImgSurfaceData.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/opengl/OGLContext.java ! src/share/classes/sun/java2d/pipe/BufferedContext.java ! src/share/classes/sun/java2d/pipe/BufferedOpCodes.java ! src/share/classes/sun/java2d/pipe/BufferedPaints.java ! src/share/classes/sun/java2d/pipe/BufferedTextPipe.java ! src/share/classes/sun/java2d/pipe/RegionIterator.java ! src/share/classes/sun/java2d/pipe/RenderBuffer.java ! src/share/classes/sun/java2d/pipe/hw/AccelDeviceEventNotifier.java ! src/share/classes/sun/java2d/pipe/hw/AccelSurface.java ! src/share/classes/sun/java2d/pipe/hw/ContextCapabilities.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/IOStatus.java ! src/share/classes/sun/security/pkcs11/Secmod.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/windows/classes/sun/java2d/d3d/D3DBlitLoops.java ! src/windows/classes/sun/java2d/d3d/D3DContext.java ! src/windows/classes/sun/java2d/d3d/D3DPaints.java ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c ! src/windows/native/sun/windows/awt_DataTransferer.cpp ! src/windows/native/sun/windows/awt_MenuItem.h Changeset: 898ce0cf7476 Author: ohair Date: 2012-06-07 20:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/898ce0cf7476 Merge ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java Changeset: 1953cf522107 Author: erikj Date: 2012-06-07 20:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1953cf522107 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/CompileDemos.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CopySamples.gmk + makefiles/CreateJars.gmk ! makefiles/GendataBreakIterator.gmk + makefiles/GendataFontConfig.gmk + makefiles/GendataHtml32dtd.gmk + makefiles/GendataTimeZone.gmk ! makefiles/GenerateClasses.gmk ! makefiles/GenerateData.gmk ! makefiles/GenerateJavaSources.gmk + makefiles/GensrcBuffer.gmk ! makefiles/GensrcCharacterData.gmk + makefiles/GensrcCharsetCoder.gmk + makefiles/GensrcCharsetMapping.gmk + makefiles/GensrcExceptions.gmk + makefiles/GensrcIcons.gmk ! makefiles/GensrcJDWP.gmk ! makefiles/GensrcLocaleDataMetaInfo.gmk ! makefiles/GensrcMisc.gmk ! makefiles/GensrcProperties.gmk + makefiles/GensrcSwing.gmk + makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/LegacyMakefiles.gmk ! makefiles/Makefile + makefiles/OldImages.gmk ! makefiles/Setup.gmk ! makefiles/Tools.gmk - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile ! makefiles/common/Defs-macosx.gmk ! makefiles/common/Release-macosx.gmk ! makefiles/common/Release.gmk - makefiles/common/shared/Defs-utils.gmk ! makefiles/common/shared/Defs.gmk ! makefiles/docs/CORE_PKGS.gmk ! makefiles/java/Makefile - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers ! makefiles/java/redist/Makefile - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile + makefiles/mapfiles/libawt/mapfile-mawt-vers + makefiles/mapfiles/libawt/mapfile-vers + makefiles/mapfiles/libawt/mapfile-vers-linux + makefiles/mapfiles/libawt_headless/mapfile-vers + makefiles/mapfiles/libawt_headless/reorder-i586 + makefiles/mapfiles/libawt_headless/reorder-sparc + makefiles/mapfiles/libawt_headless/reorder-sparcv9 + makefiles/mapfiles/libawt_xawt/mapfile-vers + makefiles/mapfiles/libdcpr/mapfile-vers + makefiles/mapfiles/libhprof/mapfile-vers + makefiles/mapfiles/libinstrument/mapfile-vers + makefiles/mapfiles/libj2gss/mapfile-vers + makefiles/mapfiles/libj2pcsc/mapfile-vers + makefiles/mapfiles/libj2pkcs11/mapfile-vers + makefiles/mapfiles/libj2ucrypto/mapfile-vers + makefiles/mapfiles/libjava/mapfile-vers + makefiles/mapfiles/libjava/reorder-i586 + makefiles/mapfiles/libjava/reorder-sparc + makefiles/mapfiles/libjava/reorder-sparcv9 + makefiles/mapfiles/libjava_crw_demo/mapfile-vers + makefiles/mapfiles/libjdga/mapfile-vers + makefiles/mapfiles/libjfr/mapfile-vers + makefiles/mapfiles/libjli/mapfile-vers ! makefiles/mapfiles/libjpeg/reorder-i586 ! makefiles/mapfiles/libjpeg/reorder-sparc ! makefiles/mapfiles/libjpeg/reorder-sparcv9 + makefiles/mapfiles/libjsound/mapfile-vers + makefiles/mapfiles/libjsoundalsa/mapfile-vers + makefiles/mapfiles/libkcms/mapfile-vers + makefiles/mapfiles/libmanagement/mapfile-vers + makefiles/mapfiles/libmlib_image/mapfile-vers + makefiles/mapfiles/libnet/mapfile-vers + makefiles/mapfiles/libnio/mapfile-bsd + makefiles/mapfiles/libnio/mapfile-linux + makefiles/mapfiles/libnio/mapfile-solaris + makefiles/mapfiles/libnio/reorder-i586 + makefiles/mapfiles/libnio/reorder-sparc + makefiles/mapfiles/libnio/reorder-sparcv9 + makefiles/mapfiles/libnpt/mapfile-vers + makefiles/mapfiles/libsplashscreen/mapfile-vers + makefiles/mapfiles/libsunec/mapfile-vers ! makefiles/mapfiles/libverify/reorder-i586 ! makefiles/mapfiles/libverify/reorder-sparc ! makefiles/mapfiles/libverify/reorder-sparcv9 ! makefiles/mapfiles/libzip/reorder-i586 ! makefiles/mapfiles/libzip/reorder-sparc ! makefiles/mapfiles/libzip/reorder-sparcv9 + makefiles/scripts/addNotices.sh + makefiles/scripts/genCharsetProvider.sh + makefiles/scripts/genExceptions.sh + makefiles/scripts/localelist.sh - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers From kelly.ohair at oracle.com Fri Jun 8 17:11:17 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 08 Jun 2012 17:11:17 +0000 Subject: hg: jdk8/build/jaxp: 7170079: Adjustments to build-infra makefiles Message-ID: <20120608171122.3E6CA47802@hg.openjdk.java.net> Changeset: 83a38059327b Author: erikj Date: 2012-06-07 20:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/83a38059327b 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/Makefile From kelly.ohair at oracle.com Fri Jun 8 17:11:29 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 08 Jun 2012 17:11:29 +0000 Subject: hg: jdk8/build/corba: 7170079: Adjustments to build-infra makefiles Message-ID: <20120608171131.25BFF47803@hg.openjdk.java.net> Changeset: 0c0b50c7b76a Author: erikj Date: 2012-06-07 20:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/0c0b50c7b76a 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/Makefile From kelly.ohair at oracle.com Fri Jun 8 17:11:37 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 08 Jun 2012 17:11:37 +0000 Subject: hg: jdk8/build/jaxws: 7170079: Adjustments to build-infra makefiles Message-ID: <20120608171141.BD80B47804@hg.openjdk.java.net> Changeset: 001351a98bd5 Author: erikj Date: 2012-06-07 20:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/001351a98bd5 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/Makefile From kelly.ohair at oracle.com Fri Jun 8 17:11:53 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 08 Jun 2012 17:11:53 +0000 Subject: hg: jdk8/build/langtools: 7170079: Adjustments to build-infra makefiles Message-ID: <20120608171158.B140C47805@hg.openjdk.java.net> Changeset: ac29cc95b5c5 Author: erikj Date: 2012-06-07 20:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ac29cc95b5c5 7170079: Adjustments to build-infra makefiles Reviewed-by: ohair, ohrstrom, ihse, jonas Contributed-by: jonas , erikj , ihse , tgranat , ykantser ! makefiles/Makefile From kelly.ohair at oracle.com Fri Jun 8 17:32:48 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 8 Jun 2012 10:32:48 -0700 Subject: Need reviewer: build-infra makefile changes In-Reply-To: <46B56D0A-4D5C-494B-8F01-A4D3583499D8@Oracle.Com> References: <46B56D0A-4D5C-494B-8F01-A4D3583499D8@Oracle.Com> Message-ID: <4088F0CA-0C05-40B2-B462-3B250D229CC3@oracle.com> Technically, I had plenty of reviewers via the build-infra team, my wording was a bit off on this email. Sorry. These new build-infra changes have now been pushed into the jdk8/build forest. I have NOT verified the build-infra builds, only verified that the existing old makefiles are not impacted. This probably won't be integrated into jdk8/jdk8 until the middle of next week. So we have time to adjust any issues in jdk8/build that we find prior to Tuesday evening (Pacific time) or so. Many thanks to the build-infra team and all the hard work on this. -kto On Jun 7, 2012, at 8:10 PM, Kelly O'Hair wrote: > > No impact to the current makefiles. > > This is changes for the new build-infra makefiles. > > I'm sure there is more to come. > > Thanks to Erik, Magnus, Fredrik, and Jonas. If I missed anyone else that has contributed on this, my apologies. > > 7170079: Adjustments to build-infra makefiles > http://cr.openjdk.java.net/~ohair/openjdk8/build-infra2/webrev/ > > -kto > > From volker.simonis at gmail.com Fri Jun 8 17:50:07 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 8 Jun 2012 19:50:07 +0200 Subject: Missing/wrong build dependencies for inline functions in HotSpot In-Reply-To: <4FD22797.4090904@oracle.com> References: <4FD22797.4090904@oracle.com> Message-ID: Yes, that's really strange. You're right, the dependency file should contain ".. the names of all the included files" (gcc -man page). So it seems to be a bug in gcc and how it handles '-MMD' although I couldn't find a bug report for it and I can't believe that nobody else has noticed this before. I've tried gcc 4.4.3 and 4.1.2 and they both produce a wrong dependency file which only contains the direct includes of the processed .cpp file (with "-c -MMD -MP -MF ../generated/dependencies/frame.o.d -o frame.o"). If I compile with "-c -MM -MP -MF ../generated/dependencies/frame.o.d -o frame.o" the generated dependency file is much bigger and looks ok, but of course I get no object file. I also get he same wrong behavior for -MD vs -M. The only reason behind -MD and -MMD is that it "..can be used to generate a dependency output file as a side-effect of the compilation process" (from the GCC man page) - but that doesn't seem to work.. Does anybody has an explanation for this behavior? Regards, Volker On Fri, Jun 8, 2012 at 6:25 PM, Keith McGuigan wrote: > > I don't understand why gcc doesn't put frame_x86.inline.hpp into the > generated/dependencies/frame.o.d file. ?Isn't the point of -MMD to calculate > the full closer of header files used for listing as a dependency? ?Is this a > bug in gcc or are we using it wrong? > > I notice that Sun Studio compiler does put the arch-specific header file in > the generated dependency file. ?Weird. > > -- > - Keith > > > On 6/8/2012 11:58 AM, Volker Simonis wrote: >> >> Hi, >> >> I've just stumbled across the problem that changing the implementation >> of an inline function in HotSpot does not necessarily rebuild all the >> call sites of that function. This is because because of the way how >> the build dependencies are handled within the HotSpot. As an example >> you may have a look at frame.cpp: >> >> frame.cpp includes frame.inline.hpp >> frame.inline.hpp includes frame_x86.inline.hpp >> >> However frame.cpp only depends on frame.inline.hpp directly (i.e. >> frame.cpp only includes frame.inline.hpp directly and this is where >> the dependencies generated by gcc with '-MMD' are computed from). >> So if an inline function in frame_x86.inline.hpp will be changed (e.g. >> the constructor frame::frame()), frame.cpp will not be recompiled in >> an incremental build, although it uses the constructor frame::frame(). >> This makes incremental builds useless (or dangerous, depending on the >> view point) when inline functions are changed. >> >> I think this is a non-trivial problem which is deeply rooted in the >> way how C++ implements inlining and the way how inline functions are >> defined in HotSpot (i.e. .hpp, .inline.hpp, ?_.hpp and >> _.inline.hpp files). I don't have a solution for it but just >> wanted to ask if somebody else already stumbled upon this problem >> and/or has solution for it? >> >> Regards, >> Volker From david.holmes at oracle.com Fri Jun 8 22:19:35 2012 From: david.holmes at oracle.com (David Holmes) Date: Sat, 09 Jun 2012 08:19:35 +1000 Subject: RFR: 7175331 - Remove FDS files from embedded JRE images In-Reply-To: <4FD14ED2.2010907@oracle.com> References: <4FD14ED2.2010907@oracle.com> Message-ID: <4FD27A77.1060103@oracle.com> cc'ing build-dev for a review by a 7u Reviewer. Thanks, David On 8/06/2012 11:01 AM, David Holmes wrote: > This is a simple fix that only applies to 7u and is targeted for 7u6. > > We need to update the embedded image target in Release-embedded.gmk to > remove the FDS related files that now get created. This obviously only > impacts embedded builds. > > http://cr.openjdk.java.net/~dholmes/7175331/webrev/ > > Also tidied up some extraneous -f options on rm ($(RM) == rm -f) > > Thanks, > David From kelly.ohair at oracle.com Sat Jun 9 00:11:46 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 8 Jun 2012 17:11:46 -0700 Subject: RFR: 7175331 - Remove FDS files from embedded JRE images In-Reply-To: <4FD27A77.1060103@oracle.com> References: <4FD14ED2.2010907@oracle.com> <4FD27A77.1060103@oracle.com> Message-ID: <0E242E71-EDE7-4671-B722-8D98A3E35624@oracle.com> Looks fine. -kto On Jun 8, 2012, at 3:19 PM, David Holmes wrote: > cc'ing build-dev for a review by a 7u Reviewer. > > Thanks, > David > > On 8/06/2012 11:01 AM, David Holmes wrote: >> This is a simple fix that only applies to 7u and is targeted for 7u6. >> >> We need to update the embedded image target in Release-embedded.gmk to >> remove the FDS related files that now get created. This obviously only >> impacts embedded builds. >> >> http://cr.openjdk.java.net/~dholmes/7175331/webrev/ >> >> Also tidied up some extraneous -f options on rm ($(RM) == rm -f) >> >> Thanks, >> David From kelly.ohair at oracle.com Sat Jun 9 00:29:06 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Sat, 09 Jun 2012 00:29:06 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20120609002906.89BB647812@hg.openjdk.java.net> Changeset: dd596160b323 Author: ohair Date: 2012-06-08 17:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/dd596160b323 7170091: Fix missing wait between repo cloning in hgforest.sh Reviewed-by: strarup ! make/scripts/hgforest.sh Changeset: c61921f9b965 Author: ohair Date: 2012-06-08 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/c61921f9b965 Merge From david.holmes at oracle.com Sat Jun 9 10:50:04 2012 From: david.holmes at oracle.com (David Holmes) Date: Sat, 09 Jun 2012 20:50:04 +1000 Subject: RFR: 7175331 - Remove FDS files from embedded JRE images In-Reply-To: <4FD289F1.8060402@oracle.com> References: <4FD14ED2.2010907@oracle.com> <4FD289F1.8060402@oracle.com> Message-ID: <4FD32A5C.2060503@oracle.com> On 9/06/2012 9:25 AM, Daniel D. Daugherty wrote: > On 6/7/12 7:01 PM, David Holmes wrote: >> This is a simple fix that only applies to 7u and is targeted for 7u6. >> >> We need to update the embedded image target in Release-embedded.gmk to >> remove the FDS related files that now get created. This obviously only >> impacts embedded builds. >> >> http://cr.openjdk.java.net/~dholmes/7175331/webrev/ >> >> Also tidied up some extraneous -f options on rm ($(RM) == rm -f) > > line 168: -type f -name "*.debuginfo" -o -name "*.diz" -print > I think this part needs to be: > > -type f \( -name "*.debuginfo" -o -name "*.diz" \) -print > > so that the '-o' option binds correctly. Thanks Dan you are right. It's not likely that there would be a *.diz directory but better to get this right. I've updated the webrev for completeness: http://cr.openjdk.java.net/~dholmes/7175331/webrev.01/ but will assume your reviews stands, as does Kelly's. I have to request approval to push anyway. Thanks, David > Dan > From kelly.ohair at oracle.com Sat Jun 9 19:46:02 2012 From: kelly.ohair at oracle.com (Kelly Ohair) Date: Sat, 9 Jun 2012 12:46:02 -0700 Subject: RFR: 7175331 - Remove FDS files from embedded JRE images In-Reply-To: <4FD32A5C.2060503@oracle.com> References: <4FD14ED2.2010907@oracle.com> <4FD289F1.8060402@oracle.com> <4FD32A5C.2060503@oracle.com> Message-ID: <945ECB70-0F4D-4E8F-B5C9-DDF670500020@oracle.com> still looks ok said the blind man :( Sent from my iPhone On Jun 9, 2012, at 3:50, David Holmes wrote: > On 9/06/2012 9:25 AM, Daniel D. Daugherty wrote: >> On 6/7/12 7:01 PM, David Holmes wrote: >>> This is a simple fix that only applies to 7u and is targeted for 7u6. >>> >>> We need to update the embedded image target in Release-embedded.gmk to >>> remove the FDS related files that now get created. This obviously only >>> impacts embedded builds. >>> >>> http://cr.openjdk.java.net/~dholmes/7175331/webrev/ >>> >>> Also tidied up some extraneous -f options on rm ($(RM) == rm -f) >> >> line 168: -type f -name "*.debuginfo" -o -name "*.diz" -print >> I think this part needs to be: >> >> -type f \( -name "*.debuginfo" -o -name "*.diz" \) -print >> >> so that the '-o' option binds correctly. > > Thanks Dan you are right. It's not likely that there would be a *.diz directory but better to get this right. I've updated the webrev for completeness: > > http://cr.openjdk.java.net/~dholmes/7175331/webrev.01/ > > but will assume your reviews stands, as does Kelly's. I have to request approval to push anyway. > > Thanks, > David > >> Dan >> From daniel.daugherty at oracle.com Sun Jun 10 03:32:55 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Sat, 09 Jun 2012 21:32:55 -0600 Subject: RFR: 7175331 - Remove FDS files from embedded JRE images In-Reply-To: <4FD32A5C.2060503@oracle.com> References: <4FD14ED2.2010907@oracle.com> <4FD289F1.8060402@oracle.com> <4FD32A5C.2060503@oracle.com> Message-ID: <4FD41567.3090006@oracle.com> On 6/9/12 4:50 AM, David Holmes wrote: > On 9/06/2012 9:25 AM, Daniel D. Daugherty wrote: >> On 6/7/12 7:01 PM, David Holmes wrote: >>> This is a simple fix that only applies to 7u and is targeted for 7u6. >>> >>> We need to update the embedded image target in Release-embedded.gmk to >>> remove the FDS related files that now get created. This obviously only >>> impacts embedded builds. >>> >>> http://cr.openjdk.java.net/~dholmes/7175331/webrev/ >>> >>> Also tidied up some extraneous -f options on rm ($(RM) == rm -f) >> >> line 168: -type f -name "*.debuginfo" -o -name "*.diz" -print >> I think this part needs to be: >> >> -type f \( -name "*.debuginfo" -o -name "*.diz" \) -print >> >> so that the '-o' option binds correctly. > > Thanks Dan you are right. It's not likely that there would be a *.diz > directory but better to get this right. I've updated the webrev for > completeness: > > http://cr.openjdk.java.net/~dholmes/7175331/webrev.01/ > > but will assume your reviews stands, as does Kelly's. I have to > request approval to push anyway. Yes, my review still stands. Dan > > Thanks, > David > >> Dan >> From kelly.ohair at oracle.com Sun Jun 10 16:58:00 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Sun, 10 Jun 2012 09:58:00 -0700 Subject: RFR: 7175331 - Remove FDS files from embedded JRE images In-Reply-To: <4FD41567.3090006@oracle.com> References: <4FD14ED2.2010907@oracle.com> <4FD289F1.8060402@oracle.com> <4FD32A5C.2060503@oracle.com> <4FD41567.3090006@oracle.com> Message-ID: <89D5C7D9-CFF3-4F58-9187-4B027520C26A@oracle.com> On Jun 9, 2012, at 8:32 PM, Daniel D. Daugherty wrote: > > > On 6/9/12 4:50 AM, David Holmes wrote: >> On 9/06/2012 9:25 AM, Daniel D. Daugherty wrote: >>> On 6/7/12 7:01 PM, David Holmes wrote: >>>> This is a simple fix that only applies to 7u and is targeted for 7u6. >>>> >>>> We need to update the embedded image target in Release-embedded.gmk to >>>> remove the FDS related files that now get created. This obviously only >>>> impacts embedded builds. >>>> >>>> http://cr.openjdk.java.net/~dholmes/7175331/webrev/ >>>> >>>> Also tidied up some extraneous -f options on rm ($(RM) == rm -f) >>> >>> line 168: -type f -name "*.debuginfo" -o -name "*.diz" -print >>> I think this part needs to be: >>> >>> -type f \( -name "*.debuginfo" -o -name "*.diz" \) -print >>> >>> so that the '-o' option binds correctly. >> >> Thanks Dan you are right. It's not likely that there would be a *.diz directory but better to get this right. I've updated the webrev for completeness: >> >> http://cr.openjdk.java.net/~dholmes/7175331/webrev.01/ >> >> but will assume your reviews stands, as does Kelly's. I have to request approval to push anyway. > > Yes, my review still stands. Mine too. -kto > > Dan > >> >> Thanks, >> David >> >>> Dan >>> From volker.simonis at gmail.com Mon Jun 11 10:01:35 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 11 Jun 2012 12:01:35 +0200 Subject: Missing/wrong build dependencies for inline functions in HotSpot In-Reply-To: References: <4FD22797.4090904@oracle.com> Message-ID: I found the problem! It's related to the use of precompiled headers. We need to use '-fpch-deps' in order to get the full dependencies, otherwise all the dependencies from the pch file are omitted. I'm currently preparing a webrev which fixes the problem. It would be nice if somebody could meanwhile open a bug for the problem (e.g. "Usage of gcc with precompiled headers produces wrong build dependencies") and provide a bug-id. Regards, Volker On Fri, Jun 8, 2012 at 7:50 PM, Volker Simonis wrote: > Yes, that's really strange. You're right, the dependency file should > contain ".. the names of all the included files" (gcc -man page). > > So it seems to be a bug in gcc and how it handles '-MMD' although I > couldn't find a bug report for it and I can't believe that nobody else > has noticed this before. I've tried gcc 4.4.3 and 4.1.2 and they both > produce a wrong dependency file which only contains the direct > includes of the processed .cpp file (with "-c -MMD -MP -MF > ../generated/dependencies/frame.o.d -o frame.o"). > > If I compile with "-c -MM -MP -MF ../generated/dependencies/frame.o.d > -o frame.o" the generated dependency file is much bigger and looks ok, > but of course I get no object file. I also get he same wrong behavior > for -MD vs -M. The only reason behind -MD and -MMD is that it "..can > be used to generate a dependency output file as a side-effect of the > compilation process" (from the GCC man page) - but that doesn't seem > to work.. > > Does anybody has an explanation for this behavior? > > Regards, > Volker > > On Fri, Jun 8, 2012 at 6:25 PM, Keith McGuigan > wrote: >> >> I don't understand why gcc doesn't put frame_x86.inline.hpp into the >> generated/dependencies/frame.o.d file. ?Isn't the point of -MMD to calculate >> the full closer of header files used for listing as a dependency? ?Is this a >> bug in gcc or are we using it wrong? >> >> I notice that Sun Studio compiler does put the arch-specific header file in >> the generated dependency file. ?Weird. >> >> -- >> - Keith >> >> >> On 6/8/2012 11:58 AM, Volker Simonis wrote: >>> >>> Hi, >>> >>> I've just stumbled across the problem that changing the implementation >>> of an inline function in HotSpot does not necessarily rebuild all the >>> call sites of that function. This is because because of the way how >>> the build dependencies are handled within the HotSpot. As an example >>> you may have a look at frame.cpp: >>> >>> frame.cpp includes frame.inline.hpp >>> frame.inline.hpp includes frame_x86.inline.hpp >>> >>> However frame.cpp only depends on frame.inline.hpp directly (i.e. >>> frame.cpp only includes frame.inline.hpp directly and this is where >>> the dependencies generated by gcc with '-MMD' are computed from). >>> So if an inline function in frame_x86.inline.hpp will be changed (e.g. >>> the constructor frame::frame()), frame.cpp will not be recompiled in >>> an incremental build, although it uses the constructor frame::frame(). >>> This makes incremental builds useless (or dangerous, depending on the >>> view point) when inline functions are changed. >>> >>> I think this is a non-trivial problem which is deeply rooted in the >>> way how C++ implements inlining and the way how inline functions are >>> defined in HotSpot (i.e. .hpp, .inline.hpp, ?_.hpp and >>> _.inline.hpp files). I don't have a solution for it but just >>> wanted to ask if somebody else already stumbled upon this problem >>> and/or has solution for it? >>> >>> Regards, >>> Volker From volker.simonis at gmail.com Mon Jun 11 10:10:59 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Mon, 11 Jun 2012 12:10:59 +0200 Subject: Missing/wrong build dependencies for inline functions in HotSpot In-Reply-To: References: <4FD22797.4090904@oracle.com> Message-ID: Should this change be against http://hg.openjdk.java.net/jdk8/build/hotspot or better for http://hg.openjdk.java.net/hsx/hotspot-main/hotspot? On Mon, Jun 11, 2012 at 12:01 PM, Volker Simonis wrote: > I found the problem! > > It's related to the use of precompiled headers. We need to use > '-fpch-deps' in order to get the full dependencies, otherwise all the > dependencies from the pch file are omitted. > > I'm currently preparing a webrev which fixes ?the problem. It would be > nice if somebody could meanwhile open a bug for the problem (e.g. > "Usage of gcc with precompiled headers produces wrong build > dependencies") and provide a bug-id. > > Regards, > Volker > > > On Fri, Jun 8, 2012 at 7:50 PM, Volker Simonis wrote: >> Yes, that's really strange. You're right, the dependency file should >> contain ".. the names of all the included files" (gcc -man page). >> >> So it seems to be a bug in gcc and how it handles '-MMD' although I >> couldn't find a bug report for it and I can't believe that nobody else >> has noticed this before. I've tried gcc 4.4.3 and 4.1.2 and they both >> produce a wrong dependency file which only contains the direct >> includes of the processed .cpp file (with "-c -MMD -MP -MF >> ../generated/dependencies/frame.o.d -o frame.o"). >> >> If I compile with "-c -MM -MP -MF ../generated/dependencies/frame.o.d >> -o frame.o" the generated dependency file is much bigger and looks ok, >> but of course I get no object file. I also get he same wrong behavior >> for -MD vs -M. The only reason behind -MD and -MMD is that it "..can >> be used to generate a dependency output file as a side-effect of the >> compilation process" (from the GCC man page) - but that doesn't seem >> to work.. >> >> Does anybody has an explanation for this behavior? >> >> Regards, >> Volker >> >> On Fri, Jun 8, 2012 at 6:25 PM, Keith McGuigan >> wrote: >>> >>> I don't understand why gcc doesn't put frame_x86.inline.hpp into the >>> generated/dependencies/frame.o.d file. ?Isn't the point of -MMD to calculate >>> the full closer of header files used for listing as a dependency? ?Is this a >>> bug in gcc or are we using it wrong? >>> >>> I notice that Sun Studio compiler does put the arch-specific header file in >>> the generated dependency file. ?Weird. >>> >>> -- >>> - Keith >>> >>> >>> On 6/8/2012 11:58 AM, Volker Simonis wrote: >>>> >>>> Hi, >>>> >>>> I've just stumbled across the problem that changing the implementation >>>> of an inline function in HotSpot does not necessarily rebuild all the >>>> call sites of that function. This is because because of the way how >>>> the build dependencies are handled within the HotSpot. As an example >>>> you may have a look at frame.cpp: >>>> >>>> frame.cpp includes frame.inline.hpp >>>> frame.inline.hpp includes frame_x86.inline.hpp >>>> >>>> However frame.cpp only depends on frame.inline.hpp directly (i.e. >>>> frame.cpp only includes frame.inline.hpp directly and this is where >>>> the dependencies generated by gcc with '-MMD' are computed from). >>>> So if an inline function in frame_x86.inline.hpp will be changed (e.g. >>>> the constructor frame::frame()), frame.cpp will not be recompiled in >>>> an incremental build, although it uses the constructor frame::frame(). >>>> This makes incremental builds useless (or dangerous, depending on the >>>> view point) when inline functions are changed. >>>> >>>> I think this is a non-trivial problem which is deeply rooted in the >>>> way how C++ implements inlining and the way how inline functions are >>>> defined in HotSpot (i.e. .hpp, .inline.hpp, ?_.hpp and >>>> _.inline.hpp files). I don't have a solution for it but just >>>> wanted to ask if somebody else already stumbled upon this problem >>>> and/or has solution for it? >>>> >>>> Regards, >>>> Volker From keith.mcguigan at oracle.com Mon Jun 11 11:14:56 2012 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Mon, 11 Jun 2012 07:14:56 -0400 Subject: Missing/wrong build dependencies for inline functions in HotSpot In-Reply-To: References: <4FD22797.4090904@oracle.com> Message-ID: <4FD5D330.502@oracle.com> I can shepherd this through the hotspot-rt repository, where it will filter up to hotspot-main and then jdk8/hotspot. I'll make a CR for this too. http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot -- - Keith On 6/11/2012 6:10 AM, Volker Simonis wrote: > Should this change be against > http://hg.openjdk.java.net/jdk8/build/hotspot or better for > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot? > > On Mon, Jun 11, 2012 at 12:01 PM, Volker Simonis > wrote: >> I found the problem! >> >> It's related to the use of precompiled headers. We need to use >> '-fpch-deps' in order to get the full dependencies, otherwise all the >> dependencies from the pch file are omitted. >> >> I'm currently preparing a webrev which fixes the problem. It would be >> nice if somebody could meanwhile open a bug for the problem (e.g. >> "Usage of gcc with precompiled headers produces wrong build >> dependencies") and provide a bug-id. >> >> Regards, >> Volker >> >> >> On Fri, Jun 8, 2012 at 7:50 PM, Volker Simonis wrote: >>> Yes, that's really strange. You're right, the dependency file should >>> contain ".. the names of all the included files" (gcc -man page). >>> >>> So it seems to be a bug in gcc and how it handles '-MMD' although I >>> couldn't find a bug report for it and I can't believe that nobody else >>> has noticed this before. I've tried gcc 4.4.3 and 4.1.2 and they both >>> produce a wrong dependency file which only contains the direct >>> includes of the processed .cpp file (with "-c -MMD -MP -MF >>> ../generated/dependencies/frame.o.d -o frame.o"). >>> >>> If I compile with "-c -MM -MP -MF ../generated/dependencies/frame.o.d >>> -o frame.o" the generated dependency file is much bigger and looks ok, >>> but of course I get no object file. I also get he same wrong behavior >>> for -MD vs -M. The only reason behind -MD and -MMD is that it "..can >>> be used to generate a dependency output file as a side-effect of the >>> compilation process" (from the GCC man page) - but that doesn't seem >>> to work.. >>> >>> Does anybody has an explanation for this behavior? >>> >>> Regards, >>> Volker >>> >>> On Fri, Jun 8, 2012 at 6:25 PM, Keith McGuigan >>> wrote: >>>> >>>> I don't understand why gcc doesn't put frame_x86.inline.hpp into the >>>> generated/dependencies/frame.o.d file. Isn't the point of -MMD to calculate >>>> the full closer of header files used for listing as a dependency? Is this a >>>> bug in gcc or are we using it wrong? >>>> >>>> I notice that Sun Studio compiler does put the arch-specific header file in >>>> the generated dependency file. Weird. >>>> >>>> -- >>>> - Keith >>>> >>>> >>>> On 6/8/2012 11:58 AM, Volker Simonis wrote: >>>>> >>>>> Hi, >>>>> >>>>> I've just stumbled across the problem that changing the implementation >>>>> of an inline function in HotSpot does not necessarily rebuild all the >>>>> call sites of that function. This is because because of the way how >>>>> the build dependencies are handled within the HotSpot. As an example >>>>> you may have a look at frame.cpp: >>>>> >>>>> frame.cpp includes frame.inline.hpp >>>>> frame.inline.hpp includes frame_x86.inline.hpp >>>>> >>>>> However frame.cpp only depends on frame.inline.hpp directly (i.e. >>>>> frame.cpp only includes frame.inline.hpp directly and this is where >>>>> the dependencies generated by gcc with '-MMD' are computed from). >>>>> So if an inline function in frame_x86.inline.hpp will be changed (e.g. >>>>> the constructor frame::frame()), frame.cpp will not be recompiled in >>>>> an incremental build, although it uses the constructor frame::frame(). >>>>> This makes incremental builds useless (or dangerous, depending on the >>>>> view point) when inline functions are changed. >>>>> >>>>> I think this is a non-trivial problem which is deeply rooted in the >>>>> way how C++ implements inlining and the way how inline functions are >>>>> defined in HotSpot (i.e. .hpp, .inline.hpp, _.hpp and >>>>> _.inline.hpp files). I don't have a solution for it but just >>>>> wanted to ask if somebody else already stumbled upon this problem >>>>> and/or has solution for it? >>>>> >>>>> Regards, >>>>> Volker From erik.joelsson at oracle.com Mon Jun 11 12:57:56 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 11 Jun 2012 14:57:56 +0200 Subject: Need reviewer: build-infra makefile changes In-Reply-To: <4088F0CA-0C05-40B2-B462-3B250D229CC3@oracle.com> References: <46B56D0A-4D5C-494B-8F01-A4D3583499D8@Oracle.Com> <4088F0CA-0C05-40B2-B462-3B250D229CC3@oracle.com> Message-ID: <4FD5EB54.7010202@oracle.com> An HTML attachment was scrubbed... URL: From kelly.ohair at oracle.com Mon Jun 11 16:30:22 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 11 Jun 2012 16:30:22 +0000 Subject: hg: jdk8/build/jdk: 7175966: Fix windows build issues for build-infra project Message-ID: <20120611163042.124EB47860@hg.openjdk.java.net> Changeset: e00f450a3c5f Author: erikj Date: 2012-06-11 09:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e00f450a3c5f 7175966: Fix windows build issues for build-infra project Reviewed-by: ohair ! makefiles/CompileJavaClasses.gmk ! makefiles/java/redist/sajdi/Makefile From kelly.ohair at oracle.com Mon Jun 11 16:33:01 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 11 Jun 2012 09:33:01 -0700 Subject: Need reviewer: build-infra makefile changes In-Reply-To: <4FD5EB54.7010202@oracle.com> References: <46B56D0A-4D5C-494B-8F01-A4D3583499D8@Oracle.Com> <4088F0CA-0C05-40B2-B462-3B250D229CC3@oracle.com> <4FD5EB54.7010202@oracle.com> Message-ID: <3644B3F1-3B3C-4F94-B799-D455D978059B@oracle.com> I just pushed this change in. -kto On Jun 11, 2012, at 5:57 AM, Erik Joelsson wrote: > And I've found two issues in the windows build that I would like to correct. > > http://cr.openjdk.java.net/~erikj/build-infra-m1.1/webrev-jdk-windowsfix/ > > makefiles/java/redist/sajdi/Makefile > The windows build broke when the full debug symbols were introduced. In 7170079, we haven't converted full debug symbols yet. The webrev contains a small fix (copying make/java/redist/sajdi/Makefile) which makes the build pass, but still without properly working full debug symbols. A full conversion of that feature will be in the next major push. > > makefiles/CompileJavaClasses.gmk > My temp fix for generating headers for specific classes in jdk.base failed on windows. The reason for using the variable PLATFORM is that it's commonly used in that file at this point. > > With these two, the windows build works at least as well as it used to before 7170079. > > /Erik > > On 2012-06-08 19:32, Kelly O'Hair wrote: >> >> Technically, I had plenty of reviewers via the build-infra team, my wording was a bit off on this email. Sorry. >> >> These new build-infra changes have now been pushed into the jdk8/build forest. >> >> I have NOT verified the build-infra builds, only verified that the existing old makefiles are not impacted. >> This probably won't be integrated into jdk8/jdk8 until the middle of next week. >> So we have time to adjust any issues in jdk8/build that we find prior to Tuesday evening (Pacific time) or so. >> >> >> Many thanks to the build-infra team and all the hard work on this. >> >> -kto >> >> On Jun 7, 2012, at 8:10 PM, Kelly O'Hair wrote: >> >>> No impact to the current makefiles. >>> >>> This is changes for the new build-infra makefiles. >>> >>> I'm sure there is more to come. >>> >>> Thanks to Erik, Magnus, Fredrik, and Jonas. If I missed anyone else that has contributed on this, my apologies. >>> >>> 7170079: Adjustments to build-infra makefiles >>> http://cr.openjdk.java.net/~ohair/openjdk8/build-infra2/webrev/ >>> >>> -kto >>> >>> -------------- next part -------------- An HTML attachment was scrubbed... URL: From magnus.ihse.bursie at oracle.com Mon Jun 11 16:39:03 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 11 Jun 2012 18:39:03 +0200 Subject: Need reviewer: build-infra makefile changes In-Reply-To: <4FD5EB54.7010202@oracle.com> References: <46B56D0A-4D5C-494B-8F01-A4D3583499D8@Oracle.Com> <4088F0CA-0C05-40B2-B462-3B250D229CC3@oracle.com> <4FD5EB54.7010202@oracle.com> Message-ID: <4FD61F27.7040209@oracle.com> An HTML attachment was scrubbed... URL: From kelly.ohair at oracle.com Wed Jun 13 16:43:58 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 13 Jun 2012 16:43:58 +0000 Subject: hg: jdk8/build/corba: 7176691: prtconf: devinfo facility not available in corba building Message-ID: <20120613164400.045B2478DB@hg.openjdk.java.net> Changeset: a1f721fbe5d0 Author: ohair Date: 2012-06-13 09:43 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/a1f721fbe5d0 7176691: prtconf: devinfo facility not available in corba building Reviewed-by: tbell ! make/common/shared/Platform.gmk From lana.steuck at oracle.com Wed Jun 13 16:51:51 2012 From: lana.steuck at oracle.com (Lana Steuck) Date: Wed, 13 Jun 2012 09:51:51 -0700 Subject: : JDK8 build fails in hotspot (hsx/hotspot-main/hotspot/rev/a297b0e14605 patch?) In-Reply-To: References: Message-ID: <4FD8C527.3070303@oracle.com> Forwarding Mario's email: First, he got a build failure in 8/awt, then he tried building 8/jdk8 - same problem. JDK8 build fails in hotspot. >> ompiling >> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/blockOffsetTable.cpp >> >> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp: >> In instantiation of ?TreeList* >> TreeList::remove_chunk_replace_if_needed(TreeChunk*) >> [with Chunk = FreeChunk]?: >> >> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:1342:16: >> required from here >> >> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:173:7: >> error: ?link_tail? was not declared in this scope, and no declarations >> were found by argument-dependent lookup at the point of instantiation >> [-fpermissive] He thinks: >> I guess the tree needs to be integrated with this patch: >> >> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a297b0e14605 Could this be a problem in his build environment? - Lana -------- Original Message -------- Subject: Re: JDK8 tree fails to compile Date: Wed, 13 Jun 2012 14:17:05 +0200 From: Mario Torre To: Anthony Petrov CC: awt-dev at openjdk.java.net, Lana Steuck Hi Anthony, Lana, Thanks for taking a look at it. I got the same problem with the very latest jdk8 repository. It seems that this patch is missing there too. I'm on a Fedora 17 machine, gcc version 4.7.0 20120507 (Red Hat 4.7.0-5) (GCC), perhaps this would explain why you don't see this? (It's the first time I tried to compile directly from the OpenJDK since I updated, so I can't say when this started to happen). Cheers, Mario > On 6/13/2012 2:19 PM, Mario Torre wrote: >> >> Hi all! >> >> I'm trying to compile the latest http://hg.openjdk.java.net/jdk8/awt >> but I got this error: >> >> ompiling >> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/blockOffsetTable.cpp >> >> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp: >> In instantiation of ?TreeList* >> TreeList::remove_chunk_replace_if_needed(TreeChunk*) >> [with Chunk = FreeChunk]?: >> >> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:1342:16: >> required from here >> >> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:173:7: >> error: ?link_tail? was not declared in this scope, and no declarations >> were found by argument-dependent lookup at the point of instantiation >> [-fpermissive] >> >> I guess the tree needs to be integrated with this patch: >> >> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a297b0e14605 >> >> Any ideas? >> >> Cheers, >> Mario -- pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From daniel.daugherty at oracle.com Wed Jun 13 17:22:43 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 13 Jun 2012 11:22:43 -0600 Subject: : JDK8 build fails in hotspot (hsx/hotspot-main/hotspot/rev/a297b0e14605 patch?) In-Reply-To: <4FD8CA06.7020302@oracle.com> References: <4FD8C527.3070303@oracle.com> <4FD8CA06.7020302@oracle.com> Message-ID: <4FD8CC63.6000804@oracle.com> The changeset for 7172226 is currently queued up in Main_Baseline which is gathering changes for the HSX-24-B14 snapshot. I believe that snapshot will be taken on Friday (06.15), and submitted for PIT over the weekend. If PIT passes, then HSX-24-B14 will push to the JDK8 masters next week for the JDK8-B44 promotion. Dan On 6/13/12 11:12 AM, Mikael Gerdin wrote: > Lana, > > This is indeed an issue with HotSpot and GCC 4.7. > It's fixed by > http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/a297b0e14605 > I'm not sure when this will end up in jdk8 master but I think the > change will be in hs24-b14. > > /Mikael > > On 2012-06-13 18:51, Lana Steuck wrote: >> Forwarding Mario's email: >> >> First, he got a build failure in 8/awt, then he tried building 8/jdk8 - >> same problem. >> JDK8 build fails in hotspot. >> >>>> ompiling >>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/blockOffsetTable.cpp >>>> >>>> >>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp: >>>> >>>> In instantiation of ?TreeList* >>>> TreeList::remove_chunk_replace_if_needed(TreeChunk*) >>>> [with Chunk = FreeChunk]?: >>>> >>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:1342:16: >>>> >>>> required from here >>>> >>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:173:7: >>>> >>>> error: ?link_tail? was not declared in this scope, and no declarations >>>> were found by argument-dependent lookup at the point of instantiation >>>> [-fpermissive] >> >> >> He thinks: >> >>>> I guess the tree needs to be integrated with this patch: >>>> >>>> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a297b0e14605 >> >> Could this be a problem in his build environment? >> >> - Lana >> >> -------- Original Message -------- >> Subject: Re: JDK8 tree fails to compile >> Date: Wed, 13 Jun 2012 14:17:05 +0200 >> From: Mario Torre >> To: Anthony Petrov >> CC: awt-dev at openjdk.java.net, Lana Steuck >> >> >> Hi Anthony, Lana, >> >> Thanks for taking a look at it. >> >> I got the same problem with the very latest jdk8 repository. It seems >> that this patch is missing there too. >> >> I'm on a Fedora 17 machine, gcc version 4.7.0 20120507 (Red Hat >> 4.7.0-5) (GCC), perhaps this would explain why you don't see this? >> (It's the first time I tried to compile directly from the OpenJDK >> since I updated, so I can't say when this started to happen). >> >> Cheers, >> Mario >> >> >>> On 6/13/2012 2:19 PM, Mario Torre wrote: >>>> >>>> Hi all! >>>> >>>> I'm trying to compile the latest http://hg.openjdk.java.net/jdk8/awt >>>> but I got this error: >>>> >>>> ompiling >>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/blockOffsetTable.cpp >>>> >>>> >>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp: >>>> >>>> In instantiation of ?TreeList* >>>> TreeList::remove_chunk_replace_if_needed(TreeChunk*) >>>> [with Chunk = FreeChunk]?: >>>> >>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:1342:16: >>>> >>>> required from here >>>> >>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:173:7: >>>> >>>> error: ?link_tail? was not declared in this scope, and no declarations >>>> were found by argument-dependent lookup at the point of instantiation >>>> [-fpermissive] >>>> >>>> I guess the tree needs to be integrated with this patch: >>>> >>>> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a297b0e14605 >>>> >>>> Any ideas? >>>> >>>> Cheers, >>>> Mario >> >> >> >> -- >> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF >> Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF >> >> IcedRobot: www.icedrobot.org >> Proud GNU Classpath developer: http://www.classpath.org/ >> Read About us at: http://planet.classpath.org >> OpenJDK: http://openjdk.java.net/projects/caciocavallo/ >> >> Please, support open standards: >> http://endsoftpatents.org/ >> > > From lana.steuck at oracle.com Wed Jun 13 18:32:13 2012 From: lana.steuck at oracle.com (Lana Steuck) Date: Wed, 13 Jun 2012 11:32:13 -0700 Subject: : JDK8 build fails in hotspot (hsx/hotspot-main/hotspot/rev/a297b0e14605 patch?) In-Reply-To: <4FD8CC63.6000804@oracle.com> References: <4FD8C527.3070303@oracle.com> <4FD8CA06.7020302@oracle.com> <4FD8CC63.6000804@oracle.com> Message-ID: <4FD8DCAD.9030104@oracle.com> Hi Dan and Mikael, Thank you for the quick reply and for all the details. I have forwarded the info to Mario. Thank you! - Lana On 06/13/2012 10:22 AM, Daniel D. Daugherty wrote: > The changeset for 7172226 is currently queued up in Main_Baseline > which is gathering changes for the HSX-24-B14 snapshot. I believe > that snapshot will be taken on Friday (06.15), and submitted for > PIT over the weekend. If PIT passes, then HSX-24-B14 will push to > the JDK8 masters next week for the JDK8-B44 promotion. > > Dan > > > On 6/13/12 11:12 AM, Mikael Gerdin wrote: >> Lana, >> >> This is indeed an issue with HotSpot and GCC 4.7. >> It's fixed by >> http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/a297b0e14605 >> I'm not sure when this will end up in jdk8 master but I think the >> change will be in hs24-b14. >> >> /Mikael >> >> On 2012-06-13 18:51, Lana Steuck wrote: >>> Forwarding Mario's email: >>> >>> First, he got a build failure in 8/awt, then he tried building 8/jdk8 - >>> same problem. >>> JDK8 build fails in hotspot. >>> >>>>> ompiling >>>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/blockOffsetTable.cpp >>>>> >>>>> >>>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp: >>>>> >>>>> In instantiation of ?TreeList* >>>>> TreeList::remove_chunk_replace_if_needed(TreeChunk*) >>>>> [with Chunk = FreeChunk]?: >>>>> >>>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:1342:16: >>>>> >>>>> required from here >>>>> >>>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:173:7: >>>>> >>>>> error: ?link_tail? was not declared in this scope, and no >>>>> declarations >>>>> were found by argument-dependent lookup at the point of instantiation >>>>> [-fpermissive] >>> >>> >>> He thinks: >>> >>>>> I guess the tree needs to be integrated with this patch: >>>>> >>>>> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a297b0e14605 >>> >>> Could this be a problem in his build environment? >>> >>> - Lana >>> >>> -------- Original Message -------- >>> Subject: Re: JDK8 tree fails to compile >>> Date: Wed, 13 Jun 2012 14:17:05 +0200 >>> From: Mario Torre >>> To: Anthony Petrov >>> CC: awt-dev at openjdk.java.net, Lana Steuck >>> >>> >>> Hi Anthony, Lana, >>> >>> Thanks for taking a look at it. >>> >>> I got the same problem with the very latest jdk8 repository. It seems >>> that this patch is missing there too. >>> >>> I'm on a Fedora 17 machine, gcc version 4.7.0 20120507 (Red Hat >>> 4.7.0-5) (GCC), perhaps this would explain why you don't see this? >>> (It's the first time I tried to compile directly from the OpenJDK >>> since I updated, so I can't say when this started to happen). >>> >>> Cheers, >>> Mario >>> >>> >>>> On 6/13/2012 2:19 PM, Mario Torre wrote: >>>>> >>>>> Hi all! >>>>> >>>>> I'm trying to compile the latest http://hg.openjdk.java.net/jdk8/awt >>>>> but I got this error: >>>>> >>>>> ompiling >>>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/blockOffsetTable.cpp >>>>> >>>>> >>>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp: >>>>> >>>>> In instantiation of ?TreeList* >>>>> TreeList::remove_chunk_replace_if_needed(TreeChunk*) >>>>> [with Chunk = FreeChunk]?: >>>>> >>>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:1342:16: >>>>> >>>>> required from here >>>>> >>>>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:173:7: >>>>> >>>>> error: ?link_tail? was not declared in this scope, and no >>>>> declarations >>>>> were found by argument-dependent lookup at the point of instantiation >>>>> [-fpermissive] >>>>> >>>>> I guess the tree needs to be integrated with this patch: >>>>> >>>>> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a297b0e14605 >>>>> >>>>> Any ideas? >>>>> >>>>> Cheers, >>>>> Mario >>> >>> >>> >>> -- >>> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF >>> Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF >>> >>> IcedRobot: www.icedrobot.org >>> Proud GNU Classpath developer: http://www.classpath.org/ >>> Read About us at: http://planet.classpath.org >>> OpenJDK: http://openjdk.java.net/projects/caciocavallo/ >>> >>> Please, support open standards: >>> http://endsoftpatents.org/ >>> >> >> From david.katleman at oracle.com Thu Jun 14 00:38:51 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 14 Jun 2012 00:38:51 +0000 Subject: hg: jdk8/build: 4 new changesets Message-ID: <20120614003852.34889478E5@hg.openjdk.java.net> Changeset: dac58047c19f Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/dac58047c19f Added tag jdk8-b42 for changeset 1ce5dc164166 ! .hgtags Changeset: df998cd4d51d Author: sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/df998cd4d51d 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties Changeset: 6aea9b1a3840 Author: lana Date: 2012-06-08 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/6aea9b1a3840 Merge Changeset: 661c9aae602b Author: katleman Date: 2012-06-13 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/661c9aae602b Merge From david.katleman at oracle.com Thu Jun 14 00:38:57 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 14 Jun 2012 00:38:57 +0000 Subject: hg: jdk8/build/corba: 2 new changesets Message-ID: <20120614003859.CE833478E6@hg.openjdk.java.net> Changeset: 4def0723b0b0 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/4def0723b0b0 Added tag jdk8-b42 for changeset 79cc42c9c71b ! .hgtags Changeset: cd879aff5d3c Author: katleman Date: 2012-06-13 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/cd879aff5d3c Merge From david.katleman at oracle.com Thu Jun 14 00:41:28 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 14 Jun 2012 00:41:28 +0000 Subject: hg: jdk8/build/hotspot: Added tag jdk8-b42 for changeset 55954061c6e8 Message-ID: <20120614004132.E3527478E7@hg.openjdk.java.net> Changeset: e77b8e0ed1f8 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e77b8e0ed1f8 Added tag jdk8-b42 for changeset 55954061c6e8 ! .hgtags From david.katleman at oracle.com Thu Jun 14 00:42:55 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 14 Jun 2012 00:42:55 +0000 Subject: hg: jdk8/build/jaxp: 5 new changesets Message-ID: <20120614004311.192F1478E8@hg.openjdk.java.net> Changeset: c73aaf2b0d14 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/c73aaf2b0d14 Added tag jdk8-b42 for changeset 39ee03c16021 ! .hgtags Changeset: 633700642caf Author: joehw Date: 2012-06-07 13:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/633700642caf 7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform subbenchmark Summary: roll back XalanJ-2271 that caused the regression Reviewed-by: lancea ! src/com/sun/org/apache/xml/internal/serializer/CharInfo.java ! src/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java ! src/com/sun/org/apache/xml/internal/serializer/ToStream.java ! src/com/sun/org/apache/xml/internal/serializer/ToXMLStream.java Changeset: 238d2d0249af Author: joehw Date: 2012-06-08 11:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/238d2d0249af 7157608: One feature is not recognized. Summary: adding feature standard-uri-conformant into the recognized list Reviewed-by: psandoz ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java Changeset: b94fad1cb830 Author: lana Date: 2012-06-08 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/b94fad1cb830 Merge Changeset: eff4ece9c8bc Author: katleman Date: 2012-06-13 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/eff4ece9c8bc Merge From david.katleman at oracle.com Thu Jun 14 00:43:16 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 14 Jun 2012 00:43:16 +0000 Subject: hg: jdk8/build/jaxws: 2 new changesets Message-ID: <20120614004322.AA02F478E9@hg.openjdk.java.net> Changeset: 35e0f6001816 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/35e0f6001816 Added tag jdk8-b42 for changeset 1f20f37818a9 ! .hgtags Changeset: f00c12994562 Author: katleman Date: 2012-06-13 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/f00c12994562 Merge From david.katleman at oracle.com Thu Jun 14 00:45:35 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 14 Jun 2012 00:45:35 +0000 Subject: hg: jdk8/build/jdk: 84 new changesets Message-ID: <20120614005951.230EB478EA@hg.openjdk.java.net> Changeset: 8e8fb6500a87 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8e8fb6500a87 Added tag jdk8-b42 for changeset cf5c1f6fbc5b ! .hgtags Changeset: a2d12ca36eb3 Author: bae Date: 2012-05-25 12:56 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a2d12ca36eb3 7146550: [macosx] DnD test failure in createCompatibleWritableRaster() Reviewed-by: kizune, serb ! src/macosx/classes/sun/lwawt/macosx/CDragSourceContextPeer.java ! src/macosx/classes/sun/lwawt/macosx/CImage.java ! src/macosx/native/sun/awt/CDragSource.h ! src/macosx/native/sun/awt/CDragSource.m ! src/macosx/native/sun/awt/CDragSourceContextPeer.m ! test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java Changeset: 23b82fb671d4 Author: lana Date: 2012-05-25 19:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/23b82fb671d4 Merge Changeset: c892ca15ca52 Author: andrew Date: 2012-05-30 16:17 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c892ca15ca52 7171223: Building ExtensionSubtables.cpp should use -fno-strict-aliasing Summary: GCC 4.4+ have stricter aliasing requirements which produces a new warning from this code Reviewed-by: prr, ohair ! make/sun/font/Makefile Changeset: d988ed9d40bc Author: bae Date: 2012-05-31 12:15 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d988ed9d40bc 7120895: FontConfiguration should not use thread contextClassLoader Reviewed-by: igor, prr ! src/share/classes/sun/awt/FontConfiguration.java Changeset: baf734760bd6 Author: lana Date: 2012-06-05 17:56 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/baf734760bd6 Merge Changeset: 563582096868 Author: ohair Date: 2012-06-07 18:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/563582096868 Merge - src/macosx/bin/amd64/jvm.cfg ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 992068b99493 Author: lana Date: 2012-06-08 11:58 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/992068b99493 Merge Changeset: 5ff4693406ad Author: dcherepanov Date: 2012-05-22 12:35 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5ff4693406ad 7160293: [macosx] FileDialog appears on secondary display Reviewed-by: art, bae ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m Changeset: cac4daf60283 Author: zhouyx Date: 2012-05-23 12:37 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cac4daf60283 7170996: IME composition window does not disappear when file dialog is closed : Japanese WinXP Reviewed-by: art, bagiras ! src/windows/native/sun/windows/awt_Component.cpp Changeset: bb3ada9822e4 Author: kizune Date: 2012-05-24 15:11 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bb3ada9822e4 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode Reviewed-by: art, leonidr ! src/solaris/native/java/lang/java_props_md.c Changeset: cd00d68e06ac Author: neugens Date: 2012-05-25 14:16 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cd00d68e06ac 6800513: GTK-LaF renders menus incompletely Reviewed-by: rupashka ! src/share/classes/javax/swing/JPopupMenu.java Changeset: 4b2b963f8774 Author: ant Date: 2012-05-25 20:57 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4b2b963f8774 7171776: one more setGlobalCurrentFocusCycleRoot call requires doPrivileged Reviewed-by: art ! src/share/classes/java/awt/KeyboardFocusManager.java Changeset: bcdb6e5f31cc Author: lana Date: 2012-05-25 13:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bcdb6e5f31cc Merge Changeset: 3c9adc88956d Author: luchsh Date: 2012-05-30 10:58 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3c9adc88956d 7170655: Frame size does not follow font size change with XToolkit Reviewed-by: serb, art ! src/solaris/classes/sun/awt/X11/XLabelPeer.java + test/java/awt/Frame/ResizeAfterSetFont/ResizeAfterSetFont.java Changeset: 14f9e9060370 Author: alexsch Date: 2012-05-30 14:46 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/14f9e9060370 7146131: [macosx] When click the show optionpane button,it display partly of dialog and hung until timeout Reviewed-by: rupashka ! src/macosx/classes/com/apple/laf/AquaInternalFrameUI.java Changeset: e6de02da6870 Author: alexsch Date: 2012-05-30 14:58 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e6de02da6870 7141296: [macosx] Mouse Wheel Turn closes combobox popup Reviewed-by: rupashka ! src/macosx/classes/com/apple/laf/AquaScrollPaneUI.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java Changeset: 8800a98316b2 Author: neugens Date: 2012-05-30 18:15 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8800a98316b2 7171806: Missing test for bug ID 6800513 fix Reviewed-by: rupashka + test/javax/swing/JPopupMenu/6800513/bug6800513.java Changeset: 06a0302856eb Author: leonidr Date: 2012-05-31 20:18 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/06a0302856eb 7150089: [macosx] Default for a custom cursor created from non-existent image is not transparent Reviewed-by: anthony, kizune ! src/macosx/classes/sun/lwawt/macosx/CCustomCursor.java Changeset: fd27852f3ea5 Author: denis Date: 2012-06-01 17:08 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fd27852f3ea5 7112115: Component.getLocationOnScreen() work incorrectly if create window in point (0, 0) on oel Reviewed-by: serb, art + test/javax/swing/JSpinner/5012888/bug5012888.java Changeset: 0526ba7f723b Author: alexsch Date: 2012-06-04 14:11 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0526ba7f723b 7161766: [macosx] javax/swing/JPopupMenu/6694823/bug6694823.java failed on Mac OS X Reviewed-by: rupashka ! test/javax/swing/JPopupMenu/6694823/bug6694823.java Changeset: 79df0a4a6573 Author: omajid Date: 2012-06-04 16:39 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/79df0a4a6573 7043963: AWT workaround missing for Mutter. Reviewed-by: art, anthony Contributed-by: Denis Lila ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XWM.java + test/java/awt/WMSpecificTests/Mutter/MutterMaximizeTest.java ! test/java/awt/regtesthelpers/Util.java Changeset: fc64530a1571 Author: anthony Date: 2012-06-05 15:20 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fc64530a1571 7172722: Latest jdk7u from OSX broke universal build Summary: Add a data memeber for a new property Reviewed-by: serb, swingler ! src/macosx/native/sun/awt/AWTWindow.h Changeset: 5880da7a3628 Author: dcherepanov Date: 2012-06-05 19:48 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5880da7a3628 7123957: Switch of Gnome theme ends up deadlocked in GTKEngine.native_switch_theme Reviewed-by: art, anthony ! src/solaris/native/sun/awt/swing_GTKEngine.c Changeset: 8c6fef8404ea Author: lana Date: 2012-06-05 18:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8c6fef8404ea Merge Changeset: c6075e29ce94 Author: alexsch Date: 2012-06-06 11:54 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c6075e29ce94 7169285: [macosx] Test api/javax_swing/JPopupMenu/descriptions.html#setgetXXX doesn't take Mac main menu Reviewed-by: rupashka ! src/share/classes/javax/swing/JPopupMenu.java Changeset: 6694d9e99716 Author: littlee Date: 2012-06-07 10:22 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6694d9e99716 7174233: Openjdk is missing some key maps on the Japanese keyboards Reviewed-by: anthony, naoto ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/native/sun/xawt/XWindow.c Changeset: 77c92e809c25 Author: alexsch Date: 2012-06-07 18:24 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/77c92e809c25 7152952: [macosx] List rows overlap with enlarged font Reviewed-by: art, rupashka ! src/macosx/classes/sun/lwawt/LWListPeer.java Changeset: f1063002c843 Author: kizune Date: 2012-06-07 20:04 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f1063002c843 7124247: [macosx] Implement GraphicsDevice.setDisplayMode() Reviewed-by: anthony, swingler ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/native/sun/awt/CGraphicsDevice.m Changeset: 05ac5622a2ec Author: kizune Date: 2012-06-07 20:06 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/05ac5622a2ec Merge Changeset: 4acd0211f48b Author: rupashka Date: 2012-06-07 21:49 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4acd0211f48b 7156657: Version 7 doesn't support translucent popup menus against a translucent window Reviewed-by: art, alexsch ! src/share/classes/javax/swing/PopupFactory.java ! src/share/demo/jfc/TransparentRuler/transparentruler/Ruler.java + test/javax/swing/JPopupMenu/7156657/bug7156657.java Changeset: a1d825c477bc Author: alexsch Date: 2012-06-08 14:15 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a1d825c477bc 7092551: Double-click in TextField sets caret to the beginning Reviewed-by: bagiras, serb ! src/windows/native/sun/windows/awt_TextArea.cpp ! src/windows/native/sun/windows/awt_TextArea.h ! src/windows/native/sun/windows/awt_TextComponent.cpp ! src/windows/native/sun/windows/awt_TextComponent.h ! src/windows/native/sun/windows/awt_TextField.cpp ! src/windows/native/sun/windows/awt_TextField.h Changeset: 34ac493d6bea Author: kizune Date: 2012-06-08 22:21 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/34ac493d6bea 7175566: [macosx] Glich in fix for CR7124247 caused MacOS crash during PIT testing Reviewed-by: anthony, dcherepanov ! src/macosx/native/sun/awt/CGraphicsDevice.m Changeset: 3d7be3ac3a99 Author: lana Date: 2012-06-08 12:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3d7be3ac3a99 Merge Changeset: a2fc04c2dfc8 Author: weijun Date: 2012-05-23 15:51 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a2fc04c2dfc8 7162687: enhance KDC server availability detection Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/internal/NetClient.java ! test/ProblemList.txt ! test/sun/security/krb5/auto/BadKdc.java ! test/sun/security/krb5/auto/MaxRetries.java ! test/sun/security/krb5/auto/TcpTimeout.java + test/sun/security/krb5/auto/Unreachable.java + test/sun/security/krb5/auto/unreachable.krb5.conf Changeset: 0c3d9050c918 Author: khazra Date: 2012-05-23 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0c3d9050c918 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8 Summary: Enable Windows Version 6.2 to be recognized as Windows 8 Reviewed-by: darcy, dholmes, alanb, chegar ! src/windows/native/java/lang/java_props_md.c Changeset: 21703d431217 Author: alanb Date: 2012-05-24 10:57 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/21703d431217 7169050: (se) Selector.select slow on Solaris due to insertion of POLLREMOVE and 0 events Reviewed-by: chegar, coffeys ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java ! src/solaris/native/sun/nio/ch/DevPollArrayWrapper.c Changeset: a11c964d1319 Author: jgish Date: 2012-05-24 14:44 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a11c964d1319 7160725: Strange or obsolete @see tags in some exception java.lang javadoc Summary: update javadoc for IllegalArgumentException and NumberFormatException Reviewed-by: alanb ! src/share/classes/java/lang/IllegalArgumentException.java Changeset: 5ec5588c733d Author: nloodin Date: 2012-05-24 09:32 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5ec5588c733d 7143353: -Xrunhprof fails in Java 7 due to bad switch Reviewed-by: jrose, sspitsyn ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c ! src/share/javavm/export/classfile_constants.h Changeset: 1c869c799ef9 Author: nloodin Date: 2012-05-24 10:20 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1c869c799ef9 Merge Changeset: e309917fb9af Author: dbhole Date: 2012-05-24 19:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e309917fb9af 7117230: clean up warnings in java.text Reviewed-by: jrose, smarks ! src/share/classes/java/text/AttributedCharacterIterator.java ! src/share/classes/java/text/AttributedString.java ! src/share/classes/java/text/BreakDictionary.java ! src/share/classes/java/text/BreakIterator.java ! src/share/classes/java/text/CharacterIteratorFieldDelegate.java ! src/share/classes/java/text/ChoiceFormat.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/DateFormat.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DictionaryBasedBreakIterator.java ! src/share/classes/java/text/MergeCollation.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/text/ParseException.java ! src/share/classes/java/text/RBCollationTables.java ! src/share/classes/java/text/RBTableBuilder.java ! src/share/classes/java/text/RuleBasedBreakIterator.java Changeset: 71cf74329a9e Author: youdwei Date: 2012-05-25 13:28 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/71cf74329a9e 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled Reviewed-by: okutsu ! src/windows/native/java/util/TimeZone_md.c + test/java/util/TimeZone/DstTzTest.java Changeset: 85696e57d447 Author: youdwei Date: 2012-05-25 14:32 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/85696e57d447 7171028: dots are missed in the datetime for Slovanian Reviewed-by: yhuang ! src/share/classes/sun/text/resources/FormatData_sl.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 1def6b6bfbd9 Author: egahlin Date: 2012-05-25 12:24 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1def6b6bfbd9 7017818: NLS: JConsoleResources.java cannot be handled by translation team Reviewed-by: mchung, mfang ! make/netbeans/jconsole/build.xml ! make/sun/jconsole/FILES.gmk ! make/sun/jconsole/Makefile ! src/share/classes/sun/tools/jconsole/AboutDialog.java ! src/share/classes/sun/tools/jconsole/BorderedComponent.java ! src/share/classes/sun/tools/jconsole/ClassTab.java ! src/share/classes/sun/tools/jconsole/ConnectDialog.java ! src/share/classes/sun/tools/jconsole/CreateMBeanDialog.java ! src/share/classes/sun/tools/jconsole/Formatter.java ! src/share/classes/sun/tools/jconsole/HTMLPane.java ! src/share/classes/sun/tools/jconsole/InternalDialog.java ! src/share/classes/sun/tools/jconsole/JConsole.java ! src/share/classes/sun/tools/jconsole/LabeledComponent.java ! src/share/classes/sun/tools/jconsole/LocalVirtualMachine.java ! src/share/classes/sun/tools/jconsole/MBeansTab.java ! src/share/classes/sun/tools/jconsole/MaximizableInternalFrame.java ! src/share/classes/sun/tools/jconsole/MemoryPoolProxy.java ! src/share/classes/sun/tools/jconsole/MemoryPoolStat.java ! src/share/classes/sun/tools/jconsole/MemoryTab.java + src/share/classes/sun/tools/jconsole/Messages.java ! src/share/classes/sun/tools/jconsole/OverviewPanel.java ! src/share/classes/sun/tools/jconsole/OverviewTab.java ! src/share/classes/sun/tools/jconsole/Plotter.java ! src/share/classes/sun/tools/jconsole/PlotterPanel.java ! src/share/classes/sun/tools/jconsole/ProxyClient.java ! src/share/classes/sun/tools/jconsole/Resources.java ! src/share/classes/sun/tools/jconsole/SummaryTab.java ! src/share/classes/sun/tools/jconsole/Tab.java ! src/share/classes/sun/tools/jconsole/ThreadTab.java ! src/share/classes/sun/tools/jconsole/VMInternalFrame.java ! src/share/classes/sun/tools/jconsole/VMPanel.java ! src/share/classes/sun/tools/jconsole/VariableGridLayout.java ! src/share/classes/sun/tools/jconsole/Version.java.template ! src/share/classes/sun/tools/jconsole/inspector/OperationEntry.java ! src/share/classes/sun/tools/jconsole/inspector/TableSorter.java ! src/share/classes/sun/tools/jconsole/inspector/ThreadDialog.java ! src/share/classes/sun/tools/jconsole/inspector/Utils.java ! src/share/classes/sun/tools/jconsole/inspector/XArrayDataViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XDataViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanAttributes.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanInfo.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanNotifications.java ! src/share/classes/sun/tools/jconsole/inspector/XObject.java ! src/share/classes/sun/tools/jconsole/inspector/XOpenTypeViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XOperations.java ! src/share/classes/sun/tools/jconsole/inspector/XPlotter.java ! src/share/classes/sun/tools/jconsole/inspector/XPlottingViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XSheet.java ! src/share/classes/sun/tools/jconsole/inspector/XTable.java ! src/share/classes/sun/tools/jconsole/inspector/XTextField.java ! src/share/classes/sun/tools/jconsole/inspector/XTree.java ! src/share/classes/sun/tools/jconsole/inspector/XTreeRenderer.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java + src/share/classes/sun/tools/jconsole/resources/messages.properties + src/share/classes/sun/tools/jconsole/resources/messages_ja.properties + src/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties Changeset: f92325f12654 Author: jgish Date: 2012-05-24 11:11 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f92325f12654 7171474: Incorrect @see tags in java.lang.NumberFormatException javadoc Summary: update javadoc for NumberFormatException Reviewed-by: alanb ! src/share/classes/java/lang/NumberFormatException.java Changeset: 82134992123c Author: dcubed Date: 2012-05-25 08:20 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/82134992123c 7170449: Management is completely broken at least on Solaris 11 X86 Summary: Work around 'gobjcopy' failures on Solaris by adding temporary tools to add the '.gnu_debuglink' section and remove the SHF_ALLOC flag from "empty" section headers. Reviewed-by: sspitsyn, acorn ! make/common/Defs-solaris.gmk ! make/common/Defs.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/tools/Makefile + make/tools/add_gnu_debuglink/Makefile + make/tools/add_gnu_debuglink/add_gnu_debuglink.c + make/tools/fix_empty_sec_hdr_flags/Makefile + make/tools/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c Changeset: 7abdd3cb14ed Author: lana Date: 2012-05-25 16:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7abdd3cb14ed Merge Changeset: 60033ab79213 Author: littlee Date: 2012-05-29 09:42 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/60033ab79213 7172177: test/java/util/TimeZone/DstTzTest.java failing on all platforms Reviewed-by: alanb, okutsu - test/java/util/TimeZone/DstTzTest.java Changeset: eb441933f6fe Author: khazra Date: 2012-05-29 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/eb441933f6fe 7171591: getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c should return a value Summary: Use CHECK_NULL_RETURN instead of CHECK_NULL Reviewed-by: alanb ! src/solaris/native/java/net/net_util_md.c Changeset: 41dcfdbf8f07 Author: ksrini Date: 2012-05-29 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/41dcfdbf8f07 7168401: pack200 does not produce a compatible pack file for JDK7 classes if indy is not present Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java ! test/tools/pack200/PackageVersionTest.java Changeset: 2c773daa825d Author: mduigou Date: 2012-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2c773daa825d 6924259: Remove offset and count fields from java.lang.String Summary: Removes the use of shared character array buffers by String along with the two fields needed to support the use of shared buffers. Reviewed-by: alanb, mduigou, forax, briangoetz Contributed-by: brian.doherty at oracle.com ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringCoding.java Changeset: 43bd5ee0205e Author: mduigou Date: 2012-05-30 22:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/43bd5ee0205e 7126277: Alternative String hashing implementation Summary: All of the hashing based Map implementations: HashMap, Hashtable, LinkedHashMap, WeakHashMap and ConcurrentHashMap are modified to use an enhanced hashing algorithm for string keys when the capacity of the hash table has ever grown beyond 512 entries. The enhanced hashing implementation uses the murmur3 hashing algorithm along with random hash seeds and index masks. These enhancements mitigate cases where colliding String hash values could result in a performance bottleneck. Reviewed-by: alanb, forax, dl ! make/java/java/FILES_java.gmk ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/LinkedHashMap.java ! src/share/classes/java/util/WeakHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java + src/share/classes/sun/misc/Hashing.java ! test/java/util/Collection/BiggernYours.java ! test/java/util/Hashtable/HashCode.java ! test/java/util/Hashtable/SimpleSerialization.java + test/java/util/Map/Collisions.java ! test/java/util/Map/Get.java + test/sun/misc/Hashing.java Changeset: 0c6830e7241f Author: mullan Date: 2012-05-30 17:19 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0c6830e7241f 6854712: Revocation checking enhancements (JEP-124) 6637288: Add OCSP support to PKIX CertPathBuilder implementation 7126011: ReverseBuilder.getMatchingCACerts may throws NPE Reviewed-by: xuelei ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathBuilderSpi.java + src/share/classes/java/security/cert/CertPathChecker.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertPathValidatorSpi.java ! src/share/classes/java/security/cert/PKIXCertPathChecker.java + src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/java/security/cert/package.html ! src/share/classes/sun/security/provider/certpath/AdjacencyList.java ! src/share/classes/sun/security/provider/certpath/BasicChecker.java ! src/share/classes/sun/security/provider/certpath/BuildStep.java ! src/share/classes/sun/security/provider/certpath/Builder.java ! src/share/classes/sun/security/provider/certpath/CertStoreHelper.java ! src/share/classes/sun/security/provider/certpath/CollectionCertStore.java ! src/share/classes/sun/security/provider/certpath/ConstraintsChecker.java - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/IndexedCollectionCertStore.java ! src/share/classes/sun/security/provider/certpath/KeyChecker.java ! src/share/classes/sun/security/provider/certpath/OCSP.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java ! src/share/classes/sun/security/provider/certpath/OCSPRequest.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java + src/share/classes/sun/security/provider/certpath/PKIX.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/PKIXMasterCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/PolicyChecker.java ! src/share/classes/sun/security/provider/certpath/PolicyNodeImpl.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java + src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilderParameters.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/provider/certpath/Vertex.java ! src/share/classes/sun/security/provider/certpath/X509CertPath.java ! src/share/classes/sun/security/provider/certpath/X509CertificatePair.java ! src/share/classes/sun/security/x509/X509CRLEntryImpl.java + test/java/security/cert/PKIXRevocationChecker/UnitTest.java Changeset: 3192e73394fe Author: mullan Date: 2012-05-31 17:07 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3192e73394fe Merge - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java Changeset: 48dfc0df61d0 Author: mullan Date: 2012-05-31 17:10 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/48dfc0df61d0 Merge Changeset: 7baa22e6a6b3 Author: mduigou Date: 2012-06-01 00:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7baa22e6a6b3 7173432: Handle null key at HashMap resize Summary: If the key to be inserted into a HashMap is null and the table needs to be resized as part of the insertion then addEntry will try to recalculate the hash of a null key. This will fail with an NPE. Reviewed-by: darcy ! src/share/classes/java/util/HashMap.java + test/java/util/HashMap/NullKeyAtResize.java Changeset: 237e27c7ddc3 Author: littlee Date: 2012-06-04 16:30 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/237e27c7ddc3 7166055: Javadoc for WeakHashMap contains misleading advice Reviewed-by: dholmes, mduigou ! src/share/classes/java/util/WeakHashMap.java Changeset: a5bb0343f135 Author: weijun Date: 2012-06-04 18:06 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a5bb0343f135 7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected Reviewed-by: alanb ! test/com/sun/jdi/ConnectedVMs.java Changeset: 4573662cb28c Author: zhouyx Date: 2012-06-05 10:16 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4573662cb28c 7173044: MemoryMonitor hangs if getMax method in MemoryUsage object returns -1 Reviewed-by: dholmes, sspitsyn ! src/share/demo/management/MemoryMonitor/MemoryMonitor.java Changeset: 0678af55d3db Author: weijun Date: 2012-06-05 17:11 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0678af55d3db 7172701: KDC tests cleanup Reviewed-by: xuelei ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/OkAsDelegate.java ! test/sun/security/krb5/auto/OkAsDelegateXRealm.java - test/sun/security/krb5/auto/ok-as-delegate-xrealm.sh - test/sun/security/krb5/auto/ok-as-delegate.sh Changeset: 5ea56641276c Author: alanb Date: 2012-06-05 12:47 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5ea56641276c 7173515: (se) Selector.open fails with OOME on Solaris when unlimited file descriptors Reviewed-by: coffeys, chegar - src/share/classes/sun/nio/ch/DevPollSelectorProvider.java ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java + src/solaris/classes/sun/nio/ch/DevPollSelectorProvider.java Changeset: d1f52390275b Author: sherman Date: 2012-06-05 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d1f52390275b 6183404: Many eudc characters are incorrectly mapped in MS936 and GBK converter Summary: updated MS936 and GBK mappings Reviewed-by: alanb ! make/tools/CharsetMapping/GBK.map ! make/tools/CharsetMapping/MS936.map Changeset: 91d05db156d3 Author: lana Date: 2012-06-05 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/91d05db156d3 Merge Changeset: b6eb10d6932f Author: weijun Date: 2012-06-06 10:05 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b6eb10d6932f 7174351: test/sun/security/tools/keytool/standard.sh failed after new Hashtable Reviewed-by: xuelei ! test/sun/security/tools/keytool/KeyToolTest.java Changeset: 119c9a306a3d Author: alanb Date: 2012-06-06 17:59 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/119c9a306a3d 7172826: (se) Selector based on the Solaris event port mechanism Reviewed-by: coffeys, chegar ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/IOUtil.java ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java + src/solaris/classes/sun/nio/ch/EventPortSelectorImpl.java + src/solaris/classes/sun/nio/ch/EventPortSelectorProvider.java + src/solaris/classes/sun/nio/ch/EventPortWrapper.java ! src/solaris/classes/sun/nio/ch/SolarisEventPort.java ! src/solaris/native/sun/nio/ch/DevPollArrayWrapper.c ! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c ! src/solaris/native/sun/nio/ch/IOUtil.c ! src/solaris/native/sun/nio/ch/SolarisEventPort.c ! test/java/nio/channels/Selector/lots_of_updates.sh ! test/java/nio/channels/SocketChannel/Open.sh ! test/sun/nio/ch/SelProvider.java Changeset: af313ded4ffb Author: khazra Date: 2012-06-06 11:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/af313ded4ffb 7173645: (props) System.getProperty("os.name") should return "Windows Server 2012" for Windows Server 2012 Summary: Enable Windows Server 2012 to be recognized as "os.name" Reviewed-by: alanb, dholmes, chegar ! src/windows/native/java/lang/java_props_md.c Changeset: f8e72d7ff37d Author: xuelei Date: 2012-06-06 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f8e72d7ff37d 7174244: NPE in Krb5ProxyImpl.getServerKeys() Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/krb5/Krb5ProxyImpl.java + test/sun/security/ssl/sanity/ciphersuites/CipherSuitesInOrder.java Changeset: 713b10821c3d Author: xuelei Date: 2012-06-06 18:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/713b10821c3d 7172149: ArrayIndexOutOfBoundsException from Signature.verify Summary: take care of integer addition overflow Reviewed-by: xuelei, wetmore Contributed-by: Jonathan Lu ! src/share/classes/java/security/Signature.java + test/java/security/Signature/VerifyRangeCheckOverflow.java Changeset: 181175887d24 Author: jonas Date: 2012-06-06 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/181175887d24 7174861: all/OPT jdk build on Solaris with FDS enabled sets wrong options Summary: Use CFLAGS_COMMON instead of CC_OPT and CXXFLAGS_COMMON instead of CXX_OPT for setting FDS options. FDS should also set OPTIMIZATION_LEVEL. Reviewed-by: ihse, dholmes, ohair, dcubed ! make/common/Defs-solaris.gmk Changeset: 7543b6db3026 Author: dcubed Date: 2012-06-06 19:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7543b6db3026 Merge Changeset: 636f9486fde7 Author: alanb Date: 2012-06-07 10:31 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/636f9486fde7 7175011: ProblemList.txt updates (6/2012) Reviewed-by: mduigou, chegar ! test/ProblemList.txt Changeset: 757a5129fad7 Author: alanb Date: 2012-06-07 12:31 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/757a5129fad7 7164256: EnumMap clone doesn't clear the entrySet keeping a reference to the original Map Reviewed-by: alanb, chegar, forax, mduigou Contributed-by: dbelfer at gmail.com ! src/share/classes/java/util/EnumMap.java + test/java/util/EnumMap/ProperEntrySetOnClone.java Changeset: c89018e3f3b6 Author: nloodin Date: 2012-06-05 13:43 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c89018e3f3b6 7163471: Licensee source bundle failed around 7u4 Reviewed-by: dholmes, sla, brutisso, erikj ! make/com/oracle/Makefile Changeset: 9b814b887240 Author: weijun Date: 2012-06-07 22:33 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9b814b887240 7175041: HttpTimestamper should accept https URI Reviewed-by: mullan ! src/share/classes/sun/security/timestamp/HttpTimestamper.java Changeset: 23f8be788c77 Author: alanb Date: 2012-06-07 18:42 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/23f8be788c77 7174723: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing [win] Reviewed-by: mduigou ! test/java/lang/ProcessBuilder/Basic.java Changeset: fc0e508b713f Author: mduigou Date: 2012-06-07 01:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fc0e508b713f 7174736: JCK test api/java_util/HashMap/index_EntrySet failing Summary: Corrects a problem with HashMap.removeEntry() that caused a JCK test to fail Reviewed-by: mduigou Contributed-by: alan.bateman at oracle.com ! src/share/classes/java/util/HashMap.java Changeset: abe465d6a9b8 Author: chegar Date: 2012-06-08 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/abe465d6a9b8 7175413: Typo in comments of JVM_SupportsCX8 in jvm.h Reviewed-by: chegar Contributed-by: Krystal Mok ! src/share/javavm/export/jvm.h Changeset: 8305ddc88a5a Author: lancea Date: 2012-06-07 20:11 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8305ddc88a5a 7172551: Remove Native calls from DriverManager for jigsaw Reviewed-by: alanb, chegar, darcy, mchung ! make/java/java/FILES_c.gmk ! make/java/java/mapfile-vers ! makefiles/java/java/FILES_c.gmk ! makefiles/java/java/mapfile-vers ! src/share/classes/java/sql/DriverManager.java - src/share/native/java/sql/DriverManager.c Changeset: 7cb7bfae9d3a Author: lancea Date: 2012-06-08 09:22 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7cb7bfae9d3a Merge Changeset: 82c41d3065e2 Author: sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/82c41d3065e2 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties ! test/Makefile Changeset: 961807959c5f Author: sla Date: 2012-06-08 05:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/961807959c5f Merge Changeset: a7895dc61088 Author: robm Date: 2012-06-08 18:23 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a7895dc61088 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true Reviewed-by: alanb, chegar ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java + test/java/nio/channels/DatagramChannel/BindNull.java Changeset: cd195e5d2c07 Author: lana Date: 2012-06-08 12:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cd195e5d2c07 Merge ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java - src/share/classes/sun/nio/ch/DevPollSelectorProvider.java - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java - src/share/native/java/sql/DriverManager.c - test/sun/security/krb5/auto/ok-as-delegate-xrealm.sh - test/sun/security/krb5/auto/ok-as-delegate.sh Changeset: b3246687c369 Author: katleman Date: 2012-06-13 16:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b3246687c369 Merge - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile - makefiles/common/shared/Defs-utils.gmk - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers From david.katleman at oracle.com Thu Jun 14 01:03:01 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 14 Jun 2012 01:03:01 +0000 Subject: hg: jdk8/build/langtools: 9 new changesets Message-ID: <20120614010322.317EB478EB@hg.openjdk.java.net> Changeset: 8280c4f9f619 Author: cl Date: 2012-06-07 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8280c4f9f619 Added tag jdk8-b42 for changeset 02c5a3575539 ! .hgtags Changeset: f5dbd6895994 Author: jjh Date: 2012-05-21 16:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f5dbd6895994 7157798: Add 6 test scenarios for testing inheritance of multiple same-name methods from mulitple interfaces Reviewed-by: mcimadamore Contributed-by: sue.wei at oracle.com + test/tools/javac/generics/rawOverride/7157798/Test1.java + test/tools/javac/generics/rawOverride/7157798/Test2.java + test/tools/javac/generics/rawOverride/7157798/Test3.java + test/tools/javac/generics/rawOverride/7157798/Test3.out + test/tools/javac/generics/rawOverride/7157798/Test4.java + test/tools/javac/generics/rawOverride/7157798/Test4.out Changeset: f43aded513e7 Author: lana Date: 2012-05-25 16:32 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f43aded513e7 Merge Changeset: af6a4c24f4e3 Author: mcimadamore Date: 2012-05-31 17:42 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/af6a4c24f4e3 7166552: Inference: cleanup usage of Type.ForAll Summary: Remove hack to callback into type-inference from assignment context Reviewed-by: dlsmith, jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/ApplicableMethodFound1.java ! test/tools/javac/diags/examples/CantApplyDiamond1.java - test/tools/javac/diags/examples/FullInstSig.java ! test/tools/javac/diags/examples/IncompatibleTypes1.java ! test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/InvalidInferredTypes.java + test/tools/javac/diags/examples/NoUniqueMaximalInstance.java - test/tools/javac/diags/examples/UndeterminedType1.java ! test/tools/javac/diags/examples/WhereFreshTvar.java ! test/tools/javac/generics/7015430/T7015430.out ! test/tools/javac/generics/7151802/T7151802.out ! test/tools/javac/generics/inference/6315770/T6315770.out ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6638712/T6638712e.out ! test/tools/javac/generics/inference/6650759/T6650759m.out ! test/tools/javac/generics/inference/7154127/T7154127.out ! test/tools/javac/varargs/6313164/T6313164.out Changeset: 37dc15c68760 Author: mcimadamore Date: 2012-05-31 17:44 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/37dc15c68760 7160084: javac fails to compile an apparently valid class/interface combination Summary: javac generates wrong syntetized trees for nested enum constants Reviewed-by: dlsmith, jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/enum/7160084/T7160084a.java + test/tools/javac/enum/7160084/T7160084b.java Changeset: 844478076c25 Author: jjh Date: 2012-05-31 15:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/844478076c25 7159016: Static import of member in processor-generated class fails in JDK 7 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/T7159016.java Changeset: 252f8b7473e1 Author: lana Date: 2012-06-05 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/252f8b7473e1 Merge Changeset: e3d0a8fe4318 Author: lana Date: 2012-06-08 12:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e3d0a8fe4318 Merge - test/tools/javac/diags/examples/FullInstSig.java - test/tools/javac/diags/examples/InvalidInferredTypes.java - test/tools/javac/diags/examples/UndeterminedType1.java Changeset: f8c64d835b28 Author: katleman Date: 2012-06-13 16:58 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f8c64d835b28 Merge From tim.bell at oracle.com Thu Jun 14 05:31:31 2012 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 13 Jun 2012 22:31:31 -0700 Subject: RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS Message-ID: <4FD97733.7040409@oracle.com> Hello everyone- Kelly asked me to pick up on bug #/7152336 "//Enable builds on Windows with MinGW/MSYS"/, and this email thread: http://mail.openjdk.java.net/pipermail/build-dev/2012-April/thread.html#6083 As David pointed out, we will need at least one other bug # for the hotspot changes. That said, this is enough to get me started. Hi Volker: I have applied the patches originally from your posting. Many thanks for that: http://cr.openjdk.java.net/~simonis/MinGW_MSYS.v1/ With a few modifications (keep cpio for non MinGW/Msys builds, keep MKS as an option), the proposed changes are visible here for review: http://cr.openjdk.java.net/~tbell/7152336/webrev.00/ For reference, my test build log is visible here: http://cr.openjdk.java.net/~tbell/7152336/webrev.00/full_control_build_no_docs.log Additional test builds on JPRT (our internal build apparatus) verified that I didn't regress the existing build. Abbreviated jtreg [1] testing on this build was successful: $ /d/tools/jdk8/7152336/windows-i586/bin/java -jar /d/tools/jtreg-internal/jtreg/lib/jtreg.jar -automatic -noshell test/java/lang test/java/math test/java/util Directory "JTreport" not found: creating Directory "JTwork" not found: creating Directory "JTwork\scratch" not found: creating Test results: passed: 698; failed: 1; error: 5 Report written to D:\tools\jdk8\7152336\jdk\JTreport\html\report.html Results written to D:\tools\jdk8\7152336\jdk\JTwork Error: Some tests failed or other problems occurred. The failing test (java/lang/Math/WorstCaseTests.java) is due to a known regression: 7174532 "jdk/test/java/lang/Math/WorstCaseTests.java failing on x86" The 5 error tests are all ignored until bug xxxxxxx (for some value of x) is resolved. Thanks in advance for your review and feedback - Tim Bell [1] http://openjdk.java.net/projects/code-tools/ From magnus.ihse.bursie at oracle.com Thu Jun 14 09:12:26 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 14 Jun 2012 11:12:26 +0200 Subject: What is the xawt sizer wrapper, really? Message-ID: <4FD9AAFA.60001@oracle.com> We've had series of recurring issues with the xawt sizer wrapper (as defined in jdk/make/sun/xawt/Makefile) -- we've called it the X11Wrapper, I'm not sure if it has any other, more proper name. First of all, I must ask: what is the purpose of this? Does anybody here know, and can explain? The logic of this makefile is quite convoluted, with multi-step generation and execution. Is this really neccessary? The real problem, from our point of view, is not the complex generate/run/generate scheme -- make handles that for us. The problem is the interaction between the build and target platform, and the reason for having both 32 and 64-bit versions. Appearantly, we build both a 32 and a 64 bit version on some platforms, and then try to execute both. This works with varying degree of success depending on what build OS you're using and how it is configured. :-) Do we really need to do this? And why? Also, for 64-bit solaris we compare the generated file with a checked-in version, and if it differs, the build fail! So in reality, on this platform, we're not really doing real build work, but rather verifying that the build system looks like expected. But this is something that should be done in configure, rather as part of the build. If this is the real reason for this wrapper, could we perhaps generate these sizes-files for all platforms and check them in, and just verify them as part of configure? /Magnus (who have been working hard with the X11Wrapper for quite some time and still is totally confused about it's purpose and workings) From artem.ananiev at oracle.com Thu Jun 14 10:49:50 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Thu, 14 Jun 2012 14:49:50 +0400 Subject: Fwd: What is the xawt sizer wrapper, really? In-Reply-To: <4FD9BCBB.6080304@oracle.com> References: <4FD9AAFA.60001@oracle.com> <4FD9BCBB.6080304@oracle.com> Message-ID: <4FD9C1CE.1020801@oracle.com> Hi, Magnus, (Please, keep me in CC as I'm not subscribed to this alias) in XAWT, we don't have much native code. Xlib routines are called via sun.awt.X11.XlibWrapper, and Xlib structures are accessed via Unsafe + wrapper classes. For example, there is no XWMHints.java in the workspace: it's generated in build-time based on the information from sun/awt/X11/generator/xlibtypes. Generation process include creating a new sizer.c file for each structure described in "xlibtypes", compiling it and calling the resulted binary to get offsets for all the structure fields. Then a new Java class is generated with a number of get_* and set_* methods, which are implemented as calls to Native (which is Unsafe internally). Here are a few method from auto-generated XWMHints.java: public long get_flags() { log.finest("");return (Native.getLong(pData+0)); } public void set_flags(long v) { log.finest(""); Native.putLong(pData+0, v); } public int get_initial_state() { log.finest("");return (Native.getInt(pData+12)); } public void set_initial_state(int v) { log.finest(""); Native.putInt(pData+12, v); } I don't remember the exact issue about Solaris-x64, why it's handled separately and includes manual generation. What are exact issues you observe with the wrapper generator? Thanks, Artem > We've had series of recurring issues with the xawt sizer wrapper (as > defined in jdk/make/sun/xawt/Makefile) -- we've called it the > X11Wrapper, I'm not sure if it has any other, more proper name. > > First of all, I must ask: what is the purpose of this? Does anybody here > know, and can explain? > > The logic of this makefile is quite convoluted, with multi-step > generation and execution. Is this really neccessary? > > The real problem, from our point of view, is not the complex > generate/run/generate scheme -- make handles that for us. The problem is > the interaction between the build and target platform, and the reason > for having both 32 and 64-bit versions. > > Appearantly, we build both a 32 and a 64 bit version on some platforms, > and then try to execute both. This works with varying degree of success > depending on what build OS you're using and how it is configured. :-) > > Do we really need to do this? And why? > > Also, for 64-bit solaris we compare the generated file with a checked-in > version, and if it differs, the build fail! So in reality, on this > platform, we're not really doing real build work, but rather verifying > that the build system looks like expected. But this is something that > should be done in configure, rather as part of the build. If this is the > real reason for this wrapper, could we perhaps generate these > sizes-files for all platforms and check them in, and just verify them as > part of configure? > > /Magnus > (who have been working hard with the X11Wrapper for quite some time and > still is totally confused about it's purpose and workings) From magnus.ihse.bursie at oracle.com Thu Jun 14 11:01:16 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 14 Jun 2012 13:01:16 +0200 Subject: Fwd: What is the xawt sizer wrapper, really? In-Reply-To: <4FD9C1CE.1020801@oracle.com> References: <4FD9AAFA.60001@oracle.com> <4FD9BCBB.6080304@oracle.com> <4FD9C1CE.1020801@oracle.com> Message-ID: <4FD9C47C.3060407@oracle.com> On 2012-06-14 12:49, Artem Ananiev wrote: > > > Generation process include creating a new sizer.c file for each > structure described in "xlibtypes", compiling it and calling the > resulted binary to get offsets for all the structure fields. How is this supposed to work when cross-compiling? And why do you need to to this for another platform than the one we are compiling for? (E.g., if we are generating a 64-bit macosx build, we also do this for 32-bit macosx) > I don't remember the exact issue about Solaris-x64, why it's handled > separately and includes manual generation. The information I was able to dig up indicated that the weirdness of how this was compiled had caused breakage previously, and this was added as some kind of regression test. (It was appearantly designed to catch the error of compiling with 64-bit when 32-bit was intended, or vice versa -- or something like that). > What are exact issues you observe with the wrapper generator? Portability and cross-compilations issues. The main problem is: why is it compiled for anything else than the build platform? If it is supposed to just run on the build system, why do we need more than one? And if it is supposed to run on the target system (!), then it will not work when cross-compiling. /Magnus From david.holmes at oracle.com Thu Jun 14 11:52:20 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 14 Jun 2012 21:52:20 +1000 Subject: What is the xawt sizer wrapper, really? In-Reply-To: <4FD9AAFA.60001@oracle.com> References: <4FD9AAFA.60001@oracle.com> Message-ID: <4FD9D074.9040208@oracle.com> Hi Magnus, Yes I've also run afoul of this when cross-compiling - mostly recently when we started doing 32-bit cross-compiles (for arm) on 64-bit x86. As I understand this, sizers is to X11 Java code what the UnixConstants program is to the filesystem code. It has to determine various sizes of native data structures used by X11 so that those values can be handled correctly in the Java code (storing pointer and offsets in Java code to pass ot native). Unlike the UnixConstants these values only seem to differ between 32-bit and 64-bit, not across different OS, so our cross-compilation can use the data produced by sizers executing on the build host. (For UnixConstants we did have to bypass when cross-compiling and have generated Java classes checked in the repo - which isn't satisfactory either. David On 14/06/2012 7:12 PM, Magnus Ihse Bursie wrote: > We've had series of recurring issues with the xawt sizer wrapper (as > defined in jdk/make/sun/xawt/Makefile) -- we've called it the > X11Wrapper, I'm not sure if it has any other, more proper name. > > First of all, I must ask: what is the purpose of this? Does anybody here > know, and can explain? > > The logic of this makefile is quite convoluted, with multi-step > generation and execution. Is this really neccessary? > > The real problem, from our point of view, is not the complex > generate/run/generate scheme -- make handles that for us. The problem is > the interaction between the build and target platform, and the reason > for having both 32 and 64-bit versions. > > Appearantly, we build both a 32 and a 64 bit version on some platforms, > and then try to execute both. This works with varying degree of success > depending on what build OS you're using and how it is configured. :-) > > Do we really need to do this? And why? > > Also, for 64-bit solaris we compare the generated file with a checked-in > version, and if it differs, the build fail! So in reality, on this > platform, we're not really doing real build work, but rather verifying > that the build system looks like expected. But this is something that > should be done in configure, rather as part of the build. If this is the > real reason for this wrapper, could we perhaps generate these > sizes-files for all platforms and check them in, and just verify them as > part of configure? > > /Magnus > (who have been working hard with the X11Wrapper for quite some time and > still is totally confused about it's purpose and workings) > From magnus.ihse.bursie at oracle.com Thu Jun 14 12:10:21 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 14 Jun 2012 14:10:21 +0200 Subject: What is the xawt sizer wrapper, really? In-Reply-To: <4FD9D074.9040208@oracle.com> References: <4FD9AAFA.60001@oracle.com> <4FD9D074.9040208@oracle.com> Message-ID: <4FD9D4AD.1080309@oracle.com> On 2012-06-14 13:52, David Holmes wrote: > As I understand this, sizers is to X11 Java code what the > UnixConstants program is to the filesystem code. It has to determine > various sizes of native data structures used by X11 so that those > values can be handled correctly in the Java code (storing pointer and > offsets in Java code to pass ot native). Unlike the UnixConstants > these values only seem to differ between 32-bit and 64-bit, not across > different OS To me it sounds like two checked in files, sizes-32.data and sizes-64.data, or whatever the names should be. And perhaps a script to re-generate those if the need should ever arise. But that need not be run as part of the build process. Anyone against such a solution? /Magnus From david.holmes at oracle.com Thu Jun 14 12:14:56 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 14 Jun 2012 22:14:56 +1000 Subject: What is the xawt sizer wrapper, really? In-Reply-To: <4FD9D4AD.1080309@oracle.com> References: <4FD9AAFA.60001@oracle.com> <4FD9D074.9040208@oracle.com> <4FD9D4AD.1080309@oracle.com> Message-ID: <4FD9D5C0.4060005@oracle.com> On 14/06/2012 10:10 PM, Magnus Ihse Bursie wrote: > On 2012-06-14 13:52, David Holmes wrote: >> As I understand this, sizers is to X11 Java code what the >> UnixConstants program is to the filesystem code. It has to determine >> various sizes of native data structures used by X11 so that those >> values can be handled correctly in the Java code (storing pointer and >> offsets in Java code to pass ot native). Unlike the UnixConstants >> these values only seem to differ between 32-bit and 64-bit, not across >> different OS > > To me it sounds like two checked in files, sizes-32.data and > sizes-64.data, or whatever the names should be. And perhaps a script to > re-generate those if the need should ever arise. But that need not be > run as part of the build process. > > Anyone against such a solution? That's something for Artem and other AWT folk to consider. As I said we manage to work with this for cross-compiling by simply building and running on the build host to get the data for the target (which as far as I know is not OS specific - but I don't have absolute confirmation on that). The only glitch we had was that when we started cross-compiling on 64-bit linux it generated 64-bit data for a 32-bit target (oops!) - but that was easily fixed. David > /Magnus From volker.simonis at gmail.com Thu Jun 14 16:17:55 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 14 Jun 2012 18:17:55 +0200 Subject: RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS In-Reply-To: <4FD97733.7040409@oracle.com> References: <4FD97733.7040409@oracle.com> Message-ID: Hi Tim, I'm really happy to see that you are now taking care of this! The link to the referenced e-mail thread doesn't seem to work, so here's an alternative link: "RFR (M): Enable OpenJDK builds on Windows with MinGW/MSYS" http://old.nabble.com/RFR-%28M%29%3A-Enable-OpenJDK-builds-on-Windows-with-MinGW-MSYS-td33466599.html And yet another link to an older mail thread which gives some background information and finally led to the proposed MinGW change: "Is anyone able to build on Win 7" http://old.nabble.com/Is-anyone-able-to-build-on-Win-7-td33196055.html Regards, Volker On Thu, Jun 14, 2012 at 7:31 AM, Tim Bell wrote: > Hello everyone- > > Kelly asked me to pick up on bug #/7152336 "//Enable builds on Windows with > MinGW/MSYS"/, and this email thread: > > http://mail.openjdk.java.net/pipermail/build-dev/2012-April/thread.html#6083 > > As David pointed out, we will need at least one other bug # for the hotspot > changes. ?That said, this is enough to get me started. > > Hi Volker: > > I have applied the patches originally from your posting. ?Many thanks for > that: > http://cr.openjdk.java.net/~simonis/MinGW_MSYS.v1/ > > With a few modifications (keep cpio for non MinGW/Msys builds, keep MKS as > an option), the proposed changes are visible here for review: > > ?http://cr.openjdk.java.net/~tbell/7152336/webrev.00/ > > For reference, my test build log is visible here: > > http://cr.openjdk.java.net/~tbell/7152336/webrev.00/full_control_build_no_docs.log > > Additional test builds on JPRT (our internal build apparatus) verified that > I didn't regress the existing build. > > Abbreviated jtreg [1] testing on this build was successful: > > $ /d/tools/jdk8/7152336/windows-i586/bin/java -jar > /d/tools/jtreg-internal/jtreg/lib/jtreg.jar -automatic -noshell > test/java/lang test/java/math test/java/util > Directory "JTreport" not found: creating > Directory "JTwork" not found: creating > Directory "JTwork\scratch" not found: creating > Test results: passed: 698; failed: 1; error: 5 > Report written to D:\tools\jdk8\7152336\jdk\JTreport\html\report.html > Results written to D:\tools\jdk8\7152336\jdk\JTwork > Error: Some tests failed or other problems occurred. > > The failing test (java/lang/Math/WorstCaseTests.java) is due to a known > regression: 7174532 > > "jdk/test/java/lang/Math/WorstCaseTests.java failing on x86" > > The 5 error tests are all ignored until bug xxxxxxx (for some value of x) is > resolved. > > Thanks in advance for your review and feedback - > > Tim Bell > > [1] ?http://openjdk.java.net/projects/code-tools/ > From mikael.gerdin at oracle.com Wed Jun 13 17:12:38 2012 From: mikael.gerdin at oracle.com (Mikael Gerdin) Date: Wed, 13 Jun 2012 19:12:38 +0200 Subject: : JDK8 build fails in hotspot (hsx/hotspot-main/hotspot/rev/a297b0e14605 patch?) In-Reply-To: <4FD8C527.3070303@oracle.com> References: <4FD8C527.3070303@oracle.com> Message-ID: <4FD8CA06.7020302@oracle.com> Lana, This is indeed an issue with HotSpot and GCC 4.7. It's fixed by http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/a297b0e14605 I'm not sure when this will end up in jdk8 master but I think the change will be in hs24-b14. /Mikael On 2012-06-13 18:51, Lana Steuck wrote: > Forwarding Mario's email: > > First, he got a build failure in 8/awt, then he tried building 8/jdk8 - > same problem. > JDK8 build fails in hotspot. > >>> ompiling >>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/blockOffsetTable.cpp >>> >>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp: >>> In instantiation of ?TreeList* >>> TreeList::remove_chunk_replace_if_needed(TreeChunk*) >>> [with Chunk = FreeChunk]?: >>> >>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:1342:16: >>> required from here >>> >>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:173:7: >>> error: ?link_tail? was not declared in this scope, and no declarations >>> were found by argument-dependent lookup at the point of instantiation >>> [-fpermissive] > > > He thinks: > >>> I guess the tree needs to be integrated with this patch: >>> >>>http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a297b0e14605 > > Could this be a problem in his build environment? > > - Lana > > -------- Original Message -------- > Subject: Re: JDK8 tree fails to compile > Date: Wed, 13 Jun 2012 14:17:05 +0200 > From: Mario Torre > To: Anthony Petrov > CC: awt-dev at openjdk.java.net, Lana Steuck > > > Hi Anthony, Lana, > > Thanks for taking a look at it. > > I got the same problem with the very latest jdk8 repository. It seems > that this patch is missing there too. > > I'm on a Fedora 17 machine, gcc version 4.7.0 20120507 (Red Hat > 4.7.0-5) (GCC), perhaps this would explain why you don't see this? > (It's the first time I tried to compile directly from the OpenJDK > since I updated, so I can't say when this started to happen). > > Cheers, > Mario > > >> On 6/13/2012 2:19 PM, Mario Torre wrote: >>> >>> Hi all! >>> >>> I'm trying to compile the latest http://hg.openjdk.java.net/jdk8/awt >>> but I got this error: >>> >>> ompiling >>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/blockOffsetTable.cpp >>> >>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp: >>> In instantiation of ?TreeList* >>> TreeList::remove_chunk_replace_if_needed(TreeChunk*) >>> [with Chunk = FreeChunk]?: >>> >>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:1342:16: >>> required from here >>> >>> /home/neugens/work_space/jdk/jdk8-awt/hotspot/src/share/vm/memory/binaryTreeDictionary.cpp:173:7: >>> error: ?link_tail? was not declared in this scope, and no declarations >>> were found by argument-dependent lookup at the point of instantiation >>> [-fpermissive] >>> >>> I guess the tree needs to be integrated with this patch: >>> >>> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/rev/a297b0e14605 >>> >>> Any ideas? >>> >>> Cheers, >>> Mario > > > > -- > pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF > Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF > > IcedRobot: www.icedrobot.org > Proud GNU Classpath developer: http://www.classpath.org/ > Read About us at: http://planet.classpath.org > OpenJDK: http://openjdk.java.net/projects/caciocavallo/ > > Please, support open standards: > http://endsoftpatents.org/ > From david.holmes at oracle.com Fri Jun 15 23:59:29 2012 From: david.holmes at oracle.com (David Holmes) Date: Sat, 16 Jun 2012 09:59:29 +1000 Subject: Make assistance needed: make tries to create missing included make files Message-ID: <4FDBCC61.8070406@oracle.com> Here's the situation. We add a -include for a possibly non-existent custom makefile, eg foo.make. When the file isn't present the build tries to build the precompiled headers - Huh! ??? This is due to the following: 1. If "-include foo.make" fails to find foo.make it tries to create it. For this it runs through all the implicit rules and for example sees if it can create foo.make.o, foo.make.c etc. 2. top.make defines the following implicit rule: %.o %.i %.s: $(UpdatePCH) $(MAKE) -f vm.make $(MFLAGS) $@ #$(MAKE) -f vm.make $@ so this rule is executed to try and generate foo.make.o/i/s and so we try to create the precompiled headers. In a simple test it seemed that adding .PHONY: foo.make would fix the problem. But on the full hotspot build it didn't work. Still investigating if we made a mistake somewhere in how we did this. Other way to fix, I think, is to define some kind of rule for .make files so that the implicit rules are no longer applied. I'm not sure how to do that though. Anyone have any suggestions? Thanks, David From kelly.ohair at oracle.com Sat Jun 16 00:33:45 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 15 Jun 2012 17:33:45 -0700 Subject: Make assistance needed: make tries to create missing included make files In-Reply-To: <4FDBCC61.8070406@oracle.com> References: <4FDBCC61.8070406@oracle.com> Message-ID: foo.make: @if [ !-f foo.make ] ; then \ echo "foo.make cannot be found"; \ fi -include foo.make Just a thought. Defining a rule should get rid of the implicit search. -kto On Jun 15, 2012, at 4:59 PM, David Holmes wrote: > Here's the situation. We add a -include for a possibly non-existent custom makefile, eg foo.make. When the file isn't present the build tries to build the precompiled headers - Huh! ??? > > This is due to the following: > > 1. If "-include foo.make" fails to find foo.make it tries to create it. For this it runs through all the implicit rules and for example sees if it can create foo.make.o, foo.make.c etc. > > 2. top.make defines the following implicit rule: > > %.o %.i %.s: > $(UpdatePCH) > $(MAKE) -f vm.make $(MFLAGS) $@ > #$(MAKE) -f vm.make $@ > > so this rule is executed to try and generate foo.make.o/i/s and so we try to create the precompiled headers. > > In a simple test it seemed that adding > > .PHONY: foo.make > > would fix the problem. But on the full hotspot build it didn't work. Still investigating if we made a mistake somewhere in how we did this. > > Other way to fix, I think, is to define some kind of rule for .make files so that the implicit rules are no longer applied. I'm not sure how to do that though. > > Anyone have any suggestions? > > Thanks, > David From peter.brunet at oracle.com Sat Jun 16 16:36:06 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Sat, 16 Jun 2012 11:36:06 -0500 Subject: Mercurial error: No module named HTMLParser Message-ID: <4FDCB5F6.7050406@oracle.com> When using hg commands I always get: *** failed to import extension defpath from C:\Users\Pete\hg-extensions\defpath\defpath.py: No module named HTMLParser I am using cygwin 1.7.0 (instead of the latest due to needing to run on Windows 7). I tried adding the following to my environment variables but that didn't help. which/where indicates python is at this location. PYTHONHOME=C:\Program Files\Python27 PYTHONPATH=C:\Program Files\Python27;C:\Program Files\Python27\Lib If I type: python /cygdrive/c/Users/Pete/hg-extensions/defpath/defpath.py I get python.exe: can't open file '/cygdrive/c/Users/Pete/hg-extensions/defpath/defpath.py' [Errno 2] No such file or directory If I type ll /cygdrive/c/Users/Pete/hg-extensions/defpath/defpath.py that file is there (and the rights are 700). If I use python -v I see lots of "can't create" messages. If I run cygwin "as administrator" I don't see the "can't create" messages when using python -v but I still get the Errno 2 failure. Also running hg within an "as adminstrator" cygwin doesn't help. Does anyone have any ideas? Pete From tim.bell at oracle.com Sat Jun 16 17:32:49 2012 From: tim.bell at oracle.com (Tim Bell) Date: Sat, 16 Jun 2012 10:32:49 -0700 Subject: Mercurial error: No module named HTMLParser In-Reply-To: <4FDCB5F6.7050406@oracle.com> References: <4FDCB5F6.7050406@oracle.com> Message-ID: <4FDCC341.7050500@oracle.com> On 06/16/12 09:36, Pete Brunet wrote: > When using hg commands I always get: > > *** failed to import extension defpath from > C:\Users\Pete\hg-extensions\defpath\defpath.py: No module named HTMLParser > > I am using cygwin 1.7.0 (instead of the latest due to needing to run on > Windows 7). Did this hg and python come with your Cygwin install? Cygwin-aware programs expect Cygwin style paths, with /cygdrive/... and ':' separating the elements of a search path. > I tried adding the following to my environment variables but that didn't > help. which/where indicates python is at this location. > PYTHONHOME=C:\Program Files\Python27 > PYTHONPATH=C:\Program Files\Python27;C:\Program Files\Python27\Lib This is what a traditional Windows program would expect, but Cygwin programs won't understand the ':' and '\' characters > If I type: > python /cygdrive/c/Users/Pete/hg-extensions/defpath/defpath.py > I get > python.exe: can't open file > '/cygdrive/c/Users/Pete/hg-extensions/defpath/defpath.py' [Errno 2] No > such file or directory What happens when you run the Windows equivalent command line: python c:/Users/Pete/hg-extensions/defpath/defpath.py > If I type > ll /cygdrive/c/Users/Pete/hg-extensions/defpath/defpath.py > that file is there (and the rights are 700). > > If I use python -v I see lots of "can't create" messages. During what? An 'hg clone' operation, or something else?. Can't create output files, or .pyc files, or what files where? > cygwin "as administrator" I don't see the "can't create" messages when > using python -v but I still get the Errno 2 failure. Also running hg > within an "as adminstrator" cygwin doesn't help. > > Does anyone have any ideas? Does your windows login have 'Administrator' privileges? If not, you probably want to grant yourself 'Administrator' before proceeding. Hope this helps- Tim From peter.brunet at oracle.com Sat Jun 16 20:27:29 2012 From: peter.brunet at oracle.com (Pete Brunet) Date: Sat, 16 Jun 2012 15:27:29 -0500 Subject: Mercurial error: No module named HTMLParser In-Reply-To: <4FDCC341.7050500@oracle.com> References: <4FDCB5F6.7050406@oracle.com> <4FDCC341.7050500@oracle.com> Message-ID: <4FDCEC31.6060506@oracle.com> Thanks for the feedback Tim. On 6/16/12 12:32 PM, Tim Bell wrote: > On 06/16/12 09:36, Pete Brunet wrote: >> When using hg commands I always get: >> >> *** failed to import extension defpath from >> C:\Users\Pete\hg-extensions\defpath\defpath.py: No module named >> HTMLParser >> >> I am using cygwin 1.7.0 (instead of the latest due to needing to run on >> Windows 7). > > Did this hg and python come with your Cygwin install? Python was not installed with cygwin, but I just did that. which/where indicate python is now running from the cygwin tree. (I checked that after changing ~/.hgrc to use cygwin style paths and removing some environment variables as described below.) The error changed from No module named HTMLParser to No such file or directory for defpath.py and jcheck.py. However, ls shows that those file are there. > > Cygwin-aware programs expect Cygwin style paths, with /cygdrive/... > and ':' separating the elements of a search path. I changed ~/.hgrc to the cygwin style paths but that didn't help. > >> I tried adding the following to my environment variables but that didn't >> help. which/where indicates python is at this location. >> PYTHONHOME=C:\Program Files\Python27 >> PYTHONPATH=C:\Program Files\Python27;C:\Program Files\Python27\Lib > > This is what a traditional Windows program would expect, but Cygwin > programs won't understand the ':' and '\' characters I removed PYTHONHOME and PYTHONPATH from my system env vars (I've never needed them in the path) but that didn't help. (I also removed it from my PATH.) > >> If I type: >> python /cygdrive/c/Users/Pete/hg-extensions/defpath/defpath.py >> I get >> python.exe: can't open file >> '/cygdrive/c/Users/Pete/hg-extensions/defpath/defpath.py' [Errno 2] No >> such file or directory > > What happens when you run the Windows equivalent command line: > > python c:/Users/Pete/hg-extensions/defpath/defpath.py >From c:\Users\Pete and typing \python \defpath.py gives ImportError: No module named mercurial. > > >> If I type >> ll /cygdrive/c/Users/Pete/hg-extensions/defpath/defpath.py >> that file is there (and the rights are 700). >> >> If I use python -v I see lots of "can't create" messages. > > During what? An 'hg clone' operation, or something else?. Can't > create output files, or .pyc files, or what files where? python -v ...\defpath.py > >> cygwin "as administrator" I don't see the "can't create" messages when >> using python -v but I still get the Errno 2 failure. Also running hg >> within an "as adminstrator" cygwin doesn't help. >> >> Does anyone have any ideas? > > Does your windows login have 'Administrator' privileges? If not, you > probably want to grant yourself 'Administrator' before proceeding. It's Win 7 so even an Admin doesn't really have admin privileges, but typically when I start my cygwin sessions I don't run them as "as administrator". This has worked in the past. Note that I was off doing JavaFX work for a while and when I came back to work on 7udev I forgot about needing cygwin 1.7.0 for builds so I installed 1.7.15 (latest) and other than build I had no problems. In order to get my build to work I renamed my old 1.7.0 cygwin tree to cygwin and then the build worked, but now mercurial isn't work for me as described in my posts of today. Maybe I need to use cygwin 1.7.0 for builds and 1.7.15 for everything else. > > Hope this helps- > > Tim > From david.holmes at oracle.com Sun Jun 17 11:55:59 2012 From: david.holmes at oracle.com (David Holmes) Date: Sun, 17 Jun 2012 21:55:59 +1000 Subject: Make assistance needed: make tries to create missing included make files In-Reply-To: References: <4FDBCC61.8070406@oracle.com> Message-ID: <4FDDC5CF.5090704@oracle.com> On 16/06/2012 10:33 AM, Kelly O'Hair wrote: > foo.make: > @if [ !-f foo.make ] ; then \ > echo "foo.make cannot be found"; \ > fi > > -include foo.make > > Just a thought. Defining a rule should get rid of the implicit search. Yeah, that's pretty ugly though and noisy. Seems silly to me that -include actually attempts to build the missing file when the - indicates it isn't always expected to be there. Should be a simple way to say "don't try to make it". I would also hope that a simpler rule eg maybe: %.make: would disable the use of the implicit rules, without needing a per file existence check. Thanks, David > -kto > > On Jun 15, 2012, at 4:59 PM, David Holmes wrote: > >> Here's the situation. We add a -include for a possibly non-existent custom makefile, eg foo.make. When the file isn't present the build tries to build the precompiled headers - Huh! ??? >> >> This is due to the following: >> >> 1. If "-include foo.make" fails to find foo.make it tries to create it. For this it runs through all the implicit rules and for example sees if it can create foo.make.o, foo.make.c etc. >> >> 2. top.make defines the following implicit rule: >> >> %.o %.i %.s: >> $(UpdatePCH) >> $(MAKE) -f vm.make $(MFLAGS) $@ >> #$(MAKE) -f vm.make $@ >> >> so this rule is executed to try and generate foo.make.o/i/s and so we try to create the precompiled headers. >> >> In a simple test it seemed that adding >> >> .PHONY: foo.make >> >> would fix the problem. But on the full hotspot build it didn't work. Still investigating if we made a mistake somewhere in how we did this. >> >> Other way to fix, I think, is to define some kind of rule for .make files so that the implicit rules are no longer applied. I'm not sure how to do that though. >> >> Anyone have any suggestions? >> >> Thanks, >> David > From aph at redhat.com Mon Jun 18 17:25:57 2012 From: aph at redhat.com (Andrew Haley) Date: Mon, 18 Jun 2012 18:25:57 +0100 Subject: README-builds.html Message-ID: <4FDF64A5.8000607@redhat.com> The README-builds.html instructions say... Slow Builds: ... Creating the javadocs can be very slow, if you are running javadoc, consider skipping that step. But there is no information I can find about how to skip that step: I think it's NO_DOCS=true. Andrew. From chris.hegarty at oracle.com Mon Jun 18 17:57:45 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 18 Jun 2012 18:57:45 +0100 Subject: README-builds.html In-Reply-To: <4FDF64A5.8000607@redhat.com> References: <4FDF64A5.8000607@redhat.com> Message-ID: <4FDF6C19.10806@oracle.com> On 18/06/2012 18:25, Andrew Haley wrote: > The README-builds.html instructions say... > > Slow Builds: > > ... > > Creating the javadocs can be very slow, if you are running > javadoc, consider skipping that step. > > But there is no information I can find about how to skip that step: I > think it's NO_DOCS=true. Right, good catch. I always build with NO_DOCS=true, can save quite a bit of time on a slow machine. Docs should be updated. -Chris. > > Andrew. From tim.bell at oracle.com Mon Jun 18 18:14:19 2012 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 18 Jun 2012 11:14:19 -0700 Subject: README-builds.html In-Reply-To: <4FDF64A5.8000607@redhat.com> References: <4FDF64A5.8000607@redhat.com> Message-ID: <4FDF6FFB.6000300@oracle.com> On 06/18/12 10:25, Andrew Haley wrote: > The README-builds.html instructions say... > > Slow Builds: > > ... > > Creating the javadocs can be very slow, if you are running > javadoc, consider skipping that step. > > But there is no information I can find about how to skip that step: I > think it's NO_DOCS=true. Look in make/jdk-rules.gmk lines 40 ... 44 40 # GENERATE_DOCS determines if we ask for the docs target 41 DOCS_TARGET = docs 42 ifeq ($(GENERATE_DOCS),false) 43 DOCS_TARGET = 44 endif If you do not want docs generated, add "GENERATE_DOCS=false" to your make command. In case you decide to generate docs at some point, I suggest using a build system with plenty of RAM and increasing max heap size during the build. The default -Xmx of '612m' is too small for javadoc. Specify a value along the lines of MAX_VM_MEMORY=2048 or larger if you have the resources. Hope this helps- Tim From maurizio.cimadamore at oracle.com Tue Jun 19 09:48:33 2012 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 19 Jun 2012 10:48:33 +0100 Subject: What is the xawt sizer wrapper, really? In-Reply-To: <4FD9D5C0.4060005@oracle.com> References: <4FD9AAFA.60001@oracle.com> <4FD9D074.9040208@oracle.com> <4FD9D4AD.1080309@oracle.com> <4FD9D5C0.4060005@oracle.com> Message-ID: <4FE04AF1.3030103@oracle.com> On 14/06/12 13:14, David Holmes wrote: > On 14/06/2012 10:10 PM, Magnus Ihse Bursie wrote: >> On 2012-06-14 13:52, David Holmes wrote: >>> As I understand this, sizers is to X11 Java code what the >>> UnixConstants program is to the filesystem code. It has to determine >>> various sizes of native data structures used by X11 so that those >>> values can be handled correctly in the Java code (storing pointer and >>> offsets in Java code to pass ot native). Unlike the UnixConstants >>> these values only seem to differ between 32-bit and 64-bit, not across >>> different OS >> >> To me it sounds like two checked in files, sizes-32.data and >> sizes-64.data, or whatever the names should be. And perhaps a script to >> re-generate those if the need should ever arise. But that need not be >> run as part of the build process. >> >> Anyone against such a solution? > > That's something for Artem and other AWT folk to consider. > > As I said we manage to work with this for cross-compiling by simply > building and running on the build host to get the data for the target > (which as far as I know is not OS specific - but I don't have absolute > confirmation on that). The only glitch we had was that when we started > cross-compiling on 64-bit linux it generated 64-bit data for a 32-bit > target (oops!) - but that was easily fixed. > > David I'm getting a build failure that might be related to this - I'm getting this in JPRT only on Solaris-x64: solaris_x64_5.10-product (details from log file) /net/backpack.us.oracle.com/archives/jprt/2012/06/2012-06-19-085801.maurizio.tl/logs/solaris_x64_5.10-product.log http://bus2001067.us.oracle.com/archives/2012/06/2012-06-19-085801.maurizio.tl//logs/solaris_x64_5.10-product.log > XColor.red 8 > XColor.green 10 > XColor.blue 12 > XColor.flags 14 > XColor.pad 15 > XColor 16 > XTextProperty.value 0 > XTextProperty.encoding 8 > XTextProperty.format 16 > XTextProperty.nitems 24 > XTextProperty 32 make[4]: *** [/tmp/jprt/P1/085801.maurizio/s/build/solaris-amd64/gensrc/sun/awt/X11/generator/sizes.64] Error 1 I got this when I submitted a control JPRT job against TL which recently integrated some changes from the AWT repo - might this be related? Thanks Maurizio > >> /Magnus -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.holmes at oracle.com Tue Jun 19 11:18:25 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 19 Jun 2012 21:18:25 +1000 Subject: What is the xawt sizer wrapper, really? In-Reply-To: <4FE04AF1.3030103@oracle.com> References: <4FD9AAFA.60001@oracle.com> <4FD9D074.9040208@oracle.com> <4FD9D4AD.1080309@oracle.com> <4FD9D5C0.4060005@oracle.com> <4FE04AF1.3030103@oracle.com> Message-ID: <4FE06001.2010501@oracle.com> On 19/06/2012 7:48 PM, Maurizio Cimadamore wrote: > On 14/06/12 13:14, David Holmes wrote: >> On 14/06/2012 10:10 PM, Magnus Ihse Bursie wrote: >>> On 2012-06-14 13:52, David Holmes wrote: >>>> As I understand this, sizers is to X11 Java code what the >>>> UnixConstants program is to the filesystem code. It has to determine >>>> various sizes of native data structures used by X11 so that those >>>> values can be handled correctly in the Java code (storing pointer and >>>> offsets in Java code to pass ot native). Unlike the UnixConstants >>>> these values only seem to differ between 32-bit and 64-bit, not across >>>> different OS >>> >>> To me it sounds like two checked in files, sizes-32.data and >>> sizes-64.data, or whatever the names should be. And perhaps a script to >>> re-generate those if the need should ever arise. But that need not be >>> run as part of the build process. >>> >>> Anyone against such a solution? >> >> That's something for Artem and other AWT folk to consider. >> >> As I said we manage to work with this for cross-compiling by simply >> building and running on the build host to get the data for the target >> (which as far as I know is not OS specific - but I don't have absolute >> confirmation on that). The only glitch we had was that when we started >> cross-compiling on 64-bit linux it generated 64-bit data for a 32-bit >> target (oops!) - but that was easily fixed. >> >> David > I'm getting a build failure that might be related to this - I'm getting > this in JPRT only on Solaris-x64: > > solaris_x64_5.10-product (details from log file) > /net/backpack.us.oracle.com/archives/jprt/2012/06/2012-06-19-085801.maurizio.tl/logs/solaris_x64_5.10-product.log > http://bus2001067.us.oracle.com/archives/2012/06/2012-06-19-085801.maurizio.tl//logs/solaris_x64_5.10-product.log >> XColor.red 8 >> XColor.green 10 >> XColor.blue 12 >> XColor.flags 14 >> XColor.pad 15 >> XColor 16 >> XTextProperty.value 0 >> XTextProperty.encoding 8 >> XTextProperty.format 16 >> XTextProperty.nitems 24 >> XTextProperty 32 > make[4]: *** [/tmp/jprt/P1/085801.maurizio/s/build/solaris-amd64/gensrc/sun/awt/X11/generator/sizes.64] Error 1 > > > I got this when I submitted a control JPRT job against TL which recently > integrated some changes from the AWT repo - might this be related? I can't speak to any AWT changes. I modified the makefile to deal with cross-compilation situations. But the above appears to be a crash of the process doing the comparison of the two lists ??? David ----- > Thanks > Maurizio >> >>> /Magnus > From maurizio.cimadamore at oracle.com Tue Jun 19 12:17:14 2012 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 19 Jun 2012 13:17:14 +0100 Subject: What is the xawt sizer wrapper, really? In-Reply-To: <4FE06001.2010501@oracle.com> References: <4FD9AAFA.60001@oracle.com> <4FD9D074.9040208@oracle.com> <4FD9D4AD.1080309@oracle.com> <4FD9D5C0.4060005@oracle.com> <4FE04AF1.3030103@oracle.com> <4FE06001.2010501@oracle.com> Message-ID: <4FE06DCA.8080305@oracle.com> On 19/06/12 12:18, David Holmes wrote: > On 19/06/2012 7:48 PM, Maurizio Cimadamore wrote: >> On 14/06/12 13:14, David Holmes wrote: >>> On 14/06/2012 10:10 PM, Magnus Ihse Bursie wrote: >>>> On 2012-06-14 13:52, David Holmes wrote: >>>>> As I understand this, sizers is to X11 Java code what the >>>>> UnixConstants program is to the filesystem code. It has to determine >>>>> various sizes of native data structures used by X11 so that those >>>>> values can be handled correctly in the Java code (storing pointer and >>>>> offsets in Java code to pass ot native). Unlike the UnixConstants >>>>> these values only seem to differ between 32-bit and 64-bit, not >>>>> across >>>>> different OS >>>> >>>> To me it sounds like two checked in files, sizes-32.data and >>>> sizes-64.data, or whatever the names should be. And perhaps a >>>> script to >>>> re-generate those if the need should ever arise. But that need not be >>>> run as part of the build process. >>>> >>>> Anyone against such a solution? >>> >>> That's something for Artem and other AWT folk to consider. >>> >>> As I said we manage to work with this for cross-compiling by simply >>> building and running on the build host to get the data for the target >>> (which as far as I know is not OS specific - but I don't have absolute >>> confirmation on that). The only glitch we had was that when we started >>> cross-compiling on 64-bit linux it generated 64-bit data for a 32-bit >>> target (oops!) - but that was easily fixed. >>> >>> David >> I'm getting a build failure that might be related to this - I'm getting >> this in JPRT only on Solaris-x64: >> >> solaris_x64_5.10-product (details from log file) >> /net/backpack.us.oracle.com/archives/jprt/2012/06/2012-06-19-085801.maurizio.tl/logs/solaris_x64_5.10-product.log >> >> http://bus2001067.us.oracle.com/archives/2012/06/2012-06-19-085801.maurizio.tl//logs/solaris_x64_5.10-product.log >> >>> XColor.red 8 >>> XColor.green 10 >>> XColor.blue 12 >>> XColor.flags 14 >>> XColor.pad 15 >>> XColor 16 >>> XTextProperty.value 0 >>> XTextProperty.encoding 8 >>> XTextProperty.format 16 >>> XTextProperty.nitems 24 >>> XTextProperty 32 >> make[4]: *** >> [/tmp/jprt/P1/085801.maurizio/s/build/solaris-amd64/gensrc/sun/awt/X11/generator/sizes.64] >> Error 1 >> >> >> I got this when I submitted a control JPRT job against TL which recently >> integrated some changes from the AWT repo - might this be related? > > I can't speak to any AWT changes. I modified the makefile to deal with > cross-compilation situations. But the above appears to be a crash of > the process doing the comparison of the two lists ??? The build failure seems to be repeatable on Solaris x64 on a vanilla TL repo. Maurizio > > David > ----- > > > >> Thanks >> Maurizio >>> >>>> /Magnus >> From artem.ananiev at oracle.com Tue Jun 19 17:05:31 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 19 Jun 2012 21:05:31 +0400 Subject: Fwd: What is the xawt sizer wrapper, really? In-Reply-To: <4FD9C47C.3060407@oracle.com> References: <4FD9AAFA.60001@oracle.com> <4FD9BCBB.6080304@oracle.com> <4FD9C1CE.1020801@oracle.com> <4FD9C47C.3060407@oracle.com> Message-ID: <4FE0B15B.2020900@oracle.com> Hi, guys, unfortunately, not many of the current AWT engineers can provide valuable information on the wrapper generator. Many thanks to Yuri (in CC), he digged up the following bug: 6185483: AMD64: xawt 32-bit build should not require running a 64-bit executable It's hidden on bugs.sun.com, unfortunately. In a few words, on Solaris, we used to build single rt.jar for both 32- and 64-bit platforms, because we couldn't have two rt.jar files in solaris-i586 and solaris-amd64. So we had to build rt.jar on 32-bit platform, which at that time lacked support for cross-compilation for 64-bits (Solaris 8, Solaris Studio 8 didn't support 64-bit code generation for x86). Another problem was that when we introduced support for solaris-amd64, we followed the same pattern as with solaris-sparc/sparcv9. At the promotion time, 32-bit image was copied over 64-bit one - that was fine for sparc/sparcv9, as the files were actually the same, but different in i586/amd64 case. Decision was made to calculate 64-bit field offsets in advance and store them in the workspace, so we can have 32/64 classes. There was another discussion a few years ago about the same topic, but I don't remember any details. Most likely we decided to leave sizes.64 as is... Given that we now build using SS12, we should check if we can drop sizes.64 and calculate 64-bit offsets the same way as we do for 32-bits. Thanks, Artem On 6/14/2012 3:01 PM, Magnus Ihse Bursie wrote: > On 2012-06-14 12:49, Artem Ananiev wrote: >> >> >> Generation process include creating a new sizer.c file for each >> structure described in "xlibtypes", compiling it and calling the >> resulted binary to get offsets for all the structure fields. > > How is this supposed to work when cross-compiling? > > And why do you need to to this for another platform than the one we are > compiling for? (E.g., if we are generating a 64-bit macosx build, we > also do this for 32-bit macosx) > >> I don't remember the exact issue about Solaris-x64, why it's handled >> separately and includes manual generation. > The information I was able to dig up indicated that the weirdness of how > this was compiled had caused breakage previously, and this was added as > some kind of regression test. (It was appearantly designed to catch the > error of compiling with 64-bit when 32-bit was intended, or vice versa > -- or something like that). >> What are exact issues you observe with the wrapper generator? > > Portability and cross-compilations issues. The main problem is: why is > it compiled for anything else than the build platform? If it is supposed > to just run on the build system, why do we need more than one? And if it > is supposed to run on the target system (!), then it will not work when > cross-compiling. > > /Magnus From daniel.daugherty at oracle.com Wed Jun 20 01:21:18 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 19 Jun 2012 19:21:18 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) Message-ID: <4FE1258E.8070200@oracle.com> Greetings, This is an URGENT code review request for a Solaris specific Full Debug Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol files and related '_g' symlinks are created in the wrong sub-directory for a couple of the dtrace libraries. The incorrect paths have a double "64/" sub-directory, e.g.: solaris-/jre/lib//client/64/64/libjvm_db.debuginfo These are the correct symlink paths: solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo and these are the correct debug info file paths: solaris-/jre/lib//client/64/libjvm_db.debuginfo solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo solaris-/jre/lib//server/64/libjvm_db.debuginfo solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" and "sparcv9") don't have this issue because they don't have the "64/" sub-directories. This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve an issue that is preventing Oracle's Release Engineering scripts from running properly. Here is the webrev URL for the HSX-24/JDK8 version: http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ The HSX23.3/JDK7u6 version is the same except for the changes to make/solaris/makefiles/defs.make which are not needed in HSX23.2. Thanks, in advance, for any reviews! Dan From kelly.ohair at oracle.com Wed Jun 20 01:36:03 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Wed, 20 Jun 2012 01:36:03 +0000 Subject: hg: jdk8/build: 7178241: Basic script for JDK source code legal headers conformance verification Message-ID: <20120620013603.C5E2747A12@hg.openjdk.java.net> Changeset: 8fb4cd2f05a1 Author: mbykov Date: 2012-06-19 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/8fb4cd2f05a1 7178241: Basic script for JDK source code legal headers conformance verification Summary: A new script lic_check.sh to check license headers in JDK source code Reviewed-by: ohair, darcy Contributed-by: misha.bykov at oracle.com + make/scripts/lic_check.sh From kelly.ohair at oracle.com Wed Jun 20 01:58:21 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 19 Jun 2012 18:58:21 -0700 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE1258E.8070200@oracle.com> References: <4FE1258E.8070200@oracle.com> Message-ID: 130 ( set -e ; \ 131 cd 64 ; \ 132 $(QUIETLY) $(ADD_GNU_DEBUGLINK) \ 133 $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \ 134 ) Would be better as: 130 ( cd 64 && $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ) And making GENERATED a full path scares me. That variable is used all over the place. Are we sure all uses are ok being full paths? And shouldn't this 64 directory name be in a variable to make it more obvious? Maybe LIBJVM_DIRNAME64=64? Is this a last minute change that is expected to be extremely low risk? Doesn't feel low risk. :^( Sorry. -kto On Jun 19, 2012, at 6:21 PM, Daniel D. Daugherty wrote: > Greetings, > > This is an URGENT code review request for a Solaris specific Full Debug > Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol > files and related '_g' symlinks are created in the wrong sub-directory > for a couple of the dtrace libraries. The incorrect paths have a double > "64/" sub-directory, e.g.: > > solaris-/jre/lib//client/64/64/libjvm_db.debuginfo > > These are the correct symlink paths: > > solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo > solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo > solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo > solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo > > and these are the correct debug info file paths: > > solaris-/jre/lib//client/64/libjvm_db.debuginfo > solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo > solaris-/jre/lib//server/64/libjvm_db.debuginfo > solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo > solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo > solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo > solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo > solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo > > where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" > and "sparcv9") don't have this issue because they don't have the "64/" > sub-directories. > > This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve > an issue that is preventing Oracle's Release Engineering scripts from > running properly. > > Here is the webrev URL for the HSX-24/JDK8 version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ > > The HSX23.3/JDK7u6 version is the same except for the changes to > make/solaris/makefiles/defs.make which are not needed in HSX23.2. > > Thanks, in advance, for any reviews! > > Dan From weijun.wang at oracle.com Wed Jun 20 02:04:11 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 20 Jun 2012 10:04:11 +0800 Subject: hg: jdk8/build: 7178241: Basic script for JDK source code legal headers conformance verification In-Reply-To: <20120620013603.C5E2747A12@hg.openjdk.java.net> References: <20120620013603.C5E2747A12@hg.openjdk.java.net> Message-ID: <4FE12F9B.30301@oracle.com> I see a tiny issue with the script: 200 if [ -s ${tmpfile} ] ; then 201 diff -c ${tmpfile} ${template_dir}/${header} 1>&2 202 if [ "$?" = "0" ] ; then 203 echo "SUCCESS: The license header for "`pwd`"/"$1" has been verified." 204 echo "###" 205 else 206 echo "ERROR: License header is not correct in "`pwd`"/"$1 1>&2 207 echo "See diffs above. " 1>&2 208 echo "###" 1>&2 209 echo "" 1>&2 210 error_status=1 211 fi Here, there is a blank line after ERROR but none for SUCCESS. Thanks Max /20/2012 09:36 AM, kelly.ohair at oracle.com wrote: > Changeset: 8fb4cd2f05a1 > Author: mbykov > Date: 2012-06-19 14:24 -0700 > URL: http://hg.openjdk.java.net/jdk8/build/rev/8fb4cd2f05a1 > > 7178241: Basic script for JDK source code legal headers conformance verification > Summary: A new script lic_check.sh to check license headers in JDK source code > Reviewed-by: ohair, darcy > Contributed-by: misha.bykov at oracle.com > > + make/scripts/lic_check.sh > From david.holmes at oracle.com Wed Jun 20 02:06:04 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 20 Jun 2012 12:06:04 +1000 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE1258E.8070200@oracle.com> References: <4FE1258E.8070200@oracle.com> Message-ID: <4FE1300C.6020107@oracle.com> Hi Dan, It would be nice if the cd into the 64 directory could be handled internally to the link logic rather than occurring at the top-level (I say this as someone who will need to hand merge this into another workspace ;-) ). Also in make/solaris/makefiles/add_gnu_debuglink.make I don't understand the logic change: GENERATED = ../generated becomes TOPDIR = $(shell echo `pwd`) GENERATED = $(TOPDIR)/../generated but at what time is "pwd" evaluated? If we have: /out/lib/64 and originally we started in lib then GENERATED==lib/../generated ie out/generated. If we have now done a cd into 64 then: pwd = /out/lib/64 and so GENERATED==/out/lib/64/../generated ie /out/lib/generated. I may well be missing something but this doesn't seem right. David ----- On 20/06/2012 11:21 AM, Daniel D. Daugherty wrote: > Greetings, > > This is an URGENT code review request for a Solaris specific Full Debug > Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol > files and related '_g' symlinks are created in the wrong sub-directory > for a couple of the dtrace libraries. The incorrect paths have a double > "64/" sub-directory, e.g.: > > solaris-/jre/lib//client/64/64/libjvm_db.debuginfo > > These are the correct symlink paths: > > solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo > solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo > solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo > solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo > > and these are the correct debug info file paths: > > solaris-/jre/lib//client/64/libjvm_db.debuginfo > solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo > solaris-/jre/lib//server/64/libjvm_db.debuginfo > solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo > solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo > solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo > solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo > solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo > > where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" > and "sparcv9") don't have this issue because they don't have the "64/" > sub-directories. > > This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve > an issue that is preventing Oracle's Release Engineering scripts from > running properly. > > Here is the webrev URL for the HSX-24/JDK8 version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ > > The HSX23.3/JDK7u6 version is the same except for the changes to > make/solaris/makefiles/defs.make which are not needed in HSX23.2. > > Thanks, in advance, for any reviews! > > Dan From kelly.ohair at oracle.com Wed Jun 20 02:51:46 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 19 Jun 2012 19:51:46 -0700 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE1300C.6020107@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1300C.6020107@oracle.com> Message-ID: <7FD1D173-7D65-4895-995F-AF21B9216D4D@oracle.com> And TOPDIR might be a variable used in the top level JDK Makefiles, referring to the top of the forest. :^( So the TOPDIR name needs to be more unique I think. -kto On Jun 19, 2012, at 7:06 PM, David Holmes wrote: > Hi Dan, > > It would be nice if the cd into the 64 directory could be handled internally to the link logic rather than occurring at the top-level (I say this as someone who will need to hand merge this into another workspace ;-) ). > > Also in make/solaris/makefiles/add_gnu_debuglink.make I don't understand the logic change: > > GENERATED = ../generated > > becomes > > TOPDIR = $(shell echo `pwd`) > GENERATED = $(TOPDIR)/../generated > > but at what time is "pwd" evaluated? If we have: /out/lib/64 and originally we started in lib then GENERATED==lib/../generated ie out/generated. If we have now done a cd into 64 then: pwd = /out/lib/64 and so GENERATED==/out/lib/64/../generated ie /out/lib/generated. I may well be missing something but this doesn't seem right. > > David > ----- > > On 20/06/2012 11:21 AM, Daniel D. Daugherty wrote: >> Greetings, >> >> This is an URGENT code review request for a Solaris specific Full Debug >> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol >> files and related '_g' symlinks are created in the wrong sub-directory >> for a couple of the dtrace libraries. The incorrect paths have a double >> "64/" sub-directory, e.g.: >> >> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >> >> These are the correct symlink paths: >> >> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >> >> and these are the correct debug info file paths: >> >> solaris-/jre/lib//client/64/libjvm_db.debuginfo >> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >> solaris-/jre/lib//server/64/libjvm_db.debuginfo >> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >> >> where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" >> and "sparcv9") don't have this issue because they don't have the "64/" >> sub-directories. >> >> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve >> an issue that is preventing Oracle's Release Engineering scripts from >> running properly. >> >> Here is the webrev URL for the HSX-24/JDK8 version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >> >> The HSX23.3/JDK7u6 version is the same except for the changes to >> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >> >> Thanks, in advance, for any reviews! >> >> Dan From daniel.daugherty at oracle.com Wed Jun 20 03:15:13 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 19 Jun 2012 21:15:13 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: References: <4FE1258E.8070200@oracle.com> Message-ID: <4FE14041.7020409@oracle.com> Thanks for the quick review! On 6/19/12 7:58 PM, Kelly O'Hair wrote: > 130 ( set -e ; \ > 131 cd 64 ; \ > 132 $(QUIETLY) $(ADD_GNU_DEBUGLINK) \ > 133 $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \ > 134 ) > Would be better as: > 130 ( cd 64&& $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ) The "set -e" was your idea in another FDS fix. :-) You wanted the sub-shell to die if something went wrong which would return an error to the outer make. I do like dropping the "$(QUIETLY)" though. > And making GENERATED a full path scares me. That variable is used all over the place. > Are we sure all uses are ok being full paths? There's good news and bad news about the GENERATED variable in HotSpot Makefiles. :-) But you know this already... somewhere in the back of your mind... you remember seeing this insanity... The good news is that Linux and BSD pretty much do this: 27 TOPDIR = $(shell echo `pwd`) 28 GENERATED = $(TOPDIR)/../generated in most of their HotSpot Makefiles. Solaris, on the other hand, did not do this before, but I'm adding it in a limited way now. Why do I say "limited way"? Well... that's the bad news... Most of the HotSpot Makefiles set the GENERATED variable all on their own... And since vm.make includes most of the other HotSpot Makefiles, you get GENERATED set to various values as the various Makefiles are included... Has this made you ill yet?? What does all this mean? Well it means that GENERATED will be set to a full path for when add_gnu_debuglink.make and when fix_empty_sec_hdr_flags.make are included. Which means that both ADD_GNU_DEBUGLINK and FIX_EMPTY_SEC_HDR_FLAGS will be set to full paths which means they can be called from anywhere. As soon as one of the other HotSpot Makefiles that sets GENERATED to "../generated" is included, then GENERATED goes back and in the context of that HotSpot Makefile (and beyond), the paths are relative again. Insane you say? You betcha, but please remember that I didn't write this GENERATED variable insanity... I'm just making it work. FIX_EMPTY_SEC_HDR_FLAGS isn't called from anywhere where we did a "cd" so that change isn't strictly necessary. I could drop it without worry. Until someone else does something with it from some sub-directory somewhere and wonders why the heck the command can't be found. Yes, that's what happened to me today... > And shouldn't this 64 directory name be in a variable to make it more obvious? > Maybe LIBJVM_DIRNAME64=64? To be consistent, I should name it XLIBJVM_DIRNAME to match all the other 64/... variable names. Yes, I used a literal "64" because I'm getting tired of this FDS and Makefile crap. I can fix that also. Do you want all the variables that use 64/... to switch to this new variable? Seems like a lot of changes, but if I don't, then it'll be inconsistent. Your call. > Is this a last minute change that is expected to be extremely low risk? Doesn't feel low risk. :^( Sorry. To make it more low risk, I could drop the changes to fix_empty_sec_hdr_flags.make. That would make the GENERATED variable a full-path for the include of add_gnu_debuglink.make and for the setting of ADD_GNU_DEBUGLINK. That would be it for a full-path GENERATED value on Solaris. I've updated my monster ck_fds_jprt_job script to look into .diz ZIP archives and verify that they don't use path elements. The HSX-24 and HSX-23.2 test jobs that I ran earlier today pass the latest ck_fds_jprt_job script without error. I haven't done "hotspot + jdk" control jobs or "hotspot + everything else" control jobs yet. But since the bug was with the contents of the ".diz" file and did not show up until the .diz files were extracted by the intall repo, I'm not too worried about the control jobs. I will run them since I want to update my database of FDS test results, but I don't think they are critical. To address your review, I plan to: - drop the "$(QUIETLY)" - drop the changes to fix_empty_sec_hdr_flags.make - add the XLIBJVM_DIRNAME=64 variable and use it in the new code or in all uses of 64/... (Kelly's choice) Please let me know if this resolves your issues with the changes. And, thanks again for the quick review! Dan > -kto > > On Jun 19, 2012, at 6:21 PM, Daniel D. Daugherty wrote: > >> Greetings, >> >> This is an URGENT code review request for a Solaris specific Full Debug >> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol >> files and related '_g' symlinks are created in the wrong sub-directory >> for a couple of the dtrace libraries. The incorrect paths have a double >> "64/" sub-directory, e.g.: >> >> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >> >> These are the correct symlink paths: >> >> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >> >> and these are the correct debug info file paths: >> >> solaris-/jre/lib//client/64/libjvm_db.debuginfo >> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >> solaris-/jre/lib//server/64/libjvm_db.debuginfo >> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >> >> where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" >> and "sparcv9") don't have this issue because they don't have the "64/" >> sub-directories. >> >> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve >> an issue that is preventing Oracle's Release Engineering scripts from >> running properly. >> >> Here is the webrev URL for the HSX-24/JDK8 version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >> >> The HSX23.3/JDK7u6 version is the same except for the changes to >> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >> >> Thanks, in advance, for any reviews! >> >> Dan From daniel.daugherty at oracle.com Wed Jun 20 03:23:38 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 19 Jun 2012 21:23:38 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE1300C.6020107@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1300C.6020107@oracle.com> Message-ID: <4FE1423A.8050808@oracle.com> Thanks for the quick review! On 6/19/12 8:06 PM, David Holmes wrote: > Hi Dan, > > It would be nice if the cd into the 64 directory could be handled > internally to the link logic rather than occurring at the top-level (I > say this as someone who will need to hand merge this into another > workspace ;-) ). I'm not quite sure what you mean by this: "the cd into the 64 directory could be handled internally to the link logic rather than occurring at the top-level". This isn't "at the top-level". It's in the dtrace.make subsidiary Makefile and it only happens for the context of the subshell. The problem is that ADD_GNU_DEBUGLINK and the ZIP_EXE need to be done in the 64 directory, but nothing else in that crazy Makefile logic does need to be done in the 64 directory. > Also in make/solaris/makefiles/add_gnu_debuglink.make I don't > understand the logic change: > > GENERATED = ../generated > > becomes > > TOPDIR = $(shell echo `pwd`) > GENERATED = $(TOPDIR)/../generated > > but at what time is "pwd" evaluated? If we have: /out/lib/64 and > originally we started in lib then GENERATED==lib/../generated ie > out/generated. If we have now done a cd into 64 then: pwd = > /out/lib/64 and so GENERATED==/out/lib/64/../generated ie > /out/lib/generated. I may well be missing something but this doesn't > seem right. Please see the very long answer that I gave Kelly about the GENERATED variable and HotSpot Makefiles. In particular, the TOPDIR followed by the setting of GENERATED is used in the Linux and BSD HotSpot makefiles (most of them anyway)... I'll wait to see what you can clarify about the "top-level" comment above before I try to resolve this any further... Dan > > David > ----- > > On 20/06/2012 11:21 AM, Daniel D. Daugherty wrote: >> Greetings, >> >> This is an URGENT code review request for a Solaris specific Full Debug >> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol >> files and related '_g' symlinks are created in the wrong sub-directory >> for a couple of the dtrace libraries. The incorrect paths have a double >> "64/" sub-directory, e.g.: >> >> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >> >> These are the correct symlink paths: >> >> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >> >> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >> >> >> and these are the correct debug info file paths: >> >> solaris-/jre/lib//client/64/libjvm_db.debuginfo >> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >> solaris-/jre/lib//server/64/libjvm_db.debuginfo >> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >> >> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >> >> >> where "" is "i586" or "sparc". The 64-bit Solaris platforms >> ("amd64" >> and "sparcv9") don't have this issue because they don't have the "64/" >> sub-directories. >> >> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve >> an issue that is preventing Oracle's Release Engineering scripts from >> running properly. >> >> Here is the webrev URL for the HSX-24/JDK8 version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >> >> The HSX23.3/JDK7u6 version is the same except for the changes to >> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >> >> Thanks, in advance, for any reviews! >> >> Dan From daniel.daugherty at oracle.com Wed Jun 20 03:24:34 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 19 Jun 2012 21:24:34 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <7FD1D173-7D65-4895-995F-AF21B9216D4D@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1300C.6020107@oracle.com> <7FD1D173-7D65-4895-995F-AF21B9216D4D@oracle.com> Message-ID: <4FE14272.4070701@oracle.com> TOPDIR is also used in other HotSpot Makefiles so my usage here is consistent. Dan On 6/19/12 8:51 PM, Kelly O'Hair wrote: > And TOPDIR might be a variable used in the top level JDK Makefiles, referring to the top of the forest. :^( > So the TOPDIR name needs to be more unique I think. > > -kto > > On Jun 19, 2012, at 7:06 PM, David Holmes wrote: > >> Hi Dan, >> >> It would be nice if the cd into the 64 directory could be handled internally to the link logic rather than occurring at the top-level (I say this as someone who will need to hand merge this into another workspace ;-) ). >> >> Also in make/solaris/makefiles/add_gnu_debuglink.make I don't understand the logic change: >> >> GENERATED = ../generated >> >> becomes >> >> TOPDIR = $(shell echo `pwd`) >> GENERATED = $(TOPDIR)/../generated >> >> but at what time is "pwd" evaluated? If we have: /out/lib/64 and originally we started in lib then GENERATED==lib/../generated ie out/generated. If we have now done a cd into 64 then: pwd = /out/lib/64 and so GENERATED==/out/lib/64/../generated ie /out/lib/generated. I may well be missing something but this doesn't seem right. >> >> David >> ----- >> >> On 20/06/2012 11:21 AM, Daniel D. Daugherty wrote: >>> Greetings, >>> >>> This is an URGENT code review request for a Solaris specific Full Debug >>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol >>> files and related '_g' symlinks are created in the wrong sub-directory >>> for a couple of the dtrace libraries. The incorrect paths have a double >>> "64/" sub-directory, e.g.: >>> >>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>> >>> These are the correct symlink paths: >>> >>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>> >>> and these are the correct debug info file paths: >>> >>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>> >>> where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" >>> and "sparcv9") don't have this issue because they don't have the "64/" >>> sub-directories. >>> >>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve >>> an issue that is preventing Oracle's Release Engineering scripts from >>> running properly. >>> >>> Here is the webrev URL for the HSX-24/JDK8 version: >>> >>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>> >>> The HSX23.3/JDK7u6 version is the same except for the changes to >>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>> >>> Thanks, in advance, for any reviews! >>> >>> Dan From david.holmes at oracle.com Wed Jun 20 03:37:43 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 20 Jun 2012 13:37:43 +1000 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE1423A.8050808@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1300C.6020107@oracle.com> <4FE1423A.8050808@oracle.com> Message-ID: <4FE14587.2020207@oracle.com> On 20/06/2012 1:23 PM, Daniel D. Daugherty wrote: > Thanks for the quick review! You said it was urgent ;-) > On 6/19/12 8:06 PM, David Holmes wrote: >> It would be nice if the cd into the 64 directory could be handled >> internally to the link logic rather than occurring at the top-level (I >> say this as someone who will need to hand merge this into another >> workspace ;-) ). > > I'm not quite sure what you mean by this: "the cd into the 64 directory > could be handled internally to the link logic rather than occurring at > the top-level". > > This isn't "at the top-level". It's in the dtrace.make subsidiary > Makefile and it only happens for the context of the subshell. > > The problem is that ADD_GNU_DEBUGLINK and the ZIP_EXE need to be > done in the 64 directory, but nothing else in that crazy Makefile > logic does need to be done in the 64 directory. I "simply" meant doing the "cd 64" inside the ADD_GNU_DEBUGLINK logic rather than in the makefile that invokes that logic. That said I can live with Kelly's shorter form. >> Also in make/solaris/makefiles/add_gnu_debuglink.make I don't >> understand the logic change: >> >> GENERATED = ../generated >> >> becomes >> >> TOPDIR = $(shell echo `pwd`) >> GENERATED = $(TOPDIR)/../generated >> >> but at what time is "pwd" evaluated? If we have: /out/lib/64 and >> originally we started in lib then GENERATED==lib/../generated ie >> out/generated. If we have now done a cd into 64 then: pwd = >> /out/lib/64 and so GENERATED==/out/lib/64/../generated ie >> /out/lib/generated. I may well be missing something but this doesn't >> seem right. > > Please see the very long answer that I gave Kelly about the GENERATED > variable and HotSpot Makefiles. In particular, the TOPDIR followed > by the setting of GENERATED is used in the Linux and BSD HotSpot > makefiles (most of them anyway)... > > I'll wait to see what you can clarify about the "top-level" comment > above before I try to resolve this any further... I read the long answer and yes it is complex. As I recently had to untangle this for other reasons you (ie the hotspot developer cursed to modify the build system) need to be aware that we effectively have three levels of "make" invocations when building hotspot: - "top level" Makefile or /Makefile - buildtree.make sub-make - make of the makefiles generated by buildtree.make determining which files get included at each level, and which variables get passed through the submakes is complex. Lazy evaluation of variables adds to the complexity. That all said, it still seems to me that the logic for GENERATED is not correct if you have done a cd into the 64 subdirectory. Cheers, David > Dan > > > >> >> David >> ----- >> >> On 20/06/2012 11:21 AM, Daniel D. Daugherty wrote: >>> Greetings, >>> >>> This is an URGENT code review request for a Solaris specific Full Debug >>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol >>> files and related '_g' symlinks are created in the wrong sub-directory >>> for a couple of the dtrace libraries. The incorrect paths have a double >>> "64/" sub-directory, e.g.: >>> >>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>> >>> These are the correct symlink paths: >>> >>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>> >>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>> >>> >>> and these are the correct debug info file paths: >>> >>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>> >>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>> >>> >>> where "" is "i586" or "sparc". The 64-bit Solaris platforms >>> ("amd64" >>> and "sparcv9") don't have this issue because they don't have the "64/" >>> sub-directories. >>> >>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve >>> an issue that is preventing Oracle's Release Engineering scripts from >>> running properly. >>> >>> Here is the webrev URL for the HSX-24/JDK8 version: >>> >>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>> >>> The HSX23.3/JDK7u6 version is the same except for the changes to >>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>> >>> Thanks, in advance, for any reviews! >>> >>> Dan From daniel.daugherty at oracle.com Wed Jun 20 04:32:17 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 19 Jun 2012 22:32:17 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE14587.2020207@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1300C.6020107@oracle.com> <4FE1423A.8050808@oracle.com> <4FE14587.2020207@oracle.com> Message-ID: <4FE15251.7060509@oracle.com> On 6/19/12 9:37 PM, David Holmes wrote: > On 20/06/2012 1:23 PM, Daniel D. Daugherty wrote: >> Thanks for the quick review! > > You said it was urgent ;-) Yes, but sometimes that still doesn't get me timely reviews. :-) However, you have to be crazy to change HotSpot Makefiles so... can you really blame people for not wanting to review this stuff? > >> On 6/19/12 8:06 PM, David Holmes wrote: >>> It would be nice if the cd into the 64 directory could be handled >>> internally to the link logic rather than occurring at the top-level (I >>> say this as someone who will need to hand merge this into another >>> workspace ;-) ). >> >> I'm not quite sure what you mean by this: "the cd into the 64 directory >> could be handled internally to the link logic rather than occurring at >> the top-level". >> >> This isn't "at the top-level". It's in the dtrace.make subsidiary >> Makefile and it only happens for the context of the subshell. >> >> The problem is that ADD_GNU_DEBUGLINK and the ZIP_EXE need to be >> done in the 64 directory, but nothing else in that crazy Makefile >> logic does need to be done in the 64 directory. > > I "simply" meant doing the "cd 64" inside the ADD_GNU_DEBUGLINK logic > rather than in the makefile that invokes that logic. That said I can > live with Kelly's shorter form. You mean inside the $(ADD_GNU_DEBUGLINK) tool or inside the macro that's used to call the tool? The tool is called from a couple of different places. Inside the 64/ dir is just one of them... Let's see how things evolve based on Kelly next reply... > >>> Also in make/solaris/makefiles/add_gnu_debuglink.make I don't >>> understand the logic change: >>> >>> GENERATED = ../generated >>> >>> becomes >>> >>> TOPDIR = $(shell echo `pwd`) >>> GENERATED = $(TOPDIR)/../generated >>> >>> but at what time is "pwd" evaluated? If we have: /out/lib/64 and >>> originally we started in lib then GENERATED==lib/../generated ie >>> out/generated. If we have now done a cd into 64 then: pwd = >>> /out/lib/64 and so GENERATED==/out/lib/64/../generated ie >>> /out/lib/generated. I may well be missing something but this doesn't >>> seem right. >> >> Please see the very long answer that I gave Kelly about the GENERATED >> variable and HotSpot Makefiles. In particular, the TOPDIR followed >> by the setting of GENERATED is used in the Linux and BSD HotSpot >> makefiles (most of them anyway)... >> >> I'll wait to see what you can clarify about the "top-level" comment >> above before I try to resolve this any further... > > I read the long answer and yes it is complex. As I recently had to > untangle this for other reasons you (ie the hotspot developer cursed > to modify the build system) need to be aware that we effectively have > three levels of "make" invocations when building hotspot: > - "top level" Makefile or /Makefile > - buildtree.make sub-make > - make of the makefiles generated by buildtree.make Yes, I ran into those issues with getting the various FDS variables in "all the right places" and with "all the same values". Pain in the butt and needs to be rewritten, but that's another project. > determining which files get included at each level, and which > variables get passed through the submakes is complex. Lazy evaluation > of variables adds to the complexity. OK, but I don't think lazy evaluation is coming into play with my new TOPDIR variable or the way I'm setting GENERATED. > That all said, it still seems to me that the logic for GENERATED is > not correct if you have done a cd into the 64 subdirectory. Exactly the opposite is true. Without the TOPDIR/GENERATED combo, when you "cd 64", the "../generated" that the GENERATED variable resolves to no longer works. When GENERATED is set to "$(TOPDIR)/../generated", then it becomes an absolute path that can be used anywhere... However, I think where this is going to end up is something like: - add TOPDIR only to add_gnu_debuglink.make - set the ADD_GNU_DEBUGLINK variable using TOPDIR and a literal "../generated/add_gnu_debuglink" - don't set GENERATED in add_gnu_debuglink.make at all - drop the changes to fix_empty_sec_hdr_flags.make I think that'll reduce the risk since this fix needs to go back to HSX23.2 and HSX24. Dan > > Cheers, > David >> Dan >> >> >> >>> >>> David >>> ----- >>> >>> On 20/06/2012 11:21 AM, Daniel D. Daugherty wrote: >>>> Greetings, >>>> >>>> This is an URGENT code review request for a Solaris specific Full >>>> Debug >>>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug >>>> symbol >>>> files and related '_g' symlinks are created in the wrong sub-directory >>>> for a couple of the dtrace libraries. The incorrect paths have a >>>> double >>>> "64/" sub-directory, e.g.: >>>> >>>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>>> >>>> These are the correct symlink paths: >>>> >>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>>> >>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>>> >>>> >>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>>> >>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>>> >>>> >>>> >>>> and these are the correct debug info file paths: >>>> >>>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>>> >>>> >>>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>>> >>>> >>>> >>>> where "" is "i586" or "sparc". The 64-bit Solaris platforms >>>> ("amd64" >>>> and "sparcv9") don't have this issue because they don't have the "64/" >>>> sub-directories. >>>> >>>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will >>>> resolve >>>> an issue that is preventing Oracle's Release Engineering scripts from >>>> running properly. >>>> >>>> Here is the webrev URL for the HSX-24/JDK8 version: >>>> >>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>>> >>>> The HSX23.3/JDK7u6 version is the same except for the changes to >>>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>>> >>>> Thanks, in advance, for any reviews! >>>> >>>> Dan From david.holmes at oracle.com Wed Jun 20 04:36:46 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 20 Jun 2012 14:36:46 +1000 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE15251.7060509@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1300C.6020107@oracle.com> <4FE1423A.8050808@oracle.com> <4FE14587.2020207@oracle.com> <4FE15251.7060509@oracle.com> Message-ID: <4FE1535E.2030200@oracle.com> On 20/06/2012 2:32 PM, Daniel D. Daugherty wrote: >> That all said, it still seems to me that the logic for GENERATED is >> not correct if you have done a cd into the 64 subdirectory. > > Exactly the opposite is true. Without the TOPDIR/GENERATED combo, > when you "cd 64", the "../generated" that the GENERATED variable > resolves to no longer works. When GENERATED is set to > "$(TOPDIR)/../generated", then it becomes an absolute path that > can be used anywhere... Yes but "pwd" changes which in turn changes the path to generated. So I don't see how this works - I assume generated is not moving and that we don't have multiple generated directories. Anyway let's defer further discussion to the updated webrev. David > However, I think where this is going to end up is something like: > > - add TOPDIR only to add_gnu_debuglink.make > - set the ADD_GNU_DEBUGLINK variable using TOPDIR and a > literal "../generated/add_gnu_debuglink" > - don't set GENERATED in add_gnu_debuglink.make at all > - drop the changes to fix_empty_sec_hdr_flags.make > > I think that'll reduce the risk since this fix needs to > go back to HSX23.2 and HSX24. > > Dan > > >> >> Cheers, >> David >>> Dan >>> >>> >>> >>>> >>>> David >>>> ----- >>>> >>>> On 20/06/2012 11:21 AM, Daniel D. Daugherty wrote: >>>>> Greetings, >>>>> >>>>> This is an URGENT code review request for a Solaris specific Full >>>>> Debug >>>>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug >>>>> symbol >>>>> files and related '_g' symlinks are created in the wrong sub-directory >>>>> for a couple of the dtrace libraries. The incorrect paths have a >>>>> double >>>>> "64/" sub-directory, e.g.: >>>>> >>>>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>>>> >>>>> These are the correct symlink paths: >>>>> >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>>>> >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>>>> >>>>> >>>>> >>>>> and these are the correct debug info file paths: >>>>> >>>>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>>>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>>>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>> >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>> >>>>> >>>>> >>>>> where "" is "i586" or "sparc". The 64-bit Solaris platforms >>>>> ("amd64" >>>>> and "sparcv9") don't have this issue because they don't have the "64/" >>>>> sub-directories. >>>>> >>>>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will >>>>> resolve >>>>> an issue that is preventing Oracle's Release Engineering scripts from >>>>> running properly. >>>>> >>>>> Here is the webrev URL for the HSX-24/JDK8 version: >>>>> >>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>>>> >>>>> The HSX23.3/JDK7u6 version is the same except for the changes to >>>>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>>>> >>>>> Thanks, in advance, for any reviews! >>>>> >>>>> Dan From daniel.daugherty at oracle.com Wed Jun 20 04:50:28 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 19 Jun 2012 22:50:28 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE1535E.2030200@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1300C.6020107@oracle.com> <4FE1423A.8050808@oracle.com> <4FE14587.2020207@oracle.com> <4FE15251.7060509@oracle.com> <4FE1535E.2030200@oracle.com> Message-ID: <4FE15694.6010506@oracle.com> On 6/19/12 10:36 PM, David Holmes wrote: > On 20/06/2012 2:32 PM, Daniel D. Daugherty wrote: >>> That all said, it still seems to me that the logic for GENERATED is >>> not correct if you have done a cd into the 64 subdirectory. >> >> Exactly the opposite is true. Without the TOPDIR/GENERATED combo, >> when you "cd 64", the "../generated" that the GENERATED variable >> resolves to no longer works. When GENERATED is set to >> "$(TOPDIR)/../generated", then it becomes an absolute path that >> can be used anywhere... > > Yes but "pwd" changes which in turn changes the path to generated. So > I don't see how this works - I assume generated is not moving and that > we don't have multiple generated directories. TOPDIR is set to `pwd` once when the add_gnu_debuglink.make file is included into vm.make. The ADD_GNU_DEBUGLINK variable is only set once. Its value does not change every time it is called. Dan > > Anyway let's defer further discussion to the updated webrev. > > David > >> However, I think where this is going to end up is something like: >> >> - add TOPDIR only to add_gnu_debuglink.make >> - set the ADD_GNU_DEBUGLINK variable using TOPDIR and a >> literal "../generated/add_gnu_debuglink" >> - don't set GENERATED in add_gnu_debuglink.make at all >> - drop the changes to fix_empty_sec_hdr_flags.make >> >> I think that'll reduce the risk since this fix needs to >> go back to HSX23.2 and HSX24. >> >> Dan >> >> >>> >>> Cheers, >>> David >>>> Dan >>>> >>>> >>>> >>>>> >>>>> David >>>>> ----- >>>>> >>>>> On 20/06/2012 11:21 AM, Daniel D. Daugherty wrote: >>>>>> Greetings, >>>>>> >>>>>> This is an URGENT code review request for a Solaris specific Full >>>>>> Debug >>>>>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug >>>>>> symbol >>>>>> files and related '_g' symlinks are created in the wrong >>>>>> sub-directory >>>>>> for a couple of the dtrace libraries. The incorrect paths have a >>>>>> double >>>>>> "64/" sub-directory, e.g.: >>>>>> >>>>>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>>>>> >>>>>> These are the correct symlink paths: >>>>>> >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>>>>> >>>>>> >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>>>>> >>>>>> >>>>>> >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>>>>> >>>>>> >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> and these are the correct debug info file paths: >>>>>> >>>>>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>>>>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>>>>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>>>>> >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>>> >>>>>> >>>>>> >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>>>>> >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> where "" is "i586" or "sparc". The 64-bit Solaris platforms >>>>>> ("amd64" >>>>>> and "sparcv9") don't have this issue because they don't have the >>>>>> "64/" >>>>>> sub-directories. >>>>>> >>>>>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will >>>>>> resolve >>>>>> an issue that is preventing Oracle's Release Engineering scripts >>>>>> from >>>>>> running properly. >>>>>> >>>>>> Here is the webrev URL for the HSX-24/JDK8 version: >>>>>> >>>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>>>>> >>>>>> The HSX23.3/JDK7u6 version is the same except for the changes to >>>>>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>>>>> >>>>>> Thanks, in advance, for any reviews! >>>>>> >>>>>> Dan From daniel.daugherty at oracle.com Wed Jun 20 16:23:48 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 20 Jun 2012 10:23:48 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE1258E.8070200@oracle.com> References: <4FE1258E.8070200@oracle.com> Message-ID: <4FE1F914.7080300@oracle.com> Greetings, I've updated the fix to (hopefully) address Kelly's and David H's concerns. Here is the URL for code review round 1: http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/ Brief summary of changes relative to code review round 0: - removed definition of GENERATED from both add_gnu_debuglink.make and fix_empty_sec_hdr_flags.make; this will decouple these work around Makefiles from the regular HotSpot Makefiles that define the GENERATED macro. No, I'm not cleaning up that mess. :-) - add new "XLIBJVM_DIR = 64" variable and change all uses of a literal "64" in dtrace.make to the new variable - drop uses of $(QUIETLY) in sub-shell constructs; I don't think $(QUIETLY) works in sub-shells anyway, but my memory is fuzzy there Test JPRT jobs for HSX-24 and HSX-23.2 are in flight right now. Thanks, in advance, for any reviews! Dan On 6/19/12 7:21 PM, Daniel D. Daugherty wrote: > Greetings, > > This is an URGENT code review request for a Solaris specific Full Debug > Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol > files and related '_g' symlinks are created in the wrong sub-directory > for a couple of the dtrace libraries. The incorrect paths have a double > "64/" sub-directory, e.g.: > > solaris-/jre/lib//client/64/64/libjvm_db.debuginfo > > These are the correct symlink paths: > > > solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo > > solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo > > solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo > > solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo > > and these are the correct debug info file paths: > > solaris-/jre/lib//client/64/libjvm_db.debuginfo > solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo > solaris-/jre/lib//server/64/libjvm_db.debuginfo > solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo > solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo > > solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo > solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo > > solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo > > where "" is "i586" or "sparc". The 64-bit Solaris platforms > ("amd64" > and "sparcv9") don't have this issue because they don't have the "64/" > sub-directories. > > This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve > an issue that is preventing Oracle's Release Engineering scripts from > running properly. > > Here is the webrev URL for the HSX-24/JDK8 version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ > > The HSX23.3/JDK7u6 version is the same except for the changes to > make/solaris/makefiles/defs.make which are not needed in HSX23.2. > > Thanks, in advance, for any reviews! > > Dan > From kelly.ohair at oracle.com Wed Jun 20 16:41:21 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 20 Jun 2012 09:41:21 -0700 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE1F914.7080300@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1F914.7080300@oracle.com> Message-ID: You still have repeated patterns like: 131 ( set -e ; \ 132 cd $(XLIBJVM_DIR) ; \ 133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \ 134 ) When 131 ( cd $(XLIBJVM_DIR) && $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ) does the same thing and is more obvious, no need for the set -e -kto On Jun 20, 2012, at 9:23 AM, Daniel D. Daugherty wrote: > Greetings, > > I've updated the fix to (hopefully) address Kelly's and David H's > concerns. Here is the URL for code review round 1: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/ > > Brief summary of changes relative to code review round 0: > > - removed definition of GENERATED from both add_gnu_debuglink.make > and fix_empty_sec_hdr_flags.make; this will decouple these work > around Makefiles from the regular HotSpot Makefiles that define > the GENERATED macro. No, I'm not cleaning up that mess. :-) > - add new "XLIBJVM_DIR = 64" variable and change all uses of a > literal "64" in dtrace.make to the new variable > - drop uses of $(QUIETLY) in sub-shell constructs; I don't think > $(QUIETLY) works in sub-shells anyway, but my memory is fuzzy > there > > Test JPRT jobs for HSX-24 and HSX-23.2 are in flight right now. > > Thanks, in advance, for any reviews! > > Dan > > > On 6/19/12 7:21 PM, Daniel D. Daugherty wrote: >> Greetings, >> >> This is an URGENT code review request for a Solaris specific Full Debug >> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol >> files and related '_g' symlinks are created in the wrong sub-directory >> for a couple of the dtrace libraries. The incorrect paths have a double >> "64/" sub-directory, e.g.: >> >> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >> >> These are the correct symlink paths: >> >> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >> >> and these are the correct debug info file paths: >> >> solaris-/jre/lib//client/64/libjvm_db.debuginfo >> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >> solaris-/jre/lib//server/64/libjvm_db.debuginfo >> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >> >> where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" >> and "sparcv9") don't have this issue because they don't have the "64/" >> sub-directories. >> >> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve >> an issue that is preventing Oracle's Release Engineering scripts from >> running properly. >> >> Here is the webrev URL for the HSX-24/JDK8 version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >> >> The HSX23.3/JDK7u6 version is the same except for the changes to >> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >> >> Thanks, in advance, for any reviews! >> >> Dan >> From daniel.daugherty at oracle.com Wed Jun 20 16:44:14 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 20 Jun 2012 10:44:14 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: References: <4FE1258E.8070200@oracle.com> <4FE1F914.7080300@oracle.com> Message-ID: <4FE1FDDE.7020003@oracle.com> On 6/20/12 10:41 AM, Kelly O'Hair wrote: > You still have repeated patterns like: > 131 ( set -e ; \ > 132 cd $(XLIBJVM_DIR) ; \ > 133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \ > 134 ) > When > 131 ( cd $(XLIBJVM_DIR)&& $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ) > does the same thing and is more obvious, no need for the set -e Yes, that's because I didn't hear back from you after my reply from late last night. The "set -e" is there because you asked me to add it in a previous FDS fix. I'll switch it. Dan > -kto > > On Jun 20, 2012, at 9:23 AM, Daniel D. Daugherty wrote: > >> Greetings, >> >> I've updated the fix to (hopefully) address Kelly's and David H's >> concerns. Here is the URL for code review round 1: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/ >> >> Brief summary of changes relative to code review round 0: >> >> - removed definition of GENERATED from both add_gnu_debuglink.make >> and fix_empty_sec_hdr_flags.make; this will decouple these work >> around Makefiles from the regular HotSpot Makefiles that define >> the GENERATED macro. No, I'm not cleaning up that mess. :-) >> - add new "XLIBJVM_DIR = 64" variable and change all uses of a >> literal "64" in dtrace.make to the new variable >> - drop uses of $(QUIETLY) in sub-shell constructs; I don't think >> $(QUIETLY) works in sub-shells anyway, but my memory is fuzzy >> there >> >> Test JPRT jobs for HSX-24 and HSX-23.2 are in flight right now. >> >> Thanks, in advance, for any reviews! >> >> Dan >> >> >> On 6/19/12 7:21 PM, Daniel D. Daugherty wrote: >>> Greetings, >>> >>> This is an URGENT code review request for a Solaris specific Full Debug >>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol >>> files and related '_g' symlinks are created in the wrong sub-directory >>> for a couple of the dtrace libraries. The incorrect paths have a double >>> "64/" sub-directory, e.g.: >>> >>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>> >>> These are the correct symlink paths: >>> >>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>> >>> and these are the correct debug info file paths: >>> >>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>> >>> where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" >>> and "sparcv9") don't have this issue because they don't have the "64/" >>> sub-directories. >>> >>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve >>> an issue that is preventing Oracle's Release Engineering scripts from >>> running properly. >>> >>> Here is the webrev URL for the HSX-24/JDK8 version: >>> >>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>> >>> The HSX23.3/JDK7u6 version is the same except for the changes to >>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>> >>> Thanks, in advance, for any reviews! >>> >>> Dan >>> From daniel.daugherty at oracle.com Wed Jun 20 17:02:02 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 20 Jun 2012 11:02:02 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE1FDDE.7020003@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1F914.7080300@oracle.com> <4FE1FDDE.7020003@oracle.com> Message-ID: <4FE2020A.9080300@oracle.com> On 6/20/12 10:44 AM, Daniel D. Daugherty wrote: > On 6/20/12 10:41 AM, Kelly O'Hair wrote: >> You still have repeated patterns like: >> 131 ( set -e ; \ >> 132 cd $(XLIBJVM_DIR) ; \ >> 133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) >> $(LIBJVM_DB) ; \ >> 134 ) >> When >> 131 ( cd $(XLIBJVM_DIR)&& $(ADD_GNU_DEBUGLINK) >> $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ) >> does the same thing and is more obvious, no need for the set -e > > Yes, that's because I didn't hear back from you after my reply from > late last night. The "set -e" is there because you asked me to add > it in a previous FDS fix. > > I'll switch it. Fixed. See the following: http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/2/ Only make/solaris/makefiles/dtrace.make has changed in this round... Dan > > Dan > > >> -kto >> >> On Jun 20, 2012, at 9:23 AM, Daniel D. Daugherty wrote: >> >>> Greetings, >>> >>> I've updated the fix to (hopefully) address Kelly's and David H's >>> concerns. Here is the URL for code review round 1: >>> >>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/ >>> >>> Brief summary of changes relative to code review round 0: >>> >>> - removed definition of GENERATED from both add_gnu_debuglink.make >>> and fix_empty_sec_hdr_flags.make; this will decouple these work >>> around Makefiles from the regular HotSpot Makefiles that define >>> the GENERATED macro. No, I'm not cleaning up that mess. :-) >>> - add new "XLIBJVM_DIR = 64" variable and change all uses of a >>> literal "64" in dtrace.make to the new variable >>> - drop uses of $(QUIETLY) in sub-shell constructs; I don't think >>> $(QUIETLY) works in sub-shells anyway, but my memory is fuzzy >>> there >>> >>> Test JPRT jobs for HSX-24 and HSX-23.2 are in flight right now. >>> >>> Thanks, in advance, for any reviews! >>> >>> Dan >>> >>> >>> On 6/19/12 7:21 PM, Daniel D. Daugherty wrote: >>>> Greetings, >>>> >>>> This is an URGENT code review request for a Solaris specific Full >>>> Debug >>>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug >>>> symbol >>>> files and related '_g' symlinks are created in the wrong sub-directory >>>> for a couple of the dtrace libraries. The incorrect paths have a >>>> double >>>> "64/" sub-directory, e.g.: >>>> >>>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>>> >>>> These are the correct symlink paths: >>>> >>>> >>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>>> >>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>>> >>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>>> >>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>>> >>>> and these are the correct debug info file paths: >>>> >>>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>>> >>>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>>> >>>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>>> >>>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>>> >>>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>>> >>>> where "" is "i586" or "sparc". The 64-bit Solaris platforms >>>> ("amd64" >>>> and "sparcv9") don't have this issue because they don't have the "64/" >>>> sub-directories. >>>> >>>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will >>>> resolve >>>> an issue that is preventing Oracle's Release Engineering scripts from >>>> running properly. >>>> >>>> Here is the webrev URL for the HSX-24/JDK8 version: >>>> >>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>>> >>>> The HSX23.3/JDK7u6 version is the same except for the changes to >>>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>>> >>>> Thanks, in advance, for any reviews! >>>> >>>> Dan >>>> > From daniel.daugherty at oracle.com Wed Jun 20 19:04:19 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 20 Jun 2012 13:04:19 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE2020A.9080300@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1F914.7080300@oracle.com> <4FE1FDDE.7020003@oracle.com> <4FE2020A.9080300@oracle.com> Message-ID: <4FE21EB3.80407@oracle.com> Kelly, The JPRT job testing the latest HSX-24 version has finished and I have identical test results to the original version of this fix. The JPRT job testing the latest HSX-23.2 version is still running, but so far there are no issues. Could you let me know if this latest version resolves your code review comments? Dan On 6/20/12 11:02 AM, Daniel D. Daugherty wrote: > > > On 6/20/12 10:44 AM, Daniel D. Daugherty wrote: >> On 6/20/12 10:41 AM, Kelly O'Hair wrote: >>> You still have repeated patterns like: >>> 131 ( set -e ; \ >>> 132 cd $(XLIBJVM_DIR) ; \ >>> 133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) >>> $(LIBJVM_DB) ; \ >>> 134 ) >>> When >>> 131 ( cd $(XLIBJVM_DIR)&& $(ADD_GNU_DEBUGLINK) >>> $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ) >>> does the same thing and is more obvious, no need for the set -e >> >> Yes, that's because I didn't hear back from you after my reply from >> late last night. The "set -e" is there because you asked me to add >> it in a previous FDS fix. >> >> I'll switch it. > > Fixed. See the following: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/2/ > > Only make/solaris/makefiles/dtrace.make has changed in this round... > > Dan > > >> >> Dan >> >> >>> -kto >>> >>> On Jun 20, 2012, at 9:23 AM, Daniel D. Daugherty wrote: >>> >>>> Greetings, >>>> >>>> I've updated the fix to (hopefully) address Kelly's and David H's >>>> concerns. Here is the URL for code review round 1: >>>> >>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/ >>>> >>>> Brief summary of changes relative to code review round 0: >>>> >>>> - removed definition of GENERATED from both add_gnu_debuglink.make >>>> and fix_empty_sec_hdr_flags.make; this will decouple these work >>>> around Makefiles from the regular HotSpot Makefiles that define >>>> the GENERATED macro. No, I'm not cleaning up that mess. :-) >>>> - add new "XLIBJVM_DIR = 64" variable and change all uses of a >>>> literal "64" in dtrace.make to the new variable >>>> - drop uses of $(QUIETLY) in sub-shell constructs; I don't think >>>> $(QUIETLY) works in sub-shells anyway, but my memory is fuzzy >>>> there >>>> >>>> Test JPRT jobs for HSX-24 and HSX-23.2 are in flight right now. >>>> >>>> Thanks, in advance, for any reviews! >>>> >>>> Dan >>>> >>>> >>>> On 6/19/12 7:21 PM, Daniel D. Daugherty wrote: >>>>> Greetings, >>>>> >>>>> This is an URGENT code review request for a Solaris specific Full >>>>> Debug >>>>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug >>>>> symbol >>>>> files and related '_g' symlinks are created in the wrong >>>>> sub-directory >>>>> for a couple of the dtrace libraries. The incorrect paths have a >>>>> double >>>>> "64/" sub-directory, e.g.: >>>>> >>>>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>>>> >>>>> These are the correct symlink paths: >>>>> >>>>> >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>>>> >>>>> and these are the correct debug info file paths: >>>>> >>>>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>>>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>>>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>> >>>>> where "" is "i586" or "sparc". The 64-bit Solaris platforms >>>>> ("amd64" >>>>> and "sparcv9") don't have this issue because they don't have the >>>>> "64/" >>>>> sub-directories. >>>>> >>>>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will >>>>> resolve >>>>> an issue that is preventing Oracle's Release Engineering scripts from >>>>> running properly. >>>>> >>>>> Here is the webrev URL for the HSX-24/JDK8 version: >>>>> >>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>>>> >>>>> The HSX23.3/JDK7u6 version is the same except for the changes to >>>>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>>>> >>>>> Thanks, in advance, for any reviews! >>>>> >>>>> Dan >>>>> >> > From kelly.ohair at oracle.com Wed Jun 20 20:13:14 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 20 Jun 2012 13:13:14 -0700 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE21EB3.80407@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1F914.7080300@oracle.com> <4FE1FDDE.7020003@oracle.com> <4FE2020A.9080300@oracle.com> <4FE21EB3.80407@oracle.com> Message-ID: <7CE6F586-E761-43A7-8D85-0BC7A8EA1BFD@oracle.com> Looks fine. -kto On Jun 20, 2012, at 12:04 PM, Daniel D. Daugherty wrote: > Kelly, > > The JPRT job testing the latest HSX-24 version has finished and I > have identical test results to the original version of this fix. > The JPRT job testing the latest HSX-23.2 version is still running, > but so far there are no issues. > > Could you let me know if this latest version resolves your > code review comments? > > Dan > > > > On 6/20/12 11:02 AM, Daniel D. Daugherty wrote: >> >> >> On 6/20/12 10:44 AM, Daniel D. Daugherty wrote: >>> On 6/20/12 10:41 AM, Kelly O'Hair wrote: >>>> You still have repeated patterns like: >>>> 131 ( set -e ; \ >>>> 132 cd $(XLIBJVM_DIR) ; \ >>>> 133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \ >>>> 134 ) >>>> When >>>> 131 ( cd $(XLIBJVM_DIR)&& $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ) >>>> does the same thing and is more obvious, no need for the set -e >>> >>> Yes, that's because I didn't hear back from you after my reply from >>> late last night. The "set -e" is there because you asked me to add >>> it in a previous FDS fix. >>> >>> I'll switch it. >> >> Fixed. See the following: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/2/ >> >> Only make/solaris/makefiles/dtrace.make has changed in this round... >> >> Dan >> >> >>> >>> Dan >>> >>> >>>> -kto >>>> >>>> On Jun 20, 2012, at 9:23 AM, Daniel D. Daugherty wrote: >>>> >>>>> Greetings, >>>>> >>>>> I've updated the fix to (hopefully) address Kelly's and David H's >>>>> concerns. Here is the URL for code review round 1: >>>>> >>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/ >>>>> >>>>> Brief summary of changes relative to code review round 0: >>>>> >>>>> - removed definition of GENERATED from both add_gnu_debuglink.make >>>>> and fix_empty_sec_hdr_flags.make; this will decouple these work >>>>> around Makefiles from the regular HotSpot Makefiles that define >>>>> the GENERATED macro. No, I'm not cleaning up that mess. :-) >>>>> - add new "XLIBJVM_DIR = 64" variable and change all uses of a >>>>> literal "64" in dtrace.make to the new variable >>>>> - drop uses of $(QUIETLY) in sub-shell constructs; I don't think >>>>> $(QUIETLY) works in sub-shells anyway, but my memory is fuzzy >>>>> there >>>>> >>>>> Test JPRT jobs for HSX-24 and HSX-23.2 are in flight right now. >>>>> >>>>> Thanks, in advance, for any reviews! >>>>> >>>>> Dan >>>>> >>>>> >>>>> On 6/19/12 7:21 PM, Daniel D. Daugherty wrote: >>>>>> Greetings, >>>>>> >>>>>> This is an URGENT code review request for a Solaris specific Full Debug >>>>>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol >>>>>> files and related '_g' symlinks are created in the wrong sub-directory >>>>>> for a couple of the dtrace libraries. The incorrect paths have a double >>>>>> "64/" sub-directory, e.g.: >>>>>> >>>>>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>>>>> >>>>>> These are the correct symlink paths: >>>>>> >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>>>>> >>>>>> and these are the correct debug info file paths: >>>>>> >>>>>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>>>>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>>>>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>>> >>>>>> where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" >>>>>> and "sparcv9") don't have this issue because they don't have the "64/" >>>>>> sub-directories. >>>>>> >>>>>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve >>>>>> an issue that is preventing Oracle's Release Engineering scripts from >>>>>> running properly. >>>>>> >>>>>> Here is the webrev URL for the HSX-24/JDK8 version: >>>>>> >>>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>>>>> >>>>>> The HSX23.3/JDK7u6 version is the same except for the changes to >>>>>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>>>>> >>>>>> Thanks, in advance, for any reviews! >>>>>> >>>>>> Dan >>>>>> >>> >> From daniel.daugherty at oracle.com Wed Jun 20 20:42:31 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 20 Jun 2012 14:42:31 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <7CE6F586-E761-43A7-8D85-0BC7A8EA1BFD@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1F914.7080300@oracle.com> <4FE1FDDE.7020003@oracle.com> <4FE2020A.9080300@oracle.com> <4FE21EB3.80407@oracle.com> <7CE6F586-E761-43A7-8D85-0BC7A8EA1BFD@oracle.com> Message-ID: <4FE235B7.4050108@oracle.com> Thanks! Sorry this took three rounds. Dan On 6/20/12 2:13 PM, Kelly O'Hair wrote: > Looks fine. > > -kto > > On Jun 20, 2012, at 12:04 PM, Daniel D. Daugherty wrote: > >> Kelly, >> >> The JPRT job testing the latest HSX-24 version has finished and I >> have identical test results to the original version of this fix. >> The JPRT job testing the latest HSX-23.2 version is still running, >> but so far there are no issues. >> >> Could you let me know if this latest version resolves your >> code review comments? >> >> Dan >> >> >> >> On 6/20/12 11:02 AM, Daniel D. Daugherty wrote: >>> >>> On 6/20/12 10:44 AM, Daniel D. Daugherty wrote: >>>> On 6/20/12 10:41 AM, Kelly O'Hair wrote: >>>>> You still have repeated patterns like: >>>>> 131 ( set -e ; \ >>>>> 132 cd $(XLIBJVM_DIR) ; \ >>>>> 133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \ >>>>> 134 ) >>>>> When >>>>> 131 ( cd $(XLIBJVM_DIR)&& $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ) >>>>> does the same thing and is more obvious, no need for the set -e >>>> Yes, that's because I didn't hear back from you after my reply from >>>> late last night. The "set -e" is there because you asked me to add >>>> it in a previous FDS fix. >>>> >>>> I'll switch it. >>> Fixed. See the following: >>> >>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/2/ >>> >>> Only make/solaris/makefiles/dtrace.make has changed in this round... >>> >>> Dan >>> >>> >>>> Dan >>>> >>>> >>>>> -kto >>>>> >>>>> On Jun 20, 2012, at 9:23 AM, Daniel D. Daugherty wrote: >>>>> >>>>>> Greetings, >>>>>> >>>>>> I've updated the fix to (hopefully) address Kelly's and David H's >>>>>> concerns. Here is the URL for code review round 1: >>>>>> >>>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/ >>>>>> >>>>>> Brief summary of changes relative to code review round 0: >>>>>> >>>>>> - removed definition of GENERATED from both add_gnu_debuglink.make >>>>>> and fix_empty_sec_hdr_flags.make; this will decouple these work >>>>>> around Makefiles from the regular HotSpot Makefiles that define >>>>>> the GENERATED macro. No, I'm not cleaning up that mess. :-) >>>>>> - add new "XLIBJVM_DIR = 64" variable and change all uses of a >>>>>> literal "64" in dtrace.make to the new variable >>>>>> - drop uses of $(QUIETLY) in sub-shell constructs; I don't think >>>>>> $(QUIETLY) works in sub-shells anyway, but my memory is fuzzy >>>>>> there >>>>>> >>>>>> Test JPRT jobs for HSX-24 and HSX-23.2 are in flight right now. >>>>>> >>>>>> Thanks, in advance, for any reviews! >>>>>> >>>>>> Dan >>>>>> >>>>>> >>>>>> On 6/19/12 7:21 PM, Daniel D. Daugherty wrote: >>>>>>> Greetings, >>>>>>> >>>>>>> This is an URGENT code review request for a Solaris specific Full Debug >>>>>>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol >>>>>>> files and related '_g' symlinks are created in the wrong sub-directory >>>>>>> for a couple of the dtrace libraries. The incorrect paths have a double >>>>>>> "64/" sub-directory, e.g.: >>>>>>> >>>>>>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>>>>>> >>>>>>> These are the correct symlink paths: >>>>>>> >>>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>>>>>> >>>>>>> and these are the correct debug info file paths: >>>>>>> >>>>>>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>>>>>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>>>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>>>>>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>>>> >>>>>>> where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" >>>>>>> and "sparcv9") don't have this issue because they don't have the "64/" >>>>>>> sub-directories. >>>>>>> >>>>>>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve >>>>>>> an issue that is preventing Oracle's Release Engineering scripts from >>>>>>> running properly. >>>>>>> >>>>>>> Here is the webrev URL for the HSX-24/JDK8 version: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>>>>>> >>>>>>> The HSX23.3/JDK7u6 version is the same except for the changes to >>>>>>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>>>>>> >>>>>>> Thanks, in advance, for any reviews! >>>>>>> >>>>>>> Dan >>>>>>> From david.holmes at oracle.com Wed Jun 20 21:03:11 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 21 Jun 2012 07:03:11 +1000 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE2020A.9080300@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1F914.7080300@oracle.com> <4FE1FDDE.7020003@oracle.com> <4FE2020A.9080300@oracle.com> Message-ID: <4FE23A8F.4090202@oracle.com> Looks good to me Dan! Thanks, David On 21/06/2012 3:02 AM, Daniel D. Daugherty wrote: > > > On 6/20/12 10:44 AM, Daniel D. Daugherty wrote: >> On 6/20/12 10:41 AM, Kelly O'Hair wrote: >>> You still have repeated patterns like: >>> 131 ( set -e ; \ >>> 132 cd $(XLIBJVM_DIR) ; \ >>> 133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \ >>> 134 ) >>> When >>> 131 ( cd $(XLIBJVM_DIR)&& $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) >>> $(LIBJVM_DB) ) >>> does the same thing and is more obvious, no need for the set -e >> >> Yes, that's because I didn't hear back from you after my reply from >> late last night. The "set -e" is there because you asked me to add >> it in a previous FDS fix. >> >> I'll switch it. > > Fixed. See the following: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/2/ > > Only make/solaris/makefiles/dtrace.make has changed in this round... > > Dan > > >> >> Dan >> >> >>> -kto >>> >>> On Jun 20, 2012, at 9:23 AM, Daniel D. Daugherty wrote: >>> >>>> Greetings, >>>> >>>> I've updated the fix to (hopefully) address Kelly's and David H's >>>> concerns. Here is the URL for code review round 1: >>>> >>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/ >>>> >>>> Brief summary of changes relative to code review round 0: >>>> >>>> - removed definition of GENERATED from both add_gnu_debuglink.make >>>> and fix_empty_sec_hdr_flags.make; this will decouple these work >>>> around Makefiles from the regular HotSpot Makefiles that define >>>> the GENERATED macro. No, I'm not cleaning up that mess. :-) >>>> - add new "XLIBJVM_DIR = 64" variable and change all uses of a >>>> literal "64" in dtrace.make to the new variable >>>> - drop uses of $(QUIETLY) in sub-shell constructs; I don't think >>>> $(QUIETLY) works in sub-shells anyway, but my memory is fuzzy >>>> there >>>> >>>> Test JPRT jobs for HSX-24 and HSX-23.2 are in flight right now. >>>> >>>> Thanks, in advance, for any reviews! >>>> >>>> Dan >>>> >>>> >>>> On 6/19/12 7:21 PM, Daniel D. Daugherty wrote: >>>>> Greetings, >>>>> >>>>> This is an URGENT code review request for a Solaris specific Full >>>>> Debug >>>>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug >>>>> symbol >>>>> files and related '_g' symlinks are created in the wrong sub-directory >>>>> for a couple of the dtrace libraries. The incorrect paths have a >>>>> double >>>>> "64/" sub-directory, e.g.: >>>>> >>>>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>>>> >>>>> These are the correct symlink paths: >>>>> >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>>>> >>>>> >>>>> and these are the correct debug info file paths: >>>>> >>>>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>>>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>>>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>> >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>> >>>>> >>>>> where "" is "i586" or "sparc". The 64-bit Solaris platforms >>>>> ("amd64" >>>>> and "sparcv9") don't have this issue because they don't have the "64/" >>>>> sub-directories. >>>>> >>>>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will >>>>> resolve >>>>> an issue that is preventing Oracle's Release Engineering scripts from >>>>> running properly. >>>>> >>>>> Here is the webrev URL for the HSX-24/JDK8 version: >>>>> >>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>>>> >>>>> The HSX23.3/JDK7u6 version is the same except for the changes to >>>>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>>>> >>>>> Thanks, in advance, for any reviews! >>>>> >>>>> Dan >>>>> >> From daniel.daugherty at oracle.com Wed Jun 20 21:05:32 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 20 Jun 2012 15:05:32 -0600 Subject: URGENT code review request for Solaris FDS fix (7175255) In-Reply-To: <4FE23A8F.4090202@oracle.com> References: <4FE1258E.8070200@oracle.com> <4FE1F914.7080300@oracle.com> <4FE1FDDE.7020003@oracle.com> <4FE2020A.9080300@oracle.com> <4FE23A8F.4090202@oracle.com> Message-ID: <4FE23B1C.6020907@oracle.com> Thanks! Dan On 6/20/12 3:03 PM, David Holmes wrote: > Looks good to me Dan! > > Thanks, > David > > On 21/06/2012 3:02 AM, Daniel D. Daugherty wrote: >> >> >> On 6/20/12 10:44 AM, Daniel D. Daugherty wrote: >>> On 6/20/12 10:41 AM, Kelly O'Hair wrote: >>>> You still have repeated patterns like: >>>> 131 ( set -e ; \ >>>> 132 cd $(XLIBJVM_DIR) ; \ >>>> 133 $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) ; \ >>>> 134 ) >>>> When >>>> 131 ( cd $(XLIBJVM_DIR)&& $(ADD_GNU_DEBUGLINK) $(LIBJVM_DB_DEBUGINFO) >>>> $(LIBJVM_DB) ) >>>> does the same thing and is more obvious, no need for the set -e >>> >>> Yes, that's because I didn't hear back from you after my reply from >>> late last night. The "set -e" is there because you asked me to add >>> it in a previous FDS fix. >>> >>> I'll switch it. >> >> Fixed. See the following: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/2/ >> >> Only make/solaris/makefiles/dtrace.make has changed in this round... >> >> Dan >> >> >>> >>> Dan >>> >>> >>>> -kto >>>> >>>> On Jun 20, 2012, at 9:23 AM, Daniel D. Daugherty wrote: >>>> >>>>> Greetings, >>>>> >>>>> I've updated the fix to (hopefully) address Kelly's and David H's >>>>> concerns. Here is the URL for code review round 1: >>>>> >>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/1/ >>>>> >>>>> Brief summary of changes relative to code review round 0: >>>>> >>>>> - removed definition of GENERATED from both add_gnu_debuglink.make >>>>> and fix_empty_sec_hdr_flags.make; this will decouple these work >>>>> around Makefiles from the regular HotSpot Makefiles that define >>>>> the GENERATED macro. No, I'm not cleaning up that mess. :-) >>>>> - add new "XLIBJVM_DIR = 64" variable and change all uses of a >>>>> literal "64" in dtrace.make to the new variable >>>>> - drop uses of $(QUIETLY) in sub-shell constructs; I don't think >>>>> $(QUIETLY) works in sub-shells anyway, but my memory is fuzzy >>>>> there >>>>> >>>>> Test JPRT jobs for HSX-24 and HSX-23.2 are in flight right now. >>>>> >>>>> Thanks, in advance, for any reviews! >>>>> >>>>> Dan >>>>> >>>>> >>>>> On 6/19/12 7:21 PM, Daniel D. Daugherty wrote: >>>>>> Greetings, >>>>>> >>>>>> This is an URGENT code review request for a Solaris specific Full >>>>>> Debug >>>>>> Symbols (FDS) fix. Due to a Makefile logic error, the full debug >>>>>> symbol >>>>>> files and related '_g' symlinks are created in the wrong >>>>>> sub-directory >>>>>> for a couple of the dtrace libraries. The incorrect paths have a >>>>>> double >>>>>> "64/" sub-directory, e.g.: >>>>>> >>>>>> solaris-/jre/lib//client/64/64/libjvm_db.debuginfo >>>>>> >>>>>> These are the correct symlink paths: >>>>>> >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_db.debuginfo >>>>>> >>>>>> >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_g_dtrace.debuginfo >>>>>> >>>>>> >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_db.debuginfo >>>>>> >>>>>> >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_g_dtrace.debuginfo >>>>>> >>>>>> >>>>>> >>>>>> and these are the correct debug info file paths: >>>>>> >>>>>> solaris-/jre/lib//client/64/libjvm_db.debuginfo >>>>>> solaris-/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>>> solaris-/jre/lib//server/64/libjvm_db.debuginfo >>>>>> solaris-/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_db.debuginfo >>>>>> >>>>>> solaris-/fastdebug/jre/lib//client/64/libjvm_dtrace.debuginfo >>>>>> >>>>>> >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_db.debuginfo >>>>>> >>>>>> solaris-/fastdebug/jre/lib//server/64/libjvm_dtrace.debuginfo >>>>>> >>>>>> >>>>>> >>>>>> where "" is "i586" or "sparc". The 64-bit Solaris platforms >>>>>> ("amd64" >>>>>> and "sparcv9") don't have this issue because they don't have the >>>>>> "64/" >>>>>> sub-directories. >>>>>> >>>>>> This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will >>>>>> resolve >>>>>> an issue that is preventing Oracle's Release Engineering scripts >>>>>> from >>>>>> running properly. >>>>>> >>>>>> Here is the webrev URL for the HSX-24/JDK8 version: >>>>>> >>>>>> http://cr.openjdk.java.net/~dcubed/fds_revamp/7175255-webrev/0/ >>>>>> >>>>>> The HSX23.3/JDK7u6 version is the same except for the changes to >>>>>> make/solaris/makefiles/defs.make which are not needed in HSX23.2. >>>>>> >>>>>> Thanks, in advance, for any reviews! >>>>>> >>>>>> Dan >>>>>> >>> From david.katleman at oracle.com Wed Jun 20 22:31:07 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 20 Jun 2012 22:31:07 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20120620223107.68ACE47A44@hg.openjdk.java.net> Changeset: 02c6c67c1bb7 Author: katleman Date: 2012-06-14 13:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/02c6c67c1bb7 Added tag jdk8-b43 for changeset 661c9aae602b ! .hgtags Changeset: e4f81a817447 Author: katleman Date: 2012-06-20 15:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/e4f81a817447 Merge From david.katleman at oracle.com Wed Jun 20 22:31:15 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 20 Jun 2012 22:31:15 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b43 for changeset cd879aff5d3c Message-ID: <20120620223118.2172947A45@hg.openjdk.java.net> Changeset: 439d9bf8e4ff Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/439d9bf8e4ff Added tag jdk8-b43 for changeset cd879aff5d3c ! .hgtags From david.katleman at oracle.com Wed Jun 20 22:35:31 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 20 Jun 2012 22:35:31 +0000 Subject: hg: jdk8/build/hotspot: 35 new changesets Message-ID: <20120620223656.2F3DD47A49@hg.openjdk.java.net> Changeset: b38fb5f31e31 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b38fb5f31e31 Added tag jdk8-b43 for changeset e77b8e0ed1f8 ! .hgtags Changeset: 6e2633440960 Author: amurillo Date: 2012-06-01 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6e2633440960 7173438: new hotspot build - hs24-b14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: fab99b17c1de Author: mikael Date: 2012-06-01 20:17 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fab99b17c1de 7155453: [macosx] re-enable jbb tests in JPRT Summary: Run SPECjbb in headless mode and enable SPECjbb runs on OSX Reviewed-by: dcubed, dholmes ! make/jprt.properties Changeset: 4434fdad6b37 Author: dholmes Date: 2012-06-02 07:32 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4434fdad6b37 Merge ! make/jprt.properties Changeset: e17b61ba7bb3 Author: kamg Date: 2012-06-04 10:22 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e17b61ba7bb3 7166498: JVM crash in ClassVerifier Summary: Fixed raw pointer being used after potential safepoint/GC Reviewed-by: acorn, fparain, dholmes ! src/share/vm/classfile/verifier.cpp Changeset: a297b0e14605 Author: mgerdin Date: 2012-06-04 09:21 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a297b0e14605 7172226: HotSpot fails to build with GCC 4.7 because of stricter c++ argument dependent lookup Summary: Add "using" keyword to import base class functions from FreeList to fix template name lookup in gcc 4.7 Reviewed-by: brutisso, iveresov ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/binaryTreeDictionary.hpp Changeset: 37552638d24a Author: brutisso Date: 2012-06-05 22:30 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles Reviewed-by: azeemj, jmasa ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp Changeset: b9442ac22f59 Author: brutisso Date: 2012-06-04 13:29 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b9442ac22f59 7173460: G1: java/lang/management/MemoryMXBean/CollectionUsageThreshold.java failes with G1 Summary: The scope of TraceMemoryManagerStats in G1CollectedHeap need to cover the call to G1MonitoringSupport::update_sizes() Reviewed-by: johnc, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 063451aefde8 Author: jcoomes Date: 2012-06-08 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/063451aefde8 Merge Changeset: 2fe087c3e814 Author: jiangli Date: 2012-06-06 14:33 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2fe087c3e814 7172967: Eliminate constMethod's _method backpointer to methodOop. Summary: Eliminate constMethod's _method backpointer to methodOop, and move the _constant field from methodOop to constMethod. Reviewed-by: roland, bdelsart, kamg ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/jhelper.d ! src/os/solaris/dtrace/libjvm_db.c ! src/share/vm/oops/constMethodKlass.cpp ! src/share/vm/oops/constMethodOop.cpp ! src/share/vm/oops/constMethodOop.hpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ab6ab9f84b2d Author: bdelsart Date: 2012-06-11 04:47 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ab6ab9f84b2d Merge Changeset: dcfcdd01af4b Author: fparain Date: 2012-06-05 06:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dcfcdd01af4b 7171703: JNI DefineClass crashes client VM when first parameter is NULL Reviewed-by: acorn, kamg, sspitsyn, dholmes ! src/share/vm/prims/jni.cpp Changeset: de909f001528 Author: mikael Date: 2012-06-06 05:21 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/de909f001528 7170275: os::print_os_info needs to know about Windows 8 Summary: Recognize Windows 8 and Windows Server 2012 Reviewed-by: sla, kvn, azeemj ! src/os/windows/vm/os_windows.cpp Changeset: 40b4aaf010e4 Author: dholmes Date: 2012-06-08 02:06 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/40b4aaf010e4 7172708: 32/64 bit type issues on Windows after Mac OS X port Reviewed-by: dholmes, coleenp Contributed-by: Chris Dennis ! src/share/vm/utilities/globalDefinitions_visCPP.hpp Changeset: 0a8b8cb8b22c Author: sla Date: 2012-06-11 10:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0a8b8cb8b22c Merge Changeset: 4d399f013e5a Author: kamg Date: 2012-06-11 13:10 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4d399f013e5a 7175914: Usage of gcc with precompiled headers produces wrong build dependencies Summary: Add -fpch-deps flag to gcc builds Reviewed-by: kamg, coleenp Contributed-by: volker.simonis at gmail.com ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/gcc.make ! make/solaris/makefiles/gcc.make Changeset: 17b1b616daf7 Author: sla Date: 2012-06-14 12:21 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/17b1b616daf7 Merge Changeset: 8f6ce6f1049b Author: kvn Date: 2012-05-25 07:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8f6ce6f1049b 7170463: C2 should recognize "obj.getClass() == A.class" code pattern Summary: optimize this code pattern obj.getClass() == A.class. Reviewed-by: jrose, kvn Contributed-by: Krystal Mok ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/subnode.cpp Changeset: 4d8787136e08 Author: twisti Date: 2012-05-25 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4d8787136e08 7170145: C1 doesn't respect the JMM with volatile field loads Reviewed-by: kvn, roland ! src/share/vm/c1/c1_ValueMap.hpp Changeset: c8289830e172 Author: twisti Date: 2012-05-30 12:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c8289830e172 7172843: C1: fix "assert(has_printable_bci()) failed: _printable_bci should have been set" Reviewed-by: twisti Contributed-by: Krystal Mok ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Instruction.hpp Changeset: 7bc2d5136f54 Author: amurillo Date: 2012-06-01 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7bc2d5136f54 7173635: jprt.properties should include release jdk7u6 Reviewed-by: jcoomes ! make/jprt.properties Changeset: 8f37087fc13f Author: roland Date: 2012-06-05 10:15 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8f37087fc13f 7171890: C1: add Class.isInstance intrinsic Summary: Class.cast which calls Class.isInstance is heavily used by the new JSR 292 implementation Reviewed-by: roland Contributed-by: Krystal Mok ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp Changeset: e1635876b206 Author: twisti Date: 2012-06-06 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e1635876b206 7174884: C1: failures after 7171890: assert(cur_state != NULL) failed: state_before must be set Reviewed-by: kvn ! src/share/vm/c1/c1_Canonicalizer.cpp Changeset: 829ee34e7cbd Author: kvn Date: 2012-06-11 08:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/829ee34e7cbd Merge ! make/jprt.properties Changeset: ccaa67adfe5b Author: twisti Date: 2012-06-11 16:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ccaa67adfe5b 7063674: Wrong results from basic comparisons after calls to Long.bitCount(long) Reviewed-by: kvn ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad Changeset: 0919b2e7895d Author: kvn Date: 2012-06-11 14:58 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0919b2e7895d 7174510: 19 JCK compiler tests fail with C2 error: memNode.cpp:812 - ShouldNotReachHere Summary: Add missing check for EncodeP node in MemNode::Ideal_common_DU_postCCP() method. Reviewed-by: twisti ! src/share/vm/opto/memnode.cpp Changeset: d5dded5d1e0d Author: kvn Date: 2012-06-11 22:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d5dded5d1e0d Merge Changeset: e7715c222897 Author: roland Date: 2012-06-12 10:02 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e7715c222897 7174532: jdk/test/java/lang/Math/WorstCaseTests.java failing on x86 Summary: increase precision on x86 for the steps of the computation of exp and pow. Reviewed-by: kvn ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp Changeset: 121e5708ae96 Author: kvn Date: 2012-06-12 09:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/121e5708ae96 7169782: C2: SIGSEGV in LShiftLNode::Ideal(PhaseGVN*, bool) Summary: keep intermediate node alive till the end of the graph construction using dummy hook node trick Reviewed-by: kvn, twisti Contributed-by: vladimir.x.ivanov at oracle.com ! src/share/vm/opto/divnode.cpp + test/compiler/6732154/Test6732154.java + test/compiler/7169782/Test7169782.java Changeset: 8b0a4867acf0 Author: twisti Date: 2012-06-12 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8b0a4867acf0 7174218: remove AtomicLongCSImpl intrinsics Reviewed-by: kvn, twisti Contributed-by: Krystal Mok ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5e990493719e Author: kvn Date: 2012-06-12 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5e990493719e 7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable Summary: replace frequent C2 optimizer code patterns with new methods calls Reviewed-by: kvn, twisti Contributed-by: vladimir.x.ivanov at oracle.com ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/superword.cpp Changeset: e2fe93124108 Author: twisti Date: 2012-06-13 11:36 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e2fe93124108 7174928: JSR 292: unresolved invokedynamic call sites deopt and osr infinitely Reviewed-by: kvn ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: eba1d5bce9e8 Author: kvn Date: 2012-06-14 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/eba1d5bce9e8 Merge ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 5ba29a1db46e Author: amurillo Date: 2012-06-15 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5ba29a1db46e Merge Changeset: 831e5c76a20a Author: amurillo Date: 2012-06-15 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/831e5c76a20a Added tag hs24-b14 for changeset 5ba29a1db46e ! .hgtags From david.katleman at oracle.com Wed Jun 20 22:38:15 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 20 Jun 2012 22:38:15 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b43 for changeset eff4ece9c8bc Message-ID: <20120620223821.47B9347A4A@hg.openjdk.java.net> Changeset: 0b3f3a4ce139 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/0b3f3a4ce139 Added tag jdk8-b43 for changeset eff4ece9c8bc ! .hgtags From david.katleman at oracle.com Wed Jun 20 22:38:27 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 20 Jun 2012 22:38:27 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b43 for changeset f00c12994562 Message-ID: <20120620223831.3566247A4B@hg.openjdk.java.net> Changeset: f6a417540ef1 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/f6a417540ef1 Added tag jdk8-b43 for changeset f00c12994562 ! .hgtags From david.katleman at oracle.com Wed Jun 20 22:38:41 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 20 Jun 2012 22:38:41 +0000 Subject: hg: jdk8/build/jdk: Added tag jdk8-b43 for changeset b3246687c369 Message-ID: <20120620223906.58AD847A4C@hg.openjdk.java.net> Changeset: db471a7af031 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/db471a7af031 Added tag jdk8-b43 for changeset b3246687c369 ! .hgtags From david.katleman at oracle.com Wed Jun 20 22:40:32 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 20 Jun 2012 22:40:32 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b43 for changeset f8c64d835b28 Message-ID: <20120620224037.ECFE847A4D@hg.openjdk.java.net> Changeset: 59cbead12ff4 Author: katleman Date: 2012-06-14 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/59cbead12ff4 Added tag jdk8-b43 for changeset f8c64d835b28 ! .hgtags From david.holmes at oracle.com Thu Jun 21 00:49:33 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 21 Jun 2012 10:49:33 +1000 Subject: get_source/hgforest.sh breaks "defpath -dgu" Message-ID: <4FE26F9D.1030502@oracle.com> I just cloned the complete TL JDK8 forest by cloning the top repo then using get_source.sh to clone the other repos (open and closed). At the top-level hgdefpath shows /export/users/dh198349/jdk8 > hg defpath default = http://hg.openjdk.java.net/jdk8/tl/ default-push = None I then went into the jdk repo to run "hg defpath -dgu dholmes" and got: abort: http://hg.openjdk.java.net/jdk8/tl//jdk: Repository not found No hgrc files updated Note the // prior to jdk. If I edit .hgrc/hgrc to change that to a / the defpath works. Note that clones/pulls etc don't care about the // but the "defpath -dg" does. All of the clones initiated via hgforest.sh have the // eg: # Repos: corba jaxp jaxws langtools jdk hotspot jdk/src/closed jdk/make/closed jdk/test/closed hotspot/src/closed hotspot/test/closed deploy install sponsors pubs Starting on corba Starting on jaxp Starting on jaxws Starting on langtools # hg clone http://hg.openjdk.java.net/jdk8/tl//corba corba David From staffan.larsen at oracle.com Thu Jun 21 14:54:27 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 21 Jun 2012 16:54:27 +0200 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: <4FE316D5.3020502@oracle.com> References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> Message-ID: [adding build-dev and macosx-port-dev] On 21 jun 2012, at 14:43, David Holmes wrote: > On 21/06/2012 10:30 PM, Staffan Larsen wrote: >> Do you mean: >> >> .PHONY: $(UNIVERSAL_LIPO_LIST) $(UNIVERSAL_COPY_LIST) > > Yes. Now they will always be rebuilt. > >> Yes, that seems to have the same effect. Probably a better solution. > > I think both of these simply mask the real problem. I still don't understand how only some of the list items get "rebuilt". The CR says > > "These targets will only be run for the last item in the xxx_LIST variables (which happens to be the client jvm)" > > but I don't understand why that is? Neither do I. Makefiles is black magic to me. I only discovered that building the complete JDK from the top-level directory did not update the hotspot bits in the j2sdk-image and this was the ultimate cause. Here is an updated webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.02/ Thanks, /Staffan > But I also don't understand this universalization process. > > BTW you might want to run this past the bsd-port folks (don't recall the exact alias) and/or build-dev. I seem to recall that last time we changed something to do with universal builds it actually broke something. > > David > >> Thanks, >> /Staffan >> >> On 21 jun 2012, at 14:12, David Holmes wrote: >> >>> Hi Staffan, >>> >>> On 21/06/2012 6:33 PM, Staffan Larsen wrote: >>>> Please review the following fix to makefiles for universal binaries on >>>> max os x. The idea is to force the target to be executed for all items >>>> in the list. >>>> >>>> Fix contributed by Rickard B?ckman (rbackman). >>>> >>>> webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.01/ >>> >>> I don't understand the problem that this addresses but wouldn't you get the same affect by declaring those targets as PHONY ? >>> >>> David >>> >>> PS. Unrelated but I was astounded to see that bsd/Makefile and linux/Makefile both have a chunk of code conditional on "ifeq ($(OSNAME),solaris)" Huh! >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From henri.gomez at gmail.com Thu Jun 21 15:53:03 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Thu, 21 Jun 2012 17:53:03 +0200 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> Message-ID: universal build, on OSX ? Happy to see that some works/fixes around it :) BTW, how did you get in trouble since universal build is disabled for now unless some code is added to : There was an old thread on jdk7u-dev list and a proposed patch for review (http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-build.patch) 2012/6/21 Staffan Larsen : > [adding build-dev and macosx-port-dev] > > On 21 jun 2012, at 14:43, David Holmes wrote: > >> On 21/06/2012 10:30 PM, Staffan Larsen wrote: >>> Do you mean: >>> >>> .PHONY: $(UNIVERSAL_LIPO_LIST) $(UNIVERSAL_COPY_LIST) >> >> Yes. Now they will always be rebuilt. >> >>> Yes, that seems to have the same effect. Probably a better solution. >> >> I think both of these simply mask the real problem. I still don't understand how only some of the list items get "rebuilt". The CR says >> >> "These targets will only be run for the last item in the xxx_LIST variables (which happens to be the client jvm)" >> >> but I don't understand why that is? > > Neither do I. Makefiles is black magic to me. I only discovered that building the complete JDK from the top-level directory did not update the hotspot bits in the j2sdk-image and this was the ultimate cause. > > Here is an updated webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.02/ > > Thanks, > /Staffan > > >> But I also don't understand this universalization process. >> >> BTW you might want to run this past the bsd-port folks (don't recall the exact alias) and/or build-dev. I seem to recall that last time we changed something to do with universal builds it actually broke something. >> >> David >> >>> Thanks, >>> /Staffan >>> >>> On 21 jun 2012, at 14:12, David Holmes wrote: >>> >>>> Hi Staffan, >>>> >>>> On 21/06/2012 6:33 PM, Staffan Larsen wrote: >>>>> Please review the following fix to makefiles for universal binaries on >>>>> max os x. The idea is to force the target to be executed for all items >>>>> in the list. >>>>> >>>>> Fix contributed by Rickard B?ckman (rbackman). >>>>> >>>>> webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.01/ >>>> >>>> I don't understand the problem that this addresses but wouldn't you get the same affect by declaring those targets as PHONY ? >>>> >>>> David >>>> >>>> PS. Unrelated but I was astounded to see that bsd/Makefile and linux/Makefile both have a chunk of code conditional on "ifeq ($(OSNAME),solaris)" Huh! >>> > From kelly.ohair at oracle.com Thu Jun 21 16:19:13 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 21 Jun 2012 09:19:13 -0700 Subject: get_source/hgforest.sh breaks "defpath -dgu" In-Reply-To: <4FE26F9D.1030502@oracle.com> References: <4FE26F9D.1030502@oracle.com> Message-ID: The key is how you ran the initial clone command, did you do this: hg clone http://hg.openjdk.java.net/jdk8/tl yourTL OR hg clone http://hg.openjdk.java.net/jdk8/tl/ yourTL I could change the make/scripts/hgforest.sh to not append / when the base path already has it. -kto On Jun 20, 2012, at 5:49 PM, David Holmes wrote: > I just cloned the complete TL JDK8 forest by cloning the top repo then using get_source.sh to clone the other repos (open and closed). > > At the top-level hgdefpath shows > > /export/users/dh198349/jdk8 > hg defpath > default = http://hg.openjdk.java.net/jdk8/tl/ > default-push = None > > I then went into the jdk repo to run "hg defpath -dgu dholmes" and got: > > abort: http://hg.openjdk.java.net/jdk8/tl//jdk: Repository not found > No hgrc files updated > > Note the // prior to jdk. If I edit .hgrc/hgrc to change that to a / the defpath works. > > Note that clones/pulls etc don't care about the // but the "defpath -dg" does. > > All of the clones initiated via hgforest.sh have the // eg: > > # Repos: corba jaxp jaxws langtools jdk hotspot jdk/src/closed jdk/make/closed jdk/test/closed hotspot/src/closed hotspot/test/closed deploy install sponsors pubs > Starting on corba > Starting on jaxp > Starting on jaxws > Starting on langtools > # hg clone http://hg.openjdk.java.net/jdk8/tl//corba corba > > David > From staffan.larsen at oracle.com Thu Jun 21 16:54:46 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 21 Jun 2012 18:54:46 +0200 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> Message-ID: At least for me, MACOSX_UNIVERSAL ends up being set to true in hotspot/make/bsd/makefiles/defs.make. Line 186 and forward: # Universal build settings ifeq ($(OS_VENDOR), Darwin) # Build universal binaries by default on Mac OS X MACOSX_UNIVERSAL = true If this isn't intentional, then the fix for my problem is something else. /Staffan On 21 jun 2012, at 17:53, Henri Gomez wrote: > universal build, on OSX ? Happy to see that some works/fixes around it :) > > BTW, how did you get in trouble since universal build is disabled for > now unless some code is added to : > > There was an old thread on jdk7u-dev list and a proposed patch for > review (http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-build.patch) > > > > > > 2012/6/21 Staffan Larsen : >> [adding build-dev and macosx-port-dev] >> >> On 21 jun 2012, at 14:43, David Holmes wrote: >> >>> On 21/06/2012 10:30 PM, Staffan Larsen wrote: >>>> Do you mean: >>>> >>>> .PHONY: $(UNIVERSAL_LIPO_LIST) $(UNIVERSAL_COPY_LIST) >>> >>> Yes. Now they will always be rebuilt. >>> >>>> Yes, that seems to have the same effect. Probably a better solution. >>> >>> I think both of these simply mask the real problem. I still don't understand how only some of the list items get "rebuilt". The CR says >>> >>> "These targets will only be run for the last item in the xxx_LIST variables (which happens to be the client jvm)" >>> >>> but I don't understand why that is? >> >> Neither do I. Makefiles is black magic to me. I only discovered that building the complete JDK from the top-level directory did not update the hotspot bits in the j2sdk-image and this was the ultimate cause. >> >> Here is an updated webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.02/ >> >> Thanks, >> /Staffan >> >> >>> But I also don't understand this universalization process. >>> >>> BTW you might want to run this past the bsd-port folks (don't recall the exact alias) and/or build-dev. I seem to recall that last time we changed something to do with universal builds it actually broke something. >>> >>> David >>> >>>> Thanks, >>>> /Staffan >>>> >>>> On 21 jun 2012, at 14:12, David Holmes wrote: >>>> >>>>> Hi Staffan, >>>>> >>>>> On 21/06/2012 6:33 PM, Staffan Larsen wrote: >>>>>> Please review the following fix to makefiles for universal binaries on >>>>>> max os x. The idea is to force the target to be executed for all items >>>>>> in the list. >>>>>> >>>>>> Fix contributed by Rickard B?ckman (rbackman). >>>>>> >>>>>> webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.01/ >>>>> >>>>> I don't understand the problem that this addresses but wouldn't you get the same affect by declaring those targets as PHONY ? >>>>> >>>>> David >>>>> >>>>> PS. Unrelated but I was astounded to see that bsd/Makefile and linux/Makefile both have a chunk of code conditional on "ifeq ($(OSNAME),solaris)" Huh! >>>> >> From daniel.daugherty at oracle.com Thu Jun 21 17:08:48 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 21 Jun 2012 11:08:48 -0600 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> Message-ID: <4FE35520.6080201@oracle.com> Staffan and Henri, I think you guys are talking about different levels of support for MacOS X Universal builds. Staffan's change is in HotSpot which has supported MacOS X Universal builds for a while now. Henri is talking about the forest of repos which does not currently support MacOS X Universal builds. Dan On 6/21/12 10:54 AM, Staffan Larsen wrote: > At least for me, MACOSX_UNIVERSAL ends up being set to true in hotspot/make/bsd/makefiles/defs.make. > > Line 186 and forward: > > # Universal build settings > ifeq ($(OS_VENDOR), Darwin) > # Build universal binaries by default on Mac OS X > MACOSX_UNIVERSAL = true > > If this isn't intentional, then the fix for my problem is something else. > > /Staffan > > On 21 jun 2012, at 17:53, Henri Gomez wrote: > >> universal build, on OSX ? Happy to see that some works/fixes around it :) >> >> BTW, how did you get in trouble since universal build is disabled for >> now unless some code is added to : >> >> There was an old thread on jdk7u-dev list and a proposed patch for >> review (http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-build.patch) >> >> >> >> >> >> 2012/6/21 Staffan Larsen: >>> [adding build-dev and macosx-port-dev] >>> >>> On 21 jun 2012, at 14:43, David Holmes wrote: >>> >>>> On 21/06/2012 10:30 PM, Staffan Larsen wrote: >>>>> Do you mean: >>>>> >>>>> .PHONY: $(UNIVERSAL_LIPO_LIST) $(UNIVERSAL_COPY_LIST) >>>> Yes. Now they will always be rebuilt. >>>> >>>>> Yes, that seems to have the same effect. Probably a better solution. >>>> I think both of these simply mask the real problem. I still don't understand how only some of the list items get "rebuilt". The CR says >>>> >>>> "These targets will only be run for the last item in the xxx_LIST variables (which happens to be the client jvm)" >>>> >>>> but I don't understand why that is? >>> Neither do I. Makefiles is black magic to me. I only discovered that building the complete JDK from the top-level directory did not update the hotspot bits in the j2sdk-image and this was the ultimate cause. >>> >>> Here is an updated webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.02/ >>> >>> Thanks, >>> /Staffan >>> >>> >>>> But I also don't understand this universalization process. >>>> >>>> BTW you might want to run this past the bsd-port folks (don't recall the exact alias) and/or build-dev. I seem to recall that last time we changed something to do with universal builds it actually broke something. >>>> >>>> David >>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>>>> On 21 jun 2012, at 14:12, David Holmes wrote: >>>>> >>>>>> Hi Staffan, >>>>>> >>>>>> On 21/06/2012 6:33 PM, Staffan Larsen wrote: >>>>>>> Please review the following fix to makefiles for universal binaries on >>>>>>> max os x. The idea is to force the target to be executed for all items >>>>>>> in the list. >>>>>>> >>>>>>> Fix contributed by Rickard B?ckman (rbackman). >>>>>>> >>>>>>> webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.01/ >>>>>> I don't understand the problem that this addresses but wouldn't you get the same affect by declaring those targets as PHONY ? >>>>>> >>>>>> David >>>>>> >>>>>> PS. Unrelated but I was astounded to see that bsd/Makefile and linux/Makefile both have a chunk of code conditional on "ifeq ($(OSNAME),solaris)" Huh! From scott.kovatch at oracle.com Thu Jun 21 17:12:04 2012 From: scott.kovatch at oracle.com (Scott Kovatch) Date: Thu, 21 Jun 2012 10:12:04 -0700 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> Message-ID: 54 # Package built libraries in a universal binary 55 $(UNIVERSAL_LIPO_LIST): 56 BUILT_LIPO_FILES="`find $(EXPORT_JRE_LIB_DIR)/{i386,amd64}/$(subst $(EXPORT_JRE_LIB_DIR)/,,$@) 2>/dev/null`"; \ 57 if [ -n "$${BUILT_LIPO_FILES}" ]; then \ 58 $(MKDIR) -p $(shell dirname $@); \ 59 lipo -create -output $@ $${BUILT_LIPO_FILES}; \ 60 fi 61 62 63 # Copy built non-universal binaries in place 64 $(UNIVERSAL_COPY_LIST): 65 BUILT_COPY_FILES="`find $(EXPORT_JRE_LIB_DIR)/{i386,amd64}/$(subst $(EXPORT_JRE_LIB_DIR)/,,$@) 2>/dev/null`"; \ 66 if [ -n "$${BUILT_COPY_FILES}" ]; then \ 67 for i in $${BUILT_COPY_FILES}; do \ 68 if [ -f $${i} ]; then \ 69 $(MKDIR) -p $(shell dirname $@); \ 70 $(CP) $${i} $@; \ 71 fi; \ 72 done; \ 73 fi 74 This first item will find all object files that were built separately for i386 and amd64 architectures, and then use 'lipo -create -output ?' to create a single universal binary. The next phase copies those combined, universal binaries into EXPORT_JRE_LIB_DIR, since the Mac has never had/needed to break out libraries by architecture. So, it sounds like when you rebuilt, everything was built into jre/lib/i386 and jre/lib/amd64, but never combined (or, in this case, just copied) into jre/lib, and therefore not found. Since we only build x86_64 the lipo command is effectively a cp. -- Scott On Jun 21, 2012, at 9:54 AM, Staffan Larsen wrote: > At least for me, MACOSX_UNIVERSAL ends up being set to true in hotspot/make/bsd/makefiles/defs.make. > > Line 186 and forward: > > # Universal build settings > ifeq ($(OS_VENDOR), Darwin) > # Build universal binaries by default on Mac OS X > MACOSX_UNIVERSAL = true > > If this isn't intentional, then the fix for my problem is something else. > > /Staffan > > On 21 jun 2012, at 17:53, Henri Gomez wrote: > >> universal build, on OSX ? Happy to see that some works/fixes around it :) >> >> BTW, how did you get in trouble since universal build is disabled for >> now unless some code is added to : >> >> There was an old thread on jdk7u-dev list and a proposed patch for >> review (http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-build.patch) >> >> >> >> >> >> 2012/6/21 Staffan Larsen : >>> [adding build-dev and macosx-port-dev] >>> >>> On 21 jun 2012, at 14:43, David Holmes wrote: >>> >>>> On 21/06/2012 10:30 PM, Staffan Larsen wrote: >>>>> Do you mean: >>>>> >>>>> .PHONY: $(UNIVERSAL_LIPO_LIST) $(UNIVERSAL_COPY_LIST) >>>> >>>> Yes. Now they will always be rebuilt. >>>> >>>>> Yes, that seems to have the same effect. Probably a better solution. >>>> >>>> I think both of these simply mask the real problem. I still don't understand how only some of the list items get "rebuilt". The CR says >>>> >>>> "These targets will only be run for the last item in the xxx_LIST variables (which happens to be the client jvm)" >>>> >>>> but I don't understand why that is? >>> >>> Neither do I. Makefiles is black magic to me. I only discovered that building the complete JDK from the top-level directory did not update the hotspot bits in the j2sdk-image and this was the ultimate cause. >>> >>> Here is an updated webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.02/ >>> >>> Thanks, >>> /Staffan >>> >>> >>>> But I also don't understand this universalization process. >>>> >>>> BTW you might want to run this past the bsd-port folks (don't recall the exact alias) and/or build-dev. I seem to recall that last time we changed something to do with universal builds it actually broke something. >>>> >>>> David >>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>>>> On 21 jun 2012, at 14:12, David Holmes wrote: >>>>> >>>>>> Hi Staffan, >>>>>> >>>>>> On 21/06/2012 6:33 PM, Staffan Larsen wrote: >>>>>>> Please review the following fix to makefiles for universal binaries on >>>>>>> max os x. The idea is to force the target to be executed for all items >>>>>>> in the list. >>>>>>> >>>>>>> Fix contributed by Rickard B?ckman (rbackman). >>>>>>> >>>>>>> webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.01/ >>>>>> >>>>>> I don't understand the problem that this addresses but wouldn't you get the same affect by declaring those targets as PHONY ? >>>>>> >>>>>> David >>>>>> >>>>>> PS. Unrelated but I was astounded to see that bsd/Makefile and linux/Makefile both have a chunk of code conditional on "ifeq ($(OSNAME),solaris)" Huh! >>>>> >>> > From staffan.larsen at oracle.com Thu Jun 21 18:25:01 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 21 Jun 2012 20:25:01 +0200 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> Message-ID: On 21 jun 2012, at 19:12, Scott Kovatch wrote: > 54 # Package built libraries in a universal binary > 55 $(UNIVERSAL_LIPO_LIST): > 56 BUILT_LIPO_FILES="`find $(EXPORT_JRE_LIB_DIR)/{i386,amd64}/$(subst $(EXPORT_JRE_LIB_DIR)/,,$@) 2>/dev/null`"; \ > 57 if [ -n "$${BUILT_LIPO_FILES}" ]; then \ > 58 $(MKDIR) -p $(shell dirname $@); \ > 59 lipo -create -output $@ $${BUILT_LIPO_FILES}; \ > 60 fi > 61 > 62 > 63 # Copy built non-universal binaries in place > 64 $(UNIVERSAL_COPY_LIST): > 65 BUILT_COPY_FILES="`find $(EXPORT_JRE_LIB_DIR)/{i386,amd64}/$(subst $(EXPORT_JRE_LIB_DIR)/,,$@) 2>/dev/null`"; \ > 66 if [ -n "$${BUILT_COPY_FILES}" ]; then \ > 67 for i in $${BUILT_COPY_FILES}; do \ > 68 if [ -f $${i} ]; then \ > 69 $(MKDIR) -p $(shell dirname $@); \ > 70 $(CP) $${i} $@; \ > 71 fi; \ > 72 done; \ > 73 fi > 74 > > This first item will find all object files that were built separately for i386 and amd64 architectures, and then use 'lipo -create -output ?' to create a single universal binary. > > The next phase copies those combined, universal binaries into EXPORT_JRE_LIB_DIR, since the Mac has never had/needed to break out libraries by architecture. > > So, it sounds like when you rebuilt, everything was built into jre/lib/i386 and jre/lib/amd64, but never combined (or, in this case, just copied) into jre/lib, and therefore not found. Yes. Or rather, only the client jvm was combined, but the client jvm isn't copied into the j2sdk-image on mac, so nothing was copied. /Staffan > > Since we only build x86_64 the lipo command is effectively a cp. > > -- Scott > > > On Jun 21, 2012, at 9:54 AM, Staffan Larsen wrote: > >> At least for me, MACOSX_UNIVERSAL ends up being set to true in hotspot/make/bsd/makefiles/defs.make. >> >> Line 186 and forward: >> >> # Universal build settings >> ifeq ($(OS_VENDOR), Darwin) >> # Build universal binaries by default on Mac OS X >> MACOSX_UNIVERSAL = true >> >> If this isn't intentional, then the fix for my problem is something else. >> >> /Staffan >> >> On 21 jun 2012, at 17:53, Henri Gomez wrote: >> >>> universal build, on OSX ? Happy to see that some works/fixes around it :) >>> >>> BTW, how did you get in trouble since universal build is disabled for >>> now unless some code is added to : >>> >>> There was an old thread on jdk7u-dev list and a proposed patch for >>> review (http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-build.patch) >>> >>> >>> >>> >>> >>> 2012/6/21 Staffan Larsen : >>>> [adding build-dev and macosx-port-dev] >>>> >>>> On 21 jun 2012, at 14:43, David Holmes wrote: >>>> >>>>> On 21/06/2012 10:30 PM, Staffan Larsen wrote: >>>>>> Do you mean: >>>>>> >>>>>> .PHONY: $(UNIVERSAL_LIPO_LIST) $(UNIVERSAL_COPY_LIST) >>>>> >>>>> Yes. Now they will always be rebuilt. >>>>> >>>>>> Yes, that seems to have the same effect. Probably a better solution. >>>>> >>>>> I think both of these simply mask the real problem. I still don't understand how only some of the list items get "rebuilt". The CR says >>>>> >>>>> "These targets will only be run for the last item in the xxx_LIST variables (which happens to be the client jvm)" >>>>> >>>>> but I don't understand why that is? >>>> >>>> Neither do I. Makefiles is black magic to me. I only discovered that building the complete JDK from the top-level directory did not update the hotspot bits in the j2sdk-image and this was the ultimate cause. >>>> >>>> Here is an updated webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.02/ >>>> >>>> Thanks, >>>> /Staffan >>>> >>>> >>>>> But I also don't understand this universalization process. >>>>> >>>>> BTW you might want to run this past the bsd-port folks (don't recall the exact alias) and/or build-dev. I seem to recall that last time we changed something to do with universal builds it actually broke something. >>>>> >>>>> David >>>>> >>>>>> Thanks, >>>>>> /Staffan >>>>>> >>>>>> On 21 jun 2012, at 14:12, David Holmes wrote: >>>>>> >>>>>>> Hi Staffan, >>>>>>> >>>>>>> On 21/06/2012 6:33 PM, Staffan Larsen wrote: >>>>>>>> Please review the following fix to makefiles for universal binaries on >>>>>>>> max os x. The idea is to force the target to be executed for all items >>>>>>>> in the list. >>>>>>>> >>>>>>>> Fix contributed by Rickard B?ckman (rbackman). >>>>>>>> >>>>>>>> webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.01/ >>>>>>> >>>>>>> I don't understand the problem that this addresses but wouldn't you get the same affect by declaring those targets as PHONY ? >>>>>>> >>>>>>> David >>>>>>> >>>>>>> PS. Unrelated but I was astounded to see that bsd/Makefile and linux/Makefile both have a chunk of code conditional on "ifeq ($(OSNAME),solaris)" Huh! >>>>>> >>>> >> > From david.holmes at oracle.com Fri Jun 22 01:20:45 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 22 Jun 2012 11:20:45 +1000 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> Message-ID: <4FE3C86D.2080008@oracle.com> On 22/06/2012 4:25 AM, Staffan Larsen wrote: > On 21 jun 2012, at 19:12, Scott Kovatch wrote: > >> 54 # Package built libraries in a universal binary >> 55 $(UNIVERSAL_LIPO_LIST): >> 56 BUILT_LIPO_FILES="`find $(EXPORT_JRE_LIB_DIR)/{i386,amd64}/$(subst $(EXPORT_JRE_LIB_DIR)/,,$@) 2>/dev/null`"; \ >> 57 if [ -n "$${BUILT_LIPO_FILES}" ]; then \ >> 58 $(MKDIR) -p $(shell dirname $@); \ >> 59 lipo -create -output $@ $${BUILT_LIPO_FILES}; \ >> 60 fi >> 61 >> 62 >> 63 # Copy built non-universal binaries in place >> 64 $(UNIVERSAL_COPY_LIST): >> 65 BUILT_COPY_FILES="`find $(EXPORT_JRE_LIB_DIR)/{i386,amd64}/$(subst $(EXPORT_JRE_LIB_DIR)/,,$@) 2>/dev/null`"; \ >> 66 if [ -n "$${BUILT_COPY_FILES}" ]; then \ >> 67 for i in $${BUILT_COPY_FILES}; do \ >> 68 if [ -f $${i} ]; then \ >> 69 $(MKDIR) -p $(shell dirname $@); \ >> 70 $(CP) $${i} $@; \ >> 71 fi; \ >> 72 done; \ >> 73 fi >> 74 >> >> This first item will find all object files that were built separately for i386 and amd64 architectures, and then use 'lipo -create -output ?' to create a single universal binary. >> >> The next phase copies those combined, universal binaries into EXPORT_JRE_LIB_DIR, since the Mac has never had/needed to break out libraries by architecture. I'm not sure what "next phase" relates to here. The two chunks in the make file operate on distinct sets of files. >> So, it sounds like when you rebuilt, everything was built into jre/lib/i386 and jre/lib/amd64, but never combined (or, in this case, just copied) into jre/lib, and therefore not found. > > Yes. Or rather, only the client jvm was combined, but the client jvm isn't copied into the j2sdk-image on mac, so nothing was copied. Which begs the question: if we only build 64-bit on OSX then how/why is client being built in the first place? David ----- > /Staffan > >> >> Since we only build x86_64 the lipo command is effectively a cp. >> >> -- Scott >> >> >> On Jun 21, 2012, at 9:54 AM, Staffan Larsen wrote: >> >>> At least for me, MACOSX_UNIVERSAL ends up being set to true in hotspot/make/bsd/makefiles/defs.make. >>> >>> Line 186 and forward: >>> >>> # Universal build settings >>> ifeq ($(OS_VENDOR), Darwin) >>> # Build universal binaries by default on Mac OS X >>> MACOSX_UNIVERSAL = true >>> >>> If this isn't intentional, then the fix for my problem is something else. >>> >>> /Staffan >>> >>> On 21 jun 2012, at 17:53, Henri Gomez wrote: >>> >>>> universal build, on OSX ? Happy to see that some works/fixes around it :) >>>> >>>> BTW, how did you get in trouble since universal build is disabled for >>>> now unless some code is added to : >>>> >>>> There was an old thread on jdk7u-dev list and a proposed patch for >>>> review (http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-build.patch) >>>> >>>> >>>> >>>> >>>> >>>> 2012/6/21 Staffan Larsen: >>>>> [adding build-dev and macosx-port-dev] >>>>> >>>>> On 21 jun 2012, at 14:43, David Holmes wrote: >>>>> >>>>>> On 21/06/2012 10:30 PM, Staffan Larsen wrote: >>>>>>> Do you mean: >>>>>>> >>>>>>> .PHONY: $(UNIVERSAL_LIPO_LIST) $(UNIVERSAL_COPY_LIST) >>>>>> >>>>>> Yes. Now they will always be rebuilt. >>>>>> >>>>>>> Yes, that seems to have the same effect. Probably a better solution. >>>>>> >>>>>> I think both of these simply mask the real problem. I still don't understand how only some of the list items get "rebuilt". The CR says >>>>>> >>>>>> "These targets will only be run for the last item in the xxx_LIST variables (which happens to be the client jvm)" >>>>>> >>>>>> but I don't understand why that is? >>>>> >>>>> Neither do I. Makefiles is black magic to me. I only discovered that building the complete JDK from the top-level directory did not update the hotspot bits in the j2sdk-image and this was the ultimate cause. >>>>> >>>>> Here is an updated webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.02/ >>>>> >>>>> Thanks, >>>>> /Staffan >>>>> >>>>> >>>>>> But I also don't understand this universalization process. >>>>>> >>>>>> BTW you might want to run this past the bsd-port folks (don't recall the exact alias) and/or build-dev. I seem to recall that last time we changed something to do with universal builds it actually broke something. >>>>>> >>>>>> David >>>>>> >>>>>>> Thanks, >>>>>>> /Staffan >>>>>>> >>>>>>> On 21 jun 2012, at 14:12, David Holmes wrote: >>>>>>> >>>>>>>> Hi Staffan, >>>>>>>> >>>>>>>> On 21/06/2012 6:33 PM, Staffan Larsen wrote: >>>>>>>>> Please review the following fix to makefiles for universal binaries on >>>>>>>>> max os x. The idea is to force the target to be executed for all items >>>>>>>>> in the list. >>>>>>>>> >>>>>>>>> Fix contributed by Rickard B?ckman (rbackman). >>>>>>>>> >>>>>>>>> webrev: http://cr.openjdk.java.net/~sla/7178667/webrev.01/ >>>>>>>> >>>>>>>> I don't understand the problem that this addresses but wouldn't you get the same affect by declaring those targets as PHONY ? >>>>>>>> >>>>>>>> David >>>>>>>> >>>>>>>> PS. Unrelated but I was astounded to see that bsd/Makefile and linux/Makefile both have a chunk of code conditional on "ifeq ($(OSNAME),solaris)" Huh! >>>>>>> >>>>> >>> >> > From david.holmes at oracle.com Fri Jun 22 01:54:09 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 22 Jun 2012 11:54:09 +1000 Subject: get_source/hgforest.sh breaks "defpath -dgu" In-Reply-To: References: <4FE26F9D.1030502@oracle.com> Message-ID: <4FE3D041.10506@oracle.com> On 22/06/2012 2:19 AM, Kelly O'Hair wrote: > The key is how you ran the initial clone command, did you do this: > > hg clone http://hg.openjdk.java.net/jdk8/tl yourTL > > OR > > hg clone http://hg.openjdk.java.net/jdk8/tl/ yourTL The latter. It really shouldn't matter of course. > I could change the make/scripts/hgforest.sh to not append / when the base path already has it. BTW for the closed repos the // was in two places - again presumably because the "extra path" ended in / Arguably it is a mercurial bug - it should ignore // in paths. :( Cheers, David > -kto > > > On Jun 20, 2012, at 5:49 PM, David Holmes wrote: > >> I just cloned the complete TL JDK8 forest by cloning the top repo then using get_source.sh to clone the other repos (open and closed). >> >> At the top-level hgdefpath shows >> >> /export/users/dh198349/jdk8> hg defpath >> default = http://hg.openjdk.java.net/jdk8/tl/ >> default-push = None >> >> I then went into the jdk repo to run "hg defpath -dgu dholmes" and got: >> >> abort: http://hg.openjdk.java.net/jdk8/tl//jdk: Repository not found >> No hgrc files updated >> >> Note the // prior to jdk. If I edit .hgrc/hgrc to change that to a / the defpath works. >> >> Note that clones/pulls etc don't care about the // but the "defpath -dg" does. >> >> All of the clones initiated via hgforest.sh have the // eg: >> >> # Repos: corba jaxp jaxws langtools jdk hotspot jdk/src/closed jdk/make/closed jdk/test/closed hotspot/src/closed hotspot/test/closed deploy install sponsors pubs >> Starting on corba >> Starting on jaxp >> Starting on jaxws >> Starting on langtools >> # hg clone http://hg.openjdk.java.net/jdk8/tl//corba corba >> >> David >> > From henri.gomez at gmail.com Fri Jun 22 07:08:57 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Fri, 22 Jun 2012 09:08:57 +0200 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: <4FE35520.6080201@oracle.com> References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> <4FE35520.6080201@oracle.com> Message-ID: > Staffan and Henri, > > I think you guys are talking about different levels of support > for MacOS X Universal builds. Staffan's change is in HotSpot > which has supported MacOS X Universal builds for a while now. > > Henri is talking about the forest of repos which does not > currently support MacOS X Universal builds. If HotSpot support MacOS X Universal build, may be I could find here some support to fix a problem I get with my OpenJDK 7 universal build when using 32bits supper (-d32) and server mode (no problem in client mode). ... INFO: AJP13 Listener started: port=8009 juin 22, 2012 9:02:16 AM winstone.Logger logInternal INFO: Winstone Servlet Engine v0.9.10 running: controlPort=disabled juin 22, 2012 9:02:17 AM jenkins.InitReactorRunner$1 onAttained INFO: Started initialization # # A fatal error has been detected by the Java Runtime Environment: # # SIGBUS (0xa) at pc=0x00f5cb88, pid=495, tid=19971 # # JRE version: 7.0 # Java VM: OpenJDK Server VM (23.2-b05 mixed mode bsd-x86 ) # Problematic frame: # J sun.util.calendar.ZoneInfo.getOffsets(J[II)I # # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again # # An error report file with more information is saved as: # /Users/henri/Downloads/jenkins/hs_err_pid495.log It is easily reproducible : - Install OpenJDK 7 (from jdk7u-dev built in universal mode) from my googlecode site : http://openjdk-osx-build.googlecode.com/files/OpenJDK-OSX-1.7-universal-u-jdk-jdk7u5-b30-20120621.dmg) Then : export JAVA_HOME=/Library/Java/JavaVirtualMachines/1.7.0u.jdk/Contents/Home mkdir jenkins cd jenkins curl -L http://mirrors.jenkins-ci.org/war/latest/jenkins.war -o jenkins.war mkdir data export JENKINS_HOME=`pwd`/data java -d32 -jar jenkins.war And there is no problem using -d32 -client or -d64. Any help from Hotspot guys will be very useful since this problem prevent me to ask for universal patch to be reintroduce in OpenJDK 7 and 8. Thanks From henri.gomez at gmail.com Fri Jun 22 09:51:59 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Fri, 22 Jun 2012 11:51:59 +0200 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: <275E05A0-0934-4AAF-9C1B-F6B49D6DEC69@sudo.ch> References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> <4FE35520.6080201@oracle.com> <275E05A0-0934-4AAF-9C1B-F6B49D6DEC69@sudo.ch> Message-ID: Interesting. Problem disappears at some point but came back when rebuilding in universal mode. It will be interesting to find relative fix, may be it's needed in my patch (mainly back port of macosx-port codes) 2012/6/22 David Kocher : > I remember having seen this before [1]. > > [1] http://java.net/jira/browse/MACOSX_PORT-521 > > On 22.06.2012, at 09:08, Henri Gomez wrote: > >>> Staffan and Henri, >>> >>> I think you guys are talking about different levels of support >>> for MacOS X Universal builds. Staffan's change is in HotSpot >>> which has supported MacOS X Universal builds for a while now. >>> >>> Henri is talking about the forest of repos which does not >>> currently support MacOS X Universal builds. >> >> If HotSpot support MacOS X Universal build, may be I could find here >> some support to fix a problem I get with my OpenJDK 7 universal build >> when using 32bits supper (-d32) and server mode (no problem in client >> mode). >> >> ... >> >> INFO: AJP13 Listener started: port=8009 >> juin 22, 2012 9:02:16 AM winstone.Logger logInternal >> INFO: Winstone Servlet Engine v0.9.10 running: controlPort=disabled >> juin 22, 2012 9:02:17 AM jenkins.InitReactorRunner$1 onAttained >> INFO: Started initialization >> # >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # ?SIGBUS (0xa) at pc=0x00f5cb88, pid=495, tid=19971 >> # >> # JRE version: 7.0 >> # Java VM: OpenJDK Server VM (23.2-b05 mixed mode bsd-x86 ) >> # Problematic frame: >> # J ?sun.util.calendar.ZoneInfo.getOffsets(J[II)I >> # >> # Failed to write core dump. Core dumps have been disabled. To enable >> core dumping, try "ulimit -c unlimited" before starting Java again >> # >> # An error report file with more information is saved as: >> # /Users/henri/Downloads/jenkins/hs_err_pid495.log >> >> >> It is easily reproducible : >> >> - Install OpenJDK 7 (from jdk7u-dev built in universal mode) from my >> googlecode site : >> >> http://openjdk-osx-build.googlecode.com/files/OpenJDK-OSX-1.7-universal-u-jdk-jdk7u5-b30-20120621.dmg) >> >> Then : >> >> export JAVA_HOME=/Library/Java/JavaVirtualMachines/1.7.0u.jdk/Contents/Home >> >> mkdir jenkins >> cd jenkins >> curl -L http://mirrors.jenkins-ci.org/war/latest/jenkins.war -o jenkins.war >> mkdir data >> export JENKINS_HOME=`pwd`/data >> java -d32 -jar jenkins.war >> >> >> And there is no problem using -d32 -client or -d64. >> >> Any help from Hotspot guys will be very useful since this problem >> prevent me to ask for universal patch to be reintroduce in OpenJDK 7 >> and 8. >> >> Thanks >> > From jonathan.gibbons at oracle.com Fri Jun 22 19:16:17 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 22 Jun 2012 12:16:17 -0700 Subject: Surprising failure after "make sanity" passed Message-ID: <4FE4C481.9020507@oracle.com> A build of tl passed "make sanity" but I still got this error: CC -DSOLARIS -DSPARC_WORKS -DIA32 -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/prims -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/precompiled -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/cpu/x86/vm -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os_cpu/solaris_x86/vm -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/solaris/vm -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/posix/vm -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc -I../generated -DASSERT -DTARGET_OS_FAMILY_solaris -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_32 -DTARGET_OS_ARCH_solaris_x86 -DTARGET_OS_ARCH_MODEL_solaris_x86_32 -DTARGET_COMPILER_sparcWorks -DCOMPILER2 -DCOMPILER1 -DDONT_USE_PRECOMPILED_HEADER -D_REENTRANT -library=Cstd -g -xwe -g -c -o ../generated/adfiles/adlparse.o /tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc/adlparse.cpp make381[6]: CC: Command not found make381[6]: *** [../generated/adfiles/adlparse.o] Error 127 make381[6]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' make381[5]: *** [ad_stuff] Error 2 make381[5]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' make381[4]: *** [product] Error 2 make381[4]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir' make381[3]: *** [generic_build2] Error 2 make381[3]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' make381[2]: *** [product] Error 2 make381[2]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' make381[1]: *** [hotspot-build] Error 2 make381[1]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl' make381: *** [build_product_image] Error 2 From david.holmes at oracle.com Sat Jun 23 00:02:40 2012 From: david.holmes at oracle.com (David Holmes) Date: Sat, 23 Jun 2012 10:02:40 +1000 Subject: Surprising failure after "make sanity" passed In-Reply-To: <4FE4C481.9020507@oracle.com> References: <4FE4C481.9020507@oracle.com> Message-ID: <4FE507A0.1030304@oracle.com> Hi Jon, On 23/06/2012 5:16 AM, Jonathan Gibbons wrote: > A build of tl passed "make sanity" but I still got this error: > > > CC -DSOLARIS -DSPARC_WORKS -DIA32 > -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/prims > -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm > -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/precompiled > -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/cpu/x86/vm > -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os_cpu/solaris_x86/vm > -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/solaris/vm > -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/posix/vm > -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc > -I../generated -DASSERT -DTARGET_OS_FAMILY_solaris -DTARGET_ARCH_x86 > -DTARGET_ARCH_MODEL_x86_32 -DTARGET_OS_ARCH_solaris_x86 > -DTARGET_OS_ARCH_MODEL_solaris_x86_32 -DTARGET_COMPILER_sparcWorks > -DCOMPILER2 -DCOMPILER1 -DDONT_USE_PRECOMPILED_HEADER -D_REENTRANT > -library=Cstd -g -xwe -g -c -o ../generated/adfiles/adlparse.o > /tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc/adlparse.cpp > make381[6]: CC: Command not found Was this a JDK sanity check or hotspot? hotspot doesn't really do any sanity checking of its own. What did the sanity check report? David ----- > make381[6]: *** [../generated/adfiles/adlparse.o] Error 127 > make381[6]: Leaving directory > `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' > > make381[5]: *** [ad_stuff] Error 2 > make381[5]: Leaving directory > `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' > > make381[4]: *** [product] Error 2 > make381[4]: Leaving directory > `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir' > make381[3]: *** [generic_build2] Error 2 > make381[3]: Leaving directory > `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' > make381[2]: *** [product] Error 2 > make381[2]: Leaving directory > `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' > make381[1]: *** [hotspot-build] Error 2 > make381[1]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl' > make381: *** [build_product_image] Error 2 > From jonathan.gibbons at oracle.com Sat Jun 23 00:15:49 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 22 Jun 2012 17:15:49 -0700 Subject: Surprising failure after "make sanity" passed In-Reply-To: <4FE507A0.1030304@oracle.com> References: <4FE4C481.9020507@oracle.com> <4FE507A0.1030304@oracle.com> Message-ID: <4FE50AB5.2040506@oracle.com> I was doing a top level build, which complained about a few things until I fixed them up. But then the check seemed to be OK and the build proceeded OK, until it ran into this issue, and then another issue -- something that was brought in from /usr/sfw because of the default setting to enable debug symbols. Once I figured out how to disable them, I finally got a build to proceed. I presume the new build system will be better at determining up front everything that will be needed during the build. -- Jon On 06/22/2012 05:02 PM, David Holmes wrote: > Hi Jon, > > On 23/06/2012 5:16 AM, Jonathan Gibbons wrote: >> A build of tl passed "make sanity" but I still got this error: >> >> >> CC -DSOLARIS -DSPARC_WORKS -DIA32 >> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/prims >> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm >> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/precompiled >> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/cpu/x86/vm >> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os_cpu/solaris_x86/vm >> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/solaris/vm >> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/posix/vm >> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc >> -I../generated -DASSERT -DTARGET_OS_FAMILY_solaris -DTARGET_ARCH_x86 >> -DTARGET_ARCH_MODEL_x86_32 -DTARGET_OS_ARCH_solaris_x86 >> -DTARGET_OS_ARCH_MODEL_solaris_x86_32 -DTARGET_COMPILER_sparcWorks >> -DCOMPILER2 -DCOMPILER1 -DDONT_USE_PRECOMPILED_HEADER -D_REENTRANT >> -library=Cstd -g -xwe -g -c -o ../generated/adfiles/adlparse.o >> /tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc/adlparse.cpp >> make381[6]: CC: Command not found > > Was this a JDK sanity check or hotspot? hotspot doesn't really do any > sanity checking of its own. What did the sanity check report? > > David > ----- > >> make381[6]: *** [../generated/adfiles/adlparse.o] Error 127 >> make381[6]: Leaving directory >> `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' >> >> >> make381[5]: *** [ad_stuff] Error 2 >> make381[5]: Leaving directory >> `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' >> >> >> make381[4]: *** [product] Error 2 >> make381[4]: Leaving directory >> `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir' >> make381[3]: *** [generic_build2] Error 2 >> make381[3]: Leaving directory >> `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' >> make381[2]: *** [product] Error 2 >> make381[2]: Leaving directory >> `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' >> make381[1]: *** [hotspot-build] Error 2 >> make381[1]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl' >> make381: *** [build_product_image] Error 2 >> From staffan.larsen at oracle.com Mon Jun 25 08:36:25 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 25 Jun 2012 10:36:25 +0200 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: <4FE3C86D.2080008@oracle.com> References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> <4FE3C86D.2080008@oracle.com> Message-ID: <47E96839-1BDB-42F2-BC45-D1A98559813C@oracle.com> >>> So, it sounds like when you rebuilt, everything was built into jre/lib/i386 and jre/lib/amd64, but never combined (or, in this case, just copied) into jre/lib, and therefore not found. >> >> Yes. Or rather, only the client jvm was combined, but the client jvm isn't copied into the j2sdk-image on mac, so nothing was copied. > > Which begs the question: if we only build 64-bit on OSX then how/why is client being built in the first place? I should have said: "only the client jvm was _attempted_ to be combined". In fact, the client does not exist, but the universalize makefiles are written to handle client if it did exist. So what happened was: - the product jvm was built - it was copied to the import jdk (into jre/lib/amd64/server/) by the generic_export target - the universalize makefile tried to take the client jvm and universalize it into jre/lib/client/ (notice that there is no amd64 directory level on mac) - the universalize makefile removes all {amd64,i386} directories What should have happened: - the product jvm was built - it was copied to the import jdk (into jre/lib/amd64/server/) by the generic_export target - the universalize makefile makes a universal binary of any existing jvms (client or server) - the universalize makefile copies these jvms into jre/lib/{server,client} - the universalize makefile removes all {amd64,i386} directories But because the targets weren't .PHONY, the third step above failed. I hope that explains the problem in more detail. Who wants to be put down as reviewer? Thanks, /Staffan From kelly.ohair at oracle.com Tue Jun 26 18:08:11 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 26 Jun 2012 11:08:11 -0700 Subject: Surprising failure after "make sanity" passed In-Reply-To: <4FE50AB5.2040506@oracle.com> References: <4FE4C481.9020507@oracle.com> <4FE507A0.1030304@oracle.com> <4FE50AB5.2040506@oracle.com> Message-ID: Solaris builds will always be tough. You need particular versions of the C/C++ compilers (cc/CC or Sun Studio, or now Oracle Solaris Studio) in your PATH. I'm not sure exactly how this will be dealt with in the new build infrastructure yet. But I'll be looking at it today hopefully. -kto On Jun 22, 2012, at 5:15 PM, Jonathan Gibbons wrote: > I was doing a top level build, which complained about a few things until I fixed them up. But then the check seemed to be OK and the build proceeded OK, until it ran into this issue, and then another issue -- something that was brought in from /usr/sfw because of the default setting to enable debug symbols. Once I figured out how to disable them, I finally got a build to proceed. > > I presume the new build system will be better at determining up front everything that will be needed during the build. > > -- Jon > > On 06/22/2012 05:02 PM, David Holmes wrote: >> Hi Jon, >> >> On 23/06/2012 5:16 AM, Jonathan Gibbons wrote: >>> A build of tl passed "make sanity" but I still got this error: >>> >>> >>> CC -DSOLARIS -DSPARC_WORKS -DIA32 >>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/prims >>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm >>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/precompiled >>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/cpu/x86/vm >>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os_cpu/solaris_x86/vm >>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/solaris/vm >>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/posix/vm >>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc >>> -I../generated -DASSERT -DTARGET_OS_FAMILY_solaris -DTARGET_ARCH_x86 >>> -DTARGET_ARCH_MODEL_x86_32 -DTARGET_OS_ARCH_solaris_x86 >>> -DTARGET_OS_ARCH_MODEL_solaris_x86_32 -DTARGET_COMPILER_sparcWorks >>> -DCOMPILER2 -DCOMPILER1 -DDONT_USE_PRECOMPILED_HEADER -D_REENTRANT >>> -library=Cstd -g -xwe -g -c -o ../generated/adfiles/adlparse.o >>> /tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc/adlparse.cpp >>> make381[6]: CC: Command not found >> >> Was this a JDK sanity check or hotspot? hotspot doesn't really do any sanity checking of its own. What did the sanity check report? >> >> David >> ----- >> >>> make381[6]: *** [../generated/adfiles/adlparse.o] Error 127 >>> make381[6]: Leaving directory >>> `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' >>> >>> make381[5]: *** [ad_stuff] Error 2 >>> make381[5]: Leaving directory >>> `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' >>> >>> make381[4]: *** [product] Error 2 >>> make381[4]: Leaving directory >>> `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir' >>> make381[3]: *** [generic_build2] Error 2 >>> make381[3]: Leaving directory >>> `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' >>> make381[2]: *** [product] Error 2 >>> make381[2]: Leaving directory >>> `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' >>> make381[1]: *** [hotspot-build] Error 2 >>> make381[1]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl' >>> make381: *** [build_product_image] Error 2 >>> > From kelly.ohair at oracle.com Tue Jun 26 18:13:58 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 26 Jun 2012 11:13:58 -0700 Subject: get_source/hgforest.sh breaks "defpath -dgu" In-Reply-To: <4FE3D041.10506@oracle.com> References: <4FE26F9D.1030502@oracle.com> <4FE3D041.10506@oracle.com> Message-ID: <4DF57D53-6A98-4494-9682-FB05C404CFF3@oracle.com> On Jun 21, 2012, at 6:54 PM, David Holmes wrote: > On 22/06/2012 2:19 AM, Kelly O'Hair wrote: >> The key is how you ran the initial clone command, did you do this: >> >> hg clone http://hg.openjdk.java.net/jdk8/tl yourTL >> >> OR >> >> hg clone http://hg.openjdk.java.net/jdk8/tl/ yourTL > > The latter. It really shouldn't matter of course. > >> I could change the make/scripts/hgforest.sh to not append / when the base path already has it. > > BTW for the closed repos the // was in two places - again presumably because the "extra path" ended in / > > Arguably it is a mercurial bug - it should ignore // in paths. :( How about if I add some kind of filter on the paths I create, e.g. sed -e 's@\([^:]/\)//*@\1 at g' ??? -kto > > Cheers, > David > >> -kto >> >> >> On Jun 20, 2012, at 5:49 PM, David Holmes wrote: >> >>> I just cloned the complete TL JDK8 forest by cloning the top repo then using get_source.sh to clone the other repos (open and closed). >>> >>> At the top-level hgdefpath shows >>> >>> /export/users/dh198349/jdk8> hg defpath >>> default = http://hg.openjdk.java.net/jdk8/tl/ >>> default-push = None >>> >>> I then went into the jdk repo to run "hg defpath -dgu dholmes" and got: >>> >>> abort: http://hg.openjdk.java.net/jdk8/tl//jdk: Repository not found >>> No hgrc files updated >>> >>> Note the // prior to jdk. If I edit .hgrc/hgrc to change that to a / the defpath works. >>> >>> Note that clones/pulls etc don't care about the // but the "defpath -dg" does. >>> >>> All of the clones initiated via hgforest.sh have the // eg: >>> >>> # Repos: corba jaxp jaxws langtools jdk hotspot jdk/src/closed jdk/make/closed jdk/test/closed hotspot/src/closed hotspot/test/closed deploy install sponsors pubs >>> Starting on corba >>> Starting on jaxp >>> Starting on jaxws >>> Starting on langtools >>> # hg clone http://hg.openjdk.java.net/jdk8/tl//corba corba >>> >>> David >>> >> From weiqigao at gmail.com Tue Jun 26 19:22:14 2012 From: weiqigao at gmail.com (Weiqi Gao) Date: Tue, 26 Jun 2012 14:22:14 -0500 Subject: Building OpenJDK 6 on Solaris sparc Message-ID: Hi, I'm trying to build OpenJDK 6 and OpenJDK 7 on a variety of machines. I have encountered the following error while building OpenJDK 7 (http://hg.openjdk.java.net/jdk7/jdk7) on Solaris sparc (SunOS cicada2 5.10 Generic_139555-08 sun4u sparc SUNW,Sun-Blade-1000). I'm using the suncc5.10 compiler and the lasted jdk1.6.0_32 from Oracle as the bootstrap JDK. I'm not sure what's the cause of this problem. Can anyone shed some light on it? rm -f copy.o CC -DSOLARIS -DSPARC_WORKS -DSPARC -DPRODUCT -xF -I/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/share/vm/prims -I/home/gaow/pro jects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/share/vm -I/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/cpu/sparc/vm - I/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/os_cpu/solaris_sparc/vm -I/home/gaow/projects1/openjdk-builds/solaris-sparc/openj dk7/hotspot/src/os/solaris/vm -I/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSI ON="\"21.0-b17\"" -DHOTSPOT_BUILD_TARGET="\"product\"" -DHOTSPOT_BUILD_USER="\"gaow\"" -DHOTSPOT_LIB_ARCH=\"sparc\" -DJRE_RELEASE_VERSION="\"1.7.0-intern al-gaow_2012_06_26_13_04-b00\"" -DHOTSPOT_VM_DISTRO="\"OpenJDK\"" -DTARGET_OS_FAMILY_solaris -DTARGET_ARCH_sparc -DTARGET_ARCH_MODEL_sparc -DTARGET_OS_AR CH_solaris_sparc -DTARGET_OS_ARCH_MODEL_solaris_sparc -DTARGET_COMPILER_sparcWorks -DCOMPILER2 -DCOMPILER1 -DDONT_USE_PRECOMPILED_HEADER -xmemalign=4s -m 32 -xarch=sparc /home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/os_cpu/solaris_sparc/vm/solaris_sparc.il -template=no%extdef -feat ures=no%split_init -D_Crun_inline_placement -library=%none -KPIC -mt -xdebugformat=stabs -xO4 -features=no%except -DHAVE_DTRACE_H -DDTRACE_ENABLED - c -xMMD -xMF ../generated/dependencies/copy.o.d -o copy.o /home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/share/vm/utilities/copy. cpp cg: assertion failed in file ../src/sparc/block_edges.cc at line 581 cg: block_edges.accumulate_successors: bad state cg: 1 errors make[6]: *** [copy.o] Error 1 make[6]: Leaving directory `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/build/solaris-sparc/hotspot/outputdir/solaris_sparc_compiler2/prod uct' make[5]: *** [the_vm] Error 2 make[5]: Leaving directory `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/build/solaris-sparc/hotspot/outputdir/solaris_sparc_compiler2/prod uct' make[4]: *** [product] Error 2 make[4]: Leaving directory `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/build/solaris-sparc/hotspot/outputdir' make[3]: *** [generic_build2] Error 2 make[3]: Leaving directory `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/make' make[2]: *** [product] Error 2 make[2]: Leaving directory `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/make' make[1]: *** [hotspot-build] Error 2 make[1]: Leaving directory `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7' make: *** [build_product_image] Error 2 -- Weiqi Gao (???) weiqigao at gmail.com http://www.weiqigao.com/blog/ From John.Coomes at oracle.com Tue Jun 26 21:17:44 2012 From: John.Coomes at oracle.com (John Coomes) Date: Tue, 26 Jun 2012 14:17:44 -0700 Subject: Building OpenJDK 6 on Solaris sparc In-Reply-To: References: Message-ID: <20458.9976.569424.798712@oracle.com> Weiqi Gao (weiqigao at gmail.com) wrote: > Hi, > > I'm trying to build OpenJDK 6 and OpenJDK 7 on a variety of machines. > I have encountered the following error while building OpenJDK 7 > (http://hg.openjdk.java.net/jdk7/jdk7) on Solaris sparc (SunOS cicada2 > 5.10 Generic_139555-08 sun4u sparc SUNW,Sun-Blade-1000). I'm using > the suncc5.10 compiler and the lasted jdk1.6.0_32 from Oracle as the > bootstrap JDK. > > I'm not sure what's the cause of this problem. Can anyone shed some > light on it? > > rm -f copy.o > CC -DSOLARIS -DSPARC_WORKS -DSPARC -DPRODUCT -xF > ... > cg: assertion failed in file ../src/sparc/block_edges.cc at line 581 > cg: block_edges.accumulate_successors: bad state > cg: 1 errors Hi, That's a bug in the compiler backend. Make sure you have applied the patches listed in the README-builds.html file: http://hg.openjdk.java.net/jdk7/jdk7/raw-file/dada8003df87/README-builds.html#studio -John From david.holmes at oracle.com Tue Jun 26 21:28:01 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 27 Jun 2012 07:28:01 +1000 Subject: get_source/hgforest.sh breaks "defpath -dgu" In-Reply-To: <4DF57D53-6A98-4494-9682-FB05C404CFF3@oracle.com> References: <4FE26F9D.1030502@oracle.com> <4FE3D041.10506@oracle.com> <4DF57D53-6A98-4494-9682-FB05C404CFF3@oracle.com> Message-ID: <4FEA2961.7070707@oracle.com> On 27/06/2012 4:13 AM, Kelly O'Hair wrote: > > On Jun 21, 2012, at 6:54 PM, David Holmes wrote: > >> On 22/06/2012 2:19 AM, Kelly O'Hair wrote: >>> The key is how you ran the initial clone command, did you do this: >>> >>> hg clone http://hg.openjdk.java.net/jdk8/tl yourTL >>> >>> OR >>> >>> hg clone http://hg.openjdk.java.net/jdk8/tl/ yourTL >> >> The latter. It really shouldn't matter of course. >> >>> I could change the make/scripts/hgforest.sh to not append / when the base path already has it. >> >> BTW for the closed repos the // was in two places - again presumably because the "extra path" ended in / >> >> Arguably it is a mercurial bug - it should ignore // in paths. :( > > How about if I add some kind of filter on the paths I create, e.g. > sed -e 's@\([^:]/\)//*@\1 at g' > > ??? If that works great! I don't read regex fluently :( David > -kto > >> >> Cheers, >> David >> >>> -kto >>> >>> >>> On Jun 20, 2012, at 5:49 PM, David Holmes wrote: >>> >>>> I just cloned the complete TL JDK8 forest by cloning the top repo then using get_source.sh to clone the other repos (open and closed). >>>> >>>> At the top-level hgdefpath shows >>>> >>>> /export/users/dh198349/jdk8> hg defpath >>>> default = http://hg.openjdk.java.net/jdk8/tl/ >>>> default-push = None >>>> >>>> I then went into the jdk repo to run "hg defpath -dgu dholmes" and got: >>>> >>>> abort: http://hg.openjdk.java.net/jdk8/tl//jdk: Repository not found >>>> No hgrc files updated >>>> >>>> Note the // prior to jdk. If I edit .hgrc/hgrc to change that to a / the defpath works. >>>> >>>> Note that clones/pulls etc don't care about the // but the "defpath -dg" does. >>>> >>>> All of the clones initiated via hgforest.sh have the // eg: >>>> >>>> # Repos: corba jaxp jaxws langtools jdk hotspot jdk/src/closed jdk/make/closed jdk/test/closed hotspot/src/closed hotspot/test/closed deploy install sponsors pubs >>>> Starting on corba >>>> Starting on jaxp >>>> Starting on jaxws >>>> Starting on langtools >>>> # hg clone http://hg.openjdk.java.net/jdk8/tl//corba corba >>>> >>>> David >>>> >>> > From kelly.ohair at oracle.com Tue Jun 26 21:54:17 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 26 Jun 2012 14:54:17 -0700 Subject: get_source/hgforest.sh breaks "defpath -dgu" In-Reply-To: <4FEA2961.7070707@oracle.com> References: <4FE26F9D.1030502@oracle.com> <4FE3D041.10506@oracle.com> <4DF57D53-6A98-4494-9682-FB05C404CFF3@oracle.com> <4FEA2961.7070707@oracle.com> Message-ID: <54464907-954E-48F4-9110-8B54C33B8006@oracle.com> Here is the diff: diff --git a/make/scripts/hgforest.sh b/make/scripts/hgforest.sh --- a/make/scripts/hgforest.sh +++ b/make/scripts/hgforest.sh @@ -98,7 +98,8 @@ ( ( if [ "${command}" = "clone" -o "${command}" = "fclone" ] ; then - cline="hg clone ${pull_default}/${i} ${i}" + pull_newrepo="`echo ${pull_default}/${i} | sed -e 's@\([^:]/\)//*@\1 at g'`" + cline="hg clone ${pull_newrepo} ${i}" echo "# ${cline}" ( eval "${cline}" ) else @@ -121,7 +122,8 @@ n=`expr ${n} '+' 1` ( ( - cline="hg clone ${pull_extra}/${i} ${i}" + pull_newextrarepo="`echo ${pull_extra}/${i} | sed -e 's@\([^:]/\)//*@\1 at g'`" + cline="hg clone ${pull_newextrarepo} ${i}" echo "# ${cline}" ( eval "${cline}" ) echo "# exit code $?" -kto On Jun 26, 2012, at 2:28 PM, David Holmes wrote: > On 27/06/2012 4:13 AM, Kelly O'Hair wrote: >> >> On Jun 21, 2012, at 6:54 PM, David Holmes wrote: >> >>> On 22/06/2012 2:19 AM, Kelly O'Hair wrote: >>>> The key is how you ran the initial clone command, did you do this: >>>> >>>> hg clone http://hg.openjdk.java.net/jdk8/tl yourTL >>>> >>>> OR >>>> >>>> hg clone http://hg.openjdk.java.net/jdk8/tl/ yourTL >>> >>> The latter. It really shouldn't matter of course. >>> >>>> I could change the make/scripts/hgforest.sh to not append / when the base path already has it. >>> >>> BTW for the closed repos the // was in two places - again presumably because the "extra path" ended in / >>> >>> Arguably it is a mercurial bug - it should ignore // in paths. :( >> >> How about if I add some kind of filter on the paths I create, e.g. >> sed -e 's@\([^:]/\)//*@\1 at g' >> >> ??? > > If that works great! I don't read regex fluently :( > > David > >> -kto >> >>> >>> Cheers, >>> David >>> >>>> -kto >>>> >>>> >>>> On Jun 20, 2012, at 5:49 PM, David Holmes wrote: >>>> >>>>> I just cloned the complete TL JDK8 forest by cloning the top repo then using get_source.sh to clone the other repos (open and closed). >>>>> >>>>> At the top-level hgdefpath shows >>>>> >>>>> /export/users/dh198349/jdk8> hg defpath >>>>> default = http://hg.openjdk.java.net/jdk8/tl/ >>>>> default-push = None >>>>> >>>>> I then went into the jdk repo to run "hg defpath -dgu dholmes" and got: >>>>> >>>>> abort: http://hg.openjdk.java.net/jdk8/tl//jdk: Repository not found >>>>> No hgrc files updated >>>>> >>>>> Note the // prior to jdk. If I edit .hgrc/hgrc to change that to a / the defpath works. >>>>> >>>>> Note that clones/pulls etc don't care about the // but the "defpath -dg" does. >>>>> >>>>> All of the clones initiated via hgforest.sh have the // eg: >>>>> >>>>> # Repos: corba jaxp jaxws langtools jdk hotspot jdk/src/closed jdk/make/closed jdk/test/closed hotspot/src/closed hotspot/test/closed deploy install sponsors pubs >>>>> Starting on corba >>>>> Starting on jaxp >>>>> Starting on jaxws >>>>> Starting on langtools >>>>> # hg clone http://hg.openjdk.java.net/jdk8/tl//corba corba >>>>> >>>>> David >>>>> >>>> >> From kelly.ohair at oracle.com Tue Jun 26 23:11:34 2012 From: kelly.ohair at oracle.com (Kelly Ohair) Date: Tue, 26 Jun 2012 16:11:34 -0700 Subject: Building OpenJDK 6 on Solaris sparc In-Reply-To: References: Message-ID: <046E7C8A-6435-4BBF-8453-F22B7368E57E@oracle.com> with each release we have an official or standard compiler that should be used others may work but we try to make sure the official one always works look at the README-builds.html file at the top of the openjdk forest Sent from my iPhone On Jun 26, 2012, at 12:22, Weiqi Gao wrote: > Hi, > > I'm trying to build OpenJDK 6 and OpenJDK 7 on a variety of machines. > I have encountered the following error while building OpenJDK 7 > (http://hg.openjdk.java.net/jdk7/jdk7) on Solaris sparc (SunOS cicada2 > 5.10 Generic_139555-08 sun4u sparc SUNW,Sun-Blade-1000). I'm using > the suncc5.10 compiler and the lasted jdk1.6.0_32 from Oracle as the > bootstrap JDK. > > I'm not sure what's the cause of this problem. Can anyone shed some > light on it? > > rm -f copy.o > CC -DSOLARIS -DSPARC_WORKS -DSPARC -DPRODUCT -xF > -I/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/share/vm/prims > -I/home/gaow/pro > jects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/share/vm > -I/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/cpu/sparc/vm > - > I/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/os_cpu/solaris_sparc/vm > -I/home/gaow/projects1/openjdk-builds/solaris-sparc/openj > dk7/hotspot/src/os/solaris/vm > -I/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/os/posix/vm > -I../generated -DHOTSPOT_RELEASE_VERSI > ON="\"21.0-b17\"" -DHOTSPOT_BUILD_TARGET="\"product\"" > -DHOTSPOT_BUILD_USER="\"gaow\"" -DHOTSPOT_LIB_ARCH=\"sparc\" > -DJRE_RELEASE_VERSION="\"1.7.0-intern > al-gaow_2012_06_26_13_04-b00\"" -DHOTSPOT_VM_DISTRO="\"OpenJDK\"" > -DTARGET_OS_FAMILY_solaris -DTARGET_ARCH_sparc > -DTARGET_ARCH_MODEL_sparc -DTARGET_OS_AR > CH_solaris_sparc -DTARGET_OS_ARCH_MODEL_solaris_sparc > -DTARGET_COMPILER_sparcWorks -DCOMPILER2 -DCOMPILER1 > -DDONT_USE_PRECOMPILED_HEADER -xmemalign=4s -m > 32 -xarch=sparc > /home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/os_cpu/solaris_sparc/vm/solaris_sparc.il > -template=no%extdef -feat > ures=no%split_init -D_Crun_inline_placement -library=%none -KPIC -mt > -xdebugformat=stabs -xO4 -features=no%except -DHAVE_DTRACE_H > -DDTRACE_ENABLED - > c -xMMD -xMF ../generated/dependencies/copy.o.d -o copy.o > /home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/src/share/vm/utilities/copy. > cpp > cg: assertion failed in file ../src/sparc/block_edges.cc at line 581 > cg: block_edges.accumulate_successors: bad state > cg: 1 errors > make[6]: *** [copy.o] Error 1 > make[6]: Leaving directory > `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/build/solaris-sparc/hotspot/outputdir/solaris_sparc_compiler2/prod > uct' > make[5]: *** [the_vm] Error 2 > make[5]: Leaving directory > `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/build/solaris-sparc/hotspot/outputdir/solaris_sparc_compiler2/prod > uct' > make[4]: *** [product] Error 2 > make[4]: Leaving directory > `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/build/solaris-sparc/hotspot/outputdir' > make[3]: *** [generic_build2] Error 2 > make[3]: Leaving directory > `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/make' > make[2]: *** [product] Error 2 > make[2]: Leaving directory > `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7/hotspot/make' > make[1]: *** [hotspot-build] Error 2 > make[1]: Leaving directory > `/home/gaow/projects1/openjdk-builds/solaris-sparc/openjdk7' > make: *** [build_product_image] Error 2 > > > -- > Weiqi Gao (???) > weiqigao at gmail.com > http://www.weiqigao.com/blog/ From staffan.larsen at oracle.com Wed Jun 27 08:13:16 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 27 Jun 2012 10:13:16 +0200 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: <47E96839-1BDB-42F2-BC45-D1A98559813C@oracle.com> References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> <4FE3C86D.2080008@oracle.com> <47E96839-1BDB-42F2-BC45-D1A98559813C@oracle.com> Message-ID: Can I have a Review for this change, please? The very simple fix is here: http://cr.openjdk.java.net/~sla/7178667/webrev.02/ Thanks, /Staffan On 25 jun 2012, at 10:36, Staffan Larsen wrote: > >>>> So, it sounds like when you rebuilt, everything was built into jre/lib/i386 and jre/lib/amd64, but never combined (or, in this case, just copied) into jre/lib, and therefore not found. >>> >>> Yes. Or rather, only the client jvm was combined, but the client jvm isn't copied into the j2sdk-image on mac, so nothing was copied. >> >> Which begs the question: if we only build 64-bit on OSX then how/why is client being built in the first place? > > I should have said: "only the client jvm was _attempted_ to be combined". In fact, the client does not exist, but the universalize makefiles are written to handle client if it did exist. > > So what happened was: > - the product jvm was built > - it was copied to the import jdk (into jre/lib/amd64/server/) by the generic_export target > - the universalize makefile tried to take the client jvm and universalize it into jre/lib/client/ (notice that there is no amd64 directory level on mac) > - the universalize makefile removes all {amd64,i386} directories > > What should have happened: > - the product jvm was built > - it was copied to the import jdk (into jre/lib/amd64/server/) by the generic_export target > - the universalize makefile makes a universal binary of any existing jvms (client or server) > - the universalize makefile copies these jvms into jre/lib/{server,client} > - the universalize makefile removes all {amd64,i386} directories > > But because the targets weren't .PHONY, the third step above failed. > > I hope that explains the problem in more detail. Who wants to be put down as reviewer? > > Thanks, > /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: From Dmitry.Samersoff at oracle.com Wed Jun 27 10:03:01 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 27 Jun 2012 14:03:01 +0400 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> <4FE3C86D.2080008@oracle.com> <47E96839-1BDB-42F2-BC45-D1A98559813C@oracle.com> Message-ID: <4FEADA55.40701@oracle.com> Looks good for me. -Dmitry On 2012-06-27 12:13, Staffan Larsen wrote: > Can I have a Review for this change, please? > > The very simple fix is > here: http://cr.openjdk.java.net/~sla/7178667/webrev.02/ > > Thanks, > /Staffan > > On 25 jun 2012, at 10:36, Staffan Larsen wrote: > >> >>>>> So, it sounds like when you rebuilt, everything was built into >>>>> jre/lib/i386 and jre/lib/amd64, but never combined (or, in this >>>>> case, just copied) into jre/lib, and therefore not found. >>>> >>>> Yes. Or rather, only the client jvm was combined, but the client jvm >>>> isn't copied into the j2sdk-image on mac, so nothing was copied. >>> >>> Which begs the question: if we only build 64-bit on OSX then how/why >>> is client being built in the first place? >> >> I should have said: "only the client jvm was _attempted_ to be >> combined". In fact, the client does not exist, but the universalize >> makefiles are written to handle client if it did exist. >> >> So what happened was: >> - the product jvm was built >> - it was copied to the import jdk (into jre/lib/amd64/server/) by the >> generic_export target >> - the universalize makefile tried to take the client jvm and >> universalize it into jre/lib/client/ (notice that there is no amd64 >> directory level on mac) >> - the universalize makefile removes all {amd64,i386} directories >> >> What should have happened: >> - the product jvm was built >> - it was copied to the import jdk (into jre/lib/amd64/server/) by the >> generic_export target >> - the universalize makefile makes a universal binary of any existing >> jvms (client or server) >> - the universalize makefile copies these jvms into jre/lib/{server,client} >> - the universalize makefile removes all {amd64,i386} directories >> >> But because the targets weren't .PHONY, the third step above failed. >> >> I hope that explains the problem in more detail. Who wants to be put >> down as reviewer? >> >> Thanks, >> /Staffan >> > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From david.holmes at oracle.com Wed Jun 27 11:22:27 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 27 Jun 2012 21:22:27 +1000 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> <4FE3C86D.2080008@oracle.com> <47E96839-1BDB-42F2-BC45-D1A98559813C@oracle.com> Message-ID: <4FEAECF3.3020408@oracle.com> On 27/06/2012 6:13 PM, Staffan Larsen wrote: > Can I have a Review for this change, please? Ok. :) David > The very simple fix is here: > http://cr.openjdk.java.net/~sla/7178667/webrev.02/ > > Thanks, > /Staffan > > On 25 jun 2012, at 10:36, Staffan Larsen wrote: > >> >>>>> So, it sounds like when you rebuilt, everything was built into >>>>> jre/lib/i386 and jre/lib/amd64, but never combined (or, in this >>>>> case, just copied) into jre/lib, and therefore not found. >>>> >>>> Yes. Or rather, only the client jvm was combined, but the client jvm >>>> isn't copied into the j2sdk-image on mac, so nothing was copied. >>> >>> Which begs the question: if we only build 64-bit on OSX then how/why >>> is client being built in the first place? >> >> I should have said: "only the client jvm was _attempted_ to be >> combined". In fact, the client does not exist, but the universalize >> makefiles are written to handle client if it did exist. >> >> So what happened was: >> - the product jvm was built >> - it was copied to the import jdk (into jre/lib/amd64/server/) by the >> generic_export target >> - the universalize makefile tried to take the client jvm and >> universalize it into jre/lib/client/ (notice that there is no amd64 >> directory level on mac) >> - the universalize makefile removes all {amd64,i386} directories >> >> What should have happened: >> - the product jvm was built >> - it was copied to the import jdk (into jre/lib/amd64/server/) by the >> generic_export target >> - the universalize makefile makes a universal binary of any existing >> jvms (client or server) >> - the universalize makefile copies these jvms into jre/lib/{server,client} >> - the universalize makefile removes all {amd64,i386} directories >> >> But because the targets weren't .PHONY, the third step above failed. >> >> I hope that explains the problem in more detail. Who wants to be put >> down as reviewer? >> >> Thanks, >> /Staffan >> > From weiqigao at gmail.com Wed Jun 27 13:48:10 2012 From: weiqigao at gmail.com (Weiqi Gao) Date: Wed, 27 Jun 2012 08:48:10 -0500 Subject: Building OpenJDK 6 on Solaris sparc In-Reply-To: <20458.9976.569424.798712@oracle.com> References: <20458.9976.569424.798712@oracle.com> Message-ID: <4FEB0F1A.3040403@gmail.com> Thank you John. -- Weiqi Gao On 6/26/2012 4:17 PM, John Coomes wrote: > Weiqi Gao (weiqigao at gmail.com) wrote: >> Hi, >> >> I'm trying to build OpenJDK 6 and OpenJDK 7 on a variety of machines. >> I have encountered the following error while building OpenJDK 7 >> (http://hg.openjdk.java.net/jdk7/jdk7) on Solaris sparc (SunOS cicada2 >> 5.10 Generic_139555-08 sun4u sparc SUNW,Sun-Blade-1000). I'm using >> the suncc5.10 compiler and the lasted jdk1.6.0_32 from Oracle as the >> bootstrap JDK. >> >> I'm not sure what's the cause of this problem. Can anyone shed some >> light on it? >> >> rm -f copy.o >> CC -DSOLARIS -DSPARC_WORKS -DSPARC -DPRODUCT -xF >> ... >> cg: assertion failed in file ../src/sparc/block_edges.cc at line 581 >> cg: block_edges.accumulate_successors: bad state >> cg: 1 errors > Hi, > > That's a bug in the compiler backend. Make sure you have applied the > patches listed in the README-builds.html file: > > http://hg.openjdk.java.net/jdk7/jdk7/raw-file/dada8003df87/README-builds.html#studio > > -John From erik.joelsson at oracle.com Wed Jun 27 14:45:20 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 27 Jun 2012 07:45:20 -0700 Subject: Surprising failure after "make sanity" passed In-Reply-To: References: <4FE4C481.9020507@oracle.com> <4FE507A0.1030304@oracle.com> <4FE50AB5.2040506@oracle.com> Message-ID: <4FEB1C80.2090201@oracle.com> In the build-infra world, the compiler has to be found by configure in some way (usually by putting it in the path) at configure time. After that the build will use the absolute path found by configure. Configure will definitely fail if it can't find a valid compiler. /Erik On 2012-06-26 11:08, Kelly O'Hair wrote: > Solaris builds will always be tough. > > You need particular versions of the C/C++ compilers (cc/CC or Sun Studio, or now Oracle Solaris Studio) in your PATH. > > I'm not sure exactly how this will be dealt with in the new build infrastructure yet. But I'll be looking at it today hopefully. > > -kto > > On Jun 22, 2012, at 5:15 PM, Jonathan Gibbons wrote: > >> I was doing a top level build, which complained about a few things until I fixed them up. But then the check seemed to be OK and the build proceeded OK, until it ran into this issue, and then another issue -- something that was brought in from /usr/sfw because of the default setting to enable debug symbols. Once I figured out how to disable them, I finally got a build to proceed. >> >> I presume the new build system will be better at determining up front everything that will be needed during the build. >> >> -- Jon >> >> On 06/22/2012 05:02 PM, David Holmes wrote: >>> Hi Jon, >>> >>> On 23/06/2012 5:16 AM, Jonathan Gibbons wrote: >>>> A build of tl passed "make sanity" but I still got this error: >>>> >>>> >>>> CC -DSOLARIS -DSPARC_WORKS -DIA32 >>>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/prims >>>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm >>>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/precompiled >>>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/cpu/x86/vm >>>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os_cpu/solaris_x86/vm >>>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/solaris/vm >>>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/os/posix/vm >>>> -I/tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc >>>> -I../generated -DASSERT -DTARGET_OS_FAMILY_solaris -DTARGET_ARCH_x86 >>>> -DTARGET_ARCH_MODEL_x86_32 -DTARGET_OS_ARCH_solaris_x86 >>>> -DTARGET_OS_ARCH_MODEL_solaris_x86_32 -DTARGET_COMPILER_sparcWorks >>>> -DCOMPILER2 -DCOMPILER1 -DDONT_USE_PRECOMPILED_HEADER -D_REENTRANT >>>> -library=Cstd -g -xwe -g -c -o ../generated/adfiles/adlparse.o >>>> /tmp/jjg/7178763-doctree-oome/tl/hotspot/src/share/vm/adlc/adlparse.cpp >>>> make381[6]: CC: Command not found >>> Was this a JDK sanity check or hotspot? hotspot doesn't really do any sanity checking of its own. What did the sanity check report? >>> >>> David >>> ----- >>> >>>> make381[6]: *** [../generated/adfiles/adlparse.o] Error 127 >>>> make381[6]: Leaving directory >>>> `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' >>>> >>>> make381[5]: *** [ad_stuff] Error 2 >>>> make381[5]: Leaving directory >>>> `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir/solaris_i486_compiler2/product' >>>> >>>> make381[4]: *** [product] Error 2 >>>> make381[4]: Leaving directory >>>> `/tmp/jjg/7178763-doctree-oome/tl/build/solaris-i586/hotspot/outputdir' >>>> make381[3]: *** [generic_build2] Error 2 >>>> make381[3]: Leaving directory >>>> `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' >>>> make381[2]: *** [product] Error 2 >>>> make381[2]: Leaving directory >>>> `/tmp/jjg/7178763-doctree-oome/tl/hotspot/make' >>>> make381[1]: *** [hotspot-build] Error 2 >>>> make381[1]: Leaving directory `/tmp/jjg/7178763-doctree-oome/tl' >>>> make381: *** [build_product_image] Error 2 >>>> From tim.bell at oracle.com Wed Jun 27 16:45:43 2012 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 27 Jun 2012 09:45:43 -0700 Subject: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS In-Reply-To: <4FD97733.7040409@oracle.com> References: <4FD97733.7040409@oracle.com> Message-ID: <4FEB38B7.2080908@oracle.com> I went over the open changes again and removed some debug code left in by mistake, updated copyright dates and fixed a few typos. Here is an updated webrev: http://cr.openjdk.java.net/~tbell/7152336/webrev.01/ These changes are building in both 32 and 64 bit mode on my Windows 7 system. jtreg test runs of the '-automatic -noshell' tests under test/java/lang test/java/math test/java/util ran as expected (2 failures, both known bugs). Thanks in advance for your review and feedback - I'd like to get these changes in soon. Tim Bell On 06/13/12 22:31, Tim Bell wrote: > Hello everyone- > > Kelly asked me to pick up on bug #/7152336 "//Enable builds on Windows > with MinGW/MSYS"/, and this email thread: > > http://mail.openjdk.java.net/pipermail/build-dev/2012-April/thread.html#6083 > > > As David pointed out, we will need at least one other bug # for the > hotspot changes. That said, this is enough to get me started. > > Hi Volker: > > I have applied the patches originally from your posting. Many thanks > for that: > http://cr.openjdk.java.net/~simonis/MinGW_MSYS.v1/ > > With a few modifications (keep cpio for non MinGW/Msys builds, keep > MKS as an option), the proposed changes are visible here for review: > > http://cr.openjdk.java.net/~tbell/7152336/webrev.00/ > > For reference, my test build log is visible here: > > http://cr.openjdk.java.net/~tbell/7152336/webrev.00/full_control_build_no_docs.log > > > Additional test builds on JPRT (our internal build apparatus) verified > that I didn't regress the existing build. > > Abbreviated jtreg [1] testing on this build was successful: > > $ /d/tools/jdk8/7152336/windows-i586/bin/java -jar > /d/tools/jtreg-internal/jtreg/lib/jtreg.jar -automatic -noshell > test/java/lang test/java/math test/java/util > Directory "JTreport" not found: creating > Directory "JTwork" not found: creating > Directory "JTwork\scratch" not found: creating > Test results: passed: 698; failed: 1; error: 5 > Report written to D:\tools\jdk8\7152336\jdk\JTreport\html\report.html > Results written to D:\tools\jdk8\7152336\jdk\JTwork > Error: Some tests failed or other problems occurred. > > The failing test (java/lang/Math/WorstCaseTests.java) is due to a > known regression: 7174532 > > "jdk/test/java/lang/Math/WorstCaseTests.java failing on x86" > > The 5 error tests are all ignored until bug xxxxxxx (for some value of > x) is resolved. > > Thanks in advance for your review and feedback - > > Tim Bell > > [1] http://openjdk.java.net/projects/code-tools/ > From josef.stadelmann at axa-winterthur.ch Wed Jun 27 16:59:57 2012 From: josef.stadelmann at axa-winterthur.ch (Stadelmann Josef) Date: Wed, 27 Jun 2012 18:59:57 +0200 Subject: why can I not download the /jdk repository Message-ID: Just o inform you before I give up. At the README of jdk7 or jdk8 one can read --------------- This one root repository can be obtained with something like: hg clone http://hg.openjdk.java.net/jdk8/jdk8 openjdk8 To make sure you have all the nested repositories, you can run the get_source.sh script located in the same respository as this file: cd openjdk8 && sh ./get_source.sh --------------- Since weeks, running the get_source.sh, download takes place for all sub-repositories except and always fails for the jdk*/jdk repository. "hg clone http://hg.openjdk.java.net/jdk7/jdk7/ C:/OpenJDK/jdk7/jdk" Watching the network, there is an immediate transfer of the .hg subdirectory but then after about 20 minutes I get an abort error C770817 at C036357 /cygdrive/e/OpenJDK/jdk8 $ hg clone http://hg.openjdk.java.net/jdk8/jdk8/jdk jdk requesting all changes abort: error: WHY? Once in the past 4 weeks, I was able to download it on a Saturday at home. Josef -------------- next part -------------- An HTML attachment was scrubbed... URL: From volker.simonis at gmail.com Wed Jun 27 17:32:00 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 27 Jun 2012 19:32:00 +0200 Subject: why can I not download the /jdk repository In-Reply-To: References: Message-ID: Hi, this may be related to Cygwin. The error "C770817 at C036357 /cygdrive/e/OpenJDK/jdk8" indicates that you are using a "Cygwin-Mercurial". I would recommend to install and use a native Windows Mercurial (e.g. http://tortoisehg.bitbucket.org/download/index.html) and try with that one. I never had problems cloning with tortoisehg, also I didn't succeed to push with it (I think because of some ssh/private-key issues). So I use the Cygwin hg for pushing, but that's not very stable for me either... Regards, Volker On Wed, Jun 27, 2012 at 6:59 PM, Stadelmann Josef wrote: > Just o inform you before I give up. > > At the README of jdk7 or jdk8 one can read > > --------------- > > This one root repository can be obtained with something like: > > ??? hg clone http://hg.openjdk.java.net/jdk8/jdk8 openjdk8 > > > > ? To make sure you have all the nested repositories, you can run the > > ? get_source.sh script located in the same respository as this file: > > ??? cd openjdk8 && sh ./get_source.sh > > --------------- > > Since weeks, running the get_source.sh, download takes place for all > > sub-repositories except and always fails for the jdk*/jdk repository. > > "hg clone http://hg.openjdk.java.net/jdk7/jdk7/ C:/OpenJDK/jdk7/jdk" > > Watching the network, there is an immediate transfer of the .hg subdirectory > > but then after about 20 minutes I get an abort error > > C770817 at C036357 /cygdrive/e/OpenJDK/jdk8 > > $ hg clone http://hg.openjdk.java.net/jdk8/jdk8/jdk jdk > > requesting all changes > > abort: error: > > WHY? > > Once in the past 4 weeks, I was able to download it on a Saturday at home. > > Josef From dkocher at sudo.ch Fri Jun 22 08:40:20 2012 From: dkocher at sudo.ch (David Kocher) Date: Fri, 22 Jun 2012 10:40:20 +0200 Subject: RFR (S): 7178667: ALT_EXPORT_PATH does not export server jvm on macosx In-Reply-To: References: <0BEEBFB0-B103-418F-BD96-D3C497879A17@oracle.com> <4FE30F94.7030700@oracle.com> <4FE316D5.3020502@oracle.com> <4FE35520.6080201@oracle.com> Message-ID: <275E05A0-0934-4AAF-9C1B-F6B49D6DEC69@sudo.ch> I remember having seen this before [1]. [1] http://java.net/jira/browse/MACOSX_PORT-521 On 22.06.2012, at 09:08, Henri Gomez wrote: >> Staffan and Henri, >> >> I think you guys are talking about different levels of support >> for MacOS X Universal builds. Staffan's change is in HotSpot >> which has supported MacOS X Universal builds for a while now. >> >> Henri is talking about the forest of repos which does not >> currently support MacOS X Universal builds. > > If HotSpot support MacOS X Universal build, may be I could find here > some support to fix a problem I get with my OpenJDK 7 universal build > when using 32bits supper (-d32) and server mode (no problem in client > mode). > > ... > > INFO: AJP13 Listener started: port=8009 > juin 22, 2012 9:02:16 AM winstone.Logger logInternal > INFO: Winstone Servlet Engine v0.9.10 running: controlPort=disabled > juin 22, 2012 9:02:17 AM jenkins.InitReactorRunner$1 onAttained > INFO: Started initialization > # > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGBUS (0xa) at pc=0x00f5cb88, pid=495, tid=19971 > # > # JRE version: 7.0 > # Java VM: OpenJDK Server VM (23.2-b05 mixed mode bsd-x86 ) > # Problematic frame: > # J sun.util.calendar.ZoneInfo.getOffsets(J[II)I > # > # Failed to write core dump. Core dumps have been disabled. To enable > core dumping, try "ulimit -c unlimited" before starting Java again > # > # An error report file with more information is saved as: > # /Users/henri/Downloads/jenkins/hs_err_pid495.log > > > It is easily reproducible : > > - Install OpenJDK 7 (from jdk7u-dev built in universal mode) from my > googlecode site : > > http://openjdk-osx-build.googlecode.com/files/OpenJDK-OSX-1.7-universal-u-jdk-jdk7u5-b30-20120621.dmg) > > Then : > > export JAVA_HOME=/Library/Java/JavaVirtualMachines/1.7.0u.jdk/Contents/Home > > mkdir jenkins > cd jenkins > curl -L http://mirrors.jenkins-ci.org/war/latest/jenkins.war -o jenkins.war > mkdir data > export JENKINS_HOME=`pwd`/data > java -d32 -jar jenkins.war > > > And there is no problem using -d32 -client or -d64. > > Any help from Hotspot guys will be very useful since this problem > prevent me to ask for universal patch to be reintroduce in OpenJDK 7 > and 8. > > Thanks > From kelly.ohair at oracle.com Wed Jun 27 20:02:34 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 27 Jun 2012 13:02:34 -0700 Subject: why can I not download the /jdk repository In-Reply-To: References: Message-ID: <61F1BE95-84E7-4311-B6F4-609D0EB48DD7@oracle.com> I found this old documentation when I worked on the JavaFX project, maybe this helps: TortoiseHG (Windows) Get the TortoiseHG Download bundle and install it. It install into the directory: "C:/Program Files/TortoiseHG/". After installing it: Edit the file "C:/Program Files/TortoiseHG/Mercurial.ini" and make sure the ssh command used is from CYGWIN and not Plink. Unless of course you want to use Plink, it's up to you. Prepend "C:/Program Files/TortoiseHG/" to your PATH, make sure it is before /usr/bin, so that running hg version tells you it is TortoiseHG. Mercurial Tips On Windows, the default CYGWIN hg will not work on some of the repositories, so you can downgrade the CYGWIN hg version to 1.0.2 or switch to use the TortoiseHG build of Mercurial, which is a 1.3.1 or newer version. The problem centers around the Windows limits to full pathnames. Mercurial .hg/ files can end up with much longer filenames than the file they represent in the working set, or the files you edit. The most recent releases of Mercurial have optimized these path lengths, but versions like 1.1 had made the problem worse, resulting in some of our repositories not cloning. Version 1.0.2 was ok, but 1.3.1 or newer is best. Unfortunately, at this time, 1.3.1 is not available with CYGWIN. On Windows, the CYGWIN hg is a Python script and doesn't play well with the native Windows system. Some ant scripts try and run hg and ant will fail when running a Python script. Using TortoiseHG solves this problem because it provides a hg.exe. -kto On Jun 27, 2012, at 10:32 AM, Volker Simonis wrote: > Hi, > > this may be related to Cygwin. The error "C770817 at C036357 > /cygdrive/e/OpenJDK/jdk8" indicates that you are using a > "Cygwin-Mercurial". I would recommend to install and use a native > Windows Mercurial (e.g. > http://tortoisehg.bitbucket.org/download/index.html) and try with that > one. > > I never had problems cloning with tortoisehg, also I didn't succeed to > push with it (I think because of some ssh/private-key issues). So I > use the Cygwin hg for pushing, but that's not very stable for me > either... > > Regards, > Volker > > On Wed, Jun 27, 2012 at 6:59 PM, Stadelmann Josef > wrote: >> Just o inform you before I give up. >> >> At the README of jdk7 or jdk8 one can read >> >> --------------- >> >> This one root repository can be obtained with something like: >> >> hg clone http://hg.openjdk.java.net/jdk8/jdk8 openjdk8 >> >> >> >> To make sure you have all the nested repositories, you can run the >> >> get_source.sh script located in the same respository as this file: >> >> cd openjdk8 && sh ./get_source.sh >> >> --------------- >> >> Since weeks, running the get_source.sh, download takes place for all >> >> sub-repositories except and always fails for the jdk*/jdk repository. >> >> "hg clone http://hg.openjdk.java.net/jdk7/jdk7/ C:/OpenJDK/jdk7/jdk" >> >> Watching the network, there is an immediate transfer of the .hg subdirectory >> >> but then after about 20 minutes I get an abort error >> >> C770817 at C036357 /cygdrive/e/OpenJDK/jdk8 >> >> $ hg clone http://hg.openjdk.java.net/jdk8/jdk8/jdk jdk >> >> requesting all changes >> >> abort: error: >> >> WHY? >> >> Once in the past 4 weeks, I was able to download it on a Saturday at home. >> >> Josef -------------- next part -------------- An HTML attachment was scrubbed... URL: From John.Coomes at oracle.com Wed Jun 27 22:26:57 2012 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 27 Jun 2012 15:26:57 -0700 Subject: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS In-Reply-To: <4FEB38B7.2080908@oracle.com> References: <4FD97733.7040409@oracle.com> <4FEB38B7.2080908@oracle.com> Message-ID: <20459.34993.211603.210208@oracle.com> Tim Bell (tim.bell at oracle.com) wrote: > I went over the open changes again and removed some debug code left in > by mistake, updated copyright dates and fixed a few typos. Here is an > updated webrev: > > http://cr.openjdk.java.net/~tbell/7152336/webrev.01/ > > These changes are building in both 32 and 64 bit mode on my Windows 7 > system. > > jtreg test runs of the '-automatic -noshell' tests under test/java/lang > test/java/math test/java/util ran as expected (2 failures, both known > bugs). I only looked at the hotspot changes, which are fine. One minor request. In hotspot/make/windows/makefiles/defs.make: 215 else 216 ifeq ($(USING_MINGW), true) 217 ABS_OUTPUTDIR := $(shell $(CD) $(OUTPUTDIR);$(PWD)) 218 ABS_BOOTDIR := $(shell $(CD) $(BOOTDIR);$(PWD)) 219 ABS_GAMMADIR := $(shell $(CD) $(GAMMADIR);$(PWD)) 220 ABS_OS_MAKEFILE := $(shell $(CD) $(HS_MAKE_DIR)/$(OSNAME);$(PWD))/build.make 221 else You can append line 216 to 215, e.g., 215 else ifeq ($(USING_MINGW), true) which eliminates some indentation and an endif, and I find easier to read. -John > Thanks in advance for your review and feedback - I'd like to get these > changes in soon. > > Tim Bell > > > On 06/13/12 22:31, Tim Bell wrote: > > Hello everyone- > > > > Kelly asked me to pick up on bug #/7152336 "//Enable builds on Windows > > with MinGW/MSYS"/, and this email thread: > > > > http://mail.openjdk.java.net/pipermail/build-dev/2012-April/thread.html#6083 > > > > > > As David pointed out, we will need at least one other bug # for the > > hotspot changes. That said, this is enough to get me started. > > > > Hi Volker: > > > > I have applied the patches originally from your posting. Many thanks > > for that: > > http://cr.openjdk.java.net/~simonis/MinGW_MSYS.v1/ > > > > With a few modifications (keep cpio for non MinGW/Msys builds, keep > > MKS as an option), the proposed changes are visible here for review: > > > > http://cr.openjdk.java.net/~tbell/7152336/webrev.00/ > > > > For reference, my test build log is visible here: > > > > http://cr.openjdk.java.net/~tbell/7152336/webrev.00/full_control_build_no_docs.log > > > > > > Additional test builds on JPRT (our internal build apparatus) verified > > that I didn't regress the existing build. > > > > Abbreviated jtreg [1] testing on this build was successful: > > > > $ /d/tools/jdk8/7152336/windows-i586/bin/java -jar > > /d/tools/jtreg-internal/jtreg/lib/jtreg.jar -automatic -noshell > > test/java/lang test/java/math test/java/util > > Directory "JTreport" not found: creating > > Directory "JTwork" not found: creating > > Directory "JTwork\scratch" not found: creating > > Test results: passed: 698; failed: 1; error: 5 > > Report written to D:\tools\jdk8\7152336\jdk\JTreport\html\report.html > > Results written to D:\tools\jdk8\7152336\jdk\JTwork > > Error: Some tests failed or other problems occurred. > > > > The failing test (java/lang/Math/WorstCaseTests.java) is due to a > > known regression: 7174532 > > > > "jdk/test/java/lang/Math/WorstCaseTests.java failing on x86" > > > > The 5 error tests are all ignored until bug xxxxxxx (for some value of > > x) is resolved. > > > > Thanks in advance for your review and feedback - > > > > Tim Bell > > > > [1] http://openjdk.java.net/projects/code-tools/ > > > From david.katleman at oracle.com Wed Jun 27 22:52:18 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 27 Jun 2012 22:52:18 +0000 Subject: hg: jdk8/build: 4 new changesets Message-ID: <20120627225218.7432D47B61@hg.openjdk.java.net> Changeset: 1e989139ce0d Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/1e989139ce0d Added tag jdk8-b44 for changeset e4f81a817447 ! .hgtags Changeset: 1af3996aa431 Author: sla Date: 2012-06-11 20:52 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/1af3996aa431 7175802: Missing jdk_jfr in top-level make file Reviewed-by: alanb ! test/Makefile Changeset: 67e1fb3b2b33 Author: lana Date: 2012-06-17 21:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/67e1fb3b2b33 Merge Changeset: 633f2378c904 Author: lana Date: 2012-06-25 21:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/633f2378c904 Merge From david.katleman at oracle.com Wed Jun 27 22:52:26 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 27 Jun 2012 22:52:26 +0000 Subject: hg: jdk8/build/corba: 9 new changesets Message-ID: <20120627225233.035F047B62@hg.openjdk.java.net> Changeset: ad3ba4b392cc Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/ad3ba4b392cc Added tag jdk8-b44 for changeset 439d9bf8e4ff ! .hgtags Changeset: 5222b7d658d4 Author: coffeys Date: 2012-03-26 14:01 +0100 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/5222b7d658d4 7143851: Improve IIOP stub and tie generation in RMIC 7149048: Changes to corba rmic stubGenerator class are not used during jdk build process Reviewed-by: mschoene, robm ! src/share/classes/sun/rmi/rmic/iiop/StubGenerator.java Changeset: e324dfb90c9e Author: mbankal Date: 2012-03-28 02:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/e324dfb90c9e 7079902: Refine CORBA data models Reviewed-by: coffeys ! src/share/classes/com/sun/corba/se/impl/interceptors/ClientRequestInfoImpl.java ! src/share/classes/com/sun/corba/se/impl/interceptors/ServerRequestInfoImpl.java ! src/share/classes/com/sun/corba/se/impl/javax/rmi/CORBA/Util.java ! src/share/classes/com/sun/corba/se/impl/oa/poa/POAPolicyMediatorBase_R.java ! src/share/classes/com/sun/corba/se/impl/oa/toa/TOAFactory.java ! src/share/classes/com/sun/corba/se/impl/orb/ParserTable.java ! src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3.java ! src/share/classes/com/sun/corba/se/impl/orbutil/RepositoryId_1_3_1.java ! src/share/classes/com/sun/corba/se/impl/protocol/LocalClientRequestDispatcherBase.java ! src/share/classes/com/sun/corba/se/impl/util/RepositoryId.java ! src/share/classes/com/sun/corba/se/spi/logging/CORBALogDomains.java ! src/share/classes/sun/rmi/rmic/iiop/IDLNames.java Changeset: 2846cb957582 Author: mbankal Date: 2012-03-28 02:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/2846cb957582 Merge Changeset: a00c5c0b1f30 Author: asaha Date: 2012-04-10 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/a00c5c0b1f30 Merge - make/tools/src/build/tools/stripproperties/StripProperties.java Changeset: 3697feea6f54 Author: asaha Date: 2012-05-08 07:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/3697feea6f54 Merge Changeset: 787fb5a0602f Author: asaha Date: 2012-05-21 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/787fb5a0602f Merge Changeset: 25bb958d07de Author: asaha Date: 2012-06-07 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/25bb958d07de Merge Changeset: 747dad9e9d37 Author: lana Date: 2012-06-26 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/747dad9e9d37 Merge From david.katleman at oracle.com Wed Jun 27 22:55:25 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 27 Jun 2012 22:55:25 +0000 Subject: hg: jdk8/build/hotspot: 11 new changesets Message-ID: <20120627225553.88F2547B63@hg.openjdk.java.net> Changeset: 0976e71907b9 Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0976e71907b9 Added tag jdk8-b44 for changeset 831e5c76a20a ! .hgtags Changeset: 1e76463170b3 Author: kamg Date: 2012-03-29 18:55 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1e76463170b3 7110720: Issue with vm config file loadingIssue with vm config file loading Summary: disabling default config files if -XX:-ReadDefaultConfigFiles Reviewed-by: phh, jrose, dcubed, dholmes ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/compiler/compilerOracle.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/arguments.cpp + test/runtime/7110720/Test7110720.sh Changeset: e778c29768e6 Author: never Date: 2012-04-04 20:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e778c29768e6 7152811: Issues in client compiler Reviewed-by: kvn, jrose ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciField.hpp Changeset: 958bb4b7be49 Author: asaha Date: 2012-04-10 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/958bb4b7be49 Merge ! src/share/vm/runtime/arguments.cpp Changeset: aa07e41a9f80 Author: never Date: 2012-04-12 12:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/aa07e41a9f80 7160677: missing else in fix for 7152811 Reviewed-by: kvn, kevinw ! src/share/vm/ci/ciField.cpp Changeset: 5142b5110214 Author: asaha Date: 2012-05-08 07:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5142b5110214 Merge ! src/share/vm/opto/runtime.cpp Changeset: d558e01a72c0 Author: kamg Date: 2012-05-03 15:37 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d558e01a72c0 7160757: Problem with hotspot/runtime_classfile Summary: Allow only current and super invokespecials of Reviewed-by: never, coleenp, dcubed ! src/share/vm/classfile/verifier.cpp + test/runtime/7160757/Test7160757.java Changeset: 6d2c830e025d Author: asaha Date: 2012-05-08 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6d2c830e025d Merge Changeset: 84e198dc2474 Author: asaha Date: 2012-05-21 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/84e198dc2474 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp ! src/share/vm/runtime/arguments.cpp Changeset: f9d57285de70 Author: asaha Date: 2012-06-07 12:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f9d57285de70 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 9d5f20961bc5 Author: lana Date: 2012-06-26 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9d5f20961bc5 Merge ! src/share/vm/classfile/verifier.cpp From david.katleman at oracle.com Wed Jun 27 22:58:26 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 27 Jun 2012 22:58:26 +0000 Subject: hg: jdk8/build/jaxp: 10 new changesets Message-ID: <20120627225852.9095547B64@hg.openjdk.java.net> Changeset: a5c1047a05e9 Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/a5c1047a05e9 Added tag jdk8-b44 for changeset 0b3f3a4ce139 ! .hgtags Changeset: f328914a04ea Author: joehw Date: 2012-06-11 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/f328914a04ea 7157610: NullPointerException occurs when parsing XML doc Summary: recovers what was the original disallow-doctype-decl, reporting error when disallow-doctype-decl is true, and change everything else that was added for SupportDTD to be governed by a new flag 'fSupportDTD'. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java Changeset: 0c7f86d9ff8b Author: joehw Date: 2012-06-12 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/0c7f86d9ff8b 7144423: StAX EventReader swallows the cause of error Summary: make sure the cause of the error is properly reported Reviewed-by: lancea, psandoz ! src/com/sun/xml/internal/stream/XMLEventReaderImpl.java Changeset: a079926a6d81 Author: lana Date: 2012-06-17 21:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/a079926a6d81 Merge Changeset: 54a86b897fe8 Author: lana Date: 2012-06-25 21:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/54a86b897fe8 Merge Changeset: d117133a7283 Author: joehw Date: 2012-04-10 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/d117133a7283 7157609: Issues with loop Reviewed-by: hawtin, lancea, asaha ! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLScanner.java Changeset: 0e635b48336a Author: asaha Date: 2012-05-08 07:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/0e635b48336a Merge = src/com/sun/org/apache/xerces/internal/impl/XMLScanner.java < src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLScanner.java - src/share/classes/com/sun/java_cup/internal/runtime/Scanner.java - src/share/classes/com/sun/java_cup/internal/runtime/Symbol.java - src/share/classes/com/sun/java_cup/internal/runtime/lr_parser.java - src/share/classes/com/sun/java_cup/internal/runtime/virtual_parse_stack.java - src/share/classes/com/sun/org/apache/bcel/internal/Constants.java - src/share/classes/com/sun/org/apache/bcel/internal/ExceptionConstants.java - src/share/classes/com/sun/org/apache/bcel/internal/Repository.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/AccessFlags.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Attribute.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/AttributeReader.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ClassFormatException.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ClassParser.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Code.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/CodeException.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Constant.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantCP.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantClass.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFieldref.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantInteger.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantInterfaceMethodref.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantMethodref.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantNameAndType.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantObject.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantPool.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantString.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantUtf8.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantValue.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Deprecated.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/DescendingVisitor.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/EmptyVisitor.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/ExceptionTable.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Field.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/FieldOrMethod.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/InnerClass.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/InnerClasses.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/JavaClass.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/LineNumber.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/LineNumberTable.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/LocalVariable.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/LocalVariableTable.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Method.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Node.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/PMGClass.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Signature.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/SourceFile.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/StackMap.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/StackMapEntry.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/StackMapType.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Synthetic.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Unknown.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Utility.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/Visitor.java - src/share/classes/com/sun/org/apache/bcel/internal/classfile/package.html - src/share/classes/com/sun/org/apache/bcel/internal/generic/AALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/AASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ACONST_NULL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ANEWARRAY.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ARETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ARRAYLENGTH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ATHROW.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/AllocationInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ArithmeticInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ArrayInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ArrayType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BIPUSH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BREAKPOINT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BasicType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BranchHandle.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/BranchInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CHECKCAST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CPInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ClassGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ClassGenException.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ClassObserver.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CodeExceptionGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/CompoundInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ConstantPoolGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ConstantPushInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ConversionInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/D2F.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/D2I.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/D2L.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DADD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DCMPG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DCMPL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DDIV.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DLOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DMUL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DNEG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DREM.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DRETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DSTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DSUB.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP2_X1.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP2_X2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP_X1.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/DUP_X2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/EmptyVisitor.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ExceptionThrower.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/F2D.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/F2I.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/F2L.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FADD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FCMPG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FCMPL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FDIV.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FLOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FMUL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FNEG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FREM.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FRETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FSTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FSUB.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldGenOrMethodGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldObserver.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/FieldOrMethod.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GETFIELD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GETSTATIC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GOTO.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GOTO_W.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/GotoInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2B.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2C.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2D.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2F.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2L.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/I2S.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IADD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IAND.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ICONST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IDIV.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFEQ.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFGE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFGT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFLE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFLT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFNE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFNONNULL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IFNULL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ACMPEQ.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ACMPNE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPEQ.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPGE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPGT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPLE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPLT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IF_ICMPNE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IINC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ILOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IMPDEP1.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IMPDEP2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IMUL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INEG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INSTANCEOF.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEINTERFACE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKESPECIAL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKESTATIC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/INVOKEVIRTUAL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IOR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IREM.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IRETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ISHL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ISHR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ISTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ISUB.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IUSHR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IXOR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IfInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/IndexedInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/Instruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionComparator.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionConstants.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionHandle.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionList.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionListObserver.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionTargeter.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/InvokeInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/JSR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/JSR_W.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/JsrInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/L2D.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/L2F.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/L2I.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LADD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LAND.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LCMP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LCONST.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2_W.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LDC_W.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LDIV.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LLOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LMUL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LNEG.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LOOKUPSWITCH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LOR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LREM.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LRETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LSHL.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LSHR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LSTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LSUB.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LUSHR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LXOR.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LineNumberGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LoadClass.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LoadInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LocalVariableGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/LocalVariableInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MONITORENTER.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MONITOREXIT.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MULTIANEWARRAY.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MethodGen.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/MethodObserver.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/NEW.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/NEWARRAY.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/NOP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/NamedAndTyped.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ObjectType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/POP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/POP2.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PUSH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PUTFIELD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PUTSTATIC.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PopInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/PushInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/RET.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/RETURN.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ReferenceType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ReturnInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/ReturnaddressType.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SALOAD.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SASTORE.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SIPUSH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SWAP.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/SWITCH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/Select.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/StackConsumer.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/StackInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/StackProducer.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/StoreInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/TABLESWITCH.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/TargetLostException.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/Type.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/TypedInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/UnconditionalBranch.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/VariableLengthInstruction.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/Visitor.java - src/share/classes/com/sun/org/apache/bcel/internal/generic/package.html - src/share/classes/com/sun/org/apache/bcel/internal/package.html - src/share/classes/com/sun/org/apache/bcel/internal/util/AttributeHTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/BCELFactory.java - src/share/classes/com/sun/org/apache/bcel/internal/util/BCELifier.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ByteSequence.java - src/share/classes/com/sun/org/apache/bcel/internal/util/Class2HTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassLoader.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassLoaderRepository.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassPath.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassQueue.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassSet.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassStack.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ClassVector.java - src/share/classes/com/sun/org/apache/bcel/internal/util/CodeHTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/ConstantHTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/InstructionFinder.java - src/share/classes/com/sun/org/apache/bcel/internal/util/JavaWrapper.java - src/share/classes/com/sun/org/apache/bcel/internal/util/MethodHTML.java - src/share/classes/com/sun/org/apache/bcel/internal/util/Repository.java - src/share/classes/com/sun/org/apache/bcel/internal/util/SyntheticRepository.java - src/share/classes/com/sun/org/apache/bcel/internal/util/package.html - src/share/classes/com/sun/org/apache/regexp/internal/CharacterArrayCharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/CharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/RE.java - src/share/classes/com/sun/org/apache/regexp/internal/RECompiler.java - src/share/classes/com/sun/org/apache/regexp/internal/REDebugCompiler.java - src/share/classes/com/sun/org/apache/regexp/internal/REProgram.java - src/share/classes/com/sun/org/apache/regexp/internal/RESyntaxException.java - src/share/classes/com/sun/org/apache/regexp/internal/RETest.java - src/share/classes/com/sun/org/apache/regexp/internal/REUtil.java - src/share/classes/com/sun/org/apache/regexp/internal/ReaderCharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/StreamCharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/StringCharacterIterator.java - src/share/classes/com/sun/org/apache/regexp/internal/recompile.java - src/share/classes/com/sun/org/apache/xalan/META-INF/services/javax.xml.transform.TransformerFactory - src/share/classes/com/sun/org/apache/xalan/META-INF/services/javax.xml.xpath.XPathFactory - src/share/classes/com/sun/org/apache/xalan/META-INF/services/org.apache.xml.dtm.DTMManager - src/share/classes/com/sun/org/apache/xalan/internal/Version.java - src/share/classes/com/sun/org/apache/xalan/internal/extensions/ExpressionContext.java - src/share/classes/com/sun/org/apache/xalan/internal/extensions/package.html - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltBase.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltCommon.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltDatetime.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltDynamic.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltMath.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltSets.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltStrings.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/Extensions.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/NodeInfo.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/lib/package.html - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLMessages.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_en.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_es.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_fr.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_it.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ja.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_ko.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_pt_BR.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_sv.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_CN.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_zh_TW.java - src/share/classes/com/sun/org/apache/xalan/internal/res/XSLTInfo.properties - src/share/classes/com/sun/org/apache/xalan/internal/res/package.html - src/share/classes/com/sun/org/apache/xalan/internal/templates/Constants.java - src/share/classes/com/sun/org/apache/xalan/internal/templates/package.html - src/share/classes/com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/Process.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xslt/package.html - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/CollatorFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/DOM.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/DOMCache.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/DOMEnhancedForDTM.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/NodeIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/ProcessorVersion.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/StripFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/Translet.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/TransletException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/Compile.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/Transform.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/getopt/GetOpt.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/getopt/GetOptsException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/getopt/IllegalArgumentException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/cmdline/getopt/MissingOptArgException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AbsoluteLocationPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AbsolutePathPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AlternativePattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AncestorPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ApplyImports.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ApplyTemplates.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ArgumentList.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Attribute.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeSet.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeValue.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeValueTemplate.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BinOpExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BooleanCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BooleanExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CallTemplate.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CastCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CastExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CeilingCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Choose.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Closure.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Comment.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CompilerException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ConcatCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Constants.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ContainsCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Copy.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CopyOf.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/CurrentCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/DecimalFormatting.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/DocumentCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ElementAvailableCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/EqualityExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Expression.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Fallback.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilterExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilterParentPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilteredAbsoluteLocationPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FloorCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FlowList.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ForEach.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FormatNumberCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionAvailableCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/GenerateIdCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/IdKeyPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/IdPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/If.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/IllegalCharException.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Import.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Include.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Instruction.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/IntExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Key.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/KeyCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/KeyPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LangCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LastCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LiteralAttribute.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LiteralElement.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LiteralExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LocalNameCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LocationPathPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LogicalExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Makefile.inc - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Message.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Mode.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NameBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NameCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NamespaceAlias.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NamespaceUriCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NodeTest.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NotCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Number.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/NumberCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Otherwise.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Output.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Param.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ParameterRef.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ParentLocationPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ParentPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Pattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/PositionCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Predicate.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ProcessingInstruction.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ProcessingInstructionPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/QName.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RealExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RelationalExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RelativeLocationPath.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RelativePathPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/RoundCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SimpleAttributeValue.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Sort.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SourceLoader.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/StartsWithCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Step.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/StepPattern.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/StringCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/StringLengthCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Stylesheet.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SymbolTable.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SyntaxTreeNode.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Template.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/TestSeq.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Text.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/TopLevelElement.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/TransletOutput.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnaryOpExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnionPathExpr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnparsedEntityUriCall.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnresolvedRef.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnsupportedElement.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UseAttributeSets.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/ValueOf.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Variable.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableRef.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/VariableRefBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/When.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Whitespace.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/WithParam.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathLexer.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathParser.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XslAttribute.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XslElement.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/sym.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/AttributeSetMethodGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/BooleanType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ClassGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/CompareGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ca.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_cs.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_de.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_es.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_fr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_it.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ja.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_ko.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_pt_BR.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sk.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_sv.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_CN.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages_zh_TW.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMsg.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/FilterGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/IntType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/MatchGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/MethodGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/MethodType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/MultiHashtable.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NamedMethodGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeCounterGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeSetType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeSortRecordFactGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeSortRecordGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NodeType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/NumberType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ObjectType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/RealType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ReferenceType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ResultTreeType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/RtMethodGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/SlotAllocator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/StringStack.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/StringType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/TestGenerator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/Type.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/TypeCheckError.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/Util.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/VoidType.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/xpath.cup - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/xpath.lex - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/AbsoluteIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/AdaptiveResultTreeImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/AnyNodeCounter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/BitArray.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/CachedNodeListIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/ClonedNodeListIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/CollatorFactoryBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/CurrentNodeListFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/CurrentNodeListIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DOMAdapter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DOMBuilder.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DOMWSFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DupFilterIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/EmptyFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/ExtendedSAX.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/Filter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/FilterIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/FilteredStepIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/ForwardPositionIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/KeyIndex.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/LoadDocument.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MatchingIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MultiDOM.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MultiValuedNodeHeapIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/MultipleNodeCounter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeCounter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeIteratorBase.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecord.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecordFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NthIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SAXImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SimpleResultTreeImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SingleNodeCounter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SingletonIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SortSettings.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SortingIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/StepIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/StripWhitespaceFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/UnionIterator.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/XSLTCDTMManager.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/javax.xml.transform.TransformerFactory - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Attributes.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Constants.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ca.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_cs.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_de.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_es.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_fr.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_it.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ja.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_ko.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_pt_BR.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sk.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_sv.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_CN.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ErrorMessages_zh_TW.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Hashtable.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/MessageHandler.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Node.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Operators.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Parameter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/StringValueHandler.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/output/OutputBuffer.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/output/StringOutputBuffer.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/output/TransletOutputHandlerFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/output/WriterOutputBuffer.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/DOM2SAX.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/DOM2TO.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/ObjectFactory.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/OutputSettings.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2DOM.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2StAXBaseWriter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2StAXEventWriter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2StAXStreamWriter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SecuritySupport.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SmartTransformerFactoryImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXEvent2SAX.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/StAXStream2SAX.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesHandlerImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TrAXFilter.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerHandlerImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/XSLTCSource.java - src/share/classes/com/sun/org/apache/xalan/internal/xsltc/util/IntegerArray.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/AttrImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/AttrNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/AttributeMap.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CDATASectionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CharacterDataImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ChildNode.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CommentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDOMImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDocumentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMConfigurationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMErrorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMImplementationListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMImplementationSourceImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMInputImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMLocatorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMNormalizer.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMOutputImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMStringListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DOMXSImplementationSourceImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeepNodeListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredAttrImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredAttrNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredCDATASectionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredCommentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDOMImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDocumentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDocumentTypeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredElementDefinitionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredElementImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredElementNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredEntityImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredEntityReferenceImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredNode.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredNotationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredProcessingInstructionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredTextImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DocumentFragmentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DocumentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/DocumentTypeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ElementDefinitionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ElementImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ElementNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/EntityImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/EntityReferenceImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/LCount.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NamedNodeMapImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NodeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NodeIteratorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NodeListCache.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/NotationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ObjectFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIAttrNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIDOMImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIDocumentImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIElementNSImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ParentNode.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/ProcessingInstructionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/RangeExceptionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/RangeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/SecuritySupport.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/TextImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/TreeWalkerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/events/EventImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/events/MutationEventImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/dom/org.apache.xerces.dom.DOMImplementationSourceImpl - src/share/classes/com/sun/org/apache/xerces/internal/dom/org.w3c.dom.DOMImplementationSourceList - src/share/classes/com/sun/org/apache/xerces/internal/impl/Constants.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/ExternalSubsetResolver.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/PropertyManager.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/RevalidationHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/Version.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11DTDScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11DocumentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11EntityScanner.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11NSDocumentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XML11NamespaceBinder.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDTDScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLErrorReporter.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLNSDocumentScannerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLNamespaceBinder.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLStreamFilterImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLStreamReaderImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLVersionDetector.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/BalancedDTDGrammar.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/DTDGrammar.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/DTDGrammarBucket.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XML11DTDProcessor.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XML11DTDValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XML11NSDTDValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLAttributeDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLContentSpec.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDLoader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDProcessor.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDValidatorFilter.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLElementDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLEntityDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLNSDTDValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLNotationDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLSimpleType.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMAny.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMBinOp.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMLeaf.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMNode.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMStateSet.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMUniOp.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/ContentModelValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/DFAContentModel.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/MixedContentModel.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/SimpleContentModel.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DTDDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DVFactoryException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DatatypeException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/InvalidDatatypeFacetException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/InvalidDatatypeValueException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/ObjectFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/SchemaDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/SecuritySupport.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/ValidatedInfo.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/ValidationContext.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/XSFacets.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/XSSimpleType.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/DTDDVFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/ENTITYDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/IDDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/IDREFDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/ListDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/NMTOKENDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/NOTATIONDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/StringDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/XML11DTDDVFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/XML11IDDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/XML11IDREFDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/dtd/XML11NMTOKENDatatypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/util/Base64.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/util/ByteListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/util/HexBin.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/AbstractDateTimeDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/AnyAtomicDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/AnySimpleDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/AnyURIDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/Base64BinaryDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/BaseDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/BaseSchemaDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/BooleanDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DateDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DateTimeDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DayDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DayTimeDurationDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DecimalDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DoubleDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/DurationDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/EntityDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/ExtendedSchemaDVFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/FloatDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/FullDVFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/HexBinaryDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/IDDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/IDREFDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/IntegerDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/ListDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/MonthDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/MonthDayDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/PrecisionDecimalDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/QNameDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/SchemaDVFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/SchemaDateTimeException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/StringDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/TimeDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/TypeValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/UnionDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/XSSimpleTypeDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/XSSimpleTypeDelegate.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/YearDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/YearMonthDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/YearMonthDurationDV.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/io/ASCIIReader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/io/MalformedByteSequenceException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/io/UCSReader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/io/UTF8Reader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_de.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_es.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_fr.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_it.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_ja.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_ko.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_pt_BR.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_sv.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_zh_CN.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessageFormatter_zh_TW.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_de.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_es.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_it.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_ko.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_pt_BR.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_sv.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_zh_CN.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_zh_TW.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/validation/EntityState.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/validation/ValidationManager.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/validation/ValidationState.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/XPath.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/XPathException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/BMPattern.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/CaseInsensitiveMap.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/Match.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/Op.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/ParseException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/ParserForXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/REUtil.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/RangeToken.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/RegexParser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/RegularExpression.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/Token.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/message.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_fr.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_ja.properties - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/AttributePSVImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/ElementPSVImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/SchemaGrammar.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/SchemaNamespaceSupport.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/SchemaSymbols.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/SubstitutionGroupHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaException.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAnnotationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAttributeDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAttributeGroupDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAttributeUseImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSComplexTypeDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSConstraints.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSDDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSDeclarationPool.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSElementDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSGrammarBucket.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSGroupDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSImplementationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSLoaderImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSModelGroupImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSModelImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSNotationDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSParticleDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSWildcardDecl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/Field.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/FieldActivator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/IdentityConstraint.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/KeyRef.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/Selector.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/UniqueOrKey.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/ValueStore.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/XPathMatcher.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/CMBuilder.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/CMNodeFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSAllCM.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMBinOp.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMLeaf.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMRepeatingLeaf.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMUniOp.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSCMValidator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSDFACM.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSEmptyCM.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/AttrImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultDocument.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultElement.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultNode.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultText.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/DefaultXMLDocumentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/ElementImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/NamedNodeMapImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/NodeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/SchemaDOM.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/SchemaDOMImplementation.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/SchemaDOMParser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/SchemaParsingConfig.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/opti/TextImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/SchemaContentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/StAXSchemaParser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAnnotationInfo.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAbstractIDConstraintTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAbstractParticleTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAbstractTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAttributeGroupTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDAttributeTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDComplexTypeTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDElementTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDGroupTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDKeyrefTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDNotationTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDSimpleTypeTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDUniqueOrKeyTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDWildcardTraverser.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDocumentInfo.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/LSInputListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/ObjectListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/ShortListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/SimpleLocator.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/StringListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XInt.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XIntPool.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSGrammarPool.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSNamedMap4Types.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSNamedMapImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSObjectListImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/DefaultValidationErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/DocumentBuilderImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/JAXPConstants.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/JAXPValidatorComponent.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/SchemaValidatorConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/TeeXMLDocumentFilterImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/UnparsedEntityHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DatatypeFactoryImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationDayTimeImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationYearMonthImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/XMLGregorianCalendarImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/javax.xml.datatype.DatatypeFactory - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/javax.xml.parsers.DocumentBuilderFactory - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/javax.xml.parsers.SAXParserFactory - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/AbstractXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DOMDocumentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DOMResultAugmentor.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DOMResultBuilder.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DOMValidatorHelper.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/DraconianErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/EmptyXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ErrorHandlerAdaptor.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/JAXPValidationMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ReadOnlyGrammarPool.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/SimpleXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/SoftReferenceGrammarPool.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/StAXValidatorHelper.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/StreamValidatorHelper.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/Util.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHelper.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/WeakReferenceXMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/WrappedSAXException.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaValidatorComponentManager.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/XSGrammarPoolContainer.java - src/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/javax.xml.validation.SchemaFactory - src/share/classes/com/sun/org/apache/xerces/internal/parsers/AbstractDOMParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/AbstractSAXParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/AbstractXMLDocumentParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/BasicParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/CachingParserPool.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/DOMParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/DOMParserImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/DTDConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/DTDParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/IntegratedParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/NonValidatingConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/ObjectFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/SAXParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/SecurityConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/SecuritySupport.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/StandardParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XIncludeAwareParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XIncludeParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configurable.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11Configuration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11DTDConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XML11NonValidatingConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLDocumentParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLGrammarCachingConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLGrammarParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLGrammarPreparser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XMLParser.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/XPointerParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/parsers/org.apache.xerces.xni.parser.DTDConfiguration - src/share/classes/com/sun/org/apache/xerces/internal/parsers/org.apache.xerces.xni.parser.XML11Configuration - src/share/classes/com/sun/org/apache/xerces/internal/parsers/org.apache.xerces.xni.parser.XMLParserConfiguration - src/share/classes/com/sun/org/apache/xerces/internal/parsers/org.xml.sax.driver - src/share/classes/com/sun/org/apache/xerces/internal/util/AttributesProxy.java - src/share/classes/com/sun/org/apache/xerces/internal/util/AugmentationsImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DOMEntityResolverWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DOMErrorHandlerWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DOMInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DOMUtil.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DatatypeMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DefaultErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/util/DraconianErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/util/EncodingMap.java - src/share/classes/com/sun/org/apache/xerces/internal/util/EntityResolver2Wrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/EntityResolverWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/ErrorHandlerProxy.java - src/share/classes/com/sun/org/apache/xerces/internal/util/ErrorHandlerWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/FeatureState.java - src/share/classes/com/sun/org/apache/xerces/internal/util/HTTPInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/util/IntStack.java - src/share/classes/com/sun/org/apache/xerces/internal/util/JAXPNamespaceContextWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/LocatorProxy.java - src/share/classes/com/sun/org/apache/xerces/internal/util/LocatorWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/MessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceContextWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/NamespaceSupport.java - src/share/classes/com/sun/org/apache/xerces/internal/util/ParserConfigurationSettings.java - src/share/classes/com/sun/org/apache/xerces/internal/util/PropertyState.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SAX2XNI.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SAXInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SAXLocatorWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SAXMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SecurityManager.java - src/share/classes/com/sun/org/apache/xerces/internal/util/ShadowedSymbolTable.java - src/share/classes/com/sun/org/apache/xerces/internal/util/StAXInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/util/StAXLocationWrapper.java - src/share/classes/com/sun/org/apache/xerces/internal/util/Status.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SymbolHash.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SymbolTable.java - src/share/classes/com/sun/org/apache/xerces/internal/util/SynchronizedSymbolTable.java - src/share/classes/com/sun/org/apache/xerces/internal/util/TeeXMLDocumentFilterImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/TypeInfoImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/URI.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XML11Char.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLAttributesImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLAttributesIteratorImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLCatalogResolver.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLChar.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLDocumentFilterImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLEntityDescriptionImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLErrorCode.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLGrammarPoolImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLInputSourceAdaptor.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLResourceIdentifierImpl.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLStringBuffer.java - src/share/classes/com/sun/org/apache/xerces/internal/util/XMLSymbols.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/MultipleScopeNamespaceSupport.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/SecuritySupport.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XInclude11TextReader.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeNamespaceSupport.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeTextReader.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XPointerElementHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XPointerFramework.java - src/share/classes/com/sun/org/apache/xerces/internal/xinclude/XPointerSchema.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/Augmentations.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/NamespaceContext.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/QName.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLAttributes.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLDTDContentModelHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLDTDHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLDocumentFragmentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLDocumentHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLLocator.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLResourceIdentifier.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XMLString.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/XNIException.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/Grammar.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLDTDDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLGrammarDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLGrammarLoader.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLGrammarPool.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XMLSchemaDescription.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/grammars/XSGrammar.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLComponent.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLComponentManager.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLConfigurationException.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDContentModelFilter.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDContentModelSource.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDFilter.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDScanner.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDTDSource.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentFilter.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentScanner.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLDocumentSource.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLEntityResolver.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLInputSource.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParseException.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/xni/parser/XMLPullParserConfiguration.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/ElementSchemePointer.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/ShortHandPointer.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerErrorHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerHandler.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerMessageFormatter.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerPart.java - src/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerProcessor.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/AttributePSVI.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/ElementPSVI.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/ItemPSVI.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/LSInputList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/PSVIProvider.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/ShortList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/StringList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSAnnotation.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSAttributeDeclaration.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSAttributeGroupDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSAttributeUse.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSComplexTypeDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSConstants.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSElementDeclaration.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSException.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSFacet.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSIDCDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSImplementation.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSLoader.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSModel.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSModelGroup.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSModelGroupDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSMultiValueFacet.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSNamedMap.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSNamespaceItem.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSNamespaceItemList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSNotationDeclaration.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSObject.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSObjectList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSParticle.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSSimpleTypeDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSTerm.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSTypeDefinition.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/XSWildcard.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/ByteList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/ObjectList.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSDateTime.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSDecimal.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSDouble.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSFloat.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/XSQName.java - src/share/classes/com/sun/org/apache/xerces/internal/xs/datatypes/package.html - src/share/classes/com/sun/org/apache/xml/internal/dtm/Axis.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTM.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMAxisIterator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMAxisTraverser.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMConfigurationException.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMDOMException.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMException.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMFilter.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMIterator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMManager.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/DTMWSFilter.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/ChunkedIntArray.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/CoroutineManager.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/CoroutineParser.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/CustomStringPool.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMAxisIterNodeList.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMAxisIteratorBase.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMChildIterNodeList.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMDefaultBase.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMDefaultBaseIterators.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMDefaultBaseTraversers.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMDocumentImpl.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMManagerDefault.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNamedNodeMap.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeIterator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeList.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeListBase.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMSafeStringPool.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMStringPool.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMTreeWalker.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/EmptyIterator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/ExpandedNameTable.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/ExtendedType.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/IncrementalSAXSource.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/IncrementalSAXSource_Filter.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/IncrementalSAXSource_Xerces.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/NodeLocator.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/dom2dtm/DOM2DTM.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/dom2dtm/DOM2DTMdefaultNamespaceDeclarationNode.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/sax2dtm/SAX2DTM.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/sax2dtm/SAX2DTM2.java - src/share/classes/com/sun/org/apache/xml/internal/dtm/ref/sax2dtm/SAX2RTFDTM.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_ca.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_cs.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_de.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_en.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_es.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_fr.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_it.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_ja.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_ko.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_pt_BR.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_sk.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_sv.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_tr.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_CN.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_HK.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLErrorResources_zh_TW.java - src/share/classes/com/sun/org/apache/xml/internal/res/XMLMessages.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/Catalog.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/CatalogEntry.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/CatalogException.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/CatalogManager.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/Resolver.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/BootstrapResolver.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/Debug.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/FileURL.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/Namespaces.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/PublicId.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/CatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/DOMCatalogParser.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/DOMCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/ExtendedXMLCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/OASISXMLCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/SAXCatalogParser.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/SAXCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/SAXParserHandler.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/TR9401CatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/TextCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/readers/XCatalogReader.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/tools/CatalogResolver.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/tools/ResolvingParser.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/tools/ResolvingXMLFilter.java - src/share/classes/com/sun/org/apache/xml/internal/resolver/tools/ResolvingXMLReader.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/BaseMarkupSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/DOMSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/DOMSerializerImpl.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/ElementState.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/EncodingInfo.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/Encodings.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/HTMLEntities.res - src/share/classes/com/sun/org/apache/xml/internal/serialize/HTMLSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/HTMLdtd.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/IndentPrinter.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/LineSeparator.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/Method.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/OutputFormat.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/Printer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/Serializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/SerializerFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/SerializerFactoryImpl.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/TextSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/XHTMLSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/XML11Serializer.java - src/share/classes/com/sun/org/apache/xml/internal/serialize/XMLSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/AttributesImplSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/CharInfo.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/DOMSerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ElemContext.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ElemDesc.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/EmptySerializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/EncodingInfo.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/ExtendedContentHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ExtendedLexicalHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/HTMLEntities.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/Method.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/NamespaceMappings.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertiesFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertyUtils.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializationHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Serializer.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerBase.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerConstants.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerFactory.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerTrace.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerTraceWriter.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLSAXHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToHTMLStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToSAXHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToTextSAXHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToTextStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToUnknownStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToXMLSAXHandler.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/ToXMLStream.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/TransformStateSetter.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/TreeWalker.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Utils.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/Version.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/WriterChain.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/WriterToASCI.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/WriterToUTF8Buffered.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/XMLEntities.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/XSLOutputAttributes.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/output_html.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/output_text.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/output_unknown.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/output_xml.properties - src/share/classes/com/sun/org/apache/xml/internal/serializer/package.html - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/AttList.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/BoolStack.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/DOM2Helper.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/Messages.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/MsgKey.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ca.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_cs.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_de.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_en.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_es.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_fr.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_it.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ja.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_ko.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_sv.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_zh_CN.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SerializerMessages_zh_TW.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/StringToIntTable.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/SystemIDResolver.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/URI.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/Utils.java - src/share/classes/com/sun/org/apache/xml/internal/serializer/utils/WrappedRuntimeException.java - src/share/classes/com/sun/org/apache/xml/internal/utils/AttList.java - src/share/classes/com/sun/org/apache/xml/internal/utils/BoolStack.java - src/share/classes/com/sun/org/apache/xml/internal/utils/CharKey.java - src/share/classes/com/sun/org/apache/xml/internal/utils/Constants.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DOM2Helper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DOMBuilder.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DOMHelper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DOMOrder.java - src/share/classes/com/sun/org/apache/xml/internal/utils/DefaultErrorHandler.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ElemDesc.java - src/share/classes/com/sun/org/apache/xml/internal/utils/FastStringBuffer.java - src/share/classes/com/sun/org/apache/xml/internal/utils/Hashtree2Node.java - src/share/classes/com/sun/org/apache/xml/internal/utils/IntStack.java - src/share/classes/com/sun/org/apache/xml/internal/utils/IntVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ListingErrorHandler.java - src/share/classes/com/sun/org/apache/xml/internal/utils/LocaleUtility.java - src/share/classes/com/sun/org/apache/xml/internal/utils/MutableAttrListImpl.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NSInfo.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NameSpace.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NamespaceSupport2.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NodeConsumer.java - src/share/classes/com/sun/org/apache/xml/internal/utils/NodeVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ObjectFactory.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ObjectPool.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ObjectStack.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ObjectVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/PrefixResolver.java - src/share/classes/com/sun/org/apache/xml/internal/utils/PrefixResolverDefault.java - src/share/classes/com/sun/org/apache/xml/internal/utils/QName.java - src/share/classes/com/sun/org/apache/xml/internal/utils/RawCharacterHandler.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SAXSourceLocator.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SecuritySupport.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SerializableLocatorImpl.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StopParseException.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringBufferPool.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringComparable.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringToIntTable.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringToStringTable.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringToStringTableVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StringVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/StylesheetPIHandler.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SuballocatedByteVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SuballocatedIntVector.java - src/share/classes/com/sun/org/apache/xml/internal/utils/SystemIDResolver.java - src/share/classes/com/sun/org/apache/xml/internal/utils/ThreadControllerWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/TreeWalker.java - src/share/classes/com/sun/org/apache/xml/internal/utils/Trie.java - src/share/classes/com/sun/org/apache/xml/internal/utils/URI.java - src/share/classes/com/sun/org/apache/xml/internal/utils/UnImplNode.java - src/share/classes/com/sun/org/apache/xml/internal/utils/WrappedRuntimeException.java - src/share/classes/com/sun/org/apache/xml/internal/utils/WrongParserException.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XML11Char.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLChar.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLCharacterRecognizer.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLString.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLStringDefault.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLStringFactory.java - src/share/classes/com/sun/org/apache/xml/internal/utils/XMLStringFactoryDefault.java - src/share/classes/com/sun/org/apache/xml/internal/utils/package.html - src/share/classes/com/sun/org/apache/xml/internal/utils/res/CharArrayWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/IntArrayWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/LongArrayWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/StringArrayWrapper.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResourceBundle.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResourceBundleBase.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_de.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_en.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_es.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_fr.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_it.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ja_JP_A.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ja_JP_HA.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ja_JP_HI.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ja_JP_I.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_ko.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_sv.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_zh_CN.java - src/share/classes/com/sun/org/apache/xml/internal/utils/res/XResources_zh_TW.java - src/share/classes/com/sun/org/apache/xpath/internal/Arg.java - src/share/classes/com/sun/org/apache/xpath/internal/CachedXPathAPI.java - src/share/classes/com/sun/org/apache/xpath/internal/Expression.java - src/share/classes/com/sun/org/apache/xpath/internal/ExpressionNode.java - src/share/classes/com/sun/org/apache/xpath/internal/ExpressionOwner.java - src/share/classes/com/sun/org/apache/xpath/internal/ExtensionsProvider.java - src/share/classes/com/sun/org/apache/xpath/internal/FoundIndex.java - src/share/classes/com/sun/org/apache/xpath/internal/NodeSet.java - src/share/classes/com/sun/org/apache/xpath/internal/NodeSetDTM.java - src/share/classes/com/sun/org/apache/xpath/internal/SourceTree.java - src/share/classes/com/sun/org/apache/xpath/internal/SourceTreeManager.java - src/share/classes/com/sun/org/apache/xpath/internal/VariableStack.java - src/share/classes/com/sun/org/apache/xpath/internal/WhitespaceStrippingElementMatcher.java - src/share/classes/com/sun/org/apache/xpath/internal/XPath.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathAPI.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathContext.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathException.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathProcessorException.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathVisitable.java - src/share/classes/com/sun/org/apache/xpath/internal/XPathVisitor.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/AttributeIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/AxesWalker.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/BasicTestIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/ChildIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/ChildTestIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/ContextNodeList.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/DescendantIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/FilterExprIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/FilterExprIteratorSimple.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/FilterExprWalker.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/HasPositionalPredChecker.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/IteratorPool.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/LocPathIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/MatchPatternIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/NodeSequence.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/OneStepIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/OneStepIteratorForward.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/PathComponent.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/PredicatedNodeTest.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/RTFIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/ReverseAxesWalker.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/SelfIteratorNoPredicate.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/SubContextList.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/UnionChildIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/UnionPathIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/WalkerFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/WalkingIterator.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/WalkingIteratorSorted.java - src/share/classes/com/sun/org/apache/xpath/internal/axes/package.html - src/share/classes/com/sun/org/apache/xpath/internal/compiler/Compiler.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/FuncLoader.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/FunctionTable.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/Keywords.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/Lexer.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/ObjectFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/OpCodes.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/OpMap.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/OpMapVector.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/PsuedoNames.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/SecuritySupport.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/XPathDumper.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/XPathParser.java - src/share/classes/com/sun/org/apache/xpath/internal/compiler/package.html - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathEvaluatorImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathExpressionImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathNSResolverImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathNamespaceImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathResultImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/XPathStylesheetDOM3Exception.java - src/share/classes/com/sun/org/apache/xpath/internal/domapi/package.html - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncBoolean.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncCeiling.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncConcat.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncContains.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncCount.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncCurrent.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncDoclocation.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncExtElementAvailable.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncExtFunction.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncExtFunctionAvailable.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncFalse.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncFloor.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncGenerateId.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncId.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncLang.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncLast.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncLocalPart.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncNamespace.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncNormalizeSpace.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncNot.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncNumber.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncPosition.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncQname.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncRound.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncStartsWith.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncString.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncStringLength.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSubstring.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSubstringAfter.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSubstringBefore.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSum.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSystemProperty.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncTranslate.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncTrue.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FuncUnparsedEntityURI.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/Function.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/Function2Args.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/Function3Args.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FunctionDef1Arg.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FunctionMultiArgs.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/FunctionOneArg.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/ObjectFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/SecuritySupport.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/SecuritySupport12.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/WrongNumberArgsException.java - src/share/classes/com/sun/org/apache/xpath/internal/functions/package.html - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/JAXPExtensionsProvider.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/JAXPPrefixResolver.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/JAXPVariableStack.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathExpressionImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathFactoryImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/DTMXRTreeFrag.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XBoolean.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XBooleanStatic.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XMLStringFactoryImpl.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XNodeSet.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XNodeSetForDOM.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XNull.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XNumber.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XObject.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XObjectFactory.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XRTreeFrag.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XRTreeFragSelectWrapper.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XString.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XStringForChars.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/XStringForFSB.java - src/share/classes/com/sun/org/apache/xpath/internal/objects/package.html - src/share/classes/com/sun/org/apache/xpath/internal/operations/And.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Bool.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Div.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Equals.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Gt.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Gte.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Lt.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Lte.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Minus.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Mod.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Mult.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Neg.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/NotEquals.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Number.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Operation.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Or.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Plus.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Quo.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/String.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/UnaryOperation.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/Variable.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/VariableSafeAbsRef.java - src/share/classes/com/sun/org/apache/xpath/internal/operations/package.html - src/share/classes/com/sun/org/apache/xpath/internal/package.html - src/share/classes/com/sun/org/apache/xpath/internal/patterns/ContextMatchStepPattern.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/FunctionPattern.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/NodeTest.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/NodeTestFilter.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/StepPattern.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/UnionPattern.java - src/share/classes/com/sun/org/apache/xpath/internal/patterns/package.html - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_de.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_en.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_es.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_fr.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_it.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_ja.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_ko.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_pt_BR.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_sv.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_zh_CN.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_zh_TW.java - src/share/classes/com/sun/org/apache/xpath/internal/res/XPATHMessages.java - src/share/classes/com/sun/org/apache/xpath/internal/res/package.html - src/share/classes/com/sun/xml/internal/stream/Entity.java - src/share/classes/com/sun/xml/internal/stream/EventFilterSupport.java - src/share/classes/com/sun/xml/internal/stream/StaxEntityResolverWrapper.java - src/share/classes/com/sun/xml/internal/stream/StaxErrorReporter.java - src/share/classes/com/sun/xml/internal/stream/StaxXMLInputSource.java - src/share/classes/com/sun/xml/internal/stream/XMLBufferListener.java - src/share/classes/com/sun/xml/internal/stream/XMLEntityReader.java - src/share/classes/com/sun/xml/internal/stream/XMLEntityStorage.java - src/share/classes/com/sun/xml/internal/stream/XMLEventReaderImpl.java - src/share/classes/com/sun/xml/internal/stream/XMLInputFactoryImpl.java - src/share/classes/com/sun/xml/internal/stream/XMLOutputFactoryImpl.java - src/share/classes/com/sun/xml/internal/stream/dtd/DTDGrammarUtil.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/DTDGrammar.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLAttributeDecl.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLElementDecl.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLNotationDecl.java - src/share/classes/com/sun/xml/internal/stream/dtd/nonvalidating/XMLSimpleType.java - src/share/classes/com/sun/xml/internal/stream/events/AttributeImpl.java - src/share/classes/com/sun/xml/internal/stream/events/CharacterEvent.java - src/share/classes/com/sun/xml/internal/stream/events/CommentEvent.java - src/share/classes/com/sun/xml/internal/stream/events/DTDEvent.java - src/share/classes/com/sun/xml/internal/stream/events/DummyEvent.java - src/share/classes/com/sun/xml/internal/stream/events/EndDocumentEvent.java - src/share/classes/com/sun/xml/internal/stream/events/EndElementEvent.java - src/share/classes/com/sun/xml/internal/stream/events/EntityDeclarationImpl.java - src/share/classes/com/sun/xml/internal/stream/events/EntityReferenceEvent.java - src/share/classes/com/sun/xml/internal/stream/events/LocationImpl.java - src/share/classes/com/sun/xml/internal/stream/events/NamedEvent.java - src/share/classes/com/sun/xml/internal/stream/events/NamespaceImpl.java - src/share/classes/com/sun/xml/internal/stream/events/NotationDeclarationImpl.java - src/share/classes/com/sun/xml/internal/stream/events/ProcessingInstructionEvent.java - src/share/classes/com/sun/xml/internal/stream/events/StartDocumentEvent.java - src/share/classes/com/sun/xml/internal/stream/events/StartElementEvent.java - src/share/classes/com/sun/xml/internal/stream/events/XMLEventAllocatorImpl.java - src/share/classes/com/sun/xml/internal/stream/events/XMLEventFactoryImpl.java - src/share/classes/com/sun/xml/internal/stream/javax.xml.stream.XMLEventFactory - src/share/classes/com/sun/xml/internal/stream/javax.xml.stream.XMLInputFactory - src/share/classes/com/sun/xml/internal/stream/javax.xml.stream.XMLOutputFactory - src/share/classes/com/sun/xml/internal/stream/util/BufferAllocator.java - src/share/classes/com/sun/xml/internal/stream/util/ReadOnlyIterator.java - src/share/classes/com/sun/xml/internal/stream/util/ThreadLocalBufferAllocator.java - src/share/classes/com/sun/xml/internal/stream/writers/UTF8OutputStreamWriter.java - src/share/classes/com/sun/xml/internal/stream/writers/WriterUtility.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLDOMWriterImpl.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLEventWriterImpl.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLOutputSource.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLStreamWriterImpl.java - src/share/classes/com/sun/xml/internal/stream/writers/XMLWriter.java - src/share/classes/javax/xml/XMLConstants.java - src/share/classes/javax/xml/datatype/DatatypeConfigurationException.java - src/share/classes/javax/xml/datatype/DatatypeConstants.java - src/share/classes/javax/xml/datatype/DatatypeFactory.java - src/share/classes/javax/xml/datatype/Duration.java - src/share/classes/javax/xml/datatype/FactoryFinder.java - src/share/classes/javax/xml/datatype/SecuritySupport.java - src/share/classes/javax/xml/datatype/XMLGregorianCalendar.java - src/share/classes/javax/xml/datatype/package.html - src/share/classes/javax/xml/namespace/NamespaceContext.java - src/share/classes/javax/xml/namespace/QName.java - src/share/classes/javax/xml/namespace/package.html - src/share/classes/javax/xml/parsers/DocumentBuilder.java - src/share/classes/javax/xml/parsers/DocumentBuilderFactory.java - src/share/classes/javax/xml/parsers/FactoryConfigurationError.java - src/share/classes/javax/xml/parsers/FactoryFinder.java - src/share/classes/javax/xml/parsers/ParserConfigurationException.java - src/share/classes/javax/xml/parsers/SAXParser.java - src/share/classes/javax/xml/parsers/SAXParserFactory.java - src/share/classes/javax/xml/parsers/SecuritySupport.java - src/share/classes/javax/xml/parsers/package.html - src/share/classes/javax/xml/stream/EventFilter.java - src/share/classes/javax/xml/stream/FactoryConfigurationError.java - src/share/classes/javax/xml/stream/FactoryFinder.java - src/share/classes/javax/xml/stream/Location.java - src/share/classes/javax/xml/stream/SecuritySupport.java - src/share/classes/javax/xml/stream/StreamFilter.java - src/share/classes/javax/xml/stream/XMLEventFactory.java - src/share/classes/javax/xml/stream/XMLEventReader.java - src/share/classes/javax/xml/stream/XMLEventWriter.java - src/share/classes/javax/xml/stream/XMLInputFactory.java - src/share/classes/javax/xml/stream/XMLOutputFactory.java - src/share/classes/javax/xml/stream/XMLReporter.java - src/share/classes/javax/xml/stream/XMLResolver.java - src/share/classes/javax/xml/stream/XMLStreamConstants.java - src/share/classes/javax/xml/stream/XMLStreamException.java - src/share/classes/javax/xml/stream/XMLStreamReader.java - src/share/classes/javax/xml/stream/XMLStreamWriter.java - src/share/classes/javax/xml/stream/events/Attribute.java - src/share/classes/javax/xml/stream/events/Characters.java - src/share/classes/javax/xml/stream/events/Comment.java - src/share/classes/javax/xml/stream/events/DTD.java - src/share/classes/javax/xml/stream/events/EndDocument.java - src/share/classes/javax/xml/stream/events/EndElement.java - src/share/classes/javax/xml/stream/events/EntityDeclaration.java - src/share/classes/javax/xml/stream/events/EntityReference.java - src/share/classes/javax/xml/stream/events/Namespace.java - src/share/classes/javax/xml/stream/events/NotationDeclaration.java - src/share/classes/javax/xml/stream/events/ProcessingInstruction.java - src/share/classes/javax/xml/stream/events/StartDocument.java - src/share/classes/javax/xml/stream/events/StartElement.java - src/share/classes/javax/xml/stream/events/XMLEvent.java - src/share/classes/javax/xml/stream/util/EventReaderDelegate.java - src/share/classes/javax/xml/stream/util/StreamReaderDelegate.java - src/share/classes/javax/xml/stream/util/XMLEventAllocator.java - src/share/classes/javax/xml/stream/util/XMLEventConsumer.java - src/share/classes/javax/xml/transform/ErrorListener.java - src/share/classes/javax/xml/transform/FactoryFinder.java - src/share/classes/javax/xml/transform/OutputKeys.java - src/share/classes/javax/xml/transform/Result.java - src/share/classes/javax/xml/transform/SecuritySupport.java - src/share/classes/javax/xml/transform/Source.java - src/share/classes/javax/xml/transform/SourceLocator.java - src/share/classes/javax/xml/transform/Templates.java - src/share/classes/javax/xml/transform/Transformer.java - src/share/classes/javax/xml/transform/TransformerConfigurationException.java - src/share/classes/javax/xml/transform/TransformerException.java - src/share/classes/javax/xml/transform/TransformerFactory.java - src/share/classes/javax/xml/transform/TransformerFactoryConfigurationError.java - src/share/classes/javax/xml/transform/URIResolver.java - src/share/classes/javax/xml/transform/dom/DOMLocator.java - src/share/classes/javax/xml/transform/dom/DOMResult.java - src/share/classes/javax/xml/transform/dom/DOMSource.java - src/share/classes/javax/xml/transform/dom/package.html - src/share/classes/javax/xml/transform/overview.html - src/share/classes/javax/xml/transform/package.html - src/share/classes/javax/xml/transform/sax/SAXResult.java - src/share/classes/javax/xml/transform/sax/SAXSource.java - src/share/classes/javax/xml/transform/sax/SAXTransformerFactory.java - src/share/classes/javax/xml/transform/sax/TemplatesHandler.java - src/share/classes/javax/xml/transform/sax/TransformerHandler.java - src/share/classes/javax/xml/transform/sax/package.html - src/share/classes/javax/xml/transform/stax/StAXResult.java - src/share/classes/javax/xml/transform/stax/StAXSource.java - src/share/classes/javax/xml/transform/stax/package.html - src/share/classes/javax/xml/transform/stream/StreamResult.java - src/share/classes/javax/xml/transform/stream/StreamSource.java - src/share/classes/javax/xml/transform/stream/package.html - src/share/classes/javax/xml/validation/Schema.java - src/share/classes/javax/xml/validation/SchemaFactory.java - src/share/classes/javax/xml/validation/SchemaFactoryFinder.java - src/share/classes/javax/xml/validation/SchemaFactoryLoader.java - src/share/classes/javax/xml/validation/SecuritySupport.java - src/share/classes/javax/xml/validation/TypeInfoProvider.java - src/share/classes/javax/xml/validation/Validator.java - src/share/classes/javax/xml/validation/ValidatorHandler.java - src/share/classes/javax/xml/validation/package.html - src/share/classes/javax/xml/xpath/SecuritySupport.java - src/share/classes/javax/xml/xpath/XPath.java - src/share/classes/javax/xml/xpath/XPathConstants.java - src/share/classes/javax/xml/xpath/XPathException.java - src/share/classes/javax/xml/xpath/XPathExpression.java - src/share/classes/javax/xml/xpath/XPathExpressionException.java - src/share/classes/javax/xml/xpath/XPathFactory.java - src/share/classes/javax/xml/xpath/XPathFactoryConfigurationException.java - src/share/classes/javax/xml/xpath/XPathFactoryFinder.java - src/share/classes/javax/xml/xpath/XPathFunction.java - src/share/classes/javax/xml/xpath/XPathFunctionException.java - src/share/classes/javax/xml/xpath/XPathFunctionResolver.java - src/share/classes/javax/xml/xpath/XPathVariableResolver.java - src/share/classes/javax/xml/xpath/package.html - src/share/classes/org/w3c/dom/Attr.java - src/share/classes/org/w3c/dom/CDATASection.java - src/share/classes/org/w3c/dom/CharacterData.java - src/share/classes/org/w3c/dom/Comment.java - src/share/classes/org/w3c/dom/DOMConfiguration.java - src/share/classes/org/w3c/dom/DOMError.java - src/share/classes/org/w3c/dom/DOMErrorHandler.java - src/share/classes/org/w3c/dom/DOMException.java - src/share/classes/org/w3c/dom/DOMImplementation.java - src/share/classes/org/w3c/dom/DOMImplementationList.java - src/share/classes/org/w3c/dom/DOMImplementationSource.java - src/share/classes/org/w3c/dom/DOMLocator.java - src/share/classes/org/w3c/dom/DOMStringList.java - src/share/classes/org/w3c/dom/Document.java - src/share/classes/org/w3c/dom/DocumentFragment.java - src/share/classes/org/w3c/dom/DocumentType.java - src/share/classes/org/w3c/dom/Element.java - src/share/classes/org/w3c/dom/Entity.java - src/share/classes/org/w3c/dom/EntityReference.java - src/share/classes/org/w3c/dom/NameList.java - src/share/classes/org/w3c/dom/NamedNodeMap.java - src/share/classes/org/w3c/dom/Node.java - src/share/classes/org/w3c/dom/NodeList.java - src/share/classes/org/w3c/dom/Notation.java - src/share/classes/org/w3c/dom/ProcessingInstruction.java - src/share/classes/org/w3c/dom/Text.java - src/share/classes/org/w3c/dom/TypeInfo.java - src/share/classes/org/w3c/dom/UserDataHandler.java - src/share/classes/org/w3c/dom/bootstrap/DOMImplementationRegistry.java - src/share/classes/org/w3c/dom/css/CSS2Properties.java - src/share/classes/org/w3c/dom/css/CSSCharsetRule.java - src/share/classes/org/w3c/dom/css/CSSFontFaceRule.java - src/share/classes/org/w3c/dom/css/CSSImportRule.java - src/share/classes/org/w3c/dom/css/CSSMediaRule.java - src/share/classes/org/w3c/dom/css/CSSPageRule.java - src/share/classes/org/w3c/dom/css/CSSPrimitiveValue.java - src/share/classes/org/w3c/dom/css/CSSRule.java - src/share/classes/org/w3c/dom/css/CSSRuleList.java - src/share/classes/org/w3c/dom/css/CSSStyleDeclaration.java - src/share/classes/org/w3c/dom/css/CSSStyleRule.java - src/share/classes/org/w3c/dom/css/CSSStyleSheet.java - src/share/classes/org/w3c/dom/css/CSSUnknownRule.java - src/share/classes/org/w3c/dom/css/CSSValue.java - src/share/classes/org/w3c/dom/css/CSSValueList.java - src/share/classes/org/w3c/dom/css/Counter.java - src/share/classes/org/w3c/dom/css/DOMImplementationCSS.java - src/share/classes/org/w3c/dom/css/DocumentCSS.java - src/share/classes/org/w3c/dom/css/ElementCSSInlineStyle.java - src/share/classes/org/w3c/dom/css/RGBColor.java - src/share/classes/org/w3c/dom/css/Rect.java - src/share/classes/org/w3c/dom/css/ViewCSS.java - src/share/classes/org/w3c/dom/events/DocumentEvent.java - src/share/classes/org/w3c/dom/events/Event.java - src/share/classes/org/w3c/dom/events/EventException.java - src/share/classes/org/w3c/dom/events/EventListener.java - src/share/classes/org/w3c/dom/events/EventTarget.java - src/share/classes/org/w3c/dom/events/MouseEvent.java - src/share/classes/org/w3c/dom/events/MutationEvent.java - src/share/classes/org/w3c/dom/events/UIEvent.java - src/share/classes/org/w3c/dom/html/HTMLAnchorElement.java - src/share/classes/org/w3c/dom/html/HTMLAppletElement.java - src/share/classes/org/w3c/dom/html/HTMLAreaElement.java - src/share/classes/org/w3c/dom/html/HTMLBRElement.java - src/share/classes/org/w3c/dom/html/HTMLBaseElement.java - src/share/classes/org/w3c/dom/html/HTMLBaseFontElement.java - src/share/classes/org/w3c/dom/html/HTMLBodyElement.java - src/share/classes/org/w3c/dom/html/HTMLButtonElement.java - src/share/classes/org/w3c/dom/html/HTMLCollection.java - src/share/classes/org/w3c/dom/html/HTMLDListElement.java - src/share/classes/org/w3c/dom/html/HTMLDOMImplementation.java - src/share/classes/org/w3c/dom/html/HTMLDirectoryElement.java - src/share/classes/org/w3c/dom/html/HTMLDivElement.java - src/share/classes/org/w3c/dom/html/HTMLDocument.java - src/share/classes/org/w3c/dom/html/HTMLElement.java - src/share/classes/org/w3c/dom/html/HTMLFieldSetElement.java - src/share/classes/org/w3c/dom/html/HTMLFontElement.java - src/share/classes/org/w3c/dom/html/HTMLFormElement.java - src/share/classes/org/w3c/dom/html/HTMLFrameElement.java - src/share/classes/org/w3c/dom/html/HTMLFrameSetElement.java - src/share/classes/org/w3c/dom/html/HTMLHRElement.java - src/share/classes/org/w3c/dom/html/HTMLHeadElement.java - src/share/classes/org/w3c/dom/html/HTMLHeadingElement.java - src/share/classes/org/w3c/dom/html/HTMLHtmlElement.java - src/share/classes/org/w3c/dom/html/HTMLIFrameElement.java - src/share/classes/org/w3c/dom/html/HTMLImageElement.java - src/share/classes/org/w3c/dom/html/HTMLInputElement.java - src/share/classes/org/w3c/dom/html/HTMLIsIndexElement.java - src/share/classes/org/w3c/dom/html/HTMLLIElement.java - src/share/classes/org/w3c/dom/html/HTMLLabelElement.java - src/share/classes/org/w3c/dom/html/HTMLLegendElement.java - src/share/classes/org/w3c/dom/html/HTMLLinkElement.java - src/share/classes/org/w3c/dom/html/HTMLMapElement.java - src/share/classes/org/w3c/dom/html/HTMLMenuElement.java - src/share/classes/org/w3c/dom/html/HTMLMetaElement.java - src/share/classes/org/w3c/dom/html/HTMLModElement.java - src/share/classes/org/w3c/dom/html/HTMLOListElement.java - src/share/classes/org/w3c/dom/html/HTMLObjectElement.java - src/share/classes/org/w3c/dom/html/HTMLOptGroupElement.java - src/share/classes/org/w3c/dom/html/HTMLOptionElement.java - src/share/classes/org/w3c/dom/html/HTMLParagraphElement.java - src/share/classes/org/w3c/dom/html/HTMLParamElement.java - src/share/classes/org/w3c/dom/html/HTMLPreElement.java - src/share/classes/org/w3c/dom/html/HTMLQuoteElement.java - src/share/classes/org/w3c/dom/html/HTMLScriptElement.java - src/share/classes/org/w3c/dom/html/HTMLSelectElement.java - src/share/classes/org/w3c/dom/html/HTMLStyleElement.java - src/share/classes/org/w3c/dom/html/HTMLTableCaptionElement.java - src/share/classes/org/w3c/dom/html/HTMLTableCellElement.java - src/share/classes/org/w3c/dom/html/HTMLTableColElement.java - src/share/classes/org/w3c/dom/html/HTMLTableElement.java - src/share/classes/org/w3c/dom/html/HTMLTableRowElement.java - src/share/classes/org/w3c/dom/html/HTMLTableSectionElement.java - src/share/classes/org/w3c/dom/html/HTMLTextAreaElement.java - src/share/classes/org/w3c/dom/html/HTMLTitleElement.java - src/share/classes/org/w3c/dom/html/HTMLUListElement.java - src/share/classes/org/w3c/dom/ls/DOMImplementationLS.java - src/share/classes/org/w3c/dom/ls/LSException.java - src/share/classes/org/w3c/dom/ls/LSInput.java - src/share/classes/org/w3c/dom/ls/LSLoadEvent.java - src/share/classes/org/w3c/dom/ls/LSOutput.java - src/share/classes/org/w3c/dom/ls/LSParser.java - src/share/classes/org/w3c/dom/ls/LSParserFilter.java - src/share/classes/org/w3c/dom/ls/LSProgressEvent.java - src/share/classes/org/w3c/dom/ls/LSResourceResolver.java - src/share/classes/org/w3c/dom/ls/LSSerializer.java - src/share/classes/org/w3c/dom/ls/LSSerializerFilter.java - src/share/classes/org/w3c/dom/package.html - src/share/classes/org/w3c/dom/ranges/DocumentRange.java - src/share/classes/org/w3c/dom/ranges/Range.java - src/share/classes/org/w3c/dom/ranges/RangeException.java - src/share/classes/org/w3c/dom/ranges/package.html - src/share/classes/org/w3c/dom/stylesheets/DocumentStyle.java - src/share/classes/org/w3c/dom/stylesheets/LinkStyle.java - src/share/classes/org/w3c/dom/stylesheets/MediaList.java - src/share/classes/org/w3c/dom/stylesheets/StyleSheet.java - src/share/classes/org/w3c/dom/stylesheets/StyleSheetList.java - src/share/classes/org/w3c/dom/traversal/DocumentTraversal.java - src/share/classes/org/w3c/dom/traversal/NodeFilter.java - src/share/classes/org/w3c/dom/traversal/NodeIterator.java - src/share/classes/org/w3c/dom/traversal/TreeWalker.java - src/share/classes/org/w3c/dom/views/AbstractView.java - src/share/classes/org/w3c/dom/views/DocumentView.java - src/share/classes/org/w3c/dom/xpath/COPYRIGHT.html - src/share/classes/org/w3c/dom/xpath/XPathEvaluator.java - src/share/classes/org/w3c/dom/xpath/XPathException.java - src/share/classes/org/w3c/dom/xpath/XPathExpression.java - src/share/classes/org/w3c/dom/xpath/XPathNSResolver.java - src/share/classes/org/w3c/dom/xpath/XPathNamespace.java - src/share/classes/org/w3c/dom/xpath/XPathResult.java - src/share/classes/org/xml/sax/AttributeList.java - src/share/classes/org/xml/sax/Attributes.java - src/share/classes/org/xml/sax/COPYING - src/share/classes/org/xml/sax/COPYING.txt - src/share/classes/org/xml/sax/ContentHandler.java - src/share/classes/org/xml/sax/DTDHandler.java - src/share/classes/org/xml/sax/DocumentHandler.java - src/share/classes/org/xml/sax/EntityResolver.java - src/share/classes/org/xml/sax/ErrorHandler.java - src/share/classes/org/xml/sax/HandlerBase.java - src/share/classes/org/xml/sax/InputSource.java - src/share/classes/org/xml/sax/Locator.java - src/share/classes/org/xml/sax/Parser.java - src/share/classes/org/xml/sax/SAXException.java - src/share/classes/org/xml/sax/SAXNotRecognizedException.java - src/share/classes/org/xml/sax/SAXNotSupportedException.java - src/share/classes/org/xml/sax/SAXParseException.java - src/share/classes/org/xml/sax/XMLFilter.java - src/share/classes/org/xml/sax/XMLReader.java - src/share/classes/org/xml/sax/ext/Attributes2.java - src/share/classes/org/xml/sax/ext/Attributes2Impl.java - src/share/classes/org/xml/sax/ext/DeclHandler.java - src/share/classes/org/xml/sax/ext/DefaultHandler2.java - src/share/classes/org/xml/sax/ext/EntityResolver2.java - src/share/classes/org/xml/sax/ext/LexicalHandler.java - src/share/classes/org/xml/sax/ext/Locator2.java - src/share/classes/org/xml/sax/ext/Locator2Impl.java - src/share/classes/org/xml/sax/ext/package.html - src/share/classes/org/xml/sax/helpers/AttributeListImpl.java - src/share/classes/org/xml/sax/helpers/AttributesImpl.java - src/share/classes/org/xml/sax/helpers/DefaultHandler.java - src/share/classes/org/xml/sax/helpers/LocatorImpl.java - src/share/classes/org/xml/sax/helpers/NamespaceSupport.java - src/share/classes/org/xml/sax/helpers/NewInstance.java - src/share/classes/org/xml/sax/helpers/ParserAdapter.java - src/share/classes/org/xml/sax/helpers/ParserFactory.java - src/share/classes/org/xml/sax/helpers/XMLFilterImpl.java - src/share/classes/org/xml/sax/helpers/XMLReaderAdapter.java - src/share/classes/org/xml/sax/helpers/XMLReaderFactory.java - src/share/classes/org/xml/sax/helpers/package.html - src/share/classes/org/xml/sax/package.html Changeset: 6aadb7d98564 Author: asaha Date: 2012-05-21 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/6aadb7d98564 Merge Changeset: c865c6951fea Author: asaha Date: 2012-06-07 12:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/c865c6951fea Merge Changeset: 57476f66e13c Author: lana Date: 2012-06-26 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/57476f66e13c Merge From david.katleman at oracle.com Wed Jun 27 22:59:02 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 27 Jun 2012 22:59:02 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b44 for changeset f6a417540ef1 Message-ID: <20120627225907.5880247B65@hg.openjdk.java.net> Changeset: e80ac58b5ba9 Author: katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/e80ac58b5ba9 Added tag jdk8-b44 for changeset f6a417540ef1 ! .hgtags From david.katleman at oracle.com Wed Jun 27 23:05:10 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 27 Jun 2012 23:05:10 +0000 Subject: hg: jdk8/build/jdk: 57 new changesets Message-ID: <20120627231458.8416B47B67@hg.openjdk.java.net> Changeset: 9d88f2ce6338 Author: katleman Date: 2012-06-21 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9d88f2ce6338 Added tag jdk8-b44 for changeset db471a7af031 ! .hgtags Changeset: eb50eeb2eb7d Author: prr Date: 2012-06-13 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/eb50eeb2eb7d 7027300: Unsynchronized HashMap access causes endless loop Reviewed-by: bae, jgodinez ! src/share/classes/sun/font/SunLayoutEngine.java Changeset: 5959fec806d8 Author: bae Date: 2012-06-14 11:14 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5959fec806d8 7153693: Three 2D_ImageIO tests failed due ImageFormatException on OEL 6.* Unbreakable Kernel x64 Reviewed-by: jgodinez, prr ! src/share/native/sun/awt/image/jpeg/jpegdecoder.c Changeset: 2aa89f018a2f Author: prr Date: 2012-06-14 16:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2aa89f018a2f 7158366: [macosx] Print-to-file dialog doesn't have an entry field for a name Reviewed-by: bae, jgodinez ! src/share/classes/sun/print/ServiceDialog.java Changeset: e42563f8ec12 Author: lana Date: 2012-06-17 22:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e42563f8ec12 Merge - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile - makefiles/common/shared/Defs-utils.gmk - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers - src/share/classes/sun/nio/ch/DevPollSelectorProvider.java - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java - src/share/native/java/sql/DriverManager.c - test/sun/security/krb5/auto/ok-as-delegate-xrealm.sh - test/sun/security/krb5/auto/ok-as-delegate.sh Changeset: b8ff85860648 Author: prr Date: 2012-06-19 09:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b8ff85860648 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null Reviewed-by: bae, igor ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: c05893704c82 Author: lana Date: 2012-06-25 21:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c05893704c82 Merge Changeset: 45259658e158 Author: rupashka Date: 2012-06-09 17:42 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/45259658e158 7165725: JAVA6 HTML PARSER CANNOT PARSE MULTIPLE SCRIPT TAGS IN A LINE CORRECTLY Reviewed-by: alexsch ! src/share/classes/javax/swing/text/html/parser/Parser.java + test/javax/swing/text/html/parser/Parser/7165725/bug7165725.java + test/javax/swing/text/html/parser/Parser/7165725/false-text-after-script.html + test/javax/swing/text/html/parser/Parser/7165725/successive-script-tag.html Changeset: 0474e0ed2ef2 Author: kizune Date: 2012-06-09 19:18 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0474e0ed2ef2 7173487: closed/java/awt/Frame/RemoveNotifyTest/RemoveNotifyTest.html Reviewed-by: anthony, dcherepanov, serb ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java Changeset: b57167b71169 Author: luchsh Date: 2012-06-11 10:52 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b57167b71169 7155887: ComboBox does not display focus outline in GTK L&F Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java Changeset: f05e517a74b3 Author: anthony Date: 2012-06-13 18:33 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f05e517a74b3 7176644: [macosx] Missing NSAutoreleasePool in CGLGraphicsConfig.m OGLGC_DestroyOGLGraphicsConfig Summary: Create and drain an autorelease pool Reviewed-by: anthony, dcherepanov Contributed-by: Tomas Hurka ! src/macosx/native/sun/java2d/opengl/CGLGraphicsConfig.m Changeset: f90369b3d61d Author: alexsch Date: 2012-06-13 18:43 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f90369b3d61d 7150049: [macosx] closed/javax/swing/JCheckBox/4449413/bug4449413.java check the checkbox again,it auto fail Reviewed-by: rupashka + test/javax/swing/JCheckBox/4449413/bug4449413.html + test/javax/swing/JCheckBox/4449413/bug4449413.java Changeset: 8326709c6315 Author: kizune Date: 2012-06-15 18:28 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8326709c6315 7171163: [macosx] Shortcomings in the design of the secondary native event loop made JavaFX DnD deadlock Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java Changeset: f709f8ebebd4 Author: lana Date: 2012-06-17 22:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f709f8ebebd4 Merge - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile - makefiles/common/shared/Defs-utils.gmk - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers - src/share/classes/sun/nio/ch/DevPollSelectorProvider.java - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java - src/share/native/java/sql/DriverManager.c - test/sun/security/krb5/auto/ok-as-delegate-xrealm.sh - test/sun/security/krb5/auto/ok-as-delegate.sh Changeset: 4b470e9017da Author: alexsch Date: 2012-06-18 15:39 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4b470e9017da 7174970: NLS [ccjk] Extra mnemonic keys at standard filechooserdialog (open and save) in metal L&F Reviewed-by: rupashka ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties Changeset: 3226f1968e77 Author: kizune Date: 2012-06-19 21:09 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3226f1968e77 7172430: [macosx] debug message in non debug jdk build Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/AWTView.m Changeset: e7dc778d768e Author: anthony Date: 2012-06-22 16:32 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e7dc778d768e 7170716: JVM crash when opening an AWT app from a registered file. Summary: Copy the queued blocks to prevent their deallocation Reviewed-by: anthony, swingler Contributed-by: Marco Dinacci ! src/macosx/native/sun/osxapp/QueuingApplicationDelegate.h ! src/macosx/native/sun/osxapp/QueuingApplicationDelegate.m Changeset: cafcc94a11a7 Author: anthony Date: 2012-06-25 17:27 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cafcc94a11a7 7174718: [macosx] Regression in 7u6 b12: PopupFactory leaks DefaultFrames. Summary: Fix memory management Reviewed-by: art, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 6dae09c6759e Author: lana Date: 2012-06-25 21:36 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6dae09c6759e Merge Changeset: fc575c78f5d3 Author: alanb Date: 2012-06-10 10:29 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fc575c78f5d3 7175775: Disable SA options in jinfo/Basic.java test until SA updated for new hash and String count/offset Reviewed-by: minqi ! test/sun/tools/jinfo/Basic.sh Changeset: 46ff1b63b0c3 Author: lancea Date: 2012-06-11 07:10 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/46ff1b63b0c3 7171917: CachedRowSetImpl.populate does not handle map properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java Changeset: 6b6a73e8c036 Author: lancea Date: 2012-06-12 17:32 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6b6a73e8c036 7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag properly Reviewed-by: joehw ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java Changeset: 9fd127ff51d5 Author: ohair Date: 2012-06-12 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9fd127ff51d5 7176138: Fixes for missing close() calls and possible null pointer reference instead of fatal error Reviewed-by: dcubed ! src/share/demo/jvmti/hprof/hprof_table.c ! src/solaris/demo/jvmti/hprof/hprof_md.c Changeset: 7b93a2a9cd15 Author: ohair Date: 2012-06-12 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7b93a2a9cd15 Merge Changeset: 4435f8b20d08 Author: weijun Date: 2012-06-13 19:23 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4435f8b20d08 7176574: sun/security/krb5/auto/TcpTimeout.java failed with solaris-i586 Reviewed-by: chegar ! test/sun/security/krb5/auto/TcpTimeout.java Changeset: 4f99d146fce0 Author: alanb Date: 2012-06-14 12:13 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4f99d146fce0 7176630: (sc) SocketChannel.write does not write more than 128k when channel configured blocking [win] Reviewed-by: khazra, chegar ! src/windows/native/sun/nio/ch/SocketDispatcher.c + test/java/nio/channels/SocketChannel/ShortWrite.java Changeset: 505455116320 Author: mduigou Date: 2012-06-13 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/505455116320 7173919: Minor optimization of hashing methods Summary: several minor optimizations to hashing methods used by hash map classes Reviewed-by: dholmes ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/WeakHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: 28588ace1fb9 Author: lancea Date: 2012-06-14 15:05 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/28588ace1fb9 7145913: CachedRowSetSwriter.insertNewRow() throws SQLException Reviewed-by: joehw, naoto, psandoz, forax ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java Changeset: 00c9d6cce3ec Author: coffeys Date: 2012-06-15 14:16 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/00c9d6cce3ec 7156963: Incorrect copyright header in java/io/SerialCallbackContext Reviewed-by: weijun, coffeys Contributed-by: edvard.wendelin at oracle.com ! src/share/classes/java/io/SerialCallbackContext.java Changeset: 8deec0d1fc6f Author: mullan Date: 2012-06-15 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8deec0d1fc6f 7176326: CertPath/CertPathBuilderTest failures after webrev 6854712_6637288_7126011 Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/BasicChecker.java + test/java/security/cert/CertPathBuilder/zeroLengthPath/ZeroLengthPath.java Changeset: 0e382512610f Author: mullan Date: 2012-06-15 08:47 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0e382512610f Merge Changeset: e01b47409e37 Author: mullan Date: 2012-06-15 09:16 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e01b47409e37 Merge Changeset: 23394d686f74 Author: alanb Date: 2012-06-15 17:16 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/23394d686f74 7176485: (bf) Allow temporary buffer cache to grow to IOV_MAX Reviewed-by: chegar, coffeys ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/IOUtil.java ! src/share/classes/sun/nio/ch/Util.java ! src/solaris/native/sun/nio/ch/FileDispatcherImpl.c ! src/solaris/native/sun/nio/ch/IOUtil.c ! src/windows/native/sun/nio/ch/IOUtil.c ! src/windows/native/sun/nio/ch/SocketDispatcher.c ! src/windows/native/sun/nio/ch/nio_util.h Changeset: e60cedd3a4aa Author: mduigou Date: 2012-06-15 13:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e60cedd3a4aa 7175758: Improve unit test of Map iterators and Iterator.remove() Summary: Adds additional tests of Map iterators and Iterator.remove() Reviewed-by: lancea ! test/java/util/Map/Collisions.java Changeset: 8e5635ded425 Author: wetmore Date: 2012-06-15 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8e5635ded425 7177556: Put TestProviderLeak.java on the ProblemList until test can be reworked Reviewed-by: khazra ! test/ProblemList.txt Changeset: 6b40703aad55 Author: lana Date: 2012-06-17 21:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6b40703aad55 Merge - makefiles/altclasses/Makefile - makefiles/apple/Makefile - makefiles/apple/applescript/Makefile - makefiles/com/Makefile - makefiles/com/apple/Makefile - makefiles/com/apple/osx/Makefile - makefiles/com/apple/osxui/Makefile - makefiles/com/oracle/Makefile - makefiles/com/oracle/jfr/Makefile - makefiles/com/oracle/security/ucrypto/FILES_c.gmk - makefiles/com/oracle/security/ucrypto/Makefile - makefiles/com/oracle/security/ucrypto/mapfile-vers - makefiles/com/sun/Makefile - makefiles/common/shared/Defs-utils.gmk - makefiles/java/fdlibm/FILES_c.gmk - makefiles/java/fdlibm/Makefile - makefiles/java/instrument/Makefile - makefiles/java/instrument/mapfile-vers - makefiles/java/java/Exportedfiles.gmk - makefiles/java/java/FILES_c.gmk - makefiles/java/java/FILES_java.gmk - makefiles/java/java/Makefile - makefiles/java/java/localelist.sh - makefiles/java/java/mapfile-vers - makefiles/java/java/reflect/Makefile - makefiles/java/java/reorder-i586 - makefiles/java/java/reorder-sparc - makefiles/java/java/reorder-sparcv9 - makefiles/java/java_crw_demo/Makefile - makefiles/java/java_crw_demo/mapfile-vers - makefiles/java/java_hprof_demo/Makefile - makefiles/java/java_hprof_demo/mapfile-vers - makefiles/java/jexec/Makefile - makefiles/java/jli/Makefile - makefiles/java/jli/mapfile-vers - makefiles/java/jobjc/Makefile - makefiles/java/jvm/Makefile - makefiles/java/main/Makefile - makefiles/java/main/java/Makefile - makefiles/java/main/java/mapfile-amd64 - makefiles/java/main/java/mapfile-i586 - makefiles/java/main/java/mapfile-sparc - makefiles/java/main/java/mapfile-sparcv9 - makefiles/java/main/javaw/Makefile - makefiles/java/management/Exportedfiles.gmk - makefiles/java/management/FILES_c.gmk - makefiles/java/management/Makefile - makefiles/java/management/mapfile-vers - makefiles/java/net/FILES_c.gmk - makefiles/java/net/Makefile - makefiles/java/net/mapfile-vers - makefiles/java/nio/Exportedfiles.gmk - makefiles/java/nio/FILES_c.gmk - makefiles/java/nio/FILES_java.gmk - makefiles/java/nio/Makefile - makefiles/java/nio/addNotices.sh - makefiles/java/nio/genBuffer.sh - makefiles/java/nio/genCharsetProvider.sh - makefiles/java/nio/genCoder.sh - makefiles/java/nio/genExceptions.sh - makefiles/java/nio/mapfile-bsd - makefiles/java/nio/mapfile-linux - makefiles/java/nio/mapfile-solaris - makefiles/java/nio/reorder-i586 - makefiles/java/nio/reorder-sparc - makefiles/java/nio/reorder-sparcv9 - makefiles/java/npt/Makefile - makefiles/java/npt/mapfile-vers - makefiles/java/redist/fonts/Makefile - makefiles/java/security/Makefile - makefiles/java/sun_nio/FILES_java.gmk - makefiles/java/sun_nio/Makefile - makefiles/java/util/FILES_java.gmk - makefiles/java/util/FILES_properties.gmk - makefiles/java/util/Makefile - makefiles/java/verify/Makefile - makefiles/java/verify/mapfile-vers - makefiles/java/verify/reorder-i586 - makefiles/java/verify/reorder-sparc - makefiles/java/verify/reorder-sparcv9 - makefiles/javax/Makefile - makefiles/javax/imageio/Makefile - makefiles/javax/management/Makefile - makefiles/javax/sound/FILES_c.gmk - makefiles/javax/sound/Makefile - makefiles/javax/sound/SoundDefs.gmk - makefiles/javax/sound/jsoundalsa/Makefile - makefiles/javax/sound/jsoundalsa/mapfile-vers - makefiles/javax/sound/jsoundds/Makefile - makefiles/javax/sound/mapfile-vers - makefiles/javax/sql/Makefile - makefiles/javax/swing/FILES.gmk - makefiles/javax/swing/Makefile - makefiles/javax/swing/beaninfo/FILES.gmk - makefiles/javax/swing/beaninfo/Makefile - makefiles/javax/swing/beaninfo/SwingBeans.gmk - makefiles/javax/swing/beaninfo/manifest - makefiles/javax/swing/html32dtd/Makefile - makefiles/javax/swing/plaf/FILES.gmk - makefiles/javax/swing/plaf/Makefile - makefiles/sun/Makefile - makefiles/sun/awt/CondenseRules.awk - makefiles/sun/awt/Depend.mak - makefiles/sun/awt/Depend.sed - makefiles/sun/awt/FILES_c_macosx.gmk - makefiles/sun/awt/FILES_c_unix.gmk - makefiles/sun/awt/FILES_c_windows.gmk - makefiles/sun/awt/FILES_export_macosx.gmk - makefiles/sun/awt/FILES_export_unix.gmk - makefiles/sun/awt/FILES_export_windows.gmk - makefiles/sun/awt/Makefile - makefiles/sun/awt/README - makefiles/sun/awt/make.depend - makefiles/sun/awt/mapfile-mawt-vers - makefiles/sun/awt/mapfile-vers - makefiles/sun/awt/mapfile-vers-linux - makefiles/sun/awt/mawt.gmk - makefiles/sun/cmm/Makefile - makefiles/sun/cmm/kcms/FILES_c_unix.gmk - makefiles/sun/cmm/kcms/FILES_c_windows.gmk - makefiles/sun/cmm/kcms/Makefile - makefiles/sun/cmm/kcms/mapfile-vers - makefiles/sun/dcpr/FILES_c.gmk - makefiles/sun/dcpr/Makefile - makefiles/sun/dcpr/mapfile-vers - makefiles/sun/headless/Makefile - makefiles/sun/headless/mapfile-vers - makefiles/sun/headless/reorder-i586 - makefiles/sun/headless/reorder-sparc - makefiles/sun/headless/reorder-sparcv9 - makefiles/sun/image/Makefile - makefiles/sun/image/generic/FILES_c.gmk - makefiles/sun/image/generic/Makefile - makefiles/sun/image/generic/mapfile-vers - makefiles/sun/image/vis/FILES_c.gmk - makefiles/sun/image/vis/Makefile - makefiles/sun/javazic/Makefile - makefiles/sun/jdbc/Makefile - makefiles/sun/jdga/Makefile - makefiles/sun/jdga/mapfile-vers - makefiles/sun/lwawt/FILES_c_macosx.gmk - makefiles/sun/lwawt/FILES_export_macosx.gmk - makefiles/sun/lwawt/Makefile - makefiles/sun/nio/Makefile - makefiles/sun/nio/cs/FILES_java.gmk - makefiles/sun/nio/cs/Makefile - makefiles/sun/org/Makefile - makefiles/sun/org/mozilla/Makefile - makefiles/sun/org/mozilla/javascript/Makefile - makefiles/sun/osxapp/Makefile - makefiles/sun/security/Makefile - makefiles/sun/security/ec/FILES_c.gmk - makefiles/sun/security/ec/mapfile-vers - makefiles/sun/security/jgss/Makefile - makefiles/sun/security/jgss/wrapper/FILES_c.gmk - makefiles/sun/security/jgss/wrapper/Makefile - makefiles/sun/security/jgss/wrapper/mapfile-vers - makefiles/sun/security/krb5/FILES_c_windows.gmk - makefiles/sun/security/krb5/Makefile - makefiles/sun/security/mscapi/FILES_cpp.gmk - makefiles/sun/security/mscapi/Makefile - makefiles/sun/security/other/Makefile - makefiles/sun/security/smartcardio/FILES_c.gmk - makefiles/sun/security/smartcardio/Makefile - makefiles/sun/security/smartcardio/mapfile-vers - makefiles/sun/security/tools/Makefile - makefiles/sun/security/util/Makefile - makefiles/sun/splashscreen/FILES_c.gmk - makefiles/sun/splashscreen/Makefile - makefiles/sun/splashscreen/mapfile-vers - makefiles/sun/xawt/FILES_c_unix.gmk - makefiles/sun/xawt/FILES_export_unix.gmk - makefiles/sun/xawt/Makefile - makefiles/sun/xawt/mapfile-vers Changeset: 689129c71ccd Author: alanb Date: 2012-06-18 11:19 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/689129c71ccd 7177617: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing (win) Reviewed-by: chegar, coffeys ! test/java/nio/channels/AsyncCloseAndInterrupt.java ! test/java/nio/channels/SocketChannel/AdaptSocket.java + test/java/nio/channels/SocketChannel/CloseDuringWrite.java ! test/java/nio/channels/TestUtil.java Changeset: 4419c8f0b2f2 Author: okutsu Date: 2012-06-19 16:21 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4419c8f0b2f2 6380549: (rb) ResourceBundle.Control global binding support Reviewed-by: naoto ! make/java/java/FILES_java.gmk ! src/share/classes/java/util/ResourceBundle.java + src/share/classes/java/util/spi/ResourceBundleControlProvider.java + test/java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.java + test/java/util/spi/ResourceBundleControlProvider/UserDefaultControlTest.sh + test/java/util/spi/ResourceBundleControlProvider/providersrc/Makefile + test/java/util/spi/ResourceBundleControlProvider/providersrc/UserControlProvider.java + test/java/util/spi/ResourceBundleControlProvider/providersrc/UserXMLControl.java + test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB.xml + test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB_ja.xml + test/java/util/spi/ResourceBundleControlProvider/providersrc/java.util.spi.ResourceBundleControlProvider + test/java/util/spi/ResourceBundleControlProvider/rbcontrolprovider.jar Changeset: efc2791d7c5d Author: chegar Date: 2012-06-19 10:20 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/efc2791d7c5d 6901992: InvalidJarIndexException due to bug in sun.misc.JarIndex.merge() Reviewed-by: chegar Contributed-by: dbelfer at gmail.com ! src/share/classes/sun/misc/JarIndex.java + test/sun/misc/JarIndex/JarIndexMergeForClassLoaderTest.java + test/sun/misc/JarIndex/JarIndexMergeTest.java Changeset: cdcbd22cfb9d Author: xuelei Date: 2012-06-19 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cdcbd22cfb9d 7166487: checkSequenceNumber method never called within readRecord of SSLEngineImpl Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLEngineImpl.java Changeset: dfe5617c18b4 Author: dholmes Date: 2012-06-20 22:40 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dfe5617c18b4 7178483: Change version string for Embedded releases Reviewed-by: dholmes, lancea Contributed-by: Gary Collins ! make/common/Defs-embedded.gmk Changeset: 4a4a04bfeece Author: chegar Date: 2012-06-25 14:19 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4a4a04bfeece 7176784: Windows authentication not working on some computers Reviewed-by: michaelm ! src/windows/native/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.c Changeset: b76779abcd7f Author: lana Date: 2012-06-25 21:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b76779abcd7f Merge Changeset: bff59bf994da Author: mullan Date: 2012-02-22 15:38 -0500 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bff59bf994da 7145239: Finetune package definition restriction Reviewed-by: hawtin ! src/share/lib/security/java.security ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 1d8a3ef381f7 Author: bae Date: 2012-02-28 10:44 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1d8a3ef381f7 7143617: Improve fontmanager layout lookup operations Reviewed-by: igor, prr, mschoene ! src/share/native/sun/font/layout/LookupProcessor.cpp ! src/share/native/sun/font/layout/LookupProcessor.h Changeset: 9e6e535a6769 Author: rupashka Date: 2012-02-28 16:09 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9e6e535a6769 7143614: SynthLookAndFeel stability improvement Reviewed-by: malenkov ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLabelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java + test/javax/swing/plaf/synth/7143614/bug7143614.java Changeset: 8516c5b4521b Author: weijun Date: 2012-02-29 14:06 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8516c5b4521b 7143872: Improve certificate extension processing Reviewed-by: mullan ! src/share/classes/sun/security/x509/CRLExtensions.java ! src/share/classes/sun/security/x509/CertificateExtensions.java ! src/share/classes/sun/security/x509/X509CRLEntryImpl.java ! src/share/classes/sun/security/x509/X509CRLImpl.java ! src/share/classes/sun/security/x509/X509CertImpl.java + test/sun/security/x509/X509CRLImpl/OrderAndDup.java Changeset: 3640f1a043f8 Author: coffeys Date: 2012-03-26 14:03 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3640f1a043f8 7143851: Improve IIOP stub and tie generation in RMIC 7149048: Changes to corba rmic stubGenerator class are not used during jdk build process Reviewed-by: mschoene, robm ! make/com/sun/jmx/Makefile Changeset: 9de49289df0f Author: asaha Date: 2012-04-10 10:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9de49289df0f Merge ! make/com/oracle/net/Makefile - make/sun/motif12/reorder-i586 - make/sun/motif12/reorder-sparc - make/sun/motif12/reorder-sparcv9 ! make/sun/rmi/rmi/mapfile-vers - src/linux/doc/man/apt.1 - src/linux/doc/man/ja/apt.1 - src/share/classes/com/sun/tools/jdi/LinkedHashMap.java - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/awt/FocusingTextField.java - src/share/classes/sun/awt/HorizBagLayout.java - src/share/classes/sun/awt/OrientableFlowLayout.java - src/share/classes/sun/awt/VariableGridLayout.java - src/share/classes/sun/awt/VerticalBagLayout.java - src/share/classes/sun/io/ByteToCharASCII.java - src/share/classes/sun/io/ByteToCharBig5.java - src/share/classes/sun/io/ByteToCharBig5_HKSCS.java - src/share/classes/sun/io/ByteToCharBig5_Solaris.java - src/share/classes/sun/io/ByteToCharConverter.java - src/share/classes/sun/io/ByteToCharCp037.java - src/share/classes/sun/io/ByteToCharCp1006.java - src/share/classes/sun/io/ByteToCharCp1025.java - src/share/classes/sun/io/ByteToCharCp1026.java - src/share/classes/sun/io/ByteToCharCp1046.java - src/share/classes/sun/io/ByteToCharCp1047.java - src/share/classes/sun/io/ByteToCharCp1097.java - src/share/classes/sun/io/ByteToCharCp1098.java - src/share/classes/sun/io/ByteToCharCp1112.java - src/share/classes/sun/io/ByteToCharCp1122.java - src/share/classes/sun/io/ByteToCharCp1123.java - src/share/classes/sun/io/ByteToCharCp1124.java - src/share/classes/sun/io/ByteToCharCp1140.java - src/share/classes/sun/io/ByteToCharCp1141.java - src/share/classes/sun/io/ByteToCharCp1142.java - src/share/classes/sun/io/ByteToCharCp1143.java - src/share/classes/sun/io/ByteToCharCp1144.java - src/share/classes/sun/io/ByteToCharCp1145.java - src/share/classes/sun/io/ByteToCharCp1146.java - src/share/classes/sun/io/ByteToCharCp1147.java - src/share/classes/sun/io/ByteToCharCp1148.java - src/share/classes/sun/io/ByteToCharCp1149.java - src/share/classes/sun/io/ByteToCharCp1250.java - src/share/classes/sun/io/ByteToCharCp1251.java - src/share/classes/sun/io/ByteToCharCp1252.java - src/share/classes/sun/io/ByteToCharCp1253.java - src/share/classes/sun/io/ByteToCharCp1254.java - src/share/classes/sun/io/ByteToCharCp1255.java - src/share/classes/sun/io/ByteToCharCp1256.java - src/share/classes/sun/io/ByteToCharCp1257.java - src/share/classes/sun/io/ByteToCharCp1258.java - src/share/classes/sun/io/ByteToCharCp1381.java - src/share/classes/sun/io/ByteToCharCp1383.java - src/share/classes/sun/io/ByteToCharCp273.java - src/share/classes/sun/io/ByteToCharCp277.java - src/share/classes/sun/io/ByteToCharCp278.java - src/share/classes/sun/io/ByteToCharCp280.java - src/share/classes/sun/io/ByteToCharCp284.java - src/share/classes/sun/io/ByteToCharCp285.java - src/share/classes/sun/io/ByteToCharCp297.java - src/share/classes/sun/io/ByteToCharCp33722.java - src/share/classes/sun/io/ByteToCharCp420.java - src/share/classes/sun/io/ByteToCharCp424.java - src/share/classes/sun/io/ByteToCharCp437.java - src/share/classes/sun/io/ByteToCharCp500.java - src/share/classes/sun/io/ByteToCharCp737.java - src/share/classes/sun/io/ByteToCharCp775.java - src/share/classes/sun/io/ByteToCharCp833.java - src/share/classes/sun/io/ByteToCharCp834.java - src/share/classes/sun/io/ByteToCharCp838.java - src/share/classes/sun/io/ByteToCharCp850.java - src/share/classes/sun/io/ByteToCharCp852.java - src/share/classes/sun/io/ByteToCharCp855.java - src/share/classes/sun/io/ByteToCharCp856.java - src/share/classes/sun/io/ByteToCharCp857.java - src/share/classes/sun/io/ByteToCharCp858.java - src/share/classes/sun/io/ByteToCharCp860.java - src/share/classes/sun/io/ByteToCharCp861.java - src/share/classes/sun/io/ByteToCharCp862.java - src/share/classes/sun/io/ByteToCharCp863.java - src/share/classes/sun/io/ByteToCharCp864.java - src/share/classes/sun/io/ByteToCharCp865.java - src/share/classes/sun/io/ByteToCharCp866.java - src/share/classes/sun/io/ByteToCharCp868.java - src/share/classes/sun/io/ByteToCharCp869.java - src/share/classes/sun/io/ByteToCharCp870.java - src/share/classes/sun/io/ByteToCharCp871.java - src/share/classes/sun/io/ByteToCharCp874.java - src/share/classes/sun/io/ByteToCharCp875.java - src/share/classes/sun/io/ByteToCharCp918.java - src/share/classes/sun/io/ByteToCharCp921.java - src/share/classes/sun/io/ByteToCharCp922.java - src/share/classes/sun/io/ByteToCharCp930.java - src/share/classes/sun/io/ByteToCharCp933.java - src/share/classes/sun/io/ByteToCharCp935.java - src/share/classes/sun/io/ByteToCharCp937.java - src/share/classes/sun/io/ByteToCharCp939.java - src/share/classes/sun/io/ByteToCharCp942.java - src/share/classes/sun/io/ByteToCharCp942C.java - src/share/classes/sun/io/ByteToCharCp943.java - src/share/classes/sun/io/ByteToCharCp943C.java - src/share/classes/sun/io/ByteToCharCp948.java - src/share/classes/sun/io/ByteToCharCp949.java - src/share/classes/sun/io/ByteToCharCp949C.java - src/share/classes/sun/io/ByteToCharCp950.java - src/share/classes/sun/io/ByteToCharCp964.java - src/share/classes/sun/io/ByteToCharCp970.java - src/share/classes/sun/io/ByteToCharDBCS_ASCII.java - src/share/classes/sun/io/ByteToCharDBCS_EBCDIC.java - src/share/classes/sun/io/ByteToCharDoubleByte.java - src/share/classes/sun/io/ByteToCharEUC.java - src/share/classes/sun/io/ByteToCharEUC2.java - src/share/classes/sun/io/ByteToCharEUC_CN.java - src/share/classes/sun/io/ByteToCharEUC_JP.java - src/share/classes/sun/io/ByteToCharEUC_JP_LINUX.java - src/share/classes/sun/io/ByteToCharEUC_JP_Solaris.java - src/share/classes/sun/io/ByteToCharEUC_KR.java - src/share/classes/sun/io/ByteToCharEUC_TW.java - src/share/classes/sun/io/ByteToCharGB18030.java - src/share/classes/sun/io/ByteToCharGB18030DB.java - src/share/classes/sun/io/ByteToCharGBK.java - src/share/classes/sun/io/ByteToCharISCII91.java - src/share/classes/sun/io/ByteToCharISO2022.java - src/share/classes/sun/io/ByteToCharISO2022CN.java - src/share/classes/sun/io/ByteToCharISO2022JP.java - src/share/classes/sun/io/ByteToCharISO2022KR.java - src/share/classes/sun/io/ByteToCharISO8859_1.java - src/share/classes/sun/io/ByteToCharISO8859_13.java - src/share/classes/sun/io/ByteToCharISO8859_15.java - src/share/classes/sun/io/ByteToCharISO8859_2.java - src/share/classes/sun/io/ByteToCharISO8859_3.java - src/share/classes/sun/io/ByteToCharISO8859_4.java - src/share/classes/sun/io/ByteToCharISO8859_5.java - src/share/classes/sun/io/ByteToCharISO8859_6.java - src/share/classes/sun/io/ByteToCharISO8859_7.java - src/share/classes/sun/io/ByteToCharISO8859_8.java - src/share/classes/sun/io/ByteToCharISO8859_9.java - src/share/classes/sun/io/ByteToCharJIS0201.java - src/share/classes/sun/io/ByteToCharJIS0208.java - src/share/classes/sun/io/ByteToCharJIS0208_Solaris.java - src/share/classes/sun/io/ByteToCharJIS0212.java - src/share/classes/sun/io/ByteToCharJIS0212_Solaris.java - src/share/classes/sun/io/ByteToCharJISAutoDetect.java - src/share/classes/sun/io/ByteToCharJohab.java - src/share/classes/sun/io/ByteToCharKOI8_R.java - src/share/classes/sun/io/ByteToCharMS874.java - src/share/classes/sun/io/ByteToCharMS932.java - src/share/classes/sun/io/ByteToCharMS936.java - src/share/classes/sun/io/ByteToCharMS949.java - src/share/classes/sun/io/ByteToCharMS950.java - src/share/classes/sun/io/ByteToCharMS950_HKSCS.java - src/share/classes/sun/io/ByteToCharMacArabic.java - src/share/classes/sun/io/ByteToCharMacCentralEurope.java - src/share/classes/sun/io/ByteToCharMacCroatian.java - src/share/classes/sun/io/ByteToCharMacCyrillic.java - src/share/classes/sun/io/ByteToCharMacDingbat.java - src/share/classes/sun/io/ByteToCharMacGreek.java - src/share/classes/sun/io/ByteToCharMacHebrew.java - src/share/classes/sun/io/ByteToCharMacIceland.java - src/share/classes/sun/io/ByteToCharMacRoman.java - src/share/classes/sun/io/ByteToCharMacRomania.java - src/share/classes/sun/io/ByteToCharMacSymbol.java - src/share/classes/sun/io/ByteToCharMacThai.java - src/share/classes/sun/io/ByteToCharMacTurkish.java - src/share/classes/sun/io/ByteToCharMacUkraine.java - src/share/classes/sun/io/ByteToCharPCK.java - src/share/classes/sun/io/ByteToCharSJIS.java - src/share/classes/sun/io/ByteToCharSingleByte.java - src/share/classes/sun/io/ByteToCharTIS620.java - src/share/classes/sun/io/ByteToCharUTF16.java - src/share/classes/sun/io/ByteToCharUTF8.java - src/share/classes/sun/io/ByteToCharUnicode.java - src/share/classes/sun/io/ByteToCharUnicodeBig.java - src/share/classes/sun/io/ByteToCharUnicodeBigUnmarked.java - src/share/classes/sun/io/ByteToCharUnicodeLittle.java - src/share/classes/sun/io/ByteToCharUnicodeLittleUnmarked.java - src/share/classes/sun/io/CharToByteASCII.java - src/share/classes/sun/io/CharToByteBig5.java - src/share/classes/sun/io/CharToByteBig5_HKSCS.java - src/share/classes/sun/io/CharToByteBig5_Solaris.java - src/share/classes/sun/io/CharToByteConverter.java - src/share/classes/sun/io/CharToByteCp037.java - src/share/classes/sun/io/CharToByteCp1006.java - src/share/classes/sun/io/CharToByteCp1025.java - src/share/classes/sun/io/CharToByteCp1026.java - src/share/classes/sun/io/CharToByteCp1046.java - src/share/classes/sun/io/CharToByteCp1047.java - src/share/classes/sun/io/CharToByteCp1097.java - src/share/classes/sun/io/CharToByteCp1098.java - src/share/classes/sun/io/CharToByteCp1112.java - src/share/classes/sun/io/CharToByteCp1122.java - src/share/classes/sun/io/CharToByteCp1123.java - src/share/classes/sun/io/CharToByteCp1124.java - src/share/classes/sun/io/CharToByteCp1140.java - src/share/classes/sun/io/CharToByteCp1141.java - src/share/classes/sun/io/CharToByteCp1142.java - src/share/classes/sun/io/CharToByteCp1143.java - src/share/classes/sun/io/CharToByteCp1144.java - src/share/classes/sun/io/CharToByteCp1145.java - src/share/classes/sun/io/CharToByteCp1146.java - src/share/classes/sun/io/CharToByteCp1147.java - src/share/classes/sun/io/CharToByteCp1148.java - src/share/classes/sun/io/CharToByteCp1149.java - src/share/classes/sun/io/CharToByteCp1250.java - src/share/classes/sun/io/CharToByteCp1251.java - src/share/classes/sun/io/CharToByteCp1252.java - src/share/classes/sun/io/CharToByteCp1253.java - src/share/classes/sun/io/CharToByteCp1254.java - src/share/classes/sun/io/CharToByteCp1255.java - src/share/classes/sun/io/CharToByteCp1256.java - src/share/classes/sun/io/CharToByteCp1257.java - src/share/classes/sun/io/CharToByteCp1258.java - src/share/classes/sun/io/CharToByteCp1381.java - src/share/classes/sun/io/CharToByteCp1383.java - src/share/classes/sun/io/CharToByteCp273.java - src/share/classes/sun/io/CharToByteCp277.java - src/share/classes/sun/io/CharToByteCp278.java - src/share/classes/sun/io/CharToByteCp280.java - src/share/classes/sun/io/CharToByteCp284.java - src/share/classes/sun/io/CharToByteCp285.java - src/share/classes/sun/io/CharToByteCp297.java - src/share/classes/sun/io/CharToByteCp33722.java - src/share/classes/sun/io/CharToByteCp420.java - src/share/classes/sun/io/CharToByteCp424.java - src/share/classes/sun/io/CharToByteCp437.java - src/share/classes/sun/io/CharToByteCp500.java - src/share/classes/sun/io/CharToByteCp737.java - src/share/classes/sun/io/CharToByteCp775.java - src/share/classes/sun/io/CharToByteCp833.java - src/share/classes/sun/io/CharToByteCp834.java - src/share/classes/sun/io/CharToByteCp838.java - src/share/classes/sun/io/CharToByteCp850.java - src/share/classes/sun/io/CharToByteCp852.java - src/share/classes/sun/io/CharToByteCp855.java - src/share/classes/sun/io/CharToByteCp856.java - src/share/classes/sun/io/CharToByteCp857.java - src/share/classes/sun/io/CharToByteCp858.java - src/share/classes/sun/io/CharToByteCp860.java - src/share/classes/sun/io/CharToByteCp861.java - src/share/classes/sun/io/CharToByteCp862.java - src/share/classes/sun/io/CharToByteCp863.java - src/share/classes/sun/io/CharToByteCp864.java - src/share/classes/sun/io/CharToByteCp865.java - src/share/classes/sun/io/CharToByteCp866.java - src/share/classes/sun/io/CharToByteCp868.java - src/share/classes/sun/io/CharToByteCp869.java - src/share/classes/sun/io/CharToByteCp870.java - src/share/classes/sun/io/CharToByteCp871.java - src/share/classes/sun/io/CharToByteCp874.java - src/share/classes/sun/io/CharToByteCp875.java - src/share/classes/sun/io/CharToByteCp918.java - src/share/classes/sun/io/CharToByteCp921.java - src/share/classes/sun/io/CharToByteCp922.java - src/share/classes/sun/io/CharToByteCp930.java - src/share/classes/sun/io/CharToByteCp933.java - src/share/classes/sun/io/CharToByteCp935.java - src/share/classes/sun/io/CharToByteCp937.java - src/share/classes/sun/io/CharToByteCp939.java - src/share/classes/sun/io/CharToByteCp942.java - src/share/classes/sun/io/CharToByteCp942C.java - src/share/classes/sun/io/CharToByteCp943.java - src/share/classes/sun/io/CharToByteCp943C.java - src/share/classes/sun/io/CharToByteCp948.java - src/share/classes/sun/io/CharToByteCp949.java - src/share/classes/sun/io/CharToByteCp949C.java - src/share/classes/sun/io/CharToByteCp950.java - src/share/classes/sun/io/CharToByteCp964.java - src/share/classes/sun/io/CharToByteCp970.java - src/share/classes/sun/io/CharToByteDBCS_ASCII.java - src/share/classes/sun/io/CharToByteDBCS_EBCDIC.java - src/share/classes/sun/io/CharToByteDoubleByte.java - src/share/classes/sun/io/CharToByteEUC.java - src/share/classes/sun/io/CharToByteEUC_CN.java - src/share/classes/sun/io/CharToByteEUC_JP.java - src/share/classes/sun/io/CharToByteEUC_JP_LINUX.java - src/share/classes/sun/io/CharToByteEUC_JP_Solaris.java - src/share/classes/sun/io/CharToByteEUC_KR.java - src/share/classes/sun/io/CharToByteEUC_TW.java - src/share/classes/sun/io/CharToByteGB18030.java - src/share/classes/sun/io/CharToByteGBK.java - src/share/classes/sun/io/CharToByteISCII91.java - src/share/classes/sun/io/CharToByteISO2022.java - src/share/classes/sun/io/CharToByteISO2022CN_CNS.java - src/share/classes/sun/io/CharToByteISO2022CN_GB.java - src/share/classes/sun/io/CharToByteISO2022JP.java - src/share/classes/sun/io/CharToByteISO2022KR.java - src/share/classes/sun/io/CharToByteISO8859_1.java - src/share/classes/sun/io/CharToByteISO8859_13.java - src/share/classes/sun/io/CharToByteISO8859_15.java - src/share/classes/sun/io/CharToByteISO8859_2.java - src/share/classes/sun/io/CharToByteISO8859_3.java - src/share/classes/sun/io/CharToByteISO8859_4.java - src/share/classes/sun/io/CharToByteISO8859_5.java - src/share/classes/sun/io/CharToByteISO8859_6.java - src/share/classes/sun/io/CharToByteISO8859_7.java - src/share/classes/sun/io/CharToByteISO8859_8.java - src/share/classes/sun/io/CharToByteISO8859_9.java - src/share/classes/sun/io/CharToByteJIS0201.java - src/share/classes/sun/io/CharToByteJIS0208.java - src/share/classes/sun/io/CharToByteJIS0208_Solaris.java - src/share/classes/sun/io/CharToByteJIS0212.java - src/share/classes/sun/io/CharToByteJIS0212_Solaris.java - src/share/classes/sun/io/CharToByteJohab.java - src/share/classes/sun/io/CharToByteKOI8_R.java - src/share/classes/sun/io/CharToByteMS874.java - src/share/classes/sun/io/CharToByteMS932.java - src/share/classes/sun/io/CharToByteMS936.java - src/share/classes/sun/io/CharToByteMS949.java - src/share/classes/sun/io/CharToByteMS950.java - src/share/classes/sun/io/CharToByteMS950_HKSCS.java - src/share/classes/sun/io/CharToByteMacArabic.java - src/share/classes/sun/io/CharToByteMacCentralEurope.java - src/share/classes/sun/io/CharToByteMacCroatian.java - src/share/classes/sun/io/CharToByteMacCyrillic.java - src/share/classes/sun/io/CharToByteMacDingbat.java - src/share/classes/sun/io/CharToByteMacGreek.java - src/share/classes/sun/io/CharToByteMacHebrew.java - src/share/classes/sun/io/CharToByteMacIceland.java - src/share/classes/sun/io/CharToByteMacRoman.java - src/share/classes/sun/io/CharToByteMacRomania.java - src/share/classes/sun/io/CharToByteMacSymbol.java - src/share/classes/sun/io/CharToByteMacThai.java - src/share/classes/sun/io/CharToByteMacTurkish.java - src/share/classes/sun/io/CharToByteMacUkraine.java - src/share/classes/sun/io/CharToBytePCK.java - src/share/classes/sun/io/CharToByteSJIS.java - src/share/classes/sun/io/CharToByteSingleByte.java - src/share/classes/sun/io/CharToByteTIS620.java - src/share/classes/sun/io/CharToByteUTF16.java - src/share/classes/sun/io/CharToByteUTF8.java - src/share/classes/sun/io/CharToByteUnicode.java - src/share/classes/sun/io/CharToByteUnicodeBig.java - src/share/classes/sun/io/CharToByteUnicodeBigUnmarked.java - src/share/classes/sun/io/CharToByteUnicodeLittle.java - src/share/classes/sun/io/CharToByteUnicodeLittleUnmarked.java - src/share/classes/sun/io/CharacterEncoding.java - src/share/classes/sun/io/ConversionBufferFullException.java - src/share/classes/sun/io/Converters.java - src/share/classes/sun/io/MalformedInputException.java - src/share/classes/sun/io/UnknownCharacterException.java - src/share/classes/sun/nio/ch/SctpMessageInfoImpl.java - src/share/classes/sun/nio/ch/SctpStdSocketOption.java - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java ! src/share/classes/sun/security/x509/CRLExtensions.java - src/share/classes/sun/security/x509/CertAndKeyGen.java ! src/share/classes/sun/security/x509/CertificateExtensions.java ! src/share/classes/sun/security/x509/X509CRLEntryImpl.java ! src/share/classes/sun/security/x509/X509CRLImpl.java ! src/share/classes/sun/security/x509/X509CertImpl.java - src/share/classes/sun/tools/jar/JarImageSource.java ! src/share/lib/security/java.security-solaris - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c - src/share/native/java/util/zip/zlib-1.2.3/ChangeLog - src/share/native/java/util/zip/zlib-1.2.3/README - src/share/native/java/util/zip/zlib-1.2.3/compress.c - src/share/native/java/util/zip/zlib-1.2.3/crc32.h - src/share/native/java/util/zip/zlib-1.2.3/deflate.c - src/share/native/java/util/zip/zlib-1.2.3/deflate.h - src/share/native/java/util/zip/zlib-1.2.3/gzio.c - src/share/native/java/util/zip/zlib-1.2.3/infback.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.c - src/share/native/java/util/zip/zlib-1.2.3/inffast.h - src/share/native/java/util/zip/zlib-1.2.3/inffixed.h - src/share/native/java/util/zip/zlib-1.2.3/inflate.c - src/share/native/java/util/zip/zlib-1.2.3/inflate.h - src/share/native/java/util/zip/zlib-1.2.3/inftrees.c - src/share/native/java/util/zip/zlib-1.2.3/inftrees.h - src/share/native/java/util/zip/zlib-1.2.3/patches/ChangeLog_java - src/share/native/java/util/zip/zlib-1.2.3/patches/crc32.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/inflate.c.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zconf.h.diff - src/share/native/java/util/zip/zlib-1.2.3/patches/zlib.h.diff - src/share/native/java/util/zip/zlib-1.2.3/trees.c - src/share/native/java/util/zip/zlib-1.2.3/trees.h - src/share/native/java/util/zip/zlib-1.2.3/uncompr.c - src/share/native/java/util/zip/zlib-1.2.3/zadler32.c - src/share/native/java/util/zip/zlib-1.2.3/zconf.h - src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.2.3/zlib.h - src/share/native/java/util/zip/zlib-1.2.3/zutil.c - src/share/native/java/util/zip/zlib-1.2.3/zutil.h - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c - src/share/native/sun/rmi/server/MarshalInputStream.c - src/solaris/classes/sun/awt/motif/AWTLockAccess.java - src/solaris/classes/sun/awt/motif/MFontPeer.java - src/solaris/classes/sun/awt/motif/MToolkit.java - src/solaris/classes/sun/awt/motif/MToolkitThreadBlockedHandler.java - src/solaris/classes/sun/awt/motif/MWindowAttributes.java - src/solaris/classes/sun/awt/motif/X11FontMetrics.java - src/solaris/classes/sun/nio/ch/SctpAssocChange.java - src/solaris/classes/sun/nio/ch/SctpAssociationImpl.java - src/solaris/classes/sun/nio/ch/SctpChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpNet.java - src/solaris/classes/sun/nio/ch/SctpNotification.java - src/solaris/classes/sun/nio/ch/SctpPeerAddrChange.java - src/solaris/classes/sun/nio/ch/SctpResultContainer.java - src/solaris/classes/sun/nio/ch/SctpSendFailed.java - src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java - src/solaris/classes/sun/nio/ch/SctpShutdown.java - src/solaris/doc/sun/man/man1/apt.1 - src/solaris/doc/sun/man/man1/ja/apt.1 - src/solaris/native/sun/awt/MouseInfo.c - src/solaris/native/sun/awt/XDrawingArea.c - src/solaris/native/sun/awt/XDrawingArea.h - src/solaris/native/sun/awt/XDrawingAreaP.h - src/solaris/native/sun/awt/awt_Cursor.h - src/solaris/native/sun/awt/awt_KeyboardFocusManager.h - src/solaris/native/sun/awt/awt_MToolkit.c - src/solaris/native/sun/awt/awt_MToolkit.h - src/solaris/native/sun/awt/awt_MenuItem.h - src/solaris/native/sun/awt/awt_PopupMenu.h - src/solaris/native/sun/awt/awt_TopLevel.h - src/solaris/native/sun/awt/awt_Window.h - src/solaris/native/sun/awt/awt_mgrsel.c - src/solaris/native/sun/awt/awt_mgrsel.h - src/solaris/native/sun/awt/awt_motif.h - src/solaris/native/sun/awt/awt_wm.c - src/solaris/native/sun/awt/awt_wm.h - src/solaris/native/sun/awt/awt_xembed.h - src/solaris/native/sun/awt/awt_xembed_server.c - src/solaris/native/sun/awt/awt_xembed_server.h - src/solaris/native/sun/nio/ch/Sctp.h - src/solaris/native/sun/nio/ch/SctpChannelImpl.c - src/solaris/native/sun/nio/ch/SctpNet.c - src/solaris/native/sun/nio/ch/SctpServerChannelImpl.c - src/windows/classes/sun/nio/ch/SctpChannelImpl.java - src/windows/classes/sun/nio/ch/SctpMultiChannelImpl.java - src/windows/classes/sun/nio/ch/SctpServerChannelImpl.java - test/java/io/File/BlockIsDirectory.java - test/java/io/File/isDirectory/Applet.html - test/java/io/File/isDirectory/Applet.java - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.java - test/java/util/ResourceBundle/Control/ExpirationTest.sh - test/sun/nio/cs/OLD/TestX11CS.java - test/sun/nio/cs/TestISCII91.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java - test/tools/launcher/ChangeDataModel.sh - test/tools/launcher/CreatePlatformFile.java - test/tools/launcher/DefaultLocaleTest.sh - test/tools/launcher/SomeException.java - test/tools/launcher/UnicodeCleanup.java - test/tools/launcher/UnicodeTest.sh - test/tools/launcher/deleteI18n.sh - test/tools/launcher/i18nTest.sh - test/tools/launcher/unresolvedExceptions.sh Changeset: 95998c60ab4b Author: robm Date: 2012-04-11 17:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/95998c60ab4b 7143606: File.createTempFile should be improved for temporary files created by the platform. Reviewed-by: sherman ! src/macosx/classes/apple/applescript/AppleScriptEngine.java ! src/share/classes/com/sun/java/util/jar/pack/Driver.java ! src/share/classes/java/awt/Font.java ! src/share/classes/javax/imageio/stream/FileCacheImageInputStream.java ! src/share/classes/javax/imageio/stream/FileCacheImageOutputStream.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/rmi/server/Activation.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/classes/sun/tools/native2ascii/Main.java ! src/solaris/classes/sun/font/FcFontConfiguration.java ! src/solaris/classes/sun/print/UnixPrintJob.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java Changeset: afe424ee3240 Author: asaha Date: 2012-05-08 07:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/afe424ee3240 Merge ! src/share/lib/security/java.security ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows - test/sun/security/pkcs11/nss/lib/linux-amd64/libfreebl3.chk - test/sun/security/pkcs11/nss/lib/linux-amd64/libfreebl3.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libnspr4.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libnss3.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libnssckbi.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libplc4.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libplds4.so - test/sun/security/pkcs11/nss/lib/linux-amd64/libsoftokn3.chk - test/sun/security/pkcs11/nss/lib/linux-amd64/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/linux-i586/libnspr4.so - test/sun/security/pkcs11/nss/lib/linux-i586/libnss3.so - test/sun/security/pkcs11/nss/lib/linux-i586/libnssckbi.so - test/sun/security/pkcs11/nss/lib/linux-i586/libplc4.so - test/sun/security/pkcs11/nss/lib/linux-i586/libplds4.so - test/sun/security/pkcs11/nss/lib/linux-i586/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libnspr4.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libnss3.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libnssckbi.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libplc4.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libplds4.so - test/sun/security/pkcs11/nss/lib/solaris-amd64/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libfreebl3.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libnspr4.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libnss3.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libnssckbi.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libplc4.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libplds4.so - test/sun/security/pkcs11/nss/lib/solaris-i586/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libfreebl_hybrid_3.chk - test/sun/security/pkcs11/nss/lib/solaris-sparc/libfreebl_hybrid_3.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libnspr4.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libnss3.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libnssckbi.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libplc4.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libplds4.so - test/sun/security/pkcs11/nss/lib/solaris-sparc/libsoftokn3.chk - test/sun/security/pkcs11/nss/lib/solaris-sparc/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libnspr4.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libnss3.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libnssckbi.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libplc4.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libplds4.so - test/sun/security/pkcs11/nss/lib/solaris-sparcv9/libsoftokn3.so - test/sun/security/pkcs11/nss/lib/windows-i586/libnspr4.dll - test/sun/security/pkcs11/nss/lib/windows-i586/libplc4.dll - test/sun/security/pkcs11/nss/lib/windows-i586/libplds4.dll - test/sun/security/pkcs11/nss/lib/windows-i586/nss3.dll - test/sun/security/pkcs11/nss/lib/windows-i586/nssckbi.dll - test/sun/security/pkcs11/nss/lib/windows-i586/softokn3.dll Changeset: 3a2cfce96908 Author: coffeys Date: 2012-05-17 12:21 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3a2cfce96908 7123896: Unexpected behavior due to Solaris using separate IPv4 and IPv6 port spaces Reviewed-by: alanb ! src/share/native/java/net/net_util.c ! src/share/native/java/net/net_util.h ! src/solaris/native/java/net/net_util_md.c ! src/windows/native/java/net/net_util_md.c ! test/java/net/Socket/setReuseAddress/Basic.java ! test/java/net/Socket/setReuseAddress/Restart.java Changeset: cf097cda2733 Author: jrose Date: 2012-05-18 20:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cf097cda2733 7165628: Issues with java.lang.invoke.MethodHandles.Lookup Summary: Base SecurityManager checks on either of Lookup.lookupClass or caller class; also clarify Lookup access checks. Reviewed-by: twisti ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/util/VerifyAccess.java + test/java/lang/invoke/AccessControlTest.java + test/java/lang/invoke/AccessControlTest_subpkg/Acquaintance_remote.java Changeset: 36d899822de7 Author: asaha Date: 2012-05-21 15:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/36d899822de7 Merge - src/macosx/bin/amd64/jvm.cfg ! src/share/classes/sun/print/PSPrinterJob.java - src/share/classes/sun/security/action/LoadLibraryAction.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! src/solaris/native/java/net/net_util_md.c - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 4c403c00fdf1 Author: asaha Date: 2012-05-24 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4c403c00fdf1 7171228: closed/java/lang/SecurityManager/CheckPackageDefinition.java failure Reviewed-by: mullan ! src/share/lib/security/java.security ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 2fbf98031e65 Author: asaha Date: 2012-06-07 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2fbf98031e65 Merge ! src/share/native/java/net/net_util.h ! src/solaris/native/java/net/net_util_md.c Changeset: b92353a01aa0 Author: lana Date: 2012-06-26 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b92353a01aa0 Merge ! src/share/classes/sun/security/x509/X509CRLEntryImpl.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! src/solaris/native/java/net/net_util_md.c From david.katleman at oracle.com Wed Jun 27 23:19:47 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 27 Jun 2012 23:19:47 +0000 Subject: hg: jdk8/build/langtools: 8 new changesets Message-ID: <20120627232006.4163E47B69@hg.openjdk.java.net> Changeset: a39c99192184 Author: katleman Date: 2012-06-21 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/a39c99192184 Added tag jdk8-b44 for changeset 59cbead12ff4 ! .hgtags Changeset: 9cafabb5e576 Author: ksrini Date: 2012-06-11 15:33 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/9cafabb5e576 7160072: (javac) JavacParserTests needs cleanup Reviewed-by: jjg ! test/tools/javac/parser/JavacParserTest.java Changeset: e534aa747b22 Author: lana Date: 2012-06-17 21:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e534aa747b22 Merge Changeset: 34e254ffd0e7 Author: mcimadamore Date: 2012-06-19 13:25 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/34e254ffd0e7 7177701: error: Filling jar message during javax/imageio/metadata/IIOMetadataFormatImpl compilation Summary: Recent JDK hash changes affected order in which files are returned from JavacFileManager.list() Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java Changeset: 5c0b3faeb0b0 Author: jjg Date: 2012-06-20 13:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/5c0b3faeb0b0 7174143: encapsulate doc comment table Reviewed-by: ksrini, mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java - src/share/classes/com/sun/tools/javac/parser/EndPosTable.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + src/share/classes/com/sun/tools/javac/parser/SimpleDocCommentTable.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java + src/share/classes/com/sun/tools/javac/tree/DocCommentTable.java + src/share/classes/com/sun/tools/javac/tree/EndPosTable.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! test/tools/javac/6304921/TestLog.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/tree/DocCommentToplevelTest.java ! test/tools/javac/tree/TreePosTest.java Changeset: 067f51db3402 Author: jjg Date: 2012-06-21 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/067f51db3402 7178297: provide mapping from doc comment position to source file position Reviewed-by: mcimadamore, ksrini ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java Changeset: 3468519d9b45 Author: jjg Date: 2012-06-22 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3468519d9b45 7178763: javadoc OutOfMemory error results in several jdk8 tl nightly failures Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java Changeset: e111e4587cca Author: lana Date: 2012-06-25 21:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e111e4587cca Merge - src/share/classes/com/sun/tools/javac/parser/EndPosTable.java From Sergey.Bylokhov at oracle.com Thu Jun 28 14:03:09 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Thu, 28 Jun 2012 18:03:09 +0400 Subject: Need reviewer - @GenerateNativeHeader In-Reply-To: References: Message-ID: <4FEC641D.6000104@oracle.com> Hi, Kelly. Looks like changes in these files are unnecessary. |Cdiffs Udiffs Sdiffs Frames Old New Patch Raw | *src/macosx/classes/sun/lwawt/LWLabelPeer.java* 4 lines changed: 4 ins; 0 del; 0 mod; 115 unchg |Cdiffs Udiffs Sdiffs Frames Old New Patch Raw | *src/macosx/classes/sun/lwawt/LWTextFieldPeer.java* 4 lines changed: 4 ins; 0 del; 0 mod; 134 unchg 23.05.2012 05:14, Kelly O'Hair wrote: > 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI > http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ > > The new build infrastructure wants to fully automate the generation of the JNI header files (running javah). > On classes that have "native" methods this is obvious, but class that only export constants, and whose constants > are needed in the JNI native code, we need to mark these classes as needing their native header file generated. > > This change is adding: > > import javax.tools.annotation.GenerateNativeHeader; > > /* No native methods here, but the constants are needed in the supporting JNI code */ > @GenerateNativeHeader > > To any class without a native method, but needing to expose it's constants to the native code. > > -kto > -- Best regards, Sergey. -------------- next part -------------- An HTML attachment was scrubbed... URL: From josef.stadelmann at axa-winterthur.ch Thu Jun 28 16:10:50 2012 From: josef.stadelmann at axa-winterthur.ch (Stadelmann Josef) Date: Thu, 28 Jun 2012 18:10:50 +0200 Subject: AW: why can I not download the /jdk repository In-Reply-To: <61F1BE95-84E7-4311-B6F4-609D0EB48DD7@oracle.com> References: <61F1BE95-84E7-4311-B6F4-609D0EB48DD7@oracle.com> Message-ID: Thank you Kelly, Volker I checked tha path and verified that in fact C:\Program Files\TortoiseHG\hg.exe is called. the version I am using is H:\>hg version Mercurial Distributed SCM (version 2.1.2) (see http://mercurial.selenic.com for more information) Copyright (C) 2005-2012 Matt Mackall and others This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Then using TortoiseHG to download the forest one by one reveled the fllowing: I take RMB down on my OpenJDK Directory and select TortoiseHG / Clone I enter the source as http://hg.openjdk.java.net/jdk7/jdk7 I enter the target as E:\OpenJDK\jdk7 The clone takes place perfect Then RMB down on the jdk7 directory which is now a clone and asking at the context menu to launch the workbench. Absolute no problem I can see in the Repository List my default set to e:\openjdk and I can see jdk7 as jdk7 I select jdk7 in the repository list and RMB down and select from the context CLONE then I enter one after the orther. using the README already brought down I download (clone) each remote sub-repository. Simpel and easy I am asking for uncompressed data and for pull protocol for the meta data and I can see in the details window how all the sources and resources come down the line. This works for each sub repository "corba langtools hotspot jaxws jaxp" it does just not work for "jdk" I don't think the problem is on my system but it has to do with the workload of the jdk sub repository. excerpt from the clone process of the Tortoise workbench (latest greatest version). And as you can see the previous command completed successful but the clone for jdk always fails with URLerror or on a cmd line version it fails with error 255. the jaxp comes down as % hg clone --verbose -- http://hg.openjdk.java.net/jdk7/jdk7/jaxp E:\OpenJDK\jdk7\jaxp requesting all changes adding changesets <----- about 40 seconds then it continues to adding manifest; but for jdk you can wait forever here . . . adding manifests adding file changes added 233 changesets with 2213 changes to 1984 files updating to branch default resolving manifests getting .hgignore . . . . . . getting nbproject/project.xml getting nbproject/sqe.properties getting patches/jaxp_src/README 19 files updated, 0 files merged, 0 files removed, 0 files unresolved [command completed successfully Thu Jun 28 17:49:42 2012] ?- for japx % hg clone --verbose -- http://hg.openjdk.java.net/jdk7/jdk7/jdk E:\OpenJDK\jdk7\jdk ?- for jdk requesting all changes URLError: [command returned code 255 Thu Jun 28 18:02:01 2012] Guess the problem is NOT on my side of the pond, or what explains why 1 master and 5 sub-repositories clone perfect and only one "jdk" fails? Josef Von: Kelly O'Hair [mailto:kelly.ohair at oracle.com] Gesendet: Mittwoch, 27. Juni 2012 22:03 An: Volker Simonis Cc: Stadelmann Josef; build-dev at openjdk.java.net Betreff: Re: why can I not download the /jdk repository I found this old documentation when I worked on the JavaFX project, maybe this helps: TortoiseHG (Windows) Get the TortoiseHG Download bundle and install it. It install into the directory: "C:/Program Files/TortoiseHG/". After installing it: 1. Edit the file "C:/Program Files/TortoiseHG/Mercurial.ini" and make sure the ssh command used is from CYGWIN and not Plink. Unless of course you want to use Plink, it's up to you. 2. Prepend "C:/Program Files/TortoiseHG/" to your PATH, make sure it is before /usr/bin, so that running hg version tells you it is TortoiseHG. Mercurial Tips ? On Windows, the default CYGWIN hg will not work on some of the repositories, so you can downgrade the CYGWIN hg version to 1.0.2 or switch to use the TortoiseHG build of Mercurial, which is a 1.3.1 or newer version. The problem centers around the Windows limits to full pathnames. Mercurial .hg/ files can end up with much longer filenames than the file they represent in the working set, or the files you edit. The most recent releases of Mercurial have optimized these path lengths, but versions like 1.1 had made the problem worse, resulting in some of our repositories not cloning. Version 1.0.2 was ok, but 1.3.1 or newer is best. Unfortunately, at this time, 1.3.1 is not available with CYGWIN. ? On Windows, the CYGWIN hg is a Python script and doesn't play well with the native Windows system. Some ant scripts try and run hg and ant will fail when running a Python script. Using TortoiseHG solves this problem because it provides a hg.exe. -kto On Jun 27, 2012, at 10:32 AM, Volker Simonis wrote: Hi, this may be related to Cygwin. The error "C770817 at C036357 /cygdrive/e/OpenJDK/jdk8" indicates that you are using a "Cygwin-Mercurial". I would recommend to install and use a native Windows Mercurial (e.g. http://tortoisehg.bitbucket.org/download/index.html) and try with that one. I never had problems cloning with tortoisehg, also I didn't succeed to push with it (I think because of some ssh/private-key issues). So I use the Cygwin hg for pushing, but that's not very stable for me either... Regards, Volker On Wed, Jun 27, 2012 at 6:59 PM, Stadelmann Josef wrote: Just o inform you before I give up. At the README of jdk7 or jdk8 one can read --------------- This one root repository can be obtained with something like: hg clone http://hg.openjdk.java.net/jdk8/jdk8 openjdk8 To make sure you have all the nested repositories, you can run the get_source.sh script located in the same respository as this file: cd openjdk8 && sh ./get_source.sh --------------- Since weeks, running the get_source.sh, download takes place for all sub-repositories except and always fails for the jdk*/jdk repository. "hg clone http://hg.openjdk.java.net/jdk7/jdk7/ C:/OpenJDK/jdk7/jdk" Watching the network, there is an immediate transfer of the .hg subdirectory but then after about 20 minutes I get an abort error C770817 at C036357 /cygdrive/e/OpenJDK/jdk8 $ hg clone http://hg.openjdk.java.net/jdk8/jdk8/jdk jdk requesting all changes abort: error: WHY? Once in the past 4 weeks, I was able to download it on a Saturday at home. Josef From volker.simonis at gmail.com Thu Jun 28 17:24:00 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 28 Jun 2012 19:24:00 +0200 Subject: why can I not download the /jdk repository In-Reply-To: References: <61F1BE95-84E7-4311-B6F4-609D0EB48DD7@oracle.com> Message-ID: Sorry but your problem description appears quite confusing to me. The error you are getting now seems different from the one in your first post. Could you just open a DOS-shell and type: H:\>hg clone http://hg.openjdk.java.net/jdk7/jdk7/jdk (in the same way you did "H:\>hg version") And make sure you have no Cygwin and/or Python in your path. This took about 8 minutes on my Windows7 with Tortoise Mercurial 2.0.2. Cloning just http://hg.openjdk.java.net/jdk7/jdk7 took me about 2 seconds. You wrote it took you about 40 seconds which seems pretty long for such a small repository. Based on that number, cloning jdk would require 160minutes on your side which seems pretty long and which perhaps leads to strange (timeout?) problems. Regards, Volker On Thu, Jun 28, 2012 at 6:10 PM, Stadelmann Josef wrote: > Thank you Kelly, Volker > > > > I checked tha path and verified that in fact C:\Program > Files\TortoiseHG\hg.exe is called. the version I am using is > > H:\>hg version > > Mercurial Distributed SCM (version 2.1.2) > > (see http://mercurial.selenic.com for more information) > > > > Copyright (C) 2005-2012 Matt Mackall and others > > This is free software; see the source for copying conditions. There is NO > > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > > > Then using TortoiseHG to download the forest one by one reveled the > fllowing: > > > > I take RMB down on my OpenJDK Directory and select TortoiseHG / Clone > > I enter the source as http://hg.openjdk.java.net/jdk7/jdk7 > > I enter the target as? E:\OpenJDK\jdk7 > > > > The clone takes place perfect > > Then RMB down on the jdk7 directory which is now a clone and asking at the > context menu to launch > > the workbench. Absolute no problem I can see in the Repository List my > default set to e:\openjdk > > and I can see jdk7 as jdk7 > > > > I select jdk7 in the repository list and RMB down and select from the > context CLONE then > > I enter one after the orther. using the README already brought down I > download (clone) > > each remote sub-repository. Simpel and easy > > > > I am asking for uncompressed data and for pull protocol for the meta data > and I can see in the details window how all the sources and resources come > down the line. > > > > This works for each sub repository "corba langtools hotspot jaxws jaxp" it > does just not work for "jdk" > > > > I don?t think the problem is on my system but it has to do with the workload > of the jdk sub repository. > > > > excerpt from the clone process of the Tortoise workbench (latest greatest > version). And as you can see > > the previous command completed successful but the clone for jdk always fails > with URLerror or on a > > cmd line version it fails with error 255. > > > > the jaxp comes down as > > > > % hg clone --verbose -- http://hg.openjdk.java.net/jdk7/jdk7/jaxp > E:\OpenJDK\jdk7\jaxp > > requesting all changes > > adding changesets?????? ? <----- about 40 seconds then it continues to > adding manifest; ?but for jdk you can wait forever here . . . > > adding manifests > > adding file changes > > added 233 changesets with 2213 changes to 1984 files > > updating to branch default > > resolving manifests > > getting .hgignore > > . . . > > . . . > > getting nbproject/project.xml > > getting nbproject/sqe.properties > > getting patches/jaxp_src/README > > 19 files updated, 0 files merged, 0 files removed, 0 files unresolved > > [command completed successfully Thu Jun 28 17:49:42 > 2012]????????????????????????? ??????????????????????? ?- for japx > > % hg clone --verbose -- http://hg.openjdk.java.net/jdk7/jdk7/jdk > E:\OpenJDK\jdk7\jdk?????????????? ?- for jdk > > requesting all changes > > URLError: > > [command returned code 255 Thu Jun 28 18:02:01 2012] > > > > > > Guess the problem is NOT on my side of the pond, > > > > or what explains why 1 master and 5 sub-repositories clone perfect and only > one "jdk" fails? > > > > Josef > > > > > > > > > > Von: Kelly O'Hair [mailto:kelly.ohair at oracle.com] > Gesendet: Mittwoch, 27. Juni 2012 22:03 > An: Volker Simonis > Cc: Stadelmann Josef; build-dev at openjdk.java.net > > > Betreff: Re: why can I not download the /jdk repository > > > > I found this old documentation when I worked on the JavaFX project, maybe > this helps: > > > > TortoiseHG (Windows) > > Get the TortoiseHG Download bundle and install it. It install into the > directory: > > "C:/Program Files/TortoiseHG/". > > After installing it: > > 1.????? Edit the file "C:/Program Files/TortoiseHG/Mercurial.ini" and make > sure the ssh command used is from CYGWIN and not Plink. Unless of course you > want to use Plink, it's up to you. > > 2.????? Prepend "C:/Program Files/TortoiseHG/" to your PATH, make sure it is > before /usr/bin, so that running hg version tells you it is TortoiseHG. > > Mercurial Tips > > ????????? On Windows, the default CYGWIN hg will not work on some of the > repositories, so you can downgrade the CYGWIN hg version to 1.0.2 or switch > to use the TortoiseHG build of Mercurial, which is a 1.3.1 or newer version. > The problem centers around the Windows limits to full pathnames. Mercurial > .hg/ files can end up with much longer filenames than the file they > represent in the working set, or the files you edit. The most recent > releases of Mercurial have optimized these path lengths, but versions like > 1.1 had made the problem worse, resulting in some of our repositories not > cloning. Version 1.0.2 was ok, but 1.3.1 or newer is best. Unfortunately, at > this time, 1.3.1 is not available with CYGWIN. > > ????????? On Windows, the CYGWIN hg is a Python script and doesn't play well > with the native Windows system. Some ant scripts try and run hg and ant will > fail when running a Python script. Using TortoiseHG solves this problem > because it provides a hg.exe. > > -kto > > > > On Jun 27, 2012, at 10:32 AM, Volker Simonis wrote: > > > > Hi, > > this may be related to Cygwin. The error "C770817 at C036357 > /cygdrive/e/OpenJDK/jdk8" indicates that you are using a > "Cygwin-Mercurial". I would recommend to install and use a native > Windows Mercurial (e.g. > http://tortoisehg.bitbucket.org/download/index.html) and try with that > one. > > I never had problems cloning with tortoisehg, also I didn't succeed to > push with it (I think because of some ssh/private-key issues). So I > use the Cygwin hg for pushing, but that's not very stable for me > either... > > Regards, > Volker > > On Wed, Jun 27, 2012 at 6:59 PM, Stadelmann Josef > wrote: > > Just o inform you before I give up. > > > > At the README of jdk7 or jdk8 one can read > > > > --------------- > > > > This one root repository can be obtained with something like: > > > > ??? hg clone http://hg.openjdk.java.net/jdk8/jdk8 openjdk8 > > > > > > > > ? To make sure you have all the nested repositories, you can run the > > > > ? get_source.sh script located in the same respository as this file: > > > > ??? cd openjdk8 && sh ./get_source.sh > > > > --------------- > > > > Since weeks, running the get_source.sh, download takes place for all > > > > sub-repositories except and always fails for the jdk*/jdk repository. > > > > "hg clone http://hg.openjdk.java.net/jdk7/jdk7/ C:/OpenJDK/jdk7/jdk" > > > > Watching the network, there is an immediate transfer of the .hg subdirectory > > > > but then after about 20 minutes I get an abort error > > > > C770817 at C036357 /cygdrive/e/OpenJDK/jdk8 > > > > $ hg clone http://hg.openjdk.java.net/jdk8/jdk8/jdk jdk > > > > requesting all changes > > > > abort: error: > > > > WHY? > > > > Once in the past 4 weeks, I was able to download it on a Saturday at home. > > > > Josef > > From kelly.ohair at oracle.com Thu Jun 28 21:38:58 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 28 Jun 2012 14:38:58 -0700 Subject: Need reviewer - @GenerateNativeHeader In-Reply-To: <4FEC641D.6000104@oracle.com> References: <4FEC641D.6000104@oracle.com> Message-ID: Why do you say they are unnecessary? -kto On Jun 28, 2012, at 7:03 AM, Sergey Bylokhov wrote: > Hi, Kelly. > Looks like changes in these files are unnecessary. > Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/macosx/classes/sun/lwawt/LWLabelPeer.java > > 4 lines changed: 4 ins; 0 del; 0 mod; 115 unchg > Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/macosx/classes/sun/lwawt/LWTextFieldPeer.java > > 4 lines changed: 4 ins; 0 del; 0 mod; 134 unchg > > 23.05.2012 05:14, Kelly O'Hair wrote: >> 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI >> http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ >> >> The new build infrastructure wants to fully automate the generation of the JNI header files (running javah). >> On classes that have "native" methods this is obvious, but class that only export constants, and whose constants >> are needed in the JNI native code, we need to mark these classes as needing their native header file generated. >> >> This change is adding: >> >> import javax.tools.annotation.GenerateNativeHeader; >> >> /* No native methods here, but the constants are needed in the supporting JNI code */ >> @GenerateNativeHeader >> >> To any class without a native method, but needing to expose it's constants to the native code. >> >> -kto >> > > > -- > Best regards, Sergey. From kelly.ohair at oracle.com Thu Jun 28 21:45:32 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 28 Jun 2012 14:45:32 -0700 Subject: why can I not download the /jdk repository In-Reply-To: References: <61F1BE95-84E7-4311-B6F4-609D0EB48DD7@oracle.com> Message-ID: I'm running hg 2.2 on a Mac, did: time hg clone --verbose -- http://hg.openjdk.java.net/jdk7/jdk7/jdk and it took 2 minutes. Have you got anti virus software running? -kto On Jun 28, 2012, at 10:24 AM, Volker Simonis wrote: > Sorry but your problem description appears quite confusing to me. > The error you are getting now seems different from the one in your first post. > > Could you just open a DOS-shell and type: > > H:\>hg clone http://hg.openjdk.java.net/jdk7/jdk7/jdk > > (in the same way you did "H:\>hg version") > And make sure you have no Cygwin and/or Python in your path. > > This took about 8 minutes on my Windows7 with Tortoise Mercurial 2.0.2. > > Cloning just http://hg.openjdk.java.net/jdk7/jdk7 took me about 2 seconds. > You wrote it took you about 40 seconds which seems pretty long for > such a small repository. > Based on that number, cloning jdk would require 160minutes on your > side which seems pretty long and which perhaps leads to strange > (timeout?) problems. > > Regards, > Volker > > On Thu, Jun 28, 2012 at 6:10 PM, Stadelmann Josef > wrote: >> Thank you Kelly, Volker >> >> >> >> I checked tha path and verified that in fact C:\Program >> Files\TortoiseHG\hg.exe is called. the version I am using is >> >> H:\>hg version >> >> Mercurial Distributed SCM (version 2.1.2) >> >> (see http://mercurial.selenic.com for more information) >> >> >> >> Copyright (C) 2005-2012 Matt Mackall and others >> >> This is free software; see the source for copying conditions. There is NO >> >> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. >> >> >> >> Then using TortoiseHG to download the forest one by one reveled the >> fllowing: >> >> >> >> I take RMB down on my OpenJDK Directory and select TortoiseHG / Clone >> >> I enter the source as http://hg.openjdk.java.net/jdk7/jdk7 >> >> I enter the target as E:\OpenJDK\jdk7 >> >> >> >> The clone takes place perfect >> >> Then RMB down on the jdk7 directory which is now a clone and asking at the >> context menu to launch >> >> the workbench. Absolute no problem I can see in the Repository List my >> default set to e:\openjdk >> >> and I can see jdk7 as jdk7 >> >> >> >> I select jdk7 in the repository list and RMB down and select from the >> context CLONE then >> >> I enter one after the orther. using the README already brought down I >> download (clone) >> >> each remote sub-repository. Simpel and easy >> >> >> >> I am asking for uncompressed data and for pull protocol for the meta data >> and I can see in the details window how all the sources and resources come >> down the line. >> >> >> >> This works for each sub repository "corba langtools hotspot jaxws jaxp" it >> does just not work for "jdk" >> >> >> >> I don?t think the problem is on my system but it has to do with the workload >> of the jdk sub repository. >> >> >> >> excerpt from the clone process of the Tortoise workbench (latest greatest >> version). And as you can see >> >> the previous command completed successful but the clone for jdk always fails >> with URLerror or on a >> >> cmd line version it fails with error 255. >> >> >> >> the jaxp comes down as >> >> >> >> % hg clone --verbose -- http://hg.openjdk.java.net/jdk7/jdk7/jaxp >> E:\OpenJDK\jdk7\jaxp >> >> requesting all changes >> >> adding changesets <----- about 40 seconds then it continues to >> adding manifest; but for jdk you can wait forever here . . . >> >> adding manifests >> >> adding file changes >> >> added 233 changesets with 2213 changes to 1984 files >> >> updating to branch default >> >> resolving manifests >> >> getting .hgignore >> >> . . . >> >> . . . >> >> getting nbproject/project.xml >> >> getting nbproject/sqe.properties >> >> getting patches/jaxp_src/README >> >> 19 files updated, 0 files merged, 0 files removed, 0 files unresolved >> >> [command completed successfully Thu Jun 28 17:49:42 >> 2012] ?- for japx >> >> % hg clone --verbose -- http://hg.openjdk.java.net/jdk7/jdk7/jdk >> E:\OpenJDK\jdk7\jdk ?- for jdk >> >> requesting all changes >> >> URLError: >> >> [command returned code 255 Thu Jun 28 18:02:01 2012] >> >> >> >> >> >> Guess the problem is NOT on my side of the pond, >> >> >> >> or what explains why 1 master and 5 sub-repositories clone perfect and only >> one "jdk" fails? >> >> >> >> Josef >> >> >> >> >> >> >> >> >> >> Von: Kelly O'Hair [mailto:kelly.ohair at oracle.com] >> Gesendet: Mittwoch, 27. Juni 2012 22:03 >> An: Volker Simonis >> Cc: Stadelmann Josef; build-dev at openjdk.java.net >> >> >> Betreff: Re: why can I not download the /jdk repository >> >> >> >> I found this old documentation when I worked on the JavaFX project, maybe >> this helps: >> >> >> >> TortoiseHG (Windows) >> >> Get the TortoiseHG Download bundle and install it. It install into the >> directory: >> >> "C:/Program Files/TortoiseHG/". >> >> After installing it: >> >> 1. Edit the file "C:/Program Files/TortoiseHG/Mercurial.ini" and make >> sure the ssh command used is from CYGWIN and not Plink. Unless of course you >> want to use Plink, it's up to you. >> >> 2. Prepend "C:/Program Files/TortoiseHG/" to your PATH, make sure it is >> before /usr/bin, so that running hg version tells you it is TortoiseHG. >> >> Mercurial Tips >> >> ? On Windows, the default CYGWIN hg will not work on some of the >> repositories, so you can downgrade the CYGWIN hg version to 1.0.2 or switch >> to use the TortoiseHG build of Mercurial, which is a 1.3.1 or newer version. >> The problem centers around the Windows limits to full pathnames. Mercurial >> .hg/ files can end up with much longer filenames than the file they >> represent in the working set, or the files you edit. The most recent >> releases of Mercurial have optimized these path lengths, but versions like >> 1.1 had made the problem worse, resulting in some of our repositories not >> cloning. Version 1.0.2 was ok, but 1.3.1 or newer is best. Unfortunately, at >> this time, 1.3.1 is not available with CYGWIN. >> >> ? On Windows, the CYGWIN hg is a Python script and doesn't play well >> with the native Windows system. Some ant scripts try and run hg and ant will >> fail when running a Python script. Using TortoiseHG solves this problem >> because it provides a hg.exe. >> >> -kto >> >> >> >> On Jun 27, 2012, at 10:32 AM, Volker Simonis wrote: >> >> >> >> Hi, >> >> this may be related to Cygwin. The error "C770817 at C036357 >> /cygdrive/e/OpenJDK/jdk8" indicates that you are using a >> "Cygwin-Mercurial". I would recommend to install and use a native >> Windows Mercurial (e.g. >> http://tortoisehg.bitbucket.org/download/index.html) and try with that >> one. >> >> I never had problems cloning with tortoisehg, also I didn't succeed to >> push with it (I think because of some ssh/private-key issues). So I >> use the Cygwin hg for pushing, but that's not very stable for me >> either... >> >> Regards, >> Volker >> >> On Wed, Jun 27, 2012 at 6:59 PM, Stadelmann Josef >> wrote: >> >> Just o inform you before I give up. >> >> >> >> At the README of jdk7 or jdk8 one can read >> >> >> >> --------------- >> >> >> >> This one root repository can be obtained with something like: >> >> >> >> hg clone http://hg.openjdk.java.net/jdk8/jdk8 openjdk8 >> >> >> >> >> >> >> >> To make sure you have all the nested repositories, you can run the >> >> >> >> get_source.sh script located in the same respository as this file: >> >> >> >> cd openjdk8 && sh ./get_source.sh >> >> >> >> --------------- >> >> >> >> Since weeks, running the get_source.sh, download takes place for all >> >> >> >> sub-repositories except and always fails for the jdk*/jdk repository. >> >> >> >> "hg clone http://hg.openjdk.java.net/jdk7/jdk7/ C:/OpenJDK/jdk7/jdk" >> >> >> >> Watching the network, there is an immediate transfer of the .hg subdirectory >> >> >> >> but then after about 20 minutes I get an abort error >> >> >> >> C770817 at C036357 /cygdrive/e/OpenJDK/jdk8 >> >> >> >> $ hg clone http://hg.openjdk.java.net/jdk8/jdk8/jdk jdk >> >> >> >> requesting all changes >> >> >> >> abort: error: >> >> >> >> WHY? >> >> >> >> Once in the past 4 weeks, I was able to download it on a Saturday at home. >> >> >> >> Josef >> >> From Sergey.Bylokhov at oracle.com Thu Jun 28 21:53:32 2012 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 29 Jun 2012 01:53:32 +0400 Subject: Need reviewer - @GenerateNativeHeader In-Reply-To: References: <4FEC641D.6000104@oracle.com> Message-ID: <4FECD25C.9040607@oracle.com> Hi, Kelly. Because there is no constants that "are needed in the supporting JNI code". For example in *LWLabelPeer.java:* private static final int TEXT_XPAD = 5; private static final int TEXT_YPAD = 1; These constants are really used in a nativ? code? 29.06.2012 01:38, Kelly O'Hair wrote: > Why do you say they are unnecessary? > > -kto > > On Jun 28, 2012, at 7:03 AM, Sergey Bylokhov wrote: > >> Hi, Kelly. >> Looks like changes in these files are unnecessary. >> >> |Cdiffs >> >> Udiffs >> >> Sdiffs >> >> Frames >> >> Old >> >> New >> >> Patch >> >> Raw >> >> | *src/macosx/classes/sun/lwawt/LWLabelPeer.java* >> >> 4 lines changed: 4 ins; 0 del; 0 mod; 115 unchg >> >> |Cdiffs >> >> Udiffs >> >> Sdiffs >> >> Frames >> >> Old >> >> New >> >> Patch >> >> Raw >> >> | *src/macosx/classes/sun/lwawt/LWTextFieldPeer.java* >> >> 4 lines changed: 4 ins; 0 del; 0 mod; 134 unchg >> >> >> 23.05.2012 05:14, Kelly O'Hair wrote: >>> 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI >>> http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ >>> >>> The new build infrastructure wants to fully automate the generation of the JNI header files (running javah). >>> On classes that have "native" methods this is obvious, but class that only export constants, and whose constants >>> are needed in the JNI native code, we need to mark these classes as needing their native header file generated. >>> >>> This change is adding: >>> >>> import javax.tools.annotation.GenerateNativeHeader; >>> >>> /* No native methods here, but the constants are needed in the supporting JNI code */ >>> @GenerateNativeHeader >>> >>> To any class without a native method, but needing to expose it's constants to the native code. >>> >>> -kto >>> >> >> >> -- >> Best regards, Sergey. > -- Best regards, Sergey. From kelly.ohair at oracle.com Thu Jun 28 21:59:27 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Thu, 28 Jun 2012 21:59:27 +0000 Subject: hg: jdk8/build/langtools: 7180594: Fix GenStubs in langtools for build-infra builds Message-ID: <20120628215933.2FFCD47BAE@hg.openjdk.java.net> Changeset: 01d9911df25d Author: erikj Date: 2012-06-28 14:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/01d9911df25d 7180594: Fix GenStubs in langtools for build-infra builds Reviewed-by: ohair ! make/tools/genstubs/GenStubs.java From erik.joelsson at oracle.com Thu Jun 28 22:35:14 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 28 Jun 2012 15:35:14 -0700 Subject: Need reviewer - @GenerateNativeHeader In-Reply-To: <4FECD25C.9040607@oracle.com> References: <4FEC641D.6000104@oracle.com> <4FECD25C.9040607@oracle.com> Message-ID: <4FECDC22.6000801@oracle.com> Hello, It's quite possible that the constants aren't needed. However, those files are currently on the list of files in the old build system that gets headers generated for them, and those headers are in turn included by native source files. The new annotation for automatically generating native headers is used by the new build (build-infra). We added the annotation to all java files that used to have headers generated for them. It would be even better to check each of those java files and verify that the headers are actually needed in the native code, and remove the includes for those that aren't. We felt that was beyond the scope of the build-infra project. /Erik On 2012-06-28 14:53, Sergey Bylokhov wrote: > Hi, Kelly. > Because there is no constants that "are needed in the supporting JNI > code". > For example in *LWLabelPeer.java:* > private static final int TEXT_XPAD = 5; > private static final int TEXT_YPAD = 1; > These constants are really used in a nativ? code? > > > 29.06.2012 01:38, Kelly O'Hair wrote: >> Why do you say they are unnecessary? >> >> -kto >> >> On Jun 28, 2012, at 7:03 AM, Sergey Bylokhov wrote: >> >>> Hi, Kelly. >>> Looks like changes in these files are unnecessary. >>> >>> |Cdiffs >>> >>> Udiffs >>> >>> Sdiffs >>> >>> Frames >>> >>> Old >>> >>> New >>> >>> Patch >>> >>> Raw >>> >>> | *src/macosx/classes/sun/lwawt/LWLabelPeer.java* >>> >>> 4 lines changed: 4 ins; 0 del; 0 mod; 115 unchg >>> |Cdiffs >>> >>> Udiffs >>> >>> Sdiffs >>> >>> Frames >>> >>> Old >>> >>> New >>> >>> Patch >>> >>> Raw >>> >>> | *src/macosx/classes/sun/lwawt/LWTextFieldPeer.java* >>> >>> 4 lines changed: 4 ins; 0 del; 0 mod; 134 unchg >>> >>> 23.05.2012 05:14, Kelly O'Hair wrote: >>>> 7170969: Add @GenerateNativeHeader to classes whose fields need to >>>> be exported for JNI >>>> http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ >>>> >>>> The new build infrastructure wants to fully automate the generation >>>> of the JNI header files (running javah). >>>> On classes that have "native" methods this is obvious, but class >>>> that only export constants, and whose constants >>>> are needed in the JNI native code, we need to mark these classes as >>>> needing their native header file generated. >>>> >>>> This change is adding: >>>> >>>> import javax.tools.annotation.GenerateNativeHeader; >>>> /* No native methods here, but the constants are needed in the >>>> supporting JNI code */ >>>> @GenerateNativeHeader >>>> >>>> To any class without a native method, but needing to expose it's >>>> constants to the native code. >>>> >>>> -kto >>>> >>> >>> >>> -- >>> Best regards, Sergey. >> > > From kelly.ohair at oracle.com Thu Jun 28 23:59:29 2012 From: kelly.ohair at oracle.com (Kelly Ohair) Date: Thu, 28 Jun 2012 16:59:29 -0700 Subject: Need reviewer - @GenerateNativeHeader In-Reply-To: <4FECDC22.6000801@oracle.com> References: <4FEC641D.6000104@oracle.com> <4FECD25C.9040607@oracle.com> <4FECDC22.6000801@oracle.com> Message-ID: so bottom line ... if you can determine that the GenerateNativeHeader is not needed you can delete it but please be sure Sent from my iPhone On Jun 28, 2012, at 15:35, Erik Joelsson wrote: > Hello, > > It's quite possible that the constants aren't needed. However, those files are currently on the list of files in the old build system that gets headers generated for them, and those headers are in turn included by native source files. The new annotation for automatically generating native headers is used by the new build (build-infra). We added the annotation to all java files that used to have headers generated for them. > > It would be even better to check each of those java files and verify that the headers are actually needed in the native code, and remove the includes for those that aren't. We felt that was beyond the scope of the build-infra project. > > /Erik > > On 2012-06-28 14:53, Sergey Bylokhov wrote: >> Hi, Kelly. >> Because there is no constants that "are needed in the supporting JNI code". >> For example in *LWLabelPeer.java:* >> private static final int TEXT_XPAD = 5; >> private static final int TEXT_YPAD = 1; >> These constants are really used in a nativ? code? >> >> >> 29.06.2012 01:38, Kelly O'Hair wrote: >>> Why do you say they are unnecessary? >>> >>> -kto >>> >>> On Jun 28, 2012, at 7:03 AM, Sergey Bylokhov wrote: >>> >>>> Hi, Kelly. >>>> Looks like changes in these files are unnecessary. >>>> >>>> |Cdiffs Udiffs Sdiffs Frames Old New Patch Raw | *src/macosx/classes/sun/lwawt/LWLabelPeer.java* >>>> >>>> 4 lines changed: 4 ins; 0 del; 0 mod; 115 unchg >>>> |Cdiffs Udiffs Sdiffs Frames Old New Patch Raw | *src/macosx/classes/sun/lwawt/LWTextFieldPeer.java* >>>> >>>> 4 lines changed: 4 ins; 0 del; 0 mod; 134 unchg >>>> >>>> 23.05.2012 05:14, Kelly O'Hair wrote: >>>>> 7170969: Add @GenerateNativeHeader to classes whose fields need to be exported for JNI >>>>> http://cr.openjdk.java.net/~ohair/openjdk8/generateHeaders1/webrev/ >>>>> >>>>> The new build infrastructure wants to fully automate the generation of the JNI header files (running javah). >>>>> On classes that have "native" methods this is obvious, but class that only export constants, and whose constants >>>>> are needed in the JNI native code, we need to mark these classes as needing their native header file generated. >>>>> >>>>> This change is adding: >>>>> >>>>> import javax.tools.annotation.GenerateNativeHeader; >>>>> /* No native methods here, but the constants are needed in the supporting JNI code */ >>>>> @GenerateNativeHeader >>>>> >>>>> To any class without a native method, but needing to expose it's constants to the native code. >>>>> >>>>> -kto >>>>> >>>> >>>> >>>> -- >>>> Best regards, Sergey. >>> >> >> > From volker.simonis at gmail.com Fri Jun 29 12:41:20 2012 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 29 Jun 2012 14:41:20 +0200 Subject: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS In-Reply-To: <4FEB38B7.2080908@oracle.com> References: <4FD97733.7040409@oracle.com> <4FEB38B7.2080908@oracle.com> Message-ID: Hi Tim, I'm still glad that you're pushing this forward:) Just wanted to let you know two more things we found out about the MinGW build in the hope they may be useful for others as well: - you can considerably speed up the build (especially an incremental build which only rebuilds a few files) if you disable implicit make rules (i.e. use make's '-r' option). You can set "MAKE=make -r" to also use this option for recursive make invocations but perhaps it would be better to just define "MAKEFLAGS += -r" in the top-level makefiles. Without this option, make tries to look up a lot of non-existing RCS and SCCS files which especially hurts on Windows (see http://www.electric-cloud.com/blog/2009/08/19/makefile-performance-built-in-rules/ for a more detailed description). - internally we use a sh-script (build.sh) which sets some environment variables and then calls make to start the build. Under MKS it was possible to simply call such a sh-script from an arbitrary DOS-shell because MKS registered '.sh' as a known extension and just did the right thing. Under MinGW/MSYS we had to explicitly call 'bash.exe -i build.sh '. However this unfortunately didn't work reliable. Instead the top-level DOS-shell crashed (with the error "Command Windows Host has stopped working") during the build which results in thousands of DOS-boxes popping up for every executed system command. This problem can be solved by just piping the desired command to the shell like so: "build.sh | bash.exe -i" Regards, Volker On Wed, Jun 27, 2012 at 6:45 PM, Tim Bell wrote: > I went over the open changes again and removed some debug code left in > by mistake, updated copyright dates and fixed a few typos. ?Here is an > updated webrev: > > ? ?http://cr.openjdk.java.net/~tbell/7152336/webrev.01/ > > These changes are building in both 32 and 64 bit mode on my Windows 7 > system. > > jtreg test runs of the '-automatic -noshell' tests under test/java/lang > test/java/math test/java/util ran as expected (2 failures, both known bugs). > > Thanks in advance for your review and feedback - I'd like to get these > changes in soon. > > Tim Bell > > > On 06/13/12 22:31, Tim Bell wrote: >> >> Hello everyone- >> >> Kelly asked me to pick up on bug #/7152336 "//Enable builds on Windows >> with MinGW/MSYS"/, and this email thread: >> >> >> http://mail.openjdk.java.net/pipermail/build-dev/2012-April/thread.html#6083 >> >> As David pointed out, we will need at least one other bug # for the >> hotspot changes. ?That said, this is enough to get me started. >> >> Hi Volker: >> >> I have applied the patches originally from your posting. ?Many thanks for >> that: >> http://cr.openjdk.java.net/~simonis/MinGW_MSYS.v1/ >> >> With a few modifications (keep cpio for non MinGW/Msys builds, keep MKS as >> an option), the proposed changes are visible here for review: >> >> ?http://cr.openjdk.java.net/~tbell/7152336/webrev.00/ >> >> For reference, my test build log is visible here: >> >> >> http://cr.openjdk.java.net/~tbell/7152336/webrev.00/full_control_build_no_docs.log >> >> Additional test builds on JPRT (our internal build apparatus) verified >> that I didn't regress the existing build. >> >> Abbreviated jtreg [1] testing on this build was successful: >> >> $ /d/tools/jdk8/7152336/windows-i586/bin/java -jar >> /d/tools/jtreg-internal/jtreg/lib/jtreg.jar -automatic -noshell >> test/java/lang test/java/math test/java/util >> Directory "JTreport" not found: creating >> Directory "JTwork" not found: creating >> Directory "JTwork\scratch" not found: creating >> Test results: passed: 698; failed: 1; error: 5 >> Report written to D:\tools\jdk8\7152336\jdk\JTreport\html\report.html >> Results written to D:\tools\jdk8\7152336\jdk\JTwork >> Error: Some tests failed or other problems occurred. >> >> The failing test (java/lang/Math/WorstCaseTests.java) is due to a known >> regression: 7174532 >> >> "jdk/test/java/lang/Math/WorstCaseTests.java failing on x86" >> >> The 5 error tests are all ignored until bug xxxxxxx (for some value of x) >> is resolved. >> >> Thanks in advance for your review and feedback - >> >> Tim Bell >> >> [1] ?http://openjdk.java.net/projects/code-tools/ >> > From kelly.ohair at oracle.com Fri Jun 29 16:35:31 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 29 Jun 2012 09:35:31 -0700 Subject: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS In-Reply-To: <4FEB38B7.2080908@oracle.com> References: <4FD97733.7040409@oracle.com> <4FEB38B7.2080908@oracle.com> Message-ID: <36A82AD6-4CD0-4D5E-9AE9-48AC6EE08598@oracle.com> Looks great to me. It's fantastic to see this happening. Just a few minor things: 1. For 116 DOSPATH_CMD:=$(shell cd $(JDK_TOPDIR) 2> $(DEV_NULL) && pwd)/make/tools/mingw_build_scripts/dospath.sh since dospath.sh cannot have execute permission in the repository, does this still work? 2. In Defs-utils: 178 ifdef USING_MINGW 179 ECHO = $(UTILS_COMMAND_PATH)echo -e 180 AR = $(UTILS_DEVTOOL_PATH)ar 181 ZIPEXE = $(UTILS_DEVTOOL_PATH)zip 182 UNZIP = $(UTILS_DEVTOOL_PATH)unzip 183 NAWK = $(UNIXCOMMAND_PATH)awk 184 else 185 ZIPEXE = $(UTILS_DEVTOOL_PATH)zip 186 UNZIP = $(UTILS_DEVTOOL_PATH)unzip 187 NAWK = $(UNIXCOMMAND_PATH)awk 188 endif seems like that can be simplified: ZIPEXE = $(UTILS_DEVTOOL_PATH)zip UNZIP = $(UTILS_DEVTOOL_PATH)unzip NAWK = $(UNIXCOMMAND_PATH)awk ifdef USING_MINGW ECHO = $(UTILS_COMMAND_PATH)echo -e AR = $(UTILS_DEVTOOL_PATH)ar fi ?? 3. I hate to see the for loop duplicated in Sanity.gmk, but this logic isn't long for this world, so I'd leave it. 4. The fixpath.pl and other make/scripts files might be missing a trailing newline, not sure. But overall, I see no reason to block this work from being integrated. As long as the current RE MKS builds are ok. -kto On Jun 27, 2012, at 9:45 AM, Tim Bell wrote: > I went over the open changes again and removed some debug code left in > by mistake, updated copyright dates and fixed a few typos. Here is an > updated webrev: > > http://cr.openjdk.java.net/~tbell/7152336/webrev.01/ > > These changes are building in both 32 and 64 bit mode on my Windows 7 system. > > jtreg test runs of the '-automatic -noshell' tests under test/java/lang test/java/math test/java/util ran as expected (2 failures, both known bugs). > > Thanks in advance for your review and feedback - I'd like to get these changes in soon. > > Tim Bell > > > On 06/13/12 22:31, Tim Bell wrote: >> Hello everyone- >> >> Kelly asked me to pick up on bug #/7152336 "//Enable builds on Windows with MinGW/MSYS"/, and this email thread: >> >> http://mail.openjdk.java.net/pipermail/build-dev/2012-April/thread.html#6083 >> >> As David pointed out, we will need at least one other bug # for the hotspot changes. That said, this is enough to get me started. >> >> Hi Volker: >> >> I have applied the patches originally from your posting. Many thanks for that: >> http://cr.openjdk.java.net/~simonis/MinGW_MSYS.v1/ >> >> With a few modifications (keep cpio for non MinGW/Msys builds, keep MKS as an option), the proposed changes are visible here for review: >> >> http://cr.openjdk.java.net/~tbell/7152336/webrev.00/ >> >> For reference, my test build log is visible here: >> >> http://cr.openjdk.java.net/~tbell/7152336/webrev.00/full_control_build_no_docs.log >> >> Additional test builds on JPRT (our internal build apparatus) verified that I didn't regress the existing build. >> >> Abbreviated jtreg [1] testing on this build was successful: >> >> $ /d/tools/jdk8/7152336/windows-i586/bin/java -jar /d/tools/jtreg-internal/jtreg/lib/jtreg.jar -automatic -noshell test/java/lang test/java/math test/java/util >> Directory "JTreport" not found: creating >> Directory "JTwork" not found: creating >> Directory "JTwork\scratch" not found: creating >> Test results: passed: 698; failed: 1; error: 5 >> Report written to D:\tools\jdk8\7152336\jdk\JTreport\html\report.html >> Results written to D:\tools\jdk8\7152336\jdk\JTwork >> Error: Some tests failed or other problems occurred. >> >> The failing test (java/lang/Math/WorstCaseTests.java) is due to a known regression: 7174532 "jdk/test/java/lang/Math/WorstCaseTests.java failing on x86" >> >> The 5 error tests are all ignored until bug xxxxxxx (for some value of x) is resolved. >> >> Thanks in advance for your review and feedback - >> >> Tim Bell >> >> [1] http://openjdk.java.net/projects/code-tools/ >> >