From david.katleman at oracle.com Thu Oct 4 00:28:08 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 04 Oct 2012 00:28:08 +0000 Subject: hg: jdk8/build: Added tag jdk8-b58 for changeset 936702480487 Message-ID: <20121004002808.9A6404718B@hg.openjdk.java.net> Changeset: dae9821589cc Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/dae9821589cc Added tag jdk8-b58 for changeset 936702480487 ! .hgtags From david.katleman at oracle.com Thu Oct 4 00:28:12 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 04 Oct 2012 00:28:12 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b58 for changeset 18462a19f7bd Message-ID: <20121004002813.BD11E4718C@hg.openjdk.java.net> Changeset: d54dc53e223e Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/d54dc53e223e Added tag jdk8-b58 for changeset 18462a19f7bd ! .hgtags From david.katleman at oracle.com Thu Oct 4 00:29:16 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 04 Oct 2012 00:29:16 +0000 Subject: hg: jdk8/build/hotspot: 48 new changesets Message-ID: <20121004003056.38EF24718D@hg.openjdk.java.net> Changeset: 04ed664b7e30 Author: amurillo Date: 2012-09-21 14:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/04ed664b7e30 7200236: new hotspot build - hs25-b03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: fac3dd92ebaf Author: bpittore Date: 2012-09-19 17:22 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fac3dd92ebaf 7195372: Wrong copyright in new files Summary: Fixed copyrights Reviewed-by: dholmes Contributed-by: Bill Pittore ! agent/make/saenv.sh ! agent/make/start-debug-server-proc.sh ! agent/src/share/classes/sun/jvm/hotspot/debugger/ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/amd64/AMD64ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/ia64/IA64ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/sparc/SPARCThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/x86/X86ThreadContext.java ! make/linux/makefiles/sa.make Changeset: ef7fe63a2d39 Author: vladidan Date: 2012-09-24 19:00 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ef7fe63a2d39 Merge Changeset: 15ba0e7a3ff4 Author: sla Date: 2012-09-17 11:46 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/15ba0e7a3ff4 7193201: [OS X] The development launcher should be signed and given task_for_pid privileges Reviewed-by: sspitsyn, nloodin, mgronlun, coleenp ! make/bsd/makefiles/launcher.make + src/os/bsd/launcher/Info-privileged.plist Changeset: a7509aff1b06 Author: dholmes Date: 2012-09-17 07:36 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a7509aff1b06 7194254: jstack reports wrong thread priorities Reviewed-by: dholmes, sla, fparain Contributed-by: Dmytro Sheyko ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp + test/runtime/7194254/Test7194254.java Changeset: 7b41bee02500 Author: dholmes Date: 2012-09-17 08:44 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7b41bee02500 Merge Changeset: 716e6ef4482a Author: zgu Date: 2012-09-17 10:20 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/716e6ef4482a 7190089: NMT ON: NMT failed assertion on thread's stack base address Summary: Solaris only, record stack info to NMT after stack size adjustment was made for primordial threads Reviewed-by: kvn, acorn, coleenp ! src/os/solaris/vm/os_solaris.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: c088e2e95e69 Author: zgu Date: 2012-09-17 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c088e2e95e69 Merge ! src/share/vm/runtime/thread.cpp Changeset: 9a86ddfc6c8f Author: zgu Date: 2012-09-17 16:37 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9a86ddfc6c8f 7188594: Print statistic collected by NMT with VM flag Summary: Print out statistics of collected NMT data if it is on at VM exits Reviewed-by: kvn, coleenp, twisti ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/services/memTracker.hpp Changeset: 45f22ba9348d Author: zgu Date: 2012-09-18 11:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/45f22ba9348d Merge Changeset: 1cb8583c3da8 Author: minqi Date: 2012-09-18 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1cb8583c3da8 7191786: retransformClasses() does not pass in LocalVariableTypeTable of a method Summary: JVMTI REtruncformClasses must support LocalVariableTypeTable attribute Reviewed-by: dcubed, dsamersoff, rbackman Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: 26994b6e10d5 Author: minqi Date: 2012-09-19 08:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/26994b6e10d5 Merge Changeset: 989cf02ca531 Author: ihse Date: 2012-09-17 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/989cf02ca531 7172012: Make test-in-build an option (Queens) Reviewed-by: ohair, dholmes ! make/bsd/Makefile ! make/defs.make ! make/linux/Makefile ! make/solaris/Makefile Changeset: 06be7f06c2de Author: ohair Date: 2012-09-18 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/06be7f06c2de Merge Changeset: 37518f191ddb Author: ohair Date: 2012-09-18 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/37518f191ddb 7198329: Add $(sort) to object files used in links makes binarties more consistent Reviewed-by: dholmes, tbell, erikj, ihse, ohrstrom ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/launcher.make ! make/solaris/makefiles/vm.make Changeset: 0e5be2138cd6 Author: jcoomes Date: 2012-09-18 19:44 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0e5be2138cd6 Merge Changeset: 2c527daec02c Author: jcoomes Date: 2012-09-19 16:18 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2c527daec02c Merge Changeset: 6af8f3562069 Author: kevinw Date: 2012-09-19 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6af8f3562069 7196045: Possible JVM deadlock in ThreadTimesClosure when using HotspotInternal non-public API. Reviewed-by: sspitsyn, dholmes ! src/share/vm/services/management.cpp + test/runtime/7196045/Test7196045.java Changeset: 8440414b0fd8 Author: kevinw Date: 2012-09-20 03:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8440414b0fd8 Merge Changeset: b711844284e2 Author: nloodin Date: 2012-09-21 10:56 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b711844284e2 7200092: Make NMT a bit friendlier to work with Reviewed-by: kvn, ysr, azeemj ! src/share/vm/services/memTracker.cpp Changeset: 5a98bf7d847b Author: minqi Date: 2012-09-24 12:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5a98bf7d847b 6879063: SA should use hsdis for disassembly Summary: We should in SA to use hsdis for it like the JVM does to replace the current java based disassembler. Reviewed-by: twisti, jrose, sla Contributed-by: yumin.qi at oracle.com - agent/make/ClosureFinder.java ! agent/make/Makefile ! agent/src/os/bsd/MacosxDebuggerLocal.m ! agent/src/os/linux/Makefile ! agent/src/os/linux/mapfile ! agent/src/os/solaris/proc/Makefile ! agent/src/os/solaris/proc/mapfile ! agent/src/os/win32/windbg/Makefile ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java ! agent/src/share/classes/sun/jvm/hotspot/asm/Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java ! agent/src/share/classes/sun/jvm/hotspot/asm/InstructionVisitor.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/SADebugServer.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/VirtualMachineImpl.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86RegisterMap.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js + agent/src/share/native/sadis.c ! agent/test/jdi/jstack.sh ! agent/test/jdi/jstack64.sh ! agent/test/jdi/runsa.sh ! agent/test/jdi/sasanity.sh ! agent/test/libproc/libproctest.sh ! agent/test/libproc/libproctest64.sh ! make/bsd/makefiles/sa.make ! make/bsd/makefiles/saproc.make ! make/linux/makefiles/sa.make ! make/linux/makefiles/saproc.make ! make/sa.files ! make/solaris/makefiles/sa.make ! make/solaris/makefiles/saproc.make ! make/windows/makefiles/sa.make ! src/share/tools/hsdis/Makefile ! src/share/tools/hsdis/README ! src/share/tools/hsdis/hsdis-demo.c ! src/share/tools/hsdis/hsdis.c ! src/share/tools/hsdis/hsdis.h ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp Changeset: 3d739d45d9fd Author: minqi Date: 2012-09-24 20:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3d739d45d9fd Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java Changeset: 45535ab90688 Author: dholmes Date: 2012-09-25 07:58 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/45535ab90688 7200065: Cross-compilation changes to support the new-build Reviewed-by: dholmes, ohair Contributed-by: Fredrik Ohrstrom ! make/linux/makefiles/adlc.make ! make/linux/makefiles/defs.make Changeset: b86575d092a2 Author: dsamersoff Date: 2012-09-27 20:22 +0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b86575d092a2 Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java ! make/linux/makefiles/sa.make ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 5baec2e69518 Author: jmasa Date: 2012-09-25 07:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5baec2e69518 7200615: NPG: optimized VM build is broken Reviewed-by: kvn ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/memory/metaspace.cpp Changeset: 8966c2d65d96 Author: brutisso Date: 2012-09-25 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8966c2d65d96 7200470: KeepAliveClosure not needed in CodeCache::do_unloading Summary: Removed the unused keep_alive parameter Reviewed-by: stefank, dholmes, kamg, coleenp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: 7c2fd5948145 Author: brutisso Date: 2012-09-25 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7c2fd5948145 Merge Changeset: 15fba4382765 Author: stefank Date: 2012-09-28 14:14 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/15fba4382765 Merge Changeset: 2cb2f30450c7 Author: twisti Date: 2012-09-17 12:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2cb2f30450c7 7196262: JSR 292: java/lang/invoke/PrivateInvokeTest.java fails on solaris-sparc Reviewed-by: kvn, jrose, bdelsart ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/asm/register.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 8d3cc6612bd1 Author: kvn Date: 2012-09-17 17:02 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8d3cc6612bd1 7197033: missing ResourceMark for assert in Method::bci_from() Summary: Added missing ResourceMark. Reviewed-by: dholmes, coleenp, jmasa ! src/share/vm/oops/method.cpp Changeset: 137868b7aa6f Author: kvn Date: 2012-09-17 19:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/137868b7aa6f 7196199: java/text/Bidi/Bug6665028.java failed: Bidi run count incorrect Summary: Save whole XMM/YMM registers in safepoint interrupt handler. Reviewed-by: roland, twisti ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/x86.ad ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/superword.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp + test/compiler/7196199/Test7196199.java Changeset: 9d89c76b0505 Author: twisti Date: 2012-09-19 10:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9d89c76b0505 7198499: TraceTypeProfile as diagnostic option Reviewed-by: kvn Contributed-by: Aleksey Shipilev ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/doCall.cpp Changeset: 8ae8f9dd7099 Author: kvn Date: 2012-09-19 16:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8ae8f9dd7099 7199010: incorrect vector alignment Summary: Fixed vectors alignment when several arrays are accessed in one loop. Reviewed-by: roland, twisti ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/superword.hpp Changeset: 7eca5de9e0b6 Author: roland Date: 2012-09-20 16:49 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7eca5de9e0b6 7023898: Intrinsify AtomicLongFieldUpdater.getAndIncrement() Summary: use shorter instruction sequences for atomic add and atomic exchange when possible. Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/x86.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp Changeset: b31471cdc53e Author: kvn Date: 2012-09-24 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b31471cdc53e 7200163: add CodeComments functionality to assember stubs Summary: Pass the codeBuffer to the Stub constructor, and adapts the disassembler to print the comments. Reviewed-by: jrose, kvn, twisti Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeBlob.hpp ! src/share/vm/code/icBuffer.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 3a327d0b8586 Author: twisti Date: 2012-09-24 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3a327d0b8586 7188176: The JVM should differentiate between T and M series and adjust GC ergonomics Reviewed-by: kvn Contributed-by: Tao Mao ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp Changeset: f7c1f489db55 Author: twisti Date: 2012-09-24 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f7c1f489db55 Merge Changeset: c92f43386117 Author: kvn Date: 2012-09-24 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c92f43386117 Merge ! src/share/vm/classfile/vmSymbols.hpp Changeset: 9191895df19d Author: twisti Date: 2012-09-24 17:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9191895df19d 7200001: failed C1 OSR compile doesn't get recompiled with C2 Reviewed-by: kvn ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: 1a9b9cfcef41 Author: neliasso Date: 2012-03-29 16:43 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1a9b9cfcef41 7163863: Updated projectcreator Summary: Enable source browsing for all platform dependent code Reviewed-by: brutisso, coleenp ! make/windows/makefiles/projectcreator.make ! src/share/tools/ProjectCreator/BuildConfig.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java + src/share/tools/ProjectCreator/FileTreeCreator.java + src/share/tools/ProjectCreator/FileTreeCreatorVC10.java + src/share/tools/ProjectCreator/FileTreeCreatorVC7.java ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java Changeset: 0702f188baeb Author: kvn Date: 2012-09-25 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0702f188baeb 7200233: C2: can't use expand rules for vector instruction rules Summary: Added missed _bottom_type set in ArchDesc::defineExpand() and missed vector nodes in MatchRule::is_vector(). Reviewed-by: twisti, roland, dlong ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 06f52c4d0e18 Author: kvn Date: 2012-09-25 15:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/06f52c4d0e18 7200264: 7192963 changes disabled shift vectors Summary: Replaced is_vector_use() call with explicit check for vector shift's count. Reviewed-by: twisti, roland, dlong, vlivanov ! src/share/vm/opto/superword.cpp + test/compiler/7200264/Test7200264.sh + test/compiler/7200264/TestIntVect.java Changeset: e626685e9f6c Author: kvn Date: 2012-09-27 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e626685e9f6c 7193318: C2: remove number of inputs requirement from Node's new operator Summary: Deleted placement new operator of Node - node(size_t, Compile *, int). Reviewed-by: kvn, twisti Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/divnode.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp Changeset: 69fb89ec6fa7 Author: kvn Date: 2012-09-27 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/69fb89ec6fa7 7198084: NPG: distance is too big for short branches in test_invocation_counter_for_mdp() Summary: use long branches in test_invocation_counter_for_mdp() Reviewed-by: twisti ! src/cpu/sparc/vm/interp_masm_sparc.cpp Changeset: f2e12eb74117 Author: kvn Date: 2012-09-28 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f2e12eb74117 Merge - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp Changeset: 9f008ad79470 Author: amurillo Date: 2012-09-28 13:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9f008ad79470 Added tag hs25-b03 for changeset f2e12eb74117 ! .hgtags Changeset: 2dd08e86a2bf Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2dd08e86a2bf Added tag jdk8-b58 for changeset 6bb378c50828 ! .hgtags Changeset: 8a1a6b9b4f20 Author: katleman Date: 2012-10-03 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8a1a6b9b4f20 Merge ! .hgtags - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java From david.katleman at oracle.com Thu Oct 4 00:32:30 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 04 Oct 2012 00:32:30 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b58 for changeset 1cb19abb3f7b Message-ID: <20121004003235.7A1004718E@hg.openjdk.java.net> Changeset: af9e8b0f1900 Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/af9e8b0f1900 Added tag jdk8-b58 for changeset 1cb19abb3f7b ! .hgtags From david.katleman at oracle.com Thu Oct 4 00:32:39 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 04 Oct 2012 00:32:39 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b58 for changeset cac4c3937063 Message-ID: <20121004003243.E24DF4718F@hg.openjdk.java.net> Changeset: ae107401be11 Author: katleman Date: 2012-09-27 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/ae107401be11 Added tag jdk8-b58 for changeset cac4c3937063 ! .hgtags From david.katleman at oracle.com Thu Oct 4 00:32:51 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 04 Oct 2012 00:32:51 +0000 Subject: hg: jdk8/build/jdk: Added tag jdk8-b58 for changeset d94613ac03d8 Message-ID: <20121004003312.8A7A747190@hg.openjdk.java.net> Changeset: abad1f417bd3 Author: katleman Date: 2012-09-27 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/abad1f417bd3 Added tag jdk8-b58 for changeset d94613ac03d8 ! .hgtags From david.katleman at oracle.com Thu Oct 4 00:34:35 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 04 Oct 2012 00:34:35 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b58 for changeset 804a3fbc86e2 Message-ID: <20121004003439.E9CD747191@hg.openjdk.java.net> Changeset: f299927fc316 Author: katleman Date: 2012-09-27 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f299927fc316 Added tag jdk8-b58 for changeset 804a3fbc86e2 ! .hgtags From david.holmes at oracle.com Sun Oct 7 23:36:15 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 08 Oct 2012 09:36:15 +1000 Subject: RFR: 8000461 Top level build doesn't pass OPENJDK=true through to the hotspot build Message-ID: <507211EF.8040405@oracle.com> This is a simple fix contributed by Mark Weilaard to add the OPENJDK=true make variable to COMMON_BUILD_ARGUMENTS so that it gets passed down to the component builds - in particular hotspot: http://cr.openjdk.java.net/~dholmes/8000461/webrev/ Here's an extract from a build log showing the value gets passed: cd ./hotspot/make && \ make JDK_TOPDIR=/export/users/dh/jdk8-build/jdk JDK_MAKE_SHARED_DIR=/export/users/dh/jdk8-build/jdk/ make/common/shared EXTERNALSANITYCONTROL=true SOURCE_LANGUAGE_VERSION=7 TARGET_CLASS_VERSION=7 MILESTONE=ea BUILD_NUMBER=b00 JDK_BUILD_NUMBER=b00 FULL_VERSION=1.8.0-ea-b00 PREVIOUS_JDK_VERSION=1.7.0 JDK_VERSION=1.8.0 JDK_MKTG_VERSION=8 JDK_MAJOR_VE RSION=1 JDK_MINOR_VERSION=8 JDK_MICRO_VERSION=0 PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=7 PREVIOUS_MICRO_VERSION=0 O PENJDK=true ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 ALT_OUTPUTDIR=/export/users/dh/jdk8-build/builds/b00/openjdk-linu x-i586-ea/hotspot/outputdir ALT_EXPORT_PATH=/export/users/dh/jdk8-build/builds/b00/openjdk-linux-i586-ea/hotspot/impor t BUILD_FLAVOR=product ALT_SLASH_JAVA=/java ALT_BOOTDIR=/java/re/jdk/1.7.0/archive/fcs/binaries/linux-amd64 ALT_LANGTOOLS_DI ST=/export/users/dh/jdk8-build/builds/b00/openjdk-linux-i586-ea/langtools/dist all_product Thanks, David From tim.bell at oracle.com Mon Oct 8 01:29:01 2012 From: tim.bell at oracle.com (Tim Bell) Date: Sun, 07 Oct 2012 18:29:01 -0700 Subject: RFR: 8000461 Top level build doesn't pass OPENJDK=true through to the hotspot build In-Reply-To: <507211EF.8040405@oracle.com> References: <507211EF.8040405@oracle.com> Message-ID: <50722C5D.1060308@oracle.com> On 10/07/12 16:36, David Holmes wrote: > This is a simple fix contributed by Mark Weilaard to add the > OPENJDK=true make variable to COMMON_BUILD_ARGUMENTS so that it gets > passed down to the component builds - in particular hotspot: > > http://cr.openjdk.java.net/~dholmes/8000461/webrev/ Looks good. Reviewed! Tim > Here's an extract from a build log showing the value gets passed: > > cd ./hotspot/make && \ > make JDK_TOPDIR=/export/users/dh/jdk8-build/jdk > JDK_MAKE_SHARED_DIR=/export/users/dh/jdk8-build/jdk/ > make/common/shared EXTERNALSANITYCONTROL=true > SOURCE_LANGUAGE_VERSION=7 TARGET_CLASS_VERSION=7 MILESTONE=ea > BUILD_NUMBER=b00 > JDK_BUILD_NUMBER=b00 FULL_VERSION=1.8.0-ea-b00 > PREVIOUS_JDK_VERSION=1.7.0 JDK_VERSION=1.8.0 JDK_MKTG_VERSION=8 > JDK_MAJOR_VE > RSION=1 JDK_MINOR_VERSION=8 JDK_MICRO_VERSION=0 > PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=7 > PREVIOUS_MICRO_VERSION=0 O > PENJDK=true ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 > ALT_OUTPUTDIR=/export/users/dh/jdk8-build/builds/b00/openjdk-linu > x-i586-ea/hotspot/outputdir > ALT_EXPORT_PATH=/export/users/dh/jdk8-build/builds/b00/openjdk-linux-i586-ea/hotspot/impor > t BUILD_FLAVOR=product ALT_SLASH_JAVA=/java > ALT_BOOTDIR=/java/re/jdk/1.7.0/archive/fcs/binaries/linux-amd64 > ALT_LANGTOOLS_DI > ST=/export/users/dh/jdk8-build/builds/b00/openjdk-linux-i586-ea/langtools/dist > all_product > > Thanks, > David > From david.holmes at oracle.com Mon Oct 8 01:43:04 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 08 Oct 2012 11:43:04 +1000 Subject: RFR: 8000461 Top level build doesn't pass OPENJDK=true through to the hotspot build In-Reply-To: <50722C5D.1060308@oracle.com> References: <507211EF.8040405@oracle.com> <50722C5D.1060308@oracle.com> Message-ID: <50722FA8.7030709@oracle.com> Thanks Tim. I'll give others a chance to chime-in before pushing. David On 8/10/2012 11:29 AM, Tim Bell wrote: > On 10/07/12 16:36, David Holmes wrote: >> This is a simple fix contributed by Mark Weilaard to add the >> OPENJDK=true make variable to COMMON_BUILD_ARGUMENTS so that it gets >> passed down to the component builds - in particular hotspot: >> >> http://cr.openjdk.java.net/~dholmes/8000461/webrev/ > > Looks good. Reviewed! > > Tim > >> Here's an extract from a build log showing the value gets passed: >> >> cd ./hotspot/make && \ >> make JDK_TOPDIR=/export/users/dh/jdk8-build/jdk >> JDK_MAKE_SHARED_DIR=/export/users/dh/jdk8-build/jdk/ >> make/common/shared EXTERNALSANITYCONTROL=true >> SOURCE_LANGUAGE_VERSION=7 TARGET_CLASS_VERSION=7 MILESTONE=ea >> BUILD_NUMBER=b00 >> JDK_BUILD_NUMBER=b00 FULL_VERSION=1.8.0-ea-b00 >> PREVIOUS_JDK_VERSION=1.7.0 JDK_VERSION=1.8.0 JDK_MKTG_VERSION=8 >> JDK_MAJOR_VE >> RSION=1 JDK_MINOR_VERSION=8 JDK_MICRO_VERSION=0 >> PREVIOUS_MAJOR_VERSION=1 PREVIOUS_MINOR_VERSION=7 >> PREVIOUS_MICRO_VERSION=0 O >> PENJDK=true ARCH_DATA_MODEL=64 COOKED_BUILD_NUMBER=0 >> ALT_OUTPUTDIR=/export/users/dh/jdk8-build/builds/b00/openjdk-linu >> x-i586-ea/hotspot/outputdir >> ALT_EXPORT_PATH=/export/users/dh/jdk8-build/builds/b00/openjdk-linux-i586-ea/hotspot/impor >> >> t BUILD_FLAVOR=product ALT_SLASH_JAVA=/java >> ALT_BOOTDIR=/java/re/jdk/1.7.0/archive/fcs/binaries/linux-amd64 >> ALT_LANGTOOLS_DI >> ST=/export/users/dh/jdk8-build/builds/b00/openjdk-linux-i586-ea/langtools/dist >> all_product >> >> Thanks, >> David >> > > From erik.joelsson at oracle.com Mon Oct 8 15:09:02 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 08 Oct 2012 17:09:02 +0200 Subject: Review request: Build infra update Message-ID: <5072EC8E.9040501@oracle.com> After achieving the milestone of equivalent images from the new and old build, this is a good time to refresh build-infra in jdk8. Here is a webrev with the proposed changes: http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/ Unfortunately the builds will not be as equal in jdk8 as in the build-infra forest due to bug "JDK-8000518 - Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java". Running the comparison script also takes a very long time because of it. /Erik From david.holmes at oracle.com Tue Oct 9 02:10:05 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 09 Oct 2012 12:10:05 +1000 Subject: Review request: Build infra update In-Reply-To: <5072EC8E.9040501@oracle.com> References: <5072EC8E.9040501@oracle.com> Message-ID: <5073877D.8080804@oracle.com> Hi Erik, In Images.gmk you seem to have duplicated the targets/instructions for copying rather than updating them ie: 197 $(JRE_IMAGE_DIR)/lib/%: $(JDK_OUTPUTDIR)/lib/% 198 $(ECHO) Copying $(patsubst $(OUTPUT_ROOT)/%,%,$@) 199 $(install-file) 200 ... 222 # Rules for copying from images/jar directory 223 $(JRE_IMAGE_DIR)/lib/%: $(IMAGES_OUTPUTDIR)/lib/% 224 $(ECHO) Copying $(patsubst $(OUTPUT_ROOT)/%,%,$@) 225 $(install-file) Otherwise I've looked through and fwiw have "Reviewed" the changes. The proof as always is in the building. A couple of to-do items for future cleanup: - remove hardcoded build number and milestone from version.numbers - relocate closed.version.numbers to the closed repo and access it by checking for $(CUSTOM_MAKE_DIR)/version.numbers - remove hardwiring of src/closed paths for socketOptions etc BTW I still haven't seen a resolution to my problem trying to build on Solaris. I'll re-try with latest build-infra. Cheers, David ----- On 9/10/2012 1:09 AM, Erik Joelsson wrote: > After achieving the milestone of equivalent images from the new and old > build, this is a good time to refresh build-infra in jdk8. Here is a > webrev with the proposed changes: > > http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/ > > > Unfortunately the builds will not be as equal in jdk8 as in the > build-infra forest due to bug "JDK-8000518 - Javac generates duplicate > name_and_type constant pool entry for class BinaryOpValueExp.java". > Running the comparison script also takes a very long time because of it. > > /Erik From david.holmes at oracle.com Tue Oct 9 06:09:22 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 09 Oct 2012 06:09:22 +0000 Subject: hg: jdk8/build: 8000461: Top level build doesn't pass OPENJDK=true through to the hotspot build Message-ID: <20121009060923.0993047235@hg.openjdk.java.net> Changeset: 4b54d77a6831 Author: dholmes Date: 2012-10-09 02:08 -0400 URL: http://hg.openjdk.java.net/jdk8/build/rev/4b54d77a6831 8000461: Top level build doesn't pass OPENJDK=true through to the hotspot build Summary: Add OPENJDK to the COMMON_BUILD_ARGUMENTS Reviewed-by: tbell ! make/Defs-internal.gmk From erik.joelsson at oracle.com Tue Oct 9 08:06:25 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 09 Oct 2012 10:06:25 +0200 Subject: Review request: Build infra update In-Reply-To: <5073877D.8080804@oracle.com> References: <5072EC8E.9040501@oracle.com> <5073877D.8080804@oracle.com> Message-ID: <5073DB01.7060503@oracle.com> Not exactly sure what you mean with the duplication other than the comment in the last rule being wrong. One rule is for copying from jdk/lib and the other from images/lib. Both sources contain files that are going into the image. /Erik On 2012-10-09 04:10, David Holmes wrote: > Hi Erik, > > In Images.gmk you seem to have duplicated the targets/instructions for > copying rather than updating them ie: > > 197 $(JRE_IMAGE_DIR)/lib/%: $(JDK_OUTPUTDIR)/lib/% > 198 $(ECHO) Copying $(patsubst $(OUTPUT_ROOT)/%,%,$@) > 199 $(install-file) > 200 > ... > 222 # Rules for copying from images/jar directory > 223 $(JRE_IMAGE_DIR)/lib/%: $(IMAGES_OUTPUTDIR)/lib/% > 224 $(ECHO) Copying $(patsubst $(OUTPUT_ROOT)/%,%,$@) > 225 $(install-file) > > Otherwise I've looked through and fwiw have "Reviewed" the changes. > The proof as always is in the building. > > A couple of to-do items for future cleanup: > - remove hardcoded build number and milestone from version.numbers > - relocate closed.version.numbers to the closed repo and access it by > checking for $(CUSTOM_MAKE_DIR)/version.numbers > - remove hardwiring of src/closed paths for socketOptions etc > > BTW I still haven't seen a resolution to my problem trying to build on > Solaris. I'll re-try with latest build-infra. > > Cheers, > David > ----- > > On 9/10/2012 1:09 AM, Erik Joelsson wrote: >> After achieving the milestone of equivalent images from the new and old >> build, this is a good time to refresh build-infra in jdk8. Here is a >> webrev with the proposed changes: >> >> http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/ >> >> >> Unfortunately the builds will not be as equal in jdk8 as in the >> build-infra forest due to bug "JDK-8000518 - Javac generates duplicate >> name_and_type constant pool entry for class BinaryOpValueExp.java". >> Running the comparison script also takes a very long time because of it. >> >> /Erik From erik.joelsson at oracle.com Tue Oct 9 08:25:56 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 09 Oct 2012 10:25:56 +0200 Subject: Review request: Build infra update In-Reply-To: <5073DB01.7060503@oracle.com> References: <5072EC8E.9040501@oracle.com> <5073877D.8080804@oracle.com> <5073DB01.7060503@oracle.com> Message-ID: <5073DF94.3040509@oracle.com> Oh and thanks for the review of course! /Erik On 2012-10-09 10:06, Erik Joelsson wrote: > Not exactly sure what you mean with the duplication other than the > comment in the last rule being wrong. One rule is for copying from > jdk/lib and the other from images/lib. Both sources contain files that > are going into the image. > > /Erik > > On 2012-10-09 04:10, David Holmes wrote: >> Hi Erik, >> >> In Images.gmk you seem to have duplicated the targets/instructions >> for copying rather than updating them ie: >> >> 197 $(JRE_IMAGE_DIR)/lib/%: $(JDK_OUTPUTDIR)/lib/% >> 198 $(ECHO) Copying $(patsubst $(OUTPUT_ROOT)/%,%,$@) >> 199 $(install-file) >> 200 >> ... >> 222 # Rules for copying from images/jar directory >> 223 $(JRE_IMAGE_DIR)/lib/%: $(IMAGES_OUTPUTDIR)/lib/% >> 224 $(ECHO) Copying $(patsubst $(OUTPUT_ROOT)/%,%,$@) >> 225 $(install-file) >> >> Otherwise I've looked through and fwiw have "Reviewed" the changes. >> The proof as always is in the building. >> >> A couple of to-do items for future cleanup: >> - remove hardcoded build number and milestone from version.numbers >> - relocate closed.version.numbers to the closed repo and access it by >> checking for $(CUSTOM_MAKE_DIR)/version.numbers >> - remove hardwiring of src/closed paths for socketOptions etc >> >> BTW I still haven't seen a resolution to my problem trying to build >> on Solaris. I'll re-try with latest build-infra. >> >> Cheers, >> David >> ----- >> >> On 9/10/2012 1:09 AM, Erik Joelsson wrote: >>> After achieving the milestone of equivalent images from the new and old >>> build, this is a good time to refresh build-infra in jdk8. Here is a >>> webrev with the proposed changes: >>> >>> http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/ >>> >>> >>> Unfortunately the builds will not be as equal in jdk8 as in the >>> build-infra forest due to bug "JDK-8000518 - Javac generates duplicate >>> name_and_type constant pool entry for class BinaryOpValueExp.java". >>> Running the comparison script also takes a very long time because of >>> it. >>> >>> /Erik From magnus.ihse.bursie at oracle.com Tue Oct 9 09:33:26 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 09 Oct 2012 11:33:26 +0200 Subject: Review request: Build infra update In-Reply-To: <5072EC8E.9040501@oracle.com> References: <5072EC8E.9040501@oracle.com> Message-ID: <5073EF66.5090903@oracle.com> On 2012-10-08 17:09, Erik Joelsson wrote: > After achieving the milestone of equivalent images from the new and > old build, this is a good time to refresh build-infra in jdk8. Here is > a webrev with the proposed changes: > > http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/ > Looks good! /Magnus From david.holmes at oracle.com Tue Oct 9 10:59:16 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 09 Oct 2012 20:59:16 +1000 Subject: Review request: Build infra update In-Reply-To: <5073DB01.7060503@oracle.com> References: <5072EC8E.9040501@oracle.com> <5073877D.8080804@oracle.com> <5073DB01.7060503@oracle.com> Message-ID: <50740384.5020902@oracle.com> On 9/10/2012 6:06 PM, Erik Joelsson wrote: > Not exactly sure what you mean with the duplication other than the > comment in the last rule being wrong. One rule is for copying from > jdk/lib and the other from images/lib. Both sources contain files that > are going into the image. I thought you were only allowed to define one recipe per target? Or are we going to find disjoint sets of files in each location? These wildcard based targets and dependencies still cause me some confusion. I don't understand what process make follows to actually determine what the real set of targets is. David > /Erik > > On 2012-10-09 04:10, David Holmes wrote: >> Hi Erik, >> >> In Images.gmk you seem to have duplicated the targets/instructions for >> copying rather than updating them ie: >> >> 197 $(JRE_IMAGE_DIR)/lib/%: $(JDK_OUTPUTDIR)/lib/% >> 198 $(ECHO) Copying $(patsubst $(OUTPUT_ROOT)/%,%,$@) >> 199 $(install-file) >> 200 >> ... >> 222 # Rules for copying from images/jar directory >> 223 $(JRE_IMAGE_DIR)/lib/%: $(IMAGES_OUTPUTDIR)/lib/% >> 224 $(ECHO) Copying $(patsubst $(OUTPUT_ROOT)/%,%,$@) >> 225 $(install-file) >> >> Otherwise I've looked through and fwiw have "Reviewed" the changes. >> The proof as always is in the building. >> >> A couple of to-do items for future cleanup: >> - remove hardcoded build number and milestone from version.numbers >> - relocate closed.version.numbers to the closed repo and access it by >> checking for $(CUSTOM_MAKE_DIR)/version.numbers >> - remove hardwiring of src/closed paths for socketOptions etc >> >> BTW I still haven't seen a resolution to my problem trying to build on >> Solaris. I'll re-try with latest build-infra. >> >> Cheers, >> David >> ----- >> >> On 9/10/2012 1:09 AM, Erik Joelsson wrote: >>> After achieving the milestone of equivalent images from the new and old >>> build, this is a good time to refresh build-infra in jdk8. Here is a >>> webrev with the proposed changes: >>> >>> http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/ >>> >>> >>> Unfortunately the builds will not be as equal in jdk8 as in the >>> build-infra forest due to bug "JDK-8000518 - Javac generates duplicate >>> name_and_type constant pool entry for class BinaryOpValueExp.java". >>> Running the comparison script also takes a very long time because of it. >>> >>> /Erik From erik.joelsson at oracle.com Tue Oct 9 11:13:27 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 09 Oct 2012 13:13:27 +0200 Subject: Review request: Build infra update In-Reply-To: <50740384.5020902@oracle.com> References: <5072EC8E.9040501@oracle.com> <5073877D.8080804@oracle.com> <5073DB01.7060503@oracle.com> <50740384.5020902@oracle.com> Message-ID: <507406D7.3060809@oracle.com> On 2012-10-09 12:59, David Holmes wrote: > On 9/10/2012 6:06 PM, Erik Joelsson wrote: >> Not exactly sure what you mean with the duplication other than the >> comment in the last rule being wrong. One rule is for copying from >> jdk/lib and the other from images/lib. Both sources contain files that >> are going into the image. > > I thought you were only allowed to define one recipe per target? Or > are we going to find disjoint sets of files in each location? > > These wildcard based targets and dependencies still cause me some > confusion. I don't understand what process make follows to actually > determine what the real set of targets is. > My assumption is that the sets are disjoint yes. I'm not completely sure of the process either, but figured that as long as the sets are disjoint, it will be fine. Also, if they are not, we have a problem regardless imo. I do agree I might have gone a bit too wild with the pattern targets in this case though. /Erik From david.holmes at oracle.com Tue Oct 9 11:26:54 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 09 Oct 2012 21:26:54 +1000 Subject: Review request: Build infra update In-Reply-To: <507406D7.3060809@oracle.com> References: <5072EC8E.9040501@oracle.com> <5073877D.8080804@oracle.com> <5073DB01.7060503@oracle.com> <50740384.5020902@oracle.com> <507406D7.3060809@oracle.com> Message-ID: <507409FE.6030306@oracle.com> On 9/10/2012 9:13 PM, Erik Joelsson wrote: > On 2012-10-09 12:59, David Holmes wrote: >> On 9/10/2012 6:06 PM, Erik Joelsson wrote: >>> Not exactly sure what you mean with the duplication other than the >>> comment in the last rule being wrong. One rule is for copying from >>> jdk/lib and the other from images/lib. Both sources contain files that >>> are going into the image. >> >> I thought you were only allowed to define one recipe per target? Or >> are we going to find disjoint sets of files in each location? >> >> These wildcard based targets and dependencies still cause me some >> confusion. I don't understand what process make follows to actually >> determine what the real set of targets is. >> > My assumption is that the sets are disjoint yes. I'm not completely sure > of the process either, but figured that as long as the sets are > disjoint, it will be fine. Also, if they are not, we have a problem > regardless imo. So the process is, as I understand it, for every file that matches the dependency pattern a target for that file, in the output-location, is created and the recipe then copies from src to destination. As you say the two sets of input files should be distinct so there are no duplicates in the set of targets formed. (Though if you don't do a clean before rebuilding with this patch applied things might get a bit confused :) ). > I do agree I might have gone a bit too wild with the pattern targets in > this case though. :) Not sure how else you could define these generic copying routines. Thanks, David > /Erik From david.katleman at oracle.com Wed Oct 10 22:20:54 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 10 Oct 2012 22:20:54 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20121010222055.4F47847299@hg.openjdk.java.net> Changeset: b9d574659206 Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/b9d574659206 Added tag jdk8-b59 for changeset dae9821589cc ! .hgtags Changeset: e07f499b9dcc Author: katleman Date: 2012-10-10 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/e07f499b9dcc Merge From david.katleman at oracle.com Wed Oct 10 22:20:59 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 10 Oct 2012 22:20:59 +0000 Subject: hg: jdk8/build/corba: Added tag jdk8-b59 for changeset d54dc53e223e Message-ID: <20121010222100.67E4D4729A@hg.openjdk.java.net> Changeset: 207ef43ba69e Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/207ef43ba69e Added tag jdk8-b59 for changeset d54dc53e223e ! .hgtags From david.katleman at oracle.com Wed Oct 10 22:23:40 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 10 Oct 2012 22:23:40 +0000 Subject: hg: jdk8/build/hotspot: 19 new changesets Message-ID: <20121010222426.C6DEC4729B@hg.openjdk.java.net> Changeset: a3fd4914ac81 Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/a3fd4914ac81 Added tag jdk8-b59 for changeset 8a1a6b9b4f20 ! .hgtags Changeset: 1b582b1bf7cb Author: amurillo Date: 2012-09-28 14:36 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1b582b1bf7cb 8000251: new hotspot build - hs25-b04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 988bf00cc564 Author: johnc Date: 2012-09-27 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/988bf00cc564 7200261: G1: Liveness counting inconsistencies during marking verification Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures. Reviewed-by: brutisso, jwilhelm, jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp Changeset: 5c8fbbfed964 Author: stefank Date: 2012-10-01 11:07 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5c8fbbfed964 Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java Changeset: 85f1cded9793 Author: stefank Date: 2012-09-28 15:34 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/85f1cded9793 8000230: Change os::print_location to be more descriptive when a location is pointing into an object Reviewed-by: mgerdin, twisti ! src/share/vm/runtime/os.cpp Changeset: 86af3dacab81 Author: stefank Date: 2012-10-01 13:29 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/86af3dacab81 8000227: [obj|type]ArrayKlass::oop_print_on prints one line to tty instead of the provided output stream Reviewed-by: brutisso, sla, jmasa, coleenp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: 87ac5c0a404d Author: stefank Date: 2012-10-01 13:29 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/87ac5c0a404d 8000228: Missing call to cr() when printing entry_point in nmethod, in os::print_location Reviewed-by: brutisso, neliasso ! src/share/vm/runtime/os.cpp Changeset: f81a7c0c618d Author: jmasa Date: 2012-10-03 08:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f81a7c0c618d 7199349: NPG: PS: Crash seen in jprt Reviewed-by: johnc ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/runtime/globals.hpp Changeset: 22b8d3d181d9 Author: jwilhelm Date: 2012-10-03 20:31 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/22b8d3d181d9 8000351: Tenuring threshold should be unsigned Summary: Change the flags and variables related to tenuring threshold to be unsigned Reviewed-by: jmasa, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/shared/ageTable.cpp ! src/share/vm/gc_implementation/shared/ageTable.hpp ! src/share/vm/gc_implementation/shared/gcAdaptivePolicyCounters.hpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/oops/markOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 2e6857353b2c Author: johnc Date: 2012-10-04 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2e6857353b2c 8000311: G1: ParallelGCThreads==0 broken Summary: Divide by zero error, if ParallelGCThreads is 0, when adjusting the PLAB size. Reviewed-by: jmasa, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp Changeset: 097d78aaf2b5 Author: jmasa Date: 2012-10-04 10:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/097d78aaf2b5 7198873: NPG: VM Does not unload classes with UseConcMarkSweepGC Reviewed-by: johnc, mgerdin, jwilhelm ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp Changeset: ca70b919819f Author: jmasa Date: 2012-10-04 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ca70b919819f Merge Changeset: f6b0eb4e44cf Author: twisti Date: 2012-10-01 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f6b0eb4e44cf 7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path Reviewed-by: jrose, kvn ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciClassList.hpp + src/share/vm/ci/ciMethodType.hpp ! src/share/vm/ci/ciObject.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciSignature.cpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp Changeset: 859c45fb8cea Author: kvn Date: 2012-10-02 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/859c45fb8cea 7201026: add vector for shift count Summary: Add generation of vectors for scalar shift count. Reviewed-by: roland, twisti, dlong ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp ! src/share/vm/opto/vectornode.hpp ! test/compiler/7200264/Test7200264.sh Changeset: f13867c41f73 Author: kvn Date: 2012-10-02 14:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f13867c41f73 7199742: A lot of C2 OSR compilations of the same method's bci Summary: Don't clone head of OSR loop. Reviewed-by: jrose, twisti ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/opto/parse1.cpp + test/compiler/7199742/Test7199742.java Changeset: bf2edd3c9b0f Author: neliasso Date: 2012-10-04 06:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bf2edd3c9b0f 8000102: Resolve include conflicts Summary: Removing include of c1/c1_runtime.hpp and opto/runtime.hpp from all os-files. Reviewed-by: kvn Contributed-by: nils.eliasson at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp Changeset: 685457683e86 Author: kvn Date: 2012-10-05 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/685457683e86 Merge Changeset: 1cc7a2a11d00 Author: amurillo Date: 2012-10-05 13:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1cc7a2a11d00 Merge Changeset: 3cfd05b2219a Author: amurillo Date: 2012-10-05 13:28 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/3cfd05b2219a Added tag hs25-b04 for changeset 1cc7a2a11d00 ! .hgtags From david.katleman at oracle.com Wed Oct 10 22:26:32 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 10 Oct 2012 22:26:32 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b59 for changeset af9e8b0f1900 Message-ID: <20121010222640.691914729C@hg.openjdk.java.net> Changeset: 2d1dff5310da Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/2d1dff5310da Added tag jdk8-b59 for changeset af9e8b0f1900 ! .hgtags From david.katleman at oracle.com Wed Oct 10 22:26:44 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 10 Oct 2012 22:26:44 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b59 for changeset ae107401be11 Message-ID: <20121010222648.630654729D@hg.openjdk.java.net> Changeset: 5c5a65ad5291 Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/5c5a65ad5291 Added tag jdk8-b59 for changeset ae107401be11 ! .hgtags From david.katleman at oracle.com Wed Oct 10 22:26:55 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 10 Oct 2012 22:26:55 +0000 Subject: hg: jdk8/build/jdk: Added tag jdk8-b59 for changeset abad1f417bd3 Message-ID: <20121010222723.7443D4729E@hg.openjdk.java.net> Changeset: cec8fa02f156 Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cec8fa02f156 Added tag jdk8-b59 for changeset abad1f417bd3 ! .hgtags From david.katleman at oracle.com Wed Oct 10 22:32:09 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 10 Oct 2012 22:32:09 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b59 for changeset f299927fc316 Message-ID: <20121010223215.179754729F@hg.openjdk.java.net> Changeset: 3d2b98ffcb53 Author: katleman Date: 2012-10-04 14:36 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/3d2b98ffcb53 Added tag jdk8-b59 for changeset f299927fc316 ! .hgtags From michael.fang at oracle.com Wed Oct 10 23:21:11 2012 From: michael.fang at oracle.com (Michael Fang) Date: Wed, 10 Oct 2012 16:21:11 -0700 Subject: [8] Review request for 8000693 Move jdk.tbom from jdk/make/closed to jdk repository Message-ID: <507602E7.1080405@oracle.com> Hi Build dev team, This was originally submitted as 7196354 check-in jdk.tbom file to openjdk repo, but the file was checked in to the closedjdk repository. The automated translation drop system handles penjdk and closedjdk resource files separately as 2 different components. Having jdk.tbom file in closedjdk repository caused the system to not generate the translation drop for openjdk files. Therefore, I need to move the file to jdk repository under jdk/make. The webrev can be found here: http://cr.openjdk.java.net/~mfang/8000693/webrev.00/ Could you please let me know if you have concern about the move? The file itself has not been touched. Thanks! -michael From mark.reinhold at oracle.com Wed Oct 10 23:41:35 2012 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 10 Oct 2012 16:41:35 -0700 Subject: [8] Review request for 8000693 Move jdk.tbom from jdk/make/closed to jdk repository In-Reply-To: michael.fang@oracle.com; Wed, 10 Oct 2012 16:21:11 PDT; <507602E7.1080405@oracle.com> Message-ID: <20121010234135.34C0217E6@eggemoggin.niobe.net> 2012/10/10 16:21 -0700, michael.fang at oracle.com: > This was originally submitted as 7196354 check-in jdk.tbom file to openjdk > repo, but the file was checked in to the closedjdk repository. > > The automated translation drop system handles penjdk and closedjdk resource > files separately as 2 different components. Having jdk.tbom file in closedjdk > repository caused the system to not generate the translation drop for openjdk > files. Therefore, I need to move the file to jdk repository under jdk/make. Putting this file into an OpenJDK source tree is no more acceptable now than it was when you first proposed it. I think you need to get somebody to fix Oracle's internal translation system instead. - Mark From sean.coffey at oracle.com Thu Oct 11 09:21:43 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Thu, 11 Oct 2012 10:21:43 +0100 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: <50766DEA.2000108@oracle.com> References: <50766DEA.2000108@oracle.com> Message-ID: <50768FA7.9060100@oracle.com> Moving this off discuss mailing list to build-dev. Why is ENABLE_FULL_DEBUG_SYMBOLS being set to 1 for many product builds now ? It slows down the build and creates increased bundle size even though the majority of users do not require this functionality. Could we consider flipping the default for ENABLE_FULL_DEBUG_SYMBOLS to 0 ? (like I've done for all my build scripts?) regards, Sean. -------- Original Message -------- Subject: Re: How to decrease size of j2sdk_image Date: Thu, 11 Oct 2012 14:57:46 +0800 From: Weijun Wang To: discuss at openjdk.java.net You can try set ENABLE_FULL_DEBUG_SYMBOLS to 0. -Max On 10/11/2012 02:38 PM, matchew wrote: > > After successful openJDK7 build (Ubuntu 12.04) i have found that > 'j2sdk-image' has 240MB. More than 100MB belongs to one directory: > openjdk7/jre/lib/amd64 > > Can anyone explain me why it is so big? For example in openJDK7 installed > via package manager this folder has only 18MB > > Is there any way to decrease its size? > > Thanks in advance > -- > Mateusz > From daniel.daugherty at oracle.com Thu Oct 11 14:35:20 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 11 Oct 2012 08:35:20 -0600 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: <50768FA7.9060100@oracle.com> References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> Message-ID: <5076D928.3030404@oracle.com> On 10/11/12 3:21 AM, Se?n Coffey wrote: > Moving this off discuss mailing list to build-dev. > > Why is ENABLE_FULL_DEBUG_SYMBOLS being set to 1 for many product > builds now ? It slows down the build and creates increased bundle size > even though the majority of users do not require this functionality. The Full Debug Symbols feature will eventually be enabled for all OSes for which Oracle generates bits. I think MacOS X is the last platform and that work is tracked by: 7165611 3/3 implement Full Debug Symbols on MacOS X The default setting for ENABLE_FULL_DEBUG_SYMBOLS is "1" (enabled) because the Full Debug Symbols feature is intentionally enabled in all promoted bits for diagnosibility and debuggability. If FDS is not enabled when the promoted bits are built, then the debug info generated by a rebuild of *exactly the same source* with FDS enabled cannot be (reliably) used with the promoted bits. You might be saying: That's fine for promoted bits, but what about the rest of us? The answer there is actually simple. We want our developer private builds and automated system builds, e.g., JPRT, to match what Release Engineering builds. We don't want RE to be surprised by an integration that builds fine when FDS is disabled only to blow up when FDS is enabled. Similarly, we also don't want SQE/SQA to be surprised by different test results with bits built by RE versus bits built with FDS disabled, e.g., JPRT. Enabling "debug info" in a build changes the compiler optimizations and that changes the bits in the binary. Those changes in the binary might mask a bug that only shows up after RE has built with FDS enabled. Conversely, if you disable FDS in your private build, you might end up chasing a bug that only reproduces in your private build and doesn't reproduce in an FDS enabled build. > Could we consider flipping the default for ENABLE_FULL_DEBUG_SYMBOLS > to 0 ? (like I've done for all my build scripts?) For the reasons I stated above, no we won't change the default for ENABLE_FULL_DEBUG_SYMBOLS to "0" (disabled) unless Oracle changes the way that promoted bits are built. You are welcome to disable the feature in your private builds which is why I added the ENABLE_FULL_DEBUG_SYMBOLS flag. However, please remember that any testing that you do with those bits won't necessarily match testing done with the official promoted bits. Dan > > regards, > Sean. > > -------- Original Message -------- > Subject: Re: How to decrease size of j2sdk_image > Date: Thu, 11 Oct 2012 14:57:46 +0800 > From: Weijun Wang > To: discuss at openjdk.java.net > > > > You can try set ENABLE_FULL_DEBUG_SYMBOLS to 0. > > -Max > > On 10/11/2012 02:38 PM, matchew wrote: > > > > After successful openJDK7 build (Ubuntu 12.04) i have found that > > 'j2sdk-image' has 240MB. More than 100MB belongs to one directory: > > openjdk7/jre/lib/amd64 > > > > Can anyone explain me why it is so big? For example in openJDK7 installed > > via package manager this folder has only 18MB > > > > Is there any way to decrease its size? > > > > Thanks in advance > > -- > > Mateusz > > > > > From daniel.daugherty at oracle.com Thu Oct 11 14:58:09 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 11 Oct 2012 08:58:09 -0600 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> Message-ID: <5076DE81.4080608@oracle.com> On 10/11/12 8:50 AM, matchew wrote: > what about openjdk builds used for example by ubuntu package manager > (default repos)? these builds do not have these debug files (*.diz) at > all. I don't know how Ubuntu builds the OpenJDK repos so I can't really comment on why those builds don't have debug info files. Downstream projects can change the default settings and several of the downstream Linux project have enabled even more debug info in their builds. > If i am not considering jvm/jdk native code debugging is it safe to > just remove them all? It's your build. If you don't think you need the debug info, then you can remove it. Dan > > 2012/10/11 Daniel D. Daugherty > > > On 10/11/12 3:21 AM, Se?n Coffey wrote: >> Moving this off discuss mailing list to build-dev. >> >> Why is ENABLE_FULL_DEBUG_SYMBOLS being set to 1 for many product >> builds now ? It slows down the build and creates increased bundle >> size even though the majority of users do not require this >> functionality. > > The Full Debug Symbols feature will eventually be enabled for all > OSes for which Oracle generates bits. I think MacOS X is the last > platform and that work is tracked by: > > 7165611 3/3 implement Full Debug Symbols on MacOS X > > The default setting for ENABLE_FULL_DEBUG_SYMBOLS is "1" (enabled) > because the Full Debug Symbols feature is intentionally enabled in > all promoted bits for diagnosibility and debuggability. If FDS is > not enabled when the promoted bits are built, then the debug info > generated by a rebuild of *exactly the same source* with FDS enabled > cannot be (reliably) used with the promoted bits. > > You might be saying: > > That's fine for promoted bits, but what about the rest of us? > > The answer there is actually simple. We want our developer private > builds and automated system builds, e.g., JPRT, to match what Release > Engineering builds. We don't want RE to be surprised by an integration > that builds fine when FDS is disabled only to blow up when FDS is > enabled. > > Similarly, we also don't want SQE/SQA to be surprised by different > test results with bits built by RE versus bits built with FDS > disabled, > e.g., JPRT. Enabling "debug info" in a build changes the compiler > optimizations and that changes the bits in the binary. Those changes > in the binary might mask a bug that only shows up after RE has built > with FDS enabled. Conversely, if you disable FDS in your private > build, > you might end up chasing a bug that only reproduces in your private > build and doesn't reproduce in an FDS enabled build. > > >> Could we consider flipping the default for >> ENABLE_FULL_DEBUG_SYMBOLS to 0 ? (like I've done for all my build >> scripts?) > > For the reasons I stated above, no we won't change the default for > ENABLE_FULL_DEBUG_SYMBOLS to "0" (disabled) unless Oracle changes > the way that promoted bits are built. > > You are welcome to disable the feature in your private builds which > is why I added the ENABLE_FULL_DEBUG_SYMBOLS flag. However, please > remember that any testing that you do with those bits won't > necessarily > match testing done with the official promoted bits. > > Dan > > >> >> regards, >> Sean. >> >> -------- Original Message -------- >> Subject: Re: How to decrease size of j2sdk_image >> Date: Thu, 11 Oct 2012 14:57:46 +0800 >> From: Weijun Wang >> >> To: discuss at openjdk.java.net >> >> >> >> You can try set ENABLE_FULL_DEBUG_SYMBOLS to 0. >> >> -Max >> >> On 10/11/2012 02:38 PM, matchew wrote: >> > >> > After successful openJDK7 build (Ubuntu 12.04) i have found that >> > 'j2sdk-image' has 240MB. More than 100MB belongs to one directory: >> > openjdk7/jre/lib/amd64 >> > >> > Can anyone explain me why it is so big? For example in openJDK7 installed >> > via package manager this folder has only 18MB >> > >> > Is there any way to decrease its size? >> > >> > Thanks in advance >> > -- >> > Mateusz >> > >> >> >> > From daniel.daugherty at oracle.com Thu Oct 11 15:13:16 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 11 Oct 2012 09:13:16 -0600 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> <5076DE81.4080608@oracle.com> Message-ID: <5076E20C.7070809@oracle.com> On 10/11/12 9:09 AM, matchew wrote: > Understand. But why still when ENABLE_FULL_DEBUG_SYMBOLS is set to 0 > these files are generated? What type of build are you doing? The ENABLE_FULL_DEBUG_SYMBOLS flag only disables the feature for "product bits" builds. For a JDK build that is an "OPT" build. For a HotSpot build that is a "product" build. Dan > > 2012/10/11 Daniel D. Daugherty > > > On 10/11/12 8:50 AM, matchew wrote: >> what about openjdk builds used for example by ubuntu package >> manager (default repos)? these builds do not have these debug >> files (*.diz) at all. > > I don't know how Ubuntu builds the OpenJDK repos so I can't > really comment on why those builds don't have debug info files. > Downstream projects can change the default settings and several > of the downstream Linux project have enabled even more debug > info in their builds. > > >> If i am not considering jvm/jdk native code debugging is it safe >> to just remove them all? > > It's your build. If you don't think you need the debug info, then > you can remove it. > > Dan > > >> >> 2012/10/11 Daniel D. Daugherty > > >> >> On 10/11/12 3:21 AM, Se?n Coffey wrote: >>> Moving this off discuss mailing list to build-dev. >>> >>> Why is ENABLE_FULL_DEBUG_SYMBOLS being set to 1 for many >>> product builds now ? It slows down the build and creates >>> increased bundle size even though the majority of users do >>> not require this functionality. >> >> The Full Debug Symbols feature will eventually be enabled for all >> OSes for which Oracle generates bits. I think MacOS X is the last >> platform and that work is tracked by: >> >> 7165611 3/3 implement Full Debug Symbols on MacOS X >> >> The default setting for ENABLE_FULL_DEBUG_SYMBOLS is "1" >> (enabled) >> because the Full Debug Symbols feature is intentionally >> enabled in >> all promoted bits for diagnosibility and debuggability. If FDS is >> not enabled when the promoted bits are built, then the debug info >> generated by a rebuild of *exactly the same source* with FDS >> enabled >> cannot be (reliably) used with the promoted bits. >> >> You might be saying: >> >> That's fine for promoted bits, but what about the rest of us? >> >> The answer there is actually simple. We want our developer >> private >> builds and automated system builds, e.g., JPRT, to match what >> Release >> Engineering builds. We don't want RE to be surprised by an >> integration >> that builds fine when FDS is disabled only to blow up when FDS is >> enabled. >> >> Similarly, we also don't want SQE/SQA to be surprised by >> different >> test results with bits built by RE versus bits built with FDS >> disabled, >> e.g., JPRT. Enabling "debug info" in a build changes the compiler >> optimizations and that changes the bits in the binary. Those >> changes >> in the binary might mask a bug that only shows up after RE >> has built >> with FDS enabled. Conversely, if you disable FDS in your >> private build, >> you might end up chasing a bug that only reproduces in your >> private >> build and doesn't reproduce in an FDS enabled build. >> >> >>> Could we consider flipping the default for >>> ENABLE_FULL_DEBUG_SYMBOLS to 0 ? (like I've done for all my >>> build scripts?) >> >> For the reasons I stated above, no we won't change the >> default for >> ENABLE_FULL_DEBUG_SYMBOLS to "0" (disabled) unless Oracle changes >> the way that promoted bits are built. >> >> You are welcome to disable the feature in your private builds >> which >> is why I added the ENABLE_FULL_DEBUG_SYMBOLS flag. However, >> please >> remember that any testing that you do with those bits won't >> necessarily >> match testing done with the official promoted bits. >> >> Dan >> >> >>> >>> regards, >>> Sean. >>> >>> -------- Original Message -------- >>> Subject: Re: How to decrease size of j2sdk_image >>> Date: Thu, 11 Oct 2012 14:57:46 +0800 >>> From: Weijun Wang >>> >>> To: discuss at openjdk.java.net >>> >>> >>> >>> You can try set ENABLE_FULL_DEBUG_SYMBOLS to 0. >>> >>> -Max >>> >>> On 10/11/2012 02:38 PM, matchew wrote: >>> > >>> > After successful openJDK7 build (Ubuntu 12.04) i have found that >>> > 'j2sdk-image' has 240MB. More than 100MB belongs to one directory: >>> > openjdk7/jre/lib/amd64 >>> > >>> > Can anyone explain me why it is so big? For example in openJDK7 installed >>> > via package manager this folder has only 18MB >>> > >>> > Is there any way to decrease its size? >>> > >>> > Thanks in advance >>> > -- >>> > Mateusz >>> > >>> >>> >>> >> > From daniel.daugherty at oracle.com Thu Oct 11 15:26:19 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 11 Oct 2012 09:26:19 -0600 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> <5076DE81.4080608@oracle.com> <5076E20C.7070809@oracle.com> Message-ID: <5076E51B.6000302@oracle.com> How are you invoking your build? Dan On 10/11/12 9:19 AM, matchew wrote: > i believe i am doing full build - including jdk, hotspot, etc. So how > can i switch off debug symbols in jdk builds? > > 2012/10/11 Daniel D. Daugherty > > > On 10/11/12 9:09 AM, matchew wrote: >> Understand. But why still when ENABLE_FULL_DEBUG_SYMBOLS is set >> to 0 these files are generated? > > What type of build are you doing? The ENABLE_FULL_DEBUG_SYMBOLS > flag only disables the feature for "product bits" builds. For a > JDK build that is an "OPT" build. For a HotSpot build that is a > "product" build. > > Dan > > >> >> 2012/10/11 Daniel D. Daugherty > > >> >> On 10/11/12 8:50 AM, matchew wrote: >>> what about openjdk builds used for example by ubuntu package >>> manager (default repos)? these builds do not have these >>> debug files (*.diz) at all. >> >> I don't know how Ubuntu builds the OpenJDK repos so I can't >> really comment on why those builds don't have debug info files. >> Downstream projects can change the default settings and several >> of the downstream Linux project have enabled even more debug >> info in their builds. >> >> >>> If i am not considering jvm/jdk native code debugging is it >>> safe to just remove them all? >> >> It's your build. If you don't think you need the debug info, then >> you can remove it. >> >> Dan >> >> >>> >>> 2012/10/11 Daniel D. Daugherty >> > >>> >>> On 10/11/12 3:21 AM, Se?n Coffey wrote: >>>> Moving this off discuss mailing list to build-dev. >>>> >>>> Why is ENABLE_FULL_DEBUG_SYMBOLS being set to 1 for >>>> many product builds now ? It slows down the build and >>>> creates increased bundle size even though the majority >>>> of users do not require this functionality. >>> >>> The Full Debug Symbols feature will eventually be >>> enabled for all >>> OSes for which Oracle generates bits. I think MacOS X is >>> the last >>> platform and that work is tracked by: >>> >>> 7165611 3/3 implement Full Debug Symbols on MacOS X >>> >>> The default setting for ENABLE_FULL_DEBUG_SYMBOLS is "1" >>> (enabled) >>> because the Full Debug Symbols feature is intentionally >>> enabled in >>> all promoted bits for diagnosibility and debuggability. >>> If FDS is >>> not enabled when the promoted bits are built, then the >>> debug info >>> generated by a rebuild of *exactly the same source* with >>> FDS enabled >>> cannot be (reliably) used with the promoted bits. >>> >>> You might be saying: >>> >>> That's fine for promoted bits, but what about the >>> rest of us? >>> >>> The answer there is actually simple. We want our >>> developer private >>> builds and automated system builds, e.g., JPRT, to match >>> what Release >>> Engineering builds. We don't want RE to be surprised by >>> an integration >>> that builds fine when FDS is disabled only to blow up >>> when FDS is >>> enabled. >>> >>> Similarly, we also don't want SQE/SQA to be surprised by >>> different >>> test results with bits built by RE versus bits built >>> with FDS disabled, >>> e.g., JPRT. Enabling "debug info" in a build changes the >>> compiler >>> optimizations and that changes the bits in the binary. >>> Those changes >>> in the binary might mask a bug that only shows up after >>> RE has built >>> with FDS enabled. Conversely, if you disable FDS in your >>> private build, >>> you might end up chasing a bug that only reproduces in >>> your private >>> build and doesn't reproduce in an FDS enabled build. >>> >>> >>>> Could we consider flipping the default for >>>> ENABLE_FULL_DEBUG_SYMBOLS to 0 ? (like I've done for >>>> all my build scripts?) >>> >>> For the reasons I stated above, no we won't change the >>> default for >>> ENABLE_FULL_DEBUG_SYMBOLS to "0" (disabled) unless >>> Oracle changes >>> the way that promoted bits are built. >>> >>> You are welcome to disable the feature in your private >>> builds which >>> is why I added the ENABLE_FULL_DEBUG_SYMBOLS flag. >>> However, please >>> remember that any testing that you do with those bits >>> won't necessarily >>> match testing done with the official promoted bits. >>> >>> Dan >>> >>> >>>> >>>> regards, >>>> Sean. >>>> >>>> -------- Original Message -------- >>>> Subject: Re: How to decrease size of j2sdk_image >>>> Date: Thu, 11 Oct 2012 14:57:46 +0800 >>>> From: Weijun Wang >>>> >>>> To: discuss at openjdk.java.net >>>> >>>> >>>> >>>> >>>> You can try set ENABLE_FULL_DEBUG_SYMBOLS to 0. >>>> >>>> -Max >>>> >>>> On 10/11/2012 02:38 PM, matchew wrote: >>>> > >>>> > After successful openJDK7 build (Ubuntu 12.04) i have found that >>>> > 'j2sdk-image' has 240MB. More than 100MB belongs to one directory: >>>> > openjdk7/jre/lib/amd64 >>>> > >>>> > Can anyone explain me why it is so big? For example in openJDK7 installed >>>> > via package manager this folder has only 18MB >>>> > >>>> > Is there any way to decrease its size? >>>> > >>>> > Thanks in advance >>>> > -- >>>> > Mateusz >>>> > >>>> >>>> >>>> >>> >> > From david.holmes at oracle.com Fri Oct 12 05:20:57 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 12 Oct 2012 15:20:57 +1000 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: <5076E51B.6000302@oracle.com> References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> <5076DE81.4080608@oracle.com> <5076E20C.7070809@oracle.com> <5076E51B.6000302@oracle.com> Message-ID: <5077A8B9.4010800@oracle.com> >> On 10/11/12 9:09 AM, matchew wrote: >>> Understand. But why still when ENABLE_FULL_DEBUG_SYMBOLS is set >>> to 0 these files are generated? Because you have to set FULL_DEBUG_SYMBOLS=0 when invoking make, not ENABLE_FULL_DEBUG_SYMBOLS=0. From the makefiles: # The Full Debug Symbols (FDS) default for VARIANT == OPT builds is # enabled with debug info files ZIP'ed to save space. For VARIANT != # OPT builds, FDS is always enabled, after all a debug build without # debug info isn't very useful. The ZIP_DEBUGINFO_FILES option only has # meaning when FDS is enabled. # # If you invoke a build with FULL_DEBUG_SYMBOLS=0, then FDS will be # disabled for a VARIANT == OPT build. # # Note: Use of a different variable name for the FDS override option # versus the FDS enabled check is intentional (FULL_DEBUG_SYMBOLS # versus ENABLE_FULL_DEBUG_SYMBOLS). For auto build systems that pass # in options via environment variables, use of distinct variables # prevents strange behaviours. For example, in a VARIANT != OPT build, # the FULL_DEBUG_SYMBOLS environment variable will be 0, but the # ENABLE_FULL_DEBUG_SYMBOLS make variable will be 1. If the same # variable name is used, then different values can be picked up by # different parts of the build. Just to be clear, we only need two # variable names because the incoming option value can be overridden # in some situations, e.g., a VARIANT != OPT build. David ----- >> What type of build are you doing? The ENABLE_FULL_DEBUG_SYMBOLS >> flag only disables the feature for "product bits" builds. For a >> JDK build that is an "OPT" build. For a HotSpot build that is a >> "product" build. >> >> Dan >> >> >>> >>> 2012/10/11 Daniel D. Daugherty >> > >>> >>> On 10/11/12 8:50 AM, matchew wrote: >>>> what about openjdk builds used for example by ubuntu package >>>> manager (default repos)? these builds do not have these >>>> debug files (*.diz) at all. >>> >>> I don't know how Ubuntu builds the OpenJDK repos so I can't >>> really comment on why those builds don't have debug info files. >>> Downstream projects can change the default settings and several >>> of the downstream Linux project have enabled even more debug >>> info in their builds. >>> >>> >>>> If i am not considering jvm/jdk native code debugging is it >>>> safe to just remove them all? >>> >>> It's your build. If you don't think you need the debug info, then >>> you can remove it. >>> >>> Dan >>> >>> >>>> >>>> 2012/10/11 Daniel D. Daugherty >>> > >>>> >>>> On 10/11/12 3:21 AM, Se?n Coffey wrote: >>>>> Moving this off discuss mailing list to build-dev. >>>>> >>>>> Why is ENABLE_FULL_DEBUG_SYMBOLS being set to 1 for >>>>> many product builds now ? It slows down the build and >>>>> creates increased bundle size even though the majority >>>>> of users do not require this functionality. >>>> >>>> The Full Debug Symbols feature will eventually be >>>> enabled for all >>>> OSes for which Oracle generates bits. I think MacOS X is >>>> the last >>>> platform and that work is tracked by: >>>> >>>> 7165611 3/3 implement Full Debug Symbols on MacOS X >>>> >>>> The default setting for ENABLE_FULL_DEBUG_SYMBOLS is "1" >>>> (enabled) >>>> because the Full Debug Symbols feature is intentionally >>>> enabled in >>>> all promoted bits for diagnosibility and debuggability. >>>> If FDS is >>>> not enabled when the promoted bits are built, then the >>>> debug info >>>> generated by a rebuild of *exactly the same source* with >>>> FDS enabled >>>> cannot be (reliably) used with the promoted bits. >>>> >>>> You might be saying: >>>> >>>> That's fine for promoted bits, but what about the >>>> rest of us? >>>> >>>> The answer there is actually simple. We want our >>>> developer private >>>> builds and automated system builds, e.g., JPRT, to match >>>> what Release >>>> Engineering builds. We don't want RE to be surprised by >>>> an integration >>>> that builds fine when FDS is disabled only to blow up >>>> when FDS is >>>> enabled. >>>> >>>> Similarly, we also don't want SQE/SQA to be surprised by >>>> different >>>> test results with bits built by RE versus bits built >>>> with FDS disabled, >>>> e.g., JPRT. Enabling "debug info" in a build changes the >>>> compiler >>>> optimizations and that changes the bits in the binary. >>>> Those changes >>>> in the binary might mask a bug that only shows up after >>>> RE has built >>>> with FDS enabled. Conversely, if you disable FDS in your >>>> private build, >>>> you might end up chasing a bug that only reproduces in >>>> your private >>>> build and doesn't reproduce in an FDS enabled build. >>>> >>>> >>>>> Could we consider flipping the default for >>>>> ENABLE_FULL_DEBUG_SYMBOLS to 0 ? (like I've done for >>>>> all my build scripts?) >>>> >>>> For the reasons I stated above, no we won't change the >>>> default for >>>> ENABLE_FULL_DEBUG_SYMBOLS to "0" (disabled) unless >>>> Oracle changes >>>> the way that promoted bits are built. >>>> >>>> You are welcome to disable the feature in your private >>>> builds which >>>> is why I added the ENABLE_FULL_DEBUG_SYMBOLS flag. >>>> However, please >>>> remember that any testing that you do with those bits >>>> won't necessarily >>>> match testing done with the official promoted bits. >>>> >>>> Dan >>>> >>>> >>>>> >>>>> regards, >>>>> Sean. >>>>> >>>>> -------- Original Message -------- >>>>> Subject: Re: How to decrease size of j2sdk_image >>>>> Date: Thu, 11 Oct 2012 14:57:46 +0800 >>>>> From: Weijun Wang >>>>> >>>>> To: discuss at openjdk.java.net >>>>> >>>>> >>>>> >>>>> >>>>> You can try set ENABLE_FULL_DEBUG_SYMBOLS to 0. >>>>> >>>>> -Max >>>>> >>>>> On 10/11/2012 02:38 PM, matchew wrote: >>>>> > >>>>> > After successful openJDK7 build (Ubuntu 12.04) i have found that >>>>> > 'j2sdk-image' has 240MB. More than 100MB belongs to one directory: >>>>> > openjdk7/jre/lib/amd64 >>>>> > >>>>> > Can anyone explain me why it is so big? For example in openJDK7 >>>>> installed >>>>> > via package manager this folder has only 18MB >>>>> > >>>>> > Is there any way to decrease its size? >>>>> > >>>>> > Thanks in advance >>>>> > -- >>>>> > Mateusz >>>>> > >>>>> >>>>> >>>>> >>>> >>> >> From sean.coffey at oracle.com Fri Oct 12 11:16:57 2012 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Fri, 12 Oct 2012 12:16:57 +0100 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: <5076D928.3030404@oracle.com> References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> Message-ID: <5077FC29.20503@oracle.com> Dan, thanks for the detailed reply. It makes sense to exercise such code where possible. However, I'd also argue that Oracle JDK != OpenJDK. why would openJDK developers get to build FDS by default? - it slows the build and makes bundles bigger. I would imagine most developers don't need the functionality and for the ones that do - they have the FULL_DEBUG_SYMBOLS switch to flip.. JPRT and other internal build systems can activate such a switch easily also. my two cent. regards, Sean. On 11/10/12 15:35, Daniel D. Daugherty wrote: > On 10/11/12 3:21 AM, Se?n Coffey wrote: >> Moving this off discuss mailing list to build-dev. >> >> Why is ENABLE_FULL_DEBUG_SYMBOLS being set to 1 for many product >> builds now ? It slows down the build and creates increased bundle >> size even though the majority of users do not require this functionality. > > The Full Debug Symbols feature will eventually be enabled for all > OSes for which Oracle generates bits. I think MacOS X is the last > platform and that work is tracked by: > > 7165611 3/3 implement Full Debug Symbols on MacOS X > > The default setting for ENABLE_FULL_DEBUG_SYMBOLS is "1" (enabled) > because the Full Debug Symbols feature is intentionally enabled in > all promoted bits for diagnosibility and debuggability. If FDS is > not enabled when the promoted bits are built, then the debug info > generated by a rebuild of *exactly the same source* with FDS enabled > cannot be (reliably) used with the promoted bits. > > You might be saying: > > That's fine for promoted bits, but what about the rest of us? > > The answer there is actually simple. We want our developer private > builds and automated system builds, e.g., JPRT, to match what Release > Engineering builds. We don't want RE to be surprised by an integration > that builds fine when FDS is disabled only to blow up when FDS is > enabled. > > Similarly, we also don't want SQE/SQA to be surprised by different > test results with bits built by RE versus bits built with FDS disabled, > e.g., JPRT. Enabling "debug info" in a build changes the compiler > optimizations and that changes the bits in the binary. Those changes > in the binary might mask a bug that only shows up after RE has built > with FDS enabled. Conversely, if you disable FDS in your private build, > you might end up chasing a bug that only reproduces in your private > build and doesn't reproduce in an FDS enabled build. > > >> Could we consider flipping the default for ENABLE_FULL_DEBUG_SYMBOLS >> to 0 ? (like I've done for all my build scripts?) > > For the reasons I stated above, no we won't change the default for > ENABLE_FULL_DEBUG_SYMBOLS to "0" (disabled) unless Oracle changes > the way that promoted bits are built. > > You are welcome to disable the feature in your private builds which > is why I added the ENABLE_FULL_DEBUG_SYMBOLS flag. However, please > remember that any testing that you do with those bits won't necessarily > match testing done with the official promoted bits. > > Dan > > >> >> regards, >> Sean. >> >> -------- Original Message -------- >> Subject: Re: How to decrease size of j2sdk_image >> Date: Thu, 11 Oct 2012 14:57:46 +0800 >> From: Weijun Wang >> To: discuss at openjdk.java.net >> >> >> >> You can try set ENABLE_FULL_DEBUG_SYMBOLS to 0. >> >> -Max >> >> On 10/11/2012 02:38 PM, matchew wrote: >> > >> > After successful openJDK7 build (Ubuntu 12.04) i have found that >> > 'j2sdk-image' has 240MB. More than 100MB belongs to one directory: >> > openjdk7/jre/lib/amd64 >> > >> > Can anyone explain me why it is so big? For example in openJDK7 installed >> > via package manager this folder has only 18MB >> > >> > Is there any way to decrease its size? >> > >> > Thanks in advance >> > -- >> > Mateusz >> > >> >> >> From erik.joelsson at oracle.com Fri Oct 12 11:30:30 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 12 Oct 2012 13:30:30 +0200 Subject: Review request: Build infra update In-Reply-To: <5072EC8E.9040501@oracle.com> References: <5072EC8E.9040501@oracle.com> Message-ID: <5077FF56.9040502@oracle.com> So far we have reviews from David and Magnus. Could use one more with reviewer status. Kelly, could you start looking into submitting this? /Erik On 2012-10-08 17:09, Erik Joelsson wrote: > After achieving the milestone of equivalent images from the new and > old build, this is a good time to refresh build-infra in jdk8. Here is > a webrev with the proposed changes: > > http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/ > > > Unfortunately the builds will not be as equal in jdk8 as in the > build-infra forest due to bug "JDK-8000518 - Javac generates duplicate > name_and_type constant pool entry for class BinaryOpValueExp.java". > Running the comparison script also takes a very long time because of it. > > /Erik From daniel.daugherty at oracle.com Fri Oct 12 14:45:56 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 12 Oct 2012 08:45:56 -0600 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: <5077A8B9.4010800@oracle.com> References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> <5076DE81.4080608@oracle.com> <5076E20C.7070809@oracle.com> <5076E51B.6000302@oracle.com> <5077A8B9.4010800@oracle.com> Message-ID: <50782D24.6000104@oracle.com> David is right. It is amazing how many times I read right past the fact that the wrong make variable was being used. The right make invocation is: make FULL_DEBUG_SYMBOLS=0 The ENABLE_FULL_DEBUG_SYMBOLS make variable is what is used in the various makefiles to implement the logic checks for the FDS feature. Here is the text from the (currently internal) FDS FAQ: > 8) How do I build without FDS? > > Invoke your build with "FULL_DEBUG_SYMBOLS=0", e.g., with a JPRT > job, use "-buildenv FULL_DEBUG_SYMBOLS=0" on the JPRT submit > command line. That will disable the Full Debug Symbols for > "product" builds (HotSpot) and for "OPT" builds (JDK). > > Some folks have asked how to disable FDS on all builds. Invoke > your build with "ALT_OBJCOPY=/no_such_path", e.g., with a JPRT > job, use "-buildenv ALT_OBJCOPY=/no_such_path" on the JPRT submit > command line. That will disable the Full Debug Symbols for all > Linux and Solaris builds. > > There isn't a way to disable FDS on all Windows builds. > "FULL_DEBUG_SYMBOLS=0" does disable FDS for Windows "product" > builds (HotSpot) and for Windows "OPT" builds (JDK). FDS had been > hard-coded as enabled on Windows since JDK1.4.1 so being able to > disable it for "product" builds was a step forward. > Dan On 10/11/12 11:20 PM, David Holmes wrote: >>> On 10/11/12 9:09 AM, matchew wrote: >>>> Understand. But why still when ENABLE_FULL_DEBUG_SYMBOLS is set >>>> to 0 these files are generated? > > Because you have to set FULL_DEBUG_SYMBOLS=0 when invoking make, not > ENABLE_FULL_DEBUG_SYMBOLS=0. From the makefiles: > > # The Full Debug Symbols (FDS) default for VARIANT == OPT builds is > # enabled with debug info files ZIP'ed to save space. For VARIANT != > # OPT builds, FDS is always enabled, after all a debug build without > # debug info isn't very useful. The ZIP_DEBUGINFO_FILES option only has > # meaning when FDS is enabled. > # > # If you invoke a build with FULL_DEBUG_SYMBOLS=0, then FDS will be > # disabled for a VARIANT == OPT build. > # > # Note: Use of a different variable name for the FDS override option > # versus the FDS enabled check is intentional (FULL_DEBUG_SYMBOLS > # versus ENABLE_FULL_DEBUG_SYMBOLS). For auto build systems that pass > # in options via environment variables, use of distinct variables > # prevents strange behaviours. For example, in a VARIANT != OPT build, > # the FULL_DEBUG_SYMBOLS environment variable will be 0, but the > # ENABLE_FULL_DEBUG_SYMBOLS make variable will be 1. If the same > # variable name is used, then different values can be picked up by > # different parts of the build. Just to be clear, we only need two > # variable names because the incoming option value can be overridden > # in some situations, e.g., a VARIANT != OPT build. > > David > ----- > >>> What type of build are you doing? The ENABLE_FULL_DEBUG_SYMBOLS >>> flag only disables the feature for "product bits" builds. For a >>> JDK build that is an "OPT" build. For a HotSpot build that is a >>> "product" build. >>> >>> Dan >>> >>> >>>> >>>> 2012/10/11 Daniel D. Daugherty >>> > >>>> >>>> On 10/11/12 8:50 AM, matchew wrote: >>>>> what about openjdk builds used for example by ubuntu package >>>>> manager (default repos)? these builds do not have these >>>>> debug files (*.diz) at all. >>>> >>>> I don't know how Ubuntu builds the OpenJDK repos so I can't >>>> really comment on why those builds don't have debug info files. >>>> Downstream projects can change the default settings and several >>>> of the downstream Linux project have enabled even more debug >>>> info in their builds. >>>> >>>> >>>>> If i am not considering jvm/jdk native code debugging is it >>>>> safe to just remove them all? >>>> >>>> It's your build. If you don't think you need the debug info, then >>>> you can remove it. >>>> >>>> Dan >>>> >>>> >>>>> >>>>> 2012/10/11 Daniel D. Daugherty >>>> > >>>>> >>>>> On 10/11/12 3:21 AM, Se?n Coffey wrote: >>>>>> Moving this off discuss mailing list to build-dev. >>>>>> >>>>>> Why is ENABLE_FULL_DEBUG_SYMBOLS being set to 1 for >>>>>> many product builds now ? It slows down the build and >>>>>> creates increased bundle size even though the majority >>>>>> of users do not require this functionality. >>>>> >>>>> The Full Debug Symbols feature will eventually be >>>>> enabled for all >>>>> OSes for which Oracle generates bits. I think MacOS X is >>>>> the last >>>>> platform and that work is tracked by: >>>>> >>>>> 7165611 3/3 implement Full Debug Symbols on MacOS X >>>>> >>>>> The default setting for ENABLE_FULL_DEBUG_SYMBOLS is "1" >>>>> (enabled) >>>>> because the Full Debug Symbols feature is intentionally >>>>> enabled in >>>>> all promoted bits for diagnosibility and debuggability. >>>>> If FDS is >>>>> not enabled when the promoted bits are built, then the >>>>> debug info >>>>> generated by a rebuild of *exactly the same source* with >>>>> FDS enabled >>>>> cannot be (reliably) used with the promoted bits. >>>>> >>>>> You might be saying: >>>>> >>>>> That's fine for promoted bits, but what about the >>>>> rest of us? >>>>> >>>>> The answer there is actually simple. We want our >>>>> developer private >>>>> builds and automated system builds, e.g., JPRT, to match >>>>> what Release >>>>> Engineering builds. We don't want RE to be surprised by >>>>> an integration >>>>> that builds fine when FDS is disabled only to blow up >>>>> when FDS is >>>>> enabled. >>>>> >>>>> Similarly, we also don't want SQE/SQA to be surprised by >>>>> different >>>>> test results with bits built by RE versus bits built >>>>> with FDS disabled, >>>>> e.g., JPRT. Enabling "debug info" in a build changes the >>>>> compiler >>>>> optimizations and that changes the bits in the binary. >>>>> Those changes >>>>> in the binary might mask a bug that only shows up after >>>>> RE has built >>>>> with FDS enabled. Conversely, if you disable FDS in your >>>>> private build, >>>>> you might end up chasing a bug that only reproduces in >>>>> your private >>>>> build and doesn't reproduce in an FDS enabled build. >>>>> >>>>> >>>>>> Could we consider flipping the default for >>>>>> ENABLE_FULL_DEBUG_SYMBOLS to 0 ? (like I've done for >>>>>> all my build scripts?) >>>>> >>>>> For the reasons I stated above, no we won't change the >>>>> default for >>>>> ENABLE_FULL_DEBUG_SYMBOLS to "0" (disabled) unless >>>>> Oracle changes >>>>> the way that promoted bits are built. >>>>> >>>>> You are welcome to disable the feature in your private >>>>> builds which >>>>> is why I added the ENABLE_FULL_DEBUG_SYMBOLS flag. >>>>> However, please >>>>> remember that any testing that you do with those bits >>>>> won't necessarily >>>>> match testing done with the official promoted bits. >>>>> >>>>> Dan >>>>> >>>>> >>>>>> >>>>>> regards, >>>>>> Sean. >>>>>> >>>>>> -------- Original Message -------- >>>>>> Subject: Re: How to decrease size of j2sdk_image >>>>>> Date: Thu, 11 Oct 2012 14:57:46 +0800 >>>>>> From: Weijun Wang >>>>>> >>>>>> To: discuss at openjdk.java.net >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> You can try set ENABLE_FULL_DEBUG_SYMBOLS to 0. >>>>>> >>>>>> -Max >>>>>> >>>>>> On 10/11/2012 02:38 PM, matchew wrote: >>>>>> > >>>>>> > After successful openJDK7 build (Ubuntu 12.04) i have found that >>>>>> > 'j2sdk-image' has 240MB. More than 100MB belongs to one directory: >>>>>> > openjdk7/jre/lib/amd64 >>>>>> > >>>>>> > Can anyone explain me why it is so big? For example in openJDK7 >>>>>> installed >>>>>> > via package manager this folder has only 18MB >>>>>> > >>>>>> > Is there any way to decrease its size? >>>>>> > >>>>>> > Thanks in advance >>>>>> > -- >>>>>> > Mateusz >>>>>> > >>>>>> >>>>>> >>>>>> >>>>> >>>> >>> From jonathan.gibbons at oracle.com Fri Oct 12 15:17:43 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 12 Oct 2012 08:17:43 -0700 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: <50782D24.6000104@oracle.com> References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> <5076DE81.4080608@oracle.com> <5076E20C.7070809@oracle.com> <5076E51B.6000302@oracle.com> <5077A8B9.4010800@oracle.com> <50782D24.6000104@oracle.com> Message-ID: <50783497.6010100@oracle.com> Is there, should there be a FAQ for the new build, along the lines of a series of "How do I ..." questions? -- Jon From Kelly.Ohair at oracle.com Fri Oct 12 15:29:12 2012 From: Kelly.Ohair at oracle.com (Kelly O'Hair) Date: Fri, 12 Oct 2012 08:29:12 -0700 Subject: Review request: Build infra update In-Reply-To: <5077FF56.9040502@oracle.com> References: <5072EC8E.9040501@oracle.com> <5077FF56.9040502@oracle.com> Message-ID: <744B89E8-A78B-499E-B6ED-82AFB44A8E05@oracle.com> I'll see what I can do. I've almost crawled out from under the email pile, down to 500 emails... -kto On Oct 12, 2012, at 4:30 AM, Erik Joelsson wrote: > So far we have reviews from David and Magnus. Could use one more with reviewer status. Kelly, could you start looking into submitting this? > > /Erik > > On 2012-10-08 17:09, Erik Joelsson wrote: >> After achieving the milestone of equivalent images from the new and old build, this is a good time to refresh build-infra in jdk8. Here is a webrev with the proposed changes: >> >> http://cr.openjdk.java.net/~erikj/build-infra5/webrev.01/ >> >> Unfortunately the builds will not be as equal in jdk8 as in the build-infra forest due to bug "JDK-8000518 - Javac generates duplicate name_and_type constant pool entry for class BinaryOpValueExp.java". Running the comparison script also takes a very long time because of it. >> >> /Erik From tim.bell at oracle.com Fri Oct 12 15:39:51 2012 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 12 Oct 2012 08:39:51 -0700 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: <50783497.6010100@oracle.com> References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> <5076DE81.4080608@oracle.com> <5076E20C.7070809@oracle.com> <5076E51B.6000302@oracle.com> <5077A8B9.4010800@oracle.com> <50782D24.6000104@oracle.com> <50783497.6010100@oracle.com> Message-ID: <507839C7.7080903@oracle.com> Hi Jon: > Is there, should there be a FAQ for the new build, along the lines of > a series of "How do I ..." questions? > > -- Jon Have you been through "README for the New Build System"? http://openjdk.java.net/projects/build-infra/guide.html Section 9 of that doc is a FAQ. We can certainly update the page if useful information is lacking there. Please let us know. Tim From aph at redhat.com Fri Oct 12 15:43:00 2012 From: aph at redhat.com (Andrew Haley) Date: Fri, 12 Oct 2012 08:43:00 -0700 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: <5077FC29.20503@oracle.com> References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> <5077FC29.20503@oracle.com> Message-ID: <50783A84.8020203@redhat.com> On 10/12/2012 04:16 AM, Se?n Coffey wrote: > thanks for the detailed reply. It makes sense to exercise such code > where possible. > > However, I'd also argue that Oracle JDK != OpenJDK. > > why would openJDK developers get to build FDS by default? - it slows the > build and makes bundles bigger. I would imagine most developers don't > need the functionality and for the ones that do - they have the > FULL_DEBUG_SYMBOLS switch to flip.. Just to explain how we work, and perhaps make it easier to understand what we do: In the GNU & Linux world we always build everything with full debug symbols. We always put debug info into separate bundles, so it makes no difference to the size of the packages. (Full debuginfo is required by distro policies.) Build time for HotSpot doesn't much matter because we're usually doing incremental builds when working on HotSpot itself, and if we're building all of OpenJDK it's not a huge difference. If we are working on HotSpot, we need full debuginfo because without it GDB doesn't work well. All of our engineers expect to be able to debug any package, whoever built it, if needs be. Andrew. From jonathan.gibbons at oracle.com Fri Oct 12 16:00:18 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 12 Oct 2012 09:00:18 -0700 Subject: Fwd: Re: How to decrease size of j2sdk_image In-Reply-To: <507839C7.7080903@oracle.com> References: <50766DEA.2000108@oracle.com> <50768FA7.9060100@oracle.com> <5076D928.3030404@oracle.com> <5076DE81.4080608@oracle.com> <5076E20C.7070809@oracle.com> <5076E51B.6000302@oracle.com> <5077A8B9.4010800@oracle.com> <50782D24.6000104@oracle.com> <50783497.6010100@oracle.com> <507839C7.7080903@oracle.com> Message-ID: <50783E92.2050504@oracle.com> Tim, Thanks, I haven't visited that page in a while and the info there is certainly helpful. Section 10 is also useful. I notice that some of the info is out of date (like refs to VERBOSE in FAQ, and "SKIP_BOOT_CYCLE not supported in new build" in Cheat Sheet.) I guess with the recent messages to the list of the form, "how do I..." it would be worth checking to see if the answer is RTFM, and updating the FM manual as needed :-) -- Jon On 10/12/2012 08:39 AM, Tim Bell wrote: > Hi Jon: > >> Is there, should there be a FAQ for the new build, along the lines of >> a series of "How do I ..." questions? >> >> -- Jon > > Have you been through "README for the New Build System"? > > http://openjdk.java.net/projects/build-infra/guide.html > > Section 9 of that doc is a FAQ. > > We can certainly update the page if useful information is lacking > there. Please let us know. > > Tim > From steve.sides at oracle.com Fri Oct 12 17:58:40 2012 From: steve.sides at oracle.com (Steve Sides) Date: Fri, 12 Oct 2012 10:58:40 -0700 Subject: Heads up: large sets of copyright year updates going into jdk8/tl/jdk Message-ID: <50785A50.9090407@oracle.com> Hi All, This is a heads up notice, all files in jdk repositories which have been updated in 2012, and have not had the copyright year updated, are now doing so. All other repositories have completed this chore and we've saved this largest for last. Individually, each of these changes is trivial to update the copyright year in the copyright header, however, there are many of them. A first push to jdk8/tl over the weekend will update 2000+ files. Once this is in master and down in jdk8/awt, the script will run again to update the remaining 1000 or so files. Once these first large pushes are completed, periodic updates through til GA should be of a much smaller size and much easier to deal with. -steve From kelly.ohair at oracle.com Mon Oct 15 17:59:13 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 15 Oct 2012 10:59:13 -0700 Subject: [8] Review request for 8000693 Move jdk.tbom from jdk/make/closed to jdk repository In-Reply-To: <507602E7.1080405@oracle.com> References: <507602E7.1080405@oracle.com> Message-ID: On Oct 10, 2012, at 4:21 PM, Michael Fang wrote: > Hi Build dev team, > > This was originally submitted as 7196354 check-in jdk.tbom file to openjdk repo, but the file was checked in to the closedjdk repository. > > The automated translation drop system handles penjdk and closedjdk resource files separately as 2 different components. Having jdk.tbom file in closedjdk repository caused the system to not generate the translation drop for openjdk files. Therefore, I need to move the file to jdk repository under jdk/make. > > The webrev can be found here: http://cr.openjdk.java.net/~mfang/8000693/webrev.00/ > > Could you please let me know if you have concern about the move? The file itself has not been touched. > > Thanks! > > -michael I agree with Mark on this, I do not want to see this file in the openjdk repos. Please contact me so we can discuss other solutions. -kto From michael.fang at oracle.com Mon Oct 15 18:08:41 2012 From: michael.fang at oracle.com (Michael Fang) Date: Mon, 15 Oct 2012 11:08:41 -0700 Subject: [8] Review request for 8000693 Move jdk.tbom from jdk/make/closed to jdk repository In-Reply-To: References: <507602E7.1080405@oracle.com> Message-ID: <507C5129.1020309@oracle.com> Thanks Kelly for the comment. I am working with our team and management to figure out what else we can do to support localization without this file. -michael On 12?10?15? 10:59 ??, Kelly O'Hair wrote: > On Oct 10, 2012, at 4:21 PM, Michael Fang wrote: > >> Hi Build dev team, >> >> This was originally submitted as 7196354 check-in jdk.tbom file to openjdk repo, but the file was checked in to the closedjdk repository. >> >> The automated translation drop system handles penjdk and closedjdk resource files separately as 2 different components. Having jdk.tbom file in closedjdk repository caused the system to not generate the translation drop for openjdk files. Therefore, I need to move the file to jdk repository under jdk/make. >> >> The webrev can be found here: http://cr.openjdk.java.net/~mfang/8000693/webrev.00/ >> >> Could you please let me know if you have concern about the move? The file itself has not been touched. >> >> Thanks! >> >> -michael > I agree with Mark on this, I do not want to see this file in the openjdk repos. > > Please contact me so we can discuss other solutions. > > -kto > From philip.race at oracle.com Wed Oct 17 16:18:55 2012 From: philip.race at oracle.com (Phil Race) Date: Wed, 17 Oct 2012 09:18:55 -0700 Subject: Request for review : FreeType embedded in OSX packages In-Reply-To: References: Message-ID: <507EDA6F.9090304@oracle.com> On 10/17/12 1:11 AM, Henri Gomez wrote: >> You need to create a bug at describing what you want to change, and then attach a new patch. Mike's review plus one other will be enough to get it into JDK 8. JDK 7u will need two reviewers, since I think the Java2D team owns this part of the code. (I cc'd Phil Race). > Ticket created : #2361569 > > Link to patches provided inside What number is that ? I think its just an incident. I will file a JIRA bug on this shortly .. but I had tried the patch yesterday and FWIW it doesn't seem to remove "build" dependency on the system libfreetype .. I don't think anything you did caused this because it would already fail for me in the sanity check at the beginning but a complete fix would address this too where it seems the ALT_ path is not making it through to tools/freetypecheck/Makefile dyld: Library not loaded: /usr/local/lib/libfreetype.6.dylib Referenced from: /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck Reason: image not found make[2]: *** [all] Trace/BPT trap: 5 .. .. ERROR: FreeType version 2.3.0 or higher is required. /bin/mkdir -p /openjdk8/2d/build/macosx-x86_64/btbins rm -f /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck Failed to build freetypecheck. Exiting because of the above error(s). ----- Also did you try this in the old and new build systems ? Finally, the way we build internally I guess our jprt and R/E builds of openjdk on OS X (if the latter were tried at all) should be made capable of using a custom freetype build. I think they can be ignorant of this change for now, but without creating a build and making them use it they will still spit out builds which rely on the system freetype -phil. From philip.race at oracle.com Wed Oct 17 16:27:51 2012 From: philip.race at oracle.com (Phil Race) Date: Wed, 17 Oct 2012 09:27:51 -0700 Subject: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages In-Reply-To: <507EDA6F.9090304@oracle.com> References: <507EDA6F.9090304@oracle.com> Message-ID: <507EDC87.5060505@oracle.com> PS .. I could be misremembering or misunderstanding but the other obstacle I ran into when I looked at this (ages ago) was that the freetype I built was expecting to be installed in a specific location. I didn't think it was enough to tell the JDK build to look for the freetype lib, it seemed that the freetype.dylib was fussy about where it was placed. Could you also check that your build works and really loads *your* version of the lib - try using a Postscript Type 1 font via Font.createFont(), that should trigger it. -phil. On 10/17/12 9:18 AM, Phil Race wrote: > On 10/17/12 1:11 AM, Henri Gomez wrote: >>> You need to create a bug at >>> describing what you want to change, and then attach a new patch. >>> Mike's review plus one other will be enough to get it into JDK 8. >>> JDK 7u will need two reviewers, since I think the Java2D team owns >>> this part of the code. (I cc'd Phil Race). >> Ticket created : #2361569 >> >> Link to patches provided inside > > What number is that ? I think its just an incident. I will file a JIRA > bug > on this shortly .. but I had tried the patch yesterday and FWIW it > doesn't > seem to remove "build" dependency on the system libfreetype .. > I don't think anything you did caused this because it would already fail > for me in the sanity check at the beginning but a complete fix would > address this too where it seems the ALT_ path is not making it through > to tools/freetypecheck/Makefile > > dyld: Library not loaded: /usr/local/lib/libfreetype.6.dylib > Referenced from: > /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck > Reason: image not found > make[2]: *** [all] Trace/BPT trap: 5 > .. > .. > ERROR: FreeType version 2.3.0 or higher is required. > /bin/mkdir -p /openjdk8/2d/build/macosx-x86_64/btbins > rm -f /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck > /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck > Failed to build freetypecheck. > > Exiting because of the above error(s). > ----- > > Also did you try this in the old and new build systems ? > > Finally, the way we build internally I guess our jprt and R/E builds of > openjdk on OS X (if the latter were tried at all) should be made capable > of using a custom freetype build. I think they can be ignorant of > this change for now, but without creating a build and making them use > it they will still spit out builds which rely on the system freetype > > -phil. > > From henri.gomez at gmail.com Wed Oct 17 17:30:22 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Wed, 17 Oct 2012 19:30:22 +0200 Subject: Request for review : FreeType embedded in OSX packages In-Reply-To: <507EDA6F.9090304@oracle.com> References: <507EDA6F.9090304@oracle.com> Message-ID: <23CFCEDD-6939-4A58-A9DF-6CA59857C1CF@gmail.com> Only tried it with old build system. Le 17 oct. 2012 ? 18:18, Phil Race a ?crit : > On 10/17/12 1:11 AM, Henri Gomez wrote: >>> You need to create a bug at describing what you want to change, and then attach a new patch. Mike's review plus one other will be enough to get it into JDK 8. JDK 7u will need two reviewers, since I think the Java2D team owns this part of the code. (I cc'd Phil Race). >> Ticket created : #2361569 >> >> Link to patches provided inside > > What number is that ? I think its just an incident. I will file a JIRA bug > on this shortly .. but I had tried the patch yesterday and FWIW it doesn't > seem to remove "build" dependency on the system libfreetype .. > I don't think anything you did caused this because it would already fail > for me in the sanity check at the beginning but a complete fix would > address this too where it seems the ALT_ path is not making it through > to tools/freetypecheck/Makefile > > dyld: Library not loaded: /usr/local/lib/libfreetype.6.dylib > Referenced from: /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck > Reason: image not found > make[2]: *** [all] Trace/BPT trap: 5 > .. > .. > ERROR: FreeType version 2.3.0 or higher is required. > /bin/mkdir -p /openjdk8/2d/build/macosx-x86_64/btbins > rm -f /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck > /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck > Failed to build freetypecheck. > > Exiting because of the above error(s). > ----- > > Also did you try this in the old and new build systems ? > > Finally, the way we build internally I guess our jprt and R/E builds of > openjdk on OS X (if the latter were tried at all) should be made capable > of using a custom freetype build. I think they can be ignorant of > this change for now, but without creating a build and making them use > it they will still spit out builds which rely on the system freetype > > -phil. > > From henri.gomez at gmail.com Wed Oct 17 17:31:07 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Wed, 17 Oct 2012 19:31:07 +0200 Subject: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages In-Reply-To: <507EDC87.5060505@oracle.com> References: <507EDA6F.9090304@oracle.com> <507EDC87.5060505@oracle.com> Message-ID: Any sample java code available ? Le 17 oct. 2012 ? 18:27, Phil Race a ?crit : > PS .. I could be misremembering or misunderstanding but the other > obstacle I ran into when I looked at this (ages ago) was that the freetype > I built was expecting to be installed in a specific location. I didn't > think it was enough to tell the JDK build to look for the freetype lib, > it seemed that the freetype.dylib was fussy about where it was placed. > Could you also check that your build works and really loads *your* > version of the lib - try using a Postscript Type 1 font via Font.createFont(), > that should trigger it. > > -phil. > > On 10/17/12 9:18 AM, Phil Race wrote: >> On 10/17/12 1:11 AM, Henri Gomez wrote: >>>> You need to create a bug at describing what you want to change, and then attach a new patch. Mike's review plus one other will be enough to get it into JDK 8. JDK 7u will need two reviewers, since I think the Java2D team owns this part of the code. (I cc'd Phil Race). >>> Ticket created : #2361569 >>> >>> Link to patches provided inside >> >> What number is that ? I think its just an incident. I will file a JIRA bug >> on this shortly .. but I had tried the patch yesterday and FWIW it doesn't >> seem to remove "build" dependency on the system libfreetype .. >> I don't think anything you did caused this because it would already fail >> for me in the sanity check at the beginning but a complete fix would >> address this too where it seems the ALT_ path is not making it through >> to tools/freetypecheck/Makefile >> >> dyld: Library not loaded: /usr/local/lib/libfreetype.6.dylib >> Referenced from: /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck >> Reason: image not found >> make[2]: *** [all] Trace/BPT trap: 5 >> .. >> .. >> ERROR: FreeType version 2.3.0 or higher is required. >> /bin/mkdir -p /openjdk8/2d/build/macosx-x86_64/btbins >> rm -f /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck >> /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck >> Failed to build freetypecheck. >> >> Exiting because of the above error(s). >> ----- >> >> Also did you try this in the old and new build systems ? >> >> Finally, the way we build internally I guess our jprt and R/E builds of >> openjdk on OS X (if the latter were tried at all) should be made capable >> of using a custom freetype build. I think they can be ignorant of >> this change for now, but without creating a build and making them use >> it they will still spit out builds which rely on the system freetype >> >> -phil. > From philip.race at oracle.com Wed Oct 17 17:40:43 2012 From: philip.race at oracle.com (Phil Race) Date: Wed, 17 Oct 2012 10:40:43 -0700 Subject: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages In-Reply-To: References: <507EDA6F.9090304@oracle.com> <507EDC87.5060505@oracle.com> Message-ID: <507EED9B.8040706@oracle.com> I filed : (JDK-8001065) [macosx] OpenJDK on OS X should use bundled freetype, not one from the system Sample code is just import java.awt.Font; public class CreateFont { public static void main(String args[]) throws Exception { Font f = Font.createFont(Font|.TYPE1_FONT, new java.io.File("mytype1font.pfa")); } } You can get a font from ||| any of a gazillion places .. there'll be plenty on almost any Linux you have handy. -phil. On 10/17/2012 10:31 AM, Henri Gomez wrote: > Any sample java code available ? > > Le 17 oct. 2012 ? 18:27, Phil Race a ?crit : > >> PS .. I could be misremembering or misunderstanding but the other >> obstacle I ran into when I looked at this (ages ago) was that the freetype >> I built was expecting to be installed in a specific location. I didn't >> think it was enough to tell the JDK build to look for the freetype lib, >> it seemed that the freetype.dylib was fussy about where it was placed. >> Could you also check that your build works and really loads *your* >> version of the lib - try using a Postscript Type 1 font via Font.createFont(), >> that should trigger it. >> >> -phil. >> >> On 10/17/12 9:18 AM, Phil Race wrote: >>> On 10/17/12 1:11 AM, Henri Gomez wrote: >>>>> You need to create a bug at describing what you want to change, and then attach a new patch. Mike's review plus one other will be enough to get it into JDK 8. JDK 7u will need two reviewers, since I think the Java2D team owns this part of the code. (I cc'd Phil Race). >>>> Ticket created : #2361569 >>>> >>>> Link to patches provided inside >>> What number is that ? I think its just an incident. I will file a JIRA bug >>> on this shortly .. but I had tried the patch yesterday and FWIW it doesn't >>> seem to remove "build" dependency on the system libfreetype .. >>> I don't think anything you did caused this because it would already fail >>> for me in the sanity check at the beginning but a complete fix would >>> address this too where it seems the ALT_ path is not making it through >>> to tools/freetypecheck/Makefile >>> >>> dyld: Library not loaded: /usr/local/lib/libfreetype.6.dylib >>> Referenced from: /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck >>> Reason: image not found >>> make[2]: *** [all] Trace/BPT trap: 5 >>> .. >>> .. >>> ERROR: FreeType version 2.3.0 or higher is required. >>> /bin/mkdir -p /openjdk8/2d/build/macosx-x86_64/btbins >>> rm -f /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck >>> /openjdk8/2d/build/macosx-x86_64/btbins/freetype_versioncheck >>> Failed to build freetypecheck. >>> >>> Exiting because of the above error(s). >>> ----- >>> >>> Also did you try this in the old and new build systems ? >>> >>> Finally, the way we build internally I guess our jprt and R/E builds of >>> openjdk on OS X (if the latter were tried at all) should be made capable >>> of using a custom freetype build. I think they can be ignorant of >>> this change for now, but without creating a build and making them use >>> it they will still spit out builds which rely on the system freetype >>> >>> -phil. From mandy.chung at oracle.com Wed Oct 17 18:11:23 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 17 Oct 2012 11:11:23 -0700 Subject: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false Message-ID: <507EF4CB.90103@oracle.com> I need a reviewer to fix this build problem that only affects partial build. make/common/internal/Defs-jaxws.gmk maintains an explicit list of JAXWS packages to import from a JDK for a partial JDK. However, the list was not up-to-date and missing some JAXWS classes. You can reproduce the problem by doing SKIP_CYCLE_BUILD=false BUILD_JAXWS=false and got this exception: Exception in thread "main" java.lang.NoClassDefFoundError: com/sun/istack/internal/FinalArrayList The fix is to add the missing packages to the list: diff --git a/make/common/internal/Defs-jaxws.gmk b/make/common/internal/Defs-jaxws.gmk --- a/make/common/internal/Defs-jaxws.gmk +++ b/make/common/internal/Defs-jaxws.gmk @@ -34,6 +34,10 @@ javax/xml/ws \ javax/jws \ javax/annotation \ + com/sun/org/glassfish \ + com/sun/istack/internal \ + com/sun/istack/internal/localization \ + com/sun/istack/internal/logging \ com/sun/xml/internal/bind \ com/sun/xml/internal/fastinfoset \ com/sun/xml/internal/messaging \ Thanks Mandy From henri.gomez at gmail.com Wed Oct 17 18:27:04 2012 From: henri.gomez at gmail.com (Henri Gomez) Date: Wed, 17 Oct 2012 20:27:04 +0200 Subject: [OpenJDK 2D-Dev] Request for review : FreeType embedded in OSX packages In-Reply-To: <507EED9B.8040706@oracle.com> References: <507EDA6F.9090304@oracle.com> <507EDC87.5060505@oracle.com> <507EED9B.8040706@oracle.com> Message-ID: 2012/10/17 Phil Race : > I filed : (JDK-8001065) [macosx] OpenJDK on OS X should use bundled > freetype, not one from the system > > Sample code is just > > import java.awt.Font; > public class CreateFont { > > public static void main(String args[]) throws Exception { > Font f = Font.createFont(Font|.TYPE1_FONT, new > java.io.File("mytype1font.pfa")); > } > } > > > You can get a font from ||| > any > of a gazillion places .. there'll be plenty > on almost any Linux you have handy. I tried with a .pfb file, from http://www.ctan.org/tex-archive/fonts/ and its works with Java 7u9, OpenJDK 7 and OpenJDK 8. From kelly.ohair at oracle.com Wed Oct 17 18:29:19 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 17 Oct 2012 11:29:19 -0700 Subject: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false In-Reply-To: <507EF4CB.90103@oracle.com> References: <507EF4CB.90103@oracle.com> Message-ID: Looks ok to me. Did you plan on integrating it into jdk8/build? -kto On Oct 17, 2012, at 11:11 AM, Mandy Chung wrote: > I need a reviewer to fix this build problem that only affects partial build. > > make/common/internal/Defs-jaxws.gmk maintains an explicit list of > JAXWS packages to import from a JDK for a partial JDK. However, > the list was not up-to-date and missing some JAXWS classes. You can > reproduce the problem by doing SKIP_CYCLE_BUILD=false BUILD_JAXWS=false > and got this exception: > > Exception in thread "main" java.lang.NoClassDefFoundError: com/sun/istack/internal/FinalArrayList > > The fix is to add the missing packages to the list: > > diff --git a/make/common/internal/Defs-jaxws.gmk b/make/common/internal/Defs-jaxws.gmk > --- a/make/common/internal/Defs-jaxws.gmk > +++ b/make/common/internal/Defs-jaxws.gmk > @@ -34,6 +34,10 @@ > javax/xml/ws \ > javax/jws \ > javax/annotation \ > + com/sun/org/glassfish \ > + com/sun/istack/internal \ > + com/sun/istack/internal/localization \ > + com/sun/istack/internal/logging \ > com/sun/xml/internal/bind \ > com/sun/xml/internal/fastinfoset \ > com/sun/xml/internal/messaging \ > > Thanks > Mandy > From mandy.chung at oracle.com Wed Oct 17 18:33:28 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 17 Oct 2012 11:33:28 -0700 Subject: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false In-Reply-To: References: <507EF4CB.90103@oracle.com> Message-ID: <507EF9F8.4040101@oracle.com> On 10/17/2012 11:29 AM, Kelly O'Hair wrote: > Looks ok to me. Did you plan on integrating it into jdk8/build? I can do that. Thanks for reminding me - my local repo is a clone of jdk8/tl. Mandy > -kto > > On Oct 17, 2012, at 11:11 AM, Mandy Chung wrote: > >> I need a reviewer to fix this build problem that only affects partial build. >> >> make/common/internal/Defs-jaxws.gmk maintains an explicit list of >> JAXWS packages to import from a JDK for a partial JDK. However, >> the list was not up-to-date and missing some JAXWS classes. You can >> reproduce the problem by doing SKIP_CYCLE_BUILD=false BUILD_JAXWS=false >> and got this exception: >> >> Exception in thread "main" java.lang.NoClassDefFoundError: com/sun/istack/internal/FinalArrayList >> >> The fix is to add the missing packages to the list: >> >> diff --git a/make/common/internal/Defs-jaxws.gmk b/make/common/internal/Defs-jaxws.gmk >> --- a/make/common/internal/Defs-jaxws.gmk >> +++ b/make/common/internal/Defs-jaxws.gmk >> @@ -34,6 +34,10 @@ >> javax/xml/ws \ >> javax/jws \ >> javax/annotation \ >> + com/sun/org/glassfish \ >> + com/sun/istack/internal \ >> + com/sun/istack/internal/localization \ >> + com/sun/istack/internal/logging \ >> com/sun/xml/internal/bind \ >> com/sun/xml/internal/fastinfoset \ >> com/sun/xml/internal/messaging \ >> >> Thanks >> Mandy >> From Alan.Bateman at oracle.com Wed Oct 17 18:36:54 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 17 Oct 2012 19:36:54 +0100 Subject: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false In-Reply-To: <507EF4CB.90103@oracle.com> References: <507EF4CB.90103@oracle.com> Message-ID: <507EFAC6.4060904@oracle.com> On 17/10/2012 19:11, Mandy Chung wrote: > I need a reviewer to fix this build problem that only affects partial > build. > > make/common/internal/Defs-jaxws.gmk maintains an explicit list of > JAXWS packages to import from a JDK for a partial JDK. However, > the list was not up-to-date and missing some JAXWS classes. You can > reproduce the problem by doing SKIP_CYCLE_BUILD=false BUILD_JAXWS=false > and got this exception: > > Exception in thread "main" java.lang.NoClassDefFoundError: > com/sun/istack/internal/FinalArrayList > > The fix is to add the missing packages to the list: > > diff --git a/make/common/internal/Defs-jaxws.gmk > b/make/common/internal/Defs-jaxws.gmk > --- a/make/common/internal/Defs-jaxws.gmk > +++ b/make/common/internal/Defs-jaxws.gmk > @@ -34,6 +34,10 @@ > javax/xml/ws \ > javax/jws \ > javax/annotation \ > + com/sun/org/glassfish \ > + com/sun/istack/internal \ > + com/sun/istack/internal/localization \ > + com/sun/istack/internal/logging \ > com/sun/xml/internal/bind \ > com/sun/xml/internal/fastinfoset \ > com/sun/xml/internal/messaging \ I've run it into several times, the stack trace when running tests is typically: Exception in thread "main" java.lang.NoClassDefFoundError: com/sun/istack/internal/Pool$Impl at com.sun.xml.internal.bind.v2.runtime.JAXBContextImpl.(JAXBContextImpl.java:171) at com.sun.xml.internal.bind.v2.runtime.JAXBContextImpl.(JAXBContextImpl.java:126) at com.sun.xml.internal.bind.v2.runtime.JAXBContextImpl$JAXBContextBuilder.build(JAXBContextImpl.java:1148) at com.sun.xml.internal.bind.v2.ContextFactory.createContext(ContextFactory.java:130) The proposed fix looks fine to me and helps until we transition to the new build (where partial builds as we know them go away). -Alan From Alan.Bateman at oracle.com Wed Oct 17 18:44:26 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 17 Oct 2012 19:44:26 +0100 Subject: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false In-Reply-To: <507EF9F8.4040101@oracle.com> References: <507EF4CB.90103@oracle.com> <507EF9F8.4040101@oracle.com> Message-ID: <507EFC8A.7070809@oracle.com> On 17/10/2012 19:33, Mandy Chung wrote: > On 10/17/2012 11:29 AM, Kelly O'Hair wrote: >> Looks ok to me. Did you plan on integrating it into jdk8/build? > > I can do that. Thanks for reminding me - my local repo is a clone of > jdk8/tl. It probably doesn't matter if this goes in via jdk8/tl. -Alan. From kelly.ohair at oracle.com Wed Oct 17 18:53:52 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 17 Oct 2012 11:53:52 -0700 Subject: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false In-Reply-To: <507EFC8A.7070809@oracle.com> References: <507EF4CB.90103@oracle.com> <507EF9F8.4040101@oracle.com> <507EFC8A.7070809@oracle.com> Message-ID: <6C38FAD8-4686-4194-B210-AEEFD8129337@oracle.com> On Oct 17, 2012, at 11:44 AM, Alan Bateman wrote: > On 17/10/2012 19:33, Mandy Chung wrote: >> On 10/17/2012 11:29 AM, Kelly O'Hair wrote: >>> Looks ok to me. Did you plan on integrating it into jdk8/build? >> >> I can do that. Thanks for reminding me - my local repo is a clone of jdk8/tl. > It probably doesn't matter if this goes in via jdk8/tl. True. -kto > > -Alan. From mandy.chung at oracle.com Wed Oct 17 19:10:13 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 17 Oct 2012 12:10:13 -0700 Subject: Review request for 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false In-Reply-To: <6C38FAD8-4686-4194-B210-AEEFD8129337@oracle.com> References: <507EF4CB.90103@oracle.com> <507EF9F8.4040101@oracle.com> <507EFC8A.7070809@oracle.com> <6C38FAD8-4686-4194-B210-AEEFD8129337@oracle.com> Message-ID: <507F0295.3060708@oracle.com> On 10/17/2012 11:53 AM, Kelly O'Hair wrote: > On Oct 17, 2012, at 11:44 AM, Alan Bateman wrote: > >> On 17/10/2012 19:33, Mandy Chung wrote: >>> On 10/17/2012 11:29 AM, Kelly O'Hair wrote: >>>> Looks ok to me. Did you plan on integrating it into jdk8/build? >>> I can do that. Thanks for reminding me - my local repo is a clone of jdk8/tl. >> It probably doesn't matter if this goes in via jdk8/tl. > True. I just pushed it to jdk8/tl. Most of the build changes are for the new build-infra work. This change is in the old build system and so it doesn't matter :) Thanks. Mandy From david.katleman at oracle.com Wed Oct 17 22:07:11 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 17 Oct 2012 22:07:11 +0000 Subject: hg: jdk8/build: Added tag jdk8-b60 for changeset e07f499b9dcc Message-ID: <20121017220711.6384F473F9@hg.openjdk.java.net> Changeset: 20ff117b5090 Author: katleman Date: 2012-10-11 09:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/20ff117b5090 Added tag jdk8-b60 for changeset e07f499b9dcc ! .hgtags From david.katleman at oracle.com Wed Oct 17 22:07:14 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 17 Oct 2012 22:07:14 +0000 Subject: hg: jdk8/build/corba: 4 new changesets Message-ID: <20121017220718.138D7473FA@hg.openjdk.java.net> Changeset: 41bb9e606efd Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/41bb9e606efd Added tag jdk8-b60 for changeset 207ef43ba69e ! .hgtags Changeset: 27d87f0031bf Author: alanb Date: 2012-10-05 15:08 +0100 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/27d87f0031bf 7195779: javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently, NPE in tie class Reviewed-by: alanb, coffeys Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/sun/rmi/rmic/iiop/StubGenerator.java Changeset: d9c1dab1515b Author: lana Date: 2012-10-08 15:38 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/d9c1dab1515b Merge Changeset: 0e08ba7648fb Author: lana Date: 2012-10-11 16:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/0e08ba7648fb Merge From david.katleman at oracle.com Wed Oct 17 22:10:25 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 17 Oct 2012 22:10:25 +0000 Subject: hg: jdk8/build/hotspot: 31 new changesets Message-ID: <20121017221126.0B67A473FC@hg.openjdk.java.net> Changeset: 0cc77f9b31ad Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0cc77f9b31ad Added tag jdk8-b60 for changeset 3cfd05b2219a ! .hgtags Changeset: 81e878c53615 Author: amurillo Date: 2012-10-05 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/81e878c53615 8000498: new hotspot build - hs25-b05 Reviewed-by: jcoomes ! make/hotspot_version Changeset: d8ce2825b193 Author: coleenp Date: 2012-09-29 06:40 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d8ce2825b193 8000213: NPG: Should have renamed arrayKlass and typeArrayKlass Summary: Capitalize these metadata types (and objArrayKlass) Reviewed-by: stefank, twisti, kvn ! agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Klass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Metadata.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/TypeArrayKlass.java ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciArrayKlass.cpp ! src/share/vm/ci/ciArrayKlass.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciKlass.hpp ! src/share/vm/ci/ciObjArrayKlass.cpp ! src/share/vm/ci/ciObjArrayKlass.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciTypeArrayKlass.cpp ! src/share/vm/ci/ciTypeArrayKlass.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/memory/specialized_oop_closures.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/objArrayKlass.inline.hpp ! src/share/vm/oops/objArrayOop.cpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/oop.psgc.inline.hpp ! src/share/vm/oops/oopsHierarchy.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/shark/sharkRuntime.cpp Changeset: fab6fbf427d2 Author: kevinw Date: 2012-09-30 23:24 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fab6fbf427d2 7200145: runtime/7196045/Test7196045.java fails with No class provided for `main' Reviewed-by: dholmes, dsamersoff ! test/runtime/7196045/Test7196045.java Changeset: ba8fd2fe198b Author: coleenp Date: 2012-10-04 08:38 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ba8fd2fe198b 7198519: Broken build, hotspot-rt win USE_PRECOMPILED_HEADER=0 Summary: Uncommented out include for sys/stat.h and deleted include statements that were commented out. Reviewed-by: coleenp, acorn, dholmes Contributed-by: harold.seigel at oracle.com ! src/os/windows/vm/jvm_windows.h Changeset: bacdc1d5c21c Author: coleenp Date: 2012-10-04 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bacdc1d5c21c 6884973: java -XX:Atomics=2 crashes Summary: Remove buggy experimental option Reviewed-by: acorn, coleenp Contributed-by: harold.seigel at oracle.com ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 48087f745a86 Author: dholmes Date: 2012-10-04 19:52 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/48087f745a86 7199186: runtime/7194254/Test7194254.java fails - wrong test name on @run Reviewed-by: kvn, twisti ! test/runtime/7194254/Test7194254.java Changeset: f2eb2d4488db Author: dholmes Date: 2012-10-04 20:09 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f2eb2d4488db Merge Changeset: 75982791ddb6 Author: coleenp Date: 2012-10-08 09:18 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/75982791ddb6 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field. Summary: Don't use HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N directly. Reviewed-by: coleenp, kamg, dholmes, sspitsyn Contributed-by: Mark Wielaard ! make/bsd/makefiles/buildtree.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/dtrace.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/dtrace.hpp Changeset: 7a40901e0d5c Author: minqi Date: 2012-10-08 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7a40901e0d5c 8000332: SA ClassDump throws exception after permgen removal Summary: In ClassWrite.writeFields(), fields count was mistakenly set to fields length which overflow the array index. Also removed a file which is leftover from 6879063 changeset. Reviewed-by: coleenp, sspitsyn Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/native/sadis.c Changeset: 0e8ca886e4e1 Author: minqi Date: 2012-10-08 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0e8ca886e4e1 Merge Changeset: 6e5a59a8e4a7 Author: rbackman Date: 2012-10-09 07:41 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6e5a59a8e4a7 Merge ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 26351ce8c4b0 Author: coleenp Date: 2012-10-09 02:42 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/26351ce8c4b0 8000622: Forgot to hg add and check in test for JDK-7170638 Summary: add the test Reviewed-by: coleenp, kamg Contributed-by: Mark Wielaard + test/serviceability/7170638/SDTProbesGNULinuxTest.sh Changeset: b9a9ed0f8eeb Author: mikael Date: 2012-10-09 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b9a9ed0f8eeb 7197424: update copyright year to match last edit in jdk8 hotspot repository Summary: Update copyright year to 2012 for relevant files Reviewed-by: dholmes, coleenp ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java ! agent/src/share/classes/sun/jvm/hotspot/oops/BranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/CounterData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/JumpData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MultiBranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/VirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/BasicHashtable.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/BasicHashtableEntry.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/Hashtable.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HashtableBucket.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HashtableEntry.java ! make/bsd/Makefile ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/jvmg.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/rules.make ! make/bsd/makefiles/sparcWorks.make ! make/bsd/makefiles/top.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/ppc.make ! make/linux/makefiles/product.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sparcWorks.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/top.make ! make/windows/build.bat ! make/windows/build_vm_def.sh ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/launcher.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/rules.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/shared.make ! make/windows/makefiles/vm.make ! make/windows/projectfiles/common/Makefile ! src/cpu/sparc/vm/c1_FrameMap_sparc.cpp ! src/cpu/sparc/vm/c1_FrameMap_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.hpp ! src/cpu/sparc/vm/c1_LinearScan_sparc.hpp ! src/cpu/sparc/vm/interpreterGenerator_sparc.hpp ! src/cpu/x86/vm/c1_FrameMap_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/cpu/x86/vm/interpreterGenerator_x86.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/templateTable_x86_32.hpp ! src/cpu/x86/vm/templateTable_x86_64.hpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/zero/vm/interpreterGenerator_zero.hpp ! src/cpu/zero/vm/methodHandles_zero.hpp ! src/os/bsd/vm/decoder_machO.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/decoder_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/launcher.script ! src/os/posix/vm/os_posix.cpp ! src/os/posix/vm/os_posix.hpp ! src/os/solaris/dtrace/hs_private.d ! src/os/solaris/vm/attachListener_solaris.cpp ! src/os/solaris/vm/decoder_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/solaris/vm/perfMemory_solaris.cpp ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/decoder_windows.hpp ! src/os/windows/vm/os_windows.hpp ! src/os/windows/vm/perfMemory_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.inline.hpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.hpp ! src/os_cpu/linux_x86/vm/os_linux_x86.inline.hpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.il ! src/os_cpu/solaris_x86/vm/solaris_x86_64.il ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.hpp ! src/os_cpu/windows_x86/vm/os_windows_x86.inline.hpp ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/register.hpp ! src/share/vm/c1/c1_CFGPrinter.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_Compiler.cpp ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_FrameMap.hpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_ValueMap.cpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/c1/c1_ValueStack.cpp ! src/share/vm/c1/c1_ValueStack.hpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/ci/ciSymbol.cpp ! src/share/vm/ci/ciTypeFlow.hpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/classfile/javaAssertions.hpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/code/vmreg.hpp ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.hpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.hpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp ! src/share/vm/gc_implementation/g1/survRateGroup.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.hpp ! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.hpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psGenerationCounters.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionLAB.hpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/collectorCounters.cpp ! src/share/vm/gc_implementation/shared/collectorCounters.hpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/gcPolicyCounters.hpp ! src/share/vm/gc_implementation/shared/gcStats.hpp ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp ! src/share/vm/gc_implementation/shared/generationCounters.cpp ! src/share/vm/gc_implementation/shared/generationCounters.hpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/spaceCounters.cpp ! src/share/vm/gc_implementation/shared/spaceCounters.hpp ! src/share/vm/gc_implementation/shared/spaceDecorator.hpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/libadt/set.cpp ! src/share/vm/libadt/vectset.cpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp ! src/share/vm/memory/heap.cpp ! src/share/vm/memory/heap.hpp ! src/share/vm/memory/referencePolicy.hpp ! src/share/vm/memory/space.inline.hpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/divnode.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/locknode.hpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/subnode.hpp ! src/share/vm/prims/jniExport.hpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/prims/jvmtiExtensions.cpp ! src/share/vm/prims/jvmtiRawMonitor.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/prims/jvmtiUtil.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/dtraceJSDT.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.hpp ! src/share/vm/runtime/monitorChunk.cpp ! src/share/vm/runtime/monitorChunk.hpp ! src/share/vm/runtime/mutex.hpp ! src/share/vm/runtime/park.cpp ! src/share/vm/runtime/perfMemory.cpp ! src/share/vm/runtime/stubCodeGenerator.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/task.hpp ! src/share/vm/runtime/timer.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/g1MemoryPool.cpp ! src/share/vm/services/g1MemoryPool.hpp ! src/share/vm/services/lowMemoryDetector.hpp ! src/share/vm/services/memoryManager.hpp ! src/share/vm/trace/tracing.hpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder_elf.cpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp ! src/share/vm/utilities/elfStringTable.cpp ! src/share/vm/utilities/elfStringTable.hpp ! src/share/vm/utilities/elfSymbolTable.cpp ! src/share/vm/utilities/elfSymbolTable.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/histogram.cpp ! src/share/vm/utilities/histogram.hpp ! src/share/vm/utilities/intHisto.cpp ! src/share/vm/utilities/intHisto.hpp ! src/share/vm/utilities/preserveException.cpp ! src/share/vm/utilities/stack.hpp ! src/share/vm/utilities/stack.inline.hpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.hpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp ! test/compiler/6859338/Test6859338.java ! test/compiler/7116216/StackOverflow.java Changeset: c3e799c37717 Author: vlivanov Date: 2012-10-05 18:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/c3e799c37717 7177003: C1: LogCompilation support Summary: add LogCompilation support in C1 - both client and tiered mode. Reviewed-by: twisti, kvn ! src/os/linux/vm/vmError_linux.cpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/compiler/compileLog.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/ostream.cpp Changeset: 9a9b6e05ffb4 Author: vlivanov Date: 2012-10-05 19:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9a9b6e05ffb4 8000232: NPG: SIGSEGV in Dependencies::DepStream::check_klass_dependency on solaris-x64 Summary: Move decoding into Dependencies::DepStream::argument, so no caller could see encoded context value (NULL) anymore. Reviewed-by: twisti, kvn ! src/share/vm/code/dependencies.cpp Changeset: 9024b6b53ec2 Author: vlivanov Date: 2012-10-05 19:44 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9024b6b53ec2 8000485: Hotspot build fails in Solaris Studio IDE when building dtrace Summary: Prepend '.' to the existing native library path Reviewed-by: kvn, sspitsyn ! make/bsd/makefiles/dtrace.make ! make/solaris/makefiles/dtrace.make Changeset: 377508648226 Author: vlivanov Date: 2012-10-08 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/377508648226 8000313: C2 should use jlong for 64bit values Summary: Replace all occurrences of long with jlong in C2 code. Reviewed-by: kvn, twisti ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/phaseX.hpp Changeset: 65d07d9ee446 Author: twisti Date: 2012-10-08 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/65d07d9ee446 8000263: JSR 292: signature types may appear to be unloaded Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/globals.hpp Changeset: 8e47bac5643a Author: roland Date: 2012-10-09 10:11 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8e47bac5643a 7054512: Compress class pointers after perm gen removal Summary: support of compress class pointers in the compilers. Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/debugger/Address.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/Debugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/JVMDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/dummy/DummyAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerServer.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/memory/Universe.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Array.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Instance.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MetadataField.java + agent/src/share/classes/sun/jvm/hotspot/oops/NarrowKlassField.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java ! agent/src/share/classes/sun/jvm/hotspot/oops/java_lang_Class.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/RobustOopDeterminator.java ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os/bsd/dtrace/generateJvmOffsets.cpp ! src/os/bsd/dtrace/jhelper.d ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/jhelper.d ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/instanceOop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/globalDefinitions.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: f6badecb7ea7 Author: vlivanov Date: 2012-10-09 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f6badecb7ea7 7199654: Remove LoadUI2LNode Summary: Removed LoadUI2L node from Ideal nodes, use match rule in .ad files instead. Reviewed-by: kvn ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/superword.cpp Changeset: d336b3173277 Author: kvn Date: 2012-10-09 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d336b3173277 8000592: Improve adlc usability Summary: several changes to adlc to improve its usability Reviewed-by: kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/archDesc.hpp ! src/share/vm/adlc/dict2.cpp ! src/share/vm/adlc/filebuff.hpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/main.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp Changeset: 94e9408dbf50 Author: roland Date: 2012-10-11 18:21 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/94e9408dbf50 8000753: compiler/6912517 crashes on 64bit sparc with compressed oops off Summary: code generated by c1 for getClass intrinsic broken when klass field is loaded on 64bit with compressed klass off. Reviewed-by: kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp Changeset: 19eb999cb72c Author: twisti Date: 2012-10-11 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/19eb999cb72c 8000740: remove LinkWellKnownClasses Reviewed-by: kvn, jrose ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp Changeset: d804e148cff8 Author: kvn Date: 2012-10-12 09:22 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d804e148cff8 Merge ! make/bsd/makefiles/dtrace.make ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fb19af007ffc Author: jprovino Date: 2012-10-10 14:35 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fb19af007ffc 7189254: Change makefiles for more flexibility to override defaults Summary: Change makefiles so that targets and parameters can be overridden by alternate makefiles. Reviewed-by: dholmes, coleenp ! make/Makefile ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/ia64.make + make/bsd/makefiles/minimal1.make ! make/bsd/makefiles/vm.make ! make/defs.make + make/excludeSrc.make ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/ia64.make + make/linux/makefiles/minimal1.make ! make/linux/makefiles/vm.make ! make/windows/makefiles/defs.make ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/metaspaceShared.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/forte.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiImpl.hpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/prims/jvmtiThreadState.hpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/classLoadingService.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/heapDumper.hpp ! src/share/vm/services/management.cpp ! src/share/vm/services/management.hpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memTracker.hpp ! src/share/vm/services/runtimeService.cpp ! src/share/vm/services/runtimeService.hpp ! src/share/vm/utilities/macros.hpp Changeset: bbeecede56dd Author: jiangli Date: 2012-10-11 14:36 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bbeecede56dd 8000459: assert(java_lang_String::is_instance(entry)) failure with various mlvm tests. Summary: Remove unneeded assert. Reviewed-by: sspitsyn, coleenp ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 9855b7e559ae Author: collins Date: 2012-10-12 10:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9855b7e559ae Merge ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/vm.make ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/management.cpp Changeset: 5876f980ea19 Author: collins Date: 2012-10-12 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5876f980ea19 Merge ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b261523fe66c Author: amurillo Date: 2012-10-12 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b261523fe66c Merge Changeset: 4547dc71db76 Author: amurillo Date: 2012-10-12 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4547dc71db76 Added tag hs25-b05 for changeset b261523fe66c ! .hgtags From david.katleman at oracle.com Wed Oct 17 22:14:58 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 17 Oct 2012 22:14:58 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b60 for changeset 2d1dff5310da Message-ID: <20121017221502.BBF35473FD@hg.openjdk.java.net> Changeset: 6b1db0b41d2f Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/6b1db0b41d2f Added tag jdk8-b60 for changeset 2d1dff5310da ! .hgtags From david.katleman at oracle.com Wed Oct 17 22:15:09 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 17 Oct 2012 22:15:09 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b60 for changeset 5c5a65ad5291 Message-ID: <20121017221512.B121D473FE@hg.openjdk.java.net> Changeset: 97e5e74e2a34 Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/97e5e74e2a34 Added tag jdk8-b60 for changeset 5c5a65ad5291 ! .hgtags From david.katleman at oracle.com Wed Oct 17 22:16:21 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 17 Oct 2012 22:16:21 +0000 Subject: hg: jdk8/build/jdk: 51 new changesets Message-ID: <20121017222630.DB230473FF@hg.openjdk.java.net> Changeset: 869519bc17ce Author: katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/869519bc17ce Added tag jdk8-b60 for changeset cec8fa02f156 ! .hgtags Changeset: 4d8b411a2bc1 Author: jgodinez Date: 2012-09-25 09:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4d8b411a2bc1 7158350: [macosx] Strange results of SwingUIText printing Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CTextPipe.m Changeset: 5aff878baaf6 Author: lana Date: 2012-09-28 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5aff878baaf6 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/macosx/classes/sun/awt/SunToolkitSubclass.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 8dd4cae72975 Author: ceisserer Date: 2012-10-01 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8dd4cae72975 7188093: closed/sun/java2d/pipe/ScaleQualityTest.java fails Reviewed-by: prr, flar ! src/solaris/classes/sun/java2d/xr/XRDrawImage.java Changeset: 89a1094e384f Author: bae Date: 2012-10-05 16:21 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/89a1094e384f 8000176: Need automated test for checking scale quality Reviewed-by: prr, bae Contributed-by: Vadim Pakhnushev + test/sun/java2d/pipe/InterpolationQualityTest.java Changeset: 2bc7669294cc Author: lana Date: 2012-10-08 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2bc7669294cc Merge Changeset: 9aa37a39cf39 Author: zhouyx Date: 2012-09-20 17:39 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9aa37a39cf39 7194184: JColorChooser swatch cannot accessed from keyboard Reviewed-by: rupashka, alexsch ! src/share/classes/javax/swing/colorchooser/DefaultSwatchChooserPanel.java + test/javax/swing/JColorChooser/Test7194184.java Changeset: 4f519691520c Author: vkarnauk Date: 2012-09-20 17:55 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4f519691520c 7123767: Wrong tooltip location in Multi-Monitor configurations Reviewed-by: rupashka ! src/share/classes/javax/swing/ToolTipManager.java + test/javax/swing/ToolTipManager/7123767/bug7123767.java Changeset: adddc599e551 Author: alexsch Date: 2012-09-21 13:48 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/adddc599e551 7199180: [macosx] Dead keys handling for input methods Reviewed-by: kizune, anthony ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java ! src/macosx/native/sun/awt/AWTEvent.m ! src/macosx/native/sun/awt/AWTView.m + test/java/awt/event/KeyEvent/DeadKey/DeadKeyMacOSXInputText.java Changeset: 88048b34405e Author: leonidr Date: 2012-09-24 15:25 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/88048b34405e 7124239: [macosx] sun.awt.SunToolkit.InfiniteLoop exception in realSync called from SwingTestHelper Reviewed-by: anthony ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/osxapp/NSApplicationAWT.h ! src/macosx/native/sun/osxapp/NSApplicationAWT.m Changeset: d6cba7bfbb3d Author: leonidr Date: 2012-09-24 18:24 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d6cba7bfbb3d 7179349: [macosx] Java processes on Mac should not use default Apple icon Reviewed-by: anthony ! make/sun/osxapp/Makefile + make/sun/osxapp/ToBin.java ! src/macosx/native/sun/osxapp/NSApplicationAWT.m + src/macosx/native/sun/osxapp/resource/icons/JavaApp.icns Changeset: 39227bb92978 Author: serb Date: 2012-09-24 21:33 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/39227bb92978 7160627: [macosx] TextArea has wrong initial size 7124213: [macosx] pack() does ignore size of a component; doesn't on the other platforms Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWCanvasPeer.java ! src/macosx/classes/sun/lwawt/LWCheckboxPeer.java ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWContainerPeer.java ! src/macosx/classes/sun/lwawt/LWLabelPeer.java ! src/macosx/classes/sun/lwawt/LWListPeer.java ! src/macosx/classes/sun/lwawt/LWPanelPeer.java ! src/macosx/classes/sun/lwawt/LWScrollBarPeer.java ! src/macosx/classes/sun/lwawt/LWTextAreaPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/macosx/classes/sun/lwawt/LWToolkit.java + test/java/awt/ScrollPane/ScrollPanePreferredSize/ScrollPanePreferredSize.java + test/java/awt/TextArea/TextAreaTwicePack/TextAreaTwicePack.java Changeset: c8da47a4d441 Author: alexsch Date: 2012-09-26 18:59 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c8da47a4d441 7124515: [macosx] Test fail like 6366126 (ArrayIndexOutOfBoundException pressing ENTER after removing items) Reviewed-by: serb, anthony + test/java/awt/List/EmptyListEventTest/EmptyListEventTest.java Changeset: ad467dee852a Author: alexsch Date: 2012-09-28 14:54 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ad467dee852a 7197619: Using modifiers for the dead key detection on Windows Reviewed-by: bagiras, leonidr ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h Changeset: 4b8bb77fdda9 Author: lana Date: 2012-09-28 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4b8bb77fdda9 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 3ac112755bb5 Author: bagiras Date: 2012-10-03 21:01 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3ac112755bb5 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call Reviewed-by: art, denis ! src/macosx/native/sun/awt/InitIDs.m ! src/share/classes/java/awt/Choice.java ! src/solaris/native/sun/awt/initIDs.c ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Choice.h + test/java/awt/Choice/ItemStateChangeTest/ItemStateChangeTest.java Changeset: 27ee94051373 Author: lana Date: 2012-10-08 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/27ee94051373 Merge Changeset: f5229879ea40 Author: chegar Date: 2012-09-20 09:36 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f5229879ea40 7193520: Removed references to Linux kernel version 2.2 Summary: Linux kernel version 2.2 isn't supported anymore. Reviewed-by: chegar, dsamersoff, alanb Contributed-by: John Zavgren ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/PlainSocketImpl.c ! src/solaris/native/java/net/SocketInputStream.c ! src/solaris/native/java/net/bsd_close.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h Changeset: 3ad5464e7a21 Author: ksrini Date: 2012-09-20 13:01 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3ad5464e7a21 7199614: (pack200) remove unused file Reviewed-by: alanb - src/share/test/pack200/pack.conf Changeset: 3cfb621d5e7e Author: alanb Date: 2012-09-21 15:39 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/3cfb621d5e7e 7199551: (bf) CharBuffer.append(CharSequence) throws BufferOverflowException for read-only buffer Reviewed-by: iris, dxu, chegar ! src/share/classes/java/nio/X-Buffer.java.template ! test/java/nio/Buffer/Basic-X.java.template ! test/java/nio/Buffer/Basic.java ! test/java/nio/Buffer/BasicByte.java ! test/java/nio/Buffer/BasicChar.java ! test/java/nio/Buffer/BasicDouble.java ! test/java/nio/Buffer/BasicFloat.java ! test/java/nio/Buffer/BasicInt.java ! test/java/nio/Buffer/BasicLong.java ! test/java/nio/Buffer/BasicShort.java Changeset: f0aa997ad78b Author: valeriep Date: 2012-09-25 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f0aa997ad78b 7199941: test about AES/ECB mode fails Summary: Fixed the problem of field "blockMode" not having correct value for AES algorithms. Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs11/P11Cipher.java Changeset: 4fcbddfd97f0 Author: valeriep Date: 2012-09-25 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4fcbddfd97f0 7199939: DSA 576 and 640 bit keys fail when initializing for No precomputed parameters Summary: Fixed initialize(int, SecureRandom) call to not error out when no precomputed params available. Reviewed-by: vinnie ! src/share/classes/sun/security/provider/DSAKeyPairGenerator.java ! src/share/classes/sun/security/provider/DSAParameterGenerator.java ! src/share/classes/sun/security/provider/ParameterCache.java Changeset: a58585051c4b Author: xuelei Date: 2012-09-26 21:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a58585051c4b 7200295: CertificateRequest message is wrapping when using large numbers of Certs Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/HandshakeOutStream.java ! src/share/classes/sun/security/ssl/Record.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/CertRequestOverflow.java Changeset: 790b81b631ba Author: alanb Date: 2012-09-27 10:30 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/790b81b631ba 7200742: (se) Selector.select does not block when starting Coherence (sol) Reviewed-by: chegar ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java + test/java/nio/channels/Selector/ChangingInterests.java Changeset: 9e879c0288c2 Author: andrew Date: 2012-09-27 17:55 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9e879c0288c2 7201205: Add Makefile configuration option to build with unlimited crypto in OpenJDK. Summary: Allow OpenJDK to use the unlimited crypto policy. Reviewed-by: wetmore, ohair ! make/javax/crypto/Makefile Changeset: 11a5da68673c Author: robm Date: 2012-09-27 22:35 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/11a5da68673c 7199862: Make sure that a connection is still alive when retrieved from KeepAliveCache in certain cases Reviewed-by: chegar ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: b3c7a3138c5d Author: robm Date: 2012-09-28 04:39 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b3c7a3138c5d 7199219: Proxy-Connection headers set incorrectly when a HttpClient is retrieved from the Keep Alive Cache Reviewed-by: chegar ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 7529cc41e637 Author: peytoia Date: 2012-09-28 14:14 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7529cc41e637 7069824: Support for BCP47 locale matching Reviewed-by: naoto, okutsu ! src/share/classes/java/util/Locale.java + src/share/classes/sun/util/locale/LocaleEquivalentMaps.java + src/share/classes/sun/util/locale/LocaleMatcher.java + test/java/util/Locale/Bug7069824.java + test/java/util/Locale/tools/EquivMapsGenerator.java + test/java/util/Locale/tools/language-subtag-registry.txt Changeset: 7e3ef09bb348 Author: weijun Date: 2012-09-28 17:15 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7e3ef09bb348 7200682: TEST_BUG: keytool/autotest.sh still has problems with libsoftokn.so Reviewed-by: alanb, smarks ! test/sun/security/tools/keytool/autotest.sh Changeset: b8e08f5d255a Author: dxu Date: 2012-09-28 11:14 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b8e08f5d255a 6950237: Test java/nio/file/Path/CopyAndMove.java does not work correctly when test dir in on VFAT Reviewed-by: alanb ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! test/java/nio/file/Files/CopyAndMove.java Changeset: 77bf5cde2192 Author: lana Date: 2012-09-28 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/77bf5cde2192 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/macosx/classes/sun/awt/SunToolkitSubclass.java Changeset: 0c1c4b185451 Author: dsamersoff Date: 2012-09-29 15:44 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/0c1c4b185451 7186723: TEST_BUG: Race condition in sun/management/jmxremote/startstop/JMXStartStopTest.sh Summary: Make test self-terminating and independent to cygwin/mks kill behaviour Reviewed-by: sspitsyn, alanb ! test/ProblemList.txt ! test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/management/jmxremote/startstop/REMOTE_TESTING.txt Changeset: 39cbe256c3d1 Author: alanb Date: 2012-10-01 15:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/39cbe256c3d1 8000269: Cleanup javadoc warnings Reviewed-by: lancea, darcy, ulfzibis, iris, naoto, dholmes ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/PrintWriter.java ! src/share/classes/java/io/Reader.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/InheritableThreadLocal.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/StrictMath.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ThreadGroup.java ! src/share/classes/java/lang/ThreadLocal.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/Inet4Address.java ! src/share/classes/java/net/SocketInputStream.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/nio/channels/Channels.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/security/AllPermission.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/DigitList.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/RBCollationTables.java ! src/share/classes/java/text/RBTableBuilder.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/JumboEnumSet.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/java/util/RegularEnumSet.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/java/util/prefs/XmlSupport.java ! src/share/classes/javax/crypto/CryptoAllPermission.java ! src/share/classes/javax/crypto/CryptoPermission.java ! src/share/classes/javax/crypto/CryptoPolicyParser.java ! src/share/classes/javax/crypto/NullCipherSpi.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/naming/spi/NamingManager.java ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/javax/sql/ConnectionPoolDataSource.java ! src/share/classes/javax/sql/PooledConnection.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java Changeset: 75080f572f84 Author: olagneau Date: 2012-10-02 10:11 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/75080f572f84 7050528: Improve performance of java.text.DecimalFormat.format() call stack Reviewed-by: darcy ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/NumberFormat.java + test/java/text/Format/DecimalFormat/FormatMicroBenchmark.java + test/java/text/Format/DecimalFormat/GoldenDoubleValues.java + test/java/text/Format/DecimalFormat/GoldenFormattedValues.java + test/java/text/Format/DecimalFormat/RoundingAndPropertyTest.java Changeset: 041c687c4f40 Author: psandoz Date: 2012-10-02 10:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/041c687c4f40 7197642: (sl) ServiceLoader.load(null) doesn't throw NPE Reviewed-by: alanb ! src/share/classes/java/util/ServiceLoader.java + test/java/util/ServiceLoader/NPE.java Changeset: 6750ab947255 Author: alanb Date: 2012-10-02 12:23 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6750ab947255 8000268: sun/security/provider/X509Factory/BigCRL.java failing on Linux 32-bit Reviewed-by: mullan ! test/sun/security/provider/X509Factory/BigCRL.java Changeset: 4744dc70e5d1 Author: peytoia Date: 2012-10-03 15:11 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4744dc70e5d1 7104012: AIOOBE from RuleBasedBreakIterator.lookupState for some suppl. chars Reviewed-by: okutsu ! src/share/classes/sun/text/SupplementaryCharacterData.java + test/java/text/BreakIterator/Bug7104012.java Changeset: 7fe88d457d85 Author: dxu Date: 2012-10-03 09:03 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7fe88d457d85 6910472: Typo in : java.io.ObjectOutputStream.reset() "refered" Reviewed-by: dholmes, alanb ! src/share/classes/java/io/ObjectOutputStream.java Changeset: 123db1c28d92 Author: peytoia Date: 2012-10-04 11:36 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/123db1c28d92 7196316: Wrong rounding mode in DecimalFormat after deserialization Reviewed-by: okutsu ! src/share/classes/java/text/DecimalFormat.java + test/java/text/Format/DecimalFormat/Bug7196316.java Changeset: 8692e14b8ea8 Author: peytoia Date: 2012-10-04 18:05 +0900 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8692e14b8ea8 7201151: Fix Contribution : Java cannot get Windows's IME name correctly Reviewed-by: okutsu ! src/windows/native/sun/windows/awt_InputMethod.cpp Changeset: 344f0acff085 Author: vinnie Date: 2012-02-14 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/344f0acff085 7133495: [macosx] KeyChain KeyStore implementation retrieves only one private key entry Reviewed-by: weijun ! src/macosx/native/apple/security/KeystoreImpl.m + test/sun/security/tools/keytool/ListKeychainStore.sh Changeset: 77af5b4ae4f0 Author: vinnie Date: 2012-10-04 11:54 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/77af5b4ae4f0 Merge Changeset: c6a0b13e6efa Author: naoto Date: 2012-10-04 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/c6a0b13e6efa 7196799: CLDR adapter can not be invoked when region code is specified in Locale 7197573: java/util/Locale/LocaleProviders.sh failed. Reviewed-by: okutsu ! make/java/java/FILES_java.gmk ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java + src/share/classes/sun/util/locale/provider/FallbackLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: bba370caafad Author: robm Date: 2012-10-04 19:53 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bba370caafad 7184932: Remove the temporary Selector usage in the NIO socket adapters Reviewed-by: alanb ! make/java/nio/mapfile-bsd ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! src/share/classes/sun/nio/ch/Net.java ! src/share/classes/sun/nio/ch/ServerSocketAdaptor.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/nio/ch/Util.java ! src/solaris/native/sun/nio/ch/Net.c ! src/windows/native/sun/nio/ch/Net.c + test/java/nio/channels/etc/AdaptorCloseAndInterrupt.java Changeset: cd4f181eb666 Author: naoto Date: 2012-10-04 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cd4f181eb666 7200119: Collator.getAvailableLocales() doesn't return Locale.US Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java + test/java/text/Collator/Bug7200119.java Changeset: 647424d6cf65 Author: naoto Date: 2012-10-04 21:05 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/647424d6cf65 Merge Changeset: 88a726a5b2dc Author: naoto Date: 2012-10-05 09:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/88a726a5b2dc 7198834: HOST Adapter: one extra empty space in the end of the pattern string Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: f65871e75fde Author: alanb Date: 2012-10-06 13:56 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f65871e75fde 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations Reviewed-by: mchung, forax ! make/java/java/FILES_java.gmk ! make/sun/util/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/sun/util/spi/XmlPropertiesProvider.java + src/share/classes/sun/util/xml/META-INF/services/sun.util.spi.XmlPropertiesProvider + src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java - src/share/classes/sun/util/xml/XMLUtils.java + test/java/util/Properties/CustomProvider.java + test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/MyXmlPropertiesProvider.java Changeset: 92f3a96f3c78 Author: weijun Date: 2012-10-08 10:42 +0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/92f3a96f3c78 7201053: Krb5LoginModule shows NPE when both useTicketCache and storeKey are set to true Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java + test/sun/security/krb5/auto/UseCacheAndStoreKey.java Changeset: d8581143e11d Author: lana Date: 2012-10-08 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/d8581143e11d Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: 61ddb3fd000a Author: lana Date: 2012-10-11 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/61ddb3fd000a Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf From david.katleman at oracle.com Wed Oct 17 22:34:25 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 17 Oct 2012 22:34:25 +0000 Subject: hg: jdk8/build/langtools: 22 new changesets Message-ID: <20121017223516.6777A47400@hg.openjdk.java.net> Changeset: 67f7408d935e Author: katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/67f7408d935e Added tag jdk8-b60 for changeset 3d2b98ffcb53 ! .hgtags Changeset: 8987971bcb45 Author: jjg Date: 2012-09-24 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/8987971bcb45 7196462: JavacProcessingEnvironment should tolerate BasicJavacTask Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/T7196462.java Changeset: 99983a4a593b Author: mcimadamore Date: 2012-09-25 11:52 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/99983a4a593b 7193913: Cleanup Resolve.findMethod Summary: Refactor method lookup logic in Resolve.findMethod Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 26d93df3905a Author: mcimadamore Date: 2012-09-25 11:53 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/26d93df3905a 7194586: Add back-end support for invokedynamic Summary: Add support for invokedynamic bytecode instruction; includes suppot for generation of all related classfile attributes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/util/Names.java + test/tools/javac/lambda/TestInvokeDynamic.java Changeset: 2eca84194807 Author: mcimadamore Date: 2012-09-25 11:55 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/2eca84194807 7175433: Inference cleanup: add helper class to handle inference variables Summary: Add class to handle inference variables instantiation and associated info Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/generics/inference/6638712/T6638712c.out + test/tools/javac/varargs/6313164/T7175433.java Changeset: ad2ca2a4ab5e Author: mcimadamore Date: 2012-09-25 11:56 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ad2ca2a4ab5e 7177306: Regression: unchecked method call does not erase return type Summary: Spurious extra call to Attr.checkMethod when method call is unchecked Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/IncompatibleEqUpperBounds.java ! test/tools/javac/generics/7015430/T7015430.out ! test/tools/javac/generics/7151802/T7151802.out + test/tools/javac/generics/inference/7177306/T7177306a.java + test/tools/javac/generics/inference/7177306/T7177306a.out + test/tools/javac/generics/inference/7177306/T7177306b.java + test/tools/javac/generics/inference/7177306/T7177306b.out + test/tools/javac/generics/inference/7177306/T7177306c.java + test/tools/javac/generics/inference/7177306/T7177306d.java + test/tools/javac/generics/inference/7177306/T7177306e.java + test/tools/javac/generics/inference/7177306/T7177306e.out Changeset: 0e5899f09dab Author: jjg Date: 2012-09-25 13:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/0e5899f09dab 7193657: provide internal ArrayUtils class to simplify common usage of arrays in javac Reviewed-by: mcimadamore, jjg Contributed-by: vicenterz at yahoo.es ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/javac/api/MultiTaskListener.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/file/Locations.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java + src/share/classes/com/sun/tools/javac/util/ArrayUtils.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/ByteBuffer.java ! src/share/classes/com/sun/tools/javac/util/SharedNameTable.java ! src/share/classes/com/sun/tools/javap/StackMapWriter.java Changeset: 99d23c0ef8ee Author: jjg Date: 2012-09-25 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/99d23c0ef8ee 7196464: upgrade JavaCompiler.shouldStopPolicy to accomodate policies in face of error and no error Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java Changeset: db36841709e4 Author: mcimadamore Date: 2012-09-26 14:22 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/db36841709e4 7188968: New instance creation expression using diamond is checked twice Summary: Unify method and constructor check logic Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/6840059/T6840059.out ! test/tools/javac/6857948/T6857948.out ! test/tools/javac/diags/examples/KindnameConstructor.java ! test/tools/javac/generics/diamond/7002837/T7002837.java + test/tools/javac/generics/diamond/7002837/T7002837.out + test/tools/javac/generics/diamond/7188968/T7188968.java + test/tools/javac/generics/diamond/7188968/T7188968.out ! test/tools/javac/positions/T6264029.out Changeset: 1a65d6565b45 Author: mcimadamore Date: 2012-09-28 16:56 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/1a65d6565b45 8000233: Fix issues in recent push Summary: Forgot to incorporate review comments in pushed changesets Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/util/Names.java Changeset: f1e6b361a329 Author: mcimadamore Date: 2012-09-28 18:50 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f1e6b361a329 8000241: langtools doesn't build Summary: bad merge with langtools tip caused build glitch Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! test/tools/javac/lambda/TestInvokeDynamic.java Changeset: 73312ec2cf7c Author: jfranck Date: 2012-09-28 11:39 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/73312ec2cf7c 7199925: Separate compilation breaks check that elements have a default for the containing annotation Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties Changeset: e77841f2c74b Author: lana Date: 2012-09-28 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/e77841f2c74b Merge Changeset: 20e4a54b1629 Author: ksrini Date: 2012-09-29 09:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/20e4a54b1629 7198582: (java) Minor refactor of JavacParser Reviewed-by: jjg, ksrini Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java Changeset: 1408af4cd8b0 Author: mcimadamore Date: 2012-10-04 13:04 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/1408af4cd8b0 7177387: Add target-typing support in method context Summary: Add support for deferred types and speculative attribution Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeTags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/conditional/Conditional.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/IncompatibleTypesInConditional.java + test/tools/javac/diags/examples/TypeConditional.java Changeset: 573ceb23beeb Author: mcimadamore Date: 2012-10-05 14:35 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/573ceb23beeb 7177385: Add attribution support for lambda expressions Summary: Add support for function descriptor lookup, functional interface inference and lambda expression type-checking Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/6402516/TestLocalElements.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAccessArgTypeInFunctionalDesc.java + test/tools/javac/diags/examples/CantAccessReturnTypeInFunctionalDesc.java + test/tools/javac/diags/examples/CantAccessThrownTypesInFunctionalDesc.java ! test/tools/javac/diags/examples/CantRefNonEffectivelyFinalVar.java ! test/tools/javac/diags/examples/CatchWithoutTry.java + test/tools/javac/diags/examples/CyclicInference.java + test/tools/javac/diags/examples/IncompatibleAbstracts.java + test/tools/javac/diags/examples/IncompatibleArgTypesInLambda.java + test/tools/javac/diags/examples/IncompatibleDescsInFunctionalIntf.java + test/tools/javac/diags/examples/IncompatibleRetTypeInLambda.java + test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java + test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java + test/tools/javac/diags/examples/MissingReturnValueFragment.java + test/tools/javac/diags/examples/NoAbstracts.java + test/tools/javac/diags/examples/NoSuitableFunctionalIntfInst.java + test/tools/javac/diags/examples/NotAFunctionalIntf.java + test/tools/javac/diags/examples/PotentialLambdaFound.java - test/tools/javac/diags/examples/TypeConditional.java + test/tools/javac/diags/examples/UnexpectedLambda.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/typeAnnotations/newlocations/BasicTest.out Changeset: d604fd09480b Author: bpatel Date: 2012-10-05 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d604fd09480b 7132631: The help-doc.html generates an invalid link to constant-values.html Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties + test/com/sun/javadoc/testHelpFile/TestHelpFile.java Changeset: ef88ae455c88 Author: bpatel Date: 2012-10-05 14:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ef88ae455c88 7068595: html files in class-use dir do not get loaded correctly when Frames link is clicked Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! test/com/sun/javadoc/testUseOption/TestUseOption.java Changeset: f4e45397722a Author: bpatel Date: 2012-10-05 14:21 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/f4e45397722a 4696488: javadoc doesn't handle UNC paths for destination directory Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java + test/tools/javadoc/T4696488.java Changeset: d4b3cb1ece84 Author: mcimadamore Date: 2012-10-06 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d4b3cb1ece84 7177386: Add attribution support for method references Summary: Add type-checking/lookup routines for method references Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! test/tools/javac/6758789/T6758789a.out ! test/tools/javac/6840059/T6840059.out ! test/tools/javac/7132880/T7132880.out ! test/tools/javac/Diagnostics/6722234/T6722234a_1.out ! test/tools/javac/Diagnostics/6722234/T6722234a_2.out ! test/tools/javac/Diagnostics/6722234/T6722234b_1.out ! test/tools/javac/Diagnostics/6722234/T6722234b_2.out ! test/tools/javac/Diagnostics/6722234/T6722234c.out ! test/tools/javac/Diagnostics/6862608/T6862608a.out ! test/tools/javac/Diagnostics/6862608/T6862608b.out ! test/tools/javac/T6326754.out ! test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAccessInnerClsConstr.java + test/tools/javac/diags/examples/CantApplySymbolFragment.java + test/tools/javac/diags/examples/CantApplySymbolsFragment.java + test/tools/javac/diags/examples/CantResolveLocationArgsFragment.java + test/tools/javac/diags/examples/CantResolveLocationArgsParamsFragment.java ! test/tools/javac/diags/examples/CyclicInference.java ! test/tools/javac/diags/examples/ExplicitParamsDoNotConformToBounds.java ! test/tools/javac/diags/examples/InaccessibleVarargsType/InaccessibleVarargsType.java ! test/tools/javac/diags/examples/IncompatibleEqUpperBounds.java + test/tools/javac/diags/examples/IncompatibleRetTypeInMref.java + test/tools/javac/diags/examples/IncompatibleThrownTypesInMref.java ! test/tools/javac/diags/examples/InferArgsLengthMismatch.java ! test/tools/javac/diags/examples/InferNoConformingAssignment.java ! test/tools/javac/diags/examples/InferVarargsArgumentMismatch.java ! test/tools/javac/diags/examples/InferredDoNotConformToEq.java ! test/tools/javac/diags/examples/InferredDoNotConformToUpper.java ! test/tools/javac/diags/examples/KindnameConstructor.java ! test/tools/javac/diags/examples/MethodReferencesNotSupported.java ! test/tools/javac/diags/examples/NoArgs.java + test/tools/javac/diags/examples/NonStaticCantBeRefFragment.java ! test/tools/javac/diags/examples/NotApplicableMethodFound.java + test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccessFragment.java + test/tools/javac/diags/examples/RefAmbiguousFragment.java + test/tools/javac/diags/examples/UnexpectedMref.java ! test/tools/javac/diags/examples/VarargsArgumentMismatch.java ! test/tools/javac/diags/examples/VerboseResolveMulti1.java ! test/tools/javac/diags/examples/WhereCaptured.java ! test/tools/javac/diags/examples/WhereCaptured1.java ! test/tools/javac/diags/examples/WhereTypeVar.java ! test/tools/javac/generics/7034511/T7034511a.out ! test/tools/javac/generics/7034511/T7034511b.out ! test/tools/javac/generics/inference/6611449/T6611449.out ! test/tools/javac/generics/inference/6638712/T6638712a.out ! test/tools/javac/generics/inference/6638712/T6638712c.out ! test/tools/javac/generics/inference/6638712/T6638712d.out ! test/tools/javac/generics/inference/6838943/T6838943.out ! test/tools/javac/generics/inference/7086586/T7086586.out ! test/tools/javac/generics/inference/7177306/T7177306b.out ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/quid/T6999438.out ! test/tools/javac/varargs/6313164/T6313164.out Changeset: aa3ef5c09b1b Author: lana Date: 2012-10-08 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/aa3ef5c09b1b Merge Changeset: 26020b247ad3 Author: lana Date: 2012-10-11 17:00 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/26020b247ad3 Merge From kelly.ohair at oracle.com Thu Oct 18 17:47:35 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 18 Oct 2012 10:47:35 -0700 Subject: Makefile changes Message-ID: If you are making any changes to the Makefiles or build process in jdk8, please let us know in the build group build-dev at openjdk.java.net. We will need to review and approve ALL Makefile and build changes from now until we change over to the new build-infra Makefiles. The build-infra team can help you determine the equivalent change needed in the new build-infra Makefiles. -kto From chris.gruszka at oracle.com Thu Oct 18 18:23:25 2012 From: chris.gruszka at oracle.com (Chris Gruszka) Date: Thu, 18 Oct 2012 14:23:25 -0400 Subject: Makefile changes In-Reply-To: References: Message-ID: <5080491D.5040404@oracle.com> Kelly, Does this include closed repositories like install? My understanding was that no changes had been made for closed repos. -ChrisG On 10/18/2012 1:47 PM, Kelly O'Hair wrote: > If you are making any changes to the Makefiles or build process in jdk8, please let us know in the build group > build-dev at openjdk.java.net. We will need to review and approve ALL Makefile and build changes from now > until we change over to the new build-infra Makefiles. > The build-infra team can help you determine the equivalent change needed in the new build-infra Makefiles. > > -kto > From chris.gruszka at oracle.com Thu Oct 18 18:40:07 2012 From: chris.gruszka at oracle.com (Chris Gruszka) Date: Thu, 18 Oct 2012 14:40:07 -0400 Subject: Makefile changes In-Reply-To: <5080491D.5040404@oracle.com> References: <5080491D.5040404@oracle.com> Message-ID: <50804D07.6070408@oracle.com> I saw your other email, that it does apply to closed repos. In our current JDK8 PIT (b62/b63?), we have makefile/.gmk file changes in: 7184404: MacOS AU needs to support a scheduled update check 7197469: update copyright year to match last edit in jdk8 install repository 7198150: install inclusion of JavaFX cobundle must fail if cobundle isn't available in ALT_JAVAFX_ZIP_DIR 7200833: After JavaFX truly cobundle, DS NEXTVER builds fail 7196306: After JavaFX truly cobundle, JavaFX_VERSION in ds_build_versions is wrong 7195616: JavaFX files are not signed during DS build 8000536: [Mac] JavaFX missing from install (JDK and private JRE) 7200140: Install repo for JDK8 has SUNWj7* directories 7199651: 7u10 win64 build failed at rebase process by including a signed 7192948: bin/installer.dll has wrong versions and is not signed -ChrisG On 10/18/2012 2:23 PM, Chris Gruszka wrote: > Kelly, > Does this include closed repositories like install? > My understanding was that no changes had been made for closed repos. > > -ChrisG > > On 10/18/2012 1:47 PM, Kelly O'Hair wrote: >> If you are making any changes to the Makefiles or build process in >> jdk8, please let us know in the build group >> build-dev at openjdk.java.net. We will need to review and approve ALL >> Makefile and build changes from now >> until we change over to the new build-infra Makefiles. >> The build-infra team can help you determine the equivalent change >> needed in the new build-infra Makefiles. >> >> -kto >> From kumar.x.srinivasan at oracle.COM Thu Oct 18 19:06:20 2012 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Thu, 18 Oct 2012 12:06:20 -0700 Subject: Enhance jcheck for Copyright location on 0th line ? Message-ID: <5080532C.8020409@oracle.COM> Hi, { I don't know if this has been brought my apologies if it has } When using NetBeans sometimes the import statements are inserted preceding the Copyright header, this happens with a new java file containing a Copyright header, and if import statements are absent, in which case NB does not know where to group them. Does anyone think it would be a worthwhile enhancement to jcheck, ie. warn and thereby ensure the Copyright header is on the very first line of the file ? Kumar From joe.darcy at oracle.com Thu Oct 18 19:43:55 2012 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 18 Oct 2012 12:43:55 -0700 Subject: Enhance jcheck for Copyright location on 0th line ? In-Reply-To: <5080532C.8020409@oracle.COM> References: <5080532C.8020409@oracle.COM> Message-ID: <50805BFB.3000601@oracle.com> Kumar, There is now a copyright-checking script in the repos which could/should be run before a push or during an integration. I think this is preferable to having jcheck do more semantic analysis of sources given all the special cases that can come about. -Joe On 10/18/2012 12:06 PM, Kumar Srinivasan wrote: > Hi, > > { I don't know if this has been brought my apologies if it has } > > When using NetBeans sometimes the import statements are inserted > preceding > the Copyright header, this happens with a new java file containing a > Copyright header, > and if import statements are absent, in which case NB does not know > where to group > them. > > Does anyone think it would be a worthwhile enhancement to jcheck, ie. > warn and thereby ensure the Copyright header is on the very first line > of the file ? > > Kumar From Dmitry.Samersoff at oracle.com Thu Oct 18 20:16:54 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Fri, 19 Oct 2012 00:16:54 +0400 Subject: Enhance jcheck for Copyright location on 0th line ? In-Reply-To: <50805BFB.3000601@oracle.com> References: <5080532C.8020409@oracle.COM> <50805BFB.3000601@oracle.com> Message-ID: <508063B6.5020408@oracle.com> Joe, I would like to advertize the scripts that saves me lots of time. This script is plugable and could be extended as necessary. Actually, I would prefer to have one, uniform script as a part of a build process and jcheck as the last line defender rather than set of semi-maintained one-per-problem scripts. -Dmitry On 2012-10-18 23:43, Joe Darcy wrote: > Kumar, > > There is now a copyright-checking script in the repos which could/should > be run before a push or during an integration. > > I think this is preferable to having jcheck do more semantic analysis of > sources given all the special cases that can come about. > > -Joe > > On 10/18/2012 12:06 PM, Kumar Srinivasan wrote: >> Hi, >> >> { I don't know if this has been brought my apologies if it has } >> >> When using NetBeans sometimes the import statements are inserted >> preceding >> the Copyright header, this happens with a new java file containing a >> Copyright header, >> and if import statements are absent, in which case NB does not know >> where to group >> them. >> >> Does anyone think it would be a worthwhile enhancement to jcheck, ie. >> warn and thereby ensure the Copyright header is on the very first line >> of the file ? >> >> Kumar > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From dan.xu at oracle.com Mon Oct 22 22:12:34 2012 From: dan.xu at oracle.com (Dan Xu) Date: Mon, 22 Oct 2012 15:12:34 -0700 Subject: Make File Changes For CR4239752 Message-ID: <5085C4D2.6020902@oracle.com> Hi, I have a bug fix which needs make file changes, which can be reviewed at http://cr.openjdk.java.net/~dxu/4239752/webrev/. With the above make file changes, I am able to build jdk successfully in old build system. But if I built it using new build system, the build process failed and complained about missing generated header file, java_io_FileSystem.h. I wonder how I can make the equivalent make file changes in the new build-infra Makefiles. Thanks! -Dan From magnus.ihse.bursie at oracle.com Mon Oct 22 23:12:13 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 23 Oct 2012 01:12:13 +0200 Subject: Make File Changes For CR4239752 In-Reply-To: <5085C4D2.6020902@oracle.com> References: <5085C4D2.6020902@oracle.com> Message-ID: <27F53C8E-9EF7-4A2E-A219-D9A5CA32A034@oracle.com> Dan, This does not look like a change that should require any changes to the Makefiles in build-infra. Did you try "make clean" before building with your fixes? I think there are some issues with the automatic removing of generated header files when the last native method is removed from a class. /Magnus 23 okt 2012 kl. 00:12 skrev Dan Xu : > Hi, > > I have a bug fix which needs make file changes, which can be reviewed at http://cr.openjdk.java.net/~dxu/4239752/webrev/. > > With the above make file changes, I am able to build jdk successfully in old build system. But if I built it using new build system, the build process failed and complained about missing generated header file, java_io_FileSystem.h. > > I wonder how I can make the equivalent make file changes in the new build-infra Makefiles. Thanks! > > -Dan From kelly.ohair at oracle.com Mon Oct 22 23:21:53 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 22 Oct 2012 16:21:53 -0700 Subject: Make File Changes For CR4239752 In-Reply-To: <27F53C8E-9EF7-4A2E-A219-D9A5CA32A034@oracle.com> References: <5085C4D2.6020902@oracle.com> <27F53C8E-9EF7-4A2E-A219-D9A5CA32A034@oracle.com> Message-ID: <69B36902-1010-405A-B5A2-396868208320@oracle.com> I agree Magnus, should have worked. It looks like makefiles/mapfiles/libjava/mapfile-vers was changed, and that should do it. I assume the .so is dependent on the mapfiles right? --- Dan, If a clean build fails, please send us cut&paste of the error. -kto On Oct 22, 2012, at 4:12 PM, Magnus Ihse Bursie wrote: > Dan, > > This does not look like a change that should require any changes to the Makefiles in build-infra. > > Did you try "make clean" before building with your fixes? I think there are some issues with the automatic removing of generated header files when the last native method is removed from a class. > > /Magnus > > 23 okt 2012 kl. 00:12 skrev Dan Xu : > >> Hi, >> >> I have a bug fix which needs make file changes, which can be reviewed at http://cr.openjdk.java.net/~dxu/4239752/webrev/. >> >> With the above make file changes, I am able to build jdk successfully in old build system. But if I built it using new build system, the build process failed and complained about missing generated header file, java_io_FileSystem.h. >> >> I wonder how I can make the equivalent make file changes in the new build-infra Makefiles. Thanks! >> >> -Dan From dan.xu at oracle.com Tue Oct 23 00:03:19 2012 From: dan.xu at oracle.com (Dan Xu) Date: Mon, 22 Oct 2012 17:03:19 -0700 Subject: Make File Changes For CR4239752 In-Reply-To: <69B36902-1010-405A-B5A2-396868208320@oracle.com> References: <5085C4D2.6020902@oracle.com> <27F53C8E-9EF7-4A2E-A219-D9A5CA32A034@oracle.com> <69B36902-1010-405A-B5A2-396868208320@oracle.com> Message-ID: <5085DEC7.40103@oracle.com> I just cleaned the build by running "make dist-clean" command, and then configure and re-make jdk. But the error still exists. Here is the error message, > c:/cygwin/home/danxu/dev/Jdk/tl8/jdk/src/windows/native/java/io/WinNTFileSystem_md.c(46) > : fatal error C1083: Cannot open include file: 'java_io_FileSystem.h': > No such file or directory > mlib_ImageAffine_NN.c > c:/cygwin/home/danxu/dev/Jdk/tl8/jdk/src/share/native/common/jdk_util.c(61) > : warning C4267: 'initializing' : conversion from 'size_t' to 'int', > possible loss of data > mlib_ImageAffine_NN_Bit.c > CompileNativeLibraries.gmk:225: recipe for target > `/cygdrive/c/cygwin/home/danxu/dev/Jdk/tl8/build/windows-x86_64-normal-server-release/jdk/objs/libjava/WinNTFileSystem_md.obj' > failed > make[2]: *** > [/cygdrive/c/cygwin/home/danxu/dev/Jdk/tl8/build/windows-x86_64-normal-server-release/jdk/objs/libjava/WinNTFileSystem_md.obj] > Error 2 It seems that the java_io_FileSystem.h is not generated automatically after my change. Before the change, I can see this header file was generated under build/windows-x86_64-normal-server-release/jdk/gensrc_headers/ directory. I wonder how the header file is generated in the build. Thanks! -Dan On 10/22/2012 04:21 PM, Kelly O'Hair wrote: > I agree Magnus, should have worked. > It looks like makefiles/mapfiles/libjava/mapfile-vers was changed, and that should do it. > I assume the .so is dependent on the mapfiles right? > > --- > > Dan, > > If a clean build fails, please send us cut&paste of the error. > > -kto > > On Oct 22, 2012, at 4:12 PM, Magnus Ihse Bursie wrote: > >> Dan, >> >> This does not look like a change that should require any changes to the Makefiles in build-infra. >> >> Did you try "make clean" before building with your fixes? I think there are some issues with the automatic removing of generated header files when the last native method is removed from a class. >> >> /Magnus >> >> 23 okt 2012 kl. 00:12 skrev Dan Xu : >> >>> Hi, >>> >>> I have a bug fix which needs make file changes, which can be reviewed at http://cr.openjdk.java.net/~dxu/4239752/webrev/. >>> >>> With the above make file changes, I am able to build jdk successfully in old build system. But if I built it using new build system, the build process failed and complained about missing generated header file, java_io_FileSystem.h. >>> >>> I wonder how I can make the equivalent make file changes in the new build-infra Makefiles. Thanks! >>> >>> -Dan From erik.joelsson at oracle.com Tue Oct 23 08:16:23 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 23 Oct 2012 10:16:23 +0200 Subject: Make File Changes For CR4239752 In-Reply-To: <5085C4D2.6020902@oracle.com> References: <5085C4D2.6020902@oracle.com> Message-ID: <50865257.20800@oracle.com> Just to make sure I understand the change correctly. The only native method in java.io.FileSystem, getFileSystem() has been moved to a new class java.io.DefaultFileSystem. In the new build system, we avoid listing classes needing native headers and instead use a new feature in javac that automatically emits header files for classes with native methods or that have the annotation javax.tools.annotation.GenerateNativeHeader. The reason for generating headers for classes without native methods is to expose constants defined in the class to the native code. The first question then is whether a native header is still needed for java_io_FileSystem? Are the constants used in native code? Do they still belong in this class given that the method moved? I have no idea, so I'm asking you. If headers are still needed, there are two ways of getting the new build to generate them. The most obvious being adding the annotation mentioned above. However, there is one complication. I suspect this class is part of the base module in jigsaw and for those classes we have special treatment because of not wanting dependencies on the compile module. If this is the case, there is a special list of files in jdk/makefiles/CompileJavaClasses.gmk where this class should be added (currently looking like this): JDK_BASE_HEADER_CLASSES:=java.lang.Integer \ java.lang.Long \ java.net.SocketOptions \ sun.nio.ch.IOStatus Hope that helps! /erik On 2012-10-23 00:12, Dan Xu wrote: > Hi, > > I have a bug fix which needs make file changes, which can be reviewed > at http://cr.openjdk.java.net/~dxu/4239752/webrev/. > > With the above make file changes, I am able to build jdk successfully > in old build system. But if I built it using new build system, the > build process failed and complained about missing generated header > file, java_io_FileSystem.h. > > I wonder how I can make the equivalent make file changes in the new > build-infra Makefiles. Thanks! > > -Dan From Alan.Bateman at oracle.com Tue Oct 23 13:12:58 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 23 Oct 2012 14:12:58 +0100 Subject: Make File Changes For CR4239752 In-Reply-To: <50865257.20800@oracle.com> References: <5085C4D2.6020902@oracle.com> <50865257.20800@oracle.com> Message-ID: <508697DA.1040908@oracle.com> On 23/10/2012 09:16, Erik Joelsson wrote: > : > > The first question then is whether a native header is still needed for > java_io_FileSystem? Are the constants used in native code? Do they > still belong in this class given that the method moved? I have no > idea, so I'm asking you. > Yes, with Dan's changes it means this is another case of constants referenced in native code but without any native methods on the defining class. If it wasn't a candidate to include in the base module then it would be a candidate for @GenerativeNativeHeaders. I believe that annotation will soon be changed and will move to java.lang.annotation, in which case the concerns about putting it on core classes will go away. -Alan From jon.masamitsu at oracle.com Tue Oct 23 15:14:50 2012 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Tue, 23 Oct 2012 08:14:50 -0700 Subject: Makefile change in 7045397 Message-ID: <5086B46A.2020106@oracle.com> This change to add free lists to the class metadata (part of the perm gen removal project) http://cr.openjdk.java.net/~jmasa/7045397/webrev.03/ has a change to make/excludeSrc.make to remove freeList.cpp, binaryTreeDictionary.cpp, and freeBlockDictionary.cpp from the exclude list. These files had code that was previously only used by the CMS garbage collector but is now shared with class metadata allocation code. The change also added adaptiveFreeList.cpp (code specific to CMS removed from freeList.cpp) to the exclude list. The udiff for the change to excludeSrc.make is http://cr.openjdk.java.net/~jmasa/7045397/webrev.03/make/excludeSrc.make.udiff.html This is a request to review the above change to excludeSrc.make. Thanks. From kelly.ohair at oracle.com Tue Oct 23 17:25:58 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 23 Oct 2012 10:25:58 -0700 Subject: Makefile change in 7045397 In-Reply-To: <5086B46A.2020106@oracle.com> References: <5086B46A.2020106@oracle.com> Message-ID: <290500E6-F929-4696-AF8B-04D633C250E0@oracle.com> Looks fine. -kto On Oct 23, 2012, at 8:14 AM, Jon Masamitsu wrote: > This change to add free lists to the class metadata (part of the perm > gen removal project) > > http://cr.openjdk.java.net/~jmasa/7045397/webrev.03/ > > has a change to make/excludeSrc.make to remove > freeList.cpp, binaryTreeDictionary.cpp, and > freeBlockDictionary.cpp from the exclude list. These > files had code that was previously only used by the > CMS garbage collector but is now shared with > class metadata allocation code. The > change also added adaptiveFreeList.cpp (code > specific to CMS removed from freeList.cpp) to > the exclude list. The udiff for the change to > excludeSrc.make is > > http://cr.openjdk.java.net/~jmasa/7045397/webrev.03/make/excludeSrc.make.udiff.html > > This is a request to review the above change > to excludeSrc.make. > > Thanks. From dan.xu at oracle.com Tue Oct 23 18:47:18 2012 From: dan.xu at oracle.com (Dan Xu) Date: Tue, 23 Oct 2012 11:47:18 -0700 Subject: Make File Changes For CR4239752 In-Reply-To: <508697DA.1040908@oracle.com> References: <5085C4D2.6020902@oracle.com> <50865257.20800@oracle.com> <508697DA.1040908@oracle.com> Message-ID: <5086E636.1090105@oracle.com> Thank you for all your good comments. After adding the @GenerateNativeHeader annotation, I am able to build the jdk using the new build. But where can I check whether this class is part of the base module in jigsaw? Or should I just use the annotation as the concerns will go away soon? -Dan On Tue 23 Oct 2012 06:12:58 AM PDT, Alan Bateman wrote: > On 23/10/2012 09:16, Erik Joelsson wrote: >> : >> >> The first question then is whether a native header is still needed >> for java_io_FileSystem? Are the constants used in native code? Do >> they still belong in this class given that the method moved? I have >> no idea, so I'm asking you. >> > Yes, with Dan's changes it means this is another case of constants > referenced in native code but without any native methods on the > defining class. If it wasn't a candidate to include in the base module > then it would be a candidate for @GenerativeNativeHeaders. I believe > that annotation will soon be changed and will move to > java.lang.annotation, in which case the concerns about putting it on > core classes will go away. > > -Alan From bradford.wetmore at oracle.com Tue Oct 23 19:53:58 2012 From: bradford.wetmore at oracle.com (Brad Wetmore) Date: Tue, 23 Oct 2012 12:53:58 -0700 Subject: Recent Minor Change to Makefiles. Message-ID: <5086F5D6.30203@oracle.com> I just made a minor change to the JCE makefiles. I forgot to have it reviewed by you, sorry! Fortunately the changes are very minor. http://hg.openjdk.java.net/jdk8/tl/jdk/rev/940c8cc5a5c4 1. I'm adding the missing Manifest file to several of the JCE jar files. 2. Changing the string stored in the manifest file from $RELEASE to $JDK_VERSION Brad From jennifer.zuo at oracle.com Tue Oct 23 20:40:07 2012 From: jennifer.zuo at oracle.com (Jennifer Zuo) Date: Tue, 23 Oct 2012 16:40:07 -0400 Subject: Makefile changes Message-ID: <508700A7.8020107@oracle.com> Here is the make file changes for the install workspace regarding to wix conversion of the jre/jdk installers http://sqe-rb.us.oracle.com/r/12286/ Thanks, Jennifer From tim.bell at gmail.com Tue Oct 23 21:40:12 2012 From: tim.bell at gmail.com (tim.bell at gmail.com) Date: Tue, 23 Oct 2012 21:40:12 +0000 Subject: hg: jdk8/build: 7152336: Enable builds on Windows with MinGW/MSYS Message-ID: <20121023214013.04814474DD@hg.openjdk.java.net> Changeset: c12e759ac4e8 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/c12e759ac4e8 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! README-builds.html + make/scripts/fixpath.pl ! make/scripts/vsvars.sh From tim.bell at gmail.com Tue Oct 23 21:40:24 2012 From: tim.bell at gmail.com (tim.bell at gmail.com) Date: Tue, 23 Oct 2012 21:40:24 +0000 Subject: hg: jdk8/build/jdk: 7152336: Enable builds on Windows with MinGW/MSYS Message-ID: <20121023214059.2DA3C474DE@hg.openjdk.java.net> Changeset: a0a2b186ae28 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a0a2b186ae28 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! make/com/sun/java/pack/Makefile ! make/common/Defs-windows.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/jdk_generic_profile.sh ! make/tools/freetypecheck/Makefile + make/tools/msys_build_scripts/dospath.sh + make/tools/msys_build_scripts/dospath.vbs From tim.bell at gmail.com Tue Oct 23 21:41:09 2012 From: tim.bell at gmail.com (tim.bell at gmail.com) Date: Tue, 23 Oct 2012 21:41:09 +0000 Subject: hg: jdk8/build/corba: 7152336: Enable builds on Windows with MinGW/MSYS Message-ID: <20121023214110.C0F69474DF@hg.openjdk.java.net> Changeset: 0a5931be9176 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/0a5931be9176 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk From david.holmes at oracle.com Wed Oct 24 05:15:34 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 24 Oct 2012 15:15:34 +1000 Subject: Makefile change in 7045397 In-Reply-To: <5086B46A.2020106@oracle.com> References: <5086B46A.2020106@oracle.com> Message-ID: <50877976.6020004@oracle.com> Hi Jon, This change only affects the building of the minimal VM. If we need these additional files for NPG then we need them. Change seems okay to me. I assume minimal VM now builds correctly. Thanks, david On 24/10/2012 1:14 AM, Jon Masamitsu wrote: > This change to add free lists to the class metadata (part of the perm > gen removal project) > > http://cr.openjdk.java.net/~jmasa/7045397/webrev.03/ > > has a change to make/excludeSrc.make to remove > freeList.cpp, binaryTreeDictionary.cpp, and > freeBlockDictionary.cpp from the exclude list. These > files had code that was previously only used by the > CMS garbage collector but is now shared with > class metadata allocation code. The > change also added adaptiveFreeList.cpp (code > specific to CMS removed from freeList.cpp) to > the exclude list. The udiff for the change to > excludeSrc.make is > > http://cr.openjdk.java.net/~jmasa/7045397/webrev.03/make/excludeSrc.make.udiff.html > > > This is a request to review the above change > to excludeSrc.make. > > Thanks. From Alan.Bateman at oracle.com Wed Oct 24 11:13:01 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 24 Oct 2012 12:13:01 +0100 Subject: Make File Changes For CR4239752 In-Reply-To: <5086E636.1090105@oracle.com> References: <5085C4D2.6020902@oracle.com> <50865257.20800@oracle.com> <508697DA.1040908@oracle.com> <5086E636.1090105@oracle.com> Message-ID: <5087CD3D.9000406@oracle.com> On 23/10/2012 19:47, Dan Xu wrote: > Thank you for all your good comments. After adding the > @GenerateNativeHeader annotation, I am able to build the jdk using the > new build. > > But where can I check whether this class is part of the base module in > jigsaw? Or should I just use the annotation as the concerns will go > away soon? > > -Dan I think Erik or Magnus should be able to advise on where is the right place to explicitly generate the headers for the core classes. If there isn't any easy way to do that then I wouldn't object to adding @GenerateNativeHeader, on the assumption that it will be replaced soon. -Alan. From erik.joelsson at oracle.com Wed Oct 24 11:55:46 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 24 Oct 2012 13:55:46 +0200 Subject: Make File Changes For CR4239752 In-Reply-To: <5087CD3D.9000406@oracle.com> References: <5085C4D2.6020902@oracle.com> <50865257.20800@oracle.com> <508697DA.1040908@oracle.com> <5086E636.1090105@oracle.com> <5087CD3D.9000406@oracle.com> Message-ID: <5087D742.1050505@oracle.com> Alan seems to prefer explicit generation for this class. In that case the correct place to add it is in the list I referred to earlier: in jdk/makefiles/CompileJavaClasses.gmk: JDK_BASE_HEADER_CLASSES:=java.lang.Integer \ java.lang.Long \ java.net.SocketOptions \ sun.nio.ch.IOStatus \ java.io.FileSystem <- Add this and the backslash on the previous line /Erik On 2012-10-24 13:13, Alan Bateman wrote: > On 23/10/2012 19:47, Dan Xu wrote: >> Thank you for all your good comments. After adding the >> @GenerateNativeHeader annotation, I am able to build the jdk using >> the new build. >> >> But where can I check whether this class is part of the base module >> in jigsaw? Or should I just use the annotation as the concerns will >> go away soon? >> >> -Dan > I think Erik or Magnus should be able to advise on where is the right > place to explicitly generate the headers for the core classes. If > there isn't any easy way to do that then I wouldn't object to adding > @GenerateNativeHeader, on the assumption that it will be replaced soon. > > -Alan. From jon.masamitsu at oracle.com Wed Oct 24 16:45:01 2012 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Wed, 24 Oct 2012 09:45:01 -0700 Subject: Makefile change in 7045397 In-Reply-To: <50877976.6020004@oracle.com> References: <5086B46A.2020106@oracle.com> <50877976.6020004@oracle.com> Message-ID: <50881B0D.2010803@oracle.com> On 10/23/12 22:15, David Holmes wrote: > Hi Jon, > > This change only affects the building of the minimal VM. If we need > these additional files for NPG then we need them. > > Change seems okay to me. I assume minimal VM now builds correctly. Yes, it builds correctly now. Thanks. Jon > > Thanks, > david > > On 24/10/2012 1:14 AM, Jon Masamitsu wrote: >> This change to add free lists to the class metadata (part of the perm >> gen removal project) >> >> http://cr.openjdk.java.net/~jmasa/7045397/webrev.03/ >> >> has a change to make/excludeSrc.make to remove >> freeList.cpp, binaryTreeDictionary.cpp, and >> freeBlockDictionary.cpp from the exclude list. These >> files had code that was previously only used by the >> CMS garbage collector but is now shared with >> class metadata allocation code. The >> change also added adaptiveFreeList.cpp (code >> specific to CMS removed from freeList.cpp) to >> the exclude list. The udiff for the change to >> excludeSrc.make is >> >> http://cr.openjdk.java.net/~jmasa/7045397/webrev.03/make/excludeSrc.make.udiff.html >> >> >> >> This is a request to review the above change >> to excludeSrc.make. >> >> Thanks. From david.katleman at oracle.com Wed Oct 24 20:32:54 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 24 Oct 2012 20:32:54 +0000 Subject: hg: jdk8/build: 2 new changesets Message-ID: <20121024203254.B7ADA47513@hg.openjdk.java.net> Changeset: 8343ccdd63f1 Author: katleman Date: 2012-10-18 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/8343ccdd63f1 Added tag jdk8-b61 for changeset 20ff117b5090 ! .hgtags Changeset: 8a3fe0ae06a8 Author: katleman Date: 2012-10-24 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/8a3fe0ae06a8 Merge From david.katleman at oracle.com Wed Oct 24 20:32:58 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 24 Oct 2012 20:32:58 +0000 Subject: hg: jdk8/build/corba: 2 new changesets Message-ID: <20121024203300.4DAB347514@hg.openjdk.java.net> Changeset: 2394155f9f9e Author: katleman Date: 2012-10-18 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/2394155f9f9e Added tag jdk8-b61 for changeset 0e08ba7648fb ! .hgtags Changeset: 08afb9c6f44f Author: katleman Date: 2012-10-24 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/08afb9c6f44f Merge From david.katleman at oracle.com Wed Oct 24 20:35:08 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 24 Oct 2012 20:35:08 +0000 Subject: hg: jdk8/build/hotspot: 16 new changesets Message-ID: <20121024203547.327EC47517@hg.openjdk.java.net> Changeset: fcbdaeb69946 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/fcbdaeb69946 Added tag jdk8-b61 for changeset 4547dc71db76 ! .hgtags Changeset: 58fbf2da3c16 Author: amurillo Date: 2012-10-12 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/58fbf2da3c16 8000834: new hotspot build - hs25-b06 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8a5ea0a9ccc4 Author: johnc Date: 2012-10-06 01:17 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/8a5ea0a9ccc4 7127708: G1: change task num types from int to uint in concurrent mark Summary: Change the type of various task num fields, parameters etc to unsigned and rename them to be more consistent with the other collectors. Code changes were also reviewed by Vitaly Davidovich. Reviewed-by: johnc Contributed-by: Kaushik Srenevasan ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp Changeset: 04155d9c8c76 Author: johnc Date: 2012-10-08 09:12 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/04155d9c8c76 8000358: G1: metaspace information not printed in PrintHeapAtGC output nor in hs_err file Summary: Missing call to MetaspaceAux::print_on() in G1CollectedHeap::print_on(). Reviewed-by: azeemj, jmasa Contributed-by: Mikael Gerdin ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: dd2b66d09ccd Author: stefank Date: 2012-10-09 22:12 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dd2b66d09ccd 8000659: NPG: ClassCastExceptions are unexpectedly thrown when testing nashorn Summary: Treat the oops in invoke_method_table() as strong roots when ClassUnloading is enabled. Reviewed-by: kamg, coleenp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 4202510ee0fe Author: johnc Date: 2012-10-15 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/4202510ee0fe 8000831: Heap verification output incorrect/incomplete Summary: Restore non-silent output of heap verification. Reviewed-by: ysr, brutisso, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/utilities/debug.cpp Changeset: 633ba56cb013 Author: jmasa Date: 2012-10-17 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/633ba56cb013 Merge ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/memory/universe.hpp Changeset: bdb5f8c9978b Author: coleenp Date: 2012-10-10 17:04 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/bdb5f8c9978b 7199068: NPG: SharedSkipVerify is meaningless Summary: Remove the SharedSkipVerify flag Reviewed-by: kamg, sspitsyn, coleenp Contributed-by: harold.seigel at oracle.com ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp Changeset: 48a75d2640a5 Author: kamg Date: 2012-10-11 14:27 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/48a75d2640a5 7054345: Support version 52.0 class file in HotSpot Summary: Accept classfiles with major version 52 Reviewed-by: coleenp, acorn ! src/share/vm/classfile/classFileParser.cpp Changeset: e0ea0e94c23c Author: kevinw Date: 2012-10-15 16:48 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e0ea0e94c23c 7195151: Multiplatform tescase for 6929067 Reviewed-by: kamg, kvn ! test/runtime/6929067/Test6929067.sh Changeset: e52361627b65 Author: coleenp Date: 2012-10-15 22:33 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e52361627b65 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/globals.hpp Changeset: 045cb62046a7 Author: rbackman Date: 2012-08-28 15:15 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/045cb62046a7 7093328: JVMTI: jvmtiPrimitiveFieldCallback always report 0's for static primitives Reviewed-by: dholmes, dcubed ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 7b5885dadbdc Author: nloodin Date: 2012-10-17 17:36 +0200 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/7b5885dadbdc 8000617: It should be possible to allocate memory without the VM dying. Reviewed-by: coleenp, kamg ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: e8c79c2ba3f3 Author: coleenp Date: 2012-10-18 12:29 -0400 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e8c79c2ba3f3 Merge Changeset: d0337c31c8be Author: amurillo Date: 2012-10-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d0337c31c8be Merge Changeset: dccd40de8db1 Author: amurillo Date: 2012-10-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dccd40de8db1 Added tag hs25-b06 for changeset d0337c31c8be ! .hgtags From david.katleman at oracle.com Wed Oct 24 20:37:34 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 24 Oct 2012 20:37:34 +0000 Subject: hg: jdk8/build/jaxp: Added tag jdk8-b61 for changeset 6b1db0b41d2f Message-ID: <20121024203740.0E2114751A@hg.openjdk.java.net> Changeset: 5d0fa0108d02 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/5d0fa0108d02 Added tag jdk8-b61 for changeset 6b1db0b41d2f ! .hgtags From david.katleman at oracle.com Wed Oct 24 20:37:45 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 24 Oct 2012 20:37:45 +0000 Subject: hg: jdk8/build/jaxws: Added tag jdk8-b61 for changeset 97e5e74e2a34 Message-ID: <20121024203749.211474751B@hg.openjdk.java.net> Changeset: d265b9b4c0f5 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/d265b9b4c0f5 Added tag jdk8-b61 for changeset 97e5e74e2a34 ! .hgtags From david.katleman at oracle.com Wed Oct 24 20:38:01 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 24 Oct 2012 20:38:01 +0000 Subject: hg: jdk8/build/jdk: 4 new changesets Message-ID: <20121024203857.1862E4751D@hg.openjdk.java.net> Changeset: 1ae6420126af Author: katleman Date: 2012-10-18 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/1ae6420126af Added tag jdk8-b61 for changeset 61ddb3fd000a ! .hgtags Changeset: 61af38b8d4ff Author: twisti Date: 2012-10-19 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/61af38b8d4ff 8000989: smaller code changes to make future JSR 292 backports easier Reviewed-by: jrose ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/BigArityTest.java ! test/java/lang/invoke/PrivateInvokeTest.java Changeset: 7a7e49acadec Author: kamg Date: 2012-10-22 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7a7e49acadec 8001225: Disable jdk regression test java/lang/System/Versions.java until jdk's classfile version code is updated Summary: Exclude java/lang/System/Versions.java test Reviewed-by: sspitsyn, coleenp ! test/ProblemList.txt Changeset: 50b8b17449d2 Author: katleman Date: 2012-10-24 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/50b8b17449d2 Merge From david.katleman at oracle.com Wed Oct 24 20:39:43 2012 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 24 Oct 2012 20:39:43 +0000 Subject: hg: jdk8/build/langtools: Added tag jdk8-b61 for changeset 26020b247ad3 Message-ID: <20121024203947.D46C44751E@hg.openjdk.java.net> Changeset: b47bb81ba962 Author: katleman Date: 2012-10-18 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/b47bb81ba962 Added tag jdk8-b61 for changeset 26020b247ad3 ! .hgtags From magnus.ihse.bursie at oracle.com Thu Oct 25 11:42:04 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 25 Oct 2012 13:42:04 +0200 Subject: Request for Review: Support build-infra output directory in langtools test Message-ID: <5089258C.2060708@oracle.com> There are several similarities between jdk/test/Makefile and langtools/test/Makefile. This makes it possible to run tests from either one in build-infra (the new build system) by using the target "test". In jdk/test/Makefile there is a test for an external variable ALT_OUTPUTDIR, which directs where the test results should be stored. The build-infra framework uses this to keep the test output in the corresponding build directory. However, while the code is very similar in langtools/test/Makefile, this exact feature is not available. This results in langtools tests being hardcoded to end up in a directory named as in the old build system. Here is a rather trivial patch that will add the ALT_OUTPUTDIR functionality to langtools as well. http://cr.openjdk.java.net/~ihse/support-build-infra-output-in-langtools-test/webrev.00/ I'm assuming someone in the langtools group should review this as well, and that it probably should go in via the -tl forest. I couldn't figure out what mailing list to reach the langtools group on though, so I'd appreaciate some help with forwarding this to the right persons. /Magnus From magnus.ihse.bursie at oracle.com Thu Oct 25 13:49:37 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 25 Oct 2012 15:49:37 +0200 Subject: Request for Review: Add hotspot support for building with mingw/msys on build-infra (the new build) Message-ID: <50894371.5010001@oracle.com> The following patch will allow build-infra to perform builds on MinGW/MSys. It also updates the case for cygwin, with the two changes: 1) It replaces a $(subst) from / to \ which acted on output from cygpath -m (mixed mode), with just cygpath -w (windows mode, i.e. mixed mode but with \ instead of /). 2) In analogy with the msys case, we only do path convertion of the first word (i.e. the executable), not any possibly following arguments. In reality, there are no argument in the cygwin case (in contrary to the msys case, where the build infra solution requires passing additional arguments to the binaries). If these are problematic, they can be dropped. The important part, from build-infras point of view, is the mingw case. http://cr.openjdk.java.net/~ihse/hotspot-build-infra-msys-support/webrev.00/ /Magnus From magnus.ihse.bursie at oracle.com Thu Oct 25 14:51:27 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 25 Oct 2012 16:51:27 +0200 Subject: Request for Review: Integrating build-infra changes into build forest Message-ID: <508951EF.1040804@oracle.com> Here is a webrev of the latest changes in build-infra that we want to push to the build forest. http://cr.openjdk.java.net/~ihse/build-infra-integ/ For jdk, langtools, corba, jaxp and jaxws, all changes are in the makefiles directory. No patches from hotspot are needed at this time. (See separate mail on this.) In the top level, all changes are in the common directory (currently used exclusively by build-infra), except for a couple of changes at the root directory. This includes addition of a new, top-level configure script and the nbprojects directory. (Kelly, do you still want to push this?) /Magnus From kelly.ohair at oracle.com Thu Oct 25 20:40:33 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 25 Oct 2012 13:40:33 -0700 Subject: Request for Review: Support build-infra output directory in langtools test In-Reply-To: <5089258C.2060708@oracle.com> References: <5089258C.2060708@oracle.com> Message-ID: This change is not right. We should not use the name ALT_ anything in this makefile, it is an independent Makefile. For better or worse, it does not share the build make logic at all. The names ALT_OUTPUTDIR and ABS_OUTPUTDIR could just be something like TEST_OUTPUT_ROOT or something without the ALT or OUTPUTDIR names. If these var names were changed I'd be fine with this basic change. But at the same time, there are also the test/Makefiles in jdk, hotspot, and the root. I would think we should at least verify those don't need the same change. -kto On Oct 25, 2012, at 4:42 AM, Magnus Ihse Bursie wrote: > There are several similarities between jdk/test/Makefile and langtools/test/Makefile. This makes it possible to run tests from either one in build-infra (the new build system) by using the target "test". In jdk/test/Makefile there is a test for an external variable ALT_OUTPUTDIR, which directs where the test results should be stored. The build-infra framework uses this to keep the test output in the corresponding build directory. > > However, while the code is very similar in langtools/test/Makefile, this exact feature is not available. This results in langtools tests being hardcoded to end up in a directory named as in the old build system. > > Here is a rather trivial patch that will add the ALT_OUTPUTDIR functionality to langtools as well. > > http://cr.openjdk.java.net/~ihse/support-build-infra-output-in-langtools-test/webrev.00/ > > I'm assuming someone in the langtools group should review this as well, and that it probably should go in via the -tl forest. I couldn't figure out what mailing list to reach the langtools group on though, so I'd appreaciate some help with forwarding this to the right persons. > > /Magnus From dan.xu at oracle.com Thu Oct 25 21:28:19 2012 From: dan.xu at oracle.com (Dan Xu) Date: Thu, 25 Oct 2012 14:28:19 -0700 Subject: Make File Changes For CR4239752 In-Reply-To: <5087D742.1050505@oracle.com> References: <5085C4D2.6020902@oracle.com> <50865257.20800@oracle.com> <508697DA.1040908@oracle.com> <5086E636.1090105@oracle.com> <5087CD3D.9000406@oracle.com> <5087D742.1050505@oracle.com> Message-ID: <5089AEF3.8060107@oracle.com> Thank you, Eric. I have updated my change and tested it locally. Everything works well. Here is the latest webrev, please review the change, http://cr.openjdk.java.net/~dxu/4239752/webrev/. Thanks! -Dan On Wed 24 Oct 2012 04:55:46 AM PDT, Erik Joelsson wrote: > Alan seems to prefer explicit generation for this class. In that case > the correct place to add it is in the list I referred to earlier: > > in jdk/makefiles/CompileJavaClasses.gmk: > > JDK_BASE_HEADER_CLASSES:=java.lang.Integer \ > java.lang.Long \ > java.net.SocketOptions \ > sun.nio.ch.IOStatus \ > java.io.FileSystem <- Add this and the > backslash on the previous line > > /Erik > > On 2012-10-24 13:13, Alan Bateman wrote: >> On 23/10/2012 19:47, Dan Xu wrote: >>> Thank you for all your good comments. After adding the >>> @GenerateNativeHeader annotation, I am able to build the jdk using >>> the new build. >>> >>> But where can I check whether this class is part of the base module >>> in jigsaw? Or should I just use the annotation as the concerns will >>> go away soon? >>> >>> -Dan >> I think Erik or Magnus should be able to advise on where is the right >> place to explicitly generate the headers for the core classes. If >> there isn't any easy way to do that then I wouldn't object to adding >> @GenerateNativeHeader, on the assumption that it will be replaced soon. >> >> -Alan. From jonathan.gibbons at oracle.com Fri Oct 26 00:22:20 2012 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 25 Oct 2012 17:22:20 -0700 Subject: Request for Review: Support build-infra output directory in langtools test In-Reply-To: References: <5089258C.2060708@oracle.com> Message-ID: <5089D7BC.8050408@oracle.com> I note that there are some notes on the OpenJDK website about running tests. See here: http://openjdk.java.net/jtreg/#makefile In particular, it includes this text: > > When using these targets, it is recommended to set the following > variables, either as environment variables or on the "make" command line: > > * |JT_HOME|: the jtreg installation directory > * |PRODUCT_HOME|: the JDK build to be tested: this is typically a > file path ending in /j2sdk-image/ > If someone makes any changes such that this is no longer true, please let me know so that I can update these notes. -- Jon On 10/25/2012 01:40 PM, Kelly O'Hair wrote: > This change is not right. > > We should not use the name ALT_ anything in this makefile, it is an independent Makefile. > For better or worse, it does not share the build make logic at all. > > The names ALT_OUTPUTDIR and ABS_OUTPUTDIR could just be something like TEST_OUTPUT_ROOT > or something without the ALT or OUTPUTDIR names. > > If these var names were changed I'd be fine with this basic change. But at the same time, there are also the test/Makefiles > in jdk, hotspot, and the root. I would think we should at least verify those don't need the same change. > > -kto > > On Oct 25, 2012, at 4:42 AM, Magnus Ihse Bursie wrote: > >> There are several similarities between jdk/test/Makefile and langtools/test/Makefile. This makes it possible to run tests from either one in build-infra (the new build system) by using the target "test". In jdk/test/Makefile there is a test for an external variable ALT_OUTPUTDIR, which directs where the test results should be stored. The build-infra framework uses this to keep the test output in the corresponding build directory. >> >> However, while the code is very similar in langtools/test/Makefile, this exact feature is not available. This results in langtools tests being hardcoded to end up in a directory named as in the old build system. >> >> Here is a rather trivial patch that will add the ALT_OUTPUTDIR functionality to langtools as well. >> >> http://cr.openjdk.java.net/~ihse/support-build-infra-output-in-langtools-test/webrev.00/ >> >> I'm assuming someone in the langtools group should review this as well, and that it probably should go in via the -tl forest. I couldn't figure out what mailing list to reach the langtools group on though, so I'd appreaciate some help with forwarding this to the right persons. >> >> /Magnus From kelly.ohair at oracle.com Fri Oct 26 01:24:41 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 25 Oct 2012 18:24:41 -0700 Subject: Request for Review: Add hotspot support for building with mingw/msys on build-infra (the new build) In-Reply-To: <50894371.5010001@oracle.com> References: <50894371.5010001@oracle.com> Message-ID: <08803191-4297-4464-B062-0F7010585D5F@oracle.com> It has been my experience that using cygpath -w created problems with shell escape logic, and that is why cygpath -m with a make level subst change is done, it was less problematic. I don't understand why you would even want to change the cygwin logic at all, if it isn't broken why mess with it? So my suggestion would be to add the msys logic, and leave the old cygwin logic alone. I could have sworn that Tim Bell already did this change, and yes, if I look at: http://hg.openjdk.java.net/jdk8/build/hotspot/file/dccd40de8db1/make/windows/makefiles/defs.make These changes are there already, or something equivalent. Have you talked with Tim Bell about this change? -kto On Oct 25, 2012, at 6:49 AM, Magnus Ihse Bursie wrote: > The following patch will allow build-infra to perform builds on MinGW/MSys. > > It also updates the case for cygwin, with the two changes: > > 1) It replaces a $(subst) from / to \ which acted on output from cygpath -m (mixed mode), with just cygpath -w (windows mode, i.e. mixed mode but with \ instead of /). > > 2) In analogy with the msys case, we only do path convertion of the first word (i.e. the executable), not any possibly following arguments. In reality, there are no argument in the cygwin case (in contrary to the msys case, where the build infra solution requires passing additional arguments to the binaries). > > If these are problematic, they can be dropped. The important part, from build-infras point of view, is the mingw case. > > http://cr.openjdk.java.net/~ihse/hotspot-build-infra-msys-support/webrev.00/ > > /Magnus From kelly.ohair at oracle.com Fri Oct 26 02:49:46 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 25 Oct 2012 19:49:46 -0700 Subject: Makefile changes In-Reply-To: <50804D07.6070408@oracle.com> References: <5080491D.5040404@oracle.com> <50804D07.6070408@oracle.com> Message-ID: <6B38EB02-1ECA-46AF-8B06-F196B936DA70@oracle.com> If these changes are integrated and on their way to jdk8/jdk8 already, it's water under the bridge, we need to see them earlier in the future. I appreciate the information though, I looked at these changesets and they look fine, but it is extremely hard to review makefile changes and know that they are correct, as you well know. :( I don't think we need to see copyright changes. What I will observe is that there appears to be many extremely minor, maybe cosmetic changes being made to makefiles that probably are unnecessary. What I will suggest from now on is that developers should strive to NOT change any makefiles unless the changes have been deemed critical or necessary for some kind of bug fix. Cleanups and misc format changes to makefiles would not be a good idea right now. Thanks for the heads up on these changes. -kto On Oct 18, 2012, at 11:40 AM, Chris Gruszka wrote: > I saw your other email, that it does apply to closed repos. > > In our current JDK8 PIT (b62/b63?), we have makefile/.gmk file changes in: > 7184404: MacOS AU needs to support a scheduled update check > > 7197469: update copyright year to match last edit in jdk8 install repository > > 7198150: install inclusion of JavaFX cobundle must fail if cobundle isn't available in ALT_JAVAFX_ZIP_DIR > > 7200833: After JavaFX truly cobundle, DS NEXTVER builds fail > 7196306: After JavaFX truly cobundle, JavaFX_VERSION in ds_build_versions is wrong > 7195616: JavaFX files are not signed during DS build > > 8000536: [Mac] JavaFX missing from install (JDK and private JRE) > > 7200140: Install repo for JDK8 has SUNWj7* directories > > 7199651: 7u10 win64 build failed at rebase process by including a signed > 7192948: bin/installer.dll has wrong versions and is not signed > > -ChrisG > > On 10/18/2012 2:23 PM, Chris Gruszka wrote: >> >> Kelly, >> Does this include closed repositories like install? >> My understanding was that no changes had been made for closed repos. >> >> -ChrisG >> >> On 10/18/2012 1:47 PM, Kelly O'Hair wrote: >>> If you are making any changes to the Makefiles or build process in jdk8, please let us know in the build group >>> build-dev at openjdk.java.net. We will need to review and approve ALL Makefile and build changes from now >>> until we change over to the new build-infra Makefiles. >>> The build-infra team can help you determine the equivalent change needed in the new build-infra Makefiles. >>> >>> -kto >>> From magnus.ihse.bursie at oracle.com Fri Oct 26 04:39:26 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 26 Oct 2012 06:39:26 +0200 Subject: Request for Review: Support build-infra output directory in langtools test In-Reply-To: References: <5089258C.2060708@oracle.com> Message-ID: <70A5456A-B148-40D6-93AF-AE479F4A8ADF@oracle.com> As I said, the name ALT_OUTPUTDIR is already used in jdk/test/Makefile. That is the reason I used it. Of course it could be called anything, but if it is not called the same thing across repos, we get a hard time for no good reason. The only important thing for integration with build-infra is that the langtools test makefile gets a customizable output directory, so it is not hard-coded to the old output directory. The build-infra test integration currently calls test/Makefile in the root, and that works fine. I do not remeber if it is because it already has this variable, or because it does not output anything, but I suspect thr latter. I was not aware that the hotspot repo also shared this test logic, so I haven't checked there. /Magnus 25 okt 2012 kl. 22:40 skrev Kelly O'Hair : > > This change is not right. > > We should not use the name ALT_ anything in this makefile, it is an independent Makefile. > For better or worse, it does not share the build make logic at all. > > The names ALT_OUTPUTDIR and ABS_OUTPUTDIR could just be something like TEST_OUTPUT_ROOT > or something without the ALT or OUTPUTDIR names. > > If these var names were changed I'd be fine with this basic change. But at the same time, there are also the test/Makefiles > in jdk, hotspot, and the root. I would think we should at least verify those don't need the same change. > > -kto > > On Oct 25, 2012, at 4:42 AM, Magnus Ihse Bursie wrote: > >> There are several similarities between jdk/test/Makefile and langtools/test/Makefile. This makes it possible to run tests from either one in build-infra (the new build system) by using the target "test". In jdk/test/Makefile there is a test for an external variable ALT_OUTPUTDIR, which directs where the test results should be stored. The build-infra framework uses this to keep the test output in the corresponding build directory. >> >> However, while the code is very similar in langtools/test/Makefile, this exact feature is not available. This results in langtools tests being hardcoded to end up in a directory named as in the old build system. >> >> Here is a rather trivial patch that will add the ALT_OUTPUTDIR functionality to langtools as well. >> >> http://cr.openjdk.java.net/~ihse/support-build-infra-output-in-langtools-test/webrev.00/ >> >> I'm assuming someone in the langtools group should review this as well, and that it probably should go in via the -tl forest. I couldn't figure out what mailing list to reach the langtools group on though, so I'd appreaciate some help with forwarding this to the right persons. >> >> /Magnus > From david.holmes at oracle.com Fri Oct 26 05:40:30 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 26 Oct 2012 15:40:30 +1000 Subject: Request for Review: Integrating build-infra changes into build forest In-Reply-To: <508951EF.1040804@oracle.com> References: <508951EF.1040804@oracle.com> Message-ID: <508A224E.9000000@oracle.com> On 26/10/2012 12:51 AM, Magnus Ihse Bursie wrote: > Here is a webrev of the latest changes in build-infra that we want to > push to the build forest. > > http://cr.openjdk.java.net/~ihse/build-infra-integ/ > > For jdk, langtools, corba, jaxp and jaxws, all changes are in the > makefiles directory. I've looked at jdk and top-level. No major comments. The proof of all this is in the building and the sooner we get jdk8/jdk8 up to date with this the sooner build-infra can wind up as a distinct project :) In version.numbers I'd still like to see these entries deleted: 30 JDK_BUILD_NUMBER= 31 MILESTONE=internal so that they can be overridden through the environment. David ----- > No patches from hotspot are needed at this time. (See separate mail on > this.) > > In the top level, all changes are in the common directory (currently > used exclusively by build-infra), except for a couple of changes at the > root directory. This includes addition of a new, top-level configure > script and the nbprojects directory. (Kelly, do you still want to push > this?) > /Magnus From magnus.ihse.bursie at oracle.com Fri Oct 26 08:04:44 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 26 Oct 2012 10:04:44 +0200 Subject: Request for Review: Add hotspot support for building with mingw/msys on build-infra (the new build) In-Reply-To: <08803191-4297-4464-B062-0F7010585D5F@oracle.com> References: <50894371.5010001@oracle.com> <08803191-4297-4464-B062-0F7010585D5F@oracle.com> Message-ID: <508A441C.9070101@oracle.com> On 2012-10-26 03:24, Kelly O'Hair wrote: > It has been my experience that using cygpath -w created problems with shell escape logic, > and that is why cygpath -m with a make level subst change is done, it was less problematic. It think it would work, but I understand why you are cautious. I can revert that part. > I don't understand why you would even want to change the cygwin logic at all, if it isn't broken why mess with it? It turned out that it was indeed broken, but I had forgot what I fixed. :-) The current code works if CC is defined like CC=/path/to/compiler but it will not work if CC is defined like CC=/path/to/compiler -extra -compiler -options That is what the $(firstword) stuff is about, just converting the compiler path. This would be just a complaint in general that it broke expectations on how to setup CC, if not this turned out to be a problem for the latest changes in build-infra. In older build-infra, we send in CC=/path/to/fixpath /path/to/compiler and by a lucky co-incidence, this will actually work, altough not as expected. (As far as I can understand, the hotspot makefile cygpath rewrite will change both paths.) However, when I added support for msys in build-infra, I changed the syntax for fixpath (formerly uncygdrive). It now requires an switch telling it to work in cygwin or msys mode, so we send in: CC=/path/to/fixpath -c /path/to/compiler which will make the hotspot rewrite code break. (My guess is that cygpath converts /path/to/fixpath but ignores everything from -c and forward). Since fixpath actually isn't technically needed when building hotspot, we can work around this differently in Hotspot. Maybe that is the pragmatic way. But I still believe it's theoretically wrong with not handling a CC= which contains more than a path to an executable. :-) > So my suggestion would be to add the msys logic, and leave the old cygwin logic alone. > > I could have sworn that Tim Bell already did this change, and yes, if I look at: > > http://hg.openjdk.java.net/jdk8/build/hotspot/file/dccd40de8db1/make/windows/makefiles/defs.make > > These changes are there already, or something equivalent. > > Have you talked with Tim Bell about this change? Not specifically about this change, but we communicated a lot while I was developing msys support for build-infra. I'm not sure what you want to tell me by the link. There was a change (7181175: Enable builds on Windows with MinGW/MSYS), http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0d8e265ba727 which added the USING_MINGW variable that I need to check. However I can't see anything in this file that would fix the CXX etc variables for msys, the way my patch is doing it. But then again, we can probably do without this patch, if we make things differently in build-infra. We're already doing some weird special stuff for Hotspot builds that I guess adding another exception won't be that different. I'll look into it. /Magnus From magnus.ihse.bursie at oracle.com Fri Oct 26 08:13:06 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 26 Oct 2012 10:13:06 +0200 Subject: Request for Review: Support build-infra output directory in langtools test In-Reply-To: <5089D7BC.8050408@oracle.com> References: <5089258C.2060708@oracle.com> <5089D7BC.8050408@oracle.com> Message-ID: <508A4612.6030804@oracle.com> On 2012-10-26 02:22, Jonathan Gibbons wrote: > I note that there are some notes on the OpenJDK website about running > tests. > See here: http://openjdk.java.net/jtreg/#makefile > > In particular, it includes this text: >> >> When using these targets, it is recommended to set the following >> variables, either as environment variables or on the "make" command >> line: >> >> * |JT_HOME|: the jtreg installation directory >> * |PRODUCT_HOME|: the JDK build to be tested: this is typically a >> file path ending in /j2sdk-image/ >> > > If someone makes any changes such that this is no longer true, please > let me know so that I can update these notes. The PRODUCT_HOME is definitiely still correct, I set this when running test from the build-infra makefile. However, the documentation does not seem to mention what this is about: some way to override were test output/logs are stored. This is currently hard-coded in langtools. In jdk, there is a default but it is possible to override, which is used by the build-infra makefile. It would probably make sense to make such a override mechanism official and documented, once you all have agreed on a good name on the variable. ;-) /Magnus From erik.joelsson at oracle.com Fri Oct 26 08:27:15 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Fri, 26 Oct 2012 10:27:15 +0200 Subject: Make File Changes For CR4239752 In-Reply-To: <5089AEF3.8060107@oracle.com> References: <5085C4D2.6020902@oracle.com> <50865257.20800@oracle.com> <508697DA.1040908@oracle.com> <5086E636.1090105@oracle.com> <5087CD3D.9000406@oracle.com> <5087D742.1050505@oracle.com> <5089AEF3.8060107@oracle.com> Message-ID: <508A4963.8030109@oracle.com> Looks good to me! /Erik On 2012-10-25 23:28, Dan Xu wrote: > Thank you, Eric. > > I have updated my change and tested it locally. Everything works well. > Here is the latest webrev, please review the change, > http://cr.openjdk.java.net/~dxu/4239752/webrev/. Thanks! > > -Dan > > On Wed 24 Oct 2012 04:55:46 AM PDT, Erik Joelsson wrote: >> Alan seems to prefer explicit generation for this class. In that case >> the correct place to add it is in the list I referred to earlier: >> >> in jdk/makefiles/CompileJavaClasses.gmk: >> >> JDK_BASE_HEADER_CLASSES:=java.lang.Integer \ >> java.lang.Long \ >> java.net.SocketOptions \ >> sun.nio.ch.IOStatus \ >> java.io.FileSystem <- Add this and the >> backslash on the previous line >> >> /Erik >> >> On 2012-10-24 13:13, Alan Bateman wrote: >>> On 23/10/2012 19:47, Dan Xu wrote: >>>> Thank you for all your good comments. After adding the >>>> @GenerateNativeHeader annotation, I am able to build the jdk using >>>> the new build. >>>> >>>> But where can I check whether this class is part of the base module >>>> in jigsaw? Or should I just use the annotation as the concerns will >>>> go away soon? >>>> >>>> -Dan >>> I think Erik or Magnus should be able to advise on where is the right >>> place to explicitly generate the headers for the core classes. If >>> there isn't any easy way to do that then I wouldn't object to adding >>> @GenerateNativeHeader, on the assumption that it will be replaced soon. >>> >>> -Alan. From magnus.ihse.bursie at oracle.com Fri Oct 26 12:48:35 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 26 Oct 2012 14:48:35 +0200 Subject: Request for Review: Add hotspot support for building with mingw/msys on build-infra (the new build) In-Reply-To: <508A441C.9070101@oracle.com> References: <50894371.5010001@oracle.com> <08803191-4297-4464-B062-0F7010585D5F@oracle.com> <508A441C.9070101@oracle.com> Message-ID: <508A86A3.9060902@oracle.com> On 2012-10-26 10:04, Magnus Ihse Bursie wrote: > Since fixpath actually isn't technically needed when building hotspot, > we can work around this differently in Hotspot. Maybe that is the > pragmatic way. But I still believe it's theoretically wrong with not > handling a CC= which contains more than a path to an executable. :-) > ... > But then again, we can probably do without this patch, if we make > things differently in build-infra. We're already doing some weird > special stuff for Hotspot builds that I guess adding another exception > won't be that different. I'll look into it. I just pushed a fix for this in build-infra, meaning this patch is not needed anymore. Let's drop it. (Kelly: it also means that now your JPRT Windows runs should work out fine! :-)) /Magnus From kelly.ohair at oracle.com Fri Oct 26 15:02:54 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 26 Oct 2012 08:02:54 -0700 Subject: Request for Review: Add hotspot support for building with mingw/msys on build-infra (the new build) In-Reply-To: <508A441C.9070101@oracle.com> References: <50894371.5010001@oracle.com> <08803191-4297-4464-B062-0F7010585D5F@oracle.com> <508A441C.9070101@oracle.com> Message-ID: <359018D5-25D1-455A-9CF9-60F22CEB9E66@oracle.com> On Oct 26, 2012, at 1:04 AM, Magnus Ihse Bursie wrote: > On 2012-10-26 03:24, Kelly O'Hair wrote: >> It has been my experience that using cygpath -w created problems with shell escape logic, >> and that is why cygpath -m with a make level subst change is done, it was less problematic. > It think it would work, but I understand why you are cautious. I can revert that part. >> I don't understand why you would even want to change the cygwin logic at all, if it isn't broken why mess with it? > It turned out that it was indeed broken, but I had forgot what I fixed. :-) The current code works if CC is defined like > CC=/path/to/compiler > but it will not work if CC is defined like > CC=/path/to/compiler -extra -compiler -options > That is what the $(firstword) stuff is about, just converting the compiler path. But according to the GNU manual, http://www.gnu.org/software/make/manual/make.html#Implicit-Variables, the CC name should be just a path to an executable, at least by convention, compiler flags belong in other variables. > > This would be just a complaint in general that it broke expectations on how to setup CC, if not this turned out to be a problem for the latest changes in build-infra. > > In older build-infra, we send in > CC=/path/to/fixpath /path/to/compiler > and by a lucky co-incidence, this will actually work, altough not as expected. (As far as I can understand, the hotspot makefile cygpath rewrite will change both paths.) What "hotspot makefile cygpath rewrite" are we talking about here? The CYGWIN cygpath utility, as far as I know, operates on one path or a PATH style path (path:path), not a command line or series of blank separated paths. > > However, when I added support for msys in build-infra, I changed the syntax for fixpath (formerly uncygdrive). It now requires an switch telling it to work in cygwin or msys mode, so we send in: > CC=/path/to/fixpath -c /path/to/compiler > which will make the hotspot rewrite code break. (My guess is that cygpath converts /path/to/fixpath but ignores everything from -c and forward). If cygpath is given a command line, I think we may be in 'undefined' behavior, I'm not sure what it would do. As I understand it, the uncygdrive (and fixpath) tool is intended to process a full command line, right? But CYGWIN's cygpath utility is just for paths. Or am I missing something here? > > Since fixpath actually isn't technically needed when building hotspot, we can work around this differently in Hotspot. Maybe that is the pragmatic way. But I still believe it's theoretically wrong with not handling a CC= which contains more than a path to an executable. :-) I tend to disagree, having multiple words in CC is unconventional, and if we do that, we need to consider the consequences of straying from the typical make convention. But I'd rather not get into what is theoretically wrong or right, it just needs to work, so we do what we have to. The fixpath trick concerns me on windows, all the extra exec's and all, but I've kept quiet about it because I'm not that up to speed on the specific issues. I think we need to watch fixpath pretty closely, something tells me we aren't done with this issue, just a gut feeling. > > >> So my suggestion would be to add the msys logic, and leave the old cygwin logic alone. >> >> I could have sworn that Tim Bell already did this change, and yes, if I look at: >> >> http://hg.openjdk.java.net/jdk8/build/hotspot/file/dccd40de8db1/make/windows/makefiles/defs.make >> >> These changes are there already, or something equivalent. >> >> Have you talked with Tim Bell about this change? > > Not specifically about this change, but we communicated a lot while I was developing msys support for build-infra. > > I'm not sure what you want to tell me by the link. There was a change (7181175: Enable builds on Windows with MinGW/MSYS), > http://hg.openjdk.java.net/jdk8/build/hotspot/rev/0d8e265ba727 > which added the USING_MINGW variable that I need to check. However I can't see anything in this file that would fix the CXX etc variables for msys, the way my patch is doing it. > You are correct that something needs to fix the multiple word issue of $(CC) for msys. > But then again, we can probably do without this patch, if we make things differently in build-infra. We're already doing some weird special stuff for Hotspot builds that I guess adding another exception won't be that different. I'll look into it. I appreciate that. -kto > > /Magnus From Alan.Bateman at oracle.com Fri Oct 26 16:16:34 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 26 Oct 2012 17:16:34 +0100 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge Message-ID: <508AB762.1090606@oracle.com> We're jettisoning the legacy JDBC-ODBC bridge from Oracle's jdk8 builds and this means updating several make files. Here's the webrev: http://cr.openjdk.java.net/~alanb/7176225/webrev/ I believe I got everything in the both builds. The only thing that isn't clear is the old Def-solaris.gmk and whether MAPFILE_EXCEPTION should be defined or set to () as I have it. Thanks, -Alan. From kelly.ohair at oracle.com Fri Oct 26 16:31:44 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 26 Oct 2012 09:31:44 -0700 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: <508AB762.1090606@oracle.com> References: <508AB762.1090606@oracle.com> Message-ID: Looks ok to me. We may need to do some builds both ways to make sure. -kto On Oct 26, 2012, at 9:16 AM, Alan Bateman wrote: > > We're jettisoning the legacy JDBC-ODBC bridge from Oracle's jdk8 builds and this means updating several make files. Here's the webrev: > > http://cr.openjdk.java.net/~alanb/7176225/webrev/ > > I believe I got everything in the both builds. The only thing that isn't clear is the old Def-solaris.gmk and whether MAPFILE_EXCEPTION should be defined or set to () as I have it. > > Thanks, > > -Alan. From tim.bell at oracle.com Fri Oct 26 17:06:55 2012 From: tim.bell at oracle.com (Tim Bell) Date: Fri, 26 Oct 2012 10:06:55 -0700 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: References: <508AB762.1090606@oracle.com> Message-ID: <508AC32F.6080402@oracle.com> Looks good to me also. Always good to see code deletion take place. Tim On 10/26/12 09:31, Kelly O'Hair wrote: > Looks ok to me. > > We may need to do some builds both ways to make sure. > > -kto > > On Oct 26, 2012, at 9:16 AM, Alan Bateman wrote: > >> We're jettisoning the legacy JDBC-ODBC bridge from Oracle's jdk8 builds and this means updating several make files. Here's the webrev: >> >> http://cr.openjdk.java.net/~alanb/7176225/webrev/ >> >> I believe I got everything in the both builds. The only thing that isn't clear is the old Def-solaris.gmk and whether MAPFILE_EXCEPTION should be defined or set to () as I have it. >> >> Thanks, >> >> -Alan. From johnyeary at gmail.com Fri Oct 26 20:14:11 2012 From: johnyeary at gmail.com (John Yeary) Date: Fri, 26 Oct 2012 16:14:11 -0400 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: <508AC32F.6080402@oracle.com> References: <508AB762.1090606@oracle.com> <508AC32F.6080402@oracle.com> Message-ID: Hello All, Out of curiosity what will replace it? I looked at the transitional notification[1], but it leaves me feeling a little uneasy about it. At one point, I worked on a number of "simple" applications which used MS Access as the database for a Java Swing front end. The only driver to connect these applications was the JDBC-ODBC bridge. A number of those applications are still around today. Is it safe to assume that the users will not upgrade their systems? When JDK 8 comes out, their applications will fail. I realize that I have come late to the conversation on this since the removal is almost completed, but I see an issue cropping up in the future. John [1] http://download.java.net/jdk8/docs/technotes/guides/jdbc/bridge.html ____________________________ John Yeary ____________________________ *NetBeans Dream Team* *President Greenville Java Users Group Java Users Groups Community Leader Java Enterprise Community Leader* ____________________________ "Far better it is to dare mighty things, to win glorious triumphs, even though checkered by failure, than to take rank with those poor spirits who neither enjoy much nor suffer much, because they live in the gray twilight that knows not victory nor defeat." -- Theodore Roosevelt On Fri, Oct 26, 2012 at 1:06 PM, Tim Bell wrote: > Looks good to me also. > > Always good to see code deletion take place. > > Tim > > > On 10/26/12 09:31, Kelly O'Hair wrote: > >> Looks ok to me. >> >> We may need to do some builds both ways to make sure. >> >> -kto >> >> On Oct 26, 2012, at 9:16 AM, Alan Bateman wrote: >> >> We're jettisoning the legacy JDBC-ODBC bridge from Oracle's jdk8 builds >>> and this means updating several make files. Here's the webrev: >>> >>> http://cr.openjdk.java.net/~**alanb/7176225/webrev/ >>> >>> I believe I got everything in the both builds. The only thing that isn't >>> clear is the old Def-solaris.gmk and whether MAPFILE_EXCEPTION should be >>> defined or set to () as I have it. >>> >>> Thanks, >>> >>> -Alan. >>> >> > > From Ulf.Zibis at CoSoCo.de Fri Oct 26 20:57:13 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Fri, 26 Oct 2012 22:57:13 +0200 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: References: <508AB762.1090606@oracle.com> <508AC32F.6080402@oracle.com> Message-ID: <508AF929.3000903@CoSoCo.de> Hi, I also feel sorry for jettisoning the JDBC-ODBC-bridge from the JDK. What does it harm to leave it? Would it be possible to have the sources in a java.net project, so people could use it via the Extension class loader? -Ulf Am 26.10.2012 22:14, schrieb John Yeary: > Hello All, > > Out of curiosity what will replace it? I looked at the transitional > notification[1], but it leaves me feeling a little uneasy about it. At one > point, I worked on a number of "simple" applications which used MS Access > as the database for a Java Swing front end. The only driver to connect > these applications was the JDBC-ODBC bridge. A number of those applications > are still around today. Is it safe to assume that the users will not > upgrade their systems? When JDK 8 comes out, their applications will fail. > > I realize that I have come late to the conversation on this since the > removal is almost completed, but I see an issue cropping up in the future. > > John > > > [1] http://download.java.net/jdk8/docs/technotes/guides/jdbc/bridge.html > ____________________________ > > John Yeary > ____________________________ > *NetBeans Dream Team* > *President Greenville Java Users Group > Java Users Groups Community Leader > Java Enterprise Community Leader* > > ____________________________ > > > > > > > > > > "Far better it is to dare mighty things, to win glorious triumphs, even > though checkered by failure, than to take rank with those poor spirits who > neither enjoy much nor suffer much, because they live in the gray twilight > that knows not victory nor defeat." > -- Theodore Roosevelt From kelly.ohair at oracle.com Fri Oct 26 21:36:48 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 26 Oct 2012 21:36:48 +0000 Subject: hg: jdk8/build: 8000992: Update new build-infra makefiles Message-ID: <20121026213649.11844475A5@hg.openjdk.java.net> Changeset: e64f2cb57d05 Author: ohair Date: 2012-10-26 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/e64f2cb57d05 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes from ohair, tbell, and dholmes. Special credit to ohstrom for his smartjavac work. Reviewed-by: erikj, ihse, dholmes, tbell ! NewMakefile.gmk ! common/autoconf/autogen.sh ! common/autoconf/basics.m4 + common/autoconf/basics_windows.m4 ! common/autoconf/boot-jdk.m4 ! common/autoconf/build-aux/config.guess ! common/autoconf/build-performance.m4 ! common/autoconf/builddeps.m4 ! common/autoconf/closed.version.numbers ! common/autoconf/compare.sh.in ! common/autoconf/configure ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 ! common/autoconf/hotspot-spec.gmk.in ! common/autoconf/jdk-options.m4 ! common/autoconf/libraries.m4 ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 + common/autoconf/toolchain_windows.m4 ! common/autoconf/version.numbers + common/bin/compare.sh + common/bin/compare_exceptions.sh.incl - common/bin/compareimage.sh - common/bin/diffexec.sh - common/bin/diffjarzip.sh - common/bin/difflib.sh - common/bin/difftext.sh - common/bin/exception_list_linux - common/bin/extractvcvars.sh ! common/bin/hide_important_warnings_from_javac.sh ! common/bin/logger.sh + common/bin/shell-tracer.sh - common/bin/unicode2x.sed ! common/makefiles/HotspotWrapper.gmk ! common/makefiles/IdlCompilation.gmk ! common/makefiles/JavaCompilation.gmk + common/makefiles/Main.gmk ! common/makefiles/MakeBase.gmk ! common/makefiles/MakeHelpers.gmk ! common/makefiles/Makefile ! common/makefiles/NativeCompilation.gmk ! common/makefiles/RMICompilation.gmk - common/makefiles/compress.post - common/makefiles/compress.pre + common/makefiles/support/ListPathsSafely-post-compress.incl + common/makefiles/support/ListPathsSafely-pre-compress.incl + common/makefiles/support/ListPathsSafely-uncompress.sed + common/makefiles/support/unicode2x.sed - common/makefiles/uncompress.sed + common/src/fixpath.c - common/src/uncygdrive.c + configure From kelly.ohair at oracle.com Fri Oct 26 21:36:49 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 26 Oct 2012 21:36:49 +0000 Subject: hg: jdk8/build/corba: 8000992: Update new build-infra makefiles Message-ID: <20121026213653.3C319475A6@hg.openjdk.java.net> Changeset: de2b8def2be5 Author: ohair Date: 2012-10-26 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/de2b8def2be5 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes from ohair, tbell, and dholmes. Special credit to ohstrom for his smartjavac work. Reviewed-by: erikj, ihse, dholmes, tbell + makefiles/BuildCorba.gmk ! makefiles/Makefile From kelly.ohair at oracle.com Fri Oct 26 21:36:53 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 26 Oct 2012 21:36:53 +0000 Subject: hg: jdk8/build/jaxws: 8000992: Update new build-infra makefiles Message-ID: <20121026213700.A2D75475A7@hg.openjdk.java.net> Changeset: c30a7cb5c587 Author: ohair Date: 2012-10-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/c30a7cb5c587 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes from ohair, tbell, and dholmes. Special credit to ohstrom for his smartjavac work. Reviewed-by: erikj, ihse, dholmes, tbell + makefiles/BuildJaxws.gmk ! makefiles/Makefile From kelly.ohair at oracle.com Fri Oct 26 21:36:54 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 26 Oct 2012 21:36:54 +0000 Subject: hg: jdk8/build/jaxp: 8000992: Update new build-infra makefiles Message-ID: <20121026213703.E7F4F475A8@hg.openjdk.java.net> Changeset: 121fc928a361 Author: ohair Date: 2012-10-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/121fc928a361 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes from ohair, tbell, and dholmes. Special credit to ohstrom for his smartjavac work. Reviewed-by: erikj, ihse, dholmes, tbell + makefiles/BuildJaxp.gmk ! makefiles/Makefile From kelly.ohair at oracle.com Fri Oct 26 21:36:58 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 26 Oct 2012 21:36:58 +0000 Subject: hg: jdk8/build/langtools: 8000992: Update new build-infra makefiles Message-ID: <20121026213704.D91FB475A9@hg.openjdk.java.net> Changeset: 741cce355ba6 Author: ohair Date: 2012-10-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/741cce355ba6 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes from ohair, tbell, and dholmes. Special credit to ohstrom for his smartjavac work. Reviewed-by: erikj, ihse, dholmes, tbell + makefiles/BuildLangtools.gmk ! makefiles/Makefile From kelly.ohair at oracle.com Fri Oct 26 21:36:59 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Fri, 26 Oct 2012 21:36:59 +0000 Subject: hg: jdk8/build/jdk: 8000992: Update new build-infra makefiles Message-ID: <20121026213748.C5B5A475AA@hg.openjdk.java.net> Changeset: 64dd2aba6d33 Author: ohair Date: 2012-10-26 14:23 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/64dd2aba6d33 8000992: Update new build-infra makefiles Summary: Build-infra project integration. Multiple authors on this work: erikj and ihse primarily, also changes from ohair, tbell, and dholmes. Special credit to ohstrom for his smartjavac work. Reviewed-by: erikj, ihse, dholmes, tbell + makefiles/BuildJdk.gmk + makefiles/Bundles.gmk ! makefiles/CompileDemos.gmk ! makefiles/CompileJavaClasses.gmk ! makefiles/CompileLaunchers.gmk ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/GendataBreakIterator.gmk ! makefiles/GendataFontConfig.gmk ! makefiles/GendataHtml32dtd.gmk ! makefiles/GenerateClasses.gmk ! makefiles/GenerateJavaSources.gmk ! makefiles/GensrcBuffer.gmk ! makefiles/GensrcCLDR.gmk ! makefiles/GensrcCharacterData.gmk ! makefiles/GensrcCharsetCoder.gmk ! makefiles/GensrcCharsetMapping.gmk ! makefiles/GensrcExceptions.gmk ! makefiles/GensrcIcons.gmk ! makefiles/GensrcJDWP.gmk ! makefiles/GensrcJObjC.gmk ! makefiles/GensrcLocaleDataMetaInfo.gmk ! makefiles/GensrcMisc.gmk ! makefiles/GensrcProperties.gmk ! makefiles/GensrcSwing.gmk ! makefiles/GensrcX11Wrappers.gmk ! makefiles/Images.gmk ! makefiles/Import.gmk ! makefiles/Makefile ! makefiles/Tools.gmk - makefiles/docs/CORE_PKGS.gmk - makefiles/docs/Makefile - makefiles/docs/NON_CORE_PKGS.gmk - makefiles/docs/Notes.html - makefiles/mapfiles/launchers/mapfile-amd64 - makefiles/mapfiles/launchers/mapfile-i586 - makefiles/mapfiles/libawt_headless/reorder-i586 - makefiles/mapfiles/libjava/reorder-i586 - makefiles/mapfiles/libjpeg/reorder-i586 - makefiles/mapfiles/libnio/mapfile-bsd - makefiles/mapfiles/libnio/reorder-i586 - makefiles/mapfiles/libverify/reorder-i586 - makefiles/mapfiles/libzip/reorder-i586 + makefiles/sun/awt/X11/ToBin.java + makefiles/sun/osxapp/ToBin.java - makefiles/sun/xawt/ToBin.java From Alan.Bateman at oracle.com Fri Oct 26 21:39:31 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 26 Oct 2012 22:39:31 +0100 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: References: <508AB762.1090606@oracle.com> <508AC32F.6080402@oracle.com> Message-ID: <508B0313.9000403@oracle.com> On 26/10/2012 21:14, John Yeary wrote: > Hello All, > > Out of curiosity what will replace it? I looked at the transitional > notification[1], but it leaves me feeling a little uneasy about it. At one > point, I worked on a number of "simple" applications which used MS Access > as the database for a Java Swing front end. The only driver to connect > these applications was the JDBC-ODBC bridge. A number of those applications > are still around today. Is it safe to assume that the users will not > upgrade their systems? When JDK 8 comes out, their applications will fail. > > I realize that I have come late to the conversation on this since the > removal is almost completed, but I see an issue cropping up in the future. > > John > The JDBC-ODBC bridge has never been in OpenJDK, it's just the make files. In any case, the JDBC-ODBC bridge has been on death row for a long time. Lance can confirm but I believe that it hasn't been updated beyond JBDC 2.0 whereas JDK7 moved to JDBC 4.1. I don't think it has been usable with any of the JDBC features that were added over the last few major releases. Another thing is that I don't think it has ever been supported. The oldest documentation I found is JDK 1.3 where it was recommended only for experimental use. I don't think it has really been necessary for many years anyway as so many JDBC drivers available. -Alan. From kelly.ohair at oracle.com Fri Oct 26 22:27:06 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 26 Oct 2012 15:27:06 -0700 Subject: Request for Review: Support build-infra output directory in langtools test In-Reply-To: <70A5456A-B148-40D6-93AF-AE479F4A8ADF@oracle.com> References: <5089258C.2060708@oracle.com> <70A5456A-B148-40D6-93AF-AE479F4A8ADF@oracle.com> Message-ID: <807B6AEC-92C9-4E5E-BD5D-472A508AA89A@oracle.com> On Oct 25, 2012, at 9:39 PM, Magnus Ihse Bursie wrote: > As I said, the name ALT_OUTPUTDIR is already used in jdk/test/Makefile. That is the reason I used it. Of course it could be called anything, but if it is not called the same thing across repos, we get a hard time for no good reason. I originally had visions of the test makefiles sharing logic with the build makefiles, then thought better of it. There are advantages to keeping the test makefile logic separate, or if not separate, carefully sharing select logic. My attitude now is that separate is better, and we should avoid any possible variable name collisions to avoid confusion and prevent any future sharing tricks. Testing configurations turn out to be different than build configurations. This test/Makefile logic started out extremely simple, got very complicated, then Jonathan started improving jtreg to support some of the issues we had, and then test/Makefile started getting a bit more simple again. So this file has been evolving quite a bit. At some point I decided that this was the best way for JPRT to run tests because it allowed the developer to use the same test targets for testing as JPRT, and insulated JPRT from having to know how the test harnesses worked. > > The only important thing for integration with build-infra is that the langtools test makefile gets a customizable output directory, so it is not hard-coded to the old output directory. > Fair enough, but let's see if we can integrate that change into the jdk8/tl/langtools repository. Jonathan Gibbons should look at the change if he has the time. > The build-infra test integration currently calls test/Makefile in the root, and that works fine. I do not remeber if it is because it already has this variable, or because it does not output anything, but I suspect thr latter. > > I was not aware that the hotspot repo also shared this test logic, so I haven't checked there. "sharing" is probably not the right word, "copied" would be better, unfortunately. :^( If we could put some shared test make logic in the top level common/makefiles area, we could try and share that, but hotspot still has completely independent makefiles, so some copies might be needed for now, in hotspot. -kto > > /Magnus > > 25 okt 2012 kl. 22:40 skrev Kelly O'Hair : > >> >> This change is not right. >> >> We should not use the name ALT_ anything in this makefile, it is an independent Makefile. >> For better or worse, it does not share the build make logic at all. >> >> The names ALT_OUTPUTDIR and ABS_OUTPUTDIR could just be something like TEST_OUTPUT_ROOT >> or something without the ALT or OUTPUTDIR names. >> >> If these var names were changed I'd be fine with this basic change. But at the same time, there are also the test/Makefiles >> in jdk, hotspot, and the root. I would think we should at least verify those don't need the same change. >> >> -kto >> >> On Oct 25, 2012, at 4:42 AM, Magnus Ihse Bursie wrote: >> >>> There are several similarities between jdk/test/Makefile and langtools/test/Makefile. This makes it possible to run tests from either one in build-infra (the new build system) by using the target "test". In jdk/test/Makefile there is a test for an external variable ALT_OUTPUTDIR, which directs where the test results should be stored. The build-infra framework uses this to keep the test output in the corresponding build directory. >>> >>> However, while the code is very similar in langtools/test/Makefile, this exact feature is not available. This results in langtools tests being hardcoded to end up in a directory named as in the old build system. >>> >>> Here is a rather trivial patch that will add the ALT_OUTPUTDIR functionality to langtools as well. >>> >>> http://cr.openjdk.java.net/~ihse/support-build-infra-output-in-langtools-test/webrev.00/ >>> >>> I'm assuming someone in the langtools group should review this as well, and that it probably should go in via the -tl forest. I couldn't figure out what mailing list to reach the langtools group on though, so I'd appreaciate some help with forwarding this to the right persons. >>> >>> /Magnus >> From erik.joelsson at oracle.com Mon Oct 29 09:37:22 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Mon, 29 Oct 2012 10:37:22 +0100 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: <508AB762.1090606@oracle.com> References: <508AB762.1090606@oracle.com> Message-ID: <508E4E52.4060803@oracle.com> Looks good to me. On 2012-10-26 18:16, Alan Bateman wrote: > > We're jettisoning the legacy JDBC-ODBC bridge from Oracle's jdk8 > builds and this means updating several make files. Here's the webrev: > > http://cr.openjdk.java.net/~alanb/7176225/webrev/ > > I believe I got everything in the both builds. The only thing that > isn't clear is the old Def-solaris.gmk and whether MAPFILE_EXCEPTION > should be defined or set to () as I have it. > > Thanks, > > -Alan. From Ulf.Zibis at CoSoCo.de Mon Oct 29 11:57:07 2012 From: Ulf.Zibis at CoSoCo.de (Ulf Zibis) Date: Mon, 29 Oct 2012 12:57:07 +0100 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: <508B0313.9000403@oracle.com> References: <508AB762.1090606@oracle.com> <508AC32F.6080402@oracle.com> <508B0313.9000403@oracle.com> Message-ID: <508E6F13.3050105@CoSoCo.de> Am 26.10.2012 23:39, schrieb Alan Bateman: > > The JDBC-ODBC bridge has never been in OpenJDK, it's just the make files. I know, but is it still in Oracle JDK? > I don't think it has really been necessary for many years anyway as so many JDBC drivers available. For a quick connection to a MS Access DB it has been useful, even if not perfect. I'm not aware of any other free or open source JDBC-driver to connect to ... ... and MS Access is widely used by "semi-professionals" ;-) -Ulf From johnyeary at gmail.com Mon Oct 29 12:41:00 2012 From: johnyeary at gmail.com (John Yeary) Date: Mon, 29 Oct 2012 08:41:00 -0400 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: <508E6F13.3050105@CoSoCo.de> References: <508AB762.1090606@oracle.com> <508AC32F.6080402@oracle.com> <508B0313.9000403@oracle.com> <508E6F13.3050105@CoSoCo.de> Message-ID: Thanks Ulf, that was my exact point Ulf. Although, you were much more eloquent. One of the most consistent things that Java has done is ensuring backwards compatibility. The removal of something like the JDBC-ODBC bridge will cause issues later. We tell people to upgrade all the time. Security problems arise and we patch them followed by a message to tell folks to upgrade. The consumer JRE even has a reminder application which asks them if they want to upgrade. One click, and their applications stop working. Although I don't do anything now with MS Access, I see these nice Swing applications which end up with an Access database. The software that runs a number of Yoga studios has this configuration. It is the small businesses which rely on the cheaper Access based applications which will have problems. If ever there was a case for Jigsaw this is it. Oracle if you don't want to upgrade, or enhance it that is OK. However, leave it there for those who need it. Just my thoughts. John ____________________________ John Yeary ____________________________ *NetBeans Dream Team* *President Greenville Java Users Group Java Users Groups Community Leader Java Enterprise Community Leader* ____________________________ "Far better it is to dare mighty things, to win glorious triumphs, even though checkered by failure, than to take rank with those poor spirits who neither enjoy much nor suffer much, because they live in the gray twilight that knows not victory nor defeat." -- Theodore Roosevelt On Mon, Oct 29, 2012 at 7:57 AM, Ulf Zibis wrote: > Am 26.10.2012 23:39, schrieb Alan Bateman: > > >> The JDBC-ODBC bridge has never been in OpenJDK, it's just the make files. >> > > I know, but is it still in Oracle JDK? > > > I don't think it has really been necessary for many years anyway as so >> many JDBC drivers available. >> > > For a quick connection to a MS Access DB it has been useful, even if not > perfect. > I'm not aware of any other free or open source JDBC-driver to connect to > ... > ... and MS Access is widely used by "semi-professionals" ;-) > > -Ulf > > From anthony.petrov at oracle.com Mon Oct 29 15:37:50 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 29 Oct 2012 19:37:50 +0400 Subject: [8] Review request for 8001764: vsvars.sh should support VS2012 Message-ID: <508EA2CE.2070807@oracle.com> Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in order to set up the build environment, so I think the proposed changes should be useful. Once we start using VS2012 (or VS2014, or whatever it will be) for JDK, the vsvars.sh will already support that. -- best regards, Anthony From kelly.ohair at oracle.com Mon Oct 29 16:07:13 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 29 Oct 2012 09:07:13 -0700 Subject: [8] Review request for 8001764: vsvars.sh should support VS2012 In-Reply-To: <508EA2CE.2070807@oracle.com> References: <508EA2CE.2070807@oracle.com> Message-ID: Looks good to me. -kto On Oct 29, 2012, at 8:37 AM, Anthony Petrov wrote: > Hello, > > Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: > > http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ > > We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in order to set up the build environment, so I think the proposed changes should be useful. Once we start using VS2012 (or VS2014, or whatever it will be) for JDK, the vsvars.sh will already support that. > > -- > best regards, > Anthony From tim.bell at oracle.com Mon Oct 29 16:29:28 2012 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 29 Oct 2012 09:29:28 -0700 Subject: [8] Review request for 8001764: vsvars.sh should support VS2012 In-Reply-To: <508EA2CE.2070807@oracle.com> References: <508EA2CE.2070807@oracle.com> Message-ID: <508EAEE8.5080204@oracle.com> Anthony: > Please review a fix for > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: > > http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ These changes look fine. > We're not yet switching JDK builds to VS2012. However, the vsvars.sh > script is useful for other applications in order to set up the build > environment, so I think the proposed changes should be useful. Once we > start using VS2012 (or VS2014, or whatever it will be) for JDK, the > vsvars.sh will already support that. Changing compilers needs to come down from the release team. I hope you realize that. If they do not make a decision soon, VS2012 or later will wait until JDK9. Tim From magnus.ihse.bursie at oracle.com Mon Oct 29 17:32:13 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 29 Oct 2012 18:32:13 +0100 Subject: Request for Review: Support build-infra output directory in langtools test In-Reply-To: <807B6AEC-92C9-4E5E-BD5D-472A508AA89A@oracle.com> References: <5089258C.2060708@oracle.com> <70A5456A-B148-40D6-93AF-AE479F4A8ADF@oracle.com> <807B6AEC-92C9-4E5E-BD5D-472A508AA89A@oracle.com> Message-ID: <508EBD9D.2070004@oracle.com> On 2012-10-27 00:27, Kelly O'Hair wrote: >> The only important thing for integration with build-infra is that the langtools test makefile gets a customizable output directory, so it is not hard-coded to the old output directory. >> > Fair enough, but let's see if we can integrate that change into the jdk8/tl/langtools repository. > Jonathan Gibbons should look at the change if he has the time. Jon told me in a private mail: "It's a Makefile, so I defer to the Build Group experts." > >> The build-infra test integration currently calls test/Makefile in the root, and that works fine. I do not remeber if it is because it already has this variable, or because it does not output anything, but I suspect thr latter. >> >> I was not aware that the hotspot repo also shared this test logic, so I haven't checked there. > "sharing" is probably not the right word, "copied" would be better, unfortunately. :^( > > If we could put some shared test make logic in the top level common/makefiles area, we could try and share > that, but hotspot still has completely independent makefiles, so some copies might be needed for now, in hotspot. "Shared logic" might still have "copied code", if you understand what I mean. The jdk and langtools test files are copied as well, but they have the same input arguments etc. That what was I meant by "shared logic". But I agree completely that it would be better if common logic was extracted to the toplevel/common directory, possibly a new common/test if you want to keep test and build separated. /Magnus From christian.thalinger at oracle.com Mon Oct 29 17:42:12 2012 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Mon, 29 Oct 2012 10:42:12 -0700 Subject: Fwd: RFR: 8000780: make Zero build and run with JDK8 References: <1350515353.2097.80.camel@mercury> Message-ID: This patch contains a Makefile change: http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html -- Chris Begin forwarded message: > From: Roman Kennke > Subject: Re: RFR: Make Zero build and run with JDK8 > Date: October 17, 2012 4:09:13 PM PDT > To: Christian Thalinger > Cc: hotspot-dev at openjdk.java.net > > Am Mittwoch, den 17.10.2012, 15:34 -0700 schrieb Christian Thalinger: >> On Oct 17, 2012, at 3:05 PM, Roman Kennke wrote: >> >>> Am Mittwoch, den 17.10.2012, 14:40 -0700 schrieb Christian Thalinger: >>>> On Oct 16, 2012, at 8:01 AM, Roman Kennke wrote: >>>> >>>>> Hi Christian, >>>>> >>>>>>>>>> In the recent weeks I worked on the Zero interpreter, to get it to build >>>>>>>>>> and run with JDK8, and in particular with the latest changes that came >>>>>>>>>> from mlvm (meth-lazy). The following webrev applies to hsx/hotspot-main: >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.00/ >>>>>>>> >>>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>> >>>>>>>> - if (dest->blob() == NULL) { >>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>> >>>>>>>> Do we really need this when you have this: >>>>>>> >>>>>>> The above is needed, because the loop above it that initializes >>>>>>> dest_filled is never executed. However, I will change the test to >>>>>>> dest_filled != NULL :-) >>>>>>> >>>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>> >>>>>>>> - memset(to, value, count); >>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>> >>>>>>>> } >>>>>>> >>>>>>> Turns out that this is 1. not related to the other change above and 2. >>>>>>> not needed. I'll remove it. >>>>>>> >>>>>>>> src/share/vm/interpreter/interpreter.cpp: >>>>>>>> >>>>>>>> - assert(_entry_table[kind] == _entry_table[abstract], "previous value must be AME entry"); >>>>>>>> + assert(_entry_table[kind] == NULL || _entry_table[kind] == _entry_table[abstract], "previous value must be AME entry or NULL"); >>>>>>>> >>>>>>>> Why did you need that change? >>>>>>> >>>>>>> Apparently, before the whole table was initialized, and the methodhandle >>>>>>> related entries left as abstract. Now the methodhandle entries are >>>>>>> simply left to NULL. I suppose we could change the assert to >>>>>>> >>>>>>> assert(_entry_table[kind] == NULL, "previous value must be NULL"); >>>>>>> >>>>>>> Alternatively, we could fix the code that puts the other entries to also >>>>>>> set the methodhandle entries to AME and go back to the original assert. >>>>>>> What do you think? >>>>>> >>>>>> TemplateInterpreterGenerator::generate_all sets all MH entries to AME: >>>>>> >>>>>> // method handle entry kinds are generated later in MethodHandlesAdapterGenerator::generate: >>>>>> for (int i = Interpreter::method_handle_invoke_FIRST; i <= Interpreter::method_handle_invoke_LAST; i++) { >>>>>> Interpreter::MethodKind kind = (Interpreter::MethodKind) i; >>>>>> Interpreter::_entry_table[kind] = Interpreter::_entry_table[Interpreter::abstract]; >>>>>> } >>>>>> >>>>>> You need similar code in Zero. >>>>> >>>>> Alright, I extracted this piece of code into a separate protected method >>>>> void AbstractInterpreterGenerator::initializeMethodHandleEntries() and >>>>> call it both from templateInterpreter and cppInterpreter to initialize >>>>> the method handle entries to AME. >>>>> >>>>> This new webrev also reverts this: >>>>> >>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>> >>>>>>>> - memset(to, value, count); >>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>> >>>>>>>> } >>>>>> >>>>> >>>>> .. and changes the 0x0 to NULL here: >>>>> >>>>> >>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>> >>>>>>>> - if (dest->blob() == NULL) { >>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>> >>>>>> >>>>> >>>>> I tried JRuby a little more and verified that it's actually using +indy, >>>>> and it works all well. >>>>> >>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.01/ >>>> >>>> It seems this webrev contains the old changes. >>> >>> Arg! I did the changes in my hotspot-comp tree then made the webrev in >>> my hotspot-main :-) Here's the correct one: >>> >>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.02/ >> >> That looks better. The only thing is we don't use camel-case for methods: >> >> + void initializeMethodHandleEntries(); >> >> Could you change it to: >> >> + void initialize_method_handle_entries(); >> >> I would do it myself but I cannot verify that I didn't break Zero. I really should set up a build environment for Zero... > > Here it comes: > > http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/ > > I built both Zero and normal debug_build successfully. > > Cheers, > Roman > > From kelly.ohair at oracle.com Mon Oct 29 18:05:04 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 29 Oct 2012 11:05:04 -0700 Subject: RFR: 8000780: make Zero build and run with JDK8 In-Reply-To: References: <1350515353.2097.80.camel@mercury> Message-ID: <1EA174D1-768A-45AD-A836-7FDFD61EE93A@oracle.com> Looks fine. -kto On Oct 29, 2012, at 10:42 AM, Christian Thalinger wrote: > This patch contains a Makefile change: > > http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html > > -- Chris > > Begin forwarded message: > >> From: Roman Kennke >> Subject: Re: RFR: Make Zero build and run with JDK8 >> Date: October 17, 2012 4:09:13 PM PDT >> To: Christian Thalinger >> Cc: hotspot-dev at openjdk.java.net >> >> Am Mittwoch, den 17.10.2012, 15:34 -0700 schrieb Christian Thalinger: >>> On Oct 17, 2012, at 3:05 PM, Roman Kennke wrote: >>> >>>> Am Mittwoch, den 17.10.2012, 14:40 -0700 schrieb Christian Thalinger: >>>>> On Oct 16, 2012, at 8:01 AM, Roman Kennke wrote: >>>>> >>>>>> Hi Christian, >>>>>> >>>>>>>>>>> In the recent weeks I worked on the Zero interpreter, to get it to build >>>>>>>>>>> and run with JDK8, and in particular with the latest changes that came >>>>>>>>>>> from mlvm (meth-lazy). The following webrev applies to hsx/hotspot-main: >>>>>>>>>>> >>>>>>>>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.00/ >>>>>>>>> >>>>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>>> >>>>>>>>> - if (dest->blob() == NULL) { >>>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>>> >>>>>>>>> Do we really need this when you have this: >>>>>>>> >>>>>>>> The above is needed, because the loop above it that initializes >>>>>>>> dest_filled is never executed. However, I will change the test to >>>>>>>> dest_filled != NULL :-) >>>>>>>> >>>>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>>> >>>>>>>>> - memset(to, value, count); >>>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>>> >>>>>>>>> } >>>>>>>> >>>>>>>> Turns out that this is 1. not related to the other change above and 2. >>>>>>>> not needed. I'll remove it. >>>>>>>> >>>>>>>>> src/share/vm/interpreter/interpreter.cpp: >>>>>>>>> >>>>>>>>> - assert(_entry_table[kind] == _entry_table[abstract], "previous value must be AME entry"); >>>>>>>>> + assert(_entry_table[kind] == NULL || _entry_table[kind] == _entry_table[abstract], "previous value must be AME entry or NULL"); >>>>>>>>> >>>>>>>>> Why did you need that change? >>>>>>>> >>>>>>>> Apparently, before the whole table was initialized, and the methodhandle >>>>>>>> related entries left as abstract. Now the methodhandle entries are >>>>>>>> simply left to NULL. I suppose we could change the assert to >>>>>>>> >>>>>>>> assert(_entry_table[kind] == NULL, "previous value must be NULL"); >>>>>>>> >>>>>>>> Alternatively, we could fix the code that puts the other entries to also >>>>>>>> set the methodhandle entries to AME and go back to the original assert. >>>>>>>> What do you think? >>>>>>> >>>>>>> TemplateInterpreterGenerator::generate_all sets all MH entries to AME: >>>>>>> >>>>>>> // method handle entry kinds are generated later in MethodHandlesAdapterGenerator::generate: >>>>>>> for (int i = Interpreter::method_handle_invoke_FIRST; i <= Interpreter::method_handle_invoke_LAST; i++) { >>>>>>> Interpreter::MethodKind kind = (Interpreter::MethodKind) i; >>>>>>> Interpreter::_entry_table[kind] = Interpreter::_entry_table[Interpreter::abstract]; >>>>>>> } >>>>>>> >>>>>>> You need similar code in Zero. >>>>>> >>>>>> Alright, I extracted this piece of code into a separate protected method >>>>>> void AbstractInterpreterGenerator::initializeMethodHandleEntries() and >>>>>> call it both from templateInterpreter and cppInterpreter to initialize >>>>>> the method handle entries to AME. >>>>>> >>>>>> This new webrev also reverts this: >>>>>> >>>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>>> >>>>>>>>> - memset(to, value, count); >>>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>>> >>>>>>>>> } >>>>>>> >>>>>> >>>>>> .. and changes the 0x0 to NULL here: >>>>>> >>>>>> >>>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>>> >>>>>>>>> - if (dest->blob() == NULL) { >>>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>>> >>>>>>> >>>>>> >>>>>> I tried JRuby a little more and verified that it's actually using +indy, >>>>>> and it works all well. >>>>>> >>>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.01/ >>>>> >>>>> It seems this webrev contains the old changes. >>>> >>>> Arg! I did the changes in my hotspot-comp tree then made the webrev in >>>> my hotspot-main :-) Here's the correct one: >>>> >>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.02/ >>> >>> That looks better. The only thing is we don't use camel-case for methods: >>> >>> + void initializeMethodHandleEntries(); >>> >>> Could you change it to: >>> >>> + void initialize_method_handle_entries(); >>> >>> I would do it myself but I cannot verify that I didn't break Zero. I really should set up a build environment for Zero... >> >> Here it comes: >> >> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/ >> >> I built both Zero and normal debug_build successfully. >> >> Cheers, >> Roman >> >> > From christian.thalinger at oracle.com Mon Oct 29 18:09:06 2012 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Mon, 29 Oct 2012 11:09:06 -0700 Subject: RFR: 8000780: make Zero build and run with JDK8 In-Reply-To: <1EA174D1-768A-45AD-A836-7FDFD61EE93A@oracle.com> References: <1350515353.2097.80.camel@mercury> <1EA174D1-768A-45AD-A836-7FDFD61EE93A@oracle.com> Message-ID: Thank you, Kelly. -- Chris On Oct 29, 2012, at 11:05 AM, Kelly O'Hair wrote: > Looks fine. > > -kto > > On Oct 29, 2012, at 10:42 AM, Christian Thalinger wrote: > >> This patch contains a Makefile change: >> >> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html >> >> -- Chris >> >> Begin forwarded message: >> >>> From: Roman Kennke >>> Subject: Re: RFR: Make Zero build and run with JDK8 >>> Date: October 17, 2012 4:09:13 PM PDT >>> To: Christian Thalinger >>> Cc: hotspot-dev at openjdk.java.net >>> >>> Am Mittwoch, den 17.10.2012, 15:34 -0700 schrieb Christian Thalinger: >>>> On Oct 17, 2012, at 3:05 PM, Roman Kennke wrote: >>>> >>>>> Am Mittwoch, den 17.10.2012, 14:40 -0700 schrieb Christian Thalinger: >>>>>> On Oct 16, 2012, at 8:01 AM, Roman Kennke wrote: >>>>>> >>>>>>> Hi Christian, >>>>>>> >>>>>>>>>>>> In the recent weeks I worked on the Zero interpreter, to get it to build >>>>>>>>>>>> and run with JDK8, and in particular with the latest changes that came >>>>>>>>>>>> from mlvm (meth-lazy). The following webrev applies to hsx/hotspot-main: >>>>>>>>>>>> >>>>>>>>>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.00/ >>>>>>>>>> >>>>>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>>>> >>>>>>>>>> - if (dest->blob() == NULL) { >>>>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>>>> >>>>>>>>>> Do we really need this when you have this: >>>>>>>>> >>>>>>>>> The above is needed, because the loop above it that initializes >>>>>>>>> dest_filled is never executed. However, I will change the test to >>>>>>>>> dest_filled != NULL :-) >>>>>>>>> >>>>>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>>>> >>>>>>>>>> - memset(to, value, count); >>>>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>>>> >>>>>>>>>> } >>>>>>>>> >>>>>>>>> Turns out that this is 1. not related to the other change above and 2. >>>>>>>>> not needed. I'll remove it. >>>>>>>>> >>>>>>>>>> src/share/vm/interpreter/interpreter.cpp: >>>>>>>>>> >>>>>>>>>> - assert(_entry_table[kind] == _entry_table[abstract], "previous value must be AME entry"); >>>>>>>>>> + assert(_entry_table[kind] == NULL || _entry_table[kind] == _entry_table[abstract], "previous value must be AME entry or NULL"); >>>>>>>>>> >>>>>>>>>> Why did you need that change? >>>>>>>>> >>>>>>>>> Apparently, before the whole table was initialized, and the methodhandle >>>>>>>>> related entries left as abstract. Now the methodhandle entries are >>>>>>>>> simply left to NULL. I suppose we could change the assert to >>>>>>>>> >>>>>>>>> assert(_entry_table[kind] == NULL, "previous value must be NULL"); >>>>>>>>> >>>>>>>>> Alternatively, we could fix the code that puts the other entries to also >>>>>>>>> set the methodhandle entries to AME and go back to the original assert. >>>>>>>>> What do you think? >>>>>>>> >>>>>>>> TemplateInterpreterGenerator::generate_all sets all MH entries to AME: >>>>>>>> >>>>>>>> // method handle entry kinds are generated later in MethodHandlesAdapterGenerator::generate: >>>>>>>> for (int i = Interpreter::method_handle_invoke_FIRST; i <= Interpreter::method_handle_invoke_LAST; i++) { >>>>>>>> Interpreter::MethodKind kind = (Interpreter::MethodKind) i; >>>>>>>> Interpreter::_entry_table[kind] = Interpreter::_entry_table[Interpreter::abstract]; >>>>>>>> } >>>>>>>> >>>>>>>> You need similar code in Zero. >>>>>>> >>>>>>> Alright, I extracted this piece of code into a separate protected method >>>>>>> void AbstractInterpreterGenerator::initializeMethodHandleEntries() and >>>>>>> call it both from templateInterpreter and cppInterpreter to initialize >>>>>>> the method handle entries to AME. >>>>>>> >>>>>>> This new webrev also reverts this: >>>>>>> >>>>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>>>> >>>>>>>>>> - memset(to, value, count); >>>>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>>>> >>>>>>>>>> } >>>>>>>> >>>>>>> >>>>>>> .. and changes the 0x0 to NULL here: >>>>>>> >>>>>>> >>>>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>>>> >>>>>>>>>> - if (dest->blob() == NULL) { >>>>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> I tried JRuby a little more and verified that it's actually using +indy, >>>>>>> and it works all well. >>>>>>> >>>>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.01/ >>>>>> >>>>>> It seems this webrev contains the old changes. >>>>> >>>>> Arg! I did the changes in my hotspot-comp tree then made the webrev in >>>>> my hotspot-main :-) Here's the correct one: >>>>> >>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.02/ >>>> >>>> That looks better. The only thing is we don't use camel-case for methods: >>>> >>>> + void initializeMethodHandleEntries(); >>>> >>>> Could you change it to: >>>> >>>> + void initialize_method_handle_entries(); >>>> >>>> I would do it myself but I cannot verify that I didn't break Zero. I really should set up a build environment for Zero... >>> >>> Here it comes: >>> >>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/ >>> >>> I built both Zero and normal debug_build successfully. >>> >>> Cheers, >>> Roman >>> >>> >> > From magnus.ihse.bursie at oracle.com Mon Oct 29 18:45:17 2012 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 29 Oct 2012 19:45:17 +0100 Subject: jdk8 makefile changes In-Reply-To: <4FFB7E64.5010507@oracle.COM> References: <6E1102AE-5167-4FA8-888F-264EDA515E4C@oracle.com> <6D686E00-4ABF-4D27-B9CA-A86004DA655A@oracle.com> <4FFB6E8D.1010409@oracle.COM> <4FFB7539.5070309@oracle.com> <4FFB7E64.5010507@oracle.COM> Message-ID: <508ECEBD.4080509@oracle.com> Hi Kumar, I know it is a long time since you wrote this, but there have been several changes to build-infra lately that might help with your issues. We filter out the GNU link command. We try harder to locate VS10, and if still not found, it can be set using "sh configure --with-tools-dir=". These changes are currently in the build forest, and is scheduled to be integrated to the master forest this Wednesday. You might want to test again using this latest version. Hopefully this time you'll get a smooth ride. /Magnus On 2012-07-10 02:59, Kumar Srinivasan wrote: > nOn 7/9/2012 5:20 PM, David Holmes wrote: >> On 10/07/2012 9:51 AM, Kumar Srinivasan wrote: >>> On windows, I see a failure when building hotspot, as as follows. >>> Kumar >>> >>> link.exe /SAFESEH /manifest kernel32.lib user32.lib gdi32.lib >>> winspool.lib codlg32.lib advapi32.lib shell32.lib ole32.lib >>> oleaut32.lib uuid.lib >>> Wsock32.lib winmm.lib /nologo /machine:I386 /opt:REF /opt:ICF,8 /map >>> /debug >>> psapi.lib /subystem:console /out:adlc.exe main.obj adlparse.obj >>> archDesc.obj arena.obj >>> dfa.ob dict2.obj filebuff.obj forms.obj formsopt.obj formssel.obj >>> opcodes.obj >>> output_.obj output_h.obj >>> /usr/bin/link: extra operand `kernel32.lib' >> >> It looks like it is trying to run the GNU link command instead of the >> Visual Studio one. > one other clue, VS10 is not in its standard install location, setting > the path to the VS's link > does not help, so autoconf has inferred the wrong path it seems. > > Kumar > > >> >> David >> ----- >> >> >>> Try `/usr/bin/link --help' for more information. >>> NMAKE : fatal error U1077: >>> 'C:\WORKSP~1\JDK8-B~1\build\WINDOW~1\UNCYGD~1.EXE' : >>> return code '0x1' >>> Stop. >>> NMAKE : fatal error U1077: 'cd' : return code '0x2' >>> Stop. >>> NMAKE : fatal error U1077: '"C:\Program Files\MSVS10\VC\BIN\nmake.EXE"' >>> : retur >>> code '0x2' >>> Stop. >>> make[2]: *** [generic_build2] Error 2 >>> make[1]: *** [product] Error 2 >>> make: *** [hotspot-only] Error 2 >>>> The jdk8/build forest has been in sync for a few days, so anyone >>>> willing to try the new build system with OpenJDK 8, please >>>> follow these instructions: >>>> >>>> hg clone http://hg.openjdk.java.net/jdk8/build jdk8-build >>>> cd jdk8-build >>>> sh ./get_source.sh >>>> cd common/makefiles >>>> ../autoconf/configure >>>> make images >>>> >>>> Let us know what works, what doesn't. >>>> >>>> Many of us will be concentrating on binary comparisons over the next >>>> few days to insure that we are building >>>> everything we did before, and the same content. >>>> >>>> -kto >>>> >>>> On Jul 3, 2012, at 11:38 AM, Kelly O'Hair wrote: >>>> >>>>> Heads up... >>>>> >>>>> We expect to do a sync up of the jdk8/build forest with the latest in >>>>> the build-infra forest in the next few days. >>>>> >>>>> As the new build-infra project starts getting more solid and we >>>>> contemplate when we can switch >>>>> the default to building with the new build-infra Makefiles (we don't >>>>> know exactly when yet). >>>>> >>>>> **** IMPORTANT NOTICE **** >>>>> It will be important that *anyone* making *any* changes to the jdk8 >>>>> Makefiles keep the build-dev >>>>> or build-infra mailing lists informed. >>>>> For a period of time we need to maintain two separate build >>>>> mechanisms, and we want to make sure >>>>> that both build the same thing. >>>>> The hotspot repository is the one exception where we don't have two >>>>> sets of makefiles, but we still >>>>> would like to know when anyone is changing the makefiles or anything >>>>> to do with the build process. >>>>> ***************************** >>>>> >>>>> We will soon be running both builds and doing comparisons of the >>>>> resulting j2sdk-image files from >>>>> both to insure we match. So if we detect differences we will be >>>>> tracking down how those differences >>>>> happened (that's a hint that we will be watching :^). >>>>> >>>>> More information on the new build-infra Makefiles can be found at: >>>>> http://openjdk.java.net/projects/build-infra/ >>>>> >>>>> User Guide is at: >>>>> http://openjdk.java.net/projects/build-infra/guide.html >>>>> >>>>> Some preliminary timings for building the product image (effectively, >>>>> build/j2sdk-image/): >>>>> OLD NEW build-infra times (All estimates, similar VMs/Zones) >>>>> linux_i586 (21m 59s) (08m 13s) >>>>> linux_x64 (13m 34s) (07m 04s) >>>>> solaris_i586 (26m 14s) (11m 31s) >>>>> solaris_sparc (54m 02s) (28m 21s) >>>>> windows_i586 (55m 49s) (32m 22s) (old used MKS, build-infra only uses >>>>> CYGWIN) >>>>> windows_x64 (36m 36s) (23m 50s) " " " >>>>> >>>>> Notes: >>>>> * Machines with more processors will reduce the build time for >>>>> build-infra builds, less so with the old Makefiles. >>>>> * Always use local disk or /tmp (all above timings use /tmp, always >>>>> local disk) >>>>> * Above uses VMs for Windows and Linux, raw hardware would be faster >>>>> * Use of ccache can sometimes speed things up, but can also skew the >>>>> timings, >>>>> in the above measurements OLD used ccache, NEW did not. >>>>> >>>>> -kto >>> > From anthony.petrov at oracle.com Mon Oct 29 19:06:09 2012 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Mon, 29 Oct 2012 23:06:09 +0400 Subject: [8] Review request for 8001764: vsvars.sh should support VS2012 In-Reply-To: <508EAEE8.5080204@oracle.com> References: <508EA2CE.2070807@oracle.com> <508EAEE8.5080204@oracle.com> Message-ID: <508ED3A1.3080405@oracle.com> Tim, Kelly: thanks for your review. I'll push the fix via the awt forest tomorrow. On 10/29/2012 8:29 PM, Tim Bell wrote: >> We're not yet switching JDK builds to VS2012. However, the vsvars.sh >> script is useful for other applications in order to set up the build >> environment, so I think the proposed changes should be useful. Once we >> start using VS2012 (or VS2014, or whatever it will be) for JDK, the >> vsvars.sh will already support that. > > Changing compilers needs to come down from the release team. I hope you > realize that. If they do not make a decision soon, VS2012 or later will > wait until JDK9. That's correct. Currently we don't have any plans to change compilers for JDK 8. It will be discussed with the release team when need arises. -- best regards, Anthony From kelly.ohair at oracle.com Mon Oct 29 19:09:23 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Mon, 29 Oct 2012 12:09:23 -0700 Subject: [8] Review request for 8001764: vsvars.sh should support VS2012 In-Reply-To: <508ED3A1.3080405@oracle.com> References: <508EA2CE.2070807@oracle.com> <508EAEE8.5080204@oracle.com> <508ED3A1.3080405@oracle.com> Message-ID: On Oct 29, 2012, at 12:06 PM, Anthony Petrov wrote: > Tim, Kelly: thanks for your review. I'll push the fix via the awt forest tomorrow. Great. Thanks for making the change. -kto > > On 10/29/2012 8:29 PM, Tim Bell wrote: >>> We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in order to set up the build environment, so I think the proposed changes should be useful. Once we start using VS2012 (or VS2014, or whatever it will be) for JDK, the vsvars.sh will already support that. >> Changing compilers needs to come down from the release team. I hope you realize that. If they do not make a decision soon, VS2012 or later will wait until JDK9. > > That's correct. Currently we don't have any plans to change compilers for JDK 8. It will be discussed with the release team when need arises. > > -- > best regards, > Anthony From tim.bell at oracle.com Mon Oct 29 19:20:53 2012 From: tim.bell at oracle.com (Tim Bell) Date: Mon, 29 Oct 2012 12:20:53 -0700 Subject: [8] Review request for 8001764: vsvars.sh should support VS2012 In-Reply-To: <508ED3A1.3080405@oracle.com> References: <508EA2CE.2070807@oracle.com> <508EAEE8.5080204@oracle.com> <508ED3A1.3080405@oracle.com> Message-ID: <508ED715.3040809@oracle.com> On 10/29/12 12:06, Anthony Petrov wrote: > That's correct. Currently we don't have any plans to change compilers > for JDK 8. It will be discussed with the release team when need arises. OK, thanks. Sorry if I sounded a bit fussy, but I want to avoid last minute surprises if we can, and it is better to over communicate. Best Regards- Tim From kelly.ohair at oracle.com Mon Oct 29 20:05:40 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 29 Oct 2012 20:05:40 +0000 Subject: hg: jdk8/build/jdk: 8001887: build-infra: Correct mapfiles in build-infra area Message-ID: <20121029200631.57F4747656@hg.openjdk.java.net> Changeset: 5b29d6157504 Author: erikj Date: 2012-10-29 13:04 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5b29d6157504 8001887: build-infra: Correct mapfiles in build-infra area Reviewed-by: ohair ! makefiles/mapfiles/libnio/mapfile-linux ! makefiles/mapfiles/libnio/mapfile-macosx ! makefiles/mapfiles/libnio/mapfile-solaris From kelly.ohair at oracle.com Mon Oct 29 20:43:12 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 29 Oct 2012 20:43:12 +0000 Subject: hg: jdk8/build/jdk: 8001891: build-infra: Adding X_CFLAGS and X_LIBS to lwawt and sizer compilation Message-ID: <20121029204345.ACD3647659@hg.openjdk.java.net> Changeset: dcee387cde81 Author: ohrstrom Date: 2012-10-29 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dcee387cde81 8001891: build-infra: Adding X_CFLAGS and X_LIBS to lwawt and sizer compilation Reviewed-by: ohair ! makefiles/CompileNativeLibraries.gmk ! makefiles/GensrcX11Wrappers.gmk From kelly.ohair at oracle.com Mon Oct 29 20:56:15 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 29 Oct 2012 20:56:15 +0000 Subject: hg: jdk8/build/jdk: 8001898: build-infra: correct exclusion lists for mac jar builds; ... Message-ID: <20121029205646.2C1BD4765B@hg.openjdk.java.net> Changeset: 524d1a705f7b Author: erikj Date: 2012-10-29 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/524d1a705f7b 8001898: build-infra: correct exclusion lists for mac jar builds 8001896: build-infra: UNLIMITED_CRYPTO changes Reviewed-by: ohair ! makefiles/CreateJars.gmk From kelly.ohair at oracle.com Mon Oct 29 21:08:21 2012 From: kelly.ohair at oracle.com (kelly.ohair at oracle.com) Date: Mon, 29 Oct 2012 21:08:21 +0000 Subject: hg: jdk8/build: 8001897: build-infra: misc adjustments to configure script Message-ID: <20121029210821.CCB8B4765C@hg.openjdk.java.net> Changeset: e3182741ade2 Author: ihse Date: 2012-10-29 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/e3182741ade2 8001897: build-infra: misc adjustments to configure script Reviewed-by: ohair ! common/autoconf/Makefile.in ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 From Alan.Bateman at oracle.com Tue Oct 30 11:55:19 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 30 Oct 2012 11:55:19 +0000 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: References: <508AB762.1090606@oracle.com> <508AC32F.6080402@oracle.com> <508B0313.9000403@oracle.com> <508E6F13.3050105@CoSoCo.de> Message-ID: <508FC027.1080901@oracle.com> On 29/10/2012 12:41, John Yeary wrote: > Thanks Ulf, that was my exact point Ulf. Although, you were much more > eloquent. > > One of the most consistent things that Java has done is ensuring backwards > compatibility. The removal of something like the JDBC-ODBC bridge will > cause issues later. We tell people to upgrade all the time. Security > problems arise and we patch them followed by a message to tell folks to > upgrade. The consumer JRE even has a reminder application which asks them > if they want to upgrade. One click, and their applications stop working. > > Although I don't do anything now with MS Access, I see these nice Swing > applications which end up with an Access database. The software that runs a > number of Yoga studios has this configuration. It is the small businesses > which rely on the cheaper Access based applications which will have > problems. > The JDBC-ODBC bridge was a useful stop-gap 10+ years ago when there wasn't JDBC drivers available for all databases. It has never supported to my knowledge and the recommendation has always been to use a JDBC driver for the database. For those that are still using it then they have another year to find an alternative. I don't think that is too unreasonable. There will of course be a warning on the download pages that developers will see. For MS Access there are several JDBC drivers available, many of which support JDBC 4.1. There are also other alternatives such as MySQL or Derby available that might be better anyway. I think your point about communities or developers that have been using it and aren't reading download pages, release notes or blogs is valid concern. Any help reaching out to those communities would be appreciated. As regards releasing the source code then this is easier said than done. The JDBC-ODBC bridge came from a third-party originally. To be honest I don't think it's worth the cost and effort anyway as it's completely obsolete. If folks really see a need for this then it provides an opportunity to start up a new project to develop a modern JDBC-ODBC bridge. -Alan From naoto.sato at oracle.com Tue Oct 30 16:33:43 2012 From: naoto.sato at oracle.com (Naoto Sato) Date: Tue, 30 Oct 2012 09:33:43 -0700 Subject: [8]Review request: 8001231 : Move locale data out of rt.jar (except the US locale) Message-ID: <50900167.80805@oracle.com> Hello, I need someone to review my changes to the following bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001231 The fix is to move locale data out of rt.jar into localedata.jar which will be optional in the compact profile (http://openjdk.java.net/jeps/161) The gist of the changes are in FILES_* files, but I also modified the makefiles for the new build-infra build. So I would appreciate your review in this area as well. The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8001231/webrev.00/ Naoto From david.holmes at oracle.com Wed Oct 31 07:29:58 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 31 Oct 2012 17:29:58 +1000 Subject: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling Message-ID: <5090D376.4080204@oracle.com> http://cr.openjdk.java.net/~dholmes/8002034/webrev/ This mainly addresses JDK-8002034 Allow Full Debug Symbols when cross-compiling The initial FDS work simply disables FDS when cross-compilation is involved. But we're now ready to deal with the cross-compilation case (and even if we weren't these changes would be fine anyway). So if FDS is initially enabled we will rely on ALT_OBJCOPY being set to the correct value for cross-compilation; and we don't set the default OBJCOPY in that case. So if you do nothing when cross-compiling OBJCOPY will be empty and that will cause the build to disable FDS, just as if the OBJCOPY command was not found. As this is the same code that causes: JDK-8001756 Hotspot makefiles report missing OBJCOPY command in the wrong circumstances I also fixed this by moving the OBJCOPY checks inside the ENABLE_FULL_DEBUG_SYMBOLS=1 conditional. Basically unless we are asking for FDS we shouldn't complain if the OBJCOPY command is not found. This will be pushed to the hotspot-emb repo as it is needed there ASAP. I'll be doing a similar change, under 8002040, for the JDK side of things. Thanks, David From Alan.Bateman at oracle.com Wed Oct 31 10:06:46 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 31 Oct 2012 10:06:46 +0000 Subject: [8]Review request: 8001231 : Move locale data out of rt.jar (except the US locale) In-Reply-To: <50900167.80805@oracle.com> References: <50900167.80805@oracle.com> Message-ID: <5090F836.7040801@oracle.com> On 30/10/2012 16:33, Naoto Sato wrote: > Hello, > > I need someone to review my changes to the following bug: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001231 > > The fix is to move locale data out of rt.jar into localedata.jar which > will be optional in the compact profile > (http://openjdk.java.net/jeps/161) The gist of the changes are in > FILES_* files, but I also modified the makefiles for the new > build-infra build. So I would appreciate your review in this area as > well. > > The proposed fix is located at: > > http://cr.openjdk.java.net/~naoto/8001231/webrev.00/ > > Naoto I looked through the changes and they look fine to me, it's good to have this separation. Also good to see that you've also updated the makefiles for the new build system. If we were continuing with the old build system then I would suggested using AUTO_FILES_JAVA_DIRS as there shouldn't be a need to list every source file for every locale in the make files. The only question I have is whether there is any performance implications for the western Europe locales. I don't know if we've got any tests that would tell us whether this is significant or not. -Alan From erik.joelsson at oracle.com Wed Oct 31 10:20:39 2012 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 31 Oct 2012 11:20:39 +0100 Subject: [8]Review request: 8001231 : Move locale data out of rt.jar (except the US locale) In-Reply-To: <50900167.80805@oracle.com> References: <50900167.80805@oracle.com> Message-ID: <5090FB77.4020302@oracle.com> I have looked through and compared the build output of old and new build. It looks good to me. /Erik On 2012-10-30 17:33, Naoto Sato wrote: > Hello, > > I need someone to review my changes to the following bug: > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001231 > > The fix is to move locale data out of rt.jar into localedata.jar which > will be optional in the compact profile > (http://openjdk.java.net/jeps/161) The gist of the changes are in > FILES_* files, but I also modified the makefiles for the new > build-infra build. So I would appreciate your review in this area as > well. > > The proposed fix is located at: > > http://cr.openjdk.java.net/~naoto/8001231/webrev.00/ > > Naoto From kumar.x.srinivasan at oracle.COM Wed Oct 31 17:43:54 2012 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Wed, 31 Oct 2012 10:43:54 -0700 Subject: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK Message-ID: <5091635A.3010000@oracle.COM> Hello, Please review changes to rev up the default -source and -target for jdk compilation, thus producing v52.0 class files. Bug is here: https://jbs.oracle.com/bugs/browse/JDK-8001191 Webrev is here: http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/ Note: this webrev is generated against the master repository but changes will be pushed via tl after the tl-master sync is completed. Thanks Kumar From mike.duigou at oracle.com Wed Oct 31 18:08:23 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 31 Oct 2012 11:08:23 -0700 Subject: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK In-Reply-To: <5091635A.3010000@oracle.COM> References: <5091635A.3010000@oracle.COM> Message-ID: Looks good. make/java/invoke/Makefile: I have had good success in the lambda repo with just removing the version directives from this file. They date from early days of 292 and are no longer relevant. The package compiles just fine using the global default now. On Oct 31 2012, at 10:43 , Kumar Srinivasan wrote: > Hello, > > Please review changes to rev up the default -source and -target for jdk compilation, > thus producing v52.0 class files. > > Bug is here: > https://jbs.oracle.com/bugs/browse/JDK-8001191 > > Webrev is here: > http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/ > > Note: this webrev is generated against the master repository but changes will be > pushed via tl after the tl-master sync is completed. > > Thanks > Kumar > From naoto.sato at oracle.com Wed Oct 31 18:12:17 2012 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 31 Oct 2012 11:12:17 -0700 Subject: [8]Review request: 8001231 : Move locale data out of rt.jar (except the US locale) In-Reply-To: <5090F836.7040801@oracle.com> References: <50900167.80805@oracle.com> <5090F836.7040801@oracle.com> Message-ID: <50916A01.5000201@oracle.com> Thank you for the review, Alan. On 10/31/12 3:06 AM, Alan Bateman wrote: > I looked through the changes and they look fine to me, it's good to have > this separation. Also good to see that you've also updated the makefiles > for the new build system. If we were continuing with the old build > system then I would suggested using AUTO_FILES_JAVA_DIRS as there > shouldn't be a need to list every source file for every locale in the > make files. Only tricky part is that for the US locale, it's not automatic. US and non-US locale data co-exist in sun/text/resources/en and sun/util/resources/en. Considering the traditional build is going away, I just modified the existing file lists to work with the desired US/non-US separation. > The only question I have is whether there is any performance > implications for the western Europe locales. I don't know if we've got > any tests that would tell us whether this is significant or not. Will look into this and come up with some data. Naoto From kumar.x.srinivasan at oracle.COM Wed Oct 31 18:18:42 2012 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Wed, 31 Oct 2012 11:18:42 -0700 Subject: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK In-Reply-To: References: <5091635A.3010000@oracle.COM> Message-ID: <50916B82.6060601@oracle.COM> > Looks good. > > make/java/invoke/Makefile: > I have had good success in the lambda repo with just removing the version directives from this file. They date from early days of 292 and are no longer relevant. The package compiles just fine using the global default now. Lets address this as separate issue when we start the lambda merges. Kumar > > On Oct 31 2012, at 10:43 , Kumar Srinivasan wrote: > >> Hello, >> >> Please review changes to rev up the default -source and -target for jdk compilation, >> thus producing v52.0 class files. >> >> Bug is here: >> https://jbs.oracle.com/bugs/browse/JDK-8001191 >> >> Webrev is here: >> http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/ >> >> Note: this webrev is generated against the master repository but changes will be >> pushed via tl after the tl-master sync is completed. >> >> Thanks >> Kumar >> From chris.hegarty at oracle.com Wed Oct 31 20:45:29 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 31 Oct 2012 20:45:29 +0000 Subject: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK In-Reply-To: <5091635A.3010000@oracle.COM> References: <5091635A.3010000@oracle.COM> Message-ID: Looks fine Kumar. -Chris On 31 Oct 2012, at 17:43, Kumar Srinivasan wrote: > Hello, > > Please review changes to rev up the default -source and -target for jdk compilation, > thus producing v52.0 class files. > > Bug is here: > https://jbs.oracle.com/bugs/browse/JDK-8001191 > > Webrev is here: > http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/ > > Note: this webrev is generated against the master repository but changes will be > pushed via tl after the tl-master sync is completed. > > Thanks > Kumar > From christian.thalinger at oracle.com Thu Oct 18 17:53:59 2012 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Thu, 18 Oct 2012 17:53:59 -0000 Subject: Fwd: RFR: 8000780: make Zero build and run with JDK8 References: <1350515353.2097.80.camel@mercury> Message-ID: <3426220D-520E-4A65-B3E0-829E28F197E8@oracle.com> This patch contains a Makefile change: http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html -- Chris Begin forwarded message: > From: Roman Kennke > Subject: Re: RFR: Make Zero build and run with JDK8 > Date: October 17, 2012 4:09:13 PM PDT > To: Christian Thalinger > Cc: hotspot-dev at openjdk.java.net > > Am Mittwoch, den 17.10.2012, 15:34 -0700 schrieb Christian Thalinger: >> On Oct 17, 2012, at 3:05 PM, Roman Kennke wrote: >> >>> Am Mittwoch, den 17.10.2012, 14:40 -0700 schrieb Christian Thalinger: >>>> On Oct 16, 2012, at 8:01 AM, Roman Kennke wrote: >>>> >>>>> Hi Christian, >>>>> >>>>>>>>>> In the recent weeks I worked on the Zero interpreter, to get it to build >>>>>>>>>> and run with JDK8, and in particular with the latest changes that came >>>>>>>>>> from mlvm (meth-lazy). The following webrev applies to hsx/hotspot-main: >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.00/ >>>>>>>> >>>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>> >>>>>>>> - if (dest->blob() == NULL) { >>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>> >>>>>>>> Do we really need this when you have this: >>>>>>> >>>>>>> The above is needed, because the loop above it that initializes >>>>>>> dest_filled is never executed. However, I will change the test to >>>>>>> dest_filled != NULL :-) >>>>>>> >>>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>> >>>>>>>> - memset(to, value, count); >>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>> >>>>>>>> } >>>>>>> >>>>>>> Turns out that this is 1. not related to the other change above and 2. >>>>>>> not needed. I'll remove it. >>>>>>> >>>>>>>> src/share/vm/interpreter/interpreter.cpp: >>>>>>>> >>>>>>>> - assert(_entry_table[kind] == _entry_table[abstract], "previous value must be AME entry"); >>>>>>>> + assert(_entry_table[kind] == NULL || _entry_table[kind] == _entry_table[abstract], "previous value must be AME entry or NULL"); >>>>>>>> >>>>>>>> Why did you need that change? >>>>>>> >>>>>>> Apparently, before the whole table was initialized, and the methodhandle >>>>>>> related entries left as abstract. Now the methodhandle entries are >>>>>>> simply left to NULL. I suppose we could change the assert to >>>>>>> >>>>>>> assert(_entry_table[kind] == NULL, "previous value must be NULL"); >>>>>>> >>>>>>> Alternatively, we could fix the code that puts the other entries to also >>>>>>> set the methodhandle entries to AME and go back to the original assert. >>>>>>> What do you think? >>>>>> >>>>>> TemplateInterpreterGenerator::generate_all sets all MH entries to AME: >>>>>> >>>>>> // method handle entry kinds are generated later in MethodHandlesAdapterGenerator::generate: >>>>>> for (int i = Interpreter::method_handle_invoke_FIRST; i <= Interpreter::method_handle_invoke_LAST; i++) { >>>>>> Interpreter::MethodKind kind = (Interpreter::MethodKind) i; >>>>>> Interpreter::_entry_table[kind] = Interpreter::_entry_table[Interpreter::abstract]; >>>>>> } >>>>>> >>>>>> You need similar code in Zero. >>>>> >>>>> Alright, I extracted this piece of code into a separate protected method >>>>> void AbstractInterpreterGenerator::initializeMethodHandleEntries() and >>>>> call it both from templateInterpreter and cppInterpreter to initialize >>>>> the method handle entries to AME. >>>>> >>>>> This new webrev also reverts this: >>>>> >>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>> >>>>>>>> - memset(to, value, count); >>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>> >>>>>>>> } >>>>>> >>>>> >>>>> .. and changes the 0x0 to NULL here: >>>>> >>>>> >>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>> >>>>>>>> - if (dest->blob() == NULL) { >>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>> >>>>>> >>>>> >>>>> I tried JRuby a little more and verified that it's actually using +indy, >>>>> and it works all well. >>>>> >>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.01/ >>>> >>>> It seems this webrev contains the old changes. >>> >>> Arg! I did the changes in my hotspot-comp tree then made the webrev in >>> my hotspot-main :-) Here's the correct one: >>> >>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.02/ >> >> That looks better. The only thing is we don't use camel-case for methods: >> >> + void initializeMethodHandleEntries(); >> >> Could you change it to: >> >> + void initialize_method_handle_entries(); >> >> I would do it myself but I cannot verify that I didn't break Zero. I really should set up a build environment for Zero... > > Here it comes: > > http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/ > > I built both Zero and normal debug_build successfully. > > Cheers, > Roman > > From dan.xu at oracle.com Mon Oct 22 21:55:00 2012 From: dan.xu at oracle.com (Dan Xu) Date: Mon, 22 Oct 2012 21:55:00 -0000 Subject: Make File Changes For CR4239752 Message-ID: <5085C0B5.7040809@oracle.com> Hi, I have a bug fix which needs make file changes, which can be reviewed at http://cr.openjdk.java.net/~dxu/4239752/webrev/. With the above make file changes, I am able to build jdk successfully in old build system. But if I built it using new build system, the build process failed and complained about missing generated header file, java_io_FileSystem.h. I wonder how I can make the equivalent make file changes in the new build-infra Makefiles. Thanks! -Dan From christian.thalinger at oracle.com Thu Oct 25 22:41:40 2012 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Thu, 25 Oct 2012 15:41:40 -0700 Subject: Fwd: RFR: 8000780: make Zero build and run with JDK8 References: <1350515353.2097.80.camel@mercury> Message-ID: <3BB1FDD5-29B3-4D47-B48E-FEBB6FD2AB85@oracle.com> This patch contains a Makefile change: http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/make/Makefile.udiff.html -- Chris Begin forwarded message: > From: Roman Kennke > Subject: Re: RFR: Make Zero build and run with JDK8 > Date: October 17, 2012 4:09:13 PM PDT > To: Christian Thalinger > Cc: hotspot-dev at openjdk.java.net > > Am Mittwoch, den 17.10.2012, 15:34 -0700 schrieb Christian Thalinger: >> On Oct 17, 2012, at 3:05 PM, Roman Kennke wrote: >> >>> Am Mittwoch, den 17.10.2012, 14:40 -0700 schrieb Christian Thalinger: >>>> On Oct 16, 2012, at 8:01 AM, Roman Kennke wrote: >>>> >>>>> Hi Christian, >>>>> >>>>>>>>>> In the recent weeks I worked on the Zero interpreter, to get it to build >>>>>>>>>> and run with JDK8, and in particular with the latest changes that came >>>>>>>>>> from mlvm (meth-lazy). The following webrev applies to hsx/hotspot-main: >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.00/ >>>>>>>> >>>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>> >>>>>>>> - if (dest->blob() == NULL) { >>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>> >>>>>>>> Do we really need this when you have this: >>>>>>> >>>>>>> The above is needed, because the loop above it that initializes >>>>>>> dest_filled is never executed. However, I will change the test to >>>>>>> dest_filled != NULL :-) >>>>>>> >>>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>> >>>>>>>> - memset(to, value, count); >>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>> >>>>>>>> } >>>>>>> >>>>>>> Turns out that this is 1. not related to the other change above and 2. >>>>>>> not needed. I'll remove it. >>>>>>> >>>>>>>> src/share/vm/interpreter/interpreter.cpp: >>>>>>>> >>>>>>>> - assert(_entry_table[kind] == _entry_table[abstract], "previous value must be AME entry"); >>>>>>>> + assert(_entry_table[kind] == NULL || _entry_table[kind] == _entry_table[abstract], "previous value must be AME entry or NULL"); >>>>>>>> >>>>>>>> Why did you need that change? >>>>>>> >>>>>>> Apparently, before the whole table was initialized, and the methodhandle >>>>>>> related entries left as abstract. Now the methodhandle entries are >>>>>>> simply left to NULL. I suppose we could change the assert to >>>>>>> >>>>>>> assert(_entry_table[kind] == NULL, "previous value must be NULL"); >>>>>>> >>>>>>> Alternatively, we could fix the code that puts the other entries to also >>>>>>> set the methodhandle entries to AME and go back to the original assert. >>>>>>> What do you think? >>>>>> >>>>>> TemplateInterpreterGenerator::generate_all sets all MH entries to AME: >>>>>> >>>>>> // method handle entry kinds are generated later in MethodHandlesAdapterGenerator::generate: >>>>>> for (int i = Interpreter::method_handle_invoke_FIRST; i <= Interpreter::method_handle_invoke_LAST; i++) { >>>>>> Interpreter::MethodKind kind = (Interpreter::MethodKind) i; >>>>>> Interpreter::_entry_table[kind] = Interpreter::_entry_table[Interpreter::abstract]; >>>>>> } >>>>>> >>>>>> You need similar code in Zero. >>>>> >>>>> Alright, I extracted this piece of code into a separate protected method >>>>> void AbstractInterpreterGenerator::initializeMethodHandleEntries() and >>>>> call it both from templateInterpreter and cppInterpreter to initialize >>>>> the method handle entries to AME. >>>>> >>>>> This new webrev also reverts this: >>>>> >>>>>>> static void pd_fill_to_bytes(void* to, size_t count, jubyte value) { >>>>>>>> >>>>>>>> - memset(to, value, count); >>>>>>>> + if ( count > 0 ) memset(to, value, count); >>>>>>>> >>>>>>>> } >>>>>> >>>>> >>>>> .. and changes the 0x0 to NULL here: >>>>> >>>>> >>>>>>> src/share/vm/asm/codeBuffer.cpp: >>>>>>>> >>>>>>>> - if (dest->blob() == NULL) { >>>>>>>> + if (dest->blob() == NULL && dest_filled != 0x0) { >>>>>>>> >>>>>> >>>>> >>>>> I tried JRuby a little more and verified that it's actually using +indy, >>>>> and it works all well. >>>>> >>>>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.01/ >>>> >>>> It seems this webrev contains the old changes. >>> >>> Arg! I did the changes in my hotspot-comp tree then made the webrev in >>> my hotspot-main :-) Here's the correct one: >>> >>> http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.02/ >> >> That looks better. The only thing is we don't use camel-case for methods: >> >> + void initializeMethodHandleEntries(); >> >> Could you change it to: >> >> + void initialize_method_handle_entries(); >> >> I would do it myself but I cannot verify that I didn't break Zero. I really should set up a build environment for Zero... > > Here it comes: > > http://cr.openjdk.java.net/~rkennke/zerojdk8/webrev.03/ > > I built both Zero and normal debug_build successfully. > > Cheers, > Roman > > From Lance.Andersen at oracle.com Fri Oct 26 21:56:13 2012 From: Lance.Andersen at oracle.com (Lance Andersen - Oracle) Date: Fri, 26 Oct 2012 17:56:13 -0400 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: <508B0313.9000403@oracle.com> References: <508AB762.1090606@oracle.com> <508AC32F.6080402@oracle.com> <508B0313.9000403@oracle.com> Message-ID: <427C9386-4744-42AC-9F9C-7A266E297752@oracle.com> On Oct 26, 2012, at 5:39 PM, Alan Bateman wrote: > On 26/10/2012 21:14, John Yeary wrote: >> Hello All, >> >> Out of curiosity what will replace it? I looked at the transitional >> notification[1], but it leaves me feeling a little uneasy about it. At one >> point, I worked on a number of "simple" applications which used MS Access >> as the database for a Java Swing front end. The only driver to connect >> these applications was the JDBC-ODBC bridge. A number of those applications >> are still around today. Is it safe to assume that the users will not >> upgrade their systems? When JDK 8 comes out, their applications will fail. >> >> I realize that I have come late to the conversation on this since the >> removal is almost completed, but I see an issue cropping up in the future. >> >> John >> > The JDBC-ODBC bridge has never been in OpenJDK, it's just the make files. > > In any case, the JDBC-ODBC bridge has been on death row for a long time. Lance can confirm but I believe that it hasn't been updated beyond JBDC 2.0 whereas JDK7 moved to JDBC 4.1. I don't think it has been usable with any of the JDBC features that were added over the last few major releases. That is correct, it has not been enhanced in close to 10 years. It has been tweaked just enough to allow it to continue to build. We do not test it, we do not fix bugs in it (and I have a long list of bugs) and it does not run on all of the platforms for which there is a JDK and is not part of the JRE. > > Another thing is that I don't think it has ever been supported. That is correct. > The oldest documentation I found is JDK 1.3 where it was recommended only for experimental use. I don't think it has really been necessary for many years anyway as so many JDBC drivers available. There are some databases, such as access, where you might be out of luck in the short term with Java SE 8 but again we have not been updating the bridge and it is sorely behind the times. If someone sees a need for this, it provides an opportunity to create a driver that they might choose to support commercially. Best Lance > > -Alan. -------------- next part -------------- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From Lance.Andersen at oracle.com Tue Oct 30 12:27:28 2012 From: Lance.Andersen at oracle.com (Lance Andersen - Oracle) Date: Tue, 30 Oct 2012 08:27:28 -0400 Subject: Build changes for 7176225: Remove JDBC-ODBC Bridge In-Reply-To: <508FC027.1080901@oracle.com> References: <508AB762.1090606@oracle.com> <508AC32F.6080402@oracle.com> <508B0313.9000403@oracle.com> <508E6F13.3050105@CoSoCo.de> <508FC027.1080901@oracle.com> Message-ID: <0EDEA951-2690-4359-B4BB-63681FD0C33D@oracle.com> On Oct 30, 2012, at 7:55 AM, Alan Bateman wrote: > On 29/10/2012 12:41, John Yeary wrote: >> Thanks Ulf, that was my exact point Ulf. Although, you were much more >> eloquent. >> >> One of the most consistent things that Java has done is ensuring backwards >> compatibility. The removal of something like the JDBC-ODBC bridge will >> cause issues later. We tell people to upgrade all the time. Security >> problems arise and we patch them followed by a message to tell folks to >> upgrade. The consumer JRE even has a reminder application which asks them >> if they want to upgrade. One click, and their applications stop working. The JDBC-ODBC Bridge was never included with the JRE, you had to install a JDK which provided it and not all JDKs do. >> >> Although I don't do anything now with MS Access, I see these nice Swing >> applications which end up with an Access database. The software that runs a >> number of Yoga studios has this configuration. It is the small businesses >> which rely on the cheaper Access based applications which will have >> problems. >> > The JDBC-ODBC bridge was a useful stop-gap 10+ years ago when there wasn't JDBC drivers available for all databases. It has never supported to my knowledge and the recommendation has always been to use a JDBC driver for the database. For those that are still using it then they have another year to find an alternative. I don't think that is too unreasonable. There will of course be a warning on the download pages that developers will see. For MS Access there are several JDBC drivers available, many of which support JDBC 4.1. There are also other alternatives such as MySQL or Derby available that might be better anyway. > > I think your point about communities or developers that have been using it and aren't reading download pages, release notes or blogs is valid concern. Any help reaching out to those communities would be appreciated. > > As regards releasing the source code then this is easier said than done. The JDBC-ODBC bridge came from a third-party originally. To be honest I don't think it's worth the cost and effort anyway as it's completely obsolete. There is a pretty big cost to continue to maintain, support, and test the JDBC-ODBC bridge properly given the amount of platforms, ODBC drivers, databases you would have to adequately test to do it properly. > If folks really see a need for this then it provides an opportunity to start up a new project to develop a modern JDBC-ODBC bridge. > > -Alan -------------- next part -------------- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From jim.gish at oracle.com Wed Oct 31 18:08:20 2012 From: jim.gish at oracle.com (Jim Gish) Date: Wed, 31 Oct 2012 14:08:20 -0400 Subject: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK In-Reply-To: <5091635A.3010000@oracle.COM> References: <5091635A.3010000@oracle.COM> Message-ID: <50916914.2050004@oracle.com> Looks good to me. Thanks, Jim On 10/31/2012 01:43 PM, Kumar Srinivasan wrote: > Hello, > > Please review changes to rev up the default -source and -target for > jdk compilation, > thus producing v52.0 class files. > > Bug is here: > https://jbs.oracle.com/bugs/browse/JDK-8001191 > > Webrev is here: > http://cr.openjdk.java.net/~ksrini/8001191/webrev.0/ > > Note: this webrev is generated against the master repository but > changes will be > pushed via tl after the tl-master sync is completed. > > Thanks > Kumar > -- Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304 Oracle Java Platform Group | Core Libraries Team 35 Network Drive Burlington, MA 01803 jim.gish at oracle.com