make dist-clean should remove javacservers directory

Erik Joelsson erik.joelsson at oracle.com
Fri Aug 16 12:32:43 UTC 2013


Hello Ivan,

Thank you for the patch. It looks good and I will be happy to sponsor it 
for you.

/Erik

On 2013-08-01 22:48, Ivan Gerasimov wrote:
> Hello!
>
> When sjavac is enabled, configure creates $OUTPUT_ROOT/javacservers 
> directory.
> However, make dist-clean doesn't remove it.
>
> Please find a simple fix below.
>
> Sincerely yours,
> Ivan
>
>
> diff --git a/common/makefiles/Main.gmk b/common/makefiles/Main.gmk
> --- a/common/makefiles/Main.gmk
> +++ b/common/makefiles/Main.gmk
> @@ -204,7 +204,7 @@
>  # If the output directory was created by configure and now becomes 
> empty, remove it as well.
>  # FIXME: tmp should not be here, fix ResetTimers instead. And remove 
> spec.sh!
>  dist-clean: clean
> -    @($(CD) $(OUTPUT_ROOT) && $(RM) -r *spec.gmk config.* 
> configure-arguments Makefile compare.sh spec.sh tmp)
> +    @($(CD) $(OUTPUT_ROOT) && $(RM) -r *spec.gmk config.* 
> configure-arguments Makefile compare.sh spec.sh tmp javacservers)
>      @$(if $(filter $(CONF_NAME),$(notdir $(OUTPUT_ROOT))), \
>      if test "x`$(LS) $(OUTPUT_ROOT)`" != x; then \
>          $(ECHO) "Warning: Not removing non-empty configuration 
> directory for '$(CONF_NAME)'" ;\
>



More information about the build-dev mailing list