RFR: 8028162 - Update Netbeans / Solaris Studio project files on Mac

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Thu Nov 14 11:24:16 UTC 2013


Hi Magnus,

Magnus Ihse Bursie skrev 14/11/13 9:51 AM:
> Hi Jesper,
>
> I assume you wanted to post this to the build-dev list -- the build-infra-dev
> was a project-based list used during active development of the new build system.

OK, thanks for forwarding.

>
> As far as I can tell, the changes looks good. (But I'm not a formal reviewer)

Thanks! Do you know which repository is the most suitable to push this change? I 
can't go through hsx/hotspot-gc ;-)

>
> Thinking long term, this file should probably be generated on the fly instead of
> updated manually like this.

It is fairly automatic since Solaris Studio generates the files, but if it could 
be done by the make files it would of course be even better.
/Jesper

>
> /Magnus
>
> On 2013-11-12 13:56, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> Could I have a couple of reviews of the updated project files for NetBeans /
>> Solaris Studio.
>>
>> This change updates the Mac part of the project files. I intend to do the same
>> change on linux as well but that will be a separate change. Then maybe someone
>> who has a Solaris box can update the Solaris part?
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028162
>>
>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8028162/webrev/
>>
>> Looking at the diff you will see that all $SRC have been replaced by 0. This
>> was done automatically by Solaris Studio. I asked in the support forum if this
>> was correct, and apparently it was :-)
>>
>> Forum: http://myforums.oracle.com/jive3/thread.jspa?threadID=1350319&tstart=0
>>
>> Thanks,
>> /Jesper
>



More information about the build-dev mailing list