7u40 on WXP/Cygwin: webrev: Is there a java or ant version of webrev?

Jonathan Gibbons jonathan.gibbons at oracle.com
Mon Nov 18 20:32:51 UTC 2013


I disagree.  Using Cywin paths like /cygdrive/z/dev is a PITA since 
they're not understood down at the Java level, meaning that any time you 
exit the Cygwin ecosystem, you have to convert to native paths.

Using mixed paths is often a viable pragmatic compromise.

-- Jon


On 11/18/2013 12:22 PM, Magnus Ihse Bursie wrote:
> You should never use dos (or mixed) style paths, like Z:/dev, in Cygwin.
>
> Since Cygwin never presents $PWD like that, I suspect the problem is that you have gotten a bad path somewhere, most likely in your hgrc.
>
> What does cat .hg/hgrc say?
>
> And - importantly - did you clone the repo using hg from Cygwin and not TortoiseHG? The latter does not work well with Cygwin, and could very well end up writing a dos/mixed style path to the hgrc, which would then cause webrev to fail.
>
> /Magnus
>
>> 5 okt 2013 kl. 15:28 skrev Francis ANDRE <francis.andre.kampbell at orange.fr>:
>>
>> Hi Builders
>>
>> I am really fighting against the triumvira (Cygwin, ksh, webrev.ksh) because of a bug in the cd command of the korn shell under cygwin -- log  below --. The cd command prepends the target directory where to go by the current $PWD.
>>
>> cd Z:/DEV/OpenJDK_7u40/hotspot/make/windows/makefiles becomes
>> cd /cygdrive/z/DEV/OpenJDK_7u40/hotspot/Z:/DEV/OpenJDK_7u40/hotspot/make/windows/makefiles
>>
>> and for sure, the translated directory does not exist.
>>
>> So, it is clear that's not a problem with webrev.ksh but I am stacked with and I have no idea when this problem will be fixed in the Cygwin tool.  Thus I am wondering if there is a java or ant version of webrev because I am not able to fix this issue in a 3000+ lines of ksh while that's not a problem in java or ant.
>>
>> Francis
>>
>> $ ksh ./make/scripts/webrev.ksh -v
>> ./make/scripts/webrev.ksh version: 23.18-hg+jbs
>>    SCM detected: mercurial
>>       Workspace: Z:/DEV/OpenJDK_7u40/hotspot
>> Compare against: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/hotspot
>>       Output to: Z:/DEV/OpenJDK_7u40/hotspot/webrev
>>    Output Files:
>> ./make/scripts/webrev.ksh[2899]: cd: /cygdrive/z/DEV/OpenJDK_7u40/hotspot/Z:/DEV/OpenJDK_7u40/hotspot/make/windows/makefiles: No such file or directory
>> abort: cannot follow file not in parent revision: "sa.make"         make/windows/makefiles/sa.make
>> ./make/scripts/webrev.ksh[2899]: cd: /cygdrive/z/DEV/OpenJDK_7u40/hotspot/Z:/DEV/OpenJDK_7u40/hotspot/make/windows/makefiles: No such file or directory
>> *** Error: file not in parent or child




More information about the build-dev mailing list