Fwd: Re: RFR(xxs): 8072935: Fix missing newline at end of file after 8067447

[Mario Torre]

2015-02-12 14:27 GMT+01:00 Volker Simonis <volker.simonis at gmail.com>:
> Hi,
>
> I don't think we should enforce a minimum Version for GCC (actually we
> would have to enforce an exact version because the master builds at
> Oracle are only tested with exactly one compiler version - see
> https://wiki.openjdk.java.net/display/Build/Supported+build+platforms).
>
> Different users have different requirements and if somebody for some
> reason has to use an older/newer version of GCC we shouldn't make that
> unnecessarily hard. But issuing a warning during the configure step
> would be fine for me.
>
> I think that compiling a project with different compilers or different
> versions of a compiler is a very good overall health check. In this
> case we detected a file without new-line at the end of files. I think
> everybody agrees this is something we do not want to have, no
> difference if it is objected by the official build tools.
>
> I'd like to propose a new test in jcheck instead which checks for this
> situation.

+1,

Cheers,
Mario


-- 
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

Java Champion - Blog: http://neugens.wordpress.com - Twitter: @neugens
Proud GNU Classpath developer: http://www.classpath.org/
OpenJDK: http://openjdk.java.net/projects/caciocavallo/

Please, support open standards:
http://endsoftpatents.org/