RFR: Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg]

Omair Majid omajid at redhat.com
Mon Oct 26 17:30:34 UTC 2015


(moving from jdk9-dev)

Hi,

I have created a webrev at:
http://cr.openjdk.java.net/~omajid/webrevs/8139932-typo-makefile-jpeg/00/

Typo in makefile changes for 8043805 [Allow using a system-installed libjpeg]
Reviewed-by: omajid, prr
Contributed-by: Matthias Klose <doko at ubuntu.com>

Regards,
Omair

* Philip Race <philip.race at oracle.com> [2015-10-19 17:22]:
> I filed https://bugs.openjdk.java.net/browse/JDK-8139932
> 
> -phil.
> 
> On 10/19/15, 12:51 PM, Matthias Klose wrote:
> >till seen with b87.  The current makefile has a typo, referencing the
> >wrong file.
> >
> >Please create a ticket and a webrev. I don't have access to these tools.
> >
> >Matthias
> >
> >libjpeg-fix.diff
> >
> >
> ># DP: Fix libjavajpeg build using the system jpeg library.
> >
> >Index: b/jdk/make/lib/Awt2dLibraries.gmk
> >===================================================================
> >--- a/jdk/make/lib/Awt2dLibraries.gmk
> >+++ b/jdk/make/lib/Awt2dLibraries.gmk
> >@@ -476,7 +476,7 @@ endif
> >  ifeq ($(USE_EXTERNAL_LIBJPEG), true)
> >    LIBJPEG_LIBS := -ljpeg
> >    BUILD_LIBJAVAJPEG_INCLUDE_FILES := \
> >-      imageIOJPEG.c \
> >+      imageioJPEG.c \
> >        jpegdecoder.c
> >    BUILD_LIBJAVAJPEG_HEADERS :=
> >  else

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681



More information about the build-dev mailing list