RFR: JDK-8151435: Windows devkit missing 32bit msvcdis120.dll
Tim Bell
tim.bell at oracle.com
Tue Mar 8 14:46:15 UTC 2016
Erik:
> The current windows devkit (VS2013SP4) is missing a 32bit version of
> the lib msvcdis120.dll. This dll is needed for the dumbin utility to
> function, which is used in the compare script.This patch modified the
> script we use to generate the devkit to add the missing file.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8151435
> Patch:
> diff -r 2436705f4a75 make/devkit/createWindowsDevkit.sh
> --- a/make/devkit/createWindowsDevkit.sh
> +++ b/make/devkit/createWindowsDevkit.sh
> @@ -74,6 +74,10 @@
> cp $DEVKIT_ROOT/VC/redist/x86/$MSVCP_DLL $DEVKIT_ROOT/VC/bin/
> cp $DEVKIT_ROOT/VC/redist/x64/$MSVCR_DLL $DEVKIT_ROOT/VC/bin/amd64/
> cp $DEVKIT_ROOT/VC/redist/x64/$MSVCP_DLL $DEVKIT_ROOT/VC/bin/amd64/
> + # The msvcdis dll is needed to run some of the tools in VC/bin
> but is not
> + # shipped in that directory. Copy it from the common dir.
> + cp
> "$VS_INSTALL_DIR/Common7/IDE/msvcdis${VS_VERSION_NUM_NODOT}.dll" \
> + $DEVKIT_ROOT/VC/bin/
> fi
>
> ################################################################################
>
Looks good to me.
Tim
More information about the build-dev
mailing list