Fix the version of required jdk

Volker Simonis volker.simonis at gmail.com
Fri Mar 11 07:35:52 UTC 2016


Hi Yuji,

your fix looks reasonable. But as the name implies,
'generated-configure.sh' is a generated file. A complete patch should
change the source files (in this case common/autoconf/help.m4) and
recreate 'generated-configure.sh' by calling
common/autoconf/autogen.sh (you should use autoconf 2.69).

You also need as sponsor from within Oracle because only they can
check in changes to 'generated-configure.sh' (because it also touches
the closed sources).

Regards,
Volker


On Fri, Mar 11, 2016 at 7:48 AM, KUBOTA Yuji <kubota.yuji at gmail.com> wrote:
> Hi everyone.
>
> configure of jdk9 (and build-infra/jdk9) requires boot jdk version is 8 or 9.
> But help message requires jdk7. Especially, yum_help requires JRE.
> So I create a small patch to fix, please someone review it?
>
> I do not have an account of openjdk, so I want a sponsor.
>
> diff --git a/common/autoconf/generated-configure.sh
> b/common/autoconf/generated-configure.sh
> --- a/common/autoconf/generated-configure.sh
> +++ b/common/autoconf/generated-configure.sh
> @@ -4053,7 +4053,7 @@
>      devkit)
>        PKGHANDLER_COMMAND="sudo apt-get install build-essential" ;;
>      openjdk)
> -      PKGHANDLER_COMMAND="sudo apt-get install openjdk-7-jdk" ;;
> +      PKGHANDLER_COMMAND="sudo apt-get install openjdk-8-jdk" ;;
>      alsa)
>        PKGHANDLER_COMMAND="sudo apt-get install libasound2-dev" ;;
>      cups)
> @@ -4076,7 +4076,7 @@
>      devkit)
>        PKGHANDLER_COMMAND="sudo yum groupinstall \"Development Tools\"" ;;
>      openjdk)
> -      PKGHANDLER_COMMAND="sudo yum install java-1.7.0-openjdk" ;;
> +      PKGHANDLER_COMMAND="sudo yum install java-1.8.0-openjdk-devel" ;;
>      alsa)
>        PKGHANDLER_COMMAND="sudo yum install alsa-lib-devel" ;;
>      cups)
>
> Thanks,
> Yuji



More information about the build-dev mailing list