RFR: 8166790: Add stress test GCBasher

Erik Joelsson erik.joelsson at oracle.com
Thu Sep 29 07:46:52 UTC 2016



On 2016-09-29 06:14, David Holmes wrote:
> Hi Erik,
>
> On 29/09/2016 1:01 AM, Erik Helin wrote:
>
>
> This seems wrong:
>
>  443 
> ${my.make.rule.test.targets.hotspot.reg.group:GROUP=hotspot_fast_gc_gcbasher}, 
>        \
>  444 
> ${my.make.rule.test.targets.hotspot.reg.group:GROUP=hotspot_fast_runtime}, 
>            \
>  445 
> ${my.make.rule.test.targets.hotspot.reg.group:GROUP=hotspot_fast_serviceability}, 
>     \
>  446 
> ${my.make.rule.test.targets.hotspot.reg.group:GROUP=jdk_svc_sanity}, 
>              \
>  447   solaris_sparcv9_5.11-product-c2-hotspot_fast_gc_gcbasher, 
>                      \
>  448   solaris_x64_5.11-product-c2-hotspot_fast_gc_gcbasher, 
>                      \
>  449   linux_i586_3.8-product-c2-hotspot_fast_gc_gcbasher, 
>                      \
>  450   linux_x64_3.8-product-c2-hotspot_fast_gc_gcbasher, 
>                      \
>  451   macosx_x64_10.9-product-c2-hotspot_fast_gc_gcbasher, 
>                      \
>  452   windows_i586_6.3-product-c2-hotspot_fast_gc_gcbasher, 
>                      \
>  453   windows_x64_6.3-product-c2-hotspot_fast_gc_gcbasher, 
>                      \
>
> You've added the new tests through a group substitution at line 443, 
> but then have added each platform individually. I don't think 447 - 
> 453 should be there else the test will run twice per platform.
>
The groups only add fastdebug. The extra lines are for product. The 
other jtreg tests only run on fastdebug while gcbasher has traditionally 
been run on both product and fastdebug. I believe Erik just wanted to 
keep it the same.

/Erik



More information about the build-dev mailing list