Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

mark.reinhold at oracle.com mark.reinhold at oracle.com
Mon Apr 3 21:39:25 UTC 2017


2017/4/3 13:35:30 -0700, simon at cjnash.com:
> On 03/04/2017 21:15, mark.reinhold at oracle.com wrote:
>> 2017/4/3 11:41:03 -0700, mandy.chung at oracle.com:
>>> Webrev:
>>>  http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/
>>> 
>>> ...
>>> 
>>> This shows the old and new value of OS_NAME/OS_ARCH properties
>>> in the `release` file:
>>> 
>>>            JDK 8               JDK 9
>>>            -----               -----
>>> OS_NAME     Linux               linux
>>>            SunOS               solaris
>>>            Darwin              osx
>>>            Windows             windows
>>>             
>>> OS_ARCH     i386,x86            x86
>>>            i586,amd64,x86_64   x64
>>>            sparcv9             sparcv9
>>>            arm                 arm32
>>>            aarch64             arm64
> 
> I am not sure why we would change to osx for Mac when the Mac developers
> have recently dropped the Mac OS X terminology and changed it to macOS.

Agreed -- we should change OS_NAME from "Darwin" to "macos".

- Mark



More information about the build-dev mailing list