Review Request JDK-8175819: OS name and arch in JMOD files should match the values as in the bundle name

Mandy Chung mandy.chung at oracle.com
Tue Apr 4 21:13:42 UTC 2017


> On Apr 4, 2017, at 12:42 AM, Alan Bateman <alan.bateman at oracle.com> wrote:
> 
> On 03/04/2017 19:41, Mandy Chung wrote:
> 
>> Webrev:
>>   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8175819/webrev.00/
>> 
> I went through the updates to jlink, assuming test SystemModulesTest will be aligned to the recent mails.
> 

It’s already aligned. I updated webrev.00 in place yesterday.  Maybe you need to reload it if you happened opening the old version.

> In DefaultImageBuilder.storeFiles then map(ResourcePoolModule::osName).orElse(null) would be cleaner.
> 

OK.

> I'm sure Volker or someone maintaining the AIX port will ask for jdk.tools.jlink.internal.Platform to be extended to handle that platform.

I was wondering if Volker would ask that. Anyway, I have added Platform::AIX constant.

Will send out a new webrev.

Mandy




More information about the build-dev mailing list