RFR: JDK-8193055 ADD_JVM_ARG_IF_OK always fails
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Tue Dec 5 10:49:20 UTC 2017
We mistakenly use -XX:-UnlockDiagnosticVMOptions instead of
-XX:+UnlockDiagnosticVMOptions in a ADD_JVM_ARG_IF_OK call. This means
that the test will always fail and the arguments will never be added to
the command line.
Since this has been the case all time along, it's probably not that
important, but it was added to keep down the logging when using a debug
build as boot jdk, which has probably not been tested that much either.
We should either fix this or remove the arguments completely.
Bug: https://bugs.openjdk.java.net/browse/JDK-8193055
Patch inline:
diff --git a/make/autoconf/boot-jdk.m4 b/make/autoconf/boot-jdk.m4
--- a/make/autoconf/boot-jdk.m4
+++ b/make/autoconf/boot-jdk.m4
@@ -354,7 +354,7 @@
AC_MSG_CHECKING([flags for boot jdk java command] )
# Disable special log output when a debug build is used as Boot JDK...
- ADD_JVM_ARG_IF_OK([-XX:-PrintVMOptions -XX:-UnlockDiagnosticVMOptions
-XX:-LogVMOutput],boot_jdk_jvmargs,[$JAVA])
+ ADD_JVM_ARG_IF_OK([-XX:-PrintVMOptions -XX:+UnlockDiagnosticVMOptions
-XX:-LogVMOutput],boot_jdk_jvmargs,[$JAVA])
# Force en-US environment
ADD_JVM_ARG_IF_OK([-Duser.language=en
-Duser.country=US],boot_jdk_jvmargs,[$JAVA])
/Magnus
More information about the build-dev
mailing list