Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

[David Holmes]

Hi Joe,

On 13/12/2017 7:27 AM, joe darcy wrote:
> Hi David,
> 
> 
> On 12/12/2017 1:11 PM, David Holmes wrote:
>> Hi Joe,
>>
>> On 12/12/2017 5:04 PM, joe darcy wrote:
>>> Hello,
>>>
>>> With the JDK 11 line of development opening up in a few days, a few 
>>> changes are needed to prepared to turn a JDK 10 code base into a JDK 
>>> 11 one including:
>>>
>>>      JDK-8173382: Add -source 11 and -target 11 to javac
>>>      JDK-8193291: Add SourceVersion.RELEASE_11
>>>
>>>      Webev:
>>>          http://cr.openjdk.java.net/~darcy/8173382.1/
>>>      CSRs:
>>>          JDK-8193350: Add -source 11 and -target 11 to javac
>>>          JDK-8193351: Add SourceVersion.RELEASE_11
>>>
>>> Please review the preliminary webrev and CSRs.
>>
>> I don't see a change to the actual JDK version as part of this ?? 
> 
> Correct; the webrev to date is the langtools portion of the new JDK 
> groundbreaking, the same subset of groundbreaking I looked at for the 9 
> -> 10 transition. Other pieces are needed too, including HotSpot changes 
> and the actual version update.

So what is the overall transition strategy here? I don't see how you can 
change javac to default to -source/-target 11 prior to bumping the 
actual version to 11. Or do you expect all the additional pieces to come 
together at the same time?

Thanks,
David

>> hat's the change that will cause hotspot to fail to build in debug 
>> mode as soon as the version is bumped - I filed:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8193364
>>
>> to at least get over that.
>>
>>> Note that breaking with previous contentions, the current iteration 
>>> of the change does *not* add -source/-target "1.11" as an alias for 
>>> "11". Only "11" is recognized.
>>>
>>> I didn't see how to add support for an "11" value for "--release" so 
>>> I problem listed two tests until that is sorted out.
>>
>> Okay. It's very hard to discern what uses of "RELEASE_11" pertain to 
>> "-release" support and what just pertain to -source/-target. ??
> 
> In this iteration, mostly -source/-target. The code that populates the 
> list of releases supported by --release has had some updates since I 
> last looked at it and I didn't figure that part out before sending out 
> this review.
> 
>>
>>> The build is simultaneously updated to user -source/-target 11, hence 
>>> the inclusion of build-dev.
>>>
>>> Various langtools tests and test infrastructure is updated too.
>>
>> test/langtools/tools/javac/versions/Versions.java looks like it needed 
>> some updates for JDK 10!
> 
> Better late than never ;-)
> 
> Thanks,
> 
> -Joe
>