Zero fails to build on SPARC again, similar to JDK-8186578

[John Paul Adrian Glaubitz]

Hi Erik!

On 04/10/2018 06:54 PM, Erik Joelsson wrote:
> I've found the problem. In JvmFeatures.gmk we have:
> 
> ifeq ($(call check-jvm-feature, zero), true)
>    JVM_CFLAGS_FEATURES += -DZERO -DCC_INTERP -DZERO_LIBARCH='"$(OPENJDK_TARGET_CPU_LEGACY_LIB)"' $(LIBFFI_CFLAGS)
>    JVM_LIBS_FEATURES += $(LIBFFI_LIBS)
>    ifeq ($(OPENJDK_TARGET_CPU), sparcv9)
>      BUILD_LIBJVM_EXTRA_FILES := $(TOPDIR)/src/hotspot/cpu/sparc/memset_with_concurrent_readers_sparc.cpp
>    endif
> endif
> 
> The BUILD_LIBJVM_EXTRA_FILES is implicitly trying to set the EXTRA_FILES argument to the BUILD_LIBJVM SetupNativeCompilation call. This used to work because there was no setting of that parameter in the actual call. In a recent change, that parameter is not set to something else, overriding the assignment above.

Aha! Do you happen to know which change was responsible for that? Then I can
adjust the bug summary accordingly.

> To fix this, you need to add $(BUILD_LIBJVM_EXTRA_FILES) to the EXTRA_FILES line in CompileJvm.gmk.

Indeed, this fixes it! Thanks so much, I was already about to give up ;).

Adrian

-- 
  .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913