RFR: JDK-8200358 Remove mapfiles for JDK executables

Thomas Stüfe thomas.stuefe at gmail.com
Wed Mar 28 14:56:42 UTC 2018


On Wed, Mar 28, 2018 at 2:19 PM, Martin Buchholz <martinrb at google.com>
wrote:

> I'm not sure about this.
>
> IIRC the AIX linker is able to use executables as a build-time input.
> Maybe our AIX maintainers have some expertise here.
>
>
I am quite sure we do not do that in the VM. I'm running a test build with
your patch.

Thanks, Thomas


> I think the _dynamic_ linker will see symbols in the executable.  Resolving
> them is likely to be strictly more work at startup, and it is likely that
> the symbols are visible to dlsym(NULL ...)
>
> We have local patches at Google that involve adding symbols to these
> mapfiles to increase visibility to dlsym.  Maintaining mapfiles is no fun,
> but the precise definition of symbol visibility seems in the Spirit of
> Java.
>
> On Wed, Mar 28, 2018 at 4:08 AM, Magnus Ihse Bursie <
> magnus.ihse.bursie at oracle.com> wrote:
>
> > This patch removes mapfiles for the JDK executables (launchers). There's
> > really no reason to have mapfiles in the first place for executables.
> Since
> > no-one is linking to them, what symbols they export is immaterial.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8200358
> > WebRev: http://cr.openjdk.java.net/~ihse/JDK-8200358-remove-launcher
> > -mapfiles/webrev.01
> >
> > /Magnus
> >
> >
>



More information about the build-dev mailing list