Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

[Andrew Leonard]

Thanks Magnus,
no hurry, next week will be fine.
Cheers
Andrew

Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leonard at uk.ibm.com 




From:   Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com>
To:     Andrew Leonard <andrew_m_leonard at uk.ibm.com>
Cc:     David Holmes <david.holmes at oracle.com>, build-dev at openjdk.java.net
Date:   31/01/2019 20:10
Subject:        Re: Proposal: JDK-8217896: Make better use of LCPUs when 
building on AIX




31 jan. 2019 kl. 16:01 skrev Andrew Leonard <andrew_m_leonard at uk.ibm.com>:

Hiya, 
I've created and tested a new webrev using lparstat and following your 
guidelines, webrev.01 is here: 
    http://cr.openjdk.java.net/~aleonard/8217896/webrev.01/ 
If someone is happy to sponsor and review please? 

This looks good to me. I can sponsor, but won't have time to push it until 
tomorrow or after the weekend, so if anyone else wants to step in feel 
free to do so. :)

/Magnus

Many thanks 
Andrew 

Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
Phone internal: 245913, external: 01962 815913
internet email: andrew_m_leonard at uk.ibm.com 




From:        Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> 
To:        Andrew Leonard <andrew_m_leonard at uk.ibm.com>, David Holmes <
david.holmes at oracle.com> 
Cc:        build-dev at openjdk.java.net 
Date:        30/01/2019 17:16 
Subject:        Re: Proposal: JDK-8217896: Make better use of LCPUs when 
building on AIX 





On 2019-01-30 17:37, Andrew Leonard wrote:
> Thanks David,
> I just found the reference you mention, it is a little vague, but says
> maybe as you said. I've reworked and tested the following which seems
> better:
>    NUM_CORES=`lparstat -m | grep -o "lcpu=[[0-9]]*" | cut -d "=" -f 2`
> I'll create a new webrev with this.
Note that you should use $GREP and $CUT; in theory we should also check 
for lparstat, but we've been sloppy with that for the other cpu checking 
methods so maybe we can be that for AIX here as well.

/Magnus
> Thanks
> Andrew
>
> Andrew Leonard
> Java Runtimes Development
> IBM Hursley
> IBM United Kingdom Ltd
> Phone internal: 245913, external: 01962 815913
> internet email: andrew_m_leonard at uk.ibm.com
>
>
>
>
> From:   David Holmes <david.holmes at oracle.com>
> To:     Erik Joelsson <erik.joelsson at oracle.com>, Andrew Leonard
> <andrew_m_leonard at uk.ibm.com>, build-dev at openjdk.java.net
> Date:   30/01/2019 02:25
> Subject:        Re: Proposal: JDK-8217896: Make better use of LCPUs when
> building on AIX
>
>
>
> On 30/01/2019 3:05 am, Erik Joelsson wrote:
>> Hello,
>>
>> I'm OK with this, but since I can't verify it at all, I would be more
>> comfortable if one of the other AIX users would review this as well.
> Ditto. I did some googling on this and pmcycles is flagged as maybe
> being deprecated in the future and may require privileges to execute.
> lparstat -i seems to be more commonly used.
>
> David
> -----
>
>> /Erik
>>
>> On 2019-01-29 05:08, Andrew Leonard wrote:
>>> Hi,
>>> Please can I get a sponsor for this build performance enhancement on
> AIX,
>>> by better determining the number of LCPUs on smt AIX machines:
>>> 
> https://cr.openjdk.java.net/~aleonard/8217896/webrev.00/
>
>>> My testing shows up to 30% improved build times when leveraging the
>>> available LCPUs.
>>> Many thanks
>>> Andrew
>>>
>>> Andrew Leonard
>>> Java Runtimes Development
>>> IBM Hursley
>>> IBM United Kingdom Ltd
>>> Phone internal: 245913, external: 01962 815913
>>> internet email: andrew_m_leonard at uk.ibm.com
>>>
>>>
>>> Unless stated otherwise above:
>>> IBM United Kingdom Limited - Registered in England and Wales with
> number
>>> 741598.
>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
>>> 3AU
>
>
>
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 
3AU





Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU



Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU