RFR: JDK-8218186 Clean up CLDR generation in build

Naoto Sato naoto.sato at oracle.com
Tue Feb 5 15:32:53 UTC 2019


Thanks, Magnus. The change looks good to me too.

Naoto

On 2/5/19 1:57 AM, Magnus Ihse Bursie wrote:
> On 2019-02-01 14:43, naoto.sato at oracle.com wrote:
>> Hi Magnus,
>>
>> I am assuming that the generated resource bundles are exactly the same 
>> as before this fix, correct?
> 
> Yes. I have verified this using the COMPARE_BUILD functionality.
> 
> /Magnus
>>
>> Naoto
>>
>> On 2/1/19 2:50 AM, Magnus Ihse Bursie wrote:
>>> The CLDR data is, since Jigsaw, used in two different modules -- 
>>> java.base and jdk.localedata. Unfortunately, the split between these 
>>> two modules were not fully finished as part of the Jigsaw project.
>>>
>>> This patch aims to resolving most of this. The CLDRConverter build 
>>> tool is now called from Gensrc-java.base and Gensrc-jdk.localedata, 
>>> for their respective module. The calls have been updated to match 
>>> modern build-infra standards.
>>>
>>> Also, the raw CLDR data was located mixed in with the Java source, in 
>>> jdk.localedata. This patch also moves the data to make/data/cldr, to 
>>> align with input data to all other build tools.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8218186
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8218186-cleanup-CLDR/webrev.01
>>>
>>> /Magnus
> 


More information about the build-dev mailing list