RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

Erik Joelsson erik.joelsson at oracle.com
Thu Feb 7 17:39:09 UTC 2019


Hello Severin,

There is a macro for automatically finding all source dirs for a module. 
So in Gensrc-jdk.jlink.gmk, I think it would be better expressed using 
that macro, like this:

JLINK_RESOURCE_DIRS := $(wildcard $(addsuffix 
/jdk/tools/jlink/resources, $(call FindModuleSrcSdirs, jdk.jlink)))

The above could/should even be inlined.

Otherwise build changes look ok.

/Erik

On 2019-02-07 09:09, Severin Gehwolf wrote:
> Hi,
>
> Could I please get reviews for this enhancement? It adds a debug
> symbols stripping plug-in to jlink for Linux and Unix platforms. It's
> the first platform specific jlink plugin and the approach taken for
> keeping it contained is to use a plugin specific ResourceBundle.
> Discussion for this happened in [1].
>
> The test uses a native library which should never get debug symbols
> stripped during the test library build. As such, tiny modifications
> were needed to make/common/TestFilesCompilation.gmk. Hence, build-dev
> being on the list for this RFR. The test currently only runs on Linux
> and requires objcopy to be available. Otherwise the test is being
> skipped.
>
> Example usage of this plugin is described in the bug.
>
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8214796/04/webrev/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214796
>
> Testing: test/jdk/tools/jlink test/jdk/jdk/modules tests on Linux
> x86_64 (with good and broken objcopy) and the newly added test. It's
> currently running through jdk/submit too.
>
> Thoughts?
>
> Thanks,
> Severin
>
> [1] http://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-January/014109.html
>


More information about the build-dev mailing list