RFR(T) : 8219132 : switch to jtreg4.2-b14

Igor Ignatyev igor.ignatyev at oracle.com
Wed Feb 20 01:54:08 UTC 2019


Joe,

allowSmartActionArgs is opt-in if requiredVersion < b14, and opt-out if requiredVersion >= b14, please see http://hg.openjdk.java.net/code-tools/jtreg/rev/36c592d2f544 <http://hg.openjdk.java.net/code-tools/jtreg/rev/36c592d2f544> . so you don't have to have allowSmartActionArgs=true in 8219254.

Thanks,
-- Igor

> On Feb 19, 2019, at 5:49 PM, Joseph D. Darcy <joe.darcy at oracle.com> wrote:
> 
> Hello,
> 
> On 2/19/2019 5:06 PM, Igor Ignatyev wrote:
>> Hi Erik,
>> 
>> thanks for your review.
>> 
>> we can't just bump the required version as it can introduce changes in tests' behavior. requiredVersion >= 4.2 b14 will enable allowSmartActionArgs[1],
> 
> From what I understand from Jon, allowSmartActionArgs is opt-in and has to be enabled in the TEST.ROOT file with
> 
>    allowSmartActionArgs=true
> 
> Therefore, IIRC, the required version could be bumped without enabling smart action args.
> 
> (I have a patch in progress to use smart action args for langtools tests: https://mail.openjdk.java.net/pipermail/compiler-dev/2019-February/012959.html)
> 
> HTH,
> 
> -Joe
> 
>>  this will affect all the tests which have ${<X>} in their @run directives, for example it will affect many vmTestbase tests which use PropertyResolvingWrapper. therefore, I suggest we bump requiredVersion after we clean up such tests and have filed 8219140[2] to deal w/ vmTestbase tests. I'll check if there are other tests which will be affected and will file RFE(s) to cover them as well.
>> 
>> [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7902352 <https://bugs.openjdk.java.net/browse/CODETOOLS-7902352>
>> [2] https://bugs.openjdk.java.net/browse/JDK-8219140 <https://bugs.openjdk.java.net/browse/JDK-8219140>
>> 
>> Thanks,
>> -- Igor
>> 
>>> On Feb 19, 2019, at 5:01 PM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>>> 
>>> Looks good.
>>> 
>>> Do we need to also bump the required version in the TEST.ROOT files?
>>> 
>>> /Erik
>>> 
>>> On 2019-02-19 16:34, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html
>>>>> 1 line changed: 0 ins; 0 del; 1 mod;
>>>> Hi all,
>>>> 
>>>> could you please review this one-liner which switch jtreg version to jtreg4.2-b14?
>>>> 
>>>> webrev: http://cr.openjdk.java.net/~iignatyev//8219132/webrev.00/index.html
>>>> JBS:  https://bugs.openjdk.java.net/browse/JDK-8219132
>>>> testing: tier[1-5], client tests and jcstress test group testing showed no new failures; spot checking of .jtr files also didn't find any anomalies
>>>> 
>>>> Thanks,
>>>> -- Igor
> 



More information about the build-dev mailing list